nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30179 commits 1 branch 0 tags 363 MiB
Commit graph

4454 commits

Author SHA1 Message Date
Tadashi G. Takaoka
21177c1afe Remove gesture typing settings when disabled by configuration 
Bug: 7506408
Change-Id: I4de53ace170d5ddc9779f42ac344c4190c80a019
 2012-11-09 07:58:27 -08:00
Jean Chalard
01d47b8096 Fix a logic flaw. 
This test is seriously wrong : although we do have a method that
does exactly the right thing, this looks at a very specific, unrelated
variable state in hope it happens to be set only in the relevant
cases by the play of logic.
I don't think this changes anything concretely, as the assumption
was probably true in the practice ; still, this code is very hard to
read and prone to unexpected breakage.

Change-Id: I77ab576f90762429fcc752df31ed30e1c81871dc
 2012-11-09 19:16:37 +09:00
Ken Wakasa
710d06cea9 Suppress dictionary pack support when IS_EXPERIMENTAL is true 
Change-Id: If8813cb989c1fa8744a3bf36e8514ced3c8f46a3
 2012-11-09 15:03:31 +09:00
Tadashi G. Takaoka
c43ff6f66c Remove gesture typing settings when disabled by configuration 
Bug: 7506408
Change-Id: I4de53ace170d5ddc9779f42ac344c4190c80a019
 2012-11-09 12:44:40 +09:00
Ken Wakasa
43f579e9f6 am 4eef5101: am aa5d6fe0: am 9cc22c45: am 5d2556b9: Reset the IME if requested by the app. 
* commit '4eef51016adc4e103fa65d944a0ab31527ddced8':
  Reset the IME if requested by the app.
 2012-11-08 06:22:02 -08:00
Ken Wakasa
5d2556b932 Reset the IME if requested by the app. 
Specifically, reset the KeyboardState to the main Alphabet layout in
LatinIME.onStartInputViewInternal() if a keyboard layout set doesn't get
reloaded in the method.

Please note TextView.setText() calls up resetInput(), then the IME should
reset with it.

bug: 7482086

Note that bug: 6851364 needs to be revisited.

Change-Id: I5d448c10963d3dd952dd13cb587085ec7b014e69
 2012-11-07 01:09:26 +09:00
Tadashi G. Takaoka
ffb0c093d1 Merge "Move isInvalidCordinates() method to Constants class" 2012-10-31 21:24:01 -07:00
Tadashi G. Takaoka
24ab8055aa Move isInvalidCordinates() method to Constants class 
Change-Id: Iad1464c299ad6055af1db1ff7978e5cd9a14750f
 2012-11-01 13:12:58 +09:00
Tadashi G. Takaoka
20dd1bc090 Cosmetic source code formating change 
Change-Id: I3a53b49afab70dfb13f12027070635da6001eb79
 2012-11-01 13:10:44 +09:00
Ken Wakasa
1e61493c50 Use 32-bit code points for suggestions output 
This is a multi-project commit with Ic43dd666

bug: 6526418
Change-Id: I39c1acb4e91d04cd8a4ec5a943c8cf575da75ebc
 2012-11-01 00:09:51 +09:00
Jean Chalard
51a0ef8c59 Add a plumbing option to dicttool info. 
Also align the `porcelain' option to the diff command
that was used mistakenly.

Bug: 7388665
Change-Id: Ic0e1b98c62ce37b2e909384a0370af4458563703
 2012-10-31 16:35:22 +09:00
Tadashi G. Takaoka
c7318bbc0b Fix possible NPE 
Bug: 7398904
Change-Id: I6b7aba7a9bf52ca494cb4390b19525c98790bd49
 2012-10-29 18:40:37 +09:00
Tadashi G. Takaoka
cfbfb1c50a Remove reference of android.util.Log in Constants class 
This is a follow up of Iee01d4d2.

Change-Id: I0bcd349d317d9f7d40ef0574e72c640f9f990c5d
 2012-10-29 17:25:13 +09:00
Tadashi G. Takaoka
7947eaf475 Merge "Move code point constants from Keyboard to Constants class" 2012-10-29 00:10:52 -07:00
Tadashi G. Takaoka
240871ecaf Move code point constants from Keyboard to Constants class 
Change-Id: Iee01d4d2b916d0b584531104ac865ae6e6370a3d
 2012-10-29 16:04:20 +09:00
Jean Chalard
f41389a74b Remove warnings 
Thanks Eclipse

Change-Id: I88e3979ed22be5d8be5a5accdde417c6b1a8bf2d
 2012-10-29 14:24:16 +09:00
Jean Chalard
a23e333079 Implement the word-level diff (A9) 
Bug: 7388857
Change-Id: I4c4560d4f4b579936a44cdf409a4c27300b65610
 2012-10-29 12:31:22 +09:00
Satoshi Kataoka
6067b9e1bd am ef5f88f3: am 5e118c4c: am 60dea36d: Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
* commit 'ef5f88f33e432284c958fafe18f891a10f77e1f9':
  Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
 2012-10-25 19:31:27 -07:00
Satoshi Kataoka
60dea36daf Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
Bug: 7393485
Bug: 7272829
Change-Id: I873e8d99486c734e76484526631a90fc55e91c86
 2012-10-25 20:00:46 +09:00
Jean Chalard
47cac57e45 Finish up the "info" command in dicttool. (A6) 
Bug: 7388857
Change-Id: I704f12a6be76ce1644ec5e8dd3b667f112e9c04a
 2012-10-25 19:15:24 +09:00
Jean Chalard
b3c98901c5 Add auto detection and decoding of dictionary files. (A2) 
Bug: 7388852
Change-Id: I25e755fc15f5b383acc046f668e9681efa4f0c2f
 2012-10-25 16:40:15 +09:00
Jean Chalard
ddb0bcc051 Fix a bug where a bigram would be ignored 
Bug: 7403386
Change-Id: I89f495d07f7059a9f1ccd97d487c2f2657a8ebd2
 2012-10-24 13:24:59 +09:00
Jean Chalard
5e5be5a2d2 Merge "Return the correct bigram frequency" 2012-10-23 01:19:28 -07:00
Jean Chalard
c59c741987 Return the correct bigram frequency 
The "correct" bigram frequency is now returned by the reading
code. However, as the binary format represents the frequency
in a lossy manner, the frequency is not guaranteed to be the
exact same as the one in the source text format - only a close
enough value. It is however the exact same value seen by the
native code.

Bug: 7395653
Change-Id: I49199ef18901c671189912b3550623e9643baedd
 2012-10-23 17:17:37 +09:00
Jean Chalard
1e0cc86b6f Fix the build. 
It seems this change snuck out from a previous version.

Change-Id: I9c33d51273732b1d55bfd60f0957184c86fa88ab
 2012-10-23 15:34:42 +09:00
Jean Chalard
c7020f54f9 Merge "Add reader and writer for the combined dict format." 2012-10-22 23:11:20 -07:00
Jean Chalard
9bb4eebf48 Add reader and writer for the combined dict format. 
This introduces a new textual format for the dictionary that combines
words, bigrams and shortcuts to avoid complexity. It is also extensible
to n-grams to fool-prof for the future, and easier to read than XML.

Bug: 7388540
Change-Id: I942bbad51bd0c905a5a54c278667563fd6dd66ec
 2012-10-23 15:06:25 +09:00
Jean Chalard
751f3dc0e1 am 6fe6f38d: am d39e6435: am f960eb18: Don\'t put spaces after characters that don\'t take one 
* commit '6fe6f38d8af09b24e40a6e01eae919820cd04c16':
  Don't put spaces after characters that don't take one
 2012-10-22 21:46:43 -07:00
Jean Chalard
f960eb186d Don't put spaces after characters that don't take one 
Bug: 7393639
Change-Id: I1245a7b5077e554642838d6856ce269ca7f91988
 2012-10-23 12:28:28 +09:00
Tadashi G. Takaoka
7f77aed507 Merge "Replace useless CharSequence to String" 2012-10-22 14:27:35 -07:00
Tadashi G. Takaoka
15f6d4ae34 Add @UsedForTesting and @ExternallyReferenced annotations 
Bug: 7268357
Change-Id: I0b7e0c19f04af9ae30874d0a4c26ad81bc80be8c
 2012-10-22 11:18:43 -07:00
Tadashi G. Takaoka
bc464e2952 Replace useless CharSequence to String 
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
 2012-10-22 11:03:28 -07:00
Tadashi G. Takaoka
5faf419519 Suggestion strip will honor haptic feedback settings of keyboard 
Bug: 7313372
Change-Id: I427da8de68be3d2a78e810556340b96ab4edcc2d
 2012-10-17 21:40:02 -07:00
Tadashi G. Takaoka
8e360c68f1 Move AudioAndHapticFeedbackManager from LatinIME to KeyboardSwitcher 
Bug: 7313372
Change-Id: I9bd3275f57ed3f5c2c4a95768443af505513ee97
 2012-10-17 19:39:16 -07:00
Jean Chalard
c5dc32ac59 am b37e87e7: am 63b3fc0d: am 15142588: Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 
* commit 'b37e87e7d50725f20a6b2f8484fc25cc7db3134f':
  Have "no whitespace before cursor" upon gesture trigger phantom space
 2012-10-16 18:12:50 -07:00
Jean Chalard
1514258824 Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 2012-10-16 18:06:11 -07:00
Jean Chalard
e91d495c53 Have "no whitespace before cursor" upon gesture trigger phantom space 
Bug: 7359291
Bug: 7357758
Bug: 7197651
Change-Id: Ia805a87e922739ae0a06978a3bf00d91c94b6c51
 2012-10-17 09:36:07 +09:00
Tadashi G. Takaoka
788c885aa5 am 344a7fef: am 658e935b: am c0bc3369: Merge "Fix more suggestions text width calculation" into jb-mr1-dev 
* commit '344a7fef5bd101e2d1c4278cc35de2862f28a456':
  Fix more suggestions text width calculation
 2012-10-16 17:32:00 -07:00
Jean Chalard
fa3d984d1b am 60211f0d: am 2631fe4c: am 6686e63f: Honor automatic shift turned off for gestures 
* commit '60211f0d250ca931788d32d5a69c880f75ef7d49':
  Honor automatic shift turned off for gestures
 2012-10-16 17:28:18 -07:00
Tadashi G. Takaoka
c0bc336955 Merge "Fix more suggestions text width calculation" into jb-mr1-dev 2012-10-16 17:24:35 -07:00
Tadashi G. Takaoka
bdc8b9e42b Fix more suggestions text width calculation 
Bug: 7345983
Change-Id: Ic1554db98e7aaf032eb90a98c0c37c7c789461b5
 2012-10-16 14:24:30 -07:00
Jean Chalard
6686e63f21 Honor automatic shift turned off for gestures 
Bug: 7354129
Change-Id: Ia02336e8cea2f04b629edbe74b7815cce0d7fad6
 2012-10-17 05:41:06 +09:00
Jean Chalard
01e0913ad2 Make a better choice for the temporary file 
Change-Id: I745bb285b6b52875c8d2b3a94deb962352f9754e
 2012-10-12 19:58:07 +09:00
Ken Wakasa
b0aa9606ae am 726e98b7: am c1a1937c: am 2220aeed: Merge "Put temporary files under a separate directory." into jb-mr1-dev 
* commit '726e98b7378987b2cfe46ea5395692640b108e83':
  Put temporary files under a separate directory.
 2012-10-11 08:41:42 -07:00
Jean Chalard
66c90cd2ae Put temporary files under a separate directory. 
Bug: 7328003
Change-Id: Ibe5278ea209d149f87fd08785c77b17e3859948e
 2012-10-11 17:53:06 +09:00
Ken Wakasa
06636bf96a am 0081681e: am c44314b4: am dc38a343: Merge "Use a freq of 1 instead of 0 for non-word shortcuts." into jb-mr1-dev 
* commit '0081681e346ce5c958e5eef264caa3f257b094c5':
  Use a freq of 1 instead of 0 for non-word shortcuts.
 2012-10-09 07:48:46 -07:00
Jean Chalard
99b84b42f9 Use a freq of 1 instead of 0 for non-word shortcuts. 
Also fix a spelling mistake in a comment

Bug: 7301525
Change-Id: I4437403dce620fed03871485ee04f13c51ce34fc
 2012-10-09 19:16:07 +09:00
Ken Wakasa
b02ee3d67a Make use of the NELEMS and KEYCODE_SPACE macro. Also, remove an unused parameter. 
Change-Id: I3c7e6c59990c92b0d5e2fb80493e8673cdd37b09
 2012-10-09 11:17:50 +09:00
Ken Wakasa
fc62882591 Fix a small typo 
Change-Id: I813d97b9453f8aa7aae99bd165336b1e5a81dc6a
 2012-10-07 12:05:23 +09:00
Tadashi G. Takaoka
792980d4aa Avoid calling switchToLastInputMethod when other IMEs are in effect (DO NOT MERGE) 
Bug: 7299050
Change-Id: Ife6721a5fcbc4872bd36ffd8a8b81b04d73aebec
 2012-10-06 19:01:36 +09:00
Yuichiro Hanada
d2579c4832 fix writeCharGroup. 
Change-Id: Ib841afaba0a20c3b300eb7d3e9133243f9f3ae58
 2012-10-05 14:54:17 +09:00
Ken Wakasa
feac8a91f9 am 933e7c37: am 37c8f8b5: am 20f07e33: Merge "Unlink an old file before moving the new file over it" into jb-mr1-dev 
* commit '933e7c3770c00a9eea43c447d96daec1ada62041':
  Unlink an old file before moving the new file over it
 2012-10-04 15:40:20 -07:00
Ken Wakasa
20f07e335d Merge "Unlink an old file before moving the new file over it" into jb-mr1-dev 2012-10-04 15:33:41 -07:00
Jean Chalard
daff19bc29 am d173ed18: am bf6c8bd8: am 3f7fe829: Merge "Always consider a new line the start of a sentence" into jb-mr1-dev 
* commit 'd173ed18e44ea5cdc48d5f620bb91efcd3ed5174':
  Always consider a new line the start of a sentence
 2012-10-04 06:00:45 -07:00
Jean Chalard
2699b45dbc Always consider a new line the start of a sentence 
Bug: 7282523
Change-Id: I10a73e99efdfe6acb9a16819694b98c6714fd451
 2012-10-04 20:54:28 +09:00
Yuichiro Hanada
3c6d9fe148 Add insertWord. 
bug: 6669677

Change-Id: Ide55a4931071de9cd42c1cddae63ddd531d2feba
 2012-10-04 17:19:47 +09:00
Jean Chalard
c15726482e Unlink an old file before moving the new file over it 
This is unlikely to be relevant to this bug, but just in case.

Bug: 7274972
Change-Id: I56b31b377af16cc2c15ceb90a19792bed3aab367
 2012-10-04 15:49:08 +09:00
Yuichiro Hanada
c3a98ca306 Add writeNode. 
Change-Id: I088bb6ea43ce0841d725e48b677d429e1155569d
 2012-10-04 14:28:42 +09:00
Yuichiro Hanada
38712ff27d Add updateParentAddresses. 
Change-Id: Iac210131b7c003ef363e1138bf22f777a37c6a89
 2012-10-03 19:37:17 +09:00
Yuichiro Hanada
a853356b82 Add isDeletedGroup. 
Change-Id: I83f09c068868e5e6e1b46f494a6ef957f0b466d8
 2012-10-03 02:19:41 -07:00
Yuichiro Hanada
7223cc2ef1 Add MAX_BIGRAMS_IN_A_GROUP. 
Change-Id: I128d5deb8e523045d7ad77d7a8fd3db944f71238
 2012-10-03 18:10:06 +09:00
Satoshi Kataoka
69c787f3b7 am 96717371: am e8825ce3: am 1fd10ea2: Merge "Throw illegal argument exception in BinaryDictionary::editDistance" into jb-mr1-dev 
* commit '967173711f17ba30d3608881f501985f07fef4fd':
  Throw illegal argument exception in BinaryDictionary::editDistance
 2012-10-03 01:21:43 -07:00
Satoshi Kataoka
1fd10ea22c Merge "Throw illegal argument exception in BinaryDictionary::editDistance" into jb-mr1-dev 2012-10-03 01:15:52 -07:00
Satoshi Kataoka
66d955ad71 Throw illegal argument exception in BinaryDictionary::editDistance 
Bug: 7276803
Change-Id: Icd9bdec0a04179a29d00336819d205627f77b71a
 2012-10-03 17:15:47 +09:00
Tadashi G. Takaoka
c6ff7c42d9 Add SuggestedWords.isEmpty() method 
Change-Id: I0fcb104a6a81aee4b99f5ee848eba7495630dc7d
 2012-10-03 15:09:10 +09:00
Tadashi G. Takaoka
3e5a3c18be Add final modifier to the classes under suggestions sub-package 
Change-Id: I19fc8eaac1aebef9cf4deb004e78484ff9a1e7ca
 2012-10-03 14:57:29 +09:00
Tadashi G. Takaoka
5f5f7825e7 am 4d009dbc: am ace7d128: am d445b56c: Fix possible NPE caused while monkey test 
* commit '4d009dbc514cd77eb22e4162e4ae7ea852e1b77e':
  Fix possible NPE caused while monkey test
 2012-10-02 22:44:57 -07:00
Yuichiro Hanada
4ad4ff618f Add makeCharGroupFlags. 
Change-Id: Id2c580f21b77f66a97c5fbdf4542fdafe6c43614
 2012-10-03 14:33:59 +09:00
Tadashi G. Takaoka
d445b56ce1 Fix possible NPE caused while monkey test 
Bug: 7269036
Change-Id: I9054b33ad3c8996cac3ee5f0e9c01ba8ceea4971
 2012-10-03 14:33:52 +09:00
Tadashi G. Takaoka
c3aea8ea9f Merge "Avoid calling switchToLastInputMethod when other IMEs are in effect" 2012-10-02 01:36:37 -07:00
Tadashi G. Takaoka
aec5cc8476 Avoid calling switchToLastInputMethod when other IMEs are in effect 
Bug: 7268389
Change-Id: I4d960cbf063002b4dc0ea813c966366b56c0346d
 2012-10-02 17:29:15 +09:00
Tadashi G. Takaoka
fe3fb2502d am 58e1be74: am de102ede: am 15281adb: Show gesture floating preview text by default 
* commit '58e1be74a989637b0b71ebf990ed1b3c9a21e7af':
  Show gesture floating preview text by default
 2012-10-01 23:41:38 -07:00
Tadashi G. Takaoka
15281adbc1 Show gesture floating preview text by default 
Bug: 7244214
Change-Id: Ib4ab810ef50798828dd10c39a8077466165772e4
 2012-10-01 21:23:00 -07:00
Jean Chalard
37688ae8c1 am 86db54df: am 137203d4: am 574b80aa: Remove debug prints. 
* commit '86db54df74b821a15f7a3081c3737f8a63f91214':
  Remove debug prints.
 2012-10-01 13:46:16 -07:00
Yuichiro Hanada
7f438aa12f Make writeCharGroup return a size of a new group. 
bug: 6669677

Change-Id: I56f6a07b04b08443f2c052927404318c2018fc9d
 2012-10-01 22:02:04 +09:00
Ken Wakasa
00e1d421c2 Merge "Add writeCharGroup." 2012-10-01 05:53:24 -07:00
Yuichiro Hanada
fb7e08ea8f Add writeCharGroup. 
bug: 6669677

Change-Id: I36792ba9c511a5148c963096cc93ca8c2e0ee04e
 2012-10-01 21:50:38 +09:00
Jean Chalard
574b80aace Remove debug prints. 
Bug: 7226098
Change-Id: Ibacb740022a6af56c9d555d6797dd402a89f6ca4
 2012-10-01 17:03:15 +09:00
Tadashi G. Takaoka
7339a62a13 Fix NPE observed only by monkey test 
Bug: 7258660
Change-Id: I286c704b32efeada8505d953438f2595166f7e8f
 2012-10-01 14:55:18 +09:00
Tadashi G. Takaoka
99501896f5 am 9925e487: am 6052a81e: Merge "Fix gesture detection algorithm" into jb-mr1-dev 
* commit '9925e487b345e4a63d3dc25e3bf156e0fbfbb04d':
  Fix gesture detection algorithm
 2012-09-28 06:54:04 -07:00
Tadashi G. Takaoka
58fe5a421f Fix gesture detection algorithm 
This change also
  * Introduces adaptive gesture detecting threshold for time domain in addition to length domain.
  * Tunes the parameters for detecting gesture after fast typing.
  * Fixes a bug in dismissing gesture floating preview text.
  * Cleanup debug messages

Bug: 7218902
Change-Id: Iafccd872c6efe0c3b5ae65fa40b04c80d9f139c7
 2012-09-28 22:47:55 +09:00
Yuichiro Hanada
f3aed3ea26 Add updateChildrenAddress. 
Change-Id: Ic06a755d85612476e719e580469dc1cd9447286c
 2012-09-28 18:45:56 +09:00
Yuichiro Hanada
7a7d117aa7 Ignore the broken file. 
bug: 7249561

Change-Id: If001bf75ef12b4d342a77e54706c7fed90c89afb
 2012-09-28 14:19:14 +09:00
Tadashi G. Takaoka
a28a05e971 Cleanup: Make some classes as final 
Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
 2012-09-27 19:03:30 +09:00
Yuichiro Hanada
84d858ed5e Use BinaryDictInputOutput to save UserHistoryDictionary. 
bug: 6669677

Change-Id: I08193c26f76dbd48168f8ac02c1b737525bfc7b2
 2012-09-27 12:02:17 +09:00
Yuichiro Hanada
2aea34fb31 Add updateParentAddress. 
bug: 6669677

Change-Id: I353f8ae53720cdf7a809271a28cb703709609f53
 2012-09-26 17:18:01 +09:00
Yuichiro Hanada
2ee70804e9 Add moved char groups. 
bug: 6669677

Change-Id: I372f841044fe8e076a50a80ac10b715e5f8fd4eb
 2012-09-26 17:01:48 +09:00
Yuichiro Hanada
a161bdac88 add capacity to FusionDictionaryBufferInterface. 
bug: 6669677

Change-Id: I4627093811a19c46ce13fe351d1db63cbd78cf4a
 2012-09-25 21:47:11 +09:00
Yuichiro Hanada
93d7c6233f Make getTerminalPosition read linked-list nodes. 
bug: 6669677

Change-Id: I599d276f430efe23d402695c325e23906b7705b3
 2012-09-25 21:11:15 +09:00
Yuichiro Hanada
8ec0064c49 Make children addresses and parent addresses use signed addresses. 
Signed addresses are used only in version 3 with dynamic update.

bug: 6669677

Change-Id: Iadaeab199b5019d2330b4573c24da74d64f0945e
 2012-09-25 12:55:14 +09:00
Jean Chalard
0eef4b1e6f Merge "Add suggestion span upon starting a gesture." into jb-mr1-dev 2012-09-24 04:30:32 -07:00
Jean Chalard
6a58bb7ac9 Add suggestion span upon starting a gesture. 
Bug: 7196761
Change-Id: If60cb809b205159ced1887f94b7caf9775fcf3bb
 2012-09-24 20:25:46 +09:00
Jean Chalard
88985bfa2e Merge "Fix a bug where the cursor pos wouldn't be tracked correctly" into jb-mr1-dev 2012-09-24 03:41:48 -07:00
Jean Chalard
72c5d32888 Fix a bug where the cursor pos wouldn't be tracked correctly 
This would cause
Bug: 7208199

Change-Id: I8474985bfe349e1530b27bc98842937627bbe4e0
 2012-09-24 19:33:42 +09:00
Jean Chalard
6efe788494 Set punctuation suggestions at start if activated 
Bug: 7218468
Change-Id: I9f8c1f13dc26cedb95b65279a34a825021dfa72a
 2012-09-24 17:27:03 +09:00
Jean Chalard
65ef26081b Merge "Fix a race condition with shift" into jb-mr1-dev 2012-09-23 23:48:20 -07:00
Jean Chalard
fff8613df0 Fix a race condition with shift 
Bug: 7062092
Change-Id: Ie1984673e9ffc9291d9650ec38ce99031ad93585
 2012-09-24 15:07:52 +09:00
Yuichiro Hanada
82d9deaaf2 Combine mHasParentAddress with mHasLinkedListNode into mSupportsDynamicUpdate. 
bug: 6669677

Change-Id: I82799af199358420f09ac34fc005091e202c5d3b
 2012-09-24 13:17:44 +09:00
Tadashi G. Takaoka
3088e0c9e9 Merge "Fix gesture start detection algorithm" into jb-mr1-dev 2012-09-21 01:51:57 -07:00
Tadashi G. Takaoka
02a67200fc Fix gesture start detection algorithm 
Bug: 7032858
Change-Id: I9f4d939fa87fdead4c5a5921338a16cd0a59b7ac
 2012-09-21 17:30:00 +09:00
Satoshi Kataoka
8ae8c76149 Cleanup settings 
bug: 7200189

Change-Id: Ibfd9254670cde5f4b2b693cc9334ee2845bede59
 2012-09-21 15:10:27 +09:00
Yuichiro Hanada
66597f5e5f Add deleteWord. 
bug: 6669677

Change-Id: I1a5b90ee05e5cffd74a5c140384a3e37c79e7e70
 2012-09-21 12:40:07 +09:00
Yuichiro Hanada
73779f7631 Make readUnigramsAndBigramsBinary read linked-list nodes. 
Change-Id: I07ae036b0b06e71d7a18f2bf11e4692cd4213568
 2012-09-20 20:37:02 +09:00
Yuichiro Hanada
d36245fad2 Add getTerminalPosition. 
Change-Id: If04d779db23b1aea2cc12e5e9b8cecfcb35a5737
 2012-09-20 18:02:16 +09:00
Jean Chalard
b4e74cfc87 Auto correct on gesture when typed word is 1 char long 
Bug: 7178462
Change-Id: I779d8ee4a957a9d1fdcc80d33257a98965dec7b8
 2012-09-20 16:14:16 +09:00
Tadashi G. Takaoka
bfcd2b3fc0 Merge "Change to "Show language switch key" option" into jb-mr1-dev 2012-09-19 19:56:59 -07:00
Tadashi G. Takaoka
1a4aa7e307 Change to "Show language switch key" option 
This change deprecates "Suppress language switch key".

Bug: 7037410
Change-Id: I1bc90877b4d2ee9364728959fd680dcb5b22ecbf
 2012-09-20 11:33:40 +09:00
Satoshi Kataoka
01a5a7d061 Merge "Clear cache of user dic" into jb-mr1-dev 2012-09-19 04:15:19 -07:00
Satoshi Kataoka
17f7b406aa Clear cache of user dic 
Change-Id: Iec2793de3fff7bf15f68f82a50331de7742b7049
 2012-09-19 20:11:45 +09:00
Tadashi G. Takaoka
567204a140 Merge "Show gesture floating preview text is off by default" into jb-mr1-dev 2012-09-19 03:00:40 -07:00
Tadashi G. Takaoka
4f8e451d0c Show gesture floating preview text is off by default 
Bug: 7043127
Change-Id: Icabf080f43a5934fef3824919bb03229522d5e5a
 2012-09-19 18:59:10 +09:00
Jean Chalard
caf15c3c67 Merge "Fix a bug that would persist caps lock state" into jb-mr1-dev 2012-09-19 02:30:49 -07:00
Satoshi Kataoka
8eb2065289 Merge "Log for geometric input" into jb-mr1-dev 2012-09-19 02:22:03 -07:00
Jean Chalard
ad0642cf25 Fix a bug that would persist caps lock state 
...with regards to suggestions. It's much simpler to look at
whether the word is actually all capitalized or not.

Bug: 7113544
Change-Id: Idc0e77b2f812964e650ade0e32b9d4c09228cb74
 2012-09-19 17:54:35 +09:00
Satoshi Kataoka
87cecf7db6 Log for geometric input 
Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f
 2012-09-19 17:45:27 +09:00
Yuichiro Hanada
65feee12e5 Make BinaryDictIOUtils. 
Change-Id: I45830235ee738233e8eb2bd91d659705b698f58c
 2012-09-19 15:37:37 +09:00
Yuichiro Hanada
c2fdf0dfbf Make readNode read linked list nodes. 
Change-Id: Ia5eaae0653179b2eb74c53b0823beaf80377a389
 2012-09-19 14:49:23 +09:00
Yuichiro Hanada
a149c53c8e add limit to FusionDictionaryBufferInterface. 
Change-Id: Ic9ff717a9751023d47b02ff3b9d1fbf3115c2501
 2012-09-19 12:28:19 +09:00
Jean Chalard
a0ebb28d15 Merge "Fix a bug with capitalizations (A15)" into jb-mr1-dev 2012-09-18 20:02:05 -07:00
Jean Chalard
3bf113f0ea Merge "Mark 2 resolved TODOS as such (A14)" into jb-mr1-dev 2012-09-18 20:01:31 -07:00
Jean Chalard
c9923430ed Merge "Support the gesture + phantom space case (A13)" into jb-mr1-dev 2012-09-18 18:36:13 -07:00
Yuichiro Hanada
b686df15fc Add a new flag for linked list nodes. 
Change-Id: Ib2f194775cfe5ab05481ac95cd709d6e8e8dd3c6
 2012-09-18 22:01:49 +09:00
Yuichiro Hanada
bf45dc4860 Make writePlacedNode write the linked-list node. 
Change-Id: I60feda815ea08cf73300fccca1ae12b97550f116
 2012-09-18 21:20:07 +09:00
Yuichiro Hanada
061d225fb1 Add a new option to FormatOptions. 
Change-Id: I8bf089bea5de46570a5e81fb1ea3ab22c07eeee1
 2012-09-18 21:03:13 +09:00
Satoshi Kataoka
e55785e682 New flag for the internal settings 
Change-Id: I81e69a6cda833a0d2c59a73388321ed11e0bd5b3
 2012-09-18 20:33:43 +09:00
Satoshi Kataoka
2040090b46 Merge "Log touch timing" into jb-mr1-dev 2012-09-18 04:32:52 -07:00
Satoshi Kataoka
f8b35b9b04 Log touch timing 
Change-Id: I45ce16c3194fac6da98486a986d23318347cad3a
 2012-09-18 19:26:25 +09:00
Jean Chalard
75b3f81fe1 Fix a bug with capitalizations (A15) 
When only one character has been typed, we should not take that
as a strong symbol that everything should be upper-cased.

Change-Id: I4e3a3223269e6763e3594baeaa844daa79a624ed
 2012-09-18 18:52:05 +09:00
Jean Chalard
e4783f95b2 Mark 2 resolved TODOS as such (A14) 
Change-Id: Ifbb731f5c825675436d079db4ffbae657d71f8da
 2012-09-18 18:49:17 +09:00
Jean Chalard
d461bfd660 Support the gesture + phantom space case (A13) 
Bug: 6950087
Change-Id: I198699f6e687ac74c35b9edfe469dce880d9ecaf
 2012-09-18 18:48:49 +09:00
Jean Chalard
717d4938b5 Merge "Remove useless code (A12)" into jb-mr1-dev 2012-09-18 02:42:36 -07:00
Jean Chalard
ed47131612 Merge "Fix a bug with surrogate characters" into jb-mr1-dev 2012-09-18 02:06:55 -07:00
Jean Chalard
6c721b5f68 Fix a bug with surrogate characters 
This is a pretty bad bug :/

Bug: 7013840
Change-Id: I12c7cfa4fa9d56b2c1fee6e6222c64fe20b88fa3
 2012-09-18 18:01:15 +09:00
Jean Chalard
b128b1cdfe Merge "Take space state into account for caps (A11)" into jb-mr1-dev 2012-09-18 00:21:48 -07:00
Jean Chalard
5822323514 Remove useless code (A12) 
All this code is done inside the StringUtils or RichInputConnection
classes, where it's more logical. Since the IPC call is entirely
gone now, it's no use having these guards inside Latin IME.

Change-Id: Id324567e7458aed12b6f21d7114be3bd39725f15
 2012-09-18 16:16:33 +09:00
Jean Chalard
90a9127244 Take space state into account for caps (A11) 
Bug: 6950087
Change-Id: I8a1bca24db64b4dd54db8ac74d90cf43cbdddab6
 2012-09-18 16:16:28 +09:00
Yuichiro Hanada
8adc0154e6 Remove populateOptions(final ByteBuffer buffer). 
Change-Id: Ifc4c64c9cffe4f343c5a604c192db010a1792acc
 2012-09-18 14:42:52 +09:00
Yuichiro Hanada
65e4970026 Fix hackCanUseDictionaryFile. 
Bug: 7169473

Change-Id: I575aaa350042af076a8da5756993cdae9e73422c
 2012-09-18 14:19:38 +09:00
Jean Chalard
252da38fcd Take locale into account for caps (A10) 
Bug: 4967874
Change-Id: Ic7ce7b2de088308fa00865c81246c84c605db1e5
 2012-09-14 19:42:05 +09:00
Jean Chalard
da8aca6002 Merge "Fix comment warnings (A9)" into jb-mr1-dev 2012-09-14 03:20:34 -07:00
Jean Chalard
32c8704c21 Merge "Remove an unused function (A8)" into jb-mr1-dev 2012-09-14 03:19:53 -07:00
Jean Chalard
5cb9b70a3a Merge "Fix abbreviations processing for English (A7)" into jb-mr1-dev 2012-09-14 03:14:21 -07:00
Jean Chalard
a3f06baa57 Merge "Do not auto-correct upon starting a gesture." into jb-mr1-dev 2012-09-14 03:11:51 -07:00
Jean Chalard
6e65ff8001 Fix comment warnings (A9) 
Thanks Eclipse

Change-Id: Ie2b83f1ec7ab38a76155f8c264e3944685ae934d
 2012-09-14 19:01:37 +09:00
Jean Chalard
50e61b8628 Remove an unused function (A8) 
Change-Id: I0578068946d32192c4faf14b3e86624b7301c7d9
 2012-09-14 19:01:37 +09:00
Jean Chalard
2c0d916287 Fix abbreviations processing for English (A7) 
It's still incorrect for non-English languages.

Bug: 4967874
Change-Id: I3d4379265f72e1c0435eba90ab878a80bbcf55ce
 2012-09-14 19:01:25 +09:00
Jean Chalard
b29efecd26 Merge "Fix a bug with open parens and some other chars" into jb-mr1-dev 2012-09-14 02:30:36 -07:00
Jean Chalard
7e4ad33a65 Fix a bug with open parens and some other chars 
A space would be inserted after an open parenthesis if
it's typed after a manual pick.

Bug: 7167687
Change-Id: Ic49d09c34747117ccfbdbb8c66f634d88d4a45b0
 2012-09-14 18:23:35 +09:00
Jean Chalard
e8db06fc02 Merge "Replace immediate values with named constants for characters (A6)" into jb-mr1-dev 2012-09-14 02:17:48 -07:00
Jean Chalard
d806065033 Merge "Simplification again (A5)" into jb-mr1-dev 2012-09-14 02:17:01 -07:00
Tadashi G. Takaoka
f035649cb6 Asynchronously look up dictionary for gesture input 
Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280
 2012-09-14 02:12:11 -07:00
Jean Chalard
eda096538b Do not auto-correct upon starting a gesture. 
We decided to revert this UI decision after negative feedback.
Indeed, if you use to gesture but tap just one word, chances
are it's because you know you do NOT want a dictionary word.

Bug: 6965241
Change-Id: I85fdfab3c1cf1d3c0fd3e95908e01bdf56bccbba
 2012-09-14 17:52:54 +09:00
Jean Chalard
35dc8cf223 Replace immediate values with named constants for characters (A6) 
Change-Id: I6248f9f3ff99003ab62be22eac673df0f7f5c015
 2012-09-14 16:59:50 +09:00
Jean Chalard
e94c276690 Simplification again (A5) 
Change-Id: Id3ba200e06244e6d13cf57d346001d61f85ef1a2
 2012-09-14 16:59:18 +09:00
Jean Chalard
6f8dfd92b1 Simplify the code some more (A4) 
Change-Id: I1b1763ceefda6357dc698195928d0f16bc425830
 2012-09-14 16:58:04 +09:00
Jean Chalard
33a226f897 Merge "Small simplification (A3)" into jb-mr1-dev 2012-09-13 19:53:14 -07:00
Yuichiro Hanada
cc958dd96e Refactor BinaryDictInputOutput. 
Change-Id: Idb4b635fcac70cc988e0dd3ce3bf121fba12099c
 2012-09-14 11:08:01 +09:00
Jean Chalard
5fbe3764ae Small simplification (A3) 
Change-Id: I2ea9566ce5cb1fbccd33a42836244a899365de6a
 2012-09-13 20:13:52 +09:00
Jean Chalard
d7fdc730c3 Merge "Simplify a call, and add comments (A2)" into jb-mr1-dev 2012-09-13 03:38:50 -07:00
Jean Chalard
3d54e1c1ec Simplify a call, and add comments (A2) 
Since the function has to be modified heavily but does a lot
of non-trivial work, add a wealth of comments explaining what
it does and why so as to facilitate understanding the changes
to come.

Bug: 4967874
Change-Id: I6c21aea15f161d807035f279dfb7d1b98b3e9144
 2012-09-13 18:59:04 +09:00
Jean Chalard
2427f578c8 Merge "Import TextUtils.getCapsMode to fix it internally (A1)" into jb-mr1-dev 2012-09-13 02:57:35 -07:00
Jean Chalard
378728920b Merge "Make onUpdateSelection much more resilient to race conditions." into jb-mr1-dev 2012-09-13 02:28:52 -07:00
Jean Chalard
9d1c73ffd8 Import TextUtils.getCapsMode to fix it internally (A1) 
This should have on effect at all on behavior,
except an increase in performance.

Bug: 4967874
Bug: 6950087
Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
 2012-09-13 17:46:39 +09:00
Jean Chalard
5ed88457bf Make onUpdateSelection much more resilient to race conditions. 
This is pretty much as strong as it gets. It should be
impossible to get false positives and nearly impossible to
get true negatives with this new code.

Bug: 6981089
Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
 2012-09-13 17:35:26 +09:00
Yuichiro Hanada
1a347723c5 Move FormatOptions and FileHeader to FormatSpec. 
Change-Id: I232e35598635113bf2c81825669c744aadc79efe
 2012-09-13 16:35:41 +09:00
Yuichiro Hanada
81d97eec0e Move constants and comments. 
Change-Id: Ifd66bda7d528827ba61c60531121ea206a2325be
 2012-09-13 14:28:39 +09:00
Jean Chalard
18fc3bf4c4 Merge "Make Latin IME aware of its surrounding text." into jb-mr1-dev 2012-09-12 02:07:48 -07:00
Jean Chalard
28d765ed90 Make Latin IME aware of its surrounding text. 
This is a preparatory change for
Bug: 4967874
Bug: 6617760
Bug: 6950087

Change-Id: I3abf8e45c0d02c42491421f108370220134b9602
 2012-09-12 17:54:16 +09:00
Yuichiro Hanada
8d031a63b4 Add put method to FusionDictionaryBufferInterface. 
Change-Id: Iac0b35d2da05e81237d105e8fe13c56d16038de1
 2012-09-12 15:41:21 +09:00
Jean Chalard
8c06a468e0 Stop auto-correcting non-whitelisted one-char strings 
Bug: 7134017
Change-Id: I75cf474dedafda3e1683dd8f7740c13aafdcf5ab
 2012-09-11 17:24:08 +09:00
Yuichiro Hanada
e55b644aef Add new binary dictionary format. 
Change-Id: Ia99411d4009857d5e420ca87ef8acf1f1826d3ed
 2012-09-10 13:05:46 +09:00
Ken Wakasa
60af4f03a8 Fix dicttool_aosp build 
Change-Id: Iabcf420b4120e3d275fdbcb23939a0ab6052ddf0
 2012-09-10 12:56:10 +09:00
Yuichiro Hanada
eae7b293e4 Check the length of the word when add to FusionDictionary. 
Change-Id: Id98d18e90a8b83b597507728b467f56888c8fd12
 2012-09-10 12:35:53 +09:00
Yuichiro Hanada
be5db53a09 Add tests for readDictionaryBinary with byte array. 
Change-Id: I2c2815e9d4867687fb3f5b0c661e6162b88c0a0c
 2012-09-06 20:35:33 +09:00
Yuichiro Hanada
83dfe0fd8c Add FormatOptions. 
Change-Id: Ibad05a5f9143de1156b2c897593ec89b0a0b07e7
 2012-09-05 18:05:43 +09:00
Jean Chalard
ac25fcac71 Display punctuation suggestions on cursor move 
...if punctuation suggestions are requested.

Fixes the symptom, but not the root cause of
Bug: 6981089

Change-Id: I683a7451c99457829cb4e5a762f43548ff89a535
 2012-09-04 19:54:55 +09:00
Ken Wakasa
2e4713a54e Merge "Check the length of the word when add to userhistory." into jb-mr1-dev 2012-09-04 02:36:35 -07:00
Tadashi G. Takaoka
848331222e Use string-array resource to define predefined-subtypes 
Bug: 6809603
Change-Id: Icafe4652ec17844838b28c04977deb88bcb9aa8f
 2012-09-04 17:18:39 +09:00
Yuichiro Hanada
dd435b305e Check the length of the word when add to userhistory. 
Change-Id: I7f2fe1771eed6b610704892b24f8a0283a779162
 2012-09-04 15:34:41 +09:00
Ken Wakasa
f2789819bd Cosmetic fixes and a bug fix in UnigramDictionary::testCharGroupForContinuedLikeness(). 
This change has actually been extracted from a change work in progress I4fe423834b8131fb122251892c98228a6e08ba25

Change-Id: I52568fa09da2ea22be7f8bfe9676b7cd73c31fa4
 2012-09-04 14:23:37 +09:00
Jean Chalard
8251036616 Match calls in I8a70e43b for Icbe60bdf 
Change-Id: I3a9eaaa018cd338ca8d9aa09c0fa58800b637e19
 2012-09-03 11:58:23 +09:00
Jean Chalard
2035b946a3 Merge "Reinstate the shortcut-only attribute" into jb-mr1-dev 2012-09-02 19:28:01 -07:00
Jean Chalard
72b1c93941 Reinstate the shortcut-only attribute 
Also add the blacklist attribute

Bug: 7005742
Bug: 2704000
Change-Id: Icbe60bdf25bfb098d9e3f20870be30d6aef07c9d
 2012-08-31 22:11:52 +09:00
Yuichiro Hanada
666a433802 add UserHistoryDictIOUtils. 
Change-Id: I8a70e43b23f65b5fd5f0ee0b30a94ad8f5ef8a8a
 2012-08-31 15:08:57 +09:00
Kurt Partridge
9bbc7ec052 Merge changes Ifb983c35,I0b947421 into jb-mr1-dev 
* changes:
  ResearchLogger clean up splash screen
  ResearchLogger no longer offers option to disable logging
 2012-08-30 22:56:53 -07:00
Kurt Partridge
58eb4d9f27 ResearchLogger no longer offers option to disable logging 
Bug: 6188932
Change-Id: I0b9474216080f3820438c09f89b0b6c6c102c69d
 2012-08-30 22:51:56 -07:00
Yuichiro Hanada
b2a43a2ed4 add readUnigramsAndBigramsBinary. 
Change-Id: I7967f11211221d4877bf0a0c30183af885f45390
 2012-08-31 14:39:19 +09:00
Tadashi G. Takaoka
35ff94547c Separate inner classes of keyboard package out under internal package 
Change-Id: Ia3969bd5ddec5aa5d81d05ad4cf676d818587922
 2012-08-30 15:37:55 +09:00
Jean Chalard
ded498d4a4 Merge "add readHeader." into jb-mr1-dev 2012-08-29 22:32:14 -07:00
Yuichiro Hanada
62ed901100 add readHeader. 
Change-Id: I5be5d62a63ca897e36fe93200ffdca6befb363aa
 2012-08-30 14:17:50 +09:00
Tadashi G. Takaoka
61bc66b324 Revert "Revert "Fix key letter size of 5-rows Thai keyboard"" 
This reverts commit 7a5ca9982f.
Depends: Ia4fa5046b3106e2710b9d5df1a6cc5f2cf995ec7

Change-Id: I0b9d0125380efe898943dc26ae884378145c44a3
 2012-08-30 11:30:13 +09:00
Tadashi G. Takaoka
b590d69e1f Merge "Revert "Revert "Move resource related methods to ResourceUtils""" into jb-mr1-dev 2012-08-29 19:29:37 -07:00
Ken Wakasa
d2a81ab9bd Merge "Add FusionDictionaryBufferInterface." into jb-mr1-dev 2012-08-29 18:49:03 -07:00
Tadashi G. Takaoka
92821614fd Revert "Revert "Move resource related methods to ResourceUtils"" 
This reverts commit bfc02a7005.

Change-Id: Ife4c0312ea3260211b1b5ee39b239e8e9d7db67e
Depends: I3d862515568be36d5aa80d12e7e5c0a9bf4d06a6
 2012-08-29 22:30:55 +09:00
Ken Wakasa
bfc02a7005 Revert "Move resource related methods to ResourceUtils" 
This reverts commit 160dc0f98e

Change-Id: Ic5a3d9c70b8f6f2993d8455799945ec2633cad66
 2012-08-29 04:33:39 -07:00
Yuichiro Hanada
f5c4ff4817 Add FusionDictionaryBufferInterface. 
Change-Id: I8640c994231d5f46bc6e074ce8a5bf5344fed0aa
 2012-08-29 19:27:49 +09:00
Tadashi G. Takaoka
160dc0f98e Move resource related methods to ResourceUtils 
Change-Id: I14535b030e58363315dd2daecaaef4edd6990cd9
 2012-08-29 17:51:07 +09:00
Tadashi G. Takaoka
1e11c44d1b Make utility classes final 
Change-Id: Ic4f69b4c8da33c9fca50d6829724179310c2f875
 2012-08-29 17:38:08 +09:00
Jean Chalard
4fa01ee570 Merge "Allow Latin IME to cancel smiley-auto-correct consistenly" into jb-mr1-dev 2012-08-29 01:18:15 -07:00
Jean Chalard
a05a0f2077 Allow Latin IME to cancel smiley-auto-correct consistenly 
This change makes Latin IME behave consistently with regards
to other auto-correction cancellations in cases of auto-correction
cancellation after smiley-triggered auto-correction. That is,
pressing the smiley key when the keyboard signals it's about to
auto-correct will get the auto-correction there plus a smiley,
and pressing backspace will cancel the auto-correction, and
pressing backspace again will delete the smiley.

Bug: 7067593
Change-Id: Ia7eef70a5d06b8b9afa1f1fbb0ed1dbc21a3059f
 2012-08-29 16:49:39 +09:00
Tadashi G. Takaoka
9879f65651 Add ResourceUtils 
Change-Id: Ia198f8d95eae8c007623cd52d73cc1528d22fee9
 2012-08-29 16:36:00 +09:00
Tadashi G. Takaoka
95c486cdf3 Merge "Move some methods from Utils to LocaleUtils class" into jb-mr1-dev 2012-08-29 00:35:27 -07:00
Tadashi G. Takaoka
0023a57eea Move some methods from Utils to LocaleUtils class 
Change-Id: I4a834549c2ea96ac30d7e2cb692d69af219cab1a
 2012-08-29 16:24:53 +09:00
Tadashi G. Takaoka
237f5e4f9b Remove unused methods from Utils class 
Change-Id: I209b75f1cca381610f25cd219f35ea62b9762be2
 2012-08-29 16:10:16 +09:00
Jean Chalard
43d3f0fa3b Merge "Auto-correct after smileys and gestures." into jb-mr1-dev 2012-08-28 01:59:20 -07:00
Tadashi G. Takaoka
ef2bfad590 Use TypedArray.getFraction to read percentile values in resource 
Change-Id: Ifc8b024d190efba4cd536fd639621e841eb9970e
 2012-08-28 15:18:40 +09:00
Jean Chalard
6c70b92003 Auto-correct after smileys and gestures. 
Bug: 6936790
Bug: 6965241
Change-Id: I1f61327eb5591960c280e425df9cd86b9c52f5d6
 2012-08-27 18:54:05 +09:00
Jean Chalard
5cc596160a Merge "Use ByteBuffer when reading FusionDictionary from file." into jb-mr1-dev 2012-08-23 21:56:02 -07:00
Yuichiro Hanada
d4fe7fda30 Use ByteBuffer when reading FusionDictionary from file. 
Change-Id: Ia71561648e17f846d277c22309ac37c21c67a537
 2012-08-24 13:31:08 +09:00
Tadashi G. Takaoka
64a26b4389 Fix bug in InputPointers.append 
Change-Id: I39825757bbae32b66c4b61cb6c4fbcaa2e0c9c47
 2012-08-23 17:59:08 +09:00
Tadashi G. Takaoka
64ee096100 Add toString method to InputPointers and ResizableIntArray 
Change-Id: I835ee131855bef8233cf2672e2fb288b939148a6
 2012-08-23 17:29:36 +09:00
Kurt Partridge
d573bad5bd Merge "ResearchLogging capture full n-gram data" into jb-mr1-dev 2012-08-22 10:41:10 -07:00
Tadashi G. Takaoka
50e7501722 Merge "Fix SubtypeSwitcher initialization path" into jb-mr1-dev 2012-08-22 01:02:04 -07:00
Tadashi G. Takaoka
9fc6af325e Fix SubtypeSwitcher initialization path 
This change also removes the reference of LatinIME from
SubtypeSwitcher.

Bug: 7026856
Change-Id: I78a266f3682b11f09b49bbcdcdb6aee713e6af37
 2012-08-22 16:05:34 +09:00
Kurt Partridge
bf653996ea ResearchLogging capture full n-gram data 
- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ic70ccb6c2e11eb02d887821434b44daa3eb7a3e2

Bug: 6188932
Change-Id: I731d6cff6539e997874f723b68bdb0d9b651b937
 2012-08-21 22:37:33 -07:00
Tadashi G. Takaoka
ecfbf4625c Add static construct method for SparseArray 
Change-Id: I6da97f6ea23578318f403bb5d64c30b1663c69ee
 2012-08-22 14:22:20 +09:00
Tadashi G. Takaoka
1f05cf6dab Remove GCUtils utility class 
Change-Id: Ia666aeb10c155d69763faf7f01ceca113b9b4653
 2012-08-22 12:34:22 +09:00
Tadashi G. Takaoka
f852891437 Merge "Remove KeyboardSwitcher reference from ResearchLogger" into jb-mr1-dev 2012-08-21 20:22:57 -07:00
Jean Chalard
07d485d705 Merge "Fix a silly bug." into jb-mr1-dev 2012-08-21 20:16:28 -07:00
Tadashi G. Takaoka
c3f78c9057 Remove KeyboardSwitcher reference from ResearchLogger 
Change-Id: I671a83c19977fda358c8e8a730e22ee155f65512
 2012-08-22 12:14:52 +09:00
Jean Chalard
32f6503a27 Fix a silly bug. 
This would prevent user history to work at all.

Bug: 7023638
Change-Id: I5d8867a07fb8859325d274e956ae667c094d0ac1
 2012-08-22 12:09:24 +09:00
Tadashi G. Takaoka
5f282ea9e4 Add CollectionUtils class to create generic collection easily 
Change-Id: I6b4de9187e122298e5e9cd8ddc9070d062df6a89
 2012-08-22 10:21:38 +09:00
Kurt Partridge
94e7f4bef9 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with I05496cfd762e9a41c42c50099143f1efc0a3d8a2

Bug: 6188932
Change-Id: I424abb2e437901262a9620255493916b7c3ff74b
 2012-08-21 17:13:36 -07:00
Jean Chalard
8b6b5592cb Merge "Treat all caps for gesture input." into jb-mr1-dev 2012-08-21 04:39:04 -07:00
Jean Chalard
324cc1dbe6 Merge "Tell the shift mode to the word composer." into jb-mr1-dev 2012-08-21 04:38:27 -07:00
Jean Chalard
1eba97d92f Treat all caps for gesture input. 
Bug: 6950087
Change-Id: I9f2271780600572c9befa96c7ad98494c554dd2b
 2012-08-21 20:29:53 +09:00
Jean Chalard
adbd9ae105 Tell the shift mode to the word composer. 
Bug: 6950087
Change-Id: Ifab9d6d075af398c6468d081216488712f8a53fb
 2012-08-21 20:27:42 +09:00
Tadashi G. Takaoka
ac78633be2 Rename and consolidate some constants 
Change-Id: I7863936cca18b28bf0117afcbcf544a5fd7f185d
 2012-08-21 17:54:53 +09:00
Tadashi G. Takaoka
6785b90727 Remove touch coordinate from pickSuggestionManually 
Change-Id: I33b1b4bc6fdfd263c4b2bb7125c07b4bddcf3c9f
 2012-08-21 17:13:45 +09:00
Kurt Partridge
48643b0e0d Merge "Revert "ResearchLogger log RichInputConnection"" into jb-mr1-dev 2012-08-20 10:18:40 -07:00
Kurt Partridge
adb591e75b Merge "Revert "ResearchLogging capture full n-gram data"" into jb-mr1-dev 2012-08-20 10:18:30 -07:00
Kurt Partridge
35c11842a7 Revert "ResearchLogger log RichInputConnection" 
This reverts commit 1964ffb3f4

Change-Id: Ie43e7ac828faa91e1824a255bb3ecf6c8222d4e8
 2012-08-20 10:17:45 -07:00
Kurt Partridge
3d35908749 Revert "ResearchLogging capture full n-gram data" 
This reverts commit 221e756fd7

Change-Id: Iefc4e4e27ddc925d4a4634627b0467bd4ee2a66e
 2012-08-20 10:17:40 -07:00
Kurt Partridge
752c53760c Merge changes I568c90d4,I4667f8f6 into jb-mr1-dev 
* changes:
  ResearchLogging capture full n-gram data
  ResearchLogger to track simple statistics
 2012-08-20 08:47:45 -07:00
Kurt Partridge
461f1942f9 Merge "ResearchLogger log RichInputConnection" into jb-mr1-dev 2012-08-20 08:47:33 -07:00
Tadashi G. Takaoka
cb2362cee1 Merge "Make some usages of SparseArray thread-safe" into jb-mr1-dev 2012-08-19 23:23:08 -07:00
Tadashi G. Takaoka
8ce351a827 Make some usages of SparseArray thread-safe 
This is a follow up of I39d9bf1a7c272eb16d6ed4698f52457579b40f10.

Change-Id: Ic3288e491175f9a85679a21064093f9db5a65466
 2012-08-20 15:00:26 +09:00
Jean Chalard
1aed102d4c Merge "Fix capitalization, part 1" into jb-mr1-dev 2012-08-19 22:29:59 -07:00
Jean Chalard
4c6db0592e Merge "Remove the whitelist dictionary." into jb-mr1-dev 2012-08-19 22:13:15 -07:00
Jean Chalard
04d6649d29 Merge "Remove access to the whitelist class." into jb-mr1-dev 2012-08-19 22:12:36 -07:00
Jean Chalard
13822d2b05 Hack to skip reading an outdated binary file. 
Bug: 7005813
Change-Id: Ie0d8d4b2d5eb147838ca23bdd5ec1cecd4f01151
 2012-08-20 13:56:52 +09:00
Jean Chalard
fb087a95f9 Fix capitalization, part 1 
The case this fixes is typing "Ah.\n" in gmail for example

Bug: 6950087
Change-Id: Ia4bf3a57dde49b9c9d47d315e9f85b7ffc7ee6e3
 2012-08-20 13:51:27 +09:00
Kurt Partridge
221e756fd7 ResearchLogging capture full n-gram data 
DO NOT MERGE

- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ie2bc79fd7fe6b951b24771e94b8d4ca21989af65

Bug: 6188932
Change-Id: I568c90d4af07e7c759c1e7fc64b716bd8c7b4ae5
 2012-08-17 21:44:07 -07:00
Kurt Partridge
1964ffb3f4 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with Ib71f841044ec1072610ab5638a5edfce29b7c05b

DO NOT MERGE

Bug: 6188932
Change-Id: I9ec7500a5b18bfe1a5a5bb1e5bf21c43351fc59e
 2012-08-17 21:44:06 -07:00
Ken Wakasa
e46d12927e Fix NPE in LatinIME.addToUserHistoryDictionary() 
bug: 7007063
Change-Id: Ie3e2f77dcbc597dda0c0df9a970336e5aac0edba
 2012-08-18 00:04:33 +09:00
Ken Wakasa
72c0f4de1d Merge "add reconstructBigramFrequency" into jb-mr1-dev 2012-08-17 03:19:12 -07:00
Yuichiro Hanada
c0a75c8ecb add reconstructBigramFrequency 
Change-Id: Iff20dcb9ca0d6064bb118247887fe24b812c0c61
 2012-08-17 19:05:16 +09:00
Jean Chalard
aa27635a8a Reword a confusing comment 
Bug: 7005645
Change-Id: Ifd942b3ce242aeeec512e132e1cee31329e994b1
 2012-08-17 17:22:28 +09:00
Jean Chalard
46fc768e54 Remove the whitelist dictionary. 
The functionality now lives in the binary dictionary.

This finalizes work on
Bug: 6906525

Change-Id: Id106d871e8afdf9afa886d2a30bea87ff89f2d24
 2012-08-17 15:13:10 +09:00
Jean Chalard
3e43e6998e Remove access to the whitelist class. 
...which becomes useless. It will be entirely removed in an
upcoming change.

Change-Id: I2f1d27f1eceda79454b01f21e057b98f2953131a
 2012-08-17 13:01:25 +09:00
Jean Chalard
228674f6c7 Merge "fix findWordInTree." into jb-mr1-dev 2012-08-16 18:54:24 -07:00
Yuichiro Hanada
0d35c159fe fix findWordInTree. 
Change-Id: I8f42df28f76188677db9d4e55885e1fc6a40b53f
 2012-08-17 10:23:01 +09:00
Jean Chalard
3083b4b77d Merge "Fix a debug method" into jb-mr1-dev 2012-08-16 17:59:11 -07:00
Jean Chalard
cc1062cfd0 Fix a debug method 
Change-Id: Icf78fb0d5f7caea78f053fffd1ecd4289629964a
 2012-08-17 09:24:45 +09:00
Ken Wakasa
bc44ad77e5 Merge "fix findWordInTree." into jb-mr1-dev 2012-08-16 04:26:55 -07:00
Yuichiro Hanada
66f338983b fix findWordInTree. 
Change-Id: I9d81c815494a0670afa81219ad7bad82274d997e
 2012-08-16 20:21:47 +09:00
Jean Chalard
91c64902b0 Merge "Refresh editor info when the text field attributes changes." into jb-mr1-dev 2012-08-15 02:35:21 -07:00
Jean Chalard
e234aed428 Refresh editor info when the text field attributes changes. 
For some reason we get a "restarting" flag from the browser
some times when the input field is different. The attributes
however are not the same, so we can detect that and reload
appropriately.

Bug: 6946793
Change-Id: I6762dae6f41db690497b026a707d9cc89c840b34
 2012-08-15 18:32:59 +09:00
Jean Chalard
cd0e004888 Merge "Ensure #offer always actually offers something." into jb-mr1-dev 2012-08-15 02:16:09 -07:00
Jean Chalard
653dbfb8ed Ensure #offer always actually offers something. 
This will allow remaining requests after a call to terminate
correctly.

Bug: 6963142
Change-Id: Iff67058bb8a39f2f1b468d3894861e8125de6659
 2012-08-15 18:10:10 +09:00
Satoshi Kataoka
3979f060f0 Step 28-A Introduce the session Id to getSuggestion 
Change-Id: I39d9bf1a7c272eb16d6ed4698f52457579b40f10
 2012-08-15 15:44:45 +09:00
alanv
0538493309 Fix the build. 
Change-Id: I744f6232e81981ab694d3d1e92bab5fd6efa46c0
 2012-08-14 15:34:29 -07:00
Charles Chen
dd7f79097a Merge "Change accessibility event type for app-driven speech." into jb-mr1-dev 2012-08-14 14:33:32 -07:00
Jean Chalard
e30c05800f Preemptive anti-deadlock device 
We don't know of any actual bug in the implementation of the
pool that may result in a deadlock, but this still implements
a means out of a deadlock if one ever arises anyway. It's
meant to improve the resilience of the spell checker.

Bug: 5441027
Change-Id: I689491090792dbb89110ee56631965c5bb2dc712
 2012-08-14 17:04:14 +09:00
Jean Chalard
5d6b8e1818 Fix a bug that would prevent spell checking 
java.lang.ArrayIndexOutOfBoundsException:
        [I offset=0 length=528 src.length=512
com.android.inputmethod.keyboard.ProximityInfo
        .setProximityInfoNative(Native Method)
com.android.inputmethod.keyboard.ProximityInfo
        .createSpellCheckerProximityInfo(ProximityInfo.java:85)
com.android.inputmethod.latin.spellcheck.AndroidSpellCheckerService
        .createDictAndProximity(AndroidSpellCheckerService.java:411)

The array was too small with respect with the passed size.

Change-Id: I7777d7aecd17375d3fbf82854a66eb7a5a289ce6
 2012-08-14 14:45:17 +09:00
Ken Wakasa
bcec82de66 Clean up constructors 
And, use C++ style casts and use float math functions rather than double ones to save memory space.

Also, stop using FloatMath and NativeUtils as standard Math methods are faster now.
See http://code.google.com/p/android/issues/detail?id=36199 and https://android-review.googlesource.com/40700

multi-project commit with I4259fb5ab8a15ac5760a7f04fc8f4c860529f04a

Change-Id: I0b81cff8c91769f7559a59b9528c75a5aabb4211
 2012-08-13 10:48:37 +09:00
satok
847c8dfe17 Fix JNI 
Change-Id: If134baf52e78fbe18b78611a23870f5d10c80955
 2012-08-11 13:54:01 +09:00
alanv
5f312c9c15 Change accessibility event type for app-driven speech. 
Bug: 6614400
Change-Id: I0ef309b7f3f35bf37b4664ea599c9e6ffb1a4ab8
 2012-08-10 13:51:17 -07:00
Ken Wakasa
f3850e5543 Use JNI Region calls also in getSuggestions() 
Change-Id: I9cc0208397c202aeb6f7b5bb5ad59e00c5afbd80
 2012-08-10 21:09:23 +09:00
Satoshi Kataoka
f6c2200890 Workaround to stop init dict traverse session 
Change-Id: I3d46c54a96a9fc0359ef75b9d2f8590b44164a8b
 2012-08-10 21:07:53 +09:00
Jean Chalard
7b258e512d Accept whitelisted entries from any source. 
...not only the WhitelistDictionary.

Bug: 6906525
Change-Id: I7f181eb6936ec17bbccdc4e736fd09292af24e9c
 2012-08-10 19:02:19 +09:00
Jean Chalard
caed149b67 Optimization & Simplification 
It's useless to do the whitelist lookup twice. Also, putting
this test out of this method will allow whitelist entries to
come from other sources.

Bug: 6906525
Change-Id: I4afe678cae6556d16642d155ce770fbf4e61ad49
 2012-08-10 19:02:15 +09:00
Jean Chalard
dc2fb6bc6d Merge "Pass the type from native code all the way to Java." into jb-mr1-dev 2012-08-10 01:26:59 -07:00
Jean Chalard
926ef06a1e Pass the type from native code all the way to Java. 
Bug: 6906525
Change-Id: I057390d47a223450e22d8338509e22c28fc0d5f6
 2012-08-10 15:51:55 +09:00
Satoshi Kataoka
e9f3e182e4 Add arguments for dic traverse session 
Change-Id: I8776ad528eeea9a5fc4dcf394ca13bb80c04fb6d
 2012-08-10 12:34:00 +09:00
Ken Wakasa
5bb4206275 Use more JNI Region calls 
Change-Id: I371db517ff4749c0b7e5bdb4362e6310c91a24dc
 2012-08-10 00:46:20 +09:00
Satoshi Kataoka
9d29871605 Add reset method for dic travserse session 
Change-Id: Ia3dd924f92549da2cf8302ef77c629902d4f275b
 2012-08-09 17:49:19 +09:00
Tadashi G. Takaoka
2be2d77664 Update dictionary availability at onStartInputView 
This is a follow up of I7901c0f9489b4deb79314c2c903b138611bfd78e

Change-Id: I38c22e886db247c402a964e3ddd10b09a461151c
 2012-08-09 16:09:54 +09:00
Tadashi G. Takaoka
9abea49dd4 Merge "Fix NPE and don't call UI API from non-UI thread" into jb-mr1-dev 2012-08-08 20:00:19 -07:00
Tadashi G. Takaoka
8335c59ea7 Fix NPE and don't call UI API from non-UI thread 
This change also reverts I29ec3e9f10484f30288fac76f0c45b3707bc2259

Bug: 6956969
Bug: 6891020
Bug: 6947253
Change-Id: I7901c0f9489b4deb79314c2c903b138611bfd78e
 2012-08-09 11:55:41 +09:00
Satoshi Kataoka
60d4961f34 Merge "Pass traverse session" into jb-mr1-dev 2012-08-08 07:50:44 -07:00
Satoshi Kataoka
9127811493 Pass traverse session 
Change-Id: I84bfaaa406e3f51421c08a7ee8f9576ebdba54d4
 2012-08-08 23:30:31 +09:00
Satoshi Kataoka
181567f9c7 Merge "Add traverse session" into jb-mr1-dev 2012-08-08 04:40:36 -07:00
Satoshi Kataoka
c4e4dfe17d Add traverse session 
Bug: 6942265

Change-Id: I384cf701f5ee44c4b1037e5b8ddfa3d570286f55
 2012-08-08 20:39:43 +09:00
Tadashi G. Takaoka
79eefda0d3 Add SuggestInitializationListener to BinaryDictionary.resetMainDict() 
Change-Id: I4c01f172ddb2ca60fa6e604384610c90b76e5457
 2012-08-08 15:55:26 +09:00
Tadashi G. Takaoka
27e48447a4 Lingering gesture floating preview text a bit 
Bug: 6936095
Change-Id: I873343e9aa6afdf6bdb223795f03232509b012a7
 2012-08-07 13:54:42 +09:00
Tadashi G. Takaoka
7a13975700 Cleanup unused import and dead code 
Change-Id: Ife877620561d29a8f25602916420741186104617
 2012-08-06 17:28:33 +09:00
Tadashi G. Takaoka
dba77186f7 Fix duplicate getSuggestions() call for main dictionary 
Change-Id: I092480063452505cdf03dbd83b9c64e535822931
 2012-08-06 17:08:38 +09:00
Tadashi G. Takaoka
b27959741a Fix Utils.getStackTrace() 
Change-Id: Iaf160af32bb77b3ad5929cb5ee8eccd01165bdf6
 2012-08-06 16:50:43 +09:00
Tadashi G. Takaoka
0a524de3df Separate updateSuggestionStrip from commitTyped 
The commitTyped() called updateSuggestionStrip(), and that led to call
Suggest.getSuggestedWordsForTypingInput() even after a batch input was
started because WordComposer.commitWord() reset the batch input state.

Bug: 6932442
Change-Id: If645b1ef0343aa1e21ca71a9275b40c6c3be13df
 2012-08-06 14:31:01 +09:00
Jean Chalard
15b28432ba Merge "Cleanup unused code" into jb-mr1-dev 2012-08-03 09:32:27 -07:00
Jean Chalard
8ee4b35c70 Cleanup unused code 
The Italian dictionary has been amended to contain words that
include apostrophes, and accordingly the apostrophe is now
excluded from word separators in Italian.
This code was only used for Italian, and in the general case
it does the wrong thing; it was only needed by limitations of
the old dictionary.

Bug: 6929108
Change-Id: I7ff4615e01899a1cebed2c4c51679cd0746740fe
 2012-08-04 01:15:04 +09:00
Jean Chalard
54e84a00fc Make a makedict command for dicttool (A3) 
This behaves exactly as the old makedict command. Further
changes will redirect the calls to makedict to this, so as
to consolidate similar code.

Groundwork for
Bug: 6429606

Change-Id: Ibeadbf48bec70f988a15ca36ebf5d1ce3b5b54ea
 2012-08-04 01:11:46 +09:00
Jean Chalard
3f80541844 Merge "Fix an OOB exception" into jb-mr1-dev 2012-08-03 07:17:37 -07:00
Jean Chalard
4c976aceee Fix an OOB exception 
Not sure exactly how this can happen, but at least this should
prevent us from crashing.

Bug: 6920884
Change-Id: I451864756b48c5cb5e98b06edee917d88766d77f
 2012-08-03 23:10:47 +09:00
Tadashi G. Takaoka
622d6a5b1b Using hardware accelerated drawing 
When Canvas has been hardware accelerated, don't use offscreen bitmap.

Bug: 6872994
Change-Id: I1121f76377991692bc29ebeedbfbfa1b2a12dbb7
 2012-08-03 20:46:10 +09:00
Ken Wakasa
fb955693d4 Enable hardware accelerated drawing for SoftInputWindow of LatinIME 
Taking advantage of Ib6a8bda46223ce1153f32834daf02a820d16136e

bug: 6872994
Change-Id: I799b25b6509980dd9f039bead9bc926b42cbb040
 2012-08-02 15:11:31 +09:00
Jean Chalard
f68fe7a9c9 Don't forward phantom space state on stripper input 
Bug: 6890540
Change-Id: I923b24e3bc17e7b923be4940ad739b58dca24a1f
 2012-07-31 01:48:10 +09:00
Tadashi G. Takaoka
ca57f5ba40 Move gesture preview parameters to KeyboardView attributes 
Change-Id: Iff9d6b485e202656fc869f3ff4d94575ad2c186f
 2012-07-30 20:10:48 +09:00
Tadashi G. Takaoka
47e2bf3298 Add advanced options to turn on/off the gesture trail and text preview 
Bug: 6883053
Change-Id: I601718afb37289108b45ef68626c7c315edca35d
 2012-07-30 15:54:27 +09:00
Jean Chalard
79d4c70b93 Merge "Don't auto-correct when there are digits." into jb-mr1-dev 2012-07-27 09:12:01 -07:00
Jean Chalard
e7c471a52f Don't auto-correct when there are digits. 
Bug: 6667462
Change-Id: I796655f57c71c9f50ae6e38dd08b71df3998dbcf
 2012-07-28 00:15:54 +09:00
Jean Chalard
6fc72cae20 Fix a bug with autocaps 
Port of Iece016f4

Bug: 6886405
Change-Id: I148c296d8a3841c40b6748e73ed2b0fff473b627
 2012-07-27 21:09:25 +09:00
Jean Chalard
aa906c36aa Handle correctly the restarting argument 
Bug: 6851364
Change-Id: Ie939a43b8527a76aec213b702d3d850717f22a81
 2012-07-26 21:57:15 +09:00
Tadashi G. Takaoka
941f222c21 Merge "Remove unused setProximityCorrectionEnabled() methods" 2012-07-25 19:54:40 -07:00
Ken Wakasa
e55d78ab0c Stop swallowing an UnsatisfiedLinkError 
Change-Id: I37d61274e1527229befabae2c392fd78e279b807
 2012-07-26 09:15:39 +09:00
Tadashi G. Takaoka
c4376db0f0 Remove unused setProximityCorrectionEnabled() methods 
Change-Id: I03aa6608ee435b36377de41684162b303740f571
 2012-07-25 20:37:36 +09:00
Tom Ouyang
2f81757c3a Add dynamic floating preview for incremental gesture recognition. 
Change-Id: I7ba7ac24aa96a0ff19267997c5b58853079bc6dc
 2012-07-25 19:40:55 +09:00
Tadashi G. Takaoka
0657b9698a Update gesture mode state when dictionary gets available 
Bug: 6860204
Change-Id: I840b7bf1983ab92fa4e0b180129176539e96409f
 2012-07-25 16:11:53 +09:00
Tadashi G. Takaoka
369e54cc33 Add Suggest initialization finish listener 
Bug: 6860204
Change-Id: I1e4c03c99415cd9bdea5a8556ff4093c33f0f508
 2012-07-25 09:55:22 +09:00
Tadashi G. Takaoka
506259396f Merge "Update gesture suggestions even when suggestions strip is off" 2012-07-23 03:45:21 -07:00
Tadashi G. Takaoka
7575ac7054 Update gesture suggestions even when suggestions strip is off 
Bug: 6852483
Change-Id: I873ae0f2e3bc863e989629f8bc0cc90ee33a4920
 2012-07-23 19:37:00 +09:00
Jean Chalard
c0f0ceeccf Merge "Fix a bug with the 'add to dict' hint popping up too much" 2012-07-23 03:20:01 -07:00
Jean Chalard
491d451e38 Fix a bug with the 'add to dict' hint popping up too much 
Not having a main dictionary is not sufficient reason to display
the hint. If the user already added the word to the dictionary then
we shouldn't be displaying it again, even if we don't have a main
dictionary for the current language.

Bug: 6829798
Change-Id: I6b081f51c82ef395fe2e394fd3167363e743ea6f
 2012-07-23 18:32:13 +09:00
Tadashi G. Takaoka
259905ba90 Rename suggestion strip related methods 
Change-Id: I942692bbc2e577482f353d875405c4658a1102fc
 2012-07-23 18:04:02 +09:00
Tadashi G. Takaoka
4702671ea4 Rename SuggestionsView to SuggestionStripView 2012-07-23 15:37:43 +09:00
Tadashi G. Takaoka
c8e45ddb03 Rename LatinKeyboardView to MainKeyboardView 
Change-Id: I8f3123b8d727c7beb72e226f80c17794f89c8b60
 2012-07-23 12:11:43 +09:00
Kurt Partridge
3c233bf1a5 ResearchLogger feedback form 
- also cleaned up RLog menu

multi-project commit with If0fd4fef89d390073e6939d5188ed5696866cb33

Bug: 6188932
Change-Id: I4f66f13bd366b4e8bde742ccd0704f812c6d33f9
 2012-07-22 18:36:24 -07:00
Kurt Partridge
6b966160ac ResearchLog refactor 
- new package: com.android.inputmethod.research

multi-project commit with Ic0a5744f3160d13218addd589890623c0d120ffc

Bug: 6188932

Change-Id: Icf8d4a40a5725401799be6e209a640d99a5f34c4
 2012-07-20 15:06:51 -07:00
Tadashi G. Takaoka
7519091f7c Use ResizableIntArray in GestureStroke 
Change-Id: I034e80df03c7c6c0895fdf2c03763627d410d425
 2012-07-20 19:32:28 +09:00
Tadashi G. Takaoka
62b8dddb6d Add gesture input enable settings 
Bug: 6845325
Change-Id: I3165465b0b280e32a9288da16abb75baa67288dc
 2012-07-20 19:26:36 +09:00
Tom Ouyang
528738341d Merge "Add gesture trail feedback." 2012-07-20 01:26:30 -07:00
Tom Ouyang
4daf32b6c0 Add gesture trail feedback. 
Change-Id: I32709fac0dec3165678a052aa286e2fb3d90721b
 2012-07-20 17:09:23 +09:00
Tadashi G. Takaoka
2f6a90ac31 Merge "Implement ResizableIntArray.fill" 2012-07-20 00:33:07 -07:00
Tadashi G. Takaoka
7abdcf1ed3 Implement ResizableIntArray.fill 
Change-Id: I570641bc2f32d016c247db6c065a138d8235ab8c
 2012-07-20 16:05:37 +09:00
Tadashi G. Takaoka
732edc1ff1 Merge "Fix NPE where the current subtype is null" 2012-07-19 22:57:39 -07:00
Tadashi G. Takaoka
d6a18cdedb Fix NPE where the current subtype is null 
Bug: 6847999
 2012-07-20 14:51:41 +09:00
Kurt Partridge
48ded4e3b1 Merge "ResearchLogger: make logging more reliable (esp on startup)" 2012-07-19 21:31:41 -07:00
Tadashi G. Takaoka
c49c85f835 Implement ResizableIntArray.setLength and .get 
This change revises ResizableIntArrayTests as well.
 2012-07-20 12:02:38 +09:00
Kurt Partridge
0df487678e ResearchLogger: make logging more reliable (esp on startup) 
Bug: 6188932
Change-Id: I692e427ba2e6da7bb15f48208304c4a034392a22
 2012-07-19 09:00:21 -07:00
Tadashi G. Takaoka
9370ab9ada Make ScalableIntArray public as ResizableIntArray 
Change-Id: Ibbbc117214912ffa192c694bde5b7d55154f40c4
 2012-07-19 20:37:53 +09:00
Tadashi G. Takaoka
57f7de0ba6 Add default capacity parameter to InputPointers' constructor 
Change-Id: I02f23096f0682d30effe4dfc1ca57881a1e4aedc
 2012-07-19 12:06:00 +09:00
Tadashi G. Takaoka
9580c467f9 Consolidate GestureTracker into PointerTracker 
Change-Id: Ib28fae10493a9142ba4dff6cf57f52c59766b209
 2012-07-18 20:11:06 +09:00
Tadashi G. Takaoka
10102f02af Change the batch input methods of KeyboardActionListener 
This change also removes the reference of SuggestedWords from
GestureTracker and KeyboardActionListener.

Change-Id: I25ef8756007986abf99a931afd665bbfe6fa387f
 2012-07-18 18:53:36 +09:00
Kurt Partridge
5e53542489 Merge "delete old ResearchLog files" 2012-07-16 09:41:10 -07:00
Kurt Partridge
81dae8d015 delete old ResearchLog files 
cleans out the local directory of files that may have persisted
accidentally because of system crashes, etc.  default lifetime is
curently 1 day.

Bug: 6188932
Change-Id: I4b51169d6dd0eddb6bf8b661165f88e63782ce7d
 2012-07-13 20:25:38 -07:00
Kurt Partridge
73c5dbd9d2 researchLog records versionCode, versionName 
Bug: 6188932
Change-Id: I3d8502a5397035be5287ea720599e3fda4c669d6
 2012-07-13 20:21:18 -07:00
Tom Ouyang
eea34598bf Merging minimal gesture input 
Change-Id: Iee6ae48bb6309c2867b5d2e344fe7d86dfabd654
 2012-07-13 19:32:18 +09:00
Jean Chalard
e9808694fe Fix a bug where the word composer is not correctly reset 
...upon commit

Change-Id: I1fea87cb4c133a0884329eb9b61bf3053c36cd1b
 2012-07-13 13:31:27 +09:00
Tadashi G. Takaoka
7247bff6d6 Fix InputPointers.append 
Change-Id: I6995f9b2ed00b9f948e1299e576a5e24725d58f8
 2012-07-13 11:46:03 +09:00
Jean Chalard
c7387a4fd0 Add values for suggestion types (A120) 
Also, use it in getBigrams.

Change-Id: Ia0be9b57d1b7effcd8a936e01e957d1195b39c68
 2012-07-12 19:21:44 +09:00
Jean Chalard
6931df9c17 Pass an array to output suggestion types (A119a) 
This needs the matching A119b change to not break the build.
The array is passed, but not used yet.

Bug: 6166228
Change-Id: Ia91d658461d989ee8c94e9b31bb06f4a36f4c5b6
 2012-07-12 19:21:42 +09:00
Jean Chalard
2c5cf744e5 Increase encapsulation (A118) 
showSuggestions is only ever called by updateSuggestionsOrPredictions.
It only feels natural that, when called with a 0-sized or null
suggestion list, it clears the suggestions.

Change-Id: I5b52bc9151afca1bb6c6f0a7f81e3255add92177
 2012-07-12 15:58:16 +09:00
Jean Chalard
1343d27de3 Readability improvement (A117) 
Change-Id: I6f8bb05a23edb40a079da60b7136170ec9043282
 2012-07-12 15:58:16 +09:00
Jean Chalard
24a63b5537 Simplification (A116) 
Change-Id: I97cf92a7b0dabc251dd241b24978ea00d1e5f047
 2012-07-12 15:58:16 +09:00
Jean Chalard
f5b55cb70c Compute variables closer to where they are used (A115) 
This improves locality, it's better for readability/performance

Change-Id: Ibb1efaf86e362dd2c9398722d0da2144df96b333
 2012-07-12 15:58:09 +09:00
Jean Chalard
2549b4978e Cleanup (A114) 
Change-Id: I7e24e0aeae7c004cae310ae9f46cf90dac2d4d14
 2012-07-12 15:09:57 +09:00
Jean Chalard
02f1c1534c Cleanup (A113) 
If not composing a word, then consideredWord is always the empty
string.
Hence, it's never whitelisted, but it's also always "NotAWord",
so isWhitelistedOrNotAWord returns always true, so
allowsToBeAutoCorrected is always true. Which means that
isPrediction implies allowsToBeAutoCorrected == true.
Thus, !isPrediction && !allowsToBeAutoCorrected is strictly
equivalent to !allowsToBeAutocorrected.

Change-Id: I4ad7a7c3447851c539646d97cf55ff065e6ee115
 2012-07-12 15:09:48 +09:00
Jean Chalard
ae13061245 Simplification (A112) 
If we are not composing a word, that isFirstCharCapitalized
and isAllUpperCase are guaranteed to return false.

Change-Id: Ic4a0be9574acf4653c729a9594f963f5bcf0c757
 2012-07-12 14:30:33 +09:00
Jean Chalard
d8afa2fbe1 Remove the ultimate code duplication (A111) 
Change-Id: I7c76613df8f148feb02765f187db3ca6dc577977
 2012-07-12 14:30:33 +09:00
Jean Chalard
3b57631b60 Resolve a TODO: bury some implementation detail in native (A110) 
The fact that prediction does not accept a null argument is an
implementation detail, it should not be visible to Java code.

Change-Id: I3a156b323b6db9353de898d33f3f7c81751cecb1
 2012-07-12 14:30:30 +09:00
Jean Chalard
18d76afa91 Remove an unused method (A109) 
Change-Id: Ib785b7e8c554d030395e2c0ca92edb44eb2b245f
 2012-07-12 14:30:03 +09:00
Jean Chalard
251f302985 Stop using a redundant method (A108) 
Change-Id: Iffc0bae0a273419e7c50d69526c0c8e402c6461c
 2012-07-12 14:30:00 +09:00
Jean Chalard
6a5d17cd2f Remove a useless parameter (A106) 
Change-Id: Ic0ecea22212fd1a098a3a168da460374e446f4a3
 2012-07-12 11:28:16 +09:00
Jean Chalard
b7d7c5a369 Make a constant really constant (A104) 
Change-Id: Ied1f9f96a574b1e6a8ee0a71bfb1604d9c962e1c
 2012-07-12 11:16:30 +09:00
Jean Chalard
e4e7e5fc82 Cleanup (A103) 
Change-Id: Ib5ebddfdb87ef71a2f8d859fb45d3ac78040e97a
 2012-07-11 16:14:58 +09:00
Tadashi Takaoka
5e21ea1a35 Revert "Workaround to avoid a bug in the batch input bigram dictionary lookup" 
This reverts commit 1250cdeab2
 2012-07-11 00:07:08 -07:00
Tadashi G. Takaoka
1250cdeab2 Workaround to avoid a bug in the batch input bigram dictionary lookup 
Change-Id: I8a5641c88c45918d6bed81a0b03efdcff0b380c5
 2012-07-11 15:38:13 +09:00
Jean Chalard
9c09fd02eb Inline a method to be able to factorize code (A102) 
Change-Id: I121071f80c8af3c1053968dc76aaeca3352ca9a8
 2012-07-11 14:57:51 +09:00
Jean Chalard
d6c610400e Inline a wrapper method (A101) 
Change-Id: I6ce856ff49a8f8c696851b2487590704010fc758
 2012-07-11 14:57:51 +09:00
Tadashi G. Takaoka
eb1443883f Support batch input 
Change-Id: Ibe63212fe71cdebb5b897bc5018ae75b2a87555a
 2012-07-11 14:53:20 +09:00
Jean Chalard
21e5759e8e Merge "Small readability improvement (A100)" 2012-07-10 22:49:25 -07:00
Jean Chalard
27207eaa04 Merge "Pull up some common code again (A99)" 2012-07-10 22:49:06 -07:00
Jean Chalard
722b00275d Merge "Pull up some identical code (A98)" 2012-07-10 22:48:58 -07:00
Jean Chalard
8b166465b0 Merge "Inline a method to avoid confusion (A97)" 2012-07-10 22:48:52 -07:00
Jean Chalard
fd9b485111 Merge "Remove parameters for easier inlining (A96)" 2012-07-10 22:48:44 -07:00
Jean Chalard
0b329fd0d1 Merge "Pull up some more common code (A95)" 2012-07-10 22:48:38 -07:00
Jean Chalard
a5acd68caa Merge "Pull up common code in the caller (A94)" 2012-07-10 22:48:33 -07:00
Kurt Partridge
0d54692ce4 Merge "intentional logging" 2012-07-10 21:20:47 -07:00
Jean Chalard
82d5ed6fcd Small readability improvement (A100) 
Change-Id: I6340748654a95d203ed43ceb9a7e6468b5b8ab1c
 2012-07-11 11:19:50 +09:00
Jean Chalard
860a9f85ff Pull up some common code again (A99) 
Change-Id: I9e9f5664bb12bb25d74c8a076a6ee1024c708145
 2012-07-11 11:19:50 +09:00
Jean Chalard
8eaeb60e7f Pull up some identical code (A98) 
Change-Id: I6c265956394cf49e74b0256dfa5af06fe6b30467
 2012-07-11 11:19:33 +09:00
Jean Chalard
e77f2996ea Inline a method to avoid confusion (A97) 
Change-Id: I3c3ffcd3d40493f4bfa0f6596f923b3430e605aa
 2012-07-11 11:19:18 +09:00
Jean Chalard
cfae32c610 Remove parameters for easier inlining (A96) 
Change-Id: Ied2e291393609300173681e26e82b7dd36b41bd0
 2012-07-11 11:16:22 +09:00
Jean Chalard
ea98e026f1 Pull up some more common code (A95) 
Change-Id: I3ac7ee823471a6d1da8031e064bce38b0e5a8f5c
 2012-07-11 11:15:18 +09:00
Jean Chalard
b4b93dbf3e Pull up common code in the caller (A94) 
Change-Id: I84b97886280eca75d5f2b7546f20f8b1bced55bc
 2012-07-11 11:13:56 +09:00
Kurt Partridge
223d671ffc intentional logging 
- separate ResearchLog from ResearchLogger
- fix abort menu to explicitly indicate re-enabling of logging
- auto flush entries every 5s
- conform to new suggestedWords class

multi-project change with I9fe1f8fe59d5891daa4ca84af157f36fb1bb17dc

Bug: 6188932

Change-Id: I7e99390f934481c6ed9cea2b259944583edda5bb
 2012-07-10 18:44:18 -07:00
Jean Chalard
6f233f7ba1 Remove useless member variables (A93) 
Change-Id: Iff0a0e8835f4d630b51a15c0d91881437094e785
 2012-07-10 20:18:10 +09:00
Jean Chalard
2ae75ed56b Start converging two identical methods (A92) 
Change-Id: I3c85a80610fde664a328f5606d0724f00d445ebe
 2012-07-10 20:13:54 +09:00
Tadashi G. Takaoka
d82dcdc924 Add batch input dictionary lookup 
Change-Id: I4da3c976838e8eb56c9ec80aafaaf54d759b7981
 2012-07-10 20:01:28 +09:00
Jean Chalard
5e573a1f0a Remove a useless parameter (A91A) 
Change-Id: I1d1758048649ef337875a5141d825569af7ad38c
 2012-07-10 19:31:36 +09:00
Jean Chalard
f5943153ad Cleanup old methods (A90) 
Change-Id: I5435cef8ac6be523934ffa394952cb120c8e89d6
 2012-07-10 19:30:46 +09:00
Jean Chalard
b30d2185f2 Implement the common Dictionary interface (A89) 
This will de-duplicate a lot of existing code.

Change-Id: Idaffb2fde23b9741f057bcb2ecb3dde9d12ea5c5
 2012-07-10 19:30:42 +09:00
Jean Chalard
a69f12a246 Reduce method visibility (A88) 
Change-Id: I29d6afbcba0998558c9b19287a460d9f0e410994
 2012-07-10 19:19:47 +09:00
Jean Chalard
0f57bdc0e5 Factorize code (A87) 
Why was this copy-pasted :(

Change-Id: I6a537c56425ad039d7301a5fe1e0485784f07914
 2012-07-10 19:19:43 +09:00
Jean Chalard
4e42e378fa Move stuff around for readability (A86) 
Change-Id: I5f4a18e43f3012acf96978d625325bf7c69c9c80
 2012-07-10 18:57:57 +09:00
Jean Chalard
82009901ea Add a consolidated method to the Dictionary interface (A85) 
Change-Id: I5d79021e69cc738e3013e31764ab0a59e15decdf
 2012-07-10 18:57:12 +09:00
Jean Chalard
2a37fb9d30 Refresh the cached single quotes count on commit 
Change-Id: I9df5cf95c14da2e11ac709ca5e32dc7db3b02c37
 2012-07-10 18:43:42 +09:00
Jean Chalard
a9632d8173 Merge "Enhance behavior consistency (A84)" 2012-07-10 02:31:40 -07:00
Jean Chalard
184c552917 Merge "Refactoring for whitelist (A83)" 2012-07-10 02:24:58 -07:00
Jean Chalard
b53e96813c Merge "Refactoring (A82)" 2012-07-10 02:24:47 -07:00
Jean Chalard
50d1b7902f Merge "Fix a bug with suggestion behavior (A81)" 2012-07-10 02:24:36 -07:00
Jean Chalard
a4d346c37a Merge "Cleanup visibility in LatinIME (A80)" 2012-07-10 02:21:46 -07:00
Jean Chalard
c677b0071d Enhance behavior consistency (A84) 
Use the word the same way for suggestion and prediction. It makes
little logical sense that the trailing single quotes be removed
for suggestion lookup but not for prediction lookup.

Change-Id: I0de4b5f7c5b4c1b4ba1817ff9653d7c03967146d
 2012-07-10 18:05:20 +09:00
Jean Chalard
1c6693a219 Refactoring for whitelist (A83) 
Avoid special casing the whitelist dictionary by having it implement
the interface it pretends it implements

Change-Id: I8b873cb0f3fe13cefd32c8cb756a25c8ae16a2b4
 2012-07-10 18:05:20 +09:00
Jean Chalard
fb6eeeb35a Refactoring (A82) 
The user history dictionary should be the one knowing it does not suggest words
beyond 2 characters, not Suggest.

Change-Id: Ie85ec6116eb495e0c7f51108e4620c5ae536f4bf
 2012-07-10 18:05:20 +09:00
Jean Chalard
966efe4889 Fix a bug with suggestion behavior (A81) 
Bug: 6788235
Change-Id: I5a4212872e0fd3f9e80168fd3abd5c2b3bc4110f
 2012-07-10 18:05:19 +09:00
Jean Chalard
a5bb353de9 Cleanup visibility in LatinIME (A80) 
Many methods were public but could have been private: change them
to private. Also, add a comment above public methods that don't
come from the IMF to make it clearer why they are necessary.

Change-Id: I574154b015d09c0f8542b81763f497691afdc3c1
 2012-07-10 18:05:15 +09:00
Satoshi Kataoka
7fcad7b9b6 Separate ICS-dependent code from the spell checker service 
Bug: 6789576
Change-Id: Ia768258f6fa121c7a7757093eb8a20e665580865
 2012-07-10 17:45:26 +09:00
Jean Chalard
b98414f8fd Merge "Remove useless code (A79)" 2012-07-10 00:47:56 -07:00
Jean Chalard
29540b25f0 Merge "Simplification (A78)" 2012-07-10 00:47:10 -07:00
Jean Chalard
728c0cb251 Remove useless code (A79) 
We postUpdateSuggestionStrip right away anyway - this only
makes the suggestion strip blink

Change-Id: I2ebd933e9a4c804ef1e8c62ccdaf4953a98a792e
 2012-07-10 16:41:49 +09:00
Jean Chalard
09fdd30e52 Simplification (A78) 
Change-Id: I622503af858ef419e94a17f182253cb03da00462
 2012-07-10 16:41:47 +09:00
Satoshi Kataoka
74620f449e Merge "Create AndroidSpellCheckerSessionFactory" 2012-07-10 00:26:00 -07:00
Satoshi Kataoka
37b19ffe6c Create AndroidSpellCheckerSessionFactory 
Bug: 6789576
Change-Id: I6de1e1aa64cf14f38ecb250579418bc518f0d838
 2012-07-10 16:16:53 +09:00
Satoshi Kataoka
759778a751 Merge "Separate SpellCheckerSession from SpellCheckerService" 2012-07-09 23:42:15 -07:00
Satoshi Kataoka
84ed096641 Separate SpellCheckerSession from SpellCheckerService 
Bug: 6789576
Change-Id: I7c55d36afad7ef6046353b3c9e849a54a6dc83ae
 2012-07-10 15:34:40 +09:00
Jean Chalard
fed702a0ad Merge "Move a test (A77)" 2012-07-09 23:01:33 -07:00
Jean Chalard
75e605f7ca Merge "Pull up common code in the consolidated method (A76)" 2012-07-09 22:41:33 -07:00
Jean Chalard
c466cd3f99 Move a test (A77) 
Change-Id: I417bd5f1318696aaa39fee18f3e750ea5c231f6b
 2012-07-10 14:24:33 +09:00
Jean Chalard
32f5384fc9 Pull up common code in the consolidated method (A76) 
Change-Id: I3ebecec37b49e139c243cf9da8bfe491e7ddada1
 2012-07-10 14:22:12 +09:00
Tadashi G. Takaoka
80973dc76f Merge "A little optimization of InputPointers.copy" 2012-07-09 21:09:13 -07:00
Tadashi G. Takaoka
2ad6d12a30 A little optimization of InputPointers.copy 
Change-Id: Id83b34e076ef91e06d7c1dd2b3ee7bb64d01b8cb
 2012-07-10 13:05:43 +09:00
Jean Chalard
24e8a06f98 am 949d2ae5: am 4bcf70c9: Fix a bad interaction with mmap 
* commit '949d2ae5788977c5e87e35e1bd1770f54ac88f5b':
  Fix a bad interaction with mmap
 2012-07-09 20:24:01 -07:00
Tadashi G. Takaoka
7389c601e3 Merge "Add InputPointers.append() method" 2012-07-09 01:39:38 -07:00
Tadashi G. Takaoka
1087c53f5a Add InputPointers.append() method 
Change-Id: Id2b0e242f7e9ce0ca888067857f8b64c02fde84e
 2012-07-09 17:33:10 +09:00
Jean Chalard
e4498929b0 Simple refactoring (A75) 
Change-Id: Id19efc5d279616da52667fa70326b86aba70d4a0
 2012-07-09 15:06:16 +09:00
Jean Chalard
d579f1aefc Consolidate methods that do the same thing (A74) 
Change-Id: I6e7c3aba2b40ecefa483c9680978bc806368e96e
 2012-07-09 15:06:16 +09:00
Jean Chalard
347a80f793 Tiny refactoring (A73) 
If !mWordComposer.isComposingWord(), then mWordComposer.getTypedWord()
will always return an empty string.

Change-Id: Ife66d0abc44c743cbc30d31724e833cda168fd5c
 2012-07-09 15:06:16 +09:00
Jean Chalard
7a422a0142 Cleanup again (A72) 
Change-Id: Id3765bf9826cc2c7ca70158cda53c75dc58f51c6
 2012-07-09 15:06:16 +09:00
Jean Chalard
37eaa24b5a Simplification (A71) 
Change-Id: I7a91d84291bea581ecc8ec5b29b9a87ccec76e7d
 2012-07-09 15:06:16 +09:00
Jean Chalard
dc1b84d96c Defer testing composition to a later time (A70) 
This is not exactly the same logically speaking, because it's
theoretically possible that the composing state changed in between
the message enqueueing and it's retrieval. However in the practice,
if the composing state changed the message *must* have been
cancelled and resent, else the behavior breaks. So this actually
is more robust, and removes some obscure requirements on the
calling code.

In the practice, it should also make the cancelUpdateSuggestionStrip
message useless, although this change does not yet remove it.

Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
 2012-07-09 15:06:16 +09:00
Jean Chalard
a6757f400a Code simplification (A69) 
Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
 2012-07-09 15:06:16 +09:00
Jean Chalard
8f9c9377fc Consolidate two methods (A68) 
Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
 2012-07-09 15:06:15 +09:00
Jean Chalard
146bd2e456 Pass the value we really want to pass to update functions (A67) 
Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
 2012-07-09 15:06:15 +09:00
Jean Chalard
60dbe0be43 Preparative change to pass a boolean with known value (A66) 
Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
 2012-07-09 15:06:15 +09:00
Jean Chalard
853f4221ab Merge "Remove useless processing (A65)" 2012-07-08 23:05:11 -07:00
Tadashi G. Takaoka
6b4ce58fc6 Remove unused WordComposer.init method 
Change-Id: I46c6a6e1c1536599cb909bf81297001b238f2ec8
 2012-07-06 20:12:14 +09:00
Tadashi G. Takaoka
36311cacd6 Merge "Extend onTextInput to be able to inject suggestions" 2012-07-06 03:40:03 -07:00
Tadashi G. Takaoka
4be03befe3 Extend onTextInput to be able to inject suggestions 
Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
 2012-07-06 19:36:11 +09:00
Jean Chalard
a3dee0d062 Merge "Fix a bug where spaces would be forgotten" 2012-07-06 02:09:28 -07:00
Jean Chalard
4fde56b818 Fix a bug where spaces would be forgotten 
Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
 2012-07-06 17:51:10 +09:00
Jean Chalard
8e36e5102e Remove useless processing (A65) 
We just resetted the composing state - updating suggestions
is sure to yield no results. We may as well not call
updateSuggestions at all.
We should however still cancel any lingering timer from a
previous input field, to avoid this useless processing.

Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
 2012-07-06 16:28:42 +09:00
Jean Chalard
449be371ae Refinement (A64) 
Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
 2012-07-06 16:28:42 +09:00
Jean Chalard
43193ad60f Remove useless code (A63) 
If the separator is not a space, then we will always call
setPunctuationSuggestions and reset the suggestion strip anyway.
If the separator is a space, then the cursor has a space on
the left, which means isCursorTouchingWord depends only on
whether it touches a word on the right. If we were displaying
the "add to dictionary hint", it means a suggestion was just
chosen, so it had to be displayed, and that requires a composing
word and no non-separator at the right of the cursor.

In the end, if we go through this postUpdateSuggestions call,
we are sure we will reset the suggestions later in this method,
either by calling postUpdateBigramPredictions, or
setPunctuationSuggestions.

Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
 2012-07-06 16:28:42 +09:00
Jean Chalard
8ba33c1a49 Simplification (A62) 
Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
 2012-07-06 16:27:55 +09:00
Jean Chalard
66a2e96fb4 Remove useless code (A61) 
Just after this, clear() will be called, removing the suggestion
strip from the screen. It will later be displayed again through
onStartInputView, which will update its content.

Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
 2012-07-06 13:07:48 +09:00
Jean Chalard
b1dc8ad5f2 Simplification (A60) 
Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
 2012-07-06 13:07:48 +09:00
Jean Chalard
663dbfd1cc Simplification & UI improvement (A59) 
The responsivity is better like this. This does not seem to
feel slow as the previous comment seemed to indicate.

Also remove a stale comment.

Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
 2012-07-06 13:07:48 +09:00
Jean Chalard
746e014eb5 Show predictions in the right cases (A58) 
After reverting an auto-correct we always have a separator after
the previously inserted word, and the cursor is never touching
a word. Showing predictions is the right thing to do, while
calling postUpdateSuggestions will invariably yield an invariably
blank suggestion strip, which is not very helpful.

Likewise, after we pick a suggestion, we should be showing the
predictions unless showing the addToDictionary hint. There was
a bug here in the corner case that the word would be a candidate
for user dictionary, but the user dictionary provider is not
available: in this case we should be showing predictions, but
we were showing an unhelpful empty suggestion bar.

Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
 2012-07-06 13:07:48 +09:00
Jean Chalard
0e9e7e337d Cleanup (A57) 
We stopped cancelling manual picks a few weeks ago. This code
is dead.

Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
 2012-07-06 13:07:30 +09:00
Jean Chalard
29eeef75ec Merge "Fix a bug where the caps mode would not be changed" 2012-07-05 19:11:28 -07:00
Jean Chalard
f254e3fec7 Fix a bug where the caps mode would not be changed 
Bug: 6766059
Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
 2012-07-06 11:08:20 +09:00
Jean Chalard
d81e7d24d3 Simplification (A56) 
If suggestion and prediction messages both happen to be in
the queue, the latest one will win (update the suggestion strip
later than the other, overwriting any previous suggestions).
So when we enqueue either one, it is always safe to cancel
all messages of both types.

Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
 2012-07-05 18:19:51 +09:00
Jean Chalard
414f14436e Remove an unused method (A55) 
Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
 2012-07-05 18:10:37 +09:00
Jean Chalard
c84f178cd9 Merge "Remove a useless method, rename another. (A54)" 2012-07-05 02:05:50 -07:00
Tadashi G. Takaoka
92d2f7e03b Merge "Initialize SubtypeLocale from Settings" 2012-07-05 02:04:35 -07:00
Jean Chalard
792e7ddc24 Merge "Remove a redundant test (A53)" 2012-07-05 01:57:04 -07:00
Jean Chalard
9636735c0a Merge "Small simplification (A52)" 2012-07-05 01:56:55 -07:00
Jean Chalard
21524c755c Merge "Put some more code in common (A51)" 2012-07-05 01:50:44 -07:00
Jean Chalard
71d7fc91b7 Merge "Pull up a common variable into the wrapping method (A50)" 2012-07-05 01:47:59 -07:00
Jean Chalard
ac3ad6ef9f Merge "Factorize some common code (A49)" 2012-07-05 01:45:08 -07:00
Tadashi G. Takaoka
d6ac0443f0 Initialize SubtypeLocale from Settings 
Bug: 6781106
Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
 2012-07-05 17:39:30 +09:00
Tadashi G. Takaoka
15d3532170 Merge "Fix tab key's navigation behavior" 2012-07-05 01:24:00 -07:00
Jean Chalard
3d8e7a62fc Remove a useless method, rename another. (A54) 
Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
 2012-07-05 17:22:15 +09:00
Jean Chalard
0783366036 Remove a redundant test (A53) 
Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
 2012-07-05 17:22:04 +09:00
Jean Chalard
4cba560dbb Small simplification (A52) 
Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
 2012-07-05 17:22:00 +09:00
Jean Chalard
ea80794dd4 Put some more code in common (A51) 
Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
 2012-07-05 17:21:55 +09:00
Jean Chalard
cbfd2e1fdb Pull up a common variable into the wrapping method (A50) 
Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
 2012-07-05 17:21:51 +09:00
Jean Chalard
7ed22f1f72 Factorize some common code (A49) 
Also add some comment to clarify what's happening inside those
methods

Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
 2012-07-05 17:21:44 +09:00
Tadashi G. Takaoka
b28934adac Fix tab key's navigation behavior 
Bug: 6435484
Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
 2012-07-05 16:57:14 +09:00
Jean Chalard
e47c728dd5 Add a wrapper to updateSuggestions / Predictions (A48) 
The goal is to have those converge, as they contain almost 100%
duplicated code.

Change-Id: I6921791d47efce9fb396efd9626839d706664a91
 2012-07-05 11:10:04 +09:00
Jean Chalard
7b40c68277 Refactoring which will help with future changes (A47) 
Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
 2012-07-05 11:10:02 +09:00
Jean Chalard
e9a86e2cdb Search bigrams for the lower case version of the word (A46) 
...if there aren't any for the exact case version.

Bug: 6752830
Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
 2012-07-04 20:12:58 +09:00
Jean Chalard
4bcf70c931 Fix a bad interaction with mmap 
Bug: 6761221
Change-Id: I7e6d98dc9d7cb34a6163c3957e401ff97abb975c
 2012-07-04 17:57:06 +09:00
Tadashi G. Takaoka
ac3bd96192 Merge "Remove WordComposer.add(int, int, int, KeyDetector) method" 2012-07-04 01:48:42 -07:00
Tadashi G. Takaoka
5c641a9f59 Remove WordComposer.add(int, int, int, KeyDetector) method 
Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
 2012-07-04 17:29:47 +09:00
Tadashi G. Takaoka
5c98206dc5 Merge "Use Keyboard.getKey" 2012-07-04 01:12:02 -07:00
Tadashi G. Takaoka
adc80eef15 Use Keyboard.getKey 
Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
 2012-07-04 16:31:57 +09:00
Tadashi G. Takaoka
040aa28ed4 Merge "Get rid of redundant CharSequence member from SuggestedWordInfo" 2012-07-04 00:27:07 -07:00
Tadashi G. Takaoka
f3897fb54e Get rid of redundant CharSequence member from SuggestedWordInfo 
Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
 2012-07-04 16:04:59 +09:00
Jean Chalard
c5e911c06b Consolidate a method inside another (A45) 
It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.

This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.

Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
 2012-07-04 11:51:51 +09:00
Jean Chalard
f72b8f5662 Move the safety net function to AutoCorrection (A44) 
Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
 2012-07-04 11:51:46 +09:00
Jean Chalard
accd63f35f Merge "Refactoring (A43)" 2012-07-03 19:40:19 -07:00
Jean Chalard
b87b23eb75 Merge "Remove useless code (A42)" 2012-07-02 18:56:41 -07:00
Jean Chalard
6547f43666 Merge "Clarify some code and fix a bug (A41)" 2012-07-02 18:52:56 -07:00
Jean Chalard
d6496c0913 Merge "Fix a bug with the user dictionary locale." 2012-07-02 02:57:50 -07:00
Jean Chalard
d113fd0be4 Fix a bug with the user dictionary locale. 
We internally use the string "zz" to mean no locale, but
the user dictionary service does not understand that and
words added with this locale pitifully end being added to
a "zz" user dictionary, which makes no sense to the user.
This change fixes things so that words added when the
keyboard is in a "no locale" layout, the words are added
to the global, all-locales user dictionary.

Bug: 6645306
Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
 2012-07-02 17:14:47 +09:00
Jean Chalard
4ca05e2474 Refactoring (A43) 
Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
 2012-07-02 15:46:11 +09:00
Jean Chalard
7ad088a4cf Remove useless code (A42) 
If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !

Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>

Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
 2012-07-02 15:46:08 +09:00
Jean Chalard
90d300c770 Clarify some code and fix a bug (A41) 
The test against hasMainDictionary is a test to know if we should
auto-correct or not. Its result should be recorded in
hasAutoCorrection, not in allowsToBeAutoCorrected.

Actually, this value being inserted in allowsToBeAutoCorrected was
causing a bug that nobody noticed: when typing in a language with
no dictionary, the word in the middle of the suggestion strip would
always be bold, as if it was going to auto-correct to itself !
This change fixes this bug.

Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
 2012-07-02 15:46:03 +09:00
Jean Chalard
2631e3b195 Small refactoring (A39) 
Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea
 2012-07-02 15:45:58 +09:00
Jean Chalard
79f5317848 Match calls for future consolidation (A38) 
Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9
 2012-07-02 15:45:54 +09:00
Jean Chalard
cd288620ea Make the autocorrection scheme more straightforward (A37) 
Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd
 2012-07-02 15:45:34 +09:00
Jean Chalard
aba432bf8d Remove a duplicate method (A36) 
Bug: 6705473
Change-Id: Ib6260034b09739b60071e90a018b2dc6be3815d7
 2012-07-02 12:12:16 +09:00
Jean Chalard
84074cf503 Update log and make a variable private (A35). 
Change-Id: Ib4a8f41dc5941bce46402e1a41a6c21dccb0601f
 2012-07-02 12:11:27 +09:00
Jean Chalard
1842fbba93 Remove old debug code that has been long broken (A34) 
Change-Id: I9b5a0e34529724984aad1e2bf99b3e00f8ed0dd7
 2012-06-29 19:47:00 +09:00
Satoshi Kataoka
105069a15f Merge "Add input pointers" 2012-06-29 03:03:01 -07:00
Satoshi Kataoka
71538b08e4 Add input pointers 
Change-Id: I95300bf0a847fb86d026e846ff4ad723bb45284f
 2012-06-29 18:58:51 +09:00
Jean Chalard
1b2e2d893d Add a more synthetic variable (A33) 
The goal here is to disambiguate TypedWordValid and
HasAutoCorrectionCandidate. Ultimately, HasAutoCorrectionCandidate
will disappear.

Bug: 6705473
Change-Id: I1acbd0a5efc7f4bf7b0bdb12839fe3d84e9d1dda
 2012-06-29 17:00:57 +09:00
Jean Chalard
9011b89f4e Remove cruft (A32) 
Change-Id: I35c2ba4caf6be4ba0449e11c0597ae8e468c0e6e
 2012-06-29 17:00:57 +09:00
Jean Chalard
2cda148fd5 Simplification (A31) 
Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
 2012-06-29 17:00:57 +09:00
Jean Chalard
deb2d88245 Small refactoring (A30) 
Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
 2012-06-29 17:00:57 +09:00
Jean Chalard
0a63111821 Remove a useless parameter (A29) 
Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
 2012-06-29 17:00:56 +09:00
Jean Chalard
4f444410f2 Remove a useless variable (A28) 
Change-Id: I1058123d233540fb72a94028987a43740224f635
 2012-06-29 17:00:56 +09:00
Jean Chalard
f4267c0521 Fix a small bug (A27) 
TypedWordValid and AllowsToBeAutoCorrected are almost the
same thing; the difference is whether the word is also a
whitelist entry or not. In this case, TypedWordValid was
the right one to test.

Change-Id: I695fe5b9f6bbe9d3ba314c646da3a25742c9f4ed
 2012-06-29 17:00:56 +09:00
Jean Chalard
9e0af57736 Optimization (A26) 
Change-Id: I1d7790289635729645995fb8c38868259ab1b3be
 2012-06-29 17:00:56 +09:00
Jean Chalard
7a94cbd2a4 Remove useless code (A25) 
isWhitelistedOrNotAWord takes an 'ignoreCase' argument. By looking
at the contents of the wordcomposer here, there is only one case
where its output will be different : when the word is typed with a
capital, but the lower case version exists in the dictionary.
E.g. the user typed "This".

In this case, isWhitelistedOrNotAWord in line 235 will return false
instead of true, so the test will score a true instead of a false,
so hasAutoCorrection may be true instead of false in this specific
case and that's the only case where it's different.

But in this case, allowsToBeAutoCorrected is certain to be false,
which means the result will not have changed if hasAutoCorrection
was true in the first place. So in the end this change is sure not
to change the behavior.

Change-Id: Ic41cf959c20c19165f84d9b8ff006731fa595d84
 2012-06-29 16:57:56 +09:00
Jean Chalard
b3cfde2cbb Add a few comments for future reference (A24) 
Change-Id: Ia356130b8a95ec9cf676bc6be05d801c13f14b64
 2012-06-29 15:45:27 +09:00
Jean Chalard
e398c6c024 Rename a method for readability (A23) 
Change-Id: I6f569322e645d36bc82fddf4ec2fd621972e3b47
 2012-06-29 15:45:24 +09:00
Jean Chalard
ea578f6b1d Revert a test for readability (A22) 
Change-Id: I1df4cef5ae2736a22273843dce67f0012181bfd3
 2012-06-29 15:44:55 +09:00
Jean Chalard
19d02c19d0 Remove a useless variable (A21) 
Change-Id: I901e6b0e2b994128da19d68233b9f68bb308cb95
 2012-06-29 15:44:17 +09:00
Jean Chalard
4d5e7235c5 Remove a useless variable (A20) 
Change-Id: Ifc37462f5243563693c8cd7cbeb401ff054daa52
 2012-06-29 15:12:51 +09:00
Jean Chalard
739683dcfb Rename a method for readability (A19) 
Change-Id: I0b8c06d1fd0bfb3caf363c048acc7048abed1752
 2012-06-29 15:12:51 +09:00
Jean Chalard
31b346aac6 Remove a useless test (A18) 
allowsToBeAutoCorrected always returns false if the word is empty.
This is because the whitelist never contains an empty string,
and isValidWord returns false if the word is empty.

Change-Id: I34ecc2a1563aea6db5b2f12796f251f6598576a2
 2012-06-29 15:12:51 +09:00
Jean Chalard
b01cdb975a Inline a method (A17) 
This will allow us to remove unnecessary processing

Change-Id: I251dfdaffb077906186686ebe65fd82e1e360bd2
 2012-06-29 15:12:51 +09:00
Jean Chalard
42dde06782 Make a function a one-liner (A16) 
...to better inline it

Change-Id: I88496b8f18b81f0c05e4bbf2d1039de1f93e0c25
 2012-06-29 15:12:51 +09:00
Jean Chalard
a96a11949f Inline a simple method (A15) 
Change-Id: Ib74fcbf33c680bf02c39a9896e30e3afbcfd149a
 2012-06-29 15:12:51 +09:00
Jean Chalard
074c90af98 Inline a method (A14) 
The new code is worse than the old one, but this is a necessary
step to make things prettier.

Change-Id: If6e8a139bb85e6920c749743c78792a22a8acb45
 2012-06-29 15:12:51 +09:00
Jean Chalard
1333579b4b Don't special-case 1-letter words (A13) 
There is no reason to prevent 1-letter words to auto-correct
to themselves, or to dictionary words. Don't do it.

Change-Id: Iceada847ae632336026ada29afed0353cd9c51b5
 2012-06-29 15:12:51 +09:00
Jean Chalard
d426941ee8 Fix a theoretical bug (A12) 
If a word is a dictionary word but still has no suggestion,
this method should return true. In the practice, it makes
no difference since a word without suggestion won't be changed
anyway.

Change-Id: Ib1f5ef254b7da7e5cedb2f973529ad431beb93f9
 2012-06-29 15:12:51 +09:00
Jean Chalard
9701b360d9 Rename a terribly-named method for clarity (A11) 
Change-Id: Id180000404dc6929d80f98c0e9cd2026230ad2d1
 2012-06-29 15:12:50 +09:00
Jean Chalard
6b911c27a3 Merge "Small readability improvement (A10)" 2012-06-28 23:11:23 -07:00
Jean Chalard
f89a75134b Small readability improvement (A10) 
Change-Id: Iba326921711e1c4eab38264e66b6b44a64fec398
 2012-06-29 15:05:08 +09:00
Jean Chalard
305326e789 Refactoring and add debug prints (A9) 
Change-Id: I46497bff107f0def0dfa2b043b20d9a0b0cde040
 2012-06-29 14:24:54 +09:00
Jean Chalard
5110e2cb51 Optimization (A8) 
Change-Id: I2b9e8cc6a13fd9af84a5189e4d3fbb2b05c68d46
 2012-06-29 12:54:11 +09:00
Jean Chalard
4847a27f74 Cleanup (A7) 
Change-Id: Iba97e0062b702c005ab3ff9ce59f181d19ab7c98
 2012-06-28 19:13:16 +09:00
Jean Chalard
ed83d4b143 Stop special-casing a single suggestion (A6) 
Treat it like the others

Change-Id: Ic24e40ada0e75773c3ece9470ab61c350697be5d
 2012-06-28 19:12:37 +09:00
Jean Chalard
251bb70f08 Cleanup (A5) 
Change-Id: I06134145b47c46bbc6c340ca539f34a01e2ca163
 2012-06-28 19:12:37 +09:00
Jean Chalard
4c4e3a0949 Transform the whitelist suggestion like the others (A4) 
...instead of having a different code path

Change-Id: Icd177e2151e45d25300000d4b63d4fba1f52b6a8
 2012-06-28 19:10:32 +09:00
Jean Chalard
33b3805e79 Small refactoring (A3) 
This will help make upcoming changes clearer

Change-Id: Ida8d4935f7315e5da6007ad364124694da3112d0
 2012-06-28 19:10:24 +09:00
Jean Chalard
b7cdafd78a Don't pass everything to a function that needs only the head (A2) 
Change-Id: Ic367836202ab8071c1a9a02eaf0651b0da947d51
 2012-06-28 19:10:13 +09:00
Jean Chalard
09b30ac954 Merge "Use a TreeSet to sort suggestions instead of doing it by hand (A1)" 2012-06-28 03:08:26 -07:00
Jean Chalard
2d2e348033 Use a TreeSet to sort suggestions instead of doing it by hand (A1) 
Change-Id: I16ba39321107e87ad48a99c2410a15995a66f23c
 2012-06-28 18:54:14 +09:00
Tadashi G. Takaoka
69527d4d60 am 5e5cf045: am 7f7947c9: Keep subtypes in method.xml the same as pre-JellyBean 
* commit '5e5cf045ca6debafcc29ae1c47afda4a3a152326':
  Keep subtypes in method.xml the same as pre-JellyBean
 2012-06-27 21:58:53 -07:00
Tadashi G. Takaoka
7f7947c97b Keep subtypes in method.xml the same as pre-JellyBean 
This change prevents Android Keyboard subtypes being mistakenly
disabled when upgrading from pre-JellyBean to JellyBean.

Bug: 6750906
Change-Id: I05de6c512e7aa17356e415476e5248986c7d4253
 2012-06-28 13:44:09 +09:00
Jean Chalard
10abf10c1f Convert local members to local variables 
Change-Id: I852787986c79502a4de7effe9c8281a4cf2d519d
 2012-06-27 19:54:29 +09:00
Jean Chalard
3ecb2747b3 Optimization. 
It's useless to do this for all suggestions including those
that will be ousted from the list.

Change-Id: I7bd63d783e21984a269e4b1ae17e9b9d8c0859e3
 2012-06-27 18:55:43 +09:00
Jean Chalard
3705ef407b Read the suggestion type from the suggestion 
...instead of dirtily passing it from the dictionary loop

Change-Id: I92ddbd7451609b69f6d4dc31bf89d614423b2016
 2012-06-27 18:18:35 +09:00
Jean Chalard
24eec0fa68 Remember the source dictionary for each suggestion. 
Change-Id: I3c63372bd5572a479a67eaecfe8c8ea1cabc70d9
 2012-06-27 18:17:28 +09:00
Jean Chalard
d8f0caa406 Move constants to a better place. 
Change-Id: I5c27a3ed99b17f850e26a8503de16f001c7111c1
 2012-06-27 18:08:08 +09:00
Jean Chalard
089c11a086 Cleanup 
Change-Id: I575f22330bf6881af1d9a35f22b51b7bf2198113
 2012-06-27 17:59:58 +09:00
Jean Chalard
b5afd3de0c Remove unused stuff. 
Change-Id: Ifd0d5b6978f76b841574a6e10157c32d0cd656b6
 2012-06-27 17:44:16 +09:00
Jean Chalard
05efe576f9 Cleanup the dictionary type. 
Stop storing an int in each of the different class types, and
just store a string in the top class.

Change-Id: I2af1832743e6fe78e5c1364f6d9cc21252bf5831
 2012-06-27 17:31:09 +09:00
Jean Chalard
c356df8e08 Merge "Update the prototype of onAddSuggestedWord - calling side." 2012-06-27 01:25:59 -07:00
Ken Wakasa
e55c23e4b0 Small cleanups 
Change-Id: Ic1a198ab1b4f0323fde9e4245729fd0e6011b914
 2012-06-27 16:54:37 +09:00
Jean Chalard
32ff2504a0 Update the prototype of onAddSuggestedWord - calling side. 
We want to get rid of all those IDs in Latin IME.

Change-Id: Ibe08100a5e2976c80abb049889233b4047a686f3
 2012-06-27 16:17:14 +09:00
Jean Chalard
2db27bcd06 Merge "Use binarySearch instead of a hand-written linear search" 2012-06-26 23:55:46 -07:00
Jean Chalard
78a8d5b6bc Merge "Implement a comparator for SuggestedWordInfos." 2012-06-26 22:55:51 -07:00
Jean Chalard
56beb9e321 Use binarySearch instead of a hand-written linear search 
Yay.

Change-Id: Icf686eb2d675da959f19edc856b521e6288dcea3
 2012-06-27 14:17:29 +09:00
Jean Chalard
9da0027b38 Implement a comparator for SuggestedWordInfos. 
Change-Id: Ic4b0ae05cd98a1aec5806c5e4b744158e73aea7a
 2012-06-27 14:16:23 +09:00
Kurt Partridge
30447239e8 Merge "only output every kth word to log" 2012-06-26 20:49:03 -07:00
Jean Chalard
4ef01c51f8 Merge "Remove some special casing" 2012-06-26 20:33:43 -07:00
Kurt Partridge
e961188e9f only output every kth word to log 
multi-project CL with Ib5b544b9b2d8b0e4419238976b2e274e5ac564f8

Bug: 6188932
Change-Id: Iea68cf36924d6fda126130a98431a6ce02ba251e
 2012-06-26 16:15:20 -07:00
Jean Chalard
7e49a2b6b8 Remove some special casing 
This special casing is useless. If the word is the same as what
user typed, the scoring algorithm already ensures that it comes
out at the top. Actually, as is written in a comment here, code
executed later is actively relying on this suggestion having
the top score ! There is no need to test it for equalness and
inserting it at the top then.

Change-Id: I263a6de59b77ec72a2dcbb933361b8e16fca0681
 2012-06-26 20:40:42 +09:00
Jean Chalard
a3f5f51ec4 Fix a bug where a log would mysteriously not work 
Change-Id: I5ca77ed65e95a6d357215c0e730238fb463986bb
 2012-06-26 20:36:51 +09:00
Jean Chalard
22657dcba0 Optimization. 
We already had that computed

Change-Id: I2a9742eaee2e9db1f73aeddda7bae7e237b4d15c
 2012-06-26 20:02:07 +09:00
Jean Chalard
ec8b27fe49 Cut out a method for clarity 
Change-Id: I1dc668698a5cd840297e713a26a525f5e32d35d6
 2012-06-26 19:49:01 +09:00
Jean Chalard
5953dc93cf Avoid string conversions when possible. 
Change-Id: Ibf5f3e40da55998364d0d835ecf283f32c80fcf5
 2012-06-26 19:45:52 +09:00
Jean Chalard
bed514bd90 Simplify a method call. 
Change-Id: Ieede787a13cef79353f13af52488ef3732ac9850
 2012-06-26 19:33:16 +09:00
Jean Chalard
9433ce86b7 Refactor and squash long-standing bugs (A2) 
This is awesome.
- Improve performance by stopping useless string/array conversions.
- Simplify method interface.
- Fix localization bugs - we now know our locale
- Fix bugs with surrogate code points

Bug: 4769095
Change-Id: I8a8ee224b713429ee0a4ce5bd52f1b63378cf56f
 2012-06-26 19:12:07 +09:00
Jean Chalard
8e17f6d93a Remember the locale in the Suggest object (A1) 
This will be necessary for uppercasing and titlecasing words
correctly.

Change-Id: I0f446a4c82bc482240ff730a2ad6586a61571d6b
 2012-06-26 18:55:18 +09:00
Jean Chalard
6cad198d9c Remove a useless member (A2) 
Change-Id: Ia727ffc2946352bbf79e0c97684f8fa98f428cef
 2012-06-26 18:42:06 +09:00
Jean Chalard
0da9a7c094 Convert a member to a local variable (A1) 
Change-Id: I9eab910989443704f83711cf4fb0070c5987a13a
 2012-06-26 18:41:49 +09:00
Jean Chalard
f05392f213 Remove an unused method (A22) 
Change-Id: I2195f365df1799c8b3b2a53670d1df535ab1a742
 2012-06-26 17:59:04 +09:00
Jean Chalard
6234be1fe7 Simplification and optimization (A20) 
Change-Id: Ia837e553ccfe67cd4303096290194a5186df059b
 2012-06-26 17:59:04 +09:00
Jean Chalard
77e95e60bb Preparation for a simplification (A19) 
Change-Id: I4605a571faf5fbc68b18ce525d6019600bfa8cf7
 2012-06-26 17:59:04 +09:00
Jean Chalard
0a79446531 Remove a meaningless separation (A18) 
Change-Id: I267177044c7d7b0d9119839a11057b2bbf41f75f
 2012-06-26 17:59:04 +09:00
Jean Chalard
61e7ec6587 Remove the Callback interface for simpler code. (A17) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I009b54fc2e73cadca6734bdca074d033e81f6a2b
 2012-06-26 17:58:52 +09:00
Jean Chalard
2f1b6c9ea4 Remove the callback argument to getBigrams() (A16) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I7457ac04f8cd4019fb86c986725aae3de1b1a65e
 2012-06-26 17:54:49 +09:00
Jean Chalard
60eed92dc3 Remove the callback argument to getWords() (A15) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I919bf70a1213ab5d7c7a9e5715bd72a6e257148b
 2012-06-26 17:36:47 +09:00
Jean Chalard
2225b3bace Do away with Utils#addAllSuggestions (A14) 
It's not used any more.

Change-Id: Id9da40fdbf7078f3ac647d1368237d6601f5a2ba
 2012-06-26 17:36:47 +09:00
Jean Chalard
d9df8094e6 Neutralize AndroidSpellChecker.SuggestionsGatherer#addWords (A13) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Ia54e1e44e1fd4e8ba2c9316928c0595cbe3f933c
 2012-06-26 17:36:47 +09:00
Jean Chalard
7830476022 Neutralize Suggest#addWords (A12) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id923367342a62a650a5f1d38e2fa0e913030dca8
 2012-06-26 17:36:47 +09:00
Jean Chalard
fd998bd37a Refactoring (A11) 
Change-Id: I86bd7587dd80773a51ba6db312ba55dc41e7c8c7
 2012-06-26 17:36:47 +09:00
Jean Chalard
64dad2d5a9 Remove an unused method and inline another (A10) 
Change-Id: Ifd71ce79711b0c15c7764e97351dbb1b8e4c0c2d
 2012-06-26 17:36:47 +09:00
Jean Chalard
28eeb35d14 Merge the interface of two methods that do the same thing (A9) 
Change-Id: Ia5701d713d0fd5bb646b54a03a1a5602dad0a9e6
 2012-06-26 16:55:09 +09:00
Jean Chalard
d82898c5a9 Change the return type of getWords and getBigrams (A8) 
This only returns stuff, but it doesn't change yet how the data
is really passed. It merely adds a way of getting the same data.
Later, the old way will be removed.

Change-Id: If3a064de362175fc5a6781b7a97b65d8730aaf3c
 2012-06-26 16:44:26 +09:00
Jean Chalard
bda7eaa63a Remove dependency on WordCallback from BinaryDictionary (A7) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I8245698fbd170e0f5cbad3c0109774bcaddc0614
 2012-06-26 16:42:48 +09:00
Jean Chalard
17111afcd6 Remove useless code and storage (A6) 
This is only used as temporary storage to be then added to
the other variable, relying on the fact that it is hopefully
sorted. It's better to just add it right away to the final
storage.

Change-Id: I5da702ac9dc579593ab21feb2021a01e5dfdf4dc
 2012-06-26 16:39:32 +09:00
Jean Chalard
5e0545d69d Remove a duplicate processing (A5) 
This filtering is already done in native code. It's useless (and
costly) to do it again here.

Change-Id: Ide6794d7a8682a881f097f33e222f10d30f297bd
 2012-06-26 16:37:05 +09:00
Jean Chalard
fac8a16c6f Merge "Remove another dependency to WordCallback (A4)" 2012-06-25 23:31:39 -07:00
Kurt Partridge
3ec249c6d1 Merge "fix IllegalOutOfBoundsException" 2012-06-25 22:52:36 -07:00
Kurt Partridge
01106f6a10 fix IllegalOutOfBoundsException 
StringUtils.toCodePointArray() had thrown IllegalOutOfBoundsException if
passed an empty string.  change to just return an empty int[].

Bug: 6188932
Change-Id: Ic41c628c0d407f49fc98cd48cb7ea13d8d5bdd77
 2012-06-25 22:40:56 -07:00
Jean Chalard
d7b9e8f503 Remove another dependency to WordCallback (A4) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I5b277124dc9244e78c4a1f4d542a55071eb479bd
 2012-06-26 13:12:01 +09:00
Ken Wakasa
9f78eed456 Remove "Key popup dismiss delay" when "Popup on keypress" is suppressed 
bug: 6714783
Change-Id: Idf674e8e1af80642f2c53f7ae5c03e21c9e04292
 2012-06-26 00:40:53 +09:00
Satoshi Kataoka
7368009799 Change JNI for Gesture 
Change-Id: I774a0052038d16677f60f7efa11fd266cb5f3088
 2012-06-25 18:54:37 +09:00
Jean Chalard
5a73d72265 Merge "Refactoring and groundwork to fix a bug with older apps" 2012-06-25 00:42:21 -07:00
Jean Chalard
c3ebf1a43a Refactoring and groundwork to fix a bug with older apps 
This has a good, although small, impact on performance : it removes
a two-way IPC call in a most frequent case, while possibly adding
one in a rather unfrequent and less critical case.

Also, this fixes a bug with surrogate pairs. This specific branch
of code now correctly handles surrogate pairs.
Aside from this, it should have no impact on behavior.

However, since it does delay access to the previous character in
the text view by a two-way IPC call, it actually goes a long way
toward fixing bug#6668226. It is not really a fix and the race
condition still exists, but this change makes it much, much
harder to hit.

Bug: 6668226
Change-Id: Id11cc6a0b7488d6bd392227cafdcf3a8d4c62f6c
 2012-06-25 16:32:25 +09:00
Jean Chalard
a316a15984 Merge "Tentatively remove a dependency on WordCallback (A3)" 2012-06-24 23:08:13 -07:00
Jean Chalard
dc01bd5ea4 Merge "Improve compatibility for ICS." 2012-06-24 20:41:19 -07:00
Satoshi Kataoka
2cf265b345 Merge "Fix possible NPE from a concurrent problem in LatinIME" 2012-06-21 22:16:48 -07:00
Kurt Partridge
e6a39d5677 Merge "Allow punctuation through privacy filter" 2012-06-21 21:53:48 -07:00
Kurt Partridge
33d9f9b6db Allow punctuation through privacy filter 
Also cleaned up the privacy code a bit.

multi-project commit with Change-Id: Ic0919a6929ebb2623ff4124f7adc96d9e5f8df3c

Bug: 6188932
Change-Id: Id470fe7cc6e4a8fb01f1ea5b178a74cd27d59218
 2012-06-21 00:17:48 -07:00
Jean Chalard
1b71ff00a2 Merge "Update an outdated comment" 2012-06-20 20:18:51 -07:00
Jean Chalard
9997b44846 Improve compatibility for ICS. 
ICS didn't have a SHORTCUT column in the user dictionary.
If running on a build under JellyBean, we should not ask
for it lest we crash.

Bug: 6600617
Change-Id: Iac0cbcc63c10064f01e2d51eec5931fd9cdd0922
 2012-06-20 18:43:56 -07:00
Jean Chalard
83f4a9866a Cleanup, part 10 : remove from the code obsolete options (C10) 
Change-Id: Id0806ad3dc7ccb632713eebaca76f0bab26ece5d
 2012-06-21 10:07:05 +09:00
Jean Chalard
7c406ed655 Tentatively remove a dependency on WordCallback (A3) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id5a59eaec2aeefa0ba4524420a8e035d383f6545
 2012-06-21 10:03:44 +09:00
Jean Chalard
e8bb8351d6 Cleanup, part 9 (C9) 
Change-Id: Ifb15553824915d0634aea83689302c2418b093f3
 2012-06-21 09:22:32 +09:00
Jean Chalard
ca6b7d5265 Cleanup, part 8 (C8) 
Change-Id: Iecc9b3d43c191614c2951408e14085cb77eefd4d
 2012-06-20 03:45:40 +09:00
Jean Chalard
2f3a694e29 Cleanup, part 7 (C7) 
Change-Id: I662be9d3b31fb9e157722f38cab1e6fb8a1152ab
 2012-06-20 03:17:33 +09:00
Jean Chalard
0e8b1db948 Merge "Cleanup, part 6 (C6)" 2012-06-19 09:25:33 -07:00
Jean Chalard
c03bd090ea Merge "Cleanup, part 4 (C4)" 2012-06-19 09:24:25 -07:00
Jean Chalard
bd765d3355 Merge "Cleanup, part 3 (C3)" 2012-06-19 09:24:00 -07:00
Satoshi Kataoka
67b9337b6c Fix possible NPE from a concurrent problem in LatinIME 
Bug: 6620746
Change-Id: Icc18de92d7edc6888c712c2cf5ce479a65f8bfad
 2012-06-19 03:34:45 +09:00
Jean Chalard
b0561ae980 Remove a member (B5) 
The new call in the test ensures getCurrentInputEditorInfo actually
works.

Change-Id: I2ee407bd9927d22db537d12f339e2b977a38054a
 2012-06-19 03:27:37 +09:00
Jean Chalard
64e52051cf Simplification (B4) 
Change-Id: Id5abf722a533980ed2d89381dbddc0a71b6f5b6b
 2012-06-19 02:54:13 +09:00
Jean Chalard
fe53e5c060 Move a settings method to SettingsValues (B3) 
Change-Id: Ibfa27bd919c92be219c4d107b3ace008ca80a19f
 2012-06-19 02:52:36 +09:00
Jean Chalard
8b538807a3 Merge "Make a variable final (A2)" 2012-06-18 10:30:19 -07:00
Jean Chalard
0176faf6c0 Merge "Add a kind to the suggestion for bookkeeping (A1)" 2012-06-18 10:30:10 -07:00
Jean Chalard
1c3c0ff1c3 Merge "Cleanup, part 2 (C2)" 2012-06-18 10:29:06 -07:00
Jean Chalard
65b7bcb045 Merge "Cleanup, part 1 (C1)" 2012-06-18 10:28:58 -07:00
Kurt Partridge
6080f6878b Remove non-dictionary words and digit touch data. 
Output to the ResearchLogger is now queued and only flushed if the word
the user was working on is a dictionary word.

multi-project commit with Ic713ec00777fbdcf4a937b3c77b995257e100fc7

Bug: 6188932
Change-Id: I9de15227ff51be23083d9096f1c1b3d83802fff7
 2012-06-17 15:02:15 -07:00
Kurt Partridge
4b91046759 Merge "Replace digits in ResearchLogger" 2012-06-16 20:48:25 -07:00
Kurt Partridge
a696781c2b Replace digits in ResearchLogger 
Digits may represent personally identifying information.  They are
now replaced with a non-identifying symbol.

multi-project commit with I07d1cfdc45f6086f67af45775f4ed12da1833aca

Bug: 6188932

Change-Id: Ifda8079e6c1f29b5f8af34c6d1fccf5770f164ca
 2012-06-16 12:37:50 -07:00
Jean Chalard
c5f1d998c2 Cleanup, part 6 (C6) 
Change-Id: I184f3a336278559df255c5d600a98fbba468a243
 2012-06-16 10:52:49 +09:00
Jean Chalard
9b233ecef2 Cleanup, part 4 (C4) 
Change-Id: I2821ae71ec49e4b6b512157d17b80198f74321e4
 2012-06-16 10:51:04 +09:00
Jean Chalard
5475e92b3f Cleanup, part 3 (C3) 
Change-Id: Ib0be8dc26b6fa366a3dabeea940d466602073244
 2012-06-16 10:46:18 +09:00
Jean Chalard
71dc280426 Cleanup, part 2 (C2) 
Change-Id: I860f41807e9bc2e38b6ad84e1527fc8707a9aa40
 2012-06-16 10:40:16 +09:00
Jean Chalard
6883153dd0 Cleanup, part 1 (C1) 
Change-Id: I2b1ddd836aaf6bfc0bd2befb78f98239ffcdbb22
 2012-06-16 10:38:57 +09:00
Jean Chalard
4a5cb5c36a Update an outdated comment 
Change-Id: I3d02dc8597ed14d998caeaa056813353e2d7ec1a
 2012-06-16 10:34:57 +09:00
Jean Chalard
dca729fddd Move final attributes to SettingsValues (B2) 
Bug: 6675475
Bug: 6677394
Change-Id: I4a26efb9226d3f909f331c4d2e47cd83a05c011e
 2012-06-16 08:01:09 +09:00
Jean Chalard
3d44f489b3 Inline a method for simplicity (B1) 
This has a confusing name and is a one-liner

Change-Id: I954a648a8413e38a535c2b81e4b171e1bdc9f1c2
 2012-06-16 03:18:00 +09:00
Jean Chalard
0998c48ac3 Make a variable final (A2) 
This is never changed, and probably doesn't need to be.
It's public because it's going to be used elsewhere in a future
change

Change-Id: Iec8d65859c470de5e1fb0b05533356fbc3b8e91b
 2012-06-16 03:10:54 +09:00
Jean Chalard
e7d2ee3ec3 Add a kind to the suggestion for bookkeeping (A1) 
This will help for debug as well as serve as groundwork for
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I74d0a7b943fb22c514ad79dc064d69ddf336d3ef
 2012-06-16 03:10:36 +09:00
Kurt Partridge
23cec44376 Merge "No logging of passwords." 2012-06-14 21:09:20 -07:00
Jean Chalard
a19c5e6380 resolved conflicts for merge of be82f297 to master 
Change-Id: If49ca384ea0ac415a75f8ea1bad77dc6719cb04d
 2012-06-15 09:03:52 +09:00
Kurt Partridge
1cef91e481 No logging of passwords. 
Bug: 6188932
Change-Id: Ibf60ec99c50da3675bf89858624218e6cc3eb1d2
 2012-06-14 15:14:20 -07:00
Jean Chalard
cf6e923b18 am 42ecf39d: am 002e43ea: Merge "Remove irrelevant options." into jb-dev 
* commit '42ecf39d04df9eb02e57cf29e63552bc04092857':
  Remove irrelevant options.
 2012-06-14 14:51:37 -07:00
Tadashi G. Takaoka
775d8dcaeb am de1d88eb: am 32f4ceb2: Dismiss more suggestions panel when suggestions strip is closed 
* commit 'de1d88eb4199160899d227f2c679215e16410c42':
  Dismiss more suggestions panel when suggestions strip is closed
 2012-06-14 14:49:08 -07:00
Jean Chalard
7cbd0478cf Merge "Do not display punctuation suggestions when bigrams are on." into jb-dev 2012-06-14 14:37:13 -07:00
Jean Chalard
002e43ead0 Merge "Remove irrelevant options." into jb-dev 2012-06-14 14:36:26 -07:00
Jean Chalard
d5b765b3bb Do not display punctuation suggestions when bigrams are on. 
Bug: 6310401
Change-Id: I9d31c48e287aceedaf2f4c5129031ddb31402451
 2012-06-15 06:01:09 +09:00
Jean Chalard
78573f2e8a Fix an NPE 
This code is temporary until we get rid of this member.

Bug: 6662963
Bug: 6667091
Change-Id: I1d970d2a97992507e86c5b94978a2543fe42b375
 2012-06-15 05:47:35 +09:00
Jean Chalard
15121cff37 Remove irrelevant options. 
Bug: 6667355
Change-Id: I39b6db17fb52e80f510cf6462f41d9cb1f8e0341
 2012-06-15 05:04:14 +09:00
Tadashi G. Takaoka
32f4ceb243 Dismiss more suggestions panel when suggestions strip is closed 
This change fixes possible NPE as well.

Bug: 6658028
Change-Id: I8706808d1002b7b0b95930fd9b08568f08645da6
 2012-06-14 11:57:43 -07:00
Satoshi Kataoka
d2f210dbe2 am d9c702d2: am 5caaf1b9: Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 
* commit 'd9c702d2ff017452f0264f2be12b6bffd6204e4a':
  Do not add profanity to user history bigram dicitonary
 2012-06-14 10:33:47 -07:00
Satoshi Kataoka
68c650fb2a Do not add profanity to user history bigram dicitonary 
Change-Id: I864c4206e3e6cde4d6ed687a9759e98901e16b9a
 2012-06-14 15:15:08 +09:00
Jean Chalard
9d71748ba4 Fix an occurrence of nested batch edits. 
This is harmless, but against policy.
Also, rework the checking code to be more readable, give more
information, and be called for all relevant methods - and not
for informative methods, which are not required to be in a
batch edit.

Change-Id: I03fa8b2e7d68a6a133f86be8a214671750c29256
 2012-06-13 07:02:07 +09:00
Jean Chalard
c7564a787e Optimization 
This is much faster. It doesn't create messages, it doesn't post
stuff in a queue, it doesn't delay execution of other messages.
Also, it decouples the timer from the functionality of the Handler
so this can be pulled up in another change to consolidate with
mLastKeyTime or so.

Change-Id: I9044fc031373e66b9b40eee8025633613d0945dc
 2012-06-13 07:02:07 +09:00
Jean Chalard
72b358aa90 Small optimization. 
This will avoid some two-way IPC calls.

Change-Id: If9eb3e99b3d08346aadd4bbed2a1761f8c2527b9
 2012-06-13 07:02:07 +09:00
Satoshi Kataoka
84bb18f4c9 resolved conflicts for merge of ee78e780 to master 
Change-Id: I88a4996bdd17c5378a67781d8075eff311670c3b
 2012-06-13 06:45:38 +09:00
Jean Chalard
58d9e46ce0 Merge "Consolidate a test." 2012-06-12 11:50:36 -07:00
Kurt Partridge
5e50eec570 Merge "Check inputs to ResearchLogger" 2012-06-12 11:39:11 -07:00
Jean Chalard
e86054e5c2 Consolidate a test. 
Stop using the numerical value, use the actual method

Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e
 2012-06-13 03:34:58 +09:00
Kurt Partridge
65fc909e13 Check inputs to ResearchLogger 
to avoid NPEs.

Bug: 6188932
Change-Id: I377ceaac867df879dc7984dae44e96b369858cca
 2012-06-12 10:56:03 -07:00
Jean Chalard
140adf204b Consolidate auto-correction settings. 
For some reason, there were several ways, not exactly identical,
to get this setting. The ones that used mAutoCorrectionEnabled
would kick in when the input field was specifying no correction,
so it would be a little strange (although harmless in the practice
because the settings set in this way would not get used later,
because the correct test would be done at that time).

Also perform a very small refactoring

Change-Id: Ica9f32b238d98009ae1852d3c1e940398f5d341c
 2012-06-12 10:29:55 +09:00
Jean Chalard
2010aad741 Move two methods in a more appropriate place 
Change-Id: I512b04e23490413a44b1ca0517102fe2d9138df3
 2012-06-12 10:29:55 +09:00
Jean Chalard
a32eb27213 Move an editing method to the RichInputConnection 
Change-Id: Ie143ad008ca8deb1c5034cb80ec1cb28a6b0682d
 2012-06-12 10:29:55 +09:00
Jean Chalard
243e370fcb Move a member call out of the way 
Change-Id: I5da48442c0b39aaff817c3b6d067a9b13fda0643
 2012-06-12 10:29:55 +09:00
Jean Chalard
747cf0435a Move two editing utility methods to RichInputConnection 
Change-Id: If8d03bea1b6369cb3043da6321048d052995d664
 2012-06-12 10:29:55 +09:00
Jean Chalard
70a046f8ca Merge "Rename mSettingsValues to mCurrentSettings" 2012-06-11 18:24:45 -07:00
Jean Chalard
64913d72bc Merge "Move suggestion strip visibility to SettingsValues" 2012-06-11 18:18:50 -07:00
Jean Chalard
15c0090e88 Merge "Accept a null input attributes for reading settings." 2012-06-11 18:18:43 -07:00
Jean Chalard
f4bc441256 Merge "Move the correction mode to SettingsValue and make it final" 2012-06-11 18:18:03 -07:00
satok
6a71f0610c Fix UserHistoryBigram data contention in UserHistoryDictionary 
Bug: 6637614
Change-Id: I34d26563e59d3b09bf35b8173dac5645ccb6a39f
 2012-06-12 08:00:14 +09:00
Jean Chalard
411a98afb9 Merge "Consolidate updateCorrectionMode() calls" 2012-06-11 14:02:15 -07:00
Jean Chalard
297e6d590b Rename mSettingsValues to mCurrentSettings 
...for readability. After all, it makes sense that "current settings"
is a "SettingsValues", while it's harder to understand why we'd
manipulate an object named "SettingsValues".

Change-Id: Ide9a17b970a6cc00b80b9a217f986268c739c662
 2012-06-08 21:34:07 +09:00
Jean Chalard
d273697259 Move suggestion strip visibility to SettingsValues 
Change-Id: If34112c69acd5122d87554043d87d8f4dbdf5d15
 2012-06-08 21:26:25 +09:00
Jean Chalard
01e3b014bb Accept a null input attributes for reading settings. 
Change-Id: I11a8e1aca3541c35d2b39b27716687fcd8ff3dc6
 2012-06-08 21:15:33 +09:00
Jean Chalard
4b9e6ee6fb Move the correction mode to SettingsValue and make it final 
At last this guy is final, at last

Change-Id: I76911f8d47493f8a1719f75fc7e949be5d7da1a2
 2012-06-08 21:10:35 +09:00
Jean Chalard
3791183076 Consolidate updateCorrectionMode() calls 
Change-Id: I43c0505e9a1652bfc568f23b787fc68a5c5e9220
 2012-06-08 21:02:19 +09:00
Ken Wakasa
e7b34b9f86 Add NativeUtils.powf() 
Change-Id: I0339f39d49bc6390d098017f32d92c776974e03e
 2012-06-08 20:46:19 +09:00
Jean Chalard
bbbdab12be Move some editing methods to RichInputConnection. 
Change-Id: I8527776a4bd8236a85bb77f9791f9b76977ad181
 2012-06-08 20:23:13 +09:00
Jean Chalard
e091982868 Straighten batch edits, pass 1 
Change-Id: I73acfee9098a87b9cde8aca720586ec748b2a82f
 2012-06-08 20:09:41 +09:00
Jean Chalard
02308bec63 Merge RichInputConnection with EditingUtils 
Change-Id: I9982ff325bef56694402caef28a77683c52ccd71
 2012-06-08 20:04:09 +09:00
Jean Chalard
5475b38328 Make a wrapper for the input connection. 
The goal is to simplify the code in LatinIME.java as well as having
a handy place to put debug calls to see interaction with TextView.

Change-Id: I255227e7e7343e0c2f3dcd1f185e5020d6186732
 2012-06-08 19:50:12 +09:00
Jean Chalard
c33a5428be Merge "Small performance tweak" 2012-06-08 01:22:31 -07:00
Jean Chalard
67fd0c240d Remove deprecated classes. 
Should we maybe rename back *BinaryDict* to *Dict* in another
change for simplicity?

Change-Id: I8f7dcb78b9bdf1a13ce403a997fbb8619f2b453b
 2012-06-08 17:12:15 +09:00
Jean Chalard
d10c473347 Small performance tweak 
Change-Id: Icd540742073d49d12e70b2d8bd99aaf7ccb5802d
 2012-06-08 17:09:40 +09:00
Jean Chalard
7214617622 Remove a slew of Eclipse warnings. 
Change-Id: I03236386aea13fbd4fb8eaeee18e0008aa136502
 2012-06-08 16:23:18 +09:00
Ken Wakasa
d418580a71 Fix typo 
Change-Id: I264f829c1584a37995dbc5ee4ba6b6783d5d4834
 2012-06-08 03:42:02 +09:00
Tadashi G. Takaoka
6b8a70105f am e4da18e2: am 6348c54f: Merge "Initializing member variable before it is referenced" into jb-dev 
* commit 'e4da18e27916f770fcd704032d30534d287d67c6':
  Initializing member variable before it is referenced
 2012-06-07 11:32:50 -07:00
satok
1e96cc1f51 am 674c51a0: am ec2981a4: Fix a bug on upgrading user history scheme 
* commit '674c51a01117b73dd25473195f92fb0c0158da26':
  Fix a bug on upgrading user history scheme
 2012-06-07 11:28:41 -07:00
Tadashi G. Takaoka
6348c54ffd Merge "Initializing member variable before it is referenced" into jb-dev 2012-06-07 11:27:32 -07:00
Tadashi G. Takaoka
40582ab438 Initializing member variable before it is referenced 
Bug: 6584882
Change-Id: I1f76388fa8cc16171bc3fc60c935ddcf0a7c4e92
 2012-06-07 11:17:59 -07:00
satok
ec2981a487 Fix a bug on upgrading user history scheme 
Bug: 6626700
Change-Id: I3190d7404e45e704be79ee2031e79b18475feb8c
 2012-06-08 02:55:23 +09:00
Tom Ouyang
11dc22d964 Merge "Contacts binary dictionary updates with change in keyboard locale." 2012-06-07 01:19:44 -07:00
Tom Ouyang
2e8aa06002 Contacts binary dictionary updates with change in keyboard locale. 
Bug: 6616436
Change-Id: I8d66a37f295134c5b9875b2a305a9be7442bd75d
 2012-06-07 00:25:41 -07:00
Jean Chalard
c8a120f970 am eead5492: am 769cecf7: Close spell-checking dictionaries in a background thread 
* commit 'eead5492615f0b05ef85ca1f88d3a41ce3f8d496':
  Close spell-checking dictionaries in a background thread
 2012-06-06 21:52:46 -07:00
Jean Chalard
769cecf7e7 Close spell-checking dictionaries in a background thread 
Bug: 6584677
Change-Id: Ifd9b0f995f4e0cf4d35a7ecde767826ab976f0b8
 2012-06-07 12:56:45 +09:00
Kurt Partridge
9b300f0caa Merge "add research log ui control" 2012-06-06 20:47:53 -07:00
Kurt Partridge
724bc479f7 add research log ui control 
- lets users flag a particular time in the research log
- lets users delete the log for this session

also makes the UsabilityLog setting control whether the ResearchLog logs or not.

multi-project commit with I89067e7d3b8daca7179333f1dbe82224c26920fe

Bug: 6188932
Change-Id: I89864ef3ab53b0efe1ea8d75247be08712f0c399
 2012-06-06 20:42:01 -07:00
Satoshi Kataoka
91c8c4f3a7 am e08cfda1: am 5a8d2fd1: Merge "Cache UserHistoryDictionary for each language" into jb-dev 
* commit 'e08cfda1ebea693c56681816076c419f23c51076':
  Cache UserHistoryDictionary for each language
 2012-06-06 10:48:46 -07:00
Satoshi Kataoka
5a8d2fd1d3 Merge "Cache UserHistoryDictionary for each language" into jb-dev 2012-06-06 10:43:50 -07:00
Satoshi Kataoka
a836808f8b Cache UserHistoryDictionary for each language 
Bug: 6603257
Change-Id: I73b65e921cff8337a00594525f67f6aec2178881
 2012-06-06 20:02:00 +09:00
Satoshi Kataoka
21b782cf22 Merge "Cache bigram results in Android SpellChecker" 2012-06-06 01:01:47 -07:00
Satoshi Kataoka
547bc0cf04 Cache bigram results in Android SpellChecker 
Bug: 6610579
Change-Id: I255c068f64f99ee80abda49153ed8ea009ca8ad3
 2012-06-06 16:58:24 +09:00
Kurt Partridge
6b3b37da97 Merge "Change constants in ResearchLogger" 2012-06-05 20:17:14 -07:00
Tadashi G. Takaoka
876711930d am 2eb5eb4d: am be2fef4d: Merge "Fix backing view height calculation in landscape orientation" into jb-dev 
* commit '2eb5eb4d447cb326b4c10cff2cae64df4e431ffd':
  Fix backing view height calculation in landscape orientation
 2012-06-05 17:58:59 -07:00
Tadashi G. Takaoka
b94f4cc71c Fix backing view height calculation in landscape orientation 
This logic has been dropped by Ib814c07f.

Bug: 6610497
Change-Id: Id89ad3280b73a31d8c9c6826e9ee297791624db1
 2012-06-05 17:41:01 -07:00
Jean Chalard
5235e0cd91 am c750f9eb: am a6166d37: Fix a bug where Latin IME crashes on spell checker request 
* commit 'c750f9eb5398a30b207891e6858863f493875199':
  Fix a bug where Latin IME crashes on spell checker request
 2012-06-05 09:54:58 -07:00
Tom Ouyang
f93551f77b am 18c4137c: am 7f7739fe: Merge "Fix a bug where the spellcheck is using the old non-binary contacts dictionary" into jb-dev 
* commit '18c4137c878c18de24a406b861ddb2a735e02f7d':
  Fix a bug where the spellcheck is using the old non-binary contacts dictionary
 2012-06-05 09:54:55 -07:00
Satoshi Kataoka
037cf8c8a5 am 7394fc43: am 0e134e6b: Merge "Avoid redundant access to DB" into jb-dev 
* commit '7394fc43028ef6e28579921c30915bd8a9c9c990':
  Avoid redundant access to DB
 2012-06-05 09:22:17 -07:00
Jean Chalard
c1cbcf949d am 9252fc1b: am dd487247: Merge "Read the script correctly" into jb-dev 
* commit '9252fc1b88df0c8bd3870546d1c8ca7681e435d3':
  Read the script correctly
 2012-06-05 09:22:15 -07:00
Kurt Partridge
f739119f3f Change constants in ResearchLogger 
Bug: 6188932
Change-Id: I3c6a3fb3e8fb139e16322e544f12bc3294cdaf1c
 2012-06-05 07:13:06 -07:00
Jean Chalard
a6166d3776 Fix a bug where Latin IME crashes on spell checker request 
Bug: 6611183
Change-Id: I8a879feb598e1ac55d73f9cb27e54aa533d3a010
 2012-06-05 16:33:21 +09:00
Tom Ouyang
7f7739fee8 Merge "Fix a bug where the spellcheck is using the old non-binary contacts dictionary" into jb-dev 2012-06-04 23:10:03 -07:00
Satoshi Kataoka
0e134e6be8 Merge "Avoid redundant access to DB" into jb-dev 2012-06-04 20:08:02 -07:00
Jean Chalard
dd4872474a Merge "Read the script correctly" into jb-dev 2012-06-04 19:55:47 -07:00
Tom Ouyang
faf0059f35 Fix a bug where the spellcheck is using the old non-binary contacts dictionary 
Bug: 6607023
Change-Id: I6dc120dea23052a0841e281c20706bfb21fd9876
 2012-06-04 14:07:47 -07:00
Satoshi Kataoka
a8c13e7942 Avoid redundant access to DB 
Bug: 6603257
Change-Id: I2e8017f9e2e222aeab0a80faa239ce83d3b212ad
 2012-06-04 23:41:50 +09:00
Jean Chalard
b1f3c24c63 Read the script correctly 
The script of a language presumably does not depend on the
country variant. This was how it was made but it was later
forgotten and the full locale was registered.

Bug: 6542210
Change-Id: Iebc90c546f9c8caf89f8aa6c6a7c4733e5bcba48
 2012-06-04 18:39:16 +09:00
Tadashi G. Takaoka
9895b815a8 am e2832daf: am 8cf3654a: Merge "Use calculated backing view height instead of the view\'s height" into jb-dev 
* commit 'e2832daf4c289f94d68c546c485fc06bbf6aefd6':
  Use calculated backing view height instead of the view's height
 2012-06-03 21:55:26 -07:00
Tadashi G. Takaoka
bc5b89cdff Use calculated backing view height instead of the view's height 
This change removes the work around that was introduced by If4f24500.

Bug: 6596131
Change-Id: Ib814c07fdac7d0aa0d7fbc2764fda1af42b82ad5
 2012-06-04 12:49:27 +09:00
Ken Wakasa
4a9e5d2c95 am a8b7451b: am 027448e0: Remove an unnecessary thread. 
* commit 'a8b7451b31872d217cd61b7d0e6fbbf7221781c8':
  Remove an unnecessary thread.
 2012-06-02 09:07:51 -07:00
Ken Wakasa
027448e08a Remove an unnecessary thread. 
bug: 6584677

While looking at bug 6584677, we found that LatinIME always spawns an unnecessary thread
for Usability Study Mode.  We don't assume this change will address the root cause of the
bug, but we'd like to remove any suspicious noises in bugreports.

Change-Id: Ie47d104f6cd77ec2ad164f13b4212cb4a70bcf1d
 2012-06-03 00:27:07 +09:00
satok
083fb024d7 am e6560252: am 72cd8466: Merge "Fix NPE in user history bigram dictionary" into jb-dev 
* commit 'e656025282c0da28ed80b2604949092dbc5fb72e':
  Fix NPE in user history bigram dictionary
 2012-05-31 20:29:43 -07:00
satok
4f96bb4520 Fix NPE in user history bigram dictionary 
Bug: 6584882
Change-Id: Id0162bffc4f0f36239cdc68383f8a47d7a957397
 2012-06-01 12:19:22 +09:00
Kurt Partridge
76dbab8eb8 Merge "Include version number in log output." 2012-05-31 16:52:43 -07:00
Kurt Partridge
58caa775a7 Include version number in log output. 
Bug: 6188932
Change-Id: I1039a3ad317d207599f30fe578bdf814c80d6852
 2012-05-31 14:19:38 -07:00
Jean Chalard
b012f45242 am bb104678: am 6f0cd9ba: Fix a possible NPE. 
* commit 'bb10467863ff531c5cbee8ffd72845a91e487e72':
  Fix a possible NPE.
 2012-05-31 03:41:04 -07:00
Jean Chalard
6f0cd9ba6d Fix a possible NPE. 
This NPE's at least in unit tests.

Change-Id: I255ac5fec9502e4e5bd18cba1211cdf46c6cafc8
 2012-05-31 19:33:39 +09:00
Jean Chalard
3d7312af5b am 40bab488: am 4f78f8cb: Merge "Remove a vibration-related option when there\'s no vibrator" into jb-dev 
* commit '40bab488cb70875f46e29f595d577cc6cc4a9264':
  Remove a vibration-related option when there's no vibrator
 2012-05-29 23:37:09 -07:00
Jean Chalard
c7f2878cf5 Remove a vibration-related option when there's no vibrator 
Bug: 6567160
Change-Id: I1b5d425ffb64b2d7390cd0b7be0825f6aca17f41
 2012-05-30 15:24:59 +09:00
Kurt Partridge
30ff0898fd Merge "Fixes to json output" 2012-05-29 17:48:50 -07:00
Kurt Partridge
86fcadde5d Fixes to json output 
- booleans and numbers in SharedPreferences not quoted as strings
- removed redundant logging from KeyboardState
- json output for KeyboardId
- remove unnecessary logging of LatinImeLogger.onStartView() and PointerTracker checking keyboardlayoutchange
- fix to day-of-month part of uuid

Multi-project commit with Idb8f190214f852ab2b58df49f9e514dc7fcbecbb

Bug: 6188932

Change-Id: I67b4a0b34aa26c2804e2b3ee2136614f0ec8181a
 2012-05-29 14:04:05 -07:00
Tom Ouyang
609ce32a4d am 126ed424: am 1ed017ef: Fix performance issue when there are no contacts in the dictionary dictionary. 
* commit '126ed42415a4dc3841e8981a23cbe8a22a9e2213':
  Fix performance issue when there are no contacts in the dictionary dictionary.
 2012-05-29 10:12:33 -07:00
Tom Ouyang
1ed017ef0e Fix performance issue when there are no contacts in the dictionary dictionary. 
Bug: 6551480
Change-Id: I8681a1bd82423c612af2d012f9b872501d8c201d
 2012-05-29 09:45:42 -07:00
Satoshi Kataoka
c5d4362b59 am 408fa1ac: am 961e676b: Merge "Set level 1 as the initial value of the valid words" into jb-dev 
* commit '408fa1ac48a3eb6f378274d5dd0e490da0f453ae':
  Set level 1 as the initial value of the valid words
 2012-05-29 04:49:33 -07:00
Satoshi Kataoka
c88f61215c Set level 1 as the initial value of the valid words 
Bug: 4192129
Change-Id: I867e78ce79c78977d08e8b66881a25b6fe5bf41f
 2012-05-29 20:39:39 +09:00
Satoshi Kataoka
9a989492db am 40ab25ca: am 51705efc: Merge "Add a JNI to get the frequency" into jb-dev 
* commit '40ab25cab0e723f34dc2f1442f414761149b2338':
  Add a JNI to get the frequency
 2012-05-29 01:32:48 -07:00
Satoshi Kataoka
2f854e170c Add a JNI to get the frequency 
Bug: 4192129
Change-Id: I3f220f5a10114d4eb23956148076cf76220bda0f
 2012-05-29 17:21:59 +09:00
Satoshi Kataoka
a62f6e363d am d882aead: am bd40b94f: Merge "Optimize the store of bigram list" into jb-dev 
* commit 'd882aeadb07d16ed887c71895577faabbd635ff3':
  Optimize the store of bigram list
 2012-05-28 23:13:43 -07:00
Satoshi Kataoka
bd40b94f96 Merge "Optimize the store of bigram list" into jb-dev 2012-05-28 23:09:59 -07:00
Satoshi Kataoka
bc56885062 Optimize the store of bigram list 
Bug: 4192129

Change-Id: Idcc62e4f9696b56b1d7013891b2da37b1784423e
 2012-05-29 15:03:10 +09:00
Satoshi Kataoka
1963e46080 am 7317a257: am 24c4d626: Merge "Fix NumberFormatException" into jb-dev 
* commit '7317a257e553c6ecc7adb4211a0370d502bfa0fe':
  Fix NumberFormatException
 2012-05-28 21:24:57 -07:00
Satoshi Kataoka
48255b1747 Fix NumberFormatException 
Bug: 6567496
Change-Id: Ib0d9fab8496c8c856b94cce5812a263efbcb724f
 2012-05-29 13:16:38 +09:00
satok
1c69942683 am fff5cd6f: am aa064139: Merge "Forget user history" into jb-dev 
* commit 'fff5cd6f767e248ecb5b30ea39cb9a22a476b953':
  Forget user history
 2012-05-27 23:03:46 -07:00
satok
aa0641394b Merge "Forget user history" into jb-dev 2012-05-27 22:59:22 -07:00
satok
fd53b8cc2b Forget user history 
Bug: 4192129

Change-Id: Ic98398e5383093a1c24373849eadc48fc4d3626f
 2012-05-28 14:34:02 +09:00
Jean Chalard
1a31b4e484 am fac23787: am bed613cf: Merge "Simulate hardware enter/delete events if the app targets < 16" into jb-dev 
* commit 'fac23787bbd7723acba4e7e344aa6f799d9584f6':
  Simulate hardware enter/delete events if the app targets < 16
 2012-05-27 21:26:06 -07:00
Jean Chalard
bed613cf11 Merge "Simulate hardware enter/delete events if the app targets < 16" into jb-dev 2012-05-27 21:21:22 -07:00
Jean Chalard
4e1a558ee8 Simulate hardware enter/delete events if the app targets < 16 
This will make text input buggy on all apps until they target
JB or superior.

Bug: 6537051
Change-Id: I726347db8c84d1582ad1962d3a910e698389e08c
 2012-05-28 12:00:43 +09:00
Jean Chalard
6d7ac8a4ef am 250f6a44: am 123017cc: Merge "Wipe the application cache selectively" into jb-dev 
* commit '250f6a44a7585d61175ec983f9afd43081cd636f':
  Wipe the application cache selectively
 2012-05-25 04:11:16 -07:00
Jean Chalard
f27ac2733c am d45e334f: am 7707e045: Merge "Cache application info." into jb-dev 
* commit 'd45e334f5a73d2cc36800a81e1bbf881e633f026':
  Cache application info.
 2012-05-25 04:11:15 -07:00
Jean Chalard
123017cc74 Merge "Wipe the application cache selectively" into jb-dev 2012-05-25 04:07:46 -07:00
Jean Chalard
7707e0459f Merge "Cache application info." into jb-dev 2012-05-25 04:07:36 -07:00
Jean Chalard
64766fbcaa am 6691bd67: am 9b93817b: Merge "Get information about the target application." into jb-dev 
* commit '6691bd675a555163aa59c2ac791c6138c1d8a32c':
  Get information about the target application.
 2012-05-25 03:34:46 -07:00
Tadashi G. Takaoka
0dfbde09b2 am 41cf0ced: am b6c314e4: Merge "Clean up some compiler warnings" into jb-dev 
* commit '41cf0ced38912c5f4a6d11a88c0deb4ac4d01860':
  Clean up some compiler warnings
 2012-05-25 03:34:45 -07:00
Jean Chalard
9b93817b7f Merge "Get information about the target application." into jb-dev 2012-05-25 03:28:00 -07:00
Tadashi G. Takaoka
93ebf74bae Clean up some compiler warnings 
Change-Id: I604da15e65fc3cf807ec4033df4e4cd5ef0196fc
 2012-05-25 19:04:54 +09:00
Jean Chalard
eb696d288e Wipe the application cache selectively 
Bug: 6537051
Change-Id: I839d0a98c729f3604582946d70c0140a5cff7dcf
 2012-05-25 18:56:13 +09:00
Jean Chalard
1b1243d61f Cache application info. 
Bug: 6537051
Change-Id: Ieca891235df0d697bdeb0510651b703654fdef38
 2012-05-25 18:54:53 +09:00
Jean Chalard
b224b60c94 Get information about the target application. 
Bug: 6537051
Change-Id: I9fe7a07b5ddf2a423d5764840753ea70544206f1
 2012-05-25 18:41:32 +09:00
Jean Chalard
5ea26193a2 am d8b3e5c6: am 0c207144: Merge "Fix a bug with a concurrent modification of a map." into jb-dev 
* commit 'd8b3e5c69f4de663c748c82155fc3b8854119826':
  Fix a bug with a concurrent modification of a map.
 2012-05-24 03:44:06 -07:00
Jean Chalard
1b06b59e28 Fix a bug with a concurrent modification of a map. 
Bug: 6538848
Change-Id: I1a8422356d9909213e53cfdc8c5bcc12eb48f19d
 2012-05-24 19:38:04 +09:00
Jean Chalard
35dacc8e78 am 9b98c4a8: am 69897af2: Merge "Add new locales for the spell checker." into jb-dev 
* commit '9b98c4a8ce496fa45b8ad6e7da57063c79d1d9e4':
  Add new locales for the spell checker.
 2012-05-24 03:37:22 -07:00
Jean Chalard
69897af20d Merge "Add new locales for the spell checker." into jb-dev 2012-05-24 03:13:56 -07:00
Jean Chalard
d527a15ec4 Add new locales for the spell checker. 
Bug: 6533167
Change-Id: I1581e8446b1af5dc3679e01be16d4fc34af725cc
 2012-05-24 18:45:58 +09:00
Tadashi G. Takaoka
fe36e7fd9b am 9c239184: am 49afe45d: Fix build 
* commit '9c239184530be37fa806cf37a4f19ae0bc824aec':
  Fix build
 2012-05-24 01:21:38 -07:00
Tadashi G. Takaoka
49afe45d8e Fix build 
Follow up of I7822adf407

Change-Id: Iac75c0f2ff2482bce1305c54cb25b708037db6c6
 2012-05-24 17:13:35 +09:00
Tadashi G. Takaoka
516b785ce0 am bc48a8f7: am c60a846e: Fix NPE in Settings.updateCustomInputStylesSummary 
* commit 'bc48a8f7ab0d9003a9c97ceb7d85bcf0502785a6':
  Fix NPE in Settings.updateCustomInputStylesSummary
 2012-05-24 00:50:37 -07:00
Tadashi G. Takaoka
c60a846e21 Fix NPE in Settings.updateCustomInputStylesSummary 
Change-Id: I7822adf407046098f97bf60da9382910c0a40209
 2012-05-24 16:43:13 +09:00
satok
8822d5a346 am 60b2d84d: am 1e1235fe: Merge "Support bigram suggestions in Android spell checker" into jb-dev 
* commit '60b2d84d82ce8fd4a7bf4592d5229ee2436a675c':
  Support bigram suggestions in Android spell checker
 2012-05-23 22:07:06 -07:00
satok
1e1235feeb Merge "Support bigram suggestions in Android spell checker" into jb-dev 2012-05-23 22:02:52 -07:00
satok
315d731d8f Support bigram suggestions in Android spell checker 
Bug: 6136291
Change-Id: Ic278153f95b23e9aa180d1d6b5960785766d96e5
 2012-05-24 12:27:33 +09:00
satok
6d6c070eba am 925212ff: am c54d558e: Cancel adding user history bigram when autocorrection is cancelled 
* commit '925212ff4b3d6ff4182a94a133c0e4a4f23dd6aa':
  Cancel adding user history bigram when autocorrection is cancelled
 2012-05-23 20:19:46 -07:00
satok
c54d558e2e Cancel adding user history bigram when autocorrection is cancelled 
Bug: 6465474
Change-Id: Ifbfe0ddc2ce5fab070939ede3db7bf03a8535a45
 2012-05-24 12:11:02 +09:00
Jean Chalard
bf52a18806 am a6f86554: am 0b6b6ee5: Merge "Notify the dictionary pack about copy failures" into jb-dev 
* commit 'a6f865541bb1f0db7d179d77d6c4fe10a22dc109':
  Notify the dictionary pack about copy failures
 2012-05-23 04:42:35 -07:00
Jean Chalard
0b6b6ee542 Merge "Notify the dictionary pack about copy failures" into jb-dev 2012-05-23 04:12:59 -07:00
Jean Chalard
3abac7e28e Notify the dictionary pack about copy failures 
Bug: 6532896
Change-Id: I57f7b1a400222c89776f9bff652a7da4470232c5
 2012-05-23 18:46:51 +09:00
Tadashi G. Takaoka
ced9f4e385 am 0673e941: am 4cba9f58: Merge "Remove unused private method Suggest.searchBigramSuggestion" into jb-dev 
* commit '0673e941eb26b491f53bbbb2bbdc49bfd07ff973':
  Remove unused private method Suggest.searchBigramSuggestion
 2012-05-23 00:22:20 -07:00
Tadashi G. Takaoka
4cba9f58d4 Merge "Remove unused private method Suggest.searchBigramSuggestion" into jb-dev 2012-05-23 00:17:25 -07:00
Jean Chalard
7555c3bb18 am 41531cfb: am ff4c037c: Merge "Remove an updated dictionary that changed locales" into jb-dev 
* commit '41531cfb7413b22267b17359a76fc47432152d57':
  Remove an updated dictionary that changed locales
 2012-05-23 00:09:51 -07:00
Jean Chalard
ff4c037c9d Merge "Remove an updated dictionary that changed locales" into jb-dev 2012-05-23 00:04:21 -07:00
Jean Chalard
b9e2bce95e Remove an updated dictionary that changed locales 
When a dictionary changes locale, we need to remove the file
that corresponds to the old version. It has a different path
than the new one, so we have to search for it explicitly.

Bug: 6540631
Change-Id: Ie9d63ba636651fe90f8fbb9627b7265ac7b34ccd
 2012-05-23 15:59:49 +09:00
Tadashi G. Takaoka
b5db270962 Remove unused private method Suggest.searchBigramSuggestion 
Change-Id: I077c4c019676fefb8eac6042bd7db1b7ab33ca03
 2012-05-23 15:32:48 +09:00
Tadashi G. Takaoka
307b882c09 am e0e7bba1: am 24ce3645: Merge "Fix RuntiomeException when no custom input style is defined" into jb-dev 
* commit 'e0e7bba154cdc22cf603687eeb8a46e7b57e2eb6':
  Fix RuntiomeException when no custom input style is defined
 2012-05-22 23:17:05 -07:00
Tadashi G. Takaoka
24ce364586 Merge "Fix RuntiomeException when no custom input style is defined" into jb-dev 2012-05-22 23:13:18 -07:00
Tadashi G. Takaoka
d6e238fc33 Fix RuntiomeException when no custom input style is defined 
Bug: 6524480
Change-Id: I6bceea9fe07095b9ff3ed25c5677a82fa5d4086a
 2012-05-23 14:48:16 +09:00
Jean Chalard
008b528cbd am c4f66d32: am 6c034901: Fix an NPE 
* commit 'c4f66d3233159ee224dd0b30dd117fe539af2be6':
  Fix an NPE
 2012-05-22 20:18:01 -07:00
Jean Chalard
6c0349012e Fix an NPE 
Bug: 6538761
Change-Id: Id85486ee93437cfec7db421d5c7f2d7980a7e32e
 2012-05-23 12:05:36 +09:00
Kurt Partridge
8ccc875754 Merge "switch ResearchLogger output to json." 2012-05-22 10:32:23 -07:00
Jean Chalard
906857430b am 37105e86: am 09c4909c: Merge "Remove a high surrogate after a delete if any" into jb-dev 
* commit '37105e8636fc84f9e903581443730a0bf6692996':
  Remove a high surrogate after a delete if any
 2012-05-22 03:38:05 -07:00
Jean Chalard
978c96aa99 Remove a high surrogate after a delete if any 
Bug: 6526328
Change-Id: Iae70cad7b3c114bc13af48ae0eadd52ab88e8471
 2012-05-22 19:04:31 +09:00
Kurt Partridge
07cd1e1731 switch ResearchLogger output to json. 
use multiple logging files, clean up internal nested class structure.

multi-project commit with I1813b6710ef586d96cf8936662f58b870040d6e5

Bug: 6188932
Change-Id: I438790e28f74747c4c1a48a20c1942a0fd818b6c
 2012-05-21 18:45:21 -07:00
Tom Ouyang
c6f4d16826 am b9c597a7: am 2798c85c: Fix cursor leak in ContactsBinaryDictionary 
* commit 'b9c597a72d2e20a23351a832916cea7353f4fc41':
  Fix cursor leak in ContactsBinaryDictionary
 2012-05-21 17:15:28 -07:00
Tom Ouyang
2798c85c0f Fix cursor leak in ContactsBinaryDictionary 
Bug: 6529131
Change-Id: I86493705fbf069ba7a6c43581cfbd1bcc27ff1ba
 2012-05-21 16:50:26 -07:00
Tadashi G. Takaoka
d4577f738b am 82ffc9fe: am 16950d65: Reset automatic upper case when chroding key is pressed 
* commit '82ffc9fe5f7255c902e371bb5353bdef97205fd6':
  Reset automatic upper case when chroding key is pressed
 2012-05-21 14:29:59 -07:00
Tadashi G. Takaoka
1e18869be6 am 2eb4565b: am fc0a0015: Mark UserDictionary and ContactsDictionary as deprecated 
* commit '2eb4565ba33d158520eba693abe3bb263853104e':
  Mark UserDictionary and ContactsDictionary as deprecated
 2012-05-21 14:29:49 -07:00
Tadashi G. Takaoka
865df41ba8 am 647827cc: am 78e3977e: Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK 
* commit '647827cc0171f7dc5d425dea5754fca3df49d036':
  Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK
 2012-05-21 14:29:25 -07:00
Ken Wakasa
1c8d9a33bb am 1dbfbc60: am fd08b439: Tiny comment update to reflect what the class does more accurately. 
* commit '1dbfbc60e7e385455f07ad4c11c34addda5c4902':
  Tiny comment update to reflect what the class does more accurately.
 2012-05-21 14:29:25 -07:00
Tom Ouyang
cfec078d8b am 4bdb2bf3: am e1128687: Merge "Change to a binary version of the expandable user dictionary." into jb-dev 
* commit '4bdb2bf3b9cceb99736a736de42088fcf3bd1a0f':
  Change to a binary version of the expandable user dictionary.
 2012-05-21 14:10:54 -07:00
Tadashi G. Takaoka
6fbb8c8fc3 am 628a5745: am 75c60bf3: Merge "Change auto caps mode argument to int type" into jb-dev 
* commit '628a5745e19d227cdff2370704a4958e2791eb5a':
  Change auto caps mode argument to int type
 2012-05-21 14:10:50 -07:00
satok
ef04186ce8 am 9a06a1e9: am 468ac358: Merge "Add utils for forgetting curve" into jb-dev 
* commit '9a06a1e9eab191838a623aa074c65fd77a2ac7d9':
  Add utils for forgetting curve
 2012-05-21 12:44:31 -07:00
Jean Chalard
45befb946f am 9ad774d1: am 91492993: Merge "Close batch edit" into jb-dev 
* commit '9ad774d1f68bf3d2a4c38e5b4c3a2fa03e371eff':
  Close batch edit
 2012-05-21 12:44:10 -07:00
Tadashi G. Takaoka
9d0c15d9b4 am da3ba3e2: am 8ec3a42d: Merge "Check duplicated entry of "custom input style"" into jb-dev 
* commit 'da3ba3e2549cc69c360fede58b7e170d92e67b0a':
  Check duplicated entry of "custom input style"
 2012-05-21 11:52:36 -07:00
Jean Chalard
c95097f8ef am b7ee6484: am 6139016b: Merge "Fix a bug where the previous word would not be read correctly" into jb-dev 
* commit 'b7ee64844c373a80969d3b98a31e56ecbdfc8bc7':
  Fix a bug where the previous word would not be read correctly
 2012-05-21 11:52:32 -07:00
Jean Chalard
8717ad4cbd am 79daef2e: am 71b047e3: Merge "Don\'t deactivate the LastComposedWord on shift" into jb-dev 
* commit '79daef2e9b29b67048cd052b33c88675a0c62220':
  Don't deactivate the LastComposedWord on shift
 2012-05-21 11:52:11 -07:00
Tadashi G. Takaoka
16950d65c3 Reset automatic upper case when chroding key is pressed 
Bug: 6501446
Change-Id: Idc3b88b5370c0d7968cc388885e9066f922cfcf3
 2012-05-21 19:24:43 +09:00
Tadashi G. Takaoka
fc0a0015f8 Mark UserDictionary and ContactsDictionary as deprecated 
Bug: 6473962
Change-Id: I14477f99f67aedf756d9387ec1d50ef57a1c079e
 2012-05-21 17:04:38 +09:00
Tadashi G. Takaoka
78e3977e90 Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK 
Bug: 6523953
Change-Id: Ibea6c74d00e956116f492a3bedfe40e580b4c316
 2012-05-21 12:24:17 +09:00
Ken Wakasa
fd08b4390e Tiny comment update to reflect what the class does more accurately. 
Change-Id: I9eab3b5d387a5bf5d9b7fce4c1618170a7f34727
 2012-05-20 16:56:29 +09:00
Tom Ouyang
e1128687b1 Merge "Change to a binary version of the expandable user dictionary." into jb-dev 2012-05-18 10:05:11 -07:00
Tadashi G. Takaoka
553e2f19c1 Change auto caps mode argument to int type 
Bug: 6501446
Change-Id: I3f7bc0fc39edd29ebf96107c3d43b9ccc9b8022e
 2012-05-18 17:46:05 +09:00
satok
607a924486 Add utils for forgetting curve 
Bug: 4192129
Change-Id: Iebb7ac355e1c1891da31c33754315bd76a61889b
 2012-05-18 14:50:05 +09:00
Jean Chalard
d4cacb1e41 Close batch edit 
This does the same thing as Ie30e1aff but differently

Bug: 6512086
Change-Id: I47ae990510d3f657abd45ad5f0e325d93dec83c0
 2012-05-18 12:07:58 +09:00
Tom Ouyang
f6adff6227 Change to a binary version of the expandable user dictionary. 
Bug: 6435677
Change-Id: If83409f699608d443796e64a3c65692ae81b98e6
 2012-05-17 15:12:00 -07:00
Tadashi G. Takaoka
8ec3a42d2b Merge "Check duplicated entry of "custom input style"" into jb-dev 2012-05-17 04:36:16 -07:00
Tadashi G. Takaoka
749b2a388e Check duplicated entry of "custom input style" 
Bug: 6495488
Change-Id: Ia6c2421cb0e7c1793d4dfe18acd07fd6f8c5d797
 2012-05-17 20:20:41 +09:00
Jean Chalard
6139016b2b Merge "Fix a bug where the previous word would not be read correctly" into jb-dev 2012-05-17 04:06:54 -07:00
Jean Chalard
6e5ca89050 Fix a bug where the previous word would not be read correctly 
Bug: 6510002
Change-Id: Id30f67e0ca6f7a6fbbbd07922ae19e416c5ef55e
 2012-05-17 20:03:39 +09:00
Jean Chalard
125de3dfdf Don't deactivate the LastComposedWord on shift 
Bug: 6495116
Change-Id: Ib86de02a1216146082bf58a033982ac37fefffe1
 2012-05-17 17:05:30 +09:00
satok
ac067f2db7 am 0028ed36: Use "float" instead of "double" 
* commit '0028ed3627ff4f37a62a80f3b2c857e373cd5090':
  Use "float" instead of "double"
 2012-05-16 05:04:46 -07:00
satok
0028ed3627 Use "float" instead of "double" 
Change-Id: I93ed4d88ede4058f081dd8d634b00dfff4e96d07
 2012-05-16 20:45:05 +09:00
satok
080bc96786 am f837b57b: Merge "Reorder suggestions result according to auto correction threshold" into jb-dev 
* commit 'f837b57bf51b2767ec62a6140b28d84383ad75b1':
  Reorder suggestions result according to auto correction threshold
 2012-05-16 04:42:56 -07:00
satok
f837b57bf5 Merge "Reorder suggestions result according to auto correction threshold" into jb-dev 2012-05-16 04:13:08 -07:00
satok
db1939dbaa Reorder suggestions result according to auto correction threshold 
Bug: 5413904
Change-Id: I3aa3a8109ba45d2129b58d8242866fd3dd3473cb
 2012-05-16 19:58:48 +09:00
Tadashi G. Takaoka
b6d040c57f am b8b9ed81: Merge "Show dialog to guide the user to input subtype enabler" into jb-dev 
* commit 'b8b9ed8187d7d472e7803dd82e68fce7a5816d8e':
  Show dialog to guide the user to input subtype enabler
 2012-05-16 01:57:35 -07:00
Tadashi G. Takaoka
50e373943d am bd85efd5: Merge "Set divider icon\'s alpha value on the fly" into jb-dev 
* commit 'bd85efd5fb70496b05aa7a3dd7646dca894a9464':
  Set divider icon's alpha value on the fly
 2012-05-16 01:57:34 -07:00
Tadashi G. Takaoka
b8b9ed8187 Merge "Show dialog to guide the user to input subtype enabler" into jb-dev 2012-05-16 01:52:25 -07:00
Tadashi G. Takaoka
bd85efd5fb Merge "Set divider icon's alpha value on the fly" into jb-dev 2012-05-16 01:52:19 -07:00
Jean Chalard
93661b3b35 am ed49e4d8: Merge "Stop meaningless bigram computations" into jb-dev 
* commit 'ed49e4d82e3050bcf0e96babb40ce908d03f87f2':
  Stop meaningless bigram computations
 2012-05-16 01:49:08 -07:00
Jean Chalard
ed49e4d82e Merge "Stop meaningless bigram computations" into jb-dev 2012-05-16 01:43:39 -07:00
Tadashi G. Takaoka
1f2d0aa6c9 Set divider icon's alpha value on the fly 
Bug: 6183494
Change-Id: I61a0c7617648d9c52e5001b3479afa0ab4913adc
 2012-05-16 17:41:56 +09:00
Tadashi G. Takaoka
7566448ddf Show dialog to guide the user to input subtype enabler 
Bug: 6370433
Change-Id: Ic5777c1d95fe2ce9f48c72b8cc05c7ac250f4cdf
 2012-05-16 16:19:00 +09:00
Jean Chalard
12fbdfb6f9 am fbecbe84: Merge "Don\'t auto-correct when there is no main dictionary." into jb-dev 
* commit 'fbecbe8474338c237ee6758efe516fad1d58429c':
  Don't auto-correct when there is no main dictionary.
 2012-05-16 00:18:50 -07:00
Jean Chalard
fbecbe8474 Merge "Don't auto-correct when there is no main dictionary." into jb-dev 2012-05-16 00:14:04 -07:00
Jean Chalard
f0e12a9699 Don't auto-correct when there is no main dictionary. 
Bug: 6502485
Change-Id: I5803b0db8552867110587a1140fc03fc2e0eccef
 2012-05-16 16:09:14 +09:00
Tadashi G. Takaoka
fcb81e3171 am b4b3e80f: Merge "Fix empty custom input style entry appears after orientation change" into jb-dev 
* commit 'b4b3e80f1124eaefc4218fbd03a2af2dc4fece17':
  Fix empty custom input style entry appears after orientation change
 2012-05-15 11:37:56 -07:00
Jean Chalard
edcc32802f am 2bbdac53: Merge "Use a formula packing more information into 4 bits field" into jb-dev 
* commit '2bbdac539a7dc5478fd2f28d748b0dcf29eb1dd7':
  Use a formula packing more information into 4 bits field
 2012-05-15 11:37:55 -07:00
Jean Chalard
848081ad8b am 8dced70b: Merge "Read and use user dictionary shortcuts." into jb-dev 
* commit '8dced70b062744a2c27e0cf6dcd0787cf598a97c':
  Read and use user dictionary shortcuts.
 2012-05-15 11:37:54 -07:00
satok
d9c4aa83e1 am 76218b96: Merge "Do not set "SuggestionSpan"s for suggestions from the next word predicition" into jb-dev 
* commit '76218b966a6a712f3baa72d95c6d125d414cdbd4':
  Do not set "SuggestionSpan"s for suggestions from the next word predicition
 2012-05-15 11:37:52 -07:00
Jean Chalard
d09d3598d0 am a9aeb6f3: Merge "Small optimization" into jb-dev 
* commit 'a9aeb6f3ccd2964d79c287860bd660d9f19c8917':
  Small optimization
 2012-05-15 11:37:51 -07:00
Jean Chalard
bc740afba3 am b1120fe7: Merge "Small optimizations" into jb-dev 
* commit 'b1120fe79ac40717b2b91ba60608b2c9f735c368':
  Small optimizations
 2012-05-15 11:37:51 -07:00
Jean Chalard
47fedb8993 am f5ac6c72: Merge "More optimizations" into jb-dev 
* commit 'f5ac6c725a0e12c1ed796de9f255103b957e1724':
  More optimizations
 2012-05-15 11:37:50 -07:00
Jean Chalard
16c34b1bc5 am f184e73d: Merge "Some more obvious optimizations" into jb-dev 
* commit 'f184e73dd77464c53cbfe2815916e826cd32f318':
  Some more obvious optimizations
 2012-05-15 11:37:49 -07:00
Jean Chalard
ee2fc381ba am 78df7181: Merge "Some obvious optimizations to makedict" into jb-dev 
* commit '78df7181ff150596aa62591bfda6255c6517aa59':
  Some obvious optimizations to makedict
 2012-05-15 11:37:49 -07:00
Kurt Partridge
0320c526c2 Merge "include text context in researchLogger" 2012-05-15 10:17:59 -07:00
Tadashi G. Takaoka
b4b3e80f11 Merge "Fix empty custom input style entry appears after orientation change" into jb-dev 2012-05-15 04:23:50 -07:00
Tadashi G. Takaoka
c6846f28ba Fix empty custom input style entry appears after orientation change 
Bug: 6495828
Change-Id: I77c44e24340cff4e0702ac6dee02e4dd84076f3e
 2012-05-15 20:19:31 +09:00
Jean Chalard
2bbdac539a Merge "Use a formula packing more information into 4 bits field" into jb-dev 2012-05-15 03:02:01 -07:00
Jean Chalard
418b343797 Use a formula packing more information into 4 bits field 
Bug: 6313806
Change-Id: Id0779bd69afae0bb4a4a285340c1eb306544663a
 2012-05-15 18:59:21 +09:00
Jean Chalard
a86c0f1ea4 Stop meaningless bigram computations 
Bug: 6313806
Change-Id: Idf765b40812a43de13aa166ed0b44c7b5f7cc218
 2012-05-15 16:34:17 +09:00
Jean Chalard
8dced70b06 Merge "Read and use user dictionary shortcuts." into jb-dev 2012-05-14 20:38:23 -07:00
Jean Chalard
19ad9bf145 Read and use user dictionary shortcuts. 
Bug: 4646172

Change-Id: I51002c73d5bad1a698110c5cda02253348be8eed
 2012-05-15 12:23:43 +09:00
satok
76218b966a Merge "Do not set "SuggestionSpan"s for suggestions from the next word predicition" into jb-dev 2012-05-14 20:14:53 -07:00
satok
0142b997bf Do not set "SuggestionSpan"s for suggestions from the next word predicition 
Bug: 6294817
Change-Id: I5010eafa5ba7e947743706adf7e722f4f0cfb415
 2012-05-15 12:08:31 +09:00
Tom Ouyang
0c5b2a01d4 am 5282f00f: Merge "Contacts dictionary rebuilds only when contact names have changed." into jb-dev 
* commit '5282f00ff871bc0ae8303a2b6dacb283f73e31ea':
  Contacts dictionary rebuilds only when contact names have changed.
 2012-05-14 19:41:34 -07:00
Jean Chalard
a9aeb6f3cc Merge "Small optimization" into jb-dev 2012-05-14 19:11:19 -07:00
Jean Chalard
b1120fe79a Merge "Small optimizations" into jb-dev 2012-05-14 19:11:11 -07:00
Jean Chalard
f5ac6c725a Merge "More optimizations" into jb-dev 2012-05-14 19:11:06 -07:00
Jean Chalard
f184e73dd7 Merge "Some more obvious optimizations" into jb-dev 2012-05-14 19:11:02 -07:00
Jean Chalard
78df7181ff Merge "Some obvious optimizations to makedict" into jb-dev 2012-05-14 19:10:48 -07:00
Kurt Partridge
aec44d50a7 include text context in researchLogger 
when logging LatinIME.onUpdateSelection(), now include the current word and
preceding word.  no escaping of the word is performed; this is temporary
until the output format is cleaned up.

also fix EditingUtils.getWordRangeAtCursor to support supplementary
UTF-16 characters.

Bug: 6188932
Change-Id: If4612a2627537d5d8bb2f9585a3ad1b4e56c2e26
 2012-05-14 09:55:26 -07:00
Jean Chalard
76319c6931 Small optimization 
Performance gain is < 2%

Bug: 6394357
Change-Id: I2b7da946788cf11d1a491efd20fb2bd2333c23d1
 2012-05-14 15:52:01 +09:00
Jean Chalard
4df5b43df8 Small optimizations 
Bug: 6394357
Change-Id: I00ba1b5ab3d527b3768e28090c758ddd1629f281
 2012-05-14 15:51:58 +09:00
Jean Chalard
3b1b72ac4d More optimizations 
We don't merge tails anyway, and we can't do it any more
because that would break the bigram lookup algorithm.
The speedup is about 20%, and possibly double this if
there are no bigrams.

Bug: 6394357

Change-Id: I9eec11dda9000451706d280f120404a2acbea304
 2012-05-14 12:41:18 +09:00
Jean Chalard
12efad3d15 Some more obvious optimizations 
The speedup is about 15%

Bug: 6394357
Change-Id: Ibd57363d9d793206dd916d8927366db4192083b6
 2012-05-14 12:35:31 +09:00
Jean Chalard
47db0be7cb Some obvious optimizations to makedict 
Bug: 6394357
Change-Id: Ibfd98aac2304ef50cf90b1de984736ddcfe7a4bc
 2012-05-14 12:34:05 +09:00
Tom Ouyang
4d289d39ae Contacts dictionary rebuilds only when contact names have changed. 
Bug: 6396600
Change-Id: Iad693ec4bab6351793d624e5c5b0a9f5c12a60e3
 2012-05-11 18:43:53 -07:00
Jean Chalard
19278ea91f am 59e6ad38: Merge "Write the bigram frequency following the new formula" into jb-dev 
* commit '59e6ad38748b0d3c2ed63738d6ab5e6f123466d0':
  Write the bigram frequency following the new formula
 2012-05-11 04:46:21 -07:00
Jean Chalard
59e6ad3874 Merge "Write the bigram frequency following the new formula" into jb-dev 2012-05-11 04:42:36 -07:00
Jean Chalard
f7346de94a Write the bigram frequency following the new formula 
This also tests for bigram frequency against unigram frequency

Bug: 6313806
Bug: 6028348
Change-Id: If7faa3559fee9f2496890f0bc0e081279e100854
 2012-05-11 20:27:22 +09:00
Jean Chalard
e1c75a42c2 am ad0233fa: Merge "Refactor a method" into jb-dev 
* commit 'ad0233fa02985e597054bc50726a412fd8fff371':
  Refactor a method
 2012-05-11 04:13:53 -07:00
Jean Chalard
ad0233fa02 Merge "Refactor a method" into jb-dev 2012-05-11 04:09:17 -07:00
Jean Chalard
4455fe2c89 Refactor a method 
Rename it, rename parameters, and add a parameter that will
be necessary soon.
Also, rescale the bigram frequency as necessary.

Bug: 6313806
Change-Id: I192543cfb6ab6bccda4a1a53c8e67fbf50a257b0
 2012-05-11 19:34:35 +09:00
satok
9978953e29 am 6792a909: Merge "Output caps debug code" into jb-dev 
* commit '6792a909cd0da3db6a957cb2576b4d08f46a53b7':
  Output caps debug code
 2012-05-11 03:33:42 -07:00
satok
59f091875c am 5434f464: Remove unexpectedly split words with single quotes 
* commit '5434f46481c6331c3f107e6940cb49ba9dd5ea4d':
  Remove unexpectedly split words with single quotes
 2012-05-11 03:33:41 -07:00
satok
6792a909cd Merge "Output caps debug code" into jb-dev 2012-05-11 03:06:29 -07:00
satok
5434f46481 Remove unexpectedly split words with single quotes 
Bug: 6451163
Change-Id: I4c5595f727934f2b401e9bb11a6ba613668f4a42
 2012-05-11 18:49:29 +09:00
satok
b6fb5eb391 Output caps debug code 
Change-Id: I4a3399d9066bd28dab893ecebb720924110b871d
 2012-05-11 17:37:14 +09:00
Ken Wakasa
369ab4cd01 am 88794b24: Remove the dependency to SpellCheckerProximityInfo from ProximityInfo. 
* commit '88794b24c0928e3bbea59999fce47c78c028863d':
  Remove the dependency to SpellCheckerProximityInfo from ProximityInfo.
 2012-05-11 01:10:45 -07:00
Ken Wakasa
88794b24c0 Remove the dependency to SpellCheckerProximityInfo from ProximityInfo. 
In conjunction with I596b2deb

Change-Id: I42f059158ae78e1c1c807ed4d3688edbcf18c006
 2012-05-11 17:03:06 +09:00
Tadashi G. Takaoka
7dc925bc9a am 684c519d: Merge "Cleanup indentation" into jb-dev 
* commit '684c519d9d72443b9668fa1474ce2970ceb86a4f':
  Cleanup indentation
 2012-05-10 11:56:23 -07:00
Tadashi G. Takaoka
cee24a1f6c Cleanup indentation 
Change-Id: Iaaade378acb81a2d68e2e721778a82fd8d5e20a5
 2012-05-10 17:48:10 +09:00
Tadashi G. Takaoka
d079a0cde5 am bced8270: Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev 
* commit 'bced82709ad262d59ec523439ea7b22b18c5335b':
  Fix calculation of more keys keyboard position based on key preview
 2012-05-09 10:12:50 -07:00
Tadashi G. Takaoka
bced82709a Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev 2012-05-09 06:04:47 -07:00
Tadashi G. Takaoka
7ecc1081ab Fix calculation of more keys keyboard position based on key preview 
Bug: 6135881
Change-Id: Id1c4e2c13d13b474466cb9b42b425aa9f6f9448b
 2012-05-09 21:23:09 +09:00
Tadashi G. Takaoka
46b26ed892 am c8bde75c: Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev 
* commit 'c8bde75cf455c02efc57c2e35bbe446b83c23739':
  Optimize InputConnection.getCursorCapsMode calling
 2012-05-09 01:55:45 -07:00
Jean Chalard
9648b1674e am d5cd7e64: Small optimization 
* commit 'd5cd7e64aa30096241f63e47a9169699bdd98231':
  Small optimization
 2012-05-09 01:55:44 -07:00
Jean Chalard
4e02b1273b am 442ac5d0: Merge "Don\'t ask for surrounding characters for each keypress" into jb-dev 
* commit '442ac5d0bb96ec257d26b28df2fabefdefe59b96':
  Don't ask for surrounding characters for each keypress
 2012-05-09 01:55:43 -07:00
Tadashi G. Takaoka
3b0f0b57ff am f52aef84: Merge "Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified" into jb-dev 
* commit 'f52aef84a582197d6f8e580044b2d24d2a710cef':
  Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
 2012-05-09 01:55:41 -07:00
Tadashi G. Takaoka
c8bde75cf4 Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev 2012-05-09 00:24:00 -07:00
Tadashi G. Takaoka
03ca17c841 Optimize InputConnection.getCursorCapsMode calling 
Bug: 6464226
Change-Id: I30c1b01be5e1719ded5f7f8a7e24a38e9bbc3637
 2012-05-09 16:19:08 +09:00
Jean Chalard
d5cd7e64aa Small optimization 
Change-Id: I067249976e557b60b606d2153deaeb3c8f1f38ac
 2012-05-09 16:14:25 +09:00
Jean Chalard
736b109e16 Don't ask for surrounding characters for each keypress 
Bug: 6464226
Change-Id: I03745bbcc21e5ec6ca57fa1257bf21c0cd26391a
 2012-05-09 15:19:35 +09:00
Tadashi G. Takaoka
0b831ba2aa Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified 
Bug: 6435484
Change-Id: Iccca7d1b770c547efae0b5e5931cebd910083d40
 2012-05-08 13:20:39 +09:00
satok
725fff0511 am e58f3af8: Treat apostrophe as single quote in spell checker 
* commit 'e58f3af8a7bf852c3b100de1bd85d95d13e0e15e':
  Treat apostrophe as single quote in spell checker
 2012-05-07 06:28:55 -07:00
satok
e58f3af8a7 Treat apostrophe as single quote in spell checker 
Bug: 6435348
Change-Id: Iaaac9042e7e6cb21a3f2243bc6e8e055cc24f74d
 2012-05-07 22:21:55 +09:00
Tadashi G. Takaoka
9fcae31e7e am 165725ab: Fix build 
* commit '165725aba8a179440af9c93869b35f206b2e133f':
  Fix build
 2012-05-06 16:53:43 -07:00
Tadashi G. Takaoka
165725aba8 Fix build 
Related-change: I173a3dc0
Change-Id: I4b5adedb70f7501e84fd3604aa240161c97dc713
 2012-05-07 08:19:17 +09:00
Tadashi G. Takaoka
33e95e9186 am 8e50c5d1: Fix subtype name for a custom input style with en_US and en_GB 
* commit '8e50c5d198f65beb6679a9a1e0102e5fc52d7707':
  Fix subtype name for a custom input style with en_US and en_GB
 2012-05-06 11:33:49 -07:00
Tadashi G. Takaoka
8e50c5d198 Fix subtype name for a custom input style with en_US and en_GB 
This change utilizes "UntranslatableReplacementStringInSubtypeName"
subtype extra value to display keyboard layout name dynamically.

Bug: 6449315
Change-Id: I9ef4c3d66ff9a223aa8c89c346d04cb72e4f6263
 2012-05-07 03:25:08 +09:00
Tadashi G. Takaoka
e14d4f386c am 4e6c6046: Merge "Fix newly created custom input style display name" into jb-dev 
* commit '4e6c60464580213cda67c46499259d2ff0bbc493':
  Fix newly created custom input style display name
 2012-05-06 10:49:45 -07:00
Tadashi G. Takaoka
4e6c604645 Merge "Fix newly created custom input style display name" into jb-dev 2012-05-06 10:46:07 -07:00
Tadashi G. Takaoka
ca93442026 Fix newly created custom input style display name 
This will revert I4263632e

Bug: 6443665
Bug: 6410653
Change-Id: Id9ad1a204ed9802488abfc2c536a95d62d55afe0
 2012-05-07 02:42:08 +09:00
Ken Wakasa
a0fe57a290 am 3665e2a8: Merge "Tidy up the MakedictLog class." into jb-dev 
* commit '3665e2a8fc29c9bbe98d1c73e00af26abd6a5421':
  Tidy up the MakedictLog class.
 2012-05-06 10:36:29 -07:00
Ken Wakasa
3665e2a8fc Merge "Tidy up the MakedictLog class." into jb-dev 2012-05-06 10:31:46 -07:00
Tadashi G. Takaoka
ee3177d64d am 4c9bdcc9: Merge "Fix missing synchronized modifier" into jb-dev 
* commit '4c9bdcc9579288ca379c49d36c0ba0ec81515ef7':
  Fix missing synchronized modifier
 2012-05-06 09:56:31 -07:00
Tadashi G. Takaoka
4c9bdcc957 Merge "Fix missing synchronized modifier" into jb-dev 2012-05-06 09:52:52 -07:00
Tadashi G. Takaoka
66c09113f6 am 90b73b85: Merge "Get subtype name string resource from its own locale" into jb-dev 
* commit '90b73b85e4d1846b84f97fb3b1a5f7897f89b985':
  Get subtype name string resource from its own locale
 2012-05-06 09:49:23 -07:00
Tadashi G. Takaoka
5b2eb0f505 Fix missing synchronized modifier 
Change-Id: Ied70a86bedb08adcf8353b189367172459f55292
 2012-05-07 00:55:01 +09:00
Tadashi G. Takaoka
757c12556b Get subtype name string resource from its own locale 
Bug: 6443655
Change-Id: Ib9ee55178f0d0f885aa0640b9cba4a179cf0c566
 2012-05-07 00:44:54 +09:00
Ken Wakasa
84478103ec Tidy up the MakedictLog class. 
Follow up to I436b2b7b

Change-Id: Id17b134dab2f876b874a505e92a379c8b5567fa4
 2012-05-05 23:40:21 +09:00
Kurt Partridge
5a937aae99 Merge "record full text after finishing session" 2012-05-04 21:09:22 -07:00
Ken Wakasa
e9001d28c4 am 03b423f3: Suppress debug log from makedict in LatinIME 
* commit '03b423f313cccb85890346ec4e6e347335f89fbf':
  Suppress debug log from makedict in LatinIME
 2012-05-04 18:14:36 -07:00
Ken Wakasa
03b423f313 Suppress debug log from makedict in LatinIME 
bug: 6447900
Change-Id: I436b2b7b261b422a7edca9cb99a4689b63877fe0
 2012-05-05 09:28:27 +09:00
Kurt Partridge
d67a248de4 record full text after finishing session 
uses onWindowHidden() callback as proxy for finishing session.

Bug: 6188932
Change-Id: Ic63b47c946ca91fc35f80d71b2f9e24e2d0339ac
 2012-05-04 10:57:50 -07:00
Kurt Partridge
77814c4bb0 associate a per-device UUID with the researchLog 
logged upon starting a session

Bug: 6188932
Change-Id: I197d231fbc1d87cf5a3649b485a9be4b17898ba3
 2012-05-02 18:43:27 -07:00
satok
a814fd0ddd am 9ba92faa: Merge "Fix build breakage" into jb-dev 
* commit '9ba92faa81f864c721ee1a9ba8b97c3ead49a38d':
  Fix build breakage
 2012-05-02 02:18:56 -07:00
satok
9ec06c17d4 Fix build breakage 
Change-Id: I22305137b336c9aab019d044a517ae8bc5fefe45
 2012-05-02 18:14:40 +09:00
satok
34590d6cd1 am 57007ed5: Merge "Workaround return preserved backing view height when the backing view is not ready" into jb-dev 
* commit '57007ed582fbe89b2f2ac24e06a15a4fb5a948df':
  Workaround return preserved backing view height when the backing view is not ready
 2012-05-02 01:44:30 -07:00
satok
57007ed582 Merge "Workaround return preserved backing view height when the backing view is not ready" into jb-dev 2012-05-02 01:42:00 -07:00
satok
f4cf5b9952 Workaround return preserved backing view height when the backing view is not ready 
Change-Id: If4f24500ead516c46e6a93a95291e0897548c2f0
 2012-05-02 17:40:10 +09:00
Kurt Partridge
f000a5cd5a Merge "log packageName in researchLogger on startup" 2012-05-01 18:19:02 -07:00
Tadashi G. Takaoka
ae2388c7f7 Fix checking if subtype belongs to this ime 
Bug: 6422318
Change-Id: I5779c0e277444315191fa964a976dcb4316cc24a
 2012-05-01 20:21:10 +09:00
Jean Chalard
4b5b46bb66 Don't autocorrect after suggestion resuming 
Bug: 6105732
Change-Id: I92e7a9c6d6eb648f747c3b396d7993479fd8478a
 2012-05-01 17:06:29 +09:00
Kurt Partridge
623118fe48 log packageName in researchLogger on startup 
Bug: 6188932

Change-Id: I85f434bf284d6b481893f7d41c884a4f0c57ce49
 2012-04-30 11:21:12 -07:00
Ken Wakasa
0ab1c664c1 Avoid Resources$NotFoundException 
bug: 6410653
Change-Id: I4263632e76b44abf8ecd9114a9eb185ad39201fd
 2012-04-28 03:24:05 +09:00
Jean Chalard
20a6dea1ca Add a flag for bigram presence in the header 
This is a cherry-pick of Icb602762 onto jb-dev.

Bug: 6355745
Change-Id: Icb602762bb0d81472f024fa491571062ec1fc4e9
 2012-04-26 16:40:29 +09:00
Jean Chalard
329c8d7bcc Merge "Ignore bigrams that are not also listed as unigrams" into jb-dev 2012-04-26 00:26:04 -07:00
Tadashi G. Takaoka
45c57dcc2d Merge "Fix SubtypeSwitcher incomplete initialization" into jb-dev 2012-04-25 23:22:06 -07:00
Jean Chalard
44c64f46a1 Ignore bigrams that are not also listed as unigrams 
This is a cherry pick of I14b67e51 on jb-dev

Bug: 6340915
Change-Id: Iaa512abe1b19ca640ea201f9761fd7f1416270ed
 2012-04-26 15:20:30 +09:00
Tadashi G. Takaoka
3d407cc086 Fix SubtypeSwitcher incomplete initialization 
Bug: 6400718
Change-Id: Id5dce156ad397b911bfeaedeeddd4aeb21a10b3a
 2012-04-26 13:41:15 +09:00
Tadashi G. Takaoka
27b42ced86 Fix "no language" subtype name (DO NOT MERGE) 
* Move SubtypeLocale.get{Full,Middle,Short}DisplayName() to
  LatinLeyboardView and add unit tests (SpacebarTextTests).
* Add SubtypeLocale.getSubtypeDisplayName()

This is a cherry-pick of I57420c6a from Master.

Bug: 6393865
Change-Id: I68748189c17c73984ac4ae05a5a40fb54bf46453
 2012-04-26 11:50:28 +09:00
Tadashi G. Takaoka
cbaf6d85f1 Cancel SubtypePreference dialog properly 
Bug: 6384416
Bug: 6387408
Change-Id: Ia7b0653a09410b42a55915815c887bf0ad56c856
 2012-04-25 15:42:14 +09:00
Tadashi G. Takaoka
9f0a137f82 Save & restore additional subtype dialog state when orientation is changed 
Bug: 6384416
Change-Id: Id5fa4742ad900fafb82cc37a0bbb9f380b99254d
 2012-04-25 15:29:05 +09:00
Tadashi G. Takaoka
96e404310d Ignore unknown keyboard layout safely 
Bug: 6393755
Change-Id: I3a74b23f934cd52925026ad04647cc76de92ee07
 2012-04-25 13:34:04 +09:00
Tom Ouyang
ce54a14bed Merge "Change expandable binary dict write to a temp file first." 2012-04-24 10:54:56 -07:00
Tom Ouyang
a9b2be8a81 Change expandable binary dict write to a temp file first. 
Bug: 6380724
Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
 2012-04-24 10:52:53 -07:00
Jean Chalard
805fed49e1 Merge "Fix binary reading code performance." 2012-04-23 23:39:37 -07:00
Tadashi G. Takaoka
fe4d13cbcb Merge "Make the "Touch again to save" hint text touchable." 2012-04-23 23:20:49 -07:00
Jean Chalard
1d80a7f395 Fix binary reading code performance. 
This is not the Right fix ; the Right fix would be to read
the file in a buffered way. However this delivers tolerable
performance for a minimal amount of code changes.
We may want to skip submitting this patch, but keep it around
in case we need to use the functionality until we have a good
patch.

Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
 2012-04-24 15:16:17 +09:00
Jean Chalard
cbebbaf065 Merge "Fix a bug where a node size would be seen as increasing." 2012-04-23 22:19:19 -07:00
Jean Chalard
a64a1a46e4 Fix a bug where a node size would be seen as increasing. 
The core reason for this is quite shrewd. When a word is a bigram
of itself, the corresponding chargroup will have a bigram referring
to itself. When computing bigram offsets, we use cached addresses of
chargroups, but we compute the size of the node as we go. Hence, a
discrepancy may happen between the base offset as seen by the bigram
(which uses the recomputed value) and the target offset (which uses
the cached value).
When this happens, the cached node address is too large. The relative
offset is negative, which is expected, since it points to this very
charnode whose start is a few bytes earlier. But since the cached
address is too large, the offset is computed as smaller than it should
be.
On the next pass, the cache has been refreshed with the newly computed
size and the seen offset is now correct (or at least, much closer to
correct). The correct value is larger than the previously computed
offset, which was too small. If it happens that it crosses the -255 or
-65335 boundary, the address will be seen as needing 1 more byte than
previously computed. If this is the only change in size of this node,
the node will be seen as having a larger size than previously, which
is unexpected. Debug code was catching this and crashing the program.

So this case is very rare, but in an even rarer occurence, it may
happen that in the same node, another chargroup happens to decrease
it size by the same amount. In this case, the node may be seen as
having not been modified. This is probably extremely rare. If on
top of this, it happens that no other node has been modified, then
the file may be seen as complete, and the discrepancy left as is
in the file, leading to a broken file. The probability that this
happens is abyssally low, but the bug exists, and the current debug
code would not have caught this.
To further catch similar bugs, this change also modifies the test
that  decides if the node has changed. On grounds that all components
of a node may only decrease in size with each successive pass, it's
theoritically safe to assume that the same size means the node
contents have not changed, but in case of a bug like the bug above
where a component wrongly grows while another shrinks and both cancel
each other out, the new code will catch this. Also, this change adds
a check against the number of passses, to avoid infinite loops in
case of a bug in the computation code.

This change fixes this bug by updating the cached address of each
chargroup as we go. This eliminates the discrepancy and fixes the
bug.

Bug: 6383103
Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
 2012-04-24 14:04:02 +09:00
Tadashi G. Takaoka
9f763d1445 Make the "Touch again to save" hint text touchable. 
Bug: 6355346
Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
 2012-04-24 13:44:14 +09:00
Tadashi G. Takaoka
3e3bb36f1f Fix NPE in AdditionalSubtypeSettings 
Bug: 6384416
Change-Id: I878071b8b78acce51649f9637b59830ab681c696
 2012-04-24 11:01:45 +09:00
Jean Chalard
fa1affbaec Merge "Fix a bug where two spaces would be added instead of one" 2012-04-23 17:03:32 -07:00
Jean Chalard
5ee0ee0dbe Merge "Fix a bug where a batch edit would not be started." 2012-04-23 17:02:41 -07:00
Jean Chalard
87f7fa12db Merge "Pass words as int[] to the native code." 2012-04-23 17:02:26 -07:00
Tom Ouyang
bebcae8ff5 Merge "Binary bigram lookup checks both uppercase and lowercase when previous word is uppercase." 2012-04-23 09:06:05 -07:00
Jean Chalard
551612dd9e Fix a bug where two spaces would be added instead of one 
Bug: 6378291
Change-Id: Id2453333ae16146f816faf0eb68baa8ea1dd106a
 2012-04-23 18:15:51 +09:00
Jean Chalard
96fb3094aa Fix a bug where a batch edit would not be started. 
This would end up in TextView sometimes calling onUpdateSelection
multiple times (this is the correct behavior for TextView). We now
commit the space and the word in a batch edit, and we only get
onUpdateSelection once.

Bug: 6300527
Change-Id: I9579f3d8f5320c1cc24a7a42f19db8e105eb090d
 2012-04-23 17:45:50 +09:00
Jean Chalard
522a04ea5b Pass words as int[] to the native code. 
We need to get the bigrams during the call to getSuggestions for
bug#6313806. We already give an int[] to getSuggestions and we
wanted to get rid of char[]'s anyway because it doesn't work with
surrogate pairs, so here we go.

Bug: 6313806
Change-Id: I56ce99f1db6b3302cdf42f0527343bded837091e
 2012-04-23 16:05:36 +09:00
Tadashi G. Takaoka
e060d1a540 Merge "Fix using keyboard layout display name in custom input style spinner" 2012-04-22 23:16:57 -07:00
Tadashi G. Takaoka
a245be6819 Fix using keyboard layout display name in custom input style spinner 
Change-Id: I80626591574aa9995011202cf868f9c2c5168303
 2012-04-23 13:54:58 +09:00
Jean Chalard
0df78d46da Use the best matching cached dictionary for each category 
Bug: 6327270
Change-Id: I5a0e732c8a3fd55fd8ac3c8fe1c58e7f91555d97
 2012-04-23 12:37:52 +09:00
Tom Ouyang
0806bb01d9 Binary bigram lookup checks both uppercase and lowercase when previous word is uppercase. 
Bug: 6363029
Change-Id: I71a1ed5b88f54fcc15bfaf89d3645b8f17ebb821
 2012-04-22 17:48:00 -07:00
Ken Wakasa
1894c6e586 Remove unused methods and classes 
Change-Id: I1a82bf2202d436efa4c5135d705a048fe45a0257
 2012-04-22 18:48:54 +09:00
Ken Wakasa
f8ad37a8fc Remove an unused method 
Change-Id: I3abbf6462c31b11167e356fe77b8afca2514a869
 2012-04-22 12:50:01 +09:00
Tadashi G. Takaoka
118762b444 Merge "Predefined keyboard layouts are configurable via XML resource" 2012-04-20 03:24:39 -07:00
Tadashi G. Takaoka
38026b4f03 Predefined keyboard layouts are configurable via XML resource 
Bug: 4460018
Change-Id: Ia03ec826fb3853ea814d9764686903dbe31a6507
 2012-04-20 19:19:24 +09:00
Jean Chalard
04b03f4dd6 Allow using a format version 2 word list in LatinIME 
Change-Id: I73a4df3a83e49be6e8d3a7d14eb027cfe10f1a23
 2012-04-20 18:56:03 +09:00
Tadashi G. Takaoka
78173bdf53 Support Dvorak layout 
Bug: 4460018
Change-Id: I08a9b556720f6c4f7089a8838c0869c9f88f479c
 2012-04-20 17:28:32 +09:00
Jean Chalard
29a1fc0f6b Don't allow cancelling manual pick. 
Bug: 6347202
Change-Id: I30b53256e83c534436b0f0ff594fd4aaabf4558c
 2012-04-20 15:55:45 +09:00
Kurt Partridge
5b92113cdb Merge "remove unnecessary KeyboardState logging" 2012-04-19 20:53:44 -07:00
Kurt Partridge
4d43d6f96e Merge "researchLogger detail on IME sessions" 2012-04-19 20:35:21 -07:00
Kurt Partridge
c59d74ce47 remove unnecessary KeyboardState logging 
Bug: 6188932
Change-Id: Iafbb1825777122a1810fa3339853263aced3077e
 2012-04-19 20:32:37 -07:00
Kurt Partridge
48a7681e06 researchLogger detail on IME sessions 
log device type, screen size, etc.  also simplification inside ResearchLogger
to use exceptions better, and fix ResearchLoggerTests to not change
preferences to specify the logfile.

multi-project change with Idfd193b16260215cca32886e288f03a0c12b2781

Bug: 6188932
Change-Id: Idd3ca6eb8e8e3934f68234b241c7fd7d0cc3bcd5
 2012-04-19 20:19:55 -07:00
Tom Ouyang
7cdb560513 Merge "Change binary dictionary output buffer size to match dictionary size." 2012-04-19 17:18:59 -07:00
Tom Ouyang
df7ebbbd61 Change binary dictionary output buffer size to match dictionary size. 
Bug: 6355943
Change-Id: Iaab7bc16ba0dbc7bfde70b06e7bd355519838831
 2012-04-19 10:18:57 -07:00
Tadashi G. Takaoka
6a7019ff5d Move main dictionary availability check to LatinIME 
Change-Id: Ib6183fec833d87bc32514b03bb691fec0a1e6ff8
 2012-04-19 23:23:26 +09:00
Tadashi G. Takaoka
65e93e352f Fix SubtypeSwitcher to honor subtype 
Bug: 6364170
Change-Id: I31f9a7c9b6b4ca04a1c78a4210dcaae0db9825db
 2012-04-19 22:42:14 +09:00
Tadashi G. Takaoka
b9fca7a192 Fix stack overflow 
Change-Id: I977b240ea462b40852ba9504282312d5fa4e2885
 2012-04-19 20:21:02 +09:00
Tadashi G. Takaoka
ab39afca23 Remove LatinIME reference from DictionaryFactor class 
Change-Id: Iad10e71baa81a1b4eb3c84ead47d658d567b8201
 2012-04-19 19:57:43 +09:00
Tadashi G. Takaoka
1cb08acaf3 Add Constants class to hold public constants 
This change also gets rid of compiler warnings about "deprecations".

Change-Id: Id9b83483c453a81ebac34b684656db05e3599657
 2012-04-19 19:45:19 +09:00
Tadashi G. Takaoka
c27fe6253c Add custom subtype settings 
Bug: 4460018
Change-Id: I4919d79516dcf574be2761bbaf9adcdc381b2ddc
 2012-04-19 19:33:51 +09:00
Tadashi G. Takaoka
344af15674 Change predefined additional subtype format in preference 
This change also refactor StringUtils class

Change-Id: Ie0b4d169b21c260bf238d6fcc9ab0ee8bfd6b508
 2012-04-19 17:11:21 +09:00
Tadashi G. Takaoka
f5a0bd2c28 Make predefined subtype configurable by XML resource 
Change-Id: I1f8486a1fb652f1e06789e7bfd2cc57273092234
 2012-04-18 22:45:26 +09:00
Tadashi G. Takaoka
55d28fd1b2 Cleanup InputMethodManagerCompatWrapper 
Change-Id: Id3b84ee19bb504ed8fbb398e260cc663a5b5ae0d
 2012-04-18 18:01:29 +09:00
Tadashi G. Takaoka
a58ebc73ae Fix typo of some methods' name 
Also changes some methods' argument type from Locale to String.

Change-Id: Ib68b528a450dc68a01546483403230f76500bee4
 2012-04-18 16:40:50 +09:00
Kurt Partridge
d442984e96 researchLogging for inputConnection events 
Bug: 6188932
Change-Id: I596df68956abd879293cfb550e66e7d7d0ba74e9
 2012-04-17 20:05:10 -07:00
Tadashi G. Takaoka
18178fefdc Merge "Remove useless key event handling methods" 2012-04-17 19:58:05 -07:00
Tadashi G. Takaoka
79e07e3f84 Remove useless key event handling methods 
Change-Id: I8c42fba79aba643ab7a145e6fd54ef23855a3ad0
 2012-04-18 11:55:11 +09:00
Jean Chalard
bde232dcaa Merge "Pass the previous word down to native code in getSuggestions" 2012-04-17 18:01:05 -07:00
Tadashi G. Takaoka
69bcc15cb3 Add SubtypeUtils.setAditionalInputMethodSubtypes method 
Change-Id: Ia3043346ed87297e01d505980555fdf29ce4f96f
 2012-04-17 22:48:00 +09:00
Jean Chalard
80111f08e2 Pass the previous word down to native code in getSuggestions 
Change-Id: I477b631d81ef58461e44954f3ae5fd895928bb97
 2012-04-17 20:07:10 +09:00
satok
74a84febc7 Cache results of the spell checker 
Change-Id: Ie11cd1b07e069474b140fbaae65fca703adc056f
 2012-04-17 19:45:57 +09:00
Tadashi G. Takaoka
761b6bc120 Merge "Add SubtypeLocale.getKeyboardLayoutSetDisplayName" 2012-04-17 03:08:59 -07:00
Tadashi G. Takaoka
bb17bafac3 Add SubtypeLocale.getKeyboardLayoutSetDisplayName 
Change-Id: I576b47a936545e653ce9e26222ba4db143ea90e6
 2012-04-17 18:55:51 +09:00
Jean Chalard
1277692519 Merge "Pass the previous word to getSuggestions" 2012-04-16 20:56:03 -07:00
Jean Chalard
ac27e4544b Pass the previous word to getSuggestions 
This is a preparative change to bug#6313806

Change-Id: I1be9ec49b21005c1f45ce459fa93712bc74ef3f0
 2012-04-17 12:43:53 +09:00
Kurt Partridge
9bfb620215 add logPoint for manual correction (inc touch pos) 
Bug: 6188932
Change-Id: Ibcc4901bcfab6632ee4c59cb58d35452218a288d
 2012-04-16 16:52:25 -07:00
Tadashi G. Takaoka
8b833071a1 Fix Settings fragment isn't shown on tablet 
Bug: 6341510
Change-Id: I319bb72400995d8385b0b14ef25b164dee3974da
 2012-04-16 16:36:28 +09:00
Tadashi G. Takaoka
11a40a047f Make Utils.getDeviceOverrideValue aware of device orientation 
Bug: 6277225
Change-Id: If41fe5cbee0985b9a4740dcd5d1c6ba73b94b377
 2012-04-16 12:59:55 +09:00
Tom Ouyang
a7352c8df4 Merge "Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams." 2012-04-13 18:30:19 -07:00
Tom Ouyang
18222f8c86 Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams. 
Bug: 6188977
Change-Id: I753422eed1effaeb5fd01124cf1ddd1e31ee9d60
 2012-04-13 17:54:39 -07:00
Kurt Partridge
2783c51e6d Merge "clean up researchLogging of autocorrection" 2012-04-13 10:47:19 -07:00
Tadashi G. Takaoka
c206d04623 Use InputMethodSettingsFragment for IME settings 
Change-Id: Id6d9cd0ddf99c0687b6d3ea4b2f868f6cf2a0eaf
 2012-04-13 19:56:47 +09:00
Tadashi G. Takaoka
f6972561fc Utilize InputMethodSubtype and additional subtype 
* Remove de_QY and fr_CH from supported subtypes
* Add de-qwerty and fr-qwertz predefined additional subtypes instead.

Change-Id: I49e8ba0299529302f2b91b4d018b07304cdd6897
 2012-04-13 18:36:26 +09:00
Tadashi G. Takaoka
8abde7db6b Refatcor InputMethodSubtype related stuff a bit 
Change-Id: Iaded72331660afbaeddda085f2b633b681d4b6df
 2012-04-13 16:24:11 +09:00
Kurt Partridge
60adb87574 clean up researchLogging of autocorrection 
remove dependence of ResearchLogger on LatinImeLogger
for autocorrection

multi-project commit with I32cc134b

Bug: 6188932
Change-Id: Iaeda97eb43fa4782db2d1b2a6d8d09a93b395111
 2012-04-12 22:59:21 -07:00
satok
cf6b2099be Add isDictionaryAvailable to SubtypeSwitcher 
Change-Id: I534878d330b57bbfaa8b7711082456969771f4dc
 2012-04-12 19:46:02 +09:00
Jean Chalard
cec8552b18 Pass a parameter to the dict pack if we don't have a default dict 
Also, optimize quite a bit the code that decides whether we have
a default dict or not.

Bug: 5705834
Change-Id: Ied20fbcbbc42cbe8c01759d11b1804d1156c6960
 2012-04-12 13:05:31 +09:00
Kurt Partridge
fed44d08d8 Merge "change ResearchLoggerTests to check file" 2012-04-11 13:19:52 -07:00
Kurt Partridge
b8e2ae3bc3 change ResearchLoggerTests to check file 
multi-project commit with I587003f2

Bug: 6188932
Change-Id: I3d3f0c9d011301489473dc330338ea4a7ba61e9e
 2012-04-11 11:17:44 -07:00
Jean Chalard
e6269759d6 Read the dictionary resource in a more sensical place. 
We don't need to pass this down all the way from LatinIME any more.
It fetched be done exactly where it needs to be.

Change-Id: I9f277f9c4f9de70ae755a1334d86c67bbb24c988
 2012-04-11 21:03:21 +09:00
Tadashi G. Takaoka
78ab80844b Add language suffix to main dictionary 
Bug: 6319377
Change-Id: Ie6a887fefa12e33c17bfeb5d22984e7c1a7bdb46
 2012-04-11 16:11:34 +09:00
Tadashi G. Takaoka
2be51f4fd0 Generate KeyboardLabelsSet from donottranslate-more-keys.xml 
This change introduces makelabel tool that reads all languages'
donottranslate-more-keys and generate KeyboardLabelsSet.java source
file. The makelabel command must be invoked prior to compile LatinIME.

Change-Id: I7515c7919c535e30f9c80a37bdc831d0f682cd43
 2012-04-11 11:23:47 +09:00
Tom Ouyang
ecd2ac93bc Add an expandable binary dictionary that can be modified at runtime and works with native algorithms. 
Bug: 6188977
Change-Id: Iec5c4e7d1d3918ac645187bd32dc3f82a95fec1e
 2012-04-10 10:17:52 -07:00
Kurt Partridge
a9ca7867b5 move suggested words logpoint to SuggestionsView.java 
Bug: 6188932
Change-Id: I73974783783bb4453962cb9009656d86d2074409
 2012-04-09 16:24:29 -07:00
Kurt Partridge
9bc29d78a6 add more data collection points to ResearchLogger (attempt #2) 
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.

multi-project change with I159f5de2

this CL is the same as I618bcd07, which was reverted because of
incompatibilities with vendor branches.

Bug: 6188932
Change-Id: I999249dceb0c04f5a4ffbfff25caed09d24a2c52
 2012-04-09 09:38:07 -07:00
Kurt Partridge
d16bda4a4a Revert "add more data collection points to ResearchLogger" 
This reverts commit ac9e87c03e
 2012-04-06 18:26:34 -07:00
Kurt Partridge
ac9e87c03e add more data collection points to ResearchLogger 
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.

Bug: 6188932
Change-Id: I618bcd07b22c9efc794745678b073afe1e79a697
 2012-04-06 09:35:13 -07:00
Jean Chalard
b5e1f48987 Remove the now useless Flag class. 
Change-Id: Ibe45189b73e2606cf77e30da166dd0d45ae47c5c
 2012-04-06 19:47:16 +09:00
Jean Chalard
338d3ec725 Replace the flags in getSuggestions with a boolean. 
Change-Id: I0ec44df1979cb1dc21017ea290d2151a2af0e7cd

Conflicts:

	java/src/com/android/inputmethod/latin/Suggest.java
 2012-04-06 19:34:48 +09:00
Jean Chalard
24aee9100e Change the flags to a boolean in constructors. 
Change-Id: I9939204f3b16346aaebd4d726315ba9c4faf910a
 2012-04-06 19:33:01 +09:00
Jean Chalard
f420df2823 Add support for German umlaut and French ligatures flags 
Bug: 6202812
Change-Id: Ib4a7f96f6ef86c840069b15d04393f84d428c176
 2012-04-06 17:07:29 +09:00
Jean Chalard
b8060399c7 Remove constructors 
And small cleanup.

Change-Id: I1de903f42c1b8d57a488be2162e0b94055a6d1f2
 2012-04-06 16:53:15 +09:00
Jean Chalard
8cf1a8d04f Remove the shortcutOnly attribute which is now useless. 
Change-Id: Ifccdfdaf7c0066bb7728981503baceff0fedb71f
 2012-04-06 16:27:53 +09:00
Tadashi G. Takaoka
b6313f7275 Merge "Cleanup unused methods" 2012-04-05 23:46:56 -07:00
satok
7540fd009d Merge "Fix the locale of the flags in BinaryDicitonary for tests" 2012-04-05 22:33:17 -07:00
Tadashi G. Takaoka
a4c7733cf7 Cleanup unused methods 
Change-Id: Ic7c1ec0e0606da6eb5b954934547c6e8a561fed5
 2012-04-06 12:27:53 +09:00
Tadashi G. Takaoka
fc169c726a Merge "Use keyboardSet extra value of subtype to specify layout type" 2012-04-05 19:17:30 -07:00
Jean Chalard
af7d86c5b8 Merge "Update the names and default values of bigram options." 2012-04-05 05:08:56 -07:00
Jean Chalard
80f2ccc236 Update the names and default values of bigram options. 
Bug: 6293595

Change-Id: I9978a1127c64b7a26a5ccf6f777366f7c4e214db
 2012-04-05 21:07:40 +09:00
Ken Wakasa
aa300bb73a Don't draw red underline for manually picked words that came from bigram prediction 
Change-Id: I544680c8b4b1baff71bd08168630a34e803c40b9
 2012-04-05 20:50:27 +09:00
Tadashi G. Takaoka
11d9ee742f Use keyboardSet extra value of subtype to specify layout type 
Change-Id: Ice1f345a08a8d760e3b847c885c4072e3e142c97
 2012-04-05 17:25:15 +09:00
satok
ae234abd21 Fix the locale of the flags in BinaryDicitonary for tests 
Bug: 6129372
Change-Id: I5611f88b10c44261b6145c9dc8615b80e4341e77
 2012-04-05 12:48:30 +09:00
Tadashi G. Takaoka
cb389ef0d6 Refactor to utilize InputMethodSubtype 
Change-Id: I76fbc8a395eb8dab996c02c86d7328f07865f8cf
 2012-04-05 12:27:27 +09:00
satok
43ebd8a035 Fix the locale of flags in BinaryDictionary 
Bug: 6129372
Change-Id: I4958c2aabf651d7e26648a29b75fcc6c77813451
 2012-04-04 21:50:42 +09:00
Tadashi G. Takaoka
b082c95a2b Use no language "zz" to disable shortcut key 
Change-Id: Ifba5bbd4298ecf84cc5e0ebdb4fc8494eafff62e
 2012-04-04 14:35:55 +09:00
Tadashi G. Takaoka
c7e43a7aec Merge "Use language agnostic QWERTY for forceAscii" 2012-04-03 21:06:52 -07:00
Tadashi G. Takaoka
234bf612ca Merge "Use "No language (QWERTY)" for language agnostic QWERTY keyboard name" 2012-04-03 21:03:10 -07:00
Tadashi G. Takaoka
32bfc1601a Use language agnostic QWERTY for forceAscii 
Bug: 6286208
Change-Id: I1b3b6f04c9033e7dc57a30e8dce43e01428b8e4e
 2012-04-04 12:59:58 +09:00
Tadashi G. Takaoka
3bf57a5624 Use "No language (QWERTY)" for language agnostic QWERTY keyboard name 
Bug: 6010147
Change-Id: I401c2e3fcd639c0e1a03e64489a0d792810caa18
 2012-04-04 12:58:42 +09:00
satok
d8af793983 Merge "Fix NPE in SuggestedWords" 2012-04-03 19:23:03 -07:00
satok
f088204a90 Fix NPE in SuggestedWords 
Bug: 6279966
Change-Id: Ia94a78d79cc51014126d18612aabdc7ce51487a4
 2012-04-04 11:09:13 +09:00
Tadashi G. Takaoka
d2c5533fd9 Merge "Add RunInLocale class to guard locale switching" 2012-04-03 01:53:05 -07:00
Tadashi G. Takaoka
56dda78d52 Merge "Cleanup InputTypeCompatUtils to InputTypeUtils" 2012-04-03 01:50:08 -07:00
Tadashi G. Takaoka
16c6f35570 Add RunInLocale class to guard locale switching 
Bug: 6128216
Change-Id: I8d9c75c773c3de886183b291ada7a3836295839b
 2012-04-03 17:43:45 +09:00
Tadashi G. Takaoka
be55086fd9 Cleanup InputTypeCompatUtils to InputTypeUtils 
Bug: 6129704
Change-Id: I45e19e456ef7c6e61fe877ea544fef1b9f896e95
 2012-04-03 17:42:19 +09:00
Tadashi G. Takaoka
b07939764a Merge "Fix typo" 2012-04-03 01:31:47 -07:00
Tadashi G. Takaoka
8f433a66b2 Fix typo 
Follow up for I5b9964f2
Bug: 6129704

Change-Id: Ia90c013cf4c4e6f675da5701644bd10833898c3f
 2012-04-03 17:27:51 +09:00
Tadashi G. Takaoka
244c825c4b Merge "Cleanup EditorInfoCompatUtils" 2012-04-03 00:49:55 -07:00
Tadashi G. Takaoka
7a0779a441 Merge "Cleanup FrameLayoutCompatUtils to ViewLayoutUtils" 2012-04-03 00:47:32 -07:00
Tadashi G. Takaoka
0d1a5d5b97 Cleanup EditorInfoCompatUtils 
Bug: 6129704
Change-Id: I5b9964f2ad52e7cd60c63acca93d0241a1e729ef
 2012-04-03 16:45:36 +09:00
Tadashi G. Takaoka
13d6ecc4c2 Remove InputMethodServiceCompatWrapper 
Bug: 6129704
Change-Id: I76f2854e27623be940a711d0d48fd3f90132141c
 2012-04-03 16:02:09 +09:00
Tadashi G. Takaoka
8443af57ba Merge "Remove InputMethodSubtypeCompatWrapper" 2012-04-02 23:57:43 -07:00
Tadashi G. Takaoka
9cc2c94c8b Remove InputMethodSubtypeCompatWrapper 
Bug: 6129704
Change-Id: I8f84f0f61a2205ac1fcd1cd40e3a586ee535282d
 2012-04-03 15:31:26 +09:00
Jean Chalard
c734c2aca1 Add a simple way to input dictionary header attributes 
Just add them as an attribute to the root of the XML node.

Bug: 6202812
Change-Id: Idf040bfebf20a72f9e4370930a85d97df593f484
 2012-04-03 15:18:51 +09:00
Tadashi G. Takaoka
19457316c1 Remove CAN_HANDLE_ON_CURRENT_INPUT_METHOD_SUBTYPE_CHANGED boolean 
Bug: 6129704
Change-Id: I7643e656c6e7656eff339cc301dd32f34dee83a4
 2012-04-02 23:22:49 +09:00
Tadashi G. Takaoka
b1904ec235 Merge "Remove InputMethodInfoCompatWrapper" 2012-04-02 07:14:20 -07:00
Tadashi G. Takaoka
c8461d1ae2 Cleanup FrameLayoutCompatUtils to ViewLayoutUtils 
Bug: 6129704
Change-Id: I52f2e236c7dae3ac2cba64392165f955a53d3f42
 2012-04-02 22:55:12 +09:00
Tadashi G. Takaoka
0dbf6ab53d Remove InputMethodInfoCompatWrapper 
Bug: 6129704
Change-Id: I0eca1ee7d1769ddc44f93c50f0723196299bc6d6
 2012-04-02 21:33:49 +09:00
satok
7e518d8b83 Combine candidate words and scores 
Bug: 5240798
Change-Id: Ie56c1c2cfd7f365e771fee88c1ed15012448feed
 2012-04-02 18:39:24 +09:00
satok
209dd09e5a Come back the proximity correction to ExpandableDictionary 
Bug: 6242539
Change-Id: Ic0467d54c9d85d0653812d4e127328878ef15b94
 2012-04-02 15:01:21 +09:00
Ken Wakasa
96fdc4dd84 Remove InputConnectionCompatUtils 
Also, small cleanup in proguard.flags

bug: 6129704
Change-Id: If4cc694dbe74b26b1d0da301bbc321ee7afc0211
 2012-03-31 19:04:38 +09:00
Ken Wakasa
672635493e Remove ArraysCompatUtils 
bug: 6129704
Change-Id: I0f1a0dee744e6dcdea7ae8606119b4af22b86663
 2012-03-30 22:50:53 +09:00
Ken Wakasa
376eb52450 Move VibratorCompatWrapper to VibratorUtils. 
bug: 6129704

Change-Id: Ib63f1ed2d610e27e14957cf8805ef884cae6adf6
 2012-03-30 19:23:12 +09:00
Tadashi G. Takaoka
fb5b4c4fc3 Add language agnostic QWERTY subtype 
Bug: 6010147
Change-Id: I705e38ac889172ae8b7c2a68e5c688f2ffc28320
 2012-03-30 18:20:52 +09:00
Ken Wakasa
911b8f9d19 Remove the "deprecated" classes 
bug: 6129704
Change-Id: Ib27f2774444e1f084b19be3fe6f56d25dffa7084
 2012-03-30 16:20:56 +09:00
Kurt Partridge
347fcab043 improve ResearchLogger performance 
also demonstrate proposed logpoint invocation

Bug: 6188932
Change-Id: Ib6a7a196fe2e5f8184d26d1e0e3e91b404454112
 2012-03-29 15:37:41 -07:00
Tadashi G. Takaoka
8acbce1f78 Merge "Separate leftward arrow from "add to dictionary" hint text" 2012-03-29 01:20:07 -07:00
Tadashi G. Takaoka
20b4c223b4 Merge "Fix some obvious compiler warnings" 2012-03-29 00:18:36 -07:00
Tadashi G. Takaoka
499c5e8ad8 Merge "Don't send touch coordinates if proximity characters correction is disabled" 2012-03-29 00:18:28 -07:00
Tadashi G. Takaoka
8dcad2ed47 Don't send touch coordinates if proximity characters correction is disabled 
Bug: 6225317
Change-Id: I4fa65e020d838f53066d4a071f58fb6f40583e0b
 2012-03-29 16:11:54 +09:00
Tadashi G. Takaoka
aaa9e8626a Merge "Fix race condition while changing the system locale" 2012-03-29 00:10:35 -07:00
Tadashi G. Takaoka
2eb8781dc2 Separate leftward arrow from "add to dictionary" hint text 
Bug: 6008875
Change-Id: I2be1698e485bc6541163771f41b8b82eaa3cee7a
 2012-03-29 15:58:26 +09:00
Tadashi G. Takaoka
c61cd79229 Fix some obvious compiler warnings 
Change-Id: I10a634f7492b45d5a72345f14d36cf341946387d
 2012-03-29 15:07:53 +09:00
Tadashi G. Takaoka
7769b76fc9 Fix race condition while changing the system locale 
Bug: 6128216
Change-Id: Ie153e3eb18feeb97aada6a7708075f5152f11999
 2012-03-29 14:36:45 +09:00
Kurt Partridge
2d9483ff16 make ResearchLogger log write only 
Bug: 6188932
Change-Id: I8a8f944b1d4ee858d5ecaad0d3adc6dc7af54f68
 2012-03-28 17:36:05 -07:00
Jean Chalard
428484d6f9 Merge "Remove useless adding of shortcut as unigrams." 2012-03-28 04:41:05 -07:00
Jean Chalard
e705a122d1 Remove useless adding of shortcut as unigrams. 
Change-Id: I1f50ebf00d6dd0dad4114fad86ace5b7b304613a
 2012-03-28 20:40:38 +09:00
Jean Chalard
aacffad8ef Merge "Add read support for string shortcuts for makedict." 2012-03-28 04:40:28 -07:00
Jean Chalard
752996540f Add read support for string shortcuts for makedict. 
Change-Id: I48ee4fc9ac703ad2a680b3cd848de91c415ea3c8
 2012-03-28 20:40:08 +09:00
Jean Chalard
7b49efdea6 Merge "Change the format of the shortcuts in the binary dict." 2012-03-28 04:39:55 -07:00
Tadashi G. Takaoka
a501caa9a5 Merge "Remove SupportTouchPositionCorrection from subtype extra value" 2012-03-28 04:36:27 -07:00
Jean Chalard
3bbb31f3f0 Change the format of the shortcuts in the binary dict. 
This only includes the write part of the change. The read part is
coming in a different commit.

Change-Id: Iabe7af6cd134462dc19245f5400719920ed31c8f
 2012-03-28 20:24:07 +09:00
Tadashi G. Takaoka
e07db71d26 Remove SupportTouchPositionCorrection from subtype extra value 
Change-Id: Ieedff9ec212f5567405ca276b0f2194132ba7b0c
 2012-03-28 19:45:28 +09:00
satok
6ba8de2a60 Good bye the proximity logic in Java code 
Bug: 4343280
Change-Id: I82f7d08703647a3492ce6e2d3b741146df58927e
 2012-03-28 18:42:30 +09:00
satok
67094f5bde Do not re-calculate primary code in WordComposer 
Bug: 4343280
Test: Ib43c0f1d1a19d067ea0

Change-Id: I3393a6099cb7fb824994f4656ccfef884f9c6bc4
 2012-03-28 17:23:10 +09:00
satok
9611b281e1 Fix AIOOBE 
Bug: 6236912
Change-Id: Ie09e5ef1c23eb48621ac3f2f2dc28dc2e46ca288
 2012-03-28 13:02:14 +09:00
Ken Wakasa
f71aee8f4f Tighten up the "define" classes. 
Change-Id: I854b1dd56b676d0a492a15c16bfe4c6a1bcccdf7
 2012-03-27 22:43:25 +09:00
satok
0a1b00869d Merge "Put a misspelled flag if the word is not valid by the same logic of Android spell checker." 2012-03-27 01:16:54 -07:00
satok
356776a9b7 Put a misspelled flag if the word is not valid by the same logic of Android spell checker. 
Bug: 6222722

Currently, the flags of the suggestion span from the Latin IME is different from the flags from Android spell checker.

Change-Id: I2f7a54ae0d63235a0b94e039109ab8b2f1311055
 2012-03-27 17:11:48 +09:00
satok
01ab7c8b59 ongoing cleanup 2 
Change-Id: I66b61cbe491cf8375144e834390beae3209a777d
 2012-03-27 16:28:48 +09:00
Ken Wakasa
c166697e3f Optimization: Start making use of ProductionFlag.IS_EXPERIMENTAL for ResearchLogger 
Move GodMode specific tests to relevant directories as well.

This goes along with I9dc4d469

Change-Id: I4a21c53846b26eede346cb1da13e6abbdf9ec27f
 2012-03-27 11:55:23 +09:00
satok
2ac1fad645 Merge "Add a flag file for the experimental mode" 2012-03-26 04:53:49 -07:00
satok
9b2f77f2b1 Add a flag file for the experimental mode 
Change-Id: I880b7c85dbc20f8d7590b7f65b5f898bfb2266f9
 2012-03-26 18:52:46 +09:00
Jean Chalard
d2cd3d54f9 Merge "Split a method for reuse" 2012-03-26 02:12:20 -07:00
Kurt Partridge
400ff86c7b Merge "add tests for ResearchLogger" 2012-03-26 01:49:09 -07:00
Kurt Partridge
2482e6c386 add tests for ResearchLogger 
Bug: 6188932
Change-Id: Icf407f9d145d2b25b70d5d7bc30ee3d64561620c
 2012-03-26 17:21:50 +09:00
Jean Chalard
8403611960 Split a method for reuse 
Change-Id: I9a82e538903f05bedad51bc195866abbd9daf957
 2012-03-26 16:34:29 +09:00
Jean Chalard
a77bbc64f0 Merge "Correct a shaky processing and move it to a better place" 2012-03-25 17:57:49 -07:00
Kurt Partridge
e327628855 update ResearchLogger times to report SystemClock.uptime() 
Bug: 6188932
Change-Id: I852537caed46958e4d9c3251664edaa69652205c
 2012-03-24 22:41:11 +09:00
Kurt Partridge
d05afa3f4c move usability log code to new class (ResearchLogger) and clean api 
This change also undoes the effects of I8694eb9016, which was an initial
effort built on Utils.UsabilityStudyLogs.  Now Utils operates as it did
previously, for backward compatibility, but the ResearchLogger retains
the new log format.

Coordinated with  I274b75c5.

Bug: 6188932
Change-Id: I41208bdc6b511f69a010c9fc38a936521beba7d5
 2012-03-24 20:14:42 +09:00
Jean Chalard
08baf5ff8e Merge "Fix a native crash" 2012-03-23 06:40:50 -07:00
Jean Chalard
b0b89c87f6 Fix a native crash 
-1 & 0xFFFF is 65536 :p

Change-Id: I8ecb882b6d6c5bcc91b52e23eb9cc02b04fcdd34
 2012-03-23 22:36:00 +09:00
Tadashi G. Takaoka
fce9ca4202 Merge "Remove verbose debug message" 2012-03-23 06:25:13 -07:00
Tadashi G. Takaoka
61f24842c7 Remove verbose debug message 
Change-Id: I05bfe24228a6fbe806987d2a0d81e59611c3b476
 2012-03-23 22:23:56 +09:00
Jean Chalard
380ad509e6 Merge "Optimization and typo fix" 2012-03-23 06:20:58 -07:00
Tom Ouyang
b163f91621 Merge "Add support for updating and adding bigrams to existing nodes." 2012-03-23 05:57:55 -07:00
Tom Ouyang
7cfe20efbe Add support for updating and adding bigrams to existing nodes. 
Bug: 6188977
Change-Id: I48aca8ba199247d73395ab13b9d1976f4e739208
 2012-03-23 21:52:39 +09:00
Jean Chalard
71f9d30b18 Correct a shaky processing and move it to a better place 
The old code would remove caps from the first letter if
auto-capsed but that makes very little sense when the word
is camel-cased. Also, it would not correctly handle
surrogate pairs, and would require a direct reference to
LatinIME and a specific method to do the processing in an
unexpected place.

Change-Id: I416d6a805242788a2473f007ca7452c9fe3f5205
 2012-03-23 21:40:07 +09:00
Jean Chalard
3ee7d97587 Optimization and typo fix 
Change-Id: Iafa414b8bcf2cca4569b3753bfac58f301a72269
 2012-03-23 21:29:30 +09:00
satok
8980bd4a25 Merge "Cleanup jni 1" 2012-03-23 03:24:08 -07:00
satok
9df4a4527a Cleanup jni 1 
Change-Id: Ieb6af8385356e259720b50f1fe46a694a098b30f
 2012-03-23 19:03:20 +09:00
Jean Chalard
c4f69e7d68 Merge "Stop creating useless objects" 2012-03-23 02:56:10 -07:00
Jean Chalard
0e134a4477 Merge "Small optimization" 2012-03-23 02:47:54 -07:00
Jean Chalard
a492790982 Stop creating useless objects 
Man that was bad, it's heavy, it's called quite often, and it's
totally useless

Change-Id: Ia7e23e0e60ff4a929b226f3f4ccabedbc3ea2c06
 2012-03-23 17:55:11 +09:00
Jean Chalard
e5f02cff7a Small optimization 
Change-Id: I5dd7c848f2aaec20325e7ee85f27e282e1ba7a85
 2012-03-23 17:03:55 +09:00
Jean Chalard
cc78d03a62 Add processing for French ligatures. 
Bug: 5140033
Change-Id: I1c2751fc617e662aad9f67506e28a622f81d0bc9
 2012-03-23 16:50:59 +09:00
Ken Wakasa
066866954a Add a missing comparison in Word.equals() 
Follow up to I94e2e29c

bug: 6209651
Change-Id: Iff2daca8c2678e2d1796f98d6db738f109e3d03f
 2012-03-23 14:41:16 +09:00
Ken Wakasa
6ef88a8901 Merge "Add missing Word.hashCode()" 2012-03-22 22:11:51 -07:00
Ken Wakasa
9f0ea52a5d Add missing Word.hashCode() 
Some cleanups too.

bug: 6209651
Change-Id: I94e2e29c92e90e554e4952d277d590e093766c4f
 2012-03-23 13:11:39 +09:00
Jean Chalard
081616cd2f Send correct coordinates for the spell checker 
This results in the computation being done in native code
and the correct proximity being used.
Bug: 6181080

Change-Id: I08fa05c781d607e4feca2caeda353ec19c133a3d
 2012-03-23 13:02:58 +09:00
Jean Chalard
e7cfe43652 Merge "Don't rely on spell checker proximity in tests" 2012-03-22 02:15:29 -07:00
Jean Chalard
8e31d76983 Merge "Make some constants more explicit." 2012-03-22 02:15:21 -07:00
Jean Chalard
109728193e Don't rely on spell checker proximity in tests 
This fixes the input logic tests that were broken and suppresses
their dependency upon the spell checker proximity. Instead, it
gets the Keyboard instance from Latin IME and uses the actual
coordinates, which results in a test run closer to what actually
happens during typing.

Change-Id: I3a81d249ee7fb3ac6ae6940aa2e8b2421e829e5c
 2012-03-22 18:08:23 +09:00
Jean Chalard
330cd291fa Make some constants more explicit. 
This wasn't very obvious, but the actual values are critical, so
make it more readable
Bug: 6181080

Change-Id: I07461d2df4c796dad0cb6f5283e41a28036d023c
 2012-03-22 14:28:05 +09:00
Kurt Partridge
19b8a73efa Merge "log through group level abstractions" 2012-03-21 20:30:35 -07:00
Kurt Partridge
fdd68f0657 log through group level abstractions 
For the groups:
- LogGroup.MOTION subfields now deteremined in Utils.writeMotionEvent() rather
  than in LatinKeyboardView.processMotionEvent()
- LogGroup.KEY is now logged throguh LatinIME.onCodeInput() rather than
  Utils.push().  This catches keys more generally, including modifiers, and
  records touch positions for everything.  Removed now-redundant
  Utils.writeBackspace() and Utils.writeChar().
- LogGroup.CORRECTION uses Utils.writeCorrection(), and formats instead of
  leaving this to callers.
- LogGroup.STATE_CHANGE uses Utils.writeStateChange().  Optional fields are
  still left to callers, as this group has more variety.

Formats have changed to incorporate new fields.

Minor housekeeping:

ENABLE_USABILITY_STUDY_LOG constants replaced with variable references, as
the logging feature can be changed in Settings and therefore dynamically
changes.

New log format:

20120322-111203.621+0900        1332382323621   s       [onStartInputView]      com.socialnmobile.dictapps.notepad.color.note   2131624043      147457  1140850694
20120322-111204.912+0900        1332382324912   m       [Down]  2782355 0       243     171     0.5666667       0.895
20120322-111204.975+0900        1332382324975   m       [Move]  2782419 0       240     171     0.6     1.17
20120322-111204.983+0900        1332382324983   m       [Move]  2782428 0       238     171     0.6     1.1899999
20120322-111204.992+0900        1332382324992   m       [Move]  2782437 0       236     171     0.6     1.1899999
20120322-111205.002+0900        1332382325002   m       [Move]  2782446 0       232     170     0.6     1.1899999
20120322-111205.012+0900        1332382325012   m       [Move]  2782456 0       227     169     0.6     1.125
20120322-111205.021+0900        1332382325021   m       [Move]  2782465 0       224     168     0.6     1.125
20120322-111205.031+0900        1332382325031   m       [Move]  2782475 0       221     167     0.6     0.895
20120322-111205.040+0900        1332382325040   m       [Move]  2782483 0       213     164     0.6     0.58
20120322-111205.047+0900        1332382325047   m       [Up]    2782491 0       213     164     0.6     0.58
20120322-111205.052+0900        1332382325052   k       'D'     243     171
20120322-111205.228+0900        1332382325228   m       [Down]  2782622 0       171     71      0.6333334       1.275
20120322-111205.243+0900        1332382325243   m       [Move]  2782677 0       178     69      0.6333334       1.275
20120322-111205.325+0900        1332382325325   m       [Up]    2782750 0       178     69      0.6333334       1.275
20120322-111205.333+0900        1332382325333   k       'e'     171     71
20120322-111205.509+0900        1332382325509   m       [Down]  2782936 0       265     139     0.53333336      0.885
20120322-111205.512+0900        1332382325512   m       [Move]  2782954 0       265     141     0.53333336      1.04
20120322-111205.552+0900        1332382325552   m       [Move]  2782973 0       265     143     0.5666667       1.14
20120322-111205.663+0900        1332382325663   m       [Up]    2783102 0       265     143     0.5666667       1.14
20120322-111205.668+0900        1332382325668   k       'f'     265     139
20120322-111206.140+0900        1332382326140   m       [Down]  2783584 0       348     352     0.53333336      0.675
20120322-111206.206+0900        1332382326206   m       [Move]  2783648 0       348     354     0.5666667       0.73499995
20120322-111206.223+0900        1332382326223   m       [Move]  2783666 0       348     356     0.5666667       0.545
20120322-111206.232+0900        1332382326232   m       [Up]    2783674 0       348     356     0.5666667       0.545
20120322-111206.236+0900        1332382326236   k       ' '     348     352
20120322-111206.245+0900        1332382326245   c       [----]  Def             -1

Bug: 6188932
Change-Id: Iea46a0c683f858b72005b8e81191ef1d70262dca
 2012-03-22 12:02:10 +09:00
Ken Wakasa
2aa02b84a4 Revive the Makefile for makedict 
Follow up to I4d2ef504.  Address a compiler warning and a small optimization as well.

bug: 6188977
bug: 6209651
Change-Id: Ibc9da51d48ebf0b8815ad0bb2f697242970ba8f7
 2012-03-22 11:55:18 +09:00
Tom Ouyang
7ac556216d Merge "Move makedict to LatinIME android keyboard." 2012-03-21 05:50:28 -07:00
Kurt Partridge
221dd3d183 Merge "Add additional structure to output logs to group entries by optional fields." 2012-03-21 05:50:01 -07:00
Tadashi G. Takaoka
4897df803d Merge "Refactor key drawing code in KeyboardView" 2012-03-21 04:31:55 -07:00
Tadashi G. Takaoka
72913f97ed Refactor key drawing code in KeyboardView 
Change-Id: Ic7af05caee32eb6cba68d27ba4e2d9072472b34d
 2012-03-21 20:29:51 +09:00
Tadashi G. Takaoka
4cc44f9f77 Merge "Refactor to memorize device dependent override parameters" 2012-03-21 04:26:39 -07:00
Kurt Partridge
78bf41b89c Add additional structure to output logs to group entries by optional fields. 
The new format has time, time as int, and the new logGroup code
    (m=motionEvent, k=key, s=statechange, c=correction)
    followed by additional text whose format depends on the logGroup code.

The additional text will be cleaned up in later CL's.

20120321-170548.067+0900        1332317148067   m
[Down]143116235,0,691,378,0.40000004,0.435
20120321-170548.133+0900        1332317148133   m
[Up]143116302,0,691,378,0.40000004,0.435
20120321-170548.146+0900        1332317148146   k       <enter> 691     378
20120321-170602.485+0900        1332317162485   s
[onStartInputView]com.socialnmobile.dictapps.notepad.color.note,2131624043,147457,1140850694
20120321-170606.508+0900        1332317166508   m
[Down]143134679,0,40,154,0.4666667,0.64
20120321-170606.567+0900        1332317166567   m
[Move]143134723,0,42,154,0.4666667,0.765
20120321-170606.577+0900        1332317166577   m
[Move]143134746,0,44,154,0.4666667,0.775
20120321-170606.652+0900        1332317166652   m
[Up]143134824,0,44,154,0.4666667,0.775
20120321-170606.662+0900        1332317166662   k       A       40      154
20120321-170607.200+0900        1332317167200   m
[Down]143135372,0,411,390,0.53333336,0.585
20120321-170607.311+0900        1332317167311   m
[Up]143135483,0,411,390,0.53333336,0.585
20120321-170607.313+0900        1332317167313   c       [----]A

Bug: 6188932
Change-Id: I8694eb9016d8cf0389ef582f6c7d2820aa4d2c92
 2012-03-21 19:41:10 +09:00
Tom Ouyang
e276c2401e Move makedict to LatinIME android keyboard. 
Bug: 6188977
Change-Id: I4d2ef504bb983abbda3cb52ee450cb46f58d95cf
 2012-03-21 19:30:26 +09:00
Tadashi G. Takaoka
624f1bab39 Refactor to memorize device dependent override parameters 
Change-Id: I79482a8ef3846525669979a30dec183ea18138b5
 2012-03-21 18:20:18 +09:00
Jean Chalard
32aac4777f Merge "Correctly close the gzip stream" 2012-03-21 01:32:07 -07:00
Jean Chalard
bc89f5d3a5 Correctly close the gzip stream 
I had gotten the chain call in reverse.
Bug: 6177523

Change-Id: Ic5b76425de2d5d05d5132f8d2c7ade0d79c14ccc
 2012-03-21 17:28:37 +09:00
Jean Chalard
f5f53c2fa6 Merge "Strengthen java code against bad returns from native" 2012-03-21 00:54:25 -07:00
Jean Chalard
6ca3ac08ed Strengthen java code against bad returns from native 
This doesn't really fix the following bug but it may alleviate
the symptoms

Bug: 6191885
Change-Id: I0de3f550cc7c6cdf79b291399785ad31b205d2ac
 2012-03-21 16:40:26 +09:00
Kurt Partridge
140467b8b6 Updated logger to record touch position within backspace key events. 
Bug: 6188932
Change-Id: Ida2aff618153792f9803f30f1251d67c89af1fe0
 2012-03-20 23:29:34 +09:00
satok
1fe943aabd Merge "Cleanup proximity related code" 2012-03-19 02:40:25 -07:00
satok
728d1c884e Cleanup proximity related code 
Bug: 4343280
Change-Id: I57c0f9e20d9d8911009ea97057251a7f7a81512f
 2012-03-19 18:33:59 +09:00
satok
546b8275ab Merge "Add a dummy file and package for make dict" 2012-03-19 02:01:05 -07:00
Kurt Partridge
6d7e0a876b Merge "Fix TAG name" 2012-03-19 00:52:44 -07:00
Kurt Partridge
9a50777890 Fix TAG name 
Change-Id: Ibea065bc72e6b5e40cfa3ffa2fb6bcdeb107ffc4
 2012-03-19 16:11:17 +09:00
satok
905670bd87 Add a dummy file and package for make dict 
Change-Id: I195fd42f2a773bcc6fab0a61336a1c15d97902bb
 2012-03-19 15:26:13 +09:00
Jean Chalard
9ffb94fa13 Rename the user history dictionary. 
UserBigramDictionary -> UserHistoryDictionary.

Also update all methods, strings and comments, except those needed
for backward compatibility (which only include the name of the
database file).

Change-Id: I0bccea29880dc566b90100575b83baaa947b03ae
 2012-03-19 12:03:51 +09:00
Ken Wakasa
660776e09b Small performance improvement by removing interface accesses. 
Change-Id: I6d91f3b086470b79306dbe2874db9748b9e0eb5f
 2012-03-17 01:53:51 +09:00
satok
cbb5053b6c Fix NPE 
bug: 6181736

Change-Id: I6522f19555c27f33c9ff4eaa8b2559a51a38f015
 2012-03-17 01:37:53 +09:00
satok
a50a34f8b4 Merge "Calculate proximity characters in the native code" 2012-03-16 01:38:07 -07:00
satok
1caff47ecd Calculate proximity characters in the native code 
Bug: 4343280

Change-Id: I6adaf560f7a4f1f96dcb6ec2f61f20ee3001167e
 2012-03-16 17:26:36 +09:00
Jean Chalard
d0d25ac8ec Merge "Remove UserUnigramDictionary." 2012-03-16 01:11:52 -07:00
Jean Chalard
f73efa9077 Merge "Move the UserUnigramDictionary functionality over" 2012-03-16 01:05:10 -07:00
Jean Chalard
7dcbed04d9 Remove UserUnigramDictionary. 
This isn't used any more.

Change-Id: Ie63ae621bcac9342b869b9f236f35bf66ec3a09b
 2012-03-16 17:04:41 +09:00
Jean Chalard
c68d1bbfaf Move the UserUnigramDictionary functionality over 
UserBigramDictionary now assumes both functionalities. It will
be renamed to UserHistoryDictionary in a future change.

There are several reasons to do this. First, there is a lot of
duplicate code in User{Unigram,Bigram}Dictionaries that are
factored by the few lines of code in this change. Also, other
dictionaries like BinaryDictionary or ContactsDictionary all
assume both responsibilities, as should be the case
theoretically.

It is also possible to do this because previous versions don't
write any unigram data that we'd want to reuse. For even older
versions that do write data, we can't really make any sense out
of it. Bigram data however can be useful, and this allows us to
reuse it easily.

Change-Id: I755525f92744e1536eaef097527e8151b7859a30
 2012-03-16 17:01:57 +09:00
satok
c59e383977 Merge "Do not change the proximity orders" 2012-03-15 21:09:46 -07:00
satok
ef08daddea Do not change the proximity orders 
Bug: 4343280
Change-Id: I4e2dfb00d9c843a8a285d409ac5ab8fca5fb1694
 2012-03-16 12:54:17 +09:00
Jean Chalard
c24f66e180 Streamline some user history dictionary code 
A lot of things don't really make sense in the old code.
Let's streamline it for now so that we have a cleaner interface
to work with. This is preliminary work for bug 4192129.

Change-Id: If01a5974cfadc43afced610c57fcf7fde67c1346
 2012-03-16 12:22:39 +09:00
Tadashi G. Takaoka
5bee1b00c8 Merge "Remove touch dead zone" 2012-03-15 05:16:56 -07:00
Tadashi G. Takaoka
723aaa2eeb Remove touch dead zone 
KeyDetector should use the distance from the hit box to detect the
key.

Bug: 6174250
Change-Id: Id1745d90222d1d1a10467f194b45307c12449944
 2012-03-15 20:16:43 +09:00
Jean Chalard
3fe263fac6 Extract an annoying method call 
Change-Id: I78f22bb38222fea54a55e460fcf728bf941d15e9
 2012-03-15 19:30:15 +09:00
Jean Chalard
6ec1209a33 Fix a bug where quotes and dashes are considered letters 
Bug: 6174065
Change-Id: I702760d44ead0eeb60d06360aa3bb03c2ec73325
 2012-03-15 18:18:52 +09:00
Jean Chalard
2be7a37acf Small cleanup 
Exit-fast, update comment, make a method private

Change-Id: Id103bf03aeef43a1a4d064ecabb819490dc5d39a
 2012-03-15 15:54:25 +09:00
Jean Chalard
7c5f2bbd2a Remove useless code 
I tracked all the calls to the constructor, and the passed
list is never null. It's also final, so it's safe.

Change-Id: I320f907acee0b237bb286a9a183c18106809174a
 2012-03-15 15:10:07 +09:00
Jean Chalard
042557b45b De-duplicate a method 
Change-Id: Ia1c80eeff00a55573bb311f07e1275da23bdcf98
 2012-03-15 15:04:29 +09:00
Jean Chalard
e8ddfe4273 Remove useless code 
Change-Id: I58de87c1ba4cd1130419191f63ff83b685604356
 2012-03-15 14:51:22 +09:00
Jean Chalard
4e74658883 Optimization 
All calls to this methods are made with an actual String. No sense
beating ourselves with an interface stick.

Change-Id: I6ef98286be6f81f73864b04f3a17e68f36a6e542
 2012-03-15 14:48:47 +09:00
Jean Chalard
123407261c Stop meaningless explicit null passing 
Change-Id: I6950897d262f610d502b7f8293b9dd8d2b53e6e8
 2012-03-15 14:37:40 +09:00
Jean Chalard
3187ba5dfe Remove a now-useless flag. 
This has been moved to the SuggestedWords object and is now
represented by a single flag instead of a flag in each suggestion.

Change-Id: I6e9a7cff5a7701de7e61b4de13baac25c9a87b1b
 2012-03-15 14:21:02 +09:00
Jean Chalard
4f6cf258fe Use the unique flag in SuggestionsView 
Also, the first word in a sugestions list can never be
obsolete.

Change-Id: Ib21439aac8db4e6ce5b15b7a2aabe4222bc354db
 2012-03-15 14:11:41 +09:00
Jean Chalard
03a3517075 Add info for obsolete suggestions in SuggestedWords 
Change-Id: I9684c7b08244b34853ce8a99b6e9d885389f6687
 2012-03-15 13:12:08 +09:00
Jean Chalard
5f9593593e Remove useless stuff 
Change-Id: I43dae30774c40a9d6e7396f8fa73ed4b82a7c777
 2012-03-15 12:47:05 +09:00
Jean Chalard
ca3e7cbdf4 Move a computation closer to where it's used. 
Change-Id: I5aee4c36ceaacbb1dbfc47c011f1e4aec4b9dca6
 2012-03-15 12:23:16 +09:00
Jean Chalard
eb5ffdac90 Merge "Some readability improvement" 2012-03-14 18:47:32 -07:00
Jean Chalard
c787db51ed Merge "Cut out a private method to make things more readable" 2012-03-14 18:47:26 -07:00
Jean Chalard
b9a5cb77f0 Merge "Minor optimization" 2012-03-14 18:47:21 -07:00
Jean Chalard
53d57ad6d3 Merge "Some code simplification" 2012-03-14 18:47:16 -07:00
satok
05c54ffc7f Merge "Really pass the y - touch correction to the native code" 2012-03-14 06:47:19 -07:00
satok
853d9020ed Really pass the y - touch correction to the native code 
Bug: 4343280

Test:  I11f8518d9ee

Change-Id: I4b90bdffffed9736af223ac83c1a54019add70bb
 2012-03-14 21:54:52 +09:00
Tadashi G. Takaoka
ea51bfd8a8 Fix SuggestedWords.toString 
Change-Id: Ide3f605ce40e8c230f217bbf37ab016457ee91f1
 2012-03-14 19:23:15 +09:00
Jean Chalard
271e5b6cb7 Some readability improvement 
In-place replacements of visibly identical things.

Change-Id: I02b51bd7f63597e3428f0650b239e9a39ef5a7c7
 2012-03-14 18:50:08 +09:00
Jean Chalard
0d0f182959 Cut out a private method to make things more readable 
Change-Id: I791700890338e023bd86b8794dbc90379b91dc7d
 2012-03-14 18:43:32 +09:00
Jean Chalard
ac5e463402 Minor optimization 
We know the size in advance, this may save a few allocations

Change-Id: I2fb9a725f34ba2da4f34ed335652f10447d5d166
 2012-03-14 18:35:07 +09:00
Jean Chalard
def4551c2a Some code simplification 
Just write the same thing in a more succint manner

Change-Id: I08a2c5edd52a3502914541061fd5b6ee7a92ebc4
 2012-03-14 18:33:57 +09:00
Jean Chalard
4a08b2f0e4 Cleanup & optimization 
Renaming some variables, and obvious optimizations.

Change-Id: Ib716748e9f3d602cf276dcd4e73f3bcfb819585e
 2012-03-14 18:29:06 +09:00
Jean Chalard
f985efe39c Remove a useless parameter 
Change-Id: I03005240238fb004c20b2df0d836796e2e8b307f
 2012-03-14 18:12:12 +09:00
Jean Chalard
bdf6d1b18b Remove a useless method 
Change-Id: I208dd2e725e37c2fb3cd51fe48194679e5912f6b
 2012-03-14 15:59:04 +09:00
Jean Chalard
eda7d8af60 Remove the Builder 
Change-Id: Idef22e6a82d59e3ec95b95ad237debcb07daf000
 2012-03-14 15:42:26 +09:00
Jean Chalard
33cc825374 Match the constructor of SuggestedWords to the Builder call. 
We have to match one way or another, and the argument order to the
Builder call is more logical.

Change-Id: Iac7c3a351c2687cb294d6a4924fd9cb20ca95177
 2012-03-14 15:42:22 +09:00
Jean Chalard
7d55c891af Make the Builder private 
Change-Id: I2184084f4b7729c4324f8291d548bd4c4c2872a1
 2012-03-14 15:42:14 +09:00
Jean Chalard
5b0643f50d Re-sequence the last calls to build() 
Change-Id: If77ee5aa9483d3ca03c52812f31665dee6468e99
 2012-03-14 14:19:24 +09:00
Jean Chalard
88bf1ba526 Move up the static methods of the Builder 
Change-Id: Ic3e07b745b7b24cae0f772ea49e0de615b44caf9
 2012-03-14 13:10:22 +09:00
Jean Chalard
8e19b1183e Kill the last place where the Builder was being used 
I had missed that one

Change-Id: I9a5040a7a61e294396aa424de96a69dbb15f037a
 2012-03-14 13:10:12 +09:00
Jean Chalard
e3afb7d192 Make the Builder fully immutable at last 
Change-Id: Ie399ca7a9e76ccab44a92bc378d11f92392fed2c
 2012-03-13 20:33:13 +09:00
Jean Chalard
6ffb5018c1 Straighten out the last bastion of the Builder 
...and go for the kill

Change-Id: I5ad57211b250d2578ca22a5dae93344d52f9da80
 2012-03-13 20:26:47 +09:00
Jean Chalard
ec471c72f8 Add to SuggestedWords a missing parameter, and use it. 
Also stop using Builder between its creation and the call to
the #build() method.

Change-Id: Ie1fc3ec7b6f4c7c3789f672f4e26b4bf58c3e062
 2012-03-13 20:19:21 +09:00
Jean Chalard
2e2519ee91 Make still more members of the Builder final. 
Change-Id: Ic455f97247da5e40d4939555ab639ecffef36e2d
 2012-03-13 20:05:00 +09:00
Jean Chalard
bd4ba23d2b Some code reorganization. 
Use the same local variable inside both branches of an if.

Change-Id: I61f7d506d984f3723ec90604416d1875dd97cd8c
 2012-03-13 19:54:56 +09:00
Jean Chalard
b5eeb724fc Make some more Builder attributes final. 
Change-Id: I3132b7fe4ee97c566736bfc21c3783cfc79fc7ff
 2012-03-13 19:53:38 +09:00
Jean Chalard
c60fea852d Make the suggested word list final in Builder. 
Change-Id: I2ddfab00dc8c141fc989a051f16eb2b3571b7e86
 2012-03-13 19:37:17 +09:00
Jean Chalard
08adb09e14 Remove unused stuff. 
Remove 2 methods that were left only for tests to compile in
another project, but are not used any more now that the tests
have been updated.
Also remove an attribute that is never read.

Change-Id: Ic9ba1f52a465199c82c923d77ed7450460e8a4b9
 2012-03-13 19:37:16 +09:00
Jean Chalard
674ffcdf93 Make an add into a set. 
This method now only sets words, so it should be named set.
The functionality is identical since there are no more places
where the list is reused.
This will also allow to make the list final in an upcoming change.

Change-Id: I25b0c7d7f13c3fa5d89806f01f48f1026769603f
 2012-03-13 19:07:42 +09:00
Jean Chalard
d6662ecd30 Cleanup 
Remove an unused method, make others static, fix a formatting
issue

Change-Id: I40cb0b5e01a6f8e2f7b953bd9aad3168dfee71d1
 2012-03-13 18:34:19 +09:00
Jean Chalard
4ee186920e Remove a method that causes annoying side-effects. 
...and replace by a call to a central method.

Change-Id: I93d0a2c2e99963a5b69923d1062d0e01853216b6
 2012-03-13 18:22:49 +09:00
Jean Chalard
adf218eed5 Kill the StringBuilderPool. 
The intention may have been nice originally but these end up
being copied anyway :/
Let's remove them now, and in a later change, just keep
references to the created objects.

Change-Id: Ifba8357c20384f9eb40cd916665ed1fc6dc8cab1
 2012-03-13 17:59:49 +09:00
Jean Chalard
d0d4074392 Remove a useless parameter. 
Change-Id: I7625bf17158c207ad7e8cd496bef825704173c4c
 2012-03-13 15:34:06 +09:00
Tadashi G. Takaoka
6fbcd0d219 Merge "Use Animator to draw language name on spacebar" 2012-03-12 22:57:57 -07:00
Tadashi G. Takaoka
4c0c638a18 Use Animator to draw language name on spacebar 
Note that Animator class exists in framework only on Honeycomb or
later.

Change-Id: Ie3392dbf8acc1547ebb2d16e04086c911d961aed
 2012-03-13 14:25:57 +09:00
Jean Chalard
7c9bff96f0 Kill methods with side-effects, take 2 
...working this time

Change-Id: I80e377e6250d3817f1e067a551bca2a557740764
 2012-03-13 14:18:30 +09:00
Jean Chalard
b26af7eae7 Revert "Kill methods with side-effects" 
This reverts commit ca0e048688
 2012-03-12 19:42:29 -07:00
Jean Chalard
ca0e048688 Kill methods with side-effects 
Change-Id: I42baeec68eb2540e7d8f8538ae2dceeef5594391
 2012-03-12 19:48:32 +09:00
Jean Chalard
c3c4ed91cf Consolidate words into SuggestedWordInfo 
We can't get rid of SuggestedWordInfo because it conveys
the information about whether a suggestion is outdated or
not. It is always created anyway. So it makes sense not
to have separate lists and to just keep everything in the
SuggestedWordInfo object.

Change-Id: Idd79dc267d97633901d3d2869da457736963e178
 2012-03-12 18:58:20 +09:00
Jean Chalard
c0c20b386f Fix an OOB 
The combination of I6b0262fe which removes the internal
size() > 1 test in the safety net calculation and I642a5893
which assumed DBG means there is at least one suggestion.
This change writes the test correctly.

Change-Id: Ib63bce4e163a785f408dd145c23d64cd58fa8c90
 2012-03-12 16:50:58 +09:00
Jean Chalard
30936116d8 Merge "Make a method accessible for tests" 2012-03-12 00:23:29 -07:00
Jean Chalard
9dedec7c29 Make a method accessible for tests 
Tests are using a wrapper method that's going to disappear soon.
The method that becomes package-visible now is destined to be
removed too a little later.

Change-Id: If99b1c77ed52e050b47216cc7afab5f35c4bbb38
 2012-03-12 16:11:16 +09:00
Jean Chalard
1dfef0336d Make a method static 
Change-Id: Ie1d460562d38105abe91ae2da17cafd49e2cd394
 2012-03-12 15:00:36 +09:00
Ken Wakasa
c1ca8815f5 Fix an obvious bug in handleLanguageSwitchKey() 
bug: 5759092

Change-Id: I8c7b2ef024cbab399d96f6b3ec553da4e9d2fb18
 2012-03-11 00:44:47 +09:00
Jean Chalard
1a85b74adb Entirely remove safety net memory. 
mHasAutoCorrectionCandidate now includes the fact that this
did not get caught by the safety net. This is more intuitive.

Change-Id: I6502bbf1ca64a0a6d64f55d723305cf78352a656
 2012-03-09 22:10:25 +09:00
Jean Chalard
68823ae08e Make the safety net memory private 
Change-Id: I10959d47c980d2e8f2ea995955acf02193e3ff7b
 2012-03-09 22:01:15 +09:00
Jean Chalard
ebbb7e9665 Recompute safety net in debug cases instead of memorizing 
Change-Id: I67f3a31db081afa4871ec441dd461c56e098c668
 2012-03-09 22:00:23 +09:00
Jean Chalard
682c2d53cc Make access to the safety net calculation easier 
Change-Id: If33897b38af94ae81b05e5ef140a542724b9f34a
 2012-03-09 21:44:40 +09:00
Jean Chalard
151d5cb532 Extract a condition from a method 
Change-Id: I6b0262fe7cb3f7a31cc19d724c301467be932640
 2012-03-09 21:37:44 +09:00
Jean Chalard
36c1b37914 Remove a useless argument 
Change-Id: I713433a3225193489fad5bdafcf302b529903116
 2012-03-09 21:24:47 +09:00
Jean Chalard
28e59b98c6 Remove a useless escape 
Change-Id: I1ef0685cc9888c9cef9f60015d32b66dde75ef9b
 2012-03-09 21:10:55 +09:00
Jean Chalard
d5f618e90a Remove a useless test 
If we are not composing a word here, we have already returned

Change-Id: I63281abace777e3658286d4df6781d2cd5a29c33
 2012-03-09 20:53:45 +09:00
Jean Chalard
c5d2bb786e Don't use an intermediate object with a different meaning 
Change-Id: Ie89916b49c852a51385ffd61cb596a58f23a46a0
 2012-03-09 20:51:33 +09:00
Jean Chalard
ed9986824e Move some auto-correction logic to where it belongs 
Change-Id: I897c5ec3a630a4a6bfc593906df4d3fc7b244482
 2012-03-09 20:45:37 +09:00
Jean Chalard
dfd4abe818 Fix a shameful bug 
I must have been sleeping when I wrote that

Change-Id: I887180ab610785a2000636adeeed99230b3c5390
 2012-03-09 19:31:35 +09:00
Jean Chalard
0cf422fbb7 Reduction, step 8 
Change-Id: I54334039597e235e24f169e34c1d44109180ee88
 2012-03-09 19:00:29 +09:00
Jean Chalard
a333ff19ef Reduction, step 7 
Change-Id: I177ef2f29c8b6000c5e3d021c016c5d216fe3fc6
 2012-03-09 18:59:20 +09:00
Jean Chalard
a3ee019331 Reduction, step 6 
Change-Id: I22ad4cea0e0cac23813da7e788f5c94974ce0ebf
 2012-03-09 18:58:01 +09:00
Jean Chalard
dbd140504d Reduction, step 5 
Change-Id: Iac52e62c2bdffad14f916f69eade2b785bb41767
 2012-03-09 18:44:23 +09:00
Jean Chalard
0b96bc4b2b Reduction, step 4 
Change-Id: Ib27dc6e9486c3f0f2ec1e94a88a52d12c1af2d38
 2012-03-09 18:44:20 +09:00
Jean Chalard
5a61d03f31 Reduction, step 3 
Change-Id: I0e08b102c9539d97c473505b9d42176c4a7c8853
 2012-03-09 18:44:16 +09:00
Jean Chalard
8abd15b59f Reduction, step 2 
Change-Id: I06e117df43d25dbaf9fc7a7366efd9355a6215ce
 2012-03-09 18:44:10 +09:00
Jean Chalard
f08f30176b Reduction, step 1 
Change-Id: Ic3ed04300cfd4c0b69b93b27379aca4093b32f67
 2012-03-09 18:38:44 +09:00
Jean Chalard
de165aed2a Separate bigram prediction from suggestion process 
Change-Id: Ibdef206fbd6688a45cebbd7fb8a9f6cd175d03b0
 2012-03-09 18:38:20 +09:00
Jean Chalard
6f722c8301 Remove useless stuff 
Change-Id: I462d24da2d26661990d6aab2a13fde851763fd61
 2012-03-09 18:36:52 +09:00
Jean Chalard
67af2a2415 Export some more logic out of Latin IME 
Change-Id: Ib264533a05e9e09347bf254789e6ab5beec92400
 2012-03-09 18:36:49 +09:00
Jean Chalard
df9fce5df1 Export some logic out of LatinIME 
Hopefully that will end in Suggest/SuggestedWords being autonomous
and won't need the logic spoon-fed to them

Change-Id: I915661bce13c69c8a5b8e5d4a8c41e18fea594cf
 2012-03-09 18:36:45 +09:00
Jean Chalard
91e55ac000 Small optimization 
We only use some of those results in one branch of an if() test.
Let's not compute those that are not needed.

Change-Id: I6ca068646b86d2980fb88e75b110ad077362c4ff
 2012-03-09 16:47:43 +09:00
Jean Chalard
195419b1ec Small reorganization 
...resulting in a slight optimization

Change-Id: I83a9b8c92c3d93ce75988285997ec138b3ffe52e
 2012-03-09 16:41:35 +09:00
Jean Chalard
838629aea0 Remove useless test 
typedWord may not be null here

Change-Id: I9e7afb89fafbf6fcbc91fbc132aecc06aec8979f
 2012-03-09 15:52:23 +09:00
Jean Chalard
d48b76267a Merge "Remove a useless test (B7)" 2012-03-08 22:26:20 -08:00
Jean Chalard
2d82757fc6 Merge "Rename a parameter (B6)" 2012-03-08 22:23:33 -08:00
Jean Chalard
de19ab878d Merge "Remove useless tests (B5)" 2012-03-08 22:22:56 -08:00
Jean Chalard
5a7cb9305a Merge "Remove a provably useless test (B4)" 2012-03-08 22:22:20 -08:00
Jean Chalard
54392438c5 Merge "Optimize and clean up (B2)" 2012-03-08 22:00:02 -08:00
Jean Chalard
90bd4efd10 Remove a useless test (B7) 
consideredWord is provably never null.

Change-Id: Ifaa0d2471c46f14967e70ad004d2b82f841a4566
 2012-03-09 14:55:46 +09:00
Jean Chalard
cf8bc92ba0 Rename a parameter (B6) 
This is not necessarily the typed word. Actually, the parameter
that's passed here has trailing single quotes culled out of it.

Change-Id: Ia2038faa2cbbd3a5b8263e6c0fb5b8e670993fe9
 2012-03-09 14:52:35 +09:00
Jean Chalard
92146f2926 Remove useless tests (B5) 
WordComposer#getTypedWord() may not return null. Don't test for it.

Change-Id: I6aff14892503d0c275a3328c404ed99d2f40a687
 2012-03-09 14:52:04 +09:00
Jean Chalard
31a5da28e3 Merge "Move some code around (B1)" 2012-03-08 21:15:25 -08:00
Jean Chalard
8cd847c2fa Remove a provably useless test (B4) 
If !mInputAttributes.mInputTypeNoAutoCorrect then mCorrectionMode
will not have allowed #hasAutoCorrection() to return true.

Change-Id: I1b498d5aeb26194c765cc9b9dcb24d980de43894
 2012-03-09 12:56:48 +09:00
Jean Chalard
94b20c90d8 Optimize and clean up (B2) 
Stop parameters from escaping and don't do useless work and
simplify the code.
Yay.

Change-Id: I0dfc3e14b1cb50e0730f6d9c1d52b54516baa90e
 2012-03-09 12:51:55 +09:00
Jean Chalard
dc5dfe37e0 Move some code around (B1) 
The goal is to make the creation of the Builder closer to
the #build() call

Change-Id: I48d76d4efdc180479829016582edd9de47e7332c
 2012-03-09 12:33:23 +09:00
Jean Chalard
13fb8fb775 Limit escape of parameters 
Change-Id: I3a7ab069042d5542ab2e033d1eeb13d718cd7698
 2012-03-09 12:30:23 +09:00
Jean Chalard
23a5e9d1a7 Merge "Make AutoCorrection static and non-instantiable (A5)" 2012-03-08 19:05:30 -08:00
Jean Chalard
2621fe2256 Merge "Move a memory in the container class (A4)" 2012-03-08 19:04:56 -08:00
Jean Chalard
427dfe37ec Merge "Remove an unused method" 2012-03-08 18:31:26 -08:00
Jean Chalard
cbbfa15765 Merge "Make AutoCorrection a step closer to being static (A3)" 2012-03-08 18:30:19 -08:00
Jean Chalard
58722d83f0 Merge "Stop uselessly remembering a value (A2)" 2012-03-08 18:30:10 -08:00
Jean Chalard
caae6df0ce Remove an unused method 
Who would have guessed this wasn't being called at all.

Change-Id: Ib74a212356ea44e9bf149619ed5464c14684a1ba
 2012-03-09 11:10:55 +09:00
Jean Chalard
21af2f40c5 Merge broadcast receivers again 
It's probably simpler not to have registers dance around,
and just message the feedback manager when the audio event
happens.

Change-Id: Id0710ed102d10d01f1af93ad8cb660653bb3a9f8
 2012-03-09 11:00:23 +09:00
Jean Chalard
7b77c683d7 Fix a crash 
Bug: 6137076
Change-Id: I05f9f72a2678d10d3400dab5fc71544276739dcf
 2012-03-09 10:29:51 +09:00
Jean Chalard
39286f98bc Merge "Remove useless stuff (A1)" 2012-03-08 04:02:46 -08:00
Tadashi G. Takaoka
f686211183 Merge "Split Utils class to StringUtils, SubtypeUtils, and JniUtils" 2012-03-08 03:59:59 -08:00
Jean Chalard
82adfdaeae Make AutoCorrection static and non-instantiable (A5) 
This needs change Ic6756baa to not break the build

Change-Id: I1c772dd99d63fec5d3ad67a0eb7fbc28ec7a0f0f
 2012-03-08 20:56:59 +09:00
Jean Chalard
7a580a4769 Move a memory in the container class (A4) 
This allows us to make AutoCorrection a purely static class.

Change-Id: I15b81bd7f3d6ea487154a5b09a81bc323be82ce1
 2012-03-08 20:56:11 +09:00
Jean Chalard
9254dbcd7e Make AutoCorrection a step closer to being static (A3) 
Change-Id: Ide3d9785661a672af9bc8dc0cf91cab816dd6caa
 2012-03-08 20:55:49 +09:00
Jean Chalard
719f92fc77 Stop uselessly remembering a value (A2) 
The value is only used in debug mode, and it can be recomputed
at the time.
This change does not impact the logic. There is however a side
effect: in debug mode, the normalized score will be displayed
also when the word comes out of the whitelist or is a valid word.
It's actually a good thing.

The end purpose is to make all methods in AutoCorrection static.

Change-Id: I1642b1fdfa6ae62b8aa2fed94a8a26ff4a7e4d0e
 2012-03-08 20:55:37 +09:00
Jean Chalard
ec0fca8a8b Remove useless stuff (A1) 
Remove an unused method and avoid doing a useless computation

Change-Id: I29593c2e93f15857249b35bdd72ca28045056302
 2012-03-08 20:55:25 +09:00
Tadashi G. Takaoka
cc8c8b99bd Split Utils class to StringUtils, SubtypeUtils, and JniUtils 
Change-Id: I09e91675fe7d573dad8c933ad513b21d7e409144
 2012-03-08 20:30:38 +09:00
Tadashi G. Takaoka
b43f2aeb69 Merge "Fix centering more suggestions panel on tablet" 2012-03-08 03:24:07 -08:00
Jean Chalard
2b1280c0f0 Merge "Return a value for tests instead of saving it" 2012-03-08 03:10:18 -08:00
Jean Chalard
32c181bfe0 Return a value for tests instead of saving it 
Change-Id: I54fa32b92e89d03a53866bd1c0ee65955dd6b3d3
 2012-03-08 20:07:54 +09:00
Jean Chalard
2bb29c4674 Simplification 
Change-Id: Ibced83da2398f1e9ab6a0d6a22c2ad7c8f25cb7b
 2012-03-08 19:50:47 +09:00
Jean Chalard
0f1efae262 Merge "Cleanup unused imports (A7)" 2012-03-08 02:32:48 -08:00
Jean Chalard
663aabca0c Merge "Get the view for haptic feedback as a parameter (A6)" 2012-03-08 02:32:39 -08:00
Jean Chalard
85e88d30c1 Merge "Remove a useless member (A5)" 2012-03-08 02:32:25 -08:00
Jean Chalard
60705c9ed3 Merge "Simplification of sound settings (A4)" 2012-03-08 02:32:16 -08:00
Jean Chalard
d2b5ea2084 Merge "Make a condition positive (A3)" 2012-03-08 02:32:07 -08:00
Jean Chalard
d749fb86ab Merge "Simplify audio management (A2)" 2012-03-08 02:31:57 -08:00
Jean Chalard
7cfae83434 Merge "Export audio and haptic feedback to a specialized class. (A1)" 2012-03-08 02:31:45 -08:00
Tadashi G. Takaoka
bcbaffd9dd Fix centering more suggestions panel on tablet 
Bug: 6129726
Change-Id: I8dac3251eec68ad3fb523c632ff39f3cc661c81f
 2012-03-08 19:02:22 +09:00
Jean Chalard
8667bbeab3 Small rename 
Left/Right is wrong terminology here

Change-Id: I58c55849e45d9984dd3fb7b75a64e07667c9eba4
 2012-03-08 18:49:38 +09:00
Jean Chalard
41a2929282 Cleanup unused imports (A7) 
Change-Id: I48ba12e4311cbf2982ee8f5312b279bc8c1fdfe8
 2012-03-08 18:37:03 +09:00
Jean Chalard
544c3c2952 Get the view for haptic feedback as a parameter (A6) 
It's rather annoying (and possibly dangerous) to keep this as a member.
Get it from outside.

Change-Id: I00c42db96395fb65204fb140aeedc82bf312a86e
 2012-03-08 18:37:00 +09:00
Jean Chalard
29d967fdcb Remove a useless member (A5) 
Change-Id: Ibaaeb8dbcb012f5e973e27ed9928401515656e9e
 2012-03-08 18:36:56 +09:00
Jean Chalard
bdbb22bb33 Simplification of sound settings (A4) 
Change-Id: I0c6e207bae1e08c45a95b3479e1d67228d696792
 2012-03-08 18:36:43 +09:00
Jean Chalard
2651b17fc4 Make a condition positive (A3) 
mSoundOn is much easier to understand than mSilentModeOn

Change-Id: Ie51c5c75fcad62e13e0fb578a266af80f15dc440
 2012-03-08 18:36:19 +09:00
Jean Chalard
793791cdf0 Simplify audio management (A2) 
There is little point in deferring loading for this. Getting the
service at startup time is not very expensive anyway, plus we
can avoid getting it in a later change if sound is off in settings.

Change-Id: I08d65467f245fa2f9f617eb23257c327b3115673
 2012-03-08 18:35:48 +09:00
Jean Chalard
564496bad6 Export audio and haptic feedback to a specialized class. (A1) 
Change-Id: I957d883d1ccf188cb98eb11031aa0a32fce4ed76
 2012-03-08 18:35:20 +09:00
Jean Chalard
f8b39f39cd Merge "Remove a useless class (B4)" 2012-03-08 01:14:33 -08:00
Jean Chalard
4b656a3fef Merge "Remove stuff that's not used any more (B3)" 2012-03-08 01:13:06 -08:00
Jean Chalard
d8447ec353 Merge "Use the simple auto-correction status (B2)" 2012-03-08 01:12:46 -08:00
Jean Chalard
fbe767cec5 Merge "Remember auto-correction status simply (B1)" 2012-03-08 00:54:30 -08:00
Tadashi G. Takaoka
3e2d385810 Restart LatinIME service when keyboard theme is changed 
Bug: 6023947
Change-Id: I779da32708fca7333aff74929cc98173246ee685
 2012-03-08 15:08:16 +09:00
Tadashi G. Takaoka
c648b88779 Merge "Dynamically determine key preview backing view height" 2012-03-07 04:17:52 -08:00
Tadashi G. Takaoka
c8b0e5797e Dynamically determine key preview backing view height 
Bug: 6023947
Change-Id: I53a5c0eb99100a0dfe3e025808f5dc55747d1287
 2012-03-07 20:33:17 +09:00
Jean Chalard
dab392c6f4 Merge "Fix a bug with successive manual picks" 2012-03-07 01:51:59 -08:00
Jean Chalard
3dd4bcb283 Merge "Recompute suggestions on language change." 2012-03-07 01:35:12 -08:00
Jean Chalard
b84ee82e66 Recompute suggestions on language change. 
Bug: 6106407
Change-Id: I43d9c89610a9ed7a9f6825bd90334d7b343df52c
 2012-03-07 17:35:32 +09:00
Jean Chalard
845b24d9d3 Fix a bug with successive manual picks 
Bug: 6121571
Change-Id: Ib16fbef1087da3b7da5539901ec57156f242f089
 2012-03-07 17:32:42 +09:00
Jean Chalard
f773ef19e8 Remove a useless class (B4) 
\o/

Bug: 5975068
Change-Id: Ia18b55af6d555e7ee7af1cdd7c6227fc1ee6786b
 2012-03-07 15:34:15 +09:00
Jean Chalard
a0beebf711 Remove stuff that's not used any more (B3) 
Change-Id: Ie86675ff2facd37430051bf129ddd930fb933dc9
 2012-03-07 15:32:55 +09:00
Jean Chalard
0a59ac2ba8 Use the simple auto-correction status (B2) 
Change-Id: I9d2f053b6f7bad20fc6afe5f5086a965e5014a5c
 2012-03-07 15:31:22 +09:00
Jean Chalard
70852c91dc Remember auto-correction status simply (B1) 
This duplicates the functionality in ComposingStateManager at
a fraction of the cost. It's not used yet.

Change-Id: Ica2607fb2f7c41e11189fcb566e253db8f62596f
 2012-03-07 15:20:01 +09:00
Tadashi G. Takaoka
65fe7f7994 Merge "Add language switch key only to the phone layouts" 2012-03-06 18:19:45 -08:00
Tadashi G. Takaoka
81d4e3cd66 Add language switch key only to the phone layouts 
Bug: 5759092
Change-Id: Ic7d7d4812976654c0e85fecabd1128eadfc52c5c
 2012-03-07 10:03:21 +09:00
Jean Chalard
89ffb212b4 Make the keyboardswitcher and the subtypeswitcher final. 
Change-Id: Ifcc79357adcc53f93b190b6e98d5569f42f74655
 2012-03-06 19:07:21 +09:00
Jean Chalard
3cd1a00eca Resolve a todo 
This exports some voiceproxy complexity to voiceproxy rather
than keeping it in latinime

Change-Id: I0b3523e77af4104cc3ed28417956059c734c8bfe
 2012-03-06 18:43:18 +09:00
satok
691f1c174b Fix coordinates sent to native code 
Change-Id: I2c8b093b59ad36ffe860c3c4d360d87251d101c4
 2012-03-06 16:38:00 +09:00
satok
231ef8fa3e Merge "Integrate the logic to calculate the proximities" 2012-03-05 23:25:29 -08:00
satok
ca7ec2097c Integrate the logic to calculate the proximities 
Bug: 4343280

Change-Id: I0f6a7e6912ed4abea07c10d266da4c7ccb0dae76
 2012-03-06 15:34:27 +09:00
Jean Chalard
00ed3be95c Correct special space handling of punctuation 
This fixes two defects:
- One where some separators should promote a phantom space to
a real space. This bug had a unit test but wasn't tracked.
- One where French punctuations would behave incorrectly. Tracked
Bug: 6113693

Change-Id: Ia7f86fc960e00141757632ab2c9bce9168dd6966
 2012-03-06 14:00:34 +09:00
Tadashi G. Takaoka
e79b1a8312 Make SuggestedWords immutable completely 
Change-Id: I1b0f7b857e89307c987187c1969a2846aa97fdcc
 2012-03-05 23:06:37 +09:00
Tadashi G. Takaoka
8cc8f26adf Make SuggestedWords partially immutable 
Change-Id: I72a2f71d7f6565a30c06e563b0a64f496542cde9
 2012-03-05 22:11:13 +09:00
Tadashi Takaoka
d5b6360549 Merge "Revert "Make SuggestedWords immutable"" 2012-03-05 02:57:00 -08:00
Tadashi Takaoka
d62fa834c6 Revert "Make SuggestedWords immutable" 
This reverts commit c208f4dfb7
 2012-03-05 02:54:21 -08:00
Jean Chalard
6a830277df Merge "Refactoring" 2012-03-05 01:49:46 -08:00
Jean Chalard
611a5bdf65 Refactoring 
Change-Id: I2f92c01fa1ff6b318128d387f26942b5d47de3e0
 2012-03-05 18:36:51 +09:00
Tadashi G. Takaoka
c208f4dfb7 Make SuggestedWords immutable 
Change-Id: I26bd82aee5ead84e40abfc3db5a48ed6d1e42361
 2012-03-05 17:24:30 +09:00
Jean Chalard
895b70b8af Move some treatment to a more sensical place. 
It makes more sense to catch words with the safety net in
updateSuggestions() than in showSuggestions(). Also, it's useless
to do it in updateBigramPredictions, because the result will
always be provably false.
This will also help with writing unit tests.

Change-Id: Ifab81e6c5a74b1aa75cf85ef7742fee69a98f5ce
 2012-03-05 14:27:49 +09:00
Jean Chalard
9b01890254 Move a method to a more sensical place. 
Change-Id: I11f87448f689cf828bff960ad7a3e4739a3457dc
 2012-03-05 14:19:35 +09:00
Jean Chalard
611ec69413 Remove a useless method 
Change-Id: I2002662ee07af2fcc626a52ea4e9ad8977b29ca2
 2012-03-05 12:46:35 +09:00
Jean Chalard
428178aca6 Merge "Replace a useless computation with a constant" 2012-03-04 19:35:11 -08:00
Jean Chalard
4ab5486bf2 Merge "Remove a useless test" 2012-03-04 19:35:02 -08:00
Jean Chalard
4e112d0782 Replace a useless computation with a constant 
This is provably always false

Change-Id: I88d783fa59fec0b7a729558ba974a6a58c158645
 2012-03-05 11:57:36 +09:00
Jean Chalard
a04d2358c0 Remove a useless test 
With the current logic, this test provably always resolves
to false.

Change-Id: Iba84ef5f3a14cd8ac48c6a813519ab283bf605f8
 2012-03-05 11:38:45 +09:00
Tadashi G. Takaoka
49079df8ec Merge "Omit InputMethodManagerCompatWrapper argument from some utility methods" 2012-03-04 18:12:47 -08:00
Tadashi G. Takaoka
2d25ba2750 Omit InputMethodManagerCompatWrapper argument from some utility methods 
Change-Id: Ic837018c702c8c575de3e5e81fe8e31fee16fe22
 2012-03-05 10:43:12 +09:00
Jean Chalard
c2136c4e63 Merge "Some renaming" 2012-03-04 17:26:22 -08:00
Jean Chalard
a157249014 Merge "Remove a useless method" 2012-03-02 05:57:48 -08:00
Jean Chalard
e53840d216 Merge "Some more simplification" 2012-03-02 05:56:58 -08:00
Tadashi G. Takaoka
3a1844c33b Merge "Support dividers in MoreKeysKeyboard" 2012-03-02 03:58:13 -08:00
Tadashi G. Takaoka
5ef4fccbb9 Support dividers in MoreKeysKeyboard 
Bug: 6080806
Change-Id: Iacd78c6aab6abf948717d34da7489a79c41316d2
 2012-03-02 20:52:25 +09:00
Jean Chalard
a83a53ba24 Some renaming 
Change-Id: I445277cb3af469a0145a8da0ffb801b7e19048cd
 2012-03-02 20:46:54 +09:00
Jean Chalard
5edda4111e Remove a useless method 
Change-Id: I038e6a82b6463a2a8ec494171a596d76fbc75fe1
 2012-03-02 20:38:41 +09:00
Jean Chalard
dd931c47be Some more simplification 
I wish "are we autocorrecting?" was not computed in a dozen
places all depending on a hundred code paths
More than likely, this fixes very subtle discrepancies
between auto-correction indicator with the underline and with
the LED on the spacebar - which is not displayed any more in
the current version anyway. Especially, the LED probably
would have been off when the word was caught by the safety net.

Change-Id: Idda3021771081d6155b06915e728ecd64d9e042e
 2012-03-02 20:34:10 +09:00
Jean Chalard
e2a50bd804 Optimization 
Avoid doing some useless processing.

Change-Id: I4ce0a188e10db30322bd25751dc5c09492cea301
 2012-03-02 20:26:51 +09:00
Jean Chalard
7204eab3da Precompute two values that never change 
Change-Id: Ic54e7926028ea8374564da5e5004d710f42c53e1
 2012-03-02 20:04:42 +09:00
Jean Chalard
38e535e596 Change a parameter type to make a call clearer 
Change-Id: I2918d0a8b00da743689b919f80128bbf36973f24
 2012-03-02 20:01:34 +09:00
Jean Chalard
5bc2b61274 Move a method up a level 
Change-Id: I6b9a697480127e4745698ab19f8a360b86ff39ca
 2012-03-02 19:59:55 +09:00
Jean Chalard
d02783cb63 Break out a method 
Change-Id: Ia14fc320422b7f198c33ba522bb93dd70fbcb2c1
 2012-03-02 19:52:06 +09:00
Jean Chalard
5a2c19d4fb Merge "Revert "Make a member read-only"" 2012-03-02 02:49:42 -08:00
Jean Chalard
f1967ce322 Revert "Make a member read-only" 
This reverts commit 6a43e39bf0
 2012-03-02 02:49:24 -08:00
Jean Chalard
9727aea418 Merge "Small refactor (A1)" 2012-03-02 02:47:42 -08:00
Jean Chalard
6a43e39bf0 Make a member read-only 
Change-Id: I9a718eaf07e1b6c659e649350d3605f365db2839
 2012-03-02 19:17:57 +09:00
Jean Chalard
d992fa847d Small refactor (A1) 
Change-Id: Ia0838bbce47a2b60067f464685ad6d55ee4ec934
 2012-03-02 18:55:04 +09:00
Tadashi G. Takaoka
ede2133cb1 Support time, date, and datetime keyboard 
Bug: 6030364
Change-Id: I2bd4daf264757d8f3fa7c946d10a39c36ccf5905
 2012-03-02 14:01:07 +09:00
Tadashi G. Takaoka
961703841e Merge "Explicitly specify that labels might be in more keys" 2012-03-01 03:56:32 -08:00
Tadashi G. Takaoka
e4c45c6ef9 Explicitly specify that labels might be in more keys 
Bug: 6080806
Bug: 6081427
Change-Id: I455a0210e65ea2a7774e0e0071cea5f4a99577bd
 2012-03-01 20:03:47 +09:00
Jean Chalard
fa12acb8b7 Change a dangerous ID 
The message id 0 is used intrinsically by the framework
for all messages without a specific ID. Using 0 here
we can't reliably use the post(Runnable) method on our
handler, because these would in *some* respects be taken
for update_suggestion messages, but not all.
For example, they'd be removed on removeMessage() but
they would not trigger the actual process. This would
lead to utter confusion.

Change-Id: I5d9b01d38e2ff090cd0d80c27421dc8a41c317b8
 2012-03-01 19:05:51 +09:00
Jean Chalard
f3f90e6d35 Try to survive unavailability of local storage 
Bug: 6035465
Change-Id: Ibe2d542349ec598824f78b91d374a977082fc2d1
 2012-03-01 09:43:29 +09:00
Jean Chalard
5e4d2a0fa9 Remove logs now that we don't need them any more. 
This has served its purpose, we don't need this any more.
The logging function itself can be kept since it's not called
any more. It may come in handy later.
Bug: 6053661

Change-Id: Icb40dad131793a704dbe6514cf7433e43ea04450
 2012-02-22 20:45:43 -08:00
Jean Chalard
3f65960e16 Add debug prints to help with debugging 
This is intended to help tracking #6048808.
Another bug has been filed to remove this once we're done with
the debugging: #6053661

Change-Id: I4547fb71926af6dc2e9c23ee4b44e4e345be6657
 2012-02-22 16:16:32 -08:00
Jean Chalard
5935950d44 Rename cancelCommit to revertCommit 
This wording is easier to understand, and it matches the other
revert* functions.

Change-Id: Ibc2ec79fb5a0f9bf508e5cdeb75e54abd9241d0c
 2012-02-22 01:09:23 -08:00
Jean Chalard
4fef31510d Remove a useless code path (A7) 
This is never called any more, since we now use the cancelCommit
path to react to a backspace after a manual pick.
This concludes the run of changes to implement feature
request #5968922

Change-Id: I23df653bb2a3de2ba0152394d5d616a42ac7519b
 2012-02-22 01:05:36 -08:00
Jean Chalard
bdf89ce5fe Rename cancelAutoCorrect to cancelCommit (A6) 
Also remove a test in debug mode that would check for absence of
a situation which is now expected.

Change-Id: Ia5be350bc98a604b3bf8f6057652c5534f6a19af
 2012-02-22 00:59:01 -08:00
Jean Chalard
2aa16dd81f Merge "Activate the code to cancel a manual pick (A5)" 2012-02-22 00:50:13 -08:00
Jean Chalard
80c25df49d Merge "Implement cancelling a manual pick (A4)" 2012-02-22 00:29:23 -08:00
Jean Chalard
8db74d0fae Merge "Use the stored separator instead of reading it back (A3)" 2012-02-22 00:24:19 -08:00
Jean Chalard
9271b770e8 Activate the code to cancel a manual pick (A5) 
This finally makes active the behavior described in
Bug: 5968922

Change-Id: I363ed23270c3dea75411ea806011225097b5d07c
 2012-02-22 00:05:19 -08:00
Jean Chalard
32f0af1fc4 Implement cancelling a manual pick (A4) 
This is new code, but simple code. The new code path is never
used for now, but it will be in an upcoming change. This serves
to implement feature request #5968922

Change-Id: I3e67731ec6e9fc0b86c5cbd972e9c081781c11a9
 2012-02-22 00:00:51 -08:00
Jean Chalard
193d23f40e Use the stored separator instead of reading it back (A3) 
Now that we have stored our committing separator, we can use
it directly instead of reading it back from the text view
paying the IPC cost. This prepares for feature request #5968922.

Change-Id: Ifeaa2d659cf12b91c89d28e6ff7d07a669258184
 2012-02-21 23:56:36 -08:00
Jean Chalard
e043bf02f2 Merge "Give LastComposedWord knowledge of the separator (A2)" 2012-02-21 23:42:21 -08:00
Jean Chalard
1dfdc8056c Merge "Give LastComposedWord knowledge of the committed word (A1)" 2012-02-21 23:41:42 -08:00
Jean Chalard
66bb563535 Give LastComposedWord knowledge of the separator (A2) 
This stores the separator that was used to commit the word in
the LastComposedWord. It may be NOT_A_SEPARATOR if there was
no separator (for example, the cursor moved causing a commit,
or there was a manual pick). This is necessary to implement
feature request #5968922.

Change-Id: I5fcf19a78ec66d68d4df89418eaef13952588207
 2012-02-21 23:33:58 -08:00
Jean Chalard
cf9d92629c Give LastComposedWord knowledge of the committed word (A1) 
There is no point storing the prospective autocorrect - we are
recomputing it anyway. The committed word however will be necessary
to implement feature request #5968922.

Change-Id: I588c18e1a5a1050a791d601de465f421ccbe36cd
 2012-02-21 23:12:21 -08:00
Tadashi G. Takaoka
1b3c16c183 Merge "Add next/prev navigate action more keys and remove tab key" 2012-02-21 23:09:58 -08:00
Tadashi G. Takaoka
05bfd189a8 Add next/prev navigate action more keys and remove tab key 
Bug: 6037537
Bug: 5961814
Change-Id: I9c6dedf953452a180fcd5bce7bfadfd3c821f224
 2012-02-21 22:50:50 -08:00
Jean Chalard
5262fe8832 Dismiss the hint on a non-word-starting non-separator 
This would happen when a character is not a separator but is not
a word starter. Such characters include single quote and
dollar, and others non-letter, non-separator chars.
We set the bigram predictions if any - if not so configured, this
will fallback on setting back punctuations into the strip.

Bug: 6010408
Change-Id: Id203bbe87f8c13de0d5027b555c9067c7ec98f92
 2012-02-21 21:16:18 -08:00
Jean Chalard
b141c9cd3f Rename resources to reflect current usage 
Bug: 6010403
Change-Id: Ia02ff31007296fdf6901504f238dfd9e4621f658
 2012-02-21 18:54:44 -08:00
Jean Chalard
8a3d369840 Remove a useles parens 
...I could swear I had compiled :/

Change-Id: I4e1fb2b1dda0a4ceffe2082935395d05297c63ec
 2012-02-21 16:53:05 -08:00
Jean Chalard
9a2a11e65b Rewrite a condition 
Change-Id: I805c9579788d99b015feb2075ad4771756c7adc5
 2012-02-21 15:46:53 -08:00
Jean Chalard
2649e42d75 Extract a method to reset the ime state 
Change-Id: I921184b85b94418cf360508ee3f67e85b10b3d72
 2012-02-21 15:12:01 -08:00
Jean Chalard
5eeff7cf54 Converge paths of an if() branch 
This is to help with further refactoring.

Change-Id: Ib2459903862570cf7022fd90f2d5c524a6bbbe19
 2012-02-19 18:02:40 -08:00
Jean Chalard
1044539080 Rename variables and add comments 
Change-Id: I746f2364d9f02f22aa6ab57d7060013ee114f4e3
 2012-02-19 17:26:41 -08:00
Jean Chalard
1fead1d5f1 Read the initial selection value. 
It turns out this was available in an unexpected place.
Fixes both the following bugs
Bug: 5948469
Bug: 6023118

Change-Id: Ie1a91b8268540ea0f0df02bee94c3bbdeb0fa4c5
 2012-02-17 20:54:48 -08:00
Jean Chalard
1950964157 Merge "Don't assume a word has been added to the user dict" 2012-02-17 15:29:52 -08:00
Tadashi G. Takaoka
97bde43740 Settings key always exists in more keys of shortcut/f1 key 
This change also
  * Fix comman/f1 key for Arabic keyboard.
  * Removes "show settings key option" and related stuff.
  * Renames and simplifies F2 key to shortcut key on 7 inch tablet.

Change-Id: Ib1cf99ad00d9780a2f0d170260e756771e161521
 2012-02-17 01:04:11 -08:00
Jean Chalard
8e4b3bbf9f Don't assume a word has been added to the user dict 
The user may now cancel or edit a word upon adding to the
user dictionary. We can no longer assume the word has been
added as is and for the current locale. We should just rely
on standard mechanisms that inform us of new insertions.

Bug: 6015347
Change-Id: I069b19c0c844ca29d6de4c4d162306f9413adea8
 2012-02-16 19:19:05 -08:00
Tadashi G. Takaoka
beb08b398f Remove unnecessary and harmful KeyboardState.onUpdateShiftState call 
This change also cancels double tap and long press timers if other
letter key is pressed after shift key.

Bug: 5693999
Bug: 6017610
Change-Id: I3b5f3debfb8915fa73a93b409a38afadf24132e9
 2012-02-16 18:02:17 -08:00
Jean Chalard
ad290d6505 Activate bigram predictions from the binary dictionary 
Change-Id: If1cc50539d7677b854b1cd3bea3423c8c0865de5
 2012-02-15 19:51:24 -08:00
Charles Chen
4baf767fac Merge "Improved shift key and symbol/alpha switch key accessibility feedback." 2012-02-09 15:33:40 -08:00
Jean Chalard
accd2a9f61 Merge "Add finals" 2012-02-08 19:08:09 -08:00
Jean Chalard
a828f613a8 Merge "Some more simplification" 2012-02-08 19:05:46 -08:00
Jean Chalard
8ff0564f6a Add finals 
Change-Id: Ib81be9a0df34c5e9fc49d2b5d9bf02297ea2b499
 2012-02-09 11:40:54 +09:00
Jean Chalard
6a800b253f Some more simplification 
Remove useless method calls, and ultimately remove useless
method.

Change-Id: I3f353b1b37460d5e9ceae5cb5dde3fff0da81c21
 2012-02-09 11:38:03 +09:00
Jean Chalard
4721427c7d Allow revert swap punctuation again 
This may not be the best behavior, but it's the same as ICS.
Bug: 5981844

Change-Id: Ibb7798e2a315312310ed3be4e731d0fe1ac04456
 2012-02-09 11:34:00 +09:00
Tadashi G. Takaoka
7a39bd4454 Shift+Smiley key will register newline character of textMultiLine 
This change also
 * Honors the custom action label in EditorInfo.actionLabel.
 * Invokes InputConnection.performeEditorAction if action is specifed
   at EditorInfo.imeOptions or actionLabel/actionId.
 * Stops using InputMethodService.sendKeyChar. Implements
   sendKeyCodePoint instead.

Bug: 2498607
Bug: 5961809
Bug: 5368408
Change-Id: If4cd5eb3dacfc6b6a7ea434b0617c2438e06e42d
 2012-02-08 19:31:35 +09:00
Jean Chalard
82efc941ba Merge "More simplification" 2012-02-08 01:43:23 -08:00
Jean Chalard
e771fc2f1a More simplification 
A suggested punctuation is sure to be 1 character and a word separator,
so the isSuggestedPunctuation() test is redundant.

Change-Id: I3d31f0825f069f64d514682e46be62afdae25291
 2012-02-08 18:17:51 +09:00
Jean Chalard
9159b9953d Fix the auto-composer to support supplementary chars 
Change-Id: I61ff218ae2ca4eb443a370e581b677755258670a
 2012-02-08 15:45:51 +09:00
Jean Chalard
8174373a0e Merge "Remove a nested edition occurence" 2012-02-07 19:42:35 -08:00
Jean Chalard
5a6daf46cf Merge "Cleanup" 2012-02-07 19:42:26 -08:00
Jean Chalard
862f950da3 Cleanup 
Remove a useless test (we can only come here if the code
is not a separator, as we are only called from onCodeInput
inside an explicit test).

Change-Id: Icd996a5a1c18a550117a144a1d35f167b96211f7
 2012-02-08 12:06:18 +09:00
Jean Chalard
2124bc5bf5 Remove a nested edition occurence 
This was harmless but confusing

Change-Id: Ic271f80d3dadf01b29e3875c6a8ad51b99a936f9
 2012-02-08 12:03:55 +09:00
Jean Chalard
2e2d6b4d40 Small simplification 
Change-Id: I55f81f3ab427fd5b28bb1f31960077cd1897cbd0
 2012-02-08 11:41:15 +09:00
Jean Chalard
1b986cc488 Merge "Fix a bug with manual pick then dotcom key" 2012-02-07 16:59:47 -08:00
alanv
8d4f0d5d1d Improved shift key and symbol/alpha switch key accessibility feedback. 
Bug: 5933165
Change-Id: Id71f38874640785b7ad43b7a70e27f40c13be748
 2012-02-07 13:14:18 -08:00
Tadashi G. Takaoka
69f672a4b3 Merge "Remove unused InputConnection argument" 2012-02-07 04:15:07 -08:00
Jean Chalard
12d67e6d5d Fix a bug with manual pick then dotcom key 
Inhibit adding phantom space for tld keys even if the last
character inserted in the textview is not a dot

Change-Id: Ie92554ead7a18c932480905c5738aff7c0159a32
 2012-02-07 20:36:48 +09:00
Tadashi G. Takaoka
64eaa67eb5 Remove unused InputConnection argument 
Change-Id: Ic45c8c6e7730775654317fb6e2d1cb64f9031f46
 2012-02-07 19:38:06 +09:00
Jean Chalard
cfec7e72fd Merge "Fix a race condition that makes tests unstable" 2012-02-07 02:28:12 -08:00
Jean Chalard
816a8a0fd8 Fix a race condition that makes tests unstable 
Change-Id: Ic19d380eb64855884bc6ded8547c200dd772ffe9
 2012-02-07 19:22:37 +09:00
Jean Chalard
172a013ab5 Fix a bug with the auto-correct indicator 
Bug: 5969106
Change-Id: I02d4b9184bb2c3fc0d08ffd5db77a9f9d816631f
 2012-02-07 17:20:23 +09:00
Jean Chalard
a7f2500001 Fix a bug with common objects. 
Bug: 5961179
Change-Id: I452efc552c6ab390931f25557d7aee5a64bf054e
 2012-02-06 18:41:00 +09:00
Jean Chalard
fb684cebe8 Stop inserting a space after a manually picked word. 
Bug: 4994861
Change-Id: I6ae256a94dbaddea4304304779d17025620c5025
 2012-02-03 18:45:44 +09:00
Tadashi G. Takaoka
909b2940db Merge "Get rid of Key.setIcon(Drawable)" 2012-02-02 21:51:51 -08:00
Tadashi G. Takaoka
e7948a8692 Get rid of Key.setIcon(Drawable) 
Change-Id: If6ebbdefcbfd0cc14c72858f9bb44861e8abe079
 2012-02-03 14:38:17 +09:00
Jean Chalard
825e2bbd91 Fix a bug when deleting the last char 
And unit test

Change-Id: Ic4fc3626f8b86e10156d770d41cd6deab5d31f39
 2012-02-03 13:03:54 +09:00
Jean Chalard
9242a2bcf8 Fix string iterations in a couple places. 
Seems I didn't get how to iterate on a String correctly >.>
Talk about a big bug. Anyway, I think it's working now.

Bug: 5955228
Change-Id: I988c900cf2a16c44b9505cfd4f77c7cda7e592f0
 2012-02-03 11:15:46 +09:00
Tadashi G. Takaoka
8261a4cad7 Merge "Move CSV parser to KeySpecParser" 2012-02-01 23:25:17 -08:00
Tadashi G. Takaoka
0086861d5a Move CSV parser to KeySpecParser 
Change-Id: I424fb47bc70e9b6aaa5a16ae9b2500d23da75c26
 2012-02-02 16:10:14 +09:00
satok
e05b3f4b3a Support additional proximity characters 
Change-Id: Ifbe0d7e4eafea1926bbce968eae4724dd5769689
 2012-02-02 16:07:16 +09:00
Tadashi G. Takaoka
8ca325f437 Merge "Make KeySpecParser and CSV parser code point aware" 2012-02-01 22:56:54 -08:00
Tadashi G. Takaoka
e01d272603 Make KeySpecParser and CSV parser code point aware 
This change also renames MoreKeySpecParser to KeySpecParser

Change-Id: I35733cdbb344f16b57ffa2cfe79055c089b4e409
 2012-02-02 15:51:40 +09:00
Jean Chalard
51fd1632f5 Stop throwing an exception in some corner cases. 
When the application is modifying the text under our feet,
we may come through this code path. We should log the error
rather than crash.

Bug: 5869235
Change-Id: Ic0fd24c3bc805d44c5db0ad781ddebeca0450614
 2012-02-02 15:15:55 +09:00
Tadashi G. Takaoka
ff858c7ff5 Use MoreKeySpecParser to parse puctuations strip resources 
This change also
  * Doesn't use Key.getRtlParenthesisCode to get correct parentheses
    code in RTL context. Intead uses the outputText feature of
    moreKeys specification.
  * Move CVS string parser from KeyStyles to Utils.

Bug: 5948247
Change-Id: I45752c7d01b4f7d3f3da900b110a2185b336a1f0
 2012-02-01 19:33:26 +09:00
Tadashi G. Takaoka
a5c96f376a Move long press shift handling from PointerTracker to KeyboardState 
This change also
  * Rename phone shift keyboard to phone symbols keyboard.
    Use CODE_SWITCH_ALPHA_SYMBOL code to switch between phone and phone symbols keyboard.
  * Remove phone symbols keyboard from tablet.
  * Introduces enableLongPress flag of Key.keyActionFlags attribute.
  * Remove clumsy long press code from PointerTracker.
  * Remove CODE_CAPSLOCK handling from LatinIME.
  * Make KeyboardSwitcher to invoke haptic and audio feedback.

Change-Id: I00e1f697a10ab5112aec75e36853b96246ff5054
 2012-02-01 19:04:21 +09:00
Tadashi G. Takaoka
433ca6a46d Cleanup redundant methods of KeyboardSwitcher 
Change-Id: I2ebeb8852177f6c6e30578d0bb3f372f488dc6c1
 2012-01-31 17:18:14 +09:00
Tadashi G. Takaoka
ca2f051cc1 Auto generate various shift states alphabet keyboard automatically 
If any shift state variants of alphabet keyboard layout is not
specified in KeyboardSet.Element, it will be automatically generated
from base alphabet keyboard definition.

This change also
  * Eliminates KeyboardShiftState object from Keyboard.
  * Removes various set shift state methods from Keyboard.
  * Removes KeyboardSet.Element.elementAutoGenerate attribute.
  * Separates "sticky" Key.backgroundType to "stickyOff" and "stickyOn"
  * Add preserveCase flag to smiley, .com, and labeled special keys.
  * Rename KeyboardShiftState class to AlphabetShiftState.
  * Rename some attributes from *UppercaseLetter* to *ShiftedLetterHint*.
  * Introduce shiftedLetterActivated to Key.keyLabelFlags

Change-Id: I01a0a8efeeaa76820ae728a5bdfa8d02b6ce74b7
 2012-01-31 12:55:45 +09:00
Ken Wakasa
6029b43a3d Add "size" and "pressure" for MotionEvent logs 
bug: 5722703
Change-Id: I8e08942324b666de96682ce63e70c8d324535782
 2012-01-30 12:22:15 +09:00
Jean Chalard
449415c72f Cleanup (A9) 
Deactivate the LastComposedWord when the commit was not the right
type, instead of fooling it by passing it a null auto-correction.

Change-Id: I032b477dc691bd151a644ca4b0c9f0a9b5512e45
 2012-01-26 20:10:49 +09:00
Jean Chalard
5971a0a0bb Remove a useless member (A8) 
It turns out this can be removed entirely.

Change-Id: I6f23703cef1666311989a825285317eef696487f
 2012-01-26 20:10:49 +09:00
Jean Chalard
be79227dc9 Remove the CharacterStore class (A7) 
Remove the now useless WordComposer.CharacterStore class
and merge back its members inside WordComposer. This should
simplify the word composer a bit.

Change-Id: I5fe32418c62a583cd558dce98758a4701559bdf5
 2012-01-26 20:03:44 +09:00
Jean Chalard
c7c152de4b Guard against wrong auto-correction cancellation (A6) 
This deactivates the cancellation at each separator pressed while
not composing a word. The net effect is to fix
Bug: 5875776

Change-Id: I67aa3f842ddff250828c60596ad5a7e466c1ddaa
 2012-01-26 19:57:37 +09:00
Jean Chalard
b6b8729374 Straighten out resuming suggestion on kept word (A5) 
This is cleanup.
This also introduces a "deactivated" state to the last committed
word, that can be used for
Bug: 5875776

Change-Id: I1855adb8ac8123f6d2c5365b0ae899145e5c3ba1
 2012-01-26 19:24:36 +09:00
Jean Chalard
2712f23acb Remove mCommittedWordSavedForSuggestionResuming (A4) 
Change-Id: Ia62ef33b5c777a258b02280bda1b8368780a7eef
 2012-01-26 18:36:28 +09:00
Jean Chalard
2692a87007 Move some functionality into LastComposedWord (A3) 
Change-Id: Ie0ea02a061dd0cb84db5f33113ff433584636bc7
 2012-01-26 18:25:08 +09:00
Jean Chalard
1f8fc62ccb Add useful information to LastComposedWord (A2) 
Change-Id: Idf47f2e2bdd1d6394fc4b1ab7df28d64a808da1e
 2012-01-26 17:49:55 +09:00
Jean Chalard
95eeb2df63 Merge "Add a class for previously composed data (A1)" 2012-01-26 00:43:57 -08:00
Jean Chalard
267563d1bb Add a class for previously composed data (A1) 
Change-Id: I87498799e6a48b8fa65924a098bb0ceb7626dce1
 2012-01-26 17:22:52 +09:00
Tadashi G. Takaoka
736d740aa5 Merge "Get rid of Resource reference from KeyboardView, LatinKeyboardView and PointerTracker" 2012-01-26 00:17:56 -08:00
Tadashi G. Takaoka
160f01211d Get rid of Resource reference from KeyboardView, LatinKeyboardView and PointerTracker 
This change introduces the following attributes.
 * KeyboardView
   - keyPreviewLingerTimeout
 * LatinKeboardView
   - keyHysteresisDistance
   - touchNoiseThresholdTime
   - touchNoiseThresholdDistance
   - slidingKeyInputEnable
   - keyRepeatStartTimeout
   - keyRepeatInterval
   - longPressKeyTimeout
   - longPressShiftKeyTimeout
   - longPressSpaceKeyTimeout
   - ignoreSpecialKeyTimeout
   - showMiniKeyboardAtTouchedPoint

Change-Id: I25159a87289b12447e20031add173523070e9b03
 2012-01-26 16:10:20 +09:00
Tadashi G. Takaoka
bd51aaf98f Merge "Warn deprecated privateImeOptions, "nm" and "forceAscii"" 2012-01-25 22:20:35 -08:00
Jean Chalard
051ac1ef14 Merge "Add a guard against OOB." 2012-01-25 21:22:18 -08:00
Jean Chalard
8be16f78b1 Add a guard against OOB. 
...and avoid crashing in one case where the application may
change the text while we are typing.

Bug: 5685922
Change-Id: I4a22c63168986f43ac84f512aaa4267023d536e3
 2012-01-26 14:17:48 +09:00
Jean Chalard
5a38ff305f Merge "Convert an internal enum into an int of same underlying value." 2012-01-25 21:13:56 -08:00
Tadashi G. Takaoka
4f5c3a2898 Warn deprecated privateImeOptions, "nm" and "forceAscii" 
Public API EditorInfo.IME_FLAG_FORCE_ASCII has been supported by
I6665b483.

Change-Id: I0ffdee15d8177d126cd8fe86a6bc4ab21be58c36
 2012-01-26 13:37:35 +09:00
Jean Chalard
6e082cb30d Convert an internal enum into an int of same underlying value. 
Goes together with Id4f4e066

Bug: 5922118
Change-Id: I1e39dd01c67e9284d9d7fe008d868847e69986d7
 2012-01-26 13:07:51 +09:00
Jean Chalard
fda847a870 Small cleanup 
All calls to this method are done with the same parameter,
and it's really hard to understand if we call upon this
member inside.

Change-Id: I787664bb59053ab0fe666ed812fb12b2b9090918
 2012-01-26 11:40:16 +09:00
Jean Chalard
d9702a375a Merge "Add a test for auto-correction." 2012-01-25 02:33:39 -08:00
Jean Chalard
0bfe359ee4 Add a test for auto-correction. 
Fix two related subtle bugs:
- Stop singling out fat-finger-only corrections for rejection
  when touch coordinates are not available.
- Remove a racy check that would happen only in debug mode

Change-Id: Ic904f9b27c091ca6b369052c4e65a630bff81257
 2012-01-25 19:29:40 +09:00
Tadashi G. Takaoka
38d6a18821 Use String instaed of CharSequence in Key class 
Change-Id: Ia76a41daede402ed2a509e110ae97d6bb660c760
 2012-01-25 17:04:00 +09:00
Jean Chalard
77da3d5a3b Fix a bug where backspace would not delete the selection 
Bug: 5699301
Change-Id: I6c5a8470464d045349ac38e191c859b5c34cbeee
 2012-01-24 18:07:23 +09:00
Jean Chalard
5fd11a7f33 Fix a typo 
Change-Id: I358350c959d5610214a752b14d7744fe83eb3821
 2012-01-24 11:58:07 +09:00
Jean Chalard
35e9a7ac55 Merge "Squash a ridiculously improbable NPE" 2012-01-22 18:37:29 -08:00
Tadashi G. Takaoka
54c2dd67b0 Merge "Support @string reference in moreKeys attribute" 2012-01-20 01:59:31 -08:00
Tadashi G. Takaoka
e54a4005d5 Support @string reference in moreKeys attribute 
Change-Id: If0056d0601149d2ddd0e231a81e7b2409b37fc06
 2012-01-20 18:46:33 +09:00
Jean Chalard
7c177e82af Merge "Fix a bug where a check would fail" 2012-01-20 01:16:44 -08:00
Jean Chalard
7546ff6e34 Fix a bug where a check would fail 
Bug: 5894393
Change-Id: I810de58730f2cabcaf7b8dc1d85b3725f959094b
 2012-01-20 18:09:59 +09:00
Tadashi G. Takaoka
3eede315dc Merge "Move MoreKeySpecParser.getResourceId to Utils" 2012-01-20 00:01:29 -08:00
Tadashi G. Takaoka
0718590486 Move MoreKeySpecParser.getResourceId to Utils 
Change-Id: I0640dbe76a8ff2dc45b504eca631942811571736
 2012-01-20 16:28:18 +09:00
Jean Chalard
af9fe5c5fc Fix a bug where the user typed word would not be passed. 
Bug: 5894271
Change-Id: I4f02ff322697159e08f5e898608c0aff11dacb2f
 2012-01-20 15:39:06 +09:00
Jean Chalard
250cf0a781 Merge "Fix a bug with backspace happening after a manual pick." 2012-01-19 01:55:30 -08:00
Jean Chalard
3b2112e70a Fix a bug with backspace happening after a manual pick. 
Bug: 5884397
Change-Id: I01f462075bcbf7da38e9af2084ecd37143923e8b
 2012-01-19 18:41:02 +09:00
Jean Chalard
95a6e58ebc Small code simplification. 
I'm pretty sure the test here was useless.

Change-Id: Iaece641fbd5455406533b19555f2b639759a525f
 2012-01-19 18:03:45 +09:00
Jean Chalard
af480be66e Squash a ridiculously improbable NPE 
This probably can't be triggered by anything that is not
a monkey, but still, let's fix this

Bug: 5797549
Change-Id: I9a7d9fd6664c97787ce676a28675e96f46df7658
 2012-01-19 12:06:00 +09:00
Tadashi G. Takaoka
5731b939c7 Remove KeyboardSwicther.toggleCapslock 
Change-Id: Id613c06e2df770659095d78d42637aed063d0c70
 2012-01-17 19:26:24 +09:00
Tadashi G. Takaoka
2a88440419 Rename KeyboardActionListener methods 
* Rename KeyboardActionListener.onPress to onPressKey
* Rename KeyboardActionListener.onRelease to onReleaseKey
* Merge KeyboardSwicther.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardSwitcher.onReleaseShift and onReleaseSymbol to onReleaseKey.
* Merge KeyboardState.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardState.onReleaseShift and onReleaseSymbol to onReleaseKey.

Change-Id: Icf28fd18e238c5e534c292893e4ab5b6b98e72f8
 2012-01-17 19:07:20 +09:00
Tadashi G. Takaoka
c9fade6b87 Merge "Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher" 2012-01-17 00:07:38 -08:00
Tadashi G. Takaoka
87e025da11 Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher 
Change-Id: I9bb8f78b0a766cd7937d5cbe1c1e5e35898b2997
 2012-01-17 16:49:33 +09:00
Jean Chalard
d104a7aac8 Merge "Fix a bug where words disappear on inserting separators" 2012-01-16 23:22:03 -08:00
Jean Chalard
edc6395d9b Fix a bug where words disappear on inserting separators 
The basic idea is that in some situations, we would restart
suggestions, but before evaluating them we would bail out
because suggestions were not requested. This would lead to
the "correction" set to null, so we would commit a null word.

This fix does two things:
- Do not restart suggestions when not requested.
- If we still end up with a composing word when suggestions
  are not requested, we select the typed word as the
  correct version.

Bug: 5846646
Change-Id: Ic35351841d0cb20afa99092ef681ecb7bd68bec6
 2012-01-17 16:16:52 +09:00
Jean Chalard
aed5819a84 Merge "Fix a bug where suggestion would restart at a bad time" 2012-01-16 22:51:23 -08:00
Jean Chalard
fbd1ac8083 Fix a bug where suggestion would restart at a bad time 
Bug: 5846646
Change-Id: I7c907d0a9478e0878b92ead94173caefc21b627b
 2012-01-17 15:50:18 +09:00
Tadashi G. Takaoka
1ef6fc7e15 Support EditorInfo.IME_FLAG_FORCE_ASCII 
Bug: 5850605
Change-Id: I6665b483f775094903f2e26f5584e4b141592ab5
 2012-01-17 14:38:00 +09:00
Tadashi G. Takaoka
edf107e2a6 Merge "Add "force non-distinct multitouch" debug option" 2012-01-16 20:22:36 -08:00
Tadashi G. Takaoka
06b7c256b1 Add "force non-distinct multitouch" debug option 
Change-Id: I9fd6fabf03515011cedb8aaa30fdb7a77f2d4d12
 2012-01-17 13:19:01 +09:00
Jean Chalard
a8ba49c253 Small cleanup 
The method deleteWordAtCursor would call finishComposingText,
which is a very unexpected state change and would probably cause
surprising bugs to any parent that would call it.
As it happens, it's not used anywhere any more so let's just
remove it.

Change-Id: Iaa9200866e40b4e914f76baa987279948300679c
 2012-01-17 11:55:23 +09:00
Jean Chalard
72d285f4d7 Add some comments about resuming auto-suggestion 
Bug: 5846646
Change-Id: Ib2c76ec173972eb7acadbfaae7e930849d546721
 2012-01-17 10:29:11 +09:00
Tadashi G. Takaoka
9751a626ec Don't cache resource value that depends on orientation 
Bug: 5794655
Change-Id: Ib324366c772e20bb54aba63c2f4540dc0f9de515
 2012-01-16 12:26:34 +09:00
Tadashi G. Takaoka
211680e375 Merge "Fix SuggestTests" 2012-01-13 01:39:43 -08:00
Tadashi G. Takaoka
9c735b8038 Fix SuggestTests 
We need revised scoring test because dictionary look up algorithm has
been changed significantly since this SuggestTests was made.

Change-Id: I69d527a6bfa24ed0dc189fddad1afab0566c6eb8
 2012-01-13 15:25:28 +09:00
satok
4da8e8e4d3 Merge "Fix a bug in the logic to show 3 dots of the ime switcher" 2012-01-12 19:41:12 -08:00
satok
83a018419a Fix a bug in the logic to show 3 dots of the ime switcher 
Bug: 5806103
Change-Id: I67b3f0bb25d5fb9cfb902c03f41ae3e582107187
 2012-01-13 11:50:31 +09:00
satok
21814c56f0 Merge "Move auto correction thresthold to the native code" 2012-01-12 02:58:35 -08:00
satok
be0cf72253 Move auto correction thresthold to the native code 
bug: 5858137

Change-Id: Ic4b6270c6e51ef4ed25a6a1d8ddd7fdfa70fd78d
 2012-01-12 19:56:15 +09:00
Jean Chalard
ab34a4a7f5 Merge "Fix a bug where last candidate would not be reset" 2012-01-11 21:47:35 -08:00
Jean Chalard
cda8a42cbe Merge "Add a sanity check" 2012-01-11 21:47:26 -08:00
Jean Chalard
a8c8ab1cb4 Remove an excessive parens 
Change-Id: If8aa4253ab0f664e628ed7f4d7a3adc02a898cc7
 2012-01-12 14:07:56 +09:00
Jean Chalard
852630ba34 Add a sanity check 
Check if any character is both a magic space swapper and
a magic space stripper for the current language, and throw
an exception if found. Since this is expensive, it's done
only in debug mode.

Change-Id: Ibd166db87c91495b76878ea0e4f420a62c7bb276
 2012-01-12 12:44:49 +09:00
Jean Chalard
9de5cfc67a Fix a crash where revertSwap would be wrongly called 
This would crash the program when inputting a punctuation
symbol that should not swap with a weak space through the
suggestion strip, then press backspace.
Those include all two-part punctuation symbols in French for
example, as well as magic space strippers like the dash in
English. For English all suggestion strips symbols happen to
be magic space swappers so this would not happen in English
by default.
Also fix a typo.

Change-Id: Ia40678c264e978509b5786290a75a3c57181648e
 2012-01-12 11:55:40 +09:00
Jean Chalard
cd2286fff1 Fix a bug where last candidate would not be reset 
Bug: 5851148
Change-Id: Ic270318842d8e16bc62d78d5fe0d6be0ca1fb532
 2012-01-12 11:16:51 +09:00
Tadashi G. Takaoka
8cab0b56eb Get rid of Keyboard.CODE_DUMMY 
Change-Id: Id2320f4d9b5f22f0ac844ab20ce42b0c4e7c6880
 2012-01-10 18:19:36 +09:00
Tadashi G. Takaoka
ee4be6e3c6 Call KeyboardState.onUpdateShiftState from onCodeInput if code is a normal letter 
This will be helpful to write unit test code.

Change-Id: Ib61cc46ac547084e0dc9ecd3a50814fecf08ace2
 2012-01-10 15:13:05 +09:00
Ken Wakasa
0d0f01da67 Fix a typo. A follow up to I68dd6b8d 
Change-Id: I16fa4099c75faac35344b0e4d3c2b866ddac896a
 2011-12-21 22:34:08 +09:00
Jean Chalard
0fd625bcfd Fix a bug with wrong auto-correct cancellation 
Auto-correct cancellation would sometimes kick in at
wrong times, causing crashes.

Bug: 5784542
Change-Id: I68dd6b8d9237ce9b66af2dc63e77ba6dd5fd69dd
 2011-12-21 19:28:02 +09:00
Jean Chalard
752d8cc4fc Fix a bug with TYPE_TEXT_CLASS 
This was introduced by a badly-rebased commit. The culprit was
I103d6851. There was also another bug lurking there introduced
by a previous commit that this fixes.

Bug: 5775347
Change-Id: I133b54a5159e19714f4bcae8ffbb4824cff9f466
 2011-12-20 15:31:55 +09:00
Jean Chalard
9e8761c440 Reorganize the auto-correction memory 
Change-Id: I31cce9db471dcd4a7b3477bcb037a8ff482b7696
 2011-12-19 17:33:15 +09:00
Tadashi G. Takaoka
4e1dab8cfa Move KeyboardBuilder and KeyboardParams classes into Keyboard class 
This change also moves XmlParseUtils to com.android.inputmethod.latin package.

Bug: 5778201
Change-Id: I7d9faa344460753ce178ad4048e0fadb65c75614
 2011-12-18 20:19:16 +09:00
Tadashi G. Takaoka
3708787fe9 Remove LatinKeyboard class 
Change-Id: I68c667b00dadf2ed9f1c62fb7da37d2cf499cd81
 2011-12-18 19:10:42 +09:00
Tadashi G. Takaoka
4112dc0500 Move spacebar drawing code from LatinKeyboard to LatinKeyboardView 
Also this change moves LatinKeyboard attributes,
autoCorrectionSpacebarLedEnabled, autoCorrectionSpacebarLedIcon,
spacebarTextRatio, spacebarTextColor, and spacebarTextShadowColor to
LatinKeyboardView.

Change-Id: I7cc27ce1fc550e9f620a9ed0fbe4b8172902d5a1
 2011-12-18 19:07:12 +09:00
Tadashi G. Takaoka
22b48de11c Get rid of Key.needsSpecialPopupHint and related 
Change-Id: I28e87ea3af9581f12094770b42f113e9018886c4
 2011-12-18 16:08:28 +09:00
Jean Chalard
43c0a034bd Merge "Pretty print for InputAttributes" 2011-12-16 04:01:49 -08:00
Jean Chalard
4d0f03bd66 Remove a write-only variable. 
Change-Id: I825307a429f46b31ed9bd940b5a97d2713127dfe
 2011-12-16 20:54:58 +09:00
Jean Chalard
6fa003ee23 Pretty print for InputAttributes 
Change-Id: I5e4b2b6f3cd943c8f6187aaed21d67ec786bf5df
 2011-12-16 20:53:44 +09:00
Jean Chalard
2b2c0b574c Merge "Use the WordComposer to check if we are composing a word" 2011-12-16 03:47:34 -08:00
Jean Chalard
80b66bb166 General cleanup. 
Move variables around, inline useless functions, remove
useless local variables.

Change-Id: Icb89d8b211a2ad4bc3619137c2276a649c2a5e34
 2011-12-16 20:36:32 +09:00
Jean Chalard
644c8b7c96 Initialize input attributes in the InputAttribute class 
Change-Id: I103d6851f54f47cbffdb567fb0f4c505c4697b05
 2011-12-16 20:35:16 +09:00
Jean Chalard
3b7aceca60 Merge "Make applicationSpecifiedCompletionOn final." 2011-12-16 03:20:00 -08:00
Tadashi G. Takaoka
bf7ed75e4f Merge "Move KeyboardSwitcher.getKeyboard to KeyboardSet" 2011-12-16 03:13:38 -08:00
Tadashi G. Takaoka
645128af71 Move KeyboardSwitcher.getKeyboard to KeyboardSet 
This change also gets rid of XML id from KeyboardId.

Bug: 5002108
Bug: 5679585
Change-Id: I7086c7da3c01ba4ade7f77ee5cc731310da46404
 2011-12-16 20:10:57 +09:00
Jean Chalard
ccc35f7fa7 Make applicationSpecifiedCompletionOn final. 
This is the last one (whew)
Also move a somewhat unrelated initialization out of the
input attribute initialization function.

Change-Id: Icc77b32fd16b112ab43786715061b1c9dca31c04
 2011-12-16 19:09:01 +09:00
Jean Chalard
9cc1312eee Make inputTypeAutoCorrect final. 
Change-Id: I550eba1fc3fa2843d007a8208d81fad208c1196b
 2011-12-16 19:08:52 +09:00
Jean Chalard
13db05f930 Make isSettingsSuggestionStripOn final. 
Change-Id: Iabb99a7f8f3f1777f9a87ae2bddff9795a50fa92
 2011-12-16 19:08:13 +09:00
Jean Chalard
1ba17f97d5 Small refactoring 
This helps to make following changes smaller

Change-Id: I95ba2901ac3bf1ed70a748c35a0babdd9af1df63
 2011-12-16 18:21:26 +09:00
Jean Chalard
4fc0f6ab02 Merge "Make insertSpaceOnPickSuggestionManually final." 2011-12-16 01:15:35 -08:00
Jean Chalard
2ad14a2ea7 Merge "Use temporary variables for computing editor attributes" 2011-12-16 01:07:56 -08:00
Jean Chalard
520e69056e Merge "Create a class for input attributes." 2011-12-16 01:06:12 -08:00
Jean Chalard
ae0c109d11 Make insertSpaceOnPickSuggestionManually final. 
Change-Id: I32fce0ea8c5c58b6f920d0758c8bf57769f39a12
 2011-12-16 18:04:39 +09:00
satok
cadc0f7d79 Merge "Send touch event in usability study mode" 2011-12-16 01:04:26 -08:00
Jean Chalard
4e8922f1be Use temporary variables for computing editor attributes 
The ultimate intent is to make these variables final,
which will allow to move the computing function to the
InputAttributes class.

Change-Id: Ifb1fc7321a19b10d60aa63fa0daaa2708deda2cf
 2011-12-16 18:04:17 +09:00
Jean Chalard
dc9d0fcc11 Create a class for input attributes. 
Change-Id: I834390c83865aac59fb758d5c66cf9b74103abd8
 2011-12-16 18:03:16 +09:00
satok
15d4793911 Send touch event in usability study mode 
Change-Id: I0cdcd57bfd31c9b21cfb932d7ff91bd013cde6d7
 2011-12-16 17:56:14 +09:00
Jean Chalard
196d82cdd7 Use the WordComposer to check if we are composing a word 
...instead of the hard-to-understand mHasUncommittedTypedChars.
This is possible because now the word composer is actually aware
of commits.

Change-Id: I36b664ce8402a280f801e87b9ebe161f416b0853
 2011-12-16 15:58:29 +09:00
Jean Chalard
be2f81f055 Merge "Make the word composer aware of commits." 2011-12-15 22:54:23 -08:00
Jean Chalard
c73c26790f Make the word composer aware of commits. 
Change-Id: I04e691fbc9227d4df195429bca89edea93575347
 2011-12-16 15:41:10 +09:00
Tadashi G. Takaoka
8c3d5b6961 Add com.android.inputmethod.latin.suggestions package 
Change-Id: If4b823768ab9c073625da3034ecc8091be1df230
 2011-12-16 14:21:44 +09:00
Tadashi G. Takaoka
a44685ab32 Add colorValidTypedWord and alphaValidTypedWord 
This change fixes Gingerbread theme.

Change-Id: I142437ac0173df48ab36390f47ed67c6cea24a65
 2011-12-16 12:26:19 +09:00
Tadashi G. Takaoka
e9a0efc242 Merge "Cleanup unused variables and parameters" 2011-12-15 18:02:38 -08:00
Tadashi G. Takaoka
2ac5988f84 Cleanup unused variables and parameters 
Change-Id: Iad756a7a775c93f3344c6962e7b3456ef8339490
 2011-12-15 20:26:12 +09:00
Jean Chalard
05f654d498 Merge "Group all input-related info into an inner class." 2011-12-15 03:21:47 -08:00
Tadashi G. Takaoka
c3ef86d861 Merge "Fix auto correction spacebar LED" 2011-12-15 03:19:32 -08:00
Jean Chalard
27dff63833 Group all input-related info into an inner class. 
Currently, these variables hold the info about the composing
word, or maybe some outdated info, and it's not very clear
which it is. LatinIME is maintaining the freshness info in
a separate boolean, and uses it throughout the code for many,
many things, leading to much confusion.
The idea in grouping this info is, it can be saved in another
instance and restored later. It can be tested against to know
whether there is actually outdated but kept info or not, and
it should allow to straighten out what is actually currently
being typed. Ultimately, it will eliminate the need for
LatinIME to keep track of the status of the info in the
word composer.

Change-Id: I00e2c690f303f8320c9be35590a6df4583e9e456
 2011-12-15 19:58:04 +09:00
Tadashi G. Takaoka
2d74806262 Change visibility to avoid synthetic accessor method 
Change-Id: Ie93c7437fb9a3fe63adaa48c2d4a723f96c0a0e1
 2011-12-15 19:50:53 +09:00
Tadashi G. Takaoka
23d27fefcb Fix auto correction spacebar LED 
Change-Id: I4894d188d5612380cc9f8eec7cb72544e37fb2b0
 2011-12-15 17:34:14 +09:00
Jean Chalard
f3ca6a59a7 Cleanup 
Change-Id: I724df0be7ac07ffb9f1f4974175aed5a2606221b
 2011-12-14 18:42:47 +09:00
Jean Chalard
1c6cf26c37 Move some code inside a function to simplify flow 
Also rename the function to reflect better the behavior.
An upcoming change will clean up the remnants

Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
 2011-12-14 17:56:57 +09:00
Jean Chalard
46798d8f1f Fail faster in case of a bug 
Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
 2011-12-14 17:54:18 +09:00
Jean Chalard
b588003426 Refactoring. 
Small simplification of the code.

Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
 2011-12-14 16:59:25 +09:00
Tadashi G. Takaoka
e35e13fc7d Merge "Record onStartInputView" 2011-12-13 23:31:43 -08:00
Tadashi G. Takaoka
689b901156 Merge "Utilize KeyboardSet XML definitions" 2011-12-13 23:31:00 -08:00
Jean Chalard
dbdb385bb0 Merge "Fix a long-standing race condition." 2011-12-13 23:29:47 -08:00
Tadashi G. Takaoka
f86109ca56 Utilize KeyboardSet XML definitions 
This change introduces KeyboardSet and SubKeyboard XML definitions to
represent a set of keyboard layouts.

Bug: 5002108
Bug: 5679585
Change-Id: Ib6c8d5936187381bb6725c9fe574e93871c01a86
 2011-12-14 16:28:31 +09:00
Jean Chalard
514beb0992 Fix a long-standing race condition. 
Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.

Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
 2011-12-14 16:24:18 +09:00
Tadashi G. Takaoka
7ef235f53f Record onStartInputView 
Bug: 5722703
Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
 2011-12-14 16:22:30 +09:00
Jean Chalard
8e3faff244 Merge "Decouple member logic from control flow" 2011-12-13 06:28:48 -08:00
Jean Chalard
7b5bc1ff4d Decouple member logic from control flow 
This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.

Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
 2011-12-13 23:15:12 +09:00
Jean Chalard
f7d6517d6b Various mini-cleanups 
- Stop the word composer from escaping - take a page from the law
  of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.

Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
 2011-12-13 23:09:22 +09:00
Jean Chalard
edf4995a3b Merge "Remove the input connection sidework from handleCharacter" 2011-12-13 04:28:30 -08:00
Jean Chalard
dafa7a8e15 Remove the input connection sidework from handleCharacter 
Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
 2011-12-13 21:12:07 +09:00
Jean Chalard
117fc93f37 Move mBestWord to the word composer. 
mBestWord has a confusing name - it's actually an auto-correction.
It's cleaner if it lives in the word composer because an
auto-correction should be tied to a specific user input, and
should be reset each time the user input changes to avoid
race conditions.

Change-Id: I718d29395bc747372067e6440e090c6a181994ae
 2011-12-13 21:06:51 +09:00
Jean Chalard
7e6f4daa19 Merge "Tighten conditions for space-related cancelling" 2011-12-13 01:23:15 -08:00
Jean Chalard
c525750835 Merge "Consolidate underlining code under one function." 2011-12-13 01:22:08 -08:00
Jean Chalard
77d59b0691 Consolidate underlining code under one function. 
Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
 2011-12-13 17:42:27 +09:00
Jean Chalard
8ad4013406 Tighten conditions for space-related cancelling 
Instead of ignoring silently a found bug, throw an exception.

Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
 2011-12-13 17:40:06 +09:00
satok
ba526e3157 Extract the jni library name 
Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
 2011-12-13 17:25:43 +09:00
Jean Chalard
14cb8448df Remove a useless return 
Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
 2011-12-13 16:48:28 +09:00
Jean Chalard
2939063947 Simplification 
Both tests have the same meaning. They should be merged.
Also, if "deleteLast()" deletes more than one char (which
never happens in the current implementation, but it's not
guaranteed), the new code is more correct.

Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
 2011-12-13 16:06:00 +09:00
Jean Chalard
d2c69c7d12 Refactoring 
If mHasUncommittedTypedChars is true, then
mWordSavedForAutoCorrectCancellation must always be null, and
spaceState must always be SPACE_STATE_NONE.
Hence, this change is supposed to be very no-op.

Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
 2011-12-13 16:04:11 +09:00
Jean Chalard
2245c3b5b3 Refactor + small bugfix 
postUpdateShiftKeyState used to be called also when
mEnteredText is not null => this is a bugfix.
The rest does not change the logic, as posting a message can
be done anywhere within the function with no impact.

Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
 2011-12-13 15:59:36 +09:00
Jean Chalard
a2a85d45e0 Refactoring 
Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
 2011-12-13 15:38:49 +09:00
Jean Chalard
34081186f9 Merge "Fix a bug where revert auto-correct would revert too much" 2011-12-12 04:46:27 -08:00
Jean Chalard
5c3ff4c9c8 Fix a bug where revert auto-correct would revert too much 
If there are no uncommitted chars, we shouldn't enter any of
the tests that follow. We didn't use to, but a change today
made it possible - it should not happen.
There is no point in doing the rest of the tests, they are
sure to fail.

Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
 2011-12-12 21:27:16 +09:00
Jean Chalard
4f41cbc588 Remove a useless function call 
Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
 2011-12-12 20:51:43 +09:00
Jean Chalard
dcf8a6b2c6 Merge "Move a settings var to the settings class" 2011-12-12 03:31:42 -08:00
Jean Chalard
2a659b8aa6 Remove a useless variable 
This can be just read when it's needed.

Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
 2011-12-12 20:22:39 +09:00
Jean Chalard
d567b230b0 Move a settings var to the settings class 
Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
 2011-12-12 19:52:17 +09:00
Jean Chalard
7208af0ecd Remove a messy and unused class. 
Today is a happy day

Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
 2011-12-12 19:31:29 +09:00
Jean Chalard
f162ed7ec8 Merge "Remove side-effects from TextEntryState" 2011-12-12 02:20:49 -08:00
Jean Chalard
406d192a9e Remove side-effects from TextEntryState 
Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
 2011-12-12 19:19:39 +09:00
Jean Chalard
c2a76a1529 Remove a useless variable. 
Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
 2011-12-12 16:49:32 +09:00
Jean Chalard
890d13189d Straighten out logic for revert word paths 
This also includes a new memorized string with simpler
logic that will allow to remove other members

Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
 2011-12-12 16:41:49 +09:00
Jean Chalard
86344836ee Merge "Remove a duplicated variable." 2011-12-11 21:26:31 -08:00
Tadashi G. Takaoka
2ba1bcccdd Remove unused Keyboard.CODE_CANCEL 
Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
 2011-12-12 12:56:30 +09:00
Jean Chalard
3651220327 Remove a duplicated variable. 
This is awesome cleanup.

Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
 2011-12-12 12:06:41 +09:00
Ken Wakasa
9260422423 Build God Mode keyboard with API level 14 
Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8
 2011-12-10 03:45:40 +09:00
satok
4af5e3c5f4 Fix isResearcherPackage 
Change-Id: I286450fe89a37d75cb398f17d300ddc6f5857ffd
 2011-12-10 01:16:16 +09:00
Ken Wakasa
2edd109f84 Some tweaks for Researcher Mode 
Change-Id: I6b16dd2fe6d7356c747ba0ee2da5976738003ded
 2011-12-10 00:35:50 +09:00
satok
2a89e36db0 Merge "Add a functionality to attach a log file to Gmail app Bug: 5722703" 2011-12-09 05:59:36 -08:00
satok
a8b6292cee Add a functionality to attach a log file to Gmail app 
Bug: 5722703

Change-Id: I089f944bdbf2cbb036eb59dd9b5b414370c770f1
 2011-12-09 22:38:15 +09:00
Tadashi G. Takaoka
963abf4bcc Merge "Remove unused public methods from KeyboardState and KeyboardSwitcher" 2011-12-09 04:38:14 -08:00
Jean Chalard
74671cf6c5 Resolve TODOs: add members to hold preferences 
Change-Id: I34f6c76bf9318e1fbe8eb5ffab6772a98ff824e0
 2011-12-09 21:24:13 +09:00
Tadashi G. Takaoka
df9deffba2 Remove unused public methods from KeyboardState and KeyboardSwitcher 
Bug: 5708602
Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
 2011-12-09 21:14:13 +09:00
Jean Chalard
0fe3611bee Resolve TODOs: add some members to store prefs 
Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
 2011-12-09 20:16:57 +09:00
Jean Chalard
85b063f97e Resolve TODOs: add members to store raw settings 
Change-Id: I481eadb6a73faf239e24d05b7e220fcb01194fa4
 2011-12-09 19:03:55 +09:00
Jean Chalard
12f10e1585 Read options in the declaration order 
Change-Id: I1a7c4d0bcaedad6d4045c36c79280c23234db5b3
 2011-12-09 18:58:24 +09:00
Jean Chalard
c40b807ca4 Straighten out prefs reading code 
Change-Id: Ibf9113a8ef07ac720100ee32d2e5ef321e8ddd98
 2011-12-09 18:54:07 +09:00
Jean Chalard
bab1f045f4 Straighten out members extracted from resources. 
Change-Id: I9b9602ec5b379b44b0f0663d4f065dbcf88fd352
 2011-12-09 18:19:30 +09:00
Jean Chalard
ba93dda8ce Match constant names to option names 
Change-Id: I7586fa342d7a39412d656890f7b525139c45ea4a
 2011-12-09 17:58:51 +09:00
Jean Chalard
837b109f27 Reorder members in SettingsValues. 
Reorder so that they match the order in the preference xml
file. Also add TODOs for missing raw variables.

Change-Id: I06332c131a624d6c359512d75c808f3f7313fa91
 2011-12-09 17:56:31 +09:00
Jean Chalard
c207e0a7da Move settings variables to the settings class 
Change-Id: Ifa7033a84b08ea626eb44cf6d04ba8e28c250bea
 2011-12-09 16:47:31 +09:00
Jean Chalard
284c8a0449 Merge "Stop a flag from escaping." 2011-12-08 23:14:15 -08:00
Jean Chalard
0c3b8ce842 Merge "Move settings method from Utils to SettingsValues" 2011-12-08 23:09:33 -08:00
Jean Chalard
4606de117b Stop a flag from escaping. 
The ultimate intent is to close it up in the settings, as it does not
change while typing, only when the keyboard is open again.

Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
 2011-12-09 16:09:04 +09:00
Jean Chalard
ed43296217 Move settings method from Utils to SettingsValues 
Change-Id: I633378a41f63cd492b8c9345d550e07254df5e5a
 2011-12-09 16:03:10 +09:00
satok
4bae9d56d9 Merge "Show usability study mode for research purposes" 2011-12-08 22:40:58 -08:00
satok
e0dfc54c5b Show usability study mode for research purposes 
Bug: 5722703

Change-Id: I27acc374c5d4b52707708b83689dea5d78a573d7
 2011-12-09 15:31:06 +09:00
Tadashi G. Takaoka
a76c62e92d Merge "Remove direct calls of setKeyboardXXX from KeyboardSwitcher" 2011-12-08 21:33:09 -08:00
Tadashi G. Takaoka
96c56cb577 Remove direct calls of setKeyboardXXX from KeyboardSwitcher 
These calls, setAlphabetKeyboard, setSymbolsKeyboard, and
setSymbolsShiftedKeyboard have to be call backed from KeyboardState.

Bug: 5708602
Change-Id: Ibbe1a21bd10bf942e17886869c0ab0fa1735b87e
 2011-12-09 13:26:11 +09:00
Jean Chalard
7a16a061e6 Extract Settings.Values to a new class 
This is pretty much automatic refactoring. Thanks Eclipse!

Change-Id: I8ccd24d11878445c836347e9c487c91461eee9cd
 2011-12-09 12:40:50 +09:00
Jean Chalard
92e5756dfb Merge "Cleanup" 2011-12-08 05:14:26 -08:00
Jean Chalard
c1fdd966a7 Remove a useless method 
Change-Id: Ib6a0ee21bfe2000231f9ba7bcad4b18ae57e4249
 2011-12-08 21:47:26 +09:00
Jean Chalard
283b0c2b64 Cleanup 
Here, shouldAutoCorrect implies mSettingsValues.mAutoCorrectEnabled

Change-Id: I9256718dd63b75252d1454e264db6814bbf18aa5
 2011-12-08 21:37:15 +09:00
Jean Chalard
3da7df8db7 Merge "Add proximity for Russian." 2011-12-08 02:22:28 -08:00
Jean Chalard
1830cd1dc8 Add proximity for Russian. 
This also tries to make the code as easy to extend as possible
for future developments.

Bug: 5701241
Change-Id: I1ed48e6a5cc7aab94c5d6e309930cc004247d7e7
 2011-12-08 19:00:52 +09:00
Jean Chalard
9e38f9a980 Merge "Use the system-wide interface to add a word." 2011-12-08 00:52:32 -08:00
Tadashi G. Takaoka
eef6238f94 Move SWITCH_STATE related stuffs to KeyboardState 
Bug: 5708602
Change-Id: I904ec370e3761c47af17a680c0932ec98cfd3c27
 2011-12-08 16:12:49 +09:00
Tadashi G. Takaoka
6b7100feca Don't execute pending onStartInputView if EditorInfos are equivalent 
Bug: 5722732
Bug: 5722867
Change-Id: I8347c258b286c3329f318d50adf205e78e49c722
 2011-12-07 22:39:13 +09:00
Jean Chalard
361c42b746 Use the system-wide interface to add a word. 
Bug: 5306641
Change-Id: Ic87e5bc3a5f1f03c57d48f2d92c28e0aba06847d
 2011-12-07 16:19:05 +09:00
Tadashi G. Takaoka
8a70e70c84 Remove toggleSymbolsShift and rename toggleKeyboardMode 
Bug: 5708602
Change-Id: Iadef3e862d00505d1d9f588d0d64445754d7b962
 2011-12-06 18:12:34 +09:00
Jean Chalard
bb2b30fc7f Add support for Russian spell checking. 
Note that this is not enough: we still need to create a
reasonable proximity table for Cyrillic characters, or we
won't be able to show up suggestions.

Bug: 5701241
Change-Id: Idb141f7a230a6e1a46094308c26f43c01ab3b97a
 2011-12-05 18:57:03 +09:00
Jean Chalard
db5aedb5a5 Add an option to use contacts or not while spell checking 
Bug: 5447495
Change-Id: Iffb09895676c3dd1a79d1699b0eac865282508d4
 2011-11-30 18:58:10 +09:00
Tadashi G. Takaoka
e22baaadd3 Get rid of usage of key index 
Change-Id: I7596ce3ae52fde436d06c2dd95ae873c7aa5ef7f
 2011-11-29 19:07:54 +09:00
Jean Chalard
55042ff977 Merge "Resume suggestion when backspacing to the end of a word" 2011-11-29 01:15:42 -08:00
Tadashi G. Takaoka
b230806f44 Merge "Save keyboard layout only when it is shown" 2011-11-29 00:53:38 -08:00
Jean Chalard
6b1f500da4 Resume suggestion when backspacing to the end of a word 
Bug: 5515381
Change-Id: I26fea896feaf2e9716c7ae3d4f2630360f23ac50
 2011-11-29 17:50:36 +09:00
Jean Chalard
117fc18ed4 Keep count of the trailing single quotes for suggestions 
Bug: 5665809
Change-Id: I4d9100dbe980861ccb55c78464524be670cac1f7
 2011-11-29 15:16:28 +09:00
Tadashi G. Takaoka
f2c9a88887 Save keyboard layout only when it is shown 
Bug: 5130446
Change-Id: I150b4a053036eae050099155169325f0d1f7dfed
 2011-11-29 14:12:49 +09:00
Tadashi G. Takaoka
9324665263 Move ignore special key code out from LatinIME to PointerTracker 
Bug: 5560766
Bug: 5639503
Change-Id: I34c9eea833516adf6ef1db58f1a64a5ef5322fa9
 2011-11-22 17:49:12 -08:00
Jean Chalard
6d1cbbc2ff Fix a bug with single quotes 
I14dd3815 special-cased single quotes at the start of a word, but
did not do so correctly - it would kill a composing word if entered
just after some punctuations.
The right test was not isCursorTouchingWord() but
mHasUncommittedTypedChars, which actually makes for a simpler
implementation.

Bug: 5648032
Change-Id: Icd21d213e0cad6da68cacfeb921502cd8dcfac95
 2011-11-22 18:29:51 +09:00
Tadashi G. Takaoka
e7eac906c0 Pending onStartInputView only if the EditorInfo is identical 
Bug: 5604372
Change-Id: I2a88cf15b07eebd29e43e460f6ec758432181b01
 2011-11-21 16:32:46 -08:00
Jean Chalard
19cbdfc92f Merge "Remove an unused (and scary) method" 2011-11-21 00:57:45 -08:00
Jean Chalard
ce86e39e00 Merge "Cleanup." 2011-11-21 00:53:49 -08:00
Jean Chalard
5d5028f2c5 Remove an unused (and scary) method 
Change-Id: I14a545a3e4955a25fde17554156552c755d44e2f
 2011-11-21 17:45:32 +09:00
Jean Chalard
6ecd1e1280 Merge "Special case quotes at start and end of words" 2011-11-21 00:21:09 -08:00
Jean Chalard
c83359f974 Special case quotes at start and end of words 
Single quote at start of word is not considered a part of a
word any more.
Single quote at the end of a word now behave like capitalization:
lookup in the dictionary is done *disregarding* a final quote,
and it is forcefully added back into the suggestions afterwards.

Bug: 5566368
Change-Id: I14dd3815f4b743edba56d64a3abdf4b73d863a6a
 2011-11-21 16:34:39 +09:00
Tadashi G. Takaoka
e00ede531f am 5619d765: Shift/Symbol/Smiley will not disable settings/microphone keys 
* commit '5619d7658459d13723b6d7ad8969b249adf9e717':
  Shift/Symbol/Smiley will not disable settings/microphone keys
 2011-11-18 15:23:14 -08:00
Tadashi G. Takaoka
5dc318a3f2 am 10dff768: Fix NPE introduced by I38b21d49 
* commit '10dff76856a98b6eec86a53d3d07fdc9708037b7':
  Fix NPE introduced by I38b21d49
 2011-11-18 14:48:05 -08:00
Tadashi G. Takaoka
49cc3beb75 resolved conflicts for merge of 137667ed to master 
Change-Id: I75fc5d278b002ab89dd2475d282d0ee4aede7817
 2011-11-18 08:51:39 -08:00
Tadashi G. Takaoka
5619d76584 Shift/Symbol/Smiley will not disable settings/microphone keys 
Bug: 5560766
Change-Id: Ic2dbb835e87a7debb222093756816e683b464b83
 2011-11-17 23:32:19 -08:00
Jean Chalard
88562bec54 Cleanup. 
Fix a typo, and move a cursor.close() in a finally{} clause

Change-Id: Iac011ebb80b9430774c7dc5cd94728d05cef443f
 2011-11-18 15:24:49 +09:00
Tadashi G. Takaoka
10dff76856 Fix NPE introduced by I38b21d49 
Bug: 5560766
Change-Id: Ic5eaebe0ef893c69ad90a777ebfa07807535a0e3
 2011-11-17 21:46:24 -08:00
Tadashi G. Takaoka
137667ed3d Merge "Ignore microphone and settings key while typing" into ics-mr1 2011-11-17 18:01:43 -08:00
Tadashi G. Takaoka
175acb8205 Ignore microphone and settings key while typing 
Bug: 5560766
Change-Id: I38b21d49b7e803bf94805ba8e13849b3c734e010
 2011-11-17 16:01:31 -08:00
Tadashi G. Takaoka
60acfdf4a8 Skip loading keyboard when SoftInputWindow hasn't shown yet. (DO NOT MERGE) 
This is cherry-pick of I003101b2 from Master for Bug: 5541192
Bug: 5636367

Change-Id: I560126d17be6a770b19c1f1347332ebdfde5d671
 2011-11-17 14:30:54 -08:00
Tadashi G. Takaoka
eb520c5683 am 549e295d: Fix updateFullscreenMode of LatinIME 
* commit '549e295dc113bff50077c3c355dcd94af09a1b2f':
  Fix updateFullscreenMode of LatinIME
 2011-11-15 18:25:21 -08:00
Tadashi G. Takaoka
549e295dc1 Fix updateFullscreenMode of LatinIME 
Bug: 5597608
Change-Id: If4b18dc933493bd74bc5506c028af86b0450df1f
 2011-11-15 15:15:11 -08:00
Ken Wakasa
ed631627cb Double space conversion should be enabled only when the 1st space is "weak". 
bug: 5608934
Change-Id: Ide7ca9d526620c4f225a6f5eb27dcd7df5b504bd
 2011-11-15 12:35:22 +09:00
Jean Chalard
85170a9c17 Merge "Be stricter for ruling characters out of spell checking" 2011-11-10 15:51:45 -08:00
Jean Chalard
72479ea363 Be stricter for ruling characters out of spell checking 
Bug: 5548308
Change-Id: Ie8025b02424b72b69a07907cde1093830c2d4d3d
 2011-11-10 12:57:09 +09:00
Jean Chalard
a409f009fa Fill in the HAS_RECOMMENDED_SUGGESTIONS flag. 
Bug: 5530727
Change-Id: Ic53e227f72096053e08d90204bf1f287ec09290b
 2011-11-10 02:52:46 +09:00
Ken Wakasa
cea3c5bc17 am 0a75373f: Merge "Fix a bug where the UserDictionary may not be released" into ics-mr1 
* commit '0a75373f4187d2db036757c2c2bcaba42301fd22':
  Fix a bug where the UserDictionary may not be released
 2011-11-07 23:04:05 +00:00
Jean Chalard
8b9c89aee2 Fix a bug where the UserDictionary may not be released 
Bug: 5547357
Change-Id: I521afeaa349c86fb0087cedb70127de6acebec78
 2011-11-07 14:31:59 +09:00
Tadashi G. Takaoka
1e39565bb4 Skip loading keyboard when SoftInputWindow hasn't shown yet. 
Bug: 5541192
Change-Id: I003101b2a3fdeb5bb554d249634ec5ab50aea09e
 2011-11-04 15:01:58 +09:00
Jean Chalard
2c77216e22 Remove trailing spaces when appropriate 
Bug: 5509651
Change-Id: I99cfb5a6fc2873e2c11ed16967cd82a7f504a263
 2011-11-02 19:44:26 +09:00
Tadashi G. Takaoka
5fdcd7d5cd Fix JNI as 64bit ready 
Change-Id: I7a3ed2cee3b20744869aa5cf89ff9fd95f5ab8fe
 2011-10-31 20:44:01 +09:00
Tadashi G. Takaoka
6f811bd13f Merge "Make some private method static" 2011-10-27 22:57:58 -07:00
Tadashi G. Takaoka
8fbf29e2d5 Make some private method static 
Change-Id: Ia23765268be0ef89d7fe7c3f5372ed32d6615765
 2011-10-28 13:31:31 +09:00
Tadashi G. Takaoka
3122cf8daa am 07a44557: Merge "Cancel pending rotation when another rotation start" into ics-mr1 
* commit '07a445572f7fa21c0e24f5cdb0f0b88ff2adc672':
  Cancel pending rotation when another rotation start
 2011-10-27 22:59:14 +00:00
Ken Wakasa
644d33d60e Display "Touch again to save" in the keyboard locale 
bug: 524239
Change-Id: I227c193ba149f9296f8b1cf40aa3d9cf4e6ae2ab
 2011-10-28 00:33:15 +09:00
Tadashi G. Takaoka
dd25e4fa2c Cancel pending rotation when another rotation start 
Bug: 5516802
Change-Id: Iccb0abeb94e6dc1322a98a0c744188bb74034c7f
 2011-10-27 17:03:03 +09:00
Tadashi G. Takaoka
37c6bbb675 am a7c41996: Merge "Preventing infinite call of dismissMoreKeysPanel" into ics-mr1 
* commit 'a7c419964f46d1c354e81c5688f5da6b43428c9a':
  Preventing infinite call of dismissMoreKeysPanel
 2011-10-27 02:35:12 +00:00
Tadashi G. Takaoka
a7c419964f Merge "Preventing infinite call of dismissMoreKeysPanel" into ics-mr1 2011-10-26 17:27:35 -07:00
Tadashi G. Takaoka
ef543c725e Merge "Use onCustomRequest to request haptick and audio feedback" 2011-10-26 07:54:23 -07:00
Tadashi G. Takaoka
d999ea4480 Use onCustomRequest to request haptick and audio feedback 
Change-Id: I958f274d8cfebb1551cdf08f1bada50c20fb9ca0
 2011-10-26 23:32:38 +09:00
Tadashi G. Takaoka
e648e83939 Merge "Remove eventTime argument from PointerTracker.onShowMoreKeysPanel" 2011-10-26 07:29:25 -07:00
Ken Wakasa
44f4d77b75 am cb8cb95d: Fix NPE 
* commit 'cb8cb95d0afd340de9f1a0e15948f0068d2450bc':
  Fix NPE
 2011-10-26 14:25:28 +00:00
Tadashi G. Takaoka
e51d164482 Remove eventTime argument from PointerTracker.onShowMoreKeysPanel 
Change-Id: Idbcd6e3047c6c0c407e3b347cf9f65951d43a312
 2011-10-26 20:54:35 +09:00
Jean Chalard
120586c226 Group special spaces and double/swapped spaces in undo mode 
This introduces an elementary undo facility that accounts
for magic space, strong space, double space and its cancelling,
and swapped punctuation and its cancelling.
The former three were existing behavior ; this change adds
the swapped punctuation cancelling behavior.

Bug: 5454442
Change-Id: I87af633f30caa2788e9af725e556a7f0746d9a14
 2011-10-26 19:12:55 +09:00
Jean Chalard
dec6c0f929 DO NOT MERGE: Fix a bug where the sequence numbers would be wrong 
The spell checker cannot afford to return static objects,
seeing as the framework will then use the same objects to
pair the cookie and sequence ids to the request.
This is a backport of Ia9c3a933

Bug: 5503243
Change-Id: Ia9c3a933bfb30cf5525418b240ef60632d72c9d0
 2011-10-26 17:57:00 +09:00
Tadashi G. Takaoka
0cf7a45ac5 Preventing infinite call of dismissMoreKeysPanel 
Bug: 5514583

Change-Id: Idf8dd1ebba0afdb768e538c2626b60770421d4be
 2011-10-26 17:03:41 +09:00
Ken Wakasa
cb8cb95d0a Fix NPE 
bug: 5512097
Change-Id: Id6752c95c9c4b39e7975daa187a2ab92b740060a
 2011-10-26 02:35:44 +09:00
Jean Chalard
d0c5f9395a Cleanup. 
Remove a state that can never be reached, and ajust all the
callers that would always have received false.

Change-Id: Iac025568be11743428419e0772da306a4f0a0bf1
 2011-10-25 21:57:30 +09:00
Jean Chalard
ce668e7a0b Small clean up. 
Remove unused methods and constants.

Change-Id: If72e04394a2943b416915217d22cb6e58a0508b3
 2011-10-25 21:35:43 +09:00
Jean Chalard
126698fdd2 Add a strong space behavior. 
Bug: 5454442
Change-Id: Ic095cb65dd7b4427617cd74fc7c53a9666b218c4
 2011-10-25 18:40:14 +09:00
Jean Chalard
c47c2dc65a Merge "Fix a cosmetic bug where text would blink on space swap" 2011-10-25 02:14:28 -07:00
Jean Chalard
b715299125 Fix a cosmetic bug where text would blink on space swap 
On space swap or space removal in some occasions there would be
a small blink on the screen. This change fixes that.

Change-Id: I486cbcc5dfcafd531b3fa92c4f9a3255832f22cc
 2011-10-25 18:02:23 +09:00
Jean Chalard
cd43edbc32 Small clean up 
Remove an unused method and constant

Change-Id: I3e99ea9fc182c83399d46aca81d1b69aab2c36d1
 2011-10-25 17:12:51 +09:00
Jean Chalard
cba1af9c56 Fix a bug where the sequence numbers would be wrong 
The spell checker cannot afford to return static objects,
seeing as the framework will then use the same objects to
pair the cookie and sequence ids to the request.

Bug: 5503243
Change-Id: Ia9c3a933bfb30cf5525418b240ef60632d72c9d0
 2011-10-24 22:40:41 +09:00
Jean Chalard
ee89b40a92 Merge "Use the contacts dictionary in the spell checker." 2011-10-24 03:48:34 -07:00
Jean Chalard
2e3c6da868 Use the contacts dictionary in the spell checker. 
Bug: 5447495
Change-Id: I7292eb291a1630265884cc8e505a2e83a74f0c72
 2011-10-24 19:44:01 +09:00
Tadashi G. Takaoka
b2b1eb5ca5 Call updateFulscreenMode before calling isFullscreenMode 
Bug: 5495739
Change-Id: I25eab59833a8b95a0b75893d37a45e67504fa7d0
 2011-10-24 15:30:49 +09:00
Jean Chalard
26a531c6fe Rename a flag 
...and insert some explaining commands

Change-Id: Iff6511e71d66abfaea9f6c21c47f74fa0a67ad78
 2011-10-21 19:59:46 +09:00
Tadashi G. Takaoka
49426a1ea9 Fix potential NPE 
Bug: 5462524
Change-Id: I76012d1bbcd83d58f034c2f588802e4d1b7edc4d
 2011-10-20 20:31:17 +09:00
Tadashi G. Takaoka
9f058749f2 am 61aebb0a: Merge "Update suggestions strip divider" into ics-mr0 
* commit '61aebb0a1e3d12cd5287c9be3c2e37df565af888':
  Update suggestions strip divider
 2011-10-19 18:11:20 -07:00
Tadashi G. Takaoka
61aebb0a1e Merge "Update suggestions strip divider" into ics-mr0 2011-10-19 18:09:17 -07:00
Tadashi G. Takaoka
78674d0ff7 Add warning log for unexpected inputType (DO NOT MERGE) 
This is a cherry-pick of I3484c751 from Master.

Bug: 5130446
Change-Id: I140980bf093fb3310496c8021166d16f0ddc362f
 2011-10-19 18:52:07 +09:00
Tadashi G. Takaoka
2c47080e7b Update suggestions strip divider 
Bug: 5142447
Change-Id: I275a304e46456e3b80968fb5de330a3b04bd2035
 2011-10-19 16:54:37 +09:00
Tadashi G. Takaoka
82c8c2e6c0 Add warning log for unexpected inputType 
Bug: 5130446
Change-Id: I3484c75144ba68db0734a4d38186d2eafd1b1879
 2011-10-19 16:53:07 +09:00
satok
c5d51a40a4 am fe2d9079: Fix a bug that the typed word with the blue underline indicator will be duplicated 
* commit 'fe2d90798ea409ee39d6f63942eb01bb7eed98e3':
  Fix a bug that the typed word with the blue underline indicator will be duplicated
 2011-10-17 11:32:24 -07:00
satok
fe2d90798e Fix a bug that the typed word with the blue underline indicator will be duplicated 
Bug: 5466373

Change-Id: I0300c34cb6076b12ecb89cb29bea95288559108f
 2011-10-17 13:25:22 +09:00
Tadashi G. Takaoka
6262fa5307 am ed6bc82d: Merge "Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced"" into ics-mr0 
* commit 'ed6bc82d9785372c407e1a4f563ae7d30c479b8a':
  Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced"
 2011-10-13 22:09:08 -07:00
Tadashi G. Takaoka
d874ac581e Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced" 
This reverts commit b1bc5fd896. (If3a73179)
Bug: 5410786
 2011-10-14 12:15:24 +09:00
satok
22c2a23cda am 605a6fea: Merge "Fix the safety net Bug: 5453150" into ics-mr0 
* commit '605a6fea750c4acc96a5136ecaf7162e0a858b9f':
  Fix the safety net Bug: 5453150
 2011-10-12 23:46:25 -07:00
satok
605a6fea75 Merge "Fix the safety net Bug: 5453150" into ics-mr0 2011-10-12 23:44:54 -07:00
satok
2aa1dd45c4 Fix the safety net 
Bug: 5453150

Change-Id: I5990feb2622738988bf29843c6bcdb9cbf8bbf33
 2011-10-13 15:16:59 +09:00
Tadashi G. Takaoka
283d35cb6c am 62fb8a48: Merge "Take invisible extractArea height into account" into ics-mr0 
* commit '62fb8a480df325ebc6b2a4dc023a944e3cd0bcef':
  Take invisible extractArea height into account
 2011-10-12 12:00:44 -07:00
Tadashi G. Takaoka
62fb8a480d Merge "Take invisible extractArea height into account" into ics-mr0 2011-10-12 11:02:05 -07:00
satok
e596fe2702 am ef0a7b75: Merge "Suppress flickers of the auto correction indicator" into ics-mr0 
* commit 'ef0a7b75462c75b756caa09d9dd356309968abf3':
  Suppress flickers of the auto correction indicator
 2011-10-12 10:10:41 -07:00
satok
604d80c671 Suppress flickers of the auto correction indicator 
Bug: 5440788
Change-Id: I7832b449ee777dbd87388a02cebdfee0ce350fbd
 2011-10-12 19:14:13 +09:00
Tadashi G. Takaoka
d44647e76f Take invisible extractArea height into account 
Bug: 5410786
Change-Id: I97ce2d72f86ce62b37d408103863af66f91e7107
 2011-10-12 19:13:28 +09:00
satok
a86869711e Merge "Add a settings to change the sound effect volume" 2011-10-11 06:29:11 -07:00
satok
79c0acf519 Add a settings to change the sound effect volume 
Bug: 5345401
Bug: 5402541
Change-Id: I1e653573a3362160104b77388d6cbd1700424649
 2011-10-11 22:25:13 +09:00
Tadashi G. Takaoka
8d4be2516a Merge "Fix haptic and audio feedback of caps-lock mode changing" 2011-10-11 00:38:17 -07:00
Tadashi G. Takaoka
f44aeb6618 Fix haptic and audio feedback of caps-lock mode changing 
Bug: 5435669
Change-Id: Ic1c1eb00d7e535a3ac602b9b505fd8bf43da5a8d
 2011-10-11 15:27:56 +09:00
Tadashi G. Takaoka
ed2b6c714b Remove unused import 
Change-Id: I31115c29e47cdd09b2d8cc8f04e9fc9f9d542811
 2011-10-11 12:53:36 +09:00
satok
602bcecf6b Merge "Put SuggestionSpan as the indicater of the auto-correction" 2011-10-10 02:58:22 -07:00
satok
ec780e2868 Put SuggestionSpan as the indicater of the auto-correction 
Bug: 5245468

Change-Id: Ia5609e1b3c69f5553e3632fbce60a55665a5b185
 2011-10-10 18:44:52 +09:00
Svetoslav Ganov
7c2d7ad634 Merge "Let accessibility users know to connect a headset when the IME connects to a password field." 2011-10-07 15:36:04 -07:00
Jean Chalard
fee149abe0 Use the whitelist as a dictionary in the spell checker. 
Bug: 5402436
Change-Id: If89b8bbdebf6751697c4788270d01d4639cff665
 2011-10-07 19:25:36 +09:00
Jean Chalard
266ae6964d Merge "Fix a bug with the whitelist" 2011-10-07 02:50:11 -07:00
Jean Chalard
5f41b705fc Fix a bug with the whitelist 
This bug would kill the case where the whitelist contains
a word to be autocorrected to an uppercased version of
itself, and the user would enter the uppercase version.
In this case, this bug would cause the typed word to be
killed off the list of candidates, and possibly autocorrected
to the *next* candidate.

When the whitelist checks whether this the typed word is
a candidate for whitelisting, this change has it check whether
the whitelisting results in the typed word before returning.
Hence, it can keep the case-insensitive behavior of the
whitelist.

Coincidentally, this change renames the method used to do
this, because it does not comply with the general contract
of Dictionary. This happens to be in the way of another
upcoming change.

Bug: 5420371
Change-Id: Ifb305271acc5f171adf9b18c762ae7975b14be0a
 2011-10-07 18:40:23 +09:00
Tadashi G. Takaoka
beac24226b Merge "Add haptic feedback for caps lock" 2011-10-07 02:21:15 -07:00
Jean Chalard
af0f13d15c Add pretty-printing to SuggestedWords.Builder to help debug 
Change-Id: I2f40ca40f2b452078d0f24cef72e0182e10e2269
 2011-10-07 14:35:18 +09:00
Tadashi G. Takaoka
416ee19d33 Add haptic feedback for caps lock 
When long press triggers caps lock, the keyboard also triggers haptic
feedback.

This change also fixes trivial harmless bug in KeyboardSwitcher.

Bug: 5424681
Change-Id: I62706b49abd7be1dcebc3c5166ea03f426fc8c86
 2011-10-07 13:57:49 +09:00
Alan Viverette
b0c8db018d Let accessibility users know to connect a headset when the IME connects to a password field. 
Change-Id: If96cd7626950dd12e88a8a97f5e405d303d41e06
 2011-10-06 11:02:29 -07:00
Jean Chalard
3d36cdcd2d Merge "Fix possible NPE in debug mode" 2011-10-06 03:44:24 -07:00
Jean Chalard
51075d145a Fix possible NPE in debug mode 
Change-Id: I55776110a489621c99e9a3bf58daa6fcaf415cb3
 2011-10-06 19:36:40 +09:00
Jean Chalard
c53661f152 Fix a possible OutOfBoundsException 
Change-Id: I6eb13c228738119c78496a96acaedbccefd83cd3
 2011-10-06 19:05:23 +09:00
Jean Chalard
3458d61807 Make the whitelist an instanciable class. 
This goes together with I6b8628b9acc32449e4147a2a754b222fbb76c754
or it will break the build

Bug: 5402436
Change-Id: I07c6266b713773a8de80bb22afdd4c566261f78a
 2011-10-06 16:05:21 +09:00
Tadashi G. Takaoka
ab72a97d7c Cleanup unused import 
This change also gets rid of several compiler warnings.

Change-Id: I23962edaadad18a6e0395d528af17b909dcf5dad
 2011-10-04 12:46:20 +09:00
Yusuke Nojima
a25dd3b5c3 Merge "Pass the touch position correction flag from KeyboardSwitcher." 2011-10-03 04:42:53 -07:00
Yusuke Nojima
294e1b4a5a Pass the touch position correction flag from KeyboardSwitcher. 
Change-Id: Ia242a9fa2fa71f7fdf8f974071a2df7acc4aa51f
 2011-10-03 20:41:03 +09:00
Jean Chalard
45f45a4fdb Cleanup : remove recorrection-related stuff. 
This removes UPDATE_OLD_SUGGESTIONS, and the associated settings.

Bug: 5402537
Change-Id: Ie87d4e05c54e4b7d2dd5a05f2d0b570e9cd3e463
 2011-10-03 18:23:23 +09:00
Jean Chalard
fe5364c825 Cleanup : remove old recorrection code 
This removes the calls, but another change will be needed to remove
the messages LatinIME used to send itself to update the suggestion
strip.

Bug: 5402537
Change-Id: I5d1aa63a892516f339f3ceac21f43771b5ffda34
 2011-10-03 17:45:45 +09:00
Jean Chalard
cd95a36558 Fix a bug where moving the cursor would not reset selection 
This change updates suggestions when the cursor is moved.
It is now reasonable to remove the explicit test for
TextEntryState.isAcceptedDefault because it is now shielded
by mExpectingUpdateSelection : actually, this probably fixes
a long-standing bug.

Bug: 5337309
Change-Id: Iee4046420c6a88d1a07d428230f93c3ebef25c39
 2011-10-03 17:18:29 +09:00
Jean Chalard
397f6f8299 Merge "Small refactoring" 2011-10-02 23:12:41 -07:00
Jean Chalard
4c0fe57198 Small refactoring 
Change-Id: Ifc33e109562abb3dd720ad4fed76add8ab1a64aa
 2011-10-03 14:58:34 +09:00
satok
904baab25a Remove code related to AutoText 
Bug: 5245751

Change-Id: Ic02f951e8e1dbde9d8964d2c16e4928fb374ca41
 2011-10-03 14:38:44 +09:00
satok
62c7e25e11 Move SharedPreferencesCompat to com.android.inputmethod.compat 
Change-Id: Ied336339b8eb3643f14517c251b07c09398f61fe
 2011-09-30 20:17:32 +09:00
satok
ba76e6ff27 Show the duration of vibration in settings 
bug: 5345401

Change-Id: I666d48d8ddf6c14540eb401129c20ce93972d9cf
 2011-09-30 20:09:04 +09:00
Jean Chalard
646a66159a Merge "Make use of the FULL_EDIT_DISTANCE flag." 2011-09-30 00:41:14 -07:00
Jean Chalard
673cebf9e9 Make use of the FULL_EDIT_DISTANCE flag. 
In effect, this stops the spell checker from suggesting overly
long words.
More precisely, it takes advantage of the new facility that
takes into account the whole length of the dictionary word when
computing scores, so words much longer than the input word will
see their score demoted accordingly.

Bug: 5384578
Change-Id: I326cd7c87c3080e7fa8729f78517f8ba13672a9b
 2011-09-30 16:00:07 +09:00
Tadashi G. Takaoka
59f8ca752d Skip successive InputMethodService callbacks after orientation changed 
IME is called back four methods for each input field as a IME life
cycle. The four methods are onStartInput, onStartInputView,
onFinishInputView and onFinishInput.

After orientation changed, Those quartet methods will be called back
twice. This behavior of the framework might be a bug.

In order to restore the previous keyboard layout, we should skip
onFinishInputView and onFinishInput of the first quartet and
onStartInput and onStartInputView of the second quartet.

Bug: 4311428
Change-Id: I450ddc0cce5d00abc971ffd42a507a8a86682548
 2011-09-30 10:38:32 +09:00
satok
db096d681f Merge "Add a flag to demote completed suggestions" 2011-09-29 03:58:27 -07:00
satok
40a5f6fa4d Add a flag to demote completed suggestions 
Bug: 5390063
Change-Id: I0ef4fbcc705539624269fd2f8c4e782679fc44b3
 2011-09-29 19:48:18 +09:00
Jean Chalard
3ff95b7290 Merge "Add a threshold for suggestion score." 2011-09-29 01:47:50 -07:00
Jean Chalard
4609c02f9e Add a threshold for suggestion score. 
Bug: 5384578

Change-Id: Ic0b0203d873492a41c72defef835adf36f010f47
 2011-09-29 17:38:08 +09:00
satok
4866758a98 Merge "Update suggestions when user presses the backspace even when there is not two or more suggestions" 2011-09-29 00:19:17 -07:00
satok
074cda4d26 Update suggestions when user presses the backspace even when there is not two or more suggestions 
Bug: 5384445
Change-Id: I419999da8f5745ac114d0173beeadcb365a8c3ac
 2011-09-29 16:12:11 +09:00
Tadashi G. Takaoka
2087cf508a Merge "Handle back key and outside touch correctly in more suggestions window" 2011-09-28 23:41:55 -07:00
Tadashi G. Takaoka
bfc1d732ac Handle back key and outside touch correctly in more suggestions window 
Bug: 5385284
Change-Id: Ic0517182d294c79e37c88f1ef30cb4d2917b2800
 2011-09-29 15:07:15 +09:00
Jean Chalard
85782abaf1 Move some arguments to final members. 
This is preparation for
Bug: 5384578

Change-Id: I7d493c441f375fa5f23c5e3cfa8134e2ce7775fe
 2011-09-29 13:11:09 +09:00
satok
433965784d add vibration duration settings 
Change-Id: I56a1a94df63160f367f866da759d7dd4fc428ed5
 2011-09-29 11:46:20 +09:00
Jean Chalard
90086846dc Merge "Change the logic of the LOOKS_LIKE_TYPO flag" 2011-09-28 03:59:26 -07:00
Jean Chalard
647db70fec Change the logic of the LOOKS_LIKE_TYPO flag 
It now follows the following logic:
- If the word should be filtered out => false
- Else => !IN_THE_DICTIONARY

This defines the behavior for ICS MR0, and prepares for addition
of a new HAS_LIKELY_SUGGESTIONS flag in MR1.

Bug: 5383800

Change-Id: I530b1404ae8cf3337ff68ef5ab0f4d95f2dad0e8
 2011-09-28 19:42:43 +09:00
Tadashi G. Takaoka
2fc4248700 Introduce hit box to Key and get rid of edge flags 
Change-Id: I2b78d2ca756223b5497d01127c3a0190dcc81e57
 2011-09-28 19:31:37 +09:00
Tadashi G. Takaoka
ffd156c77e Postpone onDisplayCompletions until onStartInputView has been executed 
Bug: 5108267
Change-Id: I42d297ce4e4913e5dab5f5d647b1d13dc860b884
 2011-09-28 09:36:40 +09:00
Tadashi G. Takaoka
f451ed2012 Forward touch events above the keyboard to the suggestions strip 
The gutter area between the suggestions strip and the top-row keys
looks like a part of the suggestions strip, and the touch events
landing on the area should be forwarded to the suggestions strip.

Bug: 5246673
Change-Id: I92af763be0feed21aa36ceffb5d575abe554f19e
 2011-09-27 19:02:24 +09:00
Tadashi G. Takaoka
73cd4c1428 Fix onDeatchedFromWindow to protected 
Change-Id: Ief666554ffd405a43363e66ea2bc2d87aa76a882
 2011-09-27 15:18:02 +09:00
Jean Chalard
a9876980c8 Fix a possible deadlock. 
Bug: 5359873
Change-Id: I80ae901c43b6ae59879e3c8b1a9dd8a937d558c1
 2011-09-26 18:16:24 +09:00
Tadashi G. Takaoka
acf6b6815a Merge "Fix keyboard row height calculation" 2011-09-25 19:25:28 -07:00
Tadashi G. Takaoka
8fbfac4ffb Fix keyboard row height calculation 
The keyboard height will be distrubuted as:
  top_padding + (key_height + vertical_gap) * row_count - vertical_gap + bottom_padding

Change-Id: I841f356b9dbf8cfaf3756178bc9e4e6b2aa61364
 2011-09-26 10:25:49 +09:00
Ken Wakasa
c9f562a9a4 Partially revert I0fa5eefc 
bug: 5344295
Change-Id: Idb10e37862773a62ff60afe874844e8968a58b5d
 2011-09-24 09:38:45 +09:00
Fabrice Di Meglio
c66a7278d2 Merge "Revert "Use "..." instead of "\u2026""" 2011-09-23 15:08:23 -07:00
Fabrice Di Meglio
9bdce3a59e Revert "Use "..." instead of "\u2026"" 
This reverts commit 8673ceb066

The Roboto Font is having the real ellipsis back
 2011-09-23 14:59:33 -07:00
Gilles Debunne
8d6fd877c5 am b1bc5fd8: Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced 
* commit 'b1bc5fd896329a39ad51a8c79e2970750c814ea0':
  Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced
 2011-09-21 18:57:03 -07:00
Gilles Debunne
b1bc5fd896 Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced 
CL https://android-git.corp.google.com/g/#/c/136474 refactored
the fullscreen test, but ithe IME_FLAG_NO_EXTRACT_UI test was
lost in the process.

Note that there is still a problem (orthogonal to that change
with key_preview_backing, which appears opaque and black sometimes.

I'll re-open 5315001.

Change-Id: If3a73179d21eaca10bdc948db7bac4b4f7a88d34
 2011-09-21 16:14:30 -07:00
Tadashi G. Takaoka
68c7b9b195 Merge "Remove "autoCorrectInvert" feature from SuggestionsView" 2011-09-20 23:28:31 -07:00
Tadashi G. Takaoka
92a83e74ec Merge "Fix key preview backing view height" 2011-09-20 23:24:43 -07:00
Tadashi G. Takaoka
77a87e3cb5 Remove "autoCorrectInvert" feature from SuggestionsView 
Bug: 5162005
Change-Id: Iec679f5f05f28cd7e8013d7350ea03372f1cd7b2
 2011-09-21 15:06:51 +09:00
Tadashi G. Takaoka
8673ceb066 Use "..." instead of "\u2026" 
Because "TRHEE DOT LEADER" glyph of Roboto font is broken, we decide
to use "..." instead.

Bug: 5344295
Change-Id: I0fa5eefc00baf80747ff5215c018619a7e15a58e
 2011-09-21 14:00:36 +09:00
Tadashi G. Takaoka
f5fe245df0 Fix key preview backing view height 
Bug: 5344344
Change-Id: Ied0cda2c4b822b391ece54a6880fae8e349cc0bc
 2011-09-21 11:22:05 +09:00
Tadashi G. Takaoka
3fc4ddec68 Sliding suggestions strip starts showing more suggestions 
Bug: 5301019
Change-Id: I87daa9e472f9e93a6da9de754376b7fa4740171a
 2011-09-21 10:42:50 +09:00
Ken Wakasa
37af28dd23 Enable vibrate on keypress by default 
bug: 5337363
Change-Id: I14c95d27dd236d0a43e64a46ae6fbf9f2a97a3da
 2011-09-20 20:31:03 +09:00
Ken Wakasa
34a9831811 Merge "Tweak LatinIME's keypress volume" 2011-09-20 04:07:38 -07:00
Tadashi G. Takaoka
95dba8a82c Merge "The back button key event is delivered correctly" 2011-09-20 04:00:44 -07:00
Ken Wakasa
f58293f6eb Tweak LatinIME's keypress volume 
bug: 5337902
Change-Id: I7f864f158d110aa3e755961303799882f59b7e4c
 2011-09-20 20:00:43 +09:00
Tadashi G. Takaoka
d7b00f3490 The back button key event is delivered correctly 
Bug: 5275063
Change-Id: I439ce18665e40dc8b2e40e923e5cabfcae7c81cf
 2011-09-20 19:51:03 +09:00
Tadashi G. Takaoka
6d8d25ee5a (DO NOT MERGE) Update fullscreen mode also at onStartInputView 
This is a cherry-pick cheof I190a71f7 from Master.

Bug: 5315001
Change-Id: I76c756eeecf21eec4c88dd4558d5c50f10ff3d3c
 2011-09-20 16:59:00 +09:00
Tadashi G. Takaoka
3ea503c851 Merge "Update fullscreen mode also at onStartInputView" 2011-09-20 00:47:00 -07:00
Tadashi G. Takaoka
59010a89b8 Update fullscreen mode also at onStartInputView 
This change also separates controlling visibility of "key preview
backing view" from suggestions strip visibility.

Bug: 5315001
Change-Id: I190a71f7956c804e5d89d2d5bacecc62d565ac2c
 2011-09-20 16:38:24 +09:00
Jean Chalard
d2547c6888 Merge "Have the spell checker report IN_DICT correctly" 2011-09-19 23:19:47 -07:00
Ken Wakasa
28f36d68af Tweak LatinIME's keypress vibration duration 
bug: 5337363
Change-Id: If6e6de587cbcddf26710d8f0b237c4bc393589b6
 2011-09-20 11:23:30 +09:00
Jean Chalard
e897e4d342 Have the spell checker report IN_DICT correctly 
...even if the word is filtered out.
This also contains minor refactoring.

Bug: 5329658
Change-Id: I397a2a74f819a51df3bd07c6b94e8d29244389c4
 2011-09-16 18:26:02 +09:00
Tadashi G. Takaoka
0967ef4036 Draw more suggestions hint using text font 
Bug: 5287964
Change-Id: I692b5303268c7b5115853177c956e147312c582d
 2011-09-16 16:47:58 +09:00
Tadashi G. Takaoka
ba0e30f212 (DO NOT MERGE) Fix checking capitalized word code 
This is a follow up change of If6c0edef.
This is a cherry-pick of Idb415f53 from Master.

Bug: 5328922
Change-Id: I36d8bda9fb95e4809598296226c598a9f08bd8bb
 2011-09-16 12:40:09 +09:00
Tadashi G. Takaoka
436a645ea8 Fix checking capitalized word code 
This is a follow up change of If6c0edef.

Bug: 5328922
Change-Id: Idb415f53f3fea6660c7802577d08b4d89d4e7842
 2011-09-16 12:28:13 +09:00
Jean Chalard
97ec205504 Merge "Add an option to user dict to match more precise locales" 2011-09-15 02:28:20 -07:00
Jean Chalard
cfed273922 Add an option to user dict to match more precise locales 
This should not be used lightly, as it violates the general
contract of locale, and does kill some legitimate (albeit
alledgedly rare) use patterns.
Currently, the spell checker uses this because it uses a
negative logic: it should match broadly, and when in doubt,
match even more broadly, which is almost never the case of
something that uses the locale.
In other words: don't use this option unless you are
very, VERY sure that's what you want. Hint: it isn't

Bug: 5280929
Change-Id: Ib3cae319c692161d653630038c5bcde1f4340c05
 2011-09-15 18:01:13 +09:00
Jean Chalard
39fe5bfc3c Merge "Avoid returning an object that's still used internally" 2011-09-15 00:28:19 -07:00
Jean Chalard
5c08151c22 Avoid returning an object that's still used internally 
There is no definite path known for this to end up being
touched by other classes, but we could imagine through
some way or some other it ends up shoved in the stringbuilder
pool, leading to catastrophic results.

Hopefully related to
Bug: 5248688

Change-Id: Ib8abfc31263cbf31d515ed607ced5d8253971938
 2011-09-15 16:23:03 +09:00
Jean Chalard
199dc5e0e4 Don't kill LatinIME if the spellchecker crashes. 
If the spellchecker encounters a bug and happens to crash,
it may be sensible to avoid killing the keyboard in response.
This is a possible way to do it, which comes with the big
drawback of making bugs in the spell checker harder to find.

Change-Id: Idb26fb592b9718e1dbdadeda8fbd1a8a1d805c28
 2011-09-15 16:01:21 +09:00
satok
fa52a09f21 Merge "Remove experimental settings" 2011-09-14 02:57:58 -07:00
Jean Chalard
d2738757d2 Merge "Filter out of spellchecking words that don't look like words" 2011-09-14 02:05:48 -07:00
Jean Chalard
88fa53b840 Filter out of spellchecking words that don't look like words 
Note that this affects only the results of the spell checker if
actually passed such a word. For example, the spell checker will
not flag "http://oju" as a typo, because it looks like a URL.
But in the current implementation, TextView passes "http" and
"oju" separately, so "oju" is still flagged as a typo.

Bug: 5281875
Change-Id: I9d721fd3af34edc51b11908cf2e8fe994b164242
 2011-09-14 17:46:06 +09:00
satok
c9c54a84bc Remove experimental settings 
Bug: 5314288
Change-Id: I31cbc6da0ca5e61a5fa4a893c774f2110a5698f1
 2011-09-14 16:24:39 +09:00
Jean Chalard
1586dc6edf Merge "Fix a bug where the user dict's locale match would be wrong" 2011-09-13 23:44:44 -07:00
Jean Chalard
d97def5925 Fix a bug where the user dict's locale match would be wrong 
This is preparation for
Bug: 5280929

Change-Id: Iab0096acf057aa288b1986d225aad815bd70b145
 2011-09-14 15:41:46 +09:00
Jean Chalard
63e55cd55e Don't report 1-char words as typos 
Bug: 5281875
Change-Id: If6b6d057e18390bf01dcd31c46104b6856fbdbda
 2011-09-13 21:45:19 +09:00
Tadashi G. Takaoka
ea843f2a24 Make WordComposer aware of capitalized word 
Change-Id: If6c0edef2334f018f2e04c6034f8ce747206f150
 2011-09-13 19:11:10 +09:00
Tadashi G. Takaoka
6602b03e80 Merge "Linger the "more suggestions" when the user is sliding the touch point" 2011-09-12 21:33:14 -07:00
Tadashi G. Takaoka
02ce5392f5 Merge "Dismiss the more suggestions when the user is sliding down the touch point" 2011-09-12 21:32:40 -07:00
Tadashi G. Takaoka
87104bace9 Dismiss the more suggestions when the user is sliding down the touch point 
Bug: 5299142
Change-Id: I466ff41948bbb49fb6874817ecfd94d338238d19
 2011-09-13 13:03:50 +09:00
Tadashi G. Takaoka
2abd8547e3 Linger the "more suggestions" when the user is sliding the touch point 
Bug: 5299024
Change-Id: I00b5e59ba480cbf057bdd69d1357d2c477be90f7
 2011-09-13 13:03:24 +09:00
Tadashi G. Takaoka
697bf585f8 Update suggestions strip text color 
Bug: 5287964
Change-Id: Ic40bb656873f41bb6d65427f02399464e831aab2
 2011-09-13 12:54:59 +09:00
Jean Chalard
f5ef30dfc6 Have the spell checker honor case 
Bug: 5281103
Change-Id: I415c84dbb55f1eeb5deb9f248b4056881982ee13
 2011-09-12 12:25:25 +09:00