Merge "Fix race condition while changing the system locale"

main
Tadashi G. Takaoka 2012-03-29 00:10:35 -07:00 committed by Android (Google) Code Review
commit aaa9e8626a
1 changed files with 7 additions and 5 deletions

View File

@ -168,12 +168,14 @@ public class LocaleUtils {
* @param newLocale the locale to change to.
* @return the old locale.
*/
public static Locale setSystemLocale(final Resources res, final Locale newLocale) {
public static synchronized Locale setSystemLocale(final Resources res, final Locale newLocale) {
final Configuration conf = res.getConfiguration();
final Locale saveLocale = conf.locale;
conf.locale = newLocale;
res.updateConfiguration(conf, res.getDisplayMetrics());
return saveLocale;
final Locale oldLocale = conf.locale;
if (newLocale != null && !newLocale.equals(oldLocale)) {
conf.locale = newLocale;
res.updateConfiguration(conf, res.getDisplayMetrics());
}
return oldLocale;
}
private static final HashMap<String, Locale> sLocaleCache = new HashMap<String, Locale>();