nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
29433 commits 1 branch 0 tags 363 MiB
Commit graph

5946 commits

Author SHA1 Message Date
Kurt Partridge
d117c1a116 Merge "Do not record log split time when handling separator" 2013-04-09 02:31:48 +00:00
Ken Wakasa
d17c8bd929 Update comments 
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
 2013-04-08 23:05:45 +09:00
Jean Chalard
c87449497c Fix bugs and add tests 
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
 2013-04-05 12:11:19 +09:00
Jean Chalard
7d3836d63a Move a generic string utility to StringUtils 
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
 2013-04-05 12:09:14 +09:00
Tadashi G. Takaoka
6e3f307266 Refactor SpellCheckerProximityInfo as extending ProximityInfo 
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
 2013-04-02 19:06:32 +09:00
Jean Chalard
ecb59eff90 Revert "[DO NOT MERGE] Activate hardware keyboard handling" 
This reverts commit c741f1f83b
DO NOT MERGE is ignored and this is merged anyway :(

Change-Id: Ie044cdfc6021933379ec97ad7346c5c8591f70bf
 2013-04-02 16:08:48 +09:00
Jean Chalard
c741f1f83b [DO NOT MERGE] Activate hardware keyboard handling 
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
 2013-04-02 15:38:13 +09:00
Kurt Partridge
30772c3758 Allow logging while replaying 
Previously logging was disabled during replay.  This makes it impossible to use logged data as a
regression test, since the new log was unavailable.  This change corrects this problem.

Change-Id: I19dc31def2f2f87fd219dc561c739d18e4ab9c9c
 2013-04-01 16:49:39 -07:00
Kurt Partridge
636b8c4231 Do not record log split time when handling separator 
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken.  However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word.  This change corrects this bug.

Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
 2013-04-01 16:48:15 -07:00
Kurt Partridge
5779bc91e6 Merge "Split LogUnits differently." 2013-04-01 23:08:21 +00:00
Kurt Partridge
0c0ab2b4d9 Merge "Reorder ResearchLogger call" 2013-04-01 15:19:45 +00:00
Jean Chalard
0745fe83d4 am b8869ec1: am 0fcc4960: Deactivate hardware keyboard handling. 
* commit 'b8869ec1e39c1751825841e790d21fc854dca9ce':
  Deactivate hardware keyboard handling.
 2013-04-01 05:42:42 -07:00
Jean Chalard
0fcc4960bc Deactivate hardware keyboard handling. 
Bug: 8000119

Change-Id: I021481343d6d87efd8ff6110e9aa0906a1a3d11d
 2013-04-01 21:35:45 +09:00
Tadashi G. Takaoka
75028af28c Interpolate gesture preview trails 
There is the boolean flag to kill interpolation.

Bug: 7167303
Change-Id: Iac7e4cb88cf437c2ee77c003c9cddb92416025c7
 2013-04-01 19:15:36 +09:00
Jean Chalard
43341ba042 Merge "Ask the client to make itself known when it's not" 2013-04-01 09:00:25 +00:00
Jean Chalard
76d5f512f9 Ask the client to make itself known when it's not 
Upon invoking the settings of the dictionary pack with an unknown
client, we now launch an intent to ask the client to make itself known.
This change also includes the code that receives this intent and
acts upon it.

Bug: 8492879
Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
 2013-04-01 17:37:22 +09:00
Jean Chalard
065f126f1d Merge "Fix two nasty bugs with surrogate pairs." 2013-04-01 08:28:08 +00:00
Jean Chalard
a411595b16 Fix two nasty bugs with surrogate pairs. 
The important bug is in findWordInTree. The problem, which is
not obvious, is that we were calling codePointAt() with the
code point index in the string, instead of the char index.
The other bug this change fixes was harmless in the practice,
because it's in the iteration which is only used for debug and
pretty printing purposes. It's very similar in that it would
substract a length in code point to a length in chars and
truncate a StringBuilder at that length, so it would fail in a
quite similar manner. This changes the meaning of the "length"
attribute in Position, but it's clearer this way anyway.

Bug: 8450145
Change-Id: If396f883a9e6449de39351553ba83f5be5bd30f0
 2013-04-01 17:06:19 +09:00
Jean Chalard
740da0d8d0 Fix an NPE 
Also remove an unused method and make 2 private variables
final.

Bug: 8461093
Change-Id: I676d93fda28e82eb5a6978f2e7ad5a0add2cbecf
 2013-03-29 18:41:29 +09:00
Tadashi G. Takaoka
48d8d8d0ae Fix potential NPE in MainKeyboardView.KeyTimerHandler 
Bug: 8469652
Change-Id: Ib7a548e6a24d2e02de85ab444c0ec99d8f6b82c3
 2013-03-28 17:54:36 +09:00
Jean Chalard
2188cbae63 Merge "Fix an NPE" 2013-03-28 06:56:49 +00:00
Jean Chalard
d555a0d77a Merge "Cleanup" 2013-03-28 06:16:40 +00:00
Jean Chalard
28d5f4577f Fix an NPE 
The code was passing the wrong parameter.

Bug: 8492879
Change-Id: I091d62ca29601e3807eed287c7bdad38bf43a502
 2013-03-28 15:08:05 +09:00
Jean Chalard
dae90cfb01 Cleanup 
Seems there was an unclosed cursor :o

Change-Id: I7616849ace5217d8c6f54465f7b3a634e3c14116
 2013-03-28 14:43:32 +09:00
Satoshi Kataoka
f463b45d8e Merge "Fix Possible NPE" 2013-03-27 04:51:48 +00:00
Satoshi Kataoka
2cdf5351aa Merge "Fix possible SIOOBE" 2013-03-27 03:28:49 +00:00
Satoshi Kataoka
33306acfa4 Fix possible SIOOBE 
Bug: 8461021

Change-Id: I8b0385610b80b5a672ec380935c485a0e01ae984
 2013-03-27 12:25:02 +09:00
Kurt Partridge
39cb0334d9 Avoid NPE 
Initialize FeedbackLog earlier to avoid NPE

Change-Id: I646944c68a7d092345def16060b2a4edd8c7dbef
 2013-03-26 16:46:43 -07:00
Kurt Partridge
189be5196a Split LogUnits differently. 
Previously an autocorrection caused a new LogUnit to be started,
splitting off the previous LogUnit right at the autocorrection method
time.  This change causes the split to happen before the MotionEvents
that led to the autocorrection being called.

Change-Id: I2504df8eb47ee77e5f46bac34a8450636c03fd9f
 2013-03-26 16:46:43 -07:00
Kurt Partridge
cb25e1fe37 Reorder ResearchLogger call 
Previously, ResearchLogger#onWordFinished() was called with an outdated parameter value for
isBatchMode, causing it to report false even for gestures.  This changes fixes this problem.

Change-Id: Ifcabee236ba5fe20376ad882155d3f3142cd7613
 2013-03-26 14:37:57 -07:00
Kurt Partridge
ef103e1f2e Merge "Close ResearchLogger upon onFinishInputView" 2013-03-26 19:23:00 +00:00
Tadashi G. Takaoka
73d00e68d8 Merge "Use XmlPullParser.getEventType()" 2013-03-26 05:38:18 +00:00
Satoshi Kataoka
435cccb2c5 Fix Possible NPE 
Bug: 8448448
Change-Id: Ibe89c9abd24c4debb33a69c372eadf2afb09ea1c
 2013-03-26 13:02:23 +09:00
Satoshi Kataoka
0b3271010f Merge "Fix possible NPE" 2013-03-26 03:49:06 +00:00
Tadashi G. Takaoka
52f4b04768 Use XmlPullParser.getEventType() 
Change-Id: Ie423d3416639f81409cc920658c8088b7519b045
 2013-03-26 12:13:56 +09:00
Tadashi G. Takaoka
d17b69ec00 Clean up XmlParserUtils 
Change-Id: I636e8f359d47f39e61a7f77e3e686f2721779b6f
 2013-03-26 12:03:07 +09:00
Kurt Partridge
6d71d238e2 [FileEncap18] Clean up uploading scheduling 
- Move scheduling logic from ResearchLogger.java to
  UploaderService.java
- Switch to a one-shot timer.  Previously the uploader was scheduled
  on an inexact repeating schedule.  It's better to reschedule the
  next upload after the current one is finished to reduce the chances
  of multiple uploads happening at the same time.
- Avoid double-execution
    - Previously a scheduled upload might run right after an explicit
      one if they occured at the same time.  This change reduces the
      chances of this.
- Some method extraction and naming

Change-Id: I9efda11be77d334c7f61bd40a36d65f0421ebde4
 2013-03-25 17:50:26 -07:00
Kurt Partridge
87bc3a4a62 Close ResearchLogger upon onFinishInputView 
Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden().  This
resulted in multiple logs being written.

Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.

Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
 2013-03-25 17:31:25 -07:00
Satoshi Kataoka
a17dccbfc6 Fix possible NPE 
Bug: 8457109
Change-Id: I321fbef53e20a7c36ef4bd9f544b50abe6a52be9
 2013-03-25 19:00:38 +09:00
Tadashi G. Takaoka
fb658d6c53 Fix possible ArrayIndexOutOfBoundsException 
Bug: 8461864
Change-Id: Icd8f4f51ec064461c08d00c1c58bedf5fbae2553
 2013-03-25 12:37:04 +09:00
Alan Viverette
a7b4398c35 Don't announce changes for A11y within the same keyboard mode. 
Bug: 8439108
Change-Id: If9f14bb65625468dcd399df47ad0d2123be30be7
 2013-03-22 11:53:12 -07:00
Satoshi Kataoka
19a7008728 Merge "Fix appname" 2013-03-22 07:23:08 +00:00
Satoshi Kataoka
3c8117c88f Fix appname 
Bug: 6789579
Change-Id: Ic4694e36e0846af95fa8dcdef919be251983b528
 2013-03-22 16:19:44 +09:00
Tadashi G. Takaoka
3a8a63c399 Remove unused import 
This is a follow up of I062c076f.

Change-Id: Ic3a83d95aed1f86121ed552a6f20f0d24f9d6d83
 2013-03-22 15:23:06 +09:00
Tadashi G. Takaoka
c6452f2569 Merge "Remove reference to string.english_ime_name" 2013-03-22 05:11:50 +00:00
Satoshi Kataoka
f4352c2ce3 Merge "Use correct appname resource" 2013-03-22 05:11:26 +00:00
Satoshi Kataoka
242c066dde Use correct appname resource 
Bug: 6789579
Change-Id: Id11435a28d6c5b6c72867814e23f5e62429080f8
 2013-03-22 14:08:38 +09:00
Tadashi G. Takaoka
9f3774c194 Remove reference to string.english_ime_name 
Bug: 6789579
Change-Id: I062c076f0ca16cc39274e20955aa83d667b7380d
 2013-03-22 14:08:23 +09:00
Tadashi G. Takaoka
ee91bde16c Clean up InflateException reference from KeyboardBuilder 
Change-Id: If9daa00b6d829ce2069a027e4bfec310ec108615
 2013-03-21 12:27:33 +09:00
Alan Viverette
9da7fa0f50 am 559616fb: Prevent keyboard A11y proxy from referencing a null keyboard view. 
* commit '559616fb0c39e2f0bacdf294b84ba16ad1e8f371':
  Prevent keyboard A11y proxy from referencing a null keyboard view.
 2013-03-19 23:59:56 +00:00
Alan Viverette
559616fb0c Prevent keyboard A11y proxy from referencing a null keyboard view. 
Bug: 8402674
Change-Id: I507cdabccdabb3fd7aebc071c93eb6d4dcb9635d
 2013-03-19 13:17:42 -07:00
Satoshi Kataoka
a462cd80ae Support feedback 
Bug: 8143554
Change-Id: If0a6bafc94da040f97f27c6d046fb58bed9fd615
 2013-03-19 17:25:55 +09:00
Jean Chalard
8e005f2989 am 1061bfdb: Break dependencies to allow offdevice tests to build 
* commit '1061bfdb34bbcb63bf0046eec42313d264ac33fa':
  Break dependencies to allow offdevice tests to build
 2013-03-19 08:12:50 +00:00
Jean Chalard
6d90a10a34 am 0cc0544a: Merge the dictionary pack in Latin IME. 
* commit '0cc0544a2995c7eb54a830ae54db60af89d4073d':
  Merge the dictionary pack in Latin IME.
 2013-03-19 08:12:49 +00:00
Jean Chalard
1061bfdb34 Break dependencies to allow offdevice tests to build 
Change-Id: Ia9a2e8f0672b3f72943f26fb15de1d3c7c5ce7f1
 2013-03-19 16:45:25 +09:00
Jean Chalard
0cc0544a29 Merge the dictionary pack in Latin IME. 
Bug: 8161354
Change-Id: I17c23f56dd3bc2f27726556bf2c5a9d5520bd172
 2013-03-19 15:40:14 +09:00
Tadashi G. Takaoka
841c295f3c resolved conflicts for merge of 5b048292 to master 
Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
 2013-03-19 10:48:10 +09:00
Ken Wakasa
9c3860ce46 Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS 
bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
 2013-03-18 23:15:47 +09:00
Jean Chalard
f8325ec4bb am 5cb0560b: Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 
* commit '5cb0560b000f37b3fb3937f01b6d3e928afef57a':
  Access the dictionary pack only if have INTERNET permission
 2013-03-18 11:08:52 +00:00
Jean Chalard
5cb0560b00 Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 2013-03-18 11:04:53 +00:00
Jean Chalard
ce487bcf33 Access the dictionary pack only if have INTERNET permission 
Bug: 8161354
Change-Id: I68ee3acb2955a017d25666cc2dad791798f9064a
 2013-03-18 18:40:33 +09:00
Satoshi Kataoka
62ed594c37 am e0e67373: Refactor parameters by naming convention 
* commit 'e0e67373735918c78eaeaf24f127e1d28816aa29':
  Refactor parameters by naming convention
 2013-03-18 06:47:10 +00:00
Satoshi Kataoka
e0e6737373 Refactor parameters by naming convention 
Change-Id: I8bda8075b33f656ecbec08320afcd864b620fe77
 2013-03-18 15:42:15 +09:00
Tadashi G. Takaoka
3268a44e1c am a5067333: Disable the header list of DebugSettingsActivity 
* commit 'a50673330e012f6cca02b83eca1c047b8da319e0':
  Disable the header list of DebugSettingsActivity
 2013-03-15 07:10:00 +00:00
Tadashi G. Takaoka
a50673330e Disable the header list of DebugSettingsActivity 
This change addresses the issue that the debug settings on 10-inch
tablet doesn't show up.

Change-Id: I60540cf21276869a3ca81b7b0154056ce7d93ff1
 2013-03-15 15:33:27 +09:00
Kurt Partridge
f33f1cab2f [FileEncap9] Extract ResearchLogDirectory class 
Previously used a monotonically increasing int.  Now uses uuid and nanoseconds.

squashed in:
    [FileEncap11] Read preference from ResearchSettings
    Change-Id: Ic779e0a69db6b16e92c6f4b63dbe7b7add566ab6

    [FileEncap12] Simplify directory cleanup invocation
    Change-Id: I688047409c0343d32b11447fb625dfb726c731ec

    [FileEncap14] Change log filename syntax
    Change-Id: I9243b20b2eb392f81ab8c5c3d19315211240e0bc

Change-Id: I5c9d70e0cb7b0965158e17dd71dfab796bd9a440
 2013-03-14 06:37:56 -07:00
Kurt Partridge
7faa2caa80 Merge "[Lazy4] Remove useless debug code" 2013-03-14 13:13:57 +00:00
Tadashi G. Takaoka
fb606c6277 am f0864b1d: Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 
* commit 'f0864b1d95411ce9886a5ade13f42cb17f578828':
  Clean up StaticInnerHandlerWrapper a bit
 2013-03-14 03:44:00 +00:00
Tadashi G. Takaoka
f0864b1d95 Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 2013-03-14 03:41:01 +00:00
Tadashi G. Takaoka
1ab33383f9 am 0d5f214a: Fix NPE found in monkey test 
* commit '0d5f214aa774ab0ab7c17521984caae11c9f4c2b':
  Fix NPE found in monkey test
 2013-03-14 03:39:38 +00:00
Tadashi G. Takaoka
41e60bf6dd Clean up StaticInnerHandlerWrapper a bit 
Change-Id: Ib07efe6da1eb2f0fd9ef68ca71502c98f7e19f4b
 2013-03-14 12:35:47 +09:00
Tadashi G. Takaoka
0d5f214aa7 Fix NPE found in monkey test 
Bug: 8383127
Change-Id: Ifd70acabe118b477f103937c7f1e99e38e210833
 2013-03-14 12:19:10 +09:00
Tadashi G. Takaoka
f5caf5be99 am 601a8582: Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 
* commit '601a8582d0f761a85b6eb16e7a6b78402f6f2599':
  Move checking non-persistent checkbox to onResume
 2013-03-14 02:33:28 +00:00
Satoshi Kataoka
0b2512017e am 0ab44b21: Merge "Make isInternal mutable" into jb-mr2-dev 
* commit '0ab44b21bd6ef5e9fde329b25dfd84f6ca5c0825':
  Make isInternal mutable
 2013-03-13 17:24:49 +00:00
Kurt Partridge
64b9596544 Merge "[Lazy2] Pass a runnable to abort" 2013-03-13 13:20:55 +00:00
Jean Chalard
8067b769f1 Merge "[DO NOT MERGE] Deactivate H/W keyboard handling" into jb-mr2-dev 2013-03-13 10:55:04 +00:00
Tadashi G. Takaoka
601a8582d0 Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 2013-03-13 07:52:35 +00:00
Satoshi Kataoka
0ab44b21bd Merge "Make isInternal mutable" into jb-mr2-dev 2013-03-13 07:41:11 +00:00
Satoshi Kataoka
756791e6bf Make isInternal mutable 
Change-Id: Ib81ceba801be0ac7ef65c4eadd1ec8599e80dacc
 2013-03-13 16:28:50 +09:00
Tadashi G. Takaoka
24cea7f1fb Move checking non-persistent checkbox to onResume 
Bug: 8336068
Change-Id: I07e67a6aee24a239a21e6fc69eb2ec741b9a5b2b
 2013-03-13 15:54:33 +09:00
Jean Chalard
13a82d9530 [Lazy2] Pass a runnable to abort 
Change-Id: I721afbf426099753aa876a55323eb806b08c24d6
 2013-03-12 18:56:57 -07:00
Kurt Partridge
5e75e15a95 Merge "[Lazy1] Switch to blocking log closures" 2013-03-13 00:18:02 +00:00
Jean Chalard
7423005b96 [Lazy1] Switch to blocking log closures 
Change-Id: I4daec20b7b47b0d71c5aab6e17cd660015e19e71
 2013-03-12 17:09:08 -07:00
Tadashi G. Takaoka
dbfd2825c8 am 2bbd3065: Language dependent single/doule quotation more keys 
* commit '2bbd3065d3bd9785ad1638c65f8c73f11bf21922':
  Language dependent single/doule quotation more keys
 2013-03-12 05:57:30 +00:00
Tadashi G. Takaoka
2bbd3065d3 Language dependent single/doule quotation more keys 
The natural way of marking quoted text vary from language to
language. This change introduces the following variations.

* LEFT and RIGHT quotations (English etc.)
* LOW-9 and LEFT quotations (German etc.)
* LOW-9 and RIGHT quotations (Dutch etc.)
* RIGHT and RIGHT quotations (Swedish etc.)
* LEFT ANGLE and RIGHT ANGLE quotations (French etc.)
* RIGHT ANGLE and LEFT ANGLE quotations

Bug: 8356419
Change-Id: I75726ab7ed783d02f189b46236c9d5079737bcff
 2013-03-12 14:43:34 +09:00
Jean Chalard
92eaa6fc7c [DO NOT MERGE] Deactivate H/W keyboard handling 
For MR2, LatinIME should not be handling hardware keyboard
events. The feature is still work in progress.

Change-Id: I56ff18bff84ba6b5a6bc3f8829b42eaf33b72554
 2013-03-12 14:22:06 +09:00
Jean Chalard
220b271dfa [Lazy4] Remove useless debug code 
This code is cluttering readability and getting in the way
of future updates.
Future updates will make it much easier to debug and to
test this code, so this needs to disappear.

Change-Id: I32e28ec608587b6b7c07250a2692b13e8fc98465
 2013-03-08 17:46:00 -08:00
Svetoslav Ganov
2d9b7f60dd am af37cbb4: Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev 
* commit 'af37cbb44ef40fcd15fa02456c9abda8021847ce':
  Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
 2013-03-08 19:24:25 +00:00
Svetoslav Ganov
af37cbb44e Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev 2013-03-08 19:20:00 +00:00
Tadashi G. Takaoka
60906d4d08 am 914d054e: Move logic of selecting key preview attribute to Key class 
* commit '914d054ea26d18a1ba6a60f8c5e749136477bbf2':
  Move logic of selecting key preview attribute to Key class
 2013-03-08 11:24:13 +00:00
Tadashi G. Takaoka
914d054ea2 Move logic of selecting key preview attribute to Key class 
This change also fixes the size of a key preview letter to follow a
keyLabelFlags specification.

Change-Id: Ie13790788a16c5a053c1a2cbcac3d38314b14b7f
 2013-03-08 19:44:22 +09:00
Kurt Partridge
bba39b9b67 [FileEncap8] Remove useless "success" variable 
Change-Id: Icf76bc0b795b6a9221d9a6d61c38df31af54ab7b
 2013-03-07 17:43:35 -08:00
Kurt Partridge
ee3261ff55 [FileEncap7] Extract uploadContents method 
Change-Id: I018b2726533042dbcb25713ea039aec41c148db2
 2013-03-07 17:43:28 -08:00
Kurt Partridge
4436446e9b [FileEncap6] Extract Uploader class 
Gerrit was stuck on original change I9ef4eb7450

Change-Id: I6d4ee686944074779aca5b09b018782c7033874d
 2013-03-07 16:19:44 -08:00
Alan Viverette
c2ee72a214 Announce keyboard mode changes as a WINDOW_STATE_CHANGED event. 
Bug: 8165295
Change-Id: Ie416f6cdb68377f3e06f30e9b6363c38ba2a602d
 2013-03-07 10:39:55 -08:00
Kurt Partridge
41c471d93d Merge "[FileEncap5] Move conditional logic to caller" 2013-03-06 20:59:04 +00:00
Kurt Partridge
1bc20700d5 Merge "[FileEncap4] Simplify logic" 2013-03-06 20:05:47 +00:00
Kurt Partridge
719bb3aa39 Merge "[FileEncap3] Extract isUploadingUnconditionally method" 2013-03-06 19:14:52 +00:00
Kurt Partridge
5e5b6b7870 Merge "[FileEncap2] Remove mCanUpload instance variable" 2013-03-06 18:39:07 +00:00
Kurt Partridge
b000e94eea Merge "[FileEncap1] Extract hasUploadingPermisssions method" 2013-03-06 18:02:26 +00:00
Kurt Partridge
9283644c41 [FileEncap5] Move conditional logic to caller 
Change-Id: I6599539059f86dc8902210d325439c08035b2e2a
 2013-03-06 07:19:41 -08:00
Kurt Partridge
88f466678c [FileEncap4] Simplify logic 
Change-Id: Ibb8660d12812b867856259d3e5c04a31e281027d
 2013-03-06 07:19:41 -08:00
Kurt Partridge
7f7850d23a [FileEncap3] Extract isUploadingUnconditionally method 
- remove isUploadingUnconditionally local variable

Change-Id: I69be8708c1f306568cbb9c5cbefc9e42a87df497
 2013-03-06 07:19:41 -08:00
Kurt Partridge
466e665b3c [FileEncap2] Remove mCanUpload instance variable 
Change-Id: I62a100c4d73bb64a14a7994f7dd9af7b6946d064
 2013-03-06 07:19:41 -08:00
Kurt Partridge
347b2ebebf [FileEncap1] Extract hasUploadingPermisssions method 
Change-Id: Ica1dabcf066cde6580035f12fa35a404cb32fb3f
 2013-03-06 07:19:41 -08:00
Kurt Partridge
68b3e4e7d3 Merge changes I2ded3d0a,I27ad9dfb 
* changes:
  Little cleanups
  Clean up initialization ordering
 2013-03-06 15:08:08 +00:00
Kurt Partridge
dc89d76f6b Merge "Make some methods visible for testing" 2013-03-06 03:43:55 +00:00
Kurt Partridge
25343124dd Make some methods visible for testing 
bug: 8302967

multi-project commit with Icf915abb57ef00840ee93b67a25db42ba51f1c38

Change-Id: I105bda5bdff871508140fb99487dddbf17992790
 2013-03-05 19:28:31 -08:00
Kurt Partridge
84bc16af3e Little cleanups 
Change-Id: I2ded3d0a29610941fac27c9b26168dd6c06ceccc
 2013-03-05 18:37:44 -08:00
Kurt Partridge
4eeb90cd72 Clean up initialization ordering 
This change is based on an earlier one that got stuck in Gerrit: Iab77504b

Change-Id: I27ad9dfb1bbb2300bd1e61d881a6ea0e116db066
 2013-03-05 18:37:00 -08:00
Kurt Partridge
60f51684f1 Merge "Clean up logic in onUserLoggingConsent" 2013-03-05 16:43:08 +00:00
Tadashi G. Takaoka
249c887008 am 84fa8043: Merge "Add show setup wizard icon preference settings" into jb-mr2-dev 
* commit '84fa8043e6bef47378b3fc32c277e33034d5c174':
  Add show setup wizard icon preference settings
 2013-03-05 06:30:33 +00:00
Tadashi G. Takaoka
2e1b55f796 Add show setup wizard icon preference settings 
Bug: 8239067
Change-Id: If6106a3632d3abad3e22ce29f1351525a5152ec7
 2013-03-05 14:56:41 +09:00
Kurt Partridge
157c00145b Clean up logic in onUserLoggingConsent 
- Make ResearchSetting for whether the user has seen the splash screen
- Inline #setLoggingAllowed, which is short and is now only called by
  onUserLoggingConsent

Change-Id: Icdf4592777b80643807b6ccf1d3896459c503e02
 2013-03-04 12:05:03 -08:00
Kurt Partridge
75e6fb68e9 Clean up PREF_USABILITY_STUDY_MODE 
- Refer to a common default value in DebugSettings
- Make PREF_USABILITY_STUDY_MODE independent of the ResearchLogger
- ResearchLogger uses its own preference through ResearchSettings

multi-project commit with Ie0df836c9d779eba484b522666ec357f4e234823

Change-Id: I88547a2f619db6e7364abbbec12f9f76855dd11a
 2013-03-04 12:05:03 -08:00
Kurt Partridge
788dc55662 Merge "Remove MainLogBuffer#setSuggest()" 2013-03-04 15:10:31 +00:00
Ken Wakasa
31a5386794 am a8d3d509: Small cleanup in CompatUtils 
* commit 'a8d3d50970cecf961940efc0e908fbb2f9b35472':
  Small cleanup in CompatUtils
 2013-03-04 03:56:05 +00:00
Ken Wakasa
a8d3d50970 Small cleanup in CompatUtils 
Change-Id: I9b4a8d7eae744ba6252a6475b75240248c70a3c0
 2013-03-02 17:18:18 +09:00
Kurt Partridge
a8e668c81e Merge "Move UUID preference reading to ResearchSettings.java" 2013-03-02 01:50:03 +00:00
Kurt Partridge
b094372bd6 Remove MainLogBuffer#setSuggest() 
multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624

Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
 2013-03-01 13:32:11 -08:00
Tadashi G. Takaoka
578e71e28b am 99b0dc6f: Merge "Add setup wizard launcher icon" into jb-mr2-dev 
* commit '99b0dc6f0d18f5fdd8634e8fa533bf1b3f81a538':
  Add setup wizard launcher icon
 2013-03-01 16:13:45 +00:00
Tadashi G. Takaoka
99b0dc6f0d Merge "Add setup wizard launcher icon" into jb-mr2-dev 2013-03-01 16:08:09 +00:00
Kurt Partridge
bc2588708a Merge "[TestPrep22] Make variable package-private for testing" 2013-03-01 14:48:43 +00:00
Tadashi G. Takaoka
1ffdaafd83 Add setup wizard launcher icon 
The setup wizard icon will be hidden if the Android Keyboard is in
system image.

Bug: 8239067
Change-Id: Ib0c0c9e3a0954512c3e03e42a661cdf86eff0dca
 2013-03-01 22:28:00 +09:00
Jean Chalard
31747ba787 am abaf5827: Separate suggestions from SuggestionView 
* commit 'abaf5827e7a7f5f6c5d8d98e03e6b9528b0c9351':
  Separate suggestions from SuggestionView
 2013-03-01 05:17:52 +00:00
Jean Chalard
abaf5827e7 Separate suggestions from SuggestionView 
This is a cleanup change, but it's also necessary for

Bug: 8152758
Change-Id: Id6ba06243f573fdb856f87d1df03277c9f2e5e71
 2013-02-28 21:03:18 -08:00
Kurt Partridge
00ed4704f9 Move UUID preference reading to ResearchSettings.java 
Change-Id: I8157249259cf8c3218c5c82a5729f4cbc1fb4eeb
 2013-02-28 19:54:21 -08:00
Kurt Partridge
9ba7ad8d4f Merge "[TestPrep20] Clean up import statement" 2013-03-01 01:32:35 +00:00
Tadashi G. Takaoka
040b442f3c am 18e21d58: Remove closing method from KeyboardView 
* commit '18e21d58f7c0b5c5c001835c093221c573a841c4':
  Remove closing method from KeyboardView
 2013-02-28 22:38:11 +00:00
Kurt Partridge
59912837b3 [TestPrep22] Make variable package-private for testing 
Change-Id: I902a6a40df1c672c611672f34d2f3237b0d1821b
 2013-02-28 06:45:35 -08:00
Kurt Partridge
5cd50faaca [TestPrep20] Clean up import statement 
Change-Id: Ifcfec09b669d8b2012b1c960bd4b1471c7946870
 2013-02-28 06:45:34 -08:00
Kurt Partridge
abaa88fd4e Merge "[TestPrep18] Make class public for testing" 2013-02-28 01:00:46 +00:00
Kurt Partridge
a04fbce412 Merge "[TestPrep17] Allow fake dictionary for testing" 2013-02-27 23:59:01 +00:00
Tadashi G. Takaoka
2ed1ec411d am 016046eb: Keep Keyboard object while closing KeyboardView 
* commit '016046eb4e3ea28745b9a29c41c126801f177f58':
  Keep Keyboard object while closing KeyboardView
 2013-02-27 23:22:32 +00:00
Tadashi G. Takaoka
18e21d58f7 Remove closing method from KeyboardView 
This is a follow up of Ie00ba827. After the change, the
KeyboardView.closing() method does nothing important.

Change-Id: I9659ea56ce82a95f8798a4136bf93f164b67fae7
 2013-02-27 17:35:20 +09:00
Tadashi G. Takaoka
016046eb4e Keep Keyboard object while closing KeyboardView 
Bug: 8217626
Change-Id: Ie00ba827bc391aa152427965c57488b66308a75c
 2013-02-27 17:30:16 +09:00
Kurt Partridge
424a976e58 Merge "Ensure Preference listener is unregistered" 2013-02-27 03:49:40 +00:00
Kurt Partridge
96d019f183 [TestPrep18] Make class public for testing 
Change-Id: I4b457f44dd6a5a595c61a62061ea02c251fa9ab1
 2013-02-26 19:22:56 -08:00
Kurt Partridge
5ee261a990 [TestPrep17] Allow fake dictionary for testing 
Currently ResearchLog requires a full dictionary to perform privacy-related checks.
This makes testing difficult.  This change allows a fake dictionary to be used instead.

Change-Id: Ifca5bd8647475a6b84e4324117e0faa0a35479ee
 2013-02-26 19:22:55 -08:00
Kurt Partridge
7e2c1e69bf Ensure Preference listener is unregistered 
Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
 2013-02-26 18:40:34 -08:00
Kurt Partridge
64c34122f2 Merge "[TestPrep11] Only use mHasWrittenData to control JsonWriter#endArray() call" 2013-02-27 00:41:12 +00:00
Kurt Partridge
62abc40d7d Merge "[TestPrep10] Add some comments" 2013-02-26 23:09:48 +00:00
Kurt Partridge
f170f145af [TestPrep11] Only use mHasWrittenData to control JsonWriter#endArray() call 
Change-Id: If2107e38575b009a4c372194ecd827e27bdbb2b4
 2013-02-26 15:02:52 -08:00
Kurt Partridge
a5e564bea0 [TestPrep10] Add some comments 
Change-Id: Ia8e0bd72b0dc09bfc256ec5d1996637554376b5f
 2013-02-26 15:02:52 -08:00
Tadashi G. Takaoka
183fe80031 Small cleanup of RunInLocale 
Change-Id: Ib588e67da2c88345fc4eb51587b07ebfa434e0bb
 2013-02-26 19:11:49 +09:00
Jean Chalard
0f3c05cd6b Merge "Send the dictionaries descriptions to the dict pack" 2013-02-23 10:18:03 +00:00
Jean Chalard
c6799ffeab Send the dictionaries descriptions to the dict pack 
Bug: 8255795
Change-Id: I12a5922f50c2d2e3aa639457abcc1483e6a48721
 2013-02-23 01:46:39 -08:00
Jean Chalard
76ead0ead0 Fix a possible crash 
If the dictionary ID, as indicated in the metadata, is
less than three chars long, it crashes LatinIME.
Of course we don't have such dictionary IDs in the current
metadata, but it's still better to be able to handle
the case gracefully ^^;

Change-Id: I60cdf6f8ecce9f4d44b42ddd5d157aebff9a4163
 2013-02-23 01:41:44 -08:00
Jean Chalard
aefaec3c5f Remove a cluttering log 
Bug: 8175067
Change-Id: I9a104a32ba2b3b52a5dfa250f8c642abd6169cc0
 2013-02-23 00:48:10 -08:00
Jean Chalard
8b4023c4d6 Merge "Tiny cleanup" 2013-02-23 08:07:27 +00:00
Jean Chalard
2521edec09 Fix a bug with the passed dictionary id 
We used to make the dictionary that we passed to the
dictionary pack as an initial value based on the locale.
This is wrong - it should be read from the dictionary.
This change fixes that.

Bug: 7005813
Change-Id: Ib08ed31dd9c216f6f7b9c6c3174ca514bf96e06f
 2013-02-22 20:49:48 -08:00
Jean Chalard
da0d771fe9 Tiny cleanup 
Change-Id: I5d7150a4abb3a498e790f41af569093217cb8b43
 2013-02-22 19:42:45 -08:00
Jean Chalard
8f794c72db Merge "Fix how the Enter action is decided" 2013-02-23 00:13:27 +00:00
Jean Chalard
4e4f88127b Fix how the Enter action is decided 
This unifies the software and hardware keyboard code
under a single decision process that works.

Bug: 8129303
Bug: 8152758
Change-Id: I7574c563d5f957d57bfe62fe5e3eec59a519d335
 2013-02-22 16:01:37 -08:00
Kurt Partridge
744b363ae8 [TestPrep8] Narrow try/catch scope 
Change-Id: If15f250feb81c2ad55ce1bc7dc3dafa57de87aef
 2013-02-21 17:01:08 -08:00
Kurt Partridge
78c1ad32e6 [TestPrep7] Encapsulate JsonWriter creation 
Change-Id: I4e97fa28dd0bb1101edc0db03f024432fee6f6fe
 2013-02-21 17:01:08 -08:00
Kurt Partridge
07050549b1 Merge "[TestPrep5] Parameterize MainLogBuffer" 2013-02-21 23:52:05 +00:00
Kurt Partridge
bf0d6af3d3 Merge "[TestPrep4] Add some finals" 2013-02-21 22:13:05 +00:00
Kurt Partridge
7c996475d8 Merge "[TestPrep3] Add helper method to retrive dictionary" 2013-02-21 21:18:32 +00:00
Kurt Partridge
c8a1ec6e41 Merge "[TestPrep2] Rename a method" 2013-02-21 15:57:34 +00:00
Kurt Partridge
4e5a4ddbd0 Merge "[TestPrep1] Move MotionEvent.Action strings to LoggingUtils" 2013-02-21 14:54:46 +00:00
Tadashi G. Takaoka
07296cf7ff Merge "Use WordComposer.addKeyInfo for testing" 2013-02-21 06:20:01 +00:00
Kurt Partridge
ab0bda1499 [TestPrep5] Parameterize MainLogBuffer 
Change-Id: I6d84f490922cd1f40e44ca4f95c9d950fba38290
 2013-02-20 19:37:12 -08:00
Kurt Partridge
22acdb540c [TestPrep4] Add some finals 
Change-Id: Ib437a6ad7fd6a897e2bbc65afe881ae8a3b1cbb0
 2013-02-20 19:37:12 -08:00
Kurt Partridge
19e05359e6 [TestPrep3] Add helper method to retrive dictionary 
Change-Id: Id6e03c6f8a3e96979d589f0605ac056fcad7e1ff
 2013-02-20 19:36:56 -08:00
Kurt Partridge
b6d05aeb7c [TestPrep2] Rename a method 
Change-Id: Id9a72045afa3558b20b9d63c8720fb7443d34fd9
 2013-02-20 17:13:00 -08:00
Kurt Partridge
8d429bf1a8 [TestPrep1] Move MotionEvent.Action strings to LoggingUtils 
Change-Id: I7b9ed800552f2fd546ed21e9dc06ea1ff5798337
 2013-02-20 17:12:56 -08:00
Tadashi G. Takaoka
46878544ec Add preliminary setup wizard 
Bug: 8159728
Change-Id: I30d9cd637fb1d2e64588550e0aa4387bc1f7e6e5
 2013-02-21 09:54:02 +09:00
Tadashi G. Takaoka
5701a6647f Use WordComposer.addKeyInfo for testing 
Change-Id: I500654e7a26717aa5547942357e56060afb72969
 2013-02-20 17:09:25 +09:00
Jean Chalard
d4cbc4fd07 Implement getting data files with protocol v2 
This also does it for deleting them
Bug: 8167342
Bug: 6789534
Change-Id: I1823f98508881f109a667146d3608003f87aa4cb
 2013-02-15 11:09:16 -08:00
Jean Chalard
4beaab2a88 Merge "Determine the protocol version of the dictionary pack" 2013-02-14 20:22:09 +00:00
Tadashi G. Takaoka
cb0beaf3f1 Add placeholder of keyboard setup wizard 
Bug: 8159728
Change-Id: I5552e9d0ffa8f94d183e76378d55bba6f718adfe
 2013-02-14 18:00:11 +09:00
Jean Chalard
b1f27a2e26 Determine the protocol version of the dictionary pack 
...for query.

Bug: 8167342
Change-Id: Ieb8e5b31c4b62bf507593c4631e31799aad5f267
 2013-02-13 20:45:36 -08:00
Kurt Partridge
de3e5fbf9d Merge "Cleanup in preparation for tests" 2013-02-13 23:34:07 +00:00
Kurt Partridge
531dd150eb Cleanup in preparation for tests 
multi-project commit with I1212da392ecda0ad78962da68941870b5a651eee

Change-Id: Ie74af59d4e45bf954723fee9dcf350a36468c381
 2013-02-12 20:48:44 -08:00
Jean Chalard
a9df972780 Clean up dictionary pack presence test. 
This method is much cleaner and much more readable.

Change-Id: I8055c169ef7c4453ab45c463704bd56a6080da4f
 2013-02-12 17:59:36 -08:00
Kurt Partridge
04de6802cc Merge "Add batchMode field to PickSuggestionManually" 2013-02-12 16:54:35 +00:00
Tadashi G. Takaoka
fdb1ca560e Merge "Separate caps mode related utils to CapsModeUtils" 2013-02-12 09:26:16 +00:00
Tadashi G. Takaoka
ce6bcdd1a5 Separate caps mode related utils to CapsModeUtils 
Change-Id: I32700c434b296bb3fd39e040c2dda1fe90667daf
 2013-02-12 18:15:42 +09:00
Tadashi G. Takaoka
2c2942dd4b Merge "Move parseCsvString to StringUtils" 2013-02-12 07:57:24 +00:00
Tadashi G. Takaoka
b3fd701181 Move parseCsvString to StringUtils 
Change-Id: I602f33991ca57b6057ec2defe01573552b322857
 2013-02-12 16:18:19 +09:00
Jean Chalard
e26f0d4320 Merge "Cleanups" 2013-02-12 06:49:41 +00:00
Tadashi G. Takaoka
4cbe84ad08 Merge "Fix RTL language key code mapping" 2013-02-12 06:43:40 +00:00
Tadashi G. Takaoka
9a2039d94e Fix RTL language key code mapping 
Bug: 8168899
Bug: 8169343
Change-Id: I23120704e97d89d5ddec2b2bdff2a98a6daac4d5
 2013-02-12 14:51:54 +09:00
Jean Chalard
1c5b2a41ec Cleanups 
Follow-up to Idc6f419a

Change-Id: I4aae8f4e19f27a0a309879dc19af6e40906d58c5
 2013-02-11 21:14:56 -08:00
Jean Chalard
8018051022 Some cleanups 
Improve a slew of logging statements, and put commands that we don't
expect to need protecting against exceptions out of a try {} block.

This is a followup to Id3dc510a

Change-Id: Idc6f419ac095b5b0f2d6862d58926ef888cb34e6
 2013-02-11 19:47:15 -08:00
Jean Chalard
82441e60e2 Remove unnecessary whitespace 
This is a cleanup followup to Id3dc510a

Change-Id: Ie64395eb4b6218fd8c73cacddeed2fba1df65d26
 2013-02-11 13:31:47 -08:00
Jean Chalard
b2eac474ff Don't try to issue delete() commands on missing provider 
Bug: 8173622
Change-Id: Id3dc510ae3535169b5290e87075cb2f433a1f603
 2013-02-11 12:38:24 -08:00
Kurt Partridge
2cabb7aed0 Close file properly 
Change-Id: Ied55b6a6f1e64bbca558316d8d3d207d7655cf91
 2013-02-08 11:43:51 -08:00
Kurt Partridge
c52569ffcb Add batchMode field to PickSuggestionManually 
Change-Id: Iaaffc71378154240538bf90f0b85c3f17f3f78b3
 2013-02-08 11:39:04 -08:00
Jean Chalard
3623ad238c [B14] Implement sending the dictionary list. 
Bug: 7005813
Change-Id: Ic3ef69510d2b385d0d403191b2f701b6527d0166
 2013-02-06 19:19:30 -08:00
Jean Chalard
6ecb4c4dcc [B11] Implement reset and passing of the URL to the dict pack 
Bug: 7601410
Bug: 7595195
Change-Id: I78cf04dce7c1e64de6725d32317de288a83bd39d
 2013-02-06 15:21:33 -08:00
Jean Chalard
afe889a83d Merge "[B9] Pass the client id parameter for dict info requests" 2013-02-06 04:38:44 +00:00
Kurt Partridge
b02a19c49d Refactor LogStatement publishing method 
The method in LogUnit for publishing a LogStatement to a JsonWriter doesn't
depend on anything in the LogUnit.

multi-project commit with Id1d6ff4851148bba0e6b5a1ec6eec2b842d9c707

Change-Id: I323cec239d6ea1cee602c2ecf9b13713791e9283
 2013-02-05 15:18:20 -08:00
Tadashi G. Takaoka
298b4240f8 Separate IntentUtils from CompatUtils 
Change-Id: I373ae7ad26eee44cc8e9720314f6a53b811d0021
 2013-02-04 16:06:38 -08:00
Kurt Partridge
445d8e8bf6 Merge "[Rlog79b] Save channel name during internal use" 2013-02-04 19:16:33 +00:00
Kurt Partridge
5ca4afa543 Merge "[Rlog48c] Replay historical motion data" 2013-02-04 18:36:57 +00:00
Kurt Partridge
82b4374c75 Merge "[Rlog48b] Better visual indicator for logging state" 2013-02-04 18:06:41 +00:00
Kurt Partridge
7708bcf6fb [Rlog48c] Replay historical motion data 
Change-Id: Ib398ea61ff048b1a4ac3b7f7b4a772e173a7b294
 2013-02-04 06:13:51 -08:00
Kurt Partridge
d34347bd4b [Rlog79b] Save channel name during internal use 
The feedback string is used as a channel name in internal builds.  Add a flag
that lets it be saved between calls to make it easier to generate test data.

Change-Id: I5c6149b1e68239cd968b6852d03cc240ddde99ca
 2013-02-04 06:09:45 -08:00
Jean Chalard
8192b4a6ef [B9] Pass the client id parameter for dict info requests 
Bug: 6789534
Change-Id: Ie3ea75b19ae4da2dea531e0077c58742a9502bc6
 2013-02-02 18:23:40 +09:00
Jean Chalard
f1acb0e52d Make some strings private 
Change-Id: I0ffdbcf6bede86a3cdcb3a0e4ec263398502617c
 2013-02-02 15:00:09 +09:00
Kurt Partridge
ce9e7f667d [Rlog48b] Better visual indicator for logging state 
Now applies yellow bars if recording, green bars if replaying.

Change-Id: I39d39de6254fd57107ea5355c43b154244520985
 2013-02-01 17:10:56 -08:00
Kurt Partridge
ceffa0bec9 Merge "[Rlog79a] Disallow empty feedback messages" 2013-02-01 17:15:07 +00:00
Kurt Partridge
0cafd6580c Merge "[Rlog48a] Update and make logging strings consistent" 2013-02-01 16:33:42 +00:00
Kurt Partridge
d3f718fccd [Rlog79a] Disallow empty feedback messages 
Change-Id: I30f7c07606e466c3c9538adad94024d00f0901de
 2013-02-01 07:08:32 -08:00
Kurt Partridge
5bdd7bab11 Merge "[Rlog47] Replayer service, inspect-researchLog.py" 2013-02-01 15:05:58 +00:00
Tadashi G. Takaoka
5c58133c80 Clean up GestureFloatingPreviewText 
Change-Id: Ie64dd06a99e54b2f432725f69dc4f38c81359ce6
 2013-02-01 15:23:21 +09:00
Kurt Partridge
c20a415e15 [Rlog48a] Update and make logging strings consistent 
Change-Id: Iae04115921aaf6bbc3c6ad6e7d2d0e7401af41f8
 2013-01-31 19:08:54 -08:00
Kurt Partridge
40be4c3bdb ResearchLogger invocation tests 
- Start with just a smoke test.
- Sets up a private SharedPreferences

multi-project commit with I81cceba23692d64c2ea58a46351fc36d118ff825

Change-Id: I96e02d9a8de70cb5c03fd7411b886903e7a83673
 2013-01-31 14:54:14 -08:00
Kurt Partridge
588d9b5c8d [Rlog47] Replayer service, inspect-researchLog.py 
multi-project commit with Ia2dd81afb4ea124094a20a39e31ffd193edff3d2

Change-Id: I80fe8f2ce137fedf48038955d5f3d9deed04f763
 2013-01-31 12:13:08 -08:00
Kurt Partridge
6b574f8056 Merge "[Rlog39] Remove unnecessary commitCurrentLogUnit() call" 2013-01-31 18:52:31 +00:00
Jean Chalard
5ea4365f07 Merge "Create methods in LatinIME to make the current dict lists" 2013-01-31 16:59:11 +00:00
Kurt Partridge
e8a0bfb315 [Rlog39] Remove unnecessary commitCurrentLogUnit() call 
Change-Id: I1983095058d004476065328ad34bb9e325af7062
 2013-01-30 17:39:42 -08:00
Jean Chalard
af4a7e8c4b Create methods in LatinIME to make the current dict lists 
Bug: 7005813
Change-Id: I82232af8e3071333b6fd01e4453b6b3c0a3ddb1f
 2013-01-31 09:26:52 +09:00
Jean Chalard
3c67f6a2d0 Merge "Add a way to know externally if we're installing a new dict" 2013-01-31 00:19:23 +00:00
Jean Chalard
01a4ebcd88 Add a way to know externally if we're installing a new dict 
That helps tests know when to wait and when to declare the
dictionary actually not usable.

Bug: 7925814
Change-Id: Ic963c1206c43e3cde39ac4214a0d601f4fc6c03b
 2013-01-31 09:04:55 +09:00
Kurt Partridge
9c18a47162 Merge "[Rlog29] User interface for recording" 2013-01-30 16:40:03 +00:00
Kurt Partridge
4e049897ef Merge "[Rlog27] Add replay capability" 2013-01-30 14:38:16 +00:00
Tadashi G. Takaoka
e1f091c5d4 Add keyboardLetfPadding and keyboardRightPadding attributes 
This change splits keyboardHorizontalEdgesPadding attributes of
Keyboard into two attributes.

Change-Id: Iefdb358783b81af4027e8d9e991db36a6c429cf1
 2013-01-30 15:01:33 +09:00
Tadashi G. Takaoka
48409b9ac6 Merge "Remove "dimension|fraction" format from Key and Keyboard attributes" 2013-01-30 04:08:16 +00:00
Tadashi G. Takaoka
5ee2d79e41 Remove "dimension|fraction" format from Key and Keyboard attributes 
Change-Id: Ieec8b7f5ccdf2a57bcc539dcb5313b6353f926d7
 2013-01-30 13:01:14 +09:00
Kurt Partridge
faf35c323b [Rlog29] User interface for recording 
- Also, internal flag for automatically replaying after a recording is made (off by default)
- RLog key to "Bug?"

multi-project commit with I0c2fababd73eed5a341af487bca04ddd650d4cc2

Change-Id: I162c96a715de7180f276e08b4686a20f29dabafb
 2013-01-29 15:46:16 -08:00
Kurt Partridge
f3731188e5 [Rlog27] Add replay capability 
- Add support for replaying log files to the ResearchLogger.  This will let
  users preview data that they choose to upload.
- When the user explicitly requests that the system record their action, it
  will record everything up to, and including, the motion involved in shutting
  off the recording.  This change also removes the stop-recording motion
  commands.

Change-Id: Ib1df383bbf1881512cb111fab9f6749c25e436ba
 2013-01-29 09:33:25 -08:00
Tadashi G. Takaoka
3079b71964 Fix off-device regression test build 
Bug: 8093623
Change-Id: I775a8691bbedf58caef07d0b4af59c7444dd81be
 2013-01-29 23:02:08 +09:00
Jean Chalard
3d0477fbd2 Merge "Refactoring" 2013-01-29 10:29:25 +00:00
Jean Chalard
d515f134f7 Refactoring 
This creates a new DictionaryInfoUtils class and moves a bunch
of static methods there for later usage.

Change-Id: Iecb0643e6029a7be36bd6cb36aa918c40e6d8c6a
 2013-01-29 19:16:21 +09:00
Tadashi G. Takaoka
17dae3057c Remove {max,min}keyboardHeight attribute from Keyboard 
This change removes a DisplayMetrics reference from KeyboardBuilder.

Change-Id: I512694274e69e5281d5be47c3f938bcfd6571152
 2013-01-29 18:32:04 +09:00
Tadashi G. Takaoka
8630cd9d17 Remove keyboard layout description on the spacebar 
Bug: 8056376
Change-Id: I33f07e7a044c2b5fc20de40c7a9777dab493e41c
 2013-01-28 11:49:44 +09:00
Kurt Partridge
f77e9d7e3a Merge "Initialize ResearchLogger later to avoid NPE" 2013-01-25 17:17:34 +00:00
Jean Chalard
5228745ae0 Merge "Remove pending update messages upon starting a gesture" 2013-01-25 12:34:46 +00:00
Jean Chalard
a280e56014 Remove pending update messages upon starting a gesture 
Bug: 8064307
Change-Id: Ia623ab81b6d12eedc6b20bc4c1ce34ce72d5832f
 2013-01-25 17:00:41 +09:00
Tadashi G. Takaoka
ce875664e0 Clean up Settings and SettingsFragment a bit 
Change-Id: I93bf3cb1ea7e8fc09f4ad34b0bdd74f5f5ff1a68
 2013-01-25 16:23:29 +09:00
Kurt Partridge
63bc279596 Initialize ResearchLogger later to avoid NPE 
Change-Id: I1b817dfbdc319ac9bbf2f08e094a007849ce767f
 2013-01-24 11:13:20 -08:00
Tadashi G. Takaoka
52a0d491b4 Merge "Add preliminary graphics of sliding key input preview" 2013-01-24 09:23:28 +00:00
Tadashi G. Takaoka
ff961ddf8c Add preliminary graphics of sliding key input preview 
Bug: 7548583
Change-Id: Idde6a62f9e64458055c99c893b71c02d1adc7b04
 2013-01-24 18:14:20 +09:00
Tadashi G. Takaoka
12f2fc71f7 Merge "Display custom input style name in system locale" 2013-01-24 08:53:46 +00:00
Tadashi G. Takaoka
8203f7afe7 Display custom input style name in system locale 
Bug: 8032166
Change-Id: Ib9a6b63c4d540ce377892fb865e53abdd8adec16
 2013-01-24 17:44:49 +09:00
Tadashi G. Takaoka
f0b5fddcb8 Clean up SettingsFragment a bit 
Change-Id: Ic0727003f2645f0c38200b67bb2f4046249c6273
 2013-01-24 16:16:53 +09:00
Tadashi G. Takaoka
ef43cc9d1c Fix dismissing gesture floating preview 
Bug: 8063926
Change-Id: I3b5b29ea0d5e4833e10e830dbdb086c868cd4884
 2013-01-24 12:07:01 +09:00
Kurt Partridge
2baa4b0701 [Rlog83] Fix missing uses of hasWord() abstraction 
Change-Id: I78e286723b1b8c8bcc7aea0cc81ef2ee66a193ac
 2013-01-23 09:21:56 -08:00
Kurt Partridge
edb5c4638b Merge "[Rlog81a] Determine correction type of words" 2013-01-23 17:12:02 +00:00
Tadashi G. Takaoka
9d514af466 Merge "Refactor SubtypeLocale to hold Resources" 2013-01-23 08:37:57 +00:00
Tadashi G. Takaoka
9dc85a673e Merge "Configurable key long press timeout" 2013-01-23 08:37:36 +00:00
Tadashi G. Takaoka
cc5e4a4445 Configurable key long press timeout 
The default long presss timeout is 300msec (previous timeout was
400ms).

Bug: 7600340
Change-Id: Ia8b64784ac03588631cfcbad30e021d74f3fd0d8
 2013-01-23 17:12:28 +09:00
Satoshi Kataoka
f1074c508e Throw exception when invalid time stamps are detected in debug mode 
Change-Id: I360b5bd09869bc85ab3bccb8a43a20fed0035d9b
 2013-01-23 16:29:19 +09:00
Tadashi G. Takaoka
4b3cae9b0c Refactor SubtypeLocale to hold Resources 
Change-Id: Ia667bc2d406d66c87215dd3b9569f36f4642cfe0
 2013-01-23 16:23:11 +09:00
Tadashi G. Takaoka
40651c8cf7 Fix activity flags to launch settings activity 
This change adds the following flags to the intent to lauch settings activity.
 - Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED
 - Intent.FLAG_ACTIVITY_CLEAR_TOP

Bug: 8055342
Change-Id: I85284409bbba3fd284442e5ac4c7a55e58ad15ec
 2013-01-23 15:08:35 +09:00
Kurt Partridge
0c16a5c6ee [Rlog81a] Determine correction type of words 
Heuristic to determine whether a word was a typo correction or a complete
replacement by examining a correction to see if it falls within the list of
suggested words of the original.

Change-Id: Ieec4861a811e96aef0d14622e662b589ef8b4772
 2013-01-22 11:41:52 -08:00
Tadashi G. Takaoka
f008a11cce Merge "Cache MoreKeysKeyboard instead of container view of it" 2013-01-22 08:45:52 +00:00
Tadashi G. Takaoka
a729377395 Cache MoreKeysKeyboard instead of container view of it 
This change also cleans up MoreKeysPanel related stuff.

Bug: 8047165
Change-Id: I4f2211e00c7d08469a7413568db039c1c597fb3c
 2013-01-22 17:34:36 +09:00
Tadashi G. Takaoka
8028c1c523 Merge "SeekBarDialogPreference supports minValue and stepValue" 2013-01-22 07:40:48 +00:00
Tadashi G. Takaoka
c053293484 SeekBarDialogPreference supports minValue and stepValue 
Change-Id: I7aaeeb2db85103708747ae318610bd4896ef96fd
 2013-01-22 16:35:59 +09:00
Ken Wakasa
6c22439bf8 Remove MAX_PROXIMITY_CHARS_SIZE_INTERNAL 
Change-Id: I18a997503de4033b5341b564145bca862a872098
 2013-01-22 13:18:49 +09:00
Kurt Partridge
4cb853191c [Rlog15] ResearchLogger option to include account name in feedback 
multi-project commit with I0a293f392bd605c8203dc9a62993345ad58dcfbe

Change-Id: Ief5b940a62dbaeaecdf1c55f2ffdd1e0fdaea2b9
 2013-01-21 12:18:43 -08:00
Kurt Partridge
8b788374de Merge "[Rlog78b] Make log privacy filtering decisions on n-grams" 2013-01-21 19:39:38 +00:00
Kurt Partridge
80685aa4b9 [Rlog78b] Make log privacy filtering decisions on n-grams 
Previously, words were pushed out of a LogBuffer one at a time.  The receiving code had to keep
state to know whether a n-gram was safe to log.  This patch looks at the entire n-gram and makes a
single decision based on it alone.

mult-project commit with I3c40d7e02c77943d2668094ddb1d03efb942c74f

Change-Id: Id7d90bbd551b1a2f4e0e35f38852652f68f273f8
 2013-01-21 10:50:32 -08:00
Kurt Partridge
08d9c996dc Merge "[Rlog81b] Log more data with handleSeparator" 2013-01-21 18:48:16 +00:00
Tadashi G. Takaoka
fb523d7f5d Move AbstractDrawingPreview objects to MainKeyboardView 
Change-Id: I0be72fba9a66f7c326028ec8e4670ca74a46053f
 2013-01-21 23:25:18 +09:00
Tadashi G. Takaoka
2277733048 Merge "Add GestureTrailsPreview class" 2013-01-21 13:44:13 +00:00
Tadashi G. Takaoka
8673594830 Merge "Add SlidingKeyInputPreview class" 2013-01-21 13:43:41 +00:00
Tadashi G. Takaoka
470a5805e1 Add GestureTrailsPreview class 
Change-Id: Ibf9dff6d834d34b4134dbe38a609fd983731eedc
 2013-01-21 22:31:54 +09:00
Tadashi G. Takaoka
a237cd4a02 Add SlidingKeyInputPreview class 
Change-Id: Ided47b3420b0b1e34063f30d5142a1858af2718e
 2013-01-21 22:30:14 +09:00
Tadashi G. Takaoka
8aa9963a89 Fix Apache license comment 
Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
 2013-01-21 22:23:37 +09:00
Tadashi G. Takaoka
78292e45cb Fix missing super call in PreviewPlacerView.onDetachedFromWindow 
Change-Id: Iea79c0081cb66f54f161c0cf02cb365fcf88a07c
 2013-01-21 19:31:05 +09:00
Tadashi G. Takaoka
4987108f34 Add surrounding drawing view to AbstractDrawingPreview constructor 
Change-Id: If57e59f25fc3e29c0e7f46e8218d04fb233c27c6
 2013-01-21 18:48:06 +09:00
Tadashi G. Takaoka
820b5e079c Merge "Add PointerTracker.isOldestPointerInQueue" 2013-01-21 09:37:59 +00:00
Tadashi G. Takaoka
ab334eb646 Add PointerTracker.isOldestPointerInQueue 
Change-Id: Ic6f38253c94067ec7aa7b5add4452fa144fd9352
 2013-01-21 18:26:46 +09:00
Jean Chalard
b56260b891 [AD4] Actually copy the file in place. 
This finally makes it work.

Bug: 7702011

Change-Id: I3508c88567f79598e4d1dff561b6ba7dc5c3808f
 2013-01-21 17:58:38 +09:00
Tadashi G. Takaoka
db906a7c9a Merge "Rename AbstractDrawingPreview.onDraw to drawPreview" 2013-01-21 08:34:25 +00:00
Tadashi G. Takaoka
2ecbfe8e93 Rename AbstractDrawingPreview.onDraw to drawPreview 
This is because the android lint warns calling a method onDraw(Canvas)
from View.onDraw(Canvas).

Change-Id: I4f54996da5454d9a8c4ef43fbbcaec37724fb20e
 2013-01-21 17:00:47 +09:00
Tadashi G. Takaoka
f3c4cd45a5 Move dimming keyboard to MainKeyboardView 
Change-Id: Id44d4b758c8b92d1120d3a8b06812dc1fc26390c
 2013-01-21 16:54:08 +09:00
Jean Chalard
bde94dd96f Merge "[AD3] Implement the interface to choose a local dictionary" 2013-01-21 07:41:48 +00:00
Tadashi G. Takaoka
9c968b62d1 Move gesture related XML attribute to MainKeyboardView 
Change-Id: Ia12f73a3d7d26596ee14a0aff23244ef72753d68
 2013-01-21 16:16:48 +09:00
Tadashi G. Takaoka
375982106b Move PointerTracker.DrawingProxy to MainKeyboardView (step 2) 
Change-Id: If15d5ee683b8026d1871a3fe438dba498944faa7
 2013-01-21 16:09:25 +09:00
Tadashi G. Takaoka
0e4f0da449 Move PointerTracker.DrawingProxy to MainKeyboardView (step 1) 
Change-Id: I86014de147416453503b6412eb862a2d172426aa
 2013-01-21 16:06:50 +09:00
Jean Chalard
fbc5e9b334 [AD3] Implement the interface to choose a local dictionary 
Bug: 7702011
Change-Id: Id3b9c58dbbf5097e4d6ce986d20924eae19f9690
 2013-01-21 15:40:46 +09:00
Tadashi G. Takaoka
d9449ccf3c Move MoreKeysPanel.Controller implementation to MainKeyboardView 
Change-Id: Iffa298d51ca21a7dcd1e77c633217532d96d2cf5
 2013-01-21 15:28:17 +09:00
Tadashi G. Takaoka
b9f219c935 Remove unused Keyboard.purgeKeyboardAndClosing method 
Change-Id: Ia09ac04b0edca2a22d64ba83e054b115fe8851a6
 2013-01-21 14:26:33 +09:00
Kurt Partridge
80375649d3 [Rlog81b] Log more data with handleSeparator 
Change-Id: I4b2ebaa2398ac2f669e1e009e00842e55979e866
 2013-01-18 11:51:26 -08:00
Jean Chalard
1d15fe7e51 [AD2] Add a helper method to read an arbitrary dict header 
Bug: 7702011
Change-Id: Ib88f6dc222892831ae6932635b65fd2595b16b43
 2013-01-18 20:34:28 +09:00
Jean Chalard
babc71ee30 Merge "[AD1] Add an option to read an arbitrary dictionary." 2013-01-18 11:30:28 +00:00
Jean Chalard
fd80d1ad48 Merge "Deactivate h/w keyboard when not an internal build." 2013-01-18 11:28:24 +00:00
Jean Chalard
2e680c890d Merge "Trigger the set action when pressing hardware enter (C2)" 2013-01-18 11:18:32 +00:00
Jean Chalard
9058bc0df4 [AD1] Add an option to read an arbitrary dictionary. 
Bug: 7702011
Change-Id: I76f52dd3fdb22824fc243ab3845ceec610469c81
 2013-01-18 20:18:06 +09:00
Jean Chalard
2fc4d422e7 Deactivate h/w keyboard when not an internal build. 
The implementation is not really ready yet, so we want to
disable it for normal builds for now.
This goes together with Ic1edc6ed

Bug: 7987492
Change-Id: Id81f417e200c118f24424943823665f0b8bd6849
 2013-01-18 20:15:18 +09:00
Jean Chalard
b4ac04ae48 Trigger the set action when pressing hardware enter (C2) 
Bug: 7969231
Change-Id: I581212093df6f16fa9304e0b3e5b46714a7acdb3
 2013-01-18 20:03:38 +09:00
Jean Chalard
d5e869ced8 Merge "Track handled events to consistently return handled status (C1)" 2013-01-18 10:49:54 +00:00
Jean Chalard
976a42b873 Track handled events to consistently return handled status (C1) 
Bug: 5037589
Change-Id: I92d5be669420f0b2fdeb8fcf85aefd3961bf84b4
 2013-01-18 19:32:22 +09:00
Tadashi G. Takaoka
5d894dcfaa Merge "Correct GesturePreviewTrail.getWidth() implementation" 2013-01-18 10:26:05 +00:00
Tadashi G. Takaoka
f420e506a0 Merge "Add SeekBarDialogPreference" 2013-01-18 10:25:13 +00:00
Tadashi G. Takaoka
2df0cf2c5a Add SeekBarDialogPreference 
This change removes SeekBarDialog class.

Change-Id: I437b1e554a5af264b8031ebe05b8250a831c8d3b
 2013-01-18 19:10:55 +09:00
Tadashi G. Takaoka
41afa87a72 Merge "Remove automatic switch back to alphabet feature" 2013-01-18 10:03:02 +00:00
Tadashi G. Takaoka
cc2636b4e1 Remove automatic switch back to alphabet feature 
Change-Id: I4600c808f2ec31c18d3698a43afa7f4be9407e3e
 2013-01-18 18:44:27 +09:00
Tadashi G. Takaoka
9e63ef89e3 Correct GesturePreviewTrail.getWidth() implementation 
Bug: 7981153
Change-Id: I20785b7f82329ce6f19c883e77a9716772cda290
 2013-01-18 17:55:24 +09:00
Jean Chalard
81a4b7f48e Merge "Fix a bug in gesture after a dash or apostrophe" 2013-01-18 08:39:58 +00:00
Jean Chalard
889a5e1430 Merge "Reset forgotten members (D3)" 2013-01-18 07:46:41 +00:00
Jean Chalard
e3ec5fcc88 Fix a bug in gesture after a dash or apostrophe 
It would insert a space when it shouldn't when composing a
word ending in either dash or apostrophe and gesturing right
away.

Bug: 7889078
Change-Id: Ib3e2f6f5e551888cc081b464a641e2deac6f5ef7
 2013-01-18 15:05:34 +09:00
Jean Chalard
5a6b4f953e Merge "Insert into user dict in lower case if auto-caps (D2)" 2013-01-18 05:39:18 +00:00
Kurt Partridge
345ef67627 [Rlog78a] Annotate logUnits with corrections 
If the user makes a correction to a word, this is now explicitly indicated
in the logUnit.

Change-Id: I8638aadd7b8c8e32bbc9c4b020548d786513d887
 2013-01-17 14:05:02 -08:00
Kurt Partridge
e6a9655a03 Merge "Consolidate SuggestedWords.getWordInfo and .getInfo" 2013-01-17 22:01:26 +00:00
Kurt Partridge
937877b877 Merge "[Rlog14] Increase feedback buffer to cover whole session" 2013-01-17 21:21:49 +00:00
Kurt Partridge
63ed9abbe8 Merge "[Rlog13] ResearchLogger fix feedback" 2013-01-17 19:56:25 +00:00
Kurt Partridge
f881f10e90 Merge "Fix commit partial text logStatement" 2013-01-17 19:15:32 +00:00
Kurt Partridge
34ecd12a05 Merge "Add comment" 2013-01-17 17:50:42 +00:00
Kurt Partridge
b5ac8ef586 Consolidate SuggestedWords.getWordInfo and .getInfo 
Change-Id: I959cf049f550b7be3ec002281ca7457e566b0214
 2013-01-17 07:50:15 -08:00
Kurt Partridge
5213559e0e Fix commit partial text logStatement 
- No longer suggests that it is called from a non-existent method
  in RichInputConnection

Change-Id: I25fe4a0f232a4320ca113598bbcdd029ca319944
 2013-01-17 07:46:06 -08:00
Jean Chalard
8914555776 Reset forgotten members (D3) 
Only resetting mCapitalizedMode is enough to fix bug#8013488,
but we may as well correctly reset both fields.

Bug: 8013488
Change-Id: Icb0d7c5b1e93368e8eb7848aa9137b45d5d3531e
 2013-01-17 20:39:09 +09:00
Jean Chalard
96845ecff6 Insert into user dict in lower case if auto-caps (D2) 
Also recapitalize afterwards if the word has been changed.

Bug: 7972124
Change-Id: I9306580bb4ed0ffa80cc4559ce1abcd2034d1905
 2013-01-17 20:38:52 +09:00
Jean Chalard
c665cbee7f Merge "Forward the capitalized mode to the positional info (D1)" 2013-01-17 11:02:00 +00:00
Jean Chalard
15ea1d4096 Merge "Simplify the space-before and space-after logic." 2013-01-17 09:07:20 +00:00
Jean Chalard
ae3b96b26e Simplify the space-before and space-after logic. 
Bug: 7889078
Bug: 7268000
Change-Id: I6c77b8c9e60ef69f02526b407124d2f5d02818ee
 2013-01-17 17:52:46 +09:00
Tadashi G. Takaoka
40c59727cf Merge "Add default button to vibration/volume settings dialog" 2013-01-17 08:41:01 +00:00
Tadashi G. Takaoka
1b1fa7a18b Merge "SeekBarDialog supports neutral and dismiss listener" 2013-01-17 08:27:27 +00:00
Jean Chalard
22959faad4 Merge "Stop relying on the soft keyboard to get the editor action." 2013-01-17 07:16:58 +00:00
Jean Chalard
b6b7f5e39e Forward the capitalized mode to the positional info (D1) 
Bug: 7972124
Change-Id: I3c74f3b075e698b9e9dd1d2c7b6f173073539063
 2013-01-17 14:35:58 +09:00
Kurt Partridge
7f8c096bf2 [Rlog13] ResearchLogger fix feedback 
The feedback string was not being inserted in the feedback logs.  Also changed the tag to
"UserFeedback" from "UserTimestamp" to better reflect the data recorded.

Change-Id: Iccf781b25e2573168c36e729419468f5bd73903e
 2013-01-16 21:29:51 -08:00
Tadashi G. Takaoka
84ce64f2c0 Fix bounding rectangle of gesture preview trail 
Bug: 7917443
Bug: 7987585
Change-Id: I99e6db1fe43d3a9b497e92330a6857e0454c428c
 2013-01-16 19:51:01 +09:00
Jean Chalard
d818f1e3b6 Stop relying on the soft keyboard to get the editor action. 
Bug: 7969231
Change-Id: I9848c63c4c51550b5dc53c981eafa74e7fa95197
 2013-01-16 18:22:00 +09:00
Kurt Partridge
14b800d858 [Rlog14] Increase feedback buffer to cover whole session 
Change-Id: I55b61d9ca6eecd56181b8d2913f71559555cd89e
 2013-01-15 18:34:13 -08:00
Kurt Partridge
9579936bcf [Rlog67] Renaming clarification 
ResearchLogger.latinIME_handleSeparator wasn't doing anything really specific to
the separator, so its implementation has been renamed according to its role.

Change-Id: I24e8691c7dc440dd067e96d23e50463683e17cfc
 2013-01-15 08:57:52 -08:00
Jean Chalard
dcfceaff1b Distinguish action-enter/shift-enter/enter 
Bug: 7969231
Change-Id: I75d495ee1ea126da9be4e269ee990ee0a97793c1
 2013-01-15 19:12:41 +09:00
Ken Wakasa
c995dbcf59 Merge "Remove MAX_WORD_LENGTH_INTERNAL" 2013-01-14 19:46:09 -08:00
Ken Wakasa
5db594abba Remove MAX_WORD_LENGTH_INTERNAL 
Change-Id: Ie11ff000675601acff5fbb00e9e9f48eb32c5071
 2013-01-15 12:39:08 +09:00
Tadashi G. Takaoka
722eeb144f Fix drawing Arabic diacritics 
Bug: 8001868
Change-Id: I0e5aab266bbaad8c68e4a900b8d5572977a0379d
 2013-01-15 11:03:15 +09:00
Kurt Partridge
019bcc62b9 Merge "[Rlog68] Logger; make filenames more unique to prevent filesys conflicts" 2013-01-14 10:02:16 -08:00
Kurt Partridge
5b611e184b Merge "[Rlog63] Log whether a manual suggestion is a prediction" 2013-01-14 09:30:12 -08:00
Kurt Partridge
0a292ad883 Add comment 
Change-Id: If21222aa678a827c1fcad5cacac0fa20655e4e5e
 2013-01-14 09:08:51 -08:00
Kurt Partridge
939e3f3152 Merge "[Rlog59d] Pass separatorString through revertCommit" 2013-01-14 08:59:04 -08:00
Kurt Partridge
67a61fc6be [Rlog68] Logger; make filenames more unique to prevent filesys conflicts 
multi-project commit with If6b9f8990d7cdbf570740a81096513698d0e0f4c

Change-Id: I124aed24be0beb4c472869594184ecf003c2fed4
 2013-01-14 07:11:42 -08:00
Kurt Partridge
31156c816e [Rlog59d] Pass separatorString through revertCommit 
Change-Id: I5ef20476318979f99f543f9300cf6198d18f6244
 2013-01-14 07:01:49 -08:00
Kurt Partridge
3e05370d53 Merge "[Rlog59c] More detailed logging of backspace" 2013-01-13 11:13:37 -08:00
Kurt Partridge
916c0a08c6 Merge "[Rlog60] Log if a logUnit is uncommitted" 2013-01-12 12:57:19 -08:00
Kurt Partridge
ef3936bc54 [Rlog59c] More detailed logging of backspace 
- Normal delete events are recorded
- Includes number of characters deleted for both batch and normal delete

Change-Id: I422da3ddc94fa0ccd6c7586eaacf14c62dd16679
 2013-01-12 12:54:59 -08:00
Kurt Partridge
343a852cd9 Merge "[Rlog59b] Log CodeInput and KeyCode properly" 2013-01-12 10:18:57 -08:00
Kurt Partridge
b75e2380e2 Merge "[Rlog58b] Log user pauses" 2013-01-11 10:19:13 -08:00
Kurt Partridge
3338703a2f [Rlog63] Log whether a manual suggestion is a prediction 
Change-Id: Ia6f793611d4b18aecb1a635655af5edb639e1ecf
 2013-01-11 09:55:09 -08:00
Kurt Partridge
5523a6818d Merge "[Rlog59a] Split logUnits correctly around separators" 2013-01-11 09:18:10 -08:00
Ken Wakasa
f6870cc82d Remove BinaryDictionary.MAX_PREDICTION and MAX_SPACES, and rename MAX_WORDS to MAX_RESULTS 
Change-Id: Iab2a422b367e7521f346481c7fe5e2575f2e9de3
 2013-01-11 20:47:42 +09:00
Kurt Partridge
99931201d0 [Rlog59b] Log CodeInput and KeyCode properly 
- Fix function calls to happen at more resilient times
- In the case of phantom spaces, ensure that the logStatement goes to the
  correct logUnit

Change-Id: Ida8f6eba1e4f33d9f9b4735316e3c6316ed316c0
 2013-01-10 23:39:11 -08:00
Kurt Partridge
b4fe364b39 [Rlog60] Log if a logUnit is uncommitted 
Normally logUnits are committed to a log when the word that their data
corresponds to is complete.   However, if the user reverts a word, or goes
back to edit it, then the system may "uncommit" the logUnit, and append
additional editing steps to the end of it.  When this happens, we want to
make a note of it in the log, which is what this patch does.

Change-Id: If2bbb948469824c76facf5f06ed8a6da8ff9777c
 2013-01-10 23:18:40 -08:00
Jean Chalard
d8590857bd Fix spell checker subtype list. 
Remove the subtypes that don't get a dictionary any more in AOSP.
Also prepare for all downloadable-dictionary supported subtypes.

Bug: 7673670
Change-Id: I5b754a791233c270237b8f7e5e2208f7282ad294
 2013-01-11 14:59:34 +09:00
Kurt Partridge
05ee6ad843 [Rlog58b] Log user pauses 
Change-Id: I7802f07192a4cba4f3cfb5c08ce6d5d2d85a46c1
 2013-01-10 19:54:40 -08:00
Kurt Partridge
aa9db1e259 Merge "[Rlog] Fix some potential NPEs" 2013-01-10 17:14:10 -08:00
Kurt Partridge
90aaa2d0a5 [Rlog59a] Split logUnits correctly around separators 
Change-Id: I65ecdead7e7bdeb8a5f1748e27068ddbd5d3ce00
 2013-01-10 16:36:18 -08:00
Kurt Partridge
211103d7fe [Rlog58a] Fix privacy leak of word in logUnitStart 
Change-Id: Idcea4cd0256581e9868ac987fd1fa281ff074483
 2013-01-10 16:06:01 -08:00
Kurt Partridge
4acdd3ad69 [Rlog] Fix some potential NPEs 
Change-Id: I07b18b5db81784dca32683e5f208088181c5eed9
 2013-01-10 16:04:23 -08:00
Kurt Partridge
75e69753b7 [Rlog57b] fix logging of reverts 
Change-Id: I07c817061a0cc060197e0fea45195ca07a9bf276
 2013-01-10 15:00:28 -08:00
Kurt Partridge
a097004264 Merge "[Rlog57a] include logUnit boundaries in output" 2013-01-10 12:04:32 -08:00
Kurt Partridge
700ce8df07 Merge "[Rlog56] Buffer words before pushing out LogUnit" 2013-01-10 10:51:17 -08:00
Ken Wakasa
4da2ed7a78 Fix too thick gesture trail width 
Change-Id: If1b78183b24fa0029bc28e5f56a988372182903e
 2013-01-10 22:18:23 +09:00
satok
2ef0d3bf8d Merge "fix possible NPE in DebugSettings" 2013-01-10 03:00:24 -08:00
satok
e8b4fd2644 fix possible NPE in DebugSettings 
Change-Id: I44ec5bd3b2a00087603316f14d732164dbcf399f
 2013-01-10 19:57:33 +09:00
Jean Chalard
d9c7a6b9b3 Merge "Move a method to a utility class (C1)" 2013-01-10 00:04:11 -08:00
Jean Chalard
9c75ad1ade Merge "Fix international tests" 2013-01-10 00:03:05 -08:00
Tadashi G. Takaoka
a80b8fc98f Merge "Show final suggested word when batch input is finished" 2013-01-09 23:35:09 -08:00
Tadashi G. Takaoka
50d902ac6f Show final suggested word when batch input is finished 
This change moves dismiss timer of gesture floating preview text from
PreviewPlacerView to KeyboardView.

Bug: 7967461
Change-Id: I0ca5beddc93cb4bc4a405f914d217d37b997402b
 2013-01-10 16:25:05 +09:00
Jean Chalard
ae4c81993c Merge "Initial implementation for dead keys (B3)" 2013-01-09 23:15:49 -08:00
Jean Chalard
6a26de1d7e Initial implementation for dead keys (B3) 
Bug: 5037589
Change-Id: I9e1ff92df7d0c58eb7a0f33603adebc9efb86585
 2013-01-10 15:47:21 +09:00
Kurt Partridge
b74a0a78c2 [Rlog57a] include logUnit boundaries in output 
Change-Id: I4d1647b971b0e7a4cf1a96f341236f6ab1d2ab16
 2013-01-09 22:38:27 -08:00
Tadashi G. Takaoka
433f54ce90 Merge "Remove unused variables" 2013-01-09 22:32:23 -08:00
Jean Chalard
424d76fbf5 Merge "Add a next Event (B2)" 2013-01-09 22:23:05 -08:00
Jean Chalard
912ad4614f Fix international tests 
Tests have been broken again by recent changes to subtype
choice within Latin IME. This fixes the problem and all tests
pass again.

This change also includes a small fix to one test that was
checking for something irrelevant.

Change-Id: I6a03dea24f99b0d2ad84c4161a8413f3060bb811
 2013-01-10 15:12:17 +09:00
Tadashi G. Takaoka
a7a7f4e002 Add default button to vibration/volume settings dialog 
Change-Id: I7beb4517314efdefeb47d91b14a6b02c3075c19f
 2013-01-10 15:11:30 +09:00
Tadashi G. Takaoka
6512cd289d Merge "Cancel update batch input timer only when point is added" 2013-01-09 21:47:46 -08:00
Tadashi G. Takaoka
b2f5d15250 Cancel update batch input timer only when point is added 
Bug: 7972004
Change-Id: Ie5db5910efba851976da2284cafc69be2910d354
 2013-01-10 14:31:07 +09:00
Tadashi G. Takaoka
88df3d9239 SeekBarDialog supports neutral and dismiss listener 
Change-Id: I652fd1a383ef4074c04d03a37ebc779d229474e6
 2013-01-10 14:24:54 +09:00
Kurt Partridge
759506ef2d Merge "[Rlog52z] Cleanup and small bug fixes" 2013-01-09 21:12:13 -08:00
Kurt Partridge
403c423940 [Rlog56] Buffer words before pushing out LogUnit 
Previously, a logbuffer only held an n-gram.  Data went in and out of it, FIFO, until privacy
conditions were met (i.e. data not collected too frequently), and then an n-gram was saved.
E.g., if n=2, and only 10% of data is collected, then 18 words went through the logbuffer before
it captured the next 2 words.

However, if a user then went back and edited the n-gram, these edits were not captured.

This change changes the logbuffer size to temporarily hold data about words that are not recorded,
so that if the user backs up over them, the edits to an n-gram that we do eventually capture are
stored.  If the example above, instead of a logbuffer holding 2 words, it holds 20.  The system
waits until all the words not needed for the n-gram have been gathered (i.e. the buffer is full),
so the user has adequate time to edit, before shifting out the n-gram.  The buffer is still flushed
when the user closes the IME.  See the comment for MainLogBuffer for an explanation.

multi-project commit with I45317bc95eeb859adc1b35b24d0478f2df1a67f3

Change-Id: I4ffd95d08c6437dcf650d866ef9e24b6af512334
 2013-01-09 21:09:19 -08:00
Kurt Partridge
8bda35809b [Rlog52z] Cleanup and small bug fixes 
Change-Id: Ia3fca4881370ffcdd5f2b14d2d1094c51f4330ae
 2013-01-09 21:07:51 -08:00
Kurt Partridge
f11c4a9aeb Merge "[Rlog50] capture bigrams properly even with deletions" 2013-01-09 19:52:45 -08:00
Tadashi G. Takaoka
1aa547d94a Remove unused variables 
Change-Id: I508679c2ad21b2624760d37a9503e21733964d4c
 2013-01-10 12:34:35 +09:00
Tadashi G. Takaoka
95e3008d25 Merge "Rename variables related to key preview popup" 2013-01-09 19:32:33 -08:00
Tadashi G. Takaoka
6ece8f718b Merge "Remove unused variable" 2013-01-09 19:32:18 -08:00
Tadashi G. Takaoka
3727a3fd61 Merge "Clean up public helper methods of SettingsValues" 2013-01-09 19:04:46 -08:00
Tadashi G. Takaoka
813692c956 Rename variables related to key preview popup 
Change-Id: I0161e5844dd325af9afba80ac54a569b16c80660
 2013-01-10 11:47:18 +09:00
Tadashi G. Takaoka
e0e0b04188 Remove unused variable 
Change-Id: I7001d8b6200a5cefcf84630d663da8316422026f
 2013-01-10 11:43:35 +09:00
Kurt Partridge
3b95eaf70b [Rlog50] capture bigrams properly even with deletions 
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0

Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
 2013-01-09 16:02:37 -08:00
Jean Chalard
6c75253c11 Add a next Event (B2) 
Change-Id: If2fe6f0f4f88a6ae1f22664ded61cec6942c18b9
 2013-01-09 22:12:13 +09:00
Jean Chalard
125ad22370 Merge "Abandon the idea of an Event pool and make Event immutable (B1)" 2013-01-09 05:07:42 -08:00
Jean Chalard
8da9c337db Move a method to a utility class (C1) 
This is a preparatory change to fix bug 7969231

Change-Id: I44604ae75192a17b4e75a01f3e3d679d4901299e
 2013-01-09 21:59:06 +09:00
Jean Chalard
ae74b8cf67 Abandon the idea of an Event pool and make Event immutable (B1) 
Change-Id: I750a07c0c564a95ceac734afa873ca3da9626a7f
 2013-01-09 21:08:58 +09:00
Jean Chalard
b112a13518 Merge "Fix a race condition with backspaces" 2013-01-09 01:53:47 -08:00
Jean Chalard
516b63db28 Fix a race condition with backspaces 
And add a test to make sure it stays not-broken.

Bug: 7946604
Change-Id: I996da3d5507d591ec25a13fb57434f39843f1df5
 2013-01-09 18:37:10 +09:00
Tadashi G. Takaoka
e56686f43a Merge "Cancel update batch input timer whenever MotionEvent is received" 2013-01-09 01:12:59 -08:00
Tadashi G. Takaoka
915f348b35 Cancel update batch input timer whenever MotionEvent is received 
Bug: 7911739
Change-Id: Id2cd98385371fd98435943ed66ec5381dfaa48e0
 2013-01-09 17:55:42 +09:00
Tadashi G. Takaoka
8353e751ca Don't cancel gesture typing while more keys keyboard is shown 
Bug: 7964225
Change-Id: I4c572527b6f399282bdd963e38c147c7e69815ac
 2013-01-09 16:56:59 +09:00
Tadashi G. Takaoka
d3b0ecec22 Clean up public helper methods of SettingsValues 
Change-Id: I6c6087580b67f497eaaf16900f8df7a4a895b8e3
 2013-01-09 11:23:34 +09:00
Tadashi G. Takaoka
8315e8168b Merge "Clean up debug related preference keys" 2013-01-08 16:56:13 -08:00
Kurt Partridge
e9c6455881 [Rlog48] Better logging of MotionEvents 
- Now includes all historical data stored in a motionEvent
- Simpler API, refactored to move extraction code to JsonUtils

Change-Id: I52d9756ddbeaa14d1704787da59bf1aad18f0335
 2013-01-08 08:50:06 -08:00
Kurt Partridge
9bad176ebe Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly" 2013-01-08 08:10:31 -08:00
Kurt Partridge
b7fb16e8cc Merge "[Rlog27] Refactor LogBuffer" 2013-01-08 07:40:57 -08:00
Tadashi G. Takaoka
a5ff9f0c77 Clean up debug related preference keys 
Change-Id: Ib7129692c673b3bce253120ee709e0253aeafa52
 2013-01-08 18:26:47 +09:00
Tadashi G. Takaoka
ff0735ada8 Make Settings class singleton to manage SettingsValues 
Change-Id: Id30828a141de86d9bcf8bce586d2adb468cc59e1
 2013-01-08 17:48:47 +09:00
Tadashi G. Takaoka
8873b5ae31 Merge "Rename Settings to SettingsFragment" 2013-01-07 23:00:59 -08:00
Tadashi G. Takaoka
4b852d6044 Merge "Consolidate VibratorUtils with AudioAndHapticFeedbackManager" 2013-01-07 23:00:04 -08:00
Tadashi G. Takaoka
cbee8a33d5 Rename Settings to SettingsFragment 
Change-Id: If5bc53efc67be507663091de0f569f604c03e719
 2013-01-08 15:59:16 +09:00
Tadashi G. Takaoka
b17b887425 Consolidate VibratorUtils with AudioAndHapticFeedbackManager 
Change-Id: Ica4e3193f369330da62a259c718b779ddf9fbde5
 2013-01-08 15:13:19 +09:00
Jean Chalard
c79493a15f Adjust the used frequency of the user dictionary words. 
Bug: 7656666
Change-Id: I4b271af636f6103cb5287336229581365841d778
 2013-01-08 14:57:20 +09:00
Kurt Partridge
99f3189645 [Rlog32] ResearchLogger segment motion data around gestures correctly 
multi-project commit with I684ba5fed8c653777942e6b0366113ca40dfa37c

Change-Id: Id3804e6cfa97b4cdde212b8eebc413f76fa4772c
 2013-01-07 20:06:29 -08:00
Xiaojun Bi
28de7223e6 Merge "[mdfp] Refactoring Gesture Floating Preview Text Code" 2013-01-07 17:12:35 -08:00
Xiaojun Bi
d52730a2d7 [mdfp] Refactoring Gesture Floating Preview Text Code 
This change moves gesture preview text code from PreviewPlacerView.java
to separate classes.

Change-Id: Id8d17eff38e714c3b06aafd0b24985a9bd2d2f52
 2013-01-07 10:39:23 -08:00
Tadashi G. Takaoka
f90fc105ab Simplify singleton class initialization 
Change-Id: I16a27f2ed6ea66184bfdc9903180372cd7ea2fd1
 2013-01-07 19:05:31 +09:00
Ken Wakasa
b6ca354431 Small code cleanups 
Multi-project commit with I249d5fbe

Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
 2013-01-07 12:13:42 +09:00
Jean Chalard
f677681330 Fix double input of chars typed on a h/w keyboard 
Bug: 7939324
Change-Id: I11b7af54893cb645f8a06266a0b0ba95dd0b02f9
 2013-01-07 10:03:20 +09:00
Kurt Partridge
f77dd424b0 [Rlog27] Refactor LogBuffer 
Cleanup and prepare for replaying

Change-Id: Ie09e912c6e9c0d7375168c575ccf1cfd9375dd31
 2013-01-03 16:36:32 -08:00
Tadashi G. Takaoka
fa7f08b373 Set default audio and haptic feedback settings 
- Default keypress volume is set to 0.2f in resource.
- Default keypress vibration duration is set to 10 msec in resource.

Bug: 7055329
Change-Id: I83bd6288d171d9787d52e2b02e4e5305f1435681
 2012-12-28 19:24:32 +09:00
Tadashi G. Takaoka
a2982dd5a7 Refactor to add SeekBarDialog 
Change-Id: Id8e08a1d5ec5efb2baf96a2634111619fcb9fd4e
 2012-12-28 15:49:36 +09:00
Jean Chalard
864db4b0da A small simplification. 
It's useless to setAutoCorrection(getTypedWord()). Every time the
contents of the word composer are altered, the auto-correction is
reset, and at use time if it's null then the typed word is used
anyway.

Change-Id: I0870657a1ab3f456f376995b27e70703f7a5d23a
 2012-12-28 14:41:28 +09:00
Jean Chalard
997cba7dec Start committing hardware events (B4) 
Essentially this does activate auto-correction with a hardware
keyboard, although a lot of things are still left to implement.
No proximity is used yet which means only missing and excessive
letters are considered. Dead keys are not handled. No combiner
is supported. No suggestions are displayed. Resuming suggestions
does not work correctly with a hardware key (because the view
holds a temporary hardware event 'onKeyPreIme' and the event
from the IME won't be handled until this is handled which won't
happen until after the IME said that it did handle the event).

Bug: 5037589
Change-Id: Idcb5c7b26d56717ed772d53c062362807f11cdae
 2012-12-27 16:17:49 +09:00
Jean Chalard
581f324ed8 Initial implementation for decoding HW key events (B3) 
Bug: 5037589
Change-Id: I829f70a258de58ef8d2b836a9b435198a226e37f
 2012-12-27 16:17:46 +09:00
Jean Chalard
0abc48218e Rename some confusing variables 
Change-Id: Ib0de800599ae7f12c86270a627616d5b52366414
 2012-12-27 15:42:14 +09:00
Jean Chalard
5bde3a6163 Fix an old bug in getting a word from the connected view. 
In this test, it's impossible that start < 0 so the test is useless.
I'm not sure what the cursor test was for, but it's very old code, and
it seems the assumption was either misled or doesn't hold any more:
testing for the absolute cursor position against the length of the
word against the cursor makes no sense.

The net result of this was that when the cursor index got large
enough, resuming suggestion would not work any more.

Bug: 7586467
Change-Id: I3462082374fe9579bec7698f4d424de6ff5f2ded
 2012-12-27 15:41:10 +09:00
Tadashi G. Takaoka
0856ceef9a Merge "Get rid of current subtype and system locale cache from SubtypeSwitcher" 2012-12-26 19:21:36 -08:00
Tadashi G. Takaoka
1dbec26f8f Merge "Fix gesture trail width calculation" 2012-12-26 19:01:31 -08:00
Tadashi G. Takaoka
f483225397 Get rid of current subtype and system locale cache from SubtypeSwitcher 
Bug: 7675452
Change-Id: I2121f56964b6d25e8d40f5b8ec67eeae527b2117
 2012-12-27 12:00:38 +09:00
Tadashi G. Takaoka
92aee35222 Fix gesture trail width calculation 
Change-Id: I41e0a95437aa9b8ec9a8eefb3bc5eb0452284b60
 2012-12-27 11:43:35 +09:00
Jean Chalard
5112b59db2 Add support for multiple keyboard event decoders (B2) 
Bug: 5037589
Change-Id: I0a4926f94ef8d1caa17669801608608648b697b9
 2012-12-26 20:25:05 +09:00
Kurt Partridge
4aff3bf0ea Clean up unnecessary uses of toString() 
Leftover from changing variables from CharSequence to String

Change-Id: I4db43fcb075aa37bf9c5b2a23bad0e4c2d718379
 2012-12-23 18:42:06 -08:00
Kurt Partridge
f763dc5915 [Rlog24] ResearchLogger detect word boundaries in callers above commitText 
multi project commit with I5847d4aba97a7224ae170a7153811c5a11816449

Change-Id: Ie6fbf6f19f0193451fe6f3ddf9d4ef1637a35db1
 2012-12-23 12:33:16 -08:00
Kurt Partridge
13b1be988d Merge "Log LatinIME.commitCurrentAutoCorrection()" 2012-12-23 11:47:47 -08:00
Kurt Partridge
c1b4d14394 Merge "Differentiate LOG_EVERYTHING and LOG_FULL_TEXTVIEW_CONTENTS" 2012-12-23 11:20:34 -08:00
Kurt Partridge
5e9a5ca998 Merge "[Rlog36z] Pass LatinIME instance to logger as LatinIME class" 2012-12-23 10:37:31 -08:00
Kurt Partridge
dce58fe895 Merge "[Rlog24z] Initialize statistics variables" 2012-12-23 09:51:22 -08:00
Kurt Partridge
a51fbd92a5 Merge "[Rlog20] Remove duplicate logStatistics" 2012-12-23 09:05:00 -08:00
Kurt Partridge
99bd42b295 [Rlog24z] Initialize statistics variables 
Change-Id: I73a6009294a4f559a93b6ea9ceb4ea2683d97486
 2012-12-23 09:04:01 -08:00
Kurt Partridge
f0d626ecfc Merge "[Rlog19] ResearchLog remove unnecessary logSegment{start,end}" 2012-12-23 08:28:53 -08:00
Kurt Partridge
9e12ba6c95 Merge "[Rlog22] ResearchLogger fixed debug printing" 2012-12-22 18:02:25 -08:00
Kurt Partridge
226377e65a Log LatinIME.commitCurrentAutoCorrection() 
Change-Id: Ic46c91374ae0177cafad4579d28d6980af0d8d3a
 2012-12-22 17:32:12 -08:00
Kurt Partridge
fc6e0cce6f [Rlog19] ResearchLog remove unnecessary logSegment{start,end} 
Change-Id: I73b7765c764e5f1035f1c37df45345f26aa5acb1
 2012-12-22 17:22:43 -08:00
Kurt Partridge
583a1edc4a [Rlog22] ResearchLogger fixed debug printing 
Change-Id: I2c59983236c936b8698004db8213b68c2f964cd5
 2012-12-22 17:16:51 -08:00
Kurt Partridge
18b01e88ac Merge "[Rlog41] ResearchLogger debugging support in UploaderService" 2012-12-22 17:12:39 -08:00
Kurt Partridge
5dd5dd2911 [Rlog36z] Pass LatinIME instance to logger as LatinIME class 
Upcoming changes require LatinIME class, not just InputMethodService

Change-Id: Ia5b3a716ac02a99749fb2ba0164ba46c8a0c559a
 2012-12-22 14:20:39 -08:00
Kurt Partridge
68fc33bd92 Differentiate LOG_EVERYTHING and LOG_FULL_TEXTVIEW_CONTENTS 
Previously, LOG_EVERYTHING logged both all bigrams and also the entire TextView at the end of a
session.  Now, use a separate flag, LOG_FULL_TEXTVIEW_CONTENTS to determine whether the TextView
contents are recorded.

Change-Id: I0c7a90a8ff88aa65d057f3b2d3dd5adc3893504a
 2012-12-22 13:57:58 -08:00
Kurt Partridge
522d739524 [Rlog20] Remove duplicate logStatistics 
Change-Id: I31c5520598269a83ab218e3a024bff0a625c2770
 2012-12-22 13:38:28 -08:00
Kurt Partridge
ab5d2b45b9 [Rlog41] ResearchLogger debugging support in UploaderService 
Change-Id: I70d5bd0cb12be7a5cc216799f92622912646466f
 2012-12-22 13:07:46 -08:00
Kurt Partridge
163699e240 Merge "[Rlog12] Add comments to logging callpoints" 2012-12-22 12:59:15 -08:00
Kurt Partridge
ab9f4fd359 Merge "[Rlog7] ResearchLog improve gesture tracking" 2012-12-22 11:50:46 -08:00
Kurt Partridge
c322c3c3c7 [Rlog12] Add comments to logging callpoints 
Change-Id: Idd786e2804dc82c1fa27ecf0fc0537491438d017
 2012-12-21 12:34:39 -08:00
Kurt Partridge
f1ce54891f [Rlog7] ResearchLog improve gesture tracking 
- count how many times a gesture is deleted
- count num chars entered by gesture
- change name of fns to reflect capturing gesture information when setting composing text

Change-Id: I1b8ebf9cfcf304e0efd827c8b8e28a4010199728
 2012-12-21 12:33:54 -08:00
Kurt Partridge
5a7ac3bf2a Merge "[Rlog6.2] ResearchLogging Refactor" 2012-12-21 11:43:18 -08:00
Kurt Partridge
58281a98eb [Rlog6.2] ResearchLogging Refactor 
Move specifics of Log output format from ResearchLog to LogUnit

Change-Id: I9d0253c50bb8175ab141bd87dd9a09f39f316b10
 2012-12-21 11:36:28 -08:00
Tadashi G. Takaoka
7c1e853387 Call onCancelBatchInput only when onStartBatchInput has been called 
This NPE issue (Bug: 7903331) has been introduced by Ie68c7698.

Bug: 7903331
Change-Id: I44884f5608fe47d9db7a2c93a752d17b9ae39a22
 2012-12-21 14:31:03 +09:00
Kurt Partridge
11bc86adcb Merge "[Rlog13] Add flag to inhibit uploading" 2012-12-20 13:13:21 -08:00
Kurt Partridge
4c2b6923c3 Merge "[Rlog11] ResearchLogger printable code for research key" 2012-12-20 11:40:18 -08:00
Kurt Partridge
a98dabf106 Merge "[Rlog10] ResearchLogger change visible indicator to just lines on the side" 2012-12-20 10:43:11 -08:00
Kurt Partridge
0214f70e0c Merge "[Rlog8] Show red border if logging everything" 2012-12-20 09:53:32 -08:00
Kurt Partridge
5a50d574e4 [Rlog13] Add flag to inhibit uploading 
Change-Id: I9d22dfb3fbc8332000507c8b97d9072bdd8dda91
 2012-12-19 18:32:28 -08:00
Kurt Partridge
c572c20cd8 [Rlog8] Show red border if logging everything 
Change-Id: I5a3f21cef7d93128661b11b60eac7d84b8110e47
 2012-12-19 18:26:07 -08:00
Kurt Partridge
ff9e30f5a3 [Rlog10] ResearchLogger change visible indicator to just lines on the side 
(Note: Rlog9 was abandoned).

Change-Id: I69de4116e33d3c79216e25efe2ad2bcb2780b0ff
 2012-12-19 18:20:03 -08:00
Kurt Partridge
af34813127 [Rlog11] ResearchLogger printable code for research key 
Change-Id: Ifac7a801ea8534191a9258871d3d7f91e942788b
 2012-12-19 18:15:41 -08:00
Kurt Partridge
c2049c3284 Merge "[Rlog6.1] Fix LOG_EVERYTHING bug." 2012-12-19 17:20:12 -08:00
Kurt Partridge
94ac7a3851 Merge "Add ProductionFlag.IS_EXPERIMENTAL_DEBUG" 2012-12-19 09:02:05 -08:00
Jean Chalard
cff28c5d5d Add skeleton classes for hardware event flow (B1) 
Bug: 5037589
Change-Id: Id8eea0e2bd00dd339a1efb4b0542e4c091a84195
 2012-12-19 17:47:29 +09:00
Ken Wakasa
45239029ce Remove trailing spaces 
Change-Id: I260b85ef9e91d17f97d6e405d2d92a65b443df44
 2012-12-19 15:36:55 +09:00
Kurt Partridge
41fe487e3a [Rlog6.1] Fix LOG_EVERYTHING bug. 
(It wasn't logging everything).

Change-Id: I8c9fd1e7c04e1a3813e26e67691e0366ff48c9ee
 2012-12-18 19:47:10 -08:00
Kurt Partridge
0aafbcf879 Add ProductionFlag.IS_EXPERIMENTAL_DEBUG 
The IS_EXPERIMENTAL_DEBUG flag gives a single place to turn off all debugging flags that might be
set and to also enforce privacy controls.  Currently only used in the research package.

multi-project commit with I9275a7c8e40bf56106447a02d3056655329074b3

Change-Id: If769fe3a633f33963ca49e8ddf01ab24a30b6fd2
 2012-12-18 19:46:30 -08:00
Kurt Partridge
baf73311cd Merge "[Rlog6] ResearchLogger fix dictionary loading" 2012-12-18 12:25:31 -08:00
Kurt Partridge
ce8b139124 Merge "[Rlog5] ResearchLogging change from onFinishInput to onFinishInputView" 2012-12-18 11:34:34 -08:00
Kurt Partridge
1e55e59cc9 Merge "[Rlog4] ResearchLogger add LOG_EVERYTHING flag" 2012-12-18 10:46:12 -08:00
Kurt Partridge
8432c1317a Merge "[Rlog3] improve stat recording" 2012-12-18 09:54:05 -08:00
Kurt Partridge
606058f777 [Rlog5] ResearchLogging change from onFinishInput to onFinishInputView 
Change-Id: I7d3bcfe647249e0b8a14ac3d67460c2684f16d8c
 2012-12-17 21:39:54 -08:00
Kurt Partridge
40417aed94 [Rlog6] ResearchLogger fix dictionary loading 
Change-Id: I5af460bd7c7fd67f858626ae3daf71fd615a25bf
 2012-12-17 21:39:54 -08:00
Kurt Partridge
1a27336837 [Rlog4] ResearchLogger add LOG_EVERYTHING flag 
- broaden OUTPUT_WHOLE_BUFFER to log not just the buffer at the end, but everything along the
  way.  This should only be set when the user is aware that logging is on, e.g. in a user test.

Change-Id: I8f9874697524e533586da40d0a3e452f6a04d3e4
 2012-12-17 21:39:35 -08:00
Kurt Partridge
48160f9d84 [Rlog3] improve stat recording 
Change-Id: Ie3b70e6eadc2a9af5ef45ddfad6a3398cea7bfe8
 2012-12-17 17:08:47 -08:00
Kurt Partridge
c5da4365fb Merge "[Rlog2] ResearchLogging fix multi-space logging" 2012-12-17 16:33:57 -08:00
Kurt Partridge
3370dc8237 [Rlog2] ResearchLogging fix multi-space logging 
multi-space logging should look like single-space logging, missing a few minor log statements
(SuggestionUpdates, SetComposingText)

multi-project commit with I2af842348c2f2b8f7271ac5b63def245e83df24d

Change-Id: Icd3187c0d0377255f82787afffea657c14345803
 2012-12-17 09:53:43 -08:00
Ken Wakasa
e57e9fbd18 Merge "Remove AudioManagerCompatWrapper.java" 2012-12-17 02:50:18 -08:00
Ken Wakasa
fbe83245c9 Clean up SuggestionSpanUtils for API level 14+ 
Change-Id: Iadc235524341b48e7618e9ce05907c786409e004
 2012-12-17 19:41:44 +09:00
Ken Wakasa
1e6edb3e57 Remove AudioManagerCompatWrapper.java 
It is actually no longer needed for API 14+

Change-Id: I379809eae881351fdf210dd8eaa5e0b5662fb59f
 2012-12-17 18:27:20 +09:00
Ken Wakasa
96b22200be Privatize a few constants in BinaryDictionary.java 
Change-Id: I7defaf1f577fd67e678cac83ff935e8181dd0a48
 2012-12-17 17:46:57 +09:00
Tadashi G. Takaoka
f21a491ad8 Show last valid suggestions when gesture typing gets no suggestion 
Bug: 7679566
Change-Id: Ie68c7698144c7576b5814ee35664309bcfdcbf0f
 2012-12-17 16:19:10 +09:00
Tadashi G. Takaoka
b808188b2f Show last valid suggestions when tap typing gets no suggestion 
Bug: 7872809
Change-Id: Ib5a255de7968aba214249c1b934327d248a15efd
 2012-12-17 14:32:18 +09:00
Ken Wakasa
8c15e91344 resolved conflicts for merge of d48d6fee to master 
Change-Id: I21141956135debe737453dba87617671b1716d0a
 2012-12-15 09:44:39 +09:00
Jean Chalard
d48d6feedd am db6f21c6: am 18d688c9: Use the amended user dictionary word for insertion 
* commit 'db6f21c6792fe07a733572e1d4978f46b5462c35':
  Use the amended user dictionary word for insertion
 2012-12-14 11:01:56 -08:00
Kurt Partridge
39b5396f8e Merge "[Rlog1] Track time of log statements" 2012-12-14 06:08:20 -08:00
Jean Chalard
18d688c94b Use the amended user dictionary word for insertion 
When the user edits a word before adding it to the user
dictionary, the keyboard should replace whatever was
committed before with the amended version.

Bug: 7725834
Change-Id: I1a417be6c5a86d6a96bc2c76aca314ad8f1202a9
 2012-12-14 20:28:22 +09:00
Tadashi G. Takaoka
edbb65be3e Reset composing state at onFinishInputView 
Bug: 7709817
Change-Id: Icac0b8cb28209d98d291d8f00be55e33af5bf696
 2012-12-14 17:48:13 +09:00
Tom Ouyang
ac69ab400d Refactor more keys menu framework (part 3) 
Make it possible to re-enter gesture input even after triggering the long-press
menu. This is useful for new users who may pause at the start of a word. Works
for both single and bi-manual gestures.

Bug: 7595193
Change-Id: Ieaecfd5385ed6c10ae9347b99c2e35a0de5e895d
 2012-12-13 21:45:51 -08:00
Tom Ouyang
be68b41ccb Fix more suggestion window asymmetry bug in N7. 
Bug: 7711822
Change-Id: I63ba13b1c160cf55b8820a08e6e28fa666dd2580
 2012-12-13 21:01:30 -08:00
Tom Ouyang
1f4f404e1f Merge "Refactor more keys menu framework (part 2)" 2012-12-13 18:51:37 -08:00
Kurt Partridge
5e854e281a [Rlog1] Track time of log statements 
Log statements are now recorded with a timestamp.  This is important for filtering out statements
not part of words that are sampled when spaces are inserted automatically.

multi-project commit with Change-Id: I68221a2528045d25632aef4bb716f92a4f4a56a4

Change-Id: I46ac9b3b1dcbb08425160d0109028cb64445139c
 2012-12-13 18:44:10 -08:00
Tom Ouyang
35580bad6f Refactor more keys menu framework (part 2) 
- Integrate pointer tracking between more keys menu, more suggestions menu, and main keyboard.
- Adds multi-touch support for more keys menus. Long press with one finger and select keys with another finger.

Bug: 7508007

Change-Id: I394f28cd79e342d6bcfea573af72aa33b9def00f
 2012-12-13 13:17:28 -08:00
Tadashi G. Takaoka
8eaf75aa7b Fix label of switch to symbols key when symbols has shortcut key 
This change fixes the labels of switch to symbols key and switch back
from more symbols key when symbols layout has shortcut key.

Change-Id: I3fbbef2d929486d0f0542f4d89cb086d9f5bad82
 2012-12-13 17:44:40 +09:00
Tadashi G. Takaoka
ac3720ce6d Fix layout switch keys' label of no language subtype keyboard 
This change moves the following string from resources to
KeyboardTextsSet.
- label_to_alpha_key
- label_to_symbols_key
- label_to_symbols_with_microphone_key

Bug: 7697799
Change-Id: Icf9b8848de4c70f792e336f2ae274dab12be79ee
 2012-12-13 17:44:10 +09:00
Jean Chalard
f1b464da31 Remove a useless member 
Change-Id: Id13e0aeec6ec3655d6bb0edc7f8f7821e7dc5a36
 2012-12-11 19:15:24 +09:00
Tadashi G. Takaoka
12939572f3 Remove unused suggestion preview stuffs 
Change-Id: Ida5668f4eba1783d96e02001a64ae713f98176b7
 2012-12-07 17:47:09 -08:00
Tom Ouyang
fa2d543785 Refactor more keys menu framework (part 1) 
Eliminate use of slower popup window for rendering the more keys menu and more suggestions menu.
These menus are now drawn directly on the preview placer view.

Change-Id: I40638724a6ffde2be4b5d0341d2a5db7ff7be930
 2012-12-07 16:34:25 -08:00
Tadashi G. Takaoka
8e2b34cdb2 Cancel batch input when orientation has been changed 
Bug: 7665231
Bug: 7662486
Change-Id: I7b6095026dbf1b9b2f6d3b29f2ab83c462ab374e
 2012-12-06 14:24:05 -08:00
Tadashi G. Takaoka
b494b30453 Merge "Fix off by one bug in gesture trail drawing" 2012-12-06 09:57:24 -08:00
Jean Chalard
2da8866518 Remove a couple Eclipse and Android Lint warnings 
Change-Id: I0c29c5d2abcbf80759b996d34b534deb083cd7d3
 2012-12-06 21:30:51 +09:00
Tadashi G. Takaoka
8c93e513ad Fix off by one bug in gesture trail drawing 
Bug: 7594165
Change-Id: Ia3f7dcee71db91e39c40022b19e7b07c5d4488c8
 2012-12-05 14:56:31 -08:00
Ken Wakasa
2b6a1fed76 Method/variable/resource names clean up for the double-space period 
bug: 7664717
Change-Id: I914aa588b863c442c2d360221e3fa0f4c42640e7
 2012-12-05 12:40:10 +09:00
Jean Chalard
b4a9a6deba Merge "Fix wrong misspelling reports of fully capitalized words" 2012-12-04 01:22:48 -08:00
Jean Chalard
95bfb8ac47 Fix wrong misspelling reports of fully capitalized words 
Two flavors of words would be wrongly reported as misspelled
by the android spell checker when they are written in all
upper case letters:
- Words containing a quote or a dash or any other non-letter
- Words that need the first letter to be capitalized

Bug: 7659216
Change-Id: Ibc5d261945ffcbb8a858d4c73b7c62cef6671abf
 2012-12-04 18:05:27 +09:00
Tadashi G. Takaoka
6e9e5635c3 Merge "Dismiss sliding key input preview when touch event is canceled" 2012-12-03 23:45:46 -08:00
Tadashi G. Takaoka
08d8a676c2 Dismiss sliding key input preview when touch event is canceled 
This is a follow up of Id807af31.

Bug: 7662486
Change-Id: I13895140f1214592257d0023c1450875a4885ee9
 2012-12-04 16:37:26 +09:00
Ken Wakasa
139bd83f0c Add a new option for the double-space period functionality 
bug: 6934756

Change-Id: I94b2d08cac6533e96031d8e97f347e9b5fd72859
 2012-12-04 15:27:22 +09:00
Kurt Partridge
b10ec5319b Fix crashes related to setSpan(-1 ... -1) errors 
Fixes b/7652661

In some circumstnaces, when hiding the window, the logger tries to capture the TextView contents
and restore the cursor position based on the values stored in LatinIME.  However, the IME may not
know the cursor position.

This fix does two things 1) doesn't try to reposition the cursor if the TextView contents are not
to be captured, and 2) if the cursor position is unknown (i.e., == -1), doesn't try to move it back.

Change-Id: I3976aaccf58c18f892c3a8530218ae52bcac9989
 2012-12-03 16:39:58 -08:00
Tadashi G. Takaoka
f9898d05f7 Merge "Get rid of special keys from ProximityInfo" 2012-12-03 01:55:30 -08:00
Tadashi G. Takaoka
308aaff80c Get rid of special keys from ProximityInfo 
Bug: 7601672
Change-Id: I15faa4829b98f7b4dd07013fdd58bc2c527bcd6f
 2012-12-03 18:50:58 +09:00
Tadashi G. Takaoka
84f5816cf1 Merge "Groundwork for sliding key input preview" 2012-12-03 01:19:51 -08:00
Tadashi G. Takaoka
547b638194 Groundwork for sliding key input preview 
Bug: 7548583
Change-Id: Id807af31f581c08ff8074ed1f6766337bea9469f
 2012-12-03 18:16:12 +09:00
Tadashi G. Takaoka
6f0a60d10d Cancel gesture preview update when gesture typing is canceled 
Bug: 7594165
Change-Id: I2854a49b2a2e5d3e36cafc5196191359fd2bf003
 2012-12-03 15:04:01 +09:00
Kurt Partridge
d4dbf09241 Merge "Revert "ResearchLog. Track time of log statements"" 2012-11-30 15:18:49 -08:00
Kurt Partridge
33d5da590f Revert "ResearchLog. Track time of log statements" 
This reverts commit bdbe279cec

Other half of this change couldn't be committed because of a inter-project directory migration.  Reverting until things settle down.

Change-Id: I3862fc8485dfca6d507f620e905cfa583aa0e39a
 2012-11-30 15:18:30 -08:00
Kurt Partridge
bc8df552f0 Merge "ResearchLog. Track time of log statements" 2012-11-30 14:54:16 -08:00
Kurt Partridge
fdfa03c9f1 Merge "ResearchLogger switch word segmentation" 2012-11-30 11:52:09 -08:00
Kurt Partridge
2ae580eaea Merge "ResearchLogging of segments: groups of LogUnits that are sampled together" 2012-11-30 09:28:23 -08:00
Satoshi Kataoka
16e9d343c4 Merge "Tweak beeline speed" 2012-11-30 02:08:55 -08:00
Tadashi G. Takaoka
b5fc0e02d0 Cancel update batch input timer when gesture typing has been canceled 
Bug: 7594165
Change-Id: I9dc42919bd196c249c79668570004d3f541cc9ec
 2012-11-30 16:30:56 +09:00
Kurt Partridge
bdbe279cec ResearchLog. Track time of log statements 
Log statements are now recorded with a timestamp.  This is important for filtering out statements
not part of words that are sampled when spaces are inserted automatically.

multi-project commit with Change-Id: I68221a2528045d25632aef4bb716f92a4f4a56a4

Change-Id: I9f49c36391e1e1773b6d4876d7387c893024f87b
 2012-11-29 20:40:42 -08:00
Kurt Partridge
6a0720478d ResearchLogger switch word segmentation 
Previously, a logunit was considered a word only if it was all letters.  This is important for
tracking bigrams correctly.

Now, a logunit must have only at least one letter.  The dictionary check is still performed,
and punctuation, etc. still comes in as separate LogUnits.  But a word can contain a space,
which helps set up for logging words where spaces are inserted automatically, and other situations
in which text is committed with an additional space tacked onto the end.

Change-Id: Ia74094a99058890d20a9cdadf2d0989841a79a41
 2012-11-29 20:32:12 -08:00
Kurt Partridge
98967539fd ResearchLogging of segments: groups of LogUnits that are sampled together 
Change-Id: Id68de4c6b2df574a38bb5ca800a9b641b1d78200
 2012-11-29 20:31:56 -08:00
Satoshi Kataoka
6ae8dd4343 Tweak beeline speed 
Change-Id: I77bbd5e1888281e838d87824dc04a574b1a7ecb7
 2012-11-30 02:02:59 +09:00
Kurt Partridge
061da39c0f Merge "ResearchLogger add debugging code" 2012-11-29 06:45:25 -08:00
Kurt Partridge
bf9db1cc83 Merge "ResearchLogging fix password field collection" 2012-11-29 06:05:01 -08:00
Tadashi G. Takaoka
e14df775d4 Make RoundedLine member variables as method parameters (Step 5) 
Change-Id: Ib2ade2bf51c293c65fc9206a9a16694e6d18da50
 2012-11-29 16:50:52 +09:00
Tadashi G. Takaoka
f90475b5d4 Make RoundedLine as top level class (Step 4) 
Change-Id: Id52baefb3d61eb46b3679e1ba3aa7ef7cd020efc
 2012-11-29 16:28:12 +09:00
Kurt Partridge
565b9d2add ResearchLogger add debugging code 
Change-Id: I03729506984f259dee63f3a66fd91963e3403d16
 2012-11-28 22:46:31 -08:00
Tadashi G. Takaoka
1a6d56e31d Consolidate point calculating and path creating methods into one (Step 3) 
Change-Id: Id49eee7c38595ea312dc9a63341a376825030035
 2012-11-29 14:28:59 +09:00
Tadashi G. Takaoka
8cfd64eed9 Make rounde line algorithm as instance method (Step 2) 
Change-Id: Ia6f41dc0ce7d3f3a1e4a8bbe838835cbdd94e6e9
 2012-11-29 14:22:30 +09:00
Tadashi G. Takaoka
0d034b3169 Consolidate data and algorithm of calculating rounded line (Step 1) 
Change-Id: Ic6d72b5a34ddfbc55317fa651f78af6f50c9a284
 2012-11-29 14:14:49 +09:00
Kurt Partridge
6c95f97a93 ResearchLogging fix password field collection 
password data collection was too "sticky"; the next field wouldn't be collected either.

Change-Id: I739a956f663cff33216f83ac453b2a89d8c33dde
 2012-11-28 19:15:12 -08:00
Tadashi G. Takaoka
359c35e0f6 Add CoordinateUtils class 
Change-Id: I23784117f77da54ee2a0670e65d86e26d762a687
 2012-11-28 19:03:28 +09:00
Tadashi G. Takaoka
2200dbbf09 Merge "Set additional subtypes before getting current subtype" 2012-11-27 22:22:31 -08:00
Tadashi G. Takaoka
85e397cd10 Set additional subtypes before getting current subtype 
Bug: 7594188
Change-Id: I1977acb7189f8eb186b9b20a3e5b64b4aaabf191
 2012-11-28 14:49:38 +09:00
Tadashi G. Takaoka
2db9e1c447 Fix typo in method name 
This is a follow up of I6f851248.

Change-Id: I3fe17f3c81ed35e7c38ac9701e73c6b2c1ca8d63
 2012-11-28 14:35:37 +09:00
Tadashi G. Takaoka
0567d144a3 am 7ba02315: am b172725c: am 7d045829: Request update shift state after shift-chording input 
* commit '7ba02315abf3f6fe2e40fcb248ccf1cab8dee179':
  Request update shift state after shift-chording input
 2012-11-27 11:36:53 -08:00
Tadashi G. Takaoka
7ba02315ab am b172725c: am 7d045829: Request update shift state after shift-chording input 
* commit 'b172725c8dc26bc96667135d1b17396f2a6257b4':
  Request update shift state after shift-chording input
 2012-11-27 11:34:00 -08:00
Tadashi G. Takaoka
72fd0968e5 Provide gesture data even if the finger stays still 
Bug: 7595187
Change-Id: I6f85124815f18706b2b2b5b5da2783dffd246e8c
 2012-11-27 18:33:16 +09:00
Tadashi G. Takaoka
b3f789799a Cancel gesture typing by sliding out from keyboard 
Bug: 7594165
Change-Id: I7849d763e49b57716e8418fb8b6f90eca3a5d2ec
 2012-11-22 17:49:56 +09:00
Tadashi G. Takaoka
befc1a05c9 Fix keyboard theme initializing bug 
Change-Id: If7037f3e0606ee34d1a6739cc39da23de18cc35c
 2012-11-22 11:41:53 +09:00
Tadashi G. Takaoka
7d045829b8 Request update shift state after shift-chording input 
Bug: 7529860
Change-Id: Iec82459348722be358ae2ded15deafac21749dcd
 2012-11-21 16:12:40 +09:00
Jean Chalard
e36af707c8 resolved conflicts for merge of b7e6bbae to master 
Change-Id: Ic02809190721472d138532d2189328519117e042
 2012-11-21 13:07:31 +09:00
Jean Chalard
b7e6bbaebc am 3acd0c7a: am f732f4dd: Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 
* commit '3acd0c7a9f4a5f17897a4fe51b023d6f14ba7ef0':
  Only add spaces automatically when appropriate.
 2012-11-20 19:38:47 -08:00
Jean Chalard
f732f4ddcc Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 2012-11-20 19:36:50 -08:00
Tadashi G. Takaoka
e44ce053e7 am 8a5b176f: am fd1267e3: Add Spanish United States keyboard (DO NOT MERGE) 
* commit '8a5b176f655a46f1c575886a7d3a3c1120c91b29':
  Add Spanish United States keyboard (DO NOT MERGE)
 2012-11-20 18:58:29 -08:00
Tadashi G. Takaoka
d2266d22c9 Merge "Reorganize currency keys" 2012-11-20 02:29:37 -08:00
Tadashi G. Takaoka
c27e899dbe Reorganize currency keys 
Add Rial(ar), Indian Rupee(hi), Tugrik(mn), Baht(th), Hryvnia(uk),
Dong(vi) currency sign keys to symbol layout.

Bug: 7455289
Change-Id: I0f819631ff05c4a31d3a6868dea5e18a1797f103
 2012-11-20 18:04:55 +09:00
Jean Chalard
c82c0d0ef2 Merge "Fix variation dumping." 2012-11-19 23:56:47 -08:00
Jean Chalard
4d0fa31779 Fix variation dumping. 
Variations are not flags - they should not be OR'd in this way.
Only one variation may be active at a time.

Change-Id: I9d3d4c8fc04af56c914c65f9c55f1e7b9517fc68
 2012-11-20 16:55:16 +09:00
Jean Chalard
ec60d60078 Only add spaces automatically when appropriate. 
Correctly check the variations to determine if we should
add automatic spaces (in manual picks and gestures) or not.

Bug: 7164981
Change-Id: I19e25af839b4062c217113cd804b1473912f22a5
 2012-11-19 19:47:40 +09:00
Tadashi G. Takaoka
76d4ffeebf Add Spanish United States keyboard 
The subtype locale name on the spacebar will be suppressed when only
one subtype is enabled and
 - Subtype locale is equal to the system locale.
or
 - Subtype language is equal to the system language but the subtype is
   implicitly enabled.

Thus the "es_ES" system locale chooses "es" subtype keyboard
implicitly but the keyboard doesn't have the subtype name on its
spacebar.

This change also removes Spanish Latin America keyboard.

Bug: 7531804
Change-Id: Ib929e8235d643c0ba039eb010e18ab721a734e15
 2012-11-19 15:39:44 +09:00
Tadashi G. Takaoka
fd1267e396 Add Spanish United States keyboard (DO NOT MERGE) 
Bug: 7531804
Change-Id: Idd66ee30e5228260540308a97c930185b48e775f
 2012-11-19 11:27:07 +09:00
Ken Wakasa
41a2c10e72 resolved conflicts for merge of 4ad92578 to master 
Change-Id: I29ad9f0ba357e39889e30c9ebfcf61f9d08ee4ef
 2012-11-17 11:33:48 +09:00
Ken Wakasa
4ad92578dd am 7acd310d: am f9ff4fb5: Merge "Revert "Only add spaces automatically when appropriate."" into jb-mr1.1-dev 
* commit '7acd310d02f060f3e3e29000db902dffb6b0df9c':
  Revert "Only add spaces automatically when appropriate."
 2012-11-16 18:05:42 -08:00
Ken Wakasa
f9ff4fb5da Merge "Revert "Only add spaces automatically when appropriate."" into jb-mr1.1-dev 2012-11-16 18:00:15 -08:00
Ken Wakasa
5986931fcb Revert "Only add spaces automatically when appropriate." 
This reverts commit 6ce66d1c7d

Change-Id: I90004a5fea0bc7999ecf8742f883ff4dac264d8a
bug: 7565414
 2012-11-16 17:49:22 -08:00
Marco Nelissen
ea23a28557 resolved conflicts for merge of 6f42cf1d to master 
Change-Id: I054bb0cfba9de06473100010a76e2f3d9c2c1180
 2012-11-16 11:23:33 -08:00
Jean Chalard
3a9f84a197 am 8c470f16: am 5dee6e69: am 187e683a: Merge "Fix a bug with some text fields" into jb-mr1.1-dev 
* commit '8c470f16db291e257ac538bd0ac2a9354d34010c':
  Fix a bug with some text fields
 2012-11-16 10:36:15 -08:00
Ken Wakasa
fe9ec6bc7d Remove unused variables 
Change-Id: Ia5079368a1bc86ccdf0052445dc6945041c0abca
 2012-11-16 19:28:56 +09:00
Jean Chalard
6f42cf1dee am 3dd4548e: am 191d49ae: Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 
* commit '3dd4548ec6105ca774e84ab3223bdbcea1e4902e':
  Only add spaces automatically when appropriate.
 2012-11-15 19:14:00 -08:00
Jean Chalard
191d49ae8a Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 2012-11-15 19:09:04 -08:00
Jean Chalard
6ce66d1c7d Only add spaces automatically when appropriate. 
Bug: 7164981
Change-Id: Id672104a0fda99c52923913fb0e40c3a1ead4787
 2012-11-15 17:57:16 +09:00
Jean Chalard
8c470f16db am 5dee6e69: am 187e683a: Merge "Fix a bug with some text fields" into jb-mr1.1-dev 
* commit '5dee6e69f1de114df1f258fdc62559237989dc75':
  Fix a bug with some text fields
 2012-11-14 20:40:33 -08:00
Jean Chalard
187e683aea Merge "Fix a bug with some text fields" into jb-mr1.1-dev 2012-11-14 20:37:19 -08:00
Tadashi G. Takaoka
0dfb89b41e am eea28db3: am d4886ff5: am 929bfdd0: Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 
* commit 'eea28db3333a734bf73e688b8335245929d5f322':
  Update shift state only when input field is restarted
 2012-11-14 16:34:42 -08:00
Tadashi G. Takaoka
eea28db333 am d4886ff5: am 929bfdd0: Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 
* commit 'd4886ff5419003c3bf996939ba87e4b49bcdbfae':
  Update shift state only when input field is restarted
 2012-11-14 16:33:20 -08:00
Tadashi G. Takaoka
dda024cf30 am 428d1b64: am 4826c3ff: Merge "Fix language switch key behavior (DO NOT MERGE)" into jb-mr1.1-dev 
* commit '428d1b6469b5bc9041c35a7e1ee1476d5aacedd7':
  Fix language switch key behavior (DO NOT MERGE)
 2012-11-14 16:33:19 -08:00
Tadashi G. Takaoka
929bfdd059 Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 2012-11-14 16:29:43 -08:00
Tadashi G. Takaoka
d0725a6842 Update shift state only when input field is restarted 
Bug: 7482766
Change-Id: Ifdfa110c44b95acfbcd3e0aa34f675c70b7d7285
 2012-11-14 18:44:43 +09:00
Tadashi G. Takaoka
4a3d4620fc Merge "Fix language switch key behavior" 2012-11-14 01:42:12 -08:00
Tadashi G. Takaoka
d62be28515 Fix language switch key behavior (DO NOT MERGE) 
Bug: 7075923
Change-Id: If139411db4aa65eed64337bf2a79387cfcd04496
 2012-11-14 18:29:01 +09:00
Tadashi G. Takaoka
1931c1cab1 Fix language switch key behavior 
Bug: 7075923
Change-Id: I306e1ff5d9f873541e84e1fafb64b9473947f623
 2012-11-14 18:27:00 +09:00
Tadashi G. Takaoka
ee672144c9 Merge "Swap single and double quotation marks in Spanish tablet keyboard" 2012-11-13 23:00:53 -08:00
Tadashi G. Takaoka
0d3eb7d963 Swap single and double quotation marks in Spanish tablet keyboard 
Bug: 6672279
Change-Id: I120613e36ba6a690e54447fa6c9c90e131f2a155
 2012-11-14 15:54:19 +09:00
Satoshi Kataoka
1ee6e14507 Hide statustics logging option 
Change-Id: I1ee258948a8335af7996f9e3afcc0508adbb1ac0
 2012-11-14 14:01:52 +09:00
Jean Chalard
00c0010ccf Fix a bug with some text fields 
Not sure when this happens exactly, but it is possible that
InputConnection#getTextBeforeCursor returns null. This
happens for example upon rotating the screen with the
composing field empty in Gmail.
In this case, StringBuilder#append will convert the null
pointer into the string "null", which is sure better than a
crash, but can have a number of bad side-effects, like
auto-caps not working.

Bug: 7533034
Change-Id: Ia1cfab432c13a12ff1c2f013c59bac05a587f553
 2012-11-14 12:22:40 +09:00
Jean Chalard
372f9da4f9 am 18ff5612: am f592270a: am 7648b37d: Merge "Make sure all FDs are correctly closed." into jb-mr1.1-dev 
* commit '18ff56125345746e288118d177fcabf3c079ead3':
  Make sure all FDs are correctly closed.
 2012-11-13 18:47:02 -08:00
Jean Chalard
18ff561253 am f592270a: am 7648b37d: Merge "Make sure all FDs are correctly closed." into jb-mr1.1-dev 
* commit 'f592270a0f092c5ef52bbb0f24c8873f46e75503':
  Make sure all FDs are correctly closed.
 2012-11-13 18:45:42 -08:00
Jean Chalard
7648b37d1e Merge "Make sure all FDs are correctly closed." into jb-mr1.1-dev 2012-11-13 18:42:35 -08:00
Jean Chalard
5c32b6da44 Make sure all FDs are correctly closed. 
In this kind of series of calls, it's possible that an outer call to a
constructor fails, but the inner succeeded.
Example:
try {
    is = new A(new B());
} finally {
    if (null != is) is.close();
}
In this case, if new B() succeeds but new A() throws an
exception, is stays null and the intermediate object is never
closed. This is what was happening in this instance.

Bug: 7377336
Change-Id: I3fae9fec1135244982fcf5098c76d93f3e0f2add
 2012-11-13 16:53:07 +09:00
Jean Chalard
80d7d32424 am d2116eb2: am 7d34763e: am fac619a3: Merge "Don\'t restrict reset composing state to non-identical setText" into jb-mr1.1-dev 
* commit 'd2116eb2ea7d08e81b7efe5e342772ffcd8a7efc':
  Don't restrict reset composing state to non-identical setText
 2012-11-12 23:48:20 -08:00
Jean Chalard
1b909c2846 Resolve conflicts for merge of 3a9ba17f to master" 
Change-Id: I8a1a84a81745a708f63e4211267c4afc3a6b8e49
 2012-11-13 16:34:23 +09:00
Jean Chalard
d2116eb2ea am 7d34763e: am fac619a3: Merge "Don\'t restrict reset composing state to non-identical setText" into jb-mr1.1-dev 
* commit '7d34763e23cb49c8c96dbf9b4c613e17098dd919':
  Don't restrict reset composing state to non-identical setText
 2012-11-12 23:04:39 -08:00
Jean Chalard
3a9ba17fd2 am a13a8a58: am 0e84041b: Refactor all phantom-space-inserted spaces in one place 
* commit 'a13a8a58e05ecd3f9eccdc47ceca972a814d247e':
  Refactor all phantom-space-inserted spaces in one place
 2012-11-12 23:04:37 -08:00
Jean Chalard
fac619a34c Merge "Don't restrict reset composing state to non-identical setText" into jb-mr1.1-dev 2012-11-12 23:00:12 -08:00
Jean Chalard
0e84041bf7 Refactor all phantom-space-inserted spaces in one place 
Bug: 7164981
Change-Id: If1635c212b2d5d9cf51f5fb074f3b20dd7ec7b2a
 2012-11-13 12:53:55 +09:00
Jean Chalard
61cc2a3391 Don't restrict reset composing state to non-identical setText 
Bug: 7497063
Change-Id: Ifbd5c37408131867458fd921bdef46ef90d81478
 2012-11-12 18:34:18 +09:00
Tadashi G. Takaoka
eaaee28647 Merge "Enhance ImfUtils to InputMethodManagerWrapper class" 2012-11-11 22:43:07 -08:00
Tadashi G. Takaoka
6fbbab3b84 Enhance ImfUtils to InputMethodManagerWrapper class 
Change-Id: I6ff86ee819a446dd3ed5f9c3400d23564027b020
 2012-11-12 15:23:43 +09:00
Tadashi G. Takaoka
21177c1afe Remove gesture typing settings when disabled by configuration 
Bug: 7506408
Change-Id: I4de53ace170d5ddc9779f42ac344c4190c80a019
 2012-11-09 07:58:27 -08:00
Jean Chalard
01d47b8096 Fix a logic flaw. 
This test is seriously wrong : although we do have a method that
does exactly the right thing, this looks at a very specific, unrelated
variable state in hope it happens to be set only in the relevant
cases by the play of logic.
I don't think this changes anything concretely, as the assumption
was probably true in the practice ; still, this code is very hard to
read and prone to unexpected breakage.

Change-Id: I77ab576f90762429fcc752df31ed30e1c81871dc
 2012-11-09 19:16:37 +09:00
Ken Wakasa
710d06cea9 Suppress dictionary pack support when IS_EXPERIMENTAL is true 
Change-Id: If8813cb989c1fa8744a3bf36e8514ced3c8f46a3
 2012-11-09 15:03:31 +09:00
Tadashi G. Takaoka
c43ff6f66c Remove gesture typing settings when disabled by configuration 
Bug: 7506408
Change-Id: I4de53ace170d5ddc9779f42ac344c4190c80a019
 2012-11-09 12:44:40 +09:00
Ken Wakasa
43f579e9f6 am 4eef5101: am aa5d6fe0: am 9cc22c45: am 5d2556b9: Reset the IME if requested by the app. 
* commit '4eef51016adc4e103fa65d944a0ab31527ddced8':
  Reset the IME if requested by the app.
 2012-11-08 06:22:02 -08:00
Ken Wakasa
4eef51016a am aa5d6fe0: am 9cc22c45: am 5d2556b9: Reset the IME if requested by the app. 
* commit 'aa5d6fe05ce45e36b732a3abc849508cd8279257':
  Reset the IME if requested by the app.
 2012-11-08 06:12:57 -08:00
Ken Wakasa
5d2556b932 Reset the IME if requested by the app. 
Specifically, reset the KeyboardState to the main Alphabet layout in
LatinIME.onStartInputViewInternal() if a keyboard layout set doesn't get
reloaded in the method.

Please note TextView.setText() calls up resetInput(), then the IME should
reset with it.

bug: 7482086

Note that bug: 6851364 needs to be revisited.

Change-Id: I5d448c10963d3dd952dd13cb587085ec7b014e69
 2012-11-07 01:09:26 +09:00
Tadashi G. Takaoka
a47a777476 Merge "Cleanup logging code" 2012-11-01 02:15:24 -07:00
Tadashi G. Takaoka
fca71cfddb Cleanup logging code 
Change-Id: Ia604a4fcebfc5179bdbeaa982e052f7d3882ac6e
 2012-11-01 17:03:35 +09:00
Tadashi G. Takaoka
93b5c2ce63 Make sure PointerTrackerQueue is non-null 
Change-Id: I2106cf64bed1472fb39d24e7e5bdee7238a30bfe
 2012-11-01 15:26:06 +09:00
Tadashi G. Takaoka
081fedc422 Rename SuddenJumpingTouchEventHandler to TouchSCreenRegulator 
Change-Id: Ia4fb5b3612ff78ed1b243c80a03294b829470f5c
 2012-11-01 14:56:32 +09:00
Tadashi G. Takaoka
ffb0c093d1 Merge "Move isInvalidCordinates() method to Constants class" 2012-10-31 21:24:01 -07:00
Tadashi G. Takaoka
d80286642a Merge "Cosmetic source code formating change" 2012-10-31 21:23:49 -07:00
Tadashi G. Takaoka
0c8a08c141 Merge "Straighten an if-else-if blocks into if-return blocks" 2012-10-31 21:23:35 -07:00
Tadashi G. Takaoka
a232930d9c Straighten an if-else-if blocks into if-return blocks 
Change-Id: If3eede1257658f27384e3efc72586fabbed19f7b
 2012-11-01 13:14:19 +09:00
Tadashi G. Takaoka
24ab8055aa Move isInvalidCordinates() method to Constants class 
Change-Id: Iad1464c299ad6055af1db1ff7978e5cd9a14750f
 2012-11-01 13:12:58 +09:00
Tadashi G. Takaoka
20dd1bc090 Cosmetic source code formating change 
Change-Id: I3a53b49afab70dfb13f12027070635da6001eb79
 2012-11-01 13:10:44 +09:00
Tadashi G. Takaoka
13ae76d7a3 Cleaup non-distinct multitouch related stuff 
Change-Id: I09072267217caad2513f83b61d7db1c6d74e18d1
 2012-11-01 13:04:49 +09:00
Ken Wakasa
1e61493c50 Use 32-bit code points for suggestions output 
This is a multi-project commit with Ic43dd666

bug: 6526418
Change-Id: I39c1acb4e91d04cd8a4ec5a943c8cf575da75ebc
 2012-11-01 00:09:51 +09:00
Tadashi G. Takaoka
0ea2c80d8d Merge "Consolidate two helper methods (refactor step 3)" 2012-10-31 03:58:47 -07:00
Tadashi G. Takaoka
661bc810e5 Merge "Flatten nested if-else blocks into plain if-else blocks (refactor step 2.5)" 2012-10-31 03:46:05 -07:00
Tadashi G. Takaoka
831198a4e4 Consolidate two helper methods (refactor step 3) 
Change-Id: I8b8522d1e5342fc73346ba2748e75f0c1d5bf03c
 2012-10-31 19:45:29 +09:00
Tadashi G. Takaoka
2a3b15b267 Flatten nested if-else blocks into plain if-else blocks (refactor step 2.5) 
Change-Id: I42aad04658e14e8fd703e3828676719a333ec8f9
 2012-10-31 19:44:45 +09:00
Tadashi G. Takaoka
8ae9fbef77 Merge "Separate nested if-blocks into helper methods (refactor step 2)" 2012-10-31 03:43:27 -07:00
Tadashi G. Takaoka
3c6d3a4df8 Separate nested if-blocks into helper methods (refactor step 2) 
Change-Id: Ic0ed243f8c1fbf62793565ee37175270b47f0801
 2012-10-31 19:34:43 +09:00
Tadashi G. Takaoka
dd43dd61eb Merge "Separate nested if-blocks into helper methods (refactor step 1)" 2012-10-31 03:18:08 -07:00
Tadashi G. Takaoka
8b449c6dda Separate nested if-blocks into helper methods (refactor step 1) 
Change-Id: I87ef8b174295fb12a91fec35acd3b0cc152ad8f0
 2012-10-31 18:40:28 +09:00
Jean Chalard
51a0ef8c59 Add a plumbing option to dicttool info. 
Also align the `porcelain' option to the diff command
that was used mistakenly.

Bug: 7388665
Change-Id: Ic0e1b98c62ce37b2e909384a0370af4458563703
 2012-10-31 16:35:22 +09:00
Tadashi G. Takaoka
c7318bbc0b Fix possible NPE 
Bug: 7398904
Change-Id: I6b7aba7a9bf52ca494cb4390b19525c98790bd49
 2012-10-29 18:40:37 +09:00
Tadashi G. Takaoka
cfbfb1c50a Remove reference of android.util.Log in Constants class 
This is a follow up of Iee01d4d2.

Change-Id: I0bcd349d317d9f7d40ef0574e72c640f9f990c5d
 2012-10-29 17:25:13 +09:00
Tadashi G. Takaoka
7947eaf475 Merge "Move code point constants from Keyboard to Constants class" 2012-10-29 00:10:52 -07:00
Tadashi G. Takaoka
240871ecaf Move code point constants from Keyboard to Constants class 
Change-Id: Iee01d4d2b916d0b584531104ac865ae6e6370a3d
 2012-10-29 16:04:20 +09:00
Jean Chalard
f41389a74b Remove warnings 
Thanks Eclipse

Change-Id: I88e3979ed22be5d8be5a5accdde417c6b1a8bf2d
 2012-10-29 14:24:16 +09:00
Jean Chalard
a23e333079 Implement the word-level diff (A9) 
Bug: 7388857
Change-Id: I4c4560d4f4b579936a44cdf409a4c27300b65610
 2012-10-29 12:31:22 +09:00
Ken Wakasa
d505319a25 am 5199b8bf: am f6df37ce: Merge "LatinIME: Add accents to german keyboard" 
* commit '5199b8bf1a212b93c9f37d4bb18121ba7f174bd0':
  LatinIME: Add accents to german keyboard
 2012-10-25 23:13:48 -07:00
Ken Wakasa
5199b8bf1a am f6df37ce: Merge "LatinIME: Add accents to german keyboard" 
* commit 'f6df37ce2dce9ada1af097e0c2fbdd84c0334c61':
  LatinIME: Add accents to german keyboard
 2012-10-25 23:11:21 -07:00
Satoshi Kataoka
6067b9e1bd am ef5f88f3: am 5e118c4c: am 60dea36d: Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
* commit 'ef5f88f33e432284c958fafe18f891a10f77e1f9':
  Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
 2012-10-25 19:31:27 -07:00
Satoshi Kataoka
60dea36daf Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
Bug: 7393485
Bug: 7272829
Change-Id: I873e8d99486c734e76484526631a90fc55e91c86
 2012-10-25 20:00:46 +09:00
Jean Chalard
47cac57e45 Finish up the "info" command in dicttool. (A6) 
Bug: 7388857
Change-Id: I704f12a6be76ce1644ec5e8dd3b667f112e9c04a
 2012-10-25 19:15:24 +09:00
Jean Chalard
b3c98901c5 Add auto detection and decoding of dictionary files. (A2) 
Bug: 7388852
Change-Id: I25e755fc15f5b383acc046f668e9681efa4f0c2f
 2012-10-25 16:40:15 +09:00
Jean Chalard
ddb0bcc051 Fix a bug where a bigram would be ignored 
Bug: 7403386
Change-Id: I89f495d07f7059a9f1ccd97d487c2f2657a8ebd2
 2012-10-24 13:24:59 +09:00
Jean Chalard
5e5be5a2d2 Merge "Return the correct bigram frequency" 2012-10-23 01:19:28 -07:00
Jean Chalard
c59c741987 Return the correct bigram frequency 
The "correct" bigram frequency is now returned by the reading
code. However, as the binary format represents the frequency
in a lossy manner, the frequency is not guaranteed to be the
exact same as the one in the source text format - only a close
enough value. It is however the exact same value seen by the
native code.

Bug: 7395653
Change-Id: I49199ef18901c671189912b3550623e9643baedd
 2012-10-23 17:17:37 +09:00
Jean Chalard
1e0cc86b6f Fix the build. 
It seems this change snuck out from a previous version.

Change-Id: I9c33d51273732b1d55bfd60f0957184c86fa88ab
 2012-10-23 15:34:42 +09:00
Jean Chalard
c7020f54f9 Merge "Add reader and writer for the combined dict format." 2012-10-22 23:11:20 -07:00
Jean Chalard
9bb4eebf48 Add reader and writer for the combined dict format. 
This introduces a new textual format for the dictionary that combines
words, bigrams and shortcuts to avoid complexity. It is also extensible
to n-grams to fool-prof for the future, and easier to read than XML.

Bug: 7388540
Change-Id: I942bbad51bd0c905a5a54c278667563fd6dd66ec
 2012-10-23 15:06:25 +09:00
Jean Chalard
751f3dc0e1 am 6fe6f38d: am d39e6435: am f960eb18: Don\'t put spaces after characters that don\'t take one 
* commit '6fe6f38d8af09b24e40a6e01eae919820cd04c16':
  Don't put spaces after characters that don't take one
 2012-10-22 21:46:43 -07:00
Jean Chalard
f960eb186d Don't put spaces after characters that don't take one 
Bug: 7393639
Change-Id: I1245a7b5077e554642838d6856ce269ca7f91988
 2012-10-23 12:28:28 +09:00
Tadashi G. Takaoka
7f77aed507 Merge "Replace useless CharSequence to String" 2012-10-22 14:27:35 -07:00
Kim Le
82a6f66783 LatinIME: Add accents to german keyboard 
This fixes http://code.google.com/p/android/issues/detail?id=26247

Add
// U+00E9: "é" LATIN SMALL LETTER E WITH ACUTE
// U+00E8: "è" LATIN SMALL LETTER E WITH GRAVE
// U+00EA: "ê" LATIN SMALL LETTER E WITH CIRCUMFLEX
// U+00EB: "ë" LATIN SMALL LETTER E WITH DIAERESIS

Change-Id: I81d79f153cdfe7015bd0a343c681322ab8316db7
 2012-10-22 22:19:08 +02:00
Tadashi G. Takaoka
15f6d4ae34 Add @UsedForTesting and @ExternallyReferenced annotations 
Bug: 7268357
Change-Id: I0b7e0c19f04af9ae30874d0a4c26ad81bc80be8c
 2012-10-22 11:18:43 -07:00
Tadashi G. Takaoka
bc464e2952 Replace useless CharSequence to String 
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
 2012-10-22 11:03:28 -07:00
Tadashi G. Takaoka
5faf419519 Suggestion strip will honor haptic feedback settings of keyboard 
Bug: 7313372
Change-Id: I427da8de68be3d2a78e810556340b96ab4edcc2d
 2012-10-17 21:40:02 -07:00
Tadashi G. Takaoka
8e360c68f1 Move AudioAndHapticFeedbackManager from LatinIME to KeyboardSwitcher 
Bug: 7313372
Change-Id: I9bd3275f57ed3f5c2c4a95768443af505513ee97
 2012-10-17 19:39:16 -07:00
Tadashi G. Takaoka
723d32ad6e Shortcut key is enabled on the no language keyoard 
Bug: 6617754
Change-Id: Id8336f152456367320de3151823691eebc2e02f6
 2012-10-17 16:27:43 -07:00
Jean Chalard
c5dc32ac59 am b37e87e7: am 63b3fc0d: am 15142588: Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 
* commit 'b37e87e7d50725f20a6b2f8484fc25cc7db3134f':
  Have "no whitespace before cursor" upon gesture trigger phantom space
 2012-10-16 18:12:50 -07:00
Jean Chalard
1514258824 Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 2012-10-16 18:06:11 -07:00
Jean Chalard
e91d495c53 Have "no whitespace before cursor" upon gesture trigger phantom space 
Bug: 7359291
Bug: 7357758
Bug: 7197651
Change-Id: Ia805a87e922739ae0a06978a3bf00d91c94b6c51
 2012-10-17 09:36:07 +09:00
Tadashi G. Takaoka
788c885aa5 am 344a7fef: am 658e935b: am c0bc3369: Merge "Fix more suggestions text width calculation" into jb-mr1-dev 
* commit '344a7fef5bd101e2d1c4278cc35de2862f28a456':
  Fix more suggestions text width calculation
 2012-10-16 17:32:00 -07:00
Tadashi G. Takaoka
477088c612 am 6b169dc9: am 718a0744: am 0cbc19b0: Merge "Restrict bogus move event detector to a horizontal movement" into jb-mr1-dev 
* commit '6b169dc91d7533d36bc1f5864bcaf05450af3beb':
  Restrict bogus move event detector to a horizontal movement
 2012-10-16 17:31:56 -07:00
Jean Chalard
fa3d984d1b am 60211f0d: am 2631fe4c: am 6686e63f: Honor automatic shift turned off for gestures 
* commit '60211f0d250ca931788d32d5a69c880f75ef7d49':
  Honor automatic shift turned off for gestures
 2012-10-16 17:28:18 -07:00
Tadashi G. Takaoka
c0bc336955 Merge "Fix more suggestions text width calculation" into jb-mr1-dev 2012-10-16 17:24:35 -07:00
Tadashi G. Takaoka
0cbc19b0b1 Merge "Restrict bogus move event detector to a horizontal movement" into jb-mr1-dev 2012-10-16 17:24:23 -07:00
Tadashi G. Takaoka
d631778e1c Restrict bogus move event detector to a horizontal movement 
The bogus move detection threshold is in proportional to a diagonal
length of a key. It was in proportional to a key width.

Bug: 7346614
Change-Id: I796add8aea16dd05e9844d6c4fba8072eece39c6
 2012-10-16 14:53:54 -07:00
Tadashi G. Takaoka
bdc8b9e42b Fix more suggestions text width calculation 
Bug: 7345983
Change-Id: Ic1554db98e7aaf032eb90a98c0c37c7c789461b5
 2012-10-16 14:24:30 -07:00
Jean Chalard
6686e63f21 Honor automatic shift turned off for gestures 
Bug: 7354129
Change-Id: Ia02336e8cea2f04b629edbe74b7815cce0d7fad6
 2012-10-17 05:41:06 +09:00
Tadashi G. Takaoka
dd7db83423 am a13087e1: am 9c318bc5: am ac2a154a: Merge "Detect bogus down-move-up event and add workaround" into jb-mr1-dev 
* commit 'a13087e1abf48f8599795b9abb4f49a596a6f32c':
  Detect bogus down-move-up event and add workaround
 2012-10-12 11:14:00 -07:00
Tadashi G. Takaoka
ac2a154ae8 Merge "Detect bogus down-move-up event and add workaround" into jb-mr1-dev 2012-10-12 06:59:42 -07:00
Tadashi G. Takaoka
b0952888eb Detect bogus down-move-up event and add workaround 
Bug: 7032858
Change-Id: I2e76bf49f1e07b436d05c19881e2f2c4fed21621
 2012-10-12 20:45:08 +09:00
Jean Chalard
01e0913ad2 Make a better choice for the temporary file 
Change-Id: I745bb285b6b52875c8d2b3a94deb962352f9754e
 2012-10-12 19:58:07 +09:00
Ken Wakasa
b0aa9606ae am 726e98b7: am c1a1937c: am 2220aeed: Merge "Put temporary files under a separate directory." into jb-mr1-dev 
* commit '726e98b7378987b2cfe46ea5395692640b108e83':
  Put temporary files under a separate directory.
 2012-10-11 08:41:42 -07:00
Ken Wakasa
2220aeedfe Merge "Put temporary files under a separate directory." into jb-mr1-dev 2012-10-11 08:36:22 -07:00
Jean Chalard
66c90cd2ae Put temporary files under a separate directory. 
Bug: 7328003
Change-Id: Ibe5278ea209d149f87fd08785c77b17e3859948e
 2012-10-11 17:53:06 +09:00
Tadashi G. Takaoka
ad181915f7 Fix excessive canceling of long-press timer while gesturing 
Change-Id: I2a68c777e66a6b83d16885780a92a21e91bd3f9e
 2012-10-11 17:51:45 +09:00
Tadashi G. Takaoka
c1f2c3a646 am c66a2d1d: am 61155c70: am 9d423536: Merge "Don\'t cancel long press timer too early" into jb-mr1-dev 
* commit 'c66a2d1da69de796a2a7acb5dd6903cb5668585c':
  Don't cancel long press timer too early
 2012-10-11 00:52:05 -07:00
Tadashi G. Takaoka
c9ba26994b Don't cancel long press timer too early 
Bug: 7328861
Change-Id: I1b77ec4a30ae15b2edda42a1ff58ebc528288553
 2012-10-11 15:58:56 +09:00
Ken Wakasa
06636bf96a am 0081681e: am c44314b4: am dc38a343: Merge "Use a freq of 1 instead of 0 for non-word shortcuts." into jb-mr1-dev 
* commit '0081681e346ce5c958e5eef264caa3f257b094c5':
  Use a freq of 1 instead of 0 for non-word shortcuts.
 2012-10-09 07:48:46 -07:00
Tadashi G. Takaoka
4020289147 am 6b0fa314: am f5c10d00: am 7a17c1fc: Tuning gesture detection parameters 
* commit '6b0fa314d780ea77bd2c65b9bdd87297d50a0f6b':
  Tuning gesture detection parameters
 2012-10-09 07:48:45 -07:00
Ken Wakasa
dc38a3438b Merge "Use a freq of 1 instead of 0 for non-word shortcuts." into jb-mr1-dev 2012-10-09 07:43:16 -07:00
Tadashi G. Takaoka
11cec73499 Merge "Disable touch position correction of MoreKeysKeyboard" 2012-10-09 03:39:43 -07:00
Tadashi G. Takaoka
f9aa99c1c9 Disable touch position correction of MoreKeysKeyboard 
Change-Id: Ieec33894a348602fd71d6fe473142b43eb2551b6
 2012-10-09 19:20:28 +09:00
Jean Chalard
99b84b42f9 Use a freq of 1 instead of 0 for non-word shortcuts. 
Also fix a spelling mistake in a comment

Bug: 7301525
Change-Id: I4437403dce620fed03871485ee04f13c51ce34fc
 2012-10-09 19:16:07 +09:00
Tadashi G. Takaoka
7a17c1fcb5 Tuning gesture detection parameters 
Bug: 7032858
Change-Id: Ie4f952aa33b99ce16027500a596d723ee9bafae9
 2012-10-09 19:06:10 +09:00
Tadashi G. Takaoka
7cbb7f92ee Merge "Allow to start gesture from a non-letter key except from a modifier key" 2012-10-09 02:20:28 -07:00
Tadashi G. Takaoka
4df6549c1a Allow to start gesture from a non-letter key except from a modifier key 
Bug: 7303982
Change-Id: Id54965c1d7b2b760ac2a76a0fc509b46948e75e6
 2012-10-09 18:03:40 +09:00
Ken Wakasa
b02ee3d67a Make use of the NELEMS and KEYCODE_SPACE macro. Also, remove an unused parameter. 
Change-Id: I3c7e6c59990c92b0d5e2fb80493e8673cdd37b09
 2012-10-09 11:17:50 +09:00
Tadashi G. Takaoka
3efe5f386f am bb249cb9: am b1583b9e: am 052b162d: Merge "Add separate key hysteresis distance for sliding modifier input" into jb-mr1-dev 
* commit 'bb249cb992941ea0f3b6b962232ead147011865a':
  Add separate key hysteresis distance for sliding modifier input
 2012-10-07 09:09:59 -07:00
Ken Wakasa
fc62882591 Fix a small typo 
Change-Id: I813d97b9453f8aa7aae99bd165336b1e5a81dc6a
 2012-10-07 12:05:23 +09:00
Tadashi G. Takaoka
052b162df6 Merge "Add separate key hysteresis distance for sliding modifier input" into jb-mr1-dev 2012-10-06 10:43:04 -07:00
Tadashi G. Takaoka
f731eb1760 Add separate key hysteresis distance for sliding modifier input 
Bug: 7294402
Change-Id: I78c8be9e1a7b2d49d86bfe1e3a46d1785bfe5d48
 2012-10-07 01:19:01 +09:00
Tadashi G. Takaoka
792980d4aa Avoid calling switchToLastInputMethod when other IMEs are in effect (DO NOT MERGE) 
Bug: 7299050
Change-Id: Ife6721a5fcbc4872bd36ffd8a8b81b04d73aebec
 2012-10-06 19:01:36 +09:00
Tadashi G. Takaoka
9778ac3fdd am d7345ed0: am d34422f1: am 3623b976: Fix detecting fast typing algorithm and parameter 
* commit 'd7345ed0b532eaa2082adea6fb5e89f5fe0acb86':
  Fix detecting fast typing algorithm and parameter
 2012-10-05 03:22:09 -07:00
Tadashi G. Takaoka
3623b9767b Fix detecting fast typing algorithm and parameter 
Bug: 7032858
Change-Id: I5ed701e2394d16e43258a3c22d59991cb18adce8
 2012-10-05 18:23:39 +09:00
Ken Wakasa
035b260058 Merge "fix writeCharGroup." 2012-10-04 23:05:51 -07:00
Yuichiro Hanada
d2579c4832 fix writeCharGroup. 
Change-Id: Ib841afaba0a20c3b300eb7d3e9133243f9f3ae58
 2012-10-05 14:54:17 +09:00
Tadashi G. Takaoka
ddf8b9e1ea am 24ebf7da: am b02fc3fc: am 4580b7e4: Merge "Move gesture detection and recognition paramters to resources" into jb-mr1-dev 
* commit '24ebf7da9853f2975bf1ae3e11c0cf1962236667':
  Move gesture detection and recognition paramters to resources
 2012-10-04 22:54:16 -07:00
Tadashi G. Takaoka
80bcb99632 Move gesture detection and recognition paramters to resources 
Bug: 7032858
Change-Id: I66570a5e21cdeede1eba420c597f440ab61aa941
 2012-10-05 14:39:44 +09:00
Ken Wakasa
feac8a91f9 am 933e7c37: am 37c8f8b5: am 20f07e33: Merge "Unlink an old file before moving the new file over it" into jb-mr1-dev 
* commit '933e7c3770c00a9eea43c447d96daec1ada62041':
  Unlink an old file before moving the new file over it
 2012-10-04 15:40:20 -07:00
Ken Wakasa
20f07e335d Merge "Unlink an old file before moving the new file over it" into jb-mr1-dev 2012-10-04 15:33:41 -07:00
Jean Chalard
daff19bc29 am d173ed18: am bf6c8bd8: am 3f7fe829: Merge "Always consider a new line the start of a sentence" into jb-mr1-dev 
* commit 'd173ed18e44ea5cdc48d5f620bb91efcd3ed5174':
  Always consider a new line the start of a sentence
 2012-10-04 06:00:45 -07:00
Jean Chalard
2699b45dbc Always consider a new line the start of a sentence 
Bug: 7282523
Change-Id: I10a73e99efdfe6acb9a16819694b98c6714fd451
 2012-10-04 20:54:28 +09:00
Yuichiro Hanada
3c6d9fe148 Add insertWord. 
bug: 6669677

Change-Id: Ide55a4931071de9cd42c1cddae63ddd531d2feba
 2012-10-04 17:19:47 +09:00
Jean Chalard
c15726482e Unlink an old file before moving the new file over it 
This is unlikely to be relevant to this bug, but just in case.

Bug: 7274972
Change-Id: I56b31b377af16cc2c15ceb90a19792bed3aab367
 2012-10-04 15:49:08 +09:00
Yuichiro Hanada
c3a98ca306 Add writeNode. 
Change-Id: I088bb6ea43ce0841d725e48b677d429e1155569d
 2012-10-04 14:28:42 +09:00
Yuichiro Hanada
38712ff27d Add updateParentAddresses. 
Change-Id: Iac210131b7c003ef363e1138bf22f777a37c6a89
 2012-10-03 19:37:17 +09:00
Yuichiro Hanada
a853356b82 Add isDeletedGroup. 
Change-Id: I83f09c068868e5e6e1b46f494a6ef957f0b466d8
 2012-10-03 02:19:41 -07:00
Yuichiro Hanada
7223cc2ef1 Add MAX_BIGRAMS_IN_A_GROUP. 
Change-Id: I128d5deb8e523045d7ad77d7a8fd3db944f71238
 2012-10-03 18:10:06 +09:00
Satoshi Kataoka
69c787f3b7 am 96717371: am e8825ce3: am 1fd10ea2: Merge "Throw illegal argument exception in BinaryDictionary::editDistance" into jb-mr1-dev 
* commit '967173711f17ba30d3608881f501985f07fef4fd':
  Throw illegal argument exception in BinaryDictionary::editDistance
 2012-10-03 01:21:43 -07:00
Satoshi Kataoka
1fd10ea22c Merge "Throw illegal argument exception in BinaryDictionary::editDistance" into jb-mr1-dev 2012-10-03 01:15:52 -07:00
Satoshi Kataoka
66d955ad71 Throw illegal argument exception in BinaryDictionary::editDistance 
Bug: 7276803
Change-Id: Icd9bdec0a04179a29d00336819d205627f77b71a
 2012-10-03 17:15:47 +09:00
Tadashi G. Takaoka
c6ff7c42d9 Add SuggestedWords.isEmpty() method 
Change-Id: I0fcb104a6a81aee4b99f5ee848eba7495630dc7d
 2012-10-03 15:09:10 +09:00
Tadashi G. Takaoka
3e5a3c18be Add final modifier to the classes under suggestions sub-package 
Change-Id: I19fc8eaac1aebef9cf4deb004e78484ff9a1e7ca
 2012-10-03 14:57:29 +09:00
Tadashi G. Takaoka
5f5f7825e7 am 4d009dbc: am ace7d128: am d445b56c: Fix possible NPE caused while monkey test 
* commit '4d009dbc514cd77eb22e4162e4ae7ea852e1b77e':
  Fix possible NPE caused while monkey test
 2012-10-02 22:44:57 -07:00
Yuichiro Hanada
4ad4ff618f Add makeCharGroupFlags. 
Change-Id: Id2c580f21b77f66a97c5fbdf4542fdafe6c43614
 2012-10-03 14:33:59 +09:00
Tadashi G. Takaoka
d445b56ce1 Fix possible NPE caused while monkey test 
Bug: 7269036
Change-Id: I9054b33ad3c8996cac3ee5f0e9c01ba8ceea4971
 2012-10-03 14:33:52 +09:00
Tadashi G. Takaoka
c3aea8ea9f Merge "Avoid calling switchToLastInputMethod when other IMEs are in effect" 2012-10-02 01:36:37 -07:00
Tadashi G. Takaoka
aec5cc8476 Avoid calling switchToLastInputMethod when other IMEs are in effect 
Bug: 7268389
Change-Id: I4d960cbf063002b4dc0ea813c966366b56c0346d
 2012-10-02 17:29:15 +09:00
Tadashi G. Takaoka
fe3fb2502d am 58e1be74: am de102ede: am 15281adb: Show gesture floating preview text by default 
* commit '58e1be74a989637b0b71ebf990ed1b3c9a21e7af':
  Show gesture floating preview text by default
 2012-10-01 23:41:38 -07:00
Tadashi G. Takaoka
15281adbc1 Show gesture floating preview text by default 
Bug: 7244214
Change-Id: Ib4ab810ef50798828dd10c39a8077466165772e4
 2012-10-01 21:23:00 -07:00
Jean Chalard
37688ae8c1 am 86db54df: am 137203d4: am 574b80aa: Remove debug prints. 
* commit '86db54df74b821a15f7a3081c3737f8a63f91214':
  Remove debug prints.
 2012-10-01 13:46:16 -07:00
Yuichiro Hanada
7f438aa12f Make writeCharGroup return a size of a new group. 
bug: 6669677

Change-Id: I56f6a07b04b08443f2c052927404318c2018fc9d
 2012-10-01 22:02:04 +09:00
Ken Wakasa
00e1d421c2 Merge "Add writeCharGroup." 2012-10-01 05:53:24 -07:00
Yuichiro Hanada
fb7e08ea8f Add writeCharGroup. 
bug: 6669677

Change-Id: I36792ba9c511a5148c963096cc93ca8c2e0ee04e
 2012-10-01 21:50:38 +09:00
Jean Chalard
574b80aace Remove debug prints. 
Bug: 7226098
Change-Id: Ibacb740022a6af56c9d555d6797dd402a89f6ca4
 2012-10-01 17:03:15 +09:00
Tadashi G. Takaoka
7339a62a13 Fix NPE observed only by monkey test 
Bug: 7258660
Change-Id: I286c704b32efeada8505d953438f2595166f7e8f
 2012-10-01 14:55:18 +09:00
Tadashi G. Takaoka
99501896f5 am 9925e487: am 6052a81e: Merge "Fix gesture detection algorithm" into jb-mr1-dev 
* commit '9925e487b345e4a63d3dc25e3bf156e0fbfbb04d':
  Fix gesture detection algorithm
 2012-09-28 06:54:04 -07:00
Tadashi G. Takaoka
6052a81e08 Merge "Fix gesture detection algorithm" into jb-mr1-dev 2012-09-28 06:49:24 -07:00
Tadashi G. Takaoka
58fe5a421f Fix gesture detection algorithm 
This change also
  * Introduces adaptive gesture detecting threshold for time domain in addition to length domain.
  * Tunes the parameters for detecting gesture after fast typing.
  * Fixes a bug in dismissing gesture floating preview text.
  * Cleanup debug messages

Bug: 7218902
Change-Id: Iafccd872c6efe0c3b5ae65fa40b04c80d9f139c7
 2012-09-28 22:47:55 +09:00
Tadashi G. Takaoka
11dbf025c6 am 2626bf08: am c8f25294: Merge "Temporarily suppress key popup preview after gesture input" into jb-mr1-dev 
* commit '2626bf0889af798e484824737e9973ffb447498f':
  Temporarily suppress key popup preview after gesture input
 2012-09-28 03:42:38 -07:00
Tadashi G. Takaoka
c8f252940f Merge "Temporarily suppress key popup preview after gesture input" into jb-mr1-dev 2012-09-28 03:38:20 -07:00
Ken Wakasa
b88c8ac8e4 Merge "Add updateChildrenAddress." 2012-09-28 03:18:18 -07:00
Tadashi G. Takaoka
29d2d48182 Temporarily suppress key popup preview after gesture input 
Bug: 7244317
Change-Id: I39cdb0fbda51f3e4339301d9cc53403b1ad15409
 2012-09-28 19:10:56 +09:00
Yuichiro Hanada
f3aed3ea26 Add updateChildrenAddress. 
Change-Id: Ic06a755d85612476e719e580469dc1cd9447286c
 2012-09-28 18:45:56 +09:00
Tadashi G. Takaoka
ad6b493c16 Merge "Remove dead code for disabling gesture input after fast typing" into jb-mr1-dev 2012-09-28 00:47:05 -07:00
Tadashi G. Takaoka
bf538ab2c0 Remove dead code for disabling gesture input after fast typing 
Bug: 7218902
Change-Id: Iccc1d4cf0dd3ac84b30c68e11eee9a6ad89f14c4
 2012-09-28 16:15:51 +09:00
Yuichiro Hanada
7a7d117aa7 Ignore the broken file. 
bug: 7249561

Change-Id: If001bf75ef12b4d342a77e54706c7fed90c89afb
 2012-09-28 14:19:14 +09:00
Tadashi G. Takaoka
a28a05e971 Cleanup: Make some classes as final 
Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
 2012-09-27 19:03:30 +09:00
Tadashi G. Takaoka
1775201671 Calculate default touch position correction data for keys on 4th row 
This change also disables touch position correction for Phone/Dvorak
keyboard.

Bug: 7243101
Change-Id: Idfcc7ad1feabbe6a81635dceba5be087401fa18b
 2012-09-27 17:55:58 +09:00
Yuichiro Hanada
84d858ed5e Use BinaryDictInputOutput to save UserHistoryDictionary. 
bug: 6669677

Change-Id: I08193c26f76dbd48168f8ac02c1b737525bfc7b2
 2012-09-27 12:02:17 +09:00
Tadashi G. Takaoka
c0a1dc0e07 Merge "Draw gesture trail that is above the keyboard" into jb-mr1-dev 2012-09-26 05:01:18 -07:00
Tadashi G. Takaoka
157fe98fd4 Draw gesture trail that is above the keyboard 
Bug: 7233992
Change-Id: Ia848543a9d008c68d6ecbc7f715aa6ccdba9d1c6
 2012-09-26 20:43:13 +09:00
Yuichiro Hanada
2aea34fb31 Add updateParentAddress. 
bug: 6669677

Change-Id: I353f8ae53720cdf7a809271a28cb703709609f53
 2012-09-26 17:18:01 +09:00
Yuichiro Hanada
2ee70804e9 Add moved char groups. 
bug: 6669677

Change-Id: I372f841044fe8e076a50a80ac10b715e5f8fd4eb
 2012-09-26 17:01:48 +09:00
Tadashi G. Takaoka
1c820c4146 Merge "Don't cancel gesture trail update drawing" into jb-mr1-dev 2012-09-25 22:50:50 -07:00
Tadashi G. Takaoka
1645902cce Postpone gesture start detection on non-letter key 
Bug: 7108223
Change-Id: Ie1ead5cec947ddf86c5150dca5b20b224527e511
 2012-09-26 12:46:55 +09:00
Tadashi G. Takaoka
936371e64f Don't cancel gesture trail update drawing 
Bug: 7216955
Change-Id: Ie12bf45637b1012c9addb47279f9653334fae702
 2012-09-26 12:25:24 +09:00
Yuichiro Hanada
a161bdac88 add capacity to FusionDictionaryBufferInterface. 
bug: 6669677

Change-Id: I4627093811a19c46ce13fe351d1db63cbd78cf4a
 2012-09-25 21:47:11 +09:00
Jean Chalard
35ffb90629 Merge "Make getTerminalPosition read linked-list nodes." into jb-mr1-dev 2012-09-25 05:39:24 -07:00
Yuichiro Hanada
93d7c6233f Make getTerminalPosition read linked-list nodes. 
bug: 6669677

Change-Id: I599d276f430efe23d402695c325e23906b7705b3
 2012-09-25 21:11:15 +09:00
Tadashi G. Takaoka
630d9c95e5 Introduce typing aware gesture detection 
Bug: 7218902
Change-Id: I11ad85914bf991eca513e04ed8b5d12779101dda
 2012-09-25 20:11:05 +09:00
Tadashi G. Takaoka
10d76cdcd6 Merge "Fix touch position correction data passing" into jb-mr1-dev 2012-09-24 22:26:48 -07:00
Tadashi G. Takaoka
6ca50d9920 Fix touch position correction data passing 
Bug: 7225811
Change-Id: I3dcc0385ed633585d6810fdb742e0f88c2efbbd2
 2012-09-25 14:24:15 +09:00
Yuichiro Hanada
8ec0064c49 Make children addresses and parent addresses use signed addresses. 
Signed addresses are used only in version 3 with dynamic update.

bug: 6669677

Change-Id: Iadaeab199b5019d2330b4573c24da74d64f0945e
 2012-09-25 12:55:14 +09:00
Jean Chalard
0eef4b1e6f Merge "Add suggestion span upon starting a gesture." into jb-mr1-dev 2012-09-24 04:30:32 -07:00
Jean Chalard
6a58bb7ac9 Add suggestion span upon starting a gesture. 
Bug: 7196761
Change-Id: If60cb809b205159ced1887f94b7caf9775fcf3bb
 2012-09-24 20:25:46 +09:00
Jean Chalard
88985bfa2e Merge "Fix a bug where the cursor pos wouldn't be tracked correctly" into jb-mr1-dev 2012-09-24 03:41:48 -07:00
Jean Chalard
72c5d32888 Fix a bug where the cursor pos wouldn't be tracked correctly 
This would cause
Bug: 7208199

Change-Id: I8474985bfe349e1530b27bc98842937627bbe4e0
 2012-09-24 19:33:42 +09:00
Jean Chalard
d3fabe7fa5 Merge "Set punctuation suggestions at start if activated" into jb-mr1-dev 2012-09-24 01:30:38 -07:00
Jean Chalard
6efe788494 Set punctuation suggestions at start if activated 
Bug: 7218468
Change-Id: I9f8c1f13dc26cedb95b65279a34a825021dfa72a
 2012-09-24 17:27:03 +09:00
Tadashi G. Takaoka
b760591040 Merge "Second finger can start gesture input" into jb-mr1-dev 2012-09-24 00:12:53 -07:00
Jean Chalard
65ef26081b Merge "Fix a race condition with shift" into jb-mr1-dev 2012-09-23 23:48:20 -07:00
Tadashi G. Takaoka
b305e6775a Second finger can start gesture input 
Bug: 7108075
Change-Id: I17c419086a86c0bdac7a3858f8c66f6893678e67
 2012-09-24 15:31:51 +09:00
Jean Chalard
fff8613df0 Fix a race condition with shift 
Bug: 7062092
Change-Id: Ie1984673e9ffc9291d9650ec38ce99031ad93585
 2012-09-24 15:07:52 +09:00
Tadashi G. Takaoka
1e974deaa6 Merge "Disable gesture input while fast typing" into jb-mr1-dev 2012-09-23 21:19:55 -07:00
Yuichiro Hanada
82d9deaaf2 Combine mHasParentAddress with mHasLinkedListNode into mSupportsDynamicUpdate. 
bug: 6669677

Change-Id: I82799af199358420f09ac34fc005091e202c5d3b
 2012-09-24 13:17:44 +09:00
Tadashi G. Takaoka
9f09c6fbc8 Disable gesture input while fast typing 
Bug: 7032858
Change-Id: I0f9f92c712dbe45f4ba0b3cf331fbe11426c1db4
 2012-09-24 13:14:47 +09:00
Tadashi G. Takaoka
3088e0c9e9 Merge "Fix gesture start detection algorithm" into jb-mr1-dev 2012-09-21 01:51:57 -07:00
Tadashi G. Takaoka
02a67200fc Fix gesture start detection algorithm 
Bug: 7032858
Change-Id: I9f4d939fa87fdead4c5a5921338a16cd0a59b7ac
 2012-09-21 17:30:00 +09:00
Satoshi Kataoka
8ae8c76149 Cleanup settings 
bug: 7200189

Change-Id: Ibfd9254670cde5f4b2b693cc9334ee2845bede59
 2012-09-21 15:10:27 +09:00
Yuichiro Hanada
66597f5e5f Add deleteWord. 
bug: 6669677

Change-Id: I1a5b90ee05e5cffd74a5c140384a3e37c79e7e70
 2012-09-21 12:40:07 +09:00
Yuichiro Hanada
73779f7631 Make readUnigramsAndBigramsBinary read linked-list nodes. 
Change-Id: I07ae036b0b06e71d7a18f2bf11e4692cd4213568
 2012-09-20 20:37:02 +09:00
Ken Wakasa
54717534b1 Merge "Add getTerminalPosition." into jb-mr1-dev 2012-09-20 04:32:42 -07:00
Tadashi G. Takaoka
81d2e93772 Merge "Fix stuck gesture floatin preview text" into jb-mr1-dev 2012-09-20 03:47:46 -07:00
Tadashi G. Takaoka
61dcaaf17e Use device independent parameter for gesture 
Change-Id: Iea95992e4482108a498f14ec595f3eacc7d7fc4b
 2012-09-20 19:38:29 +09:00
Tadashi G. Takaoka
77bcd6be33 Fix stuck gesture floatin preview text 
Bug: 7192483
Change-Id: Ic62253180446a625330966a114a6fabf74ab4ec8
 2012-09-20 18:46:23 +09:00
Yuichiro Hanada
d36245fad2 Add getTerminalPosition. 
Change-Id: If04d779db23b1aea2cc12e5e9b8cecfcb35a5737
 2012-09-20 18:02:16 +09:00
Tadashi G. Takaoka
84c1bbd76d Merge "Move PointerTracker.MIN_GESTURE_RECOGNITION_TIME to GestureStroke" into jb-mr1-dev 2012-09-20 00:23:50 -07:00
Jean Chalard
b4e74cfc87 Auto correct on gesture when typed word is 1 char long 
Bug: 7178462
Change-Id: I779d8ee4a957a9d1fdcc80d33257a98965dec7b8
 2012-09-20 16:14:16 +09:00
Tadashi G. Takaoka
f80f09c7ee Move PointerTracker.MIN_GESTURE_RECOGNITION_TIME to GestureStroke 
Change-Id: Ib50192ed8f611fd8288ff9b7a1e0a19249cc6348
 2012-09-20 15:14:25 +09:00
satok
f1e13f1fb1 DO NOT MERGE: Clear cache of the user dictionary when a word is added 
This is a backport of  Iec2793de3fff7bf15f68f

Change-Id: If16d1c48edf084d892da722fb288e467f211b08e
 2012-09-20 12:27:14 +09:00
Tadashi G. Takaoka
bfcd2b3fc0 Merge "Change to "Show language switch key" option" into jb-mr1-dev 2012-09-19 19:56:59 -07:00
Tadashi G. Takaoka
1a4aa7e307 Change to "Show language switch key" option 
This change deprecates "Suppress language switch key".

Bug: 7037410
Change-Id: I1bc90877b4d2ee9364728959fd680dcb5b22ecbf
 2012-09-20 11:33:40 +09:00
Satoshi Kataoka
01a5a7d061 Merge "Clear cache of user dic" into jb-mr1-dev 2012-09-19 04:15:19 -07:00
Satoshi Kataoka
17f7b406aa Clear cache of user dic 
Change-Id: Iec2793de3fff7bf15f68f82a50331de7742b7049
 2012-09-19 20:11:45 +09:00
Tadashi G. Takaoka
c7dc673cf0 Use Path to draw gesture preview trail 
This change also reduces the number of points to use as preview trail.

Bug: 7167303
Change-Id: I0cf4908efa44b17b42d4fddd6725238236ac2654
 2012-09-19 19:29:06 +09:00
Tadashi G. Takaoka
567204a140 Merge "Show gesture floating preview text is off by default" into jb-mr1-dev 2012-09-19 03:00:40 -07:00
Tadashi G. Takaoka
4f8e451d0c Show gesture floating preview text is off by default 
Bug: 7043127
Change-Id: Icabf080f43a5934fef3824919bb03229522d5e5a
 2012-09-19 18:59:10 +09:00
Jean Chalard
caf15c3c67 Merge "Fix a bug that would persist caps lock state" into jb-mr1-dev 2012-09-19 02:30:49 -07:00
Satoshi Kataoka
8eb2065289 Merge "Log for geometric input" into jb-mr1-dev 2012-09-19 02:22:03 -07:00
Jean Chalard
ad0642cf25 Fix a bug that would persist caps lock state 
...with regards to suggestions. It's much simpler to look at
whether the word is actually all capitalized or not.

Bug: 7113544
Change-Id: Idc0e77b2f812964e650ade0e32b9d4c09228cb74
 2012-09-19 17:54:35 +09:00
Satoshi Kataoka
87cecf7db6 Log for geometric input 
Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f
 2012-09-19 17:45:27 +09:00
Tadashi G. Takaoka
a8dc30e6d7 Merge "Remove hack algorithm from GestureStroke" into jb-mr1-dev 2012-09-19 00:33:17 -07:00
Tadashi G. Takaoka
f501e4dbd2 Remove hack algorithm from GestureStroke 
Change-Id: Idd1c150677b989415e6fee4f543ff7639e98bed8
 2012-09-19 16:13:08 +09:00
Yuichiro Hanada
65feee12e5 Make BinaryDictIOUtils. 
Change-Id: I45830235ee738233e8eb2bd91d659705b698f58c
 2012-09-19 15:37:37 +09:00
Yuichiro Hanada
c2fdf0dfbf Make readNode read linked list nodes. 
Change-Id: Ia5eaae0653179b2eb74c53b0823beaf80377a389
 2012-09-19 14:49:23 +09:00
Yuichiro Hanada
a149c53c8e add limit to FusionDictionaryBufferInterface. 
Change-Id: Ic9ff717a9751023d47b02ff3b9d1fbf3115c2501
 2012-09-19 12:28:19 +09:00
Jean Chalard
a0ebb28d15 Merge "Fix a bug with capitalizations (A15)" into jb-mr1-dev 2012-09-18 20:02:05 -07:00
Jean Chalard
3bf113f0ea Merge "Mark 2 resolved TODOS as such (A14)" into jb-mr1-dev 2012-09-18 20:01:31 -07:00
Jean Chalard
c9923430ed Merge "Support the gesture + phantom space case (A13)" into jb-mr1-dev 2012-09-18 18:36:13 -07:00
Yuichiro Hanada
b686df15fc Add a new flag for linked list nodes. 
Change-Id: Ib2f194775cfe5ab05481ac95cd709d6e8e8dd3c6
 2012-09-18 22:01:49 +09:00
Yuichiro Hanada
bf45dc4860 Make writePlacedNode write the linked-list node. 
Change-Id: I60feda815ea08cf73300fccca1ae12b97550f116
 2012-09-18 21:20:07 +09:00
Yuichiro Hanada
061d225fb1 Add a new option to FormatOptions. 
Change-Id: I8bf089bea5de46570a5e81fb1ea3ab22c07eeee1
 2012-09-18 21:03:13 +09:00
Satoshi Kataoka
e55785e682 New flag for the internal settings 
Change-Id: I81e69a6cda833a0d2c59a73388321ed11e0bd5b3
 2012-09-18 20:33:43 +09:00
Satoshi Kataoka
2040090b46 Merge "Log touch timing" into jb-mr1-dev 2012-09-18 04:32:52 -07:00
Satoshi Kataoka
f8b35b9b04 Log touch timing 
Change-Id: I45ce16c3194fac6da98486a986d23318347cad3a
 2012-09-18 19:26:25 +09:00
Jean Chalard
75b3f81fe1 Fix a bug with capitalizations (A15) 
When only one character has been typed, we should not take that
as a strong symbol that everything should be upper-cased.

Change-Id: I4e3a3223269e6763e3594baeaa844daa79a624ed
 2012-09-18 18:52:05 +09:00
Jean Chalard
e4783f95b2 Mark 2 resolved TODOS as such (A14) 
Change-Id: Ifbb731f5c825675436d079db4ffbae657d71f8da
 2012-09-18 18:49:17 +09:00
Jean Chalard
d461bfd660 Support the gesture + phantom space case (A13) 
Bug: 6950087
Change-Id: I198699f6e687ac74c35b9edfe469dce880d9ecaf
 2012-09-18 18:48:49 +09:00
Jean Chalard
717d4938b5 Merge "Remove useless code (A12)" into jb-mr1-dev 2012-09-18 02:42:36 -07:00
Jean Chalard
ed47131612 Merge "Fix a bug with surrogate characters" into jb-mr1-dev 2012-09-18 02:06:55 -07:00
Jean Chalard
6c721b5f68 Fix a bug with surrogate characters 
This is a pretty bad bug :/

Bug: 7013840
Change-Id: I12c7cfa4fa9d56b2c1fee6e6222c64fe20b88fa3
 2012-09-18 18:01:15 +09:00
Jean Chalard
b128b1cdfe Merge "Take space state into account for caps (A11)" into jb-mr1-dev 2012-09-18 00:21:48 -07:00
Jean Chalard
5822323514 Remove useless code (A12) 
All this code is done inside the StringUtils or RichInputConnection
classes, where it's more logical. Since the IPC call is entirely
gone now, it's no use having these guards inside Latin IME.

Change-Id: Id324567e7458aed12b6f21d7114be3bd39725f15
 2012-09-18 16:16:33 +09:00
Jean Chalard
90a9127244 Take space state into account for caps (A11) 
Bug: 6950087
Change-Id: I8a1bca24db64b4dd54db8ac74d90cf43cbdddab6
 2012-09-18 16:16:28 +09:00
Yuichiro Hanada
8adc0154e6 Remove populateOptions(final ByteBuffer buffer). 
Change-Id: Ifc4c64c9cffe4f343c5a604c192db010a1792acc
 2012-09-18 14:42:52 +09:00
Yuichiro Hanada
65e4970026 Fix hackCanUseDictionaryFile. 
Bug: 7169473

Change-Id: I575aaa350042af076a8da5756993cdae9e73422c
 2012-09-18 14:19:38 +09:00
Jean Chalard
252da38fcd Take locale into account for caps (A10) 
Bug: 4967874
Change-Id: Ic7ce7b2de088308fa00865c81246c84c605db1e5
 2012-09-14 19:42:05 +09:00
Jean Chalard
da8aca6002 Merge "Fix comment warnings (A9)" into jb-mr1-dev 2012-09-14 03:20:34 -07:00
Jean Chalard
32c8704c21 Merge "Remove an unused function (A8)" into jb-mr1-dev 2012-09-14 03:19:53 -07:00
Jean Chalard
5cb9b70a3a Merge "Fix abbreviations processing for English (A7)" into jb-mr1-dev 2012-09-14 03:14:21 -07:00
Jean Chalard
a3f06baa57 Merge "Do not auto-correct upon starting a gesture." into jb-mr1-dev 2012-09-14 03:11:51 -07:00
Jean Chalard
6e65ff8001 Fix comment warnings (A9) 
Thanks Eclipse

Change-Id: Ie2b83f1ec7ab38a76155f8c264e3944685ae934d
 2012-09-14 19:01:37 +09:00
Jean Chalard
50e61b8628 Remove an unused function (A8) 
Change-Id: I0578068946d32192c4faf14b3e86624b7301c7d9
 2012-09-14 19:01:37 +09:00
Jean Chalard
2c0d916287 Fix abbreviations processing for English (A7) 
It's still incorrect for non-English languages.

Bug: 4967874
Change-Id: I3d4379265f72e1c0435eba90ab878a80bbcf55ce
 2012-09-14 19:01:25 +09:00
Jean Chalard
b29efecd26 Merge "Fix a bug with open parens and some other chars" into jb-mr1-dev 2012-09-14 02:30:36 -07:00
Jean Chalard
7e4ad33a65 Fix a bug with open parens and some other chars 
A space would be inserted after an open parenthesis if
it's typed after a manual pick.

Bug: 7167687
Change-Id: Ic49d09c34747117ccfbdbb8c66f634d88d4a45b0
 2012-09-14 18:23:35 +09:00
Jean Chalard
e8db06fc02 Merge "Replace immediate values with named constants for characters (A6)" into jb-mr1-dev 2012-09-14 02:17:48 -07:00
Jean Chalard
d806065033 Merge "Simplification again (A5)" into jb-mr1-dev 2012-09-14 02:17:01 -07:00
Tadashi G. Takaoka
f035649cb6 Asynchronously look up dictionary for gesture input 
Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280
 2012-09-14 02:12:11 -07:00
Jean Chalard
eda096538b Do not auto-correct upon starting a gesture. 
We decided to revert this UI decision after negative feedback.
Indeed, if you use to gesture but tap just one word, chances
are it's because you know you do NOT want a dictionary word.

Bug: 6965241
Change-Id: I85fdfab3c1cf1d3c0fd3e95908e01bdf56bccbba
 2012-09-14 17:52:54 +09:00
Jean Chalard
35dc8cf223 Replace immediate values with named constants for characters (A6) 
Change-Id: I6248f9f3ff99003ab62be22eac673df0f7f5c015
 2012-09-14 16:59:50 +09:00
Jean Chalard
e94c276690 Simplification again (A5) 
Change-Id: Id3ba200e06244e6d13cf57d346001d61f85ef1a2
 2012-09-14 16:59:18 +09:00
Jean Chalard
6f8dfd92b1 Simplify the code some more (A4) 
Change-Id: I1b1763ceefda6357dc698195928d0f16bc425830
 2012-09-14 16:58:04 +09:00
Jean Chalard
33a226f897 Merge "Small simplification (A3)" into jb-mr1-dev 2012-09-13 19:53:14 -07:00
Tadashi G. Takaoka
c869a224a4 Merge "Don't show gesture preview trail while detecting gesture input" into jb-mr1-dev 2012-09-13 19:30:00 -07:00
Tadashi G. Takaoka
9c5d165e9c Don't show gesture preview trail while detecting gesture input 
Bug: 7166222
Change-Id: Iecc8403a4eca305323ed8c8e17266d23172d84d9
 2012-09-14 11:21:12 +09:00
Yuichiro Hanada
cc958dd96e Refactor BinaryDictInputOutput. 
Change-Id: Idb4b635fcac70cc988e0dd3ce3bf121fba12099c
 2012-09-14 11:08:01 +09:00
Jean Chalard
5fbe3764ae Small simplification (A3) 
Change-Id: I2ea9566ce5cb1fbccd33a42836244a899365de6a
 2012-09-13 20:13:52 +09:00
Jean Chalard
d7fdc730c3 Merge "Simplify a call, and add comments (A2)" into jb-mr1-dev 2012-09-13 03:38:50 -07:00
Tadashi G. Takaoka
50f0388ee6 Merge "Fix gesture floating preview on up event" into jb-mr1-dev 2012-09-13 03:21:12 -07:00
Tadashi G. Takaoka
350fab6dc4 Fix gesture floating preview on up event 
This is a follow up of Iddb26ba1.

Bug: 7119032
Change-Id: Ibbc94a1a4880ca31bd8aeece89893691b14acc4d
 2012-09-13 19:07:09 +09:00
Jean Chalard
3d54e1c1ec Simplify a call, and add comments (A2) 
Since the function has to be modified heavily but does a lot
of non-trivial work, add a wealth of comments explaining what
it does and why so as to facilitate understanding the changes
to come.

Bug: 4967874
Change-Id: I6c21aea15f161d807035f279dfb7d1b98b3e9144
 2012-09-13 18:59:04 +09:00
Jean Chalard
2427f578c8 Merge "Import TextUtils.getCapsMode to fix it internally (A1)" into jb-mr1-dev 2012-09-13 02:57:35 -07:00
Tadashi G. Takaoka
737e915093 Merge "Show gesture floating preview text at oldest finger" into jb-mr1-dev 2012-09-13 02:32:53 -07:00
Jean Chalard
378728920b Merge "Make onUpdateSelection much more resilient to race conditions." into jb-mr1-dev 2012-09-13 02:28:52 -07:00
Tadashi G. Takaoka
f0e83046f0 Show gesture floating preview text at oldest finger 
Bug: 7119032
Change-Id: Iddb26ba1a595e472fde0982d744b5652d5fbda3e
 2012-09-13 18:17:15 +09:00
Jean Chalard
9d1c73ffd8 Import TextUtils.getCapsMode to fix it internally (A1) 
This should have on effect at all on behavior,
except an increase in performance.

Bug: 4967874
Bug: 6950087
Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
 2012-09-13 17:46:39 +09:00
Jean Chalard
5ed88457bf Make onUpdateSelection much more resilient to race conditions. 
This is pretty much as strong as it gets. It should be
impossible to get false positives and nearly impossible to
get true negatives with this new code.

Bug: 6981089
Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
 2012-09-13 17:35:26 +09:00
Yuichiro Hanada
1a347723c5 Move FormatOptions and FileHeader to FormatSpec. 
Change-Id: I232e35598635113bf2c81825669c744aadc79efe
 2012-09-13 16:35:41 +09:00
Yuichiro Hanada
81d97eec0e Move constants and comments. 
Change-Id: Ifd66bda7d528827ba61c60531121ea206a2325be
 2012-09-13 14:28:39 +09:00
Jean Chalard
18fc3bf4c4 Merge "Make Latin IME aware of its surrounding text." into jb-mr1-dev 2012-09-12 02:07:48 -07:00
Tadashi G. Takaoka
57e9511113 Merge "Use offscreen bitmap buffer to draw gesture preview trail" into jb-mr1-dev 2012-09-12 02:01:46 -07:00
Jean Chalard
28d765ed90 Make Latin IME aware of its surrounding text. 
This is a preparatory change for
Bug: 4967874
Bug: 6617760
Bug: 6950087

Change-Id: I3abf8e45c0d02c42491421f108370220134b9602
 2012-09-12 17:54:16 +09:00
Tadashi G. Takaoka
9ad4b2a894 Use offscreen bitmap buffer to draw gesture preview trail 
Bug: 7042741
Change-Id: Ie3d7054e786938dc501c7aa2ffc96b5924a7967b
 2012-09-12 17:47:17 +09:00
Yuichiro Hanada
8d031a63b4 Add put method to FusionDictionaryBufferInterface. 
Change-Id: Iac0b35d2da05e81237d105e8fe13c56d16038de1
 2012-09-12 15:41:21 +09:00
Tadashi G. Takaoka
64c65ce6d7 Add missing MoreKeySpec.hashCode 
Bug: 7149235
Change-Id: I14ba1017dffccc690e24289052a3ad7265a5f5f7
 2012-09-12 11:52:44 +09:00
Charles Chen
655be140a0 Merge "When Accessibility is on, intercept touch events during dispatch." into jb-mr1-dev 2012-09-11 13:31:30 -07:00
Ken Wakasa
e30c4e0bb1 Stabilize gesture recognition algorithm that looks for the nearest key. 
It relies on the order of the key array.

Change-Id: I58fa71a7b330e59cd774fc208e5b6bc1a3decd2e
 2012-09-11 20:00:21 +09:00
Jean Chalard
8c06a468e0 Stop auto-correcting non-whitelisted one-char strings 
Bug: 7134017
Change-Id: I75cf474dedafda3e1683dd8f7740c13aafdcf5ab
 2012-09-11 17:24:08 +09:00
alanv
dc2ee77724 When Accessibility is on, intercept touch events during dispatch. 
This allows Accessibility code to safely inject events into
onTouchEvent() without accidentally intercepting them.

Bug: 7137557
Change-Id: Ie4fa8e3be5b1bb84f57c6254feab1129cb89998f
 2012-09-10 15:47:24 -07:00
Yuichiro Hanada
e55b644aef Add new binary dictionary format. 
Change-Id: Ia99411d4009857d5e420ca87ef8acf1f1826d3ed
 2012-09-10 13:05:46 +09:00
Ken Wakasa
60af4f03a8 Fix dicttool_aosp build 
Change-Id: Iabcf420b4120e3d275fdbcb23939a0ab6052ddf0
 2012-09-10 12:56:10 +09:00
Yuichiro Hanada
eae7b293e4 Check the length of the word when add to FusionDictionary. 
Change-Id: Id98d18e90a8b83b597507728b467f56888c8fd12
 2012-09-10 12:35:53 +09:00
Tadashi G. Takaoka
f117f77766 Fix bimanual gesture preview trail 
Bug: 7122288
Change-Id: I9f0aabe08628880a8439bfda98844ae60206b8de
 2012-09-07 17:20:07 +09:00
Ken Wakasa
3069e22610 Merge "Add tests for readDictionaryBinary with byte array." into jb-mr1-dev 2012-09-06 04:40:41 -07:00
Yuichiro Hanada
be5db53a09 Add tests for readDictionaryBinary with byte array. 
Change-Id: I2c2815e9d4867687fb3f5b0c661e6162b88c0a0c
 2012-09-06 20:35:33 +09:00
Tadashi G. Takaoka
c1780c16a7 Revise gesture preview trail design 
Bug: 7042741
Change-Id: I99e3b3a6fc52afaee3cc5daf371131c3afebb3ae
 2012-09-06 20:09:12 +09:00
Tadashi G. Takaoka
15496ec4d7 Merge "Revise gesture floating preview design" into jb-mr1-dev 2012-09-05 20:35:40 -07:00
Tadashi G. Takaoka
71e2e8152f Revise gesture floating preview design 
Bug: 7043127
Change-Id: Ibf9a6d57279263d9b60753e0eb734b658eeda9f2
 2012-09-06 12:29:57 +09:00
Kurt Partridge
6fbb8ed253 Merge "add logging code" into jb-mr1-dev 2012-09-05 18:46:26 -07:00
Kurt Partridge
1093952cbb Merge "ResearchLogging do not even show basic data for password fields" into jb-mr1-dev 2012-09-05 11:53:07 -07:00
Kurt Partridge
625cfe3d21 Merge "ResearchLog uploadingService now waits for logging to finish" into jb-mr1-dev 2012-09-05 10:39:03 -07:00
Tadashi G. Takaoka
e8c6d5a480 Utilize StateListDrawable for key preview background 
Change-Id: I268550a185701caecefc27ebaec40fb2c940d883
 2012-09-05 20:38:00 +09:00
Yuichiro Hanada
83dfe0fd8c Add FormatOptions. 
Change-Id: Ibad05a5f9143de1156b2c897593ec89b0a0b07e7
 2012-09-05 18:05:43 +09:00
Kurt Partridge
fe05b88134 add logging code 
Change-Id: I0abb4a1ad67666162ab6703ffdb33c5e0675be93
 2012-09-04 15:24:25 -07:00
Kurt Partridge
596911479c ResearchLogging do not even show basic data for password fields 
Change-Id: I5489bad95f238e2f4d43bdd65bcf2f752d7a63fe
 2012-09-04 15:24:25 -07:00
Kurt Partridge
17114054e9 ResearchLog uploadingService now waits for logging to finish 
Bug: 6188932
Change-Id: I31c0f380b334d9117990f2d92de8d385e4a52c7c
 2012-09-04 15:24:25 -07:00
Jean Chalard
ac25fcac71 Display punctuation suggestions on cursor move 
...if punctuation suggestions are requested.

Fixes the symptom, but not the root cause of
Bug: 6981089

Change-Id: I683a7451c99457829cb4e5a762f43548ff89a535
 2012-09-04 19:54:55 +09:00
Ken Wakasa
2e4713a54e Merge "Check the length of the word when add to userhistory." into jb-mr1-dev 2012-09-04 02:36:35 -07:00
Tadashi G. Takaoka
848331222e Use string-array resource to define predefined-subtypes 
Bug: 6809603
Change-Id: Icafe4652ec17844838b28c04977deb88bcb9aa8f
 2012-09-04 17:18:39 +09:00
Tadashi G. Takaoka
147a62a8a8 Merge "Reduce amount of empty space in which keypresses are detected" into jb-mr1-dev 2012-09-04 00:55:25 -07:00
Tadashi G. Takaoka
3f00c6151f Reduce amount of empty space in which keypresses are detected 
Bug: 6942329
Change-Id: Ie92ccf43f307b8ceb9a311c30390d0cb2abf2cd7
 2012-09-04 16:11:21 +09:00
Yuichiro Hanada
dd435b305e Check the length of the word when add to userhistory. 
Change-Id: I7f2fe1771eed6b610704892b24f8a0283a779162
 2012-09-04 15:34:41 +09:00
Ken Wakasa
d34dd5bb6b Merge "Cosmetic fixes and a bug fix in UnigramDictionary::testCharGroupForContinuedLikeness()." into jb-mr1-dev 2012-09-03 22:26:42 -07:00
Ken Wakasa
f2789819bd Cosmetic fixes and a bug fix in UnigramDictionary::testCharGroupForContinuedLikeness(). 
This change has actually been extracted from a change work in progress I4fe423834b8131fb122251892c98228a6e08ba25

Change-Id: I52568fa09da2ea22be7f8bfe9676b7cd73c31fa4
 2012-09-04 14:23:37 +09:00
Tadashi G. Takaoka
2c0c1cc677 Merge "Fix key info reported by keyboard accessibility node provider." into jb-mr1-dev 2012-09-03 18:34:55 -07:00
Tadashi G. Takaoka
eceea877bd Consolidate Esperanto layout into Spanish layout 
This change also removes AsciiCapable extra value from Esperanto
subtype.

Change-Id: I0fa18ef7c52e4ba24b182e8ecb9788572660b704
 2012-09-03 17:38:56 +09:00
Tadashi G. Takaoka
ab5f9532db Use 5-row layout for Thai phone keybopard 
Bug: 6911182
Change-Id: I78f59564e8c31b9b66ed9a136584d0c57cc43120
 2012-09-03 14:15:48 +09:00
Jean Chalard
8251036616 Match calls in I8a70e43b for Icbe60bdf 
Change-Id: I3a9eaaa018cd338ca8d9aa09c0fa58800b637e19
 2012-09-03 11:58:23 +09:00
Jean Chalard
2035b946a3 Merge "Reinstate the shortcut-only attribute" into jb-mr1-dev 2012-09-02 19:28:01 -07:00
Jean Chalard
72b1c93941 Reinstate the shortcut-only attribute 
Also add the blacklist attribute

Bug: 7005742
Bug: 2704000
Change-Id: Icbe60bdf25bfb098d9e3f20870be30d6aef07c9d
 2012-08-31 22:11:52 +09:00
Tadashi G. Takaoka
a643b54b4d Add missing KeyDrawParams default constructor to fix build 
Change-Id: Id2ae9e4085b4137c961b5202e0822d484dd71e8e
 2012-08-31 20:28:46 +09:00
Tadashi G. Takaoka
dc34da218a Support per-Key and per-Keyboard key visual attributes 
This change refactors KeyDrawParams and KeyPreviewDrawParams to
separate KeyVisualAttributes.

Change-Id: I4de549eef303e1debe4b8f84668e042445fc18da
 2012-08-31 20:23:21 +09:00
Tadashi G. Takaoka
36b5f4aae2 Fix key label padding 
Change-Id: I971dd17afdaf1ce6e64e3c41bdb42a6ba3f6fd0e
 2012-08-31 19:57:25 +09:00
Yuichiro Hanada
666a433802 add UserHistoryDictIOUtils. 
Change-Id: I8a70e43b23f65b5fd5f0ee0b30a94ad8f5ef8a8a
 2012-08-31 15:08:57 +09:00
Kurt Partridge
9bbc7ec052 Merge changes Ifb983c35,I0b947421 into jb-mr1-dev 
* changes:
  ResearchLogger clean up splash screen
  ResearchLogger no longer offers option to disable logging
 2012-08-30 22:56:53 -07:00
Ken Wakasa
48643b08a9 Merge "add readUnigramsAndBigramsBinary." into jb-mr1-dev 2012-08-30 22:55:12 -07:00
Kurt Partridge
25405eafb0 ResearchLogger clean up splash screen 
- simpler text
- AlertDialog implementation
- declining users are redirected to regular IME

Bug: 6188932
Change-Id: Ifb983c3511125f8919f4a8b25aeee7de66dbb0cb
 2012-08-30 22:52:00 -07:00
Kurt Partridge
58eb4d9f27 ResearchLogger no longer offers option to disable logging 
Bug: 6188932
Change-Id: I0b9474216080f3820438c09f89b0b6c6c102c69d
 2012-08-30 22:51:56 -07:00
Yuichiro Hanada
b2a43a2ed4 add readUnigramsAndBigramsBinary. 
Change-Id: I7967f11211221d4877bf0a0c30183af885f45390
 2012-08-31 14:39:19 +09:00
Tadashi G. Takaoka
71b52a84e2 Move key label padding attributes back to KeyboardView 
This is a partially reverting change of I1e2d59bf8c438ca653e2e415ccf66fd4f15d5394

Change-Id: Id213541cdddcc0761bf6418c8429a5f96c0281ef
 2012-08-31 10:35:54 +09:00
Tadashi G. Takaoka
49d8af8a4e Separate inner classes of KeyboardView out under internal package 
Change-Id: I6d53b53526bbab951044a026476bd88a9ebd5a90
 2012-08-30 16:23:01 +09:00
Tadashi G. Takaoka
749cc18751 Move some key top visual attributes from KeyboardView to Key 
Change-Id: I1e2d59bf8c438ca653e2e415ccf66fd4f15d5394
 2012-08-30 16:14:32 +09:00
Tadashi G. Takaoka
35ff94547c Separate inner classes of keyboard package out under internal package 
Change-Id: Ia3969bd5ddec5aa5d81d05ad4cf676d818587922
 2012-08-30 15:37:55 +09:00
Jean Chalard
ded498d4a4 Merge "add readHeader." into jb-mr1-dev 2012-08-29 22:32:14 -07:00
Yuichiro Hanada
62ed901100 add readHeader. 
Change-Id: I5be5d62a63ca897e36fe93200ffdca6befb363aa
 2012-08-30 14:17:50 +09:00
Tadashi G. Takaoka
29d5973fd3 Optimize rare Key attributes to separate class 
This change also removes per-Key verticalGap and horizontalGap.

Change-Id: Id4d2129022fbbfbf5d740b8d1257032c945bb775
 2012-08-30 11:48:19 +09:00
Tadashi G. Takaoka
61bc66b324 Revert "Revert "Fix key letter size of 5-rows Thai keyboard"" 
This reverts commit 7a5ca9982f.
Depends: Ia4fa5046b3106e2710b9d5df1a6cc5f2cf995ec7

Change-Id: I0b9d0125380efe898943dc26ae884378145c44a3
 2012-08-30 11:30:13 +09:00
Tadashi G. Takaoka
b590d69e1f Merge "Revert "Revert "Move resource related methods to ResourceUtils""" into jb-mr1-dev 2012-08-29 19:29:37 -07:00
Ken Wakasa
d2a81ab9bd Merge "Add FusionDictionaryBufferInterface." into jb-mr1-dev 2012-08-29 18:49:03 -07:00
alanv
26b424b644 Fix key info reported by keyboard accessibility node provider. 
Bug: 6704529
Change-Id: I519881a96767a8858c11da7c0abac3e276a45cf5
 2012-08-29 13:07:37 -07:00
Tadashi G. Takaoka
92821614fd Revert "Revert "Move resource related methods to ResourceUtils"" 
This reverts commit bfc02a7005.

Change-Id: Ife4c0312ea3260211b1b5ee39b239e8e9d7db67e
Depends: I3d862515568be36d5aa80d12e7e5c0a9bf4d06a6
 2012-08-29 22:30:55 +09:00
Ken Wakasa
bfc02a7005 Revert "Move resource related methods to ResourceUtils" 
This reverts commit 160dc0f98e

Change-Id: Ic5a3d9c70b8f6f2993d8455799945ec2633cad66
 2012-08-29 04:33:39 -07:00
Yuichiro Hanada
f5c4ff4817 Add FusionDictionaryBufferInterface. 
Change-Id: I8640c994231d5f46bc6e074ce8a5bf5344fed0aa
 2012-08-29 19:27:49 +09:00
Tadashi G. Takaoka
160dc0f98e Move resource related methods to ResourceUtils 
Change-Id: I14535b030e58363315dd2daecaaef4edd6990cd9
 2012-08-29 17:51:07 +09:00
Tadashi G. Takaoka
f7a83d5584 Merge "Use non-bold text for Arabic and Thai keyboard" into jb-mr1-dev 2012-08-29 01:39:48 -07:00
Tadashi G. Takaoka
1e11c44d1b Make utility classes final 
Change-Id: Ic4f69b4c8da33c9fca50d6829724179310c2f875
 2012-08-29 17:38:08 +09:00
Tadashi G. Takaoka
d20652c878 Use non-bold text for Arabic and Thai keyboard 
The key text style can be specified in each keyboard layout in
addition to by KeyboardView theme.

Bug: 6753168
Change-Id: I4b5abda9322600eb8c6421f20ceef136ef103c05
 2012-08-29 17:33:44 +09:00
Jean Chalard
4fa01ee570 Merge "Allow Latin IME to cancel smiley-auto-correct consistenly" into jb-mr1-dev 2012-08-29 01:18:15 -07:00
Jean Chalard
a05a0f2077 Allow Latin IME to cancel smiley-auto-correct consistenly 
This change makes Latin IME behave consistently with regards
to other auto-correction cancellations in cases of auto-correction
cancellation after smiley-triggered auto-correction. That is,
pressing the smiley key when the keyboard signals it's about to
auto-correct will get the auto-correction there plus a smiley,
and pressing backspace will cancel the auto-correction, and
pressing backspace again will delete the smiley.

Bug: 7067593
Change-Id: Ia7eef70a5d06b8b9afa1f1fbb0ed1dbc21a3059f
 2012-08-29 16:49:39 +09:00
Tadashi G. Takaoka
9879f65651 Add ResourceUtils 
Change-Id: Ia198f8d95eae8c007623cd52d73cc1528d22fee9
 2012-08-29 16:36:00 +09:00
Tadashi G. Takaoka
95c486cdf3 Merge "Move some methods from Utils to LocaleUtils class" into jb-mr1-dev 2012-08-29 00:35:27 -07:00
Tadashi G. Takaoka
0023a57eea Move some methods from Utils to LocaleUtils class 
Change-Id: I4a834549c2ea96ac30d7e2cb692d69af219cab1a
 2012-08-29 16:24:53 +09:00
Tadashi G. Takaoka
237f5e4f9b Remove unused methods from Utils class 
Change-Id: I209b75f1cca381610f25cd219f35ea62b9762be2
 2012-08-29 16:10:16 +09:00
Charles Chen
78527e4dbb Merge "Adjust accessibility edge slop." into jb-mr1-dev 2012-08-28 10:28:55 -07:00
Tadashi G. Takaoka
263caae3c9 Merge "Support bimanual gesture input" into jb-mr1-dev 2012-08-28 02:30:22 -07:00
Tadashi G. Takaoka
6c3304ea96 Support bimanual gesture input 
Change-Id: Id86dc93fb7115ab4a6d05b3c05652df35ad08c12
 2012-08-28 18:26:07 +09:00
Jean Chalard
43d3f0fa3b Merge "Auto-correct after smileys and gestures." into jb-mr1-dev 2012-08-28 01:59:20 -07:00
Tadashi G. Takaoka
9fa0736d6a Consolidate KeyboardView.keyLetterSize and keyLetterRatio 
This change also consolidates keyboardView.keyLabelSize and
keyLabelRatio.

Change-Id: I4a45bcb6e7fc104ae4a9ae3ecdae9842d813840e
 2012-08-28 16:04:59 +09:00
Tadashi G. Takaoka
ef2bfad590 Use TypedArray.getFraction to read percentile values in resource 
Change-Id: Ifc8b024d190efba4cd536fd639621e841eb9970e
 2012-08-28 15:18:40 +09:00
alanv
e76a9b36ca Adjust accessibility edge slop. 
Bug: 6969558
Change-Id: Ie33f444e085e5c01326bdf9396eabee5c04ee81e
 2012-08-27 18:05:21 -07:00
Jean Chalard
6c70b92003 Auto-correct after smileys and gestures. 
Bug: 6936790
Bug: 6965241
Change-Id: I1f61327eb5591960c280e425df9cd86b9c52f5d6
 2012-08-27 18:54:05 +09:00
Tadashi G. Takaoka
1c2f332239 Optimize gesture preview trail drawing a bit 
This change also change the fading out duration of the gesture
preview trail to 800msec from 1,000msec

Change-Id: Icfd5b1ecad66db4f978249486f5fe362a3ae9640
 2012-08-27 14:43:39 +09:00
Tadashi G. Takaoka
5e3b93542d Fix the bug that the first gesture preview trail isn't drawn 
Change-Id: Ib3acd7c0b401e6d95b39552b48d0d974793eb438
 2012-08-24 17:48:23 +09:00
Tadashi G. Takaoka
a1a669a121 Merge "Add multiple gesture preview trails animation" into jb-mr1-dev 2012-08-24 01:05:21 -07:00
Tadashi G. Takaoka
333a300586 Add multiple gesture preview trails animation 
Change-Id: I533e6de9b138317472565be82c8ba5e422472888
 2012-08-24 17:04:20 +09:00
Jean Chalard
5cc596160a Merge "Use ByteBuffer when reading FusionDictionary from file." into jb-mr1-dev 2012-08-23 21:56:02 -07:00
Yuichiro Hanada
d4fe7fda30 Use ByteBuffer when reading FusionDictionary from file. 
Change-Id: Ia71561648e17f846d277c22309ac37c21c67a537
 2012-08-24 13:31:08 +09:00
Tadashi G. Takaoka
64a26b4389 Fix bug in InputPointers.append 
Change-Id: I39825757bbae32b66c4b61cb6c4fbcaa2e0c9c47
 2012-08-23 17:59:08 +09:00
Tadashi G. Takaoka
64ee096100 Add toString method to InputPointers and ResizableIntArray 
Change-Id: I835ee131855bef8233cf2672e2fb288b939148a6
 2012-08-23 17:29:36 +09:00
Tadashi G. Takaoka
922a85734d Merge "Remeve the reference of MainKeyboardView from PointerTracker" into jb-mr1-dev 2012-08-23 00:26:30 -07:00
Tadashi G. Takaoka
5509798977 Remeve the reference of MainKeyboardView from PointerTracker 
This change also consolidates MainKeyboardView.KeyTimerParams with
KeyTimerHandler.

Change-Id: Ifc70ca81fa7d7daded4c2204fcdffdf942c16bc5
 2012-08-23 16:22:13 +09:00
Tadashi G. Takaoka
b28139f51b Use PointerTrackerQueue.size instead of MotionEvent.getPointerCount 
Change-Id: I089e905def0b70bd38fd54ab2d84689b904bb320
 2012-08-23 15:54:00 +09:00
Tadashi G. Takaoka
694ccb5ba1 Cosmetic change to PointerTracker 
* Add final to parameters and locals
* Add curly bracket around single statement if-block

Change-Id: I9f3b23f7145e6b1d6ef806d991ed71ebc63311ff
 2012-08-23 15:14:46 +09:00
Kurt Partridge
b5ace11a2e ResearchLogging upload via service 
Upload using an intent service rather than just a thread.  More robust in case the keyboard
is closed and the upload hasn't finished yet.

multi-project commit with Id515c2b1b0d6f85be50f92a661a2d32ebaeaa143

Bug: 6188932
Change-Id: I64a9fab92ff89ee09df877db4e5f7f0ec0ffb3b6
 2012-08-22 11:27:46 -07:00
Kurt Partridge
fa0bac9057 ResearchLogging log when preferences change 
Bug: 6188932
Change-Id: I82a115aed30d7693f92d784a32b038996d8b71e3
 2012-08-22 11:27:45 -07:00
Kurt Partridge
d573bad5bd Merge "ResearchLogging capture full n-gram data" into jb-mr1-dev 2012-08-22 10:41:10 -07:00
Tadashi G. Takaoka
50e7501722 Merge "Fix SubtypeSwitcher initialization path" into jb-mr1-dev 2012-08-22 01:02:04 -07:00
Tadashi G. Takaoka
dde36ef343 Remove TextView reference from PointerTracker 
Change-Id: If8e65c08ec97f6d57932c9e3412d6fe17b0994ea
 2012-08-22 16:13:29 +09:00
Tadashi G. Takaoka
9fc6af325e Fix SubtypeSwitcher initialization path 
This change also removes the reference of LatinIME from
SubtypeSwitcher.

Bug: 7026856
Change-Id: I78a266f3682b11f09b49bbcdcdb6aee713e6af37
 2012-08-22 16:05:34 +09:00
Kurt Partridge
bf653996ea ResearchLogging capture full n-gram data 
- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ic70ccb6c2e11eb02d887821434b44daa3eb7a3e2

Bug: 6188932
Change-Id: I731d6cff6539e997874f723b68bdb0d9b651b937
 2012-08-21 22:37:33 -07:00
Tadashi G. Takaoka
ecfbf4625c Add static construct method for SparseArray 
Change-Id: I6da97f6ea23578318f403bb5d64c30b1663c69ee
 2012-08-22 14:22:20 +09:00
Tadashi G. Takaoka
1f05cf6dab Remove GCUtils utility class 
Change-Id: Ia666aeb10c155d69763faf7f01ceca113b9b4653
 2012-08-22 12:34:22 +09:00
Tadashi G. Takaoka
f852891437 Merge "Remove KeyboardSwitcher reference from ResearchLogger" into jb-mr1-dev 2012-08-21 20:22:57 -07:00
Jean Chalard
07d485d705 Merge "Fix a silly bug." into jb-mr1-dev 2012-08-21 20:16:28 -07:00
Tadashi G. Takaoka
c3f78c9057 Remove KeyboardSwitcher reference from ResearchLogger 
Change-Id: I671a83c19977fda358c8e8a730e22ee155f65512
 2012-08-22 12:14:52 +09:00
Tadashi G. Takaoka
eb59a87a07 Merge "Add CollectionUtils class to create generic collection easily" into jb-mr1-dev 2012-08-21 20:13:24 -07:00
Jean Chalard
32f6503a27 Fix a silly bug. 
This would prevent user history to work at all.

Bug: 7023638
Change-Id: I5d8867a07fb8859325d274e956ae667c094d0ac1
 2012-08-22 12:09:24 +09:00
Tadashi G. Takaoka
5f282ea9e4 Add CollectionUtils class to create generic collection easily 
Change-Id: I6b4de9187e122298e5e9cd8ddc9070d062df6a89
 2012-08-22 10:21:38 +09:00
Kurt Partridge
0a30688080 ResearchLogger to track simple statistics 
Bug: 6188932
Change-Id: Ie1bb7322706c2d4a56f5e17044bc746e9df1cf18
 2012-08-21 17:13:49 -07:00
Kurt Partridge
94e7f4bef9 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with I05496cfd762e9a41c42c50099143f1efc0a3d8a2

Bug: 6188932
Change-Id: I424abb2e437901262a9620255493916b7c3ff74b
 2012-08-21 17:13:36 -07:00
Jean Chalard
8b6b5592cb Merge "Treat all caps for gesture input." into jb-mr1-dev 2012-08-21 04:39:04 -07:00
Jean Chalard
324cc1dbe6 Merge "Tell the shift mode to the word composer." into jb-mr1-dev 2012-08-21 04:38:27 -07:00
Jean Chalard
1eba97d92f Treat all caps for gesture input. 
Bug: 6950087
Change-Id: I9f2271780600572c9befa96c7ad98494c554dd2b
 2012-08-21 20:29:53 +09:00
Jean Chalard
adbd9ae105 Tell the shift mode to the word composer. 
Bug: 6950087
Change-Id: Ifab9d6d075af398c6468d081216488712f8a53fb
 2012-08-21 20:27:42 +09:00
Tadashi G. Takaoka
ac78633be2 Rename and consolidate some constants 
Change-Id: I7863936cca18b28bf0117afcbcf544a5fd7f185d
 2012-08-21 17:54:53 +09:00
Tadashi G. Takaoka
18f69b02ef Merge "Fix NPE" into jb-mr1-dev 2012-08-21 01:37:19 -07:00
Tadashi G. Takaoka
6785b90727 Remove touch coordinate from pickSuggestionManually 
Change-Id: I33b1b4bc6fdfd263c4b2bb7125c07b4bddcf3c9f
 2012-08-21 17:13:45 +09:00
Tadashi G. Takaoka
8d0cf41f49 Fix NPE 
Bug: 7017430
Change-Id: Ie46f02a934763c3b6d65d0d62a8239d80eaefabd
 2012-08-21 16:56:45 +09:00
Kurt Partridge
48643b0e0d Merge "Revert "ResearchLogger log RichInputConnection"" into jb-mr1-dev 2012-08-20 10:18:40 -07:00
Kurt Partridge
e15e6c2c27 Merge "Revert "ResearchLogger to track simple statistics"" into jb-mr1-dev 2012-08-20 10:18:30 -07:00
Kurt Partridge
adb591e75b Merge "Revert "ResearchLogging capture full n-gram data"" into jb-mr1-dev 2012-08-20 10:18:30 -07:00
Kurt Partridge
7b0459e1a8 Merge "Revert "ResearchLogging log when preferences change"" into jb-mr1-dev 2012-08-20 10:18:20 -07:00
Kurt Partridge
f1c3e53b23 Merge "Revert "ResearchLogging upload via service"" into jb-mr1-dev 2012-08-20 10:18:10 -07:00
Kurt Partridge
35c11842a7 Revert "ResearchLogger log RichInputConnection" 
This reverts commit 1964ffb3f4

Change-Id: Ie43e7ac828faa91e1824a255bb3ecf6c8222d4e8
 2012-08-20 10:17:45 -07:00
Kurt Partridge
77257a736e Revert "ResearchLogger to track simple statistics" 
This reverts commit 7cec911fde

Change-Id: I3eb055e03a9cf463356ebaefc7827ab65a963072
 2012-08-20 10:17:43 -07:00
Kurt Partridge
3d35908749 Revert "ResearchLogging capture full n-gram data" 
This reverts commit 221e756fd7

Change-Id: Iefc4e4e27ddc925d4a4634627b0467bd4ee2a66e
 2012-08-20 10:17:40 -07:00
Kurt Partridge
fc74a01abe Revert "ResearchLogging log when preferences change" 
This reverts commit c58f5d904b

Change-Id: Ifab54ecc8b7898fe0af6446d397efd6cdb28f670
 2012-08-20 10:17:31 -07:00
Kurt Partridge
96da633582 Revert "ResearchLogging upload via service" 
This reverts commit baf1f0bd61

Change-Id: I7d959b9b626c8fb69a57788e243752952258fa80
 2012-08-20 10:17:29 -07:00
Kurt Partridge
8beeef5d3f Merge changes Ie980d38a,Ia7ee65e7 into jb-mr1-dev 
* changes:
  ResearchLogging upload via service
  ResearchLogging log when preferences change
 2012-08-20 08:48:12 -07:00
Kurt Partridge
752c53760c Merge changes I568c90d4,I4667f8f6 into jb-mr1-dev 
* changes:
  ResearchLogging capture full n-gram data
  ResearchLogger to track simple statistics
 2012-08-20 08:47:45 -07:00
Kurt Partridge
461f1942f9 Merge "ResearchLogger log RichInputConnection" into jb-mr1-dev 2012-08-20 08:47:33 -07:00
Tadashi G. Takaoka
5a49a8bb5f Merge "Cleaup gesture preview drawing code a bit" into jb-mr1-dev 2012-08-19 23:42:05 -07:00
Tadashi G. Takaoka
978c0fc878 Cleaup gesture preview drawing code a bit 
Change-Id: Ie75d497ba88805d945d6039ecad09ed0e8e5e4d3
 2012-08-20 15:40:03 +09:00
Tadashi G. Takaoka
cb2362cee1 Merge "Make some usages of SparseArray thread-safe" into jb-mr1-dev 2012-08-19 23:23:08 -07:00
Tadashi G. Takaoka
8ce351a827 Make some usages of SparseArray thread-safe 
This is a follow up of I39d9bf1a7c272eb16d6ed4698f52457579b40f10.

Change-Id: Ic3288e491175f9a85679a21064093f9db5a65466
 2012-08-20 15:00:26 +09:00
Jean Chalard
1aed102d4c Merge "Fix capitalization, part 1" into jb-mr1-dev 2012-08-19 22:29:59 -07:00
Jean Chalard
4c6db0592e Merge "Remove the whitelist dictionary." into jb-mr1-dev 2012-08-19 22:13:15 -07:00
Jean Chalard
04d6649d29 Merge "Remove access to the whitelist class." into jb-mr1-dev 2012-08-19 22:12:36 -07:00
Jean Chalard
753f7b123e Merge "Hack to skip reading an outdated binary file." into jb-mr1-dev 2012-08-19 22:11:44 -07:00
Jean Chalard
13822d2b05 Hack to skip reading an outdated binary file. 
Bug: 7005813
Change-Id: Ie0d8d4b2d5eb147838ca23bdd5ec1cecd4f01151
 2012-08-20 13:56:52 +09:00
Jean Chalard
fb087a95f9 Fix capitalization, part 1 
The case this fixes is typing "Ah.\n" in gmail for example

Bug: 6950087
Change-Id: Ia4bf3a57dde49b9c9d47d315e9f85b7ffc7ee6e3
 2012-08-20 13:51:27 +09:00
Tadashi G. Takaoka
6c63f71265 Add standard view constructors of PrevewPlacerView 
Change-Id: I00d7ae4d2330804c342a5e51cf8c0df6ed8a85d6
 2012-08-20 11:56:28 +09:00
Ken Wakasa
522e12660a Cosmetic fixes 
Change-Id: I5460252af534d4455ba22273a06ac956bc904831
 2012-08-19 01:26:05 +09:00
Kurt Partridge
c58f5d904b ResearchLogging log when preferences change 
DO NOT MERGE

Bug: 6188932
Change-Id: Ia7ee65e7f3be10d031a065aaa6c3d18610c7dff0
 2012-08-17 21:44:08 -07:00
Kurt Partridge
baf1f0bd61 ResearchLogging upload via service 
DO NOT MERGE

Upload using an intent service rather than just a thread.  More robust in case the keyboard
is closed and the upload hasn't finished yet.

multi-project commit with I40db74fb780e01364609339764e150f0291d3f9b

Bug: 6188932
Change-Id: Ie980d38a713d15c01083d41bd73f0602ec75dd16
 2012-08-17 21:44:08 -07:00
Kurt Partridge
7cec911fde ResearchLogger to track simple statistics 
DO NOT MERGE

Bug: 6188932
Change-Id: I4667f8f60aa356c73f925c298318520f71e144c5
 2012-08-17 21:44:07 -07:00
Kurt Partridge
221e756fd7 ResearchLogging capture full n-gram data 
DO NOT MERGE

- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ie2bc79fd7fe6b951b24771e94b8d4ca21989af65

Bug: 6188932
Change-Id: I568c90d4af07e7c759c1e7fc64b716bd8c7b4ae5
 2012-08-17 21:44:07 -07:00
Kurt Partridge
1964ffb3f4 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with Ib71f841044ec1072610ab5638a5edfce29b7c05b

DO NOT MERGE

Bug: 6188932
Change-Id: I9ec7500a5b18bfe1a5a5bb1e5bf21c43351fc59e
 2012-08-17 21:44:06 -07:00
Ken Wakasa
e46d12927e Fix NPE in LatinIME.addToUserHistoryDictionary() 
bug: 7007063
Change-Id: Ie3e2f77dcbc597dda0c0df9a970336e5aac0edba
 2012-08-18 00:04:33 +09:00
Ken Wakasa
72c0f4de1d Merge "add reconstructBigramFrequency" into jb-mr1-dev 2012-08-17 03:19:12 -07:00
Yuichiro Hanada
c0a75c8ecb add reconstructBigramFrequency 
Change-Id: Iff20dcb9ca0d6064bb118247887fe24b812c0c61
 2012-08-17 19:05:16 +09:00
Jean Chalard
aa27635a8a Reword a confusing comment 
Bug: 7005645
Change-Id: Ifd942b3ce242aeeec512e132e1cee31329e994b1
 2012-08-17 17:22:28 +09:00
Jean Chalard
46fc768e54 Remove the whitelist dictionary. 
The functionality now lives in the binary dictionary.

This finalizes work on
Bug: 6906525

Change-Id: Id106d871e8afdf9afa886d2a30bea87ff89f2d24
 2012-08-17 15:13:10 +09:00
Jean Chalard
3e43e6998e Remove access to the whitelist class. 
...which becomes useless. It will be entirely removed in an
upcoming change.

Change-Id: I2f1d27f1eceda79454b01f21e057b98f2953131a
 2012-08-17 13:01:25 +09:00
Jean Chalard
228674f6c7 Merge "fix findWordInTree." into jb-mr1-dev 2012-08-16 18:54:24 -07:00
Yuichiro Hanada
0d35c159fe fix findWordInTree. 
Change-Id: I8f42df28f76188677db9d4e55885e1fc6a40b53f
 2012-08-17 10:23:01 +09:00
Jean Chalard
3083b4b77d Merge "Fix a debug method" into jb-mr1-dev 2012-08-16 17:59:11 -07:00
Jean Chalard
cc1062cfd0 Fix a debug method 
Change-Id: Icf78fb0d5f7caea78f053fffd1ecd4289629964a
 2012-08-17 09:24:45 +09:00
Ken Wakasa
bc44ad77e5 Merge "fix findWordInTree." into jb-mr1-dev 2012-08-16 04:26:55 -07:00
Yuichiro Hanada
66f338983b fix findWordInTree. 
Change-Id: I9d81c815494a0670afa81219ad7bad82274d997e
 2012-08-16 20:21:47 +09:00
Jean Chalard
91c64902b0 Merge "Refresh editor info when the text field attributes changes." into jb-mr1-dev 2012-08-15 02:35:21 -07:00
Jean Chalard
e234aed428 Refresh editor info when the text field attributes changes. 
For some reason we get a "restarting" flag from the browser
some times when the input field is different. The attributes
however are not the same, so we can detect that and reload
appropriately.

Bug: 6946793
Change-Id: I6762dae6f41db690497b026a707d9cc89c840b34
 2012-08-15 18:32:59 +09:00
Jean Chalard
cd0e004888 Merge "Ensure #offer always actually offers something." into jb-mr1-dev 2012-08-15 02:16:09 -07:00
Jean Chalard
653dbfb8ed Ensure #offer always actually offers something. 
This will allow remaining requests after a call to terminate
correctly.

Bug: 6963142
Change-Id: Iff67058bb8a39f2f1b468d3894861e8125de6659
 2012-08-15 18:10:10 +09:00
Satoshi Kataoka
3979f060f0 Step 28-A Introduce the session Id to getSuggestion 
Change-Id: I39d9bf1a7c272eb16d6ed4698f52457579b40f10
 2012-08-15 15:44:45 +09:00
alanv
0538493309 Fix the build. 
Change-Id: I744f6232e81981ab694d3d1e92bab5fd6efa46c0
 2012-08-14 15:34:29 -07:00
Charles Chen
dd7f79097a Merge "Change accessibility event type for app-driven speech." into jb-mr1-dev 2012-08-14 14:33:32 -07:00
Jean Chalard
e30c05800f Preemptive anti-deadlock device 
We don't know of any actual bug in the implementation of the
pool that may result in a deadlock, but this still implements
a means out of a deadlock if one ever arises anyway. It's
meant to improve the resilience of the spell checker.

Bug: 5441027
Change-Id: I689491090792dbb89110ee56631965c5bb2dc712
 2012-08-14 17:04:14 +09:00
Jean Chalard
5d6b8e1818 Fix a bug that would prevent spell checking 
java.lang.ArrayIndexOutOfBoundsException:
        [I offset=0 length=528 src.length=512
com.android.inputmethod.keyboard.ProximityInfo
        .setProximityInfoNative(Native Method)
com.android.inputmethod.keyboard.ProximityInfo
        .createSpellCheckerProximityInfo(ProximityInfo.java:85)
com.android.inputmethod.latin.spellcheck.AndroidSpellCheckerService
        .createDictAndProximity(AndroidSpellCheckerService.java:411)

The array was too small with respect with the passed size.

Change-Id: I7777d7aecd17375d3fbf82854a66eb7a5a289ce6
 2012-08-14 14:45:17 +09:00
Tadashi G. Takaoka
f92f9de7a9 Merge "Eliminate redundant time parameter from gesture detection code" into jb-mr1-dev 2012-08-13 02:25:28 -07:00
Ken Wakasa
40a6d4af2a Merge "Cleanups in geometry_utils.h" into jb-mr1-dev 2012-08-13 02:11:52 -07:00
Tadashi G. Takaoka
74d0bb09c7 Eliminate redundant time parameter from gesture detection code 
This change also uses the key width to determine the sampling rate of
the gesture points (instead of the key height).

Change-Id: I987487825693b4883d8359eb5b31f1d668cd5ef4
 2012-08-13 18:11:03 +09:00
Ken Wakasa
0fb950858e Cleanups in geometry_utils.h 
Change-Id: Ic051703e5b67adfc62753ebd9ab254296719c6e9
 2012-08-13 17:47:00 +09:00
Tadashi G. Takaoka
fc5e3f973c Remove unnecessary drawing point 
Change-Id: Ib9cba3484a72306320eb9c1744d940da1a0998c7
 2012-08-13 14:03:10 +09:00
Tadashi G. Takaoka
708cc94a35 Remove gesture detection hacking code 
Change-Id: Idaec3753592ca0a5c5545eb5ab65254a3e32e662
 2012-08-13 12:19:19 +09:00
Ken Wakasa
bcec82de66 Clean up constructors 
And, use C++ style casts and use float math functions rather than double ones to save memory space.

Also, stop using FloatMath and NativeUtils as standard Math methods are faster now.
See http://code.google.com/p/android/issues/detail?id=36199 and https://android-review.googlesource.com/40700

multi-project commit with I4259fb5ab8a15ac5760a7f04fc8f4c860529f04a

Change-Id: I0b81cff8c91769f7559a59b9528c75a5aabb4211
 2012-08-13 10:48:37 +09:00
satok
847c8dfe17 Fix JNI 
Change-Id: If134baf52e78fbe18b78611a23870f5d10c80955
 2012-08-11 13:54:01 +09:00
alanv
5f312c9c15 Change accessibility event type for app-driven speech. 
Bug: 6614400
Change-Id: I0ef309b7f3f35bf37b4664ea599c9e6ffb1a4ab8
 2012-08-10 13:51:17 -07:00
Ken Wakasa
f3850e5543 Use JNI Region calls also in getSuggestions() 
Change-Id: I9cc0208397c202aeb6f7b5bb5ad59e00c5afbd80
 2012-08-10 21:09:23 +09:00
Satoshi Kataoka
f6c2200890 Workaround to stop init dict traverse session 
Change-Id: I3d46c54a96a9fc0359ef75b9d2f8590b44164a8b
 2012-08-10 21:07:53 +09:00
Jean Chalard
7b258e512d Accept whitelisted entries from any source. 
...not only the WhitelistDictionary.

Bug: 6906525
Change-Id: I7f181eb6936ec17bbccdc4e736fd09292af24e9c
 2012-08-10 19:02:19 +09:00
Jean Chalard
caed149b67 Optimization & Simplification 
It's useless to do the whitelist lookup twice. Also, putting
this test out of this method will allow whitelist entries to
come from other sources.

Bug: 6906525
Change-Id: I4afe678cae6556d16642d155ce770fbf4e61ad49
 2012-08-10 19:02:15 +09:00
Jean Chalard
dc2fb6bc6d Merge "Pass the type from native code all the way to Java." into jb-mr1-dev 2012-08-10 01:26:59 -07:00
Jean Chalard
926ef06a1e Pass the type from native code all the way to Java. 
Bug: 6906525
Change-Id: I057390d47a223450e22d8338509e22c28fc0d5f6
 2012-08-10 15:51:55 +09:00
Tadashi G. Takaoka
ce38c62aef Merge "Remove conservative MainKeyboardView.draw" into jb-mr1-dev 2012-08-09 23:31:53 -07:00
Satoshi Kataoka
e9f3e182e4 Add arguments for dic traverse session 
Change-Id: I8776ad528eeea9a5fc4dcf394ca13bb80c04fb6d
 2012-08-10 12:34:00 +09:00
Tadashi G. Takaoka
1b6829b0e0 Remove conservative MainKeyboardView.draw 
Change-Id: I52f58d1e013dfe1f1b0f8320cba903d3dbb4eabd
 2012-08-10 11:02:41 +09:00
Ken Wakasa
5bb4206275 Use more JNI Region calls 
Change-Id: I371db517ff4749c0b7e5bdb4362e6310c91a24dc
 2012-08-10 00:46:20 +09:00
Satoshi Kataoka
9d29871605 Add reset method for dic travserse session 
Change-Id: Ia3dd924f92549da2cf8302ef77c629902d4f275b
 2012-08-09 17:49:19 +09:00
Tadashi G. Takaoka
877157e1f5 Optimize keyboard drawing code a bit 
* Remove useless boolean flag.
 * Use invalidate(int,int,int,int).
 * Don't draw background when hardware acceleration is enabled.

Change-Id: Id560ac84f33b5151437a42a4ff22736284d71e2d
 2012-08-09 16:44:11 +09:00
Tadashi G. Takaoka
2be2d77664 Update dictionary availability at onStartInputView 
This is a follow up of I7901c0f9489b4deb79314c2c903b138611bfd78e

Change-Id: I38c22e886db247c402a964e3ddd10b09a461151c
 2012-08-09 16:09:54 +09:00
Tadashi G. Takaoka
9abea49dd4 Merge "Fix NPE and don't call UI API from non-UI thread" into jb-mr1-dev 2012-08-08 20:00:19 -07:00
Tadashi G. Takaoka
8335c59ea7 Fix NPE and don't call UI API from non-UI thread 
This change also reverts I29ec3e9f10484f30288fac76f0c45b3707bc2259

Bug: 6956969
Bug: 6891020
Bug: 6947253
Change-Id: I7901c0f9489b4deb79314c2c903b138611bfd78e
 2012-08-09 11:55:41 +09:00
Satoshi Kataoka
60d4961f34 Merge "Pass traverse session" into jb-mr1-dev 2012-08-08 07:50:44 -07:00
Satoshi Kataoka
9127811493 Pass traverse session 
Change-Id: I84bfaaa406e3f51421c08a7ee8f9576ebdba54d4
 2012-08-08 23:30:31 +09:00
Satoshi Kataoka
181567f9c7 Merge "Add traverse session" into jb-mr1-dev 2012-08-08 04:40:36 -07:00
Satoshi Kataoka
c4e4dfe17d Add traverse session 
Bug: 6942265

Change-Id: I384cf701f5ee44c4b1037e5b8ddfa3d570286f55
 2012-08-08 20:39:43 +09:00
Tadashi G. Takaoka
732f27984e Merge "Add toString() method to Keyboard" into jb-mr1-dev 2012-08-08 00:08:13 -07:00
Tadashi G. Takaoka
2bcd913e56 Merge "Add SuggestInitializationListener to BinaryDictionary.resetMainDict()" into jb-mr1-dev 2012-08-08 00:07:57 -07:00
Tadashi G. Takaoka
35336cf83a Add toString() method to Keyboard 
Change-Id: I74c8f006323ed78ec67414fd17849ab40966968e
 2012-08-08 15:59:56 +09:00
Tadashi G. Takaoka
79eefda0d3 Add SuggestInitializationListener to BinaryDictionary.resetMainDict() 
Change-Id: I4c01f172ddb2ca60fa6e604384610c90b76e5457
 2012-08-08 15:55:26 +09:00
Tadashi G. Takaoka
7ae1fd02d4 Use ArrayList to implement PointerTrackerQueue 
Change-Id: Ie386e6c7869df4df940e09fccffc5cd661134557
 2012-08-08 14:18:30 +09:00
Tadashi G. Takaoka
0cc425bd9c Add PointerTrackerQueue unit tests 
This is a groundwork to elminate LinkedList from PointerTrackerQueue.

Change-Id: Ib77780537ceb0b4273fb8e483977ab76124c5ce7
 2012-08-07 16:56:41 +09:00
Tadashi G. Takaoka
27e48447a4 Lingering gesture floating preview text a bit 
Bug: 6936095
Change-Id: I873343e9aa6afdf6bdb223795f03232509b012a7
 2012-08-07 13:54:42 +09:00
Tadashi G. Takaoka
7a13975700 Cleanup unused import and dead code 
Change-Id: Ife877620561d29a8f25602916420741186104617
 2012-08-06 17:28:33 +09:00
Tadashi G. Takaoka
dba77186f7 Fix duplicate getSuggestions() call for main dictionary 
Change-Id: I092480063452505cdf03dbd83b9c64e535822931
 2012-08-06 17:08:38 +09:00
Tadashi G. Takaoka
b27959741a Fix Utils.getStackTrace() 
Change-Id: Iaf160af32bb77b3ad5929cb5ee8eccd01165bdf6
 2012-08-06 16:50:43 +09:00
Tadashi G. Takaoka
0a524de3df Separate updateSuggestionStrip from commitTyped 
The commitTyped() called updateSuggestionStrip(), and that led to call
Suggest.getSuggestedWordsForTypingInput() even after a batch input was
started because WordComposer.commitWord() reset the batch input state.

Bug: 6932442
Change-Id: If645b1ef0343aa1e21ca71a9275b40c6c3be13df
 2012-08-06 14:31:01 +09:00
Tadashi G. Takaoka
4e9e6cd154 Fix IllegalStateException of KeyDetector 
A KeyDetector without Keyboard may exist in some rare cases. This
change eliminates throwing IllegalStateException and checks explicitly
against null.

Bug: 6891020
Change-Id: I29ec3e9f10484f30288fac76f0c45b3707bc2259
 2012-08-06 11:09:50 +09:00
Jean Chalard
15b28432ba Merge "Cleanup unused code" into jb-mr1-dev 2012-08-03 09:32:27 -07:00
Jean Chalard
8ee4b35c70 Cleanup unused code 
The Italian dictionary has been amended to contain words that
include apostrophes, and accordingly the apostrophe is now
excluded from word separators in Italian.
This code was only used for Italian, and in the general case
it does the wrong thing; it was only needed by limitations of
the old dictionary.

Bug: 6929108
Change-Id: I7ff4615e01899a1cebed2c4c51679cd0746740fe
 2012-08-04 01:15:04 +09:00
Jean Chalard
54e84a00fc Make a makedict command for dicttool (A3) 
This behaves exactly as the old makedict command. Further
changes will redirect the calls to makedict to this, so as
to consolidate similar code.

Groundwork for
Bug: 6429606

Change-Id: Ibeadbf48bec70f988a15ca36ebf5d1ce3b5b54ea
 2012-08-04 01:11:46 +09:00
Jean Chalard
3f80541844 Merge "Fix an OOB exception" into jb-mr1-dev 2012-08-03 07:17:37 -07:00
Jean Chalard
4c976aceee Fix an OOB exception 
Not sure exactly how this can happen, but at least this should
prevent us from crashing.

Bug: 6920884
Change-Id: I451864756b48c5cb5e98b06edee917d88766d77f
 2012-08-03 23:10:47 +09:00
Tadashi G. Takaoka
622d6a5b1b Using hardware accelerated drawing 
When Canvas has been hardware accelerated, don't use offscreen bitmap.

Bug: 6872994
Change-Id: I1121f76377991692bc29ebeedbfbfa1b2a12dbb7
 2012-08-03 20:46:10 +09:00
Tadashi G. Takaoka
ffe36cdc6d Merge "Small cleanup for keyboard drawing code" into jb-mr1-dev 2012-08-02 01:04:05 -07:00
Tadashi G. Takaoka
8344259fc9 Small cleanup for keyboard drawing code 
Change-Id: I8b562e03b30f82dddae311b49d316402e867cd31
 2012-08-02 16:50:31 +09:00
Tadashi G. Takaoka
76c242a1f6 Merge "Fix multi-touch input in auto-caps field" into jb-mr1-dev 2012-08-01 23:45:24 -07:00
Ken Wakasa
fb955693d4 Enable hardware accelerated drawing for SoftInputWindow of LatinIME 
Taking advantage of Ib6a8bda46223ce1153f32834daf02a820d16136e

bug: 6872994
Change-Id: I799b25b6509980dd9f039bead9bc926b42cbb040
 2012-08-02 15:11:31 +09:00
Tadashi G. Takaoka
44972bcdb6 Fix multi-touch input in auto-caps field 
Bug: 6905194
Change-Id: I7f9f61f36b7f3aa2b40c126a68232a947976aad2
 2012-08-01 18:56:11 +09:00
Tadashi G. Takaoka
d2173b5737 Cancel the while-typing timer when user hits the spacebar 
Bug: 6689079
Change-Id: I6b366acdcefb8b2c0d973a4f2a12329fc12eb5c5
 2012-07-31 19:39:52 +09:00
Tadashi G. Takaoka
b98b957424 Fix east slavic keyboard layouts 
This change affects Ukrainian, Belarusian, Kyrgyz, and Russian
keyboard. The followings are the layout changes for each language
respectively.

[Ukrainian]
 * Replace useless CYRILLIC LETTER E with CYRILLIC LETTER UKRAINIAN IE.
 * Replace useless CYRILLIC LETTER HARD SIGN with CYRILLIC LETTER YI
   on 10-inch tablet.
 * Add CYRILLIC LETTER GHE WITH UPTURN as more keys of CYRILLIC LETTER
   GHE.

[Belarusian]
 * Add CYRILLIC LETTER IO as more keys of CYRILLIC LETTER IE.
 * Replace useless CYRILLIC LETTER HARD SIGN with CYRILLIC LETTER IE
   on 10-inch tablet.

[Kyrgyz]
 * Add CYRILLIC LETTER IO as more keys of CYRILLIC LETTER IE.
 * Remove CYRILLIC LETTER HARD SIGN from more keys of CYRILLIC LETTER
   HA because CYRILLIC LETTER SOFT SIGN has it.

[Russian]
 * Remove CYRILLIC LETTER HARD SIGN from more keys of CYRILLIC LETTER
   HA because CYRILLIC LETTER SOFT SIGN has it.

This change also replace misspelled "more_keys_for_cyrillic_ye" text
name with "more_keys_for_cyrillic_ie".

Bug: 6881007
Change-Id: I9e88c4e27f66225e1676f2b286a7e55b9f2cbf5b
 2012-07-31 13:19:11 +09:00
Jean Chalard
f68fe7a9c9 Don't forward phantom space state on stripper input 
Bug: 6890540
Change-Id: I923b24e3bc17e7b923be4940ad739b58dca24a1f
 2012-07-31 01:48:10 +09:00
Tadashi G. Takaoka
ca57f5ba40 Move gesture preview parameters to KeyboardView attributes 
Change-Id: Iff9d6b485e202656fc869f3ff4d94575ad2c186f
 2012-07-30 20:10:48 +09:00
Tadashi G. Takaoka
6b9677d84b Merge "Small fix to KeyboardView" into jb-mr1-dev 2012-07-30 01:48:59 -07:00
Tadashi G. Takaoka
b9770cb7f7 Merge "Add device form factor to KeyboardId" into jb-mr1-dev 2012-07-30 00:50:25 -07:00
Tadashi G. Takaoka
edf7990e84 Small fix to KeyboardView 
Change-Id: Ifb7500ec2e55b50bb7951aa847fd4fbf49e32f4e
 2012-07-30 16:50:03 +09:00
Tadashi G. Takaoka
293f062c26 Merge "Add advanced options to turn on/off the gesture trail and text preview" into jb-mr1-dev 2012-07-30 00:22:41 -07:00
Tadashi G. Takaoka
47e2bf3298 Add advanced options to turn on/off the gesture trail and text preview 
Bug: 6883053
Change-Id: I601718afb37289108b45ef68626c7c315edca35d
 2012-07-30 15:54:27 +09:00
Tadashi G. Takaoka
75fb3ce1be More readable Key.toString() and MoreKeySpec.toString() 
Change-Id: Iee3c33dedd0c00ba259aa55e8b0c1c57b84eccdd
 2012-07-30 15:51:41 +09:00
Tadashi G. Takaoka
4731b67629 Add device form factor to KeyboardId 
This is a groundword for optimizing keyboard parsing.

Bug: 6860259
Change-Id: Ie65aa502b18c920e25cf2998b79120b3cc835952
 2012-07-30 15:33:17 +09:00
Tadashi G. Takaoka
efd8b838ee Add MoreKeySpec.toString() method for debugging 
Change-Id: Icf9c6e15521849ffc51911c1e256c9815c1960f4
 2012-07-30 15:06:26 +09:00
Jean Chalard
79d4c70b93 Merge "Don't auto-correct when there are digits." into jb-mr1-dev 2012-07-27 09:12:01 -07:00
Jean Chalard
e7c471a52f Don't auto-correct when there are digits. 
Bug: 6667462
Change-Id: I796655f57c71c9f50ae6e38dd08b71df3998dbcf
 2012-07-28 00:15:54 +09:00
Jean Chalard
78ee77ad08 Merge "Fix a bug with autocaps" into jb-mr1-dev 2012-07-27 05:19:48 -07:00
Jean Chalard
6fc72cae20 Fix a bug with autocaps 
Port of Iece016f4

Bug: 6886405
Change-Id: I148c296d8a3841c40b6748e73ed2b0fff473b627
 2012-07-27 21:09:25 +09:00
Tadashi G. Takaoka
1057670881 Make PreviewPlacerView final 
This is a groundwork for the bug.

Bug: 6883053
Change-Id: I51e9235d3bc7021790a88a44596c4314125a1ab3
 2012-07-27 19:40:39 +09:00
Tadashi G. Takaoka
99906b3fc2 Move SuddenJumpingTouchEventHandler to internal package 
Change-Id: Ifc9fb6322a2edbaac0b10e7134ee7e735f14937b
 2012-07-27 14:25:53 +09:00
Jean Chalard
7677a0ee7f Merge "Handle correctly the restarting argument" 2012-07-26 06:47:59 -07:00
Jean Chalard
aa906c36aa Handle correctly the restarting argument 
Bug: 6851364
Change-Id: Ie939a43b8527a76aec213b702d3d850717f22a81
 2012-07-26 21:57:15 +09:00
Tadashi G. Takaoka
97c8d288a8 Add Zulu keyboard 
Bug: 6867914
Change-Id: I13316ac2a554a8601f920e875d540e5375e12860
 2012-07-26 19:03:35 +09:00
Tadashi G. Takaoka
e863fb712f Merge "Fix gesture detection when sliding key input is disabled" 2012-07-26 02:13:20 -07:00
Tadashi G. Takaoka
c902dfeb8f Fix gesture detection when sliding key input is disabled 
Bug: 6867837
Change-Id: Icbfa69928c436343db545860a7d63171f52266b6
 2012-07-26 17:41:54 +09:00
Tadashi G. Takaoka
b90363e40c Fix Afrikaans more keys layout 
Bug: 6867914
Change-Id: I43178a729f4770743f9fea87bad539c54da045c5
 2012-07-26 16:31:06 +09:00
Tadashi G. Takaoka
55c01170c4 Add Afrikaans keyboard layout 
Bug: 6867914
Change-Id: Ice35b20a0a51dda21c8271256064523bb5844952
 2012-07-26 15:57:35 +09:00
Tadashi G. Takaoka
941f222c21 Merge "Remove unused setProximityCorrectionEnabled() methods" 2012-07-25 19:54:40 -07:00
Ken Wakasa
e55d78ab0c Stop swallowing an UnsatisfiedLinkError 
Change-Id: I37d61274e1527229befabae2c392fd78e279b807
 2012-07-26 09:15:39 +09:00
Charles Chen
e1643ed694 Merge "Add accessibility descriptions for additional non-character keys." 2012-07-25 11:29:56 -07:00
alanv
ba037c62ac Add accessibility descriptions for additional non-character keys. 
Bug: 6621009
Change-Id: I82fb2dc6af0fda795397e8be8c09a4f53b1656ab
 2012-07-25 11:03:41 -07:00
Shawn Pearce
0a370ac80f Merge "Add Swahili keyboard layout" 2012-07-25 10:58:44 -07:00
Tadashi G. Takaoka
c4376db0f0 Remove unused setProximityCorrectionEnabled() methods 
Change-Id: I03aa6608ee435b36377de41684162b303740f571
 2012-07-25 20:37:36 +09:00
Tom Ouyang
2f81757c3a Add dynamic floating preview for incremental gesture recognition. 
Change-Id: I7ba7ac24aa96a0ff19267997c5b58853079bc6dc
 2012-07-25 19:40:55 +09:00
Tadashi G. Takaoka
a28f6c9a18 Add Swahili keyboard layout 
Bug: 6867914
Change-Id: I2b9b0a06ff49a2afe16ec7a0ace0503d1658d413
 2012-07-25 17:48:37 +09:00
Tom Ouyang
e68385871a Fix gesture trail rendering on tablet. 
Bug: 6867837
Change-Id: I54dceee1c83679f78462104d6cee1f2300a0cfc2
 2012-07-25 16:12:37 +09:00
Tadashi G. Takaoka
0657b9698a Update gesture mode state when dictionary gets available 
Bug: 6860204
Change-Id: I840b7bf1983ab92fa4e0b180129176539e96409f
 2012-07-25 16:11:53 +09:00
Tadashi G. Takaoka
369e54cc33 Add Suggest initialization finish listener 
Bug: 6860204
Change-Id: I1e4c03c99415cd9bdea5a8556ff4093c33f0f508
 2012-07-25 09:55:22 +09:00
Tadashi G. Takaoka
9ecf634686 Add Seriban Latin keyboard layout as comments 
Bug: 6867914
Bug: 6867842
Change-Id: I3434434628e72fdb127d158de6c17fdfa77ee9c8
 2012-07-24 20:07:59 +09:00
Tadashi G. Takaoka
a01d9aea64 Add Tagalog keyboard layout 
Bug: 6867914
Change-Id: I78ca6216cc74f8d34291950c05c810c800a3ddba
 2012-07-24 18:54:43 +09:00
Tadashi G. Takaoka
506259396f Merge "Update gesture suggestions even when suggestions strip is off" 2012-07-23 03:45:21 -07:00
Tadashi G. Takaoka
7575ac7054 Update gesture suggestions even when suggestions strip is off 
Bug: 6852483
Change-Id: I873ae0f2e3bc863e989629f8bc0cc90ee33a4920
 2012-07-23 19:37:00 +09:00
Jean Chalard
c0f0ceeccf Merge "Fix a bug with the 'add to dict' hint popping up too much" 2012-07-23 03:20:01 -07:00
Jean Chalard
491d451e38 Fix a bug with the 'add to dict' hint popping up too much 
Not having a main dictionary is not sufficient reason to display
the hint. If the user already added the word to the dictionary then
we shouldn't be displaying it again, even if we don't have a main
dictionary for the current language.

Bug: 6829798
Change-Id: I6b081f51c82ef395fe2e394fd3167363e743ea6f
 2012-07-23 18:32:13 +09:00
Tadashi G. Takaoka
259905ba90 Rename suggestion strip related methods 
Change-Id: I942692bbc2e577482f353d875405c4658a1102fc
 2012-07-23 18:04:02 +09:00
Tadashi G. Takaoka
4702671ea4 Rename SuggestionsView to SuggestionStripView 2012-07-23 15:37:43 +09:00
Tadashi G. Takaoka
c8e45ddb03 Rename LatinKeyboardView to MainKeyboardView 
Change-Id: I8f3123b8d727c7beb72e226f80c17794f89c8b60
 2012-07-23 12:11:43 +09:00
Kurt Partridge
a4f762ff98 Merge "ResearchLogging indicator" 2012-07-22 19:31:40 -07:00
Kurt Partridge
4fa6e57260 ResearchLogging indicator 
- shows a indicator that logging is on.  two options are available: an obvious
red outline around the keyboard, and a subtle red dot in the lower right-hand
corner.  currently configured for the subtle red dot.

Bug: 6188932
Change-Id: I0fd1ac5a0f20329adc603aa65ab85f2d38b9fc43
 2012-07-22 19:04:34 -07:00
Kurt Partridge
74c95d6d18 Merge "ResearchLog splash screen" 2012-07-22 18:53:38 -07:00
Kurt Partridge
f0c6606807 Merge "ResearchLogger feedback form" 2012-07-22 18:53:30 -07:00
Kurt Partridge
4331012a9e ResearchLog splash screen 
Bug: 6188932
Change-Id: I1b247ecc26a2dd4f3f1c1b1cd3d928af717ebdd5
 2012-07-22 18:36:43 -07:00
Kurt Partridge
3c233bf1a5 ResearchLogger feedback form 
- also cleaned up RLog menu

multi-project commit with If0fd4fef89d390073e6939d5188ed5696866cb33

Bug: 6188932
Change-Id: I4f66f13bd366b4e8bde742ccd0704f812c6d33f9
 2012-07-22 18:36:24 -07:00
Tom Ouyang
ccaa799ee9 Update gesture bounding box handling. 
Change-Id: I085611ce6fd82608f284d74973e5bb14258cdc24
 2012-07-22 10:54:27 +09:00
Kurt Partridge
9c539d5a5c ResearchLog uploading 
- uploads files in the background to server

multi-project commit with Ie0d937773e04b2fbefc8d76c231aaa52ebc392c9

Bug: 6188932

Change-Id: I90bb0e237eeb567e4cbb51085f2229f17f1fe71c
 2012-07-20 15:24:48 -07:00
Kurt Partridge
6b966160ac ResearchLog refactor 
- new package: com.android.inputmethod.research

multi-project commit with Ic0a5744f3160d13218addd589890623c0d120ffc

Bug: 6188932

Change-Id: Icf8d4a40a5725401799be6e209a640d99a5f34c4
 2012-07-20 15:06:51 -07:00
Tadashi G. Takaoka
7519091f7c Use ResizableIntArray in GestureStroke 
Change-Id: I034e80df03c7c6c0895fdf2c03763627d410d425
 2012-07-20 19:32:28 +09:00
Tadashi G. Takaoka
2474b37abd Merge "Disable gesture input detection when more keys keyboard is showing" 2012-07-20 03:28:52 -07:00
Tadashi G. Takaoka
62b8dddb6d Add gesture input enable settings 
Bug: 6845325
Change-Id: I3165465b0b280e32a9288da16abb75baa67288dc
 2012-07-20 19:26:36 +09:00
Tadashi G. Takaoka
cc3500b0c8 Disable gesture input detection when more keys keyboard is showing 
Bug: 6852441
 2012-07-20 18:40:31 +09:00
Tom Ouyang
b8bd45a22a Merge "Fix bug where key previews do not show up." 2012-07-20 02:06:29 -07:00
Tom Ouyang
c022a9f8d4 Fix bug where key previews do not show up. 
Bug: 6852705

Change-Id: Ib90107a5dde774b4d6c1e570629ce7f7eaff44bc
 2012-07-20 18:02:12 +09:00
Ken Wakasa
afed0567e9 Performance improvements - Avoid using iterators 
Change-Id: Iab604aa1ef67acf5d54208a6bc44635632845ae0
 2012-07-20 17:51:52 +09:00
Tom Ouyang
528738341d Merge "Add gesture trail feedback." 2012-07-20 01:26:30 -07:00
Tom Ouyang
4daf32b6c0 Add gesture trail feedback. 
Change-Id: I32709fac0dec3165678a052aa286e2fb3d90721b
 2012-07-20 17:09:23 +09:00
Tadashi G. Takaoka
2f6a90ac31 Merge "Implement ResizableIntArray.fill" 2012-07-20 00:33:07 -07:00
Tadashi G. Takaoka
7abdcf1ed3 Implement ResizableIntArray.fill 
Change-Id: I570641bc2f32d016c247db6c065a138d8235ab8c
 2012-07-20 16:05:37 +09:00
Tadashi G. Takaoka
732edc1ff1 Merge "Fix NPE where the current subtype is null" 2012-07-19 22:57:39 -07:00
Tadashi G. Takaoka
d6a18cdedb Fix NPE where the current subtype is null 
Bug: 6847999
 2012-07-20 14:51:41 +09:00
Kurt Partridge
48ded4e3b1 Merge "ResearchLogger: make logging more reliable (esp on startup)" 2012-07-19 21:31:41 -07:00
Tadashi G. Takaoka
19ac19e5fd Merge "Implement ResizableIntArray.setLength and .get" 2012-07-19 20:44:54 -07:00
Ken Wakasa
2fc127698a Make ALPHA_OPAQUE public 
Change-Id: I904685be07e23292dd95296617a4b64c366f06f2
 2012-07-20 12:17:31 +09:00
Tadashi G. Takaoka
c49c85f835 Implement ResizableIntArray.setLength and .get 
This change revises ResizableIntArrayTests as well.
 2012-07-20 12:02:38 +09:00
Tom Ouyang
0c5f72e2bf Improve incremental gesture tracking. 
Eliminates need to recreate batch InputPointers on each gesture move event.
Fixes issue where batch points from previous tapping input get mixed into next gesture.

Change-Id: I9ecac66db88f5a87c6dde2138408906dd3d11139
 2012-07-20 10:44:37 +09:00
Kurt Partridge
0df487678e ResearchLogger: make logging more reliable (esp on startup) 
Bug: 6188932
Change-Id: I692e427ba2e6da7bb15f48208304c4a034392a22
 2012-07-19 09:00:21 -07:00
Tadashi G. Takaoka
9370ab9ada Make ScalableIntArray public as ResizableIntArray 
Change-Id: Ibbbc117214912ffa192c694bde5b7d55154f40c4
 2012-07-19 20:37:53 +09:00
Tadashi G. Takaoka
1e6f39a9f9 Tune the gesture detection logic a bit 
Change-Id: Ia8e8c15fdbbd49768d57cafd50325e7e45af6251
 2012-07-19 18:53:39 +09:00
Tadashi G. Takaoka
918e420d1b Gesture input should be turned off depending on the configuration 
The gesture input will be disabled when
 * It is AOSP build.
 * Accessibility mode is on.
 * The input field is password mode.

Bug: 6844755
Bug: 6844763
Bug: 6845011
Change-Id: I74972cc765d15c08059e0c9014f863ffb2a57c6c
 2012-07-19 16:33:09 +09:00
Tadashi G. Takaoka
57f7de0ba6 Add default capacity parameter to InputPointers' constructor 
Change-Id: I02f23096f0682d30effe4dfc1ca57881a1e4aedc
 2012-07-19 12:06:00 +09:00
Tadashi G. Takaoka
9580c467f9 Consolidate GestureTracker into PointerTracker 
Change-Id: Ib28fae10493a9142ba4dff6cf57f52c59766b209
 2012-07-18 20:11:06 +09:00
Tadashi G. Takaoka
10102f02af Change the batch input methods of KeyboardActionListener 
This change also removes the reference of SuggestedWords from
GestureTracker and KeyboardActionListener.

Change-Id: I25ef8756007986abf99a931afd665bbfe6fa387f
 2012-07-18 18:53:36 +09:00
Tadashi G. Takaoka
f39fccbd0f Make GestureStroke as top level class 
And make PointerTracker object has GestureStroke object.

Change-Id: Ibf5cfd593c4f13468368e01acb847589b0ab12e7
 2012-07-18 17:32:17 +09:00
Tadashi G. Takaoka
3ec31f4971 A gesture should not start from the delete key 
Change-Id: I5c8c7665454b7f10f944f307431dfffe20cf3134
 2012-07-18 14:38:51 +09:00
Tadashi G. Takaoka
af2c115253 Opening punctuations have a priority in Spanish keyboard 
Bug: 6737535
Change-Id: I87442eb978ac68be3d3df99eed8a92877a6f4ab0
 2012-07-17 16:14:36 +09:00
Kurt Partridge
5e53542489 Merge "delete old ResearchLog files" 2012-07-16 09:41:10 -07:00
Kurt Partridge
81dae8d015 delete old ResearchLog files 
cleans out the local directory of files that may have persisted
accidentally because of system crashes, etc.  default lifetime is
curently 1 day.

Bug: 6188932
Change-Id: I4b51169d6dd0eddb6bf8b661165f88e63782ce7d
 2012-07-13 20:25:38 -07:00
Kurt Partridge
73c5dbd9d2 researchLog records versionCode, versionName 
Bug: 6188932
Change-Id: I3d8502a5397035be5287ea720599e3fda4c669d6
 2012-07-13 20:21:18 -07:00
Tom Ouyang
eea34598bf Merging minimal gesture input 
Change-Id: Iee6ae48bb6309c2867b5d2e344fe7d86dfabd654
 2012-07-13 19:32:18 +09:00
Jean Chalard
e9808694fe Fix a bug where the word composer is not correctly reset 
...upon commit

Change-Id: I1fea87cb4c133a0884329eb9b61bf3053c36cd1b
 2012-07-13 13:31:27 +09:00
Tadashi G. Takaoka
7247bff6d6 Fix InputPointers.append 
Change-Id: I6995f9b2ed00b9f948e1299e576a5e24725d58f8
 2012-07-13 11:46:03 +09:00
Jean Chalard
c7387a4fd0 Add values for suggestion types (A120) 
Also, use it in getBigrams.

Change-Id: Ia0be9b57d1b7effcd8a936e01e957d1195b39c68
 2012-07-12 19:21:44 +09:00
Jean Chalard
6931df9c17 Pass an array to output suggestion types (A119a) 
This needs the matching A119b change to not break the build.
The array is passed, but not used yet.

Bug: 6166228
Change-Id: Ia91d658461d989ee8c94e9b31bb06f4a36f4c5b6
 2012-07-12 19:21:42 +09:00
Jean Chalard
2c5cf744e5 Increase encapsulation (A118) 
showSuggestions is only ever called by updateSuggestionsOrPredictions.
It only feels natural that, when called with a 0-sized or null
suggestion list, it clears the suggestions.

Change-Id: I5b52bc9151afca1bb6c6f0a7f81e3255add92177
 2012-07-12 15:58:16 +09:00
Jean Chalard
1343d27de3 Readability improvement (A117) 
Change-Id: I6f8bb05a23edb40a079da60b7136170ec9043282
 2012-07-12 15:58:16 +09:00
Jean Chalard
24a63b5537 Simplification (A116) 
Change-Id: I97cf92a7b0dabc251dd241b24978ea00d1e5f047
 2012-07-12 15:58:16 +09:00
Jean Chalard
f5b55cb70c Compute variables closer to where they are used (A115) 
This improves locality, it's better for readability/performance

Change-Id: Ibb1efaf86e362dd2c9398722d0da2144df96b333
 2012-07-12 15:58:09 +09:00
Jean Chalard
2549b4978e Cleanup (A114) 
Change-Id: I7e24e0aeae7c004cae310ae9f46cf90dac2d4d14
 2012-07-12 15:09:57 +09:00
Jean Chalard
02f1c1534c Cleanup (A113) 
If not composing a word, then consideredWord is always the empty
string.
Hence, it's never whitelisted, but it's also always "NotAWord",
so isWhitelistedOrNotAWord returns always true, so
allowsToBeAutoCorrected is always true. Which means that
isPrediction implies allowsToBeAutoCorrected == true.
Thus, !isPrediction && !allowsToBeAutoCorrected is strictly
equivalent to !allowsToBeAutocorrected.

Change-Id: I4ad7a7c3447851c539646d97cf55ff065e6ee115
 2012-07-12 15:09:48 +09:00
Jean Chalard
ae13061245 Simplification (A112) 
If we are not composing a word, that isFirstCharCapitalized
and isAllUpperCase are guaranteed to return false.

Change-Id: Ic4a0be9574acf4653c729a9594f963f5bcf0c757
 2012-07-12 14:30:33 +09:00
Jean Chalard
d8afa2fbe1 Remove the ultimate code duplication (A111) 
Change-Id: I7c76613df8f148feb02765f187db3ca6dc577977
 2012-07-12 14:30:33 +09:00
Jean Chalard
3b57631b60 Resolve a TODO: bury some implementation detail in native (A110) 
The fact that prediction does not accept a null argument is an
implementation detail, it should not be visible to Java code.

Change-Id: I3a156b323b6db9353de898d33f3f7c81751cecb1
 2012-07-12 14:30:30 +09:00
Jean Chalard
18d76afa91 Remove an unused method (A109) 
Change-Id: Ib785b7e8c554d030395e2c0ca92edb44eb2b245f
 2012-07-12 14:30:03 +09:00
Jean Chalard
251f302985 Stop using a redundant method (A108) 
Change-Id: Iffc0bae0a273419e7c50d69526c0c8e402c6461c
 2012-07-12 14:30:00 +09:00
Jean Chalard
6a5d17cd2f Remove a useless parameter (A106) 
Change-Id: Ic0ecea22212fd1a098a3a168da460374e446f4a3
 2012-07-12 11:28:16 +09:00
Jean Chalard
b7d7c5a369 Make a constant really constant (A104) 
Change-Id: Ied1f9f96a574b1e6a8ee0a71bfb1604d9c962e1c
 2012-07-12 11:16:30 +09:00
Jean Chalard
e4e7e5fc82 Cleanup (A103) 
Change-Id: Ib5ebddfdb87ef71a2f8d859fb45d3ac78040e97a
 2012-07-11 16:14:58 +09:00
Tadashi Takaoka
5e21ea1a35 Revert "Workaround to avoid a bug in the batch input bigram dictionary lookup" 
This reverts commit 1250cdeab2
 2012-07-11 00:07:08 -07:00
Tadashi G. Takaoka
1250cdeab2 Workaround to avoid a bug in the batch input bigram dictionary lookup 
Change-Id: I8a5641c88c45918d6bed81a0b03efdcff0b380c5
 2012-07-11 15:38:13 +09:00
Jean Chalard
9c09fd02eb Inline a method to be able to factorize code (A102) 
Change-Id: I121071f80c8af3c1053968dc76aaeca3352ca9a8
 2012-07-11 14:57:51 +09:00
Jean Chalard
d6c610400e Inline a wrapper method (A101) 
Change-Id: I6ce856ff49a8f8c696851b2487590704010fc758
 2012-07-11 14:57:51 +09:00
Tadashi G. Takaoka
eb1443883f Support batch input 
Change-Id: Ibe63212fe71cdebb5b897bc5018ae75b2a87555a
 2012-07-11 14:53:20 +09:00
Jean Chalard
21e5759e8e Merge "Small readability improvement (A100)" 2012-07-10 22:49:25 -07:00
Jean Chalard
27207eaa04 Merge "Pull up some common code again (A99)" 2012-07-10 22:49:06 -07:00
Jean Chalard
722b00275d Merge "Pull up some identical code (A98)" 2012-07-10 22:48:58 -07:00
Jean Chalard
8b166465b0 Merge "Inline a method to avoid confusion (A97)" 2012-07-10 22:48:52 -07:00
Jean Chalard
fd9b485111 Merge "Remove parameters for easier inlining (A96)" 2012-07-10 22:48:44 -07:00
Jean Chalard
0b329fd0d1 Merge "Pull up some more common code (A95)" 2012-07-10 22:48:38 -07:00
Jean Chalard
a5acd68caa Merge "Pull up common code in the caller (A94)" 2012-07-10 22:48:33 -07:00
Kurt Partridge
0d54692ce4 Merge "intentional logging" 2012-07-10 21:20:47 -07:00
Jean Chalard
82d5ed6fcd Small readability improvement (A100) 
Change-Id: I6340748654a95d203ed43ceb9a7e6468b5b8ab1c
 2012-07-11 11:19:50 +09:00
Jean Chalard
860a9f85ff Pull up some common code again (A99) 
Change-Id: I9e9f5664bb12bb25d74c8a076a6ee1024c708145
 2012-07-11 11:19:50 +09:00
Jean Chalard
8eaeb60e7f Pull up some identical code (A98) 
Change-Id: I6c265956394cf49e74b0256dfa5af06fe6b30467
 2012-07-11 11:19:33 +09:00
Jean Chalard
e77f2996ea Inline a method to avoid confusion (A97) 
Change-Id: I3c3ffcd3d40493f4bfa0f6596f923b3430e605aa
 2012-07-11 11:19:18 +09:00
Jean Chalard
cfae32c610 Remove parameters for easier inlining (A96) 
Change-Id: Ied2e291393609300173681e26e82b7dd36b41bd0
 2012-07-11 11:16:22 +09:00
Jean Chalard
ea98e026f1 Pull up some more common code (A95) 
Change-Id: I3ac7ee823471a6d1da8031e064bce38b0e5a8f5c
 2012-07-11 11:15:18 +09:00
Jean Chalard
b4b93dbf3e Pull up common code in the caller (A94) 
Change-Id: I84b97886280eca75d5f2b7546f20f8b1bced55bc
 2012-07-11 11:13:56 +09:00
Kurt Partridge
223d671ffc intentional logging 
- separate ResearchLog from ResearchLogger
- fix abort menu to explicitly indicate re-enabling of logging
- auto flush entries every 5s
- conform to new suggestedWords class

multi-project change with I9fe1f8fe59d5891daa4ca84af157f36fb1bb17dc

Bug: 6188932

Change-Id: I7e99390f934481c6ed9cea2b259944583edda5bb
 2012-07-10 18:44:18 -07:00
Tadashi G. Takaoka
86ade47236 Merge "Initialize SubtypeLocale from Settings (DO NOT MERGE)" into jb-dev 2012-07-10 18:32:19 -07:00
Jean Chalard
ff730dbd14 Merge "Remove useless member variables (A93)" 2012-07-10 04:33:32 -07:00
Tadashi G. Takaoka
20823b4623 Merge "Register the key when the finger slides off it in multitouch" 2012-07-10 04:19:40 -07:00
Jean Chalard
6f233f7ba1 Remove useless member variables (A93) 
Change-Id: Iff0a0e8835f4d630b51a15c0d91881437094e785
 2012-07-10 20:18:10 +09:00
Tadashi G. Takaoka
5e06b8534f Register the key when the finger slides off it in multitouch 
Moved from jb-dev branch (I807fd6f4).

Bug: 6722867
Change-Id: I9764ac72f726396caaac819675d440372c882981
 2012-07-10 20:14:29 +09:00
Jean Chalard
2ae75ed56b Start converging two identical methods (A92) 
Change-Id: I3c85a80610fde664a328f5606d0724f00d445ebe
 2012-07-10 20:13:54 +09:00
Tadashi G. Takaoka
d82dcdc924 Add batch input dictionary lookup 
Change-Id: I4da3c976838e8eb56c9ec80aafaaf54d759b7981
 2012-07-10 20:01:28 +09:00
Jean Chalard
5e573a1f0a Remove a useless parameter (A91A) 
Change-Id: I1d1758048649ef337875a5141d825569af7ad38c
 2012-07-10 19:31:36 +09:00
Jean Chalard
f5943153ad Cleanup old methods (A90) 
Change-Id: I5435cef8ac6be523934ffa394952cb120c8e89d6
 2012-07-10 19:30:46 +09:00
Jean Chalard
b30d2185f2 Implement the common Dictionary interface (A89) 
This will de-duplicate a lot of existing code.

Change-Id: Idaffb2fde23b9741f057bcb2ecb3dde9d12ea5c5
 2012-07-10 19:30:42 +09:00
Jean Chalard
a69f12a246 Reduce method visibility (A88) 
Change-Id: I29d6afbcba0998558c9b19287a460d9f0e410994
 2012-07-10 19:19:47 +09:00
Jean Chalard
0f57bdc0e5 Factorize code (A87) 
Why was this copy-pasted :(

Change-Id: I6a537c56425ad039d7301a5fe1e0485784f07914
 2012-07-10 19:19:43 +09:00
Jean Chalard
4e42e378fa Move stuff around for readability (A86) 
Change-Id: I5f4a18e43f3012acf96978d625325bf7c69c9c80
 2012-07-10 18:57:57 +09:00
Jean Chalard
82009901ea Add a consolidated method to the Dictionary interface (A85) 
Change-Id: I5d79021e69cc738e3013e31764ab0a59e15decdf
 2012-07-10 18:57:12 +09:00
Jean Chalard
2a37fb9d30 Refresh the cached single quotes count on commit 
Change-Id: I9df5cf95c14da2e11ac709ca5e32dc7db3b02c37
 2012-07-10 18:43:42 +09:00
Jean Chalard
a9632d8173 Merge "Enhance behavior consistency (A84)" 2012-07-10 02:31:40 -07:00
Jean Chalard
184c552917 Merge "Refactoring for whitelist (A83)" 2012-07-10 02:24:58 -07:00
Jean Chalard
b53e96813c Merge "Refactoring (A82)" 2012-07-10 02:24:47 -07:00
Jean Chalard
50d1b7902f Merge "Fix a bug with suggestion behavior (A81)" 2012-07-10 02:24:36 -07:00
Jean Chalard
a4d346c37a Merge "Cleanup visibility in LatinIME (A80)" 2012-07-10 02:21:46 -07:00
Jean Chalard
c677b0071d Enhance behavior consistency (A84) 
Use the word the same way for suggestion and prediction. It makes
little logical sense that the trailing single quotes be removed
for suggestion lookup but not for prediction lookup.

Change-Id: I0de4b5f7c5b4c1b4ba1817ff9653d7c03967146d
 2012-07-10 18:05:20 +09:00
Jean Chalard
1c6693a219 Refactoring for whitelist (A83) 
Avoid special casing the whitelist dictionary by having it implement
the interface it pretends it implements

Change-Id: I8b873cb0f3fe13cefd32c8cb756a25c8ae16a2b4
 2012-07-10 18:05:20 +09:00
Jean Chalard
fb6eeeb35a Refactoring (A82) 
The user history dictionary should be the one knowing it does not suggest words
beyond 2 characters, not Suggest.

Change-Id: Ie85ec6116eb495e0c7f51108e4620c5ae536f4bf
 2012-07-10 18:05:20 +09:00
Jean Chalard
966efe4889 Fix a bug with suggestion behavior (A81) 
Bug: 6788235
Change-Id: I5a4212872e0fd3f9e80168fd3abd5c2b3bc4110f
 2012-07-10 18:05:19 +09:00
Jean Chalard
a5bb353de9 Cleanup visibility in LatinIME (A80) 
Many methods were public but could have been private: change them
to private. Also, add a comment above public methods that don't
come from the IMF to make it clearer why they are necessary.

Change-Id: I574154b015d09c0f8542b81763f497691afdc3c1
 2012-07-10 18:05:15 +09:00
Satoshi Kataoka
7fcad7b9b6 Separate ICS-dependent code from the spell checker service 
Bug: 6789576
Change-Id: Ia768258f6fa121c7a7757093eb8a20e665580865
 2012-07-10 17:45:26 +09:00
Jean Chalard
b98414f8fd Merge "Remove useless code (A79)" 2012-07-10 00:47:56 -07:00
Jean Chalard
29540b25f0 Merge "Simplification (A78)" 2012-07-10 00:47:10 -07:00
Jean Chalard
728c0cb251 Remove useless code (A79) 
We postUpdateSuggestionStrip right away anyway - this only
makes the suggestion strip blink

Change-Id: I2ebd933e9a4c804ef1e8c62ccdaf4953a98a792e
 2012-07-10 16:41:49 +09:00
Jean Chalard
09fdd30e52 Simplification (A78) 
Change-Id: I622503af858ef419e94a17f182253cb03da00462
 2012-07-10 16:41:47 +09:00
Satoshi Kataoka
74620f449e Merge "Create AndroidSpellCheckerSessionFactory" 2012-07-10 00:26:00 -07:00
Satoshi Kataoka
37b19ffe6c Create AndroidSpellCheckerSessionFactory 
Bug: 6789576
Change-Id: I6de1e1aa64cf14f38ecb250579418bc518f0d838
 2012-07-10 16:16:53 +09:00
Satoshi Kataoka
759778a751 Merge "Separate SpellCheckerSession from SpellCheckerService" 2012-07-09 23:42:15 -07:00
Satoshi Kataoka
84ed096641 Separate SpellCheckerSession from SpellCheckerService 
Bug: 6789576
Change-Id: I7c55d36afad7ef6046353b3c9e849a54a6dc83ae
 2012-07-10 15:34:40 +09:00
Jean Chalard
fed702a0ad Merge "Move a test (A77)" 2012-07-09 23:01:33 -07:00
Jean Chalard
75e605f7ca Merge "Pull up common code in the consolidated method (A76)" 2012-07-09 22:41:33 -07:00
Jean Chalard
c466cd3f99 Move a test (A77) 
Change-Id: I417bd5f1318696aaa39fee18f3e750ea5c231f6b
 2012-07-10 14:24:33 +09:00
Jean Chalard
32f5384fc9 Pull up common code in the consolidated method (A76) 
Change-Id: I3ebecec37b49e139c243cf9da8bfe491e7ddada1
 2012-07-10 14:22:12 +09:00
Tadashi G. Takaoka
80973dc76f Merge "A little optimization of InputPointers.copy" 2012-07-09 21:09:13 -07:00
Tadashi G. Takaoka
2ad6d12a30 A little optimization of InputPointers.copy 
Change-Id: Id83b34e076ef91e06d7c1dd2b3ee7bb64d01b8cb
 2012-07-10 13:05:43 +09:00
Jean Chalard
24e8a06f98 am 949d2ae5: am 4bcf70c9: Fix a bad interaction with mmap 
* commit '949d2ae5788977c5e87e35e1bd1770f54ac88f5b':
  Fix a bad interaction with mmap
 2012-07-09 20:24:01 -07:00
Tadashi G. Takaoka
7389c601e3 Merge "Add InputPointers.append() method" 2012-07-09 01:39:38 -07:00
Tadashi G. Takaoka
1087c53f5a Add InputPointers.append() method 
Change-Id: Id2b0e242f7e9ce0ca888067857f8b64c02fde84e
 2012-07-09 17:33:10 +09:00
Jean Chalard
e4498929b0 Simple refactoring (A75) 
Change-Id: Id19efc5d279616da52667fa70326b86aba70d4a0
 2012-07-09 15:06:16 +09:00
Jean Chalard
d579f1aefc Consolidate methods that do the same thing (A74) 
Change-Id: I6e7c3aba2b40ecefa483c9680978bc806368e96e
 2012-07-09 15:06:16 +09:00
Jean Chalard
347a80f793 Tiny refactoring (A73) 
If !mWordComposer.isComposingWord(), then mWordComposer.getTypedWord()
will always return an empty string.

Change-Id: Ife66d0abc44c743cbc30d31724e833cda168fd5c
 2012-07-09 15:06:16 +09:00
Jean Chalard
7a422a0142 Cleanup again (A72) 
Change-Id: Id3765bf9826cc2c7ca70158cda53c75dc58f51c6
 2012-07-09 15:06:16 +09:00
Jean Chalard
37eaa24b5a Simplification (A71) 
Change-Id: I7a91d84291bea581ecc8ec5b29b9a87ccec76e7d
 2012-07-09 15:06:16 +09:00
Jean Chalard
dc1b84d96c Defer testing composition to a later time (A70) 
This is not exactly the same logically speaking, because it's
theoretically possible that the composing state changed in between
the message enqueueing and it's retrieval. However in the practice,
if the composing state changed the message *must* have been
cancelled and resent, else the behavior breaks. So this actually
is more robust, and removes some obscure requirements on the
calling code.

In the practice, it should also make the cancelUpdateSuggestionStrip
message useless, although this change does not yet remove it.

Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
 2012-07-09 15:06:16 +09:00
Jean Chalard
a6757f400a Code simplification (A69) 
Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
 2012-07-09 15:06:16 +09:00
Jean Chalard
8f9c9377fc Consolidate two methods (A68) 
Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
 2012-07-09 15:06:15 +09:00
Jean Chalard
146bd2e456 Pass the value we really want to pass to update functions (A67) 
Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
 2012-07-09 15:06:15 +09:00
Jean Chalard
60dbe0be43 Preparative change to pass a boolean with known value (A66) 
Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
 2012-07-09 15:06:15 +09:00
Jean Chalard
853f4221ab Merge "Remove useless processing (A65)" 2012-07-08 23:05:11 -07:00
Tadashi G. Takaoka
6b4ce58fc6 Remove unused WordComposer.init method 
Change-Id: I46c6a6e1c1536599cb909bf81297001b238f2ec8
 2012-07-06 20:12:14 +09:00
Tadashi G. Takaoka
36311cacd6 Merge "Extend onTextInput to be able to inject suggestions" 2012-07-06 03:40:03 -07:00
Tadashi G. Takaoka
4be03befe3 Extend onTextInput to be able to inject suggestions 
Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
 2012-07-06 19:36:11 +09:00
Jean Chalard
a3dee0d062 Merge "Fix a bug where spaces would be forgotten" 2012-07-06 02:09:28 -07:00
Jean Chalard
4fde56b818 Fix a bug where spaces would be forgotten 
Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
 2012-07-06 17:51:10 +09:00
Jean Chalard
8e36e5102e Remove useless processing (A65) 
We just resetted the composing state - updating suggestions
is sure to yield no results. We may as well not call
updateSuggestions at all.
We should however still cancel any lingering timer from a
previous input field, to avoid this useless processing.

Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
 2012-07-06 16:28:42 +09:00
Jean Chalard
449be371ae Refinement (A64) 
Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
 2012-07-06 16:28:42 +09:00
Jean Chalard
43193ad60f Remove useless code (A63) 
If the separator is not a space, then we will always call
setPunctuationSuggestions and reset the suggestion strip anyway.
If the separator is a space, then the cursor has a space on
the left, which means isCursorTouchingWord depends only on
whether it touches a word on the right. If we were displaying
the "add to dictionary hint", it means a suggestion was just
chosen, so it had to be displayed, and that requires a composing
word and no non-separator at the right of the cursor.

In the end, if we go through this postUpdateSuggestions call,
we are sure we will reset the suggestions later in this method,
either by calling postUpdateBigramPredictions, or
setPunctuationSuggestions.

Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
 2012-07-06 16:28:42 +09:00
Jean Chalard
8ba33c1a49 Simplification (A62) 
Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
 2012-07-06 16:27:55 +09:00
Jean Chalard
66a2e96fb4 Remove useless code (A61) 
Just after this, clear() will be called, removing the suggestion
strip from the screen. It will later be displayed again through
onStartInputView, which will update its content.

Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
 2012-07-06 13:07:48 +09:00
Jean Chalard
b1dc8ad5f2 Simplification (A60) 
Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
 2012-07-06 13:07:48 +09:00
Jean Chalard
663dbfd1cc Simplification & UI improvement (A59) 
The responsivity is better like this. This does not seem to
feel slow as the previous comment seemed to indicate.

Also remove a stale comment.

Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
 2012-07-06 13:07:48 +09:00
Jean Chalard
746e014eb5 Show predictions in the right cases (A58) 
After reverting an auto-correct we always have a separator after
the previously inserted word, and the cursor is never touching
a word. Showing predictions is the right thing to do, while
calling postUpdateSuggestions will invariably yield an invariably
blank suggestion strip, which is not very helpful.

Likewise, after we pick a suggestion, we should be showing the
predictions unless showing the addToDictionary hint. There was
a bug here in the corner case that the word would be a candidate
for user dictionary, but the user dictionary provider is not
available: in this case we should be showing predictions, but
we were showing an unhelpful empty suggestion bar.

Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
 2012-07-06 13:07:48 +09:00
Jean Chalard
0e9e7e337d Cleanup (A57) 
We stopped cancelling manual picks a few weeks ago. This code
is dead.

Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
 2012-07-06 13:07:30 +09:00
Jean Chalard
29eeef75ec Merge "Fix a bug where the caps mode would not be changed" 2012-07-05 19:11:28 -07:00
Jean Chalard
f254e3fec7 Fix a bug where the caps mode would not be changed 
Bug: 6766059
Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
 2012-07-06 11:08:20 +09:00
Jean Chalard
d81e7d24d3 Simplification (A56) 
If suggestion and prediction messages both happen to be in
the queue, the latest one will win (update the suggestion strip
later than the other, overwriting any previous suggestions).
So when we enqueue either one, it is always safe to cancel
all messages of both types.

Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
 2012-07-05 18:19:51 +09:00
Jean Chalard
414f14436e Remove an unused method (A55) 
Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
 2012-07-05 18:10:37 +09:00
Jean Chalard
c84f178cd9 Merge "Remove a useless method, rename another. (A54)" 2012-07-05 02:05:50 -07:00
Tadashi G. Takaoka
92d2f7e03b Merge "Initialize SubtypeLocale from Settings" 2012-07-05 02:04:35 -07:00
Jean Chalard
792e7ddc24 Merge "Remove a redundant test (A53)" 2012-07-05 01:57:04 -07:00
Jean Chalard
9636735c0a Merge "Small simplification (A52)" 2012-07-05 01:56:55 -07:00
Jean Chalard
21524c755c Merge "Put some more code in common (A51)" 2012-07-05 01:50:44 -07:00
Jean Chalard
71d7fc91b7 Merge "Pull up a common variable into the wrapping method (A50)" 2012-07-05 01:47:59 -07:00
Jean Chalard
ac3ad6ef9f Merge "Factorize some common code (A49)" 2012-07-05 01:45:08 -07:00
Tadashi G. Takaoka
bffa6cc1b2 Initialize SubtypeLocale from Settings (DO NOT MERGE) 
Bug: 6781106
Change-Id: Ic1b2b8363486820eabaa415ab3812c0e8565b7bb
 2012-07-05 17:40:13 +09:00
Tadashi G. Takaoka
d6ac0443f0 Initialize SubtypeLocale from Settings 
Bug: 6781106
Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
 2012-07-05 17:39:30 +09:00
Tadashi G. Takaoka
15d3532170 Merge "Fix tab key's navigation behavior" 2012-07-05 01:24:00 -07:00
Jean Chalard
3d8e7a62fc Remove a useless method, rename another. (A54) 
Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
 2012-07-05 17:22:15 +09:00
Jean Chalard
0783366036 Remove a redundant test (A53) 
Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
 2012-07-05 17:22:04 +09:00
Jean Chalard
4cba560dbb Small simplification (A52) 
Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
 2012-07-05 17:22:00 +09:00
Jean Chalard
ea80794dd4 Put some more code in common (A51) 
Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
 2012-07-05 17:21:55 +09:00
Jean Chalard
cbfd2e1fdb Pull up a common variable into the wrapping method (A50) 
Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
 2012-07-05 17:21:51 +09:00
Jean Chalard
7ed22f1f72 Factorize some common code (A49) 
Also add some comment to clarify what's happening inside those
methods

Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
 2012-07-05 17:21:44 +09:00
Tadashi G. Takaoka
b28934adac Fix tab key's navigation behavior 
Bug: 6435484
Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
 2012-07-05 16:57:14 +09:00
Tadashi G. Takaoka
133bb8544a Merge "Fix upper case Eszett more key" 2012-07-05 00:52:08 -07:00
Tadashi G. Takaoka
5946838b8e Fix upper case Eszett more key 
Bug: 6773873
Change-Id: I1a533c729c312a53663fb142cb6fcb4915b53206
 2012-07-05 16:13:52 +09:00
Jean Chalard
0726f466f7 Merge "Add a wrapper to updateSuggestions / Predictions (A48)" 2012-07-04 21:08:21 -07:00
Tadashi G. Takaoka
7aeb7ef1ab Merge "Fix Keyboard.getKey as thread safe" 2012-07-04 19:58:17 -07:00
Tadashi G. Takaoka
8f6c603b3b Fix Keyboard.getKey as thread safe 
This is a follow up of Id962e670.

Change-Id: I9e8542bff9e8faf57f934051fe612463c99ad61f
 2012-07-05 11:43:43 +09:00
Jean Chalard
e47c728dd5 Add a wrapper to updateSuggestions / Predictions (A48) 
The goal is to have those converge, as they contain almost 100%
duplicated code.

Change-Id: I6921791d47efce9fb396efd9626839d706664a91
 2012-07-05 11:10:04 +09:00
Jean Chalard
7b40c68277 Refactoring which will help with future changes (A47) 
Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
 2012-07-05 11:10:02 +09:00
Jean Chalard
e9a86e2cdb Search bigrams for the lower case version of the word (A46) 
...if there aren't any for the exact case version.

Bug: 6752830
Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
 2012-07-04 20:12:58 +09:00
Jean Chalard
4bcf70c931 Fix a bad interaction with mmap 
Bug: 6761221
Change-Id: I7e6d98dc9d7cb34a6163c3957e401ff97abb975c
 2012-07-04 17:57:06 +09:00
Tadashi G. Takaoka
ac3bd96192 Merge "Remove WordComposer.add(int, int, int, KeyDetector) method" 2012-07-04 01:48:42 -07:00
Tadashi G. Takaoka
5c641a9f59 Remove WordComposer.add(int, int, int, KeyDetector) method 
Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
 2012-07-04 17:29:47 +09:00
Tadashi G. Takaoka
5c98206dc5 Merge "Use Keyboard.getKey" 2012-07-04 01:12:02 -07:00
Tadashi G. Takaoka
adc80eef15 Use Keyboard.getKey 
Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
 2012-07-04 16:31:57 +09:00
Tadashi G. Takaoka
040aa28ed4 Merge "Get rid of redundant CharSequence member from SuggestedWordInfo" 2012-07-04 00:27:07 -07:00
Tadashi G. Takaoka
f3897fb54e Get rid of redundant CharSequence member from SuggestedWordInfo 
Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
 2012-07-04 16:04:59 +09:00
Jean Chalard
c5e911c06b Consolidate a method inside another (A45) 
It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.

This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.

Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
 2012-07-04 11:51:51 +09:00
Jean Chalard
f72b8f5662 Move the safety net function to AutoCorrection (A44) 
Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
 2012-07-04 11:51:46 +09:00
Jean Chalard
accd63f35f Merge "Refactoring (A43)" 2012-07-03 19:40:19 -07:00
Jean Chalard
b87b23eb75 Merge "Remove useless code (A42)" 2012-07-02 18:56:41 -07:00
Jean Chalard
6547f43666 Merge "Clarify some code and fix a bug (A41)" 2012-07-02 18:52:56 -07:00
Jean Chalard
d6496c0913 Merge "Fix a bug with the user dictionary locale." 2012-07-02 02:57:50 -07:00
Jean Chalard
d113fd0be4 Fix a bug with the user dictionary locale. 
We internally use the string "zz" to mean no locale, but
the user dictionary service does not understand that and
words added with this locale pitifully end being added to
a "zz" user dictionary, which makes no sense to the user.
This change fixes things so that words added when the
keyboard is in a "no locale" layout, the words are added
to the global, all-locales user dictionary.

Bug: 6645306
Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
 2012-07-02 17:14:47 +09:00
Jean Chalard
4ca05e2474 Refactoring (A43) 
Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
 2012-07-02 15:46:11 +09:00
Jean Chalard
7ad088a4cf Remove useless code (A42) 
If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !

Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>

Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
 2012-07-02 15:46:08 +09:00
Jean Chalard
90d300c770 Clarify some code and fix a bug (A41) 
The test against hasMainDictionary is a test to know if we should
auto-correct or not. Its result should be recorded in
hasAutoCorrection, not in allowsToBeAutoCorrected.

Actually, this value being inserted in allowsToBeAutoCorrected was
causing a bug that nobody noticed: when typing in a language with
no dictionary, the word in the middle of the suggestion strip would
always be bold, as if it was going to auto-correct to itself !
This change fixes this bug.

Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
 2012-07-02 15:46:03 +09:00
Jean Chalard
2631e3b195 Small refactoring (A39) 
Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea
 2012-07-02 15:45:58 +09:00
Jean Chalard
79f5317848 Match calls for future consolidation (A38) 
Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9
 2012-07-02 15:45:54 +09:00
Jean Chalard
cd288620ea Make the autocorrection scheme more straightforward (A37) 
Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd
 2012-07-02 15:45:34 +09:00
Jean Chalard
aba432bf8d Remove a duplicate method (A36) 
Bug: 6705473
Change-Id: Ib6260034b09739b60071e90a018b2dc6be3815d7
 2012-07-02 12:12:16 +09:00
Jean Chalard
84074cf503 Update log and make a variable private (A35). 
Change-Id: Ib4a8f41dc5941bce46402e1a41a6c21dccb0601f
 2012-07-02 12:11:27 +09:00
Jean Chalard
1842fbba93 Remove old debug code that has been long broken (A34) 
Change-Id: I9b5a0e34529724984aad1e2bf99b3e00f8ed0dd7
 2012-06-29 19:47:00 +09:00
Satoshi Kataoka
105069a15f Merge "Add input pointers" 2012-06-29 03:03:01 -07:00
Satoshi Kataoka
71538b08e4 Add input pointers 
Change-Id: I95300bf0a847fb86d026e846ff4ad723bb45284f
 2012-06-29 18:58:51 +09:00
Jean Chalard
f2af726f79 Merge "Add a more synthetic variable (A33)" 2012-06-29 02:22:05 -07:00
Jean Chalard
aa246f23ce Merge "Remove cruft (A32)" 2012-06-29 02:12:47 -07:00
Jean Chalard
defc2e2efa Merge "Simplification (A31)" 2012-06-29 02:09:16 -07:00
Jean Chalard
7a6ac44f5f Merge "Small refactoring (A30)" 2012-06-29 02:09:06 -07:00
Tadashi G. Takaoka
e0b7359126 Merge "Use SparseArray<E> instead of HashMap<Integer,E>" 2012-06-29 02:05:39 -07:00
Tadashi G. Takaoka
56853c1e48 Use SparseArray<E> instead of HashMap<Integer,E> 
Change-Id: Id962e670ee1a5164e6c69deb84625139bf5e7974
 2012-06-29 17:56:31 +09:00
Jean Chalard
1b2e2d893d Add a more synthetic variable (A33) 
The goal here is to disambiguate TypedWordValid and
HasAutoCorrectionCandidate. Ultimately, HasAutoCorrectionCandidate
will disappear.

Bug: 6705473
Change-Id: I1acbd0a5efc7f4bf7b0bdb12839fe3d84e9d1dda
 2012-06-29 17:00:57 +09:00
Jean Chalard
9011b89f4e Remove cruft (A32) 
Change-Id: I35c2ba4caf6be4ba0449e11c0597ae8e468c0e6e
 2012-06-29 17:00:57 +09:00
Jean Chalard
2cda148fd5 Simplification (A31) 
Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
 2012-06-29 17:00:57 +09:00
Jean Chalard
deb2d88245 Small refactoring (A30) 
Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
 2012-06-29 17:00:57 +09:00
Jean Chalard
0a63111821 Remove a useless parameter (A29) 
Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
 2012-06-29 17:00:56 +09:00
Jean Chalard
4f444410f2 Remove a useless variable (A28) 
Change-Id: I1058123d233540fb72a94028987a43740224f635
 2012-06-29 17:00:56 +09:00
Jean Chalard
f4267c0521 Fix a small bug (A27) 
TypedWordValid and AllowsToBeAutoCorrected are almost the
same thing; the difference is whether the word is also a
whitelist entry or not. In this case, TypedWordValid was
the right one to test.

Change-Id: I695fe5b9f6bbe9d3ba314c646da3a25742c9f4ed
 2012-06-29 17:00:56 +09:00
Jean Chalard
9e0af57736 Optimization (A26) 
Change-Id: I1d7790289635729645995fb8c38868259ab1b3be
 2012-06-29 17:00:56 +09:00
Jean Chalard
7a94cbd2a4 Remove useless code (A25) 
isWhitelistedOrNotAWord takes an 'ignoreCase' argument. By looking
at the contents of the wordcomposer here, there is only one case
where its output will be different : when the word is typed with a
capital, but the lower case version exists in the dictionary.
E.g. the user typed "This".

In this case, isWhitelistedOrNotAWord in line 235 will return false
instead of true, so the test will score a true instead of a false,
so hasAutoCorrection may be true instead of false in this specific
case and that's the only case where it's different.

But in this case, allowsToBeAutoCorrected is certain to be false,
which means the result will not have changed if hasAutoCorrection
was true in the first place. So in the end this change is sure not
to change the behavior.

Change-Id: Ic41cf959c20c19165f84d9b8ff006731fa595d84
 2012-06-29 16:57:56 +09:00
Jean Chalard
b3cfde2cbb Add a few comments for future reference (A24) 
Change-Id: Ia356130b8a95ec9cf676bc6be05d801c13f14b64
 2012-06-29 15:45:27 +09:00
Jean Chalard
e398c6c024 Rename a method for readability (A23) 
Change-Id: I6f569322e645d36bc82fddf4ec2fd621972e3b47
 2012-06-29 15:45:24 +09:00
Jean Chalard
ea578f6b1d Revert a test for readability (A22) 
Change-Id: I1df4cef5ae2736a22273843dce67f0012181bfd3
 2012-06-29 15:44:55 +09:00
Jean Chalard
19d02c19d0 Remove a useless variable (A21) 
Change-Id: I901e6b0e2b994128da19d68233b9f68bb308cb95
 2012-06-29 15:44:17 +09:00
Jean Chalard
1333579b4b Don't special-case 1-letter words (A13) 
There is no reason to prevent 1-letter words to auto-correct
to themselves, or to dictionary words. Don't do it.

Change-Id: Iceada847ae632336026ada29afed0353cd9c51b5
 2012-06-29 15:12:51 +09:00
Jean Chalard
4d5e7235c5 Remove a useless variable (A20) 
Change-Id: Ifc37462f5243563693c8cd7cbeb401ff054daa52
 2012-06-29 15:12:51 +09:00
Jean Chalard
d426941ee8 Fix a theoretical bug (A12) 
If a word is a dictionary word but still has no suggestion,
this method should return true. In the practice, it makes
no difference since a word without suggestion won't be changed
anyway.

Change-Id: Ib1f5ef254b7da7e5cedb2f973529ad431beb93f9
 2012-06-29 15:12:51 +09:00
Jean Chalard
739683dcfb Rename a method for readability (A19) 
Change-Id: I0b8c06d1fd0bfb3caf363c048acc7048abed1752
 2012-06-29 15:12:51 +09:00
Jean Chalard
31b346aac6 Remove a useless test (A18) 
allowsToBeAutoCorrected always returns false if the word is empty.
This is because the whitelist never contains an empty string,
and isValidWord returns false if the word is empty.

Change-Id: I34ecc2a1563aea6db5b2f12796f251f6598576a2
 2012-06-29 15:12:51 +09:00
Jean Chalard
b01cdb975a Inline a method (A17) 
This will allow us to remove unnecessary processing

Change-Id: I251dfdaffb077906186686ebe65fd82e1e360bd2
 2012-06-29 15:12:51 +09:00
Jean Chalard
42dde06782 Make a function a one-liner (A16) 
...to better inline it

Change-Id: I88496b8f18b81f0c05e4bbf2d1039de1f93e0c25
 2012-06-29 15:12:51 +09:00
Jean Chalard
a96a11949f Inline a simple method (A15) 
Change-Id: Ib74fcbf33c680bf02c39a9896e30e3afbcfd149a
 2012-06-29 15:12:51 +09:00
Jean Chalard
074c90af98 Inline a method (A14) 
The new code is worse than the old one, but this is a necessary
step to make things prettier.

Change-Id: If6e8a139bb85e6920c749743c78792a22a8acb45
 2012-06-29 15:12:51 +09:00
Jean Chalard
9701b360d9 Rename a terribly-named method for clarity (A11) 
Change-Id: Id180000404dc6929d80f98c0e9cd2026230ad2d1
 2012-06-29 15:12:50 +09:00
Jean Chalard
6b911c27a3 Merge "Small readability improvement (A10)" 2012-06-28 23:11:23 -07:00
Jean Chalard
f89a75134b Small readability improvement (A10) 
Change-Id: Iba326921711e1c4eab38264e66b6b44a64fec398
 2012-06-29 15:05:08 +09:00
Jean Chalard
305326e789 Refactoring and add debug prints (A9) 
Change-Id: I46497bff107f0def0dfa2b043b20d9a0b0cde040
 2012-06-29 14:24:54 +09:00
Jean Chalard
5110e2cb51 Optimization (A8) 
Change-Id: I2b9e8cc6a13fd9af84a5189e4d3fbb2b05c68d46
 2012-06-29 12:54:11 +09:00
Jean Chalard
4847a27f74 Cleanup (A7) 
Change-Id: Iba97e0062b702c005ab3ff9ce59f181d19ab7c98
 2012-06-28 19:13:16 +09:00
Jean Chalard
ed83d4b143 Stop special-casing a single suggestion (A6) 
Treat it like the others

Change-Id: Ic24e40ada0e75773c3ece9470ab61c350697be5d
 2012-06-28 19:12:37 +09:00
Jean Chalard
251bb70f08 Cleanup (A5) 
Change-Id: I06134145b47c46bbc6c340ca539f34a01e2ca163
 2012-06-28 19:12:37 +09:00
Jean Chalard
4c4e3a0949 Transform the whitelist suggestion like the others (A4) 
...instead of having a different code path

Change-Id: Icd177e2151e45d25300000d4b63d4fba1f52b6a8
 2012-06-28 19:10:32 +09:00
Jean Chalard
33b3805e79 Small refactoring (A3) 
This will help make upcoming changes clearer

Change-Id: Ida8d4935f7315e5da6007ad364124694da3112d0
 2012-06-28 19:10:24 +09:00
Jean Chalard
b7cdafd78a Don't pass everything to a function that needs only the head (A2) 
Change-Id: Ic367836202ab8071c1a9a02eaf0651b0da947d51
 2012-06-28 19:10:13 +09:00
Jean Chalard
09b30ac954 Merge "Use a TreeSet to sort suggestions instead of doing it by hand (A1)" 2012-06-28 03:08:26 -07:00
Jean Chalard
2d2e348033 Use a TreeSet to sort suggestions instead of doing it by hand (A1) 
Change-Id: I16ba39321107e87ad48a99c2410a15995a66f23c
 2012-06-28 18:54:14 +09:00
Tadashi G. Takaoka
69527d4d60 am 5e5cf045: am 7f7947c9: Keep subtypes in method.xml the same as pre-JellyBean 
* commit '5e5cf045ca6debafcc29ae1c47afda4a3a152326':
  Keep subtypes in method.xml the same as pre-JellyBean
 2012-06-27 21:58:53 -07:00
Tadashi G. Takaoka
7f7947c97b Keep subtypes in method.xml the same as pre-JellyBean 
This change prevents Android Keyboard subtypes being mistakenly
disabled when upgrading from pre-JellyBean to JellyBean.

Bug: 6750906
Change-Id: I05de6c512e7aa17356e415476e5248986c7d4253
 2012-06-28 13:44:09 +09:00
Jean Chalard
10abf10c1f Convert local members to local variables 
Change-Id: I852787986c79502a4de7effe9c8281a4cf2d519d
 2012-06-27 19:54:29 +09:00
Jean Chalard
3ecb2747b3 Optimization. 
It's useless to do this for all suggestions including those
that will be ousted from the list.

Change-Id: I7bd63d783e21984a269e4b1ae17e9b9d8c0859e3
 2012-06-27 18:55:43 +09:00
Jean Chalard
3705ef407b Read the suggestion type from the suggestion 
...instead of dirtily passing it from the dictionary loop

Change-Id: I92ddbd7451609b69f6d4dc31bf89d614423b2016
 2012-06-27 18:18:35 +09:00
Jean Chalard
24eec0fa68 Remember the source dictionary for each suggestion. 
Change-Id: I3c63372bd5572a479a67eaecfe8c8ea1cabc70d9
 2012-06-27 18:17:28 +09:00
Jean Chalard
d8f0caa406 Move constants to a better place. 
Change-Id: I5c27a3ed99b17f850e26a8503de16f001c7111c1
 2012-06-27 18:08:08 +09:00
Jean Chalard
089c11a086 Cleanup 
Change-Id: I575f22330bf6881af1d9a35f22b51b7bf2198113
 2012-06-27 17:59:58 +09:00
Jean Chalard
b5afd3de0c Remove unused stuff. 
Change-Id: Ifd0d5b6978f76b841574a6e10157c32d0cd656b6
 2012-06-27 17:44:16 +09:00
Jean Chalard
05efe576f9 Cleanup the dictionary type. 
Stop storing an int in each of the different class types, and
just store a string in the top class.

Change-Id: I2af1832743e6fe78e5c1364f6d9cc21252bf5831
 2012-06-27 17:31:09 +09:00
Jean Chalard
c356df8e08 Merge "Update the prototype of onAddSuggestedWord - calling side." 2012-06-27 01:25:59 -07:00
Ken Wakasa
e55c23e4b0 Small cleanups 
Change-Id: Ic1a198ab1b4f0323fde9e4245729fd0e6011b914
 2012-06-27 16:54:37 +09:00
Jean Chalard
32ff2504a0 Update the prototype of onAddSuggestedWord - calling side. 
We want to get rid of all those IDs in Latin IME.

Change-Id: Ibe08100a5e2976c80abb049889233b4047a686f3
 2012-06-27 16:17:14 +09:00
Jean Chalard
2db27bcd06 Merge "Use binarySearch instead of a hand-written linear search" 2012-06-26 23:55:46 -07:00
Jean Chalard
78a8d5b6bc Merge "Implement a comparator for SuggestedWordInfos." 2012-06-26 22:55:51 -07:00
Jean Chalard
56beb9e321 Use binarySearch instead of a hand-written linear search 
Yay.

Change-Id: Icf686eb2d675da959f19edc856b521e6288dcea3
 2012-06-27 14:17:29 +09:00
Jean Chalard
9da0027b38 Implement a comparator for SuggestedWordInfos. 
Change-Id: Ic4b0ae05cd98a1aec5806c5e4b744158e73aea7a
 2012-06-27 14:16:23 +09:00
Kurt Partridge
30447239e8 Merge "only output every kth word to log" 2012-06-26 20:49:03 -07:00
Jean Chalard
4ef01c51f8 Merge "Remove some special casing" 2012-06-26 20:33:43 -07:00
Kurt Partridge
e961188e9f only output every kth word to log 
multi-project CL with Ib5b544b9b2d8b0e4419238976b2e274e5ac564f8

Bug: 6188932
Change-Id: Iea68cf36924d6fda126130a98431a6ce02ba251e
 2012-06-26 16:15:20 -07:00
Jean Chalard
7e49a2b6b8 Remove some special casing 
This special casing is useless. If the word is the same as what
user typed, the scoring algorithm already ensures that it comes
out at the top. Actually, as is written in a comment here, code
executed later is actively relying on this suggestion having
the top score ! There is no need to test it for equalness and
inserting it at the top then.

Change-Id: I263a6de59b77ec72a2dcbb933361b8e16fca0681
 2012-06-26 20:40:42 +09:00
Jean Chalard
a3f5f51ec4 Fix a bug where a log would mysteriously not work 
Change-Id: I5ca77ed65e95a6d357215c0e730238fb463986bb
 2012-06-26 20:36:51 +09:00
Jean Chalard
22657dcba0 Optimization. 
We already had that computed

Change-Id: I2a9742eaee2e9db1f73aeddda7bae7e237b4d15c
 2012-06-26 20:02:07 +09:00
Jean Chalard
ec8b27fe49 Cut out a method for clarity 
Change-Id: I1dc668698a5cd840297e713a26a525f5e32d35d6
 2012-06-26 19:49:01 +09:00
Jean Chalard
0131170da9 Merge "Avoid string conversions when possible." 2012-06-26 03:48:01 -07:00
Jean Chalard
5953dc93cf Avoid string conversions when possible. 
Change-Id: Ibf5f3e40da55998364d0d835ecf283f32c80fcf5
 2012-06-26 19:45:52 +09:00
Jean Chalard
5d218bc029 Merge "Simplify a method call." 2012-06-26 03:45:02 -07:00
Jean Chalard
bed514bd90 Simplify a method call. 
Change-Id: Ieede787a13cef79353f13af52488ef3732ac9850
 2012-06-26 19:33:16 +09:00
Jean Chalard
61c1002b6b Merge "Refactor and squash long-standing bugs (A2)" 2012-06-26 03:19:20 -07:00
Tadashi G. Takaoka
abf81192ff Merge "Remove unnecessary variables" 2012-06-26 03:16:17 -07:00
Tadashi G. Takaoka
342ea3d324 Merge "Pass MotionEvent to PointerTracker" 2012-06-26 03:16:12 -07:00
Jean Chalard
9433ce86b7 Refactor and squash long-standing bugs (A2) 
This is awesome.
- Improve performance by stopping useless string/array conversions.
- Simplify method interface.
- Fix localization bugs - we now know our locale
- Fix bugs with surrogate code points

Bug: 4769095
Change-Id: I8a8ee224b713429ee0a4ce5bd52f1b63378cf56f
 2012-06-26 19:12:07 +09:00
Tadashi G. Takaoka
3314d38daf Pass MotionEvent to PointerTracker 
This is a one of groundwork to integrate gesture input.

Change-Id: I5b75c6978b51df91fdc384a9f6d1d5a5ddc563e2
 2012-06-26 19:05:47 +09:00
Jean Chalard
a8c9946b44 Merge "Remember the locale in the Suggest object (A1)" 2012-06-26 03:05:05 -07:00
Tadashi G. Takaoka
7bb8e95b52 Merge "Cleanup PointerTracker debug method" 2012-06-26 03:03:49 -07:00
Tadashi G. Takaoka
0d9d37cec2 Remove unnecessary variables 
Bug: 6722052
Change-Id: I92e85b3e49b8f4b228f0cf0994216c5050e0865c
 2012-06-26 19:01:59 +09:00
Jean Chalard
8e17f6d93a Remember the locale in the Suggest object (A1) 
This will be necessary for uppercasing and titlecasing words
correctly.

Change-Id: I0f446a4c82bc482240ff730a2ad6586a61571d6b
 2012-06-26 18:55:18 +09:00
Jean Chalard
6cad198d9c Remove a useless member (A2) 
Change-Id: Ia727ffc2946352bbf79e0c97684f8fa98f428cef
 2012-06-26 18:42:06 +09:00
Jean Chalard
0da9a7c094 Convert a member to a local variable (A1) 
Change-Id: I9eab910989443704f83711cf4fb0070c5987a13a
 2012-06-26 18:41:49 +09:00
Tadashi G. Takaoka
d7edd1cbb5 Cleanup PointerTracker debug method 
Change-Id: Ib3bfa0a46f5814a6df838005d7243e2f536a98a0
 2012-06-26 18:36:30 +09:00
Jean Chalard
f05392f213 Remove an unused method (A22) 
Change-Id: I2195f365df1799c8b3b2a53670d1df535ab1a742
 2012-06-26 17:59:04 +09:00
Jean Chalard
6234be1fe7 Simplification and optimization (A20) 
Change-Id: Ia837e553ccfe67cd4303096290194a5186df059b
 2012-06-26 17:59:04 +09:00
Jean Chalard
77e95e60bb Preparation for a simplification (A19) 
Change-Id: I4605a571faf5fbc68b18ce525d6019600bfa8cf7
 2012-06-26 17:59:04 +09:00
Jean Chalard
0a79446531 Remove a meaningless separation (A18) 
Change-Id: I267177044c7d7b0d9119839a11057b2bbf41f75f
 2012-06-26 17:59:04 +09:00
Jean Chalard
61e7ec6587 Remove the Callback interface for simpler code. (A17) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I009b54fc2e73cadca6734bdca074d033e81f6a2b
 2012-06-26 17:58:52 +09:00
Jean Chalard
2f1b6c9ea4 Remove the callback argument to getBigrams() (A16) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I7457ac04f8cd4019fb86c986725aae3de1b1a65e
 2012-06-26 17:54:49 +09:00
Jean Chalard
60eed92dc3 Remove the callback argument to getWords() (A15) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I919bf70a1213ab5d7c7a9e5715bd72a6e257148b
 2012-06-26 17:36:47 +09:00
Jean Chalard
2225b3bace Do away with Utils#addAllSuggestions (A14) 
It's not used any more.

Change-Id: Id9da40fdbf7078f3ac647d1368237d6601f5a2ba
 2012-06-26 17:36:47 +09:00
Jean Chalard
d9df8094e6 Neutralize AndroidSpellChecker.SuggestionsGatherer#addWords (A13) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Ia54e1e44e1fd4e8ba2c9316928c0595cbe3f933c
 2012-06-26 17:36:47 +09:00
Jean Chalard
7830476022 Neutralize Suggest#addWords (A12) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id923367342a62a650a5f1d38e2fa0e913030dca8
 2012-06-26 17:36:47 +09:00
Jean Chalard
fd998bd37a Refactoring (A11) 
Change-Id: I86bd7587dd80773a51ba6db312ba55dc41e7c8c7
 2012-06-26 17:36:47 +09:00
Jean Chalard
64dad2d5a9 Remove an unused method and inline another (A10) 
Change-Id: Ifd71ce79711b0c15c7764e97351dbb1b8e4c0c2d
 2012-06-26 17:36:47 +09:00
Jean Chalard
d522ddefc2 Merge "Merge the interface of two methods that do the same thing (A9)" 2012-06-26 01:35:15 -07:00
Jean Chalard
90981e423a Merge "Change the return type of getWords and getBigrams (A8)" 2012-06-26 01:33:04 -07:00
Jean Chalard
9053862470 Merge "Remove dependency on WordCallback from BinaryDictionary (A7)" 2012-06-26 01:16:43 -07:00
Jean Chalard
b9f99c8679 Merge "Remove useless code and storage (A6)" 2012-06-26 01:16:32 -07:00
Jean Chalard
8fb0ff00b1 Merge "Remove a duplicate processing (A5)" 2012-06-26 01:16:19 -07:00
Tadashi G. Takaoka
1c6a9cc44d Merge "Update current key reference in PointerTracker when keyboard is changed" 2012-06-26 00:58:16 -07:00
Jean Chalard
28eeb35d14 Merge the interface of two methods that do the same thing (A9) 
Change-Id: Ia5701d713d0fd5bb646b54a03a1a5602dad0a9e6
 2012-06-26 16:55:09 +09:00
Jean Chalard
d82898c5a9 Change the return type of getWords and getBigrams (A8) 
This only returns stuff, but it doesn't change yet how the data
is really passed. It merely adds a way of getting the same data.
Later, the old way will be removed.

Change-Id: If3a064de362175fc5a6781b7a97b65d8730aaf3c
 2012-06-26 16:44:26 +09:00
Jean Chalard
bda7eaa63a Remove dependency on WordCallback from BinaryDictionary (A7) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I8245698fbd170e0f5cbad3c0109774bcaddc0614
 2012-06-26 16:42:48 +09:00
Jean Chalard
17111afcd6 Remove useless code and storage (A6) 
This is only used as temporary storage to be then added to
the other variable, relying on the fact that it is hopefully
sorted. It's better to just add it right away to the final
storage.

Change-Id: I5da702ac9dc579593ab21feb2021a01e5dfdf4dc
 2012-06-26 16:39:32 +09:00
Jean Chalard
5e0545d69d Remove a duplicate processing (A5) 
This filtering is already done in native code. It's useless (and
costly) to do it again here.

Change-Id: Ide6794d7a8682a881f097f33e222f10d30f297bd
 2012-06-26 16:37:05 +09:00
Jean Chalard
fac8a16c6f Merge "Remove another dependency to WordCallback (A4)" 2012-06-25 23:31:39 -07:00
Tadashi G. Takaoka
8a092b4ede Update current key reference in PointerTracker when keyboard is changed 
This change also checks that the current key is the same key that
started the key repeat, when key repeat timer is fired.

Bug: 6722052
Change-Id: Id69880ded3338a5a3cbe7f8bf951f94f2651119c
 2012-06-26 15:00:12 +09:00
Kurt Partridge
3ec249c6d1 Merge "fix IllegalOutOfBoundsException" 2012-06-25 22:52:36 -07:00
Kurt Partridge
01106f6a10 fix IllegalOutOfBoundsException 
StringUtils.toCodePointArray() had thrown IllegalOutOfBoundsException if
passed an empty string.  change to just return an empty int[].

Bug: 6188932
Change-Id: Ic41c628c0d407f49fc98cd48cb7ea13d8d5bdd77
 2012-06-25 22:40:56 -07:00
Jean Chalard
d7b9e8f503 Remove another dependency to WordCallback (A4) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I5b277124dc9244e78c4a1f4d542a55071eb479bd
 2012-06-26 13:12:01 +09:00
Ken Wakasa
9f78eed456 Remove "Key popup dismiss delay" when "Popup on keypress" is suppressed 
bug: 6714783
Change-Id: Idf674e8e1af80642f2c53f7ae5c03e21c9e04292
 2012-06-26 00:40:53 +09:00
Satoshi Kataoka
7368009799 Change JNI for Gesture 
Change-Id: I774a0052038d16677f60f7efa11fd266cb5f3088
 2012-06-25 18:54:37 +09:00
Jean Chalard
5a73d72265 Merge "Refactoring and groundwork to fix a bug with older apps" 2012-06-25 00:42:21 -07:00
Jean Chalard
c3ebf1a43a Refactoring and groundwork to fix a bug with older apps 
This has a good, although small, impact on performance : it removes
a two-way IPC call in a most frequent case, while possibly adding
one in a rather unfrequent and less critical case.

Also, this fixes a bug with surrogate pairs. This specific branch
of code now correctly handles surrogate pairs.
Aside from this, it should have no impact on behavior.

However, since it does delay access to the previous character in
the text view by a two-way IPC call, it actually goes a long way
toward fixing bug#6668226. It is not really a fix and the race
condition still exists, but this change makes it much, much
harder to hit.

Bug: 6668226
Change-Id: Id11cc6a0b7488d6bd392227cafdcf3a8d4c62f6c
 2012-06-25 16:32:25 +09:00
Jean Chalard
a316a15984 Merge "Tentatively remove a dependency on WordCallback (A3)" 2012-06-24 23:08:13 -07:00
Jean Chalard
dc01bd5ea4 Merge "Improve compatibility for ICS." 2012-06-24 20:41:19 -07:00
Satoshi Kataoka
2cf265b345 Merge "Fix possible NPE from a concurrent problem in LatinIME" 2012-06-21 22:16:48 -07:00
Kurt Partridge
e6a39d5677 Merge "Allow punctuation through privacy filter" 2012-06-21 21:53:48 -07:00
Kurt Partridge
33d9f9b6db Allow punctuation through privacy filter 
Also cleaned up the privacy code a bit.

multi-project commit with Change-Id: Ic0919a6929ebb2623ff4124f7adc96d9e5f8df3c

Bug: 6188932
Change-Id: Id470fe7cc6e4a8fb01f1ea5b178a74cd27d59218
 2012-06-21 00:17:48 -07:00
Jean Chalard
1b71ff00a2 Merge "Update an outdated comment" 2012-06-20 20:18:51 -07:00
Jean Chalard
9997b44846 Improve compatibility for ICS. 
ICS didn't have a SHORTCUT column in the user dictionary.
If running on a build under JellyBean, we should not ask
for it lest we crash.

Bug: 6600617
Change-Id: Iac0cbcc63c10064f01e2d51eec5931fd9cdd0922
 2012-06-20 18:43:56 -07:00
Jean Chalard
83f4a9866a Cleanup, part 10 : remove from the code obsolete options (C10) 
Change-Id: Id0806ad3dc7ccb632713eebaca76f0bab26ece5d
 2012-06-21 10:07:05 +09:00
Jean Chalard
7c406ed655 Tentatively remove a dependency on WordCallback (A3) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id5a59eaec2aeefa0ba4524420a8e035d383f6545
 2012-06-21 10:03:44 +09:00
Jean Chalard
e8bb8351d6 Cleanup, part 9 (C9) 
Change-Id: Ifb15553824915d0634aea83689302c2418b093f3
 2012-06-21 09:22:32 +09:00
Jean Chalard
ca6b7d5265 Cleanup, part 8 (C8) 
Change-Id: Iecc9b3d43c191614c2951408e14085cb77eefd4d
 2012-06-20 03:45:40 +09:00
Jean Chalard
2f3a694e29 Cleanup, part 7 (C7) 
Change-Id: I662be9d3b31fb9e157722f38cab1e6fb8a1152ab
 2012-06-20 03:17:33 +09:00
Jean Chalard
0e8b1db948 Merge "Cleanup, part 6 (C6)" 2012-06-19 09:25:33 -07:00
Jean Chalard
c03bd090ea Merge "Cleanup, part 4 (C4)" 2012-06-19 09:24:25 -07:00
Jean Chalard
bd765d3355 Merge "Cleanup, part 3 (C3)" 2012-06-19 09:24:00 -07:00
Jean Chalard
b821b72aa1 Merge "Remove a member (B5)" 2012-06-19 09:15:57 -07:00
Satoshi Kataoka
67b9337b6c Fix possible NPE from a concurrent problem in LatinIME 
Bug: 6620746
Change-Id: Icc18de92d7edc6888c712c2cf5ce479a65f8bfad
 2012-06-19 03:34:45 +09:00
Svetoslav Ganov
808ba7b8f8 am e6730ac0: am 5e4df66f: Merge "Removing implementation of unnecessary APIs taken out of the support lib." into jb-dev 
* commit 'e6730ac0e89de1cd81b92412751ec3950d8befb4':
  Removing implementation of unnecessary APIs taken out of the support lib.
 2012-06-18 11:31:43 -07:00
Svetoslav Ganov
5e4df66fce Merge "Removing implementation of unnecessary APIs taken out of the support lib." into jb-dev 2012-06-18 11:28:04 -07:00
Jean Chalard
b0561ae980 Remove a member (B5) 
The new call in the test ensures getCurrentInputEditorInfo actually
works.

Change-Id: I2ee407bd9927d22db537d12f339e2b977a38054a
 2012-06-19 03:27:37 +09:00
Jean Chalard
56523ce0bf Merge "Simplification (B4)" 2012-06-18 10:55:59 -07:00
Jean Chalard
64e52051cf Simplification (B4) 
Change-Id: Id5abf722a533980ed2d89381dbddc0a71b6f5b6b
 2012-06-19 02:54:13 +09:00
Jean Chalard
5a1259523f Merge "Move a settings method to SettingsValues (B3)" 2012-06-18 10:53:47 -07:00
Tadashi G. Takaoka
a5bbb8df75 am e4bbff78: am 38dc9ca3: Fix duplicate period on Persian tablet keyboard 
* commit 'e4bbff783bddb70f52402454987ede281fb86039':
  Fix duplicate period on Persian tablet keyboard
 2012-06-18 10:52:54 -07:00
Tadashi G. Takaoka
794a9c913a am 58f9b35e: am 6de1b7a7: Fix Persian keyboard having correct code points 
* commit '58f9b35e1cf5a975ec1312858aad9b5cc307fda8':
  Fix Persian keyboard having correct code points
 2012-06-18 10:52:46 -07:00
Svetoslav Ganov
27bda8fee8 am 866cfd3a: am fa447071: Merge "Update LatinIME due to hidden APIs taken out of the support lib." into jb-dev 
* commit '866cfd3a68c370bedc4deb3d40ff4ff7c44902bd':
  Update LatinIME due to hidden APIs taken out of the support lib.
 2012-06-18 10:52:42 -07:00
Jean Chalard
fe53e5c060 Move a settings method to SettingsValues (B3) 
Change-Id: Ibfa27bd919c92be219c4d107b3ace008ca80a19f
 2012-06-19 02:52:36 +09:00
Tadashi G. Takaoka
38dc9ca314 Fix duplicate period on Persian tablet keyboard 
Bug: 6679579
Change-Id: I8bccbfbdf7ea1fa1b78a5af05eb1df100f22ab0c
 2012-06-18 10:33:03 -07:00
Jean Chalard
8b538807a3 Merge "Make a variable final (A2)" 2012-06-18 10:30:19 -07:00
Jean Chalard
0176faf6c0 Merge "Add a kind to the suggestion for bookkeeping (A1)" 2012-06-18 10:30:10 -07:00
Jean Chalard
1c3c0ff1c3 Merge "Cleanup, part 2 (C2)" 2012-06-18 10:29:06 -07:00
Jean Chalard
65b7bcb045 Merge "Cleanup, part 1 (C1)" 2012-06-18 10:28:58 -07:00
Svetoslav Ganov
d3cc73ada8 Removing implementation of unnecessary APIs taken out of the support lib. 
1. We have hidden a framework API and it was take out of the
   support lib. This API is not necessary and this patch removes
   the implementation in LatinIME.

bug:6675330

Change-Id: I18aff7a6c7bc2b76c7332abe0bf294fbbb99ccfc
 2012-06-17 15:22:02 -07:00
Kurt Partridge
6080f6878b Remove non-dictionary words and digit touch data. 
Output to the ResearchLogger is now queued and only flushed if the word
the user was working on is a dictionary word.

multi-project commit with Ic713ec00777fbdcf4a937b3c77b995257e100fc7

Bug: 6188932
Change-Id: I9de15227ff51be23083d9096f1c1b3d83802fff7
 2012-06-17 15:02:15 -07:00
Kurt Partridge
4b91046759 Merge "Replace digits in ResearchLogger" 2012-06-16 20:48:25 -07:00
Tadashi G. Takaoka
6de1b7a709 Fix Persian keyboard having correct code points 
Bug: 6679850
Change-Id: Iaa33f48ffb5634de31e039574fb58185c6c078e8
 2012-06-16 20:30:45 -07:00
Kurt Partridge
a696781c2b Replace digits in ResearchLogger 
Digits may represent personally identifying information.  They are
now replaced with a non-identifying symbol.

multi-project commit with I07d1cfdc45f6086f67af45775f4ed12da1833aca

Bug: 6188932

Change-Id: Ifda8079e6c1f29b5f8af34c6d1fccf5770f164ca
 2012-06-16 12:37:50 -07:00
Jean Chalard
c5f1d998c2 Cleanup, part 6 (C6) 
Change-Id: I184f3a336278559df255c5d600a98fbba468a243
 2012-06-16 10:52:49 +09:00
Jean Chalard
9b233ecef2 Cleanup, part 4 (C4) 
Change-Id: I2821ae71ec49e4b6b512157d17b80198f74321e4
 2012-06-16 10:51:04 +09:00
Jean Chalard
5475e92b3f Cleanup, part 3 (C3) 
Change-Id: Ib0be8dc26b6fa366a3dabeea940d466602073244
 2012-06-16 10:46:18 +09:00
Jean Chalard
71dc280426 Cleanup, part 2 (C2) 
Change-Id: I860f41807e9bc2e38b6ad84e1527fc8707a9aa40
 2012-06-16 10:40:16 +09:00
Jean Chalard
6883153dd0 Cleanup, part 1 (C1) 
Change-Id: I2b1ddd836aaf6bfc0bd2befb78f98239ffcdbb22
 2012-06-16 10:38:57 +09:00
Jean Chalard
4a5cb5c36a Update an outdated comment 
Change-Id: I3d02dc8597ed14d998caeaa056813353e2d7ec1a
 2012-06-16 10:34:57 +09:00
Jean Chalard
dca729fddd Move final attributes to SettingsValues (B2) 
Bug: 6675475
Bug: 6677394
Change-Id: I4a26efb9226d3f909f331c4d2e47cd83a05c011e
 2012-06-16 08:01:09 +09:00
Svetoslav Ganov
fa447071df Merge "Update LatinIME due to hidden APIs taken out of the support lib." into jb-dev 2012-06-15 15:00:55 -07:00
Jean Chalard
3d44f489b3 Inline a method for simplicity (B1) 
This has a confusing name and is a one-liner

Change-Id: I954a648a8413e38a535c2b81e4b171e1bdc9f1c2
 2012-06-16 03:18:00 +09:00
Jean Chalard
0998c48ac3 Make a variable final (A2) 
This is never changed, and probably doesn't need to be.
It's public because it's going to be used elsewhere in a future
change

Change-Id: Iec8d65859c470de5e1fb0b05533356fbc3b8e91b
 2012-06-16 03:10:54 +09:00
Jean Chalard
e7d2ee3ec3 Add a kind to the suggestion for bookkeeping (A1) 
This will help for debug as well as serve as groundwork for
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I74d0a7b943fb22c514ad79dc064d69ddf336d3ef
 2012-06-16 03:10:36 +09:00
Svetoslav Ganov
b910b18c2c Update LatinIME due to hidden APIs taken out of the support lib. 
1. We have hidden the APIs for accessiiblity focus search since
   it wull be perfomred by the client, updated the support lib,
   and now we are updating the LatinIME.

bug:6675330

Change-Id: I9dd3450b40148be7ce750f6bffc0a047a541982f
 2012-06-15 11:01:15 -07:00
Kurt Partridge
23cec44376 Merge "No logging of passwords." 2012-06-14 21:09:20 -07:00
Tadashi G. Takaoka
9328e0f2d9 am aee2ed1f: am 14bc2e89: Fix Arabic diacritics order 
* commit 'aee2ed1f4b0be7a538cc5722fed274632f2a40ba':
  Fix Arabic diacritics order
 2012-06-14 21:08:18 -07:00
Tadashi G. Takaoka
14bc2e89ef Fix Arabic diacritics order 
Bug: 6662536
Change-Id: I96e45ce0e8b9b5440a54f3b321a925bc87ec3ca9
 2012-06-14 20:33:52 -07:00
Tadashi G. Takaoka
dfcf7cac5e am 1ab436c1: am 0e473e9c: Reorder Persian diacritics 
* commit '1ab436c1e60c0e49333549fb93e135fa99458bda':
  Reorder Persian diacritics
 2012-06-14 18:30:52 -07:00
Jean Chalard
a19c5e6380 resolved conflicts for merge of be82f297 to master 
Change-Id: If49ca384ea0ac415a75f8ea1bad77dc6719cb04d
 2012-06-15 09:03:52 +09:00
Tadashi G. Takaoka
0e473e9c92 Reorder Persian diacritics 
Bug: 6661783
Change-Id: I42bab7655121ec5671854d54c47bd0c7a29e7a98
 2012-06-14 16:56:36 -07:00
Kurt Partridge
1cef91e481 No logging of passwords. 
Bug: 6188932
Change-Id: Ibf60ec99c50da3675bf89858624218e6cc3eb1d2
 2012-06-14 15:14:20 -07:00
Jean Chalard
cf6e923b18 am 42ecf39d: am 002e43ea: Merge "Remove irrelevant options." into jb-dev 
* commit '42ecf39d04df9eb02e57cf29e63552bc04092857':
  Remove irrelevant options.
 2012-06-14 14:51:37 -07:00
Tadashi G. Takaoka
775d8dcaeb am de1d88eb: am 32f4ceb2: Dismiss more suggestions panel when suggestions strip is closed 
* commit 'de1d88eb4199160899d227f2c679215e16410c42':
  Dismiss more suggestions panel when suggestions strip is closed
 2012-06-14 14:49:08 -07:00
Jean Chalard
7cbd0478cf Merge "Do not display punctuation suggestions when bigrams are on." into jb-dev 2012-06-14 14:37:13 -07:00
Jean Chalard
002e43ead0 Merge "Remove irrelevant options." into jb-dev 2012-06-14 14:36:26 -07:00
Jean Chalard
d5b765b3bb Do not display punctuation suggestions when bigrams are on. 
Bug: 6310401
Change-Id: I9d31c48e287aceedaf2f4c5129031ddb31402451
 2012-06-15 06:01:09 +09:00
Jean Chalard
78573f2e8a Fix an NPE 
This code is temporary until we get rid of this member.

Bug: 6662963
Bug: 6667091
Change-Id: I1d970d2a97992507e86c5b94978a2543fe42b375
 2012-06-15 05:47:35 +09:00
Jean Chalard
15121cff37 Remove irrelevant options. 
Bug: 6667355
Change-Id: I39b6db17fb52e80f510cf6462f41d9cb1f8e0341
 2012-06-15 05:04:14 +09:00
Tadashi G. Takaoka
32f4ceb243 Dismiss more suggestions panel when suggestions strip is closed 
This change fixes possible NPE as well.

Bug: 6658028
Change-Id: I8706808d1002b7b0b95930fd9b08568f08645da6
 2012-06-14 11:57:43 -07:00
Satoshi Kataoka
d2f210dbe2 am d9c702d2: am 5caaf1b9: Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 
* commit 'd9c702d2ff017452f0264f2be12b6bffd6204e4a':
  Do not add profanity to user history bigram dicitonary
 2012-06-14 10:33:47 -07:00
Tadashi G. Takaoka
c380959f48 am bbf18807: am 1db4f951: Fix the order of Persian diacritics 
* commit 'bbf188075d5e14626c0609f4c3ee6031f6c6d5a6':
  Fix the order of Persian diacritics
 2012-06-14 10:33:46 -07:00
Satoshi Kataoka
5caaf1b9e9 Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 2012-06-14 00:31:55 -07:00
Tadashi G. Takaoka
1db4f95105 Fix the order of Persian diacritics 
The java source file KeyboardTextsSet.java has rather big change, but
this file is auto generated by "maketext" tool. The crucial part of
this change is in 5 XML resource files.

Bug: 6661783
Change-Id: I1d827ab0ebe6caa5ab73531682d6c32540b0d7aa
 2012-06-14 15:18:25 +09:00
Satoshi Kataoka
68c650fb2a Do not add profanity to user history bigram dicitonary 
Change-Id: I864c4206e3e6cde4d6ed687a9759e98901e16b9a
 2012-06-14 15:15:08 +09:00
Jean Chalard
bbd7434229 Merge "Fix an occurrence of nested batch edits." 2012-06-13 10:37:12 -07:00
Tadashi G. Takaoka
8fa20d6a36 Merge "Remove useless copy constructor of ProximityInfo" 2012-06-12 16:24:39 -07:00
Tadashi G. Takaoka
9f42140ae2 Remove useless copy constructor of ProximityInfo 
Change-Id: I56b4a99f670ad38708ad83d76b93a631295e3333
 2012-06-12 15:13:07 -07:00
Jean Chalard
9d71748ba4 Fix an occurrence of nested batch edits. 
This is harmless, but against policy.
Also, rework the checking code to be more readable, give more
information, and be called for all relevant methods - and not
for informative methods, which are not required to be in a
batch edit.

Change-Id: I03fa8b2e7d68a6a133f86be8a214671750c29256
 2012-06-13 07:02:07 +09:00
Jean Chalard
c7564a787e Optimization 
This is much faster. It doesn't create messages, it doesn't post
stuff in a queue, it doesn't delay execution of other messages.
Also, it decouples the timer from the functionality of the Handler
so this can be pulled up in another change to consolidate with
mLastKeyTime or so.

Change-Id: I9044fc031373e66b9b40eee8025633613d0945dc
 2012-06-13 07:02:07 +09:00
Jean Chalard
72b358aa90 Small optimization. 
This will avoid some two-way IPC calls.

Change-Id: If9eb3e99b3d08346aadd4bbed2a1761f8c2527b9
 2012-06-13 07:02:07 +09:00
Satoshi Kataoka
84bb18f4c9 resolved conflicts for merge of ee78e780 to master 
Change-Id: I88a4996bdd17c5378a67781d8075eff311670c3b
 2012-06-13 06:45:38 +09:00
Jean Chalard
58d9e46ce0 Merge "Consolidate a test." 2012-06-12 11:50:36 -07:00
Kurt Partridge
5e50eec570 Merge "Check inputs to ResearchLogger" 2012-06-12 11:39:11 -07:00
Jean Chalard
e86054e5c2 Consolidate a test. 
Stop using the numerical value, use the actual method

Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e
 2012-06-13 03:34:58 +09:00
Kurt Partridge
65fc909e13 Check inputs to ResearchLogger 
to avoid NPEs.

Bug: 6188932
Change-Id: I377ceaac867df879dc7984dae44e96b369858cca
 2012-06-12 10:56:03 -07:00
Jean Chalard
140adf204b Consolidate auto-correction settings. 
For some reason, there were several ways, not exactly identical,
to get this setting. The ones that used mAutoCorrectionEnabled
would kick in when the input field was specifying no correction,
so it would be a little strange (although harmless in the practice
because the settings set in this way would not get used later,
because the correct test would be done at that time).

Also perform a very small refactoring

Change-Id: Ica9f32b238d98009ae1852d3c1e940398f5d341c
 2012-06-12 10:29:55 +09:00
Jean Chalard
2010aad741 Move two methods in a more appropriate place 
Change-Id: I512b04e23490413a44b1ca0517102fe2d9138df3
 2012-06-12 10:29:55 +09:00
Jean Chalard
a32eb27213 Move an editing method to the RichInputConnection 
Change-Id: Ie143ad008ca8deb1c5034cb80ec1cb28a6b0682d
 2012-06-12 10:29:55 +09:00
Jean Chalard
243e370fcb Move a member call out of the way 
Change-Id: I5da48442c0b39aaff817c3b6d067a9b13fda0643
 2012-06-12 10:29:55 +09:00
Jean Chalard
747cf0435a Move two editing utility methods to RichInputConnection 
Change-Id: If8d03bea1b6369cb3043da6321048d052995d664
 2012-06-12 10:29:55 +09:00
Jean Chalard
70a046f8ca Merge "Rename mSettingsValues to mCurrentSettings" 2012-06-11 18:24:45 -07:00
Jean Chalard
64913d72bc Merge "Move suggestion strip visibility to SettingsValues" 2012-06-11 18:18:50 -07:00