Commit graph

7350 commits

Author SHA1 Message Date
Tadashi G. Takaoka
3033cc51b8 Refactor logic to retrieve relevant suggestions a bit
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-20 12:08:25 +09:00
Keisuke Kuroyanagi
3f3b0af5b7 Merge "Fix unit tests by adding @UsedForTesting" 2014-01-19 22:47:03 +00:00
Keisuke Kuroyanagi
fde4c5f128 Fix unit tests by adding @UsedForTesting
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
2014-01-19 13:37:23 -08:00
Keisuke Kuroyanagi
b1814c9633 Merge "Make contacts dict and user dict version 4." 2014-01-17 20:05:17 +00:00
Keisuke Kuroyanagi
ed95d79cc4 Make contacts dict and user dict version 4.
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
2014-01-17 10:30:16 -08:00
Tadashi G. Takaoka
6a18af634e Refactor RichInputConnection a bit
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
2014-01-17 13:14:29 +09:00
Jean Chalard
2334bf6d8c Merge "Fix a bug specific to German capitalization." 2014-01-17 01:49:14 +00:00
Jean Chalard
e4f584de73 Merge "[IL60] Make InputLogicHandler package private" 2014-01-16 18:15:15 +00:00
Jean Chalard
87f87d9ac5 Merge "[IL59] Rename a method" 2014-01-16 18:13:39 +00:00
Jean Chalard
9c9c43c0b7 Merge "[IL58] Simplification" 2014-01-16 17:45:59 +00:00
Keisuke Kuroyanagi
f4bf620502 Merge "Add a dedicated method to control time in native code." 2014-01-16 17:25:29 +00:00
Jean Chalard
ab4543d593 [IL61] Remove an internal use of key coordinates
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
2014-01-17 02:10:56 +09:00
Jean Chalard
81255612bc [IL60] Make InputLogicHandler package private
Yay

Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
2014-01-17 02:10:56 +09:00
Jean Chalard
17bd129faf [IL59] Rename a method
Um... this is not async ? Remove that from the name

Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
2014-01-17 02:10:56 +09:00
Jean Chalard
ac6dfaf80b [IL58] Simplification
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.

Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
2014-01-17 02:10:51 +09:00
Jean Chalard
60afa7000f Fix a bug specific to German capitalization.
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
2014-01-17 02:06:24 +09:00
Keisuke Kuroyanagi
9e882e3937 Merge "Update personalization dict via dictionary facilitator." 2014-01-16 02:00:21 +00:00
Keisuke Kuroyanagi
12474634c5 Update personalization dict via dictionary facilitator.
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
2014-01-15 17:54:17 -08:00
Keisuke Kuroyanagi
d78a447d10 Add a dedicated method to control time in native code.
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
2014-01-15 14:55:57 -08:00
Jean Chalard
2c1a13c56c Merge "[IL57] Don't require a main dict suggestion." 2014-01-15 22:14:27 +00:00
Jean Chalard
118a4fc2b7 Merge "[IL56] Don't erase suggestions when reverting a commit." 2014-01-15 19:21:06 +00:00
Jean Chalard
e22e67e37a [IL57] Don't require a main dict suggestion.
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.

Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
2014-01-16 03:22:51 +09:00
Jean Chalard
4752b68f5a [IL56] Don't erase suggestions when reverting a commit.
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
2014-01-16 03:22:46 +09:00
Tadashi G. Takaoka
20a8a4a3d9 Fix native method signature
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
2014-01-15 18:56:40 +09:00
Tadashi G. Takaoka
01c1a1a2ba Refactor LanguageModelParam class a bit
This change must be checked in together with I9ecfd1adc1.

Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
2014-01-15 17:46:32 +09:00
Tadashi G. Takaoka
17a2bcfcce Make final Locale field public
This change must be checked in together with Id9382498a8.

Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
2014-01-15 17:11:54 +09:00
Tadashi G. Takaoka
b8a2772b0e Consolidate LanguageModelParam constructors
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
2014-01-15 16:17:53 +09:00
Tadashi G. Takaoka
7b9b095090 Move LanguageModelParams class to utility package
This change must be checked in together with Ic82d951237.

Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
2014-01-15 16:14:53 +09:00
Keisuke Kuroyanagi
68069c55c4 Fix flaky unit test.
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
2014-01-14 18:51:29 -08:00
Tadashi G. Takaoka
bf418f7cba Pass time stamp to addToUserHistory method as an argument
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
2014-01-14 15:48:08 +09:00
Keisuke Kuroyanagi
5717c63a2b Fix possible NPE in DictionaryFacilitatorForSuggest.
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
2014-01-10 21:42:08 +09:00
Jean Chalard
db0adf86a4 Merge "[IL55] Remove a useless argument." 2014-01-10 11:36:01 +00:00
Keisuke Kuroyanagi
eb66f1906d Merge "Check corpus handles during startup for personalization." 2014-01-10 11:34:39 +00:00
Jean Chalard
6c24b91601 [IL55] Remove a useless argument.
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
2014-01-10 20:28:50 +09:00
Keisuke Kuroyanagi
eb28bac542 Check corpus handles during startup for personalization.
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
2014-01-10 20:28:30 +09:00
Jean Chalard
4be9137609 Merge "[IL54.5] Use the cursor pos estimate, not the last value" 2014-01-10 10:46:27 +00:00
Jean Chalard
a224aafea3 [IL54.5] Use the cursor pos estimate, not the last value
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.

Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
2014-01-10 19:08:47 +09:00
Keisuke Kuroyanagi
f96e0f07af Merge "Periodic wipe of the personalization dict." 2014-01-10 09:31:22 +00:00
Keisuke Kuroyanagi
ba07df7fc1 Periodic wipe of the personalization dict.
Bug: 12216453

Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
2014-01-10 16:30:59 +09:00
Jean Chalard
ecf46df226 [IL54] Add a mirror method to fix the cursor pos estimate
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.

Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
2014-01-10 16:05:02 +09:00
Jean Chalard
6fbe83be7a [IL53] Fix a wrong test.
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.

When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.

The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.

Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
2014-01-10 15:21:20 +09:00
Jean Chalard
958e452025 Merge "Fix an NPE." 2014-01-10 05:13:47 +00:00
Jean Chalard
e1de87ae69 Fix an NPE.
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
2014-01-10 13:46:37 +09:00
Jean Chalard
84a3047e80 Fix build.
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
2014-01-10 12:18:26 +09:00
Tadashi G. Takaoka
ee35e69eae Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
This change must be checked in together with Iec437d6df0.

Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
2014-01-09 19:05:09 +09:00
Tadashi G. Takaoka
494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
Tadashi G. Takaoka
d7660c6f56 Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode" 2014-01-09 09:31:32 +00:00
Tadashi G. Takaoka
c912b2228a Merge "Add American typography boolean to SpacingAndPunctuations" 2014-01-09 09:31:24 +00:00
Tadashi G. Takaoka
0a75cf51af Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
2014-01-09 18:19:17 +09:00
Tadashi G. Takaoka
860c3b8e8c Add American typography boolean to SpacingAndPunctuations
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
2014-01-09 18:17:29 +09:00
Yohei Yukawa
6c326caa4f A style fix
Just a style fix to follow up the previous commit.

BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
2014-01-09 15:54:47 +09:00
Keisuke Kuroyanagi
b30f7e4bce Merge "Check whether the word is OOV or not for amanatto update." 2014-01-09 06:24:17 +00:00
Jean Chalard
eab4d25210 Merge "Remove some warnings" 2014-01-09 05:45:10 +00:00
Yohei Yukawa
c1f2986a72 Merge "Trigger haptic feedback at touch down on the EmojiPalettesView" 2014-01-09 05:19:37 +00:00
Jean Chalard
b11339b3ab Remove some warnings
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
2014-01-09 14:04:34 +09:00
Jean Chalard
d3e78fc5ce Merge "Fix a bug where changing auto-shift would cancel autorepeat." 2014-01-09 04:53:34 +00:00
Jean Chalard
5cbda70956 Fix a bug where changing auto-shift would cancel autorepeat.
Bug: 12453966
Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
2014-01-09 12:57:10 +09:00
Yohei Yukawa
df10aeb1da Trigger haptic feedback at touch down on the EmojiPalettesView
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down.
This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts.

This patch set also fixes the missing haptic feedback from facemarks such as ":-)".

Bug: 11439600
Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
2014-01-09 12:27:31 +09:00
Keisuke Kuroyanagi
05113c1847 Check whether the word is OOV or not for amanatto update.
Bug: 11736529
Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
2014-01-08 21:02:35 +09:00
Keisuke Kuroyanagi
5742a415f3 Merge "Make reloadMainDict() private." 2014-01-08 11:03:02 +00:00
Keisuke Kuroyanagi
9f1fe87580 Make reloadMainDict() private.
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
2014-01-08 18:59:43 +09:00
Jean Chalard
b90fa0fb2c Revert "Revert "Separate spacing and punctuation related settings values""
This reverts commit 8bc427799a.

Change-Id: I34f509998afdb1a7c120fbfdb9f0a1b188224a4d
2014-01-08 18:08:01 +09:00
Jean Chalard
e5cdcaff65 Fix a race condition, take 2.
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
2014-01-08 18:04:44 +09:00
Jean Chalard
1e7f2809d2 Merge "Revert "Separate spacing and punctuation related settings values"" 2014-01-08 09:03:15 +00:00
Jean Chalard
8bc427799a Revert "Separate spacing and punctuation related settings values"
This is conflicting with later changes. Temporary revert for cherry-pick.

This reverts commit 0b593ce858.

Change-Id: Id53eadb023a950cfcca496c0cfbfe583c7ec7b8c
2014-01-08 09:00:45 +00:00
Jean Chalard
d4843c25e2 Merge "Revert "Fix a race condition, take 2."" 2014-01-08 09:00:18 +00:00
Jean Chalard
a247264dc6 Revert "Fix a race condition, take 2."
Conflicts prevent this to be cherry-picked.

This reverts commit dd3d697a6e.

Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
2014-01-08 08:59:26 +00:00
Jean Chalard
ff7103d356 Merge "Fix a race condition, take 2." 2014-01-08 08:35:24 +00:00
Jean Chalard
0a0a3cdad8 Merge "Revert "Revert "Fix a race condition.""" 2014-01-08 08:35:19 +00:00
Jean Chalard
dd3d697a6e Fix a race condition, take 2.
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
2014-01-08 17:19:29 +09:00
Jean Chalard
f628629f69 Revert "Revert "Fix a race condition.""
This reverts commit 3840127244.

Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
2014-01-08 16:44:43 +09:00
Tadashi G. Takaoka
ad78058a93 Rename InputPointers.addPointer and ResizableIntArray.add
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
e13cc9d7e5 Fix ResizableIntArrayTests readability
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
9b351f7594 Merge "Fix InputPointersTests" 2014-01-08 05:29:32 +00:00
Tadashi G. Takaoka
e7dc5302af Fix InputPointersTests
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.

Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
2014-01-08 14:14:42 +09:00
Keisuke Kuroyanagi
b3c51630a6 Fix: NPE in LatinIME.loadSettnigs().
Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
2014-01-08 12:43:58 +09:00
Tadashi G. Takaoka
385031557b Merge "Separate spacing and punctuation related settings values" 2014-01-08 02:41:51 +00:00
Tadashi G. Takaoka
0b593ce858 Separate spacing and punctuation related settings values
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
2014-01-08 10:02:37 +09:00
Keisuke Kuroyanagi
c09fd175c3 Prepare using dictionaryFacilitator for amanatto updates.
Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
2014-01-07 18:11:23 +09:00
Keisuke Kuroyanagi
55713e3695 Update personalized dict only when single subtype is used.
Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
2014-01-07 18:10:27 +09:00
Keisuke Kuroyanagi
8214a8c2cf Fix possible NPE.
Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
2014-01-06 17:56:49 +09:00
Tadashi G. Takaoka
3f8c6b8c54 Merge "Add description of disabled voice input key option" 2014-01-06 03:25:15 +00:00
Tadashi G. Takaoka
12ba821bfb Add description of disabled voice input key option
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
2014-01-06 12:11:55 +09:00
Tadashi G. Takaoka
e91559a119 Merge "Update shortcut IME info before checking availability of it" 2014-01-06 03:07:23 +00:00
Tadashi G. Takaoka
e9584a1612 Merge "Add DictionaryFacilitatorForSuggest constructor for testing" 2014-01-06 02:58:12 +00:00
Tadashi G. Takaoka
b7c531b751 Update shortcut IME info before checking availability of it
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
2014-01-06 11:54:46 +09:00
Tadashi G. Takaoka
49b5fadae1 Add DictionaryFacilitatorForSuggest constructor for testing
This change must be checked in together with I00b6e79d6b.

Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
2014-01-06 11:00:51 +09:00
Jean Chalard
1e50c681af [IL52] Remove a useless method.
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.

Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.

Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
2013-12-27 22:40:19 +09:00
Jean Chalard
8ce921dd6b [IL51] Make private what can be made private
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
2013-12-27 21:09:47 +09:00
Jean Chalard
53c320e275 [IL50] Move the InputUpdater out of LatinIME.
...at last

Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
2013-12-27 21:09:41 +09:00
Jean Chalard
81e0ca5fd3 [IL49] Move InputLogic-related init code to InputLogic.
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
2013-12-27 20:06:39 +09:00
Jean Chalard
4970eda286 Fix a failing test
How/when did this happen? How was it not noticed?

Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
2013-12-27 20:04:41 +09:00
Jean Chalard
d05ea8bd82 Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic." 2013-12-27 08:06:48 +00:00
Jean Chalard
af26a44102 Merge "[IL47] Inline getSuggestedWordsGestureLocked" 2013-12-27 08:04:51 +00:00
Jean Chalard
51e79fb4b2 Merge "[IL46] Remove a useless message passing." 2013-12-27 07:56:56 +00:00
Jean Chalard
2fc1cc099f Merge "[IL45] Remove lingering messages" 2013-12-27 07:56:44 +00:00
Jean Chalard
c654fe57b1 [IL48] Move onEndBatchInputAsyncInternal to InputLogic.
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
2013-12-27 16:50:08 +09:00
Jean Chalard
4a144b9b4d [IL47] Inline getSuggestedWordsGestureLocked
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.

Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
2013-12-27 16:50:08 +09:00
Jean Chalard
71a3e96382 [IL46] Remove a useless message passing.
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords

The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.

Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
2013-12-27 16:50:06 +09:00
Jean Chalard
0d21223521 Merge "[IL44] Some factorization" 2013-12-27 06:58:12 +00:00
Jean Chalard
31ff2a4335 [IL45] Remove lingering messages
Bug: 8636060
And possibly bug: 12085864

Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
2013-12-27 15:34:30 +09:00
Jean Chalard
69e7a0d24d [IL44] Some factorization
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.

Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
2013-12-27 15:34:26 +09:00
Keisuke Kuroyanagi
c197b9ed90 Merge "Make setAdditionalDictionaries private." 2013-12-27 06:22:18 +00:00
Keisuke Kuroyanagi
86da47e8d7 Fix possible NPE in FileUtils.
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
2013-12-27 14:58:38 +09:00
Keisuke Kuroyanagi
abc3d0eb56 Make setAdditionalDictionaries private.
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
2013-12-27 14:49:32 +09:00
Jean Chalard
6bca9ac43d Fix a bug where predictions would not pop upon manual pick
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
2013-12-26 23:19:29 +09:00
Jean Chalard
33b2aaafc2 Merge "Fix a code path that looks ridiculous" 2013-12-26 13:39:21 +00:00
Jean Chalard
f294ed3308 Fix a code path that looks ridiculous
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
2013-12-26 22:28:16 +09:00
Jean Chalard
f441047fad [IL43] Small cleanup
All calls are already passing this

Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
2013-12-26 22:12:24 +09:00
Jean Chalard
c28f02880c [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
2013-12-26 22:12:22 +09:00
Jean Chalard
70433efc41 [IL41] Remove a useless call and trampoline.
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.

Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
2013-12-26 21:58:41 +09:00
Keisuke Kuroyanagi
be147f1fdc Remove DictionaryFacilitatorForSuggest.getMainDictionary().
Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
2013-12-26 20:48:19 +09:00
Keisuke Kuroyanagi
a374482719 Extract dict operations from Suggest to a new class.
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
2013-12-26 20:48:19 +09:00
Jean Chalard
5c45ff1214 [IL39] Change a test.
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.

Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
2013-12-26 18:44:17 +09:00
Jean Chalard
98140faac3 [IL38] Fix a wrong double call
This only gives bad results if a gesture results in only one suggestion.

Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
2013-12-26 18:43:47 +09:00
Keisuke Kuroyanagi
65e3ae6f15 Merge "Remove useless method call for spell checker." 2013-12-26 06:42:51 +00:00
Keisuke Kuroyanagi
7987afbea4 Remove useless method call for spell checker.
Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
2013-12-26 14:51:05 +09:00
Tadashi G. Takaoka
3fbcf48591 Merge "Add BatchInputArbiter" 2013-12-26 05:50:07 +00:00
Tadashi G. Takaoka
4a4b6d42a7 Add BatchInputArbiter
Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.

This change must be checked in together with Ia7db8f4fb7.

Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
2013-12-26 14:09:57 +09:00
Jean Chalard
30a72da42c [IL37] Small simplification
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
2013-12-26 13:51:09 +09:00
Jean Chalard
c08119e5c1 [IL36] Inline setAutoCorrection
There are far too many one-use methods.

Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
2013-12-26 13:18:36 +09:00
Jean Chalard
52a2682b99 [IL35] Preparative cleanup
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
2013-12-25 22:25:49 +09:00
Jean Chalard
0154609a2e Merge "[IL34] Introduce InputLogicHandler" 2013-12-25 13:21:54 +00:00
Keisuke Kuroyanagi
5c4bd20331 Remove "Boost personalization dictionary" from settings.
Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
2013-12-25 19:02:49 +09:00
Keisuke Kuroyanagi
bb39518bd7 Use SettingsValues instead of Settings in Suggest.
Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
2013-12-25 18:53:04 +09:00
Tadashi G. Takaoka
d99d225f10 Merge "Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints" 2013-12-25 06:58:08 +00:00
Keisuke Kuroyanagi
eea7122e5b Move dict operations to Suggest.
Bug: 8187060

Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
2013-12-25 15:26:50 +09:00
Tadashi G. Takaoka
c3fe1425a5 Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints
This change must be checked in together with Ibed5330614.

Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace
2013-12-25 15:19:00 +09:00
Jean Chalard
621dcbc31c [IL34] Introduce InputLogicHandler
Bug: 8636060
Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f
2013-12-25 14:20:19 +09:00
Keisuke Kuroyanagi
605caf1b5f Fix NPE in SettingsValues.
Change-Id: I96fc381d2b45881aeb342d33207cd7fe82f5077c
2013-12-25 14:00:16 +09:00
Tadashi G. Takaoka
a801c8fd9b Merge "Rename gesture related classes" 2013-12-25 04:04:05 +00:00
Tadashi G. Takaoka
e2a6253cb5 Rename gesture related classes
Change-Id: I5cb03576bb7221f1864e157857d872880a0a58f8
2013-12-25 11:52:54 +09:00
Keisuke Kuroyanagi
f1457e7a22 Remove personalized dicts when the option is turned off.
Bug: 11757851

Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f
2013-12-25 11:44:16 +09:00
Tadashi G. Takaoka
afca1ddd23 Comprehensive memory deallocation
Change-Id: I4673543c96eb342c3c977e00d44772a0d719a23e
2013-12-24 18:26:55 +09:00
Tadashi G. Takaoka
cf915ddc87 Rename classes related to AbstractDrawingPreview
Change-Id: Ife2e2c08b2b6fbf9ec33cf259f276878816b291c
2013-12-24 18:17:00 +09:00
Tadashi G. Takaoka
e82200787c Separate GestureStrokePreviewParams to top level class
Change-Id: I4c6ac12dac9636760128625bb5b7138b7d56f3d1
2013-12-24 17:27:15 +09:00
Tadashi G. Takaoka
dc2ce72555 Merge "Make GestureStrokeParams as a top level class" 2013-12-24 06:40:29 +00:00
Tadashi G. Takaoka
c845d4c664 Make GestureStrokeParams as a top level class
Change-Id: I540a2d3a6c6ce6ecdcccecd38df6b3c23fcf8d95
2013-12-24 15:29:10 +09:00
Jean Chalard
036930e80d Merge "[IL33] Opportunistically remove some KeyboardSwitcher" 2013-12-24 06:28:54 +00:00
Jean Chalard
8476c2e788 [IL33] Opportunistically remove some KeyboardSwitcher
Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
2013-12-24 15:11:35 +09:00
Tadashi G. Takaoka
904866c701 Clean up batch input related code a bit
Change-Id: I3b6a95fdb82bd15e2b636b1374a96d8987d5d8cf
2013-12-24 14:24:27 +09:00
Tadashi G. Takaoka
aa7a68a3e0 Remove duplicate code
Change-Id: Ia33ea2dc4bb063ec5bf282c656ccc1f11ac967fe
2013-12-24 12:39:16 +09:00
Jean Chalard
07f7536b04 [IL32] Remove a useless variable
Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c
2013-12-20 21:34:07 +09:00
Jean Chalard
1587be6977 [IL31] Move *BatchInput to InputLogic
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
2013-12-20 21:24:27 +09:00
Jean Chalard
059f4c2f39 [IL30] Minor refactoring
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
2013-12-20 20:47:44 +09:00
Jean Chalard
0547b33130 [IL29] Move retryResetCaches and tryFixLyingCursorPosition
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
2013-12-20 20:47:29 +09:00
Jean Chalard
81e8d16031 [IL28] Remove useless code
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.

Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
2013-12-20 19:48:05 +09:00
Jean Chalard
55ce2cc2d5 [IL27] Some refactoring
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
2013-12-20 19:24:38 +09:00
Jean Chalard
221df9e59a [IL26] Move restartSuggestionsOnWordTouchedByCursor
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
2013-12-20 19:09:36 +09:00
Jean Chalard
ec4b6e7bb3 [IL25] Inline handleClose
Only ever used here.

Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
2013-12-20 18:44:13 +09:00
Jean Chalard
aa161eb371 [IL24] Move mDisplayOrientation to SettingsValues.
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
2013-12-20 18:44:09 +09:00
Jean Chalard
a22a63f3b1 Merge "Fix an NPE" 2013-12-20 09:14:56 +00:00
Jean Chalard
92392b21f2 Fix an NPE
Change-Id: I6307c1545d9d48cdea66d08f8efc1b7fbb08ee42
2013-12-20 18:13:23 +09:00
Tadashi G. Takaoka
f405c58c09 Merge "Use config_screen_metrics resource in BogusMoveEventDetector" 2013-12-20 09:03:25 +00:00
Tadashi G. Takaoka
9c4de1e5f7 Use config_screen_metrics resource in BogusMoveEventDetector
Change-Id: I6b957b43c6dd7ce4f639e46d248179662c1ee669
2013-12-20 17:35:19 +09:00
Jean Chalard
1252333efd Merge "[IL23] Resolve a long-standing TODO." 2013-12-20 08:29:29 +00:00
Tadashi G. Takaoka
0c8ea69cad Merge "Separate logic of enabling gesture typing" 2013-12-20 08:03:18 +00:00
Jean Chalard
84e78cb769 Merge "[IL22] Move onTextInput to InputLogic." 2013-12-20 08:02:36 +00:00
Jean Chalard
689cff2e3b Merge "[IL21] Move the workaround utils to a better place." 2013-12-20 08:02:07 +00:00
Jean Chalard
6cf843cba6 [IL23] Resolve a long-standing TODO.
Bug: 8636060
Change-Id: I3a840c30cc4489debf9118beeec448488503bc1c
2013-12-20 16:50:14 +09:00
Jean Chalard
11730aa224 [IL22] Move onTextInput to InputLogic.
Also pull the TLD specific processing

Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
2013-12-20 16:50:14 +09:00
Jean Chalard
1404c1af85 [IL21] Move the workaround utils to a better place.
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
2013-12-20 16:48:54 +09:00
Tadashi G. Takaoka
a00838b6e8 Separate logic of enabling gesture typing
Change-Id: I91fc566f24a38a55d2352201d5d581d3fa02a428
2013-12-20 16:37:17 +09:00
Tadashi G. Takaoka
db6d9b0ab4 Merge "Separate BogusMoveEventDetector class" 2013-12-20 07:36:07 +00:00
Tadashi G. Takaoka
c986d16e8a Separate BogusMoveEventDetector class
Change-Id: I24f0ff385f338ff313ef32514f2930f120183be7
2013-12-20 16:17:41 +09:00
Tadashi G. Takaoka
9033fb1f64 Merge "Separate TypingTimeRecorder class" 2013-12-20 07:16:34 +00:00
Tadashi G. Takaoka
5045103d61 Separate TypingTimeRecorder class
Change-Id: Ic56d3e3a1be935854dcace36d8a05a9d2619dab9
2013-12-20 16:14:26 +09:00
Jean Chalard
529cdf0a0c Merge "[IL20] Remove some useless processing." 2013-12-20 07:14:09 +00:00
Jean Chalard
95d869fed4 Merge "[IL19] Resolve a TODO." 2013-12-20 07:11:24 +00:00
Jean Chalard
8a390023e1 [IL20] Remove some useless processing.
If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.

Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
2013-12-20 16:02:07 +09:00
Jean Chalard
4487a30e0d [IL19] Resolve a TODO.
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
2013-12-20 16:02:03 +09:00
Jean Chalard
f7d493979a Merge "[IL18] Move and rename updateSuggestionStrip" 2013-12-20 06:54:33 +00:00
Jean Chalard
2a6de7903c [IL18] Move and rename updateSuggestionStrip
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
2013-12-20 15:46:34 +09:00
Tadashi G. Takaoka
921a32f0a9 Remove unnecessary default KeyDetector from PointerTracker
Change-Id: Ib0fbb40a7040202d2a4b4ab49319d9e247a2a6ce
2013-12-20 15:34:54 +09:00
Tadashi G. Takaoka
dbb88e47c8 Merge "Remove unused default object of GestureStrokePreviewParams" 2013-12-20 06:33:36 +00:00
Tadashi G. Takaoka
081989ca30 Remove unused default object of GestureStrokePreviewParams
This change also fixes build broken by Id615556766.

Change-Id: I16605cc3b65e3e9ab2d5a498825c31d9b4046b73
2013-12-20 15:25:24 +09:00
Jean Chalard
1c0374da49 [IL17] Move commitChosenWord to InputLogic.
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.

Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
2013-12-20 15:13:48 +09:00
Jean Chalard
a905fcec00 [IL16] Improve getTextWithSuggestionSpan
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.

Not directly related, but helpful with:
Bug: 8636060

Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
2013-12-20 15:13:48 +09:00
Tadashi G. Takaoka
6e97efef78 Fix rugged gesture trail
Bug: 12222472
Change-Id: Id615556766718a8bd4848f7026833fbcea540c39
2013-12-20 14:40:18 +09:00
Tadashi G. Takaoka
ce9c7d7511 Merge "Remove PointerTracker reference from accessibility package" 2013-12-20 03:33:24 +00:00
Tadashi G. Takaoka
6a23b9e3d5 Remove PointerTracker reference from accessibility package
Change-Id: I1a88d9fc4db437070778ea1256aae17c32428729
2013-12-20 12:29:25 +09:00
Jean Chalard
5c9e677c2a [IL15] Some small refactoring
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
2013-12-20 11:24:45 +09:00
Jean Chalard
48ba1f25ff [IL14] Move getCurrent*Caps* to InputLogic
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
2013-12-20 11:24:42 +09:00
Jean Chalard
cdd8a1a69d [IL13] Inline restartSuggestionsOnWordBeforeCursor
It's only ever used in one place and makes unhealthy assumptions
about what the caller is doing. It's better inlined.

Bug: 8636060
Change-Id: I265d5d96894e929d09247ee2e3dc2e81efc2a276
2013-12-19 20:31:52 +09:00
Jean Chalard
bbe40835a9 [IL12] move restartSuggestions* to InputLogic
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
2013-12-19 20:30:41 +09:00
Jean Chalard
10755af97b [IL11] Cleanup
Make some methods private and add comments.

Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
2013-12-19 20:13:14 +09:00
Jean Chalard
060e292628 [IL10] Move revertCommit to InputLogic
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
2013-12-19 19:30:26 +09:00
Jean Chalard
69a57bcdcd [IL9] Move commitCurrentAutoCorrection to InputLogic
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
2013-12-19 19:30:20 +09:00
Jean Chalard
035e3885ac [IL8] Move handleNonSeparator to InputLogic
Also move getActualCapsMode and getNthPreviousWordForSuggestion

Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
2013-12-19 18:32:51 +09:00
Jean Chalard
d85e49bf8c [IL7] Move performRecapitalization to InputLogic
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
2013-12-19 18:20:41 +09:00
Jean Chalard
40b42b7d84 [IL6] Move handleSeparator to InputLogic
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod

Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
2013-12-19 17:39:01 +09:00
Jean Chalard
c8dfaab783 [IL5] Some renaming
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
2013-12-19 17:38:55 +09:00
Jean Chalard
37d3f1bd02 [IL4] Move handleNonSpecialCharacter to InputLogic.
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
2013-12-19 16:46:57 +09:00
Jean Chalard
0e82fa273d [IL3] Move handleBackspace to InputLogic.
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline

Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
2013-12-19 16:46:54 +09:00
Jean Chalard
cddf4f9d78 [IL2] Move onCodeInput to InputLogic.
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
2013-12-19 16:24:45 +09:00
Jean Chalard
7bd2a75ca1 Start separating the input logic from LatinIME.
Create an InputEngine class and start moving the relevant
variables to it.

Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
2013-12-19 14:48:43 +09:00
Jean Chalard
dfbe2bfe08 Add some info to test crashes to help diagnose flakiness
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
2013-12-18 18:10:56 +09:00
Keisuke Kuroyanagi
1f5a3faf76 Merge "Enable Personalized dictionaries based on the setting." 2013-12-17 10:40:29 +00:00
Keisuke Kuroyanagi
8732f9c5f9 Enable Personalized dictionaries based on the setting.
Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7
2013-12-17 19:36:19 +09:00
Jean Chalard
4196360912 Run GC when needed, instead of too late.
Bug: 12164855
Change-Id: Ie4d8be9f2652b01470bcc06911e2191e09fb3149
2013-12-17 18:08:48 +09:00
Jean Chalard
97a553ae69 Fix wrong dereference reading code.
Bug: 12164855
Change-Id: I26faf27edfa303510197bccaa3521578f649741d
2013-12-17 16:42:22 +09:00
Keisuke Kuroyanagi
b54c747d7c Merge "Move DictUpdater to the tests directory." 2013-12-17 05:33:16 +00:00
Keisuke Kuroyanagi
4fdcefe504 Move DictUpdater to the tests directory.
Bug: 11245133
Change-Id: I0907a091ac3ae960eaf3b27da78dbb48a24b2ea1
2013-12-17 14:31:25 +09:00
Tadashi G. Takaoka
19dd753c0c Cancel more suggestions panel when touching keyboard
Bug: 10010128
Change-Id: I2ff0870c69f407d943caf8b9cec90b7ed89de5f1
2013-12-17 12:59:37 +09:00
Tadashi G. Takaoka
dd4937848a Fix typo in varibale name
Change-Id: I7ea6c59b7c980e93c88a6cf0fef97592d411c3ba
2013-12-17 12:15:02 +09:00
Tadashi G. Takaoka
fcacde3dad Revise Armenian punctuations more keys
Bug: 12096943
Change-Id: Ib8559f030fbc27ec7f7e9a9fb36aad72cca29e9f
2013-12-17 11:12:33 +09:00
Tadashi G. Takaoka
3aeb6a9d0d Merge "Refactor touch event forwarding in InputView" 2013-12-17 02:04:40 +00:00
Tadashi G. Takaoka
27fab2cc2a Refactor touch event forwarding in InputView
Bug: 10010128
Change-Id: I82aa4ce847e66cb1241678f39b47b9e27a0f555a
2013-12-17 08:49:50 +09:00
Jean Chalard
0c7b05fc50 Merge "Fix a bug with languages without spaces and predictions" 2013-12-16 14:17:51 +00:00
Jean Chalard
7cd7cf73f4 Fix a bug with languages without spaces and predictions
This is simpler and more correct.

Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
2013-12-16 23:16:02 +09:00
Keisuke Kuroyanagi
e17cc8270f Merge "Increment version number of ver4 format to 401." 2013-12-16 14:13:42 +00:00
Keisuke Kuroyanagi
b5215d456a Increment version number of ver4 format to 401.
Bug: 11073222
Change-Id: I3878aef02040b1ef73165645fc70ede586289c51
2013-12-16 23:02:54 +09:00
Keisuke Kuroyanagi
214a3b741f Merge "Fix: incompatible PtNode array size reading." 2013-12-16 13:57:55 +00:00
Keisuke Kuroyanagi
56e7e38d37 Fix: incompatible PtNode array size reading.
Bug: 11073222
Change-Id: I681be725b5c6dcc10aa536b00327698a7df75277
2013-12-16 22:42:01 +09:00
Jean Chalard
dc06ee85ef A simplification.
This does the same thing, but simpler and faster.
Was noticed while investigating bug#12164555

Change-Id: If9926e4da8a53a65489da55197ac87122c44fe7c
2013-12-16 21:38:31 +09:00
Keisuke Kuroyanagi
769eb083ef Merge "Add option to enable personalization dictionaries." 2013-12-16 10:33:40 +00:00
Keisuke Kuroyanagi
d4bb7df412 Add option to enable personalization dictionaries.
Bug: 11757851

Change-Id: I4872c10793d4fd55c0bd9e5bc4650925de6d2c1d
2013-12-16 19:17:31 +09:00
Tadashi G. Takaoka
f3b92fb952 Merge "Fix IllegalStateException of ViewGroup" 2013-12-16 08:36:45 +00:00
Tadashi G. Takaoka
7f8345d59a Fix IllegalStateException of ViewGroup
Bug: 10629042
Change-Id: I111d092fb2f7dca47328127a155c981aa1c55906
2013-12-16 17:06:23 +09:00
Keisuke Kuroyanagi
b6a19229ba Merge "Make required binary dictionary version use FormatSpec.*" 2013-12-16 07:56:58 +00:00
Keisuke Kuroyanagi
c837767819 Make required binary dictionary version use FormatSpec.*
Change-Id: Ifb17d6551bc5071553e32a5640dd166c39374461
2013-12-16 16:50:28 +09:00
Jean Chalard
5590e9d040 Merge "Make the bad header a checked exception and fix dicttool test" 2013-12-16 07:18:44 +00:00
Jean Chalard
3df617323e Make the bad header a checked exception and fix dicttool test
Change-Id: If780a2a1cb722aee83d910904c0a6315add9552d
2013-12-16 15:40:45 +09:00
Tadashi G. Takaoka
1b5b0a3ebc Cancel long press shift key while chording input
Bug: 12123508
Change-Id: I693caad1f8ee47ebeb14419603d1fc29f6263a75
2013-12-16 15:30:41 +09:00
Jean Chalard
b868375763 Fix failing tests
- Version 3 is not supported
- Now passing the right string to open v4 dicts. Fix the tests for this.

Change-Id: I7829330c3568a715b96396ba4e4e69c6e17775ab
2013-12-16 14:32:19 +09:00
Ken Wakasa
2c25c7c9e1 Fix locale names in the make-keyboard-text tool
Change-Id: I33c3fafcff124bb94e395cc604ce264daad55d2d
2013-12-14 18:50:57 +09:00
Jean Chalard
330d2720bb Instead of ignoring PARAGRAPH spans, fix them.
I don't know what or when this flag is set, but it's only bad
news. Luckily, we can just remove it.

Bug: 12119393
Change-Id: I2952138c8ce517535b91e0fe25d2cf4960e02862
2013-12-13 23:42:31 +09:00
Jean Chalard
7a904514fb Merge "Don't use the previous word after a non-whitespace separator" 2013-12-13 11:53:30 +00:00
Jean Chalard
0b51fac907 Merge "Only update shift state if left in auto mode." 2013-12-13 11:52:13 +00:00
Jean Chalard
fae1ba767c Don't use the previous word after a non-whitespace separator
Bug: 12101276
Change-Id: Icf36d55ec171194e5561b946021bcf648782ddd4
2013-12-13 20:51:28 +09:00
Jean Chalard
28bd6e2297 Only update shift state if left in auto mode.
Bug: 12100417
Change-Id: I7bc2b19332e142a257b0399f2e5d128caf01fc7c
2013-12-13 20:47:25 +09:00
Jean Chalard
f3d281b775 Merge "Fix a bug where recapitalize prevents going to more syms" 2013-12-13 10:38:18 +00:00
Jean Chalard
5d98e1d82e Fix a bug where recapitalize prevents going to more syms
Bug: 11004973
Change-Id: I97ee9df6e8464e2149beb41c688cbfbd83ac3d8c
2013-12-13 19:21:49 +09:00
Jean Chalard
f08b1ea41a Merge "Remove references to the v3 dictionary." 2013-12-13 10:08:12 +00:00
Tadashi G. Takaoka
bf7503ae6b Merge "Fix key top letter color in shifted layout" 2013-12-13 09:55:19 +00:00
Jean Chalard
1dc7eca114 Remove references to the v3 dictionary.
Change-Id: I811c8c923ad67a6d9bfdd11bdef8991eb7135c27
2013-12-13 18:53:41 +09:00
Keisuke Kuroyanagi
3e81d9c39f Merge "Remove code for forgetting curve in Java side." 2013-12-13 09:44:16 +00:00
Keisuke Kuroyanagi
cc8c544ee2 Remove code for forgetting curve in Java side.
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
2013-12-13 18:40:58 +09:00
Tadashi G. Takaoka
815a339201 Fix key top letter color in shifted layout
There is a chance to have an empty hint label even though
keyLabelFlags has hasShiftedLetterHint flag.

Change-Id: I63b9fcc42a40391d5902814cae4c75abb61e4b94
2013-12-13 18:34:30 +09:00
Jean Chalard
a245d15da5 Have dicttool use the native library to generate v4 dicts.
Yay !

Change-Id: Iea8ced9e81031b9ab7eff05ad9ef7215be248de9
2013-12-13 18:18:20 +09:00
Jean Chalard
af0c222a5e Merge "Remove flags from Java side." 2013-12-13 09:17:10 +00:00
Jean Chalard
7b55cd3e2b Remove flags from Java side.
This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
  The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
  regardless of this flag.

Bug: 11281748
Change-Id: If567e52e245a9342adc7f3104a0f7d8d782df8c1
2013-12-13 18:15:05 +09:00
Ken Wakasa
2fa3693c26 Reset to 9bd6dac470
The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
2013-12-13 17:13:32 +09:00
Keisuke Kuroyanagi
9642286c01 Make ExpandableBinaryDictionary usable for offdevice tests.
Bug: 11956652
Change-Id: If5a503ef161781818f2efceba542be5a61be6bd1
2013-12-13 14:48:43 +09:00
Keisuke Kuroyanagi
9bd6dac470 Add a constructor for testing to non-main dictionaries.
The new constructor is used for creating dictionary instance
that uses a given file.

Bug: 11956652
Change-Id: Ifbf420a1a768eb95a5c3a58eeb1be5936b306d35
2013-12-12 20:14:06 +09:00
Keisuke Kuroyanagi
d06de553b2 Add waitAllTasksForTests for testing.
Bug: 10667710
Change-Id: I7a189e32286a6005393fbde8da736541ca9226a8
2013-12-12 17:08:51 +09:00
Keisuke Kuroyanagi
9ff51527a3 Quit passing header file path to native.
Bug: 12089197
Change-Id: Ia898f8d2836c0c131a1834dc0a396d9121ecb972
2013-12-12 16:48:34 +09:00
Jean Chalard
9fa221a7bd Remove dependency from StringUtils to Json
Change-Id: I2a89497fb9ec12a37ba09f4598742e88f6700576
2013-12-12 13:55:56 +09:00
Tadashi G. Takaoka
79cc690f55 Fix Filipino keyboard
Bug: 12102802
Change-Id: Id55ba5ebd8ddaf83ed246315d81b25ad4c9b6294
2013-12-12 11:12:23 +09:00
Keisuke Kuroyanagi
549ae3d84e Merge "Create ver4 dictionary files with the dictionary name." 2013-12-11 10:42:16 +00:00
Keisuke Kuroyanagi
84cc5a2c76 Create ver4 dictionary files with the dictionary name.
Bug: 12025402

Change-Id: Ia0bb13b2e26aa60a67dff73f3f6a1e276f1bb1dd
2013-12-11 19:30:18 +09:00
Tadashi G. Takaoka
0719c4ca72 Merge "Ignore other finger while showing more keys keyboard" 2013-12-11 09:20:02 +00:00
Tadashi G. Takaoka
7f82bb55ed Ignore other finger while showing more keys keyboard
Bug: 12088861
Change-Id: I784cb8fee247a7a4ea4af4c0569fed9334430e18
2013-12-11 18:12:45 +09:00
Tadashi G. Takaoka
7ca3dbe3e5 Merge "Don't start long press timer while other one is running" 2013-12-11 08:07:47 +00:00
Tadashi G. Takaoka
fa860a091e Don't start long press timer while other one is running
Bug: 11908158
Bug: 12088861
Change-Id: I2537855f505884da9fe958d946c79840bd19dc5f
2013-12-11 17:01:26 +09:00
Tadashi G. Takaoka
0a190a389f Merge "Rename deprecated locale directories" 2013-12-11 06:01:34 +00:00
Keisuke Kuroyanagi
ad2d34f80a Rename PersonalizationPredictionDictionary.
Change-Id: If7497310485a895dd22b8df29dc13508acaa0ab6
2013-12-11 14:09:00 +09:00
Ken Wakasa
423422c437 Rename deprecated locale directories
cf. Ibe392f5f9dbc82c3cdff8e06b958bc3bcce3fa82

Also, cf. bug id 11340849

Change-Id: I43e84f8ca04eb1aa74037a705970a36434429a0f
2013-12-11 13:27:46 +09:00
Jean Chalard
97351ad34c Merge "Fix typos." 2013-12-11 03:41:23 +00:00
Jean Chalard
a8ffdf0288 Merge "Split the header into a separate file." 2013-12-11 03:37:05 +00:00
Jean Chalard
83c879ad67 Fix typos.
One of these cost me a day and a half searching for a bug :(

Change-Id: I20f0b727f7c02e2754aaaf6a05b74c9cf9e6375e
2013-12-11 12:06:05 +09:00
Jean Chalard
3839defc90 Split the header into a separate file.
Bug: 11281748
Change-Id: Ia2490d18bf159990310e10ed45fb6b3a0dee1c5f
2013-12-11 12:03:40 +09:00
Keisuke Kuroyanagi
499371a5ef Remove PersonalizationDictinoary.
Now, PersonalizationPredictionDictionary can be used not only
for prediction but also for suggestions.
We should rename PersonalizationPredictionDictionary to
PersonalizationDictionary.

Change-Id: Ifcf4459072f3523e3f3dc783f12e15b89cdbb12d
2013-12-11 11:09:52 +09:00
Keisuke Kuroyanagi
7c8075c2ac Uncapitalized words for personalization dictionary.
Bug: 11736529
Change-Id: I62a7469afe03092ec992bfb190f717223a8c556f
2013-12-10 19:19:18 +09:00
Tadashi G. Takaoka
a2bbb1213d Remove obsolete warning message
This is a follow up of I5655c5703b.

Change-Id: I4a61689eb275b54648c6112c9f8709e4a9c35a5e
2013-12-07 18:59:13 +09:00
Tadashi G. Takaoka
4d02aa4e8c Add punctuations letters to period key on tablet
Bug: 11918360
Change-Id: I5655c5703bfcb541c9ff4b7e0da2f9b8e14947d0
2013-12-06 18:24:20 +09:00
Tadashi G. Takaoka
637ecce74c Merge "Consolidate multiple locales' period key definition" 2013-12-06 09:21:26 +00:00
Jean Chalard
90c9199753 Merge "[RF4] Actually remove ver4 dicts" 2013-12-06 08:54:33 +00:00
Keisuke Kuroyanagi
fc16c320c6 Merge "Add a jni method to fetch unigram information." 2013-12-06 08:53:21 +00:00
Keisuke Kuroyanagi
9fb28f78f7 Add a jni method to fetch unigram information.
Bug: 11956652

Change-Id: I59f1823bbc0146f6d2f34cbed8166bb6de197208
2013-12-06 17:17:38 +09:00
Jean Chalard
c5db41a9d5 [RF4] Actually remove ver4 dicts
And fix a couple bugs.

Bug: 11281748
Change-Id: If07953a4b1ff9eb1165af03fdb332d7e47cd8f32
2013-12-06 17:07:59 +09:00
Tadashi G. Takaoka
5bf55a86d0 Return null if "!text/" reference is an empty text
Change-Id: I01826f3e09527348fb4cba3302a9394ff34f424a
2013-12-06 16:51:11 +09:00
Tadashi G. Takaoka
aab0140390 Consolidate multiple locales' period key definition
Bug: 11918360
Change-Id: If59043709a433a57846de07e150bf9c14b614d52
2013-12-06 15:25:47 +09:00
Jean Chalard
a72e8f1ede [RF3] Cleanups
Make the version number a single number on native and java side.
Also, remove the hasValidContents method. It's useless since the
native code already checks this when creating the dictionary (I
wish I had known that when I added it).

Bug: 11281748
Change-Id: I572d37429972b2f280e4bdb748b709e5d0d7737e
2013-12-06 14:53:03 +09:00
Jean Chalard
cb27d955f3 Merge "[RF2] Some refactoring and some cleanup" 2013-12-06 04:30:25 +00:00
Jean Chalard
b8481456f2 [RF2] Some refactoring and some cleanup
Bug: 11281748
Change-Id: Iff45fdf6b23f77c08271a169c7d7ca45912c85e8
2013-12-06 13:06:49 +09:00
Tadashi G. Takaoka
6300168cb8 Fix puctuations more keys on Spanish/Phone
Bug: 11918360
Change-Id: I01e1c1e2a1953855bd2b009fc2d82e18cdde7140
2013-12-05 18:54:29 +09:00
Tadashi G. Takaoka
4cd86d3bb4 Cleanup exclamation and questuion keys
Bug: 11918360
Change-Id: I00731a273beea6dbc300dc215996dcadd97f17e2
2013-12-05 18:53:32 +09:00
Tadashi G. Takaoka
624fcde18b Cleanup comma key of Arabic/Farsi
Bug: 11918360
Change-Id: I4ab373d8fc012fd77a388a067d7f5d99d8247299
2013-12-05 18:15:45 +09:00
Tadashi G. Takaoka
f6b479d482 Add exclamation/question marks to Hebrew tablet keyboard
Bug: 11918360
Change-Id: I226f8fbb2177f472f69b56faca2a141687734494
2013-12-05 12:47:47 +09:00
Tadashi G. Takaoka
1eb63684f9 Merge "Add workaround to prevent ViewPager from crashing" 2013-12-04 09:05:07 +00:00
Tadashi G. Takaoka
5086275d39 Add workaround to prevent ViewPager from crashing
Bug: 11721001
Change-Id: I0824f82c30a288a3c1f0ea69e07f10bdeb744bbc
2013-12-04 17:46:15 +09:00
Jean Chalard
743c7e0e6e Merge "[RF1] Remove files that don't match the expected format, step 1" 2013-12-04 08:19:26 +00:00
Keisuke Kuroyanagi
c63f2762cc Merge "Start to use historical info." 2013-12-04 08:03:53 +00:00
Jean Chalard
5e80e699c4 [RF1] Remove files that don't match the expected format, step 1
This implements the skeleton implementation, and enables a
fallback implementation in the case the file is coming from the
dictionary provider.
- A better scheme should be used for provider-supplied dicts.
- This does not implement the solution for device-generated
    dicts yet. This will come in a future change.
- This does not implement the checking process on the native
    side yet. This will come in a future change.

Bug: 11281748
Change-Id: Ifa6e237d19dfbffe503e3674915480ea867b0ddf
2013-12-04 16:19:55 +09:00
Keisuke Kuroyanagi
e33072eb50 Quit using obsolete methods for testing.
Bug: 11073222
Change-Id: I77c99fbea2f255dbfddb646b6e12bee574647eca
2013-12-04 16:03:53 +09:00
Keisuke Kuroyanagi
4d68867839 Start to use historical info.
Bug: 11073222
Change-Id: I232d41bec5df7952856b5ba4765977707c39b94a
2013-12-04 12:52:58 +09:00
Tadashi G. Takaoka
7081a36e2f Merge "Add spacebar background drawable" 2013-12-04 03:47:41 +00:00
Tadashi G. Takaoka
dc337df48c Add spacebar background drawable
Bug: 11106827
Change-Id: Ic6e0b6bd9187901b01d64296db816afa73da9ffd
2013-12-04 12:31:10 +09:00
Keisuke Kuroyanagi
a0befc6490 Start passing timestamp for dynamic dictionaries.
Bug: 11073222
Change-Id: I89e1277f734d5959e33d61e7e9e7048084b9007a
2013-12-04 11:57:45 +09:00
Ken Wakasa
64ead8d293 Merge "Add required header attributes for user/contacts dictionary." 2013-12-03 10:23:51 +00:00
Keisuke Kuroyanagi
8bfc8c46ff Add required header attributes for user/contacts dictionary.
Bug: 11973488

Change-Id: I91ef720a24633aec0f4e81cd4f7c49c749805c49
2013-12-03 19:22:17 +09:00
Jean Chalard
25848af556 Tiny refactoring
Add a warning comment and make it so that openNative()
is only called in one place in the code.

Bug: 11281748
Change-Id: Ic7819a01deb62cf145ebf9d620da2d15fae19313
2013-12-03 17:46:56 +09:00
Tadashi G. Takaoka
6d9e273fb5 Separate common config and dimensions resources
Change-Id: Ia16880e818927bc3df7292e130b2f7b5efc9776e
2013-12-03 12:14:27 +09:00
Keisuke Kuroyanagi
d1501ea789 Make contacts/user dictionary ver2.
Change-Id: I10c29bd45fd37d765f115333087e1700dd90570b
2013-12-02 21:59:56 +09:00
Jean Chalard
5fa4ad6a85 Merge "Fix some more tests" 2013-12-02 12:41:25 +00:00
Jean Chalard
ca5c7a9e14 Fix some more tests
Bug: 11960453
Bug: 11954718
Change-Id: I71e98cc6ab30cc89e921e9ef578d7f6366049d01
2013-12-02 21:05:26 +09:00
Tadashi G. Takaoka
770b00874b Remove KeyEventHandler
Change-Id: Iddde1f85139cb21bde6e4fc275c32f3d62f4862f
2013-12-02 20:25:25 +09:00
Tadashi G. Takaoka
5d311f2c13 Merge "Add config_ prefix to the resource names merged from dimens.xml" 2013-12-02 11:14:07 +00:00
Jean Chalard
576c753d25 Fix an obvious bug
This had to be a typo

Change-Id: Id49e44d7667d64b00e883c55c683535398b6bdea
2013-12-02 20:04:52 +09:00
Tadashi G. Takaoka
8c6052bce1 Add config_ prefix to the resource names merged from dimens.xml
Change-Id: I6fb11b8cb52c06b805fb17d61450d7df50e4e20d
2013-12-02 20:01:15 +09:00
Keisuke Kuroyanagi
545e4191b3 Merge "Quit recording LastUserHistoryWriteTime." 2013-12-02 10:10:32 +00:00
Keisuke Kuroyanagi
cffe4d2d0f Quit recording LastUserHistoryWriteTime.
Change-Id: I0f2b408b4976d8119c932654e23836803d42c568
2013-12-02 18:45:32 +09:00
Jean Chalard
9ab71eda83 Fix tests.
This fixes a few bugs that became apparent with the
reinstating of a test.

Bug: 11954718
Change-Id: I1127bc3180f856566429f40d14c944e6f0007e09
2013-12-02 18:15:22 +09:00
Tadashi G. Takaoka
9a0216def9 Avoid NPE by checking
Bug: 11956240
Change-Id: I3de1ebbf96fa2422124e4d8e50190adfa09b8a49
2013-12-02 16:25:20 +09:00
Jean Chalard
d7337a72bc Merge "Fix auto-detection of format 4." 2013-11-29 10:31:37 +00:00
Jean Chalard
26c9af33a7 Fix auto-detection of format 4.
Bug: 11073222
Change-Id: I76e47d0399cf43fc3cc18cb1252f166be86b9a69
2013-11-29 19:10:19 +09:00
Tadashi G. Takaoka
3f8c1d4a19 Clean up PointerTracker a bit
Change-Id: I227501607ee1476c2f6faceca1c3c0833778a0ee
2013-11-29 16:55:25 +09:00
Tadashi G. Takaoka
18ffeaba16 Use interfaces instead of MainKeyboardView class
Change-Id: I760b107d804fc84153f08667f20061fedd308841
2013-11-29 12:19:49 +09:00
Tadashi G. Takaoka
ccc86630a2 Rename StaticInnerHandlerWrapper to LeakGuardHandlerWrapper
Change-Id: I024f0ee9c7f7718afc8a4ca0c6c49f2e88b035ad
2013-11-29 12:15:40 +09:00
Keisuke Kuroyanagi
22e28d5a2d Merge "Add version check to open binary dictionary." 2013-11-28 11:52:59 +00:00
Keisuke Kuroyanagi
8ac3c65b00 Add version check to open binary dictionary.
Bug: 11073222
Change-Id: Iabae12b8f14a9da3cdc804dcc6af443cedeb3f99
2013-11-28 20:40:26 +09:00
Tadashi G. Takaoka
2e2af0e1e1 Merge "Move MainKeyboardView.KeyTimerHandler to top level class" 2013-11-28 10:21:41 +00:00
Tadashi G. Takaoka
3fd16cbaa8 Merge "Move MainKeyboardView.DrawingHandler to top level class" 2013-11-28 10:21:34 +00:00
Tadashi G. Takaoka
3c764b2e96 Move MainKeyboardView.KeyTimerHandler to top level class
Change-Id: Iec310b7fc6127a8a5491dbb9f8f073e455e7ba29
2013-11-28 19:03:37 +09:00
Jean Chalard
33e777fe08 Merge "Change the timing of reading the previous word." 2013-11-28 09:57:22 +00:00
Tadashi G. Takaoka
c82e99caa0 Move MainKeyboardView.DrawingHandler to top level class
Change-Id: I7a785725d5eb0b594485ceb25695a89c017cc60f
2013-11-28 18:56:15 +09:00
Jean Chalard
4866a3e918 Change the timing of reading the previous word.
Bug: 11328842
Change-Id: I08229e895fc34403932648b9b931583d965f0e01
2013-11-28 18:51:03 +09:00
Jean Chalard
177a86d394 Merge "Fix getNthPreviousWord." 2013-11-28 09:02:46 +00:00
Tadashi G. Takaoka
b1d87850ec Fix updating list preference summary for unknown value
Change-Id: I86d3162a90e0068e787a906c0d3d64102487620a
2013-11-28 14:12:29 +09:00
Jean Chalard
da459787e2 Fix getNthPreviousWord.
This should take into accounts word connectors.

Change-Id: Ic7fa5c837cd65a43ba43d7ae9d299b8d20019892
2013-11-28 11:41:23 +09:00
Keisuke Kuroyanagi
3c7b603c46 Merge "Start using Ver4 dictionary format." 2013-11-27 10:02:21 +00:00
Tadashi G. Takaoka
169d76cc5c Merge "Disable mic key on more keys when voice IME is disabled" 2013-11-27 09:56:42 +00:00
Tadashi G. Takaoka
b70a419a9e Disable mic key on more keys when voice IME is disabled
Bug: 11883501
Change-Id: Ie3f496935f9600e2bde51cbebed2b4f8c90c25b2
2013-11-27 18:36:08 +09:00
Jean Chalard
4735e1d32a Merge "Fix messages in tests" 2013-11-27 08:44:31 +00:00
Jean Chalard
dfc5aade2d Fix messages in tests
They are not failing because of this right now, but future
tests would fail without this.
Concretely, since the Handler for any given main thread is
a singleton managed by the framework, the messages won't
be removed automatically. In particular, messages posted
with a delay have a large destructive potential, because
they will go through before the startInputViewInternal
method is called, because it's called with a message too (in
turn, this is because of working around framework bugs).

Bug: 11142685
Change-Id: If81a168efcfd7d93806ddc4ea432d438c45a3e1d
2013-11-27 17:37:57 +09:00
Tadashi G. Takaoka
05e099d77d Remove voice-on-main related code and resources
Change-Id: I3a1b06fa028dbf130c7aa2c83e9ec1a180aa1f5c
2013-11-27 16:48:47 +09:00
Tadashi G. Takaoka
c144299f70 Merge "Remove compiler warnings from emoji related code" 2013-11-27 03:44:34 +00:00
Ken Wakasa
c01dba872c Small optimizations for single code point strings
Change-Id: I299c7622db291ea411e2b48dfdb622b407912ea6
2013-11-27 12:40:13 +09:00
Keisuke Kuroyanagi
02fd1a78a3 Start using Ver4 dictionary format.
Bug: 11073222

Change-Id: Idd836ee15501e2f8c57c8eebc1fef7f103b01d18
2013-11-27 12:14:03 +09:00
Tadashi G. Takaoka
6bd28dfa99 Remove compiler warnings from emoji related code
Change-Id: I88ed0d25bee87c4dabcbc425589215b901345908
2013-11-27 11:51:05 +09:00
Keisuke Kuroyanagi
fd15afae46 Merge "Extend jni interface to support time stamp and shortcut." 2013-11-27 02:17:51 +00:00
Keisuke Kuroyanagi
9cdca3255b Extend jni interface to support time stamp and shortcut.
Bug: 11073222

Change-Id: I19e0501850917a13ddc756d3e78fc6f6cf3f33c4
2013-11-26 21:31:26 +09:00
Tadashi G. Takaoka
091865a266 Merge "Cleanup SettingsFragment" 2013-11-26 09:38:41 +00:00
Tadashi G. Takaoka
98dd81ab80 Cleanup SettingsFragment
Change-Id: Ic7dac203c17b34e1555ba2c91e3f8c057e85a4b5
2013-11-26 18:36:21 +09:00
Jean Chalard
a6fef7dcae Merge "Fix caps mode upon gesture-after-type-period." 2013-11-26 07:34:59 +00:00
Keisuke Kuroyanagi
581ca435cf Merge "Implement addMultipleDictionaryEntries as a jni method." 2013-11-26 07:32:23 +00:00
Jean Chalard
045fb2de64 Fix caps mode upon gesture-after-type-period.
Bug: 11630231
Change-Id: Id5626a2f5b7294e4fda0bf9b82ff85537500a104
2013-11-26 16:25:09 +09:00
Keisuke Kuroyanagi
ca16be7552 Implement addMultipleDictionaryEntries as a jni method.
Bug: 11757169

Change-Id: Ie1569e0b3c0503588ebfe5d09c7ca06116f54485
2013-11-26 16:03:10 +09:00
Tadashi G. Takaoka
ad4216becd Use InputMethodSubtypeCompatUtils to create subtypes
This change adds fixed subtypeId to dummy NO_LANGUAGE and EMOJI
subtypes.

Bug: 11142698
Change-Id: Ie633b5dea77f17a9981bd999df6e1957bde740ee
2013-11-26 15:32:14 +09:00
Tadashi G. Takaoka
6f490fb200 Fix extraValue of DUMMY_NO_LANGUAGE_SUBTYPE
This is a follow up of I9cf3d94825.

Change-Id: I2646a045d21f2a7a3bb89c76d431be844e739af3
2013-11-26 13:31:18 +09:00
Jean Chalard
b68e613016 Merge "Fix a flaky test." 2013-11-25 08:53:47 +00:00
Jean Chalard
e629f860d1 Fix a flaky test.
Corrections depend on the proximity info, which depends
on the layout, which in turn depends on the subtype and
not only the language. Thus, we need to force the whole
subtype for meaningful tests.

Bug: 11142685
Change-Id: I9cf3d948259e0236061454a93ffc2e28c7e0768f
2013-11-25 17:22:15 +09:00
Jean Chalard
3e4c520dcf Merge "Fix a failing test" 2013-11-25 04:01:28 +00:00
Jean Chalard
a78b0f6b9e Fix a failing test
Bug: 11846748
Change-Id: Ieda55477201c11fb31b0f84e70ecd081211c78fc
2013-11-25 12:55:52 +09:00
Kurt Partridge
801d140176 Use Google Feedback
Change-Id: Icc39898fc9216a91e5a75958a959aa52d0ccea73
2013-11-22 18:02:18 -08:00
Tadashi G. Takaoka
2eea2d5007 Update Color Scheme summary explicitly
Bug: 11622614
Change-Id: I5464054425e4d688eaa39f96ba9a3a3c613c6f42
2013-11-22 17:26:59 -08:00
Tadashi G. Takaoka
ea8f8da1ac Fix unusual NPE after onDestroy
Bug: 11673978
Change-Id: I4d5268312911685ff1ca9483a62442a1a9686c62
2013-11-22 17:26:42 -08:00
Tadashi G. Takaoka
db86a6f271 Add keyboard color switch option
Bug: 11622614
Change-Id: I25aa1ff7376fe72fd94ab2cb7190c61d7a98a1af
2013-11-22 17:26:33 -08:00
Tadashi G. Takaoka
51352009b5 Add JB/ICS resources from Azuki MR1 release
Bug: 11622614
Change-Id: I126fc42dd31e912788db0446b67a9d4ea80f848e
2013-11-22 17:26:26 -08:00
Tadashi G. Takaoka
fe5262a70d Rename KLP theme related resources
Bug: 11622614
Change-Id: I4e390aa263349d730b47502d84e4d528e7f5ce71
2013-11-22 17:26:17 -08:00
Tadashi G. Takaoka
d5e6044ded Rename KLP/JB/ICS common resource name suffixes to _holo
Bug: 11622614
Change-Id: I53b5ff8b6627a38aef352855ad024213a450b40f
2013-11-22 17:26:08 -08:00
Tadashi G. Takaoka
585fa0491a Implement key preview zoom in/out animations
Bug: 11518021
Change-Id: I139b18708055e0811234886578c5a30b8cc71fec
2013-11-22 19:50:45 +09:00
Tadashi G. Takaoka
7c542558bf Merge "Update Color Scheme summary explicitly" 2013-11-22 10:33:30 +00:00
Tadashi G. Takaoka
b0b1982442 Update Color Scheme summary explicitly
Bug: 11622614
Change-Id: I5464054425e4d688eaa39f96ba9a3a3c613c6f42
2013-11-22 19:21:30 +09:00
Tadashi G. Takaoka
9eb8814931 Add configuration boolean for fading key top letter
Bug: 11518021
Change-Id: I1297a258650f4b2f81b942bbfbfbc2dba686ef20
2013-11-22 18:21:37 +09:00
Ken Wakasa
16d1e77a16 Merge "handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL" 2013-11-22 07:28:15 +00:00
Ken Wakasa
e255d5c0f7 Merge "handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL" into jb-ub-latinimegoogle-bayo 2013-11-22 07:26:57 +00:00
Ken Wakasa
89182e8fea handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL
bug: 11797053
Change-Id: I295eeb5f9f0f1f07e919bf54122d003be150a174
2013-11-21 17:48:09 +09:00
Ken Wakasa
87cd39124a handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL
This is a fix only for the Bayo branch because this part in master has
been changed.

The corresponding fix in master is I295eeb5f9f0f1f07e919bf54122d003be150a174

bug: 11797053
Change-Id: I779be039ebf992de5d246c7a9d9509623fc3c120
2013-11-21 17:47:05 +09:00
Keisuke Kuroyanagi
db4f373004 Fix: PtNode array size writirng when array size > 127. DO NOT MERGE.
This is a manual cherrypick of Ib729ceedbc8ef837e50490439817b36039ae2b4e.

Bug: 11772864
Change-Id: I5ecbe729dbdd24e194e48b4d68b17af8549c4726
2013-11-21 08:45:51 +00:00
Tadashi G. Takaoka
42d9980a84 Rename ambiguous feature name and related resources
Bug: 11737015
Change-Id: I39f7ca13b99f019a2edb5aa690e3142ceba4e837
2013-11-21 10:52:53 +09:00
Keisuke Kuroyanagi
d39371e231 Merge "Fix: PtNode array size writirng when array size > 127." 2013-11-20 10:07:19 +00:00
Keisuke Kuroyanagi
680f66023c Fix: PtNode array size writirng when array size > 127.
Bug: 11772864
Change-Id: Ib729ceedbc8ef837e50490439817b36039ae2b4e
2013-11-20 18:15:59 +09:00
Tadashi G. Takaoka
d088e0e726 Merge "Don't draw key top letter when key preview is showing" 2013-11-20 08:42:34 +00:00
Tadashi G. Takaoka
818ece917f Don't draw key top letter when key preview is showing
Bug: 11518021
Change-Id: Ibd33e892b21189a7d044099942845379aa010484
2013-11-20 17:26:02 +09:00
Tadashi G. Takaoka
3a1be7e4cf Merge "Unbundle Key preview text and PointerTracker" 2013-11-20 05:46:25 +00:00
Tadashi G. Takaoka
e9ec4d1add Merge "Fix more keys keyboard display position" 2013-11-20 05:46:17 +00:00
Tadashi G. Takaoka
f914f8814c Unbundle Key preview text and PointerTracker
This change binds key preview text with Key.

Bug: 11518021
Change-Id: I5028e1108d6a5728e4feac7f6f945453eea679b6
2013-11-20 14:09:29 +09:00
Keisuke Kuroyanagi
dd0da393e1 Add DEBUG_DUMP to ContactsBinaryDictionary.
Change-Id: Iebfae5f37727deeb6636ad6301b7b1bbe5f454e0
2013-11-20 14:07:44 +09:00
Tadashi G. Takaoka
0381415423 Fix more keys keyboard display position
This is a follow up of Ia39b3d6de8.

Change-Id: I9e6152fdc5cb9fa9490b41fcf0420b9ffccea438
2013-11-20 14:00:03 +09:00
Satoshi Kataoka
994530d9bd Show source dictionary name of suggestions in the debug mode
Bug: 11772864
Change-Id: I393352494b1ef81d24622a22fe7556d09945d6ff
2013-11-20 12:31:01 +09:00
Keisuke Kuroyanagi
077b3def52 Merge "Create a method to add multiple dictionary entries." 2013-11-19 09:41:14 +00:00
Keisuke Kuroyanagi
da2ccbd4cd Create a method to add multiple dictionary entries.
Bug: 11740462
Change-Id: I7903cb02fd08d649a05b8799fb3cd00c3da26e00
2013-11-19 18:12:07 +09:00
Keisuke Kuroyanagi
eacb44b38d Show amanatto settings only when in debug mode.
Bug: 11740462
Change-Id: I206b16ab785215c6fa64e740a6dd46588c633ec8
2013-11-19 14:40:20 +09:00
Kurt Partridge
0a51c2b657 Merge "Track selection end in RichInputConnection" 2013-11-16 00:55:43 +00:00
Kurt Partridge
d564466d30 Track selection end in RichInputConnection
Change-Id: Ie5cffe03b676dcde83896cda139b42f3829eb528
2013-11-15 16:49:24 -08:00
Tadashi G. Takaoka
2cbcc987ee Merge "Fix unusual NPE after onDestroy" 2013-11-15 09:03:51 +00:00
Tadashi G. Takaoka
ffb064656e Fix unusual NPE after onDestroy
Bug: 11673978
Change-Id: I4d5268312911685ff1ca9483a62442a1a9686c62
2013-11-15 17:48:10 +09:00
Tadashi G. Takaoka
be734d298a Return copied String array from getStringArray method
In the Key class constructor, elements in a String[] instance returned
from DeclaredKeyStyle.getStringArray() may be altered by
KeySpecParser.get(Int|Boolean)Value methods.

Bug: 11245712
Change-Id: I3a7fc5ccdb2a14efb72c402dd11559ab13e08596
2013-11-15 17:19:23 +09:00
Kurt Partridge
2bf3a77814 Rename mExpectedCursorStart to mExpectedSelStart
Change-Id: If23d8bd73fe464f12f473e093dc87ed68756e1ec
2013-11-14 07:45:02 -08:00
Kurt Partridge
a2632aabf7 Merge "Extract method to reloadTextCache()" 2013-11-14 15:28:07 +00:00
Tadashi G. Takaoka
f7bb78fb58 Merge "Add keyboard color switch option" 2013-11-14 09:33:09 +00:00
Tadashi G. Takaoka
4c8a96cf88 Merge "Fix additional subtype id calculation" 2013-11-14 09:04:33 +00:00
Tadashi G. Takaoka
053424e56e Merge "Add StringUtils.joinCommaSplittableText" 2013-11-14 09:04:24 +00:00
Tadashi G. Takaoka
b4c7a10840 Add keyboard color switch option
Bug: 11622614
Change-Id: I25aa1ff7376fe72fd94ab2cb7190c61d7a98a1af
2013-11-14 17:56:07 +09:00
Tadashi G. Takaoka
1d1db42d89 Fix additional subtype id calculation
Bug: 11678247
Change-Id: I4a2061fae264473e1ebff6961aa897367ef9cc09
2013-11-14 17:45:53 +09:00
Tadashi G. Takaoka
6589751ace Add StringUtils.joinCommaSplittableText
Change-Id: I80ad9d8b5aee53f1403486a56ffae8d09cbd4e28
2013-11-14 17:43:03 +09:00
Keisuke Kuroyanagi
97fdb184bc Purge ExpandableDictionary.
Bug: 11245133
Change-Id: Ia0886686d8add940409dcd5c883c34eb5289380d
2013-11-14 14:18:02 +09:00
Jean Chalard
3a9b2430a5 Fix many small nits.
...the interaction of which results in a very bad bug.

Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
2013-11-12 22:44:59 -08:00
Jean Chalard
e4022137ee Remove an out-of-place check
Bug: 11584525
Change-Id: I76cc3e4ee21d62fbd56042adcf085efd5cafb53f
2013-11-12 22:44:58 -08:00
Jean Chalard
5a0bc6ac69 Fix many small nits.
...the interaction of which results in a very bad bug.

Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
2013-11-13 14:42:27 +09:00
Tadashi G. Takaoka
d7d6088130 Revert back punctuations to the more keys keyboard of the period
Cherry-pick I157164910f from Master.

Bug: 11621857
Change-Id: I0fd0496e9091165280f34b4640ff0e524e3847b9
2013-11-12 17:51:54 +09:00
Tadashi G. Takaoka
a2a1096406 Revert back punctuations to the more keys keyboard of the period
Bug: 11621857
Change-Id: I157164910fc6f23ef36c838d0a13792c766be223
2013-11-12 14:46:40 +09:00
Tadashi G. Takaoka
1c95c8ba3b Add JB/ICS resources from Azuki MR1 release
Bug: 11622614
Change-Id: I126fc42dd31e912788db0446b67a9d4ea80f848e
2013-11-12 13:04:47 +09:00
Tadashi G. Takaoka
c10757e8e8 Rename KLP theme related resources
Bug: 11622614
Change-Id: I4e390aa263349d730b47502d84e4d528e7f5ce71
2013-11-11 20:01:00 +09:00
Tadashi G. Takaoka
4b37b2b3f6 Rename KLP/JB/ICS common resource name suffixes to _holo
Bug: 11622614
Change-Id: I53b5ff8b6627a38aef352855ad024213a450b40f
2013-11-11 19:08:07 +09:00
Jean Chalard
af8df16887 Remove an out-of-place check
Bug: 11584525
Change-Id: I76cc3e4ee21d62fbd56042adcf085efd5cafb53f
2013-11-08 20:32:43 +09:00
Tadashi G. Takaoka
541fa7858d Add keyLabelHintVerticalAdjustment attribute
Bug: 11546184
Change-Id: I1fbdbbdcf4d6a74888c48f2e4f0b7afce7913653
2013-11-07 19:29:23 +09:00
Tadashi G. Takaoka
4d49908682 Move reference char/digit width/height method to TypefaceUtils
Change-Id: I3c94c23c31b273a07e145d381587ab0aa4ee8e68
2013-11-07 18:39:42 +09:00
Tadashi G. Takaoka
0a4f4b2bbd Add autoScale Key attribute
Bug: 11546184
Change-Id: I754e98dbc0689dbf14c52d4906141a150bde97a6
2013-11-07 16:56:37 +09:00
Kurt Partridge
4e1f8be3e5 Extract method to reloadTextCache()
Change-Id: Ibdaa9553cafeded15f800077606378b06af755cb
2013-11-06 23:43:56 -08:00
Tadashi G. Takaoka
0ea72c8519 Separate action key labels to strings-action-keys.xml
Bug: 11562208
Change-Id: I70390f9eafe51f16ff47b2e39454d1948a259469
2013-11-07 15:12:55 +09:00
Tadashi G. Takaoka
aaf532e641 Fix possible RuntimeException in parsing saved addtional subtypes
Bug: 11488129
Change-Id: I91f333aee9f3ae8d4b1d5e67d47de30f361947f3
2013-11-06 17:16:24 +09:00
Tadashi G. Takaoka
463674f950 Merge "Remove unused vertical scrollable KeyboardView" 2013-11-05 10:26:14 +00:00
Tadashi G. Takaoka
78d2895c8d Remove unused vertical scrollable KeyboardView
Bug: 11517736
Change-Id: I9d71290112c2306336e136c94b628b533e386aaa
2013-11-05 19:15:20 +09:00
Keisuke Kuroyanagi
9b3e59d644 Implement ver4 bigram reading method.
Bug: 11073222
Change-Id: I7b3408938f304da361201892e0a1342fdf92e62e
2013-11-05 16:00:26 +09:00
Keisuke Kuroyanagi
67cff29fd4 Merge "Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting." 2013-10-29 04:48:05 +00:00
Keisuke Kuroyanagi
82c962f1e0 Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting.
Change-Id: I1bfeeafa002496bb98a385b87437e7f4eb0f6e1d
2013-10-28 21:46:05 -07:00
Satoshi Kataoka
40a3712a4c Merge "Show version in dumped info" 2013-10-29 02:43:09 +00:00
Satoshi Kataoka
5982b1ea08 Show version in dumped info
Bug: 10315296
Change-Id: Icb8e271451f4f9c5b083bfb5eb408372479c2140
2013-10-28 19:22:20 -07:00
Keisuke Kuroyanagi
388c953613 Fix tests by adding @UsedForTesting.
Change-Id: I5b98db67a083bde65bb0f2fb714ae2e799fb1d45
2013-10-28 17:16:01 -07:00
Satoshi Kataoka
ba212e9d76 Add a facility to dump the dictionary contents while closing
Change-Id: I02e920e0512f2b46a778f0b23f7ca03f8d5dabe6
2013-10-28 11:25:38 -07:00
Keisuke Kuroyanagi
8e9df884aa Add a test for ver4 native binary dictionary.
Bug: 10197478
Bug: 11073222
Change-Id: I6daac6c4b048c65682c25afe6ca0fad83cc9720f
2013-10-25 12:32:30 -07:00
Jean Chalard
8a1675379e Stopgap solution for a crash.
This returns the wrong string, but since it's used for getting the
previous word for bigrams, it only results in slightly worse
suggestions quality.

Bug: 11273655
Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
2013-10-22 05:23:48 -07:00
Jean Chalard
5b5ed3d609 Fix a bug where autocaps would jam auto-commit
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
2013-10-22 05:23:48 -07:00
Keisuke Kuroyanagi
6bc5acaa79 Fix: Suggested words from user history are invalid.
- Suggestions form user history can contain invalid words.
- isValidWord always returns false.

Bug: 11139426
Change-Id: I6075b275603332ddb00f4a9284afcaa82d824270
2013-10-22 05:23:48 -07:00
Jean Chalard
7da2295328 Fix a bug where autoshift would be ignored coming from emoji
Bug: 11123691
Change-Id: I36474e12e34af95051129840865015f85595411b
2013-10-22 05:23:47 -07:00
Jean Chalard
d4b5bc1695 Merge "Preliminary refactor" 2013-10-22 11:26:54 +00:00
Jean Chalard
b00ed46385 Preliminary refactor
Bug: 11328842
Change-Id: I7c22e951fef9bc4443c6b64625e25f632f876ab1
2013-10-22 20:16:17 +09:00
Jean Chalard
729abe6332 Stopgap solution for a crash.
This returns the wrong string, but since it's used for getting the
previous word for bigrams, it only results in slightly worse
suggestions quality.

Bug: 11273655
Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
2013-10-22 20:00:09 +09:00
Jean Chalard
c130be8779 Add a sequence number to SuggestedWords.
This allows testing for suggestion freshness in an asynchronous
suggestions world.

In-advance cherrypick of Ic76cd17568598d8534aec81e037f9e37f52eb6b4
because there's a merge conflict.

Bug: 11301597
Change-Id: I4aec765a975298fcac30a48dede73d2622224fe5
2013-10-22 13:19:16 +09:00
Jean Chalard
926ebe849a Merge "Add a sequence number to SuggestedWords." 2013-10-22 04:02:11 +00:00
Jean Chalard
ac76463306 Add a sequence number to SuggestedWords.
This allows testing for suggestion freshness in an asynchronous
suggestions world.

Bug: 11301597
Change-Id: Ic76cd17568598d8534aec81e037f9e37f52eb6b4
2013-10-22 12:52:58 +09:00
Jean Chalard
c6a121805f Fix a bug where autocaps would jam auto-commit
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
2013-10-22 12:39:49 +09:00
Ken Wakasa
513b99dfa2 Cosmetic fixes
Change-Id: I44ac89edaba2e57bd1b7e091ff74b77a5e598f2f
2013-10-21 15:53:49 +09:00
Yuichiro Hanada
52f18d7f40 Change the block sizes for SparseTables.
This change saves about 240k bytes.

Bug: 10941472
Change-Id: Ieb00e4dd3391cdb0d42d705f8d0a7b1421f516f9
2013-10-18 20:28:07 +09:00
Keisuke Kuroyanagi
8e9af925b1 Merge "Fix: Suggested words from user history are invalid." 2013-10-18 11:05:03 +00:00
Keisuke Kuroyanagi
53686e0f5f Fix: Suggested words from user history are invalid.
- Suggestions form user history can contain invalid words.
- isValidWord always returns false.

Bug: 11139426
Change-Id: I6075b275603332ddb00f4a9284afcaa82d824270
2013-10-18 19:53:57 +09:00
Satoshi Kataoka
7fdb2c2956 Merge "Change the numbering order of terminal IDs." 2013-10-18 10:31:27 +00:00
Yuichiro Hanada
9ae7d37108 Change the numbering order of terminal IDs.
Change-Id: I85a6b6e948ee0de012eef2f9f841240cbca63947
2013-10-18 19:16:11 +09:00
Yuichiro Hanada
2b7110ff1f (2/2) Implement insertWord in Ver4DictUpdater.
Change-Id: I2328a9df0a009b564e8acaf4180f9b0c1ed0901a
2013-10-18 18:03:44 +09:00
Yuichiro Hanada
19b247e79d Fix the name of the argument of writeString.
Change-Id: I76916914f1402913daa56dd5387fe82e42287989
2013-10-18 17:33:10 +09:00
Yuichiro Hanada
520f612849 (1/2) Implement insertWord in Ver4DictUpdater.
Change-Id: Ia3079d5ef00ca7d831c91fb9220ad9c17038c5a3
2013-10-18 16:42:59 +09:00
Jean Chalard
0f45e1bfbc Fix a bug where autoshift would be ignored coming from emoji
Bug: 11123691
Change-Id: I36474e12e34af95051129840865015f85595411b
2013-10-17 22:58:34 +09:00
Jean Chalard
578e9b91c1 Merge "Remove useless code." 2013-10-17 06:56:12 +00:00
Jean Chalard
8447409c77 Merge "Remove mIsExpectingUpdateSelection." 2013-10-17 06:55:54 +00:00
Yuichiro Hanada
ad5b9bcec2 Add readVer4PtNodeInfo to Ver4DictDecoder.
Change-Id: Ibffaf64a9bda1fb0779a9b53558ca56ed31660d3
2013-10-17 14:37:04 +09:00
Yuichiro Hanada
36dd126ab4 Add ShortcutContentReader.
Change-Id: I7c2d0d86d85775065a9bcb2b4a8463bb4969579e
2013-10-17 11:11:29 +09:00
Jean Chalard
548716d6d9 Remove useless code.
The only use of mDeleteCount is to implement delete
acceleration. It's reset at each non-delete code point, and
is guarded by a timer.
Plus, ultimately we want to remove this completely :
acceleration should be implemented by actually deleting
stuff faster, not by deleting several code points at a time.

Change-Id: Ia3144860b3aa2499034f2a2a7c81f32087af9598
2013-10-16 18:43:15 +09:00
Jean Chalard
5731b86b88 Merge "Remove unneeded code." 2013-10-16 09:41:44 +00:00
Jean Chalard
1194b2b204 Remove mIsExpectingUpdateSelection.
Bug: 11226045
Change-Id: I043f90ba92989bd8307c978eb32630439f63a0b9
2013-10-16 18:39:20 +09:00
Jean Chalard
497976e09b Remove unneeded code.
We don't support LOG_FULL_TEXTVIEW_CONTENTS any more, nor do
we have any plans to support it again in the future.

This also is a prelude to removing mIsExpectingUpdateSelection.

Bug: 11226045
Change-Id: Ib68c6daf52993b87225a7ea9e71a414caaecfdb7
2013-10-16 18:36:16 +09:00
Yuichiro Hanada
098639d99f Add SparseContentTableReader.
Change-Id: I976afc5d320bc65835d659bae1d10d2cdc68262b
2013-10-16 17:24:59 +09:00
Yuichiro Hanada
7b5f2b71f5 Fix Ver4DictDecoder.readAndFollowForwardLink().
Change-Id: Ib527a376b693be21aebd4920ac804ee9b161eb96
2013-10-16 17:16:26 +09:00
Ken Wakasa
008d84ffa5 Merge "Fix readAndFollowForwardLink." 2013-10-16 07:48:30 +00:00
Ken Wakasa
6b7037fa68 Merge "Extract SparseTableContentWriter." 2013-10-16 07:34:03 +00:00
Yuichiro Hanada
ed831f38db Extract SparseTableContentWriter.
Change-Id: I9a58e53317654f8a09fbe79044214de3e9c59eb7
2013-10-16 09:53:30 +09:00
Yuichiro Hanada
1557de7aa4 Consolidate CharEncoding.writeString and BinaryDictIOUtils.writeString.
Change-Id: I6f990fd84e7f08fd1149198c33d8bbf1cac8e078
2013-10-16 00:30:45 +09:00
Yuichiro Hanada
522dc0d8ac Fix readAndFollowForwardLink.
Change-Id: Ifda44e6139a4a1bd065468a7f74cd9483b343644
2013-10-16 00:16:39 +09:00
Ken Wakasa
b067be0e5f Merge "Revert "Revert "Add Swiss French and German keyboard layouts.""" 2013-10-15 14:12:29 +00:00
Ken Wakasa
b044047227 mExpectingUpdateSelection was out of sync when nothing to delete.
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)

This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
2013-10-15 14:05:34 +09:00
Ken Wakasa
cf5dfd2464 am 3a3bbf4a: am eed74b81: am c8383eda: Fix wrong commitText parameter in sendKeyCodePoint()
* commit '3a3bbf4a38870ecc42b7f6fbd3a7cae20fe020a7':
  Fix wrong commitText parameter in sendKeyCodePoint()
2013-10-14 10:52:40 -07:00
Ken Wakasa
c8383eda8b Fix wrong commitText parameter in sendKeyCodePoint()
Small optimization on generating a String instance from a single code
point too.

bug: 11181913

Change-Id: I0f905e4dc6ec7841092bb4d3d940daf3b2303f5b
2013-10-13 10:56:10 +09:00
Ken Wakasa
fe97ff4083 am 60fb5865: am 06e1bdaa: am 3e35e072: Merge "Make emoji separators" into klp-dev
* commit '60fb58654e33448651fea191ba22cfdc87e37466':
  Make emoji separators
2013-10-11 05:10:21 -07:00
Satoshi Kataoka
eb7fa4dc6d am 40506273: am ac6d0c65: am 6d915037: Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev
* commit '405062733cfe066c4b9af719bfc36a9a516c9dd3':
  Fix a bug where emojis would remove the suggestion strip.
2013-10-11 05:10:19 -07:00
Ken Wakasa
3e35e0727c Merge "Make emoji separators" into klp-dev 2013-10-11 11:57:07 +00:00
Satoshi Kataoka
6d91503727 Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev 2013-10-11 11:53:07 +00:00
Jean Chalard
6fc15b9fc4 Fix a bug where emojis would remove the suggestion strip.
Bug: 11163495
Change-Id: I23d12c430125cc2a66a6e00715a4c609bb9e2bb1
2013-10-11 20:51:13 +09:00
Jean Chalard
401fb908f0 Make emoji separators
Bug: 11163495
Change-Id: I3247b8d1bbd3406b29a30a25aebd932c63431943
2013-10-11 20:00:38 +09:00
Ken Wakasa
7abdab1c6f Merge "Add a time stamp for unigrams." 2013-10-11 10:17:01 +00:00
Jean Chalard
3def959e4d am 3f1c95db: am 331c84d7: am 5fe9ab1c: Merge "Fix the suggestion size." into klp-dev
* commit '3f1c95dbdc18453dc0cd6f847b33e01db1f1d75b':
  Fix the suggestion size.
2013-10-11 01:49:51 -07:00
Jean Chalard
5fe9ab1cc6 Merge "Fix the suggestion size." into klp-dev 2013-10-11 08:38:31 +00:00
Ken Wakasa
be22a01df3 Merge "Add resolveBigramPositions." 2013-10-11 07:45:20 +00:00
Jean Chalard
c0bd0a244d Fix the suggestion size.
The available space was not computed correctly. This makes the
decision to ellipsize/expand the middle suggestion correct.

Also, the scale was not applied correctly in some cases.

Finally, for some reason ellipsize does not work as we expect.
I'm not sure how to get it to work like we want it to, but
this works around the problem in a simple manner.

Bug: 11158757
Change-Id: I083e7ac56e157f100923733e67b92a6368a526c9
2013-10-11 16:42:46 +09:00
Satoshi Kataoka
7611af753a Merge "Do not merge. Save / restore the last used emoji category" into klp-dev 2013-10-11 07:21:35 +00:00
Satoshi Kataoka
7d3f53a1cb Do not merge. Save / restore the last used emoji category
Bug: 11029983
Change-Id: I5547910c7b5dd7974292fc075af33568940f4e81
2013-10-11 16:05:38 +09:00
Satoshi Kataoka
6026a95816 Merge "Save / restore the last used emoji category" 2013-10-11 07:04:42 +00:00
Satoshi Kataoka
6dc99dc200 Save / restore the last used emoji category
Bug: 11029983
Change-Id: I1bec2c3c6b547de68562a818a8d6c9fef83787b7
2013-10-11 16:00:33 +09:00
Yuichiro Hanada
c32962b8f1 Add a time stamp for unigrams.
Bug: 10920255
Change-Id: I26d2cce3c322a4ff39a614f8615f43fb7bd3baed
2013-10-11 15:08:09 +09:00
Yuichiro Hanada
9514ed5c2a Add the new format of bigram entries.
In new format, each bigram entry has flags (1 byte), a terminal id (3 byte),
a time-stamp (4 byte), a counter (1 byte) and a level (1 byte).

Bug: 10920255
Bug: 10920165
Change-Id: I0f7fc125a6178e6d25a07e8462afc41a7f57e3e1
2013-10-11 14:50:41 +09:00
Jean Chalard
7e6ac9d727 Allow double-space-to-period after percent
Bug: 11158604
Change-Id: If8c94ef91ed58bb5028f51be7c8d9beb677436a4
2013-10-10 21:26:08 +09:00
Ken Wakasa
6dac27eeb4 Merge "Tweak vertical gap of Emoji palette. DO NOT MERGE" into klp-dev 2013-10-10 03:39:30 +00:00
Satoshi Kataoka
3a9ae65525 Tweak vertical gap of Emoji palette. DO NOT MERGE
cherrypick of I8163568a9d7f9d321148001e161c672f78796c96

Bug: 11140087
Change-Id: Ifd28f3017a8cf568a8c4a1045811564a129d85b7
2013-10-10 11:29:08 +09:00
Satoshi Kataoka
557a0935d4 Retry to tweak punctuations. DO NOT MERGE
cherrypick of I9ffc457ca44bccfa3eb3bdb0c26535d795215b26

Bug: 11130808
Change-Id: I1a65fd8acc4efe9b4e4786a3dc959498ae63c2f8
2013-10-10 11:14:37 +09:00
Ken Wakasa
856b06a3ac Revert "Revert "Add Swiss French and German keyboard layouts.""
This reverts commit 56402cf10a.

I'll submit this on 10/16 after the final cut for Bayo.

Change-Id: I0fe4ab64fd8dfa1e63e29adf00388743fca6a1ed
bug: 11144401
2013-10-10 02:07:04 +00:00
Ken Wakasa
56402cf10a Revert "Add Swiss French and German keyboard layouts."
This reverts commit 220ce8f269.

Sorry, but we are now in the week before the final cut for the next launch. We shouldn't be taking new features like this at this point. Let me revert this change for now. I'll re-revert this after the cut next week.

Change-Id: Ia8b00680c992ec526e6a858945f2380cbcdfdd55
2013-10-10 02:05:50 +00:00
Fredrik Roubert
220ce8f269 Add Swiss French and German keyboard layouts.
There used to be two "Swiss" keyboard layouts, labelled fr_CH and de_QY,
available in LatinIME. They were, however, not actually Swiss layouts
but instead work-arounds to be able to get French or German with qwertz
or qwerty (instead of azerty and qwertz) layouts, respectively. These
were thus removed by commit f6972561fc
replacing them with the generic fr-qwertz and de-qwerty layouts instead.

Here, now, is a proper Swiss keyboard layout, following Swiss standards
for people accustomed to typing on Swiss keyboards, with the expected
tailorings for French and German.

Change-Id: I9feed752053ecc694c84db713284f69bc1daf155
2013-10-09 17:42:17 +02:00
Satoshi Kataoka
a6a6abc816 Fix the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
2013-10-09 02:59:32 -07:00
Satoshi Kataoka
6862b8192d Fix crash in AdditionalSubtypeUtils
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
2013-10-09 02:59:26 -07:00
Yuichiro Hanada
67c758f160 Add resolveBigramPositions.
Bug: 11073222
Change-Id: I680e4304c6ab701e9aa132e1e140d789097a53ae
2013-10-09 17:39:22 +09:00
Satoshi Kataoka
56997a80c2 Retry to tweak punctuations
Bug: 11130808
Change-Id: I9ffc457ca44bccfa3eb3bdb0c26535d795215b26
2013-10-09 15:39:23 +09:00
Satoshi Kataoka
30ef03d865 Tweak vertical gap of Emoji palette
Bug: 11140087
Change-Id: I8163568a9d7f9d321148001e161c672f78796c96
2013-10-09 14:56:39 +09:00
Satoshi Kataoka
83994ad66b Merge "Fix the security related API change for PreferenceActivity" 2013-10-09 05:46:15 +00:00
Satoshi Kataoka
64f64bdf58 Fix the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
2013-10-09 14:34:06 +09:00
Jean Chalard
dfaec34502 Merge "Always call finishComposingText before recapitalization" 2013-10-09 05:18:01 +00:00
Jean Chalard
e306d292eb Merge "Remove a useless IPC call." 2013-10-09 05:17:51 +00:00
Satoshi Kataoka
50f9ca4acd Fix crash in AdditionalSubtypeUtils
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
2013-10-09 12:50:50 +09:00
Jean Chalard
f178685c11 Always call finishComposingText before recapitalization
Workaround for framework bug:
Bug: 10792236

Change-Id: I3706b9eed5223889791840e30660f8d17625cb70
2013-10-09 12:15:21 +09:00
Jean Chalard
27d78643e8 Remove a useless IPC call.
This is not useful because we're going to call setSelection again
with different values on the connection right away.

Also a preliminary change for
Bug: 10792236

Change-Id: I46c6ef1fbb3624086099bf81afddb0ef5ae85661
2013-10-09 12:11:28 +09:00
Satoshi Kataoka
de65b7c0b3 Merge "Fix the position of emoji palette" 2013-10-08 12:04:03 +00:00
Satoshi Kataoka
f981fe7ed2 Fix the position of emoji palette
Change-Id: I07a3912cb9fef8e28f3605de4e73a201a900e95c
2013-10-08 21:00:43 +09:00
Ken Wakasa
c040d59def Merge "Add more_keys_for_* declarations for the Swedish keyboard." 2013-10-08 11:44:54 +00:00
Fredrik Roubert
a30884e0e0 Add more_keys_for_* declarations for the Swedish keyboard.
This adds all those popup keys that were included in commit
b1cb13292f when the Swedish keyboard was
first added. Many of these definitions were later removed by commit
79b965e04f but most likely by mistake, as
that commit log message doesn't mention anything about removing these.

To help making this file more maintainable, this commit also moves a few
definitions around so that all definitions now appear in alphabetical
order.

Change-Id: Iadef9e3dd1dc7b39fe87b2fc75210d0697b24361
2013-10-08 13:28:08 +02:00
Satoshi Kataoka
a701501cb6 Merge "Reduce memory of emoji palette" 2013-10-08 11:22:21 +00:00
Satoshi Kataoka
0e01df9baf Reduce memory of emoji palette
Bug: 10902556
Change-Id: I3c8da35a601de2bfb248292c7b59235fc1120988
2013-10-08 20:11:35 +09:00
Jean Chalard
92190d9a75 Merge "Show the keyboard earlier when rotating." 2013-10-08 10:14:41 +00:00
Satoshi Kataoka
2d3e121014 Fix memory leak in EmojiPaletteView
Bug: 10902556
Change-Id: I3a8c1e08d6f953b462d914acd1f411c36f9d80f2
2013-10-08 19:05:00 +09:00
Ken Wakasa
d900b90db7 Merge "Prep for RAM footprint optimization for Emoji palettes" 2013-10-08 08:11:53 +00:00
Ken Wakasa
8cf2a5e59f Prep for RAM footprint optimization for Emoji palettes
bug: 10902556
Change-Id: I313948c73b60cd33c437cf02e8d3fb61c288a240
2013-10-08 17:09:24 +09:00
Jean Chalard
482aa129e4 Show the keyboard earlier when rotating.
Bug: 11107229
Change-Id: I0b36341d60b634a860eb13fafd0dc69fe734bdeb
2013-10-08 16:33:27 +09:00
Jean Chalard
10581e68af Make the sentence separator a resource.
This will help handing correctly the armenian full stop.

Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
2013-10-08 15:28:43 +09:00
Satoshi Kataoka
984aa60e11 Merge "Extend hitbox of emoji keys" 2013-10-07 23:27:07 +00:00
Satoshi Kataoka
5d27cb9397 Extend hitbox of emoji keys
Bug: 11105065
Change-Id: I5e90ba55cf708bf7be27d7d101cbc0719ac583c8
2013-10-07 23:22:12 +09:00
Jean Chalard
7712baa59b Merge "Fix a possible IOOB" 2013-10-07 14:21:00 +00:00
Jean Chalard
ca9c3c0613 Fix a possible IOOB
We want to use StringUtils here, but it's full of references to
stuff not accessible host-side like JsonReader and TextUtils
and SettingsValues :/

Bug: 11061476
Change-Id: I3c0194979833ede283b4f9190335dba5376fe6fc
2013-10-07 23:16:57 +09:00
Jean Chalard
3c4e8cb693 Call loadKeyboard later if it can't be called right away
Since loadKeyboard relies on the input connection being
available to give it the auto-caps state, but also can't
be called twice in a row because it needs to save and
restore its state and invalidates it after the restore,
we need to wait until we know we have a valid input
connection to call it.

Bug: 11107229
Change-Id: I1c7baf3215682df6f6ceb357bd37254f9e7418c7
2013-10-07 22:57:59 +09:00
Satoshi Kataoka
291ef1c9c3 Merge "Clear the cache of subtypes in onStartInputViewInternal" 2013-10-07 11:19:47 +00:00
Satoshi Kataoka
4be5f221e6 Clear the cache of subtypes in onStartInputViewInternal
Bug: 11077905
Change-Id: I9495f13a20edca0e6153cd1a7a0ac6891f707c59
2013-10-07 20:10:58 +09:00
Jean Chalard
86f7711407 Merge "Don't auto-correct to non-whitelist shortcuts" 2013-10-07 10:04:18 +00:00
Jean Chalard
f309f2288b Don't auto-correct to non-whitelist shortcuts
Bug: 11076722
Change-Id: I0de10ab24d33ec31f45664fe92d80d5a7bec9c20
2013-10-07 19:01:57 +09:00
Jean Chalard
a6047aae94 Merge "Set the shortcut frequency correctly." 2013-10-07 10:00:34 +00:00
Jean Chalard
f3204eebb1 Set the shortcut frequency correctly.
14 is the right value.

Bug: 11076722
Change-Id: I95d404b540f7fbe4932d1f8498cde23f1df0314f
2013-10-07 18:55:42 +09:00
Keisuke Kuroyanagi
be4d85feb0 Merge "Fix bug and Add large test for decaying dictionary." 2013-10-07 09:32:56 +00:00
Jean Chalard
7da62bbe24 Merge "Remove suggestions when string contains a period" 2013-10-07 08:34:52 +00:00
Keisuke Kuroyanagi
cfb018ba6d Fix bug and Add large test for decaying dictionary.
- GC gets failure when the dictionary become empty.
- Useless unigrams are sometimes not removed.

Bug: 10197478
Change-Id: I8d1479c01efba61a81f03bc077da6bcb4797a940
2013-10-07 17:31:01 +09:00
Jean Chalard
df33982fce Remove suggestions when string contains a period
This is not the right way to do it, but it's simple and will kill the
regression. We should investigate why the return values are
wrong in this case.

Bug: 10780091
Change-Id: I808727242c9cb1598df00a7426358dc3a658add4
2013-10-07 17:27:27 +09:00
Satoshi Kataoka
4746217247 Enter -> Alpha keyboard switcher in Emoji palette view
Bug: 11103091
Change-Id: I0c5384e9f148566d1ac1d178a8227eb913d59908
2013-10-07 17:05:54 +09:00
Satoshi Kataoka
4deb824f3a Add navigateEmoji
Bug: 11074625
Change-Id: I1ef6b81ef923684b502c24fddb4ced8fe1691733
2013-10-07 15:28:39 +09:00
Satoshi Kataoka
e6e4c70a23 Fix build
Change-Id: I61341aa7b1ceb311aaa5faa5888ba31e463a95d5
2013-10-07 12:48:14 +09:00
Satoshi Kataoka
d76b552979 Rename EmojiKeyboardView -> EmojiPalettesView
Change-Id: I226bb8e21fd2b2b6639896a1cc433d19f3f431c2
2013-10-07 12:28:13 +09:00
Jean Chalard
423921ca13 Merge "Fallback on empty locales." 2013-10-04 13:44:44 +00:00
Jean Chalard
5db7eabafb Merge "Accept double-space-period after emoji." 2013-10-04 13:05:43 +00:00
Jean Chalard
43a8a0c527 Fallback on empty locales.
This is a very rare corner case.

Bug: 11072132
Change-Id: Iad2aa69511f7dc99105284a049c63f2f997b8ef0
2013-10-04 22:04:59 +09:00
Jean Chalard
8142fd83a6 Accept double-space-period after emoji.
This also includes a fix that allows this code to read surrogate
pairs in this processing.

Bug: 11070482
Change-Id: If5ef8d6863938252f09128b7e99ea07ece6e7019
2013-10-04 22:01:36 +09:00
Satoshi Kataoka
1d188a28fb Merge "Fix emoji" 2013-10-04 12:00:39 +00:00
Satoshi Kataoka
0cf92aa826 Fix emoji
Bug: 10538430

Change-Id: Ib11e29794216b54001806ab12fe440d157243dc1
2013-10-04 20:58:09 +09:00
Satoshi Kataoka
0b288985b7 Merge "Fix emoji recent key behavior" 2013-10-04 11:18:07 +00:00
Satoshi Kataoka
e7ed5cae44 Fix emoji recent key behavior
Bug: 10538430
Change-Id: I91e03a8e7914628cdc8e57c124c95e5e6e8ea2a6
2013-10-04 20:01:00 +09:00
Ken Wakasa
c01707db03 Merge "Suppress exceptions that have always been happening." 2013-10-04 10:13:53 +00:00
Ken Wakasa
fba1bd0ec4 Suppress exceptions that have always been happening.
Change-Id: I5f85a7a0f94ea9ecbe0c4a8caebcf551fa9c9669
2013-10-04 19:10:26 +09:00
Yuichiro Hanada
e4e0add9fb Add Ver4DictUpdater.
Change-Id: I986ab26faf535fc4bc98443053f534eced9d048f
2013-10-04 17:33:29 +09:00
Yuichiro Hanada
75d60e821c Refactor BinaryDictIOUtilsTests.
Change-Id: I2208378b33038771b460abb33f9a690872e998e2
2013-10-04 14:19:13 +09:00
Yuichiro Hanada
14d31d4640 Add AbstractDictDecoder.
Change-Id: Ie69d84e090f69dc3ea1f5de73ad8c954ecd2c6a7
2013-10-04 14:16:59 +09:00
Yuichiro Hanada
73b9d3b879 Separate shortcut targets from the trie file.
Bug: 10920165
Change-Id: I340759eadbde7fb64cb3b9a3c619ee3a768cedf8
2013-10-04 11:16:10 +09:00
Keisuke Kuroyanagi
864ee881bd Merge "Fix UserHistoryDictionaryTests." 2013-10-03 12:02:34 +00:00
Keisuke Kuroyanagi
11f7cae094 Fix UserHistoryDictionaryTests.
Bug: 6669677
Bug: 10667710

Change-Id: I6cdc6a6c9cacc7f276fda3a26ec31e3eb928471c
2013-10-03 20:55:34 +09:00
Yuichiro Hanada
3dd77a6d66 Add SparseTableContentWriter to Ver4DictEncoder.
Bug: 10920165
Change-Id: I6372492e97297baad4c5aeeb3fb36dcccd7a944b
2013-10-03 20:31:01 +09:00
Yuichiro Hanada
d6e307a4b7 Add DictUpdater.
Change-Id: Ic586e46e5a9f59de53d53e59886d635345940974
2013-10-03 20:16:34 +09:00
Satoshi Kataoka
85607c5965 Merge "Fix the subtype id of the additional subtypes" 2013-10-03 07:45:24 +00:00
Satoshi Kataoka
9ecdb831db Fix the subtype id of the additional subtypes
Bug: 11032428
Change-Id: I5d422f1c15a582015770ef9a652348ca6eb8ab85
2013-10-03 16:41:13 +09:00
Satoshi Kataoka
c7f8d54d6e Merge "Prepare for changing text color for functional keys" 2013-10-03 07:15:03 +00:00
Satoshi Kataoka
194e004e81 Prepare for changing text color for functional keys
Bug: 10786040

Change-Id: I0de7d4923ea13b44adcf1f4ea456796cd02ef27b
2013-10-03 15:54:46 +09:00
Keisuke Kuroyanagi
d25cd26f1a Merge "Try decaying user history at hourly intervals." 2013-10-02 09:44:03 +00:00
Yuichiro Hanada
3aa8977cb2 Remove some unused variables.
Change-Id: Iaf1556fec194d17cb4318f2bdcc837f8d79449ef
2013-10-02 18:26:03 +09:00
Keisuke Kuroyanagi
f36a97ab3a Try decaying user history at hourly intervals.
Bug: 6669677

Change-Id: Ib465fa7e1a7f289a07843535ba89d0dd5259e803
2013-10-02 18:06:08 +09:00
Ken Wakasa
2dcb63375d Merge "Make SparseTable have multiple content tables." 2013-10-02 08:32:55 +00:00
Jean Chalard
cd7422f4df Merge "Fix a pernicious bug with caps." 2013-10-02 07:59:08 +00:00
Jean Chalard
f735117d36 Fix a pernicious bug with caps.
What's happening here is, setAlphabetKeyboard sets the
keyboard to AUTOMATIC_SHIFTED and updates the keyboard, then
restoring the keyboard old state sets it back to UNSHIFTED without
updating it. When we finally know what the correct value is,
we try to set it to UNSHIFTED, but since that's already the currently
recorded state, it skips updating the keyboard forever.

The solution is to avoid setting the shift state without updating the
keyboard.

Bug: 10948582
Change-Id: Ic8670401e378f8284e851281f91a9ad93eac8e90
2013-10-02 16:57:36 +09:00
Satoshi Kataoka
c5182c9a4a Correspond to the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: Ia7d1c6c526dae849f447c26387e96a4fb4d6042f
2013-10-02 16:25:07 +09:00
Yuichiro Hanada
4284e9aae7 Make SparseTable have multiple content tables.
Bug: 10920165
Change-Id: Ie9008452ee292fb0b1fec66e2ffed228c4af6c3e
2013-10-02 15:36:13 +09:00
Jean Chalard
a8b838b473 Merge "Fix a test and crash with a better error message when reading" 2013-10-02 06:28:06 +00:00
Jean Chalard
fa946d4a0f Fix a test and crash with a better error message when reading
When there are too many bigrams, we stop reading the file,
so the file pointer is in an inconsistent place. This means we
have no idea what's going to happen next. It's better to crash
right away.

Change-Id: Id3b7b78cbe4fda3493b3c9c46758763e1ab5f6a3
2013-10-02 11:48:47 +09:00
Satoshi Kataoka
5ceae026e0 Retain Emoji Keyboard after rotation
Bug: 10612450
Change-Id: Ie0ae953958d2b0a0a4da651584f1e28b0ba38ae3
2013-10-01 22:59:02 +09:00
Satoshi Kataoka
9d76391058 Merge "Unfortunately, hide some broken "emoji"s" 2013-10-01 12:18:13 +00:00
Jean Chalard
74577bedb3 Merge "Implement the heuristic for auto-commit." 2013-10-01 12:10:57 +00:00
Satoshi Kataoka
c7e6f3dbc3 Unfortunately, hide some broken "emoji"s
Bug: 10923117
Change-Id: I27ba38e5f388cc15ae331fd05d63db4e4a41cbbf
2013-10-01 21:02:59 +09:00
Jean Chalard
459cd6f8ef Implement the heuristic for auto-commit.
Bug: 9059617
Change-Id: I066abf018df5aaeabf415425dd822ebe233e6008
2013-10-01 21:00:40 +09:00
Jean Chalard
2afa0e621e Merge "Fix a bug where gesture would delay update." 2013-10-01 11:21:59 +00:00
Jean Chalard
b1e6eeea57 Fix a bug where gesture would delay update.
Change-Id: I94c394f45f2717bc1a4b95692a5757c1e7179152
2013-10-01 20:06:36 +09:00
Ken Wakasa
382094a784 Merge "Cleanup and remove redundant more keys on phones" 2013-10-01 10:29:15 +00:00
Ken Wakasa
e56c2f979f Cleanup and remove redundant more keys on phones
Change-Id: I419c3c119eb1e4d2e877c8c00564e46f40b6abc2
2013-10-01 19:02:09 +09:00
Ken Wakasa
cc81a93b01 Merge "Add skipPtNode to DictDecoders." 2013-10-01 09:06:39 +00:00
Yuichiro Hanada
bc4926235d Add skipPtNode to DictDecoders.
Change-Id: I042ff041b68572182c87dc87db6a6aa2bbbefc6c
2013-10-01 17:21:21 +09:00
Satoshi Kataoka
a4913994c2 Hide indication bar if only one page
Bug: 10923117
Change-Id: If81bf07ba2e7c4fff44a8832f98b4a393c15edc7
2013-10-01 16:58:42 +09:00
Keisuke Kuroyanagi
126d758c1e Merge "Quit blocking getSuggestion during GC." 2013-10-01 07:08:11 +00:00
Jean Chalard
bb57090f1d Create the wiring for auto-commit confidence computation.
Bug: 9059617
Change-Id: I7e4e05ffa8c68cfebbe362a977fd176555cad12a
2013-10-01 15:04:15 +09:00
Keisuke Kuroyanagi
03cb8f751a Quit blocking getSuggestion during GC.
Bug: 10831272

Change-Id: I995c619dc18a9120a47f547d31045cb73a9353ec
2013-10-01 12:04:06 +09:00
Alan Viverette
458fb52b98 Merge "Speak auto-corrections for accessibility" 2013-09-30 18:14:13 +00:00
Keisuke Kuroyanagi
65330d2820 Merge "Implement simple dictionary decay." 2013-09-30 11:56:15 +00:00
Keisuke Kuroyanagi
fd02b2d6ee Implement simple dictionary decay.
Groundwork and implement simple decay.
Increment probability when typed and decrement probability
at GC.

Bug: 6669677

Change-Id: Ib12caead0cbeef4ce7808fe8ac0b00ee331523fe
2013-09-30 20:53:35 +09:00
Keisuke Kuroyanagi
ef084229f6 Merge "Use reentrant lock for main dictionaries." 2013-09-30 09:25:54 +00:00
Keisuke Kuroyanagi
3e6275634b Use reentrant lock for main dictionaries.
Bug: 10964805
Change-Id: Iaa9b79fc770d8ae2ec9d7c362c90c28bc9f65ea8
2013-09-30 18:16:29 +09:00
Ken Wakasa
25f4782853 Merge "Separate bigram entries from the trie file." 2013-09-30 08:00:01 +00:00
Yuichiro Hanada
fd46e87da2 Separate bigram entries from the trie file.
Bug: 10920165
Change-Id: I42eb7f228994a56c2f31a1c83904c8c360b6d088
2013-09-30 16:42:42 +09:00
Ken Wakasa
d40a931a4d Merge "Change scopes of some methods in DynamicBinaryDictIOUtils." 2013-09-30 07:17:38 +00:00
Keisuke Kuroyanagi
c18510049a Prepare dictionary decay.
Bug: 6669677
Change-Id: I8fbae190dd44a6bdbee7e9b6d3a16208322727f7
2013-09-30 13:57:54 +09:00
Yuichiro Hanada
dc4f357f6b Change scopes of some methods in DynamicBinaryDictIOUtils.
Change-Id: I1371d41760b38834d1d5ff40e682ac0a6fc9f2e9
2013-09-30 11:32:07 +09:00
Keisuke Kuroyanagi
1cf4789ba6 Merge "Set header attributes for ExpandableBinaryDictionary." 2013-09-29 05:14:22 +00:00
Satoshi Kataoka
b0c5ddb9c7 Merge "Stop vibration while repeating delete key in emoji view" 2013-09-28 10:37:57 +00:00
Satoshi Kataoka
d0df68e6cb Stop vibration while repeating delete key in emoji view
Bug: 10960355
Change-Id: Ic1fdecdbcab4082c5383623c1f2575e3976ebe27
2013-09-28 17:02:58 +09:00
Keisuke Kuroyanagi
5ed30a7660 Set header attributes for ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2462777eaa07600f1c774226adfc4f351882f523
2013-09-28 12:50:09 +09:00
Alan Viverette
67319f92f3 Speak auto-corrections for accessibility
BUG: 8669376
Change-Id: Id71b2c2835daa7a8c9d6c92c57a7e302551c289d
2013-09-27 14:15:53 -07:00
Satoshi Kataoka
4dc2b9131f Merge "Fix possible NPE in KeyboardSwitcher" 2013-09-27 16:52:32 +00:00
Satoshi Kataoka
adbb979b56 Fix possible NPE in KeyboardSwitcher
Bug: 10964306
Change-Id: Ibcea76da746f6cac92c8d91425d25d04ade62af0
2013-09-28 01:19:18 +09:00
Keisuke Kuroyanagi
8b580819a5 Merge "Add unigram/bigram counting." 2013-09-27 14:14:49 +00:00
Keisuke Kuroyanagi
31097a57cc Add unigram/bigram counting.
Bug: 6669677
Change-Id: I05ea2201d822dddf062b08c8467daa336760e16c
2013-09-27 23:12:12 +09:00
Keisuke Kuroyanagi
e74d4a184b Stop reading dictionary while regenerating.
Bug: 10831272

Change-Id: Iead7268a9371b48d729a5f65074ccbc05f3185db
2013-09-27 21:44:26 +09:00
Jean Chalard
b7dfacd31e Merge "Send backspace as an event when TYPE_NULL." 2013-09-27 08:00:43 +00:00
Jean Chalard
de814ec0ec Send backspace as an event when TYPE_NULL.
This is not enough to really fix behavior with TYPE_NULL,
but it does make things a bit better.

Bug: 10949594
Change-Id: Ia359f781cdd76a2e2c5a4c9f166025d81b931174
2013-09-27 16:55:12 +09:00
Yuichiro Hanada
a328f538c3 Fix PrioritizedSerialExecutor.
It was possible that fetchNextTasks() would be called by multiple
threads concurrently.
If it happens, some tasks in the task queues might be ignored.

Change-Id: Idc81c43c45e382da3850cc55b9a42c281548d2a8
2013-09-27 16:46:34 +09:00
Yuichiro Hanada
781feb748c Remove unused methods.
Change-Id: I542db0c717c0bc05c8baa08f1e9db0a05946a99b
2013-09-27 12:34:38 +09:00
Keisuke Kuroyanagi
e3e10317b0 Merge "Create empty dictionary file in native code." 2013-09-26 08:03:38 +00:00
Yuichiro Hanada
d188af7022 Add SparseTable.
Bug: 10920165
Change-Id: I749dd0269e788799e30b10beb2671813d40ce15f
2013-09-26 16:16:30 +09:00
Keisuke Kuroyanagi
5ef6209656 Create empty dictionary file in native code.
Bug: 6669677
Change-Id: I46d23deee1fd091678f4593561cb8687eb815212
2013-09-26 12:59:02 +09:00
Ken Wakasa
4350a93aa5 Merge "Fix the offdevice regression test build" 2013-09-25 10:30:18 +00:00
Ken Wakasa
f56b82f809 Fix the offdevice regression test build
Followup to If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57

bug: 10622489
Change-Id: If98b2c75725f8692f0c2b41c33e448086404479b
2013-09-25 19:13:47 +09:00
Keisuke Kuroyanagi
5fa9654045 Merge "Clear traverse sessions when closing." 2013-09-25 10:06:33 +00:00
Satoshi Kataoka
6e41d9a479 Merge "Input delete onUpKey" 2013-09-25 10:02:24 +00:00
Satoshi Kataoka
a456e3f659 Input delete onUpKey
to avoid deletion when the user starts gesture from the delete key

Bug: 7303982
Change-Id: If4b3e6287ceee1cf9f72a1d92f2a6789065da454
2013-09-25 18:55:57 +09:00
Keisuke Kuroyanagi
6142068a33 Clear traverse sessions when closing.
Bug: 6669677
Change-Id: I859be934f0c60485e04cdc4cab288a18242fa04e
2013-09-25 18:32:40 +09:00
Ken Wakasa
399422f4b9 Merge "Make Ver4DictEncoder write an address table of terminal nodes." 2013-09-25 08:45:39 +00:00
Satoshi Kataoka
1e69f3e637 Fix emoji page
Bug: 10538430
Change-Id: If4d5ebb26e7ead259e8f370462ccf4c9dbf734f8
2013-09-25 17:20:27 +09:00
Yuichiro Hanada
22c5c450fe Make Ver4DictEncoder write an address table of terminal nodes.
Bug: 10920165
Change-Id: I86017456ea9fa5d6e12b57172c34f5ed4f88ef94
2013-09-25 17:03:54 +09:00
Satoshi Kataoka
0938fb6913 Allow gesture from the delete key
And inputting unexpected word while repeating the gesture
Bug: 7303982
Change-Id: I17bb6a689397500fa0e26706d6e07e427ea0b4d7
2013-09-25 14:15:43 +09:00
Satoshi Kataoka
9c3b2dbe34 Fix emoji state
Bug: 10919260
Change-Id: I85e897b2de10f147bba40dd2147e041e26f5b8ad
2013-09-25 11:59:21 +09:00
Satoshi Kataoka
431158c939 Turn off emoji palette on JB-MR2
Bug: 10919260

Change-Id: Ie5a0342386baae61285412786162e74746272538
2013-09-25 11:41:46 +09:00
Keisuke Kuroyanagi
2e58670da9 Quit using ExpandableDictionary.
Bug: 6669677
Change-Id: Ie90417fa9b726454fe729a665fcd549efabb9e94
2013-09-24 22:57:15 +09:00
Satoshi Kataoka
d1ae03046c Fix OOBE in JB backword
Bug: 10905948
Change-Id: I4e953296ce3067d05fc5759375f40513580484a6
2013-09-24 21:14:48 +09:00
Satoshi Kataoka
f068c6e656 Merge "Low memory mode in UserHistory" 2013-09-24 11:37:39 +00:00
Satoshi Kataoka
97485273d7 Low memory mode in UserHistory
Bug: 8967766
Change-Id: Id40f54f4d9f43d1f796377983a5fc0ca3417e133
2013-09-24 20:36:31 +09:00
Jean Chalard
f600923376 Merge "Tweak for armenian periods and commas." 2013-09-24 11:20:04 +00:00
Satoshi Kataoka
445ba57814 Merge "Add a utility of isLowRamDevice" 2013-09-24 10:55:11 +00:00
Satoshi Kataoka
03e55efe03 Add a utility of isLowRamDevice
Bug: 8967766

Change-Id: Id7132d1155bb3489bdab72d613289335945808e8
2013-09-24 19:53:35 +09:00
Jean Chalard
933cc808d9 Tweak for armenian periods and commas.
Bug: 7963631
Change-Id: I2eb110949f3d3b7817dbd9448654954fdee39ac2
2013-09-24 19:48:17 +09:00
Ken Wakasa
55e7b3606b Merge "More tweaks for Armenian layouts" 2013-09-24 10:33:21 +00:00
Jean Chalard
3d68b06662 Copy only the spans we are interested in.
The PARAGRAPH type of span is dangerous, as concatenating
CharSequences that contain it may crash. We also don't use
other spans than SuggestionSpans, so we don't copy them.

Bug: 10622489
Change-Id: If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57
2013-09-24 19:04:51 +09:00
Ken Wakasa
15e33c2373 More tweaks for Armenian layouts
Add Armenian question mark and exclamation mark as more keys in the symbols layout.

bug: 7963631
Change-Id: Ic4f306248c10f5439531cd468b78ba467cd1de6a
2013-09-24 18:53:06 +09:00
Satoshi Kataoka
3ca9c5cbec Merge "Implement delete key repeater" 2013-09-24 09:26:47 +00:00
Satoshi Kataoka
9204d11525 Implement delete key repeater
Bug: 10810844
Change-Id: Idbfe2196e8f0f8cf6dd1b77574eefb395c12807a
2013-09-24 18:23:38 +09:00
Ken Wakasa
1b7fc4f338 Tweaks for Armenian layouts
Added a dedicated key for the Armenian full stop

Added Armenian punctuation letters

bug: 7963631
Change-Id: Id28e224329b083a2465256f2713477b4f0782393
2013-09-24 18:22:32 +09:00
Satoshi Kataoka
50704b7d1c Merge "Turn off alpha of key popup preview" 2013-09-24 06:27:21 +00:00
Satoshi Kataoka
0d8266b6eb Turn off alpha of key popup preview
Bug: 10786040
Change-Id: I0a636e5f28f177c4d72f9af0312726711f78dd2d
2013-09-24 15:20:23 +09:00
Jean Chalard
8f23c6f78b Merge "Detect cases where rotation messes with initialization" 2013-09-24 05:38:44 +00:00
Jean Chalard
f1d8aa46f9 Detect cases where rotation messes with initialization
...and do a best effort to fix it.

Bug: 10323080
Bug: 10252066
Change-Id: Icb3c9fe85005406bdfce0b7bb143ba0a910a0ddb
2013-09-20 22:21:28 +09:00
Jean Chalard
262b867200 Merge "Catch SQLiteException from remote processes" 2013-09-20 10:59:13 +00:00
Jean Chalard
d0cf6b7623 Catch SQLiteException from remote processes
...to avoid catching fire when the Contacts or User dictionary
providers crash and burn.

Bug: 10200036
Change-Id: I73e9d126ce6d34ebc7e6ac03d94af1c12dde7eda
2013-09-20 19:55:31 +09:00
Jean Chalard
be3be424a3 Fix a bug that happens upon a race condition
Bug: 10848621
Change-Id: If5ff7f001e69af005a5ff9ab3e9f630b88a0a858
2013-09-20 18:21:10 +09:00
Ken Wakasa
280990bcb1 Merge "Address a couple more issues in Khmer layout" 2013-09-20 07:32:48 +00:00
Ken Wakasa
814acafaea Address a couple more issues in Khmer layout
bug: 6910993
Change-Id: If866629268040cf7696d9667dbca66fac6a60374
2013-09-20 16:27:30 +09:00
Jean Chalard
1d1a3d52b8 Merge "Fix a bug where null would be converted to "null"" 2013-09-20 07:19:59 +00:00
Jean Chalard
8f02f1a118 Fix a bug where null would be converted to "null"
It's unclear what the concrete effects of this are, but they are not
very strong. This only happens in corner cases, when the input
connection is not active - while rotating, for example.

Change-Id: I1d22459a6e94a8ecccb53cfcbc2d301b1d502204
2013-09-20 15:45:51 +09:00
Satoshi Kataoka
baa3121704 Update resources
Change-Id: Ia66f7181514ee1471e181e16d15622174cf72e79
2013-09-20 14:49:54 +09:00
Ken Wakasa
be5e21ecbb Add Khmer layout
bug: 6910993
Change-Id: Ie515acd625bc266494d9e63b0694e2c05a19b661
2013-09-19 22:22:41 +09:00
Ken Wakasa
72503243e4 Merge "Add showSuggestionStripWithTypedWord." 2013-09-19 11:55:09 +00:00
Yuichiro Hanada
a469743e33 Add showSuggestionStripWithTypedWord.
Bug: 10814472
Change-Id: I3a150124baf7a9b7889b033089a859ff9c11e206
2013-09-19 20:52:28 +09:00
Satoshi Kataoka
250a12f6c2 Show Emoji category page id indicator
Bug: 10538430
Change-Id: I767fa8d41c789125af266f2203b4bad7452bc0a5
2013-09-19 18:41:13 +09:00
Jean Chalard
7ba7868763 Merge "Add Ver4DictDecoder." 2013-09-19 07:24:45 +00:00
Satoshi Kataoka
11ce0545ee Merge "Fix hitbox of emoji key" 2013-09-19 07:23:06 +00:00
Yuichiro Hanada
14087ba52c Add Ver4DictDecoder.
Bug: 9618601
Change-Id: I43c5840505c6a847aaf4893a400392ccd45903c0
2013-09-19 16:11:23 +09:00
Satoshi Kataoka
2a9e065f1a Fix hitbox of emoji key
Bug: 10780368
Change-Id: If10c18fdb0e7f0b0460a721d55001ab0fef28664
2013-09-19 15:37:36 +09:00
Keisuke Kuroyanagi
ff493744a3 Merge "Quit skipping user history dictionary for gesture." 2013-09-19 06:16:10 +00:00
Jean Chalard
a7d0ab80a0 Fix an off-by-one error.
These variables were meant to represent the (x,y) coordinate of the
last pixel of the grid, to avoid going one pixel too far. But the last
pixel of the grid, of course, has coord (width - 1, height - 1).

This bug only ever happens in a rare case because to reproduce,
it needs the right (resp. bottom) coordinate of the rightmost
(resp. bottommost) plus the threshold plus half the grid width
(resp. height) to be exactly the number of pixels of the grid,
which is pretty unlikely... unless there are more tiles in the
grid than pixels on the screen, in which case the grid width is
1 and this becomes likely.

This fixes the fencepost error and renames the variables to
clarify their meaning.

Bug: 10537485
Change-Id: Iecfe2c0f29ee17776ee2cceaa4b1db722276b1f3
2013-09-19 13:43:09 +09:00
Keisuke Kuroyanagi
40f66795a2 Quit skipping user history dictionary for gesture.
Bug: 6669677
Change-Id: Id4344f2a30e9827f210055d6c65ee7776d3a63e3
2013-09-19 13:12:11 +09:00
Jean Chalard
8678062853 Merge "Fix an NPE." 2013-09-18 12:42:16 +00:00
Jean Chalard
08bc97f86f Merge "Allow double-space-to-period after a plus char" 2013-09-18 12:40:29 +00:00
Jean Chalard
673275cbc6 Fix an NPE.
Apparently, it is possible that File#getPath() returns null.
In this case, we'll have a null AssetFileAddress and an NPE
later down the road.

Bug: 9944824
Change-Id: Id6ceac1cb55439660f9811cf0fe3b574200d5a20
2013-09-18 21:39:30 +09:00
Jean Chalard
ba99d8cd0b Allow double-space-to-period after a plus char
Bug: 10704936
Change-Id: I30fdaea648605ef7e7fea6c093581ed5c6de03f3
2013-09-18 21:04:25 +09:00
Satoshi Kataoka
957a2337ee Merge "Set EmojiCapable" 2013-09-18 08:48:35 +00:00
Satoshi Kataoka
8837deab73 Merge "Fix Emoji recents" 2013-09-18 08:46:25 +00:00
Satoshi Kataoka
ea7bfa5cd5 Fix Emoji recents
Bug: 10538430

Change-Id: Ia2e423eb1843195b3c3218afc79a5820b8cd729b
2013-09-18 17:44:16 +09:00
Ken Wakasa
256937b475 Merge "Fix getChildrenPosition." 2013-09-18 08:36:48 +00:00
Satoshi Kataoka
51f275d8be Set EmojiCapable
Bug: 10240645
Change-Id: I891309c2a82f8d10f8fdb0872403a7a235e27b5f
2013-09-18 17:29:23 +09:00
Jean Chalard
59418672a1 Merge "Don't resume suggestion on digits." 2013-09-18 07:05:01 +00:00
Keisuke Kuroyanagi
4ad4b9d976 Merge "Fix contacts/user dictionary writing." 2013-09-18 07:00:58 +00:00
Yuichiro Hanada
d0c87576ff Fix getChildrenPosition.
Change-Id: Ic39592dbf0d4e6d2e4879cdb1a95b65d46a57e92
2013-09-18 15:50:10 +09:00
Keisuke Kuroyanagi
0011ab4bf3 Fix contacts/user dictionary writing.
Bug: 10743878
Change-Id: I5d61b7955ef69a635f994f01cc575fb23fdf942b
2013-09-18 15:31:06 +09:00
Keisuke Kuroyanagi
9465819cf6 Merge "Add BinaryDictionary.getBigramProbabilityNative()." 2013-09-18 04:10:38 +00:00
Jean Chalard
f71e1db2da Don't resume suggestion on digits.
Bug: 10780016
Change-Id: I94fad06e4c71eddc96bdda1765925f98bed160f3
2013-09-18 11:37:19 +09:00
Keisuke Kuroyanagi
4d02a2d44d Add BinaryDictionary.getBigramProbabilityNative().
Bug: 10197478
Change-Id: Id16e3ee22a17679c46cc7a0199a9e28065177aa3
2013-09-18 11:18:28 +09:00
Jean Chalard
e8f717943f Improve trailing quotes processing
Bug: 10445496
Change-Id: Ib7bd05aea59ae6c9b8ce31299ef2235521b0e350
2013-09-17 22:17:22 +09:00
Jean Chalard
060917ed9a [AC9] Resize an array
It's not easy for native code to only output the first
result, so let's supply enough room for it to output all.

Bug: 9059617
Change-Id: Ie93b7e54284c8c5d01fdc15846cf52d3442287b6
2013-09-17 19:05:30 +09:00
Jean Chalard
5cab0eb75b Merge "[AC8] Restrict the suggestion strip to the correct part" 2013-09-17 09:48:02 +00:00
Jean Chalard
b1e98c2f4f [AC8] Restrict the suggestion strip to the correct part
...for phrase gesture.

Bug: 9059617
Change-Id: Ic5c0616f28af4ba45ca72a5721d1926029adc1c5
2013-09-17 18:43:12 +09:00
Keisuke Kuroyanagi
d0246277fd Prepare dictionary saving in native code.
Bug: 6669677

Change-Id: I0787f66409e2b183c6328fa05805945520e1e93a
2013-09-17 18:07:16 +09:00
Jean Chalard
7e51989b3f Merge "[AC7] Actually auto-commit." 2013-09-17 08:20:47 +00:00
Keisuke Kuroyanagi
e8754aba1c [AC7] Actually auto-commit.
Bug: 9059617
Change-Id: I7e5d89a9037b9181a0a6456c12043b4bfda8fe4b
2013-09-17 16:44:50 +09:00
Satoshi Kataoka
fb9b50671d Temporary disable saving keys of emoticons to recents
Bug: 10538430
Change-Id: I4c3d0d692eecdd3bb5e780bdaca46f3310065471
2013-09-17 16:40:13 +09:00
Satoshi Kataoka
fc51a82079 Merge "Disable smooth scroll of Emoji pager" 2013-09-17 03:51:47 +00:00
Jean Chalard
73d607fb70 Merge "[AC5] Introduce the setting for phrase gesture." 2013-09-17 03:42:38 +00:00
Satoshi Kataoka
44220e7271 Disable smooth scroll of Emoji pager
Bug: 10538430
Change-Id: Ib9dfa28bf6b642cc8895022ead9e6b2d64001097
2013-09-17 11:46:34 +09:00
Satoshi Kataoka
f3f00006cb Save & restore emoji keyboard state
Bug: 10538430
Change-Id: I7982f53f5dfa44071e74da63826acffcdc2547e6
2013-09-16 19:39:20 +09:00
Satoshi Kataoka
5dfbc8af24 Split Emoji categories fitting the pager
Bug: 10538430
Change-Id: Ic023ac0b9db8a1fe16c73ab5fd12dfcd7cbbe6a3
2013-09-16 18:27:20 +09:00
Ken Wakasa
0f317a5603 Fix issues with Nepali layouts
- Added the missing ZWNJ/ZWJ key
- Fix a wrong letter in the shift layout of Nepali Romaized layout
- Put the currency symbol for Nepalese Rupee
- Fix the missing 2nd symbols layout
- Use the Devanagari numbers just like Hindi layout
- Fix the Main/Symbols switch key label just like Hindi layout

bug: 6910787
bug: 9833890
Change-Id: Ie6aa5a06008f1e9347d4fc08ededd48287df5d73
2013-09-16 02:08:51 +09:00
Ken Wakasa
1313d17d37 Small tweak for label_to_more_symbol_for_tablet_key
To make it a bit more consistent with the one for phones

Change-Id: Ia5775b07a0d70cabc5c51ff2b954c64ce4dc8c7c
2013-09-14 12:10:04 +09:00
Satoshi Kataoka
cdc2ce8c89 Merge "Use DynamicGridKeyboard for EmojiPager" 2013-09-13 12:20:14 +00:00
Satoshi Kataoka
b0bf7e729b Use DynamicGridKeyboard for EmojiPager
Bug: 10538430
Change-Id: Iff84e306faaa8e87d107e418d5c61c5613b57430
2013-09-13 21:18:57 +09:00
Ken Wakasa
505b6ba103 Merge "Add Lao keyboard" 2013-09-13 12:11:31 +00:00
Ken Wakasa
47761678f1 Add Lao keyboard
bug: 6911140
Change-Id: Id689be1fb9dbc89b5a9b7f142626751a62d931ed
2013-09-13 21:10:17 +09:00
Jean Chalard
a37bee2805 [AC5] Introduce the setting for phrase gesture.
Bug: 9059617
Change-Id: I6fa0f675f4edac10bd19228cd2f0c8fca97cebd6
2013-09-13 20:44:37 +09:00
Jean Chalard
41aaff6cdf Merge "[AC4] Add native methods necessary for auto-commit" 2013-09-13 11:41:55 +00:00
Jean Chalard
24aad5a4d5 [AC4] Add native methods necessary for auto-commit
Bug: 9059617
Change-Id: I7a47b0675446fc4f39628c60d16de9aea90d1b4d
2013-09-13 20:15:15 +09:00
Ken Wakasa
fbc7e61a3e Merge "Add Ver4DictEncoder." 2013-09-13 08:51:58 +00:00
Satoshi Kataoka
ffebc9cfa7 Merge "Add shutdown and isTerminated to PrioritizedSerialExecutor." 2013-09-13 08:51:43 +00:00
Yuichiro Hanada
a099a3e341 Add shutdown and isTerminated to PrioritizedSerialExecutor.
Change-Id: Id185224d135c8571a39efe8a41a66ce769142903
2013-09-13 17:46:50 +09:00
Yuichiro Hanada
a141d8ef7d Add Ver4DictEncoder.
Bug: 9618601
Change-Id: I161d2845906f07c1251deb8005fdffe49c5b7940
2013-09-13 17:33:51 +09:00
Satoshi Kataoka
2c011c697b Refactor RecentsKeyboard
Bug: 10538430
Change-Id: I7a22d2d4a105b17b2a84a3fff2bc3981823d228d
2013-09-13 16:35:07 +09:00
Satoshi Kataoka
12ff349f29 Fix emoji tabs
Bug: 10541453
Change-Id: If920eafa0c48e437301fc0b7055ea7b7bbc04669
2013-09-13 14:48:52 +09:00
Satoshi Kataoka
244eca3809 Merge "Fix emoji keyboard insets" 2013-09-13 05:25:33 +00:00
Satoshi Kataoka
898dbe3c29 Fix emoji keyboard insets
Bug: 10541453
Change-Id: I16dd72c8c55cb5d21ad61a3307c0f3c5f16f460c
2013-09-13 14:21:40 +09:00
Satoshi Kataoka
dd072e3201 Consolidate EmojiKeyboardView
bug: 10538430
Change-Id: Ia799eca303d8ec68eeeb9f00fa8002a44d0c49fc
2013-09-13 11:32:18 +09:00
Jean Chalard
40666017c9 Merge "Avoid recorrection in ex-password fields." 2013-09-12 12:29:33 +00:00
Jean Chalard
ce96d0d12f Avoid recorrection in ex-password fields.
Bug: 10115839
Change-Id: I1f1025c9f28adfb6f5a63d5ba86e359f30c0963e
2013-09-12 21:20:07 +09:00
Ken Wakasa
a6dc3056ff Merge "Add getDictDecoder." 2013-09-12 11:17:03 +00:00
Yuichiro Hanada
0e40cd0c40 Add getDictDecoder.
Bug: 9618601
Change-Id: I173100ac704c03f7d5d0d53477e83cab5d1110d4
2013-09-12 20:14:09 +09:00
Satoshi Kataoka
28af9ed19e Merge "Suppress emoji tabs on JB-MR2 or previous versions" 2013-09-12 10:58:29 +00:00
Keisuke Kuroyanagi
b118a9d729 Merge "Change cache capacity depending on the dictionary size." 2013-09-12 10:38:42 +00:00
Satoshi Kataoka
36ccb030ed Suppress emoji tabs on JB-MR2 or previous versions
Change-Id: I6a9c4994a446026b9736fda37ad7eccbd67a9a3d
2013-09-12 19:38:26 +09:00
Satoshi Kataoka
695a5a391d Merge "Change space key height in Emoji keyboard view" 2013-09-12 10:25:33 +00:00
Satoshi Kataoka
2d3d415826 Change space key height in Emoji keyboard view
bug: 10538430

Change-Id: I724a8c92b49a64196c7da2af40f3d20758e0dbae
2013-09-12 19:18:41 +09:00
Keisuke Kuroyanagi
4c2767857a Change cache capacity depending on the dictionary size.
Bug: 10699291

Change-Id: I7042d4c1307da2d991d4dd10d637f18026acb996
2013-09-12 18:47:56 +09:00
Yuichiro Hanada
be470f06e4 Hide DictBuffer from BinaryDictDecoderUtils.
Bug: 9618601
Change-Id: I87515bc1555bdfe09426a056ceda74d8e63eba82
2013-09-12 16:49:54 +09:00
Jean Chalard
87472f0038 Remove changing a word when added to the dictionary
This code is now useless.
I thought it affected 9902905, but it seems it actually does not.
Still, it's dead code.

Bug: 9902905
Change-Id: Id9c90fbf88f015af47b2368b90d173c481647093
2013-09-12 15:10:10 +09:00
Keisuke Kuroyanagi
76e431b315 Merge "Use same session id for typing and gesture." 2013-09-12 03:16:43 +00:00
Keisuke Kuroyanagi
f1233b58c2 Use same session id for typing and gesture.
Bug: 10699291
Change-Id: I7c8a3a57e8d189b72a17e4b9c6831becee6ec146
2013-09-12 12:08:22 +09:00
Yuichiro Hanada
7547a7042c Add writePtNode to DictEncoder.
Bug: 9618601
Change-Id: Ie4529444780edee8d0f0d5f23c5619c1a3344286
2013-09-11 18:27:06 +09:00
Yuichiro Hanada
95bc256f41 Add a flag to readDictioanryBinary in DictDecoder.
Change-Id: I356adb72047ebc43c924fbff1ff45e7460508a31
2013-09-11 18:20:56 +09:00
Yuichiro Hanada
e193c5255d Revert Ida230ca42 and I6adf7d08f.
Change-Id: I2ddb250d5a473ea955a5171656974de7288a13f7
2013-09-10 19:08:43 +09:00
Yuichiro Hanada
ef073f4024 Use PrioritizedSerialExecutor instead of ReentrantReadWriteLock.
Change-Id: I003b769e408ebd692085a7e17fed6d9396876202
2013-09-10 19:05:41 +09:00
Ken Wakasa
40e91e4582 Merge "Check the version of format options before writing." 2013-09-10 10:01:12 +00:00
Yuichiro Hanada
8a06b26cb4 Check the version of format options before writing.
Change-Id: I3951e4395a2da225e240e856c23339b679e6155e
2013-09-10 18:59:31 +09:00
Keisuke Kuroyanagi
e531c2241e Move a flag about switching dynamic update to java.
Bug: 6669677

Change-Id: I6aa99cae4a227f9202179c2873d13473a773e024
2013-09-10 18:45:53 +09:00
Yuichiro Hanada
acdabb25f4 Add AsyncResultHolder.
Change-Id: Icfa685bcda2f5c74f5649f09098d00b4bd321c5a
2013-09-10 15:48:06 +09:00
Satoshi Kataoka
be96361156 Merge "Check contents in user history dictionary tests" 2013-09-09 06:46:45 +00:00
Satoshi Kataoka
e5a35711b8 Check contents in user history dictionary tests
Bug: 10667710

Change-Id: I45ebb08cb4ef9a9f6d2da31e2c50e740f88209c2
2013-09-09 15:28:50 +09:00
Yuichiro Hanada
70e81af726 Hide physical structure of the dictionary from BinaryDictEncoderUtils.
Bug: 9618601
Change-Id: I01b8da42058d7c05bf7f4e6d43718032c2ad12c5
2013-09-09 14:55:33 +09:00
Yuichiro Hanada
cc2751ba03 Make commitCurrentAutoCorrection asynchronous.
Change-Id: Ida230ca4243347fb3ab9fda7de3a9a18f886cd1c
2013-09-09 14:47:26 +09:00
Keisuke Kuroyanagi
37e0fd2ff0 Revise TODO comment for I823912e3979829a.
Change-Id: I839d8cb4d45d7d17b7940d710a2fef5aeacc11ab
2013-09-09 12:26:40 +09:00
Keisuke Kuroyanagi
773f227242 Fix: wrong locking order.
Change-Id: I823912e3979829ad1e825cf91dc5e18f7f0f9cc3
2013-09-09 12:13:21 +09:00
Keisuke Kuroyanagi
e7ac900340 Merge "Write forgetting curve flag." 2013-09-09 01:46:59 +00:00
Yuichiro Hanada
563bcb5117 Rename write(|Signed)VariableAddress and to write(|Signed)ChildrenPosition.
Change-Id: Ib018bde346744b470a4fb13b0c57e3a633b8bb20
2013-09-06 23:53:58 +09:00
Yuichiro Hanada
6156892b7e Add computeChildrenPosition and simplify writePlacedNode.
Change-Id: Idcf0e056bf61e29844d4d0e91c482cd78c41704c
2013-09-06 23:52:10 +09:00
Keisuke Kuroyanagi
859b9eeaf0 Write forgetting curve flag.
Bug: 6669677
Change-Id: Ic19aa3b69fb45d9638f9dcc8c3dd8a34aad41965
2013-09-06 21:03:09 +09:00
Satoshi Kataoka
741831d322 Add margin to the label of language
Change-Id: I48dc63475caf5cc1a1ac09b82b26fbeaef993fa1
2013-09-06 17:21:44 +09:00
Satoshi Kataoka
98565a9c02 Optimize tablet layout
Bug: 9059539
Change-Id: Ideb6965768fcf092c081eb1d3102312c863cc5b6
2013-09-06 16:43:19 +09:00
Satoshi Kataoka
b690c03927 Merge "Optimize layout" 2013-09-05 13:31:53 +00:00
Satoshi Kataoka
d6217a323c Optimize layout
Bug: 9059539

Change-Id: Iabfd44daae1ef6da99a864859488a4f644240925
2013-09-05 22:27:26 +09:00
Yuichiro Hanada
b1af47c8fe Add a callback to the arguments of commitCurrentAutoCorrection.
Change-Id: I6adf7d08fdc4382233a63304743207368db8058a
2013-09-05 20:00:40 +09:00
Satoshi Kataoka
80fe84b3a4 Merge "Consolidate voice input key options no.1" 2013-09-05 07:33:59 +00:00
Satoshi Kataoka
21a89c1137 Consolidate voice input key options no.1
Change-Id: I2f928522a0795f57b4133072f270d8fd2498cae9
2013-09-05 16:25:41 +09:00
Yuichiro Hanada
55f5f7a005 [Refactor] Add writeDictionaryHeader.
Change-Id: I69026c47ce1d23f5c39c99ace76fa6b96cd1ce1b
2013-09-05 16:19:26 +09:00
Yuichiro Hanada
663f5375d1 Add comments about how to calculate parent and children addresses.
Change-Id: Idf37d9a08a7b464a14c8755bedb755005e49ba33
2013-09-05 15:10:28 +09:00
Satoshi Kataoka
e0502496da Revert "Remove symbols shifted layout"
This reverts commit c02a365485.

Change-Id: I11d31632469a594c0637f035bdd74ba60b2ac33e
2013-09-04 18:22:59 +09:00
Satoshi Kataoka
e3150664ae Revert "Remove symbols shifted layout related code"
This reverts commit 1cd027850b.

Bug: 9059539

Change-Id: I1880b799e2d0f148ae913f13cffa1b8cac48be60
2013-09-04 16:27:34 +09:00
Satoshi Kataoka
42b799d93a Revert "Remove symbols shifted related unused texts and styles"
This reverts commit 59f49b3861.

Bug: 9059539

Change-Id: I6e298a55feb942fc3720a91b65f841220443b42b
2013-09-04 12:24:55 +09:00
Yuichiro Hanada
648088aa9e Change GET_SUGGESTED_WORDS_TIMEOUT to 200.
Change-Id: Ia5aa0b7af16d7ad45c98d0c5a7dcabba76d19b67
2013-09-03 18:52:53 +09:00
Ken Wakasa
c4c7a59a12 Merge "Change GET_SUGGESTED_WORDS_TIMEOUT to 50." 2013-09-03 08:54:12 +00:00
Yuichiro Hanada
d6c947ef7b Change GET_SUGGESTED_WORDS_TIMEOUT to 50.
Change-Id: I4d495a782ed1dea1c377837c6579ce5ff74086b5
2013-09-03 17:39:47 +09:00
Satoshi Kataoka
eaee156128 Optimize tablet layout
Bug: 9059539
Change-Id: I049941d2c83764c7f07c5215799b9657a7f27764
2013-09-03 17:36:42 +09:00
Yuichiro Hanada
908fc4f1c3 Call getSuggestedWords asynchronously.
Change-Id: Ia8a21b53f4d12b759d9ef5a5181ed04875e4d198
2013-09-03 15:12:49 +09:00
Yuichiro Hanada
8616e4c03d Remove typedWord from the arguments of showSuggestionStrip.
Change-Id: Iddf33227982e65705b49c6a527286d8695878c90
2013-09-02 22:31:43 +09:00
Yuichiro Hanada
9666a22815 Revert "Revert "Add onGetSuggestedWordsCallback.""
This reverts commit 78f707a142.
Change-Id: I5dd4f2d40314002736226886477563f29a25079c
2013-09-02 14:09:53 +09:00
Ken Wakasa
acc886eeb4 Merge "Revert "Add onGetSuggestedWordsCallback."" 2013-08-30 14:07:18 +00:00
Ken Wakasa
78f707a142 Revert "Add onGetSuggestedWordsCallback."
This reverts commit 820c290a61.

Change-Id: I5c50731ff9f330c05c5841b8c65f16e28e67422c
2013-08-30 14:06:19 +00:00
Ken Wakasa
56e1b7e4f1 Fix emoji view insets calculation
bug: 10541453
Change-Id: I605e657c94686c4974d162657a5e820798d20e8f
2013-08-30 21:18:36 +09:00
Satoshi Kataoka
5169937dd4 Revert "Revert "Support Emoji keyboard""
Window resizing junkiness is addressed in I605e657c9468

This reverts commit aabc972338.

Change-Id: I0bc0f1ad9a90799e643fe9ec35f5b4bbe94eee0d
2013-08-30 19:46:10 +09:00
Ken Wakasa
9f79cf6de4 Merge "Add onGetSuggestedWordsCallback." 2013-08-30 07:52:57 +00:00
Ken Wakasa
2f95baaaf0 Merge "Revert "Remove key preview backing view"" 2013-08-30 07:51:29 +00:00
Ken Wakasa
c160a3932f Revert "Remove key preview backing view"
This reverts commit 2dfcfc5013.

Change-Id: I96c691b2e9c92be456420196cd7361d03ea4f3e9
bug: 10541453
2013-08-30 07:50:37 +00:00
Ken Wakasa
4445671efc Merge "Revert "Support Emoji keyboard"" 2013-08-30 07:27:48 +00:00
Ken Wakasa
aabc972338 Revert "Support Emoji keyboard"
This reverts commit d7791a93b0.

Change-Id: I5ca4c0227f97540e8a22b487b5056dfa3611082b
2013-08-30 07:23:42 +00:00
Yuichiro Hanada
820c290a61 Add onGetSuggestedWordsCallback.
Change-Id: Ib527d31f9c2dd6dc385cb2f767cd90d9d28a1b1b
2013-08-30 16:08:13 +09:00
Tadashi G. Takaoka
bcfcdae230 Add Armenian Phoetic keyboard
We believe this layout is Armenian Eastern Phonetic Keyboard.

Bug: 7963631
Change-Id: Iff3dd879268dd95f00855f67f749e8562fff490c
2013-08-29 20:29:39 +09:00
Tadashi G. Takaoka
d7791a93b0 Support Emoji keyboard
Bug: 6370846
Change-Id: I33ce8f952799c89929996a226ac17731a953ec2a
2013-08-29 19:48:34 +09:00
Tadashi G. Takaoka
47b71c82ec Fix keyStyle flags handling
Change-Id: Ia0d21f7a00ff99eae89c746244484d6fa3f0f44e
2013-08-29 17:20:18 +09:00
Ken Wakasa
2cbc7c682d Merge "Workaround for AIOOB exception in ProximityInfo" 2013-08-29 08:11:21 +00:00
Satoshi Kataoka
4994e1f2ba Workaround for AIOOB exception in ProximityInfo
Bug: 10537485
Change-Id: I185f17dcb2cd9e3af17a1eafefaa487804d5cce9
2013-08-29 15:47:47 +09:00
Tadashi G. Takaoka
e9e8d2d986 Use fixed column order for punctuation more keys
This is a follow up of I71f58fc49b.

Bug: 9059539
Change-Id: Ibf5684ac196e03e889160d8bb14e2b1377331133
2013-08-29 14:22:30 +09:00
Tadashi G. Takaoka
fcc6ab08ae Merge "Reduce the number of more keys of the period key" 2013-08-29 01:12:25 +00:00
Tadashi G. Takaoka
85d9b3c281 Reduce the number of more keys of the period key
Bug: 9059539
Change-Id: I71f58fc49bf33b40c17b5a94cad82e942b95e3f1
2013-08-29 10:10:13 +09:00
Tadashi G. Takaoka
41745c4995 Add keyboardLayoutSet attribute to <case> condition
Change-Id: I017c4a3c1c7b2e4c6f607940078f61e120042270
2013-08-29 09:50:45 +09:00
Tadashi G. Takaoka
2a084e88a7 Merge "Add EmojiKeyboardView" 2013-08-28 11:22:40 +00:00
Tadashi G. Takaoka
8ac0eb59e1 Add EmojiKeyboardView
Bug: 6370846
Change-Id: Ic7d75f1d242795e756e6fede988cfe4b5cc17f0e
2013-08-28 20:18:19 +09:00
Keisuke Kuroyanagi
fe87f5f417 Pass additionalFeaturesOptions for getSuggestions().
This fixes null pointer exceptions that are caused when
getSuggestion() is called from spell checker.

Change-Id: Ifc9e7abb900e1a4646e33c91022effde439673e4
2013-08-28 19:24:28 +09:00
Tadashi G. Takaoka
c0f81463cb Merge "Add dummy Emoji subtype" 2013-08-28 07:42:29 +00:00
Tadashi G. Takaoka
bd4068c595 Merge "Add recents keyboard" 2013-08-28 07:40:05 +00:00
Tadashi G. Takaoka
803ea61d55 Add recents keyboard
Bug: 6370846
Change-Id: I5dc235395fe9b3bd95711fee2fe9b678b4660760
2013-08-28 16:33:54 +09:00
Tadashi G. Takaoka
34cbcc1aed Add dummy Emoji subtype
Bug: 6370846
Change-Id: I4fa3a6832fa316d0c6312d434be3c3ff02b52402
2013-08-28 16:26:00 +09:00
Keisuke Kuroyanagi
f0c4575cf4 Fix: Wrong file name for dynamic prediction dictionary.
Bug: 6669677
Change-Id: Id6f06a7423600d3f0604fab43d855826c20d0545
2013-08-28 14:41:32 +09:00
Tadashi G. Takaoka
16ed1868a1 Fix build
Change-Id: I60a6ee4dff8203cd9a2ed8045df6a2d75e50c89d
2013-08-27 17:32:37 +09:00
Tadashi G. Takaoka
08323cd597 Add _gb to Gingerbread resources
Bug: 10415342
Change-Id: Id8caf5a972fe72b577dbf50dcd2cf739b2d35a32
2013-08-27 17:05:22 +09:00
Tadashi G. Takaoka
adaaf9ffb8 Rename theme file names
Bug: 10415342
Change-Id: I692b157953f77c610482b494cbaeed4430bcb629
2013-08-27 14:41:54 +09:00
Tadashi G. Takaoka
1f4612fc54 Remove obsolete theme resources
Bug: 10415342
Change-Id: I9073c54b037e0f7973710a9e24ca5044f8db6db0
2013-08-27 12:47:26 +09:00
Tadashi G. Takaoka
2da94ad8cd Add scrollable KeyboardView
Bug: 6370846
Change-Id: I8b9a619e0e6a980c8b17788ad03c62effc7f35b5
2013-08-26 23:37:52 +09:00
Keisuke Kuroyanagi
78ab1bb661 Merge "Make DynamicPred...Base extend ExpandableBinaryDictionary." 2013-08-26 09:56:47 +00:00
Keisuke Kuroyanagi
6e04d65932 Make DynamicPred...Base extend ExpandableBinaryDictionary.
Bug: 6669677
Change-Id: I06afad35d3eb73510c34d10cd4116f5bcf934f7c
2013-08-26 18:50:22 +09:00
Yuichiro Hanada
d5a3c593db Remove a broken dictionary file when fail to read a dictionary file.
Bug: 10434720
Change-Id: Ibdf05a39113538546b8fcf9d59af7dddf7ca27fc
2013-08-26 18:08:21 +09:00
Yuichiro Hanada
b50a7a4bc7 Simplify computeActualNodeArraySize.
Change-Id: I128d02866c2cc70c42263496927327b8a2130139
2013-08-26 08:30:23 +00:00
Yuichiro Hanada
2232a70806 Clean up unused imports.
Change-Id: I7147ca237b99399e79210852aa5bf5a01101d779
2013-08-26 08:29:16 +00:00
Ken Wakasa
d21adb5865 Merge "[Refactor] Add DictDecoder.readUnigramsAndBigramsBinary." 2013-08-26 08:28:44 +00:00
Yuichiro Hanada
752a33640c [Refactor] Add DictDecoder.readUnigramsAndBigramsBinary.
Change-Id: I259db91d837c67cbcb3b6dc504b21dca23a6a5be
2013-08-26 17:24:38 +09:00
Tadashi G. Takaoka
4e7825cb58 Merge "Add GridRows tag to support emoji keyboard" 2013-08-26 08:24:16 +00:00
Tadashi G. Takaoka
2f5a933c04 Add GridRows tag to support emoji keyboard
Bug: 6370846
Change-Id: Ia68284b2402e52d835040da900a51cca669add2f
2013-08-26 17:19:24 +09:00
Tadashi G. Takaoka
be4f8f3fbc Merge "Clean up PC QWERTY keyboard" 2013-08-26 07:53:20 +00:00
Tadashi G. Takaoka
7f28b3cc6a Clean up PC QWERTY keyboard
Change-Id: Ibb52683e8f27517b9e7bf398d3b7a31215bd5a8d
2013-08-26 16:23:29 +09:00
Yuichiro Hanada
bb5b84a826 [Refactor] Add DictDecoder.getTerminalPosition.
Change-Id: I9d04f64a58f5481cbb64cf1c09b5c485dd4176b4
2013-08-26 16:14:59 +09:00
Ken Wakasa
800225e0b1 Merge "Rename CharGroup to PtNode." 2013-08-26 07:11:12 +00:00
Yuichiro Hanada
576f625ee1 Rename CharGroup to PtNode.
Bug: 10233675
Change-Id: I7b0eb07d195cd386cd0d9e97cd59bf48fcf24107
2013-08-26 15:58:30 +09:00
Tadashi G. Takaoka
3f1ef22ff0 Fix build
Change-Id: I77e25fd4032b7fc3b4b565c9bab18a2824d7bb76
2013-08-26 15:34:45 +09:00
Tadashi G. Takaoka
17f628c56c Merge "Add copy constructor to Keyboard" 2013-08-26 06:25:26 +00:00
Tadashi G. Takaoka
7308c36a55 Merge "Add emoji keyboard element ids" 2013-08-26 05:42:52 +00:00
Tadashi G. Takaoka
0b3d5e12e3 Add copy constructor to Keyboard
Change-Id: Ib207039f53346f420cca050080e3c4f452e63ff6
2013-08-26 14:21:45 +09:00
Tadashi G. Takaoka
68b990e7ce Add emoji keyboard element ids
Bug: 6370846
Change-Id: I0ac55bc06e1527bafad395f4a2b5059e1fed4b5d
2013-08-26 12:48:07 +09:00
Tadashi G. Takaoka
af9c8892da Merge "Remove symbols shifted related unused texts and styles" 2013-08-26 03:44:08 +00:00
Tadashi G. Takaoka
59f49b3861 Remove symbols shifted related unused texts and styles
This is a follow up of I7fe6520e4e.

Bug: 9059539
Change-Id: I1b2cdc4f6ae2f59fabc75c38f43e2b2512b08721
2013-08-26 12:08:08 +09:00
Keisuke Kuroyanagi
958f84320d Merge "Introduce DynamicDictionaryWriter for dynamic dictionary." 2013-08-26 02:29:01 +00:00
Tadashi G. Takaoka
73c2948113 Fix Persian currency symbol
Change-Id: Iea202e6d6857cbc0a3d4374c76bd72ed992da9a6
2013-08-24 02:07:47 +09:00
Tadashi G. Takaoka
ce607358bd Merge "Remove symbols shifted layout related code" 2013-08-23 15:37:57 +00:00
Tadashi G. Takaoka
1cd027850b Remove symbols shifted layout related code
This is a follow up of I7fe6520e4e.

Bug: 9059539
Change-Id: Idb39906ddb1e2234a0d1c7c4d5e6fc728090e79e
2013-08-24 00:07:23 +09:00
Yuichiro Hanada
8f4d5d5f23 Fix getDictionaryFileHeader.
Change-Id: I5186f41b0f38eb08f4154f7b3de7ffc2119fc44b
2013-08-23 22:39:36 +09:00
Keisuke Kuroyanagi
87a72f50c2 Introduce DynamicDictionaryWriter for dynamic dictionary.
Bug: 6669677
Change-Id: Ifcbeb88b908f2301ac062b411a95c8b38d24b90e
2013-08-23 22:04:27 +09:00
Yuichiro Hanada
e9a10ff0f0 Add DictDecoder.readDictionaryBinary.
Bug: 10434720
Change-Id: I14690a6e0f922ed1bab3a4b6c9a457ae84d4c1a4
2013-08-23 20:29:25 +09:00
Satoshi Kataoka
d4528b88e1 Refactor personalization dictionary
Bug: 9429906
Change-Id: I1fa4b045b21687e96de101a97e9593b0884d626f
2013-08-23 18:40:28 +09:00
Yuichiro Hanada
1b50a42b7c Fix addWord.
Change-Id: Ib71dbd5954f44ca80733fa4b1048c829e1df138a
2013-08-23 16:56:48 +09:00
Tadashi G. Takaoka
c02a365485 Remove symbols shifted layout
Bug: 9059539
Change-Id: I7fe6520e4eafcb7e1748b8bf011333c7e0da7ac2
2013-08-23 13:41:46 +09:00
Ken Wakasa
4929f8516c Merge "Fix writePlacedNode." 2013-08-22 14:03:53 +00:00
Yuichiro Hanada
aa4168ee09 Fix writePlacedNode.
Change-Id: I1d6b086f1d9f0dbd8d74f964e29ae62c533af978
2013-08-22 23:02:08 +09:00
Satoshi Kataoka
366c0c5198 Register personalization dictionary
Bug: 9429906
Change-Id: Ic754dd8da67446dfb1ebf44aa3d5ab0804298ca0
2013-08-22 18:06:59 +09:00
Yuichiro Hanada
e301085a70 Move findWordByBinaryDictReader to BinaryDictIOUtilsTests.
Change-Id: I443238fd816dea9650dcbbeb3ea757f9674fa52f
2013-08-22 14:49:49 +09:00
Ken Wakasa
fef693ea98 Merge "Add DictEncoder." 2013-08-22 05:38:09 +00:00
Yuichiro Hanada
c922c8a504 Add DictEncoder.
Change-Id: I41049b9118b58838e5dedf8e5618d939ca70c5ef
2013-08-22 11:53:41 +09:00
Tadashi G. Takaoka
198b52f6db Merge "Fix Hebrew currency symbol" 2013-08-22 02:03:09 +00:00
Tadashi G. Takaoka
6d9b4e913a Fix Hebrew currency symbol
Change-Id: Ib747828aeec20c1ebb4087169a7eb373deb163c3
2013-08-22 10:55:46 +09:00
Kurt Partridge
a09e43ef6e Merge "Fix cursor state bug" 2013-08-22 01:24:15 +00:00
Kurt Partridge
6c94a18a28 Fix cursor state bug
InputConnection#finishComposingText() should not change the position of the cursor,
so neither should it change its internal expectation of the cursor's position.

Change-Id: Ib3d39a5743cd1e8e356f438b04a5c30279430b2a
2013-08-21 17:55:35 -07:00
Ken Wakasa
f9233e0b98 Merge "Make readPtNode be called with the address from the beginning of the file." 2013-08-21 11:27:20 +00:00
Yuichiro Hanada
558e34c7bd Make readPtNode be called with the address from the beginning of the file.
Change-Id: I8939fdfb4f79e55bcd7393633784effb30df3f8f
2013-08-21 20:02:18 +09:00
Satoshi Kataoka
17cc396972 Merge "Fix build" 2013-08-21 10:56:18 +00:00
Satoshi Kataoka
b1552723ee Fix build
Change-Id: I0c0be463552a37cecfb9a403e0723b1799fb8120
2013-08-21 19:55:07 +09:00
Satoshi Kataoka
f739807a3f Merge "Add onDestroy to PersonalizationDictionarySessionRegister" 2013-08-21 10:54:08 +00:00
Yuichiro Hanada
a306e08753 Rename BinaryDictEncoder to BinaryDictEncoderUtils.
Change-Id: I4dabf17da7003b1d8204a83dbd10e5be6e8fd805
2013-08-21 18:54:34 +09:00
Yuichiro Hanada
107a5f6fb8 Add PtNodeReader.
Change-Id: Ic918822fc1b3a8a7c39ffbcf7defde2c5bf888db
2013-08-21 18:43:18 +09:00
Satoshi Kataoka
3c8f22880f Add onDestroy to PersonalizationDictionarySessionRegister
Bug: 9429906
Change-Id: Ibf8efd7302da2c27ac59e62b0393f1eec03dc136
2013-08-21 17:24:12 +09:00
Jean Chalard
77827e7b3b Merge "Don't start composing on dash." 2013-08-21 08:06:13 +00:00
Tadashi G. Takaoka
1f39d36458 Remove unnecessary alpha attributes of SuggestionStripView
Change-Id: I78701403d7bd21928c4b459bb336a565f386ebcc
2013-08-21 12:44:30 +09:00
Jean Chalard
2448159ad4 Don't start composing on dash.
Bug: 10403176
Change-Id: I9f969ab9b772dc5ba2015c494b4f98a8864277c4
2013-08-21 11:59:21 +09:00
Jean Chalard
2c7a3e0405 Merge "[AC3] Start calling the methods for auto-commit." 2013-08-20 11:05:23 +00:00
Jean Chalard
c10d76f28c Merge "[AC2] Reference a dict rather than a string in suggestion infos" 2013-08-20 11:05:12 +00:00
Jean Chalard
3f15c41d88 Merge "[AC1] Add a memory of where to cut the first word." 2013-08-20 11:05:09 +00:00
Jean Chalard
66a870cb53 [AC3] Start calling the methods for auto-commit.
Bug: 9059617
Change-Id: I190a4baf2fa831b70e00e129b5dfaa8c9c32b3a0
2013-08-20 19:26:11 +09:00
Jean Chalard
e8ef095670 [AC2] Reference a dict rather than a string in suggestion infos
Bug: 9059617
Change-Id: Ic17bc0fd5d812268fd37d7fd35b4e9ebfb95fa5e
2013-08-20 19:18:09 +09:00
Jean Chalard
ef1e363016 [AC1] Add a memory of where to cut the first word.
Bug: 9059617
Change-Id: I931b6d1eb49f9f7dd7d5b18956e35751d1b2b631
2013-08-20 18:43:19 +09:00
Satoshi Kataoka
33f5f0df8b Merge "Add a functionality to boost scores of personalization dictionary" 2013-08-20 09:08:41 +00:00
Satoshi Kataoka
d6ddb96ee8 Add a functionality to boost scores of personalization dictionary
Bug: 9429906
Change-Id: I1518c5cbc7d41188e7dc6a35d226da277ed5913f
2013-08-20 17:50:48 +09:00
Yuichiro Hanada
065aad9501 Add DictDecoder.
Change-Id: Ia1c32f21fe07081ce04d093660e18146b93275a4
2013-08-20 17:43:13 +09:00
Yuichiro Hanada
112257e40f Rename BinaryDictDecoder to Ver3DictDecoder.
Change-Id: Ibf9b95b658df6e2c2218bdb62e2380f326a03832
2013-08-20 17:11:51 +09:00
Yuichiro Hanada
66004ce2de Remove populateOptions.
Change-Id: I1a1830aaa8ea586b68fc34ff3a27ae52b810e8af
2013-08-20 16:06:52 +09:00
Satoshi Kataoka
22f01a42fc Add a functionality to clear and flush prediction dictionary
Bug: 9429906
Change-Id: I84ec444e9d46a0080dc3450b8ab32bfb99407cfe
2013-08-20 12:28:05 +09:00
Yuichiro Hanada
77bce05e6f [Refactor] Rename BinaryDictReader and BinaryDictDecoder.
BinaryDictReader -> BinaryDictDecoder.
BinaryDictDecoder -> BianryDictDecoderUtils.

Change-Id: Iadf2153b379b760538ecda488dda4f17225e5f37
2013-08-19 19:36:31 +09:00
Tadashi G. Takaoka
c8fb03e6a8 Merge "Save and restore Row attributes using stack" 2013-08-19 10:03:09 +00:00
Tadashi G. Takaoka
bcd173dfa1 Save and restore Row attributes using stack
Change-Id: I5cb402060946a711384ee53fa1caaeac86aa10cc
2013-08-19 18:36:49 +09:00
Satoshi Kataoka
6484a4f886 Consolidate onDictionaryClosed
Bug: 9429906
Change-Id: I51eef4c321cc268eac1c8dfd6561ab6e716a1fb0
2013-08-19 17:45:20 +09:00
Satoshi Kataoka
0e6fcf2bf6 Rename Personalization dictionary register functions
Bug: 9429906
Change-Id: Ibdce8db61ab6cc5922765e7ed8b7f2c718759de8
2013-08-19 16:53:21 +09:00
Keisuke Kuroyanagi
c8ac8da4e4 Merge "Prepare ExpandableBinaryDictionary to make it updatable" 2013-08-19 07:20:16 +00:00
Satoshi Kataoka
979f9f9939 Merge "Consolidate hex string utils" 2013-08-19 05:33:07 +00:00
Satoshi Kataoka
3894a5599b Consolidate hex string utils
Change-Id: Id4f4a287e3a2790b22bff7ad4a4617bf2ee82884
2013-08-19 12:09:59 +09:00
Tadashi G. Takaoka
221929c643 Keyboard.Row can have keyLabelFlags attribute
Change-Id: I5af1f1d88153068d7be6e496e6dd77bd5b09a894
2013-08-19 11:45:30 +09:00
Tadashi G. Takaoka
0154e3620f Merge "Rename KeyStyle.getFlag to getFlags" 2013-08-19 02:41:49 +00:00
Tadashi G. Takaoka
18546fa92c Merge "Make all KeyboardRow attributes private" 2013-08-19 02:41:40 +00:00
Tadashi G. Takaoka
784416f73b Make all KeyboardRow attributes private
Change-Id: Ifaca6ad5e642964d8c3a77a96a1cd74f363ee996
2013-08-19 11:36:34 +09:00
Tadashi G. Takaoka
0cfd2b08af Rename KeyStyle.getFlag to getFlags
Change-Id: Iff3d850466cb6016a53bf86104cd5d22363f96a8
2013-08-19 11:35:11 +09:00
Ken Wakasa
a83e25642f Merge "Add HeaderReaderInterface." 2013-08-19 02:34:23 +00:00
Yuichiro Hanada
d794b42f98 Add HeaderReaderInterface.
Change-Id: I298f86b70d18cd08b240509b6f757c72e1a59ffe
2013-08-19 11:15:03 +09:00
Yuichiro Hanada
8aaae56cf6 Fix unit test.
Change-Id: Ib104d5de71c2ab1a07921b407c74c21b0409d9af
2013-08-19 11:10:28 +09:00
Ken Wakasa
606a056b53 Merge "Make BinaryDictIOUtils and DynamicBinaryIOUtils use BinaryDictReader." 2013-08-16 12:46:07 +00:00
Yuichiro Hanada
3a73b37b30 Make BinaryDictIOUtils and DynamicBinaryIOUtils use BinaryDictReader.
Change-Id: I191dfe0e05ff3c2c5af99e8beebbb73b097748a3
2013-08-16 21:06:23 +09:00
Jean Chalard
e32475611c Merge "Support languages that don't use spaces." 2013-08-16 12:05:16 +00:00
Jean Chalard
c239a34262 Support languages that don't use spaces.
Thai is an example.

Bug: 10138062
Change-Id: Ib9a8264c77ed42b4256432d7c8a60d08575dcdc7
2013-08-16 21:01:08 +09:00
Ken Wakasa
c2f2d0d211 Merge "Limit the number of waiting UpdateBinaryTask to at most 1." 2013-08-16 11:58:57 +00:00
Yuichiro Hanada
e72c4e5fc7 Remove a static buffer for thread safety.
Change-Id: I335c35eb182ff63abb8a5b04c053a98d44b7c6ce
2013-08-16 20:22:46 +09:00
Keisuke Kuroyanagi
c8db6f21e9 Prepare ExpandableBinaryDictionary to make it updatable
Bug: 6669677

Change-Id: Iaa6100f58de78d104e19c7a3c41d67e7826264f9
2013-08-16 20:16:31 +09:00
Yuichiro Hanada
0d70bcc821 Limit the number of waiting UpdateBinaryTask to at most 1.
Change-Id: Ia588d8f29ab58983ea5321ff8c63ad273c33eab3
2013-08-16 19:44:47 +09:00
Ken Wakasa
47bac6ebf2 Merge "Remove unnecessary caching." 2013-08-16 08:28:19 +00:00
Yuichiro Hanada
6e26cc3f5d Remove unnecessary caching.
Change-Id: Ic4ccab9d344b30b72fca1503827eec1c628fa4ac
2013-08-16 17:10:45 +09:00
Jean Chalard
21dddb1462 Merge "Rename Node to PtNodeArray" 2013-08-16 08:00:55 +00:00
Jean Chalard
af30cbf0ee Rename Node to PtNodeArray
Bug: 10247660
Change-Id: I1a0ac19f58f96adb5efac5fd35c6404831618c99
2013-08-16 16:24:54 +09:00
Satoshi Kataoka
283cf9cfc9 Add hex string utils
Bug: 9429906
Change-Id: I3267d1d86122ab471c3e63008c73e9f9b758fc8e
2013-08-16 16:17:48 +09:00
Ken Wakasa
33fce975c9 Merge "[Refactor] Divide BinaryDictInputOutput into BinaryDictEncoder and BinaryDictDecoder." 2013-08-15 11:26:06 +00:00
Yuichiro Hanada
94460eba11 [Refactor] Divide BinaryDictInputOutput into BinaryDictEncoder and BinaryDictDecoder.
Change-Id: I7c3269d77e3e3b567e459dcaa1bc029903941744
2013-08-15 20:23:07 +09:00
Satoshi Kataoka
623e3f9d58 Merge "Fix cosmetic source code formatting" 2013-08-15 11:20:41 +00:00
Tadashi G. Takaoka
840e42d7f3 Merge "Add getters and copy constructor to Key class" 2013-08-15 11:15:42 +00:00
Tadashi G. Takaoka
25f0d73fa4 Fix cosmetic source code formatting
Change-Id: I33c14a20bc55b826082e468c0aecfa026ba5d9f3
2013-08-15 20:13:31 +09:00
Tadashi G. Takaoka
7dc60f9db7 Add getters and copy constructor to Key class
Change-Id: I78eb96dcc26378926dc63acbfeb4828cbd44435d
2013-08-15 20:12:46 +09:00
Jean Chalard
e7870a2c0d Add an initial JNI interface to dicttool.
Bug: 10100269
Change-Id: I883992c2033e7d9e7c754c0bf653767728b221b6
2013-08-15 17:58:55 +09:00
Ken Wakasa
dc83fe37ba Merge "Revert "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils."" 2013-08-15 08:56:28 +00:00
Ken Wakasa
117f18e844 Revert "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils."
This reverts commit 4c63d0614e.

Change-Id: I1fa277d720bab4d895259df7d6d82eebfa5eb6c5
2013-08-15 08:54:29 +00:00
Ken Wakasa
f74ddfbb06 Merge "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils." 2013-08-15 06:53:23 +00:00
Yuichiro Hanada
4c63d0614e [Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils.
Change-Id: I0d476abe763c11ba9005152f928e8dccf15ac9de
2013-08-15 15:46:58 +09:00
Satoshi Kataoka
a38a15ddc0 Merge "tiny refactor" 2013-08-15 06:38:49 +00:00
Satoshi Kataoka
1aae34873c tiny refactor
Change-Id: I776432b6c41cf8dee71fbd1565a6f3da9d762f9e
2013-08-15 13:38:05 +09:00
Yuichiro Hanada
1db93c9c04 [Refactor] Move some helper methods to BinaryDictIOUtils.
Change-Id: Ib817a975dc1f82241f732b236c44b042fda25b3c
2013-08-15 10:49:40 +09:00
Satoshi Kataoka
be4d38e61f Merge "Fix test breakage" 2013-08-14 11:40:34 +00:00
Satoshi Kataoka
2b39fab829 Fix test breakage
Change-Id: I10bd8fcc68711a039e000f715d7a65ae42095965
2013-08-14 20:38:32 +09:00
Satoshi Kataoka
5654a1f21e Merge "Fix a debug functionality for the personalization prediction" 2013-08-14 10:43:31 +00:00
Ken Wakasa
8e398e2147 Merge "Move some methods in BinaryDictIOUtils to DynamicBinaryDictIOUtils." 2013-08-14 10:38:15 +00:00
Satoshi Kataoka
d09ad2e368 Fix a debug functionality for the personalization prediction
Bug: 9429906

Change-Id: I10d39e1f8758dcb64c9c0111d516e3abfe81b04e
2013-08-14 19:36:20 +09:00
Yuichiro Hanada
3edb62c69b Move some methods in BinaryDictIOUtils to DynamicBinaryDictIOUtils.
Change-Id: I9ba55582c533fef0eb3e60c46bf23c8b16ee1ff4
2013-08-14 19:33:36 +09:00
Satoshi Kataoka
92038bcacd Merge "Add a method to import one bigram and string utilities" 2013-08-14 10:29:06 +00:00
Ken Wakasa
f795f2b789 Merge "Add FusionDictionaryBufferFromWritableByteBufferFactory." 2013-08-14 10:26:21 +00:00
Ken Wakasa
0766f13391 Merge "Move some constants in BinaryDictInputOutput to FormatSpec." 2013-08-14 10:25:04 +00:00
Yuichiro Hanada
665592774c Move some constants in BinaryDictInputOutput to FormatSpec.
Change-Id: I6b12faf35b65238b9a64c82d4d1a6050f980e72e
2013-08-14 19:19:27 +09:00
Tadashi G. Takaoka
bdef628a35 Merge "Add empty key background type" 2013-08-14 10:13:33 +00:00
Tadashi G. Takaoka
ed5582ec65 Merge "Thin out audio and haptic feedback while key repeat" 2013-08-14 10:11:43 +00:00
Satoshi Kataoka
4ee953125a Add a method to import one bigram and string utilities
Bug: 9429906
Change-Id: I73bbf65985196d62470552c576bb076a7cb95008
2013-08-14 18:56:12 +09:00
Jean Chalard
5fd8b7ebd5 Merge "Add looksValidForDictionaryInsertion" 2013-08-14 09:41:49 +00:00
Jean Chalard
af5fbe70ac Add looksValidForDictionaryInsertion
...and test it.

Also at the same time, add a facility to create a SettingsValues for
test, and some minor performance improvement to surrounding
methods.

Change-Id: I13b629ae14755c244af2a9406a7e9b4a4a16090f
2013-08-14 18:39:28 +09:00
Tadashi G. Takaoka
ab16237e69 Thin out audio and haptic feedback while key repeat
Bug: 6522943
Change-Id: Id60f256ab0f8741578eda276116817fa48917325
2013-08-14 18:37:58 +09:00
Jean Chalard
fdfc8ad2d0 Merge "Re-evaluate auto-caps earlier." 2013-08-14 09:29:48 +00:00
Tadashi G. Takaoka
e18439d5c7 Add empty key background type
Change-Id: I9b07c58a9b70ae0228f87e1f066ca8cd959b4f03
2013-08-14 18:12:11 +09:00
Jean Chalard
4bc74d19ef Merge "Delete surrogate together." 2013-08-14 09:06:07 +00:00
Jean Chalard
b2d954cad6 Delete surrogate together.
Stop deleting them one after the other, it makes no sense. We
can know in advance if we should delete two of them, so let's
use that.

Bug: 6526420
Change-Id: Ifa2263cbde8fedc78bb750b84d4acd3f979774ea
2013-08-14 17:53:33 +09:00
Jean Chalard
b7e782d868 Re-evaluate auto-caps earlier.
We have all we know to re-evaluate auto-caps in this case.
We don't need to wait until we get the callback from TextView.

Bug: 10287972
Change-Id: I87e4e26cd193a001f91fe852ffc5a8f728db2449
2013-08-14 17:40:23 +09:00
Jean Chalard
1162c0537d Merge "Remove dead code" 2013-08-14 08:35:46 +00:00
Yuichiro Hanada
bbc8a930f7 Add FusionDictionaryBufferFromWritableByteBufferFactory.
Change-Id: I23de0a178e7f11f2cf301fd433cde60c6152055b
2013-08-14 17:07:44 +09:00
Jean Chalard
d81b9d0276 Remove dead code
isComposingWord() is actually defined as size > 0, so this test
can never be false.

Change-Id: If71afae6f0b16bff46178f0fae3244597354fecb
2013-08-14 16:38:37 +09:00
Jean Chalard
e18fdf804a Merge "Fix a bug with surrogate pairs" 2013-08-14 07:27:54 +00:00
Jean Chalard
a74ae9c451 Fix a bug with surrogate pairs
Bug: 10316781
Change-Id: I528c59c8823cda11975cb01b0ae59f12cfadef3b
2013-08-14 16:00:28 +09:00
Ken Wakasa
ae59ce0262 Merge "Remove audio and haptic feedback while key repeating" 2013-08-13 21:50:20 +00:00
Ken Wakasa
f27297d2ec Merge "Add BinaryDictReader." 2013-08-13 11:03:44 +00:00
Yuichiro Hanada
3feacba1eb Add BinaryDictReader.
Bug: 9618601

Change-Id: Ief07fa0c3c4f7f5999a3fafcef4e47b6b6fd8143
2013-08-13 19:55:05 +09:00
Tadashi G. Takaoka
d03e5bd761 Merge "Rename maketext tool to make-keyboard-text" 2013-08-13 08:49:56 +00:00
Ken Wakasa
7242bf1a15 Merge "Make readHeader check the header size before using it." 2013-08-13 08:14:43 +00:00
Yuichiro Hanada
b7bb9c9722 Make readHeader check the header size before using it.
Change-Id: I5dc3e2b674f7343ef57317fde6bdb7349a7fe04c
2013-08-13 17:06:25 +09:00
Tadashi G. Takaoka
d1d607287d Remove audio and haptic feedback while key repeating
Bug: 6522943
Change-Id: Iad1b11172e47bfbae2b4129361a56b9d793f8f62
2013-08-13 17:03:26 +09:00
Tadashi G. Takaoka
ca6acfdd6b Rename maketext tool to make-keyboard-text
Change-Id: Icceda22aec75f9e3602da8775c0e94b110283575
2013-08-13 15:33:14 +09:00
Tadashi G. Takaoka
0adc8a2ad3 Merge "Fix parenthesis direction for RTL languages" 2013-08-13 06:22:12 +00:00
Satoshi Kataoka
46961247a6 Merge "Call onDictionaryReady" 2013-08-13 05:40:21 +00:00
Tadashi G. Takaoka
d41c44498c Fix parenthesis direction for RTL languages
Bug: 10284912
Change-Id: Ie0fc09b101034482a775961c8f8f1fcdf6dbec8f
2013-08-13 12:23:25 +09:00
Satoshi Kataoka
310f8a0f06 Call onDictionaryReady
Bug: 9429906

Change-Id: Ifc538b38b7d37469aecccd32a7e3f95a90558be7
2013-08-13 11:41:48 +09:00
Tadashi G. Takaoka
bab69d09f9 Merge "Remove redundant EditorInfo member from KeyboardLayoutSet.Builder" 2013-08-12 08:25:46 +00:00
Satoshi Kataoka
1b7c1cd513 Merge "Add PersionalizationDictionaryRegister" 2013-08-12 06:23:12 +00:00
Satoshi Kataoka
8c4fcb108f Add PersionalizationDictionaryRegister
Bug: 9429906
Change-Id: Ibd4d5cedb371c0b4ee1342a3e6d221c9e34c2402
2013-08-12 14:48:45 +09:00
Tadashi G. Takaoka
7215e06e60 Remove redundant EditorInfo member from KeyboardLayoutSet.Builder
Change-Id: I9bbba9c27d3d478421c094e6cd0e1da31fd4f4c8
2013-08-12 14:35:58 +09:00
Ken Wakasa
66a63db2d5 Merge "Rationalize how to use AdditionalFeaturesSettingUtils" 2013-08-12 01:36:46 +00:00
Ken Wakasa
4a2f6a2216 am 25402fd5: am 724db044: Deallocate gesture trail bitmap when unneeded further
* commit '25402fd5309891884a843528d47f6b4646341a3f':
  Deallocate gesture trail bitmap when unneeded further
2013-08-09 15:53:29 -07:00
Ken Wakasa
02938c6baf Rationalize how to use AdditionalFeaturesSettingUtils
It should be called regardless of the gesture input being enabled or not

Change-Id: I223a823ef18389227fc04d000cc7bf750797ba31
2013-08-10 00:32:07 +09:00
Ken Wakasa
724db04495 Deallocate gesture trail bitmap when unneeded further
Follow up to I5bc980c4dc41bc304be3c190934c1f7c55c9d244

bug: 8967766
Change-Id: I7b916daa5269cfde359a77555e8ffadf0e4a8f92
2013-08-09 21:07:40 +09:00
Tadashi G. Takaoka
2dfcfc5013 Remove key preview backing view
This change re-origanizes view hierarchy of IME's input view.

Change-Id: I9d0a07692d0f41de3345d207366393bcd5424f7e
2013-08-09 20:25:42 +09:00
Ken Wakasa
cfcf6660fc Reinstate a call to UsabilityStudyLogUtils#writeChar()
The usability study mode has been broken.

bug: 10251399
Change-Id: Iaa301241f102f412fa073f0d8b897a4c8b265a9c
2013-08-09 19:32:02 +09:00
Yuichiro Hanada
7ec9db2c34 Remove the code and comments about version 1 format.
Change-Id: I827052f234eeaa4dbcfd37da69a99866896a158b
2013-08-09 16:05:07 +09:00
Tadashi G. Takaoka
6ca0b371de Merge "Small clean up of KeyboardView.onMeasure" 2013-08-09 03:00:13 +00:00
Tadashi G. Takaoka
4f1fdc30be Small clean up of KeyboardView.onMeasure
Change-Id: I46830f8482b46c6999b80793c8b4ae860b46e429
2013-08-08 19:15:13 +09:00
Satoshi Kataoka
5c057b3241 Merge "Fix unit tests." 2013-08-08 10:14:27 +00:00
Yuichiro Hanada
7d1ae52ded Fix unit tests.
Change-Id: Ic0013089625e112aaccc888d462330640ef7cc6f
2013-08-08 19:12:35 +09:00
Tadashi G. Takaoka
96b444d429 Merge "Remove processMotionEvent from MoreKeysKeyboardView" 2013-08-08 08:23:23 +00:00
Satoshi Kataoka
1181c5acbc Merge "Fix to follow the field naming conventions." 2013-08-08 08:06:45 +00:00
Tadashi G. Takaoka
33482a9b9c Remove processMotionEvent from MoreKeysKeyboardView
Change-Id: I5373df4a7c82f964f99acf70325bba8702111a75
2013-08-08 15:30:09 +09:00
Keisuke Kuroyanagi
b6d48c4c0b Make user and contacts dict use ver3 format.
Bug: 6669677
Change-Id: I6a20eed2c8afdd1c16ada5bf85067864c7cd2a7f
2013-08-08 14:57:19 +09:00
Yuichiro Hanada
71ffcc6332 Fix to follow the field naming conventions.
Change-Id: I9b41b5f34e93a3f291a352cd85c5ac257beaa9ab
2013-08-08 12:03:36 +09:00
Jean Chalard
4456d1a8c1 Merge "Have double-space-to-period cancel leave a single space" 2013-08-08 02:52:24 +00:00
Jean Chalard
522d13c302 Have double-space-to-period cancel leave a single space
Bug: 8911898
Change-Id: Ifb4bb63c14dc960d0a53f1511908830093cca012
2013-08-08 11:49:27 +09:00
Tadashi G. Takaoka
083a40b291 Merge "Move createKeyboardSetForSpellChecker to AndroidSpellCheckService" 2013-08-07 10:32:56 +00:00
Tadashi G. Takaoka
15b80c4ec2 Merge "Add ResouceUtils.getDefaultKeyboardHeight" 2013-08-07 10:32:30 +00:00
Tadashi G. Takaoka
204e7b1401 Move createKeyboardSetForSpellChecker to AndroidSpellCheckService
Change-Id: I4a9065e703e98ffed50f2a6d76ace938dfc26ddf
2013-08-07 19:24:22 +09:00
Tadashi G. Takaoka
3897a43940 Add ResouceUtils.getDefaultKeyboardHeight
Change-Id: I377f6a83ec86b0345b170e7ad995d4577220d0ad
2013-08-07 19:23:31 +09:00
Tadashi G. Takaoka
2cb9a1434e Merge "Make key label from supplementary code point" 2013-08-07 09:59:41 +00:00
Tadashi G. Takaoka
45d0205862 Make key label from supplementary code point
Change-Id: I0a7834b5c4908a2116a8772cf85985ab8bed7091
2013-08-07 18:34:20 +09:00
Satoshi Kataoka
c05b3b56cc Merge "Add a session for the personalization dictionary" 2013-08-07 08:45:19 +00:00
Satoshi Kataoka
80aa7197b4 Add a session for the personalization dictionary
Bug: 9429906
Bug: 4192129

Change-Id: I361ab380edeee5a8a8b364df3f9f4ab202b79105
2013-08-07 16:44:30 +09:00
Tadashi G. Takaoka
15c42454c0 Remove orientation member from KeyboardId
Change-Id: I2c16134a24088dbc30b74ae7c5bc578a9d84a960
2013-08-07 16:32:54 +09:00
Jean Chalard
0f47d5163d Merge "Reword "No language"" 2013-08-06 11:11:21 +00:00
Tadashi G. Takaoka
8ba8798290 Merge "Consolidate forwardTouchEvent with dispatchTouchEvent" 2013-08-06 06:38:33 +00:00
Tadashi G. Takaoka
cc38bfb5d3 Merge "Add emoji icon and code as a groundwork" 2013-08-06 05:35:14 +00:00
Tadashi G. Takaoka
b127d88285 Add emoji icon and code as a groundwork
The emoji switching key icon asset should be updated. The icons in
this change are just borrowed from Hangout.

Bug: 10179862
Bug: 6370846
Change-Id: Icea26d2cf2ac6a6df9beb4c98f646dbe309bdcd9
2013-08-06 14:16:15 +09:00
Tadashi G. Takaoka
88f840d2a2 Consolidate forwardTouchEvent with dispatchTouchEvent
Change-Id: Ib73962acff72be0a78a3565028572ad694fb8501
2013-08-06 11:04:51 +09:00
Tadashi G. Takaoka
52d220e71b Remove unnecessary suggestion strip container
Change-Id: I3710e1fe1574c0f69f7f448619e939fb45e9b8d3
2013-08-06 10:57:47 +09:00
Tadashi G. Takaoka
2023975988 Merge "Small optimization for readability" 2013-08-06 00:04:35 +00:00
Tadashi G. Takaoka
f8d162c315 Merge "Fix keyboard caching bug for testing" 2013-08-06 00:03:59 +00:00
Tadashi G. Takaoka
c0a732f032 Remove CODE_RESEARCH
Instead of CODE_RESEARCH, special outputText ".research." is used to
invoke a research feedback dialog.

Change-Id: Ic95c956ab4f2b5f0c3f2205c9bbcdcfb67db5d6e
2013-08-05 19:05:07 +09:00
Tadashi G. Takaoka
28a148681e Small cleanup
Change-Id: I7dce7373b371f1ed5a985815f5d43fb6c6ee1f84
2013-08-05 18:46:35 +09:00
Jean Chalard
c5beb522ed Reword "No language"
Bug: 10064334
Change-Id: Ie4e6c333566eee9000fa5c8e59e9df8b9b56a5b3
2013-08-05 18:16:35 +09:00
Tadashi G. Takaoka
0016d51ab8 Small optimization for readability
Change-Id: I8a24fc0981e58a7dc30f0577c4415a1d3bc5ed4d
2013-08-05 17:36:28 +09:00
Tadashi G. Takaoka
95f9b95dfb Fix keyboard caching bug for testing
Change-Id: I00584a68d868f38c065bb6a41e8e5f4eafd44e7f
2013-08-05 17:35:08 +09:00
Satoshi Kataoka
33592d1bee Merge "Add a debug preference for using only personalization dictionary" 2013-08-02 11:30:20 +00:00
Jean Chalard
ba2f4f84ca Merge "Fix a concurrency bug." 2013-08-02 11:28:45 +00:00
Jean Chalard
10d66669c7 Fix a concurrency bug.
This probably only ever happens in tests, but still, that's
the right thing to do.

Bug: 10139031
Change-Id: I259be9e7306162e19faf738a093a77762f2e7675
2013-08-02 20:26:37 +09:00
Ken Wakasa
6333ed3801 Small cleanup
Change-Id: I7a35eb4cb7cee4c120236a2bc1974d7b345f4188
2013-08-02 20:22:51 +09:00
Satoshi Kataoka
d7491e6e81 Add a debug preference for using only personalization dictionary
Bug: 9429906
Change-Id: I2003060c7065e736d42f3b3303fbba549358dd18
2013-08-02 20:10:57 +09:00
Ken Wakasa
52876bbefd Remove unnecessary setLayerType() calls
Calling up setLayerType(LAYER_TYPE_HARDWARE, ..) on non-HW accelerated
devices was ending up with having a drawing cache in View that is not
quite needed for PreviewPlacerView.

bug: 8967766

Change-Id: Ic8e6eeaf536530ff5f23eb353b0a8e5ba96fa0e2
2013-08-02 19:30:05 +09:00
Ken Wakasa
82018f9972 Forgot to reset the matrix of offscreen canvas
Follow up to I5bc980c4dc41bc304be3c190934c1f7c55c9d244

bug: 8967766
Change-Id: I37c2e8e70ff4966ca5e4f29e5cac8349d8fe73b6
2013-08-02 18:51:57 +09:00
Tadashi G. Takaoka
e08c418ff8 Move motion event dispatcher to PointerTracker
Change-Id: I967bf4629b7d1002be6aff6007dc03d2db05c562
2013-08-02 16:34:44 +09:00
Ken Wakasa
ed56ea86d0 Merge "Deallocate offscreen buffer for non-HW-accel draw" 2013-08-01 09:29:24 +00:00
Tadashi G. Takaoka
54dd1bed52 Clean up ResearchLogger log method
Change-Id: I06c30aab462ce5b17157ff71d5d76f9755178080
2013-08-01 18:25:34 +09:00
Tadashi G. Takaoka
b6cc3a85ab Move non-distinct multitouch support to a separate class
Move code that support non-distinct multitouch screen device to the
NonDistinchMultitouchHelper class.

Change-Id: I2e44f782b83dbcd095ee8e51c36b0766da0cd457
2013-08-01 18:18:33 +09:00
Ken Wakasa
e68d565d0f Deallocate offscreen buffer for non-HW-accel draw
Follow up to I5bc980c4dc41bc304be3c190934c1f7c55c9d244

This frees up 800KB on occam_svelte when LatinIME is in background.
Confirmed the performance effect in keyboard-bring up speed was unperceivable.

bug: 8967766
Change-Id: I0fab179c61179564bd3a0349c9825e7d61f7e1f2
2013-08-01 18:01:48 +09:00
Tadashi G. Takaoka
a299421f67 Merge "Remove getTimer() reference except from PointerTracker" 2013-08-01 07:53:45 +00:00
Satoshi Kataoka
503b79029a Merge "Connect the personalization dictionary" 2013-08-01 07:36:17 +00:00
Satoshi Kataoka
60586b57cf Connect the personalization dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I9c9f3ed7699f74339ad92be6dcddb8a52c377545
2013-08-01 16:33:20 +09:00
Tadashi G. Takaoka
5433ce64c0 Remove getTimer() reference except from PointerTracker
Change-Id: I142eb5b61b932e60452b9b3514d6ddca3d21ec9d
2013-08-01 16:22:53 +09:00
Tadashi G. Takaoka
8126e79e08 Move key repeat function to PointerTracker
Change-Id: I26e553692faf48e30e9c43c71fac6980b8432111
2013-08-01 15:45:58 +09:00
Tadashi G. Takaoka
552a4b84f8 Merge "Add UsabilityStudyLogUtils.writeMotionEvent" 2013-07-31 14:21:04 +00:00
Satoshi Kataoka
567e7f05c1 Add the personalization prediction dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I0663de025405b2c92eebd528339b82baec97e2ce
2013-07-31 21:37:33 +09:00
Satoshi Kataoka
853d0fd122 Refactor the personalization dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I9f094bc5a6ce4652e310e090f1536e43f1f24ad1
2013-07-31 21:15:13 +09:00
Ken Wakasa
883bd364eb Merge "Deallocate gesture trail bitmap when unneeded" 2013-07-31 11:46:25 +00:00
Ken Wakasa
c8814e20b7 Deallocate gesture trail bitmap when unneeded
This frees up 1.7MB on Nexus 4 (occam), and 900KB on occam_svelte while
LatinIME goes to background.
The keyboard bring-up speed feels acceptable on both devices.

bug: 8967766
Change-Id: I5bc980c4dc41bc304be3c190934c1f7c55c9d244
2013-07-31 20:39:32 +09:00
Satoshi Kataoka
3b1eb88658 Merge "Refactor the user history dictionary" 2013-07-31 10:37:31 +00:00
Satoshi Kataoka
1439130442 Refactor the user history dictionary
Bug: 9429906
Bug: 4192129

Change-Id: If53bc3220627802d82ab7c396d0aabdb658573fa
2013-07-31 19:22:11 +09:00
Tadashi G. Takaoka
30977a151e Add UsabilityStudyLogUtils.writeMotionEvent
Change-Id: I41ee6d1879dc937e1554fedfc603d9bb5bec40f2
2013-07-31 19:05:14 +09:00
Jean Chalard
2d7e927354 Fix inconsistencies with mSuggest.
This should fix some NPEs, but they are so unlikely that we never
see them.

Bug: 10065412
Change-Id: I2aefea1f52024405cc3fda9106fea41a02aaf4d8
2013-07-31 18:59:18 +09:00
Satoshi Kataoka
acb3cc7473 Merge "Refactor on the user history dictionary" 2013-07-31 09:20:06 +00:00
Tadashi G. Takaoka
310ea9ab90 Remove sudden jump touch event hack
This hack was for Nexus One and Droid that can't run on ICS or later.

Change-Id: I1f9cef2022b0bbb333235e6b7c311c9785a1d894
2013-07-31 17:32:41 +09:00
Tadashi G. Takaoka
3b5c05f18c Merge "Fix Catalan keyboard layout" 2013-07-31 08:01:51 +00:00
Tadashi G. Takaoka
fea0862cf6 Merge "Fix missing Azerbaijani text resource" 2013-07-31 07:58:15 +00:00
Tadashi G. Takaoka
087c8a84a5 Fix Catalan keyboard layout
Bug: 10098472
Change-Id: I60e4aa6716f8166ca60ab5687b0faf2d84cd846b
2013-07-31 16:56:34 +09:00
Tadashi G. Takaoka
d4a6869d38 Fix missing Azerbaijani text resource
Though Azerbaijani subtype is disabled temporary by Ib8a38f85f4.

Change-Id: I887cf3508bd2945016c506eae1969778ba4582d3
2013-07-31 16:54:46 +09:00
Satoshi Kataoka
87d06afc66 Refactor on the user history dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I1a2bfe96e18119d30a72290aa48746f77a021018
2013-07-31 16:48:55 +09:00
Jean Chalard
8d46ea9156 Merge "Fix some warnings" 2013-07-31 07:38:49 +00:00
Jean Chalard
7d654d8cae Merge "Fix inconsistency with mutable settings." 2013-07-31 07:38:22 +00:00
Tadashi G. Takaoka
536e0c79cc Merge "Clean up PointerTracker a bit" 2013-07-31 07:36:27 +00:00
Jean Chalard
561c447404 Merge "Fix a problem where settings were not renewed correctly." 2013-07-31 07:17:49 +00:00
Jean Chalard
93445b4821 Fix some warnings
Change-Id: I7290cd1fb675a1b85b9b6ac2d464c932b5bca1dd
2013-07-31 16:17:01 +09:00
Tadashi G. Takaoka
212165b0b8 Clean up PointerTracker a bit
Change-Id: If4ff87348fbc40f271c68dad255dbc42f9b26eb6
2013-07-31 14:52:18 +09:00
Jean Chalard
f8c1aefd90 Merge "Clarify the expected cursor position in RichInputConnection." 2013-07-31 04:56:35 +00:00
Jean Chalard
aa108f1d7f Clarify the expected cursor position in RichInputConnection.
Change-Id: I4d36a23567415c3a293a588b51b46006256c148f
2013-07-31 12:22:15 +09:00
Satoshi Kataoka
323a7aae6c Merge "Fix the title of the personal dictionary settings" 2013-07-30 08:17:01 +00:00
Satoshi Kataoka
8befd36c65 Fix the title of the personal dictionary settings
Bug: 8976598
Change-Id: I9e07ff9e06449e2093b9ba8d6f28a030c69756bc
2013-07-30 15:39:41 +09:00
Jean Chalard
c5c226c424 Fix inconsistency with mutable settings.
Change-Id: I0550044199273cecb6f5713aa2e43ae16319cd47
2013-07-30 14:30:24 +09:00
Jean Chalard
74bcc911ea Fix a problem where settings were not renewed correctly.
Bug: 10065412
Change-Id: Id05284f45466cd5b2697a695c3d1bdfbf3cc1f24
2013-07-30 13:22:05 +09:00
Satoshi Kataoka
ab2d273133 Merge "Fix the displayed name of the personal dictionary" 2013-07-30 04:21:58 +00:00
Satoshi Kataoka
5123427532 Fix the displayed name of the personal dictionary
Bug: 8976598
Change-Id: I11dd73c8c23b05288c5f417352dc4cc99d489b95
2013-07-30 13:14:08 +09:00
Ken Wakasa
b60e65a0cc Rename a variable for SettingsValues
Change-Id: Icb4155532ea8724791c9194e8dc75ce32b6e8b16
2013-07-29 18:53:23 +09:00
Jean Chalard
d9f0c1e020 Merge "Fix an NPE" 2013-07-29 09:46:32 +00:00
Jean Chalard
5408fec63a Fix an NPE
Also make mSuggest private for more security.

Bug: 10045657
Change-Id: I712505e4d2a2606efff5d09ba9b4c656f9e7c7a9
2013-07-29 18:09:48 +09:00
Satoshi Kataoka
fb9f448b8d Merge "Add personalization dictionary helper" 2013-07-29 05:21:14 +00:00
Satoshi Kataoka
d45e4b6e5b Add personalization dictionary helper
Bug: 9429906
Bug: 4192129

Change-Id: Ic618b0b09a54ed46b20633bd4c1c570d4ac775af
2013-07-29 12:37:27 +09:00
Jean Chalard
654b0a9c16 Merge "Small optimization" 2013-07-26 11:30:50 +00:00
Jean Chalard
e7903101ea Merge "Use cached data for getTextBeforeCursor." 2013-07-26 11:25:59 +00:00
Jean Chalard
0a064a5d88 Small optimization
Bug: 8864306
Change-Id: Ic8eecd64eff6a1150a90b9f5ec9ebbc5f1d2a6a9
2013-07-26 20:17:55 +09:00
Jean Chalard
8c6537edbd Use cached data for getTextBeforeCursor.
Bug: 8864306
Change-Id: Ia146f711f1de4336d7e3363208ab92eba856f5e1
2013-07-26 20:17:52 +09:00
Satoshi Kataoka
2a8c75fc43 Merge "Add a place holder of the personalization dictionary" 2013-07-26 08:44:26 +00:00
Satoshi Kataoka
5c15b8f442 Add a place holder of the personalization dictionary
Bug: 9429906
Bug: 4192129

Change-Id: Ieacd0559e0bf286c5933e9dba716289303f533d6
2013-07-26 16:03:04 +09:00
Jean Chalard
38e9802690 Merge "Revert "Very simple refactoring"" 2013-07-26 06:58:44 +00:00
Jean Chalard
c6a07e16a5 Revert "Very simple refactoring"
This reverts commit f712dc9a4f.
It turns out this refactoring is not useful after all.

Change-Id: I0145c907b3cc5ac9a30a59abcd719cb546c9bd3a
2013-07-26 06:46:56 +00:00
Jean Chalard
0dd23544ff Merge "Very simple refactoring" 2013-07-26 05:30:47 +00:00
Satoshi Kataoka
ffcbbaf127 Refactor on UserHistoryDictionary
Bug: 9429906
Change-Id: I576a91643bdaf5017cc826ac2e07a74a9a275d60
2013-07-26 13:00:19 +09:00
Jean Chalard
f712dc9a4f Very simple refactoring
Bug: 8864306
Change-Id: I5c9b118cb6a8eb59efc52d5534b10fcab93182d6
2013-07-26 12:57:12 +09:00
Tadashi G. Takaoka
c34933828e Merge "Cancel all ongoing event when onFinishInputView" 2013-07-25 11:08:08 +00:00
Tadashi G. Takaoka
5c095e59f6 Cancel all ongoing event when onFinishInputView
Bug: 9334755
Change-Id: If0c2ac49a50f4a529aefeca603569f9413367469
2013-07-25 20:05:39 +09:00
Tadashi G. Takaoka
21c6d23dcd Merge "Add MoreKeysPanel argument to Controller methods" 2013-07-25 11:00:25 +00:00
Tadashi G. Takaoka
0e08d70fe5 Add MoreKeysPanel argument to Controller methods
Bug: 9334755
Change-Id: I5a7104f4c98982f11fb4e060fa83c21bfc360558
2013-07-25 19:53:05 +09:00
Tadashi G. Takaoka
15c41a61ad Merge "Remove boolean return value of dismissing more keys panel" 2013-07-25 10:45:05 +00:00
Tadashi G. Takaoka
09e4530ca7 Remove boolean return value of dismissing more keys panel
Bug: 9334755
Change-Id: Ic29ab69cfbf9007e98fe67695f1854b4876eb976
2013-07-25 17:51:48 +09:00
Jean Chalard
e408bbb5bf Merge "Fix a bug with multiple word insertion." 2013-07-25 08:34:41 +00:00
Jean Chalard
23a3fd5bfa Fix a bug with multiple word insertion.
This is a port of I5202bc52

Bug: 7903831
Change-Id: I3eb526de01a1f5b51212166e39b98de1d71e9eaf
2013-07-25 16:33:13 +09:00
Tadashi G. Takaoka
058f37f8ba Merge "Cosmetic code optimization" 2013-07-25 07:29:02 +00:00
Tadashi G. Takaoka
5b696d8336 Cosmetic code optimization
Change-Id: If20c1936c8d5f23f0b86d02f21f4ff8a6444244c
2013-07-25 15:44:43 +09:00
Satoshi Kataoka
5563dc3ad5 Show all languages if user enables multiple subtypes
Bug: 8976598
Change-Id: I1c3c1ede1235f696eafb3a68ec5c29479768dd0f
2013-07-25 15:15:39 +09:00
Jean Chalard
289df0ecad Merge "[FD4] Separate cached address before/after update for groups" 2013-07-25 03:03:09 +00:00
Tadashi G. Takaoka
cecb63c2c9 Merge "Make RunInLocale as top-level class" 2013-07-24 13:34:52 +00:00
Tadashi G. Takaoka
9ef59af7ce Merge "Move subtype related utility class to utils package" 2013-07-24 13:34:35 +00:00
Jean Chalard
25de86a6a2 [FD4] Separate cached address before/after update for groups
This should fix bug#8526576 for good.

Bug: 8526576
Change-Id: I473aad26b69d64efa09d2ec9d8e69f29f5cf4819
2013-07-24 18:40:14 +09:00
Jean Chalard
429db8d61e [FD3] Split stackNodes into two methods.
In the future we need to have a method that computes only
from the size, as we used to have, to initialize the cached
addresses, and a much simpler and faster method to copy
the cached sizes.

Bug: 8526576
Change-Id: I6a5a790303ab8f3bf957c7ca266eb12da7c1ad9e
2013-07-24 17:26:16 +09:00
Tadashi G. Takaoka
0c3a9b549c Make RunInLocale as top-level class
Change-Id: I07ed606b7aba098a5be85533e5baff300b21fb44
2013-07-24 16:00:25 +09:00
Tadashi G. Takaoka
a410cb48ea Move subtype related utility class to utils package
Change-Id: I3564796531ea85f2ebafde40cd822b806b8741df
2013-07-24 15:52:43 +09:00
Jean Chalard
5526d138fe Merge "[FD2] Separate cached address before/after update for nodes." 2013-07-24 01:56:02 +00:00
Ken Wakasa
b9eb32679f Cosmetic fix for the copyright header
Change-Id: I2a93ac21571d1f6255a72a1a238b03dbb95108de
2013-07-23 19:39:03 +09:00
Ken Wakasa
db341afc65 Fix wrong copyright header comment
Change-Id: I75ffbc0508c00f7ac8004b764667a174b6ab0b63
2013-07-23 19:26:05 +09:00
Jean Chalard
91cbe3566d [FD2] Separate cached address before/after update for nodes.
Bug: 8526576
Change-Id: Ib9f8594a9e12dc75eba296faff2612c4bd7483d3
2013-07-23 17:52:54 +09:00
Tadashi G. Takaoka
e6c5184742 Fix NPE in SubtypeLocale.getSubtypeDisplayName
This change moves the methods that create the subtype display name for
spacebar from MainKeyboardView to SubtypeLocale class, and
consolidates SpacebarTextTests with SubtypeLocaleTests.

Bug: 9962955
Change-Id: Ifa0a08ff80bc30753a213c2feb471599ca63fa66
2013-07-23 13:00:04 +09:00
Jean Chalard
1676b8387f Merge "Fix a bug when moving the pointer in a > 48 chars word" 2013-07-22 08:04:43 +00:00
Jean Chalard
5fa2202e36 Fix a bug when moving the pointer in a > 48 chars word
Bug: 9892261
Change-Id: I9db20c5b20a0764bd9f5b5e2bdc98180bbb9ec15
2013-07-22 17:02:09 +09:00
Ken Wakasa
a7d2fc6bef Move settings related classes to "settings"
Change-Id: Id170dbfe2dcfc93130b7be4a84615940403ec37f
2013-07-22 16:35:44 +09:00
Tadashi G. Takaoka
dc7111013f Merge "Fix IllegalArgumentException in MoreKeysKeyboard" 2013-07-19 06:44:54 +00:00
Tadashi G. Takaoka
b0e76724ed Fix IllegalArgumentException in MoreKeysKeyboard
It seems that MainKeyboardView.getMeasuredWidth() returns weird
value. Using KeyboardId.mWidth as main keyboard width may resolve the
issue.

Bug: 9684622
Change-Id: I975bfb934b8d2448e72555a3ccae0123341186b9
2013-07-19 11:43:50 +09:00
Ken Wakasa
b03447e1af Move a couple classes to the utils package
Change-Id: Ia14a2011d79bad7cd02697b9254705f6e2099442
2013-07-19 10:46:46 +09:00
Tadashi G. Takaoka
03a76a07e2 Merge "Restrict bogus events hack to certain classes of tablets" 2013-07-18 08:40:44 +00:00
Tadashi G. Takaoka
536438a45e Restrict bogus events hack to certain classes of tablets
Bug: 9061320
Change-Id: Ib8c6a5e6db5da99c447bc00867fed51ca959cc3a
2013-07-18 15:49:11 +09:00
Jean Chalard
257750d988 [FD1] Move parents' address computation outside
There is no need to do it repeatedly in this loop: it's
clearer and faster to do it at the end only.

Bug: 8526576
Change-Id: I707571179c89479830891ec6d4fd06a9fffed7c1
2013-07-17 20:47:53 +09:00
Tadashi G. Takaoka
6455172a70 Distinguish key press in repeat key
Bug: 9859367
Change-Id: Iad643f9785b193e1918a8363de4fefc3b7558bdf
2013-07-16 19:21:16 +09:00
Jean Chalard
2bc980ee28 Merge "Serialize commands sent to a separate threads" 2013-07-16 07:21:07 +00:00
Jean Chalard
6a7a569831 Serialize commands sent to a separate threads
Bug: 9715797
Change-Id: I1eda4d2f0056f70cfb8a92d658e0875706efc170
2013-07-16 15:54:39 +09:00
Jean Chalard
988a1f3132 Merge "Fix a bug with bad view reuse." 2013-07-16 05:43:15 +00:00
Jean Chalard
4d4310df75 Merge "Fix a wrong call to cancel downloads" 2013-07-16 05:40:16 +00:00
Jean Chalard
6912342a48 Fix a bug with bad view reuse.
There are many ways to fix this problem but this is the most
direct way. Removing a view from the cache when any animation
is started will ensure it won't be used again, and will be garbage
collected when it's possible. Since views are created on demand
anyway, a new one will just get created when needed, and that's
it.

Bug: 9400128
Change-Id: I4945d2859d642e79694d51ae90cf4f5bde9a5f1d
2013-07-16 14:12:55 +09:00
Keisuke Kuroynagi
4944827e0f Merge "Add methods for dynamic updating binary dictionary." 2013-07-16 02:45:01 +00:00
Kurt Partridge
8bfd57820f Merge "Do not output string-encoded MotionEvent." 2013-07-15 17:36:56 +00:00
Jean Chalard
faa729c47c Fix a wrong call to cancel downloads
This resulted in downloads not being correctly canceled.

Bug: 9715797
Change-Id: I786d869977df225f85cb69ec7ea9c96b039258fe
2013-07-11 17:15:45 +09:00
Keisuke Kuroynagi
cfbb7fbd48 Fix: Read lock is wrongly used for gutSuggestions.
Bug: 9737865

Change-Id: I017f80b46c5dc48c40f2de7c4d516a042992feb4
2013-07-09 08:40:43 +00:00
Ken Wakasa
58b2a6372f Merge "Update ExpandableDictionary.BASE_CHARS[]" 2013-07-08 03:22:15 +00:00
Ken Wakasa
d0ca62678d Update ExpandableDictionary.BASE_CHARS[]
This should be the same as CharUtils::BASE_CHARS[] in the native code.

Change-Id: I72ed4a43fd5c26a4439ef791b6b1cf703845c3a1
2013-07-05 20:29:21 +09:00
Tadashi G. Takaoka
ccf4a31027 Move TypefaceUtils and ViewUtils to utils package
Change-Id: Iccd47c27670248c43de9a539c1951111d7733111
2013-07-05 19:24:59 +09:00
Tadashi G. Takaoka
4be6198cb7 Reorganize Utils class
Change-Id: I7294d1547def5dcfcae9d1d53b277cb3cc9f2d18
2013-07-05 19:24:40 +09:00
Tadashi G. Takaoka
72c2feb573 Use TimeUnit instead of DateUtils for readability
Bug: 9550800
Change-Id: I087205530a5dbcff4bf08f48f4aa7068aae93215
2013-07-05 17:57:01 +09:00
Jean Chalard
cb13d11c0a Add a trace.
Emit a trace when a new dictionary is copied to LatinIME
successfully, not just when it fails. That will help diagnosing
some problems by being able to ensure this step succeeded
looking at the log.
This does not happen often (like, maybe 3 times at device
activation, and once every few weeks afterwards), so I think
the extra line in the log is more than acceptable.

Change-Id: I1674bc22d950a7be801076c5aa7e8bbebccab14b
2013-07-05 12:44:47 +09:00
Keisuke Kuroynagi
49910a9d77 Merge "Fix: release lock in UserHistoryDictionary." 2013-07-04 15:13:09 +00:00
Keisuke Kuroynagi
65db026265 Fix: release lock in UserHistoryDictionary.
Change-Id: I050c252910c6b5b0a79cd2d52c525679f2d6091d
2013-07-04 23:12:49 +09:00
Keisuke Kuroynagi
f8d2796724 Add methods for dynamic updating binary dictionary.
Bug: 6669677
Change-Id: I7e681ceec2af712214a647630350cb20be6b0354
2013-07-04 21:17:49 +09:00
Keisuke Kuroynagi
edd1992ed3 DictionaryWriter to abstract binary dictionary writing.
UserHistoryDictionary should become to use ExpandableBinaryDictionary.

Bug: 6669677

Change-Id: I6831c7dd2d84207d1a8f51ba15d52e0a72205d0c
2013-07-04 21:06:04 +09:00
Tadashi G. Takaoka
fe202d6738 Add Azerbaijani keyboard
Bug: 7963448
Change-Id: I39c192b342278e82e30ac6ef12c6d150c817ae70
2013-07-04 14:47:33 +09:00
Tadashi G. Takaoka
0e007eaff6 Add Kazakh keyboard
Bug: 9697273
Change-Id: Ic9943569ed60d601f093181bf135e45a25399121
2013-07-04 13:10:38 +09:00
Kurt Partridge
6d7c647470 Do not output string-encoded MotionEvent.
JsonUtils knows how to output MotionEvents into json; that mechanism
should be reused for SuddenJumpingTouchEventHandler.

Change-Id: Id4c36c05533a3a329bf43ba33d57c0830dc4d196
2013-07-03 10:13:59 -07:00
Keisuke Kuroynagi
0b1c08bf5a Use ReentrantReadWriteLock in ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2acde0517d5ed5cbd7b7149709e35fc36651335d
2013-07-03 19:46:08 +09:00
Tadashi G. Takaoka
f87e8f7ec1 Handling key repeat by emulating key press and code input
This change also eliminates a reference of
AudioAndHapticFeedbackManager from KeyboardSwitcher and MainKeyboard.

Bug: 6522943
Change-Id: Iac42ec8ff00c66deb76a660ffc07477923a58959
2013-07-02 19:50:34 +09:00
Jean Chalard
e5a3b77664 Merge "Move Range out of RichInputConnection and rename it." 2013-07-01 07:20:51 +00:00
Keisuke Kuroynagi
109ba3ace3 Merge "Regenerate old version dictionaries using new format." 2013-07-01 07:16:15 +00:00
Jean Chalard
70ee2201a0 Merge "Do not re-resume suggestion if it's not needed." 2013-07-01 07:12:24 +00:00
Jean Chalard
675bcf191c Move Range out of RichInputConnection and rename it.
Range has grown a bit too big to stay an internal class.

Change-Id: Ic3fbc48a5d10776eedd7559c4d696e5926b88288
2013-07-01 15:41:13 +09:00
Keisuke Kuroynagi
a62b5b22ef Regenerate old version dictionaries using new format.
Bug: 9617181
Change-Id: I228a3eac959f81b38e4092015e8e3c429d46fa60
2013-07-01 15:25:33 +09:00
Jean Chalard
3f0858eb2b Fix a bug where no URL means refresh never ends
This patch does two things:
- If there is no URL to download new data from, then the
Refresh button is not shown.
- Even if for some reason refresh starts for a client for
which there is no URL, loading correctly finishes.

Bug: 9388602
Change-Id: I3fd9214da50faa4b59d0bd3e775293dd34f07547
2013-07-01 14:47:30 +09:00
Jean Chalard
f0af452ce2 Do not re-resume suggestion if it's not needed.
This is much better interface-wise. It eliminates all blinking
of the line in the practice.

Bug: 8874148
Bug: 8864306
Change-Id: I87754e44784327c2e9c8b162d598d145e20668e8
2013-07-01 14:40:12 +09:00
Kurt Partridge
8142a7b637 Merge "Record number of words entered" 2013-06-28 17:01:18 +00:00
Jean Chalard
a5e28acf63 Merge "Fix a bug where AOSP Latin IME would not fill dictionaries" 2013-06-28 13:21:31 +00:00
Jean Chalard
555c4236db Fix a bug where AOSP Latin IME would not fill dictionaries
There is no reason not to contact the dictionary provider
when we don't have internet permission or when the URL
is empty. It knows how to handle both these cases.

Bug: 9388602
Change-Id: I30c4540551ad2f5e527d3acd1842bbd749feca89
2013-06-28 12:48:41 +09:00
Kurt Partridge
169571b3c0 Record number of words entered
This change records the number of words entered in every LogUnit.
This metric is helpful for determining how much multi-word gestures
and spaceless tapping is used.

Change-Id: I4c6d0f9d78e4ac2dd63fd53ed2ec70b368366f15
2013-06-27 12:30:00 -07:00
Jean Chalard
e04794cbbe Fix some warnings
Mostly remove unused imports

Change-Id: If8ceffdfad79b78194094527759f5c334746973e
2013-06-27 21:36:52 +09:00
Satoshi Kataoka
4ded1af210 Improve the language list in the personal dictionary
Bug: 9117704
Change-Id: I26e6f8369a3c7ffa4bb651b4b5a3e6f004121983
2013-06-27 20:31:02 +09:00
Satoshi Kataoka
ec69a259c6 Merge "Open an API in ExternalDictionaryGetterForDebug" 2013-06-27 10:32:05 +00:00
Satoshi Kataoka
a2bfd46adf Use internal personal dictionary settings on JBMR2 or before
Bug: 9117704
Change-Id: I7e20b03daa23b59211235183cf48d933e32845e4
2013-06-27 19:20:05 +09:00
Satoshi Kataoka
bd84a00fc1 Open an API in ExternalDictionaryGetterForDebug
and extend it

Change-Id: Id2ba8dd8928a6327d3b31eb35f7cc314e2d31050
2013-06-27 18:41:07 +09:00
Jean Chalard
2bbd78ab0a Merge "Ignore spans that are not the right size." 2013-06-27 03:06:47 +00:00
Jean Chalard
2f7f6257b6 Ignore spans that are not the right size.
Bug: 8839763
Bug: 8862327
Change-Id: I5d49c86edcbc0fc1b2b147856437cfbadd678377
2013-06-26 23:02:50 +09:00
Jean Chalard
6c0e412137 Merge "Resume suggestion at start input" 2013-06-26 10:18:32 +00:00
Jean Chalard
a690f3bc40 Merge "Readability improvement" 2013-06-26 07:37:15 +00:00
Jean Chalard
173f74bb18 Merge "Fixing follow-up to I548d899b" 2013-06-26 07:36:44 +00:00
Jean Chalard
fb72890ac6 Readability improvement
Change-Id: I2f350145f333ba1fa4eb20027b0f41107c2df02c
2013-06-26 16:03:40 +09:00
Jean Chalard
7fcf304c97 Fixing follow-up to I548d899b
I548d899b introduced a new method to fix a sync miss between
the cursor position and the cached cursor position, but did not
take into account that it should also update the cached text
before and after the cursor in this case and that there was
already a method for doing this.

Change-Id: I31bd741893207c822827304e77791b1159774e1a
2013-06-26 15:28:42 +09:00
Keisuke Kuroynagi
5bf1be7162 Add jni methods for dynamically handling a dictionary.
Bug: 6669677
Change-Id: I8a26623adbb41a78e3c023c652be635c635e3b47
2013-06-26 12:51:33 +09:00
Jean Chalard
2f69348d51 Resume suggestion at start input
Bug: 9568410
Change-Id: I65468268f8613c863fa7f3a497b64656da0a221c
2013-06-25 19:38:31 +09:00
Ken Wakasa
fd0945b0da Merge "Make UserLogRingCharBuffer an external class" 2013-06-25 09:40:31 +00:00
Ken Wakasa
9419e02fd9 Make UserLogRingCharBuffer an external class
Change-Id: I9d506995337d64ec11c72939a8d739423ee46efa
2013-06-25 18:38:13 +09:00
Jean Chalard
333362adfc Merge "Fix the one-suggestion case." 2013-06-25 09:10:09 +00:00
Jean Chalard
d7d5ff1f99 Fix the one-suggestion case.
When there is only one suggestion, this code does
not work. The reason for that is, it's not homogeneous
at all and takes indices of one thing into another.

Not completely related to b/8839763, but realized
working on this and needed to have it addressed.

Bug: 8839763
Change-Id: I422730cc7eebb69ff421a171025af0390ebcdf92
2013-06-25 18:00:30 +09:00
Keisuke Kuroynagi
38b542629a Merge "Add a parameter isUpdatable to the constructor of BinaryDictionary." 2013-06-25 08:44:48 +00:00
Keisuke Kuroynagi
981717da4c Add a parameter isUpdatable to the constructor of BinaryDictionary.
Bug: 6669677
Change-Id: I6bc25131afd97112e3bbde036a81ab559a9a6460
2013-06-25 17:39:06 +09:00
Ken Wakasa
12ef7d3702 Merge "Cleanup under the utils package" 2013-06-25 08:20:57 +00:00
Ken Wakasa
03118a2760 Cleanup under the utils package
Change-Id: If2f7bd1346cc5085bf57645830f0faac44d017e4
2013-06-25 17:09:12 +09:00
Keisuke Kuroynagi
8bc0b51369 Merge "Allow mmapping dictionary file in writable mode in openNative." 2013-06-25 07:09:37 +00:00
Keisuke Kuroynagi
f3b62900c7 Allow mmapping dictionary file in writable mode in openNative.
Bug: 6669677
Change-Id: I447668932de118b158fa029ddc977b3f3cc06cb8
2013-06-25 16:03:33 +09:00
Jean Chalard
10585620bd Merge "Fix a bug in the cached cursor pos, and simplify selection handling" 2013-06-25 05:00:11 +00:00
Kurt Partridge
1fc6b80009 Merge "Move splash screen to separate file" 2013-06-24 13:40:01 +00:00
Jean Chalard
cdf774122d Merge "Fix a small bug" 2013-06-24 10:00:05 +00:00
Ken Wakasa
bfaf349c35 Load the native lib eagerly
in the hope of avoiding UnsatisfiedLinkError. This is definitely not a
confident fix as we still don't know the root cause of the issue.

bug: 9325110
Change-Id: I1abf8031b98509f63fce6a2d069d497895ea712c
2013-06-24 18:12:04 +09:00
Ken Wakasa
bc1813186d Merge "Move util classes to the latin/utils directory" 2013-06-24 08:49:06 +00:00
Tadashi G. Takaoka
fadff6ada1 Merge "Fix possible divided by zeror error" 2013-06-24 08:44:17 +00:00
Tadashi G. Takaoka
bafe4b8a4e Fix possible divided by zeror error
Bug: 9534022
Change-Id: I5ab575c724fd7a9e80c76a93d83949e81b2970bb
2013-06-24 17:39:36 +09:00
Jean Chalard
ca52e1ca5a Fix a small bug
SpannableStrings are not the only type of Spanned, they are
only the mutable kind. SpannedString is the immutable one.
Spanned is the correct class to use there.

Bug: 8839763
Bug: 8862327
Change-Id: Ic5e6199a51f22368914f2748ac2d0d1ca6a33f78
2013-06-24 17:39:17 +09:00
Ken Wakasa
e28eba5074 Move util classes to the latin/utils directory
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
2013-06-24 17:04:40 +09:00
Jean Chalard
e8c4b99e56 Refactor text range to be able to get spans larger than the word
This changes how the Range class stores its data, but not its
functionality. It also improves encapsulation a bit.

Bug: 8839763
Bug: 8862327
Change-Id: I5bd583b3fc96a99b93a2632882d8fd587c03ab76
2013-06-24 12:31:14 +09:00
Kurt Partridge
1a0750dc95 Move splash screen to separate file
Change-Id: I5cad5d5814303d7ca4abadd3fca1c37bd1bc357e
2013-06-22 10:24:13 -07:00
Jean Chalard
b7a2fd16a1 Merge "Defer disk-intensive tasks until after the keyboard is shown" 2013-06-21 10:57:33 +00:00
Jean Chalard
673c727b7a Defer disk-intensive tasks until after the keyboard is shown
Bug: 8689779
Change-Id: Ia78d3540f44ec0028c3246a8e0163e9ecf061ecf
2013-06-21 19:41:45 +09:00
Jean Chalard
e5dee0af4a Fix a bug in the cached cursor pos, and simplify selection handling
The documentation for setComposingRegion states explicitly
that it does not move the cursor. This is just a bug.
This does not have any ill effects right now, but it will have
in later changes if not fixed.

As for the selection handling, the specific test that this code
removes used to serve a purpose, but it does not any more because
the code using the value has been much sanitized. Now the variable
can just take the obvious value, and become so self-explanatory
that the comments are unnecessary.

Change-Id: I548d899b38776bd3ab5f5361aab0d89d98f12e73
2013-06-21 18:15:07 +09:00
Tadashi G. Takaoka
9b570b5e62 Fix punctuations strip
Bug: 9508186
Change-Id: I8f0fbf4e0578cf9116d4c57e7e5747d38c89387e
2013-06-21 13:22:37 +09:00
Jean Chalard
93f74bafbb Merge "Add tests to dicttool test." 2013-06-20 08:34:38 +00:00
Jean Chalard
23d4eb55ba Add tests to dicttool test.
Bug: 8526576
Change-Id: Idd6f9cd076d5915361c68f5c29afbba67dd54eba
2013-06-20 17:29:37 +09:00
Tadashi G. Takaoka
c90181d6aa Use system default key press volume
Bug: 9475973
Change-Id: I6ae825b161dde69e19b52d73fb9aa782e2aa7423
2013-06-18 21:34:30 +09:00
Tadashi G. Takaoka
af69a14c96 Use system default vibration pattern
Bug: 9468462
Change-Id: Ifa46a56873c10888da8eaa2782fe07ef138a141b
2013-06-18 21:33:51 +09:00
Jean Chalard
3b5a503ebf Merge "Optimize ProximityInfo#computeNearestNeighbors()" 2013-06-18 11:45:06 +00:00
Jean Chalard
d55baf06d9 Optimize ProximityInfo#computeNearestNeighbors()
This cuts the time spent in computeNearestNeigbors by
a factor of 6 to 20, with an average at about 8.
This method representing about 25% of the total time
spent when switching keyboards, this change is a
20% improvement in layout switching time.

Bug: 8689779
Change-Id: Icb465f6010b317c7156057891c3341e51a198688
2013-06-18 20:33:52 +09:00
Tadashi G. Takaoka
3be8263035 Get value text from ValueProxy
As a preparation to show "system default" in the settings. LatinIME
can't know the actual system default value.

Bug: 9468462
Change-Id: I0b7898d1ca29ded7a619dd636d2ad16eb0db292e
2013-06-18 18:27:17 +09:00
Jean Chalard
2a81943d16 Fix a bug with recapitalization
This is a shameful bug :/

Bug: 9410367
Change-Id: I54ddbcd0323fa2c11fbd2aa8a1b3d2e07f6e83c8
2013-06-17 20:39:06 +09:00
Kurt Partridge
14718ab898 Merge "Log score, kind, and sourceDict for manual suggestion and gesture" 2013-06-14 17:03:03 +00:00
Jean Chalard
78b881bf5a Merge "Fix a bug with long user dict entries" 2013-06-14 08:59:51 +00:00
Tadashi G. Takaoka
97eaa543d5 Don't count Spacer into histograms
Change-Id: I202a25da4e1a722aa35c57665d73bc5990404c4e
2013-06-14 16:21:37 +09:00
Jean Chalard
6233ee3633 Fix a bug with long user dict entries
Bug: 9410958
Change-Id: I966e452c6dbdcb444abbb6ffb316849a7c85a73b
2013-06-14 12:40:35 +09:00
Kurt Partridge
fc98325c61 Log score, kind, and sourceDict for manual suggestion and gesture
b/9422713

Change-Id: I4880fad6a5b10d09ca11b63311f14862bee724e5
2013-06-13 11:03:49 -07:00
Jean Chalard
27d9c6f795 Merge "Cache subtype lists reasonably." 2013-06-13 01:49:41 +00:00
Kurt Partridge
e72d1a07b6 Merge "Allow downloadable dictionaries in development builds" 2013-06-12 21:22:34 +00:00
Kurt Partridge
3d9ebf213c Merge "Make intents unique to AOSP" 2013-06-12 18:11:17 +00:00
Kurt Partridge
14dd52b8c0 Merge "Adjust settings for development-only versions" 2013-06-12 16:50:55 +00:00
Kurt Partridge
eac0eb89f2 Merge "Fix ResearchLogger feedback bug" 2013-06-12 15:38:45 +00:00
Jean Chalard
ff6445ed0e Cache subtype lists reasonably.
This will spare a lot of IPC for Latin IME at the cost of very little
retained memory.
This improves the loading by potentially a lot - between 15 and 30%
when the layout is cached (which should now be the case almost every
time), and half that if it's not. More importantly, it makes the
load time less sensitive to high device load, which is one of the
sore points.

Bug: 8689779
Change-Id: I2e07736f1a92c38eed0e203bc690761a181da8b9
2013-06-12 18:04:52 +09:00
Kurt Partridge
2a1a463e2e Adjust settings for development-only versions
Change-Id: I4f08632d97f182d312edc82bda3c3897a71099ad
2013-06-12 02:01:45 -07:00
Tadashi G. Takaoka
dfd96be03a Retun an empty Path instead of null
Bug: 9374496
Change-Id: If74306104e9d25288e1b216a328304da376c1bdb
2013-06-12 17:35:02 +09:00
Kurt Partridge
19ba5e67af Fix ResearchLogger feedback bug
If the logger feedback screen is up and the user hits the home button or the
keyboard otherwise closes, the system won't let the user enter feedback again,
because it is waiting for the user to finish the first one.

With this change, the state associated with the feedback screen is
cleared when the user closes the keyboard.

b/9398772

Change-Id: I832a82793ad42e31b6b3fdb04fabcea75facde7d
2013-06-12 00:37:46 -07:00
Kurt Partridge
2c1796c226 Make intents unique to AOSP
This is to avoid confusion if multiple IMEs are installed with
dictionary pack components

Change-Id: Ibc91951e4fdd5db13f681e4cb06197da98527bbc
2013-06-11 15:04:00 -07:00
Jean Chalard
4d8f9f1cab Cache three main keyboards to improve average switch time
This typically improves the average loading time by about
35%, after the first time.

Bug: 8689779
Change-Id: I7b0ab6b942af1d3250b9dcbf875f27f9f64692f3
2013-06-11 12:01:56 +09:00
Satoshi Kataoka
fe95e7b1bf Merge "Fix possible NPE" 2013-06-07 11:09:52 +00:00
Tadashi G. Takaoka
77f63c8ac6 Don't use RichInputMethodManager in setup wizard
In setup wizard, InputMethodManager may not be able to be aware that
this IME is installed, especially just after the IME is installed via
GooglePlay app and hit the open button on the app to launch the setup
wizard.

Bug: 9299618
Change-Id: I00c8544178b41074253d49ae9481996ec56593d2
2013-06-07 19:09:44 +09:00
Satoshi Kataoka
6c8136d157 Fix possible NPE
Bug: 9314901
Change-Id: Id80f59df38ae72766b097fd1c23326fedd302439
2013-06-07 19:08:58 +09:00
Tadashi G. Takaoka
b0e0c5a844 Merge "Defer getting no language subtype" 2013-06-07 10:00:19 +00:00
Jean Chalard
0ad1489625 Fix an illegal argument exception
This is a bit of a shot in the dark, as I really don't see how this
can happen, but this should fix it in the correct way no matter
how it's actually happening.

Bug: 9301836
Change-Id: I472865b7a78883942c9fd46773238c23788674f8
2013-06-07 18:23:00 +09:00
Tadashi G. Takaoka
254b484e75 Defer getting no language subtype
Bug: 9318351
Change-Id: I55338c001070655a3f90df3dbe1351bd4180d520
2013-06-07 18:20:31 +09:00
Jean Chalard
6910032972 Merge "Use an iterator to remove stuff from an ArrayList." 2013-06-06 08:19:41 +00:00
Jean Chalard
0dc422e0c7 Use an iterator to remove stuff from an ArrayList.
Silly me >.>

Bug: 9306154
Change-Id: Ic00e9d6a31cd1d7aacefe68b7be9c2199e297b0d
2013-06-06 17:03:16 +09:00
Kurt Partridge
efd26bb319 Allow downloadable dictionaries in development builds
Bug: 9305379

Change-Id: Iab32753070a056d3861a45aa898911b7ab67dfb6
2013-06-05 22:14:54 -07:00
Satoshi Kataoka
f6a1a76524 Merge "Fix a possible NPE" 2013-06-06 05:02:46 +00:00
Satoshi Kataoka
6f9c6f2c64 Fix a possible NPE
Bug: 9301208
Change-Id: Id120c99ab9ef698d16cf7b8beea30c98c95d23a1
2013-06-06 12:01:22 +09:00
Tadashi G. Takaoka
cbd219a761 Move Base64Reader to utils package
Change-Id: Id46898c5cae268f05850d79938929b7707f27320
2013-06-05 19:39:36 +09:00
Tadashi G. Takaoka
9c440d1373 Merge "Remove unnecessary Drawable.setState" 2013-06-05 08:34:59 +00:00
Tadashi G. Takaoka
9d4e251826 Merge "Add CsvUtils that conform to RFC 4180" 2013-06-05 06:28:06 +00:00
Tadashi G. Takaoka
3201e98647 Remove unnecessary Drawable.setState
Change-Id: I362933ea4d5bcb1ccfebb5b22f6ccecf12337f4b
2013-06-05 14:30:16 +09:00
Tadashi G. Takaoka
3ceeb6bcc6 Add CsvUtils that conform to RFC 4180
Bug: 9070153
Change-Id: I66e55dd2f30fddfeb849edb97bc1cbda6b126d92
2013-06-05 12:26:22 +09:00
Tadashi G. Takaoka
0bfc2bc419 Merge "Add CODE_CAPSLOCK for long press shift key" 2013-06-05 02:19:02 +00:00
Tadashi G. Takaoka
9552badf3c Add CODE_CAPSLOCK for long press shift key
This change utilizes the no panel auto more key feature to implement
long press shift key for shift lock.

Change-Id: I3995d25dc35aea3c67b5aa29299815462eff9cad
2013-06-04 18:20:06 +09:00
Kurt Partridge
5fc9d6cc04 Avoid an NPE
Change-Id: I174eb8e92820fe6e7f8d3b89afae12d94063ef5d
2013-06-03 19:30:57 -07:00
Tadashi G. Takaoka
cbc7acb6f5 Merge "Expand suggestion strip when center suggestion is long" 2013-06-03 14:45:05 +00:00
Kurt Partridge
763fd9d5e9 Merge "Fix revert of committed words" 2013-06-03 13:03:26 +00:00
Tadashi G. Takaoka
b4ae86f0de Merge "Rename methods for readability" 2013-06-03 09:57:48 +00:00
Tadashi G. Takaoka
9ff7354d78 Clear previous suggestions when gesture typing starts
Bug: 8651076
Change-Id: Ic65ed3e3696409edea4e35080c11e4d1869a5a7e
2013-06-03 17:59:26 +09:00
Tadashi G. Takaoka
2a9882a433 Rename methods for readability
Change-Id: I8fc2c90cf8d3dce11740f8e61edf6dfde9b1c116
2013-06-03 17:52:21 +09:00
Tadashi G. Takaoka
043273b00f Expand suggestion strip when center suggestion is long
Bug: 9059710
Change-Id: I7fa2658cc6442e86f69c991f1e99db6fb1ef909c
2013-06-03 16:12:59 +09:00
Tadashi G. Takaoka
0e66ab7433 Merge "Fix ArrayIndexOutOfBoundException" 2013-06-03 07:12:07 +00:00
Tadashi G. Takaoka
72ac390ce6 Fix ArrayIndexOutOfBoundException
Change-Id: I243fc4965365680615eed834efe9ae0240e7f2a8
2013-06-03 15:35:49 +09:00
Kurt Partridge
c4119c8063 Merge "Uncommit an extra LogUnit" 2013-06-03 05:38:43 +00:00
Kurt Partridge
a2f3f17de6 Merge "Compare scrubbed strings when uncommitting LogUnits" 2013-06-03 03:03:58 +00:00
Kurt Partridge
743302888b Merge "Uncommit separator LogUnits" 2013-06-03 03:01:23 +00:00
Kurt Partridge
3d20946272 Merge "Uncommit LogUnits when reverting textInput" 2013-06-03 02:58:20 +00:00
Kurt Partridge
4efb5c3b65 Merge "Remove uncommit on reverting batch input" 2013-06-03 02:54:33 +00:00
Kurt Partridge
94ef54321e Fix revert of committed words
Now that separators are put into their own LogUnits, they must be handled
when going through a revert.

Bug: 9088919

Change-Id: Ibebd0752bb2fa38d74ac96001d63070dd419cee3
2013-06-02 19:22:35 -07:00
Kurt Partridge
f07024e0fa Compare scrubbed strings when uncommitting LogUnits
A LogUnit is only uncommitted if the LogUnit's word matches what is
expected.  But a LogUnit never stores numbers, only scrubbed words that
replace numbers with a special character.  So when uncommitting, the
text from the TextView must also be scrubbed for the comparison to pass
correctly.

Bug: 9088919

Change-Id: I9b56f10afce6d0cc84eb9ead3b9a9b1e061ae39c
2013-06-02 19:17:31 -07:00
Kurt Partridge
bdff287a0d Uncommit separator LogUnits
Now that separators have their own LogUnits, they must be uncommitted
from the LogBuffer when backspacing over them.

Bug: 9088919

Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
2013-06-02 19:15:57 -07:00
Kurt Partridge
8160a21c3a Uncommit an extra LogUnit
The period-generating double-space adds an extra LogUnit --
it must be removed when reverting.

Bug: 9088919

Change-Id: Ic148f40b4030a9b4a0651029bda87f7b94a52252
2013-06-02 00:02:38 -07:00
Kurt Partridge
720840851d Uncommit LogUnits when reverting textInput
Bug: 9088919

Change-Id: I17187aa0afc1c3e9d32269c65f66cfb3a08663cb
2013-06-01 23:42:35 -07:00
Kurt Partridge
4165ef031f Remove uncommit on reverting batch input
Currently when the user reverts a batch input, a LogUnit is uncommitted
from the LogBuffer.  It should not be, because the LogUnit containing the
batch input is never committed in the first place (it is only committed
to the LogBuffer when a key is pressed or a new batch input is entered).

Bug: 9088919

Change-Id: I323af453ce082437a663ccae977b21b775a964bc
2013-06-01 11:15:47 -07:00
Jean Chalard
26f489493e Fix the displayed status after download
Bug: 9166225
Change-Id: I7490593d88a5854b9e675b9ead89d2ea9b49315c
2013-05-31 20:28:15 +09:00
Jean Chalard
f61999caba Merge "Make it easy to open several dictionaries from tests" 2013-05-31 11:21:37 +00:00
Tadashi G. Takaoka
a0c3e02d71 Refactor SuggestionStripLayoutHelper a bit
Bug: 9059710
Change-Id: Ief12029bad75d4dc78090ab97555aece01b873de
2013-05-31 18:14:47 +09:00
Jean Chalard
1562fc91f0 Make it easy to open several dictionaries from tests
Bug: 9127175
Change-Id: I3f1840ee73b364df26dfddb5acb10001e0f2cb61
2013-05-31 15:36:05 +09:00
Tadashi G. Takaoka
723391c945 Merge "Tidy up Utils class a bit" 2013-05-31 06:29:24 +00:00
Kurt Partridge
e6125db98d Merge "Catch a permission exception" 2013-05-31 00:30:14 +00:00
Kurt Partridge
d63f756013 Catch a permission exception
This change catches a SecurityException if the DictionaryProvider is
unavailable.

Change-Id: I4f2d87327c40765383d8847fd4e934b3cf799488
2013-05-30 13:40:40 -07:00
Tadashi G. Takaoka
cbb99c60be Tidy up Utils class a bit
Change-Id: Idc2feb84a902a6cbb7265d1efe06c34e7d63c2c7
2013-05-31 00:32:57 +09:00
Tadashi G. Takaoka
7097aa2d3d Merge "Cleanup unreadable variable names" 2013-05-30 13:09:27 +00:00
Tadashi G. Takaoka
d67db32b30 Merge "Separate SuggestionStripLayoutHelper for readablity" 2013-05-30 13:09:17 +00:00
Jean Chalard
1a50999ed9 Merge "Tell the text view we reset state on finish input" 2013-05-30 11:53:50 +00:00
Jean Chalard
e90d039e0c Fix two strict mode warnings.
Bug: 9052555
Change-Id: I86e90488679a78a9f6e901b640025619293765a0
2013-05-30 20:12:05 +09:00
Tadashi G. Takaoka
500a9752b1 Cleanup unreadable variable names
Change-Id: Ic97687c58e25e4b0c6833cc25d10854f5f513081
2013-05-30 19:49:51 +09:00
Tadashi G. Takaoka
653603b725 Separate SuggestionStripLayoutHelper for readablity
Change-Id: I82c749c6837c3af7ae290f4cd92f5426ca58b5c7
2013-05-30 19:49:20 +09:00
Jean Chalard
8eb214d7e1 Merge "Fix dictionary pack preference order." 2013-05-30 06:38:27 +00:00
Jean Chalard
b3d150aa13 Fix dictionary pack preference order.
It turns out giving them in the right order is not enough, you
also have to actually give them a numeric priority.

Bug: 9165928
Change-Id: I2ecff38f65b70746feeeeb0ed2cc86a586a35363
2013-05-30 12:33:06 +09:00
Jean Chalard
68d9cb62e2 Tell the text view we reset state on finish input
This should be done in onFinishInput rather than onFinishInputView
but for an unknown reason onFinishInput never comes.

Bug: 9113167
Change-Id: Iafb40846a3ed8fad78bfc160d17cd431f81fe891
2013-05-29 18:44:40 +09:00
Jean Chalard
2b34b4eab6 Rub some butter on dictionary list scrolling.
The default implementation for preferences refuses to
cache the views for custom preferences at all. We can
do it, but the system won't do it for us, so this does it.
This makes the screen scrolling smooth again.

Incidentally it also fixes the bug where the button may
not animate on the first element.

Bug: 8882722
Bug: 8883108
Change-Id: I9b2306ac4bf93761a808ebfee3477a65f017cddf
2013-05-29 11:52:04 +09:00
Kurt Partridge
305509ed2f Merge "Remove unused method" 2013-05-29 01:36:27 +00:00
Kurt Partridge
b536e2ace5 Remove unused method
The removed method was used in old versions of ALK, never in master.

Change-Id: I607009d4fcca7c7c8493fee51ecd923e6a6b3890
2013-05-28 16:51:19 -07:00
Kurt Partridge
215fabff52 Merge "Rename containsCorrection to containsUserDeletions" 2013-05-28 23:41:26 +00:00
Kurt Partridge
315ab98007 Rename containsCorrection to containsUserDeletions
This change renames containsCorrection to avoid confusion with
CorrectionInfo, and to better clarify its meaning.

Change-Id: I5d8f8e2b03133c15a60d4e8b0f395cda1fff5447
2013-05-28 09:43:04 -07:00
Tadashi G. Takaoka
d99abf8cb1 Delete shared preference entry when user select default value
Change-Id: I3fbafd9024c26a99d87376f5d5e359e03988a30f
2013-05-28 20:44:25 +09:00
Tadashi G. Takaoka
39bd6ea0dc Merge "Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs" 2013-05-28 11:40:10 +00:00
Tadashi G. Takaoka
dbed20ad8d Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs
Change-Id: I16e3f3ebc43772cfd96c824afeddfd225404b857
2013-05-28 20:23:37 +09:00
Tadashi G. Takaoka
d69e4191b7 Merge "Refactor suggestion strip layout methods a bit" 2013-05-28 11:11:05 +00:00
Tadashi G. Takaoka
389d308fff Refactor suggestion strip layout methods a bit
Bug: 9059710
Change-Id: I8dc698c1d61ca51b65b232e6c586472588a4accb
2013-05-28 20:03:37 +09:00
Tadashi G. Takaoka
4c2ac9ee5f Merge "Rename commaConcatinatedText to commaSplittableText" 2013-05-28 10:58:16 +00:00
Tadashi G. Takaoka
c47bc30db8 Rename commaConcatinatedText to commaSplittableText
This is a follow up of I5a32882a08.

Change-Id: I9f0cda2167811f6bba2af042fbde0a821b4cfecd
2013-05-28 19:17:15 +09:00
Tadashi G. Takaoka
68cf2cd931 Merge "Check all regexp patterns in ResourceUtils.getDeviceOverrideValue" 2013-05-28 10:13:43 +00:00
Keisuke Kuroyanagi
e168a3c2a5 Merge "Adding additional feature settings." 2013-05-28 10:11:29 +00:00
Tadashi G. Takaoka
4c75ea858a Check all regexp patterns in ResourceUtils.getDeviceOverrideValue
This change also fixes a regexp error of Galaxy S III.

Change-Id: I42a4780bbfd2b083f4e27e61ec513aa875907344
2013-05-28 19:05:40 +09:00
Tadashi G. Takaoka
6d77ae9d81 Merge "Remove KeyboardStart.isInMomentarySwitchState" 2013-05-28 09:23:24 +00:00
Satoshi Kataoka
07e56e76a7 Merge "Implement KIND_OOV_CORRECTION" 2013-05-28 07:27:53 +00:00
Keisuke Kuroyanagi
1b100610b3 Adding additional feature settings.
Change-Id: I9fec0c03b7da9ce0305b494193f4cfe3fca144f3
2013-05-28 00:27:48 -07:00
Tadashi G. Takaoka
1b46738796 Rename "csv" in StringUtils to "commaConcatenatedText"
Change-Id: I5a32882a088e4ff5bfe973a86465d6ff839113d9
2013-05-28 16:13:36 +09:00
Tadashi G. Takaoka
e7e7b3234c Remove KeyboardStart.isInMomentarySwitchState
Change-Id: I00f45d8dd7feb6c34c0a65a8545cddd2751796d0
2013-05-28 15:26:03 +09:00
Satoshi Kataoka
3d97b95b90 Implement KIND_OOV_CORRECTION
Bug: 9127749
Change-Id: I96db15a3138e6b522c4c6ad16cc7faad577d3772
2013-05-27 18:53:43 -07:00
Satoshi Kataoka
c92e87faf3 Add smoothing utils / matrix libs
Bug: 8556775
Change-Id: I7e0516b344937b84b7d57cc4e5009b7f88e7dc98
2013-05-27 18:08:49 -07:00
Keisuke Kuroyanagi
28b6262b54 Merge "Passing options to native suggestion method." 2013-05-24 22:27:19 +00:00
Tadashi G. Takaoka
740d829092 Merge "Use localized toLowerString in AutoCorrection.isValidWord" 2013-05-24 20:00:38 +00:00
Tadashi G. Takaoka
94027c7201 Use Locale.ROOT for locale neutral operations
Bug: 9112465
Change-Id: I6cd63007287b5a1a57cfbabff35d53f66fc5620e
2013-05-24 12:07:30 -07:00
Tadashi G. Takaoka
618407ab7e Use localized toLowerString in AutoCorrection.isValidWord
Bug: 9112465
Change-Id: I63eb4115f393444560e80220d4c90f0f7101b934
2013-05-24 11:47:36 -07:00
Tadashi G. Takaoka
ebe0544fc8 Remove redundant method AutoCorrection.isInTheDictionary
Change-Id: I0737fb0b68f411f4db06014f2d94804935808922
2013-05-24 11:40:03 -07:00
Keisuke Kuroyanagi
50db5f0fff Passing options to native suggestion method.
Change-Id: I6da180cfa1b9e5aa39600e78e3bc41209a40f583
Signed-off-by: Keisuke Kuroyanagi <ksk@google.com>
2013-05-24 10:21:04 -07:00
Kurt Partridge
264fb9581c Merge "Log reasons for punting n-gram logging" 2013-05-24 00:19:24 +00:00
Kurt Partridge
aaa23bc12c Log reasons for punting n-gram logging
Addresses b/9074239

Change-Id: I91a3bfcbd32b03e4891ff5f65be01383a3fb8975
2013-05-23 13:56:36 -07:00
Tadashi G. Takaoka
6f9105383a Remove unnecessary methods of KeyboardSwitcher
Change-Id: Idd3647bb1a1d40df8bb89eda715d45427a58d0cd
2013-05-22 10:49:53 -07:00
Tadashi G. Takaoka
dc22b7226a Merge "Clean up unused return value" 2013-05-22 17:44:51 +00:00
Tadashi G. Takaoka
d88353266a Merge "Haptick and audio feedback on key repeat" 2013-05-22 17:44:01 +00:00
Kurt Partridge
5fdea4775e Merge "Always record word boundaries" 2013-05-22 03:04:35 +00:00
Tadashi G. Takaoka
009488eaaf Haptick and audio feedback on key repeat
Bug: 6522943
Change-Id: I181f7e8722bf1b3042d7f384ae8ebf87f29458a9
2013-05-21 19:48:15 -07:00
Tadashi G. Takaoka
d9a87eb857 Merge "Fix drawing debug points of gesture trails" 2013-05-22 00:39:22 +00:00
Keisuke Kuroyanagi
44f679bbd2 Merge "Fix running on device regression test and profile." 2013-05-22 00:18:14 +00:00
Tadashi G. Takaoka
96efb1252a Clean up unused return value
Change-Id: Ie59f08db947ca5314935c6b723cf498129b4515c
2013-05-21 16:42:07 -07:00
Tadashi G. Takaoka
9764397274 Fix drawing debug points of gesture trails
Bug: 7167303
Change-Id: I9a75b1b9b9127c5364da49b2a04b22c16a7ad535
2013-05-21 16:09:10 -07:00
Kurt Partridge
450d78b030 Always record word boundaries
Word boundaries are currently logged, but only if all the
details of a word pass the privacy filter and are logged.

This change records when a word is committed in all cases,
but does not disclose the word contents or any data used in
its construction.

Addresses b/9070768

Change-Id: I573679d0685c088aca65af99e46337a2f429f816
2013-05-21 16:08:54 -07:00
Tadashi G. Takaoka
8a6a15e052 Merge "Clean up IntentCompatUtils a bit" 2013-05-21 22:17:24 +00:00
Tadashi G. Takaoka
db7d4da3e5 Clean up IntentCompatUtils a bit
Change-Id: I803aa6c2160bfa1ffe992b28e7eb6e8a320c9762
2013-05-21 15:13:23 -07:00
Kurt Partridge
ff80ee20b4 Merge "Modify isAllowedToLog" 2013-05-21 21:22:23 +00:00
Kurt Partridge
74a6196c6b Modify isAllowedToLog
Currently isAllowedToLog only checks the state of the
ResearchLogger, and does not consider which log the data is
going to.  This causes problems with the logs for Feedback.
The Feedback log should inhibit normal logging procedures,
but the system needs to be able to write specific data
directly to it.

This change renames to isAllowedToLogTo and adds the
destination ResearchLog as a parameter.  A FeedbackLog is also
added as a new class so it can be distinguished from other
ResearchLogs.

Change-Id: I5a1eea05bb040c26bf816b89179f44b3024fa2ad
2013-05-21 14:09:04 -07:00
Jean Chalard
d96f63d2ed am e2bee5b1: am ede3db51: Merge "Fix a crash on a secondary user" into jb-mr2-dev
* commit 'e2bee5b134aaefc69a680be8ea65e2d7640b3ead':
  Fix a crash on a secondary user
2013-05-20 21:32:21 -07:00
Jean Chalard
ede3db51f0 Merge "Fix a crash on a secondary user" into jb-mr2-dev 2013-05-21 04:27:34 +00:00
Jean Chalard
05ea7c5d02 am 167ba345: am 89fe1f50: Add a method to work around apps broken by recorrection
* commit '167ba3459b0ce02b9add12ade9388bd2b1e6eb62':
  Add a method to work around apps broken by recorrection
2013-05-20 21:10:07 -07:00
Satoshi Kataoka
10e8b93977 Fix a crash on a secondary user
Bug: 9054063
Change-Id: I092ab6e0077578d0aca57d2e41dfbc00b46e1ba4
2013-05-21 12:27:16 +09:00
Keisuke Kuroyanagi
adf82a97a9 Fix running on device regression test and profile.
Change-Id: Ie16d9514092d6d6f42881b975420e5d1431b776c
2013-05-20 20:14:13 -07:00
Tadashi G. Takaoka
a66396369b Merge "Remove unnecessary @UsedForTesting annotation" 2013-05-21 03:07:59 +00:00
Jean Chalard
0013f97ddd am 5906b05b: am 7058b02a: Extract a new class for app-specific workarounds.
* commit '5906b05bb50c0a67bd4f03fcfae41db3daefe0bc':
  Extract a new class for app-specific workarounds.
2013-05-20 19:50:46 -07:00
Tadashi G. Takaoka
2532f72b94 Remove unnecessary @UsedForTesting annotation
Change-Id: I843fd6bc20da95e61d1a05b5b34d6e4c9db59dab
2013-05-21 10:45:59 +09:00
Jean Chalard
89fe1f5088 Add a method to work around apps broken by recorrection
Bug: 8944307
Change-Id: I8986622554f30aaf4f595099c4ab5652b75c972c
2013-05-21 07:53:31 +09:00
Jean Chalard
7058b02a9c Extract a new class for app-specific workarounds.
Bug: 8944307
Change-Id: Iaff9dd03d3d856a6bdaa2b16c4e71e95cd2b6349
2013-05-21 07:53:28 +09:00
Kurt Partridge
500dea6ad4 Fix punctuation logging
Punctuation is currently put into the same LogUnit as the
following word.  This is counter-intuitive and makes
post-processing more complicated.

This change causes punctuation to be put into its own
LogUnit.

A tricky case is the phantom space.  A phantom space is
inserted right before other text, whose MotionEvents have
already been collected and inserted into mCurrentLogBuffer.
Phantom spaces are handled by creating their own LogUnit and
inserting it into the LogBuffer right before
mCurrentLogBuffer is shifted in.

Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
2013-05-17 09:47:40 -07:00
Kurt Partridge
17b63ba588 Merge "Remove unnecessary commit/uncommit" 2013-05-15 23:52:43 +00:00
Kurt Partridge
7af5300c7d Merge "Add claifying comment" 2013-05-15 23:31:31 +00:00
Jean Chalard
b1e37e4a47 am f1dcf725: Merge "Don\'t process recorrection or resets when not shown"
* commit 'f1dcf725061b3e61e40540566a5385cf4934f424':
  Don't process recorrection or resets when not shown
2013-05-15 07:58:27 -07:00
Tadashi G. Takaoka
25f0c8089e am 96a9f357: Merge "Fix unintentional setup step advance in orientation change"
* commit '96a9f357c7e2a059687926cd7cd52ac5d06bc65e':
  Fix unintentional setup step advance in orientation change
2013-05-15 07:58:18 -07:00
Tadashi G. Takaoka
7fe675440e am 769427cf: Adjust aspect ratio of setup image
* commit '769427cff24944958f5f1f6179090a86444f3eab':
  Adjust aspect ratio of setup image
2013-05-15 07:57:38 -07:00
Jean Chalard
f1dcf72506 Merge "Don't process recorrection or resets when not shown" 2013-05-15 11:25:25 +00:00
Jean Chalard
c9aaba1253 Don't process recorrection or resets when not shown
Bug: 8954116
Change-Id: Ica27dbfc570643bb81e6cdf34cc7c796ea080d71
2013-05-15 20:20:20 +09:00
Tadashi G. Takaoka
9b4a883e09 Fix unintentional setup step advance in orientation change
Bug: 8159728
Change-Id: I53e7d7c8fb5cc231ea94474b091e550f77ae8dab
2013-05-15 19:50:35 +09:00
Tadashi G. Takaoka
769427cff2 Adjust aspect ratio of setup image
Bug: 8159728
Change-Id: I578014912fa63c4c9b4c2c89aeae7ffec836b06c
2013-05-15 14:48:27 +09:00
Kurt Partridge
993acbaaa2 Remove unnecessary commit/uncommit
When the user reverts a commit, this causes the committed
word to be changed. The user usually then goes back to edit
that word.  Going back to edit causes an uncommit, so that
the editing actions are added onto the LogUnit containing
the operations used to construct the word.

But currently, reverting also involves its own
commit/uncommit pair, with the caller performing the
uncommit, and the commit happening inside the revert
command.  This may have been necessary in the past, when
revert was called in different situations, but is
unnecessary now.  Furthermore, the guarding conditions are
currently such that the uncommit doesn't always undo the
effects of the commit, corrupting the log output.

Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
2013-05-14 12:20:27 -07:00
Kurt Partridge
7b0a148951 Merge "Rename a var to match semantics" 2013-05-14 16:11:07 +00:00
Kurt Partridge
3e8df13cd7 Add claifying comment
This is a follow-up to I7c01c3dd3ac33d7e96c00836256bae9c14b124ed

Change-Id: I9e3f8968c4bbf9525d5dfe101f71373c42f88361
2013-05-14 09:10:22 -07:00
Kurt Partridge
b2d53be740 Merge "Remove FeedbackLog instance variables." 2013-05-14 13:09:33 +00:00
Tadashi G. Takaoka
8b56ad7814 Merge "Revise welcome screen video and still image" 2013-05-14 12:01:47 +00:00
Tadashi G. Takaoka
7348d9fb72 Revise welcome screen video and still image
Bug: 8159728
Change-Id: Ief8d7197879d24ccef529e975c23d6f11c7aa458
2013-05-14 20:56:09 +09:00
Ken Wakasa
d6d70e7325 Merge "Revert "Fix isSuggestionsStripVisible when keyboard hidden"" 2013-05-14 11:46:04 +00:00
Ken Wakasa
3efa36f6aa Revert "Fix isSuggestionsStripVisible when keyboard hidden"
This reverts commit cb0d1c4c58

Change-Id: Ie2c8e01c25bd051b6157e8f32ab84392a0c7252a
bug: 8954116
2013-05-14 11:44:22 +00:00
Tadashi G. Takaoka
41016acacf Back to previous keyboard layout by canceling sliding input
Bug: 8915171
Change-Id: Iabdeb7920f67f89246087c3ee06240406ecfbc3d
2013-05-14 20:28:03 +09:00
Tadashi G. Takaoka
c9398a3b39 Merge "Fix PointerTrackerQueue.releaseAllPointerOlderThan" 2013-05-14 06:53:15 +00:00
Tadashi G. Takaoka
979fb7415b Fix PointerTrackerQueue.releaseAllPointerOlderThan
Change-Id: If353869720895ee5355079c15c724132762dd70c
2013-05-14 15:32:21 +09:00
Jean Chalard
cb0d1c4c58 Fix isSuggestionsStripVisible when keyboard hidden
When the keyboard is hidden, the suggestion strip is
never visible.

Bug: 8954116
Change-Id: I9f242d07b49ad60b625a22429bb013251e814905
2013-05-14 15:19:19 +09:00
Kurt Partridge
6fefc142cf Remove FeedbackLog instance variables.
For a while, the ResearchLogger supported comprehensive recording of the
last few words in case the user wished to upload this data to give
developers feedback.  However, this mechanism was not implemented well
(keeping a separate copy of the data), did not make the collected data
clear to the user, and was not working properly in the latest build (NPEs).
The mechanism in fact was deprecated in favor of the "userRecording"
mechanism in which the user explicitly turned on comprehensive recording,
demonstrated the issue they were experiencing, and then turned it off.

This change removes the vestiges of the FeedbackLogging mechanism.
A feedback log is still used to hold the user's message, but it is created
in a local variable as-needed, and not persisted in ResearchLogger.

Change-Id: I6a09d0ed36e1eddb6e57895e7428d22107f75f49
2013-05-13 20:37:15 -07:00
Kurt Partridge
b5c39f4531 Rename a var to match semantics
The IS_INHIBITING_AUTO_UPLOAD flag is tested in isPossibleToUpload, so it inhibits all uploads, not
just automatic ones.  Renaming to IS_INHIBITING_UPLOAD.

Change-Id: Iceed79260d4b062147f40c09f0c5bb06b2519b1b
2013-05-13 17:01:39 -07:00
Tadashi G. Takaoka
b121538e0c Tune maximum keypress duration to 100 milliseconds
Bug: 8556975
Change-Id: If7839c5764f7a269243a9570c0b7782b6f7ee73b
2013-05-13 20:04:59 +09:00
Tadashi G. Takaoka
5f857a359a Merge "Disable functional key while in sliding input mode" 2013-05-13 10:50:32 +00:00
Tadashi G. Takaoka
e3b1bdc4f1 Disable functional key while in sliding input mode
This change registers the functional key when sliding input mode is
end at the functional key itself.

Bug: 8915171
Change-Id: I2031e2aa4ebf33684221fc44d4a808112489724f
2013-05-13 19:39:57 +09:00
Tadashi G. Takaoka
b5f67e7faf Add device specific keypress vibration duration database
Bug: 8556975
Change-Id: I11260a64dc13c102bac7a9742dc66f2b05fd32de
2013-05-13 18:34:48 +09:00
Tadashi G. Takaoka
6b0bcfba9b Merge "Disable long press timer while sliding input mode" 2013-05-13 08:57:56 +00:00
Tadashi G. Takaoka
43ad100d8b Disable long press timer while sliding input mode
Bug: 8915171
Change-Id: Id8685f90766c7de55b56476de83abf97150a186d
2013-05-13 17:40:26 +09:00
Tadashi G. Takaoka
ad662adeef Disable delete key repeating while in slide input mode
Bug: 8915171
Change-Id: I04f84c29f10abc0207072d2165c75dd20f053f92
2013-05-13 17:23:08 +09:00
Tadashi G. Takaoka
18184eacb1 Support regular expression for condition pattern
Bug: 8556975
Change-Id: Iffc53d6a40dd77860434c5f7f4f59af5cd1ba92b
2013-05-13 16:25:03 +09:00
Tadashi G. Takaoka
ec83457d72 Merge "Support multiple condition for getDeviceOverrideValue" 2013-05-13 06:13:20 +00:00
Tadashi G. Takaoka
d69fa0a09a Support multiple condition for getDeviceOverrideValue
Bug: 8556975
Change-Id: I29d3a305b6ac3d8e3620c6d8592d85047d62bf48
2013-05-13 14:38:21 +09:00
Ken Wakasa
cb3bba3c4e Rename GesturePreviewTrail.java -> GestureTrail.java
Try reducing some confusions between GesturePreviewTrail.java and GestureTrailsPreview.java

Change-Id: I5fe2ee740cf1b32210530188153f6f6937e34b68
2013-05-13 13:42:22 +09:00
Kurt Partridge
7d72ca0b20 Avoid JsonWriter multi-write error
JsonWriter requires that its clients pass it only a single top-level object.
The existing implementation tries to make code cleaner by having mJsonWriter
never be null, and instead use a global static "NULL_JSON_WRITER" that just
discards data.  But because JsonWriter complains if more than one top-level
object is passed, making this a global object does not work.  This change
instead copes with mJsonWriter being null.

Change-Id: Ia37ccfc8646e91f11a64713dd92d2846eb86ac54
2013-05-10 18:21:08 -07:00
Kurt Partridge
260df84197 Merge "Remove unused code" 2013-05-10 22:12:11 +00:00
Kurt Partridge
bb17034f64 Merge "Remove ref to LatinImeLogger preference." 2013-05-10 20:41:52 +00:00
Kurt Partridge
4135c2db7b Merge "Avoid NPE by fixing ResearchLogger initialization" 2013-05-10 15:48:04 +00:00
Tadashi G. Takaoka
565ced4546 Merge "Refactor StringUtils.findPrefixedString to findValueOfKey" 2013-05-10 09:49:07 +00:00
Tadashi G. Takaoka
6d3d2ae064 Refactor StringUtils.findPrefixedString to findValueOfKey
Bug: 8556975
Change-Id: I275c99db8a0d10594a5a8c0c27ebc1a87495c307
2013-05-10 18:44:04 +09:00
Tadashi G. Takaoka
4705c0fa7c Fix screen flash when launching settings activity
Bug: 8336068
Change-Id: I90a0f259129a3f3319b158b060154cc43960c234
2013-05-10 15:36:24 +09:00
Tadashi G. Takaoka
2b5c9726f4 Introduce another activity to launch setup wizard
Bug: 8336068
Change-Id: I35b94dd87c5b01d3e927da8f918a5398dd565d33
2013-05-10 15:30:53 +09:00
Tadashi G. Takaoka
5ffa5bf3ba Merge "Keep SetupActivity alive to check re-launching from launcher" 2013-05-10 06:24:52 +00:00
Tadashi G. Takaoka
9ed322b40f Keep SetupActivity alive to check re-launching from launcher
Bug: 8336068
Change-Id: I183b8e3fd1b3898d5f8dbbb13a0c93c64341fc38
2013-05-10 15:15:53 +09:00
Jean Chalard
2564bd0937 Merge "Reuse old preferences if possible." 2013-05-10 05:56:32 +00:00
Jean Chalard
a2ec5e8338 Reuse old preferences if possible.
This is an optimization. It also happens to work around what
seems to be a framework bug in JB MR1 / MR1.1.

Bug: 8771179
Change-Id: I62cc7acdc8656d75f8a50c068c4e9d8c6ceb74a0
2013-05-10 14:41:36 +09:00
Tadashi G. Takaoka
2ad7023c54 Fix detecting out of keyboard area
Bug: 8885165
Change-Id: I85c78b23955169972fb0f5395463b6fe47f12c9c
2013-05-10 12:16:44 +09:00
Kurt Partridge
a68cace7d1 Avoid NPE by fixing ResearchLogger initialization
Previously, mMainResearchLog and mMainLogBuffer were set up
when the user moved to a new TextView, and set to null when
the user left the TextView.  This change causes
mMainResearchLog, mMainLogBuffer, mFeedbackLog, and
mFeedbackLogBuffer to be non-null forever after init() is
called.  start() no longer sets up these fields; instead
they are cleared and reset every time stop() is called.
Checks for null values are now removed.

The earlier code just didn't initialize these variables if
the user disabled logging, but since the new version
invariantly keeps these variables valid, we add a check for
whether the user has enabled logging in publishLogUnits().

Change-Id: Ifde3517f1cf924cfa33cda95fec24529b52b3c08
2013-05-09 18:38:32 -07:00
Kurt Partridge
011634163c Remove unused code
Change-Id: I192c67e9e8de44f073abc70ec85ebcdb36356c2e
2013-05-09 14:36:40 -07:00
Kurt Partridge
ef5d760ca4 Remove ref to LatinImeLogger preference.
This is a bug; the ResearchLogger uses ResearchSettings.readResearchLoggerEnabledFlag() instead,
which the user cannot change.  (We assume they will just switch to a different keyboard.)

Change-Id: Ib5731c9eeb2bc29d9cf8608033326674f5eb6f7b
2013-05-09 14:36:40 -07:00
Satoshi Kataoka
341f1b237b Tweak gesture debug
Change-Id: Iea11a095adb15fbf4be38f34542119f8bc7bcbff
2013-05-09 20:08:50 +09:00
Satoshi Kataoka
52cb409ac2 Don't resize debug array if production
Bug: 8556775
Change-Id: I46a10f8dc938cab493933f0f2b4e1f7779b24f6f
2013-05-09 19:22:24 +09:00
Satoshi Kataoka
b2c4c73064 Add debug facilities for gesture
Bug: 8556775
Change-Id: I9069b2b44356bbae9fa4aaf0b99c3d723a8c9c58
2013-05-09 19:19:11 +09:00
Satoshi Kataoka
b902109000 Fix usages of getEnabledInputMethodSubtypeList
Bug: 8450279
Change-Id: Ib8433442ae6ca6c28da2652bff687cdeaf7c196e
2013-05-09 17:07:19 +09:00
Jean Chalard
71d52474fd Merge "Optimizations and safeguards." 2013-05-08 10:11:49 +00:00
Satoshi Kataoka
eab27c1ef6 Merge "Add account e-mail addresses to the user dictionary" 2013-05-08 09:53:54 +00:00
Jean Chalard
9f9cc03277 Optimizations and safeguards.
- Don't call finishComposingText when useless.
- Add safeguards against calling setComposingRegion when the
  data returned by the editor is inconsistent.
- Cancel pending recorrection messages when new messages arrive.

Bug: 8842941
Bug: 8845001
Change-Id: I939701033cf5c2bbd85871ecf83e329021ddeb91
2013-05-08 18:47:10 +09:00
Tadashi G. Takaoka
5b8b76baa3 Merge "Move gesture preview trail parameters to resource" 2013-05-08 09:02:52 +00:00
Satoshi Kataoka
5648054667 Add account e-mail addresses to the user dictionary
Bug: 8683365
Change-Id: Id72540c515e61c3dd854892599645dd6d22b496d
2013-05-08 17:58:21 +09:00
Tadashi G. Takaoka
05124d0193 Move gesture preview trail parameters to resource
Bug: 7167303
Change-Id: I22b56588dc5a1c9d5eaec3a39b5f32c9e5a8a5b4
2013-05-08 17:51:45 +09:00
Satoshi Kataoka
faa94a2d0a Merge "Add owner's info to the dictionary" 2013-05-08 08:31:45 +00:00
Satoshi Kataoka
fc6d4a5412 Add owner's info to the dictionary
Bug: 8683365
Change-Id: I1c30eac128b4172526423ebeeb45bc6cee7fb67b
2013-05-08 17:29:04 +09:00
Satoshi Kataoka
6435c80087 Merge "Fix an issue on the transition between the setup and the settings" 2013-05-08 08:23:49 +00:00
Tadashi G. Takaoka
331d256f21 Fix an issue on the transition between the setup and the settings
Bug: 8853220

Change-Id: I99b6c46d900e9391f77986d1ae6e3edeaeff01e5
2013-05-08 15:18:45 +09:00
Satoshi Kataoka
f59c4f6840 Fix labels in the personal dictionary settings
Bug: 8855738
Bug: 8853764
Change-Id: I03383bb5d6d72645f511cc6175dec747eb13a840
2013-05-08 14:58:43 +09:00
Satoshi Kataoka
244a24e368 Consolidate dummy proximity info to the spell checker info
Bug: 8783170

Change-Id: I067486e5ec1ae7cdef8e2121392464ba71ee8add
2013-05-08 11:49:12 +09:00
Kurt Partridge
8064c669fe Fix looping logic bugs.
shiftOut() is getting called once too often through these for loops.

Change-Id: I9a68b49e6cc1469bcddd673ab1567e238cf192b8
2013-05-07 08:33:31 -07:00
Tadashi G. Takaoka
104bb70c65 Merge "Avoid drawing too long gesture preview trails" 2013-05-07 11:58:09 +00:00
Jean Chalard
2afe88b8d7 Merge "Unify space-adding on gestures." 2013-05-07 11:51:01 +00:00
Tadashi G. Takaoka
80e396d83c Avoid drawing too long gesture preview trails
Bug: 7167303
Change-Id: I63c2e8fb60f76e80346b67fd44399fa91930f2f0
2013-05-07 20:48:46 +09:00
Jean Chalard
e8b9b35471 Unify space-adding on gestures.
This is much simpler, and more correct.

Bug: 8808497
Change-Id: I7a56bf9d6d9fb481f898b7a9f5898a86c11b34c0
2013-05-07 20:38:09 +09:00
Satoshi Kataoka
a9dd74cf3f refactor spell checker
Change-Id: Ie7bea23f2ac54f03572e77c31ba7cb3d5e8f8d2f
2013-05-07 20:21:11 +09:00
Tadashi G. Takaoka
9d71a6c968 Remove unused device form factor values
Change-Id: I1ed88b842a3d45e5460dd387bfad4276c844096a
2013-05-07 18:52:22 +09:00
Tadashi G. Takaoka
84ac8f31fb Move empty listner to KeyboardActionListener.Adapter
Change-Id: Ic7bad73c089de015746c667bbfb2c09bd429a9fc
2013-05-07 16:40:15 +09:00
Tadashi G. Takaoka
61b6fc7d7b Clean up unused static variable
Change-Id: I51c5903b7716d3927d2ff09a5054725215a626b5
2013-05-07 16:36:32 +09:00
Tadashi G. Takaoka
ce67b41661 Record down point as gesture preview trail for sure
Change-Id: Ic712a6af8229a9a1aa4a5419d779927f1ef8be67
2013-05-07 15:51:23 +09:00
Tadashi G. Takaoka
4ddf1e47a7 Remove unused gesture preview trail code
Change-Id: I2aa77675628a4b1655b30852c950f5daae6f0a92
2013-05-07 14:27:34 +09:00
Tadashi G. Takaoka
a5be033d4a Preserve setup wizard step while orientation change
Bug: 8159728
Change-Id: I596f59749443b8878b5613285f0fe793d449cdbd
2013-05-02 18:42:10 +09:00
Tadashi G. Takaoka
7d19ab5c9d Using int instead of booleans to save keyboard shift state
This is a follow up of Ib2bc262aac.

Bug: 8734294
Change-Id: I0b56797ffc4f16e18da72352777fe0f000d173aa
2013-05-02 16:21:39 +09:00
Tadashi G. Takaoka
7f8dd50b8f Save automatic shift state while orientation changing
Bug: 8734294
Change-Id: Ib2bc262aacedf786a318c2fe1bd4420a21e7d847
2013-05-02 15:48:56 +09:00
Jean Chalard
83757d439e Merge "Pass blockOffensiveWords as a parameter" 2013-05-01 11:57:36 +00:00
Jean Chalard
2dbb5957e3 Pass blockOffensiveWords as a parameter
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
2013-05-01 20:47:35 +09:00
Ken Wakasa
1490b53416 Cleanup -- follow up to Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
Change-Id: Icb89c5119a67edaa019d5f7645b734cfcfc29041
2013-05-01 20:19:05 +09:00