nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Tiny refactoring

Browse source 
Add a warning comment and make it so that openNative()
is only called in one place in the code.

Bug: 11281748
Change-Id: Ic7819a01deb62cf145ebf9d620da2d15fae19313
This commit is contained in:
Jean Chalard 2013-12-03 15:42:59 +09:00
parent b6764c51ab
commit 25848af556
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
java/src/com/android/inputmethod/latin/BinaryDictionary.java
View file

@ -376,7 +376,10 @@ public final class BinaryDictionary extends Dictionary {
private void reopen() {
close();
final File dictFile = new File(mDictFilePath);
mNativeDict = openNative(dictFile.getAbsolutePath(), 0 /* startOffset */,
// WARNING: Because we pass 0 as the offstet and file.length() as the length, this can
// only be called for actual files. Right now it's only called by the flush() family of
// functions, which require an updatable dictionary, so it's okay. But beware.
loadDictionary(dictFile.getAbsolutePath(), 0 /* startOffset */,
dictFile.length(), true /* isUpdatable */);
}