Jean Chalard
805fed49e1
Merge "Fix binary reading code performance."
2012-04-23 23:39:37 -07:00
Tadashi G. Takaoka
fe4d13cbcb
Merge "Make the "Touch again to save" hint text touchable."
2012-04-23 23:20:49 -07:00
Jean Chalard
1d80a7f395
Fix binary reading code performance.
...
This is not the Right fix ; the Right fix would be to read
the file in a buffered way. However this delivers tolerable
performance for a minimal amount of code changes.
We may want to skip submitting this patch, but keep it around
in case we need to use the functionality until we have a good
patch.
Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
2012-04-24 15:16:17 +09:00
Jean Chalard
cbebbaf065
Merge "Fix a bug where a node size would be seen as increasing."
2012-04-23 22:19:19 -07:00
Jean Chalard
a64a1a46e4
Fix a bug where a node size would be seen as increasing.
...
The core reason for this is quite shrewd. When a word is a bigram
of itself, the corresponding chargroup will have a bigram referring
to itself. When computing bigram offsets, we use cached addresses of
chargroups, but we compute the size of the node as we go. Hence, a
discrepancy may happen between the base offset as seen by the bigram
(which uses the recomputed value) and the target offset (which uses
the cached value).
When this happens, the cached node address is too large. The relative
offset is negative, which is expected, since it points to this very
charnode whose start is a few bytes earlier. But since the cached
address is too large, the offset is computed as smaller than it should
be.
On the next pass, the cache has been refreshed with the newly computed
size and the seen offset is now correct (or at least, much closer to
correct). The correct value is larger than the previously computed
offset, which was too small. If it happens that it crosses the -255 or
-65335 boundary, the address will be seen as needing 1 more byte than
previously computed. If this is the only change in size of this node,
the node will be seen as having a larger size than previously, which
is unexpected. Debug code was catching this and crashing the program.
So this case is very rare, but in an even rarer occurence, it may
happen that in the same node, another chargroup happens to decrease
it size by the same amount. In this case, the node may be seen as
having not been modified. This is probably extremely rare. If on
top of this, it happens that no other node has been modified, then
the file may be seen as complete, and the discrepancy left as is
in the file, leading to a broken file. The probability that this
happens is abyssally low, but the bug exists, and the current debug
code would not have caught this.
To further catch similar bugs, this change also modifies the test
that decides if the node has changed. On grounds that all components
of a node may only decrease in size with each successive pass, it's
theoritically safe to assume that the same size means the node
contents have not changed, but in case of a bug like the bug above
where a component wrongly grows while another shrinks and both cancel
each other out, the new code will catch this. Also, this change adds
a check against the number of passses, to avoid infinite loops in
case of a bug in the computation code.
This change fixes this bug by updating the cached address of each
chargroup as we go. This eliminates the discrepancy and fixes the
bug.
Bug: 6383103
Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
2012-04-24 14:04:02 +09:00
Tadashi G. Takaoka
9f763d1445
Make the "Touch again to save" hint text touchable.
...
Bug: 6355346
Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
2012-04-24 13:44:14 +09:00
Tadashi G. Takaoka
3e3bb36f1f
Fix NPE in AdditionalSubtypeSettings
...
Bug: 6384416
Change-Id: I878071b8b78acce51649f9637b59830ab681c696
2012-04-24 11:01:45 +09:00
Jean Chalard
fa1affbaec
Merge "Fix a bug where two spaces would be added instead of one"
2012-04-23 17:03:32 -07:00
Jean Chalard
5ee0ee0dbe
Merge "Fix a bug where a batch edit would not be started."
2012-04-23 17:02:41 -07:00
Jean Chalard
87f7fa12db
Merge "Pass words as int[] to the native code."
2012-04-23 17:02:26 -07:00
Tom Ouyang
bebcae8ff5
Merge "Binary bigram lookup checks both uppercase and lowercase when previous word is uppercase."
2012-04-23 09:06:05 -07:00
Jean Chalard
551612dd9e
Fix a bug where two spaces would be added instead of one
...
Bug: 6378291
Change-Id: Id2453333ae16146f816faf0eb68baa8ea1dd106a
2012-04-23 18:15:51 +09:00
Jean Chalard
96fb3094aa
Fix a bug where a batch edit would not be started.
...
This would end up in TextView sometimes calling onUpdateSelection
multiple times (this is the correct behavior for TextView). We now
commit the space and the word in a batch edit, and we only get
onUpdateSelection once.
Bug: 6300527
Change-Id: I9579f3d8f5320c1cc24a7a42f19db8e105eb090d
2012-04-23 17:45:50 +09:00
Jean Chalard
522a04ea5b
Pass words as int[] to the native code.
...
We need to get the bigrams during the call to getSuggestions for
bug#6313806. We already give an int[] to getSuggestions and we
wanted to get rid of char[]'s anyway because it doesn't work with
surrogate pairs, so here we go.
Bug: 6313806
Change-Id: I56ce99f1db6b3302cdf42f0527343bded837091e
2012-04-23 16:05:36 +09:00
Tadashi G. Takaoka
e060d1a540
Merge "Fix using keyboard layout display name in custom input style spinner"
2012-04-22 23:16:57 -07:00
Tadashi G. Takaoka
a245be6819
Fix using keyboard layout display name in custom input style spinner
...
Change-Id: I80626591574aa9995011202cf868f9c2c5168303
2012-04-23 13:54:58 +09:00
Jean Chalard
0df78d46da
Use the best matching cached dictionary for each category
...
Bug: 6327270
Change-Id: I5a0e732c8a3fd55fd8ac3c8fe1c58e7f91555d97
2012-04-23 12:37:52 +09:00
Tom Ouyang
0806bb01d9
Binary bigram lookup checks both uppercase and lowercase when previous word is uppercase.
...
Bug: 6363029
Change-Id: I71a1ed5b88f54fcc15bfaf89d3645b8f17ebb821
2012-04-22 17:48:00 -07:00
Ken Wakasa
1894c6e586
Remove unused methods and classes
...
Change-Id: I1a82bf2202d436efa4c5135d705a048fe45a0257
2012-04-22 18:48:54 +09:00
Ken Wakasa
f8ad37a8fc
Remove an unused method
...
Change-Id: I3abbf6462c31b11167e356fe77b8afca2514a869
2012-04-22 12:50:01 +09:00
Tadashi G. Takaoka
118762b444
Merge "Predefined keyboard layouts are configurable via XML resource"
2012-04-20 03:24:39 -07:00
Tadashi G. Takaoka
38026b4f03
Predefined keyboard layouts are configurable via XML resource
...
Bug: 4460018
Change-Id: Ia03ec826fb3853ea814d9764686903dbe31a6507
2012-04-20 19:19:24 +09:00
Jean Chalard
04b03f4dd6
Allow using a format version 2 word list in LatinIME
...
Change-Id: I73a4df3a83e49be6e8d3a7d14eb027cfe10f1a23
2012-04-20 18:56:03 +09:00
Tadashi G. Takaoka
78173bdf53
Support Dvorak layout
...
Bug: 4460018
Change-Id: I08a9b556720f6c4f7089a8838c0869c9f88f479c
2012-04-20 17:28:32 +09:00
Jean Chalard
29a1fc0f6b
Don't allow cancelling manual pick.
...
Bug: 6347202
Change-Id: I30b53256e83c534436b0f0ff594fd4aaabf4558c
2012-04-20 15:55:45 +09:00
Kurt Partridge
5b92113cdb
Merge "remove unnecessary KeyboardState logging"
2012-04-19 20:53:44 -07:00
Kurt Partridge
4d43d6f96e
Merge "researchLogger detail on IME sessions"
2012-04-19 20:35:21 -07:00
Kurt Partridge
c59d74ce47
remove unnecessary KeyboardState logging
...
Bug: 6188932
Change-Id: Iafbb1825777122a1810fa3339853263aced3077e
2012-04-19 20:32:37 -07:00
Kurt Partridge
48a7681e06
researchLogger detail on IME sessions
...
log device type, screen size, etc. also simplification inside ResearchLogger
to use exceptions better, and fix ResearchLoggerTests to not change
preferences to specify the logfile.
multi-project change with Idfd193b16260215cca32886e288f03a0c12b2781
Bug: 6188932
Change-Id: Idd3ca6eb8e8e3934f68234b241c7fd7d0cc3bcd5
2012-04-19 20:19:55 -07:00
Tom Ouyang
7cdb560513
Merge "Change binary dictionary output buffer size to match dictionary size."
2012-04-19 17:18:59 -07:00
Tom Ouyang
df7ebbbd61
Change binary dictionary output buffer size to match dictionary size.
...
Bug: 6355943
Change-Id: Iaab7bc16ba0dbc7bfde70b06e7bd355519838831
2012-04-19 10:18:57 -07:00
Tadashi G. Takaoka
6a7019ff5d
Move main dictionary availability check to LatinIME
...
Change-Id: Ib6183fec833d87bc32514b03bb691fec0a1e6ff8
2012-04-19 23:23:26 +09:00
Tadashi G. Takaoka
65e93e352f
Fix SubtypeSwitcher to honor subtype
...
Bug: 6364170
Change-Id: I31f9a7c9b6b4ca04a1c78a4210dcaae0db9825db
2012-04-19 22:42:14 +09:00
Tadashi G. Takaoka
b9fca7a192
Fix stack overflow
...
Change-Id: I977b240ea462b40852ba9504282312d5fa4e2885
2012-04-19 20:21:02 +09:00
Tadashi G. Takaoka
ab39afca23
Remove LatinIME reference from DictionaryFactor class
...
Change-Id: Iad10e71baa81a1b4eb3c84ead47d658d567b8201
2012-04-19 19:57:43 +09:00
Tadashi G. Takaoka
1cb08acaf3
Add Constants class to hold public constants
...
This change also gets rid of compiler warnings about "deprecations".
Change-Id: Id9b83483c453a81ebac34b684656db05e3599657
2012-04-19 19:45:19 +09:00
Tadashi G. Takaoka
c27fe6253c
Add custom subtype settings
...
Bug: 4460018
Change-Id: I4919d79516dcf574be2761bbaf9adcdc381b2ddc
2012-04-19 19:33:51 +09:00
Tadashi G. Takaoka
344af15674
Change predefined additional subtype format in preference
...
This change also refactor StringUtils class
Change-Id: Ie0b4d169b21c260bf238d6fcc9ab0ee8bfd6b508
2012-04-19 17:11:21 +09:00
Tadashi G. Takaoka
f5a0bd2c28
Make predefined subtype configurable by XML resource
...
Change-Id: I1f8486a1fb652f1e06789e7bfd2cc57273092234
2012-04-18 22:45:26 +09:00
Tadashi G. Takaoka
55d28fd1b2
Cleanup InputMethodManagerCompatWrapper
...
Change-Id: Id3b84ee19bb504ed8fbb398e260cc663a5b5ae0d
2012-04-18 18:01:29 +09:00
Tadashi G. Takaoka
a58ebc73ae
Fix typo of some methods' name
...
Also changes some methods' argument type from Locale to String.
Change-Id: Ib68b528a450dc68a01546483403230f76500bee4
2012-04-18 16:40:50 +09:00
Kurt Partridge
d442984e96
researchLogging for inputConnection events
...
Bug: 6188932
Change-Id: I596df68956abd879293cfb550e66e7d7d0ba74e9
2012-04-17 20:05:10 -07:00
Tadashi G. Takaoka
18178fefdc
Merge "Remove useless key event handling methods"
2012-04-17 19:58:05 -07:00
Tadashi G. Takaoka
79e07e3f84
Remove useless key event handling methods
...
Change-Id: I8c42fba79aba643ab7a145e6fd54ef23855a3ad0
2012-04-18 11:55:11 +09:00
Jean Chalard
bde232dcaa
Merge "Pass the previous word down to native code in getSuggestions"
2012-04-17 18:01:05 -07:00
Tadashi G. Takaoka
69bcc15cb3
Add SubtypeUtils.setAditionalInputMethodSubtypes method
...
Change-Id: Ia3043346ed87297e01d505980555fdf29ce4f96f
2012-04-17 22:48:00 +09:00
Jean Chalard
80111f08e2
Pass the previous word down to native code in getSuggestions
...
Change-Id: I477b631d81ef58461e44954f3ae5fd895928bb97
2012-04-17 20:07:10 +09:00
satok
74a84febc7
Cache results of the spell checker
...
Change-Id: Ie11cd1b07e069474b140fbaae65fca703adc056f
2012-04-17 19:45:57 +09:00
Tadashi G. Takaoka
761b6bc120
Merge "Add SubtypeLocale.getKeyboardLayoutSetDisplayName"
2012-04-17 03:08:59 -07:00
Tadashi G. Takaoka
bb17bafac3
Add SubtypeLocale.getKeyboardLayoutSetDisplayName
...
Change-Id: I576b47a936545e653ce9e26222ba4db143ea90e6
2012-04-17 18:55:51 +09:00
Jean Chalard
1277692519
Merge "Pass the previous word to getSuggestions"
2012-04-16 20:56:03 -07:00
Jean Chalard
ac27e4544b
Pass the previous word to getSuggestions
...
This is a preparative change to bug#6313806
Change-Id: I1be9ec49b21005c1f45ce459fa93712bc74ef3f0
2012-04-17 12:43:53 +09:00
Kurt Partridge
9bfb620215
add logPoint for manual correction (inc touch pos)
...
Bug: 6188932
Change-Id: Ibcc4901bcfab6632ee4c59cb58d35452218a288d
2012-04-16 16:52:25 -07:00
Tadashi G. Takaoka
8b833071a1
Fix Settings fragment isn't shown on tablet
...
Bug: 6341510
Change-Id: I319bb72400995d8385b0b14ef25b164dee3974da
2012-04-16 16:36:28 +09:00
Tadashi G. Takaoka
11a40a047f
Make Utils.getDeviceOverrideValue aware of device orientation
...
Bug: 6277225
Change-Id: If41fe5cbee0985b9a4740dcd5d1c6ba73b94b377
2012-04-16 12:59:55 +09:00
Tom Ouyang
a7352c8df4
Merge "Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams."
2012-04-13 18:30:19 -07:00
Tom Ouyang
18222f8c86
Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams.
...
Bug: 6188977
Change-Id: I753422eed1effaeb5fd01124cf1ddd1e31ee9d60
2012-04-13 17:54:39 -07:00
Kurt Partridge
2783c51e6d
Merge "clean up researchLogging of autocorrection"
2012-04-13 10:47:19 -07:00
Tadashi G. Takaoka
c206d04623
Use InputMethodSettingsFragment for IME settings
...
Change-Id: Id6d9cd0ddf99c0687b6d3ea4b2f868f6cf2a0eaf
2012-04-13 19:56:47 +09:00
Tadashi G. Takaoka
f6972561fc
Utilize InputMethodSubtype and additional subtype
...
* Remove de_QY and fr_CH from supported subtypes
* Add de-qwerty and fr-qwertz predefined additional subtypes instead.
Change-Id: I49e8ba0299529302f2b91b4d018b07304cdd6897
2012-04-13 18:36:26 +09:00
Tadashi G. Takaoka
8abde7db6b
Refatcor InputMethodSubtype related stuff a bit
...
Change-Id: Iaded72331660afbaeddda085f2b633b681d4b6df
2012-04-13 16:24:11 +09:00
Kurt Partridge
60adb87574
clean up researchLogging of autocorrection
...
remove dependence of ResearchLogger on LatinImeLogger
for autocorrection
multi-project commit with I32cc134b
Bug: 6188932
Change-Id: Iaeda97eb43fa4782db2d1b2a6d8d09a93b395111
2012-04-12 22:59:21 -07:00
satok
cf6b2099be
Add isDictionaryAvailable to SubtypeSwitcher
...
Change-Id: I534878d330b57bbfaa8b7711082456969771f4dc
2012-04-12 19:46:02 +09:00
Jean Chalard
cec8552b18
Pass a parameter to the dict pack if we don't have a default dict
...
Also, optimize quite a bit the code that decides whether we have
a default dict or not.
Bug: 5705834
Change-Id: Ied20fbcbbc42cbe8c01759d11b1804d1156c6960
2012-04-12 13:05:31 +09:00
Kurt Partridge
fed44d08d8
Merge "change ResearchLoggerTests to check file"
2012-04-11 13:19:52 -07:00
Kurt Partridge
b8e2ae3bc3
change ResearchLoggerTests to check file
...
multi-project commit with I587003f2
Bug: 6188932
Change-Id: I3d3f0c9d011301489473dc330338ea4a7ba61e9e
2012-04-11 11:17:44 -07:00
Jean Chalard
e6269759d6
Read the dictionary resource in a more sensical place.
...
We don't need to pass this down all the way from LatinIME any more.
It fetched be done exactly where it needs to be.
Change-Id: I9f277f9c4f9de70ae755a1334d86c67bbb24c988
2012-04-11 21:03:21 +09:00
Tadashi G. Takaoka
78ab80844b
Add language suffix to main dictionary
...
Bug: 6319377
Change-Id: Ie6a887fefa12e33c17bfeb5d22984e7c1a7bdb46
2012-04-11 16:11:34 +09:00
Tadashi G. Takaoka
2be51f4fd0
Generate KeyboardLabelsSet from donottranslate-more-keys.xml
...
This change introduces makelabel tool that reads all languages'
donottranslate-more-keys and generate KeyboardLabelsSet.java source
file. The makelabel command must be invoked prior to compile LatinIME.
Change-Id: I7515c7919c535e30f9c80a37bdc831d0f682cd43
2012-04-11 11:23:47 +09:00
Tom Ouyang
ecd2ac93bc
Add an expandable binary dictionary that can be modified at runtime and works with native algorithms.
...
Bug: 6188977
Change-Id: Iec5c4e7d1d3918ac645187bd32dc3f82a95fec1e
2012-04-10 10:17:52 -07:00
Kurt Partridge
a9ca7867b5
move suggested words logpoint to SuggestionsView.java
...
Bug: 6188932
Change-Id: I73974783783bb4453962cb9009656d86d2074409
2012-04-09 16:24:29 -07:00
Kurt Partridge
9bc29d78a6
add more data collection points to ResearchLogger (attempt #2 )
...
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.
multi-project change with I159f5de2
this CL is the same as I618bcd07, which was reverted because of
incompatibilities with vendor branches.
Bug: 6188932
Change-Id: I999249dceb0c04f5a4ffbfff25caed09d24a2c52
2012-04-09 09:38:07 -07:00
Kurt Partridge
d16bda4a4a
Revert "add more data collection points to ResearchLogger"
...
This reverts commit ac9e87c03e
2012-04-06 18:26:34 -07:00
Kurt Partridge
ac9e87c03e
add more data collection points to ResearchLogger
...
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.
Bug: 6188932
Change-Id: I618bcd07b22c9efc794745678b073afe1e79a697
2012-04-06 09:35:13 -07:00
Jean Chalard
b5e1f48987
Remove the now useless Flag class.
...
Change-Id: Ibe45189b73e2606cf77e30da166dd0d45ae47c5c
2012-04-06 19:47:16 +09:00
Jean Chalard
338d3ec725
Replace the flags in getSuggestions with a boolean.
...
Change-Id: I0ec44df1979cb1dc21017ea290d2151a2af0e7cd
Conflicts:
java/src/com/android/inputmethod/latin/Suggest.java
2012-04-06 19:34:48 +09:00
Jean Chalard
24aee9100e
Change the flags to a boolean in constructors.
...
Change-Id: I9939204f3b16346aaebd4d726315ba9c4faf910a
2012-04-06 19:33:01 +09:00
Jean Chalard
f420df2823
Add support for German umlaut and French ligatures flags
...
Bug: 6202812
Change-Id: Ib4a7f96f6ef86c840069b15d04393f84d428c176
2012-04-06 17:07:29 +09:00
Jean Chalard
b8060399c7
Remove constructors
...
And small cleanup.
Change-Id: I1de903f42c1b8d57a488be2162e0b94055a6d1f2
2012-04-06 16:53:15 +09:00
Jean Chalard
8cf1a8d04f
Remove the shortcutOnly attribute which is now useless.
...
Change-Id: Ifccdfdaf7c0066bb7728981503baceff0fedb71f
2012-04-06 16:27:53 +09:00
Tadashi G. Takaoka
b6313f7275
Merge "Cleanup unused methods"
2012-04-05 23:46:56 -07:00
satok
7540fd009d
Merge "Fix the locale of the flags in BinaryDicitonary for tests"
2012-04-05 22:33:17 -07:00
Tadashi G. Takaoka
a4c7733cf7
Cleanup unused methods
...
Change-Id: Ic7c1ec0e0606da6eb5b954934547c6e8a561fed5
2012-04-06 12:27:53 +09:00
Tadashi G. Takaoka
fc169c726a
Merge "Use keyboardSet extra value of subtype to specify layout type"
2012-04-05 19:17:30 -07:00
Jean Chalard
af7d86c5b8
Merge "Update the names and default values of bigram options."
2012-04-05 05:08:56 -07:00
Jean Chalard
80f2ccc236
Update the names and default values of bigram options.
...
Bug: 6293595
Change-Id: I9978a1127c64b7a26a5ccf6f777366f7c4e214db
2012-04-05 21:07:40 +09:00
Ken Wakasa
aa300bb73a
Don't draw red underline for manually picked words that came from bigram prediction
...
Change-Id: I544680c8b4b1baff71bd08168630a34e803c40b9
2012-04-05 20:50:27 +09:00
Tadashi G. Takaoka
11d9ee742f
Use keyboardSet extra value of subtype to specify layout type
...
Change-Id: Ice1f345a08a8d760e3b847c885c4072e3e142c97
2012-04-05 17:25:15 +09:00
satok
ae234abd21
Fix the locale of the flags in BinaryDicitonary for tests
...
Bug: 6129372
Change-Id: I5611f88b10c44261b6145c9dc8615b80e4341e77
2012-04-05 12:48:30 +09:00
Tadashi G. Takaoka
cb389ef0d6
Refactor to utilize InputMethodSubtype
...
Change-Id: I76fbc8a395eb8dab996c02c86d7328f07865f8cf
2012-04-05 12:27:27 +09:00
satok
43ebd8a035
Fix the locale of flags in BinaryDictionary
...
Bug: 6129372
Change-Id: I4958c2aabf651d7e26648a29b75fcc6c77813451
2012-04-04 21:50:42 +09:00
Tadashi G. Takaoka
b082c95a2b
Use no language "zz" to disable shortcut key
...
Change-Id: Ifba5bbd4298ecf84cc5e0ebdb4fc8494eafff62e
2012-04-04 14:35:55 +09:00
Tadashi G. Takaoka
c7e43a7aec
Merge "Use language agnostic QWERTY for forceAscii"
2012-04-03 21:06:52 -07:00
Tadashi G. Takaoka
234bf612ca
Merge "Use "No language (QWERTY)" for language agnostic QWERTY keyboard name"
2012-04-03 21:03:10 -07:00
Tadashi G. Takaoka
32bfc1601a
Use language agnostic QWERTY for forceAscii
...
Bug: 6286208
Change-Id: I1b3b6f04c9033e7dc57a30e8dce43e01428b8e4e
2012-04-04 12:59:58 +09:00
Tadashi G. Takaoka
3bf57a5624
Use "No language (QWERTY)" for language agnostic QWERTY keyboard name
...
Bug: 6010147
Change-Id: I401c2e3fcd639c0e1a03e64489a0d792810caa18
2012-04-04 12:58:42 +09:00
satok
d8af793983
Merge "Fix NPE in SuggestedWords"
2012-04-03 19:23:03 -07:00
satok
f088204a90
Fix NPE in SuggestedWords
...
Bug: 6279966
Change-Id: Ia94a78d79cc51014126d18612aabdc7ce51487a4
2012-04-04 11:09:13 +09:00
Tadashi G. Takaoka
d2c5533fd9
Merge "Add RunInLocale class to guard locale switching"
2012-04-03 01:53:05 -07:00
Tadashi G. Takaoka
56dda78d52
Merge "Cleanup InputTypeCompatUtils to InputTypeUtils"
2012-04-03 01:50:08 -07:00
Tadashi G. Takaoka
16c6f35570
Add RunInLocale class to guard locale switching
...
Bug: 6128216
Change-Id: I8d9c75c773c3de886183b291ada7a3836295839b
2012-04-03 17:43:45 +09:00
Tadashi G. Takaoka
be55086fd9
Cleanup InputTypeCompatUtils to InputTypeUtils
...
Bug: 6129704
Change-Id: I45e19e456ef7c6e61fe877ea544fef1b9f896e95
2012-04-03 17:42:19 +09:00
Tadashi G. Takaoka
b07939764a
Merge "Fix typo"
2012-04-03 01:31:47 -07:00
Tadashi G. Takaoka
8f433a66b2
Fix typo
...
Follow up for I5b9964f2
Bug: 6129704
Change-Id: Ia90c013cf4c4e6f675da5701644bd10833898c3f
2012-04-03 17:27:51 +09:00
Tadashi G. Takaoka
244c825c4b
Merge "Cleanup EditorInfoCompatUtils"
2012-04-03 00:49:55 -07:00
Tadashi G. Takaoka
7a0779a441
Merge "Cleanup FrameLayoutCompatUtils to ViewLayoutUtils"
2012-04-03 00:47:32 -07:00
Tadashi G. Takaoka
0d1a5d5b97
Cleanup EditorInfoCompatUtils
...
Bug: 6129704
Change-Id: I5b9964f2ad52e7cd60c63acca93d0241a1e729ef
2012-04-03 16:45:36 +09:00
Tadashi G. Takaoka
13d6ecc4c2
Remove InputMethodServiceCompatWrapper
...
Bug: 6129704
Change-Id: I76f2854e27623be940a711d0d48fd3f90132141c
2012-04-03 16:02:09 +09:00
Tadashi G. Takaoka
8443af57ba
Merge "Remove InputMethodSubtypeCompatWrapper"
2012-04-02 23:57:43 -07:00
Tadashi G. Takaoka
9cc2c94c8b
Remove InputMethodSubtypeCompatWrapper
...
Bug: 6129704
Change-Id: I8f84f0f61a2205ac1fcd1cd40e3a586ee535282d
2012-04-03 15:31:26 +09:00
Jean Chalard
c734c2aca1
Add a simple way to input dictionary header attributes
...
Just add them as an attribute to the root of the XML node.
Bug: 6202812
Change-Id: Idf040bfebf20a72f9e4370930a85d97df593f484
2012-04-03 15:18:51 +09:00
Tadashi G. Takaoka
19457316c1
Remove CAN_HANDLE_ON_CURRENT_INPUT_METHOD_SUBTYPE_CHANGED boolean
...
Bug: 6129704
Change-Id: I7643e656c6e7656eff339cc301dd32f34dee83a4
2012-04-02 23:22:49 +09:00
Tadashi G. Takaoka
b1904ec235
Merge "Remove InputMethodInfoCompatWrapper"
2012-04-02 07:14:20 -07:00
Tadashi G. Takaoka
c8461d1ae2
Cleanup FrameLayoutCompatUtils to ViewLayoutUtils
...
Bug: 6129704
Change-Id: I52f2e236c7dae3ac2cba64392165f955a53d3f42
2012-04-02 22:55:12 +09:00
Tadashi G. Takaoka
0dbf6ab53d
Remove InputMethodInfoCompatWrapper
...
Bug: 6129704
Change-Id: I0eca1ee7d1769ddc44f93c50f0723196299bc6d6
2012-04-02 21:33:49 +09:00
satok
7e518d8b83
Combine candidate words and scores
...
Bug: 5240798
Change-Id: Ie56c1c2cfd7f365e771fee88c1ed15012448feed
2012-04-02 18:39:24 +09:00
satok
209dd09e5a
Come back the proximity correction to ExpandableDictionary
...
Bug: 6242539
Change-Id: Ic0467d54c9d85d0653812d4e127328878ef15b94
2012-04-02 15:01:21 +09:00
Ken Wakasa
96fdc4dd84
Remove InputConnectionCompatUtils
...
Also, small cleanup in proguard.flags
bug: 6129704
Change-Id: If4cc694dbe74b26b1d0da301bbc321ee7afc0211
2012-03-31 19:04:38 +09:00
Ken Wakasa
672635493e
Remove ArraysCompatUtils
...
bug: 6129704
Change-Id: I0f1a0dee744e6dcdea7ae8606119b4af22b86663
2012-03-30 22:50:53 +09:00
Ken Wakasa
376eb52450
Move VibratorCompatWrapper to VibratorUtils.
...
bug: 6129704
Change-Id: Ib63f1ed2d610e27e14957cf8805ef884cae6adf6
2012-03-30 19:23:12 +09:00
Tadashi G. Takaoka
fb5b4c4fc3
Add language agnostic QWERTY subtype
...
Bug: 6010147
Change-Id: I705e38ac889172ae8b7c2a68e5c688f2ffc28320
2012-03-30 18:20:52 +09:00
Ken Wakasa
911b8f9d19
Remove the "deprecated" classes
...
bug: 6129704
Change-Id: Ib27f2774444e1f084b19be3fe6f56d25dffa7084
2012-03-30 16:20:56 +09:00
Kurt Partridge
347fcab043
improve ResearchLogger performance
...
also demonstrate proposed logpoint invocation
Bug: 6188932
Change-Id: Ib6a7a196fe2e5f8184d26d1e0e3e91b404454112
2012-03-29 15:37:41 -07:00
Tadashi G. Takaoka
8acbce1f78
Merge "Separate leftward arrow from "add to dictionary" hint text"
2012-03-29 01:20:07 -07:00
Tadashi G. Takaoka
20b4c223b4
Merge "Fix some obvious compiler warnings"
2012-03-29 00:18:36 -07:00
Tadashi G. Takaoka
499c5e8ad8
Merge "Don't send touch coordinates if proximity characters correction is disabled"
2012-03-29 00:18:28 -07:00
Tadashi G. Takaoka
8dcad2ed47
Don't send touch coordinates if proximity characters correction is disabled
...
Bug: 6225317
Change-Id: I4fa65e020d838f53066d4a071f58fb6f40583e0b
2012-03-29 16:11:54 +09:00
Tadashi G. Takaoka
aaa9e8626a
Merge "Fix race condition while changing the system locale"
2012-03-29 00:10:35 -07:00
Tadashi G. Takaoka
2eb8781dc2
Separate leftward arrow from "add to dictionary" hint text
...
Bug: 6008875
Change-Id: I2be1698e485bc6541163771f41b8b82eaa3cee7a
2012-03-29 15:58:26 +09:00
Tadashi G. Takaoka
c61cd79229
Fix some obvious compiler warnings
...
Change-Id: I10a634f7492b45d5a72345f14d36cf341946387d
2012-03-29 15:07:53 +09:00
Tadashi G. Takaoka
7769b76fc9
Fix race condition while changing the system locale
...
Bug: 6128216
Change-Id: Ie153e3eb18feeb97aada6a7708075f5152f11999
2012-03-29 14:36:45 +09:00
Kurt Partridge
2d9483ff16
make ResearchLogger log write only
...
Bug: 6188932
Change-Id: I8a8f944b1d4ee858d5ecaad0d3adc6dc7af54f68
2012-03-28 17:36:05 -07:00
Jean Chalard
428484d6f9
Merge "Remove useless adding of shortcut as unigrams."
2012-03-28 04:41:05 -07:00
Jean Chalard
e705a122d1
Remove useless adding of shortcut as unigrams.
...
Change-Id: I1f50ebf00d6dd0dad4114fad86ace5b7b304613a
2012-03-28 20:40:38 +09:00
Jean Chalard
aacffad8ef
Merge "Add read support for string shortcuts for makedict."
2012-03-28 04:40:28 -07:00
Jean Chalard
752996540f
Add read support for string shortcuts for makedict.
...
Change-Id: I48ee4fc9ac703ad2a680b3cd848de91c415ea3c8
2012-03-28 20:40:08 +09:00
Jean Chalard
7b49efdea6
Merge "Change the format of the shortcuts in the binary dict."
2012-03-28 04:39:55 -07:00
Tadashi G. Takaoka
a501caa9a5
Merge "Remove SupportTouchPositionCorrection from subtype extra value"
2012-03-28 04:36:27 -07:00
Jean Chalard
3bbb31f3f0
Change the format of the shortcuts in the binary dict.
...
This only includes the write part of the change. The read part is
coming in a different commit.
Change-Id: Iabe7af6cd134462dc19245f5400719920ed31c8f
2012-03-28 20:24:07 +09:00
Tadashi G. Takaoka
e07db71d26
Remove SupportTouchPositionCorrection from subtype extra value
...
Change-Id: Ieedff9ec212f5567405ca276b0f2194132ba7b0c
2012-03-28 19:45:28 +09:00
satok
6ba8de2a60
Good bye the proximity logic in Java code
...
Bug: 4343280
Change-Id: I82f7d08703647a3492ce6e2d3b741146df58927e
2012-03-28 18:42:30 +09:00
satok
67094f5bde
Do not re-calculate primary code in WordComposer
...
Bug: 4343280
Test: Ib43c0f1d1a19d067ea0
Change-Id: I3393a6099cb7fb824994f4656ccfef884f9c6bc4
2012-03-28 17:23:10 +09:00
satok
9611b281e1
Fix AIOOBE
...
Bug: 6236912
Change-Id: Ie09e5ef1c23eb48621ac3f2f2dc28dc2e46ca288
2012-03-28 13:02:14 +09:00
Ken Wakasa
f71aee8f4f
Tighten up the "define" classes.
...
Change-Id: I854b1dd56b676d0a492a15c16bfe4c6a1bcccdf7
2012-03-27 22:43:25 +09:00
satok
0a1b00869d
Merge "Put a misspelled flag if the word is not valid by the same logic of Android spell checker."
2012-03-27 01:16:54 -07:00
satok
356776a9b7
Put a misspelled flag if the word is not valid by the same logic of Android spell checker.
...
Bug: 6222722
Currently, the flags of the suggestion span from the Latin IME is different from the flags from Android spell checker.
Change-Id: I2f7a54ae0d63235a0b94e039109ab8b2f1311055
2012-03-27 17:11:48 +09:00
satok
01ab7c8b59
ongoing cleanup 2
...
Change-Id: I66b61cbe491cf8375144e834390beae3209a777d
2012-03-27 16:28:48 +09:00
Ken Wakasa
c166697e3f
Optimization: Start making use of ProductionFlag.IS_EXPERIMENTAL for ResearchLogger
...
Move GodMode specific tests to relevant directories as well.
This goes along with I9dc4d469
Change-Id: I4a21c53846b26eede346cb1da13e6abbdf9ec27f
2012-03-27 11:55:23 +09:00
satok
2ac1fad645
Merge "Add a flag file for the experimental mode"
2012-03-26 04:53:49 -07:00
satok
9b2f77f2b1
Add a flag file for the experimental mode
...
Change-Id: I880b7c85dbc20f8d7590b7f65b5f898bfb2266f9
2012-03-26 18:52:46 +09:00
Jean Chalard
d2cd3d54f9
Merge "Split a method for reuse"
2012-03-26 02:12:20 -07:00
Kurt Partridge
400ff86c7b
Merge "add tests for ResearchLogger"
2012-03-26 01:49:09 -07:00
Kurt Partridge
2482e6c386
add tests for ResearchLogger
...
Bug: 6188932
Change-Id: Icf407f9d145d2b25b70d5d7bc30ee3d64561620c
2012-03-26 17:21:50 +09:00
Jean Chalard
8403611960
Split a method for reuse
...
Change-Id: I9a82e538903f05bedad51bc195866abbd9daf957
2012-03-26 16:34:29 +09:00
Jean Chalard
a77bbc64f0
Merge "Correct a shaky processing and move it to a better place"
2012-03-25 17:57:49 -07:00
Kurt Partridge
e327628855
update ResearchLogger times to report SystemClock.uptime()
...
Bug: 6188932
Change-Id: I852537caed46958e4d9c3251664edaa69652205c
2012-03-24 22:41:11 +09:00
Kurt Partridge
d05afa3f4c
move usability log code to new class (ResearchLogger) and clean api
...
This change also undoes the effects of I8694eb9016, which was an initial
effort built on Utils.UsabilityStudyLogs. Now Utils operates as it did
previously, for backward compatibility, but the ResearchLogger retains
the new log format.
Coordinated with I274b75c5.
Bug: 6188932
Change-Id: I41208bdc6b511f69a010c9fc38a936521beba7d5
2012-03-24 20:14:42 +09:00
Jean Chalard
08baf5ff8e
Merge "Fix a native crash"
2012-03-23 06:40:50 -07:00
Jean Chalard
b0b89c87f6
Fix a native crash
...
-1 & 0xFFFF is 65536 :p
Change-Id: I8ecb882b6d6c5bcc91b52e23eb9cc02b04fcdd34
2012-03-23 22:36:00 +09:00
Tadashi G. Takaoka
fce9ca4202
Merge "Remove verbose debug message"
2012-03-23 06:25:13 -07:00
Tadashi G. Takaoka
61f24842c7
Remove verbose debug message
...
Change-Id: I05bfe24228a6fbe806987d2a0d81e59611c3b476
2012-03-23 22:23:56 +09:00
Jean Chalard
380ad509e6
Merge "Optimization and typo fix"
2012-03-23 06:20:58 -07:00
Tom Ouyang
b163f91621
Merge "Add support for updating and adding bigrams to existing nodes."
2012-03-23 05:57:55 -07:00
Tom Ouyang
7cfe20efbe
Add support for updating and adding bigrams to existing nodes.
...
Bug: 6188977
Change-Id: I48aca8ba199247d73395ab13b9d1976f4e739208
2012-03-23 21:52:39 +09:00
Jean Chalard
71f9d30b18
Correct a shaky processing and move it to a better place
...
The old code would remove caps from the first letter if
auto-capsed but that makes very little sense when the word
is camel-cased. Also, it would not correctly handle
surrogate pairs, and would require a direct reference to
LatinIME and a specific method to do the processing in an
unexpected place.
Change-Id: I416d6a805242788a2473f007ca7452c9fe3f5205
2012-03-23 21:40:07 +09:00
Jean Chalard
3ee7d97587
Optimization and typo fix
...
Change-Id: Iafa414b8bcf2cca4569b3753bfac58f301a72269
2012-03-23 21:29:30 +09:00
satok
8980bd4a25
Merge "Cleanup jni 1"
2012-03-23 03:24:08 -07:00
satok
9df4a4527a
Cleanup jni 1
...
Change-Id: Ieb6af8385356e259720b50f1fe46a694a098b30f
2012-03-23 19:03:20 +09:00
Jean Chalard
c4f69e7d68
Merge "Stop creating useless objects"
2012-03-23 02:56:10 -07:00
Jean Chalard
0e134a4477
Merge "Small optimization"
2012-03-23 02:47:54 -07:00
Jean Chalard
a492790982
Stop creating useless objects
...
Man that was bad, it's heavy, it's called quite often, and it's
totally useless
Change-Id: Ia7e23e0e60ff4a929b226f3f4ccabedbc3ea2c06
2012-03-23 17:55:11 +09:00
Jean Chalard
e5f02cff7a
Small optimization
...
Change-Id: I5dd7c848f2aaec20325e7ee85f27e282e1ba7a85
2012-03-23 17:03:55 +09:00
Jean Chalard
cc78d03a62
Add processing for French ligatures.
...
Bug: 5140033
Change-Id: I1c2751fc617e662aad9f67506e28a622f81d0bc9
2012-03-23 16:50:59 +09:00
Ken Wakasa
066866954a
Add a missing comparison in Word.equals()
...
Follow up to I94e2e29c
bug: 6209651
Change-Id: Iff2daca8c2678e2d1796f98d6db738f109e3d03f
2012-03-23 14:41:16 +09:00
Ken Wakasa
6ef88a8901
Merge "Add missing Word.hashCode()"
2012-03-22 22:11:51 -07:00
Ken Wakasa
9f0ea52a5d
Add missing Word.hashCode()
...
Some cleanups too.
bug: 6209651
Change-Id: I94e2e29c92e90e554e4952d277d590e093766c4f
2012-03-23 13:11:39 +09:00
Jean Chalard
081616cd2f
Send correct coordinates for the spell checker
...
This results in the computation being done in native code
and the correct proximity being used.
Bug: 6181080
Change-Id: I08fa05c781d607e4feca2caeda353ec19c133a3d
2012-03-23 13:02:58 +09:00
Jean Chalard
e7cfe43652
Merge "Don't rely on spell checker proximity in tests"
2012-03-22 02:15:29 -07:00
Jean Chalard
8e31d76983
Merge "Make some constants more explicit."
2012-03-22 02:15:21 -07:00
Jean Chalard
109728193e
Don't rely on spell checker proximity in tests
...
This fixes the input logic tests that were broken and suppresses
their dependency upon the spell checker proximity. Instead, it
gets the Keyboard instance from Latin IME and uses the actual
coordinates, which results in a test run closer to what actually
happens during typing.
Change-Id: I3a81d249ee7fb3ac6ae6940aa2e8b2421e829e5c
2012-03-22 18:08:23 +09:00
Jean Chalard
330cd291fa
Make some constants more explicit.
...
This wasn't very obvious, but the actual values are critical, so
make it more readable
Bug: 6181080
Change-Id: I07461d2df4c796dad0cb6f5283e41a28036d023c
2012-03-22 14:28:05 +09:00
Kurt Partridge
19b8a73efa
Merge "log through group level abstractions"
2012-03-21 20:30:35 -07:00
Kurt Partridge
fdd68f0657
log through group level abstractions
...
For the groups:
- LogGroup.MOTION subfields now deteremined in Utils.writeMotionEvent() rather
than in LatinKeyboardView.processMotionEvent()
- LogGroup.KEY is now logged throguh LatinIME.onCodeInput() rather than
Utils.push(). This catches keys more generally, including modifiers, and
records touch positions for everything. Removed now-redundant
Utils.writeBackspace() and Utils.writeChar().
- LogGroup.CORRECTION uses Utils.writeCorrection(), and formats instead of
leaving this to callers.
- LogGroup.STATE_CHANGE uses Utils.writeStateChange(). Optional fields are
still left to callers, as this group has more variety.
Formats have changed to incorporate new fields.
Minor housekeeping:
ENABLE_USABILITY_STUDY_LOG constants replaced with variable references, as
the logging feature can be changed in Settings and therefore dynamically
changes.
New log format:
20120322-111203.621+0900 1332382323621 s [onStartInputView] com.socialnmobile.dictapps.notepad.color.note 2131624043 147457 1140850694
20120322-111204.912+0900 1332382324912 m [Down] 2782355 0 243 171 0.5666667 0.895
20120322-111204.975+0900 1332382324975 m [Move] 2782419 0 240 171 0.6 1.17
20120322-111204.983+0900 1332382324983 m [Move] 2782428 0 238 171 0.6 1.1899999
20120322-111204.992+0900 1332382324992 m [Move] 2782437 0 236 171 0.6 1.1899999
20120322-111205.002+0900 1332382325002 m [Move] 2782446 0 232 170 0.6 1.1899999
20120322-111205.012+0900 1332382325012 m [Move] 2782456 0 227 169 0.6 1.125
20120322-111205.021+0900 1332382325021 m [Move] 2782465 0 224 168 0.6 1.125
20120322-111205.031+0900 1332382325031 m [Move] 2782475 0 221 167 0.6 0.895
20120322-111205.040+0900 1332382325040 m [Move] 2782483 0 213 164 0.6 0.58
20120322-111205.047+0900 1332382325047 m [Up] 2782491 0 213 164 0.6 0.58
20120322-111205.052+0900 1332382325052 k 'D' 243 171
20120322-111205.228+0900 1332382325228 m [Down] 2782622 0 171 71 0.6333334 1.275
20120322-111205.243+0900 1332382325243 m [Move] 2782677 0 178 69 0.6333334 1.275
20120322-111205.325+0900 1332382325325 m [Up] 2782750 0 178 69 0.6333334 1.275
20120322-111205.333+0900 1332382325333 k 'e' 171 71
20120322-111205.509+0900 1332382325509 m [Down] 2782936 0 265 139 0.53333336 0.885
20120322-111205.512+0900 1332382325512 m [Move] 2782954 0 265 141 0.53333336 1.04
20120322-111205.552+0900 1332382325552 m [Move] 2782973 0 265 143 0.5666667 1.14
20120322-111205.663+0900 1332382325663 m [Up] 2783102 0 265 143 0.5666667 1.14
20120322-111205.668+0900 1332382325668 k 'f' 265 139
20120322-111206.140+0900 1332382326140 m [Down] 2783584 0 348 352 0.53333336 0.675
20120322-111206.206+0900 1332382326206 m [Move] 2783648 0 348 354 0.5666667 0.73499995
20120322-111206.223+0900 1332382326223 m [Move] 2783666 0 348 356 0.5666667 0.545
20120322-111206.232+0900 1332382326232 m [Up] 2783674 0 348 356 0.5666667 0.545
20120322-111206.236+0900 1332382326236 k ' ' 348 352
20120322-111206.245+0900 1332382326245 c [----] Def -1
Bug: 6188932
Change-Id: Iea46a0c683f858b72005b8e81191ef1d70262dca
2012-03-22 12:02:10 +09:00
Ken Wakasa
2aa02b84a4
Revive the Makefile for makedict
...
Follow up to I4d2ef504. Address a compiler warning and a small optimization as well.
bug: 6188977
bug: 6209651
Change-Id: Ibc9da51d48ebf0b8815ad0bb2f697242970ba8f7
2012-03-22 11:55:18 +09:00
Tom Ouyang
7ac556216d
Merge "Move makedict to LatinIME android keyboard."
2012-03-21 05:50:28 -07:00
Kurt Partridge
221dd3d183
Merge "Add additional structure to output logs to group entries by optional fields."
2012-03-21 05:50:01 -07:00
Tadashi G. Takaoka
4897df803d
Merge "Refactor key drawing code in KeyboardView"
2012-03-21 04:31:55 -07:00
Tadashi G. Takaoka
72913f97ed
Refactor key drawing code in KeyboardView
...
Change-Id: Ic7af05caee32eb6cba68d27ba4e2d9072472b34d
2012-03-21 20:29:51 +09:00
Tadashi G. Takaoka
4cc44f9f77
Merge "Refactor to memorize device dependent override parameters"
2012-03-21 04:26:39 -07:00
Kurt Partridge
78bf41b89c
Add additional structure to output logs to group entries by optional fields.
...
The new format has time, time as int, and the new logGroup code
(m=motionEvent, k=key, s=statechange, c=correction)
followed by additional text whose format depends on the logGroup code.
The additional text will be cleaned up in later CL's.
20120321-170548.067+0900 1332317148067 m
[Down]143116235,0,691,378,0.40000004,0.435
20120321-170548.133+0900 1332317148133 m
[Up]143116302,0,691,378,0.40000004,0.435
20120321-170548.146+0900 1332317148146 k <enter> 691 378
20120321-170602.485+0900 1332317162485 s
[onStartInputView]com.socialnmobile.dictapps.notepad.color.note,2131624043,147457,1140850694
20120321-170606.508+0900 1332317166508 m
[Down]143134679,0,40,154,0.4666667,0.64
20120321-170606.567+0900 1332317166567 m
[Move]143134723,0,42,154,0.4666667,0.765
20120321-170606.577+0900 1332317166577 m
[Move]143134746,0,44,154,0.4666667,0.775
20120321-170606.652+0900 1332317166652 m
[Up]143134824,0,44,154,0.4666667,0.775
20120321-170606.662+0900 1332317166662 k A 40 154
20120321-170607.200+0900 1332317167200 m
[Down]143135372,0,411,390,0.53333336,0.585
20120321-170607.311+0900 1332317167311 m
[Up]143135483,0,411,390,0.53333336,0.585
20120321-170607.313+0900 1332317167313 c [----]A
Bug: 6188932
Change-Id: I8694eb9016d8cf0389ef582f6c7d2820aa4d2c92
2012-03-21 19:41:10 +09:00
Tom Ouyang
e276c2401e
Move makedict to LatinIME android keyboard.
...
Bug: 6188977
Change-Id: I4d2ef504bb983abbda3cb52ee450cb46f58d95cf
2012-03-21 19:30:26 +09:00
Tadashi G. Takaoka
624f1bab39
Refactor to memorize device dependent override parameters
...
Change-Id: I79482a8ef3846525669979a30dec183ea18138b5
2012-03-21 18:20:18 +09:00
Jean Chalard
32aac4777f
Merge "Correctly close the gzip stream"
2012-03-21 01:32:07 -07:00
Jean Chalard
bc89f5d3a5
Correctly close the gzip stream
...
I had gotten the chain call in reverse.
Bug: 6177523
Change-Id: Ic5b76425de2d5d05d5132f8d2c7ade0d79c14ccc
2012-03-21 17:28:37 +09:00
Jean Chalard
f5f53c2fa6
Merge "Strengthen java code against bad returns from native"
2012-03-21 00:54:25 -07:00
Jean Chalard
6ca3ac08ed
Strengthen java code against bad returns from native
...
This doesn't really fix the following bug but it may alleviate
the symptoms
Bug: 6191885
Change-Id: I0de3f550cc7c6cdf79b291399785ad31b205d2ac
2012-03-21 16:40:26 +09:00
Kurt Partridge
140467b8b6
Updated logger to record touch position within backspace key events.
...
Bug: 6188932
Change-Id: Ida2aff618153792f9803f30f1251d67c89af1fe0
2012-03-20 23:29:34 +09:00
satok
1fe943aabd
Merge "Cleanup proximity related code"
2012-03-19 02:40:25 -07:00
satok
728d1c884e
Cleanup proximity related code
...
Bug: 4343280
Change-Id: I57c0f9e20d9d8911009ea97057251a7f7a81512f
2012-03-19 18:33:59 +09:00
satok
546b8275ab
Merge "Add a dummy file and package for make dict"
2012-03-19 02:01:05 -07:00
Kurt Partridge
6d7e0a876b
Merge "Fix TAG name"
2012-03-19 00:52:44 -07:00
Kurt Partridge
9a50777890
Fix TAG name
...
Change-Id: Ibea065bc72e6b5e40cfa3ffa2fb6bcdeb107ffc4
2012-03-19 16:11:17 +09:00
satok
905670bd87
Add a dummy file and package for make dict
...
Change-Id: I195fd42f2a773bcc6fab0a61336a1c15d97902bb
2012-03-19 15:26:13 +09:00
Jean Chalard
9ffb94fa13
Rename the user history dictionary.
...
UserBigramDictionary -> UserHistoryDictionary.
Also update all methods, strings and comments, except those needed
for backward compatibility (which only include the name of the
database file).
Change-Id: I0bccea29880dc566b90100575b83baaa947b03ae
2012-03-19 12:03:51 +09:00
Ken Wakasa
660776e09b
Small performance improvement by removing interface accesses.
...
Change-Id: I6d91f3b086470b79306dbe2874db9748b9e0eb5f
2012-03-17 01:53:51 +09:00
satok
cbb5053b6c
Fix NPE
...
bug: 6181736
Change-Id: I6522f19555c27f33c9ff4eaa8b2559a51a38f015
2012-03-17 01:37:53 +09:00
satok
a50a34f8b4
Merge "Calculate proximity characters in the native code"
2012-03-16 01:38:07 -07:00
satok
1caff47ecd
Calculate proximity characters in the native code
...
Bug: 4343280
Change-Id: I6adaf560f7a4f1f96dcb6ec2f61f20ee3001167e
2012-03-16 17:26:36 +09:00
Jean Chalard
d0d25ac8ec
Merge "Remove UserUnigramDictionary."
2012-03-16 01:11:52 -07:00
Jean Chalard
f73efa9077
Merge "Move the UserUnigramDictionary functionality over"
2012-03-16 01:05:10 -07:00
Jean Chalard
7dcbed04d9
Remove UserUnigramDictionary.
...
This isn't used any more.
Change-Id: Ie63ae621bcac9342b869b9f236f35bf66ec3a09b
2012-03-16 17:04:41 +09:00
Jean Chalard
c68d1bbfaf
Move the UserUnigramDictionary functionality over
...
UserBigramDictionary now assumes both functionalities. It will
be renamed to UserHistoryDictionary in a future change.
There are several reasons to do this. First, there is a lot of
duplicate code in User{Unigram,Bigram}Dictionaries that are
factored by the few lines of code in this change. Also, other
dictionaries like BinaryDictionary or ContactsDictionary all
assume both responsibilities, as should be the case
theoretically.
It is also possible to do this because previous versions don't
write any unigram data that we'd want to reuse. For even older
versions that do write data, we can't really make any sense out
of it. Bigram data however can be useful, and this allows us to
reuse it easily.
Change-Id: I755525f92744e1536eaef097527e8151b7859a30
2012-03-16 17:01:57 +09:00
satok
c59e383977
Merge "Do not change the proximity orders"
2012-03-15 21:09:46 -07:00
satok
ef08daddea
Do not change the proximity orders
...
Bug: 4343280
Change-Id: I4e2dfb00d9c843a8a285d409ac5ab8fca5fb1694
2012-03-16 12:54:17 +09:00
Jean Chalard
c24f66e180
Streamline some user history dictionary code
...
A lot of things don't really make sense in the old code.
Let's streamline it for now so that we have a cleaner interface
to work with. This is preliminary work for bug 4192129.
Change-Id: If01a5974cfadc43afced610c57fcf7fde67c1346
2012-03-16 12:22:39 +09:00
Tadashi G. Takaoka
5bee1b00c8
Merge "Remove touch dead zone"
2012-03-15 05:16:56 -07:00
Tadashi G. Takaoka
723aaa2eeb
Remove touch dead zone
...
KeyDetector should use the distance from the hit box to detect the
key.
Bug: 6174250
Change-Id: Id1745d90222d1d1a10467f194b45307c12449944
2012-03-15 20:16:43 +09:00
Jean Chalard
3fe263fac6
Extract an annoying method call
...
Change-Id: I78f22bb38222fea54a55e460fcf728bf941d15e9
2012-03-15 19:30:15 +09:00
Jean Chalard
6ec1209a33
Fix a bug where quotes and dashes are considered letters
...
Bug: 6174065
Change-Id: I702760d44ead0eeb60d06360aa3bb03c2ec73325
2012-03-15 18:18:52 +09:00
Jean Chalard
2be7a37acf
Small cleanup
...
Exit-fast, update comment, make a method private
Change-Id: Id103bf03aeef43a1a4d064ecabb819490dc5d39a
2012-03-15 15:54:25 +09:00
Jean Chalard
7c5f2bbd2a
Remove useless code
...
I tracked all the calls to the constructor, and the passed
list is never null. It's also final, so it's safe.
Change-Id: I320f907acee0b237bb286a9a183c18106809174a
2012-03-15 15:10:07 +09:00
Jean Chalard
042557b45b
De-duplicate a method
...
Change-Id: Ia1c80eeff00a55573bb311f07e1275da23bdcf98
2012-03-15 15:04:29 +09:00
Jean Chalard
e8ddfe4273
Remove useless code
...
Change-Id: I58de87c1ba4cd1130419191f63ff83b685604356
2012-03-15 14:51:22 +09:00
Jean Chalard
4e74658883
Optimization
...
All calls to this methods are made with an actual String. No sense
beating ourselves with an interface stick.
Change-Id: I6ef98286be6f81f73864b04f3a17e68f36a6e542
2012-03-15 14:48:47 +09:00
Jean Chalard
123407261c
Stop meaningless explicit null passing
...
Change-Id: I6950897d262f610d502b7f8293b9dd8d2b53e6e8
2012-03-15 14:37:40 +09:00
Jean Chalard
3187ba5dfe
Remove a now-useless flag.
...
This has been moved to the SuggestedWords object and is now
represented by a single flag instead of a flag in each suggestion.
Change-Id: I6e9a7cff5a7701de7e61b4de13baac25c9a87b1b
2012-03-15 14:21:02 +09:00
Jean Chalard
4f6cf258fe
Use the unique flag in SuggestionsView
...
Also, the first word in a sugestions list can never be
obsolete.
Change-Id: Ib21439aac8db4e6ce5b15b7a2aabe4222bc354db
2012-03-15 14:11:41 +09:00
Jean Chalard
03a3517075
Add info for obsolete suggestions in SuggestedWords
...
Change-Id: I9684c7b08244b34853ce8a99b6e9d885389f6687
2012-03-15 13:12:08 +09:00
Jean Chalard
5f9593593e
Remove useless stuff
...
Change-Id: I43dae30774c40a9d6e7396f8fa73ed4b82a7c777
2012-03-15 12:47:05 +09:00
Jean Chalard
ca3e7cbdf4
Move a computation closer to where it's used.
...
Change-Id: I5aee4c36ceaacbb1dbfc47c011f1e4aec4b9dca6
2012-03-15 12:23:16 +09:00
Jean Chalard
eb5ffdac90
Merge "Some readability improvement"
2012-03-14 18:47:32 -07:00
Jean Chalard
c787db51ed
Merge "Cut out a private method to make things more readable"
2012-03-14 18:47:26 -07:00
Jean Chalard
b9a5cb77f0
Merge "Minor optimization"
2012-03-14 18:47:21 -07:00
Jean Chalard
53d57ad6d3
Merge "Some code simplification"
2012-03-14 18:47:16 -07:00
satok
05c54ffc7f
Merge "Really pass the y - touch correction to the native code"
2012-03-14 06:47:19 -07:00
satok
853d9020ed
Really pass the y - touch correction to the native code
...
Bug: 4343280
Test: I11f8518d9ee
Change-Id: I4b90bdffffed9736af223ac83c1a54019add70bb
2012-03-14 21:54:52 +09:00
Tadashi G. Takaoka
ea51bfd8a8
Fix SuggestedWords.toString
...
Change-Id: Ide3f605ce40e8c230f217bbf37ab016457ee91f1
2012-03-14 19:23:15 +09:00
Jean Chalard
271e5b6cb7
Some readability improvement
...
In-place replacements of visibly identical things.
Change-Id: I02b51bd7f63597e3428f0650b239e9a39ef5a7c7
2012-03-14 18:50:08 +09:00
Jean Chalard
0d0f182959
Cut out a private method to make things more readable
...
Change-Id: I791700890338e023bd86b8794dbc90379b91dc7d
2012-03-14 18:43:32 +09:00
Jean Chalard
ac5e463402
Minor optimization
...
We know the size in advance, this may save a few allocations
Change-Id: I2fb9a725f34ba2da4f34ed335652f10447d5d166
2012-03-14 18:35:07 +09:00
Jean Chalard
def4551c2a
Some code simplification
...
Just write the same thing in a more succint manner
Change-Id: I08a2c5edd52a3502914541061fd5b6ee7a92ebc4
2012-03-14 18:33:57 +09:00
Jean Chalard
4a08b2f0e4
Cleanup & optimization
...
Renaming some variables, and obvious optimizations.
Change-Id: Ib716748e9f3d602cf276dcd4e73f3bcfb819585e
2012-03-14 18:29:06 +09:00
Jean Chalard
f985efe39c
Remove a useless parameter
...
Change-Id: I03005240238fb004c20b2df0d836796e2e8b307f
2012-03-14 18:12:12 +09:00
Jean Chalard
bdf6d1b18b
Remove a useless method
...
Change-Id: I208dd2e725e37c2fb3cd51fe48194679e5912f6b
2012-03-14 15:59:04 +09:00
Jean Chalard
eda7d8af60
Remove the Builder
...
Change-Id: Idef22e6a82d59e3ec95b95ad237debcb07daf000
2012-03-14 15:42:26 +09:00
Jean Chalard
33cc825374
Match the constructor of SuggestedWords to the Builder call.
...
We have to match one way or another, and the argument order to the
Builder call is more logical.
Change-Id: Iac7c3a351c2687cb294d6a4924fd9cb20ca95177
2012-03-14 15:42:22 +09:00
Jean Chalard
7d55c891af
Make the Builder private
...
Change-Id: I2184084f4b7729c4324f8291d548bd4c4c2872a1
2012-03-14 15:42:14 +09:00
Jean Chalard
5b0643f50d
Re-sequence the last calls to build()
...
Change-Id: If77ee5aa9483d3ca03c52812f31665dee6468e99
2012-03-14 14:19:24 +09:00
Jean Chalard
88bf1ba526
Move up the static methods of the Builder
...
Change-Id: Ic3e07b745b7b24cae0f772ea49e0de615b44caf9
2012-03-14 13:10:22 +09:00
Jean Chalard
8e19b1183e
Kill the last place where the Builder was being used
...
I had missed that one
Change-Id: I9a5040a7a61e294396aa424de96a69dbb15f037a
2012-03-14 13:10:12 +09:00
Jean Chalard
e3afb7d192
Make the Builder fully immutable at last
...
Change-Id: Ie399ca7a9e76ccab44a92bc378d11f92392fed2c
2012-03-13 20:33:13 +09:00
Jean Chalard
6ffb5018c1
Straighten out the last bastion of the Builder
...
...and go for the kill
Change-Id: I5ad57211b250d2578ca22a5dae93344d52f9da80
2012-03-13 20:26:47 +09:00
Jean Chalard
ec471c72f8
Add to SuggestedWords a missing parameter, and use it.
...
Also stop using Builder between its creation and the call to
the #build() method.
Change-Id: Ie1fc3ec7b6f4c7c3789f672f4e26b4bf58c3e062
2012-03-13 20:19:21 +09:00
Jean Chalard
2e2519ee91
Make still more members of the Builder final.
...
Change-Id: Ic455f97247da5e40d4939555ab639ecffef36e2d
2012-03-13 20:05:00 +09:00
Jean Chalard
bd4ba23d2b
Some code reorganization.
...
Use the same local variable inside both branches of an if.
Change-Id: I61f7d506d984f3723ec90604416d1875dd97cd8c
2012-03-13 19:54:56 +09:00
Jean Chalard
b5eeb724fc
Make some more Builder attributes final.
...
Change-Id: I3132b7fe4ee97c566736bfc21c3783cfc79fc7ff
2012-03-13 19:53:38 +09:00
Jean Chalard
c60fea852d
Make the suggested word list final in Builder.
...
Change-Id: I2ddfab00dc8c141fc989a051f16eb2b3571b7e86
2012-03-13 19:37:17 +09:00
Jean Chalard
08adb09e14
Remove unused stuff.
...
Remove 2 methods that were left only for tests to compile in
another project, but are not used any more now that the tests
have been updated.
Also remove an attribute that is never read.
Change-Id: Ic9ba1f52a465199c82c923d77ed7450460e8a4b9
2012-03-13 19:37:16 +09:00
Jean Chalard
674ffcdf93
Make an add into a set.
...
This method now only sets words, so it should be named set.
The functionality is identical since there are no more places
where the list is reused.
This will also allow to make the list final in an upcoming change.
Change-Id: I25b0c7d7f13c3fa5d89806f01f48f1026769603f
2012-03-13 19:07:42 +09:00
Jean Chalard
d6662ecd30
Cleanup
...
Remove an unused method, make others static, fix a formatting
issue
Change-Id: I40cb0b5e01a6f8e2f7b953bd9aad3168dfee71d1
2012-03-13 18:34:19 +09:00
Jean Chalard
4ee186920e
Remove a method that causes annoying side-effects.
...
...and replace by a call to a central method.
Change-Id: I93d0a2c2e99963a5b69923d1062d0e01853216b6
2012-03-13 18:22:49 +09:00
Jean Chalard
adf218eed5
Kill the StringBuilderPool.
...
The intention may have been nice originally but these end up
being copied anyway :/
Let's remove them now, and in a later change, just keep
references to the created objects.
Change-Id: Ifba8357c20384f9eb40cd916665ed1fc6dc8cab1
2012-03-13 17:59:49 +09:00
Jean Chalard
d0d4074392
Remove a useless parameter.
...
Change-Id: I7625bf17158c207ad7e8cd496bef825704173c4c
2012-03-13 15:34:06 +09:00
Tadashi G. Takaoka
6fbcd0d219
Merge "Use Animator to draw language name on spacebar"
2012-03-12 22:57:57 -07:00
Tadashi G. Takaoka
4c0c638a18
Use Animator to draw language name on spacebar
...
Note that Animator class exists in framework only on Honeycomb or
later.
Change-Id: Ie3392dbf8acc1547ebb2d16e04086c911d961aed
2012-03-13 14:25:57 +09:00
Jean Chalard
7c9bff96f0
Kill methods with side-effects, take 2
...
...working this time
Change-Id: I80e377e6250d3817f1e067a551bca2a557740764
2012-03-13 14:18:30 +09:00
Jean Chalard
b26af7eae7
Revert "Kill methods with side-effects"
...
This reverts commit ca0e048688
2012-03-12 19:42:29 -07:00
Jean Chalard
ca0e048688
Kill methods with side-effects
...
Change-Id: I42baeec68eb2540e7d8f8538ae2dceeef5594391
2012-03-12 19:48:32 +09:00
Jean Chalard
c3c4ed91cf
Consolidate words into SuggestedWordInfo
...
We can't get rid of SuggestedWordInfo because it conveys
the information about whether a suggestion is outdated or
not. It is always created anyway. So it makes sense not
to have separate lists and to just keep everything in the
SuggestedWordInfo object.
Change-Id: Idd79dc267d97633901d3d2869da457736963e178
2012-03-12 18:58:20 +09:00
Jean Chalard
c0c20b386f
Fix an OOB
...
The combination of I6b0262fe which removes the internal
size() > 1 test in the safety net calculation and I642a5893
which assumed DBG means there is at least one suggestion.
This change writes the test correctly.
Change-Id: Ib63bce4e163a785f408dd145c23d64cd58fa8c90
2012-03-12 16:50:58 +09:00
Jean Chalard
30936116d8
Merge "Make a method accessible for tests"
2012-03-12 00:23:29 -07:00
Jean Chalard
9dedec7c29
Make a method accessible for tests
...
Tests are using a wrapper method that's going to disappear soon.
The method that becomes package-visible now is destined to be
removed too a little later.
Change-Id: If99b1c77ed52e050b47216cc7afab5f35c4bbb38
2012-03-12 16:11:16 +09:00
Jean Chalard
1dfef0336d
Make a method static
...
Change-Id: Ie1d460562d38105abe91ae2da17cafd49e2cd394
2012-03-12 15:00:36 +09:00
Ken Wakasa
c1ca8815f5
Fix an obvious bug in handleLanguageSwitchKey()
...
bug: 5759092
Change-Id: I8c7b2ef024cbab399d96f6b3ec553da4e9d2fb18
2012-03-11 00:44:47 +09:00
Jean Chalard
1a85b74adb
Entirely remove safety net memory.
...
mHasAutoCorrectionCandidate now includes the fact that this
did not get caught by the safety net. This is more intuitive.
Change-Id: I6502bbf1ca64a0a6d64f55d723305cf78352a656
2012-03-09 22:10:25 +09:00
Jean Chalard
68823ae08e
Make the safety net memory private
...
Change-Id: I10959d47c980d2e8f2ea995955acf02193e3ff7b
2012-03-09 22:01:15 +09:00
Jean Chalard
ebbb7e9665
Recompute safety net in debug cases instead of memorizing
...
Change-Id: I67f3a31db081afa4871ec441dd461c56e098c668
2012-03-09 22:00:23 +09:00
Jean Chalard
682c2d53cc
Make access to the safety net calculation easier
...
Change-Id: If33897b38af94ae81b05e5ef140a542724b9f34a
2012-03-09 21:44:40 +09:00
Jean Chalard
151d5cb532
Extract a condition from a method
...
Change-Id: I6b0262fe7cb3f7a31cc19d724c301467be932640
2012-03-09 21:37:44 +09:00
Jean Chalard
36c1b37914
Remove a useless argument
...
Change-Id: I713433a3225193489fad5bdafcf302b529903116
2012-03-09 21:24:47 +09:00
Jean Chalard
28e59b98c6
Remove a useless escape
...
Change-Id: I1ef0685cc9888c9cef9f60015d32b66dde75ef9b
2012-03-09 21:10:55 +09:00
Jean Chalard
d5f618e90a
Remove a useless test
...
If we are not composing a word here, we have already returned
Change-Id: I63281abace777e3658286d4df6781d2cd5a29c33
2012-03-09 20:53:45 +09:00
Jean Chalard
c5d2bb786e
Don't use an intermediate object with a different meaning
...
Change-Id: Ie89916b49c852a51385ffd61cb596a58f23a46a0
2012-03-09 20:51:33 +09:00
Jean Chalard
ed9986824e
Move some auto-correction logic to where it belongs
...
Change-Id: I897c5ec3a630a4a6bfc593906df4d3fc7b244482
2012-03-09 20:45:37 +09:00
Jean Chalard
dfd4abe818
Fix a shameful bug
...
I must have been sleeping when I wrote that
Change-Id: I887180ab610785a2000636adeeed99230b3c5390
2012-03-09 19:31:35 +09:00
Jean Chalard
0cf422fbb7
Reduction, step 8
...
Change-Id: I54334039597e235e24f169e34c1d44109180ee88
2012-03-09 19:00:29 +09:00
Jean Chalard
a333ff19ef
Reduction, step 7
...
Change-Id: I177ef2f29c8b6000c5e3d021c016c5d216fe3fc6
2012-03-09 18:59:20 +09:00
Jean Chalard
a3ee019331
Reduction, step 6
...
Change-Id: I22ad4cea0e0cac23813da7e788f5c94974ce0ebf
2012-03-09 18:58:01 +09:00
Jean Chalard
dbd140504d
Reduction, step 5
...
Change-Id: Iac52e62c2bdffad14f916f69eade2b785bb41767
2012-03-09 18:44:23 +09:00
Jean Chalard
0b96bc4b2b
Reduction, step 4
...
Change-Id: Ib27dc6e9486c3f0f2ec1e94a88a52d12c1af2d38
2012-03-09 18:44:20 +09:00
Jean Chalard
5a61d03f31
Reduction, step 3
...
Change-Id: I0e08b102c9539d97c473505b9d42176c4a7c8853
2012-03-09 18:44:16 +09:00
Jean Chalard
8abd15b59f
Reduction, step 2
...
Change-Id: I06e117df43d25dbaf9fc7a7366efd9355a6215ce
2012-03-09 18:44:10 +09:00
Jean Chalard
f08f30176b
Reduction, step 1
...
Change-Id: Ic3ed04300cfd4c0b69b93b27379aca4093b32f67
2012-03-09 18:38:44 +09:00
Jean Chalard
de165aed2a
Separate bigram prediction from suggestion process
...
Change-Id: Ibdef206fbd6688a45cebbd7fb8a9f6cd175d03b0
2012-03-09 18:38:20 +09:00
Jean Chalard
6f722c8301
Remove useless stuff
...
Change-Id: I462d24da2d26661990d6aab2a13fde851763fd61
2012-03-09 18:36:52 +09:00
Jean Chalard
67af2a2415
Export some more logic out of Latin IME
...
Change-Id: Ib264533a05e9e09347bf254789e6ab5beec92400
2012-03-09 18:36:49 +09:00
Jean Chalard
df9fce5df1
Export some logic out of LatinIME
...
Hopefully that will end in Suggest/SuggestedWords being autonomous
and won't need the logic spoon-fed to them
Change-Id: I915661bce13c69c8a5b8e5d4a8c41e18fea594cf
2012-03-09 18:36:45 +09:00
Jean Chalard
91e55ac000
Small optimization
...
We only use some of those results in one branch of an if() test.
Let's not compute those that are not needed.
Change-Id: I6ca068646b86d2980fb88e75b110ad077362c4ff
2012-03-09 16:47:43 +09:00
Jean Chalard
195419b1ec
Small reorganization
...
...resulting in a slight optimization
Change-Id: I83a9b8c92c3d93ce75988285997ec138b3ffe52e
2012-03-09 16:41:35 +09:00
Jean Chalard
838629aea0
Remove useless test
...
typedWord may not be null here
Change-Id: I9e7afb89fafbf6fcbc91fbc132aecc06aec8979f
2012-03-09 15:52:23 +09:00
Jean Chalard
d48b76267a
Merge "Remove a useless test (B7)"
2012-03-08 22:26:20 -08:00
Jean Chalard
2d82757fc6
Merge "Rename a parameter (B6)"
2012-03-08 22:23:33 -08:00
Jean Chalard
de19ab878d
Merge "Remove useless tests (B5)"
2012-03-08 22:22:56 -08:00
Jean Chalard
5a7cb9305a
Merge "Remove a provably useless test (B4)"
2012-03-08 22:22:20 -08:00
Jean Chalard
54392438c5
Merge "Optimize and clean up (B2)"
2012-03-08 22:00:02 -08:00
Jean Chalard
90bd4efd10
Remove a useless test (B7)
...
consideredWord is provably never null.
Change-Id: Ifaa0d2471c46f14967e70ad004d2b82f841a4566
2012-03-09 14:55:46 +09:00
Jean Chalard
cf8bc92ba0
Rename a parameter (B6)
...
This is not necessarily the typed word. Actually, the parameter
that's passed here has trailing single quotes culled out of it.
Change-Id: Ia2038faa2cbbd3a5b8263e6c0fb5b8e670993fe9
2012-03-09 14:52:35 +09:00
Jean Chalard
92146f2926
Remove useless tests (B5)
...
WordComposer#getTypedWord() may not return null. Don't test for it.
Change-Id: I6aff14892503d0c275a3328c404ed99d2f40a687
2012-03-09 14:52:04 +09:00
Jean Chalard
31a5da28e3
Merge "Move some code around (B1)"
2012-03-08 21:15:25 -08:00
Jean Chalard
8cd847c2fa
Remove a provably useless test (B4)
...
If !mInputAttributes.mInputTypeNoAutoCorrect then mCorrectionMode
will not have allowed #hasAutoCorrection() to return true.
Change-Id: I1b498d5aeb26194c765cc9b9dcb24d980de43894
2012-03-09 12:56:48 +09:00
Jean Chalard
94b20c90d8
Optimize and clean up (B2)
...
Stop parameters from escaping and don't do useless work and
simplify the code.
Yay.
Change-Id: I0dfc3e14b1cb50e0730f6d9c1d52b54516baa90e
2012-03-09 12:51:55 +09:00
Jean Chalard
dc5dfe37e0
Move some code around (B1)
...
The goal is to make the creation of the Builder closer to
the #build() call
Change-Id: I48d76d4efdc180479829016582edd9de47e7332c
2012-03-09 12:33:23 +09:00
Jean Chalard
13fb8fb775
Limit escape of parameters
...
Change-Id: I3a7ab069042d5542ab2e033d1eeb13d718cd7698
2012-03-09 12:30:23 +09:00
Jean Chalard
23a5e9d1a7
Merge "Make AutoCorrection static and non-instantiable (A5)"
2012-03-08 19:05:30 -08:00
Jean Chalard
2621fe2256
Merge "Move a memory in the container class (A4)"
2012-03-08 19:04:56 -08:00
Jean Chalard
427dfe37ec
Merge "Remove an unused method"
2012-03-08 18:31:26 -08:00
Jean Chalard
cbbfa15765
Merge "Make AutoCorrection a step closer to being static (A3)"
2012-03-08 18:30:19 -08:00
Jean Chalard
58722d83f0
Merge "Stop uselessly remembering a value (A2)"
2012-03-08 18:30:10 -08:00
Jean Chalard
caae6df0ce
Remove an unused method
...
Who would have guessed this wasn't being called at all.
Change-Id: Ib74a212356ea44e9bf149619ed5464c14684a1ba
2012-03-09 11:10:55 +09:00
Jean Chalard
21af2f40c5
Merge broadcast receivers again
...
It's probably simpler not to have registers dance around,
and just message the feedback manager when the audio event
happens.
Change-Id: Id0710ed102d10d01f1af93ad8cb660653bb3a9f8
2012-03-09 11:00:23 +09:00
Jean Chalard
7b77c683d7
Fix a crash
...
Bug: 6137076
Change-Id: I05f9f72a2678d10d3400dab5fc71544276739dcf
2012-03-09 10:29:51 +09:00
Jean Chalard
39286f98bc
Merge "Remove useless stuff (A1)"
2012-03-08 04:02:46 -08:00
Tadashi G. Takaoka
f686211183
Merge "Split Utils class to StringUtils, SubtypeUtils, and JniUtils"
2012-03-08 03:59:59 -08:00
Jean Chalard
82adfdaeae
Make AutoCorrection static and non-instantiable (A5)
...
This needs change Ic6756baa to not break the build
Change-Id: I1c772dd99d63fec5d3ad67a0eb7fbc28ec7a0f0f
2012-03-08 20:56:59 +09:00
Jean Chalard
7a580a4769
Move a memory in the container class (A4)
...
This allows us to make AutoCorrection a purely static class.
Change-Id: I15b81bd7f3d6ea487154a5b09a81bc323be82ce1
2012-03-08 20:56:11 +09:00
Jean Chalard
9254dbcd7e
Make AutoCorrection a step closer to being static (A3)
...
Change-Id: Ide3d9785661a672af9bc8dc0cf91cab816dd6caa
2012-03-08 20:55:49 +09:00
Jean Chalard
719f92fc77
Stop uselessly remembering a value (A2)
...
The value is only used in debug mode, and it can be recomputed
at the time.
This change does not impact the logic. There is however a side
effect: in debug mode, the normalized score will be displayed
also when the word comes out of the whitelist or is a valid word.
It's actually a good thing.
The end purpose is to make all methods in AutoCorrection static.
Change-Id: I1642b1fdfa6ae62b8aa2fed94a8a26ff4a7e4d0e
2012-03-08 20:55:37 +09:00
Jean Chalard
ec0fca8a8b
Remove useless stuff (A1)
...
Remove an unused method and avoid doing a useless computation
Change-Id: I29593c2e93f15857249b35bdd72ca28045056302
2012-03-08 20:55:25 +09:00
Tadashi G. Takaoka
cc8c8b99bd
Split Utils class to StringUtils, SubtypeUtils, and JniUtils
...
Change-Id: I09e91675fe7d573dad8c933ad513b21d7e409144
2012-03-08 20:30:38 +09:00
Tadashi G. Takaoka
b43f2aeb69
Merge "Fix centering more suggestions panel on tablet"
2012-03-08 03:24:07 -08:00
Jean Chalard
2b1280c0f0
Merge "Return a value for tests instead of saving it"
2012-03-08 03:10:18 -08:00
Jean Chalard
32c181bfe0
Return a value for tests instead of saving it
...
Change-Id: I54fa32b92e89d03a53866bd1c0ee65955dd6b3d3
2012-03-08 20:07:54 +09:00
Jean Chalard
2bb29c4674
Simplification
...
Change-Id: Ibced83da2398f1e9ab6a0d6a22c2ad7c8f25cb7b
2012-03-08 19:50:47 +09:00
Jean Chalard
0f1efae262
Merge "Cleanup unused imports (A7)"
2012-03-08 02:32:48 -08:00
Jean Chalard
663aabca0c
Merge "Get the view for haptic feedback as a parameter (A6)"
2012-03-08 02:32:39 -08:00
Jean Chalard
85e88d30c1
Merge "Remove a useless member (A5)"
2012-03-08 02:32:25 -08:00
Jean Chalard
60705c9ed3
Merge "Simplification of sound settings (A4)"
2012-03-08 02:32:16 -08:00
Jean Chalard
d2b5ea2084
Merge "Make a condition positive (A3)"
2012-03-08 02:32:07 -08:00
Jean Chalard
d749fb86ab
Merge "Simplify audio management (A2)"
2012-03-08 02:31:57 -08:00
Jean Chalard
7cfae83434
Merge "Export audio and haptic feedback to a specialized class. (A1)"
2012-03-08 02:31:45 -08:00
Tadashi G. Takaoka
bcbaffd9dd
Fix centering more suggestions panel on tablet
...
Bug: 6129726
Change-Id: I8dac3251eec68ad3fb523c632ff39f3cc661c81f
2012-03-08 19:02:22 +09:00
Jean Chalard
8667bbeab3
Small rename
...
Left/Right is wrong terminology here
Change-Id: I58c55849e45d9984dd3fb7b75a64e07667c9eba4
2012-03-08 18:49:38 +09:00
Jean Chalard
41a2929282
Cleanup unused imports (A7)
...
Change-Id: I48ba12e4311cbf2982ee8f5312b279bc8c1fdfe8
2012-03-08 18:37:03 +09:00
Jean Chalard
544c3c2952
Get the view for haptic feedback as a parameter (A6)
...
It's rather annoying (and possibly dangerous) to keep this as a member.
Get it from outside.
Change-Id: I00c42db96395fb65204fb140aeedc82bf312a86e
2012-03-08 18:37:00 +09:00
Jean Chalard
29d967fdcb
Remove a useless member (A5)
...
Change-Id: Ibaaeb8dbcb012f5e973e27ed9928401515656e9e
2012-03-08 18:36:56 +09:00
Jean Chalard
bdbb22bb33
Simplification of sound settings (A4)
...
Change-Id: I0c6e207bae1e08c45a95b3479e1d67228d696792
2012-03-08 18:36:43 +09:00
Jean Chalard
2651b17fc4
Make a condition positive (A3)
...
mSoundOn is much easier to understand than mSilentModeOn
Change-Id: Ie51c5c75fcad62e13e0fb578a266af80f15dc440
2012-03-08 18:36:19 +09:00
Jean Chalard
793791cdf0
Simplify audio management (A2)
...
There is little point in deferring loading for this. Getting the
service at startup time is not very expensive anyway, plus we
can avoid getting it in a later change if sound is off in settings.
Change-Id: I08d65467f245fa2f9f617eb23257c327b3115673
2012-03-08 18:35:48 +09:00
Jean Chalard
564496bad6
Export audio and haptic feedback to a specialized class. (A1)
...
Change-Id: I957d883d1ccf188cb98eb11031aa0a32fce4ed76
2012-03-08 18:35:20 +09:00
Jean Chalard
f8b39f39cd
Merge "Remove a useless class (B4)"
2012-03-08 01:14:33 -08:00
Jean Chalard
4b656a3fef
Merge "Remove stuff that's not used any more (B3)"
2012-03-08 01:13:06 -08:00
Jean Chalard
d8447ec353
Merge "Use the simple auto-correction status (B2)"
2012-03-08 01:12:46 -08:00
Jean Chalard
fbe767cec5
Merge "Remember auto-correction status simply (B1)"
2012-03-08 00:54:30 -08:00
Tadashi G. Takaoka
3e2d385810
Restart LatinIME service when keyboard theme is changed
...
Bug: 6023947
Change-Id: I779da32708fca7333aff74929cc98173246ee685
2012-03-08 15:08:16 +09:00
Tadashi G. Takaoka
c648b88779
Merge "Dynamically determine key preview backing view height"
2012-03-07 04:17:52 -08:00
Tadashi G. Takaoka
c8b0e5797e
Dynamically determine key preview backing view height
...
Bug: 6023947
Change-Id: I53a5c0eb99100a0dfe3e025808f5dc55747d1287
2012-03-07 20:33:17 +09:00
Jean Chalard
dab392c6f4
Merge "Fix a bug with successive manual picks"
2012-03-07 01:51:59 -08:00
Jean Chalard
3dd4bcb283
Merge "Recompute suggestions on language change."
2012-03-07 01:35:12 -08:00
Jean Chalard
b84ee82e66
Recompute suggestions on language change.
...
Bug: 6106407
Change-Id: I43d9c89610a9ed7a9f6825bd90334d7b343df52c
2012-03-07 17:35:32 +09:00
Jean Chalard
845b24d9d3
Fix a bug with successive manual picks
...
Bug: 6121571
Change-Id: Ib16fbef1087da3b7da5539901ec57156f242f089
2012-03-07 17:32:42 +09:00
Jean Chalard
f773ef19e8
Remove a useless class (B4)
...
\o/
Bug: 5975068
Change-Id: Ia18b55af6d555e7ee7af1cdd7c6227fc1ee6786b
2012-03-07 15:34:15 +09:00
Jean Chalard
a0beebf711
Remove stuff that's not used any more (B3)
...
Change-Id: Ie86675ff2facd37430051bf129ddd930fb933dc9
2012-03-07 15:32:55 +09:00
Jean Chalard
0a59ac2ba8
Use the simple auto-correction status (B2)
...
Change-Id: I9d2f053b6f7bad20fc6afe5f5086a965e5014a5c
2012-03-07 15:31:22 +09:00
Jean Chalard
70852c91dc
Remember auto-correction status simply (B1)
...
This duplicates the functionality in ComposingStateManager at
a fraction of the cost. It's not used yet.
Change-Id: Ica2607fb2f7c41e11189fcb566e253db8f62596f
2012-03-07 15:20:01 +09:00
Tadashi G. Takaoka
65fe7f7994
Merge "Add language switch key only to the phone layouts"
2012-03-06 18:19:45 -08:00
Tadashi G. Takaoka
81d4e3cd66
Add language switch key only to the phone layouts
...
Bug: 5759092
Change-Id: Ic7d7d4812976654c0e85fecabd1128eadfc52c5c
2012-03-07 10:03:21 +09:00
Jean Chalard
89ffb212b4
Make the keyboardswitcher and the subtypeswitcher final.
...
Change-Id: Ifcc79357adcc53f93b190b6e98d5569f42f74655
2012-03-06 19:07:21 +09:00
Jean Chalard
3cd1a00eca
Resolve a todo
...
This exports some voiceproxy complexity to voiceproxy rather
than keeping it in latinime
Change-Id: I0b3523e77af4104cc3ed28417956059c734c8bfe
2012-03-06 18:43:18 +09:00
satok
691f1c174b
Fix coordinates sent to native code
...
Change-Id: I2c8b093b59ad36ffe860c3c4d360d87251d101c4
2012-03-06 16:38:00 +09:00
satok
231ef8fa3e
Merge "Integrate the logic to calculate the proximities"
2012-03-05 23:25:29 -08:00
satok
ca7ec2097c
Integrate the logic to calculate the proximities
...
Bug: 4343280
Change-Id: I0f6a7e6912ed4abea07c10d266da4c7ccb0dae76
2012-03-06 15:34:27 +09:00
Jean Chalard
00ed3be95c
Correct special space handling of punctuation
...
This fixes two defects:
- One where some separators should promote a phantom space to
a real space. This bug had a unit test but wasn't tracked.
- One where French punctuations would behave incorrectly. Tracked
Bug: 6113693
Change-Id: Ia7f86fc960e00141757632ab2c9bce9168dd6966
2012-03-06 14:00:34 +09:00
Tadashi G. Takaoka
e79b1a8312
Make SuggestedWords immutable completely
...
Change-Id: I1b0f7b857e89307c987187c1969a2846aa97fdcc
2012-03-05 23:06:37 +09:00
Tadashi G. Takaoka
8cc8f26adf
Make SuggestedWords partially immutable
...
Change-Id: I72a2f71d7f6565a30c06e563b0a64f496542cde9
2012-03-05 22:11:13 +09:00
Tadashi Takaoka
d5b6360549
Merge "Revert "Make SuggestedWords immutable""
2012-03-05 02:57:00 -08:00
Tadashi Takaoka
d62fa834c6
Revert "Make SuggestedWords immutable"
...
This reverts commit c208f4dfb7
2012-03-05 02:54:21 -08:00
Jean Chalard
6a830277df
Merge "Refactoring"
2012-03-05 01:49:46 -08:00
Jean Chalard
611a5bdf65
Refactoring
...
Change-Id: I2f92c01fa1ff6b318128d387f26942b5d47de3e0
2012-03-05 18:36:51 +09:00
Tadashi G. Takaoka
c208f4dfb7
Make SuggestedWords immutable
...
Change-Id: I26bd82aee5ead84e40abfc3db5a48ed6d1e42361
2012-03-05 17:24:30 +09:00
Jean Chalard
895b70b8af
Move some treatment to a more sensical place.
...
It makes more sense to catch words with the safety net in
updateSuggestions() than in showSuggestions(). Also, it's useless
to do it in updateBigramPredictions, because the result will
always be provably false.
This will also help with writing unit tests.
Change-Id: Ifab81e6c5a74b1aa75cf85ef7742fee69a98f5ce
2012-03-05 14:27:49 +09:00
Jean Chalard
9b01890254
Move a method to a more sensical place.
...
Change-Id: I11f87448f689cf828bff960ad7a3e4739a3457dc
2012-03-05 14:19:35 +09:00
Jean Chalard
611ec69413
Remove a useless method
...
Change-Id: I2002662ee07af2fcc626a52ea4e9ad8977b29ca2
2012-03-05 12:46:35 +09:00
Jean Chalard
428178aca6
Merge "Replace a useless computation with a constant"
2012-03-04 19:35:11 -08:00
Jean Chalard
4ab5486bf2
Merge "Remove a useless test"
2012-03-04 19:35:02 -08:00
Jean Chalard
4e112d0782
Replace a useless computation with a constant
...
This is provably always false
Change-Id: I88d783fa59fec0b7a729558ba974a6a58c158645
2012-03-05 11:57:36 +09:00
Jean Chalard
a04d2358c0
Remove a useless test
...
With the current logic, this test provably always resolves
to false.
Change-Id: Iba84ef5f3a14cd8ac48c6a813519ab283bf605f8
2012-03-05 11:38:45 +09:00
Tadashi G. Takaoka
49079df8ec
Merge "Omit InputMethodManagerCompatWrapper argument from some utility methods"
2012-03-04 18:12:47 -08:00
Tadashi G. Takaoka
2d25ba2750
Omit InputMethodManagerCompatWrapper argument from some utility methods
...
Change-Id: Ic837018c702c8c575de3e5e81fe8e31fee16fe22
2012-03-05 10:43:12 +09:00
Jean Chalard
c2136c4e63
Merge "Some renaming"
2012-03-04 17:26:22 -08:00
Jean Chalard
a157249014
Merge "Remove a useless method"
2012-03-02 05:57:48 -08:00
Jean Chalard
e53840d216
Merge "Some more simplification"
2012-03-02 05:56:58 -08:00
Tadashi G. Takaoka
3a1844c33b
Merge "Support dividers in MoreKeysKeyboard"
2012-03-02 03:58:13 -08:00
Tadashi G. Takaoka
5ef4fccbb9
Support dividers in MoreKeysKeyboard
...
Bug: 6080806
Change-Id: Iacd78c6aab6abf948717d34da7489a79c41316d2
2012-03-02 20:52:25 +09:00
Jean Chalard
a83a53ba24
Some renaming
...
Change-Id: I445277cb3af469a0145a8da0ffb801b7e19048cd
2012-03-02 20:46:54 +09:00
Jean Chalard
5edda4111e
Remove a useless method
...
Change-Id: I038e6a82b6463a2a8ec494171a596d76fbc75fe1
2012-03-02 20:38:41 +09:00
Jean Chalard
dd931c47be
Some more simplification
...
I wish "are we autocorrecting?" was not computed in a dozen
places all depending on a hundred code paths
More than likely, this fixes very subtle discrepancies
between auto-correction indicator with the underline and with
the LED on the spacebar - which is not displayed any more in
the current version anyway. Especially, the LED probably
would have been off when the word was caught by the safety net.
Change-Id: Idda3021771081d6155b06915e728ecd64d9e042e
2012-03-02 20:34:10 +09:00
Jean Chalard
e2a50bd804
Optimization
...
Avoid doing some useless processing.
Change-Id: I4ce0a188e10db30322bd25751dc5c09492cea301
2012-03-02 20:26:51 +09:00
Jean Chalard
7204eab3da
Precompute two values that never change
...
Change-Id: Ic54e7926028ea8374564da5e5004d710f42c53e1
2012-03-02 20:04:42 +09:00
Jean Chalard
38e535e596
Change a parameter type to make a call clearer
...
Change-Id: I2918d0a8b00da743689b919f80128bbf36973f24
2012-03-02 20:01:34 +09:00
Jean Chalard
5bc2b61274
Move a method up a level
...
Change-Id: I6b9a697480127e4745698ab19f8a360b86ff39ca
2012-03-02 19:59:55 +09:00
Jean Chalard
d02783cb63
Break out a method
...
Change-Id: Ia14fc320422b7f198c33ba522bb93dd70fbcb2c1
2012-03-02 19:52:06 +09:00
Jean Chalard
5a2c19d4fb
Merge "Revert "Make a member read-only""
2012-03-02 02:49:42 -08:00
Jean Chalard
f1967ce322
Revert "Make a member read-only"
...
This reverts commit 6a43e39bf0
2012-03-02 02:49:24 -08:00
Jean Chalard
9727aea418
Merge "Small refactor (A1)"
2012-03-02 02:47:42 -08:00
Jean Chalard
6a43e39bf0
Make a member read-only
...
Change-Id: I9a718eaf07e1b6c659e649350d3605f365db2839
2012-03-02 19:17:57 +09:00
Jean Chalard
d992fa847d
Small refactor (A1)
...
Change-Id: Ia0838bbce47a2b60067f464685ad6d55ee4ec934
2012-03-02 18:55:04 +09:00
Tadashi G. Takaoka
ede2133cb1
Support time, date, and datetime keyboard
...
Bug: 6030364
Change-Id: I2bd4daf264757d8f3fa7c946d10a39c36ccf5905
2012-03-02 14:01:07 +09:00
Tadashi G. Takaoka
961703841e
Merge "Explicitly specify that labels might be in more keys"
2012-03-01 03:56:32 -08:00
Tadashi G. Takaoka
e4c45c6ef9
Explicitly specify that labels might be in more keys
...
Bug: 6080806
Bug: 6081427
Change-Id: I455a0210e65ea2a7774e0e0071cea5f4a99577bd
2012-03-01 20:03:47 +09:00
Jean Chalard
fa12acb8b7
Change a dangerous ID
...
The message id 0 is used intrinsically by the framework
for all messages without a specific ID. Using 0 here
we can't reliably use the post(Runnable) method on our
handler, because these would in *some* respects be taken
for update_suggestion messages, but not all.
For example, they'd be removed on removeMessage() but
they would not trigger the actual process. This would
lead to utter confusion.
Change-Id: I5d9b01d38e2ff090cd0d80c27421dc8a41c317b8
2012-03-01 19:05:51 +09:00
Jean Chalard
f3f90e6d35
Try to survive unavailability of local storage
...
Bug: 6035465
Change-Id: Ibe2d542349ec598824f78b91d374a977082fc2d1
2012-03-01 09:43:29 +09:00
Jean Chalard
5e4d2a0fa9
Remove logs now that we don't need them any more.
...
This has served its purpose, we don't need this any more.
The logging function itself can be kept since it's not called
any more. It may come in handy later.
Bug: 6053661
Change-Id: Icb40dad131793a704dbe6514cf7433e43ea04450
2012-02-22 20:45:43 -08:00
Jean Chalard
3f65960e16
Add debug prints to help with debugging
...
This is intended to help tracking #6048808 .
Another bug has been filed to remove this once we're done with
the debugging: #6053661
Change-Id: I4547fb71926af6dc2e9c23ee4b44e4e345be6657
2012-02-22 16:16:32 -08:00
Jean Chalard
5935950d44
Rename cancelCommit to revertCommit
...
This wording is easier to understand, and it matches the other
revert* functions.
Change-Id: Ibc2ec79fb5a0f9bf508e5cdeb75e54abd9241d0c
2012-02-22 01:09:23 -08:00
Jean Chalard
4fef31510d
Remove a useless code path (A7)
...
This is never called any more, since we now use the cancelCommit
path to react to a backspace after a manual pick.
This concludes the run of changes to implement feature
request #5968922
Change-Id: I23df653bb2a3de2ba0152394d5d616a42ac7519b
2012-02-22 01:05:36 -08:00
Jean Chalard
bdf89ce5fe
Rename cancelAutoCorrect to cancelCommit (A6)
...
Also remove a test in debug mode that would check for absence of
a situation which is now expected.
Change-Id: Ia5be350bc98a604b3bf8f6057652c5534f6a19af
2012-02-22 00:59:01 -08:00
Jean Chalard
2aa16dd81f
Merge "Activate the code to cancel a manual pick (A5)"
2012-02-22 00:50:13 -08:00
Jean Chalard
80c25df49d
Merge "Implement cancelling a manual pick (A4)"
2012-02-22 00:29:23 -08:00
Jean Chalard
8db74d0fae
Merge "Use the stored separator instead of reading it back (A3)"
2012-02-22 00:24:19 -08:00
Jean Chalard
9271b770e8
Activate the code to cancel a manual pick (A5)
...
This finally makes active the behavior described in
Bug: 5968922
Change-Id: I363ed23270c3dea75411ea806011225097b5d07c
2012-02-22 00:05:19 -08:00
Jean Chalard
32f0af1fc4
Implement cancelling a manual pick (A4)
...
This is new code, but simple code. The new code path is never
used for now, but it will be in an upcoming change. This serves
to implement feature request #5968922
Change-Id: I3e67731ec6e9fc0b86c5cbd972e9c081781c11a9
2012-02-22 00:00:51 -08:00
Jean Chalard
193d23f40e
Use the stored separator instead of reading it back (A3)
...
Now that we have stored our committing separator, we can use
it directly instead of reading it back from the text view
paying the IPC cost. This prepares for feature request #5968922 .
Change-Id: Ifeaa2d659cf12b91c89d28e6ff7d07a669258184
2012-02-21 23:56:36 -08:00
Jean Chalard
e043bf02f2
Merge "Give LastComposedWord knowledge of the separator (A2)"
2012-02-21 23:42:21 -08:00
Jean Chalard
1dfdc8056c
Merge "Give LastComposedWord knowledge of the committed word (A1)"
2012-02-21 23:41:42 -08:00
Jean Chalard
66bb563535
Give LastComposedWord knowledge of the separator (A2)
...
This stores the separator that was used to commit the word in
the LastComposedWord. It may be NOT_A_SEPARATOR if there was
no separator (for example, the cursor moved causing a commit,
or there was a manual pick). This is necessary to implement
feature request #5968922 .
Change-Id: I5fcf19a78ec66d68d4df89418eaef13952588207
2012-02-21 23:33:58 -08:00
Jean Chalard
cf9d92629c
Give LastComposedWord knowledge of the committed word (A1)
...
There is no point storing the prospective autocorrect - we are
recomputing it anyway. The committed word however will be necessary
to implement feature request #5968922 .
Change-Id: I588c18e1a5a1050a791d601de465f421ccbe36cd
2012-02-21 23:12:21 -08:00
Tadashi G. Takaoka
1b3c16c183
Merge "Add next/prev navigate action more keys and remove tab key"
2012-02-21 23:09:58 -08:00
Tadashi G. Takaoka
05bfd189a8
Add next/prev navigate action more keys and remove tab key
...
Bug: 6037537
Bug: 5961814
Change-Id: I9c6dedf953452a180fcd5bce7bfadfd3c821f224
2012-02-21 22:50:50 -08:00
Jean Chalard
5262fe8832
Dismiss the hint on a non-word-starting non-separator
...
This would happen when a character is not a separator but is not
a word starter. Such characters include single quote and
dollar, and others non-letter, non-separator chars.
We set the bigram predictions if any - if not so configured, this
will fallback on setting back punctuations into the strip.
Bug: 6010408
Change-Id: Id203bbe87f8c13de0d5027b555c9067c7ec98f92
2012-02-21 21:16:18 -08:00
Jean Chalard
b141c9cd3f
Rename resources to reflect current usage
...
Bug: 6010403
Change-Id: Ia02ff31007296fdf6901504f238dfd9e4621f658
2012-02-21 18:54:44 -08:00
Jean Chalard
8a3d369840
Remove a useles parens
...
...I could swear I had compiled :/
Change-Id: I4e1fb2b1dda0a4ceffe2082935395d05297c63ec
2012-02-21 16:53:05 -08:00
Jean Chalard
9a2a11e65b
Rewrite a condition
...
Change-Id: I805c9579788d99b015feb2075ad4771756c7adc5
2012-02-21 15:46:53 -08:00
Jean Chalard
2649e42d75
Extract a method to reset the ime state
...
Change-Id: I921184b85b94418cf360508ee3f67e85b10b3d72
2012-02-21 15:12:01 -08:00
Jean Chalard
5eeff7cf54
Converge paths of an if() branch
...
This is to help with further refactoring.
Change-Id: Ib2459903862570cf7022fd90f2d5c524a6bbbe19
2012-02-19 18:02:40 -08:00
Jean Chalard
1044539080
Rename variables and add comments
...
Change-Id: I746f2364d9f02f22aa6ab57d7060013ee114f4e3
2012-02-19 17:26:41 -08:00
Jean Chalard
1fead1d5f1
Read the initial selection value.
...
It turns out this was available in an unexpected place.
Fixes both the following bugs
Bug: 5948469
Bug: 6023118
Change-Id: Ie1a91b8268540ea0f0df02bee94c3bbdeb0fa4c5
2012-02-17 20:54:48 -08:00
Jean Chalard
1950964157
Merge "Don't assume a word has been added to the user dict"
2012-02-17 15:29:52 -08:00
Tadashi G. Takaoka
97bde43740
Settings key always exists in more keys of shortcut/f1 key
...
This change also
* Fix comman/f1 key for Arabic keyboard.
* Removes "show settings key option" and related stuff.
* Renames and simplifies F2 key to shortcut key on 7 inch tablet.
Change-Id: Ib1cf99ad00d9780a2f0d170260e756771e161521
2012-02-17 01:04:11 -08:00
Jean Chalard
8e4b3bbf9f
Don't assume a word has been added to the user dict
...
The user may now cancel or edit a word upon adding to the
user dictionary. We can no longer assume the word has been
added as is and for the current locale. We should just rely
on standard mechanisms that inform us of new insertions.
Bug: 6015347
Change-Id: I069b19c0c844ca29d6de4c4d162306f9413adea8
2012-02-16 19:19:05 -08:00
Tadashi G. Takaoka
beb08b398f
Remove unnecessary and harmful KeyboardState.onUpdateShiftState call
...
This change also cancels double tap and long press timers if other
letter key is pressed after shift key.
Bug: 5693999
Bug: 6017610
Change-Id: I3b5f3debfb8915fa73a93b409a38afadf24132e9
2012-02-16 18:02:17 -08:00
Jean Chalard
ad290d6505
Activate bigram predictions from the binary dictionary
...
Change-Id: If1cc50539d7677b854b1cd3bea3423c8c0865de5
2012-02-15 19:51:24 -08:00
Charles Chen
4baf767fac
Merge "Improved shift key and symbol/alpha switch key accessibility feedback."
2012-02-09 15:33:40 -08:00
Jean Chalard
accd2a9f61
Merge "Add finals"
2012-02-08 19:08:09 -08:00
Jean Chalard
a828f613a8
Merge "Some more simplification"
2012-02-08 19:05:46 -08:00
Jean Chalard
8ff0564f6a
Add finals
...
Change-Id: Ib81be9a0df34c5e9fc49d2b5d9bf02297ea2b499
2012-02-09 11:40:54 +09:00
Jean Chalard
6a800b253f
Some more simplification
...
Remove useless method calls, and ultimately remove useless
method.
Change-Id: I3f353b1b37460d5e9ceae5cb5dde3fff0da81c21
2012-02-09 11:38:03 +09:00
Jean Chalard
4721427c7d
Allow revert swap punctuation again
...
This may not be the best behavior, but it's the same as ICS.
Bug: 5981844
Change-Id: Ibb7798e2a315312310ed3be4e731d0fe1ac04456
2012-02-09 11:34:00 +09:00
Tadashi G. Takaoka
7a39bd4454
Shift+Smiley key will register newline character of textMultiLine
...
This change also
* Honors the custom action label in EditorInfo.actionLabel.
* Invokes InputConnection.performeEditorAction if action is specifed
at EditorInfo.imeOptions or actionLabel/actionId.
* Stops using InputMethodService.sendKeyChar. Implements
sendKeyCodePoint instead.
Bug: 2498607
Bug: 5961809
Bug: 5368408
Change-Id: If4cd5eb3dacfc6b6a7ea434b0617c2438e06e42d
2012-02-08 19:31:35 +09:00
Jean Chalard
82efc941ba
Merge "More simplification"
2012-02-08 01:43:23 -08:00
Jean Chalard
e771fc2f1a
More simplification
...
A suggested punctuation is sure to be 1 character and a word separator,
so the isSuggestedPunctuation() test is redundant.
Change-Id: I3d31f0825f069f64d514682e46be62afdae25291
2012-02-08 18:17:51 +09:00
Jean Chalard
9159b9953d
Fix the auto-composer to support supplementary chars
...
Change-Id: I61ff218ae2ca4eb443a370e581b677755258670a
2012-02-08 15:45:51 +09:00
Jean Chalard
8174373a0e
Merge "Remove a nested edition occurence"
2012-02-07 19:42:35 -08:00
Jean Chalard
5a6daf46cf
Merge "Cleanup"
2012-02-07 19:42:26 -08:00
Jean Chalard
862f950da3
Cleanup
...
Remove a useless test (we can only come here if the code
is not a separator, as we are only called from onCodeInput
inside an explicit test).
Change-Id: Icd996a5a1c18a550117a144a1d35f167b96211f7
2012-02-08 12:06:18 +09:00
Jean Chalard
2124bc5bf5
Remove a nested edition occurence
...
This was harmless but confusing
Change-Id: Ic271f80d3dadf01b29e3875c6a8ad51b99a936f9
2012-02-08 12:03:55 +09:00
Jean Chalard
2e2d6b4d40
Small simplification
...
Change-Id: I55f81f3ab427fd5b28bb1f31960077cd1897cbd0
2012-02-08 11:41:15 +09:00
Jean Chalard
1b986cc488
Merge "Fix a bug with manual pick then dotcom key"
2012-02-07 16:59:47 -08:00
alanv
8d4f0d5d1d
Improved shift key and symbol/alpha switch key accessibility feedback.
...
Bug: 5933165
Change-Id: Id71f38874640785b7ad43b7a70e27f40c13be748
2012-02-07 13:14:18 -08:00
Tadashi G. Takaoka
69f672a4b3
Merge "Remove unused InputConnection argument"
2012-02-07 04:15:07 -08:00
Jean Chalard
12d67e6d5d
Fix a bug with manual pick then dotcom key
...
Inhibit adding phantom space for tld keys even if the last
character inserted in the textview is not a dot
Change-Id: Ie92554ead7a18c932480905c5738aff7c0159a32
2012-02-07 20:36:48 +09:00
Tadashi G. Takaoka
64eaa67eb5
Remove unused InputConnection argument
...
Change-Id: Ic45c8c6e7730775654317fb6e2d1cb64f9031f46
2012-02-07 19:38:06 +09:00
Jean Chalard
cfec7e72fd
Merge "Fix a race condition that makes tests unstable"
2012-02-07 02:28:12 -08:00
Jean Chalard
816a8a0fd8
Fix a race condition that makes tests unstable
...
Change-Id: Ic19d380eb64855884bc6ded8547c200dd772ffe9
2012-02-07 19:22:37 +09:00
Jean Chalard
172a013ab5
Fix a bug with the auto-correct indicator
...
Bug: 5969106
Change-Id: I02d4b9184bb2c3fc0d08ffd5db77a9f9d816631f
2012-02-07 17:20:23 +09:00
Jean Chalard
a7f2500001
Fix a bug with common objects.
...
Bug: 5961179
Change-Id: I452efc552c6ab390931f25557d7aee5a64bf054e
2012-02-06 18:41:00 +09:00
Jean Chalard
fb684cebe8
Stop inserting a space after a manually picked word.
...
Bug: 4994861
Change-Id: I6ae256a94dbaddea4304304779d17025620c5025
2012-02-03 18:45:44 +09:00
Tadashi G. Takaoka
909b2940db
Merge "Get rid of Key.setIcon(Drawable)"
2012-02-02 21:51:51 -08:00
Tadashi G. Takaoka
e7948a8692
Get rid of Key.setIcon(Drawable)
...
Change-Id: If6ebbdefcbfd0cc14c72858f9bb44861e8abe079
2012-02-03 14:38:17 +09:00
Jean Chalard
825e2bbd91
Fix a bug when deleting the last char
...
And unit test
Change-Id: Ic4fc3626f8b86e10156d770d41cd6deab5d31f39
2012-02-03 13:03:54 +09:00
Jean Chalard
9242a2bcf8
Fix string iterations in a couple places.
...
Seems I didn't get how to iterate on a String correctly >.>
Talk about a big bug. Anyway, I think it's working now.
Bug: 5955228
Change-Id: I988c900cf2a16c44b9505cfd4f77c7cda7e592f0
2012-02-03 11:15:46 +09:00
Tadashi G. Takaoka
8261a4cad7
Merge "Move CSV parser to KeySpecParser"
2012-02-01 23:25:17 -08:00
Tadashi G. Takaoka
0086861d5a
Move CSV parser to KeySpecParser
...
Change-Id: I424fb47bc70e9b6aaa5a16ae9b2500d23da75c26
2012-02-02 16:10:14 +09:00
satok
e05b3f4b3a
Support additional proximity characters
...
Change-Id: Ifbe0d7e4eafea1926bbce968eae4724dd5769689
2012-02-02 16:07:16 +09:00
Tadashi G. Takaoka
8ca325f437
Merge "Make KeySpecParser and CSV parser code point aware"
2012-02-01 22:56:54 -08:00
Tadashi G. Takaoka
e01d272603
Make KeySpecParser and CSV parser code point aware
...
This change also renames MoreKeySpecParser to KeySpecParser
Change-Id: I35733cdbb344f16b57ffa2cfe79055c089b4e409
2012-02-02 15:51:40 +09:00
Jean Chalard
51fd1632f5
Stop throwing an exception in some corner cases.
...
When the application is modifying the text under our feet,
we may come through this code path. We should log the error
rather than crash.
Bug: 5869235
Change-Id: Ic0fd24c3bc805d44c5db0ad781ddebeca0450614
2012-02-02 15:15:55 +09:00
Tadashi G. Takaoka
ff858c7ff5
Use MoreKeySpecParser to parse puctuations strip resources
...
This change also
* Doesn't use Key.getRtlParenthesisCode to get correct parentheses
code in RTL context. Intead uses the outputText feature of
moreKeys specification.
* Move CVS string parser from KeyStyles to Utils.
Bug: 5948247
Change-Id: I45752c7d01b4f7d3f3da900b110a2185b336a1f0
2012-02-01 19:33:26 +09:00
Tadashi G. Takaoka
a5c96f376a
Move long press shift handling from PointerTracker to KeyboardState
...
This change also
* Rename phone shift keyboard to phone symbols keyboard.
Use CODE_SWITCH_ALPHA_SYMBOL code to switch between phone and phone symbols keyboard.
* Remove phone symbols keyboard from tablet.
* Introduces enableLongPress flag of Key.keyActionFlags attribute.
* Remove clumsy long press code from PointerTracker.
* Remove CODE_CAPSLOCK handling from LatinIME.
* Make KeyboardSwitcher to invoke haptic and audio feedback.
Change-Id: I00e1f697a10ab5112aec75e36853b96246ff5054
2012-02-01 19:04:21 +09:00
Tadashi G. Takaoka
433ca6a46d
Cleanup redundant methods of KeyboardSwitcher
...
Change-Id: I2ebeb8852177f6c6e30578d0bb3f372f488dc6c1
2012-01-31 17:18:14 +09:00
Tadashi G. Takaoka
ca2f051cc1
Auto generate various shift states alphabet keyboard automatically
...
If any shift state variants of alphabet keyboard layout is not
specified in KeyboardSet.Element, it will be automatically generated
from base alphabet keyboard definition.
This change also
* Eliminates KeyboardShiftState object from Keyboard.
* Removes various set shift state methods from Keyboard.
* Removes KeyboardSet.Element.elementAutoGenerate attribute.
* Separates "sticky" Key.backgroundType to "stickyOff" and "stickyOn"
* Add preserveCase flag to smiley, .com, and labeled special keys.
* Rename KeyboardShiftState class to AlphabetShiftState.
* Rename some attributes from *UppercaseLetter* to *ShiftedLetterHint*.
* Introduce shiftedLetterActivated to Key.keyLabelFlags
Change-Id: I01a0a8efeeaa76820ae728a5bdfa8d02b6ce74b7
2012-01-31 12:55:45 +09:00
Ken Wakasa
6029b43a3d
Add "size" and "pressure" for MotionEvent logs
...
bug: 5722703
Change-Id: I8e08942324b666de96682ce63e70c8d324535782
2012-01-30 12:22:15 +09:00
Jean Chalard
449415c72f
Cleanup (A9)
...
Deactivate the LastComposedWord when the commit was not the right
type, instead of fooling it by passing it a null auto-correction.
Change-Id: I032b477dc691bd151a644ca4b0c9f0a9b5512e45
2012-01-26 20:10:49 +09:00
Jean Chalard
5971a0a0bb
Remove a useless member (A8)
...
It turns out this can be removed entirely.
Change-Id: I6f23703cef1666311989a825285317eef696487f
2012-01-26 20:10:49 +09:00
Jean Chalard
be79227dc9
Remove the CharacterStore class (A7)
...
Remove the now useless WordComposer.CharacterStore class
and merge back its members inside WordComposer. This should
simplify the word composer a bit.
Change-Id: I5fe32418c62a583cd558dce98758a4701559bdf5
2012-01-26 20:03:44 +09:00
Jean Chalard
c7c152de4b
Guard against wrong auto-correction cancellation (A6)
...
This deactivates the cancellation at each separator pressed while
not composing a word. The net effect is to fix
Bug: 5875776
Change-Id: I67aa3f842ddff250828c60596ad5a7e466c1ddaa
2012-01-26 19:57:37 +09:00
Jean Chalard
b6b8729374
Straighten out resuming suggestion on kept word (A5)
...
This is cleanup.
This also introduces a "deactivated" state to the last committed
word, that can be used for
Bug: 5875776
Change-Id: I1855adb8ac8123f6d2c5365b0ae899145e5c3ba1
2012-01-26 19:24:36 +09:00
Jean Chalard
2712f23acb
Remove mCommittedWordSavedForSuggestionResuming (A4)
...
Change-Id: Ia62ef33b5c777a258b02280bda1b8368780a7eef
2012-01-26 18:36:28 +09:00
Jean Chalard
2692a87007
Move some functionality into LastComposedWord (A3)
...
Change-Id: Ie0ea02a061dd0cb84db5f33113ff433584636bc7
2012-01-26 18:25:08 +09:00
Jean Chalard
1f8fc62ccb
Add useful information to LastComposedWord (A2)
...
Change-Id: Idf47f2e2bdd1d6394fc4b1ab7df28d64a808da1e
2012-01-26 17:49:55 +09:00
Jean Chalard
95eeb2df63
Merge "Add a class for previously composed data (A1)"
2012-01-26 00:43:57 -08:00
Jean Chalard
267563d1bb
Add a class for previously composed data (A1)
...
Change-Id: I87498799e6a48b8fa65924a098bb0ceb7626dce1
2012-01-26 17:22:52 +09:00
Tadashi G. Takaoka
736d740aa5
Merge "Get rid of Resource reference from KeyboardView, LatinKeyboardView and PointerTracker"
2012-01-26 00:17:56 -08:00
Tadashi G. Takaoka
160f01211d
Get rid of Resource reference from KeyboardView, LatinKeyboardView and PointerTracker
...
This change introduces the following attributes.
* KeyboardView
- keyPreviewLingerTimeout
* LatinKeboardView
- keyHysteresisDistance
- touchNoiseThresholdTime
- touchNoiseThresholdDistance
- slidingKeyInputEnable
- keyRepeatStartTimeout
- keyRepeatInterval
- longPressKeyTimeout
- longPressShiftKeyTimeout
- longPressSpaceKeyTimeout
- ignoreSpecialKeyTimeout
- showMiniKeyboardAtTouchedPoint
Change-Id: I25159a87289b12447e20031add173523070e9b03
2012-01-26 16:10:20 +09:00
Tadashi G. Takaoka
bd51aaf98f
Merge "Warn deprecated privateImeOptions, "nm" and "forceAscii""
2012-01-25 22:20:35 -08:00
Jean Chalard
051ac1ef14
Merge "Add a guard against OOB."
2012-01-25 21:22:18 -08:00
Jean Chalard
8be16f78b1
Add a guard against OOB.
...
...and avoid crashing in one case where the application may
change the text while we are typing.
Bug: 5685922
Change-Id: I4a22c63168986f43ac84f512aaa4267023d536e3
2012-01-26 14:17:48 +09:00
Jean Chalard
5a38ff305f
Merge "Convert an internal enum into an int of same underlying value."
2012-01-25 21:13:56 -08:00
Tadashi G. Takaoka
4f5c3a2898
Warn deprecated privateImeOptions, "nm" and "forceAscii"
...
Public API EditorInfo.IME_FLAG_FORCE_ASCII has been supported by
I6665b483.
Change-Id: I0ffdee15d8177d126cd8fe86a6bc4ab21be58c36
2012-01-26 13:37:35 +09:00
Jean Chalard
6e082cb30d
Convert an internal enum into an int of same underlying value.
...
Goes together with Id4f4e066
Bug: 5922118
Change-Id: I1e39dd01c67e9284d9d7fe008d868847e69986d7
2012-01-26 13:07:51 +09:00
Jean Chalard
fda847a870
Small cleanup
...
All calls to this method are done with the same parameter,
and it's really hard to understand if we call upon this
member inside.
Change-Id: I787664bb59053ab0fe666ed812fb12b2b9090918
2012-01-26 11:40:16 +09:00
Jean Chalard
d9702a375a
Merge "Add a test for auto-correction."
2012-01-25 02:33:39 -08:00
Jean Chalard
0bfe359ee4
Add a test for auto-correction.
...
Fix two related subtle bugs:
- Stop singling out fat-finger-only corrections for rejection
when touch coordinates are not available.
- Remove a racy check that would happen only in debug mode
Change-Id: Ic904f9b27c091ca6b369052c4e65a630bff81257
2012-01-25 19:29:40 +09:00
Tadashi G. Takaoka
38d6a18821
Use String instaed of CharSequence in Key class
...
Change-Id: Ia76a41daede402ed2a509e110ae97d6bb660c760
2012-01-25 17:04:00 +09:00
Jean Chalard
77da3d5a3b
Fix a bug where backspace would not delete the selection
...
Bug: 5699301
Change-Id: I6c5a8470464d045349ac38e191c859b5c34cbeee
2012-01-24 18:07:23 +09:00
Jean Chalard
5fd11a7f33
Fix a typo
...
Change-Id: I358350c959d5610214a752b14d7744fe83eb3821
2012-01-24 11:58:07 +09:00
Jean Chalard
35e9a7ac55
Merge "Squash a ridiculously improbable NPE"
2012-01-22 18:37:29 -08:00
Tadashi G. Takaoka
54c2dd67b0
Merge "Support @string reference in moreKeys attribute"
2012-01-20 01:59:31 -08:00
Tadashi G. Takaoka
e54a4005d5
Support @string reference in moreKeys attribute
...
Change-Id: If0056d0601149d2ddd0e231a81e7b2409b37fc06
2012-01-20 18:46:33 +09:00
Jean Chalard
7c177e82af
Merge "Fix a bug where a check would fail"
2012-01-20 01:16:44 -08:00
Jean Chalard
7546ff6e34
Fix a bug where a check would fail
...
Bug: 5894393
Change-Id: I810de58730f2cabcaf7b8dc1d85b3725f959094b
2012-01-20 18:09:59 +09:00
Tadashi G. Takaoka
3eede315dc
Merge "Move MoreKeySpecParser.getResourceId to Utils"
2012-01-20 00:01:29 -08:00
Tadashi G. Takaoka
0718590486
Move MoreKeySpecParser.getResourceId to Utils
...
Change-Id: I0640dbe76a8ff2dc45b504eca631942811571736
2012-01-20 16:28:18 +09:00
Jean Chalard
af9fe5c5fc
Fix a bug where the user typed word would not be passed.
...
Bug: 5894271
Change-Id: I4f02ff322697159e08f5e898608c0aff11dacb2f
2012-01-20 15:39:06 +09:00
Jean Chalard
250cf0a781
Merge "Fix a bug with backspace happening after a manual pick."
2012-01-19 01:55:30 -08:00
Jean Chalard
3b2112e70a
Fix a bug with backspace happening after a manual pick.
...
Bug: 5884397
Change-Id: I01f462075bcbf7da38e9af2084ecd37143923e8b
2012-01-19 18:41:02 +09:00
Jean Chalard
95a6e58ebc
Small code simplification.
...
I'm pretty sure the test here was useless.
Change-Id: Iaece641fbd5455406533b19555f2b639759a525f
2012-01-19 18:03:45 +09:00
Jean Chalard
af480be66e
Squash a ridiculously improbable NPE
...
This probably can't be triggered by anything that is not
a monkey, but still, let's fix this
Bug: 5797549
Change-Id: I9a7d9fd6664c97787ce676a28675e96f46df7658
2012-01-19 12:06:00 +09:00
Tadashi G. Takaoka
5731b939c7
Remove KeyboardSwicther.toggleCapslock
...
Change-Id: Id613c06e2df770659095d78d42637aed063d0c70
2012-01-17 19:26:24 +09:00
Tadashi G. Takaoka
2a88440419
Rename KeyboardActionListener methods
...
* Rename KeyboardActionListener.onPress to onPressKey
* Rename KeyboardActionListener.onRelease to onReleaseKey
* Merge KeyboardSwicther.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardSwitcher.onReleaseShift and onReleaseSymbol to onReleaseKey.
* Merge KeyboardState.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardState.onReleaseShift and onReleaseSymbol to onReleaseKey.
Change-Id: Icf28fd18e238c5e534c292893e4ab5b6b98e72f8
2012-01-17 19:07:20 +09:00
Tadashi G. Takaoka
c9fade6b87
Merge "Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher"
2012-01-17 00:07:38 -08:00
Tadashi G. Takaoka
87e025da11
Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher
...
Change-Id: I9bb8f78b0a766cd7937d5cbe1c1e5e35898b2997
2012-01-17 16:49:33 +09:00
Jean Chalard
d104a7aac8
Merge "Fix a bug where words disappear on inserting separators"
2012-01-16 23:22:03 -08:00
Jean Chalard
edc6395d9b
Fix a bug where words disappear on inserting separators
...
The basic idea is that in some situations, we would restart
suggestions, but before evaluating them we would bail out
because suggestions were not requested. This would lead to
the "correction" set to null, so we would commit a null word.
This fix does two things:
- Do not restart suggestions when not requested.
- If we still end up with a composing word when suggestions
are not requested, we select the typed word as the
correct version.
Bug: 5846646
Change-Id: Ic35351841d0cb20afa99092ef681ecb7bd68bec6
2012-01-17 16:16:52 +09:00
Jean Chalard
aed5819a84
Merge "Fix a bug where suggestion would restart at a bad time"
2012-01-16 22:51:23 -08:00
Jean Chalard
fbd1ac8083
Fix a bug where suggestion would restart at a bad time
...
Bug: 5846646
Change-Id: I7c907d0a9478e0878b92ead94173caefc21b627b
2012-01-17 15:50:18 +09:00
Tadashi G. Takaoka
1ef6fc7e15
Support EditorInfo.IME_FLAG_FORCE_ASCII
...
Bug: 5850605
Change-Id: I6665b483f775094903f2e26f5584e4b141592ab5
2012-01-17 14:38:00 +09:00
Tadashi G. Takaoka
edf107e2a6
Merge "Add "force non-distinct multitouch" debug option"
2012-01-16 20:22:36 -08:00
Tadashi G. Takaoka
06b7c256b1
Add "force non-distinct multitouch" debug option
...
Change-Id: I9fd6fabf03515011cedb8aaa30fdb7a77f2d4d12
2012-01-17 13:19:01 +09:00
Jean Chalard
a8ba49c253
Small cleanup
...
The method deleteWordAtCursor would call finishComposingText,
which is a very unexpected state change and would probably cause
surprising bugs to any parent that would call it.
As it happens, it's not used anywhere any more so let's just
remove it.
Change-Id: Iaa9200866e40b4e914f76baa987279948300679c
2012-01-17 11:55:23 +09:00
Jean Chalard
72d285f4d7
Add some comments about resuming auto-suggestion
...
Bug: 5846646
Change-Id: Ib2c76ec173972eb7acadbfaae7e930849d546721
2012-01-17 10:29:11 +09:00
Tadashi G. Takaoka
9751a626ec
Don't cache resource value that depends on orientation
...
Bug: 5794655
Change-Id: Ib324366c772e20bb54aba63c2f4540dc0f9de515
2012-01-16 12:26:34 +09:00
Tadashi G. Takaoka
211680e375
Merge "Fix SuggestTests"
2012-01-13 01:39:43 -08:00
Tadashi G. Takaoka
9c735b8038
Fix SuggestTests
...
We need revised scoring test because dictionary look up algorithm has
been changed significantly since this SuggestTests was made.
Change-Id: I69d527a6bfa24ed0dc189fddad1afab0566c6eb8
2012-01-13 15:25:28 +09:00
satok
4da8e8e4d3
Merge "Fix a bug in the logic to show 3 dots of the ime switcher"
2012-01-12 19:41:12 -08:00
satok
83a018419a
Fix a bug in the logic to show 3 dots of the ime switcher
...
Bug: 5806103
Change-Id: I67b3f0bb25d5fb9cfb902c03f41ae3e582107187
2012-01-13 11:50:31 +09:00
satok
21814c56f0
Merge "Move auto correction thresthold to the native code"
2012-01-12 02:58:35 -08:00
satok
be0cf72253
Move auto correction thresthold to the native code
...
bug: 5858137
Change-Id: Ic4b6270c6e51ef4ed25a6a1d8ddd7fdfa70fd78d
2012-01-12 19:56:15 +09:00
Jean Chalard
ab34a4a7f5
Merge "Fix a bug where last candidate would not be reset"
2012-01-11 21:47:35 -08:00
Jean Chalard
cda8a42cbe
Merge "Add a sanity check"
2012-01-11 21:47:26 -08:00
Jean Chalard
a8c8ab1cb4
Remove an excessive parens
...
Change-Id: If8aa4253ab0f664e628ed7f4d7a3adc02a898cc7
2012-01-12 14:07:56 +09:00
Jean Chalard
852630ba34
Add a sanity check
...
Check if any character is both a magic space swapper and
a magic space stripper for the current language, and throw
an exception if found. Since this is expensive, it's done
only in debug mode.
Change-Id: Ibd166db87c91495b76878ea0e4f420a62c7bb276
2012-01-12 12:44:49 +09:00
Jean Chalard
9de5cfc67a
Fix a crash where revertSwap would be wrongly called
...
This would crash the program when inputting a punctuation
symbol that should not swap with a weak space through the
suggestion strip, then press backspace.
Those include all two-part punctuation symbols in French for
example, as well as magic space strippers like the dash in
English. For English all suggestion strips symbols happen to
be magic space swappers so this would not happen in English
by default.
Also fix a typo.
Change-Id: Ia40678c264e978509b5786290a75a3c57181648e
2012-01-12 11:55:40 +09:00
Jean Chalard
cd2286fff1
Fix a bug where last candidate would not be reset
...
Bug: 5851148
Change-Id: Ic270318842d8e16bc62d78d5fe0d6be0ca1fb532
2012-01-12 11:16:51 +09:00
Tadashi G. Takaoka
8cab0b56eb
Get rid of Keyboard.CODE_DUMMY
...
Change-Id: Id2320f4d9b5f22f0ac844ab20ce42b0c4e7c6880
2012-01-10 18:19:36 +09:00
Tadashi G. Takaoka
ee4be6e3c6
Call KeyboardState.onUpdateShiftState from onCodeInput if code is a normal letter
...
This will be helpful to write unit test code.
Change-Id: Ib61cc46ac547084e0dc9ecd3a50814fecf08ace2
2012-01-10 15:13:05 +09:00
Ken Wakasa
0d0f01da67
Fix a typo. A follow up to I68dd6b8d
...
Change-Id: I16fa4099c75faac35344b0e4d3c2b866ddac896a
2011-12-21 22:34:08 +09:00
Jean Chalard
0fd625bcfd
Fix a bug with wrong auto-correct cancellation
...
Auto-correct cancellation would sometimes kick in at
wrong times, causing crashes.
Bug: 5784542
Change-Id: I68dd6b8d9237ce9b66af2dc63e77ba6dd5fd69dd
2011-12-21 19:28:02 +09:00
Jean Chalard
752d8cc4fc
Fix a bug with TYPE_TEXT_CLASS
...
This was introduced by a badly-rebased commit. The culprit was
I103d6851. There was also another bug lurking there introduced
by a previous commit that this fixes.
Bug: 5775347
Change-Id: I133b54a5159e19714f4bcae8ffbb4824cff9f466
2011-12-20 15:31:55 +09:00
Jean Chalard
9e8761c440
Reorganize the auto-correction memory
...
Change-Id: I31cce9db471dcd4a7b3477bcb037a8ff482b7696
2011-12-19 17:33:15 +09:00
Tadashi G. Takaoka
4e1dab8cfa
Move KeyboardBuilder and KeyboardParams classes into Keyboard class
...
This change also moves XmlParseUtils to com.android.inputmethod.latin package.
Bug: 5778201
Change-Id: I7d9faa344460753ce178ad4048e0fadb65c75614
2011-12-18 20:19:16 +09:00
Tadashi G. Takaoka
3708787fe9
Remove LatinKeyboard class
...
Change-Id: I68c667b00dadf2ed9f1c62fb7da37d2cf499cd81
2011-12-18 19:10:42 +09:00
Tadashi G. Takaoka
4112dc0500
Move spacebar drawing code from LatinKeyboard to LatinKeyboardView
...
Also this change moves LatinKeyboard attributes,
autoCorrectionSpacebarLedEnabled, autoCorrectionSpacebarLedIcon,
spacebarTextRatio, spacebarTextColor, and spacebarTextShadowColor to
LatinKeyboardView.
Change-Id: I7cc27ce1fc550e9f620a9ed0fbe4b8172902d5a1
2011-12-18 19:07:12 +09:00
Tadashi G. Takaoka
22b48de11c
Get rid of Key.needsSpecialPopupHint and related
...
Change-Id: I28e87ea3af9581f12094770b42f113e9018886c4
2011-12-18 16:08:28 +09:00
Jean Chalard
43c0a034bd
Merge "Pretty print for InputAttributes"
2011-12-16 04:01:49 -08:00
Jean Chalard
4d0f03bd66
Remove a write-only variable.
...
Change-Id: I825307a429f46b31ed9bd940b5a97d2713127dfe
2011-12-16 20:54:58 +09:00
Jean Chalard
6fa003ee23
Pretty print for InputAttributes
...
Change-Id: I5e4b2b6f3cd943c8f6187aaed21d67ec786bf5df
2011-12-16 20:53:44 +09:00
Jean Chalard
2b2c0b574c
Merge "Use the WordComposer to check if we are composing a word"
2011-12-16 03:47:34 -08:00
Jean Chalard
80b66bb166
General cleanup.
...
Move variables around, inline useless functions, remove
useless local variables.
Change-Id: Icb89d8b211a2ad4bc3619137c2276a649c2a5e34
2011-12-16 20:36:32 +09:00
Jean Chalard
644c8b7c96
Initialize input attributes in the InputAttribute class
...
Change-Id: I103d6851f54f47cbffdb567fb0f4c505c4697b05
2011-12-16 20:35:16 +09:00
Jean Chalard
3b7aceca60
Merge "Make applicationSpecifiedCompletionOn final."
2011-12-16 03:20:00 -08:00
Tadashi G. Takaoka
bf7ed75e4f
Merge "Move KeyboardSwitcher.getKeyboard to KeyboardSet"
2011-12-16 03:13:38 -08:00
Tadashi G. Takaoka
645128af71
Move KeyboardSwitcher.getKeyboard to KeyboardSet
...
This change also gets rid of XML id from KeyboardId.
Bug: 5002108
Bug: 5679585
Change-Id: I7086c7da3c01ba4ade7f77ee5cc731310da46404
2011-12-16 20:10:57 +09:00
Jean Chalard
ccc35f7fa7
Make applicationSpecifiedCompletionOn final.
...
This is the last one (whew)
Also move a somewhat unrelated initialization out of the
input attribute initialization function.
Change-Id: Icc77b32fd16b112ab43786715061b1c9dca31c04
2011-12-16 19:09:01 +09:00
Jean Chalard
9cc1312eee
Make inputTypeAutoCorrect final.
...
Change-Id: I550eba1fc3fa2843d007a8208d81fad208c1196b
2011-12-16 19:08:52 +09:00
Jean Chalard
13db05f930
Make isSettingsSuggestionStripOn final.
...
Change-Id: Iabb99a7f8f3f1777f9a87ae2bddff9795a50fa92
2011-12-16 19:08:13 +09:00
Jean Chalard
1ba17f97d5
Small refactoring
...
This helps to make following changes smaller
Change-Id: I95ba2901ac3bf1ed70a748c35a0babdd9af1df63
2011-12-16 18:21:26 +09:00
Jean Chalard
4fc0f6ab02
Merge "Make insertSpaceOnPickSuggestionManually final."
2011-12-16 01:15:35 -08:00
Jean Chalard
2ad14a2ea7
Merge "Use temporary variables for computing editor attributes"
2011-12-16 01:07:56 -08:00
Jean Chalard
520e69056e
Merge "Create a class for input attributes."
2011-12-16 01:06:12 -08:00
Jean Chalard
ae0c109d11
Make insertSpaceOnPickSuggestionManually final.
...
Change-Id: I32fce0ea8c5c58b6f920d0758c8bf57769f39a12
2011-12-16 18:04:39 +09:00
satok
cadc0f7d79
Merge "Send touch event in usability study mode"
2011-12-16 01:04:26 -08:00
Jean Chalard
4e8922f1be
Use temporary variables for computing editor attributes
...
The ultimate intent is to make these variables final,
which will allow to move the computing function to the
InputAttributes class.
Change-Id: Ifb1fc7321a19b10d60aa63fa0daaa2708deda2cf
2011-12-16 18:04:17 +09:00
Jean Chalard
dc9d0fcc11
Create a class for input attributes.
...
Change-Id: I834390c83865aac59fb758d5c66cf9b74103abd8
2011-12-16 18:03:16 +09:00
satok
15d4793911
Send touch event in usability study mode
...
Change-Id: I0cdcd57bfd31c9b21cfb932d7ff91bd013cde6d7
2011-12-16 17:56:14 +09:00
Jean Chalard
196d82cdd7
Use the WordComposer to check if we are composing a word
...
...instead of the hard-to-understand mHasUncommittedTypedChars.
This is possible because now the word composer is actually aware
of commits.
Change-Id: I36b664ce8402a280f801e87b9ebe161f416b0853
2011-12-16 15:58:29 +09:00
Jean Chalard
be2f81f055
Merge "Make the word composer aware of commits."
2011-12-15 22:54:23 -08:00
Jean Chalard
c73c26790f
Make the word composer aware of commits.
...
Change-Id: I04e691fbc9227d4df195429bca89edea93575347
2011-12-16 15:41:10 +09:00
Tadashi G. Takaoka
8c3d5b6961
Add com.android.inputmethod.latin.suggestions package
...
Change-Id: If4b823768ab9c073625da3034ecc8091be1df230
2011-12-16 14:21:44 +09:00
Tadashi G. Takaoka
a44685ab32
Add colorValidTypedWord and alphaValidTypedWord
...
This change fixes Gingerbread theme.
Change-Id: I142437ac0173df48ab36390f47ed67c6cea24a65
2011-12-16 12:26:19 +09:00
Tadashi G. Takaoka
e9a0efc242
Merge "Cleanup unused variables and parameters"
2011-12-15 18:02:38 -08:00
Tadashi G. Takaoka
2ac5988f84
Cleanup unused variables and parameters
...
Change-Id: Iad756a7a775c93f3344c6962e7b3456ef8339490
2011-12-15 20:26:12 +09:00
Jean Chalard
05f654d498
Merge "Group all input-related info into an inner class."
2011-12-15 03:21:47 -08:00
Tadashi G. Takaoka
c3ef86d861
Merge "Fix auto correction spacebar LED"
2011-12-15 03:19:32 -08:00
Jean Chalard
27dff63833
Group all input-related info into an inner class.
...
Currently, these variables hold the info about the composing
word, or maybe some outdated info, and it's not very clear
which it is. LatinIME is maintaining the freshness info in
a separate boolean, and uses it throughout the code for many,
many things, leading to much confusion.
The idea in grouping this info is, it can be saved in another
instance and restored later. It can be tested against to know
whether there is actually outdated but kept info or not, and
it should allow to straighten out what is actually currently
being typed. Ultimately, it will eliminate the need for
LatinIME to keep track of the status of the info in the
word composer.
Change-Id: I00e2c690f303f8320c9be35590a6df4583e9e456
2011-12-15 19:58:04 +09:00
Tadashi G. Takaoka
2d74806262
Change visibility to avoid synthetic accessor method
...
Change-Id: Ie93c7437fb9a3fe63adaa48c2d4a723f96c0a0e1
2011-12-15 19:50:53 +09:00
Tadashi G. Takaoka
23d27fefcb
Fix auto correction spacebar LED
...
Change-Id: I4894d188d5612380cc9f8eec7cb72544e37fb2b0
2011-12-15 17:34:14 +09:00
Jean Chalard
f3ca6a59a7
Cleanup
...
Change-Id: I724df0be7ac07ffb9f1f4974175aed5a2606221b
2011-12-14 18:42:47 +09:00
Jean Chalard
1c6cf26c37
Move some code inside a function to simplify flow
...
Also rename the function to reflect better the behavior.
An upcoming change will clean up the remnants
Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
2011-12-14 17:56:57 +09:00
Jean Chalard
46798d8f1f
Fail faster in case of a bug
...
Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
2011-12-14 17:54:18 +09:00
Jean Chalard
b588003426
Refactoring.
...
Small simplification of the code.
Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
2011-12-14 16:59:25 +09:00
Tadashi G. Takaoka
e35e13fc7d
Merge "Record onStartInputView"
2011-12-13 23:31:43 -08:00
Tadashi G. Takaoka
689b901156
Merge "Utilize KeyboardSet XML definitions"
2011-12-13 23:31:00 -08:00
Jean Chalard
dbdb385bb0
Merge "Fix a long-standing race condition."
2011-12-13 23:29:47 -08:00
Tadashi G. Takaoka
f86109ca56
Utilize KeyboardSet XML definitions
...
This change introduces KeyboardSet and SubKeyboard XML definitions to
represent a set of keyboard layouts.
Bug: 5002108
Bug: 5679585
Change-Id: Ib6c8d5936187381bb6725c9fe574e93871c01a86
2011-12-14 16:28:31 +09:00
Jean Chalard
514beb0992
Fix a long-standing race condition.
...
Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.
Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
2011-12-14 16:24:18 +09:00
Tadashi G. Takaoka
7ef235f53f
Record onStartInputView
...
Bug: 5722703
Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
2011-12-14 16:22:30 +09:00
Jean Chalard
8e3faff244
Merge "Decouple member logic from control flow"
2011-12-13 06:28:48 -08:00
Jean Chalard
7b5bc1ff4d
Decouple member logic from control flow
...
This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.
Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
2011-12-13 23:15:12 +09:00
Jean Chalard
f7d6517d6b
Various mini-cleanups
...
- Stop the word composer from escaping - take a page from the law
of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.
Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
2011-12-13 23:09:22 +09:00
Jean Chalard
edf4995a3b
Merge "Remove the input connection sidework from handleCharacter"
2011-12-13 04:28:30 -08:00
Jean Chalard
dafa7a8e15
Remove the input connection sidework from handleCharacter
...
Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
2011-12-13 21:12:07 +09:00
Jean Chalard
117fc93f37
Move mBestWord to the word composer.
...
mBestWord has a confusing name - it's actually an auto-correction.
It's cleaner if it lives in the word composer because an
auto-correction should be tied to a specific user input, and
should be reset each time the user input changes to avoid
race conditions.
Change-Id: I718d29395bc747372067e6440e090c6a181994ae
2011-12-13 21:06:51 +09:00
Jean Chalard
7e6f4daa19
Merge "Tighten conditions for space-related cancelling"
2011-12-13 01:23:15 -08:00
Jean Chalard
c525750835
Merge "Consolidate underlining code under one function."
2011-12-13 01:22:08 -08:00
Jean Chalard
77d59b0691
Consolidate underlining code under one function.
...
Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
2011-12-13 17:42:27 +09:00
Jean Chalard
8ad4013406
Tighten conditions for space-related cancelling
...
Instead of ignoring silently a found bug, throw an exception.
Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
2011-12-13 17:40:06 +09:00
satok
ba526e3157
Extract the jni library name
...
Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
2011-12-13 17:25:43 +09:00
Jean Chalard
14cb8448df
Remove a useless return
...
Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
2011-12-13 16:48:28 +09:00
Jean Chalard
2939063947
Simplification
...
Both tests have the same meaning. They should be merged.
Also, if "deleteLast()" deletes more than one char (which
never happens in the current implementation, but it's not
guaranteed), the new code is more correct.
Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
2011-12-13 16:06:00 +09:00
Jean Chalard
d2c69c7d12
Refactoring
...
If mHasUncommittedTypedChars is true, then
mWordSavedForAutoCorrectCancellation must always be null, and
spaceState must always be SPACE_STATE_NONE.
Hence, this change is supposed to be very no-op.
Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
2011-12-13 16:04:11 +09:00
Jean Chalard
2245c3b5b3
Refactor + small bugfix
...
postUpdateShiftKeyState used to be called also when
mEnteredText is not null => this is a bugfix.
The rest does not change the logic, as posting a message can
be done anywhere within the function with no impact.
Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
2011-12-13 15:59:36 +09:00
Jean Chalard
a2a85d45e0
Refactoring
...
Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
2011-12-13 15:38:49 +09:00
Jean Chalard
34081186f9
Merge "Fix a bug where revert auto-correct would revert too much"
2011-12-12 04:46:27 -08:00
Jean Chalard
5c3ff4c9c8
Fix a bug where revert auto-correct would revert too much
...
If there are no uncommitted chars, we shouldn't enter any of
the tests that follow. We didn't use to, but a change today
made it possible - it should not happen.
There is no point in doing the rest of the tests, they are
sure to fail.
Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
2011-12-12 21:27:16 +09:00
Jean Chalard
4f41cbc588
Remove a useless function call
...
Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
2011-12-12 20:51:43 +09:00
Jean Chalard
dcf8a6b2c6
Merge "Move a settings var to the settings class"
2011-12-12 03:31:42 -08:00
Jean Chalard
2a659b8aa6
Remove a useless variable
...
This can be just read when it's needed.
Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
2011-12-12 20:22:39 +09:00
Jean Chalard
d567b230b0
Move a settings var to the settings class
...
Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
2011-12-12 19:52:17 +09:00
Jean Chalard
7208af0ecd
Remove a messy and unused class.
...
Today is a happy day
Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
2011-12-12 19:31:29 +09:00
Jean Chalard
f162ed7ec8
Merge "Remove side-effects from TextEntryState"
2011-12-12 02:20:49 -08:00
Jean Chalard
406d192a9e
Remove side-effects from TextEntryState
...
Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
2011-12-12 19:19:39 +09:00
Jean Chalard
c2a76a1529
Remove a useless variable.
...
Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
2011-12-12 16:49:32 +09:00
Jean Chalard
890d13189d
Straighten out logic for revert word paths
...
This also includes a new memorized string with simpler
logic that will allow to remove other members
Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
2011-12-12 16:41:49 +09:00
Jean Chalard
86344836ee
Merge "Remove a duplicated variable."
2011-12-11 21:26:31 -08:00
Tadashi G. Takaoka
2ba1bcccdd
Remove unused Keyboard.CODE_CANCEL
...
Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
2011-12-12 12:56:30 +09:00
Jean Chalard
3651220327
Remove a duplicated variable.
...
This is awesome cleanup.
Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
2011-12-12 12:06:41 +09:00
Ken Wakasa
9260422423
Build God Mode keyboard with API level 14
...
Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8
2011-12-10 03:45:40 +09:00
satok
4af5e3c5f4
Fix isResearcherPackage
...
Change-Id: I286450fe89a37d75cb398f17d300ddc6f5857ffd
2011-12-10 01:16:16 +09:00
Ken Wakasa
2edd109f84
Some tweaks for Researcher Mode
...
Change-Id: I6b16dd2fe6d7356c747ba0ee2da5976738003ded
2011-12-10 00:35:50 +09:00
satok
2a89e36db0
Merge "Add a functionality to attach a log file to Gmail app Bug: 5722703"
2011-12-09 05:59:36 -08:00
satok
a8b6292cee
Add a functionality to attach a log file to Gmail app
...
Bug: 5722703
Change-Id: I089f944bdbf2cbb036eb59dd9b5b414370c770f1
2011-12-09 22:38:15 +09:00
Tadashi G. Takaoka
963abf4bcc
Merge "Remove unused public methods from KeyboardState and KeyboardSwitcher"
2011-12-09 04:38:14 -08:00
Jean Chalard
74671cf6c5
Resolve TODOs: add members to hold preferences
...
Change-Id: I34f6c76bf9318e1fbe8eb5ffab6772a98ff824e0
2011-12-09 21:24:13 +09:00
Tadashi G. Takaoka
df9deffba2
Remove unused public methods from KeyboardState and KeyboardSwitcher
...
Bug: 5708602
Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
2011-12-09 21:14:13 +09:00
Jean Chalard
0fe3611bee
Resolve TODOs: add some members to store prefs
...
Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
2011-12-09 20:16:57 +09:00
Jean Chalard
85b063f97e
Resolve TODOs: add members to store raw settings
...
Change-Id: I481eadb6a73faf239e24d05b7e220fcb01194fa4
2011-12-09 19:03:55 +09:00
Jean Chalard
12f10e1585
Read options in the declaration order
...
Change-Id: I1a7c4d0bcaedad6d4045c36c79280c23234db5b3
2011-12-09 18:58:24 +09:00
Jean Chalard
c40b807ca4
Straighten out prefs reading code
...
Change-Id: Ibf9113a8ef07ac720100ee32d2e5ef321e8ddd98
2011-12-09 18:54:07 +09:00
Jean Chalard
bab1f045f4
Straighten out members extracted from resources.
...
Change-Id: I9b9602ec5b379b44b0f0663d4f065dbcf88fd352
2011-12-09 18:19:30 +09:00
Jean Chalard
ba93dda8ce
Match constant names to option names
...
Change-Id: I7586fa342d7a39412d656890f7b525139c45ea4a
2011-12-09 17:58:51 +09:00
Jean Chalard
837b109f27
Reorder members in SettingsValues.
...
Reorder so that they match the order in the preference xml
file. Also add TODOs for missing raw variables.
Change-Id: I06332c131a624d6c359512d75c808f3f7313fa91
2011-12-09 17:56:31 +09:00
Jean Chalard
c207e0a7da
Move settings variables to the settings class
...
Change-Id: Ifa7033a84b08ea626eb44cf6d04ba8e28c250bea
2011-12-09 16:47:31 +09:00
Jean Chalard
284c8a0449
Merge "Stop a flag from escaping."
2011-12-08 23:14:15 -08:00
Jean Chalard
0c3b8ce842
Merge "Move settings method from Utils to SettingsValues"
2011-12-08 23:09:33 -08:00
Jean Chalard
4606de117b
Stop a flag from escaping.
...
The ultimate intent is to close it up in the settings, as it does not
change while typing, only when the keyboard is open again.
Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
2011-12-09 16:09:04 +09:00
Jean Chalard
ed43296217
Move settings method from Utils to SettingsValues
...
Change-Id: I633378a41f63cd492b8c9345d550e07254df5e5a
2011-12-09 16:03:10 +09:00
satok
4bae9d56d9
Merge "Show usability study mode for research purposes"
2011-12-08 22:40:58 -08:00
satok
e0dfc54c5b
Show usability study mode for research purposes
...
Bug: 5722703
Change-Id: I27acc374c5d4b52707708b83689dea5d78a573d7
2011-12-09 15:31:06 +09:00
Tadashi G. Takaoka
a76c62e92d
Merge "Remove direct calls of setKeyboardXXX from KeyboardSwitcher"
2011-12-08 21:33:09 -08:00
Tadashi G. Takaoka
96c56cb577
Remove direct calls of setKeyboardXXX from KeyboardSwitcher
...
These calls, setAlphabetKeyboard, setSymbolsKeyboard, and
setSymbolsShiftedKeyboard have to be call backed from KeyboardState.
Bug: 5708602
Change-Id: Ibbe1a21bd10bf942e17886869c0ab0fa1735b87e
2011-12-09 13:26:11 +09:00
Jean Chalard
7a16a061e6
Extract Settings.Values to a new class
...
This is pretty much automatic refactoring. Thanks Eclipse!
Change-Id: I8ccd24d11878445c836347e9c487c91461eee9cd
2011-12-09 12:40:50 +09:00
Jean Chalard
92e5756dfb
Merge "Cleanup"
2011-12-08 05:14:26 -08:00
Jean Chalard
c1fdd966a7
Remove a useless method
...
Change-Id: Ib6a0ee21bfe2000231f9ba7bcad4b18ae57e4249
2011-12-08 21:47:26 +09:00
Jean Chalard
283b0c2b64
Cleanup
...
Here, shouldAutoCorrect implies mSettingsValues.mAutoCorrectEnabled
Change-Id: I9256718dd63b75252d1454e264db6814bbf18aa5
2011-12-08 21:37:15 +09:00
Jean Chalard
3da7df8db7
Merge "Add proximity for Russian."
2011-12-08 02:22:28 -08:00
Jean Chalard
1830cd1dc8
Add proximity for Russian.
...
This also tries to make the code as easy to extend as possible
for future developments.
Bug: 5701241
Change-Id: I1ed48e6a5cc7aab94c5d6e309930cc004247d7e7
2011-12-08 19:00:52 +09:00
Jean Chalard
9e38f9a980
Merge "Use the system-wide interface to add a word."
2011-12-08 00:52:32 -08:00
Tadashi G. Takaoka
eef6238f94
Move SWITCH_STATE related stuffs to KeyboardState
...
Bug: 5708602
Change-Id: I904ec370e3761c47af17a680c0932ec98cfd3c27
2011-12-08 16:12:49 +09:00
Tadashi G. Takaoka
6b7100feca
Don't execute pending onStartInputView if EditorInfos are equivalent
...
Bug: 5722732
Bug: 5722867
Change-Id: I8347c258b286c3329f318d50adf205e78e49c722
2011-12-07 22:39:13 +09:00
Jean Chalard
361c42b746
Use the system-wide interface to add a word.
...
Bug: 5306641
Change-Id: Ic87e5bc3a5f1f03c57d48f2d92c28e0aba06847d
2011-12-07 16:19:05 +09:00
Tadashi G. Takaoka
8a70e70c84
Remove toggleSymbolsShift and rename toggleKeyboardMode
...
Bug: 5708602
Change-Id: Iadef3e862d00505d1d9f588d0d64445754d7b962
2011-12-06 18:12:34 +09:00
Jean Chalard
bb2b30fc7f
Add support for Russian spell checking.
...
Note that this is not enough: we still need to create a
reasonable proximity table for Cyrillic characters, or we
won't be able to show up suggestions.
Bug: 5701241
Change-Id: Idb141f7a230a6e1a46094308c26f43c01ab3b97a
2011-12-05 18:57:03 +09:00
Jean Chalard
db5aedb5a5
Add an option to use contacts or not while spell checking
...
Bug: 5447495
Change-Id: Iffb09895676c3dd1a79d1699b0eac865282508d4
2011-11-30 18:58:10 +09:00
Tadashi G. Takaoka
e22baaadd3
Get rid of usage of key index
...
Change-Id: I7596ce3ae52fde436d06c2dd95ae873c7aa5ef7f
2011-11-29 19:07:54 +09:00
Jean Chalard
55042ff977
Merge "Resume suggestion when backspacing to the end of a word"
2011-11-29 01:15:42 -08:00
Tadashi G. Takaoka
b230806f44
Merge "Save keyboard layout only when it is shown"
2011-11-29 00:53:38 -08:00
Jean Chalard
6b1f500da4
Resume suggestion when backspacing to the end of a word
...
Bug: 5515381
Change-Id: I26fea896feaf2e9716c7ae3d4f2630360f23ac50
2011-11-29 17:50:36 +09:00
Jean Chalard
117fc18ed4
Keep count of the trailing single quotes for suggestions
...
Bug: 5665809
Change-Id: I4d9100dbe980861ccb55c78464524be670cac1f7
2011-11-29 15:16:28 +09:00
Tadashi G. Takaoka
f2c9a88887
Save keyboard layout only when it is shown
...
Bug: 5130446
Change-Id: I150b4a053036eae050099155169325f0d1f7dfed
2011-11-29 14:12:49 +09:00
Tadashi G. Takaoka
9324665263
Move ignore special key code out from LatinIME to PointerTracker
...
Bug: 5560766
Bug: 5639503
Change-Id: I34c9eea833516adf6ef1db58f1a64a5ef5322fa9
2011-11-22 17:49:12 -08:00
Jean Chalard
6d1cbbc2ff
Fix a bug with single quotes
...
I14dd3815 special-cased single quotes at the start of a word, but
did not do so correctly - it would kill a composing word if entered
just after some punctuations.
The right test was not isCursorTouchingWord() but
mHasUncommittedTypedChars, which actually makes for a simpler
implementation.
Bug: 5648032
Change-Id: Icd21d213e0cad6da68cacfeb921502cd8dcfac95
2011-11-22 18:29:51 +09:00
Tadashi G. Takaoka
e7eac906c0
Pending onStartInputView only if the EditorInfo is identical
...
Bug: 5604372
Change-Id: I2a88cf15b07eebd29e43e460f6ec758432181b01
2011-11-21 16:32:46 -08:00
Jean Chalard
19cbdfc92f
Merge "Remove an unused (and scary) method"
2011-11-21 00:57:45 -08:00
Jean Chalard
ce86e39e00
Merge "Cleanup."
2011-11-21 00:53:49 -08:00
Jean Chalard
5d5028f2c5
Remove an unused (and scary) method
...
Change-Id: I14a545a3e4955a25fde17554156552c755d44e2f
2011-11-21 17:45:32 +09:00
Jean Chalard
6ecd1e1280
Merge "Special case quotes at start and end of words"
2011-11-21 00:21:09 -08:00
Jean Chalard
c83359f974
Special case quotes at start and end of words
...
Single quote at start of word is not considered a part of a
word any more.
Single quote at the end of a word now behave like capitalization:
lookup in the dictionary is done *disregarding* a final quote,
and it is forcefully added back into the suggestions afterwards.
Bug: 5566368
Change-Id: I14dd3815f4b743edba56d64a3abdf4b73d863a6a
2011-11-21 16:34:39 +09:00
Tadashi G. Takaoka
e00ede531f
am 5619d765
: Shift/Symbol/Smiley will not disable settings/microphone keys
...
* commit '5619d7658459d13723b6d7ad8969b249adf9e717':
Shift/Symbol/Smiley will not disable settings/microphone keys
2011-11-18 15:23:14 -08:00
Tadashi G. Takaoka
5dc318a3f2
am 10dff768
: Fix NPE introduced by I38b21d49
...
* commit '10dff76856a98b6eec86a53d3d07fdc9708037b7':
Fix NPE introduced by I38b21d49
2011-11-18 14:48:05 -08:00
Tadashi G. Takaoka
49cc3beb75
resolved conflicts for merge of 137667ed
to master
...
Change-Id: I75fc5d278b002ab89dd2475d282d0ee4aede7817
2011-11-18 08:51:39 -08:00
Tadashi G. Takaoka
5619d76584
Shift/Symbol/Smiley will not disable settings/microphone keys
...
Bug: 5560766
Change-Id: Ic2dbb835e87a7debb222093756816e683b464b83
2011-11-17 23:32:19 -08:00
Jean Chalard
88562bec54
Cleanup.
...
Fix a typo, and move a cursor.close() in a finally{} clause
Change-Id: Iac011ebb80b9430774c7dc5cd94728d05cef443f
2011-11-18 15:24:49 +09:00
Tadashi G. Takaoka
10dff76856
Fix NPE introduced by I38b21d49
...
Bug: 5560766
Change-Id: Ic5eaebe0ef893c69ad90a777ebfa07807535a0e3
2011-11-17 21:46:24 -08:00
Tadashi G. Takaoka
137667ed3d
Merge "Ignore microphone and settings key while typing" into ics-mr1
2011-11-17 18:01:43 -08:00
Tadashi G. Takaoka
175acb8205
Ignore microphone and settings key while typing
...
Bug: 5560766
Change-Id: I38b21d49b7e803bf94805ba8e13849b3c734e010
2011-11-17 16:01:31 -08:00
Tadashi G. Takaoka
60acfdf4a8
Skip loading keyboard when SoftInputWindow hasn't shown yet. (DO NOT MERGE)
...
This is cherry-pick of I003101b2 from Master for Bug: 5541192
Bug: 5636367
Change-Id: I560126d17be6a770b19c1f1347332ebdfde5d671
2011-11-17 14:30:54 -08:00
Tadashi G. Takaoka
eb520c5683
am 549e295d
: Fix updateFullscreenMode of LatinIME
...
* commit '549e295dc113bff50077c3c355dcd94af09a1b2f':
Fix updateFullscreenMode of LatinIME
2011-11-15 18:25:21 -08:00
Tadashi G. Takaoka
549e295dc1
Fix updateFullscreenMode of LatinIME
...
Bug: 5597608
Change-Id: If4b18dc933493bd74bc5506c028af86b0450df1f
2011-11-15 15:15:11 -08:00
Ken Wakasa
ed631627cb
Double space conversion should be enabled only when the 1st space is "weak".
...
bug: 5608934
Change-Id: Ide7ca9d526620c4f225a6f5eb27dcd7df5b504bd
2011-11-15 12:35:22 +09:00
Jean Chalard
85170a9c17
Merge "Be stricter for ruling characters out of spell checking"
2011-11-10 15:51:45 -08:00
Jean Chalard
72479ea363
Be stricter for ruling characters out of spell checking
...
Bug: 5548308
Change-Id: Ie8025b02424b72b69a07907cde1093830c2d4d3d
2011-11-10 12:57:09 +09:00
Jean Chalard
a409f009fa
Fill in the HAS_RECOMMENDED_SUGGESTIONS flag.
...
Bug: 5530727
Change-Id: Ic53e227f72096053e08d90204bf1f287ec09290b
2011-11-10 02:52:46 +09:00
Ken Wakasa
cea3c5bc17
am 0a75373f
: Merge "Fix a bug where the UserDictionary may not be released" into ics-mr1
...
* commit '0a75373f4187d2db036757c2c2bcaba42301fd22':
Fix a bug where the UserDictionary may not be released
2011-11-07 23:04:05 +00:00
Jean Chalard
8b9c89aee2
Fix a bug where the UserDictionary may not be released
...
Bug: 5547357
Change-Id: I521afeaa349c86fb0087cedb70127de6acebec78
2011-11-07 14:31:59 +09:00
Tadashi G. Takaoka
1e39565bb4
Skip loading keyboard when SoftInputWindow hasn't shown yet.
...
Bug: 5541192
Change-Id: I003101b2a3fdeb5bb554d249634ec5ab50aea09e
2011-11-04 15:01:58 +09:00
Jean Chalard
2c77216e22
Remove trailing spaces when appropriate
...
Bug: 5509651
Change-Id: I99cfb5a6fc2873e2c11ed16967cd82a7f504a263
2011-11-02 19:44:26 +09:00
Tadashi G. Takaoka
5fdcd7d5cd
Fix JNI as 64bit ready
...
Change-Id: I7a3ed2cee3b20744869aa5cf89ff9fd95f5ab8fe
2011-10-31 20:44:01 +09:00
Tadashi G. Takaoka
6f811bd13f
Merge "Make some private method static"
2011-10-27 22:57:58 -07:00
Tadashi G. Takaoka
8fbf29e2d5
Make some private method static
...
Change-Id: Ia23765268be0ef89d7fe7c3f5372ed32d6615765
2011-10-28 13:31:31 +09:00
Tadashi G. Takaoka
3122cf8daa
am 07a44557
: Merge "Cancel pending rotation when another rotation start" into ics-mr1
...
* commit '07a445572f7fa21c0e24f5cdb0f0b88ff2adc672':
Cancel pending rotation when another rotation start
2011-10-27 22:59:14 +00:00
Ken Wakasa
644d33d60e
Display "Touch again to save" in the keyboard locale
...
bug: 524239
Change-Id: I227c193ba149f9296f8b1cf40aa3d9cf4e6ae2ab
2011-10-28 00:33:15 +09:00
Tadashi G. Takaoka
dd25e4fa2c
Cancel pending rotation when another rotation start
...
Bug: 5516802
Change-Id: Iccb0abeb94e6dc1322a98a0c744188bb74034c7f
2011-10-27 17:03:03 +09:00
Tadashi G. Takaoka
37c6bbb675
am a7c41996
: Merge "Preventing infinite call of dismissMoreKeysPanel" into ics-mr1
...
* commit 'a7c419964f46d1c354e81c5688f5da6b43428c9a':
Preventing infinite call of dismissMoreKeysPanel
2011-10-27 02:35:12 +00:00
Tadashi G. Takaoka
a7c419964f
Merge "Preventing infinite call of dismissMoreKeysPanel" into ics-mr1
2011-10-26 17:27:35 -07:00
Tadashi G. Takaoka
ef543c725e
Merge "Use onCustomRequest to request haptick and audio feedback"
2011-10-26 07:54:23 -07:00
Tadashi G. Takaoka
d999ea4480
Use onCustomRequest to request haptick and audio feedback
...
Change-Id: I958f274d8cfebb1551cdf08f1bada50c20fb9ca0
2011-10-26 23:32:38 +09:00
Tadashi G. Takaoka
e648e83939
Merge "Remove eventTime argument from PointerTracker.onShowMoreKeysPanel"
2011-10-26 07:29:25 -07:00
Ken Wakasa
44f4d77b75
am cb8cb95d
: Fix NPE
...
* commit 'cb8cb95d0afd340de9f1a0e15948f0068d2450bc':
Fix NPE
2011-10-26 14:25:28 +00:00
Tadashi G. Takaoka
e51d164482
Remove eventTime argument from PointerTracker.onShowMoreKeysPanel
...
Change-Id: Idbcd6e3047c6c0c407e3b347cf9f65951d43a312
2011-10-26 20:54:35 +09:00
Jean Chalard
120586c226
Group special spaces and double/swapped spaces in undo mode
...
This introduces an elementary undo facility that accounts
for magic space, strong space, double space and its cancelling,
and swapped punctuation and its cancelling.
The former three were existing behavior ; this change adds
the swapped punctuation cancelling behavior.
Bug: 5454442
Change-Id: I87af633f30caa2788e9af725e556a7f0746d9a14
2011-10-26 19:12:55 +09:00
Jean Chalard
dec6c0f929
DO NOT MERGE: Fix a bug where the sequence numbers would be wrong
...
The spell checker cannot afford to return static objects,
seeing as the framework will then use the same objects to
pair the cookie and sequence ids to the request.
This is a backport of Ia9c3a933
Bug: 5503243
Change-Id: Ia9c3a933bfb30cf5525418b240ef60632d72c9d0
2011-10-26 17:57:00 +09:00
Tadashi G. Takaoka
0cf7a45ac5
Preventing infinite call of dismissMoreKeysPanel
...
Bug: 5514583
Change-Id: Idf8dd1ebba0afdb768e538c2626b60770421d4be
2011-10-26 17:03:41 +09:00
Ken Wakasa
cb8cb95d0a
Fix NPE
...
bug: 5512097
Change-Id: Id6752c95c9c4b39e7975daa187a2ab92b740060a
2011-10-26 02:35:44 +09:00
Jean Chalard
d0c5f9395a
Cleanup.
...
Remove a state that can never be reached, and ajust all the
callers that would always have received false.
Change-Id: Iac025568be11743428419e0772da306a4f0a0bf1
2011-10-25 21:57:30 +09:00
Jean Chalard
ce668e7a0b
Small clean up.
...
Remove unused methods and constants.
Change-Id: If72e04394a2943b416915217d22cb6e58a0508b3
2011-10-25 21:35:43 +09:00
Jean Chalard
126698fdd2
Add a strong space behavior.
...
Bug: 5454442
Change-Id: Ic095cb65dd7b4427617cd74fc7c53a9666b218c4
2011-10-25 18:40:14 +09:00
Jean Chalard
c47c2dc65a
Merge "Fix a cosmetic bug where text would blink on space swap"
2011-10-25 02:14:28 -07:00
Jean Chalard
b715299125
Fix a cosmetic bug where text would blink on space swap
...
On space swap or space removal in some occasions there would be
a small blink on the screen. This change fixes that.
Change-Id: I486cbcc5dfcafd531b3fa92c4f9a3255832f22cc
2011-10-25 18:02:23 +09:00
Jean Chalard
cd43edbc32
Small clean up
...
Remove an unused method and constant
Change-Id: I3e99ea9fc182c83399d46aca81d1b69aab2c36d1
2011-10-25 17:12:51 +09:00
Jean Chalard
cba1af9c56
Fix a bug where the sequence numbers would be wrong
...
The spell checker cannot afford to return static objects,
seeing as the framework will then use the same objects to
pair the cookie and sequence ids to the request.
Bug: 5503243
Change-Id: Ia9c3a933bfb30cf5525418b240ef60632d72c9d0
2011-10-24 22:40:41 +09:00
Jean Chalard
ee89b40a92
Merge "Use the contacts dictionary in the spell checker."
2011-10-24 03:48:34 -07:00
Jean Chalard
2e3c6da868
Use the contacts dictionary in the spell checker.
...
Bug: 5447495
Change-Id: I7292eb291a1630265884cc8e505a2e83a74f0c72
2011-10-24 19:44:01 +09:00
Tadashi G. Takaoka
b2b1eb5ca5
Call updateFulscreenMode before calling isFullscreenMode
...
Bug: 5495739
Change-Id: I25eab59833a8b95a0b75893d37a45e67504fa7d0
2011-10-24 15:30:49 +09:00
Jean Chalard
26a531c6fe
Rename a flag
...
...and insert some explaining commands
Change-Id: Iff6511e71d66abfaea9f6c21c47f74fa0a67ad78
2011-10-21 19:59:46 +09:00
Tadashi G. Takaoka
49426a1ea9
Fix potential NPE
...
Bug: 5462524
Change-Id: I76012d1bbcd83d58f034c2f588802e4d1b7edc4d
2011-10-20 20:31:17 +09:00
Tadashi G. Takaoka
9f058749f2
am 61aebb0a
: Merge "Update suggestions strip divider" into ics-mr0
...
* commit '61aebb0a1e3d12cd5287c9be3c2e37df565af888':
Update suggestions strip divider
2011-10-19 18:11:20 -07:00
Tadashi G. Takaoka
61aebb0a1e
Merge "Update suggestions strip divider" into ics-mr0
2011-10-19 18:09:17 -07:00
Tadashi G. Takaoka
78674d0ff7
Add warning log for unexpected inputType (DO NOT MERGE)
...
This is a cherry-pick of I3484c751 from Master.
Bug: 5130446
Change-Id: I140980bf093fb3310496c8021166d16f0ddc362f
2011-10-19 18:52:07 +09:00
Tadashi G. Takaoka
2c47080e7b
Update suggestions strip divider
...
Bug: 5142447
Change-Id: I275a304e46456e3b80968fb5de330a3b04bd2035
2011-10-19 16:54:37 +09:00
Tadashi G. Takaoka
82c8c2e6c0
Add warning log for unexpected inputType
...
Bug: 5130446
Change-Id: I3484c75144ba68db0734a4d38186d2eafd1b1879
2011-10-19 16:53:07 +09:00
satok
c5d51a40a4
am fe2d9079
: Fix a bug that the typed word with the blue underline indicator will be duplicated
...
* commit 'fe2d90798ea409ee39d6f63942eb01bb7eed98e3':
Fix a bug that the typed word with the blue underline indicator will be duplicated
2011-10-17 11:32:24 -07:00
satok
fe2d90798e
Fix a bug that the typed word with the blue underline indicator will be duplicated
...
Bug: 5466373
Change-Id: I0300c34cb6076b12ecb89cb29bea95288559108f
2011-10-17 13:25:22 +09:00
Tadashi G. Takaoka
6262fa5307
am ed6bc82d
: Merge "Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced"" into ics-mr0
...
* commit 'ed6bc82d9785372c407e1a4f563ae7d30c479b8a':
Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced"
2011-10-13 22:09:08 -07:00
Tadashi G. Takaoka
d874ac581e
Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced"
...
This reverts commit b1bc5fd896
. (If3a73179)
Bug: 5410786
2011-10-14 12:15:24 +09:00
satok
22c2a23cda
am 605a6fea
: Merge "Fix the safety net Bug: 5453150" into ics-mr0
...
* commit '605a6fea750c4acc96a5136ecaf7162e0a858b9f':
Fix the safety net Bug: 5453150
2011-10-12 23:46:25 -07:00
satok
605a6fea75
Merge "Fix the safety net Bug: 5453150" into ics-mr0
2011-10-12 23:44:54 -07:00
satok
2aa1dd45c4
Fix the safety net
...
Bug: 5453150
Change-Id: I5990feb2622738988bf29843c6bcdb9cbf8bbf33
2011-10-13 15:16:59 +09:00
Tadashi G. Takaoka
283d35cb6c
am 62fb8a48
: Merge "Take invisible extractArea height into account" into ics-mr0
...
* commit '62fb8a480df325ebc6b2a4dc023a944e3cd0bcef':
Take invisible extractArea height into account
2011-10-12 12:00:44 -07:00
Tadashi G. Takaoka
62fb8a480d
Merge "Take invisible extractArea height into account" into ics-mr0
2011-10-12 11:02:05 -07:00
satok
e596fe2702
am ef0a7b75
: Merge "Suppress flickers of the auto correction indicator" into ics-mr0
...
* commit 'ef0a7b75462c75b756caa09d9dd356309968abf3':
Suppress flickers of the auto correction indicator
2011-10-12 10:10:41 -07:00
satok
604d80c671
Suppress flickers of the auto correction indicator
...
Bug: 5440788
Change-Id: I7832b449ee777dbd87388a02cebdfee0ce350fbd
2011-10-12 19:14:13 +09:00
Tadashi G. Takaoka
d44647e76f
Take invisible extractArea height into account
...
Bug: 5410786
Change-Id: I97ce2d72f86ce62b37d408103863af66f91e7107
2011-10-12 19:13:28 +09:00
satok
a86869711e
Merge "Add a settings to change the sound effect volume"
2011-10-11 06:29:11 -07:00
satok
79c0acf519
Add a settings to change the sound effect volume
...
Bug: 5345401
Bug: 5402541
Change-Id: I1e653573a3362160104b77388d6cbd1700424649
2011-10-11 22:25:13 +09:00
Tadashi G. Takaoka
8d4be2516a
Merge "Fix haptic and audio feedback of caps-lock mode changing"
2011-10-11 00:38:17 -07:00
Tadashi G. Takaoka
f44aeb6618
Fix haptic and audio feedback of caps-lock mode changing
...
Bug: 5435669
Change-Id: Ic1c1eb00d7e535a3ac602b9b505fd8bf43da5a8d
2011-10-11 15:27:56 +09:00
Tadashi G. Takaoka
ed2b6c714b
Remove unused import
...
Change-Id: I31115c29e47cdd09b2d8cc8f04e9fc9f9d542811
2011-10-11 12:53:36 +09:00
satok
602bcecf6b
Merge "Put SuggestionSpan as the indicater of the auto-correction"
2011-10-10 02:58:22 -07:00
satok
ec780e2868
Put SuggestionSpan as the indicater of the auto-correction
...
Bug: 5245468
Change-Id: Ia5609e1b3c69f5553e3632fbce60a55665a5b185
2011-10-10 18:44:52 +09:00
Svetoslav Ganov
7c2d7ad634
Merge "Let accessibility users know to connect a headset when the IME connects to a password field."
2011-10-07 15:36:04 -07:00
Jean Chalard
fee149abe0
Use the whitelist as a dictionary in the spell checker.
...
Bug: 5402436
Change-Id: If89b8bbdebf6751697c4788270d01d4639cff665
2011-10-07 19:25:36 +09:00
Jean Chalard
266ae6964d
Merge "Fix a bug with the whitelist"
2011-10-07 02:50:11 -07:00
Jean Chalard
5f41b705fc
Fix a bug with the whitelist
...
This bug would kill the case where the whitelist contains
a word to be autocorrected to an uppercased version of
itself, and the user would enter the uppercase version.
In this case, this bug would cause the typed word to be
killed off the list of candidates, and possibly autocorrected
to the *next* candidate.
When the whitelist checks whether this the typed word is
a candidate for whitelisting, this change has it check whether
the whitelisting results in the typed word before returning.
Hence, it can keep the case-insensitive behavior of the
whitelist.
Coincidentally, this change renames the method used to do
this, because it does not comply with the general contract
of Dictionary. This happens to be in the way of another
upcoming change.
Bug: 5420371
Change-Id: Ifb305271acc5f171adf9b18c762ae7975b14be0a
2011-10-07 18:40:23 +09:00
Tadashi G. Takaoka
beac24226b
Merge "Add haptic feedback for caps lock"
2011-10-07 02:21:15 -07:00
Jean Chalard
af0f13d15c
Add pretty-printing to SuggestedWords.Builder to help debug
...
Change-Id: I2f40ca40f2b452078d0f24cef72e0182e10e2269
2011-10-07 14:35:18 +09:00
Tadashi G. Takaoka
416ee19d33
Add haptic feedback for caps lock
...
When long press triggers caps lock, the keyboard also triggers haptic
feedback.
This change also fixes trivial harmless bug in KeyboardSwitcher.
Bug: 5424681
Change-Id: I62706b49abd7be1dcebc3c5166ea03f426fc8c86
2011-10-07 13:57:49 +09:00
Alan Viverette
b0c8db018d
Let accessibility users know to connect a headset when the IME connects to a password field.
...
Change-Id: If96cd7626950dd12e88a8a97f5e405d303d41e06
2011-10-06 11:02:29 -07:00
Jean Chalard
3d36cdcd2d
Merge "Fix possible NPE in debug mode"
2011-10-06 03:44:24 -07:00
Jean Chalard
51075d145a
Fix possible NPE in debug mode
...
Change-Id: I55776110a489621c99e9a3bf58daa6fcaf415cb3
2011-10-06 19:36:40 +09:00
Jean Chalard
c53661f152
Fix a possible OutOfBoundsException
...
Change-Id: I6eb13c228738119c78496a96acaedbccefd83cd3
2011-10-06 19:05:23 +09:00
Jean Chalard
3458d61807
Make the whitelist an instanciable class.
...
This goes together with I6b8628b9acc32449e4147a2a754b222fbb76c754
or it will break the build
Bug: 5402436
Change-Id: I07c6266b713773a8de80bb22afdd4c566261f78a
2011-10-06 16:05:21 +09:00
Tadashi G. Takaoka
ab72a97d7c
Cleanup unused import
...
This change also gets rid of several compiler warnings.
Change-Id: I23962edaadad18a6e0395d528af17b909dcf5dad
2011-10-04 12:46:20 +09:00
Yusuke Nojima
a25dd3b5c3
Merge "Pass the touch position correction flag from KeyboardSwitcher."
2011-10-03 04:42:53 -07:00
Yusuke Nojima
294e1b4a5a
Pass the touch position correction flag from KeyboardSwitcher.
...
Change-Id: Ia242a9fa2fa71f7fdf8f974071a2df7acc4aa51f
2011-10-03 20:41:03 +09:00
Jean Chalard
45f45a4fdb
Cleanup : remove recorrection-related stuff.
...
This removes UPDATE_OLD_SUGGESTIONS, and the associated settings.
Bug: 5402537
Change-Id: Ie87d4e05c54e4b7d2dd5a05f2d0b570e9cd3e463
2011-10-03 18:23:23 +09:00
Jean Chalard
fe5364c825
Cleanup : remove old recorrection code
...
This removes the calls, but another change will be needed to remove
the messages LatinIME used to send itself to update the suggestion
strip.
Bug: 5402537
Change-Id: I5d1aa63a892516f339f3ceac21f43771b5ffda34
2011-10-03 17:45:45 +09:00
Jean Chalard
cd95a36558
Fix a bug where moving the cursor would not reset selection
...
This change updates suggestions when the cursor is moved.
It is now reasonable to remove the explicit test for
TextEntryState.isAcceptedDefault because it is now shielded
by mExpectingUpdateSelection : actually, this probably fixes
a long-standing bug.
Bug: 5337309
Change-Id: Iee4046420c6a88d1a07d428230f93c3ebef25c39
2011-10-03 17:18:29 +09:00
Jean Chalard
397f6f8299
Merge "Small refactoring"
2011-10-02 23:12:41 -07:00
Jean Chalard
4c0fe57198
Small refactoring
...
Change-Id: Ifc33e109562abb3dd720ad4fed76add8ab1a64aa
2011-10-03 14:58:34 +09:00
satok
904baab25a
Remove code related to AutoText
...
Bug: 5245751
Change-Id: Ic02f951e8e1dbde9d8964d2c16e4928fb374ca41
2011-10-03 14:38:44 +09:00
satok
62c7e25e11
Move SharedPreferencesCompat to com.android.inputmethod.compat
...
Change-Id: Ied336339b8eb3643f14517c251b07c09398f61fe
2011-09-30 20:17:32 +09:00
satok
ba76e6ff27
Show the duration of vibration in settings
...
bug: 5345401
Change-Id: I666d48d8ddf6c14540eb401129c20ce93972d9cf
2011-09-30 20:09:04 +09:00
Jean Chalard
646a66159a
Merge "Make use of the FULL_EDIT_DISTANCE flag."
2011-09-30 00:41:14 -07:00
Jean Chalard
673cebf9e9
Make use of the FULL_EDIT_DISTANCE flag.
...
In effect, this stops the spell checker from suggesting overly
long words.
More precisely, it takes advantage of the new facility that
takes into account the whole length of the dictionary word when
computing scores, so words much longer than the input word will
see their score demoted accordingly.
Bug: 5384578
Change-Id: I326cd7c87c3080e7fa8729f78517f8ba13672a9b
2011-09-30 16:00:07 +09:00
Tadashi G. Takaoka
59f8ca752d
Skip successive InputMethodService callbacks after orientation changed
...
IME is called back four methods for each input field as a IME life
cycle. The four methods are onStartInput, onStartInputView,
onFinishInputView and onFinishInput.
After orientation changed, Those quartet methods will be called back
twice. This behavior of the framework might be a bug.
In order to restore the previous keyboard layout, we should skip
onFinishInputView and onFinishInput of the first quartet and
onStartInput and onStartInputView of the second quartet.
Bug: 4311428
Change-Id: I450ddc0cce5d00abc971ffd42a507a8a86682548
2011-09-30 10:38:32 +09:00
satok
db096d681f
Merge "Add a flag to demote completed suggestions"
2011-09-29 03:58:27 -07:00
satok
40a5f6fa4d
Add a flag to demote completed suggestions
...
Bug: 5390063
Change-Id: I0ef4fbcc705539624269fd2f8c4e782679fc44b3
2011-09-29 19:48:18 +09:00
Jean Chalard
3ff95b7290
Merge "Add a threshold for suggestion score."
2011-09-29 01:47:50 -07:00
Jean Chalard
4609c02f9e
Add a threshold for suggestion score.
...
Bug: 5384578
Change-Id: Ic0b0203d873492a41c72defef835adf36f010f47
2011-09-29 17:38:08 +09:00
satok
4866758a98
Merge "Update suggestions when user presses the backspace even when there is not two or more suggestions"
2011-09-29 00:19:17 -07:00
satok
074cda4d26
Update suggestions when user presses the backspace even when there is not two or more suggestions
...
Bug: 5384445
Change-Id: I419999da8f5745ac114d0173beeadcb365a8c3ac
2011-09-29 16:12:11 +09:00
Tadashi G. Takaoka
2087cf508a
Merge "Handle back key and outside touch correctly in more suggestions window"
2011-09-28 23:41:55 -07:00
Tadashi G. Takaoka
bfc1d732ac
Handle back key and outside touch correctly in more suggestions window
...
Bug: 5385284
Change-Id: Ic0517182d294c79e37c88f1ef30cb4d2917b2800
2011-09-29 15:07:15 +09:00
Jean Chalard
85782abaf1
Move some arguments to final members.
...
This is preparation for
Bug: 5384578
Change-Id: I7d493c441f375fa5f23c5e3cfa8134e2ce7775fe
2011-09-29 13:11:09 +09:00
satok
433965784d
add vibration duration settings
...
Change-Id: I56a1a94df63160f367f866da759d7dd4fc428ed5
2011-09-29 11:46:20 +09:00
Jean Chalard
90086846dc
Merge "Change the logic of the LOOKS_LIKE_TYPO flag"
2011-09-28 03:59:26 -07:00
Jean Chalard
647db70fec
Change the logic of the LOOKS_LIKE_TYPO flag
...
It now follows the following logic:
- If the word should be filtered out => false
- Else => !IN_THE_DICTIONARY
This defines the behavior for ICS MR0, and prepares for addition
of a new HAS_LIKELY_SUGGESTIONS flag in MR1.
Bug: 5383800
Change-Id: I530b1404ae8cf3337ff68ef5ab0f4d95f2dad0e8
2011-09-28 19:42:43 +09:00
Tadashi G. Takaoka
2fc4248700
Introduce hit box to Key and get rid of edge flags
...
Change-Id: I2b78d2ca756223b5497d01127c3a0190dcc81e57
2011-09-28 19:31:37 +09:00
Tadashi G. Takaoka
ffd156c77e
Postpone onDisplayCompletions until onStartInputView has been executed
...
Bug: 5108267
Change-Id: I42d297ce4e4913e5dab5f5d647b1d13dc860b884
2011-09-28 09:36:40 +09:00
Tadashi G. Takaoka
f451ed2012
Forward touch events above the keyboard to the suggestions strip
...
The gutter area between the suggestions strip and the top-row keys
looks like a part of the suggestions strip, and the touch events
landing on the area should be forwarded to the suggestions strip.
Bug: 5246673
Change-Id: I92af763be0feed21aa36ceffb5d575abe554f19e
2011-09-27 19:02:24 +09:00
Tadashi G. Takaoka
73cd4c1428
Fix onDeatchedFromWindow to protected
...
Change-Id: Ief666554ffd405a43363e66ea2bc2d87aa76a882
2011-09-27 15:18:02 +09:00
Jean Chalard
a9876980c8
Fix a possible deadlock.
...
Bug: 5359873
Change-Id: I80ae901c43b6ae59879e3c8b1a9dd8a937d558c1
2011-09-26 18:16:24 +09:00
Tadashi G. Takaoka
acf6b6815a
Merge "Fix keyboard row height calculation"
2011-09-25 19:25:28 -07:00
Tadashi G. Takaoka
8fbfac4ffb
Fix keyboard row height calculation
...
The keyboard height will be distrubuted as:
top_padding + (key_height + vertical_gap) * row_count - vertical_gap + bottom_padding
Change-Id: I841f356b9dbf8cfaf3756178bc9e4e6b2aa61364
2011-09-26 10:25:49 +09:00
Ken Wakasa
c9f562a9a4
Partially revert I0fa5eefc
...
bug: 5344295
Change-Id: Idb10e37862773a62ff60afe874844e8968a58b5d
2011-09-24 09:38:45 +09:00
Fabrice Di Meglio
c66a7278d2
Merge "Revert "Use "..." instead of "\u2026"""
2011-09-23 15:08:23 -07:00
Fabrice Di Meglio
9bdce3a59e
Revert "Use "..." instead of "\u2026""
...
This reverts commit 8673ceb066
The Roboto Font is having the real ellipsis back
2011-09-23 14:59:33 -07:00
Gilles Debunne
8d6fd877c5
am b1bc5fd8
: Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced
...
* commit 'b1bc5fd896329a39ad51a8c79e2970750c814ea0':
Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced
2011-09-21 18:57:03 -07:00
Gilles Debunne
b1bc5fd896
Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced
...
CL https://android-git.corp.google.com/g/#/c/136474 refactored
the fullscreen test, but ithe IME_FLAG_NO_EXTRACT_UI test was
lost in the process.
Note that there is still a problem (orthogonal to that change
with key_preview_backing, which appears opaque and black sometimes.
I'll re-open 5315001.
Change-Id: If3a73179d21eaca10bdc948db7bac4b4f7a88d34
2011-09-21 16:14:30 -07:00
Tadashi G. Takaoka
68c7b9b195
Merge "Remove "autoCorrectInvert" feature from SuggestionsView"
2011-09-20 23:28:31 -07:00
Tadashi G. Takaoka
92a83e74ec
Merge "Fix key preview backing view height"
2011-09-20 23:24:43 -07:00
Tadashi G. Takaoka
77a87e3cb5
Remove "autoCorrectInvert" feature from SuggestionsView
...
Bug: 5162005
Change-Id: Iec679f5f05f28cd7e8013d7350ea03372f1cd7b2
2011-09-21 15:06:51 +09:00
Tadashi G. Takaoka
8673ceb066
Use "..." instead of "\u2026"
...
Because "TRHEE DOT LEADER" glyph of Roboto font is broken, we decide
to use "..." instead.
Bug: 5344295
Change-Id: I0fa5eefc00baf80747ff5215c018619a7e15a58e
2011-09-21 14:00:36 +09:00
Tadashi G. Takaoka
f5fe245df0
Fix key preview backing view height
...
Bug: 5344344
Change-Id: Ied0cda2c4b822b391ece54a6880fae8e349cc0bc
2011-09-21 11:22:05 +09:00
Tadashi G. Takaoka
3fc4ddec68
Sliding suggestions strip starts showing more suggestions
...
Bug: 5301019
Change-Id: I87daa9e472f9e93a6da9de754376b7fa4740171a
2011-09-21 10:42:50 +09:00
Ken Wakasa
37af28dd23
Enable vibrate on keypress by default
...
bug: 5337363
Change-Id: I14c95d27dd236d0a43e64a46ae6fbf9f2a97a3da
2011-09-20 20:31:03 +09:00
Ken Wakasa
34a9831811
Merge "Tweak LatinIME's keypress volume"
2011-09-20 04:07:38 -07:00
Tadashi G. Takaoka
95dba8a82c
Merge "The back button key event is delivered correctly"
2011-09-20 04:00:44 -07:00
Ken Wakasa
f58293f6eb
Tweak LatinIME's keypress volume
...
bug: 5337902
Change-Id: I7f864f158d110aa3e755961303799882f59b7e4c
2011-09-20 20:00:43 +09:00
Tadashi G. Takaoka
d7b00f3490
The back button key event is delivered correctly
...
Bug: 5275063
Change-Id: I439ce18665e40dc8b2e40e923e5cabfcae7c81cf
2011-09-20 19:51:03 +09:00
Tadashi G. Takaoka
6d8d25ee5a
(DO NOT MERGE) Update fullscreen mode also at onStartInputView
...
This is a cherry-pick cheof I190a71f7 from Master.
Bug: 5315001
Change-Id: I76c756eeecf21eec4c88dd4558d5c50f10ff3d3c
2011-09-20 16:59:00 +09:00
Tadashi G. Takaoka
3ea503c851
Merge "Update fullscreen mode also at onStartInputView"
2011-09-20 00:47:00 -07:00
Tadashi G. Takaoka
59010a89b8
Update fullscreen mode also at onStartInputView
...
This change also separates controlling visibility of "key preview
backing view" from suggestions strip visibility.
Bug: 5315001
Change-Id: I190a71f7956c804e5d89d2d5bacecc62d565ac2c
2011-09-20 16:38:24 +09:00
Jean Chalard
d2547c6888
Merge "Have the spell checker report IN_DICT correctly"
2011-09-19 23:19:47 -07:00
Ken Wakasa
28f36d68af
Tweak LatinIME's keypress vibration duration
...
bug: 5337363
Change-Id: If6e6de587cbcddf26710d8f0b237c4bc393589b6
2011-09-20 11:23:30 +09:00
Jean Chalard
e897e4d342
Have the spell checker report IN_DICT correctly
...
...even if the word is filtered out.
This also contains minor refactoring.
Bug: 5329658
Change-Id: I397a2a74f819a51df3bd07c6b94e8d29244389c4
2011-09-16 18:26:02 +09:00
Tadashi G. Takaoka
0967ef4036
Draw more suggestions hint using text font
...
Bug: 5287964
Change-Id: I692b5303268c7b5115853177c956e147312c582d
2011-09-16 16:47:58 +09:00
Tadashi G. Takaoka
ba0e30f212
(DO NOT MERGE) Fix checking capitalized word code
...
This is a follow up change of If6c0edef.
This is a cherry-pick of Idb415f53 from Master.
Bug: 5328922
Change-Id: I36d8bda9fb95e4809598296226c598a9f08bd8bb
2011-09-16 12:40:09 +09:00
Tadashi G. Takaoka
436a645ea8
Fix checking capitalized word code
...
This is a follow up change of If6c0edef.
Bug: 5328922
Change-Id: Idb415f53f3fea6660c7802577d08b4d89d4e7842
2011-09-16 12:28:13 +09:00
Jean Chalard
97ec205504
Merge "Add an option to user dict to match more precise locales"
2011-09-15 02:28:20 -07:00
Jean Chalard
cfed273922
Add an option to user dict to match more precise locales
...
This should not be used lightly, as it violates the general
contract of locale, and does kill some legitimate (albeit
alledgedly rare) use patterns.
Currently, the spell checker uses this because it uses a
negative logic: it should match broadly, and when in doubt,
match even more broadly, which is almost never the case of
something that uses the locale.
In other words: don't use this option unless you are
very, VERY sure that's what you want. Hint: it isn't
Bug: 5280929
Change-Id: Ib3cae319c692161d653630038c5bcde1f4340c05
2011-09-15 18:01:13 +09:00
Jean Chalard
39fe5bfc3c
Merge "Avoid returning an object that's still used internally"
2011-09-15 00:28:19 -07:00
Jean Chalard
5c08151c22
Avoid returning an object that's still used internally
...
There is no definite path known for this to end up being
touched by other classes, but we could imagine through
some way or some other it ends up shoved in the stringbuilder
pool, leading to catastrophic results.
Hopefully related to
Bug: 5248688
Change-Id: Ib8abfc31263cbf31d515ed607ced5d8253971938
2011-09-15 16:23:03 +09:00
Jean Chalard
199dc5e0e4
Don't kill LatinIME if the spellchecker crashes.
...
If the spellchecker encounters a bug and happens to crash,
it may be sensible to avoid killing the keyboard in response.
This is a possible way to do it, which comes with the big
drawback of making bugs in the spell checker harder to find.
Change-Id: Idb26fb592b9718e1dbdadeda8fbd1a8a1d805c28
2011-09-15 16:01:21 +09:00
satok
fa52a09f21
Merge "Remove experimental settings"
2011-09-14 02:57:58 -07:00
Jean Chalard
d2738757d2
Merge "Filter out of spellchecking words that don't look like words"
2011-09-14 02:05:48 -07:00
Jean Chalard
88fa53b840
Filter out of spellchecking words that don't look like words
...
Note that this affects only the results of the spell checker if
actually passed such a word. For example, the spell checker will
not flag "http://oju " as a typo, because it looks like a URL.
But in the current implementation, TextView passes "http" and
"oju" separately, so "oju" is still flagged as a typo.
Bug: 5281875
Change-Id: I9d721fd3af34edc51b11908cf2e8fe994b164242
2011-09-14 17:46:06 +09:00
satok
c9c54a84bc
Remove experimental settings
...
Bug: 5314288
Change-Id: I31cbc6da0ca5e61a5fa4a893c774f2110a5698f1
2011-09-14 16:24:39 +09:00
Jean Chalard
1586dc6edf
Merge "Fix a bug where the user dict's locale match would be wrong"
2011-09-13 23:44:44 -07:00
Jean Chalard
d97def5925
Fix a bug where the user dict's locale match would be wrong
...
This is preparation for
Bug: 5280929
Change-Id: Iab0096acf057aa288b1986d225aad815bd70b145
2011-09-14 15:41:46 +09:00
Jean Chalard
63e55cd55e
Don't report 1-char words as typos
...
Bug: 5281875
Change-Id: If6b6d057e18390bf01dcd31c46104b6856fbdbda
2011-09-13 21:45:19 +09:00
Tadashi G. Takaoka
ea843f2a24
Make WordComposer aware of capitalized word
...
Change-Id: If6c0edef2334f018f2e04c6034f8ce747206f150
2011-09-13 19:11:10 +09:00
Tadashi G. Takaoka
6602b03e80
Merge "Linger the "more suggestions" when the user is sliding the touch point"
2011-09-12 21:33:14 -07:00
Tadashi G. Takaoka
02ce5392f5
Merge "Dismiss the more suggestions when the user is sliding down the touch point"
2011-09-12 21:32:40 -07:00
Tadashi G. Takaoka
87104bace9
Dismiss the more suggestions when the user is sliding down the touch point
...
Bug: 5299142
Change-Id: I466ff41948bbb49fb6874817ecfd94d338238d19
2011-09-13 13:03:50 +09:00
Tadashi G. Takaoka
2abd8547e3
Linger the "more suggestions" when the user is sliding the touch point
...
Bug: 5299024
Change-Id: I00b5e59ba480cbf057bdd69d1357d2c477be90f7
2011-09-13 13:03:24 +09:00
Tadashi G. Takaoka
697bf585f8
Update suggestions strip text color
...
Bug: 5287964
Change-Id: Ic40bb656873f41bb6d65427f02399464e831aab2
2011-09-13 12:54:59 +09:00
Jean Chalard
f5ef30dfc6
Have the spell checker honor case
...
Bug: 5281103
Change-Id: I415c84dbb55f1eeb5deb9f248b4056881982ee13
2011-09-12 12:25:25 +09:00
satok
53bbf4da5a
Merge "Remove the exception in SubtypeSwitcher"
2011-09-09 02:49:18 -07:00
satok
1ecf0fb5d7
Remove the exception in SubtypeSwitcher
...
Bug: 5261455
Change-Id: Idb070702418caeb6cb975849d71b39952ac4afab
2011-09-09 18:44:48 +09:00
Jean Chalard
a40aba0022
Merge "Fix an NPE"
2011-09-09 02:18:11 -07:00
Jean Chalard
5955cfdaea
Fix an NPE
...
I think only the monkey can realistically stumble on this one,
but still.
Bug: 5276917
Change-Id: I0d9f76e4786973d3695fcd46127f0bed46621c33
2011-09-09 18:08:53 +09:00
Tadashi G. Takaoka
f01ba10c8f
Merge "Cancel more suggestions when its outside is touched"
2011-09-09 00:49:15 -07:00
Tadashi G. Takaoka
530b4176c2
Merge "Fix potential ArrayIndexOutOfBoundsException"
2011-09-08 23:24:20 -07:00
Tadashi G. Takaoka
4a9be115f2
Cancel more suggestions when its outside is touched
...
Bug: 5241105
Change-Id: Ic28afaf998dabd3c5529286a3e60400d733d3d82
2011-09-09 14:21:43 +09:00
Tadashi G. Takaoka
8332fd0b81
Fix potential ArrayIndexOutOfBoundsException
...
Change-Id: I5dad81fb274cbbcf2c4f106825eecf8e4903461c
2011-09-09 09:42:22 +09:00
Tadashi G. Takaoka
2cb36637f4
Back button to dismiss the more suggestions
...
Bug: 5275063
Change-Id: If31e9a25d827f44c8d4ff455a780ec2a6d2d9bef
2011-09-09 09:33:35 +09:00
Tadashi G. Takaoka
a08a7e99b4
Merge "Add visual dividers to more suggestions panel"
2011-09-08 07:25:17 -07:00
Tadashi G. Takaoka
30bd8cb2da
Add visual dividers to more suggestions panel
...
Bug: 5275003
Change-Id: I9464db71388a40ea768984b4cf06c8da05bfa26c
2011-09-08 23:05:55 +09:00
Jean Chalard
af3b56c887
Fix a bug where the wrong suggestion score would matter.
...
Also introduce a few debug prints.
Bug: 5240463
Change-Id: Iea2fffa3be9d7bd69da751ece9e67e94e9819ee1
2011-09-08 21:17:24 +09:00
Ken Wakasa
293db0873f
Get rid of the double quote from the suggestion strip
...
bug: 5271209
Change-Id: I1823eaac07e184092bdf2a5d607fa08ff680fca5
2011-09-08 11:46:09 +09:00
Tadashi G. Takaoka
2be872555c
Use full screen mode on landscape/phone device
...
Bug: 5262767
Change-Id: I721c18522c972ced9f359f2e5208572d54a4b7a1
2011-09-08 11:02:55 +09:00
Tadashi G. Takaoka
ed3758e33c
Merge "Tune the threshold of fullscreen mode from 2.5in to 500dip"
2011-09-07 01:08:51 -07:00
Tadashi G. Takaoka
f80b6a0699
Tune the threshold of fullscreen mode from 2.5in to 500dip
...
Bug: 5262767
Change-Id: Ie418ab766951a568d0f40822d8e8d719582749ba
2011-09-07 16:37:50 +09:00
satok
6d468c513f
Fix NPE in settings
...
Bug: 5246032
Change-Id: I452dab9bf863fb8cba142467f338088ee8b30283
2011-09-07 12:36:07 +09:00
Tadashi G. Takaoka
50e1073e11
More suggestions view can be modal
...
Bug: 5241105
Change-Id: Ib430ee129b9f3cad0bdb1ae083b1068c51a5f2ea
2011-09-06 19:18:40 +09:00
Tadashi G. Takaoka
4269a7cebd
Add gap between suggestions strip and more suggestions
...
Bug: 5260292
Change-Id: Iba792ebe0767f5117f259bcb73ac0bff778b166e
2011-09-06 18:33:01 +09:00
Tadashi G. Takaoka
8ac6d505b7
More processTouchEvent from LatinKeyboardView to PointerTracker
...
Bug: 5241105
Change-Id: I8a5d15f43e2c9f294e78127eda68b0f85da5ad15
2011-09-06 15:57:15 +09:00
Tadashi G. Takaoka
9676038b6e
Introduce maxMoreSuggestionsRow and minMoreSuggetionsWidth attributes to SuggestionsView
...
Bug: 5257594
Change-Id: Id52c841b72e38eb9034a1a7f26bcf3d4d81ad216
2011-09-05 18:59:37 +09:00
Tadashi G. Takaoka
1d8ec1cb9f
Merge "Rename suggestionsPaneViewStyle to moreSuggestionsViewStyle"
2011-09-05 01:39:33 -07:00
Tadashi G. Takaoka
0e7bd388d2
Merge "Get rid of LinearLayoutCompatUtils"
2011-09-05 01:22:15 -07:00
Tadashi G. Takaoka
0e2fa66144
Rename suggestionsPaneViewStyle to moreSuggestionsViewStyle
...
Change-Id: I30873ad870c728e28a044baf9946b4461ab03575
2011-09-05 16:48:56 +09:00
Tadashi G. Takaoka
c412309b7a
Get rid of LinearLayoutCompatUtils
...
Change-Id: If0f63eaeb4539c0e03ef20190d2f9211a176babc
2011-09-05 16:15:28 +09:00
Jean Chalard
59b501a050
Only set LOOKS_LIKE_TYPO if the max score meets a threshold
...
Bug: 5240463
Change-Id: I51e85edae57789d638aa1e12b82e6a75c49d33c7
2011-09-05 12:31:43 +09:00
Tadashi G. Takaoka
787bac0603
Merge "Use separate View for key preview backing"
2011-09-02 12:59:31 -07:00
Tadashi G. Takaoka
abb0c77af1
Use separate View for key preview backing
...
Bug: 5246982
Change-Id: Icec4281cb01771909fcece36647ee42ba179118c
2011-09-03 01:36:26 +09:00
satok
e197542a57
Merge "Add logs"
2011-09-02 04:21:07 -07:00
satok
8e5d12af9f
Add logs
...
Change-Id: I640186c8be8013841b542e8cefa5f033eb7afc32
2011-09-02 19:55:09 +09:00
Tadashi G. Takaoka
9734ecbf46
Squash MiniKeyboardKeyDetector and SuggestionsPaneKeyDetector into one
...
Bug: 5241105
Change-Id: I4c310373fb8b2426fb46205fa17a49a8346f8244
2011-09-02 17:58:39 +09:00
Tadashi G. Takaoka
d3e50a2acf
Squash SuggestionsStripParams into SuggestionsViewParams
...
Bug: 5246982
Change-Id: Idc2563cb0175aabc4282f9fd45eefaa129ed4961
2011-09-02 16:53:38 +09:00
Jean Chalard
5bb7a64fe2
Merge "Fix an NPE in settings"
2011-09-01 23:42:43 -07:00
Jean Chalard
ad56a9ac51
Fix an NPE in settings
...
Change-Id: I264c001a9cc28f864ad024fcf51fb42e9c203d3f
2011-09-02 15:35:23 +09:00
Jean Chalard
66a5884ad8
Merge "Add an option to prevent insertion of suggestion spans"
2011-09-01 22:57:39 -07:00
Jean Chalard
1531528bfe
Add an option to prevent insertion of suggestion spans
...
This is to help debug of
Bug: 5250788
Change-Id: I961321aff3776c4912eaf7a1fa4de0c01d715f24
2011-09-02 14:43:13 +09:00
Tadashi G. Takaoka
1b087064c0
Dim keyboard when more suggestions are shown
...
Bug: 5241009
Change-Id: Ia42bcfc34dddf93d35f9cea8a4f0efead6ce3a6a
2011-09-01 18:48:19 +09:00
Tadashi G. Takaoka
913e2aeef2
Rename CandidateView to SuggestionsView
...
Change-Id: I6480cdf025f065130e1969899b259a243e7a11be
2011-09-01 15:41:34 +09:00
Jean Chalard
b17300e2f0
Merge "Fix a bug where autotext would occasionally not work"
2011-08-31 22:42:11 -07:00
Tadashi G. Takaoka
537e3d3696
Merge "Remove unused suggestions pane code"
2011-08-31 22:35:12 -07:00
Tadashi G. Takaoka
3a566c48b0
Remove unused suggestions pane code
...
This is a followup for Ie1d69131.
Bug: 5023981
Change-Id: I42ec596af40cb7dcdd84b96ba5bff9ef1fb5dc92
2011-09-01 14:28:59 +09:00
Tadashi G. Takaoka
d81479a340
Implement KeyboardLocale InputMethodSubtype extra key
...
The locale is specified by KeyboardLocale extra key in method.xml,
LatinIME will use the specified locale for keyboard layout.
Bug: 5238658
Change-Id: I8e6cb66c73a7ac1bf611d9910b42fa9cff38eba0
2011-09-01 14:05:01 +09:00
Jean Chalard
358e1327d8
Fix a bug where autotext would occasionally not work
...
Autotext correction would check whether the first suggestion
so far was the same as what Autotext would return, and if it
was indeed the same, would not send its result as
autocorrect. However, the first suggestion is not guaranteed
to have a high enough score to trigger autocorrection, and
there would be cases where a word in autotext would not get
autocorrected because the word came out of bigram
suggestions. These occurrences would be extremely rare, as
they would require concomitant insert between autotext for
one char and bigram suggestion. It is, in fact, probably
limited to the capitalization of "I".
This did not happen in gingerbread because gingerbread would
not register 1-letter words as valid bigrams.
This fix works by just always sending the result of autotext
regardless of whether it is already the first suggestion or
not. This is okay because duplicates are removed afterwards
anyway - and this processing is absolutely necessary because
the autotext'd word may actually be somewhere else in the
suggestion, so it made really no sense checking for only the
first one.
Please note that there is also a race condition that can
result in "i" not being converted to "I": at the moment,
Latin IME relies on having the suggestions evaluated
at the time autocorrection is performed, but when typing
very, very fast, those messages may have been canceled.
This is not limited to the autocorrection of "i", but
affects all autocorrections. It requires a nearly
inhumane typing speed to trigger, but hitting "i" and
space in turn as fast as one can it's possible to
reproduce occasionally.
Bug: 5135113
Change-Id: I530ea6212487300001a2c0fc5b25a5c7716bdf63
2011-09-01 12:59:17 +09:00
Tadashi G. Takaoka
fdec5c1a78
Merge "Implement popup suggestions pane"
2011-08-31 05:23:54 -07:00
Tadashi G. Takaoka
29e7b7ed6e
Implement popup suggestions pane
...
Bug: 5023981
Change-Id: Ie1d69131dbf884a3f6a2beb3ac3427e5437c1486
2011-08-31 21:21:22 +09:00
Jean Chalard
a770d650b5
Fix a possible NPE
...
Change-Id: I5c57752772414b4f9475d0ad43d7fc52b97c3f33
2011-08-31 19:04:34 +09:00
Jean Chalard
18ccd552a8
Clean up bigram settings
...
Move bigram suggestion option to the advanced settings screen,
remove bigram prediction option for ICS release and remove the
now-empty bigram option category.
Bug: 5240082
Change-Id: Ib1fc608ad33d5598410f7b0cb4a1639bffef28c7
2011-08-31 15:41:13 +09:00
Jean Chalard
fcee70ea92
Merge "Check the magic number of a decoded file"
2011-08-30 22:58:29 -07:00
Jean Chalard
7a408431fe
Check the magic number of a decoded file
...
Checking the magic number of a file upon decoding is necessary,
because if the file is corrupt and we don't check it, we will
fall back to a simple copy of the corrupted file. Latin IME
would realize this and would not crash, but would not use the
corrupted dictionary. If this happened to be a main dictionary,
then the user would lose the ability to use the correct
built-in dictionary.
Not the same, but kinda similar to
Bug: 5223031
Change-Id: Ic2783dc9dd5f3dcf2865623d9452765fe3778db7
2011-08-31 14:37:11 +09:00
Tadashi G. Takaoka
b8dc674663
Get rid of MeasureSpec.UNSPECIFIED
...
Bug: 5023981
Change-Id: I14ded3c3d554ac72b66f190110652f54d91df954
2011-08-31 14:15:20 +09:00
Tadashi G. Takaoka
392276d73d
Add Key constructor for suggestions pane
...
Bug: 5023981
Change-Id: I737bacb1a6bb40f70be65d6eff85614afe6c79ed
2011-08-30 19:14:52 +09:00
Jean Chalard
f019d505d7
Fix a bug with synchronicity of spell checking/user dict
...
This fixes a race condition that would end up with the spell
checker not finding some words in the user dictionary when it
just booted.
Bug: 5194627
Change-Id: I1ba911cc53e6ae3b111d54a6f91d1d5feef3f5de
2011-08-29 18:33:20 +09:00
Jean Chalard
940514989a
Merge "Move locale-related utility methods to LocaleUtils."
2011-08-28 20:34:02 -07:00
Jean Chalard
ef35cb631c
Move locale-related utility methods to LocaleUtils.
...
Change-Id: I7e9e6e5bc4486d8618d0213b112308c3d305c15e
2011-08-29 12:29:35 +09:00
Tadashi G. Takaoka
85b4752270
Merge "Move debug information back to suggestions strip"
2011-08-26 04:07:00 -07:00
Tadashi G. Takaoka
013ba3e3e7
Move debug information back to suggestions strip
...
Change-Id: I8cfad5f780a481a251cc4f752bff3cda5ae3ffbe
2011-08-26 20:05:19 +09:00
satok
add3e05379
Do not put the suggestion span for obsolete suggestions.
...
Bug: 5219037
Change-Id: I0300fbc7e1cc97f0f8ba4d21e0e699d9fe66ed76
2011-08-26 19:12:18 +09:00
Tadashi G. Takaoka
c04bbc1ae9
Fix "touch to save" colors
...
Bug: 5218662
Change-Id: I094b2ceb7438148eb5bdf620b188f598e8442a07
2011-08-26 18:55:36 +09:00
Jean Chalard
de4e8dedcc
Allow sharing dictionaries between similar locales.
...
Bug: 5058488
Change-Id: Ib12013f58afad957a8205b439f87480cc12ea06f
2011-08-25 19:42:06 +09:00
Jean Chalard
a16621ada4
Add a debug variable
...
...that was missing
Change-Id: Ia3b17909f295e0a93dee633c8d67c0e03840023e
2011-08-24 21:36:18 +09:00
Jean Chalard
20973de72b
Avoid unnecessary output to the system log.
...
The message this removes gets printed under normal conditions.
Normally dictionary files are compressed then crypted, but not
compressed a second time; however LatinIME tries to open a
compressed-crypted-compressed file first, because it could not
do it afterwards and we want to support this case. So under
normal operations, the first method LatinIME tries is actually
expected to fail.
Also, if we decide to stop compressing or/and encrypting dicts
LatinIME supports it as a valid use case. It should not print
errors to the log.
If the file cannot be open at all, then it is an unexpected
case, and Latin IME still reports to the log.
Change-Id: Ic5228c51365a101af1d03e2c893484d3050b5a1c
2011-08-24 20:27:04 +09:00
Tadashi G. Takaoka
1d59e0dbdf
Merge "Fix suggestions strip press state to align vertically"
2011-08-24 03:35:57 -07:00