nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
31542 commits 1 branch 0 tags 363 MiB
Commit graph

7170 commits

Author SHA1 Message Date
Keisuke Kuroyanagi
03105290d8 Merge "Throw exception when the header cannot be read." 2014-02-19 04:59:47 +00:00
Tadashi G. Takaoka
776bba098b Merge "Turn off personalization default settings" 2014-02-19 04:25:04 +00:00
Keisuke Kuroyanagi
97a40d030f Throw exception when the header cannot be read. 
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
 2014-02-19 12:35:58 +09:00
Keisuke Kuroyanagi
e49e007bb2 Fix: Use old suggest after reloading. 
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
 2014-02-19 12:34:09 +09:00
Tadashi G. Takaoka
0a4ac795d6 Turn off personalization default settings 
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.

Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
 2014-02-19 12:08:50 +09:00
Jean Chalard
80d413caff Merge "Straighten out database cursors behavior." 2014-02-18 11:09:38 +00:00
Jean Chalard
28e0b24965 Merge "Fix a bug where the cache would be out of sync" 2014-02-18 10:58:50 +00:00
Jean Chalard
b8ff8ca9d9 Straighten out database cursors behavior. 
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.

It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.

Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
 2014-02-18 19:58:23 +09:00
Jean Chalard
fe92c174ea Fix a bug where the cache would be out of sync 
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.

Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
 2014-02-18 19:55:54 +09:00
Jean Chalard
783dabb812 Merge "Cleanup." 2014-02-18 09:54:33 +00:00
Jean Chalard
63be066544 Cleanup. 
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.

Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
 2014-02-18 17:07:46 +09:00
Ken Wakasa
266c8c5b1d Merge "Some cosmetic fixes in LatinIME.java" 2014-02-18 06:08:34 +00:00
Ken Wakasa
12ff7da19d Some cosmetic fixes in LatinIME.java 
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
 2014-02-18 14:56:50 +09:00
Jean Chalard
9967f0a1d0 Avoid crashing when the Content URL is not found. 
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.

Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
 2014-02-18 14:27:58 +09:00
Ken Wakasa
0d32643e69 Merge "Cosmetic fixes" 2014-02-18 03:28:04 +00:00
Ken Wakasa
2312c1954f Cosmetic fixes 
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
 2014-02-18 12:17:24 +09:00
Tadashi G. Takaoka
cc05f468ca Merge "Refactor InputAttributes a bit" 2014-02-18 02:25:46 +00:00
Tadashi G. Takaoka
06fbfc4951 Refactor InputAttributes a bit 
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
 2014-02-18 11:11:36 +09:00
Tadashi G. Takaoka
affdd36423 Set neutral suggestions should be called after load settings 
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
 2014-02-18 11:04:00 +09:00
Tadashi G. Takaoka
f0f4e9fc16 Update important notice version even when user select Settings 
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
 2014-02-18 00:14:30 +09:00
Jean Chalard
782c9fee6b Merge "Don't resume suggestion on links." 2014-02-17 11:46:54 +00:00
Jean Chalard
7a7aeffcdc Don't resume suggestion on links. 
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
 2014-02-17 20:36:16 +09:00
Jean Chalard
d91cd9919e Merge "Catch exceptions we can't do anything about." 2014-02-17 11:33:39 +00:00
Tadashi G. Takaoka
5cd732f8c5 Stop overriding InputView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
 2014-02-17 19:51:47 +09:00
Jean Chalard
a149731a67 Catch exceptions we can't do anything about. 
This also abstracts away the "package deactivated" case for
simpler and safer code.

Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
 2014-02-17 18:49:31 +09:00
Tadashi G. Takaoka
891e4860f8 Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 2014-02-17 09:20:54 +00:00
Tadashi G. Takaoka
e32548f32d Stop overriding SuggestionStripView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
 2014-02-17 18:11:10 +09:00
Tadashi G. Takaoka
1751615f7d Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 2014-02-17 08:26:38 +00:00
Tadashi G. Takaoka
3dd6bdf931 Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 2014-02-17 08:25:57 +00:00
Tadashi G. Takaoka
800ab579a9 Remove unnecessary override of MainKeyboardView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
 2014-02-17 17:09:06 +09:00
Tadashi G. Takaoka
4c628b9d5b Merge "Don't show important notice on password field" 2014-02-17 08:04:11 +00:00
Tadashi G. Takaoka
20ddd4cff5 Add InputMethodSubtypeCompatUtils.isAsciiCapable() 
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
 2014-02-17 16:08:33 +09:00
Tadashi G. Takaoka
ce78a2d8ab Don't show important notice on password field 
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
 2014-02-17 15:38:43 +09:00
Tadashi G. Takaoka
4f4fb5ef34 Merge "Use the same label of switch-to-alphabet key on Emoji palette" 2014-02-17 06:13:39 +00:00
Tadashi G. Takaoka
4c680e7bcf Merge "Add go to "Settings" button to important notice dialog" 2014-02-17 06:13:26 +00:00
Tadashi G. Takaoka
28c02b400f Add go to "Settings" button to important notice dialog 
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.

This change must be checked in together with Id115d89ba9.

Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
 2014-02-17 14:57:04 +09:00
Tadashi G. Takaoka
fe39aec08a Use the same label of switch-to-alphabet key on Emoji palette 
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
 2014-02-17 14:54:39 +09:00
Tadashi G. Takaoka
c9072dc8da Remove key show up and dismiss animation 
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
 2014-02-17 12:10:09 +09:00
Keisuke Kuroyanagi
95d16561e0 Remove unused code. 
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
 2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi
0fc93fe445 Implement PatriciaTriePolicy::getNextWordAndNextToken(). 
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
 2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi
85fe06e759 Merge "Remove unused argument from readDictionaryBinary." 2014-02-14 10:37:56 +00:00
Keisuke Kuroyanagi
8e3a1d0f89 Remove unused argument from readDictionaryBinary. 
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
 2014-02-14 19:02:15 +09:00
Tadashi G. Takaoka
b136b7dd6f Merge "Add sanity check to KeybaordTextsTable for debugging" 2014-02-14 09:52:36 +00:00
Tadashi G. Takaoka
53a237323a Add sanity check to KeybaordTextsTable for debugging 
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
 2014-02-14 18:51:03 +09:00
Jean Chalard
fdc4173213 Merge "Fix a view-related crash" 2014-02-14 09:19:34 +00:00
Jean Chalard
a7e3e74ddd Fix a view-related crash 
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
 2014-02-14 18:03:34 +09:00
Tadashi G. Takaoka
3c4f05dd66 Remove unused label_tab_key 
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
 2014-02-14 17:40:53 +09:00
Tadashi G. Takaoka
17993ed4ef Merge "Fix null KeyDetector reference" 2014-02-14 07:17:33 +00:00
Tadashi G. Takaoka
a273319c59 Add PunctuationSuggestions class 
This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
 2014-02-14 14:13:39 +09:00
Jean Chalard
4197c6f3ab Merge "Show the suggestion strip for the important notice" 2014-02-14 04:07:46 +00:00
Tadashi G. Takaoka
ef8a03685f Fix null KeyDetector reference 
This change must be checked in together with I737c266c45.

Bug: 13011041
Change-Id: Ia3d25be6de47fa16ab7156a25641e53a23948ff4
 2014-02-14 11:42:09 +09:00
Yohei Yukawa
362ab36cf0 Fix a null object reference crash on Emoji Palette 
Do nothing if the current EmojiPageKeyboardView is null.

BUG: 13006906
Change-Id: I169b70122ec939075b5be033953b48762fd528fc
 2014-02-14 10:36:31 +09:00
Yohei Yukawa
5f9f4b929b Merge "Fix indent." 2014-02-14 01:26:48 +00:00
Jean Chalard
5e09958056 Merge "Backward compatibility hack : send delete when empty." 2014-02-13 10:09:41 +00:00
Jean Chalard
2c48846903 Backward compatibility hack : send delete when empty. 
Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.

This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.

Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
 2014-02-13 18:41:54 +09:00
Tadashi G. Takaoka
7ae6721ffa Remove RTL aware !code and add corresponding !text 
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
 2014-02-13 17:32:09 +09:00
Tadashi G. Takaoka
3cb77678f5 Fix Armenian switch to alphabet key text 
Bug: 7963631
Change-Id: If5768c761ec96d3404900b0c017abc2317cce8d4
 2014-02-13 17:26:16 +09:00
Tadashi G. Takaoka
0af6d988a7 Merge "Optimize KeyboardTextsTable" 2014-02-13 08:22:58 +00:00
Tadashi G. Takaoka
0fe4d00068 Optimize KeyboardTextsTable 
This change counts all occurrences of each string resource and sort
those in descending order of the occurrence.

Change-Id: I726402157feb0d436a54bd0a7252acd17fd711f9
 2014-02-13 17:11:00 +09:00
Tadashi G. Takaoka
36b8962a9a Merge "Fix UserHistoryDictionaryTests" 2014-02-13 07:49:51 +00:00
Tadashi G. Takaoka
32c8d58cef Merge "Fix showing all suggestions when the top suggestion is long" 2014-02-13 07:17:31 +00:00
Tadashi G. Takaoka
0cda0e8a9c Fix UserHistoryDictionaryTests 
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
 2014-02-13 16:16:44 +09:00
Tadashi G. Takaoka
4f8a8f125e Fix showing all suggestions when the top suggestion is long 
This change also fixes Bug#12982404; displays the suggestion word
using entire suggestions strip if there is only one suggestion.

Bug: 12564279
Bug: 12982404
Change-Id: I51806b90c3ee34a2072880245d4e33f7be273c8f
 2014-02-13 15:22:36 +09:00
Jean Chalard
e0a425681c Merge "Fix a test." 2014-02-13 05:20:58 +00:00
Jean Chalard
cf03ff02b1 Fix a test. 
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.

Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
 2014-02-13 14:01:37 +09:00
Tadashi G. Takaoka
8dd47029f1 Merge "Refactor dictionary constructor" 2014-02-13 04:55:16 +00:00
Jean Chalard
c3cfabd0eb Merge "Dump settings." 2014-02-13 04:26:52 +00:00
Tadashi G. Takaoka
870d89b1a8 Refactor dictionary constructor 
This change must be checked in together with I3923d5af2a.

Bug: 12994268
Change-Id: I19de6efbdfa3b6c6c69a20a836e53962fd5737de
 2014-02-13 13:23:55 +09:00
Yohei Yukawa
cfe26bbcde Fix indent. 
This is a follow up for the previous commit to fix indent.

BUG: 12964092
Change-Id: I0530b1c0dae26ac736ddcc6d426ec6ce57bce4d1
 2014-02-13 01:58:58 +09:00
Jean Chalard
367a35d377 Dump settings. 
Bug: 10315296
Change-Id: Ieb020a23886514b3ba97611d8a6001f32b322f63
 2014-02-12 22:53:15 +09:00
Yohei Yukawa
50fbe4cc09 Merge "Cancel keydown events immediately once the view starts scrolling" 2014-02-12 10:21:08 +00:00
Yohei Yukawa
4c259866c4 Cancel keydown events immediately once the view starts scrolling 
The motivation of this patch is to make sure a user never feel
haptic feedback when scrolling the Emoji palette. In order to
achieve it, EmojiPageKeyboardView#releaseCurrentKey() should
be called whenever (delayed) keydown events should be canceled.

This patch wires up ViewPager.OnPageChangeListener#onPageScrolled
with EmojiPageKeyboardView#releaseCurrentKey() so that delayed
keydown events will be canceled immediately once the ViewParger
starts scrolling.

BUG: 12964092
Change-Id: Iea8c3e090bb16a8622e6b4a850af2bf963aa77d0
 2014-02-12 18:56:08 +09:00
Tadashi G. Takaoka
5a885e85c2 Merge "Keep showing key preview even when keyboard has been changed" 2014-02-12 09:40:55 +00:00
Tadashi G. Takaoka
dd6ba4b184 Merge "Fix bug in KeyPreviewChoreographer.dismissKeyPreview" 2014-02-12 09:13:37 +00:00
Jean Chalard
8adedbf47c Show the suggestion strip for the important notice 
Bug: 10587358
Change-Id: Ia060a9ca9dfc2e7fe0750536a9fea3b9cc5900c4
 2014-02-12 17:30:04 +09:00
Tadashi G. Takaoka
075158ccd0 Keep showing key preview even when keyboard has been changed 
Bug: 12979147
Change-Id: I7e1f60686d6a8a0fca463174abb0a45f1f62ca43
 2014-02-12 15:09:03 +09:00
Tadashi G. Takaoka
7e9b0b42bf Fix bug in KeyPreviewChoreographer.dismissKeyPreview 
Bug: 12979147
Change-Id: Ibc60b4565badaebe760194f27984b02f9f966996
 2014-02-12 14:50:56 +09:00
Tadashi G. Takaoka
7ffac033ac Make importance notice dialog cancel able 
Bug: 10587358
Change-Id: I7415a6f33e6b5542718164fea1555095d23233e5
 2014-02-12 11:59:43 +09:00
Tadashi G. Takaoka
6e1710f0d4 Merge "Optimize text resources' ordering a bit" 2014-02-11 13:33:42 +00:00
Tadashi G. Takaoka
d495cc36b7 Merge "Get nicer output of make-keyboard-text" 2014-02-11 12:43:32 +00:00
Tadashi G. Takaoka
8bfd6100d9 Optimize text resources' ordering a bit 
Change-Id: I19382f1d9a4b6be173d1e9f62edd727ea987fa20
 2014-02-11 21:41:55 +09:00
Tadashi G. Takaoka
ed509695a4 Get nicer output of make-keyboard-text 
Change-Id: I6d30127aac2198d55b1335002f7a66b4aaebf82d
 2014-02-11 21:41:21 +09:00
Jean Chalard
3df8bcb7a9 Revert "Display predictions when the cursor is moved after a word." 
This change is lacking some comments and break some unit tests.
It needs more work.

This reverts commit 38d31a5e79.

Change-Id: I675854fd0729f2d01b7751e35c6d0117f4f88993
 2014-02-10 14:24:30 +00:00
Jean Chalard
38d31a5e79 Display predictions when the cursor is moved after a word. 
Bug: 12951777
Change-Id: I744b98df6679edd34ca3c1392e38597325935932
 2014-02-10 23:07:00 +09:00
Jean Chalard
f9e5b1ee4f Merge "Show important notice strip" 2014-02-10 12:18:10 +00:00
Tadashi G. Takaoka
8dda9e480b Show important notice strip 
Bug: 10587358
Change-Id: I1af3faa59afb2fc4cb90176acff1c2b0b1ba369c
 2014-02-10 21:15:35 +09:00
Keisuke Kuroyanagi
ea24abf878 Merge "Remove unused code." 2014-02-10 07:19:53 +00:00
Keisuke Kuroyanagi
2ef87aee3e Merge "Make PtNode have ProbabilityInfo instead of raw value." 2014-02-10 06:10:51 +00:00
Keisuke Kuroyanagi
69ccac6e51 Remove unused code. 
Bug: 12810574
Change-Id: If0ef02a984469a3b6e0c00b1c3c8d98d0d2b5466
 2014-02-10 15:05:11 +09:00
Keisuke Kuroyanagi
8ffc631826 Make PtNode have ProbabilityInfo instead of raw value. 
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
 2014-02-10 15:05:08 +09:00
Tadashi G. Takaoka
cbb0a6de3b Merge "Fix possible NPE while finding device override value from resource" 2014-02-10 05:51:44 +00:00
Tadashi G. Takaoka
bd9887a574 Fix possible NPE while finding device override value from resource 
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
 2014-02-10 14:38:53 +09:00
Tadashi G. Takaoka
f70bcf3d32 Refactor Key constructors 
This is a followup of I76432556ca.

Change-Id: Ie2c8f7c23352a33db28e89ee8e6ebaba9eb760a3
 2014-02-10 11:14:35 +09:00
Tadashi G. Takaoka
541a3d394c Remove unused import 
Change-Id: I3f934de281eefb387026585e678d783a95729720
 2014-02-10 10:22:29 +09:00
Tadashi G. Takaoka
45eb5d924d Allow an empty keySpec for Spacer 
Bug: 12933248
Change-Id: I76432556caf319ce23c1fb7fa3d6b94118e64cf8
 2014-02-09 23:45:23 +09:00
Tadashi G. Takaoka
e5320c1d1f Generate KeyboardTextsTable.java instead of KeyboardTextsSet.java 
Change-Id: Ic48b093dc64b514822cc9daa1ac3d79deb7af089
 2014-02-07 18:56:23 +09:00
Tadashi G. Takaoka
4f72923fa2 Merge "Rename Key.keyLabel attribute to KeySpec" 2014-02-07 09:53:43 +00:00
Tadashi G. Takaoka
4e85476740 Merge "Consolidate keyIcon and code with keyLabel attribute" 2014-02-07 09:53:35 +00:00
Tadashi G. Takaoka
9684b33b69 Rename Key.keyLabel attribute to KeySpec 
Change-Id: Ida48cd9bdbc01fefad651a005084262c0f46c41c
 2014-02-07 18:47:45 +09:00
Tadashi G. Takaoka
a83a1feb62 Consolidate keyIcon and code with keyLabel attribute 
Change-Id: I75fbd348fab5022606ca14552eb03b15af6684c8
 2014-02-07 18:47:22 +09:00
Tadashi G. Takaoka
a9e1db6636 Merge "Decimal number is treated as outputText" 2014-02-07 09:26:04 +00:00
Tadashi G. Takaoka
276b1a2ebc Add debug settings for keypress popup animations 
Bug: 12928125
Change-Id: I49faab754c7d1dcf4a791dfc535d3a78b62ce67a
 2014-02-07 18:09:41 +09:00
Keisuke Kuroyanagi
6422f77e94 Merge "Use native logic to read Ver4 dict." 2014-02-06 13:00:09 +00:00
Keisuke Kuroyanagi
ab6a93773b Use native logic to read Ver4 dict. 
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
 2014-02-06 21:55:37 +09:00
Keisuke Kuroyanagi
fc6d0f8738 Merge "Implement getHeaderInfoNative." 2014-02-06 11:26:49 +00:00
Keisuke Kuroyanagi
fc9ca59cc1 Implement getHeaderInfoNative. 
Bug: 11281877
Bug: 12810574
Change-Id: Ia3d85ae2cfdb486e74b8636a62431eae883c85da
 2014-02-06 18:19:42 +09:00
Tadashi G. Takaoka
3bbd50c36b Use SubtypeLocaleUtils.isRtlLanguage 
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
 2014-02-06 18:15:32 +09:00
Tadashi G. Takaoka
48ea52800a Merge "Consolidate keyOutputText with keyLabel attribute" 2014-02-06 09:14:09 +00:00
Tadashi G. Takaoka
d645db1e37 Merge "Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag" 2014-02-06 09:01:41 +00:00
Tadashi G. Takaoka
a9b67135bd Merge "Parse keyLabel for icon, code, and outputText as well" 2014-02-06 08:38:54 +00:00
Tadashi G. Takaoka
df75444239 Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag 
This change must be checked in together with Iac93eb79fc.

Bug: 12913520
Bug: 12179576
Change-Id: Ic9a40fb0529202893be8ccb6f5abfbbe6d78508c
 2014-02-06 17:28:08 +09:00
Tadashi G. Takaoka
0df462730b Remove unused smiley key definitions 
Change-Id: Icbdfb360abab2964869898949774f47197f6d000
 2014-02-06 16:56:42 +09:00
Tadashi G. Takaoka
d6f147e142 Consolidate keyOutputText with keyLabel attribute 
Change-Id: I90ea2c9d5ce42fabc79599995a2fae1f5f652a6b
 2014-02-06 16:42:57 +09:00
Tadashi G. Takaoka
6193217f5c Parse keyLabel for icon, code, and outputText as well 
Change-Id: I023915b68b4aabd056c2c1eb745876471556e15e
 2014-02-06 16:42:17 +09:00
Jean Chalard
a9e1930a6a Merge "Conditionally store the raw suggestions." 2014-02-06 07:31:22 +00:00
Tadashi G. Takaoka
4a64ad9538 Decimal number is treated as outputText 
Change-Id: I9d4a8ac5dd26a7c41fcfbe1842a40f347a2f2aab
 2014-02-06 16:30:12 +09:00
Keisuke Kuroyanagi
fd018c1588 Merge "Use CombinedFormatUtils to convert dict elements to strings." 2014-02-06 07:29:30 +00:00
Jean Chalard
a49f61f8a7 Conditionally store the raw suggestions. 
Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
 2014-02-06 16:14:41 +09:00
Keisuke Kuroyanagi
b24de426fc Use CombinedFormatUtils to convert dict elements to strings. 
Bug: 11281877
Bug: 12810574
Change-Id: Ib631f75eab73abc9877a7698171c45e8f2fc7600
 2014-02-06 16:09:25 +09:00
Keisuke Kuroyanagi
337dce8074 Merge "Consolidate WordProperty and Word." 2014-02-06 07:02:07 +00:00
Keisuke Kuroyanagi
0c088e2d74 Merge "Unregister DictionaryDumpBroadcastReceiver in onDestroy()." 2014-02-06 06:55:42 +00:00
Keisuke Kuroyanagi
f2d15d6956 Unregister DictionaryDumpBroadcastReceiver in onDestroy(). 
Change-Id: I83a05a8369c2fe2fa7522f18eb00983a0b10dc19
 2014-02-06 15:37:41 +09:00
Keisuke Kuroyanagi
5f5feeba13 Consolidate WordProperty and Word. 
Bug: 11281877
Bug: 12810574
Change-Id: I9dc99188f80f25a8780c1860dab46e4aa80a23e5
 2014-02-06 15:13:33 +09:00
Jean Chalard
058d615121 Remove a redundant comment. 
No need to say this twice.

Change-Id: Ief7ac425037aa2767ee8f21c9552138a9c46afc8
 2014-02-05 22:42:38 +09:00
Jean Chalard
58eed6360d Merge "Stop considering personalization dicts outputs as words" 2014-02-05 13:33:12 +00:00
Jean Chalard
5095fabdd0 Stop considering personalization dicts outputs as words 
Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410
 2014-02-05 21:57:37 +09:00
Keisuke Kuroyanagi
239f7daf4a Merge "Make WeightedString have ProbabilityInfo." 2014-02-05 12:53:14 +00:00
Keisuke Kuroyanagi
df1d3e733e Make WeightedString have ProbabilityInfo. 
Bug: 11281877
Bug: 12810574
Change-Id: I265e3d8654c75766cd0e0d09d67ef62b4566298a
 2014-02-05 21:44:55 +09:00
Keisuke Kuroyanagi
e42380a471 Merge "Separate ProbabilityInfo form WordProperty." 2014-02-05 12:37:49 +00:00
Keisuke Kuroyanagi
75a3df30f6 Separate ProbabilityInfo form WordProperty. 
Bug: 11281877
Bug: 12810574
Change-Id: I0c77d976c915bdf2a2cddabd0cbedc2fb6691c7b
 2014-02-05 21:31:35 +09:00
Jean Chalard
8fb2f6a441 Merge "Fix a flash in the wrong place" 2014-02-05 09:46:44 +00:00
Jean Chalard
9e9e948a70 Fix a flash in the wrong place 
Bug: 7226099
Change-Id: I8f74802b3ae24018fc4176fb2fff2c777ae170b0
 2014-02-05 18:44:24 +09:00
Tadashi G. Takaoka
02a534d13f Merge "Treat a sole "|" as a special case of key label" 2014-02-05 09:32:12 +00:00
Tadashi G. Takaoka
6e5dbdd501 Merge "Add null check to KeySpecParser" 2014-02-05 09:32:04 +00:00
Tadashi G. Takaoka
6a16fa1f10 Merge "Refactor KeySpecParser a bit" 2014-02-05 09:17:01 +00:00
Jean Chalard
b162911fa4 Merge "[HD04] Make the locale mandatory." 2014-02-05 09:16:17 +00:00
Tadashi G. Takaoka
f7d8b8fcbc Treat a sole "|" as a special case of key label 
Change-Id: Ia72c31d15c891fa522935ba9792e88fd5d8ce7f7
 2014-02-05 17:57:44 +09:00
Jean Chalard
bbb6e8f10f Merge "[IL109] Move more code to InputLogic" 2014-02-05 08:50:28 +00:00
Jean Chalard
a6ea33b4d7 Merge "[IL108] Remove some uses of LatinIME in input logic." 2014-02-05 08:49:44 +00:00
Tadashi G. Takaoka
d9c6b33209 Add null check to KeySpecParser 
Change-Id: Ic37db8cbf8f83f753d7381e1edba8eac1ef1ceb1
 2014-02-05 17:49:26 +09:00
Tadashi G. Takaoka
bc9514032a Refactor KeySpecParser a bit 
Change-Id: I1208746f42eb92f937812149033398d8318f9c4e
 2014-02-05 17:43:53 +09:00
Jean Chalard
43cf9076b2 [HD04] Make the locale mandatory. 
Bug: 11281748
Change-Id: I69281b0053bec404c3e3c713ade3f65a140f51b1
 2014-02-05 17:35:25 +09:00
Tadashi G. Takaoka
bb476be4e6 Move key preview related methods to KeyPreviewChoreographer 
Change-Id: Ia8d6b7fa922a4da233bf851b2e94bbd2573a65a3
 2014-02-05 15:41:39 +09:00
Tadashi G. Takaoka
f2749e41e4 Merge "Revert "Move key preview related methods to KeyPreviewChoreographer"" 2014-02-05 06:28:45 +00:00
Tadashi G. Takaoka
32d6c6a400 Revert "Move key preview related methods to KeyPreviewChoreographer" 
This reverts commit 38806940b9.

Change-Id: I185c4d5f5d92dd269f678206ef3ff8316cbce6ed
 2014-02-05 06:27:41 +00:00
Jean Chalard
2bb1c6add9 [IL109] Move more code to InputLogic 
Bug: 8636060
Change-Id: Ib12eacc836e8d39c4165c97a2a287f32f6bf5405
 2014-02-05 14:49:59 +09:00
Jean Chalard
2c01dd00f2 [IL108] Remove some uses of LatinIME in input logic. 
Access the suggestion strip through the interface instead.

Bug: 8636060
Change-Id: Ia8bd705c230f943e309d677ef683b1a2cbe68036
 2014-02-05 14:49:59 +09:00
Jean Chalard
ade1aa55b6 [IL107] Add an interface to access the suggestion view. 
Bug: 8636060
Change-Id: I603af6bcdaa31f64aaaf916784720a133388c737
 2014-02-05 14:49:57 +09:00
Tadashi G. Takaoka
aac53dd7f5 Merge "Move key preview related methods to KeyPreviewChoreographer" 2014-02-05 03:45:08 +00:00
Keisuke Kuroyanagi
c488048634 Merge "Check isEligibleForAutoCommit when batch input is ended." 2014-02-05 03:34:46 +00:00
Tadashi G. Takaoka
38806940b9 Move key preview related methods to KeyPreviewChoreographer 
Change-Id: I18cbbd287313826bc72437c6ebab2915c1d7bc50
 2014-02-05 12:34:06 +09:00
Keisuke Kuroyanagi
8c5c01e981 Check isEligibleForAutoCommit when batch input is ended. 
Bug: 11951198
Change-Id: Ibbe09fa38eaa3ebf8f9b69f744a29db7ac598975
 2014-02-05 11:40:17 +09:00
Tadashi G. Takaoka
66b2fcf2bf Merge "Move some XML attributes to KeyPreviewDrawParams" 2014-02-05 00:51:23 +00:00
Keisuke Kuroyanagi
ad37cddd79 Merge "Add jni interface to get header information from native." 2014-02-04 12:52:50 +00:00
Keisuke Kuroyanagi
f32b2d5c5e Merge "Add a utility method to StringUtils." 2014-02-04 12:47:21 +00:00
Keisuke Kuroyanagi
aaf864db7b Merge "Separate header class from FormatSpec." 2014-02-04 12:42:44 +00:00
Keisuke Kuroyanagi
927aff72bc Add jni interface to get header information from native. 
Bug: 12810574
Change-Id: I2508483bcb3157f04cc1fe13f24f864d301f1f28
 2014-02-04 21:42:09 +09:00
Keisuke Kuroyanagi
53fb86c447 Add a utility method to StringUtils. 
Bug: 12810574
Change-Id: I607803e924b9e99855df7690e67488b2861c120e
 2014-02-04 21:42:06 +09:00
Keisuke Kuroyanagi
b986f78ba8 Separate header class from FormatSpec. 
Bug: 12810574
Change-Id: Iacf1cd05a268bf690ab864b5e32a18a4b0ccc693
 2014-02-04 21:36:04 +09:00
Keisuke Kuroyanagi
866fd42091 Merge "Add dictionary dump buttons in debug settings." 2014-02-04 12:34:32 +00:00
Keisuke Kuroyanagi
36c7a62dff Add dictionary dump buttons in debug settings. 
Bug: 11736680
Bug: 12810574
Change-Id: I1f797b5ac6acf94b40d9698d4535e8f5da2bfb17
 2014-02-04 21:29:09 +09:00
Tadashi G. Takaoka
7d09b56812 Move some XML attributes to KeyPreviewDrawParams 
Change-Id: I0e040b3aed63f8da983fcc51d55b55ac9294a16a
 2014-02-04 19:31:45 +09:00
Tadashi G. Takaoka
f7d682cce1 Merge "Refactor KeyPreviewDrawParams a bit" 2014-02-04 10:14:14 +00:00
Keisuke Kuroyanagi
23c487510a Merge "Check timestamp for each pointer." 2014-02-04 08:26:14 +00:00
Keisuke Kuroyanagi
99b7242f78 Merge "Make dumpAllWordsForDebug() use getNextWordProperty()." 2014-02-04 07:51:00 +00:00
Keisuke Kuroyanagi
ffb12e76b8 Merge "Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken." 2014-02-04 07:46:50 +00:00
Tadashi G. Takaoka
992c521909 Refactor KeyPreviewDrawParams a bit 
Change-Id: Ia1a2c5cd882c2524a2e2f02ae052f0404061b2f7
 2014-02-04 16:10:58 +09:00
Keisuke Kuroyanagi
33fd13bf3c Check timestamp for each pointer. 
Bug: 11325631
Change-Id: I4e296cdeccf21323c5732754e86c3a4075ccf82a
 2014-02-04 14:04:26 +09:00
Keisuke Kuroyanagi
d79fd29f61 Make dumpAllWordsForDebug() use getNextWordProperty(). 
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
 2014-02-04 13:51:49 +09:00
Keisuke Kuroyanagi
941734695b Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken. 
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
 2014-02-04 12:42:14 +09:00
Tadashi G. Takaoka
5be8a59a5a Use "Key popup dismiss delay" to control key preview zoom out animation 
Bug: 12809303
Change-Id: I2db0362a2f8c512145f1cf9326f06e5f922987b8
 2014-02-04 11:43:58 +09:00
Tadashi G. Takaoka
b06e455797 Clear important notice strip 
Bug: 10587358
Change-Id: Ic90e5825200a1d424aac4ba263b252187a203241
 2014-02-03 18:28:21 +09:00
Tadashi G. Takaoka
4d539f2c1e Merge "Fix important notice strip text layout" 2014-02-03 09:14:02 +00:00
Tadashi G. Takaoka
9706f9a2f4 Fix important notice strip text layout 
Bug: 10587358
Change-Id: I9cbdd3b450e05d6d0611a16b6b7fad945918dd5f
 2014-02-03 18:07:19 +09:00
Tadashi G. Takaoka
a2d83dfdc7 Merge "Show important notice dialog" 2014-02-03 08:04:03 +00:00
Tadashi G. Takaoka
342e81e7a6 Show important notice dialog 
Bug: 10587358
Change-Id: I3b4282a1bb183aa901110a4a2fc1b6ed72818aae
 2014-02-03 16:21:53 +09:00
Jean Chalard
80fa64e66b Merge "Don't resume suggestions if suggestions are not requested." 2014-02-03 07:07:14 +00:00
Jean Chalard
5d9be8039c Merge "Have empty suggestions go through setNeutralSuggestions." 2014-02-03 06:45:45 +00:00
Jean Chalard
2cbf152986 Have empty suggestions go through setNeutralSuggestions. 
Bug: 12865205
Change-Id: If17a390c445d0820325a9b16cc4f2f27a361187a
 2014-02-03 15:33:00 +09:00
Jean Chalard
9068fd4e77 Don't resume suggestions if suggestions are not requested. 
Bug: 12832614
Change-Id: I6a9b6d128d7e0324ba59a43cf153a3b54e1d35bf
 2014-02-03 15:20:45 +09:00
Keisuke Kuroyanagi
38f341a2a5 Add a jni method to iterate words in a dictionary. 
Bug: 12810574
Change-Id: I87b13559765f0262dfd06c2ba40d43af6437ea7f
 2014-02-03 14:51:58 +09:00
Yohei Yukawa
08d72c52f9 Merge "Introduce a delay for key-press feedback on the Emoji palette" 2014-02-03 02:14:59 +00:00
Keisuke Kuroyanagi
5ecf74b148 Merge "Extend jni interface to get bigrams in WordProperty." 2014-01-31 11:53:10 +00:00
Keisuke Kuroyanagi
94d9a2309f Extend jni interface to get bigrams in WordProperty. 
Bug: 12810574
Change-Id: Ia4b88d02ea8790a5c47d32376cc0b84c3e071ddd
 2014-01-31 20:32:44 +09:00
Tadashi G. Takaoka
2abe1cedc8 Merge "Add important notice strip" 2014-01-31 11:23:52 +00:00
Tadashi G. Takaoka
e855093f55 Move some methods to MoreKeySpec class 
Change-Id: I025ed15e36ac3113db6a5fccefa0c87f016703fa
 2014-01-31 20:19:48 +09:00
Tadashi G. Takaoka
8a296e43c9 Add important notice strip 
This change is a groundwork to show important notice.

Bug: 10587358
Change-Id: I80aa70d30e2a529b37798f0df2183b41df3ac38a
 2014-01-31 20:07:27 +09:00
Jean Chalard
4e6f72cb80 Merge "[HD03] Straighten out attribute key names in Java." 2014-01-31 08:40:25 +00:00
Tadashi G. Takaoka
7914a97b73 Merge "Move some prefix strings to relevant classes" 2014-01-31 08:11:56 +00:00
Tadashi G. Takaoka
3b4eb03fa1 Move some prefix strings to relevant classes 
Change-Id: I7321ac7820d4eded5f16f2440ffb4f525315b3f4
 2014-01-31 17:09:14 +09:00
Tadashi G. Takaoka
1e40af5ebe Merge "Refactor KeyboardTextsSet class" 2014-01-31 08:05:02 +00:00
Tadashi G. Takaoka
be0d05c5ef Merge "Move important notice version to resource" 2014-01-31 07:37:13 +00:00
Tadashi G. Takaoka
0bae2ab460 Refactor KeyboardTextsSet class 
Change-Id: I0b48c85aa2c291e1e7ee25d61c558700fc677e29
 2014-01-31 16:31:07 +09:00
Yohei Yukawa
94797fb3a6 Introduce a delay for key-press feedback on the Emoji palette 
Currently key-press effect such as highlight and vibration
occur even when a user want to scroll the Emoji palette.
To mitigate this situation, this patch introduces a short delay
for key-press feedback on the Emoji palette.

This is not an ideal solution but should be better than now.

BUG: 11103083
Change-Id: I1fa4514d742eb37f36fef60e6beabbc5eaa1653a
 2014-01-31 15:48:10 +09:00
Tadashi G. Takaoka
d245f6c9e2 Move arrayAsList method to CollectionUtils 
Change-Id: If7c1eb7c802490f19c5d3b81d714362408daf376
 2014-01-31 15:26:05 +09:00
Tadashi G. Takaoka
de76e62b69 Merge "Move some methods to StringUtils" 2014-01-31 06:16:14 +00:00
Tadashi G. Takaoka
639bf62e4f Move some methods to StringUtils 
Change-Id: I29d87fdd65ec879d1c0bdf7e7792a677687c1693
 2014-01-31 14:49:36 +09:00
Jean Chalard
79b2e4d86c [HD03] Straighten out attribute key names in Java. 
Bug: 11281748
Change-Id: I1d813bdacd45bcfd9c4cc73ac1d67c5c89854e86
 2014-01-31 14:46:07 +09:00
Jean Chalard
b0df28f4cc Merge "[HD02] Make the date header attribute mandatory." 2014-01-31 03:58:55 +00:00
Tadashi G. Takaoka
5b8ffad26c Move important notice version to resource 
Bug: 10587358
Change-Id: Ie24fc6c53b15880f4ace991a25223056f03f5eda
 2014-01-31 12:49:36 +09:00
Keisuke Kuroyanagi
748f32feba Merge "Rename UnigramProperty to WordProperty." 2014-01-31 03:06:44 +00:00
Keisuke Kuroyanagi
080a35e959 Rename UnigramProperty to WordProperty. 
Bug: 12810574
Change-Id: If5ddd803948aaf6e491ddcbaa5436fb3af3f7257
 2014-01-31 11:06:42 +09:00
Jean Chalard
a137c21c9c [HD02] Make the date header attribute mandatory. 
Bug: 11281748
Change-Id: I48a6f3d95ca89ced0c51335527201ecabfb7998e
 2014-01-30 18:19:21 +09:00
Tadashi G. Takaoka
776d46a771 Merge "Show "Touch again to save" in system locale" 2014-01-30 09:17:11 +00:00
Tadashi G. Takaoka
9b1a66843d Show "Touch again to save" in system locale 
Bug: 12811156
Change-Id: I928daf17297ec5c526720850d6203cb9af0496ac
 2014-01-30 18:03:23 +09:00
Keisuke Kuroyanagi
7ceee45376 Merge "Fix historical info of bigrams reading." 2014-01-30 08:21:34 +00:00
Tadashi G. Takaoka
bf2f0892a0 Merge "Add ImportantNoticeUtils class" 2014-01-30 08:08:37 +00:00
Tadashi G. Takaoka
a14ddfb5ff Add ImportantNoticeUtils class 
Bug: 10587358
Change-Id: I76673b47aab1579cc1310b6a978d04f874d5bcfe
 2014-01-30 17:04:05 +09:00
Keisuke Kuroyanagi
971bbcf562 Fix historical info of bigrams reading. 
Bug: 12809791
Change-Id: I879279a0d0e1007a7c6cb87a627bf046340dda98
 2014-01-30 16:19:22 +09:00
Tadashi G. Takaoka
d432892f0c Fix Farsi keyboard comma and period 
Bug: 12807701
Change-Id: I49503e9945d97e13d7cc98f54ca071cb935d1e52
 2014-01-30 15:45:23 +09:00
Jean Chalard
0c186c31d2 Merge "[IL106] Inline a now useless method." 2014-01-30 03:47:32 +00:00
Jean Chalard
90c072a5ba Merge "[IL105] Remove more useless arguments" 2014-01-30 03:46:08 +00:00
Jean Chalard
362779d608 Merge "[IL104] Remove useless arguments" 2014-01-30 03:45:15 +00:00
Jean Chalard
e5040f6b0d Merge "[IL103] Save the typed word separately in SuggestedWords." 2014-01-30 03:44:54 +00:00
Keisuke Kuroyanagi
26bd46095a Reading dictionary containing timestamps in Java Side. 
Just skipping historical information fields.

Bug: 11281877
Change-Id: I43d2adaa576b7da11ed3ca54990265dbb6f53b08
 2014-01-29 20:19:24 +09:00
Jean Chalard
ac84fe642e [IL106] Inline a now useless method. 
Bug: 8636060
Change-Id: Ic8e0225206358680aa0de421f17ab443c888036d
 2014-01-29 12:23:40 +09:00
Jean Chalard
fa7075768d [IL105] Remove more useless arguments 
Bug: 8636060
Change-Id: I9e817bb9622c84544a5ca8708e5c1fccad1ed447
 2014-01-29 12:23:26 +09:00
Jean Chalard
084c9961f4 [IL104] Remove useless arguments 
Bug: 8636060
Change-Id: I97a371fe0c6227eb0f03d3e391a33726e6280322
 2014-01-29 12:23:25 +09:00
Jean Chalard
1d2e4f9dcc [IL103] Save the typed word separately in SuggestedWords. 
This helps managing the cases where the typed word is not
in the suggestions. This happens during recorrection.

Bug: 8636060
Change-Id: I6784feb793cae96272a7f1d123a0e3bbb8f03143
 2014-01-29 12:22:21 +09:00
Tadashi G. Takaoka
a454a7b85c Add method to clear user history dictionary for testing 
This change should be checked in together with I19cd689157.

Bug: 12179576
Change-Id: I5cc9f52a37ad6623809a14575f3f4b1cd18725c3
 2014-01-29 12:01:37 +09:00
Tadashi G. Takaoka
005d2454c9 Merge "Remove suggestion_word and suggestion_info layout files" 2014-01-29 01:05:37 +00:00
Yohei Yukawa
be18530acf Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key" 2014-01-28 10:50:23 +00:00
Tadashi G. Takaoka
c2ea3f7dd9 Remove suggestion_word and suggestion_info layout files 
Change-Id: I37fea41cfc6e717ce7e5aa36ad331675fc9e8ce5
 2014-01-28 19:38:35 +09:00
Yohei Yukawa
576f8a5b72 Fix inconsistent behavior with the back-to-the-main-keyboard key 
With this patch, the back-to-the-main-keyboard in the Emoji
palette will be registered as a key-release action instead of
a key-press action, like switch-to-the-emoji-palette in the
main layout. This provides mroe consistent UX when the layout is
switched from the main layout to the Emoji palette then
switched back to the main layout.

BUG: 12464067
Change-Id: Ia0d0185db43234dfcfb7cee2677f3d199fe6ed96
 2014-01-28 19:30:27 +09:00
Jean Chalard
c9cc1b1de5 [IL102] Rename a method 
Bug: 8636060
Change-Id: Ia54afdfab9124aa5c35699e357e63eae66a7557f
 2014-01-28 17:18:02 +09:00
Jean Chalard
4500dedfa9 [IL101] Remove a method 
Bug: 8636060
Change-Id: Ic9c12fc6970987b0e1912e8ae85bed55260d66b5
 2014-01-28 17:18:02 +09:00
Jean Chalard
675f1dbaf0 [IL98] Refactoring of setSuggestedWords 
Bug: 8636060
Change-Id: Iab53df96f2c23bddc6c70c3560b380fbaef1053c
 2014-01-28 17:18:01 +09:00
Jean Chalard
491a6a6f23 [IL100] Pull up a check 
Bug: 8636060
Change-Id: I344ed59f5f55b412880fc6dc70205eecb1e79961
 2014-01-28 17:18:01 +09:00
Jean Chalard
4761d2fb00 [IL99] Migrate some code to InputLogic. 
Bug: 8636060
Change-Id: Ibf1f9c7bdc3fdd872d6c15447fa555434485cc52
 2014-01-28 17:18:01 +09:00
Jean Chalard
eb00023b9b [IL97] Readability improvement 
Bug: 8636060
Change-Id: I6b15c7fb91cd4cf23a993541c19842b51e328f8f
 2014-01-28 17:17:58 +09:00
Tadashi G. Takaoka
95e5e267ac Merge "Suggestion strip honors RTL layout" 2014-01-28 07:52:25 +00:00
Keisuke Kuroyanagi
25270ec540 Merge "Check probability before adding to the user history dict." 2014-01-28 07:35:31 +00:00
Jean Chalard
36fda2bae3 Merge "[IL96] Inline a method" 2014-01-28 07:31:48 +00:00
Keisuke Kuroyanagi
90ac041c9f Check probability before adding to the user history dict. 
Bug: 12764888
Change-Id: I5da3ef21d9d82b7034e7dc9b7d0fdca0d48a49f4
 2014-01-28 16:31:37 +09:00
Jean Chalard
7593f93565 Merge "[IL95] Inline a method that's always called in sequence" 2014-01-28 07:31:31 +00:00
Tadashi G. Takaoka
bcd30bf3e7 Suggestion strip honors RTL layout 
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
 2014-01-28 15:47:54 +09:00
Jean Chalard
86210c7dc7 [IL96] Inline a method 
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
 2014-01-28 15:47:04 +09:00
Jean Chalard
90916143b6 [IL95] Inline a method that's always called in sequence 
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
 2014-01-28 15:47:01 +09:00
Tadashi G. Takaoka
02b087090e Merge "Fix test fails caused by I8bede13c87" 2014-01-28 05:19:53 +00:00
Yohei Yukawa
0272553578 Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete." 2014-01-28 05:06:07 +00:00
Yohei Yukawa
0e04c24a05 Fix inconsistent behavior with the spacebar on the Emoji pallete. 
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.

With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.

Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
 2014-01-28 13:44:31 +09:00
Jean Chalard
ca1c1ddd4e Merge "[IL94] Remove a function and some reordering" 2014-01-28 03:46:28 +00:00
Jean Chalard
9909d6aa49 Merge "[IL93] Refactor a method inside another" 2014-01-28 03:32:52 +00:00
Jean Chalard
cbf54dea49 Merge "[IL92] Straighten out showSuggestionStripWithTypedWord" 2014-01-28 03:32:17 +00:00
Jean Chalard
5a1f837356 Merge "[IL91] Call reorder" 2014-01-28 03:26:23 +00:00
Tadashi G. Takaoka
9ac6c9064d Fix test fails caused by I8bede13c87 
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
 2014-01-28 11:17:47 +09:00
Tadashi G. Takaoka
c2e2b3949b Merge "Add SubtypeLocaleUtils.isRtlLanguage method" 2014-01-28 01:28:47 +00:00
Jean Chalard
5b5e877efe [IL94] Remove a function and some reordering 
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
 2014-01-27 20:38:45 +09:00
Jean Chalard
37e1cc931f [IL93] Refactor a method inside another 
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.

Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
 2014-01-27 20:38:45 +09:00
Jean Chalard
4c6029e530 [IL92] Straighten out showSuggestionStripWithTypedWord 
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
 2014-01-27 20:38:45 +09:00
Jean Chalard
c6367ee64d [IL91] Call reorder 
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
 2014-01-27 20:38:43 +09:00
Jean Chalard
01893b25dd Merge "[IL90] Small refactoring" 2014-01-27 11:18:52 +00:00
Jean Chalard
3f226af439 Merge "[IL89] Inline a function" 2014-01-27 11:18:19 +00:00
Jean Chalard
5b9e54c135 Merge "[IL88] Simple refactoring" 2014-01-27 11:17:54 +00:00
Jean Chalard
8f3e37a631 Merge "[IL87] Remove a call to clearSuggestionStrip" 2014-01-27 11:17:45 +00:00
Jean Chalard
521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard
7aa7e36611 Merge "[IL85] Maybe show punctuations when app completions are null" 2014-01-27 11:17:18 +00:00
Jean Chalard
264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard
7ac542d490 Merge "[IL83] Inline a call" 2014-01-27 11:16:30 +00:00
Jean Chalard
47ff423121 Merge "[IL82] Fix a wrong comment" 2014-01-27 10:11:42 +00:00
Jean Chalard
75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka
c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method 
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
 2014-01-27 19:05:16 +09:00
Jean Chalard
6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard
b084da2ae6 Merge changes I5092942a,I931c553f 
* changes:
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
 2014-01-27 10:00:37 +00:00
Jean Chalard
a3a85e8c2b Merge "[IL78] Move most of onUpdateSelection to InputLogic." 2014-01-27 09:55:08 +00:00
Jean Chalard
d38b0468b0 [IL90] Small refactoring 
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
 2014-01-27 18:42:33 +09:00
Jean Chalard
33ff321d6c [IL89] Inline a function 
We will then refactor the contents of showSuggestionStripWithTypedWord

Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
 2014-01-27 18:42:33 +09:00
Jean Chalard
ca819178a1 [IL88] Simple refactoring 
With this, the value passed to suggestedWords is never null.

Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
 2014-01-27 18:42:33 +09:00
Jean Chalard
d90bdd2187 [IL87] Remove a call to clearSuggestionStrip 
The goal is to remove the function completely.

Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
 2014-01-27 18:42:33 +09:00
Jean Chalard
3b939ed77f [IL86] Simplification and correctness fix. 
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
 2014-01-27 18:42:33 +09:00
Jean Chalard
07eddf3c43 [IL85] Maybe show punctuations when app completions are null 
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.

Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
 2014-01-27 18:42:32 +09:00
Jean Chalard
b2c0388a69 [IL84] Remove a useless call and rename a method 
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
 2014-01-27 18:42:32 +09:00
Jean Chalard
eb190ab32f [IL83] Inline a call 
The coming string of changes is very complicated, so
I'm going to do things really slowly.

Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
 2014-01-27 18:42:32 +09:00
Jean Chalard
17f1528f9e [IL82] Fix a wrong comment 
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
 2014-01-27 18:42:32 +09:00
Jean Chalard
abbd755689 [IL81] Remove a useless test. 
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
 2014-01-27 18:42:32 +09:00
Jean Chalard
f1e5b9b4d1 [IL80] Reverse a test for clarity. 
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
 2014-01-27 18:42:32 +09:00
Jean Chalard
f59487379e [IL79] Some refactoring 
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
 2014-01-27 18:42:29 +09:00
Jean Chalard
10460441db [IL78] Move most of onUpdateSelection to InputLogic. 
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
 2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka
1e4b1300e6 Merge "Refactor SuggestionsStripLayoutHelper class" 2014-01-27 09:36:52 +00:00
Jean Chalard
68d7291a6b Merge "[IL77] Remove refs to Settings from InputLogic" 2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka
148dedbc5d Refactor SuggestionsStripLayoutHelper class 
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
 2014-01-27 18:25:25 +09:00
Jean Chalard
7bee84095e Merge "[IL75] Move the SubtypeSwitcher out of InputLogic." 2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka
829ad708db Merge "Revert "Use ViewCompat support library"" 2014-01-27 09:20:19 +00:00
Jean Chalard
48df380f78 [IL77] Remove refs to Settings from InputLogic 
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
 2014-01-27 18:18:54 +09:00
Jean Chalard
969c06072d [IL75] Move the SubtypeSwitcher out of InputLogic. 
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
 2014-01-27 18:18:27 +09:00
Jean Chalard
c7ef305bbc Try to figure out whether d.quotes open or close. 
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
 2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka
e4692c0050 Revert "Use ViewCompat support library" 
This reverts commit e7ee4fa862.

Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
 2014-01-27 18:14:40 +09:00
Jean Chalard
5cf70a1d44 Merge "[IL74] Remove unused/unwanted arguments to a method." 2014-01-27 08:57:12 +00:00
Yohei Yukawa
0b58617951 Merge "Fix inconsistent behavior with backspace in the Emoji pallete." 2014-01-27 08:11:51 +00:00
Jean Chalard
0fd556ceca [IL74] Remove unused/unwanted arguments to a method. 
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
 2014-01-27 16:48:17 +09:00
Yohei Yukawa
ea8c1c811c Fix inconsistent behavior with backspace in the Emoji pallete. 
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
  the key.

This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
  different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
  key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
  subsequent delete key events when the finger is moved away
  from the key area.

Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
 2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka
f3ca92dd33 Merge "Use ViewCompat support library" 2014-01-27 07:21:41 +00:00
Tadashi G. Takaoka
e7ee4fa862 Use ViewCompat support library 
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
 2014-01-27 16:11:03 +09:00
Ken Wakasa
03283b636c Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939 
some cleanups as well

Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
 2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi
95043145df Merge "Check length of words for personalization dict." 2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi
b7197b705b Check length of words for personalization dict. 
Bug: 12602903

Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
 2014-01-24 16:32:28 -08:00
Ken Wakasa
0acd121083 Fix wrong indents. 
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
 2014-01-24 23:55:33 +09:00
Jean Chalard
b6e128cc05 Merge "[IL69.1] Move a static method to a utility class." 2014-01-24 03:04:12 +00:00
Jean Chalard
1d6e647ac3 [IL69.1] Move a static method to a utility class. 
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
 2014-01-24 11:59:23 +09:00
Jean Chalard
0c72529088 Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer" 2014-01-24 01:55:57 +00:00
Jean Chalard
3aa2043a66 Merge "[IL76] Remove a SuggestionStripView dependency" 2014-01-23 10:06:42 +00:00
Jean Chalard
f16a2a36d2 [IL71.1] Add some javadoc. 
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
 2014-01-23 17:11:47 +09:00
Jean Chalard
a1ed211c4e [IL76] Remove a SuggestionStripView dependency 
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
 2014-01-23 16:25:48 +09:00
Jean Chalard
4173610bc5 [IL66.1] Add a comment 
Followup to IL66

Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
 2014-01-23 16:00:49 +09:00
Jean Chalard
be846fc352 [IL73] Remove all refs to Key and Keyboard in WordComposer 
Please hold my gun while I have this nice cup of tea.
Yes !!

Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
 2014-01-23 15:52:29 +09:00
Jean Chalard
df8310c6e2 Merge "[IL71] Add indices to toCodePointArray." 2014-01-23 06:50:19 +00:00
Jean Chalard
1284e556f4 [IL70] Remove unused arguments 
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
 2014-01-23 15:33:14 +09:00
Jean Chalard
d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord 
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
 2014-01-23 15:32:59 +09:00
Jean Chalard
9da4b49ef6 [IL68] Start refactoring setComposingWord 
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
 2014-01-23 15:15:49 +09:00
Jean Chalard
18638d30c0 [IL71] Add indices to toCodePointArray. 
This is necessary for tests

Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
 2014-01-23 13:11:40 +09:00
Jean Chalard
eb6d41a525 [IL67] Externalize a call to the keyboard switcher 
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
 2014-01-23 13:10:02 +09:00
Jean Chalard
ab80b41a0d [IL66] Remove two accesses to KeyboardSwitcher. 
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
 2014-01-23 13:09:58 +09:00
Jean Chalard
a91dfff5e5 [IL65] Pull up X,Y processing, step 4 
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.

Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
 2014-01-22 14:44:27 +09:00
Jean Chalard
352286a43b [IL64] Pull up X,Y processing, step 3 
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
 2014-01-22 14:44:25 +09:00
Jean Chalard
b8216a4e7e [IL63] Pull up X,Y processing, step 2 
This also fixes the coordinates passed to logOnDelete and
log onSeparator.

Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
 2014-01-22 14:42:52 +09:00
Jean Chalard
2b38b5e8e6 [IL62] Pull up X,Y processing, step 1 
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.

However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.

Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
 2014-01-22 14:41:45 +09:00
Jean Chalard
591580ee8a Merge "[IL61] Remove an internal use of key coordinates" 2014-01-22 05:19:45 +00:00
Tadashi G. Takaoka
c93cf1c398 Use sorted int[] to represent word separators 
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
 2014-01-20 19:40:02 +09:00
Tadashi G. Takaoka
5b6ebdbe9e Merge "Refactor logic to retrieve relevant suggestions a bit" 2014-01-20 09:57:43 +00:00
Tadashi G. Takaoka
837cdd738b Add SpacingAndPunctuationsTests 
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
 2014-01-20 18:33:45 +09:00
Tadashi G. Takaoka
3033cc51b8 Refactor logic to retrieve relevant suggestions a bit 
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
 2014-01-20 12:08:25 +09:00
Keisuke Kuroyanagi
3f3b0af5b7 Merge "Fix unit tests by adding @UsedForTesting" 2014-01-19 22:47:03 +00:00
Keisuke Kuroyanagi
fde4c5f128 Fix unit tests by adding @UsedForTesting 
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
 2014-01-19 13:37:23 -08:00
Keisuke Kuroyanagi
b1814c9633 Merge "Make contacts dict and user dict version 4." 2014-01-17 20:05:17 +00:00
Keisuke Kuroyanagi
ed95d79cc4 Make contacts dict and user dict version 4. 
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
 2014-01-17 10:30:16 -08:00
Tadashi G. Takaoka
6a18af634e Refactor RichInputConnection a bit 
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
 2014-01-17 13:14:29 +09:00
Jean Chalard
2334bf6d8c Merge "Fix a bug specific to German capitalization." 2014-01-17 01:49:14 +00:00
Jean Chalard
e4f584de73 Merge "[IL60] Make InputLogicHandler package private" 2014-01-16 18:15:15 +00:00
Jean Chalard
87f87d9ac5 Merge "[IL59] Rename a method" 2014-01-16 18:13:39 +00:00
Jean Chalard
9c9c43c0b7 Merge "[IL58] Simplification" 2014-01-16 17:45:59 +00:00
Keisuke Kuroyanagi
f4bf620502 Merge "Add a dedicated method to control time in native code." 2014-01-16 17:25:29 +00:00
Jean Chalard
ab4543d593 [IL61] Remove an internal use of key coordinates 
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
 2014-01-17 02:10:56 +09:00
Jean Chalard
81255612bc [IL60] Make InputLogicHandler package private 
Yay

Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
 2014-01-17 02:10:56 +09:00
Jean Chalard
17bd129faf [IL59] Rename a method 
Um... this is not async ? Remove that from the name

Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
 2014-01-17 02:10:56 +09:00
Jean Chalard
ac6dfaf80b [IL58] Simplification 
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.

Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
 2014-01-17 02:10:51 +09:00
Jean Chalard
60afa7000f Fix a bug specific to German capitalization. 
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
 2014-01-17 02:06:24 +09:00
Keisuke Kuroyanagi
9e882e3937 Merge "Update personalization dict via dictionary facilitator." 2014-01-16 02:00:21 +00:00
Keisuke Kuroyanagi
12474634c5 Update personalization dict via dictionary facilitator. 
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
 2014-01-15 17:54:17 -08:00
Keisuke Kuroyanagi
d78a447d10 Add a dedicated method to control time in native code. 
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
 2014-01-15 14:55:57 -08:00
Jean Chalard
2c1a13c56c Merge "[IL57] Don't require a main dict suggestion." 2014-01-15 22:14:27 +00:00
Jean Chalard
118a4fc2b7 Merge "[IL56] Don't erase suggestions when reverting a commit." 2014-01-15 19:21:06 +00:00
Jean Chalard
e22e67e37a [IL57] Don't require a main dict suggestion. 
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.

Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
 2014-01-16 03:22:51 +09:00
Jean Chalard
4752b68f5a [IL56] Don't erase suggestions when reverting a commit. 
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
 2014-01-16 03:22:46 +09:00
Tadashi G. Takaoka
20a8a4a3d9 Fix native method signature 
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
 2014-01-15 18:56:40 +09:00
Tadashi G. Takaoka
01c1a1a2ba Refactor LanguageModelParam class a bit 
This change must be checked in together with I9ecfd1adc1.

Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
 2014-01-15 17:46:32 +09:00
Tadashi G. Takaoka
17a2bcfcce Make final Locale field public 
This change must be checked in together with Id9382498a8.

Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
 2014-01-15 17:11:54 +09:00
Tadashi G. Takaoka
b8a2772b0e Consolidate LanguageModelParam constructors 
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
 2014-01-15 16:17:53 +09:00
Tadashi G. Takaoka
7b9b095090 Move LanguageModelParams class to utility package 
This change must be checked in together with Ic82d951237.

Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
 2014-01-15 16:14:53 +09:00
Keisuke Kuroyanagi
68069c55c4 Fix flaky unit test. 
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
 2014-01-14 18:51:29 -08:00
Tadashi G. Takaoka
bf418f7cba Pass time stamp to addToUserHistory method as an argument 
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
 2014-01-14 15:48:08 +09:00
Keisuke Kuroyanagi
5717c63a2b Fix possible NPE in DictionaryFacilitatorForSuggest. 
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
 2014-01-10 21:42:08 +09:00
Jean Chalard
db0adf86a4 Merge "[IL55] Remove a useless argument." 2014-01-10 11:36:01 +00:00
Keisuke Kuroyanagi
eb66f1906d Merge "Check corpus handles during startup for personalization." 2014-01-10 11:34:39 +00:00
Jean Chalard
6c24b91601 [IL55] Remove a useless argument. 
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
 2014-01-10 20:28:50 +09:00
Keisuke Kuroyanagi
eb28bac542 Check corpus handles during startup for personalization. 
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
 2014-01-10 20:28:30 +09:00
Jean Chalard
4be9137609 Merge "[IL54.5] Use the cursor pos estimate, not the last value" 2014-01-10 10:46:27 +00:00
Jean Chalard
a224aafea3 [IL54.5] Use the cursor pos estimate, not the last value 
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.

Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
 2014-01-10 19:08:47 +09:00
Keisuke Kuroyanagi
f96e0f07af Merge "Periodic wipe of the personalization dict." 2014-01-10 09:31:22 +00:00
Keisuke Kuroyanagi
ba07df7fc1 Periodic wipe of the personalization dict. 
Bug: 12216453

Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
 2014-01-10 16:30:59 +09:00
Jean Chalard
ecf46df226 [IL54] Add a mirror method to fix the cursor pos estimate 
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.

Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
 2014-01-10 16:05:02 +09:00
Jean Chalard
6fbe83be7a [IL53] Fix a wrong test. 
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.

When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.

The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.

Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
 2014-01-10 15:21:20 +09:00
Jean Chalard
958e452025 Merge "Fix an NPE." 2014-01-10 05:13:47 +00:00
Jean Chalard
e1de87ae69 Fix an NPE. 
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
 2014-01-10 13:46:37 +09:00
Jean Chalard
84a3047e80 Fix build. 
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
 2014-01-10 12:18:26 +09:00
Tadashi G. Takaoka
ee35e69eae Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion 
This change must be checked in together with Iec437d6df0.

Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
 2014-01-09 19:05:09 +09:00
Tadashi G. Takaoka
494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords 
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
 2014-01-09 18:33:25 +09:00
Tadashi G. Takaoka
d7660c6f56 Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode" 2014-01-09 09:31:32 +00:00
Tadashi G. Takaoka
c912b2228a Merge "Add American typography boolean to SpacingAndPunctuations" 2014-01-09 09:31:24 +00:00
Tadashi G. Takaoka
0a75cf51af Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode 
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
 2014-01-09 18:19:17 +09:00
Tadashi G. Takaoka
860c3b8e8c Add American typography boolean to SpacingAndPunctuations 
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
 2014-01-09 18:17:29 +09:00
Yohei Yukawa
6c326caa4f A style fix 
Just a style fix to follow up the previous commit.

BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
 2014-01-09 15:54:47 +09:00
Keisuke Kuroyanagi
b30f7e4bce Merge "Check whether the word is OOV or not for amanatto update." 2014-01-09 06:24:17 +00:00
Jean Chalard
eab4d25210 Merge "Remove some warnings" 2014-01-09 05:45:10 +00:00
Yohei Yukawa
c1f2986a72 Merge "Trigger haptic feedback at touch down on the EmojiPalettesView" 2014-01-09 05:19:37 +00:00
Jean Chalard
b11339b3ab Remove some warnings 
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
 2014-01-09 14:04:34 +09:00
Jean Chalard
d3e78fc5ce Merge "Fix a bug where changing auto-shift would cancel autorepeat." 2014-01-09 04:53:34 +00:00
Jean Chalard
5cbda70956 Fix a bug where changing auto-shift would cancel autorepeat. 
Bug: 12453966
Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
 2014-01-09 12:57:10 +09:00
Yohei Yukawa
df10aeb1da Trigger haptic feedback at touch down on the EmojiPalettesView 
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down.
This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts.

This patch set also fixes the missing haptic feedback from facemarks such as ":-)".

Bug: 11439600
Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
 2014-01-09 12:27:31 +09:00
Keisuke Kuroyanagi
05113c1847 Check whether the word is OOV or not for amanatto update. 
Bug: 11736529
Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
 2014-01-08 21:02:35 +09:00
Keisuke Kuroyanagi
5742a415f3 Merge "Make reloadMainDict() private." 2014-01-08 11:03:02 +00:00
Keisuke Kuroyanagi
9f1fe87580 Make reloadMainDict() private. 
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
 2014-01-08 18:59:43 +09:00
Jean Chalard
b90fa0fb2c Revert "Revert "Separate spacing and punctuation related settings values"" 
This reverts commit 8bc427799a.

Change-Id: I34f509998afdb1a7c120fbfdb9f0a1b188224a4d
 2014-01-08 18:08:01 +09:00
Jean Chalard
e5cdcaff65 Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
 2014-01-08 18:04:44 +09:00
Jean Chalard
1e7f2809d2 Merge "Revert "Separate spacing and punctuation related settings values"" 2014-01-08 09:03:15 +00:00
Jean Chalard
8bc427799a Revert "Separate spacing and punctuation related settings values" 
This is conflicting with later changes. Temporary revert for cherry-pick.

This reverts commit 0b593ce858.

Change-Id: Id53eadb023a950cfcca496c0cfbfe583c7ec7b8c
 2014-01-08 09:00:45 +00:00
Jean Chalard
d4843c25e2 Merge "Revert "Fix a race condition, take 2."" 2014-01-08 09:00:18 +00:00
Jean Chalard
a247264dc6 Revert "Fix a race condition, take 2." 
Conflicts prevent this to be cherry-picked.

This reverts commit dd3d697a6e.

Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
 2014-01-08 08:59:26 +00:00
Jean Chalard
ff7103d356 Merge "Fix a race condition, take 2." 2014-01-08 08:35:24 +00:00
Jean Chalard
0a0a3cdad8 Merge "Revert "Revert "Fix a race condition.""" 2014-01-08 08:35:19 +00:00
Jean Chalard
dd3d697a6e Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
 2014-01-08 17:19:29 +09:00
Jean Chalard
f628629f69 Revert "Revert "Fix a race condition."" 
This reverts commit 3840127244.

Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
 2014-01-08 16:44:43 +09:00
Tadashi G. Takaoka
ad78058a93 Rename InputPointers.addPointer and ResizableIntArray.add 
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
e13cc9d7e5 Fix ResizableIntArrayTests readability 
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
9b351f7594 Merge "Fix InputPointersTests" 2014-01-08 05:29:32 +00:00
Tadashi G. Takaoka
e7dc5302af Fix InputPointersTests 
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.

Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
 2014-01-08 14:14:42 +09:00
Keisuke Kuroyanagi
b3c51630a6 Fix: NPE in LatinIME.loadSettnigs(). 
Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
 2014-01-08 12:43:58 +09:00
Tadashi G. Takaoka
385031557b Merge "Separate spacing and punctuation related settings values" 2014-01-08 02:41:51 +00:00
Tadashi G. Takaoka
0b593ce858 Separate spacing and punctuation related settings values 
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
 2014-01-08 10:02:37 +09:00
Keisuke Kuroyanagi
c09fd175c3 Prepare using dictionaryFacilitator for amanatto updates. 
Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
 2014-01-07 18:11:23 +09:00
Keisuke Kuroyanagi
55713e3695 Update personalized dict only when single subtype is used. 
Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
 2014-01-07 18:10:27 +09:00
Keisuke Kuroyanagi
8214a8c2cf Fix possible NPE. 
Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
 2014-01-06 17:56:49 +09:00
Tadashi G. Takaoka
3f8c6b8c54 Merge "Add description of disabled voice input key option" 2014-01-06 03:25:15 +00:00
Tadashi G. Takaoka
12ba821bfb Add description of disabled voice input key option 
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
 2014-01-06 12:11:55 +09:00
Tadashi G. Takaoka
e91559a119 Merge "Update shortcut IME info before checking availability of it" 2014-01-06 03:07:23 +00:00
Tadashi G. Takaoka
e9584a1612 Merge "Add DictionaryFacilitatorForSuggest constructor for testing" 2014-01-06 02:58:12 +00:00
Tadashi G. Takaoka
b7c531b751 Update shortcut IME info before checking availability of it 
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
 2014-01-06 11:54:46 +09:00
Tadashi G. Takaoka
49b5fadae1 Add DictionaryFacilitatorForSuggest constructor for testing 
This change must be checked in together with I00b6e79d6b.

Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
 2014-01-06 11:00:51 +09:00
Jean Chalard
1e50c681af [IL52] Remove a useless method. 
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.

Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.

Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
 2013-12-27 22:40:19 +09:00
Jean Chalard
8ce921dd6b [IL51] Make private what can be made private 
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
 2013-12-27 21:09:47 +09:00
Jean Chalard
53c320e275 [IL50] Move the InputUpdater out of LatinIME. 
...at last

Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
 2013-12-27 21:09:41 +09:00
Jean Chalard
81e0ca5fd3 [IL49] Move InputLogic-related init code to InputLogic. 
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
 2013-12-27 20:06:39 +09:00
Jean Chalard
4970eda286 Fix a failing test 
How/when did this happen? How was it not noticed?

Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
 2013-12-27 20:04:41 +09:00
Jean Chalard
d05ea8bd82 Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic." 2013-12-27 08:06:48 +00:00
Jean Chalard
af26a44102 Merge "[IL47] Inline getSuggestedWordsGestureLocked" 2013-12-27 08:04:51 +00:00
Jean Chalard
51e79fb4b2 Merge "[IL46] Remove a useless message passing." 2013-12-27 07:56:56 +00:00
Jean Chalard
2fc1cc099f Merge "[IL45] Remove lingering messages" 2013-12-27 07:56:44 +00:00
Jean Chalard
c654fe57b1 [IL48] Move onEndBatchInputAsyncInternal to InputLogic. 
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
 2013-12-27 16:50:08 +09:00
Jean Chalard
4a144b9b4d [IL47] Inline getSuggestedWordsGestureLocked 
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.

Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
 2013-12-27 16:50:08 +09:00
Jean Chalard
71a3e96382 [IL46] Remove a useless message passing. 
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords

The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.

Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
 2013-12-27 16:50:06 +09:00
Jean Chalard
0d21223521 Merge "[IL44] Some factorization" 2013-12-27 06:58:12 +00:00
Jean Chalard
31ff2a4335 [IL45] Remove lingering messages 
Bug: 8636060
And possibly bug: 12085864

Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
 2013-12-27 15:34:30 +09:00
Jean Chalard
69e7a0d24d [IL44] Some factorization 
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.

Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
 2013-12-27 15:34:26 +09:00
Keisuke Kuroyanagi
c197b9ed90 Merge "Make setAdditionalDictionaries private." 2013-12-27 06:22:18 +00:00
Keisuke Kuroyanagi
86da47e8d7 Fix possible NPE in FileUtils. 
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
 2013-12-27 14:58:38 +09:00
Keisuke Kuroyanagi
abc3d0eb56 Make setAdditionalDictionaries private. 
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
 2013-12-27 14:49:32 +09:00
Jean Chalard
6bca9ac43d Fix a bug where predictions would not pop upon manual pick 
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
 2013-12-26 23:19:29 +09:00
Jean Chalard
33b2aaafc2 Merge "Fix a code path that looks ridiculous" 2013-12-26 13:39:21 +00:00
Jean Chalard
f294ed3308 Fix a code path that looks ridiculous 
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
 2013-12-26 22:28:16 +09:00
Jean Chalard
f441047fad [IL43] Small cleanup 
All calls are already passing this

Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
 2013-12-26 22:12:24 +09:00
Jean Chalard
c28f02880c [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync 
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
 2013-12-26 22:12:22 +09:00
Jean Chalard
70433efc41 [IL41] Remove a useless call and trampoline. 
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.

Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
 2013-12-26 21:58:41 +09:00
Keisuke Kuroyanagi
be147f1fdc Remove DictionaryFacilitatorForSuggest.getMainDictionary(). 
Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
 2013-12-26 20:48:19 +09:00
Keisuke Kuroyanagi
a374482719 Extract dict operations from Suggest to a new class. 
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
 2013-12-26 20:48:19 +09:00
Jean Chalard
5c45ff1214 [IL39] Change a test. 
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.

Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
 2013-12-26 18:44:17 +09:00
Jean Chalard
98140faac3 [IL38] Fix a wrong double call 
This only gives bad results if a gesture results in only one suggestion.

Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
 2013-12-26 18:43:47 +09:00
Keisuke Kuroyanagi
65e3ae6f15 Merge "Remove useless method call for spell checker." 2013-12-26 06:42:51 +00:00
Keisuke Kuroyanagi
7987afbea4 Remove useless method call for spell checker. 
Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
 2013-12-26 14:51:05 +09:00
Tadashi G. Takaoka
3fbcf48591 Merge "Add BatchInputArbiter" 2013-12-26 05:50:07 +00:00
Tadashi G. Takaoka
4a4b6d42a7 Add BatchInputArbiter 
Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.

This change must be checked in together with Ia7db8f4fb7.

Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
 2013-12-26 14:09:57 +09:00
Jean Chalard
30a72da42c [IL37] Small simplification 
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
 2013-12-26 13:51:09 +09:00
Jean Chalard
c08119e5c1 [IL36] Inline setAutoCorrection 
There are far too many one-use methods.

Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
 2013-12-26 13:18:36 +09:00
Jean Chalard
52a2682b99 [IL35] Preparative cleanup 
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
 2013-12-25 22:25:49 +09:00
Jean Chalard
0154609a2e Merge "[IL34] Introduce InputLogicHandler" 2013-12-25 13:21:54 +00:00
Keisuke Kuroyanagi
5c4bd20331 Remove "Boost personalization dictionary" from settings. 
Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
 2013-12-25 19:02:49 +09:00
Keisuke Kuroyanagi
bb39518bd7 Use SettingsValues instead of Settings in Suggest. 
Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
 2013-12-25 18:53:04 +09:00
Tadashi G. Takaoka
d99d225f10 Merge "Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints" 2013-12-25 06:58:08 +00:00
Keisuke Kuroyanagi
eea7122e5b Move dict operations to Suggest. 
Bug: 8187060

Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
 2013-12-25 15:26:50 +09:00
Tadashi G. Takaoka
c3fe1425a5 Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints 
This change must be checked in together with Ibed5330614.

Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace
 2013-12-25 15:19:00 +09:00
Jean Chalard
621dcbc31c [IL34] Introduce InputLogicHandler 
Bug: 8636060
Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f
 2013-12-25 14:20:19 +09:00
Keisuke Kuroyanagi
605caf1b5f Fix NPE in SettingsValues. 
Change-Id: I96fc381d2b45881aeb342d33207cd7fe82f5077c
 2013-12-25 14:00:16 +09:00
Tadashi G. Takaoka
a801c8fd9b Merge "Rename gesture related classes" 2013-12-25 04:04:05 +00:00
Tadashi G. Takaoka
e2a6253cb5 Rename gesture related classes 
Change-Id: I5cb03576bb7221f1864e157857d872880a0a58f8
 2013-12-25 11:52:54 +09:00
Keisuke Kuroyanagi
f1457e7a22 Remove personalized dicts when the option is turned off. 
Bug: 11757851

Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f
 2013-12-25 11:44:16 +09:00
Tadashi G. Takaoka
afca1ddd23 Comprehensive memory deallocation 
Change-Id: I4673543c96eb342c3c977e00d44772a0d719a23e
 2013-12-24 18:26:55 +09:00
Tadashi G. Takaoka
cf915ddc87 Rename classes related to AbstractDrawingPreview 
Change-Id: Ife2e2c08b2b6fbf9ec33cf259f276878816b291c
 2013-12-24 18:17:00 +09:00
Tadashi G. Takaoka
e82200787c Separate GestureStrokePreviewParams to top level class 
Change-Id: I4c6ac12dac9636760128625bb5b7138b7d56f3d1
 2013-12-24 17:27:15 +09:00
Tadashi G. Takaoka
dc2ce72555 Merge "Make GestureStrokeParams as a top level class" 2013-12-24 06:40:29 +00:00
Tadashi G. Takaoka
c845d4c664 Make GestureStrokeParams as a top level class 
Change-Id: I540a2d3a6c6ce6ecdcccecd38df6b3c23fcf8d95
 2013-12-24 15:29:10 +09:00
Jean Chalard
036930e80d Merge "[IL33] Opportunistically remove some KeyboardSwitcher" 2013-12-24 06:28:54 +00:00
Jean Chalard
8476c2e788 [IL33] Opportunistically remove some KeyboardSwitcher 
Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
 2013-12-24 15:11:35 +09:00
Tadashi G. Takaoka
904866c701 Clean up batch input related code a bit 
Change-Id: I3b6a95fdb82bd15e2b636b1374a96d8987d5d8cf
 2013-12-24 14:24:27 +09:00
Tadashi G. Takaoka
aa7a68a3e0 Remove duplicate code 
Change-Id: Ia33ea2dc4bb063ec5bf282c656ccc1f11ac967fe
 2013-12-24 12:39:16 +09:00
Jean Chalard
07f7536b04 [IL32] Remove a useless variable 
Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c
 2013-12-20 21:34:07 +09:00
Jean Chalard
1587be6977 [IL31] Move *BatchInput to InputLogic 
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
 2013-12-20 21:24:27 +09:00
Jean Chalard
059f4c2f39 [IL30] Minor refactoring 
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
 2013-12-20 20:47:44 +09:00
Jean Chalard
0547b33130 [IL29] Move retryResetCaches and tryFixLyingCursorPosition 
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
 2013-12-20 20:47:29 +09:00
Jean Chalard
81e8d16031 [IL28] Remove useless code 
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.

Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
 2013-12-20 19:48:05 +09:00
Jean Chalard
55ce2cc2d5 [IL27] Some refactoring 
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
 2013-12-20 19:24:38 +09:00
Jean Chalard
221df9e59a [IL26] Move restartSuggestionsOnWordTouchedByCursor 
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
 2013-12-20 19:09:36 +09:00
Jean Chalard
ec4b6e7bb3 [IL25] Inline handleClose 
Only ever used here.

Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
 2013-12-20 18:44:13 +09:00
Jean Chalard
aa161eb371 [IL24] Move mDisplayOrientation to SettingsValues. 
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
 2013-12-20 18:44:09 +09:00
Jean Chalard
a22a63f3b1 Merge "Fix an NPE" 2013-12-20 09:14:56 +00:00
Jean Chalard
92392b21f2 Fix an NPE 
Change-Id: I6307c1545d9d48cdea66d08f8efc1b7fbb08ee42
 2013-12-20 18:13:23 +09:00
Tadashi G. Takaoka
f405c58c09 Merge "Use config_screen_metrics resource in BogusMoveEventDetector" 2013-12-20 09:03:25 +00:00
Tadashi G. Takaoka
9c4de1e5f7 Use config_screen_metrics resource in BogusMoveEventDetector 
Change-Id: I6b957b43c6dd7ce4f639e46d248179662c1ee669
 2013-12-20 17:35:19 +09:00
Jean Chalard
1252333efd Merge "[IL23] Resolve a long-standing TODO." 2013-12-20 08:29:29 +00:00
Tadashi G. Takaoka
0c8ea69cad Merge "Separate logic of enabling gesture typing" 2013-12-20 08:03:18 +00:00
Jean Chalard
84e78cb769 Merge "[IL22] Move onTextInput to InputLogic." 2013-12-20 08:02:36 +00:00
Jean Chalard
689cff2e3b Merge "[IL21] Move the workaround utils to a better place." 2013-12-20 08:02:07 +00:00
Jean Chalard
6cf843cba6 [IL23] Resolve a long-standing TODO. 
Bug: 8636060
Change-Id: I3a840c30cc4489debf9118beeec448488503bc1c
 2013-12-20 16:50:14 +09:00
Jean Chalard
11730aa224 [IL22] Move onTextInput to InputLogic. 
Also pull the TLD specific processing

Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
 2013-12-20 16:50:14 +09:00
Jean Chalard
1404c1af85 [IL21] Move the workaround utils to a better place. 
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
 2013-12-20 16:48:54 +09:00
Tadashi G. Takaoka
a00838b6e8 Separate logic of enabling gesture typing 
Change-Id: I91fc566f24a38a55d2352201d5d581d3fa02a428
 2013-12-20 16:37:17 +09:00
Tadashi G. Takaoka
db6d9b0ab4 Merge "Separate BogusMoveEventDetector class" 2013-12-20 07:36:07 +00:00
Tadashi G. Takaoka
c986d16e8a Separate BogusMoveEventDetector class 
Change-Id: I24f0ff385f338ff313ef32514f2930f120183be7
 2013-12-20 16:17:41 +09:00
Tadashi G. Takaoka
9033fb1f64 Merge "Separate TypingTimeRecorder class" 2013-12-20 07:16:34 +00:00
Tadashi G. Takaoka
5045103d61 Separate TypingTimeRecorder class 
Change-Id: Ic56d3e3a1be935854dcace36d8a05a9d2619dab9
 2013-12-20 16:14:26 +09:00
Jean Chalard
529cdf0a0c Merge "[IL20] Remove some useless processing." 2013-12-20 07:14:09 +00:00
Jean Chalard
95d869fed4 Merge "[IL19] Resolve a TODO." 2013-12-20 07:11:24 +00:00
Jean Chalard
8a390023e1 [IL20] Remove some useless processing. 
If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.

Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
 2013-12-20 16:02:07 +09:00
Jean Chalard
4487a30e0d [IL19] Resolve a TODO. 
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
 2013-12-20 16:02:03 +09:00
Jean Chalard
f7d493979a Merge "[IL18] Move and rename updateSuggestionStrip" 2013-12-20 06:54:33 +00:00
Jean Chalard
2a6de7903c [IL18] Move and rename updateSuggestionStrip 
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
 2013-12-20 15:46:34 +09:00
Tadashi G. Takaoka
921a32f0a9 Remove unnecessary default KeyDetector from PointerTracker 
Change-Id: Ib0fbb40a7040202d2a4b4ab49319d9e247a2a6ce
 2013-12-20 15:34:54 +09:00
Tadashi G. Takaoka
dbb88e47c8 Merge "Remove unused default object of GestureStrokePreviewParams" 2013-12-20 06:33:36 +00:00
Tadashi G. Takaoka
081989ca30 Remove unused default object of GestureStrokePreviewParams 
This change also fixes build broken by Id615556766.

Change-Id: I16605cc3b65e3e9ab2d5a498825c31d9b4046b73
 2013-12-20 15:25:24 +09:00
Jean Chalard
1c0374da49 [IL17] Move commitChosenWord to InputLogic. 
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.

Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
 2013-12-20 15:13:48 +09:00
Jean Chalard
a905fcec00 [IL16] Improve getTextWithSuggestionSpan 
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.

Not directly related, but helpful with:
Bug: 8636060

Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
 2013-12-20 15:13:48 +09:00
Tadashi G. Takaoka
6e97efef78 Fix rugged gesture trail 
Bug: 12222472
Change-Id: Id615556766718a8bd4848f7026833fbcea540c39
 2013-12-20 14:40:18 +09:00
Tadashi G. Takaoka
ce9c7d7511 Merge "Remove PointerTracker reference from accessibility package" 2013-12-20 03:33:24 +00:00
Tadashi G. Takaoka
6a23b9e3d5 Remove PointerTracker reference from accessibility package 
Change-Id: I1a88d9fc4db437070778ea1256aae17c32428729
 2013-12-20 12:29:25 +09:00
Jean Chalard
5c9e677c2a [IL15] Some small refactoring 
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
 2013-12-20 11:24:45 +09:00
Jean Chalard
48ba1f25ff [IL14] Move getCurrent*Caps* to InputLogic 
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
 2013-12-20 11:24:42 +09:00
Jean Chalard
cdd8a1a69d [IL13] Inline restartSuggestionsOnWordBeforeCursor 
It's only ever used in one place and makes unhealthy assumptions
about what the caller is doing. It's better inlined.

Bug: 8636060
Change-Id: I265d5d96894e929d09247ee2e3dc2e81efc2a276
 2013-12-19 20:31:52 +09:00
Jean Chalard
bbe40835a9 [IL12] move restartSuggestions* to InputLogic 
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
 2013-12-19 20:30:41 +09:00
Jean Chalard
10755af97b [IL11] Cleanup 
Make some methods private and add comments.

Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
 2013-12-19 20:13:14 +09:00
Jean Chalard
060e292628 [IL10] Move revertCommit to InputLogic 
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
 2013-12-19 19:30:26 +09:00
Jean Chalard
69a57bcdcd [IL9] Move commitCurrentAutoCorrection to InputLogic 
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
 2013-12-19 19:30:20 +09:00
Jean Chalard
035e3885ac [IL8] Move handleNonSeparator to InputLogic 
Also move getActualCapsMode and getNthPreviousWordForSuggestion

Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
 2013-12-19 18:32:51 +09:00
Jean Chalard
d85e49bf8c [IL7] Move performRecapitalization to InputLogic 
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
 2013-12-19 18:20:41 +09:00
Jean Chalard
40b42b7d84 [IL6] Move handleSeparator to InputLogic 
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod

Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
 2013-12-19 17:39:01 +09:00
Jean Chalard
c8dfaab783 [IL5] Some renaming 
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
 2013-12-19 17:38:55 +09:00
Jean Chalard
37d3f1bd02 [IL4] Move handleNonSpecialCharacter to InputLogic. 
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
 2013-12-19 16:46:57 +09:00
Jean Chalard
0e82fa273d [IL3] Move handleBackspace to InputLogic. 
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline

Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
 2013-12-19 16:46:54 +09:00
Jean Chalard
cddf4f9d78 [IL2] Move onCodeInput to InputLogic. 
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
 2013-12-19 16:24:45 +09:00
Jean Chalard
7bd2a75ca1 Start separating the input logic from LatinIME. 
Create an InputEngine class and start moving the relevant
variables to it.

Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
 2013-12-19 14:48:43 +09:00
Jean Chalard
dfbe2bfe08 Add some info to test crashes to help diagnose flakiness 
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
 2013-12-18 18:10:56 +09:00
Keisuke Kuroyanagi
1f5a3faf76 Merge "Enable Personalized dictionaries based on the setting." 2013-12-17 10:40:29 +00:00
Keisuke Kuroyanagi
8732f9c5f9 Enable Personalized dictionaries based on the setting. 
Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7
 2013-12-17 19:36:19 +09:00
Jean Chalard
4196360912 Run GC when needed, instead of too late. 
Bug: 12164855
Change-Id: Ie4d8be9f2652b01470bcc06911e2191e09fb3149
 2013-12-17 18:08:48 +09:00
Jean Chalard
97a553ae69 Fix wrong dereference reading code. 
Bug: 12164855
Change-Id: I26faf27edfa303510197bccaa3521578f649741d
 2013-12-17 16:42:22 +09:00
Keisuke Kuroyanagi
b54c747d7c Merge "Move DictUpdater to the tests directory." 2013-12-17 05:33:16 +00:00
Keisuke Kuroyanagi
4fdcefe504 Move DictUpdater to the tests directory. 
Bug: 11245133
Change-Id: I0907a091ac3ae960eaf3b27da78dbb48a24b2ea1
 2013-12-17 14:31:25 +09:00
Tadashi G. Takaoka
19dd753c0c Cancel more suggestions panel when touching keyboard 
Bug: 10010128
Change-Id: I2ff0870c69f407d943caf8b9cec90b7ed89de5f1
 2013-12-17 12:59:37 +09:00
Tadashi G. Takaoka
dd4937848a Fix typo in varibale name 
Change-Id: I7ea6c59b7c980e93c88a6cf0fef97592d411c3ba
 2013-12-17 12:15:02 +09:00
Tadashi G. Takaoka
fcacde3dad Revise Armenian punctuations more keys 
Bug: 12096943
Change-Id: Ib8559f030fbc27ec7f7e9a9fb36aad72cca29e9f
 2013-12-17 11:12:33 +09:00
Tadashi G. Takaoka
3aeb6a9d0d Merge "Refactor touch event forwarding in InputView" 2013-12-17 02:04:40 +00:00
Tadashi G. Takaoka
27fab2cc2a Refactor touch event forwarding in InputView 
Bug: 10010128
Change-Id: I82aa4ce847e66cb1241678f39b47b9e27a0f555a
 2013-12-17 08:49:50 +09:00
Jean Chalard
0c7b05fc50 Merge "Fix a bug with languages without spaces and predictions" 2013-12-16 14:17:51 +00:00
Jean Chalard
7cd7cf73f4 Fix a bug with languages without spaces and predictions 
This is simpler and more correct.

Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
 2013-12-16 23:16:02 +09:00
Keisuke Kuroyanagi
e17cc8270f Merge "Increment version number of ver4 format to 401." 2013-12-16 14:13:42 +00:00
Keisuke Kuroyanagi
b5215d456a Increment version number of ver4 format to 401. 
Bug: 11073222
Change-Id: I3878aef02040b1ef73165645fc70ede586289c51
 2013-12-16 23:02:54 +09:00
Keisuke Kuroyanagi
214a3b741f Merge "Fix: incompatible PtNode array size reading." 2013-12-16 13:57:55 +00:00
Keisuke Kuroyanagi
56e7e38d37 Fix: incompatible PtNode array size reading. 
Bug: 11073222
Change-Id: I681be725b5c6dcc10aa536b00327698a7df75277
 2013-12-16 22:42:01 +09:00
Jean Chalard
dc06ee85ef A simplification. 
This does the same thing, but simpler and faster.
Was noticed while investigating bug#12164555

Change-Id: If9926e4da8a53a65489da55197ac87122c44fe7c
 2013-12-16 21:38:31 +09:00
Keisuke Kuroyanagi
769eb083ef Merge "Add option to enable personalization dictionaries." 2013-12-16 10:33:40 +00:00
Keisuke Kuroyanagi
d4bb7df412 Add option to enable personalization dictionaries. 
Bug: 11757851

Change-Id: I4872c10793d4fd55c0bd9e5bc4650925de6d2c1d
 2013-12-16 19:17:31 +09:00
Tadashi G. Takaoka
f3b92fb952 Merge "Fix IllegalStateException of ViewGroup" 2013-12-16 08:36:45 +00:00
Tadashi G. Takaoka
7f8345d59a Fix IllegalStateException of ViewGroup 
Bug: 10629042
Change-Id: I111d092fb2f7dca47328127a155c981aa1c55906
 2013-12-16 17:06:23 +09:00
Keisuke Kuroyanagi
b6a19229ba Merge "Make required binary dictionary version use FormatSpec.*" 2013-12-16 07:56:58 +00:00
Keisuke Kuroyanagi
c837767819 Make required binary dictionary version use FormatSpec.* 
Change-Id: Ifb17d6551bc5071553e32a5640dd166c39374461
 2013-12-16 16:50:28 +09:00
Jean Chalard
5590e9d040 Merge "Make the bad header a checked exception and fix dicttool test" 2013-12-16 07:18:44 +00:00
Jean Chalard
3df617323e Make the bad header a checked exception and fix dicttool test 
Change-Id: If780a2a1cb722aee83d910904c0a6315add9552d
 2013-12-16 15:40:45 +09:00
Tadashi G. Takaoka
1b5b0a3ebc Cancel long press shift key while chording input 
Bug: 12123508
Change-Id: I693caad1f8ee47ebeb14419603d1fc29f6263a75
 2013-12-16 15:30:41 +09:00
Jean Chalard
b868375763 Fix failing tests 
- Version 3 is not supported
- Now passing the right string to open v4 dicts. Fix the tests for this.

Change-Id: I7829330c3568a715b96396ba4e4e69c6e17775ab
 2013-12-16 14:32:19 +09:00
Ken Wakasa
2c25c7c9e1 Fix locale names in the make-keyboard-text tool 
Change-Id: I33c3fafcff124bb94e395cc604ce264daad55d2d
 2013-12-14 18:50:57 +09:00
Jean Chalard
330d2720bb Instead of ignoring PARAGRAPH spans, fix them. 
I don't know what or when this flag is set, but it's only bad
news. Luckily, we can just remove it.

Bug: 12119393
Change-Id: I2952138c8ce517535b91e0fe25d2cf4960e02862
 2013-12-13 23:42:31 +09:00
Jean Chalard
7a904514fb Merge "Don't use the previous word after a non-whitespace separator" 2013-12-13 11:53:30 +00:00
Jean Chalard
0b51fac907 Merge "Only update shift state if left in auto mode." 2013-12-13 11:52:13 +00:00
Jean Chalard
fae1ba767c Don't use the previous word after a non-whitespace separator 
Bug: 12101276
Change-Id: Icf36d55ec171194e5561b946021bcf648782ddd4
 2013-12-13 20:51:28 +09:00
Jean Chalard
28bd6e2297 Only update shift state if left in auto mode. 
Bug: 12100417
Change-Id: I7bc2b19332e142a257b0399f2e5d128caf01fc7c
 2013-12-13 20:47:25 +09:00
Jean Chalard
f3d281b775 Merge "Fix a bug where recapitalize prevents going to more syms" 2013-12-13 10:38:18 +00:00
Jean Chalard
5d98e1d82e Fix a bug where recapitalize prevents going to more syms 
Bug: 11004973
Change-Id: I97ee9df6e8464e2149beb41c688cbfbd83ac3d8c
 2013-12-13 19:21:49 +09:00
Jean Chalard
f08b1ea41a Merge "Remove references to the v3 dictionary." 2013-12-13 10:08:12 +00:00
Tadashi G. Takaoka
bf7503ae6b Merge "Fix key top letter color in shifted layout" 2013-12-13 09:55:19 +00:00
Jean Chalard
1dc7eca114 Remove references to the v3 dictionary. 
Change-Id: I811c8c923ad67a6d9bfdd11bdef8991eb7135c27
 2013-12-13 18:53:41 +09:00
Keisuke Kuroyanagi
3e81d9c39f Merge "Remove code for forgetting curve in Java side." 2013-12-13 09:44:16 +00:00
Keisuke Kuroyanagi
cc8c544ee2 Remove code for forgetting curve in Java side. 
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
 2013-12-13 18:40:58 +09:00
Tadashi G. Takaoka
815a339201 Fix key top letter color in shifted layout 
There is a chance to have an empty hint label even though
keyLabelFlags has hasShiftedLetterHint flag.

Change-Id: I63b9fcc42a40391d5902814cae4c75abb61e4b94
 2013-12-13 18:34:30 +09:00
Jean Chalard
a245d15da5 Have dicttool use the native library to generate v4 dicts. 
Yay !

Change-Id: Iea8ced9e81031b9ab7eff05ad9ef7215be248de9
 2013-12-13 18:18:20 +09:00
Jean Chalard
af0c222a5e Merge "Remove flags from Java side." 2013-12-13 09:17:10 +00:00
Jean Chalard
7b55cd3e2b Remove flags from Java side. 
This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
  The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
  regardless of this flag.

Bug: 11281748
Change-Id: If567e52e245a9342adc7f3104a0f7d8d782df8c1
 2013-12-13 18:15:05 +09:00
Ken Wakasa
2fa3693c26 Reset to 9bd6dac470 
The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
 2013-12-13 17:13:32 +09:00
Keisuke Kuroyanagi
9642286c01 Make ExpandableBinaryDictionary usable for offdevice tests. 
Bug: 11956652
Change-Id: If5a503ef161781818f2efceba542be5a61be6bd1
 2013-12-13 14:48:43 +09:00
Keisuke Kuroyanagi
9bd6dac470 Add a constructor for testing to non-main dictionaries. 
The new constructor is used for creating dictionary instance
that uses a given file.

Bug: 11956652
Change-Id: Ifbf420a1a768eb95a5c3a58eeb1be5936b306d35
 2013-12-12 20:14:06 +09:00
Keisuke Kuroyanagi
d06de553b2 Add waitAllTasksForTests for testing. 
Bug: 10667710
Change-Id: I7a189e32286a6005393fbde8da736541ca9226a8
 2013-12-12 17:08:51 +09:00
Keisuke Kuroyanagi
9ff51527a3 Quit passing header file path to native. 
Bug: 12089197
Change-Id: Ia898f8d2836c0c131a1834dc0a396d9121ecb972
 2013-12-12 16:48:34 +09:00
Jean Chalard
9fa221a7bd Remove dependency from StringUtils to Json 
Change-Id: I2a89497fb9ec12a37ba09f4598742e88f6700576
 2013-12-12 13:55:56 +09:00
Tadashi G. Takaoka
79cc690f55 Fix Filipino keyboard 
Bug: 12102802
Change-Id: Id55ba5ebd8ddaf83ed246315d81b25ad4c9b6294
 2013-12-12 11:12:23 +09:00
Keisuke Kuroyanagi
549ae3d84e Merge "Create ver4 dictionary files with the dictionary name." 2013-12-11 10:42:16 +00:00
Keisuke Kuroyanagi
84cc5a2c76 Create ver4 dictionary files with the dictionary name. 
Bug: 12025402

Change-Id: Ia0bb13b2e26aa60a67dff73f3f6a1e276f1bb1dd
 2013-12-11 19:30:18 +09:00
Tadashi G. Takaoka
0719c4ca72 Merge "Ignore other finger while showing more keys keyboard" 2013-12-11 09:20:02 +00:00
Tadashi G. Takaoka
7f82bb55ed Ignore other finger while showing more keys keyboard 
Bug: 12088861
Change-Id: I784cb8fee247a7a4ea4af4c0569fed9334430e18
 2013-12-11 18:12:45 +09:00
Tadashi G. Takaoka
7ca3dbe3e5 Merge "Don't start long press timer while other one is running" 2013-12-11 08:07:47 +00:00
Tadashi G. Takaoka
fa860a091e Don't start long press timer while other one is running 
Bug: 11908158
Bug: 12088861
Change-Id: I2537855f505884da9fe958d946c79840bd19dc5f
 2013-12-11 17:01:26 +09:00
Tadashi G. Takaoka
0a190a389f Merge "Rename deprecated locale directories" 2013-12-11 06:01:34 +00:00
Keisuke Kuroyanagi
ad2d34f80a Rename PersonalizationPredictionDictionary. 
Change-Id: If7497310485a895dd22b8df29dc13508acaa0ab6
 2013-12-11 14:09:00 +09:00
Ken Wakasa
423422c437 Rename deprecated locale directories 
cf. Ibe392f5f9dbc82c3cdff8e06b958bc3bcce3fa82

Also, cf. bug id 11340849

Change-Id: I43e84f8ca04eb1aa74037a705970a36434429a0f
 2013-12-11 13:27:46 +09:00
Jean Chalard
97351ad34c Merge "Fix typos." 2013-12-11 03:41:23 +00:00
Jean Chalard
a8ffdf0288 Merge "Split the header into a separate file." 2013-12-11 03:37:05 +00:00
Jean Chalard
83c879ad67 Fix typos. 
One of these cost me a day and a half searching for a bug :(

Change-Id: I20f0b727f7c02e2754aaaf6a05b74c9cf9e6375e
 2013-12-11 12:06:05 +09:00
Jean Chalard
3839defc90 Split the header into a separate file. 
Bug: 11281748
Change-Id: Ia2490d18bf159990310e10ed45fb6b3a0dee1c5f
 2013-12-11 12:03:40 +09:00
Keisuke Kuroyanagi
499371a5ef Remove PersonalizationDictinoary. 
Now, PersonalizationPredictionDictionary can be used not only
for prediction but also for suggestions.
We should rename PersonalizationPredictionDictionary to
PersonalizationDictionary.

Change-Id: Ifcf4459072f3523e3f3dc783f12e15b89cdbb12d
 2013-12-11 11:09:52 +09:00
Keisuke Kuroyanagi
7c8075c2ac Uncapitalized words for personalization dictionary. 
Bug: 11736529
Change-Id: I62a7469afe03092ec992bfb190f717223a8c556f
 2013-12-10 19:19:18 +09:00
Tadashi G. Takaoka
a2bbb1213d Remove obsolete warning message 
This is a follow up of I5655c5703b.

Change-Id: I4a61689eb275b54648c6112c9f8709e4a9c35a5e
 2013-12-07 18:59:13 +09:00
Tadashi G. Takaoka
4d02aa4e8c Add punctuations letters to period key on tablet 
Bug: 11918360
Change-Id: I5655c5703bfcb541c9ff4b7e0da2f9b8e14947d0
 2013-12-06 18:24:20 +09:00
Tadashi G. Takaoka
637ecce74c Merge "Consolidate multiple locales' period key definition" 2013-12-06 09:21:26 +00:00
Jean Chalard
90c9199753 Merge "[RF4] Actually remove ver4 dicts" 2013-12-06 08:54:33 +00:00
Keisuke Kuroyanagi
fc16c320c6 Merge "Add a jni method to fetch unigram information." 2013-12-06 08:53:21 +00:00
Keisuke Kuroyanagi
9fb28f78f7 Add a jni method to fetch unigram information. 
Bug: 11956652

Change-Id: I59f1823bbc0146f6d2f34cbed8166bb6de197208
 2013-12-06 17:17:38 +09:00
Jean Chalard
c5db41a9d5 [RF4] Actually remove ver4 dicts 
And fix a couple bugs.

Bug: 11281748
Change-Id: If07953a4b1ff9eb1165af03fdb332d7e47cd8f32
 2013-12-06 17:07:59 +09:00
Tadashi G. Takaoka
5bf55a86d0 Return null if "!text/" reference is an empty text 
Change-Id: I01826f3e09527348fb4cba3302a9394ff34f424a
 2013-12-06 16:51:11 +09:00
Tadashi G. Takaoka
aab0140390 Consolidate multiple locales' period key definition 
Bug: 11918360
Change-Id: If59043709a433a57846de07e150bf9c14b614d52
 2013-12-06 15:25:47 +09:00
Jean Chalard
a72e8f1ede [RF3] Cleanups 
Make the version number a single number on native and java side.
Also, remove the hasValidContents method. It's useless since the
native code already checks this when creating the dictionary (I
wish I had known that when I added it).

Bug: 11281748
Change-Id: I572d37429972b2f280e4bdb748b709e5d0d7737e
 2013-12-06 14:53:03 +09:00
Jean Chalard
cb27d955f3 Merge "[RF2] Some refactoring and some cleanup" 2013-12-06 04:30:25 +00:00
Jean Chalard
b8481456f2 [RF2] Some refactoring and some cleanup 
Bug: 11281748
Change-Id: Iff45fdf6b23f77c08271a169c7d7ca45912c85e8
 2013-12-06 13:06:49 +09:00
Tadashi G. Takaoka
6300168cb8 Fix puctuations more keys on Spanish/Phone 
Bug: 11918360
Change-Id: I01e1c1e2a1953855bd2b009fc2d82e18cdde7140
 2013-12-05 18:54:29 +09:00
Tadashi G. Takaoka
4cd86d3bb4 Cleanup exclamation and questuion keys 
Bug: 11918360
Change-Id: I00731a273beea6dbc300dc215996dcadd97f17e2
 2013-12-05 18:53:32 +09:00
Tadashi G. Takaoka
624fcde18b Cleanup comma key of Arabic/Farsi 
Bug: 11918360
Change-Id: I4ab373d8fc012fd77a388a067d7f5d99d8247299
 2013-12-05 18:15:45 +09:00
Tadashi G. Takaoka
f6b479d482 Add exclamation/question marks to Hebrew tablet keyboard 
Bug: 11918360
Change-Id: I226f8fbb2177f472f69b56faca2a141687734494
 2013-12-05 12:47:47 +09:00
Tadashi G. Takaoka
1eb63684f9 Merge "Add workaround to prevent ViewPager from crashing" 2013-12-04 09:05:07 +00:00
Tadashi G. Takaoka
5086275d39 Add workaround to prevent ViewPager from crashing 
Bug: 11721001
Change-Id: I0824f82c30a288a3c1f0ea69e07f10bdeb744bbc
 2013-12-04 17:46:15 +09:00
Jean Chalard
743c7e0e6e Merge "[RF1] Remove files that don't match the expected format, step 1" 2013-12-04 08:19:26 +00:00
Keisuke Kuroyanagi
c63f2762cc Merge "Start to use historical info." 2013-12-04 08:03:53 +00:00
Jean Chalard
5e80e699c4 [RF1] Remove files that don't match the expected format, step 1 
This implements the skeleton implementation, and enables a
fallback implementation in the case the file is coming from the
dictionary provider.
- A better scheme should be used for provider-supplied dicts.
- This does not implement the solution for device-generated
    dicts yet. This will come in a future change.
- This does not implement the checking process on the native
    side yet. This will come in a future change.

Bug: 11281748
Change-Id: Ifa6e237d19dfbffe503e3674915480ea867b0ddf
 2013-12-04 16:19:55 +09:00
Keisuke Kuroyanagi
e33072eb50 Quit using obsolete methods for testing. 
Bug: 11073222
Change-Id: I77c99fbea2f255dbfddb646b6e12bee574647eca
 2013-12-04 16:03:53 +09:00
Keisuke Kuroyanagi
4d68867839 Start to use historical info. 
Bug: 11073222
Change-Id: I232d41bec5df7952856b5ba4765977707c39b94a
 2013-12-04 12:52:58 +09:00
Tadashi G. Takaoka
7081a36e2f Merge "Add spacebar background drawable" 2013-12-04 03:47:41 +00:00
Tadashi G. Takaoka
dc337df48c Add spacebar background drawable 
Bug: 11106827
Change-Id: Ic6e0b6bd9187901b01d64296db816afa73da9ffd
 2013-12-04 12:31:10 +09:00
Keisuke Kuroyanagi
a0befc6490 Start passing timestamp for dynamic dictionaries. 
Bug: 11073222
Change-Id: I89e1277f734d5959e33d61e7e9e7048084b9007a
 2013-12-04 11:57:45 +09:00
Ken Wakasa
64ead8d293 Merge "Add required header attributes for user/contacts dictionary." 2013-12-03 10:23:51 +00:00
Keisuke Kuroyanagi
8bfc8c46ff Add required header attributes for user/contacts dictionary. 
Bug: 11973488

Change-Id: I91ef720a24633aec0f4e81cd4f7c49c749805c49
 2013-12-03 19:22:17 +09:00
Jean Chalard
25848af556 Tiny refactoring 
Add a warning comment and make it so that openNative()
is only called in one place in the code.

Bug: 11281748
Change-Id: Ic7819a01deb62cf145ebf9d620da2d15fae19313
 2013-12-03 17:46:56 +09:00
Tadashi G. Takaoka
6d9e273fb5 Separate common config and dimensions resources 
Change-Id: Ia16880e818927bc3df7292e130b2f7b5efc9776e
 2013-12-03 12:14:27 +09:00
Keisuke Kuroyanagi
d1501ea789 Make contacts/user dictionary ver2. 
Change-Id: I10c29bd45fd37d765f115333087e1700dd90570b
 2013-12-02 21:59:56 +09:00
Jean Chalard
5fa4ad6a85 Merge "Fix some more tests" 2013-12-02 12:41:25 +00:00
Jean Chalard
ca5c7a9e14 Fix some more tests 
Bug: 11960453
Bug: 11954718
Change-Id: I71e98cc6ab30cc89e921e9ef578d7f6366049d01
 2013-12-02 21:05:26 +09:00
Tadashi G. Takaoka
770b00874b Remove KeyEventHandler 
Change-Id: Iddde1f85139cb21bde6e4fc275c32f3d62f4862f
 2013-12-02 20:25:25 +09:00
Tadashi G. Takaoka
5d311f2c13 Merge "Add config_ prefix to the resource names merged from dimens.xml" 2013-12-02 11:14:07 +00:00
Jean Chalard
576c753d25 Fix an obvious bug 
This had to be a typo

Change-Id: Id49e44d7667d64b00e883c55c683535398b6bdea
 2013-12-02 20:04:52 +09:00
Tadashi G. Takaoka
8c6052bce1 Add config_ prefix to the resource names merged from dimens.xml 
Change-Id: I6fb11b8cb52c06b805fb17d61450d7df50e4e20d
 2013-12-02 20:01:15 +09:00
Keisuke Kuroyanagi
545e4191b3 Merge "Quit recording LastUserHistoryWriteTime." 2013-12-02 10:10:32 +00:00
Keisuke Kuroyanagi
cffe4d2d0f Quit recording LastUserHistoryWriteTime. 
Change-Id: I0f2b408b4976d8119c932654e23836803d42c568
 2013-12-02 18:45:32 +09:00
Jean Chalard
9ab71eda83 Fix tests. 
This fixes a few bugs that became apparent with the
reinstating of a test.

Bug: 11954718
Change-Id: I1127bc3180f856566429f40d14c944e6f0007e09
 2013-12-02 18:15:22 +09:00
Tadashi G. Takaoka
9a0216def9 Avoid NPE by checking 
Bug: 11956240
Change-Id: I3de1ebbf96fa2422124e4d8e50190adfa09b8a49
 2013-12-02 16:25:20 +09:00
Jean Chalard
d7337a72bc Merge "Fix auto-detection of format 4." 2013-11-29 10:31:37 +00:00
Jean Chalard
26c9af33a7 Fix auto-detection of format 4. 
Bug: 11073222
Change-Id: I76e47d0399cf43fc3cc18cb1252f166be86b9a69
 2013-11-29 19:10:19 +09:00
Tadashi G. Takaoka
3f8c1d4a19 Clean up PointerTracker a bit 
Change-Id: I227501607ee1476c2f6faceca1c3c0833778a0ee
 2013-11-29 16:55:25 +09:00
Tadashi G. Takaoka
18ffeaba16 Use interfaces instead of MainKeyboardView class 
Change-Id: I760b107d804fc84153f08667f20061fedd308841
 2013-11-29 12:19:49 +09:00
Tadashi G. Takaoka
ccc86630a2 Rename StaticInnerHandlerWrapper to LeakGuardHandlerWrapper 
Change-Id: I024f0ee9c7f7718afc8a4ca0c6c49f2e88b035ad
 2013-11-29 12:15:40 +09:00
Keisuke Kuroyanagi
22e28d5a2d Merge "Add version check to open binary dictionary." 2013-11-28 11:52:59 +00:00
Keisuke Kuroyanagi
8ac3c65b00 Add version check to open binary dictionary. 
Bug: 11073222
Change-Id: Iabae12b8f14a9da3cdc804dcc6af443cedeb3f99
 2013-11-28 20:40:26 +09:00
Tadashi G. Takaoka
2e2af0e1e1 Merge "Move MainKeyboardView.KeyTimerHandler to top level class" 2013-11-28 10:21:41 +00:00
Tadashi G. Takaoka
3fd16cbaa8 Merge "Move MainKeyboardView.DrawingHandler to top level class" 2013-11-28 10:21:34 +00:00
Tadashi G. Takaoka
3c764b2e96 Move MainKeyboardView.KeyTimerHandler to top level class 
Change-Id: Iec310b7fc6127a8a5491dbb9f8f073e455e7ba29
 2013-11-28 19:03:37 +09:00
Jean Chalard
33e777fe08 Merge "Change the timing of reading the previous word." 2013-11-28 09:57:22 +00:00
Tadashi G. Takaoka
c82e99caa0 Move MainKeyboardView.DrawingHandler to top level class 
Change-Id: I7a785725d5eb0b594485ceb25695a89c017cc60f
 2013-11-28 18:56:15 +09:00
Jean Chalard
4866a3e918 Change the timing of reading the previous word. 
Bug: 11328842
Change-Id: I08229e895fc34403932648b9b931583d965f0e01
 2013-11-28 18:51:03 +09:00
Jean Chalard
177a86d394 Merge "Fix getNthPreviousWord." 2013-11-28 09:02:46 +00:00
Tadashi G. Takaoka
b1d87850ec Fix updating list preference summary for unknown value 
Change-Id: I86d3162a90e0068e787a906c0d3d64102487620a
 2013-11-28 14:12:29 +09:00
Jean Chalard
da459787e2 Fix getNthPreviousWord. 
This should take into accounts word connectors.

Change-Id: Ic7fa5c837cd65a43ba43d7ae9d299b8d20019892
 2013-11-28 11:41:23 +09:00
Keisuke Kuroyanagi
3c7b603c46 Merge "Start using Ver4 dictionary format." 2013-11-27 10:02:21 +00:00
Tadashi G. Takaoka
169d76cc5c Merge "Disable mic key on more keys when voice IME is disabled" 2013-11-27 09:56:42 +00:00
Tadashi G. Takaoka
b70a419a9e Disable mic key on more keys when voice IME is disabled 
Bug: 11883501
Change-Id: Ie3f496935f9600e2bde51cbebed2b4f8c90c25b2
 2013-11-27 18:36:08 +09:00
Jean Chalard
4735e1d32a Merge "Fix messages in tests" 2013-11-27 08:44:31 +00:00
Jean Chalard
dfc5aade2d Fix messages in tests 
They are not failing because of this right now, but future
tests would fail without this.
Concretely, since the Handler for any given main thread is
a singleton managed by the framework, the messages won't
be removed automatically. In particular, messages posted
with a delay have a large destructive potential, because
they will go through before the startInputViewInternal
method is called, because it's called with a message too (in
turn, this is because of working around framework bugs).

Bug: 11142685
Change-Id: If81a168efcfd7d93806ddc4ea432d438c45a3e1d
 2013-11-27 17:37:57 +09:00
Tadashi G. Takaoka
05e099d77d Remove voice-on-main related code and resources 
Change-Id: I3a1b06fa028dbf130c7aa2c83e9ec1a180aa1f5c
 2013-11-27 16:48:47 +09:00
Tadashi G. Takaoka
c144299f70 Merge "Remove compiler warnings from emoji related code" 2013-11-27 03:44:34 +00:00
Ken Wakasa
c01dba872c Small optimizations for single code point strings 
Change-Id: I299c7622db291ea411e2b48dfdb622b407912ea6
 2013-11-27 12:40:13 +09:00
Keisuke Kuroyanagi
02fd1a78a3 Start using Ver4 dictionary format. 
Bug: 11073222

Change-Id: Idd836ee15501e2f8c57c8eebc1fef7f103b01d18
 2013-11-27 12:14:03 +09:00
Tadashi G. Takaoka
6bd28dfa99 Remove compiler warnings from emoji related code 
Change-Id: I88ed0d25bee87c4dabcbc425589215b901345908
 2013-11-27 11:51:05 +09:00
Keisuke Kuroyanagi
fd15afae46 Merge "Extend jni interface to support time stamp and shortcut." 2013-11-27 02:17:51 +00:00
Keisuke Kuroyanagi
9cdca3255b Extend jni interface to support time stamp and shortcut. 
Bug: 11073222

Change-Id: I19e0501850917a13ddc756d3e78fc6f6cf3f33c4
 2013-11-26 21:31:26 +09:00
Tadashi G. Takaoka
091865a266 Merge "Cleanup SettingsFragment" 2013-11-26 09:38:41 +00:00
Tadashi G. Takaoka
98dd81ab80 Cleanup SettingsFragment 
Change-Id: Ic7dac203c17b34e1555ba2c91e3f8c057e85a4b5
 2013-11-26 18:36:21 +09:00
Jean Chalard
a6fef7dcae Merge "Fix caps mode upon gesture-after-type-period." 2013-11-26 07:34:59 +00:00
Keisuke Kuroyanagi
581ca435cf Merge "Implement addMultipleDictionaryEntries as a jni method." 2013-11-26 07:32:23 +00:00
Jean Chalard
045fb2de64 Fix caps mode upon gesture-after-type-period. 
Bug: 11630231
Change-Id: Id5626a2f5b7294e4fda0bf9b82ff85537500a104
 2013-11-26 16:25:09 +09:00
Keisuke Kuroyanagi
ca16be7552 Implement addMultipleDictionaryEntries as a jni method. 
Bug: 11757169

Change-Id: Ie1569e0b3c0503588ebfe5d09c7ca06116f54485
 2013-11-26 16:03:10 +09:00
Tadashi G. Takaoka
ad4216becd Use InputMethodSubtypeCompatUtils to create subtypes 
This change adds fixed subtypeId to dummy NO_LANGUAGE and EMOJI
subtypes.

Bug: 11142698
Change-Id: Ie633b5dea77f17a9981bd999df6e1957bde740ee
 2013-11-26 15:32:14 +09:00
Tadashi G. Takaoka
6f490fb200 Fix extraValue of DUMMY_NO_LANGUAGE_SUBTYPE 
This is a follow up of I9cf3d94825.

Change-Id: I2646a045d21f2a7a3bb89c76d431be844e739af3
 2013-11-26 13:31:18 +09:00
Jean Chalard
b68e613016 Merge "Fix a flaky test." 2013-11-25 08:53:47 +00:00
Jean Chalard
e629f860d1 Fix a flaky test. 
Corrections depend on the proximity info, which depends
on the layout, which in turn depends on the subtype and
not only the language. Thus, we need to force the whole
subtype for meaningful tests.

Bug: 11142685
Change-Id: I9cf3d948259e0236061454a93ffc2e28c7e0768f
 2013-11-25 17:22:15 +09:00
Jean Chalard
3e4c520dcf Merge "Fix a failing test" 2013-11-25 04:01:28 +00:00
Jean Chalard
a78b0f6b9e Fix a failing test 
Bug: 11846748
Change-Id: Ieda55477201c11fb31b0f84e70ecd081211c78fc
 2013-11-25 12:55:52 +09:00
Kurt Partridge
801d140176 Use Google Feedback 
Change-Id: Icc39898fc9216a91e5a75958a959aa52d0ccea73
 2013-11-22 18:02:18 -08:00
Tadashi G. Takaoka
2eea2d5007 Update Color Scheme summary explicitly 
Bug: 11622614
Change-Id: I5464054425e4d688eaa39f96ba9a3a3c613c6f42
 2013-11-22 17:26:59 -08:00
Tadashi G. Takaoka
ea8f8da1ac Fix unusual NPE after onDestroy 
Bug: 11673978
Change-Id: I4d5268312911685ff1ca9483a62442a1a9686c62
 2013-11-22 17:26:42 -08:00
Tadashi G. Takaoka
db86a6f271 Add keyboard color switch option 
Bug: 11622614
Change-Id: I25aa1ff7376fe72fd94ab2cb7190c61d7a98a1af
 2013-11-22 17:26:33 -08:00
Tadashi G. Takaoka
51352009b5 Add JB/ICS resources from Azuki MR1 release 
Bug: 11622614
Change-Id: I126fc42dd31e912788db0446b67a9d4ea80f848e
 2013-11-22 17:26:26 -08:00
Tadashi G. Takaoka
fe5262a70d Rename KLP theme related resources 
Bug: 11622614
Change-Id: I4e390aa263349d730b47502d84e4d528e7f5ce71
 2013-11-22 17:26:17 -08:00
Tadashi G. Takaoka
d5e6044ded Rename KLP/JB/ICS common resource name suffixes to _holo 
Bug: 11622614
Change-Id: I53b5ff8b6627a38aef352855ad024213a450b40f
 2013-11-22 17:26:08 -08:00
Tadashi G. Takaoka
585fa0491a Implement key preview zoom in/out animations 
Bug: 11518021
Change-Id: I139b18708055e0811234886578c5a30b8cc71fec
 2013-11-22 19:50:45 +09:00
Tadashi G. Takaoka
7c542558bf Merge "Update Color Scheme summary explicitly" 2013-11-22 10:33:30 +00:00
Tadashi G. Takaoka
b0b1982442 Update Color Scheme summary explicitly 
Bug: 11622614
Change-Id: I5464054425e4d688eaa39f96ba9a3a3c613c6f42
 2013-11-22 19:21:30 +09:00
Tadashi G. Takaoka
9eb8814931 Add configuration boolean for fading key top letter 
Bug: 11518021
Change-Id: I1297a258650f4b2f81b942bbfbfbc2dba686ef20
 2013-11-22 18:21:37 +09:00
Ken Wakasa
16d1e77a16 Merge "handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL" 2013-11-22 07:28:15 +00:00
Ken Wakasa
e255d5c0f7 Merge "handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL" into jb-ub-latinimegoogle-bayo 2013-11-22 07:26:57 +00:00
Ken Wakasa
89182e8fea handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL 
bug: 11797053
Change-Id: I295eeb5f9f0f1f07e919bf54122d003be150a174
 2013-11-21 17:48:09 +09:00
Ken Wakasa
87cd39124a handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL 
This is a fix only for the Bayo branch because this part in master has
been changed.

The corresponding fix in master is I295eeb5f9f0f1f07e919bf54122d003be150a174

bug: 11797053
Change-Id: I779be039ebf992de5d246c7a9d9509623fc3c120
 2013-11-21 17:47:05 +09:00
Keisuke Kuroyanagi
db4f373004 Fix: PtNode array size writirng when array size > 127. DO NOT MERGE. 
This is a manual cherrypick of Ib729ceedbc8ef837e50490439817b36039ae2b4e.

Bug: 11772864
Change-Id: I5ecbe729dbdd24e194e48b4d68b17af8549c4726
 2013-11-21 08:45:51 +00:00
Tadashi G. Takaoka
42d9980a84 Rename ambiguous feature name and related resources 
Bug: 11737015
Change-Id: I39f7ca13b99f019a2edb5aa690e3142ceba4e837
 2013-11-21 10:52:53 +09:00
Keisuke Kuroyanagi
d39371e231 Merge "Fix: PtNode array size writirng when array size > 127." 2013-11-20 10:07:19 +00:00
Keisuke Kuroyanagi
680f66023c Fix: PtNode array size writirng when array size > 127. 
Bug: 11772864
Change-Id: Ib729ceedbc8ef837e50490439817b36039ae2b4e
 2013-11-20 18:15:59 +09:00
Tadashi G. Takaoka
d088e0e726 Merge "Don't draw key top letter when key preview is showing" 2013-11-20 08:42:34 +00:00
Tadashi G. Takaoka
818ece917f Don't draw key top letter when key preview is showing 
Bug: 11518021
Change-Id: Ibd33e892b21189a7d044099942845379aa010484
 2013-11-20 17:26:02 +09:00
Tadashi G. Takaoka
3a1be7e4cf Merge "Unbundle Key preview text and PointerTracker" 2013-11-20 05:46:25 +00:00
Tadashi G. Takaoka
e9ec4d1add Merge "Fix more keys keyboard display position" 2013-11-20 05:46:17 +00:00
Tadashi G. Takaoka
f914f8814c Unbundle Key preview text and PointerTracker 
This change binds key preview text with Key.

Bug: 11518021
Change-Id: I5028e1108d6a5728e4feac7f6f945453eea679b6
 2013-11-20 14:09:29 +09:00
Keisuke Kuroyanagi
dd0da393e1 Add DEBUG_DUMP to ContactsBinaryDictionary. 
Change-Id: Iebfae5f37727deeb6636ad6301b7b1bbe5f454e0
 2013-11-20 14:07:44 +09:00
Tadashi G. Takaoka
0381415423 Fix more keys keyboard display position 
This is a follow up of Ia39b3d6de8.

Change-Id: I9e6152fdc5cb9fa9490b41fcf0420b9ffccea438
 2013-11-20 14:00:03 +09:00
Satoshi Kataoka
994530d9bd Show source dictionary name of suggestions in the debug mode 
Bug: 11772864
Change-Id: I393352494b1ef81d24622a22fe7556d09945d6ff
 2013-11-20 12:31:01 +09:00
Keisuke Kuroyanagi
077b3def52 Merge "Create a method to add multiple dictionary entries." 2013-11-19 09:41:14 +00:00
Keisuke Kuroyanagi
da2ccbd4cd Create a method to add multiple dictionary entries. 
Bug: 11740462
Change-Id: I7903cb02fd08d649a05b8799fb3cd00c3da26e00
 2013-11-19 18:12:07 +09:00
Keisuke Kuroyanagi
eacb44b38d Show amanatto settings only when in debug mode. 
Bug: 11740462
Change-Id: I206b16ab785215c6fa64e740a6dd46588c633ec8
 2013-11-19 14:40:20 +09:00
Kurt Partridge
0a51c2b657 Merge "Track selection end in RichInputConnection" 2013-11-16 00:55:43 +00:00
Kurt Partridge
d564466d30 Track selection end in RichInputConnection 
Change-Id: Ie5cffe03b676dcde83896cda139b42f3829eb528
 2013-11-15 16:49:24 -08:00
Tadashi G. Takaoka
2cbcc987ee Merge "Fix unusual NPE after onDestroy" 2013-11-15 09:03:51 +00:00
Tadashi G. Takaoka
ffb064656e Fix unusual NPE after onDestroy 
Bug: 11673978
Change-Id: I4d5268312911685ff1ca9483a62442a1a9686c62
 2013-11-15 17:48:10 +09:00
Tadashi G. Takaoka
be734d298a Return copied String array from getStringArray method 
In the Key class constructor, elements in a String[] instance returned
from DeclaredKeyStyle.getStringArray() may be altered by
KeySpecParser.get(Int|Boolean)Value methods.

Bug: 11245712
Change-Id: I3a7fc5ccdb2a14efb72c402dd11559ab13e08596
 2013-11-15 17:19:23 +09:00
Kurt Partridge
2bf3a77814 Rename mExpectedCursorStart to mExpectedSelStart 
Change-Id: If23d8bd73fe464f12f473e093dc87ed68756e1ec
 2013-11-14 07:45:02 -08:00
Kurt Partridge
a2632aabf7 Merge "Extract method to reloadTextCache()" 2013-11-14 15:28:07 +00:00
Tadashi G. Takaoka
f7bb78fb58 Merge "Add keyboard color switch option" 2013-11-14 09:33:09 +00:00
Tadashi G. Takaoka
4c8a96cf88 Merge "Fix additional subtype id calculation" 2013-11-14 09:04:33 +00:00
Tadashi G. Takaoka
053424e56e Merge "Add StringUtils.joinCommaSplittableText" 2013-11-14 09:04:24 +00:00
Tadashi G. Takaoka
b4c7a10840 Add keyboard color switch option 
Bug: 11622614
Change-Id: I25aa1ff7376fe72fd94ab2cb7190c61d7a98a1af
 2013-11-14 17:56:07 +09:00
Tadashi G. Takaoka
1d1db42d89 Fix additional subtype id calculation 
Bug: 11678247
Change-Id: I4a2061fae264473e1ebff6961aa897367ef9cc09
 2013-11-14 17:45:53 +09:00
Tadashi G. Takaoka
6589751ace Add StringUtils.joinCommaSplittableText 
Change-Id: I80ad9d8b5aee53f1403486a56ffae8d09cbd4e28
 2013-11-14 17:43:03 +09:00
Keisuke Kuroyanagi
97fdb184bc Purge ExpandableDictionary. 
Bug: 11245133
Change-Id: Ia0886686d8add940409dcd5c883c34eb5289380d
 2013-11-14 14:18:02 +09:00
Jean Chalard
3a9b2430a5 Fix many small nits. 
...the interaction of which results in a very bad bug.

Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
 2013-11-12 22:44:59 -08:00
Jean Chalard
e4022137ee Remove an out-of-place check 
Bug: 11584525
Change-Id: I76cc3e4ee21d62fbd56042adcf085efd5cafb53f
 2013-11-12 22:44:58 -08:00
Jean Chalard
5a0bc6ac69 Fix many small nits. 
...the interaction of which results in a very bad bug.

Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
 2013-11-13 14:42:27 +09:00
Tadashi G. Takaoka
d7d6088130 Revert back punctuations to the more keys keyboard of the period 
Cherry-pick I157164910f from Master.

Bug: 11621857
Change-Id: I0fd0496e9091165280f34b4640ff0e524e3847b9
 2013-11-12 17:51:54 +09:00
Tadashi G. Takaoka
a2a1096406 Revert back punctuations to the more keys keyboard of the period 
Bug: 11621857
Change-Id: I157164910fc6f23ef36c838d0a13792c766be223
 2013-11-12 14:46:40 +09:00
Tadashi G. Takaoka
1c95c8ba3b Add JB/ICS resources from Azuki MR1 release 
Bug: 11622614
Change-Id: I126fc42dd31e912788db0446b67a9d4ea80f848e
 2013-11-12 13:04:47 +09:00
Tadashi G. Takaoka
c10757e8e8 Rename KLP theme related resources 
Bug: 11622614
Change-Id: I4e390aa263349d730b47502d84e4d528e7f5ce71
 2013-11-11 20:01:00 +09:00
Tadashi G. Takaoka
4b37b2b3f6 Rename KLP/JB/ICS common resource name suffixes to _holo 
Bug: 11622614
Change-Id: I53b5ff8b6627a38aef352855ad024213a450b40f
 2013-11-11 19:08:07 +09:00
Jean Chalard
af8df16887 Remove an out-of-place check 
Bug: 11584525
Change-Id: I76cc3e4ee21d62fbd56042adcf085efd5cafb53f
 2013-11-08 20:32:43 +09:00
Tadashi G. Takaoka
541fa7858d Add keyLabelHintVerticalAdjustment attribute 
Bug: 11546184
Change-Id: I1fbdbbdcf4d6a74888c48f2e4f0b7afce7913653
 2013-11-07 19:29:23 +09:00
Tadashi G. Takaoka
4d49908682 Move reference char/digit width/height method to TypefaceUtils 
Change-Id: I3c94c23c31b273a07e145d381587ab0aa4ee8e68
 2013-11-07 18:39:42 +09:00
Tadashi G. Takaoka
0a4f4b2bbd Add autoScale Key attribute 
Bug: 11546184
Change-Id: I754e98dbc0689dbf14c52d4906141a150bde97a6
 2013-11-07 16:56:37 +09:00
Kurt Partridge
4e1f8be3e5 Extract method to reloadTextCache() 
Change-Id: Ibdaa9553cafeded15f800077606378b06af755cb
 2013-11-06 23:43:56 -08:00
Tadashi G. Takaoka
0ea72c8519 Separate action key labels to strings-action-keys.xml 
Bug: 11562208
Change-Id: I70390f9eafe51f16ff47b2e39454d1948a259469
 2013-11-07 15:12:55 +09:00
Tadashi G. Takaoka
aaf532e641 Fix possible RuntimeException in parsing saved addtional subtypes 
Bug: 11488129
Change-Id: I91f333aee9f3ae8d4b1d5e67d47de30f361947f3
 2013-11-06 17:16:24 +09:00
Tadashi G. Takaoka
463674f950 Merge "Remove unused vertical scrollable KeyboardView" 2013-11-05 10:26:14 +00:00
Tadashi G. Takaoka
78d2895c8d Remove unused vertical scrollable KeyboardView 
Bug: 11517736
Change-Id: I9d71290112c2306336e136c94b628b533e386aaa
 2013-11-05 19:15:20 +09:00
Keisuke Kuroyanagi
9b3e59d644 Implement ver4 bigram reading method. 
Bug: 11073222
Change-Id: I7b3408938f304da361201892e0a1342fdf92e62e
 2013-11-05 16:00:26 +09:00
Keisuke Kuroyanagi
67cff29fd4 Merge "Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting." 2013-10-29 04:48:05 +00:00
Keisuke Kuroyanagi
82c962f1e0 Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting. 
Change-Id: I1bfeeafa002496bb98a385b87437e7f4eb0f6e1d
 2013-10-28 21:46:05 -07:00
Satoshi Kataoka
40a3712a4c Merge "Show version in dumped info" 2013-10-29 02:43:09 +00:00
Satoshi Kataoka
5982b1ea08 Show version in dumped info 
Bug: 10315296
Change-Id: Icb8e271451f4f9c5b083bfb5eb408372479c2140
 2013-10-28 19:22:20 -07:00
Keisuke Kuroyanagi
388c953613 Fix tests by adding @UsedForTesting. 
Change-Id: I5b98db67a083bde65bb0f2fb714ae2e799fb1d45
 2013-10-28 17:16:01 -07:00
Satoshi Kataoka
ba212e9d76 Add a facility to dump the dictionary contents while closing 
Change-Id: I02e920e0512f2b46a778f0b23f7ca03f8d5dabe6
 2013-10-28 11:25:38 -07:00
Keisuke Kuroyanagi
8e9df884aa Add a test for ver4 native binary dictionary. 
Bug: 10197478
Bug: 11073222
Change-Id: I6daac6c4b048c65682c25afe6ca0fad83cc9720f
 2013-10-25 12:32:30 -07:00
Jean Chalard
8a1675379e Stopgap solution for a crash. 
This returns the wrong string, but since it's used for getting the
previous word for bigrams, it only results in slightly worse
suggestions quality.

Bug: 11273655
Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
 2013-10-22 05:23:48 -07:00
Jean Chalard
5b5ed3d609 Fix a bug where autocaps would jam auto-commit 
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
 2013-10-22 05:23:48 -07:00
Keisuke Kuroyanagi
6bc5acaa79 Fix: Suggested words from user history are invalid. 
- Suggestions form user history can contain invalid words.
- isValidWord always returns false.

Bug: 11139426
Change-Id: I6075b275603332ddb00f4a9284afcaa82d824270
 2013-10-22 05:23:48 -07:00
Jean Chalard
7da2295328 Fix a bug where autoshift would be ignored coming from emoji 
Bug: 11123691
Change-Id: I36474e12e34af95051129840865015f85595411b
 2013-10-22 05:23:47 -07:00
Jean Chalard
d4b5bc1695 Merge "Preliminary refactor" 2013-10-22 11:26:54 +00:00
Jean Chalard
b00ed46385 Preliminary refactor 
Bug: 11328842
Change-Id: I7c22e951fef9bc4443c6b64625e25f632f876ab1
 2013-10-22 20:16:17 +09:00
Jean Chalard
729abe6332 Stopgap solution for a crash. 
This returns the wrong string, but since it's used for getting the
previous word for bigrams, it only results in slightly worse
suggestions quality.

Bug: 11273655
Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
 2013-10-22 20:00:09 +09:00
Jean Chalard
c130be8779 Add a sequence number to SuggestedWords. 
This allows testing for suggestion freshness in an asynchronous
suggestions world.

In-advance cherrypick of Ic76cd17568598d8534aec81e037f9e37f52eb6b4
because there's a merge conflict.

Bug: 11301597
Change-Id: I4aec765a975298fcac30a48dede73d2622224fe5
 2013-10-22 13:19:16 +09:00
Jean Chalard
926ebe849a Merge "Add a sequence number to SuggestedWords." 2013-10-22 04:02:11 +00:00
Jean Chalard
ac76463306 Add a sequence number to SuggestedWords. 
This allows testing for suggestion freshness in an asynchronous
suggestions world.

Bug: 11301597
Change-Id: Ic76cd17568598d8534aec81e037f9e37f52eb6b4
 2013-10-22 12:52:58 +09:00
Jean Chalard
c6a121805f Fix a bug where autocaps would jam auto-commit 
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
 2013-10-22 12:39:49 +09:00
Ken Wakasa
513b99dfa2 Cosmetic fixes 
Change-Id: I44ac89edaba2e57bd1b7e091ff74b77a5e598f2f
 2013-10-21 15:53:49 +09:00
Yuichiro Hanada
52f18d7f40 Change the block sizes for SparseTables. 
This change saves about 240k bytes.

Bug: 10941472
Change-Id: Ieb00e4dd3391cdb0d42d705f8d0a7b1421f516f9
 2013-10-18 20:28:07 +09:00
Keisuke Kuroyanagi
8e9af925b1 Merge "Fix: Suggested words from user history are invalid." 2013-10-18 11:05:03 +00:00
Keisuke Kuroyanagi
53686e0f5f Fix: Suggested words from user history are invalid. 
- Suggestions form user history can contain invalid words.
- isValidWord always returns false.

Bug: 11139426
Change-Id: I6075b275603332ddb00f4a9284afcaa82d824270
 2013-10-18 19:53:57 +09:00
Satoshi Kataoka
7fdb2c2956 Merge "Change the numbering order of terminal IDs." 2013-10-18 10:31:27 +00:00
Yuichiro Hanada
9ae7d37108 Change the numbering order of terminal IDs. 
Change-Id: I85a6b6e948ee0de012eef2f9f841240cbca63947
 2013-10-18 19:16:11 +09:00
Yuichiro Hanada
2b7110ff1f (2/2) Implement insertWord in Ver4DictUpdater. 
Change-Id: I2328a9df0a009b564e8acaf4180f9b0c1ed0901a
 2013-10-18 18:03:44 +09:00
Yuichiro Hanada
19b247e79d Fix the name of the argument of writeString. 
Change-Id: I76916914f1402913daa56dd5387fe82e42287989
 2013-10-18 17:33:10 +09:00
Yuichiro Hanada
520f612849 (1/2) Implement insertWord in Ver4DictUpdater. 
Change-Id: Ia3079d5ef00ca7d831c91fb9220ad9c17038c5a3
 2013-10-18 16:42:59 +09:00
Jean Chalard
0f45e1bfbc Fix a bug where autoshift would be ignored coming from emoji 
Bug: 11123691
Change-Id: I36474e12e34af95051129840865015f85595411b
 2013-10-17 22:58:34 +09:00
Jean Chalard
578e9b91c1 Merge "Remove useless code." 2013-10-17 06:56:12 +00:00
Jean Chalard
8447409c77 Merge "Remove mIsExpectingUpdateSelection." 2013-10-17 06:55:54 +00:00
Yuichiro Hanada
ad5b9bcec2 Add readVer4PtNodeInfo to Ver4DictDecoder. 
Change-Id: Ibffaf64a9bda1fb0779a9b53558ca56ed31660d3
 2013-10-17 14:37:04 +09:00
Yuichiro Hanada
36dd126ab4 Add ShortcutContentReader. 
Change-Id: I7c2d0d86d85775065a9bcb2b4a8463bb4969579e
 2013-10-17 11:11:29 +09:00
Jean Chalard
548716d6d9 Remove useless code. 
The only use of mDeleteCount is to implement delete
acceleration. It's reset at each non-delete code point, and
is guarded by a timer.
Plus, ultimately we want to remove this completely :
acceleration should be implemented by actually deleting
stuff faster, not by deleting several code points at a time.

Change-Id: Ia3144860b3aa2499034f2a2a7c81f32087af9598
 2013-10-16 18:43:15 +09:00
Jean Chalard
5731b86b88 Merge "Remove unneeded code." 2013-10-16 09:41:44 +00:00
Jean Chalard
1194b2b204 Remove mIsExpectingUpdateSelection. 
Bug: 11226045
Change-Id: I043f90ba92989bd8307c978eb32630439f63a0b9
 2013-10-16 18:39:20 +09:00
Jean Chalard
497976e09b Remove unneeded code. 
We don't support LOG_FULL_TEXTVIEW_CONTENTS any more, nor do
we have any plans to support it again in the future.

This also is a prelude to removing mIsExpectingUpdateSelection.

Bug: 11226045
Change-Id: Ib68c6daf52993b87225a7ea9e71a414caaecfdb7
 2013-10-16 18:36:16 +09:00
Yuichiro Hanada
098639d99f Add SparseContentTableReader. 
Change-Id: I976afc5d320bc65835d659bae1d10d2cdc68262b
 2013-10-16 17:24:59 +09:00
Yuichiro Hanada
7b5f2b71f5 Fix Ver4DictDecoder.readAndFollowForwardLink(). 
Change-Id: Ib527a376b693be21aebd4920ac804ee9b161eb96
 2013-10-16 17:16:26 +09:00
Ken Wakasa
008d84ffa5 Merge "Fix readAndFollowForwardLink." 2013-10-16 07:48:30 +00:00
Ken Wakasa
6b7037fa68 Merge "Extract SparseTableContentWriter." 2013-10-16 07:34:03 +00:00
Yuichiro Hanada
ed831f38db Extract SparseTableContentWriter. 
Change-Id: I9a58e53317654f8a09fbe79044214de3e9c59eb7
 2013-10-16 09:53:30 +09:00
Yuichiro Hanada
1557de7aa4 Consolidate CharEncoding.writeString and BinaryDictIOUtils.writeString. 
Change-Id: I6f990fd84e7f08fd1149198c33d8bbf1cac8e078
 2013-10-16 00:30:45 +09:00
Yuichiro Hanada
522dc0d8ac Fix readAndFollowForwardLink. 
Change-Id: Ifda44e6139a4a1bd065468a7f74cd9483b343644
 2013-10-16 00:16:39 +09:00
Ken Wakasa
b067be0e5f Merge "Revert "Revert "Add Swiss French and German keyboard layouts.""" 2013-10-15 14:12:29 +00:00
Ken Wakasa
b044047227 mExpectingUpdateSelection was out of sync when nothing to delete. 
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)

This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
 2013-10-15 14:05:34 +09:00
Ken Wakasa
cf5dfd2464 am 3a3bbf4a: am eed74b81: am c8383eda: Fix wrong commitText parameter in sendKeyCodePoint() 
* commit '3a3bbf4a38870ecc42b7f6fbd3a7cae20fe020a7':
  Fix wrong commitText parameter in sendKeyCodePoint()
 2013-10-14 10:52:40 -07:00
Ken Wakasa
c8383eda8b Fix wrong commitText parameter in sendKeyCodePoint() 
Small optimization on generating a String instance from a single code
point too.

bug: 11181913

Change-Id: I0f905e4dc6ec7841092bb4d3d940daf3b2303f5b
 2013-10-13 10:56:10 +09:00
Ken Wakasa
fe97ff4083 am 60fb5865: am 06e1bdaa: am 3e35e072: Merge "Make emoji separators" into klp-dev 
* commit '60fb58654e33448651fea191ba22cfdc87e37466':
  Make emoji separators
 2013-10-11 05:10:21 -07:00
Satoshi Kataoka
eb7fa4dc6d am 40506273: am ac6d0c65: am 6d915037: Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev 
* commit '405062733cfe066c4b9af719bfc36a9a516c9dd3':
  Fix a bug where emojis would remove the suggestion strip.
 2013-10-11 05:10:19 -07:00
Ken Wakasa
3e35e0727c Merge "Make emoji separators" into klp-dev 2013-10-11 11:57:07 +00:00
Satoshi Kataoka
6d91503727 Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev 2013-10-11 11:53:07 +00:00
Jean Chalard
6fc15b9fc4 Fix a bug where emojis would remove the suggestion strip. 
Bug: 11163495
Change-Id: I23d12c430125cc2a66a6e00715a4c609bb9e2bb1
 2013-10-11 20:51:13 +09:00
Jean Chalard
401fb908f0 Make emoji separators 
Bug: 11163495
Change-Id: I3247b8d1bbd3406b29a30a25aebd932c63431943
 2013-10-11 20:00:38 +09:00
Ken Wakasa
7abdab1c6f Merge "Add a time stamp for unigrams." 2013-10-11 10:17:01 +00:00
Jean Chalard
3def959e4d am 3f1c95db: am 331c84d7: am 5fe9ab1c: Merge "Fix the suggestion size." into klp-dev 
* commit '3f1c95dbdc18453dc0cd6f847b33e01db1f1d75b':
  Fix the suggestion size.
 2013-10-11 01:49:51 -07:00
Jean Chalard
5fe9ab1cc6 Merge "Fix the suggestion size." into klp-dev 2013-10-11 08:38:31 +00:00
Ken Wakasa
be22a01df3 Merge "Add resolveBigramPositions." 2013-10-11 07:45:20 +00:00
Jean Chalard
c0bd0a244d Fix the suggestion size. 
The available space was not computed correctly. This makes the
decision to ellipsize/expand the middle suggestion correct.

Also, the scale was not applied correctly in some cases.

Finally, for some reason ellipsize does not work as we expect.
I'm not sure how to get it to work like we want it to, but
this works around the problem in a simple manner.

Bug: 11158757
Change-Id: I083e7ac56e157f100923733e67b92a6368a526c9
 2013-10-11 16:42:46 +09:00
Satoshi Kataoka
7611af753a Merge "Do not merge. Save / restore the last used emoji category" into klp-dev 2013-10-11 07:21:35 +00:00
Satoshi Kataoka
7d3f53a1cb Do not merge. Save / restore the last used emoji category 
Bug: 11029983
Change-Id: I5547910c7b5dd7974292fc075af33568940f4e81
 2013-10-11 16:05:38 +09:00
Satoshi Kataoka
6026a95816 Merge "Save / restore the last used emoji category" 2013-10-11 07:04:42 +00:00
Satoshi Kataoka
6dc99dc200 Save / restore the last used emoji category 
Bug: 11029983
Change-Id: I1bec2c3c6b547de68562a818a8d6c9fef83787b7
 2013-10-11 16:00:33 +09:00
Yuichiro Hanada
c32962b8f1 Add a time stamp for unigrams. 
Bug: 10920255
Change-Id: I26d2cce3c322a4ff39a614f8615f43fb7bd3baed
 2013-10-11 15:08:09 +09:00
Yuichiro Hanada
9514ed5c2a Add the new format of bigram entries. 
In new format, each bigram entry has flags (1 byte), a terminal id (3 byte),
a time-stamp (4 byte), a counter (1 byte) and a level (1 byte).

Bug: 10920255
Bug: 10920165
Change-Id: I0f7fc125a6178e6d25a07e8462afc41a7f57e3e1
 2013-10-11 14:50:41 +09:00
Jean Chalard
7e6ac9d727 Allow double-space-to-period after percent 
Bug: 11158604
Change-Id: If8c94ef91ed58bb5028f51be7c8d9beb677436a4
 2013-10-10 21:26:08 +09:00
Ken Wakasa
6dac27eeb4 Merge "Tweak vertical gap of Emoji palette. DO NOT MERGE" into klp-dev 2013-10-10 03:39:30 +00:00
Satoshi Kataoka
3a9ae65525 Tweak vertical gap of Emoji palette. DO NOT MERGE 
cherrypick of I8163568a9d7f9d321148001e161c672f78796c96

Bug: 11140087
Change-Id: Ifd28f3017a8cf568a8c4a1045811564a129d85b7
 2013-10-10 11:29:08 +09:00
Satoshi Kataoka
557a0935d4 Retry to tweak punctuations. DO NOT MERGE 
cherrypick of I9ffc457ca44bccfa3eb3bdb0c26535d795215b26

Bug: 11130808
Change-Id: I1a65fd8acc4efe9b4e4786a3dc959498ae63c2f8
 2013-10-10 11:14:37 +09:00
Ken Wakasa
856b06a3ac Revert "Revert "Add Swiss French and German keyboard layouts."" 
This reverts commit 56402cf10a.

I'll submit this on 10/16 after the final cut for Bayo.

Change-Id: I0fe4ab64fd8dfa1e63e29adf00388743fca6a1ed
bug: 11144401
 2013-10-10 02:07:04 +00:00
Ken Wakasa
56402cf10a Revert "Add Swiss French and German keyboard layouts." 
This reverts commit 220ce8f269.

Sorry, but we are now in the week before the final cut for the next launch. We shouldn't be taking new features like this at this point. Let me revert this change for now. I'll re-revert this after the cut next week.

Change-Id: Ia8b00680c992ec526e6a858945f2380cbcdfdd55
 2013-10-10 02:05:50 +00:00
Fredrik Roubert
220ce8f269 Add Swiss French and German keyboard layouts. 
There used to be two "Swiss" keyboard layouts, labelled fr_CH and de_QY,
available in LatinIME. They were, however, not actually Swiss layouts
but instead work-arounds to be able to get French or German with qwertz
or qwerty (instead of azerty and qwertz) layouts, respectively. These
were thus removed by commit f6972561fc
replacing them with the generic fr-qwertz and de-qwerty layouts instead.

Here, now, is a proper Swiss keyboard layout, following Swiss standards
for people accustomed to typing on Swiss keyboards, with the expected
tailorings for French and German.

Change-Id: I9feed752053ecc694c84db713284f69bc1daf155
 2013-10-09 17:42:17 +02:00
Satoshi Kataoka
a6a6abc816 Fix the security related API change for PreferenceActivity 
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
 2013-10-09 02:59:32 -07:00
Satoshi Kataoka
6862b8192d Fix crash in AdditionalSubtypeUtils 
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
 2013-10-09 02:59:26 -07:00
Yuichiro Hanada
67c758f160 Add resolveBigramPositions. 
Bug: 11073222
Change-Id: I680e4304c6ab701e9aa132e1e140d789097a53ae
 2013-10-09 17:39:22 +09:00
Satoshi Kataoka
56997a80c2 Retry to tweak punctuations 
Bug: 11130808
Change-Id: I9ffc457ca44bccfa3eb3bdb0c26535d795215b26
 2013-10-09 15:39:23 +09:00
Satoshi Kataoka
30ef03d865 Tweak vertical gap of Emoji palette 
Bug: 11140087
Change-Id: I8163568a9d7f9d321148001e161c672f78796c96
 2013-10-09 14:56:39 +09:00
Satoshi Kataoka
83994ad66b Merge "Fix the security related API change for PreferenceActivity" 2013-10-09 05:46:15 +00:00
Satoshi Kataoka
64f64bdf58 Fix the security related API change for PreferenceActivity 
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
 2013-10-09 14:34:06 +09:00
Jean Chalard
dfaec34502 Merge "Always call finishComposingText before recapitalization" 2013-10-09 05:18:01 +00:00
Jean Chalard
e306d292eb Merge "Remove a useless IPC call." 2013-10-09 05:17:51 +00:00
Satoshi Kataoka
50f9ca4acd Fix crash in AdditionalSubtypeUtils 
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
 2013-10-09 12:50:50 +09:00
Jean Chalard
f178685c11 Always call finishComposingText before recapitalization 
Workaround for framework bug:
Bug: 10792236

Change-Id: I3706b9eed5223889791840e30660f8d17625cb70
 2013-10-09 12:15:21 +09:00
Jean Chalard
27d78643e8 Remove a useless IPC call. 
This is not useful because we're going to call setSelection again
with different values on the connection right away.

Also a preliminary change for
Bug: 10792236

Change-Id: I46c6ef1fbb3624086099bf81afddb0ef5ae85661
 2013-10-09 12:11:28 +09:00
Satoshi Kataoka
de65b7c0b3 Merge "Fix the position of emoji palette" 2013-10-08 12:04:03 +00:00
Satoshi Kataoka
f981fe7ed2 Fix the position of emoji palette 
Change-Id: I07a3912cb9fef8e28f3605de4e73a201a900e95c
 2013-10-08 21:00:43 +09:00
Ken Wakasa
c040d59def Merge "Add more_keys_for_* declarations for the Swedish keyboard." 2013-10-08 11:44:54 +00:00
Fredrik Roubert
a30884e0e0 Add more_keys_for_* declarations for the Swedish keyboard. 
This adds all those popup keys that were included in commit
b1cb13292f when the Swedish keyboard was
first added. Many of these definitions were later removed by commit
79b965e04f but most likely by mistake, as
that commit log message doesn't mention anything about removing these.

To help making this file more maintainable, this commit also moves a few
definitions around so that all definitions now appear in alphabetical
order.

Change-Id: Iadef9e3dd1dc7b39fe87b2fc75210d0697b24361
 2013-10-08 13:28:08 +02:00
Satoshi Kataoka
a701501cb6 Merge "Reduce memory of emoji palette" 2013-10-08 11:22:21 +00:00
Satoshi Kataoka
0e01df9baf Reduce memory of emoji palette 
Bug: 10902556
Change-Id: I3c8da35a601de2bfb248292c7b59235fc1120988
 2013-10-08 20:11:35 +09:00
Jean Chalard
92190d9a75 Merge "Show the keyboard earlier when rotating." 2013-10-08 10:14:41 +00:00
Satoshi Kataoka
2d3e121014 Fix memory leak in EmojiPaletteView 
Bug: 10902556
Change-Id: I3a8c1e08d6f953b462d914acd1f411c36f9d80f2
 2013-10-08 19:05:00 +09:00
Ken Wakasa
d900b90db7 Merge "Prep for RAM footprint optimization for Emoji palettes" 2013-10-08 08:11:53 +00:00
Ken Wakasa
8cf2a5e59f Prep for RAM footprint optimization for Emoji palettes 
bug: 10902556
Change-Id: I313948c73b60cd33c437cf02e8d3fb61c288a240
 2013-10-08 17:09:24 +09:00
Jean Chalard
482aa129e4 Show the keyboard earlier when rotating. 
Bug: 11107229
Change-Id: I0b36341d60b634a860eb13fafd0dc69fe734bdeb
 2013-10-08 16:33:27 +09:00
Jean Chalard
10581e68af Make the sentence separator a resource. 
This will help handing correctly the armenian full stop.

Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
 2013-10-08 15:28:43 +09:00
Satoshi Kataoka
984aa60e11 Merge "Extend hitbox of emoji keys" 2013-10-07 23:27:07 +00:00
Satoshi Kataoka
5d27cb9397 Extend hitbox of emoji keys 
Bug: 11105065
Change-Id: I5e90ba55cf708bf7be27d7d101cbc0719ac583c8
 2013-10-07 23:22:12 +09:00
Jean Chalard
7712baa59b Merge "Fix a possible IOOB" 2013-10-07 14:21:00 +00:00
Jean Chalard
ca9c3c0613 Fix a possible IOOB 
We want to use StringUtils here, but it's full of references to
stuff not accessible host-side like JsonReader and TextUtils
and SettingsValues :/

Bug: 11061476
Change-Id: I3c0194979833ede283b4f9190335dba5376fe6fc
 2013-10-07 23:16:57 +09:00
Jean Chalard
3c4e8cb693 Call loadKeyboard later if it can't be called right away 
Since loadKeyboard relies on the input connection being
available to give it the auto-caps state, but also can't
be called twice in a row because it needs to save and
restore its state and invalidates it after the restore,
we need to wait until we know we have a valid input
connection to call it.

Bug: 11107229
Change-Id: I1c7baf3215682df6f6ceb357bd37254f9e7418c7
 2013-10-07 22:57:59 +09:00
Satoshi Kataoka
291ef1c9c3 Merge "Clear the cache of subtypes in onStartInputViewInternal" 2013-10-07 11:19:47 +00:00
Satoshi Kataoka
4be5f221e6 Clear the cache of subtypes in onStartInputViewInternal 
Bug: 11077905
Change-Id: I9495f13a20edca0e6153cd1a7a0ac6891f707c59
 2013-10-07 20:10:58 +09:00
Jean Chalard
86f7711407 Merge "Don't auto-correct to non-whitelist shortcuts" 2013-10-07 10:04:18 +00:00
Jean Chalard
f309f2288b Don't auto-correct to non-whitelist shortcuts 
Bug: 11076722
Change-Id: I0de10ab24d33ec31f45664fe92d80d5a7bec9c20
 2013-10-07 19:01:57 +09:00
Jean Chalard
a6047aae94 Merge "Set the shortcut frequency correctly." 2013-10-07 10:00:34 +00:00
Jean Chalard
f3204eebb1 Set the shortcut frequency correctly. 
14 is the right value.

Bug: 11076722
Change-Id: I95d404b540f7fbe4932d1f8498cde23f1df0314f
 2013-10-07 18:55:42 +09:00
Keisuke Kuroyanagi
be4d85feb0 Merge "Fix bug and Add large test for decaying dictionary." 2013-10-07 09:32:56 +00:00
Jean Chalard
7da62bbe24 Merge "Remove suggestions when string contains a period" 2013-10-07 08:34:52 +00:00
Keisuke Kuroyanagi
cfb018ba6d Fix bug and Add large test for decaying dictionary. 
- GC gets failure when the dictionary become empty.
- Useless unigrams are sometimes not removed.

Bug: 10197478
Change-Id: I8d1479c01efba61a81f03bc077da6bcb4797a940
 2013-10-07 17:31:01 +09:00
Jean Chalard
df33982fce Remove suggestions when string contains a period 
This is not the right way to do it, but it's simple and will kill the
regression. We should investigate why the return values are
wrong in this case.

Bug: 10780091
Change-Id: I808727242c9cb1598df00a7426358dc3a658add4
 2013-10-07 17:27:27 +09:00
Satoshi Kataoka
4746217247 Enter -> Alpha keyboard switcher in Emoji palette view 
Bug: 11103091
Change-Id: I0c5384e9f148566d1ac1d178a8227eb913d59908
 2013-10-07 17:05:54 +09:00
Satoshi Kataoka
4deb824f3a Add navigateEmoji 
Bug: 11074625
Change-Id: I1ef6b81ef923684b502c24fddb4ced8fe1691733
 2013-10-07 15:28:39 +09:00
Satoshi Kataoka
e6e4c70a23 Fix build 
Change-Id: I61341aa7b1ceb311aaa5faa5888ba31e463a95d5
 2013-10-07 12:48:14 +09:00
Satoshi Kataoka
d76b552979 Rename EmojiKeyboardView -> EmojiPalettesView 
Change-Id: I226bb8e21fd2b2b6639896a1cc433d19f3f431c2
 2013-10-07 12:28:13 +09:00
Jean Chalard
423921ca13 Merge "Fallback on empty locales." 2013-10-04 13:44:44 +00:00
Jean Chalard
5db7eabafb Merge "Accept double-space-period after emoji." 2013-10-04 13:05:43 +00:00
Jean Chalard
43a8a0c527 Fallback on empty locales. 
This is a very rare corner case.

Bug: 11072132
Change-Id: Iad2aa69511f7dc99105284a049c63f2f997b8ef0
 2013-10-04 22:04:59 +09:00
Jean Chalard
8142fd83a6 Accept double-space-period after emoji. 
This also includes a fix that allows this code to read surrogate
pairs in this processing.

Bug: 11070482
Change-Id: If5ef8d6863938252f09128b7e99ea07ece6e7019
 2013-10-04 22:01:36 +09:00
Satoshi Kataoka
1d188a28fb Merge "Fix emoji" 2013-10-04 12:00:39 +00:00
Satoshi Kataoka
0cf92aa826 Fix emoji 
Bug: 10538430

Change-Id: Ib11e29794216b54001806ab12fe440d157243dc1
 2013-10-04 20:58:09 +09:00
Satoshi Kataoka
0b288985b7 Merge "Fix emoji recent key behavior" 2013-10-04 11:18:07 +00:00
Satoshi Kataoka
e7ed5cae44 Fix emoji recent key behavior 
Bug: 10538430
Change-Id: I91e03a8e7914628cdc8e57c124c95e5e6e8ea2a6
 2013-10-04 20:01:00 +09:00
Ken Wakasa
c01707db03 Merge "Suppress exceptions that have always been happening." 2013-10-04 10:13:53 +00:00