19ad9bf145
Read and use user dictionary shortcuts.
...
Bug: 4646172
Change-Id: I51002c73d5bad1a698110c5cda02253348be8eed
2012-05-15 12:23:43 +09:00
76218b966a
Merge "Do not set "SuggestionSpan"s for suggestions from the next word predicition" into jb-dev
2012-05-14 20:14:53 -07:00
0142b997bf
Do not set "SuggestionSpan"s for suggestions from the next word predicition
...
Bug: 6294817
Change-Id: I5010eafa5ba7e947743706adf7e722f4f0cfb415
2012-05-15 12:08:31 +09:00
0c5b2a01d4
am 5282f00f: Merge "Contacts dictionary rebuilds only when contact names have changed." into jb-dev
...
* commit '5282f00ff871bc0ae8303a2b6dacb283f73e31ea':
Contacts dictionary rebuilds only when contact names have changed.
2012-05-14 19:41:34 -07:00
a9aeb6f3cc
Merge "Small optimization" into jb-dev
2012-05-14 19:11:19 -07:00
b1120fe79a
Merge "Small optimizations" into jb-dev
2012-05-14 19:11:11 -07:00
f5ac6c725a
Merge "More optimizations" into jb-dev
2012-05-14 19:11:06 -07:00
f184e73dd7
Merge "Some more obvious optimizations" into jb-dev
2012-05-14 19:11:02 -07:00
78df7181ff
Merge "Some obvious optimizations to makedict" into jb-dev
2012-05-14 19:10:48 -07:00
aec44d50a7
include text context in researchLogger
...
when logging LatinIME.onUpdateSelection(), now include the current word and
preceding word. no escaping of the word is performed; this is temporary
until the output format is cleaned up.
also fix EditingUtils.getWordRangeAtCursor to support supplementary
UTF-16 characters.
Bug: 6188932
Change-Id: If4612a2627537d5d8bb2f9585a3ad1b4e56c2e26
2012-05-14 09:55:26 -07:00
76319c6931
Small optimization
...
Performance gain is < 2%
Bug: 6394357
Change-Id: I2b7da946788cf11d1a491efd20fb2bd2333c23d1
2012-05-14 15:52:01 +09:00
4df5b43df8
Small optimizations
...
Bug: 6394357
Change-Id: I00ba1b5ab3d527b3768e28090c758ddd1629f281
2012-05-14 15:51:58 +09:00
3b1b72ac4d
More optimizations
...
We don't merge tails anyway, and we can't do it any more
because that would break the bigram lookup algorithm.
The speedup is about 20%, and possibly double this if
there are no bigrams.
Bug: 6394357
Change-Id: I9eec11dda9000451706d280f120404a2acbea304
2012-05-14 12:41:18 +09:00
12efad3d15
Some more obvious optimizations
...
The speedup is about 15%
Bug: 6394357
Change-Id: Ibd57363d9d793206dd916d8927366db4192083b6
2012-05-14 12:35:31 +09:00
47db0be7cb
Some obvious optimizations to makedict
...
Bug: 6394357
Change-Id: Ibfd98aac2304ef50cf90b1de984736ddcfe7a4bc
2012-05-14 12:34:05 +09:00
a75b2d3816
am 38b5e423: Merge "Implement "lift-to-type" interaction. Fix event text." into jb-dev
...
* commit '38b5e4239d5f31f04eaf38951442476eb378c80f':
Implement "lift-to-type" interaction. Fix event text.
2012-05-12 16:46:49 -07:00
4d289d39ae
Contacts dictionary rebuilds only when contact names have changed.
...
Bug: 6396600
Change-Id: Iad693ec4bab6351793d624e5c5b0a9f5c12a60e3
2012-05-11 18:43:53 -07:00
38b5e4239d
Merge "Implement "lift-to-type" interaction. Fix event text." into jb-dev
2012-05-11 10:16:05 -07:00
19278ea91f
am 59e6ad38: Merge "Write the bigram frequency following the new formula" into jb-dev
...
* commit '59e6ad38748b0d3c2ed63738d6ab5e6f123466d0':
Write the bigram frequency following the new formula
2012-05-11 04:46:21 -07:00
59e6ad3874
Merge "Write the bigram frequency following the new formula" into jb-dev
2012-05-11 04:42:36 -07:00
f7346de94a
Write the bigram frequency following the new formula
...
This also tests for bigram frequency against unigram frequency
Bug: 6313806
Bug: 6028348
Change-Id: If7faa3559fee9f2496890f0bc0e081279e100854
2012-05-11 20:27:22 +09:00
e1c75a42c2
am ad0233fa: Merge "Refactor a method" into jb-dev
...
* commit 'ad0233fa02985e597054bc50726a412fd8fff371':
Refactor a method
2012-05-11 04:13:53 -07:00
ad0233fa02
Merge "Refactor a method" into jb-dev
2012-05-11 04:09:17 -07:00
0dee42e4d4
am a6204bbe: Fix Spanish keyboard to have easy access to inverted ? and !
...
* commit 'a6204bbe2a8a3e34ae1adb4d2103c7323825a40c':
Fix Spanish keyboard to have easy access to inverted ? and !
2012-05-11 03:38:27 -07:00
4455fe2c89
Refactor a method
...
Rename it, rename parameters, and add a parameter that will
be necessary soon.
Also, rescale the bigram frequency as necessary.
Bug: 6313806
Change-Id: I192543cfb6ab6bccda4a1a53c8e67fbf50a257b0
2012-05-11 19:34:35 +09:00
bdae5f56e3
am 2de0b52a: Merge "Reorganize punctuations and diacritics of Arabic and Persian" into jb-dev
...
* commit '2de0b52a035ac27ffcddb0e914135f2ac104e05f':
Reorganize punctuations and diacritics of Arabic and Persian
2012-05-11 03:33:44 -07:00
9978953e29
am 6792a909: Merge "Output caps debug code" into jb-dev
...
* commit '6792a909cd0da3db6a957cb2576b4d08f46a53b7':
Output caps debug code
2012-05-11 03:33:42 -07:00
59f091875c
am 5434f464: Remove unexpectedly split words with single quotes
...
* commit '5434f46481c6331c3f107e6940cb49ba9dd5ea4d':
Remove unexpectedly split words with single quotes
2012-05-11 03:33:41 -07:00
a6204bbe2a
Fix Spanish keyboard to have easy access to inverted ? and !
...
Bug: 6480385
Change-Id: Iae7879b5264711962a662f4b3d47a834bda715be
2012-05-11 19:17:53 +09:00
2de0b52a03
Merge "Reorganize punctuations and diacritics of Arabic and Persian" into jb-dev
2012-05-11 03:06:33 -07:00
6792a909cd
Merge "Output caps debug code" into jb-dev
2012-05-11 03:06:29 -07:00
5434f46481
Remove unexpectedly split words with single quotes
...
Bug: 6451163
Change-Id: I4c5595f727934f2b401e9bb11a6ba613668f4a42
2012-05-11 18:49:29 +09:00
b6fb5eb391
Output caps debug code
...
Change-Id: I4a3399d9066bd28dab893ecebb720924110b871d
2012-05-11 17:37:14 +09:00
369ab4cd01
am 88794b24: Remove the dependency to SpellCheckerProximityInfo from ProximityInfo.
...
* commit '88794b24c0928e3bbea59999fce47c78c028863d':
Remove the dependency to SpellCheckerProximityInfo from ProximityInfo.
2012-05-11 01:10:45 -07:00
88794b24c0
Remove the dependency to SpellCheckerProximityInfo from ProximityInfo.
...
In conjunction with I596b2deb
Change-Id: I42f059158ae78e1c1c807ed4d3688edbcf18c006
2012-05-11 17:03:06 +09:00
ef6dadbe6c
Reorganize punctuations and diacritics of Arabic and Persian
...
Bug: 6029665
Change-Id: Id72d5af2c9c8fff09a366819901c950b87756dea
2012-05-11 15:48:56 +09:00
b427eabfdf
am 7c23ad92: Merge "Use key index as virtual view ID." into jb-dev
...
* commit '7c23ad92fcbeb64623c7deda7c603ec6c35e11a3':
Use key index as virtual view ID.
2012-05-10 11:58:18 -07:00
7dc925bc9a
am 684c519d: Merge "Cleanup indentation" into jb-dev
...
* commit '684c519d9d72443b9668fa1474ce2970ceb86a4f':
Cleanup indentation
2012-05-10 11:56:23 -07:00
df9aa401e4
am 52ab6864: Merge "Remove unused code from AccessibilityEntityProvider." into jb-dev
...
* commit '52ab6864d0d3402a6d0164b474055af2c64cc827':
Remove unused code from AccessibilityEntityProvider.
2012-05-10 11:56:21 -07:00
6662e2a40d
Implement "lift-to-type" interaction. Fix event text.
...
Bug: 6456970
Change-Id: Idd6b84fc7a730a1e78d9c1157e3b5f22e5d49fc4
2012-05-10 11:37:13 -07:00
7c23ad92fc
Merge "Use key index as virtual view ID." into jb-dev
2012-05-10 11:34:20 -07:00
684c519d9d
Merge "Cleanup indentation" into jb-dev
2012-05-10 01:53:38 -07:00
cee24a1f6c
Cleanup indentation
...
Change-Id: Iaaade378acb81a2d68e2e721778a82fd8d5e20a5
2012-05-10 17:48:10 +09:00
b4c41fa813
Use key index as virtual view ID.
...
Bug: 6464677
Change-Id: I443e4add8052dbce1d413c2ce38a7b98408613bf
2012-05-09 22:23:14 -07:00
52ab6864d0
Merge "Remove unused code from AccessibilityEntityProvider." into jb-dev
2012-05-09 22:18:50 -07:00
d079a0cde5
am bced8270: Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev
...
* commit 'bced82709ad262d59ec523439ea7b22b18c5335b':
Fix calculation of more keys keyboard position based on key preview
2012-05-09 10:12:50 -07:00
c3f3cbfc76
am 5a40dcaf: Release previously pressed key even when the up event points new key
...
* commit '5a40dcaf8b6250eeea241471e54e8fe856cdf19b':
Release previously pressed key even when the up event points new key
2012-05-09 10:12:49 -07:00
bced82709a
Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev
2012-05-09 06:04:47 -07:00
7ecc1081ab
Fix calculation of more keys keyboard position based on key preview
...
Bug: 6135881
Change-Id: Id1c4e2c13d13b474466cb9b42b425aa9f6f9448b
2012-05-09 21:23:09 +09:00
5a40dcaf8b
Release previously pressed key even when the up event points new key
...
Bug: 6457266
Change-Id: I52c9fe88791d2c3a4385dfa457f07da160c60699
2012-05-09 20:24:14 +09:00
46b26ed892
am c8bde75c: Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev
...
* commit 'c8bde75cf455c02efc57c2e35bbe446b83c23739':
Optimize InputConnection.getCursorCapsMode calling
2012-05-09 01:55:45 -07:00
9648b1674e
am d5cd7e64: Small optimization
...
* commit 'd5cd7e64aa30096241f63e47a9169699bdd98231':
Small optimization
2012-05-09 01:55:44 -07:00
4e02b1273b
am 442ac5d0: Merge "Don\'t ask for surrounding characters for each keypress" into jb-dev
...
* commit '442ac5d0bb96ec257d26b28df2fabefdefe59b96':
Don't ask for surrounding characters for each keypress
2012-05-09 01:55:43 -07:00
5046197085
am 34b2b5e6: Remove accessibility gesture handlers from LatinIME.
...
* commit '34b2b5e694758390126ffa3b1c7d752cdde7a05c':
Remove accessibility gesture handlers from LatinIME.
2012-05-09 01:55:43 -07:00
3b0f0b57ff
am f52aef84: Merge "Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified" into jb-dev
...
* commit 'f52aef84a582197d6f8e580044b2d24d2a710cef':
Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
2012-05-09 01:55:41 -07:00
682b1199f1
am 7b6afb12: Enable long-press spacebar on 7 inch tablet
...
* commit '7b6afb1287fb6d5edfebed7403eb31ed23a8348d':
Enable long-press spacebar on 7 inch tablet
2012-05-09 01:55:40 -07:00
c8bde75cf4
Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev
2012-05-09 00:24:00 -07:00
03ca17c841
Optimize InputConnection.getCursorCapsMode calling
...
Bug: 6464226
Change-Id: I30c1b01be5e1719ded5f7f8a7e24a38e9bbc3637
2012-05-09 16:19:08 +09:00
d5cd7e64aa
Small optimization
...
Change-Id: I067249976e557b60b606d2153deaeb3c8f1f38ac
2012-05-09 16:14:25 +09:00
442ac5d0bb
Merge "Don't ask for surrounding characters for each keypress" into jb-dev
2012-05-08 23:38:53 -07:00
736b109e16
Don't ask for surrounding characters for each keypress
...
Bug: 6464226
Change-Id: I03745bbcc21e5ec6ca57fa1257bf21c0cd26391a
2012-05-09 15:19:35 +09:00
8e5f79f57d
Remove unused code from AccessibilityEntityProvider.
...
Change-Id: I73882668b516344d36e69355e9cb39534becb629
2012-05-08 19:51:49 -07:00
34b2b5e694
Remove accessibility gesture handlers from LatinIME.
...
Bug: 6457558
Change-Id: If33ca6f026d4846ba79a701ef42c0112f5b0b488
2012-05-08 17:23:58 -07:00
f52aef84a5
Merge "Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified" into jb-dev
2012-05-08 06:43:05 -07:00
0b831ba2aa
Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
...
Bug: 6435484
Change-Id: Iccca7d1b770c547efae0b5e5931cebd910083d40
2012-05-08 13:20:39 +09:00
7b6afb1287
Enable long-press spacebar on 7 inch tablet
...
This change also eliminate useless attribute longPressSpaceKeyTimeout
of LatinKeyboardView.
Bug: 6449356
Change-Id: Ib4dace4b9510c0eb96bdddacf8e0dbaa14fcfbbf
2012-05-08 12:50:07 +09:00
725fff0511
am e58f3af8: Treat apostrophe as single quote in spell checker
...
* commit 'e58f3af8a7bf852c3b100de1bd85d95d13e0e15e':
Treat apostrophe as single quote in spell checker
2012-05-07 06:28:55 -07:00
e58f3af8a7
Treat apostrophe as single quote in spell checker
...
Bug: 6435348
Change-Id: Iaaac9042e7e6cb21a3f2243bc6e8e055cc24f74d
2012-05-07 22:21:55 +09:00
9fcae31e7e
am 165725ab: Fix build
...
* commit '165725aba8a179440af9c93869b35f206b2e133f':
Fix build
2012-05-06 16:53:43 -07:00
165725aba8
Fix build
...
Related-change: I173a3dc0
Change-Id: I4b5adedb70f7501e84fd3604aa240161c97dc713
2012-05-07 08:19:17 +09:00
33e95e9186
am 8e50c5d1: Fix subtype name for a custom input style with en_US and en_GB
...
* commit '8e50c5d198f65beb6679a9a1e0102e5fc52d7707':
Fix subtype name for a custom input style with en_US and en_GB
2012-05-06 11:33:49 -07:00
8e50c5d198
Fix subtype name for a custom input style with en_US and en_GB
...
This change utilizes "UntranslatableReplacementStringInSubtypeName"
subtype extra value to display keyboard layout name dynamically.
Bug: 6449315
Change-Id: I9ef4c3d66ff9a223aa8c89c346d04cb72e4f6263
2012-05-07 03:25:08 +09:00
e14d4f386c
am 4e6c6046: Merge "Fix newly created custom input style display name" into jb-dev
...
* commit '4e6c60464580213cda67c46499259d2ff0bbc493':
Fix newly created custom input style display name
2012-05-06 10:49:45 -07:00
4e6c604645
Merge "Fix newly created custom input style display name" into jb-dev
2012-05-06 10:46:07 -07:00
ca93442026
Fix newly created custom input style display name
...
This will revert I4263632e
Bug: 6443665
Bug: 6410653
Change-Id: Id9ad1a204ed9802488abfc2c536a95d62d55afe0
2012-05-07 02:42:08 +09:00
a0fe57a290
am 3665e2a8: Merge "Tidy up the MakedictLog class." into jb-dev
...
* commit '3665e2a8fc29c9bbe98d1c73e00af26abd6a5421':
Tidy up the MakedictLog class.
2012-05-06 10:36:29 -07:00
3665e2a8fc
Merge "Tidy up the MakedictLog class." into jb-dev
2012-05-06 10:31:46 -07:00
ee3177d64d
am 4c9bdcc9: Merge "Fix missing synchronized modifier" into jb-dev
...
* commit '4c9bdcc9579288ca379c49d36c0ba0ec81515ef7':
Fix missing synchronized modifier
2012-05-06 09:56:31 -07:00
4c9bdcc957
Merge "Fix missing synchronized modifier" into jb-dev
2012-05-06 09:52:52 -07:00
66c09113f6
am 90b73b85: Merge "Get subtype name string resource from its own locale" into jb-dev
...
* commit '90b73b85e4d1846b84f97fb3b1a5f7897f89b985':
Get subtype name string resource from its own locale
2012-05-06 09:49:23 -07:00
5b2eb0f505
Fix missing synchronized modifier
...
Change-Id: Ied70a86bedb08adcf8353b189367172459f55292
2012-05-07 00:55:01 +09:00
757c12556b
Get subtype name string resource from its own locale
...
Bug: 6443655
Change-Id: Ib9ee55178f0d0f885aa0640b9cba4a179cf0c566
2012-05-07 00:44:54 +09:00
84478103ec
Tidy up the MakedictLog class.
...
Follow up to I436b2b7b
Change-Id: Id17b134dab2f876b874a505e92a379c8b5567fa4
2012-05-05 23:40:21 +09:00
5a937aae99
Merge "record full text after finishing session"
2012-05-04 21:09:22 -07:00
e9001d28c4
am 03b423f3: Suppress debug log from makedict in LatinIME
...
* commit '03b423f313cccb85890346ec4e6e347335f89fbf':
Suppress debug log from makedict in LatinIME
2012-05-04 18:14:36 -07:00
03b423f313
Suppress debug log from makedict in LatinIME
...
bug: 6447900
Change-Id: I436b2b7b261b422a7edca9cb99a4689b63877fe0
2012-05-05 09:28:27 +09:00
d67a248de4
record full text after finishing session
...
uses onWindowHidden() callback as proxy for finishing session.
Bug: 6188932
Change-Id: Ic63b47c946ca91fc35f80d71b2f9e24e2d0339ac
2012-05-04 10:57:50 -07:00
77814c4bb0
associate a per-device UUID with the researchLog
...
logged upon starting a session
Bug: 6188932
Change-Id: I197d231fbc1d87cf5a3649b485a9be4b17898ba3
2012-05-02 18:43:27 -07:00
a814fd0ddd
am 9ba92faa: Merge "Fix build breakage" into jb-dev
...
* commit '9ba92faa81f864c721ee1a9ba8b97c3ead49a38d':
Fix build breakage
2012-05-02 02:18:56 -07:00
9ec06c17d4
Fix build breakage
...
Change-Id: I22305137b336c9aab019d044a517ae8bc5fefe45
2012-05-02 18:14:40 +09:00
34590d6cd1
am 57007ed5: Merge "Workaround return preserved backing view height when the backing view is not ready" into jb-dev
...
* commit '57007ed582fbe89b2f2ac24e06a15a4fb5a948df':
Workaround return preserved backing view height when the backing view is not ready
2012-05-02 01:44:30 -07:00
57007ed582
Merge "Workaround return preserved backing view height when the backing view is not ready" into jb-dev
2012-05-02 01:42:00 -07:00
f4cf5b9952
Workaround return preserved backing view height when the backing view is not ready
...
Change-Id: If4f24500ead516c46e6a93a95291e0897548c2f0
2012-05-02 17:40:10 +09:00
f000a5cd5a
Merge "log packageName in researchLogger on startup"
2012-05-01 18:19:02 -07:00
76d6673b2a
Merge "Fix checking if subtype belongs to this ime" into jb-dev
2012-05-01 04:23:40 -07:00
ae2388c7f7
Fix checking if subtype belongs to this ime
...
Bug: 6422318
Change-Id: I5779c0e277444315191fa964a976dcb4316cc24a
2012-05-01 20:21:10 +09:00
aec1770ed1
Tune letter text size of 7 inch tablet
...
Bug: 6422086
Bug: 6411272
Change-Id: Ia3c40206555353b6f0c633a529d546dc2379e9aa
2012-05-01 19:56:40 +09:00
a474dbc5c2
Merge "Don't autocorrect after suggestion resuming" into jb-dev
2012-05-01 01:15:23 -07:00
4b5b46bb66
Don't autocorrect after suggestion resuming
...
Bug: 6105732
Change-Id: I92e7a9c6d6eb648f747c3b396d7993479fd8478a
2012-05-01 17:06:29 +09:00
2f83e9e532
Can override key-style
...
Bug: 6412932
Change-Id: I9576ae5b42bcc54cfd8ede0bae5148f3b04c1978
2012-05-01 16:56:53 +09:00
623118fe48
log packageName in researchLogger on startup
...
Bug: 6188932
Change-Id: I85f434bf284d6b481893f7d41c884a4f0c57ce49
2012-04-30 11:21:12 -07:00
0ab1c664c1
Avoid Resources$NotFoundException
...
bug: 6410653
Change-Id: I4263632e76b44abf8ecd9114a9eb185ad39201fd
2012-04-28 03:24:05 +09:00
20a6dea1ca
Add a flag for bigram presence in the header
...
This is a cherry-pick of Icb602762 onto jb-dev.
Bug: 6355745
Change-Id: Icb602762bb0d81472f024fa491571062ec1fc4e9
2012-04-26 16:40:29 +09:00
329c8d7bcc
Merge "Ignore bigrams that are not also listed as unigrams" into jb-dev
2012-04-26 00:26:04 -07:00
93e122e28d
Merge "Fix potential "divided by zero" exception" into jb-dev
2012-04-26 00:21:07 -07:00
bd2ca9c021
Fix potential "divided by zero" exception
...
This change also refactors the language name selection to use text
x-scale.
Bug: 6396854
Change-Id: I31249a85bd042a93d627f40413161aef13617c87
2012-04-26 16:01:55 +09:00
45c57dcc2d
Merge "Fix SubtypeSwitcher incomplete initialization" into jb-dev
2012-04-25 23:22:06 -07:00
44c64f46a1
Ignore bigrams that are not also listed as unigrams
...
This is a cherry pick of I14b67e51 on jb-dev
Bug: 6340915
Change-Id: Iaa512abe1b19ca640ea201f9761fd7f1416270ed
2012-04-26 15:20:30 +09:00
3d407cc086
Fix SubtypeSwitcher incomplete initialization
...
Bug: 6400718
Change-Id: Id5dce156ad397b911bfeaedeeddd4aeb21a10b3a
2012-04-26 13:41:15 +09:00
27b42ced86
Fix "no language" subtype name (DO NOT MERGE)
...
* Move SubtypeLocale.get{Full,Middle,Short}DisplayName() to
LatinLeyboardView and add unit tests (SpacebarTextTests).
* Add SubtypeLocale.getSubtypeDisplayName()
This is a cherry-pick of I57420c6a from Master.
Bug: 6393865
Change-Id: I68748189c17c73984ac4ae05a5a40fb54bf46453
2012-04-26 11:50:28 +09:00
49caddbdab
Support PC QWERTY layout
...
Bug: 4460018
Change-Id: I9a29f6a322af66f6a152fa1883b3686c5f7a3328
2012-04-25 16:34:59 +09:00
cbaf6d85f1
Cancel SubtypePreference dialog properly
...
Bug: 6384416
Bug: 6387408
Change-Id: Ia7b0653a09410b42a55915815c887bf0ad56c856
2012-04-25 15:42:14 +09:00
9f0a137f82
Save & restore additional subtype dialog state when orientation is changed
...
Bug: 6384416
Change-Id: Id5fa4742ad900fafb82cc37a0bbb9f380b99254d
2012-04-25 15:29:05 +09:00
d454fcc2cf
Merge "Ignore unknown keyboard layout safely"
2012-04-24 23:22:26 -07:00
96e404310d
Ignore unknown keyboard layout safely
...
Bug: 6393755
Change-Id: I3a74b23f934cd52925026ad04647cc76de92ee07
2012-04-25 13:34:04 +09:00
b7286439f6
Fix percent sign in more keys
...
Bug: 6029665
Change-Id: I4bf0f5703d0c11d76bab478da2729b0e20fc64ea
2012-04-25 11:51:19 +09:00
ce54a14bed
Merge "Change expandable binary dict write to a temp file first."
2012-04-24 10:54:56 -07:00
a9b2be8a81
Change expandable binary dict write to a temp file first.
...
Bug: 6380724
Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
2012-04-24 10:52:53 -07:00
8e7740b28a
Merge "Add header commnets of KeyboardTextsSet.tmpl"
2012-04-24 00:49:11 -07:00
5723bedcd0
Merge "Revert keyHintLetterPadding only to apply horizontally"
2012-04-24 00:41:57 -07:00
ab771b01eb
Revert keyHintLetterPadding only to apply horizontally
...
Partially reverts the Ia3680d84.
Bug: 6356125
Change-Id: I8faa810b833cb98ce6f0f760aa1722e63475cd45
2012-04-24 16:20:47 +09:00
aaac9a5217
Add header commnets of KeyboardTextsSet.tmpl
...
Bug: 6371604
Change-Id: I1054685b9985b6923e3176679b3d95424d8114e0
2012-04-24 16:19:17 +09:00
805fed49e1
Merge "Fix binary reading code performance."
2012-04-23 23:39:37 -07:00
fe4d13cbcb
Merge "Make the "Touch again to save" hint text touchable."
2012-04-23 23:20:49 -07:00
1d80a7f395
Fix binary reading code performance.
...
This is not the Right fix ; the Right fix would be to read
the file in a buffered way. However this delivers tolerable
performance for a minimal amount of code changes.
We may want to skip submitting this patch, but keep it around
in case we need to use the functionality until we have a good
patch.
Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
2012-04-24 15:16:17 +09:00
cbebbaf065
Merge "Fix a bug where a node size would be seen as increasing."
2012-04-23 22:19:19 -07:00
a64a1a46e4
Fix a bug where a node size would be seen as increasing.
...
The core reason for this is quite shrewd. When a word is a bigram
of itself, the corresponding chargroup will have a bigram referring
to itself. When computing bigram offsets, we use cached addresses of
chargroups, but we compute the size of the node as we go. Hence, a
discrepancy may happen between the base offset as seen by the bigram
(which uses the recomputed value) and the target offset (which uses
the cached value).
When this happens, the cached node address is too large. The relative
offset is negative, which is expected, since it points to this very
charnode whose start is a few bytes earlier. But since the cached
address is too large, the offset is computed as smaller than it should
be.
On the next pass, the cache has been refreshed with the newly computed
size and the seen offset is now correct (or at least, much closer to
correct). The correct value is larger than the previously computed
offset, which was too small. If it happens that it crosses the -255 or
-65335 boundary, the address will be seen as needing 1 more byte than
previously computed. If this is the only change in size of this node,
the node will be seen as having a larger size than previously, which
is unexpected. Debug code was catching this and crashing the program.
So this case is very rare, but in an even rarer occurence, it may
happen that in the same node, another chargroup happens to decrease
it size by the same amount. In this case, the node may be seen as
having not been modified. This is probably extremely rare. If on
top of this, it happens that no other node has been modified, then
the file may be seen as complete, and the discrepancy left as is
in the file, leading to a broken file. The probability that this
happens is abyssally low, but the bug exists, and the current debug
code would not have caught this.
To further catch similar bugs, this change also modifies the test
that decides if the node has changed. On grounds that all components
of a node may only decrease in size with each successive pass, it's
theoritically safe to assume that the same size means the node
contents have not changed, but in case of a bug like the bug above
where a component wrongly grows while another shrinks and both cancel
each other out, the new code will catch this. Also, this change adds
a check against the number of passses, to avoid infinite loops in
case of a bug in the computation code.
This change fixes this bug by updating the cached address of each
chargroup as we go. This eliminates the discrepancy and fixes the
bug.
Bug: 6383103
Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
2012-04-24 14:04:02 +09:00
9f763d1445
Make the "Touch again to save" hint text touchable.
...
Bug: 6355346
Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
2012-04-24 13:44:14 +09:00
3e3bb36f1f
Fix NPE in AdditionalSubtypeSettings
...
Bug: 6384416
Change-Id: I878071b8b78acce51649f9637b59830ab681c696
2012-04-24 11:01:45 +09:00
fa1affbaec
Merge "Fix a bug where two spaces would be added instead of one"
2012-04-23 17:03:32 -07:00
5ee0ee0dbe
Merge "Fix a bug where a batch edit would not be started."
2012-04-23 17:02:41 -07:00
87f7fa12db
Merge "Pass words as int[] to the native code."
2012-04-23 17:02:26 -07:00
bebcae8ff5
Merge "Binary bigram lookup checks both uppercase and lowercase when previous word is uppercase."
2012-04-23 09:06:05 -07:00
9dc1200b9b
Fix key preview when shifted hint letter is activated
...
Change-Id: I70d2627318d21eb612c3c3fee2ce8e80555dba12
2012-04-23 18:50:07 +09:00
551612dd9e
Fix a bug where two spaces would be added instead of one
...
Bug: 6378291
Change-Id: Id2453333ae16146f816faf0eb68baa8ea1dd106a
2012-04-23 18:15:51 +09:00
96fb3094aa
Fix a bug where a batch edit would not be started.
...
This would end up in TextView sometimes calling onUpdateSelection
multiple times (this is the correct behavior for TextView). We now
commit the space and the word in a batch edit, and we only get
onUpdateSelection once.
Bug: 6300527
Change-Id: I9579f3d8f5320c1cc24a7a42f19db8e105eb090d
2012-04-23 17:45:50 +09:00
522a04ea5b
Pass words as int[] to the native code.
...
We need to get the bigrams during the call to getSuggestions for
bug#6313806. We already give an int[] to getSuggestions and we
wanted to get rid of char[]'s anyway because it doesn't work with
surrogate pairs, so here we go.
Bug: 6313806
Change-Id: I56ce99f1db6b3302cdf42f0527343bded837091e
2012-04-23 16:05:36 +09:00
e060d1a540
Merge "Fix using keyboard layout display name in custom input style spinner"
2012-04-22 23:16:57 -07:00
a245be6819
Fix using keyboard layout display name in custom input style spinner
...
Change-Id: I80626591574aa9995011202cf868f9c2c5168303
2012-04-23 13:54:58 +09:00
0df78d46da
Use the best matching cached dictionary for each category
...
Bug: 6327270
Change-Id: I5a0e732c8a3fd55fd8ac3c8fe1c58e7f91555d97
2012-04-23 12:37:52 +09:00
0806bb01d9
Binary bigram lookup checks both uppercase and lowercase when previous word is uppercase.
...
Bug: 6363029
Change-Id: I71a1ed5b88f54fcc15bfaf89d3645b8f17ebb821
2012-04-22 17:48:00 -07:00
1894c6e586
Remove unused methods and classes
...
Change-Id: I1a82bf2202d436efa4c5135d705a048fe45a0257
2012-04-22 18:48:54 +09:00
f8ad37a8fc
Remove an unused method
...
Change-Id: I3abbf6462c31b11167e356fe77b8afca2514a869
2012-04-22 12:50:01 +09:00
621e3f9830
Fix the build
...
Change-Id: I5c4e230500f058f7db86c05d554be45411004ffc
2012-04-20 16:44:22 -07:00
1b868393fe
Merge "Add language switch key to symbols and symbols shifted layout"
2012-04-20 03:30:53 -07:00
118762b444
Merge "Predefined keyboard layouts are configurable via XML resource"
2012-04-20 03:24:39 -07:00
3ce085079f
Add language switch key to symbols and symbols shifted layout
...
Bug: 6370179
Change-Id: I061559ea5d0cb11a059de4b6e741f9c17ee69a27
2012-04-20 19:24:18 +09:00
38026b4f03
Predefined keyboard layouts are configurable via XML resource
...
Bug: 4460018
Change-Id: Ia03ec826fb3853ea814d9764686903dbe31a6507
2012-04-20 19:19:24 +09:00
04b03f4dd6
Allow using a format version 2 word list in LatinIME
...
Change-Id: I73a4df3a83e49be6e8d3a7d14eb027cfe10f1a23
2012-04-20 18:56:03 +09:00
78173bdf53
Support Dvorak layout
...
Bug: 4460018
Change-Id: I08a9b556720f6c4f7089a8838c0869c9f88f479c
2012-04-20 17:28:32 +09:00
e42ec2a6ac
Merge "Don't allow cancelling manual pick."
2012-04-20 00:11:20 -07:00
29a1fc0f6b
Don't allow cancelling manual pick.
...
Bug: 6347202
Change-Id: I30b53256e83c534436b0f0ff594fd4aaabf4558c
2012-04-20 15:55:45 +09:00
6bfd5f6319
Fix confusable "label" usage, use "text" instead
...
* Rename makelabel tool to maketext
* Rename KeyboardLablesSet class to KeyboardTextsSet
* Rename "!label/name" to "!text/name"
Change-Id: Ia9494a89fe56f20ca8e8fedb253adbcf8b771bd3
2012-04-20 15:48:30 +09:00
cf41aff251
Use string attribute for icon name
...
Change-Id: I336acf33c7e6bc993b9da9b17ec689975fa8127d
2012-04-20 15:31:42 +09:00
050b577bfb
Merge "Make KeySpecParser case insensitive"
2012-04-19 21:21:18 -07:00
2f16fd40fa
Make KeySpecParser case insensitive
...
Change-Id: I76c3e9179dd8777d3cf3138ad76513d83672debf
2012-04-20 13:20:08 +09:00
5b92113cdb
Merge "remove unnecessary KeyboardState logging"
2012-04-19 20:53:44 -07:00
4d43d6f96e
Merge "researchLogger detail on IME sessions"
2012-04-19 20:35:21 -07:00
c59d74ce47
remove unnecessary KeyboardState logging
...
Bug: 6188932
Change-Id: Iafbb1825777122a1810fa3339853263aced3077e
2012-04-19 20:32:37 -07:00
48a7681e06
researchLogger detail on IME sessions
...
log device type, screen size, etc. also simplification inside ResearchLogger
to use exceptions better, and fix ResearchLoggerTests to not change
preferences to specify the logfile.
multi-project change with Idfd193b16260215cca32886e288f03a0c12b2781
Bug: 6188932
Change-Id: Idd3ca6eb8e8e3934f68234b241c7fd7d0cc3bcd5
2012-04-19 20:19:55 -07:00
7cdb560513
Merge "Change binary dictionary output buffer size to match dictionary size."
2012-04-19 17:18:59 -07:00
df7ebbbd61
Change binary dictionary output buffer size to match dictionary size.
...
Bug: 6355943
Change-Id: Iaab7bc16ba0dbc7bfde70b06e7bd355519838831
2012-04-19 10:18:57 -07:00
a2f458f569
Add shortcut_as_more_key label
...
This change also optimezes KeyboardLabelsSet.java by reordering
donottranslate-more-keys.xml in makelabel tool.
Change-Id: Ief46ee783454bedcdffb0f24d9d03df51b6edcd6
2012-04-20 00:54:03 +09:00
5e90f2873c
Fix comment handling of makelabel tool
...
Change-Id: Id40336b543987eee1d2777394d9ee5d0a6343a4c
2012-04-19 23:44:43 +09:00
6a7019ff5d
Move main dictionary availability check to LatinIME
...
Change-Id: Ib6183fec833d87bc32514b03bb691fec0a1e6ff8
2012-04-19 23:23:26 +09:00
65e93e352f
Fix SubtypeSwitcher to honor subtype
...
Bug: 6364170
Change-Id: I31f9a7c9b6b4ca04a1c78a4210dcaae0db9825db
2012-04-19 22:42:14 +09:00
aae757b8a1
Fix English "e" more keys
...
Change-Id: I982690a0d5f524769caa9a06d5da1528899552ef
2012-04-19 21:10:44 +09:00
d005476715
Fix English "o" more keys
...
Change-Id: If2457251a24686742f410e75938251deb91efdf8
2012-04-19 21:04:47 +09:00
b9fca7a192
Fix stack overflow
...
Change-Id: I977b240ea462b40852ba9504282312d5fa4e2885
2012-04-19 20:21:02 +09:00
ab39afca23
Remove LatinIME reference from DictionaryFactor class
...
Change-Id: Iad10e71baa81a1b4eb3c84ead47d658d567b8201
2012-04-19 19:57:43 +09:00
1cb08acaf3
Add Constants class to hold public constants
...
This change also gets rid of compiler warnings about "deprecations".
Change-Id: Id9b83483c453a81ebac34b684656db05e3599657
2012-04-19 19:45:19 +09:00
c27fe6253c
Add custom subtype settings
...
Bug: 4460018
Change-Id: I4919d79516dcf574be2761bbaf9adcdc381b2ddc
2012-04-19 19:33:51 +09:00
344af15674
Change predefined additional subtype format in preference
...
This change also refactor StringUtils class
Change-Id: Ie0b4d169b21c260bf238d6fcc9ab0ee8bfd6b508
2012-04-19 17:11:21 +09:00
f5a0bd2c28
Make predefined subtype configurable by XML resource
...
Change-Id: I1f8486a1fb652f1e06789e7bfd2cc57273092234
2012-04-18 22:45:26 +09:00
55d28fd1b2
Cleanup InputMethodManagerCompatWrapper
...
Change-Id: Id3b84ee19bb504ed8fbb398e260cc663a5b5ae0d
2012-04-18 18:01:29 +09:00
a58ebc73ae
Fix typo of some methods' name
...
Also changes some methods' argument type from Locale to String.
Change-Id: Ib68b528a450dc68a01546483403230f76500bee4
2012-04-18 16:40:50 +09:00
26d97b089d
Merge "Fix dimming keyboard"
2012-04-17 23:30:25 -07:00
b3f0912fd1
Fix dimming keyboard
...
Bug: 6354679
Change-Id: I03bb0554bc06f1aab7eaa6c69fd9241ef300318f
2012-04-18 14:55:57 +09:00
d442984e96
researchLogging for inputConnection events
...
Bug: 6188932
Change-Id: I596df68956abd879293cfb550e66e7d7d0ba74e9
2012-04-17 20:05:10 -07:00
18178fefdc
Merge "Remove useless key event handling methods"
2012-04-17 19:58:05 -07:00
79e07e3f84
Remove useless key event handling methods
...
Change-Id: I8c42fba79aba643ab7a145e6fd54ef23855a3ad0
2012-04-18 11:55:11 +09:00
bde232dcaa
Merge "Pass the previous word down to native code in getSuggestions"
2012-04-17 18:01:05 -07:00
69bcc15cb3
Add SubtypeUtils.setAditionalInputMethodSubtypes method
...
Change-Id: Ia3043346ed87297e01d505980555fdf29ce4f96f
2012-04-17 22:48:00 +09:00
80111f08e2
Pass the previous word down to native code in getSuggestions
...
Change-Id: I477b631d81ef58461e44954f3ae5fd895928bb97
2012-04-17 20:07:10 +09:00
74a84febc7
Cache results of the spell checker
...
Change-Id: Ie11cd1b07e069474b140fbaae65fca703adc056f
2012-04-17 19:45:57 +09:00
761b6bc120
Merge "Add SubtypeLocale.getKeyboardLayoutSetDisplayName"
2012-04-17 03:08:59 -07:00
bb17bafac3
Add SubtypeLocale.getKeyboardLayoutSetDisplayName
...
Change-Id: I576b47a936545e653ce9e26222ba4db143ea90e6
2012-04-17 18:55:51 +09:00
23980cdba4
Merge "Do not pass misspelled flags to TextView"
2012-04-17 02:51:28 -07:00
65ebe190a9
Do not pass misspelled flags to TextView
...
Bug: 6310268
Original CL: I2f7a54ae0d63235a0b94e039109ab8
Change-Id: I28f64a4d0bb262db819f5f8c0ffc58a259c8e62d
2012-04-17 15:51:08 +09:00
1277692519
Merge "Pass the previous word to getSuggestions"
2012-04-16 20:56:03 -07:00
ac27e4544b
Pass the previous word to getSuggestions
...
This is a preparative change to bug#6313806
Change-Id: I1be9ec49b21005c1f45ce459fa93712bc74ef3f0
2012-04-17 12:43:53 +09:00
9bfb620215
add logPoint for manual correction (inc touch pos)
...
Bug: 6188932
Change-Id: Ibcc4901bcfab6632ee4c59cb58d35452218a288d
2012-04-16 16:52:25 -07:00
8b833071a1
Fix Settings fragment isn't shown on tablet
...
Bug: 6341510
Change-Id: I319bb72400995d8385b0b14ef25b164dee3974da
2012-04-16 16:36:28 +09:00
11a40a047f
Make Utils.getDeviceOverrideValue aware of device orientation
...
Bug: 6277225
Change-Id: If41fe5cbee0985b9a4740dcd5d1c6ba73b94b377
2012-04-16 12:59:55 +09:00
423b30d59c
Use keyTextStyle to draw popup hint "..." text
...
Also popup hint "..." text doesn't follow the alpha animation of
alt-while-key-typing.
Bug: 6333266
Change-Id: I08b548a8922e6fe5e9ff036ff75cadf39fb9358a
2012-04-16 12:11:05 +09:00
a7352c8df4
Merge "Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams."
2012-04-13 18:30:19 -07:00
18222f8c86
Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams.
...
Bug: 6188977
Change-Id: I753422eed1effaeb5fd01124cf1ddd1e31ee9d60
2012-04-13 17:54:39 -07:00
2783c51e6d
Merge "clean up researchLogging of autocorrection"
2012-04-13 10:47:19 -07:00
c206d04623
Use InputMethodSettingsFragment for IME settings
...
Change-Id: Id6d9cd0ddf99c0687b6d3ea4b2f868f6cf2a0eaf
2012-04-13 19:56:47 +09:00
f6972561fc
Utilize InputMethodSubtype and additional subtype
...
* Remove de_QY and fr_CH from supported subtypes
* Add de-qwerty and fr-qwertz predefined additional subtypes instead.
Change-Id: I49e8ba0299529302f2b91b4d018b07304cdd6897
2012-04-13 18:36:26 +09:00
8abde7db6b
Refatcor InputMethodSubtype related stuff a bit
...
Change-Id: Iaded72331660afbaeddda085f2b633b681d4b6df
2012-04-13 16:24:11 +09:00
60adb87574
clean up researchLogging of autocorrection
...
remove dependence of ResearchLogger on LatinImeLogger
for autocorrection
multi-project commit with I32cc134b
Bug: 6188932
Change-Id: Iaeda97eb43fa4782db2d1b2a6d8d09a93b395111
2012-04-12 22:59:21 -07:00
35b5a7babb
Merge "Add isDictionaryAvailable to SubtypeSwitcher"
2012-04-12 04:46:29 -07:00
cf6b2099be
Add isDictionaryAvailable to SubtypeSwitcher
...
Change-Id: I534878d330b57bbfaa8b7711082456969771f4dc
2012-04-12 19:46:02 +09:00
0f87ca72f7
Start typing timer when key is pressed
...
Bug: 6327144
Change-Id: I5df0073ff38ac25e46455ef459121528c86a8dbe
2012-04-12 17:55:22 +09:00
45213ed2a6
Polish fade-in/out animations for the gray-out-while-typing keys
...
Bug: 6326723
Change-Id: Idb6fa023c497cf1f0f584f496e7e5ae82b1c9f4f
2012-04-12 16:43:24 +09:00
f1678ba802
Don't cancel key typing timer when new keyboard is set
...
This change also fixes some typos.
Bug: 6312143
Change-Id: I5d752c05b128a47ed022a4a804b02559eeee6915
2012-04-12 15:35:44 +09:00
cec8552b18
Pass a parameter to the dict pack if we don't have a default dict
...
Also, optimize quite a bit the code that decides whether we have
a default dict or not.
Bug: 5705834
Change-Id: Ied20fbcbbc42cbe8c01759d11b1804d1156c6960
2012-04-12 13:05:31 +09:00
fed44d08d8
Merge "change ResearchLoggerTests to check file"
2012-04-11 13:19:52 -07:00
b8e2ae3bc3
change ResearchLoggerTests to check file
...
multi-project commit with I587003f2
Bug: 6188932
Change-Id: I3d3f0c9d011301489473dc330338ea4a7ba61e9e
2012-04-11 11:17:44 -07:00
e6269759d6
Read the dictionary resource in a more sensical place.
...
We don't need to pass this down all the way from LatinIME any more.
It fetched be done exactly where it needs to be.
Change-Id: I9f277f9c4f9de70ae755a1334d86c67bbb24c988
2012-04-11 21:03:21 +09:00
9d95a99626
Merge "Add language suffix to main dictionary"
2012-04-11 00:21:47 -07:00
78ab80844b
Add language suffix to main dictionary
...
Bug: 6319377
Change-Id: Ie6a887fefa12e33c17bfeb5d22984e7c1a7bdb46
2012-04-11 16:11:34 +09:00
ab0d0d8a02
Add followKeyLabelRatio flag for keyLabelFlags of Key attribute
...
This change renames largeLetter flag to followKeyLargeLetterRatio as
well.
Change-Id: Ida777aac57e4d885fa051654fe863f493f8e946a
2012-04-11 15:53:38 +09:00
10f18f5fb7
Use system locale for labels on no language keyboard
...
Bug: 6010147
Change-Id: I9a6ce1bf82ca13359f715f4d1fc5f2bf15d4ee6e
2012-04-11 14:38:06 +09:00
2be51f4fd0
Generate KeyboardLabelsSet from donottranslate-more-keys.xml
...
This change introduces makelabel tool that reads all languages'
donottranslate-more-keys and generate KeyboardLabelsSet.java source
file. The makelabel command must be invoked prior to compile LatinIME.
Change-Id: I7515c7919c535e30f9c80a37bdc831d0f682cd43
2012-04-11 11:23:47 +09:00
ecd2ac93bc
Add an expandable binary dictionary that can be modified at runtime and works with native algorithms.
...
Bug: 6188977
Change-Id: Iec5c4e7d1d3918ac645187bd32dc3f82a95fec1e
2012-04-10 10:17:52 -07:00
8834e3dbce
Fix KeyboardCodesSet code mapping
...
This is a follow up for Icfd6d06f.
Change-Id: I9a11c6f1c8d9654e3fb004940791055c2bcf9f17
2012-04-10 15:09:26 +09:00
7f0c503afc
Use !icon/<icon_name> notation for more keys spec
...
Change-Id: I616e6c1ac603d2eb7a5c99ec70d5411371d15f3e
2012-04-10 12:01:07 +09:00
ed3bac91f2
Introduce KeyboardCodesSet.java and remove keycodes.xml
...
Change-Id: Icfd6d06f47425aa037682d22c895548ba6f047d8
2012-04-10 11:53:58 +09:00
a9ca7867b5
move suggested words logpoint to SuggestionsView.java
...
Bug: 6188932
Change-Id: I73974783783bb4453962cb9009656d86d2074409
2012-04-09 16:24:29 -07:00
9bc29d78a6
add more data collection points to ResearchLogger (attempt #2 )
...
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.
multi-project change with I159f5de2
this CL is the same as I618bcd07, which was reverted because of
incompatibilities with vendor branches.
Bug: 6188932
Change-Id: I999249dceb0c04f5a4ffbfff25caed09d24a2c52
2012-04-09 09:38:07 -07:00
d16bda4a4a
Revert "add more data collection points to ResearchLogger"
...
This reverts commit ac9e87c03e
2012-04-06 18:26:34 -07:00
ac9e87c03e
add more data collection points to ResearchLogger
...
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.
Bug: 6188932
Change-Id: I618bcd07b22c9efc794745678b073afe1e79a697
2012-04-06 09:35:13 -07:00
b5e1f48987
Remove the now useless Flag class.
...
Change-Id: Ibe45189b73e2606cf77e30da166dd0d45ae47c5c
2012-04-06 19:47:16 +09:00
338d3ec725
Replace the flags in getSuggestions with a boolean.
...
Change-Id: I0ec44df1979cb1dc21017ea290d2151a2af0e7cd
Conflicts:
java/src/com/android/inputmethod/latin/Suggest.java
2012-04-06 19:34:48 +09:00
24aee9100e
Change the flags to a boolean in constructors.
...
Change-Id: I9939204f3b16346aaebd4d726315ba9c4faf910a
2012-04-06 19:33:01 +09:00
f420df2823
Add support for German umlaut and French ligatures flags
...
Bug: 6202812
Change-Id: Ib4a7f96f6ef86c840069b15d04393f84d428c176
2012-04-06 17:07:29 +09:00
b8060399c7
Remove constructors
...
And small cleanup.
Change-Id: I1de903f42c1b8d57a488be2162e0b94055a6d1f2
2012-04-06 16:53:15 +09:00
8cf1a8d04f
Remove the shortcutOnly attribute which is now useless.
...
Change-Id: Ifccdfdaf7c0066bb7728981503baceff0fedb71f
2012-04-06 16:27:53 +09:00
b6313f7275
Merge "Cleanup unused methods"
2012-04-05 23:46:56 -07:00
7540fd009d
Merge "Fix the locale of the flags in BinaryDicitonary for tests"
2012-04-05 22:33:17 -07:00
a4c7733cf7
Cleanup unused methods
...
Change-Id: Ic7c1ec0e0606da6eb5b954934547c6e8a561fed5
2012-04-06 12:27:53 +09:00
fc169c726a
Merge "Use keyboardSet extra value of subtype to specify layout type"
2012-04-05 19:17:30 -07:00
26c80a1b9a
Set view properties for Key node infos.
...
Bug: 6298716
Change-Id: Iae0616f0095d32e0ca61dcb55f2f84744e91f60e
2012-04-05 14:56:57 -07:00
af7d86c5b8
Merge "Update the names and default values of bigram options."
2012-04-05 05:08:56 -07:00
80f2ccc236
Update the names and default values of bigram options.
...
Bug: 6293595
Change-Id: I9978a1127c64b7a26a5ccf6f777366f7c4e214db
2012-04-05 21:07:40 +09:00
aa300bb73a
Don't draw red underline for manually picked words that came from bigram prediction
...
Change-Id: I544680c8b4b1baff71bd08168630a34e803c40b9
2012-04-05 20:50:27 +09:00
11d9ee742f
Use keyboardSet extra value of subtype to specify layout type
...
Change-Id: Ice1f345a08a8d760e3b847c885c4072e3e142c97
2012-04-05 17:25:15 +09:00
ae234abd21
Fix the locale of the flags in BinaryDicitonary for tests
...
Bug: 6129372
Change-Id: I5611f88b10c44261b6145c9dc8615b80e4341e77
2012-04-05 12:48:30 +09:00
cb389ef0d6
Refactor to utilize InputMethodSubtype
...
Change-Id: I76fbc8a395eb8dab996c02c86d7328f07865f8cf
2012-04-05 12:27:27 +09:00
43ebd8a035
Fix the locale of flags in BinaryDictionary
...
Bug: 6129372
Change-Id: I4958c2aabf651d7e26648a29b75fcc6c77813451
2012-04-04 21:50:42 +09:00
b082c95a2b
Use no language "zz" to disable shortcut key
...
Change-Id: Ifba5bbd4298ecf84cc5e0ebdb4fc8494eafff62e
2012-04-04 14:35:55 +09:00
c7e43a7aec
Merge "Use language agnostic QWERTY for forceAscii"
2012-04-03 21:06:52 -07:00
234bf612ca
Merge "Use "No language (QWERTY)" for language agnostic QWERTY keyboard name"
2012-04-03 21:03:10 -07:00
32bfc1601a
Use language agnostic QWERTY for forceAscii
...
Bug: 6286208
Change-Id: I1b3b6f04c9033e7dc57a30e8dce43e01428b8e4e
2012-04-04 12:59:58 +09:00
3bf57a5624
Use "No language (QWERTY)" for language agnostic QWERTY keyboard name
...
Bug: 6010147
Change-Id: I401c2e3fcd639c0e1a03e64489a0d792810caa18
2012-04-04 12:58:42 +09:00
d8af793983
Merge "Fix NPE in SuggestedWords"
2012-04-03 19:23:03 -07:00
f088204a90
Fix NPE in SuggestedWords
...
Bug: 6279966
2012-04-04 11:09:13 +09:00
fde7efd877
Add private constructor to utility classes
...
Bug: 6129704
Change-Id: I52925ae7bd80683f63efc48649448865a5654f41
2012-04-03 18:01:04 +09:00
d2c5533fd9
Merge "Add RunInLocale class to guard locale switching"
2012-04-03 01:53:05 -07:00
56dda78d52
Merge "Cleanup InputTypeCompatUtils to InputTypeUtils"
2012-04-03 01:50:08 -07:00
16c6f35570
Add RunInLocale class to guard locale switching
...
Bug: 6128216
Change-Id: I8d9c75c773c3de886183b291ada7a3836295839b
2012-04-03 17:43:45 +09:00
be55086fd9
Cleanup InputTypeCompatUtils to InputTypeUtils
...
Bug: 6129704
Change-Id: I45e19e456ef7c6e61fe877ea544fef1b9f896e95
2012-04-03 17:42:19 +09:00
b07939764a
Merge "Fix typo"
2012-04-03 01:31:47 -07:00
8f433a66b2
Fix typo
...
Follow up for I5b9964f2
Bug: 6129704
Change-Id: Ia90c013cf4c4e6f675da5701644bd10833898c3f
2012-04-03 17:27:51 +09:00
78e333594b
Remove ViewParentCompatUtils
...
Bug: 6129704
Change-Id: I429dcbec01bb4d33064ab1e3d597640d76c53d2f
2012-04-03 17:26:06 +09:00
c6435f92a8
Remove AccessibilityManagerCompatUtils and MorionEventCompatUtils
...
Bug: 6129704
Change-Id: Icb7e80588536066c4fe5b4a1afc100a724b43e7b
2012-04-03 16:51:02 +09:00
244c825c4b
Merge "Cleanup EditorInfoCompatUtils"
2012-04-03 00:49:55 -07:00
7a0779a441
Merge "Cleanup FrameLayoutCompatUtils to ViewLayoutUtils"
2012-04-03 00:47:32 -07:00
0d1a5d5b97
Cleanup EditorInfoCompatUtils
...
Bug: 6129704
Change-Id: I5b9964f2ad52e7cd60c63acca93d0241a1e729ef
2012-04-03 16:45:36 +09:00
13d6ecc4c2
Remove InputMethodServiceCompatWrapper
...
Bug: 6129704
Change-Id: I76f2854e27623be940a711d0d48fd3f90132141c
2012-04-03 16:02:09 +09:00
8443af57ba
Merge "Remove InputMethodSubtypeCompatWrapper"
2012-04-02 23:57:43 -07:00
9cc2c94c8b
Remove InputMethodSubtypeCompatWrapper
...
Bug: 6129704
Change-Id: I8f84f0f61a2205ac1fcd1cd40e3a586ee535282d
2012-04-03 15:31:26 +09:00
c734c2aca1
Add a simple way to input dictionary header attributes
...
Just add them as an attribute to the root of the XML node.
Bug: 6202812
Change-Id: Idf040bfebf20a72f9e4370930a85d97df593f484
2012-04-03 15:18:51 +09:00
19457316c1
Remove CAN_HANDLE_ON_CURRENT_INPUT_METHOD_SUBTYPE_CHANGED boolean
...
Bug: 6129704
Change-Id: I7643e656c6e7656eff339cc301dd32f34dee83a4
2012-04-02 23:22:49 +09:00
b1904ec235
Merge "Remove InputMethodInfoCompatWrapper"
2012-04-02 07:14:20 -07:00
c8461d1ae2
Cleanup FrameLayoutCompatUtils to ViewLayoutUtils
...
Bug: 6129704
Change-Id: I52f2e236c7dae3ac2cba64392165f955a53d3f42
2012-04-02 22:55:12 +09:00
0dbf6ab53d
Remove InputMethodInfoCompatWrapper
...
Bug: 6129704
Change-Id: I0eca1ee7d1769ddc44f93c50f0723196299bc6d6
2012-04-02 21:33:49 +09:00
7e518d8b83
Combine candidate words and scores
...
Bug: 5240798
Change-Id: Ie56c1c2cfd7f365e771fee88c1ed15012448feed
2012-04-02 18:39:24 +09:00
209dd09e5a
Come back the proximity correction to ExpandableDictionary
...
Bug: 6242539
Change-Id: Ic0467d54c9d85d0653812d4e127328878ef15b94
2012-04-02 15:01:21 +09:00
96fdc4dd84
Remove InputConnectionCompatUtils
...
Also, small cleanup in proguard.flags
bug: 6129704
Change-Id: If4cc694dbe74b26b1d0da301bbc321ee7afc0211
2012-03-31 19:04:38 +09:00
672635493e
Remove ArraysCompatUtils
...
bug: 6129704
Change-Id: I0f1a0dee744e6dcdea7ae8606119b4af22b86663
2012-03-30 22:50:53 +09:00
cba3887b2f
Remove the SharedPreferencesCompat class that is unused.
...
bug: 6129704
Change-Id: Ib3f5ce242e016d2ffcefae915a312e5a9aeb9845
2012-03-30 22:40:11 +09:00
376eb52450
Move VibratorCompatWrapper to VibratorUtils.
...
bug: 6129704
Change-Id: Ib63f1ed2d610e27e14957cf8805ef884cae6adf6
2012-03-30 19:23:12 +09:00
3224878351
Merge "Add language agnostic QWERTY subtype"
2012-03-30 03:03:55 -07:00
fb5b4c4fc3
Add language agnostic QWERTY subtype
...
Bug: 6010147
Change-Id: I705e38ac889172ae8b7c2a68e5c688f2ffc28320
2012-03-30 18:20:52 +09:00
b264de67ea
Remove unused resources
...
Follow up to Ib27f2774
Bug: 6129704
Change-Id: I75b892a5f97270c270441a00f98e6e7ea1abc424
2012-03-30 18:06:09 +09:00
911b8f9d19
Remove the "deprecated" classes
...
bug: 6129704
Change-Id: Ib27f2774444e1f084b19be3fe6f56d25dffa7084
2012-03-30 16:20:56 +09:00
347fcab043
improve ResearchLogger performance
...
also demonstrate proposed logpoint invocation
Bug: 6188932
Change-Id: Ib6a7a196fe2e5f8184d26d1e0e3e91b404454112
2012-03-29 15:37:41 -07:00
8acbce1f78
Merge "Separate leftward arrow from "add to dictionary" hint text"
2012-03-29 01:20:07 -07:00
20b4c223b4
Merge "Fix some obvious compiler warnings"
2012-03-29 00:18:36 -07:00
499c5e8ad8
Merge "Don't send touch coordinates if proximity characters correction is disabled"
2012-03-29 00:18:28 -07:00
8dcad2ed47
Don't send touch coordinates if proximity characters correction is disabled
...
Bug: 6225317
Change-Id: I4fa65e020d838f53066d4a071f58fb6f40583e0b
2012-03-29 16:11:54 +09:00
aaa9e8626a
Merge "Fix race condition while changing the system locale"
2012-03-29 00:10:35 -07:00
2eb8781dc2
Separate leftward arrow from "add to dictionary" hint text
...
Bug: 6008875
Change-Id: I2be1698e485bc6541163771f41b8b82eaa3cee7a
2012-03-29 15:58:26 +09:00
c61cd79229
Fix some obvious compiler warnings
...
Change-Id: I10a634f7492b45d5a72345f14d36cf341946387d
2012-03-29 15:07:53 +09:00
7769b76fc9
Fix race condition while changing the system locale
...
Bug: 6128216
Change-Id: Ie153e3eb18feeb97aada6a7708075f5152f11999
2012-03-29 14:36:45 +09:00
2d9483ff16
make ResearchLogger log write only
...
Bug: 6188932
Change-Id: I8a8f944b1d4ee858d5ecaad0d3adc6dc7af54f68
2012-03-28 17:36:05 -07:00
428484d6f9
Merge "Remove useless adding of shortcut as unigrams."
2012-03-28 04:41:05 -07:00
e705a122d1
Remove useless adding of shortcut as unigrams.
...
Change-Id: I1f50ebf00d6dd0dad4114fad86ace5b7b304613a
2012-03-28 20:40:38 +09:00
aacffad8ef
Merge "Add read support for string shortcuts for makedict."
2012-03-28 04:40:28 -07:00
752996540f
Add read support for string shortcuts for makedict.
...
Change-Id: I48ee4fc9ac703ad2a680b3cd848de91c415ea3c8
2012-03-28 20:40:08 +09:00
7b49efdea6
Merge "Change the format of the shortcuts in the binary dict."
2012-03-28 04:39:55 -07:00
a501caa9a5
Merge "Remove SupportTouchPositionCorrection from subtype extra value"
2012-03-28 04:36:27 -07:00
3bbb31f3f0
Change the format of the shortcuts in the binary dict.
...
This only includes the write part of the change. The read part is
coming in a different commit.
Change-Id: Iabe7af6cd134462dc19245f5400719920ed31c8f
2012-03-28 20:24:07 +09:00
e07db71d26
Remove SupportTouchPositionCorrection from subtype extra value
...
Change-Id: Ieedff9ec212f5567405ca276b0f2194132ba7b0c
2012-03-28 19:45:28 +09:00
6ba8de2a60
Good bye the proximity logic in Java code
...
Bug: 4343280
Change-Id: I82f7d08703647a3492ce6e2d3b741146df58927e
2012-03-28 18:42:30 +09:00
67094f5bde
Do not re-calculate primary code in WordComposer
...
Bug: 4343280
Test: Ib43c0f1d1a19d067ea0
Change-Id: I3393a6099cb7fb824994f4656ccfef884f9c6bc4
2012-03-28 17:23:10 +09:00
9611b281e1
Fix AIOOBE
...
Bug: 6236912
Change-Id: Ie09e5ef1c23eb48621ac3f2f2dc28dc2e46ca288
2012-03-28 13:02:14 +09:00
f71aee8f4f
Tighten up the "define" classes.
...
Change-Id: I854b1dd56b676d0a492a15c16bfe4c6a1bcccdf7
2012-03-27 22:43:25 +09:00
b10e06feea
Merge "Use FontMetrics.top and padding to place keyHintLetter"
2012-03-27 02:51:02 -07:00
72fb8e05f9
Use FontMetrics.top and padding to place keyHintLetter
...
Bug: 6225638
Change-Id: Ia3680d84bd1e7ccbdb87aedca106641c6d270677
2012-03-27 17:47:33 +09:00
0a1b00869d
Merge "Put a misspelled flag if the word is not valid by the same logic of Android spell checker."
2012-03-27 01:16:54 -07:00
356776a9b7
Put a misspelled flag if the word is not valid by the same logic of Android spell checker.
...
Bug: 6222722
Currently, the flags of the suggestion span from the Latin IME is different from the flags from Android spell checker.
Change-Id: I2f7a54ae0d63235a0b94e039109ab8b2f1311055
2012-03-27 17:11:48 +09:00
01ab7c8b59
ongoing cleanup 2
...
Change-Id: I66b61cbe491cf8375144e834390beae3209a777d
2012-03-27 16:28:48 +09:00
c166697e3f
Optimization: Start making use of ProductionFlag.IS_EXPERIMENTAL for ResearchLogger
...
Move GodMode specific tests to relevant directories as well.
This goes along with I9dc4d469
Change-Id: I4a21c53846b26eede346cb1da13e6abbdf9ec27f
2012-03-27 11:55:23 +09:00
2ac1fad645
Merge "Add a flag file for the experimental mode"
2012-03-26 04:53:49 -07:00
9b2f77f2b1
Add a flag file for the experimental mode
...
Change-Id: I880b7c85dbc20f8d7590b7f65b5f898bfb2266f9
2012-03-26 18:52:46 +09:00
d2cd3d54f9
Merge "Split a method for reuse"
2012-03-26 02:12:20 -07:00
400ff86c7b
Merge "add tests for ResearchLogger"
2012-03-26 01:49:09 -07:00
2482e6c386
add tests for ResearchLogger
...
Bug: 6188932
Change-Id: Icf407f9d145d2b25b70d5d7bc30ee3d64561620c
2012-03-26 17:21:50 +09:00
8403611960
Split a method for reuse
...
Change-Id: I9a82e538903f05bedad51bc195866abbd9daf957
2012-03-26 16:34:29 +09:00
27bb631f4c
Merge "Add ZWNJ and ZWJ icons"
2012-03-25 23:46:29 -07:00
39390d3f94
Add ZWNJ and ZWJ icons
...
Bug: 5456620
Change-Id: I7238f41c841803746ca2ab6cd332b2be8498a3ee
2012-03-26 13:05:29 +09:00
99eb2d3404
Merge "Convert dimension unit "in" and "mm" to "dp""
2012-03-25 20:21:00 -07:00
a77bbc64f0
Merge "Correct a shaky processing and move it to a better place"
2012-03-25 17:57:49 -07:00
e327628855
update ResearchLogger times to report SystemClock.uptime()
...
Bug: 6188932
Change-Id: I852537caed46958e4d9c3251664edaa69652205c
2012-03-24 22:41:11 +09:00
d05afa3f4c
move usability log code to new class (ResearchLogger) and clean api
...
This change also undoes the effects of I8694eb9016, which was an initial
effort built on Utils.UsabilityStudyLogs. Now Utils operates as it did
previously, for backward compatibility, but the ResearchLogger retains
the new log format.
Coordinated with I274b75c5.
Bug: 6188932
Change-Id: I41208bdc6b511f69a010c9fc38a936521beba7d5
2012-03-24 20:14:42 +09:00
08baf5ff8e
Merge "Fix a native crash"
2012-03-23 06:40:50 -07:00
b0b89c87f6
Fix a native crash
...
-1 & 0xFFFF is 65536 :p
Change-Id: I8ecb882b6d6c5bcc91b52e23eb9cc02b04fcdd34
2012-03-23 22:36:00 +09:00
fce9ca4202
Merge "Remove verbose debug message"
2012-03-23 06:25:13 -07:00
61f24842c7
Remove verbose debug message
...
Change-Id: I05bfe24228a6fbe806987d2a0d81e59611c3b476
2012-03-23 22:23:56 +09:00
380ad509e6
Merge "Optimization and typo fix"
2012-03-23 06:20:58 -07:00
b163f91621
Merge "Add support for updating and adding bigrams to existing nodes."
2012-03-23 05:57:55 -07:00
7cfe20efbe
Add support for updating and adding bigrams to existing nodes.
...
Bug: 6188977
Change-Id: I48aca8ba199247d73395ab13b9d1976f4e739208
2012-03-23 21:52:39 +09:00
71f9d30b18
Correct a shaky processing and move it to a better place
...
The old code would remove caps from the first letter if
auto-capsed but that makes very little sense when the word
is camel-cased. Also, it would not correctly handle
surrogate pairs, and would require a direct reference to
LatinIME and a specific method to do the processing in an
unexpected place.
Change-Id: I416d6a805242788a2473f007ca7452c9fe3f5205
2012-03-23 21:40:07 +09:00
3ee7d97587
Optimization and typo fix
...
Change-Id: Iafa414b8bcf2cca4569b3753bfac58f301a72269
2012-03-23 21:29:30 +09:00
2a04637f60
Convert dimension unit "in" and "mm" to "dp"
...
Bug: 6183561
Change-Id: I06d74705fd49566684815853b8f2df7b5a9f9d7e
2012-03-23 21:21:26 +09:00
ad29273553
Merge "Override the keyboard height per device"
2012-03-23 05:19:36 -07:00
e49a987c23
Override the keyboard height per device
...
Bug: 6183561
Change-Id: I7432552fbe41212e8f412962b16877a2af07eb9c
2012-03-23 21:17:05 +09:00
8980bd4a25
Merge "Cleanup jni 1"
2012-03-23 03:24:08 -07:00
9df4a4527a
Cleanup jni 1
...
Change-Id: Ieb6af8385356e259720b50f1fe46a694a098b30f
2012-03-23 19:03:20 +09:00
c4f69e7d68
Merge "Stop creating useless objects"
2012-03-23 02:56:10 -07:00
0e134a4477
Merge "Small optimization"
2012-03-23 02:47:54 -07:00
a492790982
Stop creating useless objects
...
Man that was bad, it's heavy, it's called quite often, and it's
totally useless
Change-Id: Ia7e23e0e60ff4a929b226f3f4ccabedbc3ea2c06
2012-03-23 17:55:11 +09:00
e5f02cff7a
Small optimization
...
Change-Id: I5dd7c848f2aaec20325e7ee85f27e282e1ba7a85
2012-03-23 17:03:55 +09:00
cc78d03a62
Add processing for French ligatures.
...
Bug: 5140033
Change-Id: I1c2751fc617e662aad9f67506e28a622f81d0bc9
2012-03-23 16:50:59 +09:00
066866954a
Add a missing comparison in Word.equals()
...
Follow up to I94e2e29c
bug: 6209651
Change-Id: Iff2daca8c2678e2d1796f98d6db738f109e3d03f
2012-03-23 14:41:16 +09:00
6ef88a8901
Merge "Add missing Word.hashCode()"
2012-03-22 22:11:51 -07:00
9f0ea52a5d
Add missing Word.hashCode()
...
Some cleanups too.
bug: 6209651
Change-Id: I94e2e29c92e90e554e4952d277d590e093766c4f
2012-03-23 13:11:39 +09:00
081616cd2f
Send correct coordinates for the spell checker
...
This results in the computation being done in native code
and the correct proximity being used.
Bug: 6181080
Change-Id: I08fa05c781d607e4feca2caeda353ec19c133a3d
2012-03-23 13:02:58 +09:00
e7cfe43652
Merge "Don't rely on spell checker proximity in tests"
2012-03-22 02:15:29 -07:00
8e31d76983
Merge "Make some constants more explicit."
2012-03-22 02:15:21 -07:00
109728193e
Don't rely on spell checker proximity in tests
...
This fixes the input logic tests that were broken and suppresses
their dependency upon the spell checker proximity. Instead, it
gets the Keyboard instance from Latin IME and uses the actual
coordinates, which results in a test run closer to what actually
happens during typing.
Change-Id: I3a81d249ee7fb3ac6ae6940aa2e8b2421e829e5c
2012-03-22 18:08:23 +09:00
9835808e83
Merge "Use ObjectAnimator"
2012-03-22 01:39:01 -07:00
330cd291fa
Make some constants more explicit.
...
This wasn't very obvious, but the actual values are critical, so
make it more readable
Bug: 6181080
Change-Id: I07461d2df4c796dad0cb6f5283e41a28036d023c
2012-03-22 14:28:05 +09:00
31c94cea82
Use ObjectAnimator
...
Bug: 6187069
Change-Id: I7df18b470b7e746da601fab3311fb4b086f40d41
2012-03-22 12:44:46 +09:00
19b8a73efa
Merge "log through group level abstractions"
2012-03-21 20:30:35 -07:00
fdd68f0657
log through group level abstractions
...
For the groups:
- LogGroup.MOTION subfields now deteremined in Utils.writeMotionEvent() rather
than in LatinKeyboardView.processMotionEvent()
- LogGroup.KEY is now logged throguh LatinIME.onCodeInput() rather than
Utils.push(). This catches keys more generally, including modifiers, and
records touch positions for everything. Removed now-redundant
Utils.writeBackspace() and Utils.writeChar().
- LogGroup.CORRECTION uses Utils.writeCorrection(), and formats instead of
leaving this to callers.
- LogGroup.STATE_CHANGE uses Utils.writeStateChange(). Optional fields are
still left to callers, as this group has more variety.
Formats have changed to incorporate new fields.
Minor housekeeping:
ENABLE_USABILITY_STUDY_LOG constants replaced with variable references, as
the logging feature can be changed in Settings and therefore dynamically
changes.
New log format:
20120322-111203.621+0900 1332382323621 s [onStartInputView] com.socialnmobile.dictapps.notepad.color.note 2131624043 147457 1140850694
20120322-111204.912+0900 1332382324912 m [Down] 2782355 0 243 171 0.5666667 0.895
20120322-111204.975+0900 1332382324975 m [Move] 2782419 0 240 171 0.6 1.17
20120322-111204.983+0900 1332382324983 m [Move] 2782428 0 238 171 0.6 1.1899999
20120322-111204.992+0900 1332382324992 m [Move] 2782437 0 236 171 0.6 1.1899999
20120322-111205.002+0900 1332382325002 m [Move] 2782446 0 232 170 0.6 1.1899999
20120322-111205.012+0900 1332382325012 m [Move] 2782456 0 227 169 0.6 1.125
20120322-111205.021+0900 1332382325021 m [Move] 2782465 0 224 168 0.6 1.125
20120322-111205.031+0900 1332382325031 m [Move] 2782475 0 221 167 0.6 0.895
20120322-111205.040+0900 1332382325040 m [Move] 2782483 0 213 164 0.6 0.58
20120322-111205.047+0900 1332382325047 m [Up] 2782491 0 213 164 0.6 0.58
20120322-111205.052+0900 1332382325052 k 'D' 243 171
20120322-111205.228+0900 1332382325228 m [Down] 2782622 0 171 71 0.6333334 1.275
20120322-111205.243+0900 1332382325243 m [Move] 2782677 0 178 69 0.6333334 1.275
20120322-111205.325+0900 1332382325325 m [Up] 2782750 0 178 69 0.6333334 1.275
20120322-111205.333+0900 1332382325333 k 'e' 171 71
20120322-111205.509+0900 1332382325509 m [Down] 2782936 0 265 139 0.53333336 0.885
20120322-111205.512+0900 1332382325512 m [Move] 2782954 0 265 141 0.53333336 1.04
20120322-111205.552+0900 1332382325552 m [Move] 2782973 0 265 143 0.5666667 1.14
20120322-111205.663+0900 1332382325663 m [Up] 2783102 0 265 143 0.5666667 1.14
20120322-111205.668+0900 1332382325668 k 'f' 265 139
20120322-111206.140+0900 1332382326140 m [Down] 2783584 0 348 352 0.53333336 0.675
20120322-111206.206+0900 1332382326206 m [Move] 2783648 0 348 354 0.5666667 0.73499995
20120322-111206.223+0900 1332382326223 m [Move] 2783666 0 348 356 0.5666667 0.545
20120322-111206.232+0900 1332382326232 m [Up] 2783674 0 348 356 0.5666667 0.545
20120322-111206.236+0900 1332382326236 k ' ' 348 352
20120322-111206.245+0900 1332382326245 c [----] Def -1
Bug: 6188932
Change-Id: Iea46a0c683f858b72005b8e81191ef1d70262dca
2012-03-22 12:02:10 +09:00
2aa02b84a4
Revive the Makefile for makedict
...
Follow up to I4d2ef504. Address a compiler warning and a small optimization as well.
bug: 6188977
bug: 6209651
Change-Id: Ibc9da51d48ebf0b8815ad0bb2f697242970ba8f7
2012-03-22 11:55:18 +09:00
7ac556216d
Merge "Move makedict to LatinIME android keyboard."
2012-03-21 05:50:28 -07:00
221dd3d183
Merge "Add additional structure to output logs to group entries by optional fields."
2012-03-21 05:50:01 -07:00
4897df803d
Merge "Refactor key drawing code in KeyboardView"
2012-03-21 04:31:55 -07:00
72913f97ed
Refactor key drawing code in KeyboardView
...
Change-Id: Ic7af05caee32eb6cba68d27ba4e2d9072472b34d
2012-03-21 20:29:51 +09:00
4cc44f9f77
Merge "Refactor to memorize device dependent override parameters"
2012-03-21 04:26:39 -07:00
78bf41b89c
Add additional structure to output logs to group entries by optional fields.
...
The new format has time, time as int, and the new logGroup code
(m=motionEvent, k=key, s=statechange, c=correction)
followed by additional text whose format depends on the logGroup code.
The additional text will be cleaned up in later CL's.
20120321-170548.067+0900 1332317148067 m
[Down]143116235,0,691,378,0.40000004,0.435
20120321-170548.133+0900 1332317148133 m
[Up]143116302,0,691,378,0.40000004,0.435
20120321-170548.146+0900 1332317148146 k <enter> 691 378
20120321-170602.485+0900 1332317162485 s
[onStartInputView]com.socialnmobile.dictapps.notepad.color.note,2131624043,147457,1140850694
20120321-170606.508+0900 1332317166508 m
[Down]143134679,0,40,154,0.4666667,0.64
20120321-170606.567+0900 1332317166567 m
[Move]143134723,0,42,154,0.4666667,0.765
20120321-170606.577+0900 1332317166577 m
[Move]143134746,0,44,154,0.4666667,0.775
20120321-170606.652+0900 1332317166652 m
[Up]143134824,0,44,154,0.4666667,0.775
20120321-170606.662+0900 1332317166662 k A 40 154
20120321-170607.200+0900 1332317167200 m
[Down]143135372,0,411,390,0.53333336,0.585
20120321-170607.311+0900 1332317167311 m
[Up]143135483,0,411,390,0.53333336,0.585
20120321-170607.313+0900 1332317167313 c [----]A
Bug: 6188932
Change-Id: I8694eb9016d8cf0389ef582f6c7d2820aa4d2c92
2012-03-21 19:41:10 +09:00
e276c2401e
Move makedict to LatinIME android keyboard.
...
Bug: 6188977
Change-Id: I4d2ef504bb983abbda3cb52ee450cb46f58d95cf
2012-03-21 19:30:26 +09:00
624f1bab39
Refactor to memorize device dependent override parameters
...
Change-Id: I79482a8ef3846525669979a30dec183ea18138b5
2012-03-21 18:20:18 +09:00
32aac4777f
Merge "Correctly close the gzip stream"
2012-03-21 01:32:07 -07:00
bc89f5d3a5
Correctly close the gzip stream
...
I had gotten the chain call in reverse.
Bug: 6177523
Change-Id: Ic5b76425de2d5d05d5132f8d2c7ade0d79c14ccc
2012-03-21 17:28:37 +09:00
f5f53c2fa6
Merge "Strengthen java code against bad returns from native"
2012-03-21 00:54:25 -07:00
6ca3ac08ed
Strengthen java code against bad returns from native
...
This doesn't really fix the following bug but it may alleviate
the symptoms
Bug: 6191885
Change-Id: I0de3f550cc7c6cdf79b291399785ad31b205d2ac
2012-03-21 16:40:26 +09:00
140467b8b6
Updated logger to record touch position within backspace key events.
...
Bug: 6188932
Change-Id: Ida2aff618153792f9803f30f1251d67c89af1fe0
2012-03-20 23:29:34 +09:00
1fe943aabd
Merge "Cleanup proximity related code"
2012-03-19 02:40:25 -07:00
728d1c884e
Cleanup proximity related code
...
Bug: 4343280
Change-Id: I57c0f9e20d9d8911009ea97057251a7f7a81512f
2012-03-19 18:33:59 +09:00
546b8275ab
Merge "Add a dummy file and package for make dict"
2012-03-19 02:01:05 -07:00
6d7e0a876b
Merge "Fix TAG name"
2012-03-19 00:52:44 -07:00
9a50777890
Fix TAG name
...
Change-Id: Ibea065bc72e6b5e40cfa3ffa2fb6bcdeb107ffc4
2012-03-19 16:11:17 +09:00
905670bd87
Add a dummy file and package for make dict
...
Change-Id: I195fd42f2a773bcc6fab0a61336a1c15d97902bb
2012-03-19 15:26:13 +09:00
f9c2773b09
Merge "Make the primary character stable"
2012-03-18 22:01:50 -07:00
d6d0f6976c
Make the primary character stable
...
Bug: 4343280
Change-Id: I3e6eaa3803dc32a837825f3a64403430721b6192
2012-03-19 12:49:16 +09:00
9ffb94fa13
Rename the user history dictionary.
...
UserBigramDictionary -> UserHistoryDictionary.
Also update all methods, strings and comments, except those needed
for backward compatibility (which only include the name of the
database file).
Change-Id: I0bccea29880dc566b90100575b83baaa947b03ae
2012-03-19 12:03:51 +09:00
660776e09b
Small performance improvement by removing interface accesses.
...
Change-Id: I6d91f3b086470b79306dbe2874db9748b9e0eb5f
2012-03-17 01:53:51 +09:00
cbb5053b6c
Fix NPE
...
bug: 6181736
Change-Id: I6522f19555c27f33c9ff4eaa8b2559a51a38f015
2012-03-17 01:37:53 +09:00
a50a34f8b4
Merge "Calculate proximity characters in the native code"
2012-03-16 01:38:07 -07:00
1caff47ecd
Calculate proximity characters in the native code
...
Bug: 4343280
Change-Id: I6adaf560f7a4f1f96dcb6ec2f61f20ee3001167e
2012-03-16 17:26:36 +09:00
d0d25ac8ec
Merge "Remove UserUnigramDictionary."
2012-03-16 01:11:52 -07:00
f73efa9077
Merge "Move the UserUnigramDictionary functionality over"
2012-03-16 01:05:10 -07:00
7dcbed04d9
Remove UserUnigramDictionary.
...
This isn't used any more.
Change-Id: Ie63ae621bcac9342b869b9f236f35bf66ec3a09b
2012-03-16 17:04:41 +09:00
c68d1bbfaf
Move the UserUnigramDictionary functionality over
...
UserBigramDictionary now assumes both functionalities. It will
be renamed to UserHistoryDictionary in a future change.
There are several reasons to do this. First, there is a lot of
duplicate code in User{Unigram,Bigram}Dictionaries that are
factored by the few lines of code in this change. Also, other
dictionaries like BinaryDictionary or ContactsDictionary all
assume both responsibilities, as should be the case
theoretically.
It is also possible to do this because previous versions don't
write any unigram data that we'd want to reuse. For even older
versions that do write data, we can't really make any sense out
of it. Bigram data however can be useful, and this allows us to
reuse it easily.
Change-Id: I755525f92744e1536eaef097527e8151b7859a30
2012-03-16 17:01:57 +09:00
9945f36406
Merge "Don't reset animation alpha value when keyboard is set"
2012-03-15 21:12:49 -07:00
c59e383977
Merge "Do not change the proximity orders"
2012-03-15 21:09:46 -07:00
ef08daddea
Do not change the proximity orders
...
Bug: 4343280
Change-Id: I4e2dfb00d9c843a8a285d409ac5ab8fca5fb1694
2012-03-16 12:54:17 +09:00
c24f66e180
Streamline some user history dictionary code
...
A lot of things don't really make sense in the old code.
Let's streamline it for now so that we have a cleaner interface
to work with. This is preliminary work for bug 4192129.
Change-Id: If01a5974cfadc43afced610c57fcf7fde67c1346
2012-03-16 12:22:39 +09:00
b9720a55b4
Don't reset animation alpha value when keyboard is set
...
The keys' blinking that mentioned in the bug is caused by switching
keyboard layout resets the animation's alpha value to opaque but the
animation is still running and changing the alpha value
asynchronously.
I think that switching keyboard layout between alphabet and symbols
doesn't imply that the user stops typing. So the keyboard view should
continue typing state timer to keep animations' alpha values changing
and never reset the value.
Bug: 6174273
Change-Id: Id795feaf44750358f30c1b3dc8e783a7e62aefe8
2012-03-16 10:08:48 +09:00
5bee1b00c8
Merge "Remove touch dead zone"
2012-03-15 05:16:56 -07:00
723aaa2eeb
Remove touch dead zone
...
KeyDetector should use the distance from the hit box to detect the
key.
Bug: 6174250
Change-Id: Id1745d90222d1d1a10467f194b45307c12449944
2012-03-15 20:16:43 +09:00
3fe263fac6
Extract an annoying method call
...
Change-Id: I78f22bb38222fea54a55e460fcf728bf941d15e9
2012-03-15 19:30:15 +09:00
6ec1209a33
Fix a bug where quotes and dashes are considered letters
...
Bug: 6174065
Change-Id: I702760d44ead0eeb60d06360aa3bb03c2ec73325
2012-03-15 18:18:52 +09:00
2be7a37acf
Small cleanup
...
Exit-fast, update comment, make a method private
Change-Id: Id103bf03aeef43a1a4d064ecabb819490dc5d39a
2012-03-15 15:54:25 +09:00
7c5f2bbd2a
Remove useless code
...
I tracked all the calls to the constructor, and the passed
list is never null. It's also final, so it's safe.
Change-Id: I320f907acee0b237bb286a9a183c18106809174a
2012-03-15 15:10:07 +09:00
042557b45b
De-duplicate a method
...
Change-Id: Ia1c80eeff00a55573bb311f07e1275da23bdcf98
2012-03-15 15:04:29 +09:00
e8ddfe4273
Remove useless code
...
Change-Id: I58de87c1ba4cd1130419191f63ff83b685604356
2012-03-15 14:51:22 +09:00
4e74658883
Optimization
...
All calls to this methods are made with an actual String. No sense
beating ourselves with an interface stick.
Change-Id: I6ef98286be6f81f73864b04f3a17e68f36a6e542
2012-03-15 14:48:47 +09:00
123407261c
Stop meaningless explicit null passing
...
Change-Id: I6950897d262f610d502b7f8293b9dd8d2b53e6e8
2012-03-15 14:37:40 +09:00
3187ba5dfe
Remove a now-useless flag.
...
This has been moved to the SuggestedWords object and is now
represented by a single flag instead of a flag in each suggestion.
Change-Id: I6e9a7cff5a7701de7e61b4de13baac25c9a87b1b
2012-03-15 14:21:02 +09:00
4f6cf258fe
Use the unique flag in SuggestionsView
...
Also, the first word in a sugestions list can never be
obsolete.
Change-Id: Ib21439aac8db4e6ce5b15b7a2aabe4222bc354db
2012-03-15 14:11:41 +09:00
03a3517075
Add info for obsolete suggestions in SuggestedWords
...
Change-Id: I9684c7b08244b34853ce8a99b6e9d885389f6687
2012-03-15 13:12:08 +09:00
5f9593593e
Remove useless stuff
...
Change-Id: I43dae30774c40a9d6e7396f8fa73ed4b82a7c777
2012-03-15 12:47:05 +09:00
ca3e7cbdf4
Move a computation closer to where it's used.
...
Change-Id: I5aee4c36ceaacbb1dbfc47c011f1e4aec4b9dca6
2012-03-15 12:23:16 +09:00
eb5ffdac90
Merge "Some readability improvement"
2012-03-14 18:47:32 -07:00
c787db51ed
Merge "Cut out a private method to make things more readable"
2012-03-14 18:47:26 -07:00
b9a5cb77f0
Merge "Minor optimization"
2012-03-14 18:47:21 -07:00
53d57ad6d3
Merge "Some code simplification"
2012-03-14 18:47:16 -07:00
05c54ffc7f
Merge "Really pass the y - touch correction to the native code"
2012-03-14 06:47:19 -07:00
853d9020ed
Really pass the y - touch correction to the native code
...
Bug: 4343280
Test: I11f8518d9ee
Change-Id: I4b90bdffffed9736af223ac83c1a54019add70bb
2012-03-14 21:54:52 +09:00
6bc9186457
Disabled key should respond if it is in the altCodeWhileTyping state
...
Bug: 6128215
Change-Id: I81e9980f8ffa5c5eaba30676c8433f542645de1d
2012-03-14 20:17:42 +09:00
3848ca6729
Merge "Gray out "alt-code-while-typing" key icon while typing"
2012-03-14 03:36:56 -07:00
73a46bfeb7
Gray out "alt-code-while-typing" key icon while typing
...
Bug: 6128215
Change-Id: Ie9c13d9d38aad6e92cc465e22f3ef20c80e0a36a
2012-03-14 19:36:24 +09:00
b8c471af47
Merge "Fix SuggestedWords.toString"
2012-03-14 03:28:22 -07:00
ea51bfd8a8
Fix SuggestedWords.toString
...
Change-Id: Ide3f605ce40e8c230f217bbf37ab016457ee91f1
2012-03-14 19:23:15 +09:00
2d5c40d873
Send key information even when the touch position correction is not triggered.
...
Bug: 4343280
Change-Id: Id24935f9f0f66ebaa799bb92537d842033427c4c
2012-03-14 19:01:08 +09:00
02e70cf999
Merge "Use HashSet to hold keys in Keyboard"
2012-03-14 02:54:21 -07:00
a5f7969f5b
Use HashSet to hold keys in Keyboard
...
This partially reverts Ie0554362.
Change-Id: I0de971c5efb4e8eb093be2a0793a08bd79baee22
2012-03-14 18:51:01 +09:00
271e5b6cb7
Some readability improvement
...
In-place replacements of visibly identical things.
Change-Id: I02b51bd7f63597e3428f0650b239e9a39ef5a7c7
2012-03-14 18:50:08 +09:00
0d0f182959
Cut out a private method to make things more readable
...
Change-Id: I791700890338e023bd86b8794dbc90379b91dc7d
2012-03-14 18:43:32 +09:00
ac5e463402
Minor optimization
...
We know the size in advance, this may save a few allocations
Change-Id: I2fb9a725f34ba2da4f34ed335652f10447d5d166
2012-03-14 18:35:07 +09:00
def4551c2a
Some code simplification
...
Just write the same thing in a more succint manner
Change-Id: I08a2c5edd52a3502914541061fd5b6ee7a92ebc4
2012-03-14 18:33:57 +09:00
4a08b2f0e4
Cleanup & optimization
...
Renaming some variables, and obvious optimizations.
Change-Id: Ib716748e9f3d602cf276dcd4e73f3bcfb819585e
2012-03-14 18:29:06 +09:00
f985efe39c
Remove a useless parameter
...
Change-Id: I03005240238fb004c20b2df0d836796e2e8b307f
2012-03-14 18:12:12 +09:00
bdf6d1b18b
Remove a useless method
...
Change-Id: I208dd2e725e37c2fb3cd51fe48194679e5912f6b
2012-03-14 15:59:04 +09:00
eda7d8af60
Remove the Builder
...
Change-Id: Idef22e6a82d59e3ec95b95ad237debcb07daf000
2012-03-14 15:42:26 +09:00
33cc825374
Match the constructor of SuggestedWords to the Builder call.
...
We have to match one way or another, and the argument order to the
Builder call is more logical.
Change-Id: Iac7c3a351c2687cb294d6a4924fd9cb20ca95177
2012-03-14 15:42:22 +09:00
7d55c891af
Make the Builder private
...
Change-Id: I2184084f4b7729c4324f8291d548bd4c4c2872a1
2012-03-14 15:42:14 +09:00
5b0643f50d
Re-sequence the last calls to build()
...
Change-Id: If77ee5aa9483d3ca03c52812f31665dee6468e99
2012-03-14 14:19:24 +09:00
d42b0238f9
Merge "Move up the static methods of the Builder"
2012-03-13 21:22:22 -07:00
7d384c73da
Merge "Kill the last place where the Builder was being used"
2012-03-13 21:22:03 -07:00
88bf1ba526
Move up the static methods of the Builder
...
Change-Id: Ic3e07b745b7b24cae0f772ea49e0de615b44caf9
2012-03-14 13:10:22 +09:00
8e19b1183e
Kill the last place where the Builder was being used
...
I had missed that one
Change-Id: I9a5040a7a61e294396aa424de96a69dbb15f037a
2012-03-14 13:10:12 +09:00
f147da0436
Merge "Use XML animator definition"
2012-03-13 21:10:08 -07:00
d7c4ba1709
Use XML animator definition
...
Change-Id: Ic2f6d3f8fdd2c0b0a00f004f49f95b00d474ee4b
2012-03-14 13:08:27 +09:00
7b2d6a8f98
Merge "Make the Builder fully immutable at last"
2012-03-13 20:30:16 -07:00
76e3861981
Merge "Straighten out the last bastion of the Builder"
2012-03-13 20:23:16 -07:00
febf9929ca
Merge "Add to SuggestedWords a missing parameter, and use it."
2012-03-13 20:15:34 -07:00
82793f2f85
Merge "Avoid using interface member, use concrete collection class instead"
2012-03-13 06:25:39 -07:00
ce96959518
Avoid using interface member, use concrete collection class instead
...
Change-Id: I8b647e8c260aec58c557ce07f3a2d8987c24d7be
2012-03-13 22:20:34 +09:00
0bd4699f9c
Merge "Update other alt keys' graphics"
2012-03-13 06:19:53 -07:00
faad353fea
Update other alt keys' graphics
...
Change-Id: I12699907a514f5fc2e110a0a711fb91c14a8756f
2012-03-13 22:12:40 +09:00
e1a91d0b26
Merge "Avoid using collection interface, using array instead"
2012-03-13 05:19:47 -07:00
b4fbbe57f5
Avoid using collection interface, using array instead
...
Change-Id: Ie0554362b73967bfcbbab6ad19c24683066a608e
2012-03-13 20:53:15 +09:00
e3afb7d192
Make the Builder fully immutable at last
...
Change-Id: Ie399ca7a9e76ccab44a92bc378d11f92392fed2c
2012-03-13 20:33:13 +09:00
6ffb5018c1
Straighten out the last bastion of the Builder
...
...and go for the kill
Change-Id: I5ad57211b250d2578ca22a5dae93344d52f9da80
2012-03-13 20:26:47 +09:00
ec471c72f8
Add to SuggestedWords a missing parameter, and use it.
...
Also stop using Builder between its creation and the call to
the #build() method.
Change-Id: Ie1fc3ec7b6f4c7c3789f672f4e26b4bf58c3e062
2012-03-13 20:19:21 +09:00
2e2519ee91
Make still more members of the Builder final.
...
Change-Id: Ic455f97247da5e40d4939555ab639ecffef36e2d
2012-03-13 20:05:00 +09:00
edf5daa8ed
Merge "Support invalidating multiple keys in KeyboardView"
2012-03-13 04:00:15 -07:00
bd4ba23d2b
Some code reorganization.
...
Use the same local variable inside both branches of an if.
Change-Id: I61f7d506d984f3723ec90604416d1875dd97cd8c
2012-03-13 19:54:56 +09:00
b5eeb724fc
Make some more Builder attributes final.
...
Change-Id: I3132b7fe4ee97c566736bfc21c3783cfc79fc7ff
2012-03-13 19:53:38 +09:00
c60fea852d
Make the suggested word list final in Builder.
...
Change-Id: I2ddfab00dc8c141fc989a051f16eb2b3571b7e86
2012-03-13 19:37:17 +09:00
08adb09e14
Remove unused stuff.
...
Remove 2 methods that were left only for tests to compile in
another project, but are not used any more now that the tests
have been updated.
Also remove an attribute that is never read.
Change-Id: Ic9ba1f52a465199c82c923d77ed7450460e8a4b9
2012-03-13 19:37:16 +09:00
9ffaae71d9
Merge "Make an add into a set."
2012-03-13 03:35:17 -07:00
728fd52b63
Merge "Pass the locale to the native code"
2012-03-13 03:27:11 -07:00
7ef1dabd92
Pass the locale to the native code
...
Change-Id: I8f73b9b33cca56b3fa44ec6259c0896be22f4a47
2012-03-13 19:16:33 +09:00
674ffcdf93
Make an add into a set.
...
This method now only sets words, so it should be named set.
The functionality is identical since there are no more places
where the list is reused.
This will also allow to make the list final in an upcoming change.
Change-Id: I25b0c7d7f13c3fa5d89806f01f48f1026769603f
2012-03-13 19:07:42 +09:00
299ac263b3
Support invalidating multiple keys in KeyboardView
...
Change-Id: I347ccfc2cf60c17f5f0eddec6566662cb3a954ca
2012-03-13 18:55:05 +09:00
d6662ecd30
Cleanup
...
Remove an unused method, make others static, fix a formatting
issue
Change-Id: I40cb0b5e01a6f8e2f7b953bd9aad3168dfee71d1
2012-03-13 18:34:19 +09:00
4ee186920e
Remove a method that causes annoying side-effects.
...
...and replace by a call to a central method.
Change-Id: I93d0a2c2e99963a5b69923d1062d0e01853216b6
2012-03-13 18:22:49 +09:00
b8753eb31c
Merge "Kill the StringBuilderPool."
2012-03-13 02:14:37 -07:00
adf218eed5
Kill the StringBuilderPool.
...
The intention may have been nice originally but these end up
being copied anyway :/
Let's remove them now, and in a later change, just keep
references to the created objects.
Change-Id: Ifba8357c20384f9eb40cd916665ed1fc6dc8cab1
2012-03-13 17:59:49 +09:00
8e08bfb8de
Merge "Implement additional proximity characters in the native code Bug: 4343280"
2012-03-13 01:41:46 -07:00
552c3c27f0
Implement additional proximity characters in the native code
...
Bug: 4343280
Change-Id: I9bbc5cab2fef1ee80c1fe32017df811ef8af10bc
2012-03-13 17:38:50 +09:00
aee5f03d6e
Use integer alpha value instead of factor for animation
...
Change-Id: I3099a7625e0176a1d2be42e58d6eb5fa95797bcb
2012-03-13 16:47:45 +09:00
95fcb0cce9
Merge "Remove a useless parameter."
2012-03-13 00:26:06 -07:00
dabf96896e
Move language on spacebar parameters to LatinKeyboardView attributes
...
Change-Id: I06e5d7d158a9b14b00df34e68b12cd012faf17d1
2012-03-13 16:17:13 +09:00
d0d4074392
Remove a useless parameter.
...
Change-Id: I7625bf17158c207ad7e8cd496bef825704173c4c
2012-03-13 15:34:06 +09:00
6fbcd0d219
Merge "Use Animator to draw language name on spacebar"
2012-03-12 22:57:57 -07:00
4c0c638a18
Use Animator to draw language name on spacebar
...
Note that Animator class exists in framework only on Honeycomb or
later.
Change-Id: Ie3392dbf8acc1547ebb2d16e04086c911d961aed
2012-03-13 14:25:57 +09:00
7c9bff96f0
Kill methods with side-effects, take 2
...
...working this time
Change-Id: I80e377e6250d3817f1e067a551bca2a557740764
2012-03-13 14:18:30 +09:00
b26af7eae7
Revert "Kill methods with side-effects"
...
This reverts commit ca0e048688
2012-03-12 19:42:29 -07:00
ca0e048688
Kill methods with side-effects
...
Change-Id: I42baeec68eb2540e7d8f8538ae2dceeef5594391
2012-03-12 19:48:32 +09:00
f62d6f50f2
Merge "Consolidate words into SuggestedWordInfo"
2012-03-12 03:14:54 -07:00
c3c4ed91cf
Consolidate words into SuggestedWordInfo
...
We can't get rid of SuggestedWordInfo because it conveys
the information about whether a suggestion is outdated or
not. It is always created anyway. So it makes sense not
to have separate lists and to just keep everything in the
SuggestedWordInfo object.
Change-Id: Idd79dc267d97633901d3d2869da457736963e178
2012-03-12 18:58:20 +09:00
546692daac
Merge "Support disableAdditionalMoreKeys and disableKeyLabelHint"
2012-03-12 01:48:05 -07:00
b03529aa01
Support disableAdditionalMoreKeys and disableKeyLabelHint
...
Change-Id: Idfa586417acd4a223380d52f044e3a86eb780b21
2012-03-12 17:45:57 +09:00
a3f2ce1f31
Merge "Fix an OOB"
2012-03-12 01:12:40 -07:00
c0c20b386f
Fix an OOB
...
The combination of I6b0262fe which removes the internal
size() > 1 test in the safety net calculation and I642a5893
which assumed DBG means there is at least one suggestion.
This change writes the test correctly.
Change-Id: Ib63bce4e163a785f408dd145c23d64cd58fa8c90
2012-03-12 16:50:58 +09:00
b6895aec05
Merge "Rename keyboard XML files"
2012-03-12 00:42:03 -07:00
47141f7011
Rename keyboard XML files
...
* Slavic to East Slavic
* Serbian to South Slavic
* Scandinavian to Nordic
Bug: 6150183
Change-Id: I8f5641aa07b83cbb225f5fd73e351a6f8abe0784
2012-03-12 16:39:29 +09:00
30936116d8
Merge "Make a method accessible for tests"
2012-03-12 00:23:29 -07:00
9dedec7c29
Make a method accessible for tests
...
Tests are using a wrapper method that's going to disappear soon.
The method that becomes package-visible now is destined to be
removed too a little later.
Change-Id: If99b1c77ed52e050b47216cc7afab5f35c4bbb38
2012-03-12 16:11:16 +09:00
1dfef0336d
Make a method static
...
Change-Id: Ie1d460562d38105abe91ae2da17cafd49e2cd394
2012-03-12 15:00:36 +09:00
c1ca8815f5
Fix an obvious bug in handleLanguageSwitchKey()
...
bug: 5759092
Change-Id: I8c7b2ef024cbab399d96f6b3ec553da4e9d2fb18
2012-03-11 00:44:47 +09:00
1a85b74adb
Entirely remove safety net memory.
...
mHasAutoCorrectionCandidate now includes the fact that this
did not get caught by the safety net. This is more intuitive.
Change-Id: I6502bbf1ca64a0a6d64f55d723305cf78352a656
2012-03-09 22:10:25 +09:00
68823ae08e
Make the safety net memory private
...
Change-Id: I10959d47c980d2e8f2ea995955acf02193e3ff7b
2012-03-09 22:01:15 +09:00
ebbb7e9665
Recompute safety net in debug cases instead of memorizing
...
Change-Id: I67f3a31db081afa4871ec441dd461c56e098c668
2012-03-09 22:00:23 +09:00
682c2d53cc
Make access to the safety net calculation easier
...
Change-Id: If33897b38af94ae81b05e5ef140a542724b9f34a
2012-03-09 21:44:40 +09:00
151d5cb532
Extract a condition from a method
...
Change-Id: I6b0262fe7cb3f7a31cc19d724c301467be932640
2012-03-09 21:37:44 +09:00
36c1b37914
Remove a useless argument
...
Change-Id: I713433a3225193489fad5bdafcf302b529903116
2012-03-09 21:24:47 +09:00
28e59b98c6
Remove a useless escape
...
Change-Id: I1ef0685cc9888c9cef9f60015d32b66dde75ef9b
2012-03-09 21:10:55 +09:00
d5f618e90a
Remove a useless test
...
If we are not composing a word here, we have already returned
Change-Id: I63281abace777e3658286d4df6781d2cd5a29c33
2012-03-09 20:53:45 +09:00
c5d2bb786e
Don't use an intermediate object with a different meaning
...
Change-Id: Ie89916b49c852a51385ffd61cb596a58f23a46a0
2012-03-09 20:51:33 +09:00
ed9986824e
Move some auto-correction logic to where it belongs
...
Change-Id: I897c5ec3a630a4a6bfc593906df4d3fc7b244482
2012-03-09 20:45:37 +09:00
dfd4abe818
Fix a shameful bug
...
I must have been sleeping when I wrote that
Change-Id: I887180ab610785a2000636adeeed99230b3c5390
2012-03-09 19:31:35 +09:00
0cf422fbb7
Reduction, step 8
...
Change-Id: I54334039597e235e24f169e34c1d44109180ee88
2012-03-09 19:00:29 +09:00
a333ff19ef
Reduction, step 7
...
Change-Id: I177ef2f29c8b6000c5e3d021c016c5d216fe3fc6
2012-03-09 18:59:20 +09:00
a3ee019331
Reduction, step 6
...
Change-Id: I22ad4cea0e0cac23813da7e788f5c94974ce0ebf
2012-03-09 18:58:01 +09:00
dbd140504d
Reduction, step 5
...
Change-Id: Iac52e62c2bdffad14f916f69eade2b785bb41767
2012-03-09 18:44:23 +09:00
0b96bc4b2b
Reduction, step 4
...
Change-Id: Ib27dc6e9486c3f0f2ec1e94a88a52d12c1af2d38
2012-03-09 18:44:20 +09:00
5a61d03f31
Reduction, step 3
...
Change-Id: I0e08b102c9539d97c473505b9d42176c4a7c8853
2012-03-09 18:44:16 +09:00
8abd15b59f
Reduction, step 2
...
Change-Id: I06e117df43d25dbaf9fc7a7366efd9355a6215ce
2012-03-09 18:44:10 +09:00
f08f30176b
Reduction, step 1
...
Change-Id: Ic3ed04300cfd4c0b69b93b27379aca4093b32f67
2012-03-09 18:38:44 +09:00
de165aed2a
Separate bigram prediction from suggestion process
...
Change-Id: Ibdef206fbd6688a45cebbd7fb8a9f6cd175d03b0
2012-03-09 18:38:20 +09:00
6f722c8301
Remove useless stuff
...
Change-Id: I462d24da2d26661990d6aab2a13fde851763fd61
2012-03-09 18:36:52 +09:00
67af2a2415
Export some more logic out of Latin IME
...
Change-Id: Ib264533a05e9e09347bf254789e6ab5beec92400
2012-03-09 18:36:49 +09:00
df9fce5df1
Export some logic out of LatinIME
...
Hopefully that will end in Suggest/SuggestedWords being autonomous
and won't need the logic spoon-fed to them
Change-Id: I915661bce13c69c8a5b8e5d4a8c41e18fea594cf
2012-03-09 18:36:45 +09:00
91e55ac000
Small optimization
...
We only use some of those results in one branch of an if() test.
Let's not compute those that are not needed.
Change-Id: I6ca068646b86d2980fb88e75b110ad077362c4ff
2012-03-09 16:47:43 +09:00
195419b1ec
Small reorganization
...
...resulting in a slight optimization
Change-Id: I83a9b8c92c3d93ce75988285997ec138b3ffe52e
2012-03-09 16:41:35 +09:00
838629aea0
Remove useless test
...
typedWord may not be null here
Change-Id: I9e7afb89fafbf6fcbc91fbc132aecc06aec8979f
2012-03-09 15:52:23 +09:00
d48b76267a
Merge "Remove a useless test (B7)"
2012-03-08 22:26:20 -08:00
2d82757fc6
Merge "Rename a parameter (B6)"
2012-03-08 22:23:33 -08:00
de19ab878d
Merge "Remove useless tests (B5)"
2012-03-08 22:22:56 -08:00
5a7cb9305a
Merge "Remove a provably useless test (B4)"
2012-03-08 22:22:20 -08:00
54392438c5
Merge "Optimize and clean up (B2)"
2012-03-08 22:00:02 -08:00
90bd4efd10
Remove a useless test (B7)
...
consideredWord is provably never null.
Change-Id: Ifaa0d2471c46f14967e70ad004d2b82f841a4566
2012-03-09 14:55:46 +09:00
cf8bc92ba0
Rename a parameter (B6)
...
This is not necessarily the typed word. Actually, the parameter
that's passed here has trailing single quotes culled out of it.
Change-Id: Ia2038faa2cbbd3a5b8263e6c0fb5b8e670993fe9
2012-03-09 14:52:35 +09:00
92146f2926
Remove useless tests (B5)
...
WordComposer#getTypedWord() may not return null. Don't test for it.
Change-Id: I6aff14892503d0c275a3328c404ed99d2f40a687
2012-03-09 14:52:04 +09:00
31a5da28e3
Merge "Move some code around (B1)"
2012-03-08 21:15:25 -08:00
8cd847c2fa
Remove a provably useless test (B4)
...
If !mInputAttributes.mInputTypeNoAutoCorrect then mCorrectionMode
will not have allowed #hasAutoCorrection() to return true.
Change-Id: I1b498d5aeb26194c765cc9b9dcb24d980de43894
2012-03-09 12:56:48 +09:00
94b20c90d8
Optimize and clean up (B2)
...
Stop parameters from escaping and don't do useless work and
simplify the code.
Yay.
Change-Id: I0dfc3e14b1cb50e0730f6d9c1d52b54516baa90e
2012-03-09 12:51:55 +09:00
dc5dfe37e0
Move some code around (B1)
...
The goal is to make the creation of the Builder closer to
the #build() call
Change-Id: I48d76d4efdc180479829016582edd9de47e7332c
2012-03-09 12:33:23 +09:00
13fb8fb775
Limit escape of parameters
...
Change-Id: I3a7ab069042d5542ab2e033d1eeb13d718cd7698
2012-03-09 12:30:23 +09:00
23a5e9d1a7
Merge "Make AutoCorrection static and non-instantiable (A5)"
2012-03-08 19:05:30 -08:00
2621fe2256
Merge "Move a memory in the container class (A4)"
2012-03-08 19:04:56 -08:00
427dfe37ec
Merge "Remove an unused method"
2012-03-08 18:31:26 -08:00
cbbfa15765
Merge "Make AutoCorrection a step closer to being static (A3)"
2012-03-08 18:30:19 -08:00
58722d83f0
Merge "Stop uselessly remembering a value (A2)"
2012-03-08 18:30:10 -08:00
caae6df0ce
Remove an unused method
...
Who would have guessed this wasn't being called at all.
Change-Id: Ib74a212356ea44e9bf149619ed5464c14684a1ba
2012-03-09 11:10:55 +09:00
21af2f40c5
Merge broadcast receivers again
...
It's probably simpler not to have registers dance around,
and just message the feedback manager when the audio event
happens.
Change-Id: Id0710ed102d10d01f1af93ad8cb660653bb3a9f8
2012-03-09 11:00:23 +09:00
7b77c683d7
Fix a crash
...
Bug: 6137076
Change-Id: I05f9f72a2678d10d3400dab5fc71544276739dcf
2012-03-09 10:29:51 +09:00
39286f98bc
Merge "Remove useless stuff (A1)"
2012-03-08 04:02:46 -08:00
f686211183
Merge "Split Utils class to StringUtils, SubtypeUtils, and JniUtils"
2012-03-08 03:59:59 -08:00
82adfdaeae
Make AutoCorrection static and non-instantiable (A5)
...
This needs change Ic6756baa to not break the build
Change-Id: I1c772dd99d63fec5d3ad67a0eb7fbc28ec7a0f0f
2012-03-08 20:56:59 +09:00
7a580a4769
Move a memory in the container class (A4)
...
This allows us to make AutoCorrection a purely static class.
Change-Id: I15b81bd7f3d6ea487154a5b09a81bc323be82ce1
2012-03-08 20:56:11 +09:00
9254dbcd7e
Make AutoCorrection a step closer to being static (A3)
...
Change-Id: Ide3d9785661a672af9bc8dc0cf91cab816dd6caa
2012-03-08 20:55:49 +09:00
719f92fc77
Stop uselessly remembering a value (A2)
...
The value is only used in debug mode, and it can be recomputed
at the time.
This change does not impact the logic. There is however a side
effect: in debug mode, the normalized score will be displayed
also when the word comes out of the whitelist or is a valid word.
It's actually a good thing.
The end purpose is to make all methods in AutoCorrection static.
Change-Id: I1642b1fdfa6ae62b8aa2fed94a8a26ff4a7e4d0e
2012-03-08 20:55:37 +09:00
ec0fca8a8b
Remove useless stuff (A1)
...
Remove an unused method and avoid doing a useless computation
Change-Id: I29593c2e93f15857249b35bdd72ca28045056302
2012-03-08 20:55:25 +09:00
cc8c8b99bd
Split Utils class to StringUtils, SubtypeUtils, and JniUtils
...
Change-Id: I09e91675fe7d573dad8c933ad513b21d7e409144
2012-03-08 20:30:38 +09:00
7d6d98ecc5
Merge "Cleanup keyboard theme switching code"
2012-03-08 03:24:38 -08:00
b43f2aeb69
Merge "Fix centering more suggestions panel on tablet"
2012-03-08 03:24:07 -08:00
2b1280c0f0
Merge "Return a value for tests instead of saving it"
2012-03-08 03:10:18 -08:00
32c181bfe0
Return a value for tests instead of saving it
...
Change-Id: I54fa32b92e89d03a53866bd1c0ee65955dd6b3d3
2012-03-08 20:07:54 +09:00
2bb29c4674
Simplification
...
Change-Id: Ibced83da2398f1e9ab6a0d6a22c2ad7c8f25cb7b
2012-03-08 19:50:47 +09:00
0f1efae262
Merge "Cleanup unused imports (A7)"
2012-03-08 02:32:48 -08:00
663aabca0c
Merge "Get the view for haptic feedback as a parameter (A6)"
2012-03-08 02:32:39 -08:00
85e88d30c1
Merge "Remove a useless member (A5)"
2012-03-08 02:32:25 -08:00
60705c9ed3
Merge "Simplification of sound settings (A4)"
2012-03-08 02:32:16 -08:00
d2b5ea2084
Merge "Make a condition positive (A3)"
2012-03-08 02:32:07 -08:00
d749fb86ab
Merge "Simplify audio management (A2)"
2012-03-08 02:31:57 -08:00
7cfae83434
Merge "Export audio and haptic feedback to a specialized class. (A1)"
2012-03-08 02:31:45 -08:00
411749a4ba
Cleanup keyboard theme switching code
...
Change-Id: I023769b765d07237b2129d8f1b2a02ffd4c4f09d
2012-03-08 19:17:31 +09:00
bcbaffd9dd
Fix centering more suggestions panel on tablet
...
Bug: 6129726
Change-Id: I8dac3251eec68ad3fb523c632ff39f3cc661c81f
2012-03-08 19:02:22 +09:00
8667bbeab3
Small rename
...
Left/Right is wrong terminology here
Change-Id: I58c55849e45d9984dd3fb7b75a64e07667c9eba4
2012-03-08 18:49:38 +09:00
41a2929282
Cleanup unused imports (A7)
...
Change-Id: I48ba12e4311cbf2982ee8f5312b279bc8c1fdfe8
2012-03-08 18:37:03 +09:00
544c3c2952
Get the view for haptic feedback as a parameter (A6)
...
It's rather annoying (and possibly dangerous) to keep this as a member.
Get it from outside.
Change-Id: I00c42db96395fb65204fb140aeedc82bf312a86e
2012-03-08 18:37:00 +09:00
29d967fdcb
Remove a useless member (A5)
...
Change-Id: Ibaaeb8dbcb012f5e973e27ed9928401515656e9e
2012-03-08 18:36:56 +09:00
bdbb22bb33
Simplification of sound settings (A4)
...
Change-Id: I0c6e207bae1e08c45a95b3479e1d67228d696792
2012-03-08 18:36:43 +09:00
2651b17fc4
Make a condition positive (A3)
...
mSoundOn is much easier to understand than mSilentModeOn
Change-Id: Ie51c5c75fcad62e13e0fb578a266af80f15dc440
2012-03-08 18:36:19 +09:00
793791cdf0
Simplify audio management (A2)
...
There is little point in deferring loading for this. Getting the
service at startup time is not very expensive anyway, plus we
can avoid getting it in a later change if sound is off in settings.
Change-Id: I08d65467f245fa2f9f617eb23257c327b3115673
2012-03-08 18:35:48 +09:00
564496bad6
Export audio and haptic feedback to a specialized class. (A1)
...
Change-Id: I957d883d1ccf188cb98eb11031aa0a32fce4ed76
2012-03-08 18:35:20 +09:00
f8b39f39cd
Merge "Remove a useless class (B4)"
2012-03-08 01:14:33 -08:00
4b656a3fef
Merge "Remove stuff that's not used any more (B3)"
2012-03-08 01:13:06 -08:00
d8447ec353
Merge "Use the simple auto-correction status (B2)"
2012-03-08 01:12:46 -08:00
fbe767cec5
Merge "Remember auto-correction status simply (B1)"
2012-03-08 00:54:30 -08:00
bedb1d33f3
Merge "Give InputLogicTests the ability to change language"
2012-03-07 23:51:29 -08:00
274a0643b1
Give InputLogicTests the ability to change language
...
Also fix a typo, and increase the time allowed to load the main
dictionary to 2 secs instead of 1.
Bug: 6114326
Change-Id: I5f70b34fc4277c55977b18466253152aa98a2507
2012-03-08 16:39:29 +09:00
f0d5a78388
Merge "Add functions to calculate proximity characters in the native code"
2012-03-07 23:31:17 -08:00
3e2d385810
Restart LatinIME service when keyboard theme is changed
...
Bug: 6023947
Change-Id: I779da32708fca7333aff74929cc98173246ee685
2012-03-08 15:08:16 +09:00
a70ee6e3b3
Add functions to calculate proximity characters in the native code
...
Bug: 4343280
Change-Id: I17f8f6295b01900948b98680d0267753f33a46cf
2012-03-08 12:55:15 +09:00
c648b88779
Merge "Dynamically determine key preview backing view height"
2012-03-07 04:17:52 -08:00
c8b0e5797e
Dynamically determine key preview backing view height
...
Bug: 6023947
Change-Id: I53a5c0eb99100a0dfe3e025808f5dc55747d1287
2012-03-07 20:33:17 +09:00
cb8d5fa7e2
Merge "Fix duplicate flag value in Key"
2012-03-07 01:53:10 -08:00
dab392c6f4
Merge "Fix a bug with successive manual picks"
2012-03-07 01:51:59 -08:00
8e14e78377
Fix duplicate flag value in Key
...
Change-Id: I98e77e5432a228e4455998bf09a2cc671b113c4e
2012-03-07 18:41:38 +09:00
3dd4bcb283
Merge "Recompute suggestions on language change."
2012-03-07 01:35:12 -08:00
b84ee82e66
Recompute suggestions on language change.
...
Bug: 6106407
Change-Id: I43d9c89610a9ed7a9f6825bd90334d7b343df52c
2012-03-07 17:35:32 +09:00
845b24d9d3
Fix a bug with successive manual picks
...
Bug: 6121571
Change-Id: Ib16fbef1087da3b7da5539901ec57156f242f089
2012-03-07 17:32:42 +09:00
f773ef19e8
Remove a useless class (B4)
...
\o/
Bug: 5975068
Change-Id: Ia18b55af6d555e7ee7af1cdd7c6227fc1ee6786b
2012-03-07 15:34:15 +09:00
a0beebf711
Remove stuff that's not used any more (B3)
...
Change-Id: Ie86675ff2facd37430051bf129ddd930fb933dc9
2012-03-07 15:32:55 +09:00
0a59ac2ba8
Use the simple auto-correction status (B2)
...
Change-Id: I9d2f053b6f7bad20fc6afe5f5086a965e5014a5c
2012-03-07 15:31:22 +09:00
70852c91dc
Remember auto-correction status simply (B1)
...
This duplicates the functionality in ComposingStateManager at
a fraction of the cost. It's not used yet.
Change-Id: Ica2607fb2f7c41e11189fcb566e253db8f62596f
2012-03-07 15:20:01 +09:00
65fe7f7994
Merge "Add language switch key only to the phone layouts"
2012-03-06 18:19:45 -08:00
81d4e3cd66
Add language switch key only to the phone layouts
...
Bug: 5759092
Change-Id: Ic7d7d4812976654c0e85fecabd1128eadfc52c5c
2012-03-07 10:03:21 +09:00
89ffb212b4
Make the keyboardswitcher and the subtypeswitcher final.
...
Change-Id: Ifcc79357adcc53f93b190b6e98d5569f42f74655
2012-03-06 19:07:21 +09:00
3cd1a00eca
Resolve a todo
...
This exports some voiceproxy complexity to voiceproxy rather
than keeping it in latinime
Change-Id: I0b3523e77af4104cc3ed28417956059c734c8bfe
2012-03-06 18:43:18 +09:00
691f1c174b
Fix coordinates sent to native code
...
Change-Id: I2c8b093b59ad36ffe860c3c4d360d87251d101c4
2012-03-06 16:38:00 +09:00
231ef8fa3e
Merge "Integrate the logic to calculate the proximities"
2012-03-05 23:25:29 -08:00
ca7ec2097c
Integrate the logic to calculate the proximities
...
Bug: 4343280
Change-Id: I0f6a7e6912ed4abea07c10d266da4c7ccb0dae76
2012-03-06 15:34:27 +09:00
00ed3be95c
Correct special space handling of punctuation
...
This fixes two defects:
- One where some separators should promote a phantom space to
a real space. This bug had a unit test but wasn't tracked.
- One where French punctuations would behave incorrectly. Tracked
Bug: 6113693
Change-Id: Ia7f86fc960e00141757632ab2c9bce9168dd6966
2012-03-06 14:00:34 +09:00
e79b1a8312
Make SuggestedWords immutable completely
...
Change-Id: I1b0f7b857e89307c987187c1969a2846aa97fdcc
2012-03-05 23:06:37 +09:00
40b6e666e1
Merge "Make SuggestedWords partially immutable"
2012-03-05 05:29:14 -08:00
8cc8f26adf
Make SuggestedWords partially immutable
...
Change-Id: I72a2f71d7f6565a30c06e563b0a64f496542cde9
2012-03-05 22:11:13 +09:00
717f12472f
Merge "Remove unused code"
2012-03-05 04:46:09 -08:00
433be45fce
Merge "Refactor to suppress null worning"
2012-03-05 04:08:23 -08:00
add6dfb8fe
Remove unused code
...
Change-Id: I894c0850e803bdfc7b590a62ddd4076a3a4e4658
2012-03-05 21:07:03 +09:00
d5b6360549
Merge "Revert "Make SuggestedWords immutable""
2012-03-05 02:57:00 -08:00
d62fa834c6
Revert "Make SuggestedWords immutable"
...
This reverts commit c208f4dfb7
2012-03-05 02:54:21 -08:00
6a830277df
Merge "Refactoring"
2012-03-05 01:49:46 -08:00
611a5bdf65
Refactoring
...
Change-Id: I2f92c01fa1ff6b318128d387f26942b5d47de3e0
2012-03-05 18:36:51 +09:00
370674422a
Refactor to suppress null worning
...
Change-Id: I4b4dc6f86d659491d8b9a74ed120092eab964345
2012-03-05 18:15:29 +09:00
8c80fb9bcb
Fix Key to use a disabled icon when the key is disabled
...
Bug: 6114350
Change-Id: I419bc1736c27046dfea254ac510f5da478b6412c
2012-03-05 18:01:33 +09:00
c208f4dfb7
Make SuggestedWords immutable
...
Change-Id: I26bd82aee5ead84e40abfc3db5a48ed6d1e42361
2012-03-05 17:24:30 +09:00
e5cbc94d10
Merge "Support embedded more key"
2012-03-04 22:10:22 -08:00
895b70b8af
Move some treatment to a more sensical place.
...
It makes more sense to catch words with the safety net in
updateSuggestions() than in showSuggestions(). Also, it's useless
to do it in updateBigramPredictions, because the result will
always be provably false.
This will also help with writing unit tests.
Change-Id: Ifab81e6c5a74b1aa75cf85ef7742fee69a98f5ce
2012-03-05 14:27:49 +09:00
e491be6e86
Support embedded more key
...
This is a followup change to Ie10b3e0b.
Change-Id: I1f91d96e32357b83bd0546537d561d638b6ff0c6
2012-03-05 14:22:52 +09:00
9b01890254
Move a method to a more sensical place.
...
Change-Id: I11f87448f689cf828bff960ad7a3e4739a3457dc
2012-03-05 14:19:35 +09:00
611ec69413
Remove a useless method
...
Change-Id: I2002662ee07af2fcc626a52ea4e9ad8977b29ca2
2012-03-05 12:46:35 +09:00
428178aca6
Merge "Replace a useless computation with a constant"
2012-03-04 19:35:11 -08:00
4ab5486bf2
Merge "Remove a useless test"
2012-03-04 19:35:02 -08:00
4e112d0782
Replace a useless computation with a constant
...
This is provably always false
Change-Id: I88d783fa59fec0b7a729558ba974a6a58c158645
2012-03-05 11:57:36 +09:00
a04d2358c0
Remove a useless test
...
With the current logic, this test provably always resolves
to false.
Change-Id: Iba84ef5f3a14cd8ac48c6a813519ab283bf605f8
2012-03-05 11:38:45 +09:00
50b82dca62
Merge "Fix comment"
2012-03-04 18:28:01 -08:00
49079df8ec
Merge "Omit InputMethodManagerCompatWrapper argument from some utility methods"
2012-03-04 18:12:47 -08:00
04bc787ce7
Fix comment
...
This is follow up of Ie10b3e0.
Change-Id: Idefbe1575915bb87f1c86cb3ddb5efe578c5b760
2012-03-05 11:10:28 +09:00
2d25ba2750
Omit InputMethodManagerCompatWrapper argument from some utility methods
...
Change-Id: Ic837018c702c8c575de3e5e81fe8e31fee16fe22
2012-03-05 10:43:12 +09:00
c2136c4e63
Merge "Some renaming"
2012-03-04 17:26:22 -08:00
0af449aa64
Merge "Added virtual view hierarchy for keyboard accessibility."
2012-03-02 15:39:12 -08:00
a157249014
Merge "Remove a useless method"
2012-03-02 05:57:48 -08:00
e53840d216
Merge "Some more simplification"
2012-03-02 05:56:58 -08:00
508ded5827
Fix long press behavior of akye that has altCode defined
...
This issue has been introduced by I2bd4daf2
Change-Id: Ie10b3e0bb360986597a0f5a8e5b8253400f924c4
2012-03-02 21:29:51 +09:00
3a1844c33b
Merge "Support dividers in MoreKeysKeyboard"
2012-03-02 03:58:13 -08:00
5ef4fccbb9
Support dividers in MoreKeysKeyboard
...
Bug: 6080806
Change-Id: Iacd78c6aab6abf948717d34da7489a79c41316d2
2012-03-02 20:52:25 +09:00
a83a53ba24
Some renaming
...
Change-Id: I445277cb3af469a0145a8da0ffb801b7e19048cd
2012-03-02 20:46:54 +09:00
5edda4111e
Remove a useless method
...
Change-Id: I038e6a82b6463a2a8ec494171a596d76fbc75fe1
2012-03-02 20:38:41 +09:00
dd931c47be
Some more simplification
...
I wish "are we autocorrecting?" was not computed in a dozen
places all depending on a hundred code paths
More than likely, this fixes very subtle discrepancies
between auto-correction indicator with the underline and with
the LED on the spacebar - which is not displayed any more in
the current version anyway. Especially, the LED probably
would have been off when the word was caught by the safety net.
Change-Id: Idda3021771081d6155b06915e728ecd64d9e042e
2012-03-02 20:34:10 +09:00
e2a50bd804
Optimization
...
Avoid doing some useless processing.
Change-Id: I4ce0a188e10db30322bd25751dc5c09492cea301
2012-03-02 20:26:51 +09:00
7204eab3da
Precompute two values that never change
...
Change-Id: Ic54e7926028ea8374564da5e5004d710f42c53e1
2012-03-02 20:04:42 +09:00
38e535e596
Change a parameter type to make a call clearer
...
Change-Id: I2918d0a8b00da743689b919f80128bbf36973f24
2012-03-02 20:01:34 +09:00
5bc2b61274
Move a method up a level
...
Change-Id: I6b9a697480127e4745698ab19f8a360b86ff39ca
2012-03-02 19:59:55 +09:00
d02783cb63
Break out a method
...
Change-Id: Ia14fc320422b7f198c33ba522bb93dd70fbcb2c1
2012-03-02 19:52:06 +09:00
5a2c19d4fb
Merge "Revert "Make a member read-only""
2012-03-02 02:49:42 -08:00
f1967ce322
Revert "Make a member read-only"
...
This reverts commit 6a43e39bf0
2012-03-02 02:49:24 -08:00
9727aea418
Merge "Small refactor (A1)"
2012-03-02 02:47:42 -08:00
d153228013
Merge "Make a member read-only"
2012-03-02 02:29:41 -08:00
6a43e39bf0
Make a member read-only
...
Change-Id: I9a718eaf07e1b6c659e649350d3605f365db2839
2012-03-02 19:17:57 +09:00
d992fa847d
Small refactor (A1)
...
Change-Id: Ia0838bbce47a2b60067f464685ad6d55ee4ec934
2012-03-02 18:55:04 +09:00
7293b65841
Remove a useless method
...
Change-Id: Ic00520b18f74838fe1002a679952f62bc7226c15
2012-03-02 18:49:24 +09:00
025a16c31c
Readable debug output
...
Change-Id: I4110791832d2ab1d681b01c9e8a237567442c827
2012-03-02 14:48:10 +09:00
ede2133cb1
Support time, date, and datetime keyboard
...
Bug: 6030364
Change-Id: I2bd4daf264757d8f3fa7c946d10a39c36ccf5905
2012-03-02 14:01:07 +09:00
961703841e
Merge "Explicitly specify that labels might be in more keys"
2012-03-01 03:56:32 -08:00
e4c45c6ef9
Explicitly specify that labels might be in more keys
...
Bug: 6080806
Bug: 6081427
Change-Id: I455a0210e65ea2a7774e0e0071cea5f4a99577bd
2012-03-01 20:03:47 +09:00
895da64b62
Merge "Change a dangerous ID"
2012-03-01 02:28:08 -08:00
fa12acb8b7
Change a dangerous ID
...
The message id 0 is used intrinsically by the framework
for all messages without a specific ID. Using 0 here
we can't reliably use the post(Runnable) method on our
handler, because these would in *some* respects be taken
for update_suggestion messages, but not all.
For example, they'd be removed on removeMessage() but
they would not trigger the actual process. This would
lead to utter confusion.
Change-Id: I5d9b01d38e2ff090cd0d80c27421dc8a41c317b8
2012-03-01 19:05:51 +09:00
42fd1d2d72
Refactor more keys spec handling
...
Change-Id: Ibd95eff0725724ea35ad58e1d1ec7ec3d02a6e90
2012-03-01 16:07:02 +09:00
870a1ab156
Merge "Try to survive unavailability of local storage"
2012-02-29 17:05:20 -08:00
f3f90e6d35
Try to survive unavailability of local storage
...
Bug: 6035465
Change-Id: Ibe2d542349ec598824f78b91d374a977082fc2d1
2012-03-01 09:43:29 +09:00
d054aa17da
Merge "Reset previous symbols shifted state when auto switch backed"
2012-02-29 08:05:58 -08:00
4ba2216219
Reset previous symbols shifted state when auto switch backed
...
Bug: 6072517
Change-Id: I00337b3ed5c85df4627e8f5a02465d406c4d9178
2012-03-01 01:01:09 +09:00
b19a6b9fc5
Fix spacebar icon position on phone/number keyboard
...
Change-Id: I4d6bb0f2f12e7b263ff951f3173cac8e41d0f23e
2012-03-01 00:37:51 +09:00
9a81ce92c3
Added virtual view hierarchy for keyboard accessibility.
...
Bug: 5829051
Change-Id: Ied1b6267eec616bd3b9337f6e761b0c740aa0eb2
2012-02-28 10:01:40 -08:00
5e4d2a0fa9
Remove logs now that we don't need them any more.
...
This has served its purpose, we don't need this any more.
The logging function itself can be kept since it's not called
any more. It may come in handy later.
Bug: 6053661
Change-Id: Icb40dad131793a704dbe6514cf7433e43ea04450
2012-02-22 20:45:43 -08:00
3f65960e16
Add debug prints to help with debugging
...
This is intended to help tracking #6048808 .
Another bug has been filed to remove this once we're done with
the debugging: #6053661
Change-Id: I4547fb71926af6dc2e9c23ee4b44e4e345be6657
2012-02-22 16:16:32 -08:00
5935950d44
Rename cancelCommit to revertCommit
...
This wording is easier to understand, and it matches the other
revert* functions.
Change-Id: Ibc2ec79fb5a0f9bf508e5cdeb75e54abd9241d0c
2012-02-22 01:09:23 -08:00
4fef31510d
Remove a useless code path (A7)
...
This is never called any more, since we now use the cancelCommit
path to react to a backspace after a manual pick.
This concludes the run of changes to implement feature
request #5968922
Change-Id: I23df653bb2a3de2ba0152394d5d616a42ac7519b
2012-02-22 01:05:36 -08:00
bdf89ce5fe
Rename cancelAutoCorrect to cancelCommit (A6)
...
Also remove a test in debug mode that would check for absence of
a situation which is now expected.
Change-Id: Ia5be350bc98a604b3bf8f6057652c5534f6a19af
2012-02-22 00:59:01 -08:00
2aa16dd81f
Merge "Activate the code to cancel a manual pick (A5)"
2012-02-22 00:50:13 -08:00
80c25df49d
Merge "Implement cancelling a manual pick (A4)"
2012-02-22 00:29:23 -08:00
8db74d0fae
Merge "Use the stored separator instead of reading it back (A3)"
2012-02-22 00:24:19 -08:00
9271b770e8
Activate the code to cancel a manual pick (A5)
...
This finally makes active the behavior described in
Bug: 5968922
Change-Id: I363ed23270c3dea75411ea806011225097b5d07c
2012-02-22 00:05:19 -08:00
32f0af1fc4
Implement cancelling a manual pick (A4)
...
This is new code, but simple code. The new code path is never
used for now, but it will be in an upcoming change. This serves
to implement feature request #5968922
Change-Id: I3e67731ec6e9fc0b86c5cbd972e9c081781c11a9
2012-02-22 00:00:51 -08:00
193d23f40e
Use the stored separator instead of reading it back (A3)
...
Now that we have stored our committing separator, we can use
it directly instead of reading it back from the text view
paying the IPC cost. This prepares for feature request #5968922 .
Change-Id: Ifeaa2d659cf12b91c89d28e6ff7d07a669258184
2012-02-21 23:56:36 -08:00
e043bf02f2
Merge "Give LastComposedWord knowledge of the separator (A2)"
2012-02-21 23:42:21 -08:00
1dfdc8056c
Merge "Give LastComposedWord knowledge of the committed word (A1)"
2012-02-21 23:41:42 -08:00
66bb563535
Give LastComposedWord knowledge of the separator (A2)
...
This stores the separator that was used to commit the word in
the LastComposedWord. It may be NOT_A_SEPARATOR if there was
no separator (for example, the cursor moved causing a commit,
or there was a manual pick). This is necessary to implement
feature request #5968922 .
Change-Id: I5fcf19a78ec66d68d4df89418eaef13952588207
2012-02-21 23:33:58 -08:00
cf9d92629c
Give LastComposedWord knowledge of the committed word (A1)
...
There is no point storing the prospective autocorrect - we are
recomputing it anyway. The committed word however will be necessary
to implement feature request #5968922 .
Change-Id: I588c18e1a5a1050a791d601de465f421ccbe36cd
2012-02-21 23:12:21 -08:00
1b3c16c183
Merge "Add next/prev navigate action more keys and remove tab key"
2012-02-21 23:09:58 -08:00
05bfd189a8
Add next/prev navigate action more keys and remove tab key
...
Bug: 6037537
Bug: 5961814
Change-Id: I9c6dedf953452a180fcd5bce7bfadfd3c821f224
2012-02-21 22:50:50 -08:00
5262fe8832
Dismiss the hint on a non-word-starting non-separator
...
This would happen when a character is not a separator but is not
a word starter. Such characters include single quote and
dollar, and others non-letter, non-separator chars.
We set the bigram predictions if any - if not so configured, this
will fallback on setting back punctuations into the strip.
Bug: 6010408
Change-Id: Id203bbe87f8c13de0d5027b555c9067c7ec98f92
2012-02-21 21:16:18 -08:00
b141c9cd3f
Rename resources to reflect current usage
...
Bug: 6010403
Change-Id: Ia02ff31007296fdf6901504f238dfd9e4621f658
2012-02-21 18:54:44 -08:00
8a3d369840
Remove a useles parens
...
...I could swear I had compiled :/
Change-Id: I4e1fb2b1dda0a4ceffe2082935395d05297c63ec
2012-02-21 16:53:05 -08:00
9a2a11e65b
Rewrite a condition
...
Change-Id: I805c9579788d99b015feb2075ad4771756c7adc5
2012-02-21 15:46:53 -08:00
2649e42d75
Extract a method to reset the ime state
...
Change-Id: I921184b85b94418cf360508ee3f67e85b10b3d72
2012-02-21 15:12:01 -08:00
5eeff7cf54
Converge paths of an if() branch
...
This is to help with further refactoring.
Change-Id: Ib2459903862570cf7022fd90f2d5c524a6bbbe19
2012-02-19 18:02:40 -08:00
1044539080
Rename variables and add comments
...
Change-Id: I746f2364d9f02f22aa6ab57d7060013ee114f4e3
2012-02-19 17:26:41 -08:00
1fead1d5f1
Read the initial selection value.
...
It turns out this was available in an unexpected place.
Fixes both the following bugs
Bug: 5948469
Bug: 6023118
Change-Id: Ie1a91b8268540ea0f0df02bee94c3bbdeb0fa4c5
2012-02-17 20:54:48 -08:00
1950964157
Merge "Don't assume a word has been added to the user dict"
2012-02-17 15:29:52 -08:00
97bde43740
Settings key always exists in more keys of shortcut/f1 key
...
This change also
* Fix comman/f1 key for Arabic keyboard.
* Removes "show settings key option" and related stuff.
* Renames and simplifies F2 key to shortcut key on 7 inch tablet.
Change-Id: Ib1cf99ad00d9780a2f0d170260e756771e161521
2012-02-17 01:04:11 -08:00
fed72d6038
Merge "Support fixed order more keys"
2012-02-17 01:01:28 -08:00
aeeed75848
Support fixed order more keys
...
Change-Id: I979f54e8b54243da4d23cfbe08198d2aa495f870
2012-02-17 00:49:18 -08:00
8e4b3bbf9f
Don't assume a word has been added to the user dict
...
The user may now cancel or edit a word upon adding to the
user dictionary. We can no longer assume the word has been
added as is and for the current locale. We should just rely
on standard mechanisms that inform us of new insertions.
Bug: 6015347
Change-Id: I069b19c0c844ca29d6de4c4d162306f9413adea8
2012-02-16 19:19:05 -08:00
03c3018492
Merge "Use additional proximity chars even when no key is detected."
2012-02-16 19:17:48 -08:00
9025c55e9f
Use additional proximity chars even when no key is detected.
...
Change-Id: I06a8c66421fcdd43066934ec31d0a38a7cf12bf2
2012-02-16 18:58:47 -08:00
beb08b398f
Remove unnecessary and harmful KeyboardState.onUpdateShiftState call
...
This change also cancels double tap and long press timers if other
letter key is pressed after shift key.
Bug: 5693999
Bug: 6017610
Change-Id: I3b5f3debfb8915fa73a93b409a38afadf24132e9
2012-02-16 18:02:17 -08:00
ad290d6505
Activate bigram predictions from the binary dictionary
...
Change-Id: If1cc50539d7677b854b1cd3bea3423c8c0865de5
2012-02-15 19:51:24 -08:00
6213983fa1
Refactor MoreKeysKeyboard.Builder
...
Change-Id: Ib5f58b1143be60c748b81299ccc3b237d2587846
2012-02-10 18:53:54 +09:00
b9e10c318a
Merge "Key should be distinguished also by moreKeys contents and etc."
2012-02-09 23:51:18 -08:00
4baf767fac
Merge "Improved shift key and symbol/alpha switch key accessibility feedback."
2012-02-09 15:33:40 -08:00
fdb6999e55
Key should be distinguished also by moreKeys contents and etc.
...
Change-Id: Ib2caabee6af78153b5a7be0e4df522288f2a7d48
2012-02-10 03:17:39 +09:00
accd2a9f61
Merge "Add finals"
2012-02-08 19:08:09 -08:00
a828f613a8
Merge "Some more simplification"
2012-02-08 19:05:46 -08:00
8ff0564f6a
Add finals
...
Change-Id: Ib81be9a0df34c5e9fc49d2b5d9bf02297ea2b499
2012-02-09 11:40:54 +09:00
6a800b253f
Some more simplification
...
Remove useless method calls, and ultimately remove useless
method.
Change-Id: I3f353b1b37460d5e9ceae5cb5dde3fff0da81c21
2012-02-09 11:38:03 +09:00
4721427c7d
Allow revert swap punctuation again
...
This may not be the best behavior, but it's the same as ICS.
Bug: 5981844
Change-Id: Ibb7798e2a315312310ed3be4e731d0fe1ac04456
2012-02-09 11:34:00 +09:00
5962312b07
Custom action label should be a part of keyboard identifier
...
Change-Id: Ia14cabc3d49fbdcb11dd00225d225fbb91cc4012
2012-02-08 20:09:39 +09:00
7a39bd4454
Shift+Smiley key will register newline character of textMultiLine
...
This change also
* Honors the custom action label in EditorInfo.actionLabel.
* Invokes InputConnection.performeEditorAction if action is specifed
at EditorInfo.imeOptions or actionLabel/actionId.
* Stops using InputMethodService.sendKeyChar. Implements
sendKeyCodePoint instead.
Bug: 2498607
Bug: 5961809
Bug: 5368408
Change-Id: If4cd5eb3dacfc6b6a7ea434b0617c2438e06e42d
2012-02-08 19:31:35 +09:00
82efc941ba
Merge "More simplification"
2012-02-08 01:43:23 -08:00
e771fc2f1a
More simplification
...
A suggested punctuation is sure to be 1 character and a word separator,
so the isSuggestedPunctuation() test is redundant.
Change-Id: I3d31f0825f069f64d514682e46be62afdae25291
2012-02-08 18:17:51 +09:00
614cb02a91
Merge "Rename mini keyboard to more keys keyboard"
2012-02-08 00:04:16 -08:00
2affaf91a0
Rename mini keyboard to more keys keyboard
...
Change-Id: Ie4c85e8ca5a1f41a420aae5c1cd9c1cb07e237e5
2012-02-08 16:12:31 +09:00
1bd1cd19c0
Merge "Fix the auto-composer to support supplementary chars"
2012-02-07 22:46:22 -08:00
9159b9953d
Fix the auto-composer to support supplementary chars
...
Change-Id: I61ff218ae2ca4eb443a370e581b677755258670a
2012-02-08 15:45:51 +09:00
71a14420d8
Merge "Fix obvious bug"
2012-02-07 22:42:18 -08:00
93bc5e7fda
Fix obvious bug
...
Change-Id: I3a0e5c699bbe4e9274dacdbdf92dff14148bd2c1
2012-02-08 15:35:56 +09:00
8174373a0e
Merge "Remove a nested edition occurence"
2012-02-07 19:42:35 -08:00
5a6daf46cf
Merge "Cleanup"
2012-02-07 19:42:26 -08:00
862f950da3
Cleanup
...
Remove a useless test (we can only come here if the code
is not a separator, as we are only called from onCodeInput
inside an explicit test).
Change-Id: Icd996a5a1c18a550117a144a1d35f167b96211f7
2012-02-08 12:06:18 +09:00
2124bc5bf5
Remove a nested edition occurence
...
This was harmless but confusing
Change-Id: Ic271f80d3dadf01b29e3875c6a8ad51b99a936f9
2012-02-08 12:03:55 +09:00
2e2d6b4d40
Small simplification
...
Change-Id: I55f81f3ab427fd5b28bb1f31960077cd1897cbd0
2012-02-08 11:41:15 +09:00
1b986cc488
Merge "Fix a bug with manual pick then dotcom key"
2012-02-07 16:59:47 -08:00
8d4f0d5d1d
Improved shift key and symbol/alpha switch key accessibility feedback.
...
Bug: 5933165
Change-Id: Id71f38874640785b7ad43b7a70e27f40c13be748
2012-02-07 13:14:18 -08:00
c217dc9237
Convert one letter Key.outputText to Key.code
...
This change also uses Key.code instead of Key.outputText for the
variety of parentheses keys taht introduced by I85998f17.
Bug: 5975484
Change-Id: I86879c9942d264edc71e5893325a2f582763d12f
2012-02-07 22:34:20 +09:00
69f672a4b3
Merge "Remove unused InputConnection argument"
2012-02-07 04:15:07 -08:00
12d67e6d5d
Fix a bug with manual pick then dotcom key
...
Inhibit adding phantom space for tld keys even if the last
character inserted in the textview is not a dot
Change-Id: Ie92554ead7a18c932480905c5738aff7c0159a32
2012-02-07 20:36:48 +09:00
64eaa67eb5
Remove unused InputConnection argument
...
Change-Id: Ic45c8c6e7730775654317fb6e2d1cb64f9031f46
2012-02-07 19:38:06 +09:00
cfec7e72fd
Merge "Fix a race condition that makes tests unstable"
2012-02-07 02:28:12 -08:00
816a8a0fd8
Fix a race condition that makes tests unstable
...
Change-Id: Ic19d380eb64855884bc6ded8547c200dd772ffe9
2012-02-07 19:22:37 +09:00
4a3c0918dc
Merge "Fix KeyStyles to be able to override the value in style"
2012-02-07 02:04:22 -08:00
17f53103ee
Fix KeyStyles to be able to override the value in style
...
Change-Id: Ib7476cdc0f81dfeb6292ef663e9dbab6d2b949ba
2012-02-07 18:51:51 +09:00
172a013ab5
Fix a bug with the auto-correct indicator
...
Bug: 5969106
Change-Id: I02d4b9184bb2c3fc0d08ffd5db77a9f9d816631f
2012-02-07 17:20:23 +09:00
a7f2500001
Fix a bug with common objects.
...
Bug: 5961179
Change-Id: I452efc552c6ab390931f25557d7aee5a64bf054e
2012-02-06 18:41:00 +09:00
f6cf387edc
Merge "Recursively resolve @string/resource reference in key key spec parsing"
2012-02-03 03:20:37 -08:00
aca8870128
Recursively resolve @string/resource reference in key key spec parsing
...
Change-Id: I9d172605e90e828e00f7c4c8d49548498aa3b50d
2012-02-03 20:03:23 +09:00
9f17de5b4d
Merge "Stop inserting a space after a manually picked word."
2012-02-03 02:09:05 -08:00
24cd2617f5
Filter out empty entry from more keys CSV
...
Change-Id: I9a26aaa58f0f502b3bfef9de422370d2b0add8d8
2012-02-03 18:48:01 +09:00
fb684cebe8
Stop inserting a space after a manually picked word.
...
Bug: 4994861
Change-Id: I6ae256a94dbaddea4304304779d17025620c5025
2012-02-03 18:45:44 +09:00
909b2940db
Merge "Get rid of Key.setIcon(Drawable)"
2012-02-02 21:51:51 -08:00
e7948a8692
Get rid of Key.setIcon(Drawable)
...
Change-Id: If6ebbdefcbfd0cc14c72858f9bb44861e8abe079
2012-02-03 14:38:17 +09:00
825e2bbd91
Fix a bug when deleting the last char
...
And unit test
Change-Id: Ic4fc3626f8b86e10156d770d41cd6deab5d31f39
2012-02-03 13:03:54 +09:00
71915a3722
Merge "Fix string iterations in a couple places."
2012-02-02 18:40:19 -08:00
9242a2bcf8
Fix string iterations in a couple places.
...
Seems I didn't get how to iterate on a String correctly >.>
Talk about a big bug. Anyway, I think it's working now.
Bug: 5955228
Change-Id: I988c900cf2a16c44b9505cfd4f77c7cda7e592f0
2012-02-03 11:15:46 +09:00
32c54c4dbe
Fix key repeat interval timeout
...
Bug: 5960472
Change-Id: I27d4b81d393f2ace946740a0b0801cea8c63b5b8
2012-02-03 10:02:22 +09:00
44e0e4f99e
Fix Key.equals(Key)
...
Bug: 5956068
Change-Id: I2901ae28bd9121ec4f4429a53b83aae128b75e0c
2012-02-02 21:33:50 +09:00
5852a2594f
Parse escaped sequence strictly in CSV parser
...
This change alters the CSV parser behavior. The parser only resolves
* String resource reference. ["@string/res" -> "<content_of_res>"]
* Other occurrence of escape sequence will be intact. ["\x" -> "\x"]
Before this change, escape sequence in moreKeys string is parsed three
times. At first in parsing string resource, next in CSV parser, and at
last in KeySpecParser. So that representing single escape character
itself is a bit annoying, "\\\\\\\\".
Now we can represent single escape character itself in string resource by "\\\\".
Change-Id: Ib978e17b779cc82585eed8241ac3857508b14bc7
2012-02-02 20:19:26 +09:00
8261a4cad7
Merge "Move CSV parser to KeySpecParser"
2012-02-01 23:25:17 -08:00
0086861d5a
Move CSV parser to KeySpecParser
...
Change-Id: I424fb47bc70e9b6aaa5a16ae9b2500d23da75c26
2012-02-02 16:10:14 +09:00
e05b3f4b3a
Support additional proximity characters
...
Change-Id: Ifbe0d7e4eafea1926bbce968eae4724dd5769689
2012-02-02 16:07:16 +09:00
8ca325f437
Merge "Make KeySpecParser and CSV parser code point aware"
2012-02-01 22:56:54 -08:00
e01d272603
Make KeySpecParser and CSV parser code point aware
...
This change also renames MoreKeySpecParser to KeySpecParser
Change-Id: I35733cdbb344f16b57ffa2cfe79055c089b4e409
2012-02-02 15:51:40 +09:00
51fd1632f5
Stop throwing an exception in some corner cases.
...
When the application is modifying the text under our feet,
we may come through this code path. We should log the error
rather than crash.
Bug: 5869235
Change-Id: Ic0fd24c3bc805d44c5db0ad781ddebeca0450614
2012-02-02 15:15:55 +09:00
c603409f28
Removed CODE_CAPSLOCK from keyboard accessibility (fixing build).
...
Change-Id: Ibc7ef979276f563444f3c24e69ac32de5d4eb6e8
2012-02-01 10:27:52 -08:00
02dd837805
Merge "Removed spoken descriptions for characters supported by TTS or TalkBack."
2012-02-01 10:00:17 -08:00
9737351775
Merge "Refactored shift key spoken description into separate method."
2012-02-01 09:59:59 -08:00
71c695da22
Remove BIDI mirroring hack from Key
...
This change also removes isRtlKeyboard attribute from <Keyboard/>
Bug: 5948247
Change-Id: I85998f17ae146a4c8cd0f419ab820b746cb8974f
2012-02-01 22:58:16 +09:00
40e9012276
Fix wrong long press timeout for shift key
...
Change-Id: Ifafbed1bcdaf662ee6a69050043739fa71986841
2012-02-01 21:15:34 +09:00
ff858c7ff5
Use MoreKeySpecParser to parse puctuations strip resources
...
This change also
* Doesn't use Key.getRtlParenthesisCode to get correct parentheses
code in RTL context. Intead uses the outputText feature of
moreKeys specification.
* Move CVS string parser from KeyStyles to Utils.
Bug: 5948247
Change-Id: I45752c7d01b4f7d3f3da900b110a2185b336a1f0
2012-02-01 19:33:26 +09:00
a5c96f376a
Move long press shift handling from PointerTracker to KeyboardState
...
This change also
* Rename phone shift keyboard to phone symbols keyboard.
Use CODE_SWITCH_ALPHA_SYMBOL code to switch between phone and phone symbols keyboard.
* Remove phone symbols keyboard from tablet.
* Introduces enableLongPress flag of Key.keyActionFlags attribute.
* Remove clumsy long press code from PointerTracker.
* Remove CODE_CAPSLOCK handling from LatinIME.
* Make KeyboardSwitcher to invoke haptic and audio feedback.
Change-Id: I00e1f697a10ab5112aec75e36853b96246ff5054
2012-02-01 19:04:21 +09:00
7ca1249797
Refactored shift key spoken description into separate method.
...
Change-Id: I183462a68fdfd339404740fa1564f737430d73d9
2012-01-31 13:03:39 -08:00
f3e951b259
Removed spoken descriptions for characters supported by TTS or TalkBack.
...
Change-Id: Iddef18559bc6af9487e536a33607b0a0b07df282
2012-01-31 13:02:33 -08:00
3feb99fa6c
Merge "Save/restore alphabet shift locked state while rotating even in symbols mode"
2012-01-31 02:26:41 -08:00
49bd49c8fb
Save/restore alphabet shift locked state while rotating even in symbols mode
...
Bug: 5730212
Change-Id: Id2342dacd149d6385d61001f880ebcd1883cf0b4
2012-01-31 19:11:39 +09:00
aab33aac0a
Merge "Cleanup redundant methods of KeyboardSwitcher"
2012-01-31 01:33:17 -08:00
88e079ae6b
Cleanup redundant methods of KeyboardSet
...
Change-Id: I69fa1b5661695d0323222c2969679f4792b6ef0d
2012-01-31 18:27:37 +09:00
0ed2d3a449
Fix double tap shift key enable/disable shift locked mode
...
Bug: 5942452
Change-Id: I2c7b1605bceac2b2f929cd4d97c417ef15c6f754
2012-01-31 18:06:54 +09:00
433ca6a46d
Cleanup redundant methods of KeyboardSwitcher
...
Change-Id: I2ebeb8852177f6c6e30578d0bb3f372f488dc6c1
2012-01-31 17:18:14 +09:00
30964843db
Merge "Auto generate various shift states alphabet keyboard automatically"
2012-01-30 20:07:26 -08:00
ca2f051cc1
Auto generate various shift states alphabet keyboard automatically
...
If any shift state variants of alphabet keyboard layout is not
specified in KeyboardSet.Element, it will be automatically generated
from base alphabet keyboard definition.
This change also
* Eliminates KeyboardShiftState object from Keyboard.
* Removes various set shift state methods from Keyboard.
* Removes KeyboardSet.Element.elementAutoGenerate attribute.
* Separates "sticky" Key.backgroundType to "stickyOff" and "stickyOn"
* Add preserveCase flag to smiley, .com, and labeled special keys.
* Rename KeyboardShiftState class to AlphabetShiftState.
* Rename some attributes from *UppercaseLetter* to *ShiftedLetterHint*.
* Introduce shiftedLetterActivated to Key.keyLabelFlags
Change-Id: I01a0a8efeeaa76820ae728a5bdfa8d02b6ce74b7
2012-01-31 12:55:45 +09:00
16f7439682
Removed unused "no item selected" notification & supporting code from keyboard accessibility.
...
Change-Id: Ia6323ad0c1e2a0db5a2cf830e97765eddaa32cee
2012-01-30 13:45:59 -08:00
3b0f2bf169
Merge "Support addtionalMoreKeys"
2012-01-30 00:11:29 -08:00
15c99e9f1a
Support addtionalMoreKeys
...
This change also removes
* Unused more_keys_for_q, w, and p.
Change-Id: Idb99e5f6d8c2ad2d28437f42b35b21c282cd181f
2012-01-30 17:04:25 +09:00
6029b43a3d
Add "size" and "pressure" for MotionEvent logs
...
bug: 5722703
Change-Id: I8e08942324b666de96682ce63e70c8d324535782
2012-01-30 12:22:15 +09:00
a1e370ee4f
Support keyXPos/keyWidth override in <include>
...
Change-Id: I03576a6fb7916f2f66f2035a04872fe89b573cdc
2012-01-27 21:20:57 +09:00
425e1996b8
Add inactivatedLabel and inactivatedUppercaseLetter flags for Key.keyLabelFlags
...
Change-Id: I6c7dc79cbad360602b278283f4c3a24c54040622
2012-01-27 18:11:43 +09:00
c882d619bf
Merge "Save and restore previous mode keyboard state at KeyboardState.toggleAlphabetAndSymbols"
2012-01-26 23:45:36 -08:00
f057b25cdd
Save and restore previous mode keyboard state at KeyboardState.toggleAlphabetAndSymbols
...
Bug: 5881820
Change-Id: I9b1718b16c60f27c05ba727724c0189aa5284334
2012-01-27 16:03:51 +09:00
449415c72f
Cleanup (A9)
...
Deactivate the LastComposedWord when the commit was not the right
type, instead of fooling it by passing it a null auto-correction.
Change-Id: I032b477dc691bd151a644ca4b0c9f0a9b5512e45
2012-01-26 20:10:49 +09:00
5971a0a0bb
Remove a useless member (A8)
...
It turns out this can be removed entirely.
Change-Id: I6f23703cef1666311989a825285317eef696487f
2012-01-26 20:10:49 +09:00
5ef094f816
Merge "Remove the CharacterStore class (A7)"
2012-01-26 03:09:31 -08:00
1112a545cc
Merge "Add KeyboardState.SwitchActions.setAlphabetShiftLockShifted"
2012-01-26 03:05:47 -08:00
be79227dc9
Remove the CharacterStore class (A7)
...
Remove the now useless WordComposer.CharacterStore class
and merge back its members inside WordComposer. This should
simplify the word composer a bit.
Change-Id: I5fe32418c62a583cd558dce98758a4701559bdf5
2012-01-26 20:03:44 +09:00
c7c152de4b
Guard against wrong auto-correction cancellation (A6)
...
This deactivates the cancellation at each separator pressed while
not composing a word. The net effect is to fix
Bug: 5875776
Change-Id: I67aa3f842ddff250828c60596ad5a7e466c1ddaa
2012-01-26 19:57:37 +09:00
b6b8729374
Straighten out resuming suggestion on kept word (A5)
...
This is cleanup.
This also introduces a "deactivated" state to the last committed
word, that can be used for
Bug: 5875776
Change-Id: I1855adb8ac8123f6d2c5365b0ae899145e5c3ba1
2012-01-26 19:24:36 +09:00
2712f23acb
Remove mCommittedWordSavedForSuggestionResuming (A4)
...
Change-Id: Ia62ef33b5c777a258b02280bda1b8368780a7eef
2012-01-26 18:36:28 +09:00
757f8d96ee
Add KeyboardState.SwitchActions.setAlphabetShiftLockShifted
...
Change-Id: I6c49d8eb0a8272840ff03e0940d88a31c3d20bd9
2012-01-26 18:25:48 +09:00
2692a87007
Move some functionality into LastComposedWord (A3)
...
Change-Id: Ie0ea02a061dd0cb84db5f33113ff433584636bc7
2012-01-26 18:25:08 +09:00
1f8fc62ccb
Add useful information to LastComposedWord (A2)
...
Change-Id: Idf47f2e2bdd1d6394fc4b1ab7df28d64a808da1e
2012-01-26 17:49:55 +09:00
95eeb2df63
Merge "Add a class for previously composed data (A1)"
2012-01-26 00:43:57 -08:00
267563d1bb
Add a class for previously composed data (A1)
...
Change-Id: I87498799e6a48b8fa65924a098bb0ceb7626dce1
2012-01-26 17:22:52 +09:00
736d740aa5
Merge "Get rid of Resource reference from KeyboardView, LatinKeyboardView and PointerTracker"
2012-01-26 00:17:56 -08:00
160f01211d
Get rid of Resource reference from KeyboardView, LatinKeyboardView and PointerTracker
...
This change introduces the following attributes.
* KeyboardView
- keyPreviewLingerTimeout
* LatinKeboardView
- keyHysteresisDistance
- touchNoiseThresholdTime
- touchNoiseThresholdDistance
- slidingKeyInputEnable
- keyRepeatStartTimeout
- keyRepeatInterval
- longPressKeyTimeout
- longPressShiftKeyTimeout
- longPressSpaceKeyTimeout
- ignoreSpecialKeyTimeout
- showMiniKeyboardAtTouchedPoint
Change-Id: I25159a87289b12447e20031add173523070e9b03
2012-01-26 16:10:20 +09:00
bd51aaf98f
Merge "Warn deprecated privateImeOptions, "nm" and "forceAscii""
2012-01-25 22:20:35 -08:00
051ac1ef14
Merge "Add a guard against OOB."
2012-01-25 21:22:18 -08:00
8be16f78b1
Add a guard against OOB.
...
...and avoid crashing in one case where the application may
change the text while we are typing.
Bug: 5685922
Change-Id: I4a22c63168986f43ac84f512aaa4267023d536e3
2012-01-26 14:17:48 +09:00
5a38ff305f
Merge "Convert an internal enum into an int of same underlying value."
2012-01-25 21:13:56 -08:00
4f5c3a2898
Warn deprecated privateImeOptions, "nm" and "forceAscii"
...
Public API EditorInfo.IME_FLAG_FORCE_ASCII has been supported by
I6665b483.
Change-Id: I0ffdee15d8177d126cd8fe86a6bc4ab21be58c36
2012-01-26 13:37:35 +09:00
6e082cb30d
Convert an internal enum into an int of same underlying value.
...
Goes together with Id4f4e066
Bug: 5922118
Change-Id: I1e39dd01c67e9284d9d7fe008d868847e69986d7
2012-01-26 13:07:51 +09:00
fda847a870
Small cleanup
...
All calls to this method are done with the same parameter,
and it's really hard to understand if we call upon this
member inside.
Change-Id: I787664bb59053ab0fe666ed812fb12b2b9090918
2012-01-26 11:40:16 +09:00
09f8b126e5
Add Key preserveCase enum to keyLabelOptions attribute
...
To support auto generate key depending keyboard element id, the
KeysCache class is introduced to hold whole keys and reuse.
Change-Id: Icb81b5f1c1b3aaa31968dcdb93aa0a856e737f78
2012-01-25 20:16:21 +09:00
bcf2b79365
Prepare to get rid of Drawable reference from Key
...
Change-Id: If435f95b2863e0af8d8916c643e6b01feabd3ea5
2012-01-25 19:41:15 +09:00
2419a31c98
Merge "Add element predicator to <switch><case> condition of Keyboard"
2012-01-25 02:37:27 -08:00
9650e85662
Merge "Draw language name on spacebar on the fly"
2012-01-25 02:37:22 -08:00
d9702a375a
Merge "Add a test for auto-correction."
2012-01-25 02:33:39 -08:00
0bfe359ee4
Add a test for auto-correction.
...
Fix two related subtle bugs:
- Stop singling out fat-finger-only corrections for rejection
when touch coordinates are not available.
- Remove a racy check that would happen only in debug mode
Change-Id: Ic904f9b27c091ca6b369052c4e65a630bff81257
2012-01-25 19:29:40 +09:00
83306b914f
Add element predicator to <switch><case> condition of Keyboard
...
Change-Id: I8f9eb8eb28707d23e421e88f979022d844a3b3ee
2012-01-25 19:09:18 +09:00
bd93eddb52
Draw language name on spacebar on the fly
...
Change-Id: If54251acbd40d0dda37df1b368ed76dcdf3c8ac0
2012-01-25 19:05:58 +09:00
f9521c6f37
Change scope of some methods in KeyboardView
...
Change-Id: I6569b413b20a2e683c6c636aafd755f51868dd28
2012-01-25 18:50:27 +09:00
f9c6715b17
Merge "Use PointerTracker.getPointerTracker() class method"
2012-01-25 00:51:22 -08:00
38d6a18821
Use String instaed of CharSequence in Key class
...
Change-Id: Ia76a41daede402ed2a509e110ae97d6bb660c760
2012-01-25 17:04:00 +09:00
117c124c13
Add autoGenerateFromAlphabet enum to KeyboardSet.Element.elementKeyboard
...
This is the first step to support separate Keyboard for elementName.
This change is the second attempt of Icef66564.
Change-Id: I78ea6cb9ea3d965ff89e0ff5d896a6b11ba5c670
2012-01-25 13:19:53 +09:00
e88e1b22c8
Use PointerTracker.getPointerTracker() class method
...
Change-Id: Ieab5d43d2bfe9bdf2b499834dff267df84b8d76d
2012-01-25 11:08:30 +09:00
af4efd5a3e
Merge "Revert "Add autoGenerateFromAlphabet enum to KeyboardSet.Element.elementKeyboard""
2012-01-24 15:22:25 -08:00
8bb20bc682
Revert "Add autoGenerateFromAlphabet enum to KeyboardSet.Element.elementKeyboard"
...
This reverts commit b5b92f9b78
2012-01-24 15:20:05 -08:00
a34f66de2d
Merge "Add autoGenerateFromAlphabet enum to KeyboardSet.Element.elementKeyboard"
2012-01-24 01:34:31 -08:00
b5b92f9b78
Add autoGenerateFromAlphabet enum to KeyboardSet.Element.elementKeyboard
...
This is the first step to support separate Keyboard for elementName.
Change-Id: Icef66564b6938910fa06ecab664dce4be84c9505
2012-01-24 18:31:11 +09:00
20f437cc49
Merge "Test that delete actually removes any selected text."
2012-01-24 01:19:26 -08:00
1e4684ad24
Test that delete actually removes any selected text.
...
Bug: 5699301
Change-Id: I09a967eb03690251e8bd69503285c982d6958a7d
2012-01-24 18:17:09 +09:00
196da4a7be
Merge "Fix a bug where backspace would not delete the selection"
2012-01-24 01:13:34 -08:00
77da3d5a3b
Fix a bug where backspace would not delete the selection
...
Bug: 5699301
Change-Id: I6c5a8470464d045349ac38e191c859b5c34cbeee
2012-01-24 18:07:23 +09:00
25971b5a14
Clean up symbol key chording state from KeyboardState
...
Change-Id: I575da2bf2941c8a2e7b1fe0a455cbcdebb201276
2012-01-24 17:59:35 +09:00
83d81f2e34
Fix sliding shift input in caps lock mode
...
Bug: 5881820
Change-Id: I4cbe3eda83c09edc9da8efbdff7d3359c1e140d5
2012-01-24 17:58:23 +09:00
747ed9e99a
For get the symbols shifted state when switch back from alphabet layout
...
Bug: 5881820
Change-Id: Ic478264e1cd366affc34fbf4cd59f1b6e7efede7
2012-01-24 17:28:00 +09:00
0f05076990
Get rid of setShifted/setShiftLocked from SwitchActions
...
Change-Id: Ib54b0575be190556690ef2dfb14077842745f038
2012-01-24 12:27:09 +09:00
5fd11a7f33
Fix a typo
...
Change-Id: I358350c959d5610214a752b14d7744fe83eb3821
2012-01-24 11:58:07 +09:00
4eb240eb2c
Force KeyboardShiftState reset by setShiftLocked(false)
...
Change-Id: Ib00d598e6e6a91e594ae01cfc51fb688601f6b8f
2012-01-23 13:18:06 +09:00
69fa792184
Merge "Get rid of useless updateShiftState"
2012-01-22 20:16:46 -08:00
b6357bddd5
Merge "Add more debug message to KeyboardState"
2012-01-22 20:15:38 -08:00
457e506e1a
Add more debug message to KeyboardState
...
Change-Id: Ie0bceb494b0521bf406418d5ecbc16752c818aba
2012-01-23 13:14:02 +09:00
56518d424d
Get rid of useless updateShiftState
...
Because KeyboardState.onLoadKeyboard will invoke
SwitcherActions.requestUpdateShiftState eventually, the calling
updateShiftState at the end of KeyboardSwitcher.onLoadKeyboard is
useless.
Change-Id: Ib6e746b1516ef1b4c981807a9b8785a046ba50e0
2012-01-23 12:47:03 +09:00
35e9a7ac55
Merge "Squash a ridiculously improbable NPE"
2012-01-22 18:37:29 -08:00
b009a24b83
Support @icon/icon_name for more keys specification
...
Change-Id: I8842e5ce77f9d27a0969df947de292c1830e36b7
2012-01-20 20:09:02 +09:00
54c2dd67b0
Merge "Support @string reference in moreKeys attribute"
2012-01-20 01:59:31 -08:00
e54a4005d5
Support @string reference in moreKeys attribute
...
Change-Id: If0056d0601149d2ddd0e231a81e7b2409b37fc06
2012-01-20 18:46:33 +09:00
7c177e82af
Merge "Fix a bug where a check would fail"
2012-01-20 01:16:44 -08:00
7546ff6e34
Fix a bug where a check would fail
...
Bug: 5894393
Change-Id: I810de58730f2cabcaf7b8dc1d85b3725f959094b
2012-01-20 18:09:59 +09:00
3eede315dc
Merge "Move MoreKeySpecParser.getResourceId to Utils"
2012-01-20 00:01:29 -08:00
86641ef6e8
Merge "Change more key specification type to String from CharSequence"
2012-01-20 00:01:24 -08:00
0718590486
Move MoreKeySpecParser.getResourceId to Utils
...
Change-Id: I0640dbe76a8ff2dc45b504eca631942811571736
2012-01-20 16:28:18 +09:00
bd7b160cfb
Change more key specification type to String from CharSequence
...
Change-Id: I5e910f8225a248fc6403771836dec4c0b7294caa
2012-01-20 16:27:32 +09:00
af9fe5c5fc
Fix a bug where the user typed word would not be passed.
...
Bug: 5894271
Change-Id: I4f02ff322697159e08f5e898608c0aff11dacb2f
2012-01-20 15:39:06 +09:00
0ef9bfe593
Merge "Fix KeyboardState switching back from alphabet-chording input correctly"
2012-01-19 02:14:20 -08:00
085b659463
Merge "Fix KeyboardState to pass KeyboardStateMultiTouchTests"
2012-01-19 02:14:15 -08:00
4d229410f0
Merge "Cleanup KeyboardState a bit"
2012-01-19 02:14:10 -08:00
250cf0a781
Merge "Fix a bug with backspace happening after a manual pick."
2012-01-19 01:55:30 -08:00
f36f90a173
Fix KeyboardState switching back from alphabet-chording input correctly
...
Bug: 5881820
Change-Id: I108bbc25baa331cc87f00955b48188b3557d10dd
2012-01-19 18:53:38 +09:00
d26d63b35d
Fix KeyboardState to pass KeyboardStateMultiTouchTests
...
Change-Id: If2b9ee7cf3fad7633d64b98758f802792d66f7a8
2012-01-19 18:48:02 +09:00
01d9fc966a
Cleanup KeyboardState a bit
...
Rename KeyboardShiftState variable and reorder some statements.
Change-Id: I7e8842836f35876f8697f9906343f7d4a1f9db4f
2012-01-19 18:42:11 +09:00
3b2112e70a
Fix a bug with backspace happening after a manual pick.
...
Bug: 5884397
Change-Id: I01f462075bcbf7da38e9af2084ecd37143923e8b
2012-01-19 18:41:02 +09:00
8ae770f39b
Merge "Small code simplification."
2012-01-19 01:33:21 -08:00
95a6e58ebc
Small code simplification.
...
I'm pretty sure the test here was useless.
Change-Id: Iaece641fbd5455406533b19555f2b639759a525f
2012-01-19 18:03:45 +09:00
23bacdb6a5
Fix MoreKeySpecParser to be able to handle outputText correctly
...
The issue was introduced by Id2320f4d.
Bug: 5887936
Change-Id: Ifec3aefb5b168f790de696ece104b84cdab46539
2012-01-19 12:51:27 +09:00
af480be66e
Squash a ridiculously improbable NPE
...
This probably can't be triggered by anything that is not
a monkey, but still, let's fix this
Bug: 5797549
Change-Id: I9a7d9fd6664c97787ce676a28675e96f46df7658
2012-01-19 12:06:00 +09:00
06bc1db017
Add more multitouch tests
...
Change-Id: I424a4b608fec084cb787003ef4417ccf273366ae
2012-01-18 19:35:01 +09:00
60c4594ee6
Get rid of hasDistinctMultitouch reference from KeyboardState
...
Change-Id: I0a783a425302fbc381d056f5b0d757c27f2a9f14
2012-01-18 18:11:46 +09:00
5731b939c7
Remove KeyboardSwicther.toggleCapslock
...
Change-Id: Id613c06e2df770659095d78d42637aed063d0c70
2012-01-17 19:26:24 +09:00
2a88440419
Rename KeyboardActionListener methods
...
* Rename KeyboardActionListener.onPress to onPressKey
* Rename KeyboardActionListener.onRelease to onReleaseKey
* Merge KeyboardSwicther.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardSwitcher.onReleaseShift and onReleaseSymbol to onReleaseKey.
* Merge KeyboardState.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardState.onReleaseShift and onReleaseSymbol to onReleaseKey.
Change-Id: Icf28fd18e238c5e534c292893e4ab5b6b98e72f8
2012-01-17 19:07:20 +09:00
c9fade6b87
Merge "Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher"
2012-01-17 00:07:38 -08:00
87e025da11
Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher
...
Change-Id: I9bb8f78b0a766cd7937d5cbe1c1e5e35898b2997
2012-01-17 16:49:33 +09:00
d104a7aac8
Merge "Fix a bug where words disappear on inserting separators"
2012-01-16 23:22:03 -08:00
edc6395d9b
Fix a bug where words disappear on inserting separators
...
The basic idea is that in some situations, we would restart
suggestions, but before evaluating them we would bail out
because suggestions were not requested. This would lead to
the "correction" set to null, so we would commit a null word.
This fix does two things:
- Do not restart suggestions when not requested.
- If we still end up with a composing word when suggestions
are not requested, we select the typed word as the
correct version.
Bug: 5846646
Change-Id: Ic35351841d0cb20afa99092ef681ecb7bd68bec6
2012-01-17 16:16:52 +09:00
aed5819a84
Merge "Fix a bug where suggestion would restart at a bad time"
2012-01-16 22:51:23 -08:00
fbd1ac8083
Fix a bug where suggestion would restart at a bad time
...
Bug: 5846646
Change-Id: I7c907d0a9478e0878b92ead94173caefc21b627b
2012-01-17 15:50:18 +09:00
1ef6fc7e15
Support EditorInfo.IME_FLAG_FORCE_ASCII
...
Bug: 5850605
Change-Id: I6665b483f775094903f2e26f5584e4b141592ab5
2012-01-17 14:38:00 +09:00
edf107e2a6
Merge "Add "force non-distinct multitouch" debug option"
2012-01-16 20:22:36 -08:00
2764e1dffe
Merge "Remove duplicate logic from KeyboardSwitcher and KeyboardState"
2012-01-16 20:22:34 -08:00
06b7c256b1
Add "force non-distinct multitouch" debug option
...
Change-Id: I9fd6fabf03515011cedb8aaa30fdb7a77f2d4d12
2012-01-17 13:19:01 +09:00
a8ba49c253
Small cleanup
...
The method deleteWordAtCursor would call finishComposingText,
which is a very unexpected state change and would probably cause
surprising bugs to any parent that would call it.
As it happens, it's not used anywhere any more so let's just
remove it.
Change-Id: Iaa9200866e40b4e914f76baa987279948300679c
2012-01-17 11:55:23 +09:00
72d285f4d7
Add some comments about resuming auto-suggestion
...
Bug: 5846646
Change-Id: Ib2c76ec173972eb7acadbfaae7e930849d546721
2012-01-17 10:29:11 +09:00
58e782a225
Remove duplicate logic from KeyboardSwitcher and KeyboardState
...
Change-Id: I1d331ee7f71501baa4ec2df01df39340499834e4
2012-01-16 19:16:26 +09:00
7bc61ca183
Fix double tap shift key to turn off capslock mode
...
Bug: 5873562
Change-Id: If1f5ae1684905c1418ae43e55df38509444d29e2
2012-01-16 18:54:25 +09:00
9751a626ec
Don't cache resource value that depends on orientation
...
Bug: 5794655
Change-Id: Ib324366c772e20bb54aba63c2f4540dc0f9de515
2012-01-16 12:26:34 +09:00
c88026e1df
Update shift state when alphabet keyboard has been set
...
Bug: 5857492
Change-Id: I5ef78af21a76e8cf645e223d1ffa6212690bb1eb
2012-01-16 11:08:29 +09:00
ca132ce8e2
Merge "Remove reference of SubtypeSwitcher and SettingsValues from KeyboardSet"
2012-01-13 01:39:50 -08:00
211680e375
Merge "Fix SuggestTests"
2012-01-13 01:39:43 -08:00
4087ba69fa
Remove reference of SubtypeSwitcher and SettingsValues from KeyboardSet
...
Change-Id: I6c1150eea5f0a931d01578b0157f06e0aff0cc65
2012-01-13 18:05:28 +09:00
9c735b8038
Fix SuggestTests
...
We need revised scoring test because dictionary look up algorithm has
been changed significantly since this SuggestTests was made.
Change-Id: I69d527a6bfa24ed0dc189fddad1afab0566c6eb8
2012-01-13 15:25:28 +09:00
76dede6b3b
Merge "Fix SubtypeLocaleTests"
2012-01-12 22:17:20 -08:00
4015a64a26
Fix SubtypeLocaleTests
...
Change-Id: Id85814aa3bcd9cacbe446b2dfda3ca2ab9146c13
2012-01-13 14:35:43 +09:00
4da8e8e4d3
Merge "Fix a bug in the logic to show 3 dots of the ime switcher"
2012-01-12 19:41:12 -08:00
83a018419a
Fix a bug in the logic to show 3 dots of the ime switcher
...
Bug: 5806103
Change-Id: I67b3f0bb25d5fb9cfb902c03f41ae3e582107187
2012-01-13 11:50:31 +09:00
21814c56f0
Merge "Move auto correction thresthold to the native code"
2012-01-12 02:58:35 -08:00
be0cf72253
Move auto correction thresthold to the native code
...
bug: 5858137
Change-Id: Ic4b6270c6e51ef4ed25a6a1d8ddd7fdfa70fd78d
2012-01-12 19:56:15 +09:00
ab34a4a7f5
Merge "Fix a bug where last candidate would not be reset"
2012-01-11 21:47:35 -08:00
cda8a42cbe
Merge "Add a sanity check"
2012-01-11 21:47:26 -08:00
a8c8ab1cb4
Remove an excessive parens
...
Change-Id: If8aa4253ab0f664e628ed7f4d7a3adc02a898cc7
2012-01-12 14:07:56 +09:00
852630ba34
Add a sanity check
...
Check if any character is both a magic space swapper and
a magic space stripper for the current language, and throw
an exception if found. Since this is expensive, it's done
only in debug mode.
Change-Id: Ibd166db87c91495b76878ea0e4f420a62c7bb276
2012-01-12 12:44:49 +09:00
9de5cfc67a
Fix a crash where revertSwap would be wrongly called
...
This would crash the program when inputting a punctuation
symbol that should not swap with a weak space through the
suggestion strip, then press backspace.
Those include all two-part punctuation symbols in French for
example, as well as magic space strippers like the dash in
English. For English all suggestion strips symbols happen to
be magic space swappers so this would not happen in English
by default.
Also fix a typo.
Change-Id: Ia40678c264e978509b5786290a75a3c57181648e
2012-01-12 11:55:40 +09:00
cd2286fff1
Fix a bug where last candidate would not be reset
...
Bug: 5851148
Change-Id: Ic270318842d8e16bc62d78d5fe0d6be0ca1fb532
2012-01-12 11:16:51 +09:00
8cab0b56eb
Get rid of Keyboard.CODE_DUMMY
...
Change-Id: Id2320f4d9b5f22f0ac844ab20ce42b0c4e7c6880
2012-01-10 18:19:36 +09:00
ee4be6e3c6
Call KeyboardState.onUpdateShiftState from onCodeInput if code is a normal letter
...
This will be helpful to write unit test code.
Change-Id: Ib61cc46ac547084e0dc9ecd3a50814fecf08ace2
2012-01-10 15:13:05 +09:00
0fe45eac18
Merge "Optimize KeybaordView.invalidateAllKeys a bit"
2011-12-26 06:50:31 -08:00
9f6485a448
Optimize KeybaordView.invalidateAllKeys a bit
...
Change-Id: I118c792219f649b7297477c78fa725c678650159
2011-12-26 23:43:53 +09:00
07145a3706
Fix automatic temporary upper case mode shift key graphics
...
Bug: 5802387
Change-Id: I4f59fb2f971c543748ed32b37af528767a0549e4
2011-12-26 21:05:33 +09:00
0d0f01da67
Fix a typo. A follow up to I68dd6b8d
...
Change-Id: I16fa4099c75faac35344b0e4d3c2b866ddac896a
2011-12-21 22:34:08 +09:00
0fd625bcfd
Fix a bug with wrong auto-correct cancellation
...
Auto-correct cancellation would sometimes kick in at
wrong times, causing crashes.
Bug: 5784542
Change-Id: I68dd6b8d9237ce9b66af2dc63e77ba6dd5fd69dd
2011-12-21 19:28:02 +09:00
752d8cc4fc
Fix a bug with TYPE_TEXT_CLASS
...
This was introduced by a badly-rebased commit. The culprit was
I103d6851. There was also another bug lurking there introduced
by a previous commit that this fixes.
Bug: 5775347
Change-Id: I133b54a5159e19714f4bcae8ffbb4824cff9f466
2011-12-20 15:31:55 +09:00
715a203501
Merge "Reorganize the auto-correction memory"
2011-12-19 02:22:49 -08:00
4f7d278af6
Follow-up fix for I68c667b0
...
Should have preserved the logic of LatinKeyboard.getNearestKeys().
Change-Id: I97b05aa24006402be03088a215fa07abda9477df
2011-12-19 17:58:36 +09:00
9e8761c440
Reorganize the auto-correction memory
...
Change-Id: I31cce9db471dcd4a7b3477bcb037a8ff482b7696
2011-12-19 17:33:15 +09:00
42fcb2de64
Get rid of public reference to KeyboardIconsSet.ICON_* constants
...
As a consequence,
* Add Key.iconDisabledKey has been introduced and Key.getIcon honors
the enabled state of the key.
* The attribute id of disabled icon for shortcut key,
Keyboard_iconShortcutKeyDisabled, is renamed to
Keyboard_iconDisbledShortcutKey
* KeyboardIconsSet has getIconByIconId and getIconByAttrId methods
instead of getIcon.
Bug: 5778201
Change-Id: Ica93b073b9a04acd18ead7a33b60e3c6d813e7a1
2011-12-19 01:11:09 +09:00
4e1dab8cfa
Move KeyboardBuilder and KeyboardParams classes into Keyboard class
...
This change also moves XmlParseUtils to com.android.inputmethod.latin package.
Bug: 5778201
Change-Id: I7d9faa344460753ce178ad4048e0fadb65c75614
2011-12-18 20:19:16 +09:00
3708787fe9
Remove LatinKeyboard class
...
Change-Id: I68c667b00dadf2ed9f1c62fb7da37d2cf499cd81
2011-12-18 19:10:42 +09:00
4112dc0500
Move spacebar drawing code from LatinKeyboard to LatinKeyboardView
...
Also this change moves LatinKeyboard attributes,
autoCorrectionSpacebarLedEnabled, autoCorrectionSpacebarLedIcon,
spacebarTextRatio, spacebarTextColor, and spacebarTextShadowColor to
LatinKeyboardView.
Change-Id: I7cc27ce1fc550e9f620a9ed0fbe4b8172902d5a1
2011-12-18 19:07:12 +09:00
7bd714c086
Add extra key icons to KeyboardIconsSet
...
* Get rid of Key.keyIconShifted attribute.
Add Keyboard.iconShiftKeyShifted to KeyboardIconsSet.
* Get rid of LatinKeyboardView.disabledShortcutIcon attribute.
Add Keyboard.iconShortcurKeyDisabled to KeyboardIconsSet.
* Add Keyboard.iconSpaceKeyForNumber to KeyboardIconsSet.
* Fix misplaced autoCorrectionSpacebarLedIcon resources.
Change-Id: I381bff3789254977ab3cb18f58f95b3c433b1e1a
2011-12-18 18:25:29 +09:00
1ebedd7a15
Remove LatinKeyboard.adjustLabelCase override
...
Change-Id: If032605c1cd6bb8e913d465e20dec70798c4b8fb
2011-12-18 16:46:44 +09:00
5afc3ae2d9
Add LatinKeyboardView style
...
As a result, this change moves shortcut related update code to
LatinKeyboardView from LatinKeyboard.
Change-Id: I1882672577f61e73c90d6c018b7dbb61f3fe21e4
2011-12-18 16:42:23 +09:00
22b48de11c
Get rid of Key.needsSpecialPopupHint and related
...
Change-Id: I28e87ea3af9581f12094770b42f113e9018886c4
2011-12-18 16:08:28 +09:00
bc781e963f
Can override key drawing methods of KeyboardView
...
Change-Id: Ie303df4f5e944ea868f5c28ba3bb72a57cc9a35f
2011-12-18 16:08:00 +09:00
605f730959
Merge "Add LatinKeyboard.spacebarTextRatio attribute"
2011-12-17 08:43:34 -08:00
40a6739645
Fix broken build
...
This is a followup change of I8376f4f5
Change-Id: I4de4cbc903beb71d805e62b5172076a949854bc0
2011-12-18 01:36:11 +09:00
7cc2595b6f
Add LatinKeyboard.spacebarTextRatio attribute
...
Bug: 5776979
Change-Id: Ia568d1170ed33a000eb3bb02ecdf611e4b5ff2d5
2011-12-18 01:00:06 +09:00
ebec5259b7
Get rid of LatinKeyboardParam class
...
Change-Id: I8376f4f570e72929679c5e4955986c48881abd75
2011-12-18 00:39:40 +09:00
67394a394f
Preparatory small clean up for bug: 5776979
...
Change-Id: I96b20d3775180366fac50c2bb4e0b47a92ee4cdb
2011-12-17 20:45:39 +09:00
3425852be4
Remove redundant logs
...
bug: 5722703
Change-Id: I6b7285ad6f5c0c8486d24712f22249f83a1c6396
2011-12-17 00:22:01 +09:00
4af75010a1
Merge "Use Set to group Keys in Keyboard instead of List"
2011-12-16 04:26:25 -08:00
7c69397f14
Merge "Fix swapped alphabet and symbols keyboards"
2011-12-16 04:15:35 -08:00
510ebb9b16
Merge "Get rid of key index from ProxymityInfo"
2011-12-16 04:13:38 -08:00
854302282d
Fix swapped alphabet and symbols keyboards
...
Change-Id: I956684332d607cb9ab01d12af7a924c15def7fce
2011-12-16 21:12:06 +09:00
4a019a9c96
Use Set to group Keys in Keyboard instead of List
...
In deriving various shift stated alphabet keyboards from base/main
keyboard, almost all keys should be shared among variants. Grouping
keys in Set instead of List is a essential refactor to have.
Bug: 5002108
Bug: 5679585
Change-Id: Idd5644d1c45a3276a24b61c984619c03d4e4c54c
2011-12-16 21:04:04 +09:00
0c0ca874fe
Get rid of key index from ProxymityInfo
...
Change-Id: I9bee0a643d09cdd89e42ae913285c9e78d875c1c
2011-12-16 21:03:36 +09:00
43c0a034bd
Merge "Pretty print for InputAttributes"
2011-12-16 04:01:49 -08:00
4d0f03bd66
Remove a write-only variable.
...
Change-Id: I825307a429f46b31ed9bd940b5a97d2713127dfe
2011-12-16 20:54:58 +09:00
6fa003ee23
Pretty print for InputAttributes
...
Change-Id: I5e4b2b6f3cd943c8f6187aaed21d67ec786bf5df
2011-12-16 20:53:44 +09:00
2b2c0b574c
Merge "Use the WordComposer to check if we are composing a word"
2011-12-16 03:47:34 -08:00
80b66bb166
General cleanup.
...
Move variables around, inline useless functions, remove
useless local variables.
Change-Id: Icb89d8b211a2ad4bc3619137c2276a649c2a5e34
2011-12-16 20:36:32 +09:00
644c8b7c96
Initialize input attributes in the InputAttribute class
...
Change-Id: I103d6851f54f47cbffdb567fb0f4c505c4697b05
2011-12-16 20:35:16 +09:00
3b7aceca60
Merge "Make applicationSpecifiedCompletionOn final."
2011-12-16 03:20:00 -08:00
bf7ed75e4f
Merge "Move KeyboardSwitcher.getKeyboard to KeyboardSet"
2011-12-16 03:13:38 -08:00
645128af71
Move KeyboardSwitcher.getKeyboard to KeyboardSet
...
This change also gets rid of XML id from KeyboardId.
Bug: 5002108
Bug: 5679585
Change-Id: I7086c7da3c01ba4ade7f77ee5cc731310da46404
2011-12-16 20:10:57 +09:00
ccc35f7fa7
Make applicationSpecifiedCompletionOn final.
...
This is the last one (whew)
Also move a somewhat unrelated initialization out of the
input attribute initialization function.
Change-Id: Icc77b32fd16b112ab43786715061b1c9dca31c04
2011-12-16 19:09:01 +09:00
9cc1312eee
Make inputTypeAutoCorrect final.
...
Change-Id: I550eba1fc3fa2843d007a8208d81fad208c1196b
2011-12-16 19:08:52 +09:00
13db05f930
Make isSettingsSuggestionStripOn final.
...
Change-Id: Iabb99a7f8f3f1777f9a87ae2bddff9795a50fa92
2011-12-16 19:08:13 +09:00
1ba17f97d5
Small refactoring
...
This helps to make following changes smaller
Change-Id: I95ba2901ac3bf1ed70a748c35a0babdd9af1df63
2011-12-16 18:21:26 +09:00
4fc0f6ab02
Merge "Make insertSpaceOnPickSuggestionManually final."
2011-12-16 01:15:35 -08:00
2ad14a2ea7
Merge "Use temporary variables for computing editor attributes"
2011-12-16 01:07:56 -08:00
520e69056e
Merge "Create a class for input attributes."
2011-12-16 01:06:12 -08:00
ae0c109d11
Make insertSpaceOnPickSuggestionManually final.
...
Change-Id: I32fce0ea8c5c58b6f920d0758c8bf57769f39a12
2011-12-16 18:04:39 +09:00
cadc0f7d79
Merge "Send touch event in usability study mode"
2011-12-16 01:04:26 -08:00
4e8922f1be
Use temporary variables for computing editor attributes
...
The ultimate intent is to make these variables final,
which will allow to move the computing function to the
InputAttributes class.
Change-Id: Ifb1fc7321a19b10d60aa63fa0daaa2708deda2cf
2011-12-16 18:04:17 +09:00
dc9d0fcc11
Create a class for input attributes.
...
Change-Id: I834390c83865aac59fb758d5c66cf9b74103abd8
2011-12-16 18:03:16 +09:00
15d4793911
Send touch event in usability study mode
...
Change-Id: I0cdcd57bfd31c9b21cfb932d7ff91bd013cde6d7
2011-12-16 17:56:14 +09:00
289544d6e4
Use Params instead of Builder as an argument of KeyboardSet constructor
...
Change-Id: I4c576a0b0b632cdf413f2ccd5c69dbd37747fbd3
2011-12-16 16:41:49 +09:00
196d82cdd7
Use the WordComposer to check if we are composing a word
...
...instead of the hard-to-understand mHasUncommittedTypedChars.
This is possible because now the word composer is actually aware
of commits.
Change-Id: I36b664ce8402a280f801e87b9ebe161f416b0853
2011-12-16 15:58:29 +09:00
6ba5f0d341
Merge "Add error log to expensive ArraysCompatUtils.binarySearch"
2011-12-15 22:55:10 -08:00
be2f81f055
Merge "Make the word composer aware of commits."
2011-12-15 22:54:23 -08:00
c73c26790f
Make the word composer aware of commits.
...
Change-Id: I04e691fbc9227d4df195429bca89edea93575347
2011-12-16 15:41:10 +09:00
f8481883cc
Add error log to expensive ArraysCompatUtils.binarySearch
...
Change-Id: Id33998e2a99be9249de4011892555f10c5d0968d
2011-12-16 15:34:11 +09:00
cfd5b4811f
Merge "Cleanup ProximityInfo.calulateSweetSpot"
2011-12-15 22:21:17 -08:00
f1e05e74e6
Merge "Add com.android.inputmethod.latin.suggestions package"
2011-12-15 22:00:05 -08:00
6cb72b0f36
Cleanup ProximityInfo.calulateSweetSpot
...
Change-Id: I98238359dffd76a620d3b0e73b3b22dd82c56c93
2011-12-16 14:59:24 +09:00
8c3d5b6961
Add com.android.inputmethod.latin.suggestions package
...
Change-Id: If4b823768ab9c073625da3034ecc8091be1df230
2011-12-16 14:21:44 +09:00
8950f259b1
Merge "Make Key.mPreviewIcon public final"
2011-12-15 21:20:46 -08:00
0b6237da94
Make Key.mPreviewIcon public final
...
Change-Id: I280b1fa6a018e095e9b36ea5475dde68e0965350
2011-12-16 12:47:34 +09:00
a44685ab32
Add colorValidTypedWord and alphaValidTypedWord
...
This change fixes Gingerbread theme.
Change-Id: I142437ac0173df48ab36390f47ed67c6cea24a65
2011-12-16 12:26:19 +09:00
e9a0efc242
Merge "Cleanup unused variables and parameters"
2011-12-15 18:02:38 -08:00
2ac5988f84
Cleanup unused variables and parameters
...
Change-Id: Iad756a7a775c93f3344c6962e7b3456ef8339490
2011-12-15 20:26:12 +09:00
05f654d498
Merge "Group all input-related info into an inner class."
2011-12-15 03:21:47 -08:00
c3ef86d861
Merge "Fix auto correction spacebar LED"
2011-12-15 03:19:32 -08:00
27dff63833
Group all input-related info into an inner class.
...
Currently, these variables hold the info about the composing
word, or maybe some outdated info, and it's not very clear
which it is. LatinIME is maintaining the freshness info in
a separate boolean, and uses it throughout the code for many,
many things, leading to much confusion.
The idea in grouping this info is, it can be saved in another
instance and restored later. It can be tested against to know
whether there is actually outdated but kept info or not, and
it should allow to straighten out what is actually currently
being typed. Ultimately, it will eliminate the need for
LatinIME to keep track of the status of the info in the
word composer.
Change-Id: I00e2c690f303f8320c9be35590a6df4583e9e456
2011-12-15 19:58:04 +09:00
2d74806262
Change visibility to avoid synthetic accessor method
...
Change-Id: Ie93c7437fb9a3fe63adaa48c2d4a723f96c0a0e1
2011-12-15 19:50:53 +09:00
23d27fefcb
Fix auto correction spacebar LED
...
Change-Id: I4894d188d5612380cc9f8eec7cb72544e37fb2b0
2011-12-15 17:34:14 +09:00
b8c2c6e2ec
Merge "Add XmlParseUtils class"
2011-12-14 03:02:17 -08:00
d549d4334f
Merge "Remove long press settings key function"
2011-12-14 03:02:09 -08:00
17dc10724b
Remove long press settings key function
...
Bug: 5759092
Change-Id: I328e2043075ce5d0d0285febc4a9b7356702c250
2011-12-14 19:47:17 +09:00
4665463ccd
Add XmlParseUtils class
...
Change-Id: Ie288272bc75832db7d743262c4c4fbe73b6dca04
2011-12-14 19:46:03 +09:00
6652e45899
Merge "Move Keyboard.themeName to KeyboardSwitcher and make it private"
2011-12-14 02:43:06 -08:00
90c12077b2
Merge "Remove EditorInfo from KeyboardId"
2011-12-14 02:42:58 -08:00
7a91deb685
Move Keyboard.themeName to KeyboardSwitcher and make it private
...
Change-Id: I101b6927d43e86b3c636c1a527e181df8af9c73e
2011-12-14 19:01:20 +09:00
a042150a69
Merge "Just ignore settings/shortcut key while typing on tablet"
2011-12-14 01:59:46 -08:00
2d603fff64
Remove EditorInfo from KeyboardId
...
Change-Id: I70919ff30622afa1d8c29ca45589fa617f2c1f0e
2011-12-14 18:58:55 +09:00
9750165c9a
Merge "Cleanup"
2011-12-14 01:50:25 -08:00
014b755f8a
Merge "Cleanup KeyboardId's hasCode method"
2011-12-14 01:48:46 -08:00
f3ca6a59a7
Cleanup
...
Change-Id: I724df0be7ac07ffb9f1f4974175aed5a2606221b
2011-12-14 18:42:47 +09:00
601e411c13
Cleanup KeyboardId's hasCode method
...
Change-Id: I5fd8f6ac0f42152fb0e2aaaedc6092f6d82fe677
2011-12-14 18:42:20 +09:00
64361bd66d
Merge "Move some code inside a function to simplify flow"
2011-12-14 01:42:17 -08:00
676917dea2
Merge "Fail faster in case of a bug"
2011-12-14 01:42:05 -08:00
2c4b21d7ca
Merge "Cleanup settings key related stuff"
2011-12-14 01:36:34 -08:00
1c6cf26c37
Move some code inside a function to simplify flow
...
Also rename the function to reflect better the behavior.
An upcoming change will clean up the remnants
Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
2011-12-14 17:56:57 +09:00
46798d8f1f
Fail faster in case of a bug
...
Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
2011-12-14 17:54:18 +09:00
623d0155b6
Just ignore settings/shortcut key while typing on tablet
...
Bug: 5759096
Change-Id: Ie1f1800d0f32ac0938715c79974e0f382c9c3d27
2011-12-14 17:14:44 +09:00
b588003426
Refactoring.
...
Small simplification of the code.
Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
2011-12-14 16:59:25 +09:00
8b1b8aae9c
Cleanup settings key related stuff
...
Change-Id: Ie0d1204e94fcdf9d578974256bf2ae3e87797f13
2011-12-14 16:34:35 +09:00
e35e13fc7d
Merge "Record onStartInputView"
2011-12-13 23:31:43 -08:00
689b901156
Merge "Utilize KeyboardSet XML definitions"
2011-12-13 23:31:00 -08:00
dbdb385bb0
Merge "Fix a long-standing race condition."
2011-12-13 23:29:47 -08:00
f86109ca56
Utilize KeyboardSet XML definitions
...
This change introduces KeyboardSet and SubKeyboard XML definitions to
represent a set of keyboard layouts.
Bug: 5002108
Bug: 5679585
Change-Id: Ib6c8d5936187381bb6725c9fe574e93871c01a86
2011-12-14 16:28:31 +09:00
514beb0992
Fix a long-standing race condition.
...
Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.
Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
2011-12-14 16:24:18 +09:00
7ef235f53f
Record onStartInputView
...
Bug: 5722703
Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
2011-12-14 16:22:30 +09:00
8e3faff244
Merge "Decouple member logic from control flow"
2011-12-13 06:28:48 -08:00
7b5bc1ff4d
Decouple member logic from control flow
...
This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.
Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
2011-12-13 23:15:12 +09:00
f7d6517d6b
Various mini-cleanups
...
- Stop the word composer from escaping - take a page from the law
of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.
Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
2011-12-13 23:09:22 +09:00
edf4995a3b
Merge "Remove the input connection sidework from handleCharacter"
2011-12-13 04:28:30 -08:00
dafa7a8e15
Remove the input connection sidework from handleCharacter
...
Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
2011-12-13 21:12:07 +09:00
117fc93f37
Move mBestWord to the word composer.
...
mBestWord has a confusing name - it's actually an auto-correction.
It's cleaner if it lives in the word composer because an
auto-correction should be tied to a specific user input, and
should be reset each time the user input changes to avoid
race conditions.
Change-Id: I718d29395bc747372067e6440e090c6a181994ae
2011-12-13 21:06:51 +09:00
7e6f4daa19
Merge "Tighten conditions for space-related cancelling"
2011-12-13 01:23:15 -08:00
c525750835
Merge "Consolidate underlining code under one function."
2011-12-13 01:22:08 -08:00
cfe264bfee
Merge "Introduce KeyboardSet to hold related KeyboardIds"
2011-12-13 01:12:10 -08:00
c42f285b35
Introduce KeyboardSet to hold related KeyboardIds
...
This change moves
* KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and
KeyboardSet.getKeyboardId.
* KeyboardSwitcher.getF2KeyMode to KeyboardSet.
This is the first step to get rid of shift state from Keyboard.
Bug: 5002108
Bug: 5679585
Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
2011-12-13 18:10:50 +09:00
3dcba4279a
Merge "Extract the jni library name"
2011-12-13 00:46:16 -08:00
77d59b0691
Consolidate underlining code under one function.
...
Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
2011-12-13 17:42:27 +09:00
8ad4013406
Tighten conditions for space-related cancelling
...
Instead of ignoring silently a found bug, throw an exception.
Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
2011-12-13 17:40:06 +09:00
77ecf52a08
Merge "Remove KeyboardSwitcher.updateShiftLockState method"
2011-12-13 00:27:01 -08:00
ba526e3157
Extract the jni library name
...
Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
2011-12-13 17:25:43 +09:00
34f1820396
Remove KeyboardSwitcher.updateShiftLockState method
...
Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
2011-12-13 16:57:23 +09:00
14cb8448df
Remove a useless return
...
Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
2011-12-13 16:48:28 +09:00
8e404536cd
Merge "Simplification"
2011-12-12 23:39:12 -08:00
cf5cecccfe
Merge "Refactoring"
2011-12-12 23:39:00 -08:00
024ee9ff02
Merge changes I7888797c,I57b2232f
...
* changes:
Refactor + small bugfix
Refactoring
2011-12-12 23:38:17 -08:00
2939063947
Simplification
...
Both tests have the same meaning. They should be merged.
Also, if "deleteLast()" deletes more than one char (which
never happens in the current implementation, but it's not
guaranteed), the new code is more correct.
Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
2011-12-13 16:06:00 +09:00
d2c69c7d12
Refactoring
...
If mHasUncommittedTypedChars is true, then
mWordSavedForAutoCorrectCancellation must always be null, and
spaceState must always be SPACE_STATE_NONE.
Hence, this change is supposed to be very no-op.
Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
2011-12-13 16:04:11 +09:00
2245c3b5b3
Refactor + small bugfix
...
postUpdateShiftKeyState used to be called also when
mEnteredText is not null => this is a bugfix.
The rest does not change the logic, as posting a message can
be done anywhere within the function with no impact.
Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
2011-12-13 15:59:36 +09:00
a2a85d45e0
Refactoring
...
Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
2011-12-13 15:38:49 +09:00
dc52e7c646
Remove current keyboard id variable
...
Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
2011-12-13 12:49:40 +09:00
34081186f9
Merge "Fix a bug where revert auto-correct would revert too much"
2011-12-12 04:46:27 -08:00
5c3ff4c9c8
Fix a bug where revert auto-correct would revert too much
...
If there are no uncommitted chars, we shouldn't enter any of
the tests that follow. We didn't use to, but a change today
made it possible - it should not happen.
There is no point in doing the rest of the tests, they are
sure to fail.
Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
2011-12-12 21:27:16 +09:00
4f41cbc588
Remove a useless function call
...
Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
2011-12-12 20:51:43 +09:00
dcf8a6b2c6
Merge "Move a settings var to the settings class"
2011-12-12 03:31:42 -08:00
2a659b8aa6
Remove a useless variable
...
This can be just read when it's needed.
Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
2011-12-12 20:22:39 +09:00
d567b230b0
Move a settings var to the settings class
...
Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
2011-12-12 19:52:17 +09:00
7208af0ecd
Remove a messy and unused class.
...
Today is a happy day
Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
2011-12-12 19:31:29 +09:00
f162ed7ec8
Merge "Remove side-effects from TextEntryState"
2011-12-12 02:20:49 -08:00
406d192a9e
Remove side-effects from TextEntryState
...
Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
2011-12-12 19:19:39 +09:00
267cd0151f
Add special handling for "Phone number" layout.
...
Bug: 5743584
Change-Id: I821b837a2078afb64b460191c98b28f7733cf2c1
2011-12-12 18:19:29 +09:00
aa59e24ebe
Merge "Add unit test of KeyboardState"
2011-12-12 00:15:42 -08:00
c2a76a1529
Remove a useless variable.
...
Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
2011-12-12 16:49:32 +09:00
205f9ca310
Merge "Straighten out logic for revert word paths"
2011-12-11 23:48:06 -08:00
890d13189d
Straighten out logic for revert word paths
...
This also includes a new memorized string with simpler
logic that will allow to remove other members
Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
2011-12-12 16:41:49 +09:00
dfbe254de6
Add unit test of KeyboardState
...
Bug: 5708602
Change-Id: I1a8a9f4320948bb500a96df8773b0bfa1a1d4167
2011-12-12 16:34:11 +09:00
243e034716
Merge "Assign Key.mCode from the label only when outputText is not specified"
2011-12-11 23:32:32 -08:00
06b886f372
Merge "Move KeyDetector.printableCode to Keyboard"
2011-12-11 23:32:25 -08:00
7dfd5a3e83
Move KeyDetector.printableCode to Keyboard
...
Change-Id: I9cde21fbb45c1e5f1a568bb97b1b1a76524f4bf2
2011-12-12 16:17:45 +09:00
de66f3af8a
Assign Key.mCode from the label only when outputText is not specified
...
Bug: 5742827
Change-Id: I72b55ce246b14a2d8f4fd16211b71dc716db30b2
2011-12-12 16:15:18 +09:00
86344836ee
Merge "Remove a duplicated variable."
2011-12-11 21:26:31 -08:00
2ba1bcccdd
Remove unused Keyboard.CODE_CANCEL
...
Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
2011-12-12 12:56:30 +09:00
3651220327
Remove a duplicated variable.
...
This is awesome cleanup.
Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
2011-12-12 12:06:41 +09:00
9260422423
Build God Mode keyboard with API level 14
...
Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8
2011-12-10 03:45:40 +09:00
4af5e3c5f4
Fix isResearcherPackage
...
Change-Id: I286450fe89a37d75cb398f17d300ddc6f5857ffd
2011-12-10 01:16:16 +09:00
2edd109f84
Some tweaks for Researcher Mode
...
Change-Id: I6b16dd2fe6d7356c747ba0ee2da5976738003ded
2011-12-10 00:35:50 +09:00
2a89e36db0
Merge "Add a functionality to attach a log file to Gmail app Bug: 5722703"
2011-12-09 05:59:36 -08:00
a8b6292cee
Add a functionality to attach a log file to Gmail app
...
Bug: 5722703
Change-Id: I089f944bdbf2cbb036eb59dd9b5b414370c770f1
2011-12-09 22:38:15 +09:00
963abf4bcc
Merge "Remove unused public methods from KeyboardState and KeyboardSwitcher"
2011-12-09 04:38:14 -08:00
74671cf6c5
Resolve TODOs: add members to hold preferences
...
Change-Id: I34f6c76bf9318e1fbe8eb5ffab6772a98ff824e0
2011-12-09 21:24:13 +09:00
df9deffba2
Remove unused public methods from KeyboardState and KeyboardSwitcher
...
Bug: 5708602
Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
2011-12-09 21:14:13 +09:00
0fe3611bee
Resolve TODOs: add some members to store prefs
...
Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
2011-12-09 20:16:57 +09:00
85b063f97e
Resolve TODOs: add members to store raw settings
...
Change-Id: I481eadb6a73faf239e24d05b7e220fcb01194fa4
2011-12-09 19:03:55 +09:00
12f10e1585
Read options in the declaration order
...
Change-Id: I1a7c4d0bcaedad6d4045c36c79280c23234db5b3
2011-12-09 18:58:24 +09:00
c40b807ca4
Straighten out prefs reading code
...
Change-Id: Ibf9113a8ef07ac720100ee32d2e5ef321e8ddd98
2011-12-09 18:54:07 +09:00
bab1f045f4
Straighten out members extracted from resources.
...
Change-Id: I9b9602ec5b379b44b0f0663d4f065dbcf88fd352
2011-12-09 18:19:30 +09:00
92e85c87a3
Merge "Match constant names to option names"
2011-12-09 01:14:14 -08:00
f8a056c5c8
Merge "Reorder members in SettingsValues."
2011-12-09 01:14:02 -08:00
ba93dda8ce
Match constant names to option names
...
Change-Id: I7586fa342d7a39412d656890f7b525139c45ea4a
2011-12-09 17:58:51 +09:00
837b109f27
Reorder members in SettingsValues.
...
Reorder so that they match the order in the preference xml
file. Also add TODOs for missing raw variables.
Change-Id: I06332c131a624d6c359512d75c808f3f7313fa91
2011-12-09 17:56:31 +09:00
1cc046775d
Merge "KeyboardState keeps track of isAlphabetMode and isSymbolShifted"
2011-12-09 00:43:18 -08:00
c207e0a7da
Move settings variables to the settings class
...
Change-Id: Ifa7033a84b08ea626eb44cf6d04ba8e28c250bea
2011-12-09 16:47:31 +09:00
284c8a0449
Merge "Stop a flag from escaping."
2011-12-08 23:14:15 -08:00
0c3b8ce842
Merge "Move settings method from Utils to SettingsValues"
2011-12-08 23:09:33 -08:00
10dcc7eb67
KeyboardState keeps track of isAlphabetMode and isSymbolShifted
...
Bug: 5708602
Change-Id: I181cdeb90d24984ce6f6c993b278293aae7364eb
2011-12-09 16:09:16 +09:00
4606de117b
Stop a flag from escaping.
...
The ultimate intent is to close it up in the settings, as it does not
change while typing, only when the keyboard is open again.
Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
2011-12-09 16:09:04 +09:00
784181e29f
Merge "Cleanup debug logging code"
2011-12-08 23:08:22 -08:00
ed43296217
Move settings method from Utils to SettingsValues
...
Change-Id: I633378a41f63cd492b8c9345d550e07254df5e5a
2011-12-09 16:03:10 +09:00
a7af03baf4
Merge "Get rid of public KeyboardState.setShifted and setShiftLocked"
2011-12-08 23:02:47 -08:00
4bae9d56d9
Merge "Show usability study mode for research purposes"
2011-12-08 22:40:58 -08:00
e0dfc54c5b
Show usability study mode for research purposes
...
Bug: 5722703
Change-Id: I27acc374c5d4b52707708b83689dea5d78a573d7
2011-12-09 15:31:06 +09:00
930a55b846
Cleanup debug logging code
...
Change-Id: If806d61c5945d319c89d9cc127e09f98b7b10a4e
2011-12-09 15:14:05 +09:00
805402e8fa
Get rid of public KeyboardState.setShifted and setShiftLocked
...
Bug: 5708602
Change-Id: I98bcca7d3e9dd88f034d0faecada76902b2d0dff
2011-12-09 15:13:23 +09:00
a76c62e92d
Merge "Remove direct calls of setKeyboardXXX from KeyboardSwitcher"
2011-12-08 21:33:09 -08:00
96c56cb577
Remove direct calls of setKeyboardXXX from KeyboardSwitcher
...
These calls, setAlphabetKeyboard, setSymbolsKeyboard, and
setSymbolsShiftedKeyboard have to be call backed from KeyboardState.
Bug: 5708602
Change-Id: Ibbe1a21bd10bf942e17886869c0ab0fa1735b87e
2011-12-09 13:26:11 +09:00
7a16a061e6
Extract Settings.Values to a new class
...
This is pretty much automatic refactoring. Thanks Eclipse!
Change-Id: I8ccd24d11878445c836347e9c487c91461eee9cd
2011-12-09 12:40:50 +09:00
d52e760530
Merge "Cleanup KeyboardSwitcher a bit"
2011-12-08 05:55:16 -08:00
6ad9b012d9
Cleanup KeyboardSwitcher a bit
...
* Move caps lock state preserving code to KeyboardState.
* Merge KeyboardState.onLoadKeyboard and onRestoreKeyboardState.
* Merge private methods into toggleShift and toggleKeyboardMode.
Bug: 5708602
Change-Id: I793a934a0ba18d5750be011c52ebe20c1976eac6
2011-12-08 22:50:46 +09:00
92e5756dfb
Merge "Cleanup"
2011-12-08 05:14:26 -08:00
c1fdd966a7
Remove a useless method
...
Change-Id: Ib6a0ee21bfe2000231f9ba7bcad4b18ae57e4249
2011-12-08 21:47:26 +09:00
283b0c2b64
Cleanup
...
Here, shouldAutoCorrect implies mSettingsValues.mAutoCorrectEnabled
Change-Id: I9256718dd63b75252d1454e264db6814bbf18aa5
2011-12-08 21:37:15 +09:00
3da7df8db7
Merge "Add proximity for Russian."
2011-12-08 02:22:28 -08:00
1830cd1dc8
Add proximity for Russian.
...
This also tries to make the code as easy to extend as possible
for future developments.
Bug: 5701241
Change-Id: I1ed48e6a5cc7aab94c5d6e309930cc004247d7e7
2011-12-08 19:00:52 +09:00
9e38f9a980
Merge "Use the system-wide interface to add a word."
2011-12-08 00:52:32 -08:00
cf58f53a1a
Move KeyboardLayoutState into KeyboardState
...
Bug: 5708602
Change-Id: Ieb6b872d0f2cf3ad1fcb69409e2cf49f60427672
2011-12-08 17:00:56 +09:00
eef6238f94
Move SWITCH_STATE related stuffs to KeyboardState
...
Bug: 5708602
Change-Id: I904ec370e3761c47af17a680c0932ec98cfd3c27
2011-12-08 16:12:49 +09:00
b300dbbd39
Reset saved caps lock sate when new keyboard is loaded
...
Bug: 5722919
Change-Id: Id92632a0feffc3342d3c31e90c0da973c934f3c0
2011-12-07 22:48:04 +09:00
6b7100feca
Don't execute pending onStartInputView if EditorInfos are equivalent
...
Bug: 5722732
Bug: 5722867
Change-Id: I8347c258b286c3329f318d50adf205e78e49c722
2011-12-07 22:39:13 +09:00
68d600a5f6
Merge "Remove internal toggleShift calls"
2011-12-07 02:35:52 -08:00
f47993ee34
Remove internal toggleShift calls
...
Bug: 5708602
Change-Id: Id1f76dbd40aaf9ed35d4598d902043675c3d74fc
2011-12-07 19:32:47 +09:00
845d829d47
Merge "Get rid of direct reference to KeyboardId from KeyboardLayoutState"
2011-12-07 01:41:05 -08:00
bc56e04425
Reset keyboard state when loading keyboard
...
Bug: 5627467
Change-Id: I709f97e47144d3270450adc7d8053038d0df57bc
2011-12-07 17:55:22 +09:00
361c42b746
Use the system-wide interface to add a word.
...
Bug: 5306641
Change-Id: Ic87e5bc3a5f1f03c57d48f2d92c28e0aba06847d
2011-12-07 16:19:05 +09:00
2e263b70d5
Get rid of direct reference to KeyboardId from KeyboardLayoutState
...
KeyboardLayoutState.restore directly loads keyboard using private
methods such as setAlphabetKeyboard and setShifted etc. instaed of
calling public methods such as toggleCapsLock, onPressShift, and
onReleaseShift.
Bug: 5708602
Change-Id: I799f80f1d505ac7bdf17b92b189fc418994bfa2f
2011-12-07 13:02:58 +09:00
55c0198eee
am c960695f: Updated keyboard to use SPEAK_PASSWORD preference.
...
* commit 'c960695f38ae0564dff3a6897fd1843c8e74c604':
Updated keyboard to use SPEAK_PASSWORD preference.
2011-12-06 16:59:46 -08:00
c960695f38
Updated keyboard to use SPEAK_PASSWORD preference.
...
Bug: 5678383
Change-Id: Ie9bdc92f4b2c9014159d672b71e4438f8fa34f55
2011-12-06 14:06:57 -08:00
e466583ddc
Fix caps lock key behavior
...
Fix the issue introduced by Idfe69978.
Bug: 5708602
Change-Id: I4265822b7d33417b87b3e7e3f49250ac5d2ecdda
2011-12-06 19:52:25 +09:00
8a70e70c84
Remove toggleSymbolsShift and rename toggleKeyboardMode
...
Bug: 5708602
Change-Id: Iadef3e862d00505d1d9f588d0d64445754d7b962
2011-12-06 18:12:34 +09:00
0da3708540
Merge "Move KeyboardShiftState to KeyboardState"
2011-12-06 00:25:05 -08:00
c1859b8fd2
Move KeyboardShiftState to KeyboardState
...
Bug: 5708602
Change-Id: Idfe69978972bb674e0f360ef5e324739e2652d25
2011-12-06 17:04:12 +09:00
c9f8cb614e
Merge "Refactor reflection member"
2011-12-05 23:38:37 -08:00
b95905669c
Refactor reflection member
...
Change-Id: I112dbf851e10dae9e4291cf440f01b28d51180f4
2011-12-06 16:35:02 +09:00
4f7f61730c
Make Keyboard.setShifted return void
...
Bug: 5708602
Change-Id: If8150f62fbab864344f59853850ff3213c27940e
2011-12-06 14:42:30 +09:00
ec52fb6dbb
Merge "Minor refactoring of Keyboard"
2011-12-05 16:49:35 -08:00
a3cf232a2a
am e5db3871: Fix a field value for the suggestion max size Bug: 5574747
...
* commit 'e5db3871b1269703e5ef360090fb35f50ae57ed4':
Fix a field value for the suggestion max size Bug: 5574747
2011-12-05 07:54:59 -08:00
5b74989bef
Minor refactoring of Keyboard
...
* Remove isAlphaKeyboard().
* Remove isPhoneKeyboard().
* Remove getKeyboardShiftState().
Bug: 5708602
Change-Id: I8bf5009bf499ecb0501d1379f72e43406080062a
2011-12-05 20:04:52 +09:00
f7fa231b7a
Merge "Add support for Russian spell checking."
2011-12-05 02:30:29 -08:00
bb2b30fc7f
Add support for Russian spell checking.
...
Note that this is not enough: we still need to create a
reasonable proximity table for Cyrillic characters, or we
won't be able to show up suggestions.
Bug: 5701241
Change-Id: Idb141f7a230a6e1a46094308c26f43c01ab3b97a
2011-12-05 18:57:03 +09:00
6ddb07433f
Merge setManualTemporaryUpperCase and setAutomaticTemporaryUpperCase
...
Bug: 5708602
Change-Id: I6a0b5f0dcccbb6331a271cd61a48c474a7800289
2011-12-05 18:54:43 +09:00
46831d5a4b
Renaming KeyboardSwitcher.getPointerCount to isSinglePointer
...
Bug: 5708602
Change-Id: If44ed4449a3ea79228e25e2ab2c8c8fe82a93a2b
2011-12-05 17:53:58 +09:00
4a292acc6f
Make ModifierKeySatate and ShiftKeyState non-public class
...
Bug: 5708602
Change-Id: I149c2dab26774686e5c578bbf780081e9fb30e7c
2011-12-05 15:40:51 +09:00
b88c9acd88
Add KeyboardState to host shift and symbol key states
...
The KeyboardState will conatin all logic of keyboard state when series
of refactoring are achieved. And the KeyboardState should not be
entangled with other objcets such as Keyboard and KeyboardSwitcher in
order to keep it easily testable.
Bug: 5708602
Change-Id: I288bc169c47e1b4de27fe78854baadbcc85c5d23
2011-12-05 15:08:59 +09:00
e5db3871b1
Fix a field value for the suggestion max size
...
Bug: 5574747
This bug was introduced by I5e40edf6f790c078c4a05d
Change-Id: I5b0f51e1f5e8a12d786657167082bc604089505e
2011-12-05 12:53:45 +09:00
c410e243e9
Ignore releasing shift key caused by long press
...
Bug: 5694715
Change-Id: If7b84f547f5701e84d740f186d284273565b7eba
2011-12-05 12:23:38 +09:00
5c269d1e0d
Merge "Use Iterator in PointerTrackerQueue"
2011-12-01 01:36:19 -08:00
41a51bb2b4
Merge "Fix debug messages neatly"
2011-12-01 01:01:09 -08:00
78ac86ff9d
Use Iterator in PointerTrackerQueue
...
Change-Id: Ia5ad7d4511b2f2db056f2acf7cc0e002001e2123
2011-12-01 17:50:37 +09:00
e742436a29
Fix debug messages neatly
...
Change-Id: I40538d5ffbdf64df4e2848de33393327d704fc1e
2011-12-01 16:43:22 +09:00
c9f203805c
Fix potential NPE
...
Change-Id: I00e7cd521bafd2705ebc2a59d63b7bfc4fe178ba
2011-12-01 16:29:13 +09:00
ae7746e580
Merge "Add Key.altCode attribute"
2011-11-30 03:15:44 -08:00
2013bab89c
Add Key.altCode attribute
...
* Registering alternate code and while key is typing.
* Showing press/release graphics of the key that has the above altenate code.
* Showing press/release graphics of all shift keys.
* Renaming Key.ignoreWhileTyping to Key.altCodeWhileTyping.
Bug: 5639503
Change-Id: I67fb45bae76284a1f0deb6fd12ae5fb781d06cc3
2011-11-30 20:06:47 +09:00
Jean Chalard
satok
Tom Ouyang
Kurt Partridge
Charles Chen
Tadashi G. Takaoka
Ken Wakasa
Svetoslav Ganov
alanv