nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
34682 commits 1 branch 0 tags 363 MiB
Commit graph

8197 commits

Author SHA1 Message Date
Tadashi G. Takaoka
77947c9c96 Merge "Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy" 2014-10-30 09:55:51 +00:00
Tadashi G. Takaoka
34a9e2ae87 Make DrawingProxy and TimerProxy as a top-level interface 
Change-Id: Ia425f341255595f8f80c13b2aa409249f9ce4202
 2014-10-30 18:29:49 +09:00
Tadashi G. Takaoka
be708c4e59 Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy 
Change-Id: I654f7483d1c013ac2685a45af4eb2af15fa219ad
 2014-10-30 18:28:40 +09:00
Andy Wang
0ca400c827 Merge "Add a preference to resize the keyboard height." 2014-10-30 03:37:26 +00:00
Tadashi G. Takaoka
d9b1327c21 Merge "Consolidate similar methods" 2014-10-30 02:54:38 +00:00
Andy Wang
bb9400aebc Add a preference to resize the keyboard height. 
The keyboard height is controlled by a slider in the debug preferences.
Without access to debug preferences, this change is a no-op.

Bug: 6867494
Change-Id: I984064ed1cab752876615f5ed582818474d6041b
 2014-10-30 11:45:41 +09:00
Tadashi G. Takaoka
d2c00f550d Fix dismiss key preview bug introduced by I658a5b16cc 
Change-Id: I5248374dfe0504f6e64cc5d994e275d80364ec9d
 2014-10-30 11:43:53 +09:00
Tadashi G. Takaoka
051f8b1442 Consolidate similar methods 
This CL consolidates similar methods in MainKeyboardView.
- startWhileTypingFadeinAnimation and startWhileTypingFadeoutAnimation
- showSlidingKeyInputPreview and dismissSlidingKeyInputPreview

Change-Id: I607ab74683820de2456af3e75663cf8cf358ab38
 2014-10-30 11:15:59 +09:00
Tadashi G. Takaoka
4e0149c22a Merge "Remove DrawingHandler" 2014-10-29 13:42:44 +00:00
Jean Chalard
93e5cdea71 Merge "[CS8] Add explanations" 2014-10-29 12:26:23 +00:00
Tadashi G. Takaoka
2ad6d9cda3 Remove DrawingHandler 
Change-Id: I658a5b16cca1e56f0b944009b8aef09e0a97a0db
 2014-10-29 18:51:41 +09:00
Tadashi G. Takaoka
ca6e5dfedb Remove DrawingHandler.Callbacks.dismissAllKeyPreviews() 
Change-Id: I2b11ca0dec0f3522648557a9a909f305cc4170fb
 2014-10-29 15:25:09 +09:00
Jean Chalard
ecab6aff59 Remove Dict dependency on WordComposer and ProximityInfo 
Bug: 18108776
Change-Id: I9b399a44241e05a7add9bb8094263aa76de37880
 2014-10-29 12:27:24 +09:00
Jean Chalard
36799b2aa2 Move InputPointers and ResizableIntArray to common 
Bug: 18108776
Change-Id: Ie5c0430aa41a8d6c58bf510a10173223d7dfe9fe
 2014-10-29 12:09:11 +09:00
Tadashi G. Takaoka
48ee473c1e Merge "Clean up UserDictionaryCompatUtils" 2014-10-29 00:37:43 +00:00
Jean Chalard
4beeb9253a Move StringUtils under common. 
Bug: 18108776
Change-Id: Ia46a4102a0e86e71118ca5e641f9f531998e166b
 2014-10-28 22:44:30 +09:00
Jean Chalard
ca724ef71f Reduce StringUtils dependency on the Android libs 
Bug: 18108776
Change-Id: I43feb25d79f89276d44462ba71788a14c4583277
 2014-10-28 22:03:18 +09:00
Tadashi G. Takaoka
fec5219974 Fix Serbian Latin subtype handling 
This CL also adds unit tests for Hinglish and Serbian Latin.

Bug: 9687668
Bug: 17169632
Change-Id: Ib9aa1bcdf5b390a9d8c61f07165beacf850e2692
 2014-10-28 18:36:16 +09:00
Tadashi G. Takaoka
dccf4f2a41 Clean up UserDictionaryCompatUtils 
Change-Id: I1b22c82930af4f30db4237335850fb34b66f9299
 2014-10-28 17:42:17 +09:00
Tadashi G. Takaoka
395009c03e Fix NPE in AppearanceSettingsFragment 
Bug: 18147440
Change-Id: I7a7a47b3484e54146d34d11b5bd9c1305421d829
 2014-10-28 15:02:31 +09:00
Jean Chalard
67527f847e [CS8] Add explanations 
Bug: 13238601
Change-Id: I72a78be5848485f7fd77f5586573692529c7547b
 2014-10-28 13:41:00 +09:00
Tadashi G. Takaoka
d5455fea4a Merge "Add null analysis annotation to CollectionUtils" 2014-10-27 09:43:22 +00:00
Tadashi G. Takaoka
7a3de4dca9 Add null analysis annotation to CollectionUtils 
Change-Id: I3a610b037d6d1431cced3ea193171108bd5a040d
 2014-10-27 18:30:29 +09:00
Tadashi G. Takaoka
f6a6371096 Refactor CoordinateUtils 
Change-Id: I607b803273a4d7983e9e25a81b6941a3b59194c6
 2014-10-27 18:02:33 +09:00
Tadashi G. Takaoka
f7e01e866f Remove device checking of Emoji physical key 
This CL also adds a settings option to enable/disable an Emoji-ALT
physical key.

Bug: 18122464
Change-Id: Iee1d97efec979a902b0492071d5e511ca1792ff0
 2014-10-27 16:26:22 +09:00
Ken Wakasa
53b010384e Remove an unused import 
Follow up to I2b81450f99d7b4493ba0fc5e502f4333b8db48cd

Change-Id: I3d106db076e8181b65ce6843b801d12c6ca0adb1
 2014-10-24 21:36:24 +09:00
Ken Wakasa
23a357d71d Small cleanup 
Change-Id: I2b81450f99d7b4493ba0fc5e502f4333b8db48cd
 2014-10-24 19:47:26 +09:00
Tadashi G. Takaoka
067d8cdf56 Fix unit test breakage 
Change-Id: I538288054a58eb2c81ce3cbe5c9bef900fb653a5
 2014-10-24 16:48:46 +09:00
Keisuke Kuroyanagi
aad188d40a Merge "Height of the keyboard for spellchecker is too large." 2014-10-24 06:29:10 +00:00
Keisuke Kuroyanagi
6cc318bd6a Height of the keyboard for spellchecker is too large. 
Bug: 18109041
Change-Id: I0eb98a66290058c28e20c86f36395af4f763952e
 2014-10-24 14:59:52 +09:00
Ken Wakasa
7e88eae623 Add missing header 
Change-Id: I1befc2f1288674b4d871b27bdc5251b2b95e8bb7
 2014-10-24 12:00:26 +09:00
Ken Wakasa
2c6aaa7c3c Merge "Move Constants.java to the latin.common package" 2014-10-24 02:50:07 +00:00
Keisuke Kuroyanagi
989699a690 Fix unit tests (InputLogicTestsDeadKeys). 
Change-Id: I9a3191548aa0a4e674d736bc10845b952fc9a1e8
 2014-10-23 22:09:08 +09:00
Ken Wakasa
9342484e8d Move Constants.java to the latin.common package 
Our intention is to have classes of latinime-common under the common
package as much as we can.

Change-Id: I76efbbbe7bebf1a4aa943715cdff64f91675e20d
 2014-10-23 20:27:37 +09:00
Jean Chalard
b224594aca Merge "Fix a concurrency bug that ends up in a crash." 2014-10-23 08:02:37 +00:00
Keisuke Kuroyanagi
ade5ad1dae Merge "Use trigrams for personalization dict." 2014-10-23 05:42:38 +00:00
Keisuke Kuroyanagi
16cc3992d7 Use trigrams for personalization dict. 
5Bug: 14425059
Change-Id: I73cf6904e569d60996a3b079f16ea6df0cb90f02
 2014-10-23 14:32:45 +09:00
Ken Wakasa
b11fc7d423 Move annotations classes to latiime-common 
Move Constants.java too.

Change-Id: I55e8cf06f61c0a37746a7328834a52a5306cf0f2
 2014-10-23 13:00:46 +09:00
Jean Chalard
4097a20b36 Fix a concurrency bug that ends up in a crash. 
Bug: 18085768
Change-Id: I016bec997787839526ddfc521ebb99d0c7b05189
 2014-10-23 12:36:42 +09:00
Tadashi G. Takaoka
d3a4c51324 Fix Javadoc and null analysis related warnings 
This CL also adds @SuppressWarning("unused" to java-overridable package.

Bug: 18003991
Change-Id: If70527e30654384705d7a814f5efd181d9f539e1
 2014-10-23 09:58:42 +09:00
Keisuke Kuroyanagi
b5ef884fbb Support dumping ngram entries. 
Bug: 14425059
Change-Id: Ib03a0c3d166ed6f1e60c67127b28006d55143b6b
 2014-10-22 18:15:53 +09:00
Yohei Yukawa
baecaa5411 Merge "Remove BuildCompatUtils.VERSION_CODES_LXX" 2014-10-22 02:01:32 +00:00
Yohei Yukawa
66d30a4b22 Remove BuildCompatUtils.VERSION_CODES_LXX 
Finally it is turned out to be a XXL-size Lollipop.

Change-Id: Icbd22506be9de514eba287cdd8d97fbfd070ac09
 2014-10-22 01:29:58 +09:00
Yohei Yukawa
63cbdf49b9 Add @Override for a method that is overriding a new L API 
Now all the downstream builds have switched to API Level 21.
Hence putting @Override to new APIs no longer makes javac unhappy.

Change-Id: Ib3324a5d06b17d298beacab8c8802bb14e5be968
 2014-10-22 01:28:10 +09:00
Tadashi G. Takaoka
46a007261f Merge "Fix some compiler warnings" 2014-10-21 15:06:55 +00:00
Tadashi G. Takaoka
5f00fe09e9 Fix some compiler warnings 
This CL fixes the following compiler warnings.

- Indirect access to static member
- Access to a non-accessible member of an enclosing type
- Parameter assignment
- Method can be static
- Local variable declaration hides another field or variable
- Value of local variable is not used
- Unused import
- Unused private member
- Unnecessary 'else' statement
- Unnecessary declaration of throw exception
- Redundant type arguments
- Missing '@Override' annotation
- Unused '@SuppressWarning' annotations

Bug: 18003991
Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
 2014-10-21 19:28:37 +09:00
Tadashi G. Takaoka
2105aa3ea6 Merge "FIx potential NPE" 2014-10-21 08:14:46 +00:00
Tadashi G. Takaoka
097bcdcde8 FIx potential NPE 
Bug: 18052047
Change-Id: I9097d0a504b8a1d875cf66e44bb65eb6ecc8908e
 2014-10-21 14:13:27 +09:00
Adrian Velicu
05172bf1a5 Renaming "blacklist" flag to "possibly offensive" 
No behaviour changes.
Unified the overloaded FusionDictionary::add method to always take an
isPossiblyOffensive argument.

Bug: 11031090
Change-Id: I5741a023ca1ce842d2cf10d4f6c926b0efabaa78
 2014-10-21 11:51:47 +09:00
Tadashi G. Takaoka
b0ccf3a0a2 Refactor CustomInputStyleSettingsFragment 
Bug: 18003991
Change-Id: Ib005dd394faf546e4faed89ff2018ce49858a06e
 2014-10-20 17:12:33 +09:00
Keisuke Kuroyanagi
1085fef8d0 Change entry count limit. 
Unigram 10K, Bigram 30K, Trigram 30K.

Change-Id: Ibd19c6a2b618499df1c70000bad7b47498187f0a
 2014-10-20 15:01:49 +09:00
Nick Kralevich
01acdac11e fix build 
Change-Id: Iedbf01e1c6191350aed8d31c2638b2430e67a36f
 2014-10-18 07:37:46 -07:00
Nick Kralevich
237f6ca799 fix build 
Change-Id: I58a94fc0be01f272b6ad12524946f073c9f49894
 2014-10-18 06:50:03 -07:00
Jean Chalard
ea32e8fb04 Merge "Enforce a length limit to auto-correction for some languages" 2014-10-17 13:11:39 +00:00
Jean Chalard
8fc872762f Enforce a length limit to auto-correction for some languages 
Bug: 15379262
Change-Id: I27fad12f468b5bc6ad1a0876aac72e5f5ca5760a
 2014-10-17 22:05:05 +09:00
Tadashi G. Takaoka
ad2f695083 Bring back long press timeout settings 
Bug: 18025209
Change-Id: Id8dbb051e04270f6892cae12a443103bd0d32dcb
 2014-10-17 18:20:43 +09:00
Jean Chalard
bd4693cd3f Merge "[ML27.1] Allow adding additional features to other settings" 2014-10-16 11:08:37 +00:00
Jean Chalard
bdf70af177 [ML27.1] Allow adding additional features to other settings 
We may want to add additional features from some of the
other screens.

Bug: 11230254
Bug: 17966252
Change-Id: I1bb877e5cbdd74f2ffa8010b5bc6af35fe77279a
 2014-10-16 19:32:00 +09:00
Jean Chalard
eaa7efd136 [ML29] Reinitialize the subtype at input start 
Bug: 11230254
Bug: 17994347
Change-Id: I3476909c4b371d6e94a0d4c35d91e109d639b8d5
 2014-10-16 18:43:14 +09:00
Jean Chalard
f13487dfbf [ML25] Add an hasDict method. 
We used to have separate methods for existence of dicts
according to whether it's a file or a resource. This unifies both.

Bug: 11230254
Bug: 17979623
Change-Id: I728773461f3465f756d06297c3f3bee34390c3e6
 2014-10-16 17:09:27 +09:00
Jean Chalard
17100ad8ea am 8435acd7: am f7f786d8: am d9c04a6b: am 6456af0e: am ecea8551: Fix a bug with no suggestions flag 
* commit '8435acd789bd4f9c1322a73b9e0567c2dee7b336':
  Fix a bug with no suggestions flag
 2014-10-15 07:52:58 +00:00
Jean Chalard
ecea8551c3 Fix a bug with no suggestions flag 
We should reset the composition state when moving the cursor inside
the word after a gesture when the text field specifies no suggestions.

Bug: 17959921
Change-Id: I977fea775f7b7e145e343636f0fb94266a40953a
 2014-10-15 06:15:02 +00:00
Sandeep Siddhartha
b17a3bc4e8 Move sync policy related code out of account settings 
Bug: 17981687
Bug: 17464069
Change-Id: I0ae3400564fd346cc84af74dfef65f01cc1ce6a8
 2014-10-14 13:39:28 -07:00
Tadashi G. Takaoka
296b11503e Merge "Add JSR305 annotation to LeakGuardHandlerWrapper" 2014-10-14 12:30:12 +00:00
Jean Chalard
10ac940312 Merge "[ML24] Add facilities to read the script of a subtype" 2014-10-14 11:26:07 +00:00
Jean Chalard
b256bb5791 [ML24] Add facilities to read the script of a subtype 
...or more exactly, the script of the keyboard layout set associated
with a given subtype.

Bug: 11230254
Change-Id: I82f5fc81ecffc561781816008c853be6ff9438dd
 2014-10-14 20:19:15 +09:00
Keisuke Kuroyanagi
d1471ee053 Merge "Remove shouldBlockAutoCorrectionBySafetyNet" 2014-10-14 10:52:32 +00:00
Tadashi G. Takaoka
c4ffa235e5 Add JSR305 annotation to LeakGuardHandlerWrapper 
Change-Id: I7456200af739db4510c5549b7bc894fb48749455
 2014-10-14 18:19:22 +09:00
Ken Wakasa
95f100ba40 Merge "Performance fix for multiple language subtypes" 2014-10-14 06:42:14 +00:00
Jean Chalard
d15f6e8c98 Performance fix for multiple language subtypes 
The code would iterate all enabled subtypes each time
getCurrentSubtype() is called, which is really quite frequent.

Bug: 11230254
Change-Id: I91feb36de6eca84967e848fc585aae04b350be89
 2014-10-14 15:13:35 +09:00
Jean Chalard
9959140f15 Merge "Fix an NPE." 2014-10-14 02:51:16 +00:00
Jean Chalard
7d74594123 Fix an NPE. 
Bug: 17958289
Change-Id: I5c9ea668ff75b38c7ddebd767c36a950835c0c9f
 2014-10-14 11:42:43 +09:00
Sandeep Siddhartha
cbd59e02a9 Merge "Don't restore debug preferences" 2014-10-14 02:28:50 +00:00
Keisuke Kuroyanagi
29b4f7aa67 Remove shouldBlockAutoCorrectionBySafetyNet 
Bug: 13756409

[Category diff]
+1      27
-1       0
+2       0
-2       0
+3       0
-3       1
+4      11
-4       0
+5      51
-5       0
+6       0
-6      38
+7       0
-7      50

[Weighted category diff]
+1      28
-1       0
+2       0
-2       0
+3       0
-3       1
+4      11
-4       0
+5      51
-5       0
+6       0
-6      39
+7       0
-7      50

show diff for ./en_user_log_phones_2011_08.csv
+1       4
+4       5
+5       7
-6       9
-7       7

The increase of false positives comes from the spaceless
typing test cases that are synthetic data.

Change-Id: I4ea77aa56ebfaa5518c71107169e1d2332de6327
 2014-10-14 11:20:33 +09:00
Sandeep Siddhartha
06a438d3a5 Don't restore debug preferences 
Bug: 17942814
Change-Id: I0bbef716dff47ed8eb880209d448629ad853b904
 2014-10-13 18:59:48 -07:00
Tadashi G. Takaoka
ae3ad8ebdd (DO NOT MERGE) Fix checking a11y status just before calling an a11y method 
Cherry picked from Master, commit 04cd8794e0

Bug: 17035860
Change-Id: I9627d525a570ced085281b4db93fe6896081e818
 2014-10-14 01:40:27 +00:00
Sandeep Siddhartha
19084d076a Cleanup LoginAccountUtils 
Bug: 17464068
Change-Id: Icf994a7582491afebc5db522c127a30d079ce05c
 2014-10-13 12:23:22 -07:00
Sandeep Siddhartha
d9015233f5 Set up a sync preference and policy for syncing [2] 
- Adds a preference for enabling sync, which controls the sync behavior
- Make the ProductionFlags depend on appropriate flags to guarantee that
  we don't mess things when flipping some flags
- Preferences now control the "syncable" property of the provider
  thereby controlling the policy and when this entry shows up in
  system settings.

Bug: 17464069
Change-Id: I1d58351188518c1ae9f1f9e147b5ea15d32a3427
 2014-10-10 16:03:54 -07:00
Sandeep Siddhartha
1e10d29bc8 Don't restore device specific preferences 
There are two categories of preferences:
1. That are part of the default shared preference
   They were all getting backed up and restored.
   Added a blacklist to not restore some of these.
   e.g. current account

2. That are in a non-default shared preference file.
   These are not getting backed up currently, but added a specific
   local preference file for all such preferences.

Bug: 17288591
Change-Id: I2f748be971a2337543e5014434aa39313fd1e1d8
 2014-10-10 10:49:32 -07:00
Tadashi G. Takaoka
6e565332df Merge "Fixing keyboard theme selection" 2014-10-10 09:28:24 +00:00
Jean Chalard
7d5e1cb265 [ML23] Introduce a different accuracy/performance tradeoff 
Bug: 11230254
Change-Id: Ic09518c818ae7b68942b1c63160dd462e5922cb5
 2014-10-10 18:02:52 +09:00
Tadashi G. Takaoka
4f17f3df46 Fixing keyboard theme selection 
Bug: 17937287
Change-Id: I476045980843c5897820cd544daea06fa991acb5
 2014-10-10 17:42:03 +09:00
Jean Chalard
5d2d852eb0 [ML22] Improve the language on spacebar for SLS 
Bug: 11230254
Change-Id: Ib54be1a2a77b6e80cdff1af89a7b4203ea859716
 2014-10-10 16:19:48 +09:00
Jatin Matani
701b14ffa6 Merge "Make SuggestionWordInfo non-final for testabilty" 2014-10-10 05:18:55 +00:00
Sandeep Siddhartha
80f0e89aaf Remove UsedForTesting tags from BlockingHttpClient 
Bug: 17464069
Change-Id: I45aa6da0e339ffb56de613c2a0a43fe37fb2defd
 2014-10-09 14:30:45 -07:00
Jatin Matani
eaf517ffea Merge "Changes related Sync Engine library that communicates to cloud server" 2014-10-09 18:06:32 +00:00
Jean Chalard
bc18005948 Always show the typed word in recorrections. 
Bug: 11330140
Bug: 17875601
Bug: 17623275
Change-Id: Ie4620f36f312c54c7b01b5f6cbdb0bc9171b6179
 2014-10-09 17:54:58 +09:00
Keisuke Kuroyanagi
41302021d6 Merge "Rename updateCounter to updateEntriesForWordWithNgramContext." 2014-10-09 08:51:18 +00:00
Keisuke Kuroyanagi
ab4437f468 Rename updateCounter to updateEntriesForWordWithNgramContext. 
Bug: 14425059
Change-Id: Id9b0dd7e32c711ed4292981517c3febd5fe9e897
 2014-10-09 17:34:29 +09:00
Keisuke Kuroyanagi
fca049a4b0 Merge "Extend jni method to dump ngram entries." 2014-10-09 08:28:13 +00:00
Yohei Yukawa
6547311865 Merge "Simplify CursorAnchorInfoCompatWrapper" 2014-10-09 08:13:50 +00:00
Jean Chalard
437fcbaa9f [ML20.1] Move getRichInputMethodSubtype to additional features 
Bug: 11230254
Change-Id: I9bc19db5f101eeb6841394fe3637f271c93cbfa7
 2014-10-09 16:35:15 +09:00
Jatin Matani
db1b736446 Changes related Sync Engine library that communicates to cloud server 
This change updates some of the code that the library uses
to communicate with the cloud server
Specifically :
- Update BlockingHttpClient to use template ResponseProcessor
- Update HttpUrlConnectionBuilder to setAuthToken for HttpUrlConnection

Bug: 17464069
Bug: 17464805

Change-Id: I7d7b58dff594b920162f799d102e8582ff9fe6a4
 2014-10-09 00:01:32 -07:00
Yohei Yukawa
dac49f9f6d Simplify CursorAnchorInfoCompatWrapper 
With this CL, we will use CursorAnchorInfoCompatWrapper just to
avoid unexpected NoClassDefFoundError due to the direct
dependency CursorAnchorInfo class, which is available only on
API level 21 and later.

Change-Id: I254ff83f1ca41daa21d0666b5824af22ba529022
 2014-10-09 15:54:34 +09:00
Keisuke Kuroyanagi
d7a51c242b Extend jni method to dump ngram entries. 
Bug: 14425059
Change-Id: Ib03b58525fae12f254b45630bee31ecbdde227b1
 2014-10-09 15:26:10 +09:00
Jean Chalard
176e6e22cf Merge "[ML19] Actually switch the language when appropriate" 2014-10-09 05:12:01 +00:00
Jean Chalard
81a5a10476 [ML19] Actually switch the language when appropriate 
That is, when auto-correcting or when manually picking.
This is not great, but it's a good starting point.

Bug: 11230254
Change-Id: I07627f48e2de1c28053d6572c7c72625808ec79c
 2014-10-09 13:13:25 +09:00
Tadashi G. Takaoka
15480481be Add keyboard shadow 
This CL sets 8dp elevation ot input view in order to cast a shadow
onto underlying application.

Bug: 16210054
Change-Id: I7779c63612fc88e24dde65de3e4e7a45b9d1762f
 2014-10-09 12:39:15 +09:00
Jatin Matani
3c6ac75c48 Merge "Fix messaging for sync now feature, when no account is selected" 2014-10-08 23:40:27 +00:00
Jatin Matani
f66a6a3bb0 Fix messaging for sync now feature, when no account is selected 
Change-Id: I5e81b7a1eed9c2177ad3ddfa6c96c2b85c433766
 2014-10-08 15:26:39 -07:00
Tadashi G. Takaoka
9bda19891c Merge "Stop dimming main keyboard while showing more keys keyboard" 2014-10-08 13:13:26 +00:00
Jean Chalard
15335d7526 Merge "[ML18] Make WordComposer#getAutoCorrection a word info" 2014-10-08 13:04:25 +00:00
Jean Chalard
176ad53c6f [ML18] Make WordComposer#getAutoCorrection a word info 
Bug: 11230254
Change-Id: I6ad2e7f89862fbfe7af5502961643320c782347f
 2014-10-08 21:46:13 +09:00
Ken Wakasa
5b39af37c0 Fix unit test failure 
Change-Id: I5a28c6775385ba3b0b7d86c85064fd28f3cbb353
 2014-10-08 17:27:28 +09:00
Tadashi G. Takaoka
6085839627 Stop dimming main keyboard while showing more keys keyboard 
Bug: 17910364
Change-Id: Ibe76ee86a43c5939f48e45506c985b3f289eac7a
 2014-10-08 16:59:21 +09:00
Jatin Matani
847735fdfa Merge "Skeleton code for user dictionary sync" 2014-10-08 02:09:50 +00:00
Jatin Matani
3fbe459fa7 Make SuggestionWordInfo non-final for testabilty 
Needed for ag/563043
Bug:17731683
Change-Id: I4d19e512a311547204f7e8d7885fc886757a18b7
 2014-10-07 18:43:13 -07:00
Jatin Matani
734733d8ad Skeleton code for user dictionary sync 
Bug:17464069
Change-Id: If683b80e882c07fba576959346ae74cd445dd83e
 2014-10-07 12:30:12 -07:00
Yohei Yukawa
89d7965e76 Merge "Fix NoClassDefFoundError due to CursorAnchorInfo in K" 2014-10-07 10:30:36 +00:00
Yohei Yukawa
883bfd2c0b Fix NoClassDefFoundError due to CursorAnchorInfo in K 
Check API level before touching CursorAnchorInfo that is only
available in L and later.

BUG: 17891202
Change-Id: I6e8d2e3f071bd78bed8c1d24ba2b97207dea3044
 2014-10-07 19:19:20 +09:00
Jean Chalard
be4e1539cb [ML17] Add a method to switch the most probable language 
Also directly hold a ref to it. It's simpler for now, though
we may want to remove it completely later to have a flat,
purely weight-based system with no preference.
Also split weights between gesturing and typing.

Bug: 11230254
Change-Id: Ica15964a193ae6e7f14c85a9a3ed806130fa7efb
 2014-10-07 19:09:49 +09:00
Jean Chalard
38ec825ef8 [ML16] Remove DictionaryFacilitator.getLocale() 
Bug: 11230254
Change-Id: Ife99df42bc145fbd2d5c3128330bc0f88b104de9
 2014-10-07 16:44:26 +09:00
Jean Chalard
ea07734956 [ML15] First step in removing DictionaryFacilitator.getLocale 
Bug: 11230254
Change-Id: Ied010ec6f1024080e8a499f682d2fc1780e82ef7
 2014-10-07 16:06:35 +09:00
Keisuke Kuroyanagi
3ead4d7f8a Merge "Quit having obsolete options for ime-simulator." 2014-10-07 02:03:59 +00:00
Adrian Velicu
639837f85d Merge "Postponing memory deallocation after onFinishInputView" 2014-10-06 23:45:40 +00:00
Tadashi G. Takaoka
6fb586a527 Fix missing prediction words on contextual strip 
Bug: 17874801
Change-Id: Iaba935a6b2548376f10a0ecd80f07ea7ada6c60a
 2014-10-07 00:06:53 +09:00
Yohei Yukawa
db6c32778e Merge "Add a utility method to SuggestionSpanUtils" 2014-10-06 15:03:20 +00:00
Adrian Velicu
7b8f317050 Postponing memory deallocation after onFinishInputView 
Bug: 17559789
Change-Id: I1d4b1524028164d27ec4eadd3960b567148f2b84
 2014-10-06 23:14:48 +09:00
Jean Chalard
fcc4cbf6f1 Merge "[ML14] Forward the locale list to relevant places, again" 2014-10-06 13:32:32 +00:00
Keisuke Kuroyanagi
a84a8d38c0 Quit having obsolete options for ime-simulator. 
Bug: 16547409
Change-Id: I43f5a15153cbd7072fde15764a664ad4d1c6417f
 2014-10-06 22:03:39 +09:00
Jean Chalard
bc051a561f [ML14] Forward the locale list to relevant places, again 
Diff:
+++ b/java/src/com/android/inputmethod/keyboard/internal/KeyboardBuilder.java
@@ -735,7 +735,7 @@ public class KeyboardBuilder<KP extends KeyboardParams> {

     private boolean matchLocaleCodes(TypedArray caseAttr, final Locale[] locales) {
         // TODO: adujst this for multilingual input
-        return matchString(caseAttr, R.styleable.Keyboard_Case_languageCode, locales[0].toString());
+        return matchString(caseAttr, R.styleable.Keyboard_Case_localeCode, locales[0].toString());
     }

     private boolean matchLanguageCodes(TypedArray caseAttr, Locale[] locales) {

Change-Id: Icefac18dd6d5fea97f591177cf8df1ba6de7f4f0
 2014-10-06 21:27:32 +09:00
Yohei Yukawa
4f04fd95f4 Merge "Remove ENABLE_CURSOR_ANCHOR_INFO_CALLBACK" 2014-10-06 11:02:24 +00:00
Yohei Yukawa
81c2dfe9c6 Remove ENABLE_CURSOR_ANCHOR_INFO_CALLBACK 
We can now start relying on L APIs even in unbundled release.

This means ENABLE_CURSOR_ANCHOR_INFO_CALLBACK can be always true.
Hence we simply remove it.

Change-Id: I0353e992e97e252059f83accea100504594bf171
 2014-10-06 19:39:13 +09:00
Tadashi G. Takaoka
4bde90bf77 Merge "Update setup wizard video and image of AOSP" 2014-10-06 08:08:11 +00:00
Tadashi G. Takaoka
48b707e1bd Update setup wizard video and image of AOSP 
Bug: 17769384
Change-Id: I23748bce17566aad1693ff56e8c04f493f957f84
 2014-10-06 16:53:22 +09:00
Tadashi G. Takaoka
8b24e7abde Merge "Refactor custom input style settings" 2014-10-06 07:35:34 +00:00
Yohei Yukawa
03c1e7955a Add a utility method to SuggestionSpanUtils 
This is a ground work for subsequent CLs.

BUG: 16995261
Change-Id: Icbb708a35412a635a0d625b520069840c0bb0904
 2014-10-06 16:22:51 +09:00
Yohei Yukawa
a48ff4e294 Merge "Add unittest for SuggestionSpanUtils" 2014-10-06 07:20:39 +00:00
Keisuke Kuroyanagi
9290d0a4eb Make UserHistoryDictionary use updateEntriesForWordWithNgramContext() 
Bug: 14425059
Change-Id: I409ebf90f68f4a0f1638128ac5ee6af859323d30
 2014-10-06 15:50:38 +09:00
Tadashi G. Takaoka
399a3bd930 Refactor custom input style settings 
This CL removes references of Pair class.

Change-Id: I7cda0ac438ac1d5026599cb52ac2ea8845339da9
 2014-10-06 15:39:42 +09:00
Yohei Yukawa
ceedaf6321 Add unittest for SuggestionSpanUtils 
This adds unittest for SuggestionSpanUtils for subsequent CLs.
No behavior change is intended in this CL.

BUG: 16995261
Change-Id: I90d1591cab893a1421ca633963b7c8f00a5fe4b4
 2014-10-06 12:24:46 +09:00
Keisuke Kuroyanagi
6accf63d0a Make unit tests use new entry updating method. 
Bug: 14425059
Change-Id: Ie7d92e92822a0d3a8b654d213e55d45aab799f5d
 2014-10-06 12:09:15 +09:00
Ken Wakasa
faefad5b0f Revert "[ML14] Forward the locale list to relevant places" 
This reverts commit 15dbd38283.

Bug: 11230254

Reverting due to unit test breakage.

Change-Id: Icf29ba5c808c754515aef2d1b4162d72f606acfe
 2014-10-03 23:48:53 +00:00
Jean Chalard
15dbd38283 [ML14] Forward the locale list to relevant places 
Bug: 11230254
Change-Id: Idf3ed27b396d63ade9800c72c5ce0ed613f5f669
 2014-10-03 23:20:38 +09:00
Tadashi G. Takaoka
826186f66b Use Devanagari Danda letter as full stop on Nepali keyboard 
Bug: 17741882
Change-Id: I62e8c9a3f194b9a3a6724c7d1a92292b150ddeb9
 2014-10-03 09:48:18 +00:00
Jean Chalard
332f43275d Merge "Fix a behavior change in dicttool" 2014-10-03 09:33:28 +00:00
Jean Chalard
d415747a27 Merge "[ML13] Fix the locale passing in ProximityInfo" 2014-10-03 09:24:49 +00:00
Tadashi G. Takaoka
96d31df8c4 Fix when to show input view 
Bug: 15922840
Bug: 17788786
Change-Id: I69aea682202650b601a295d9da583ef8e05a3982
 2014-10-03 18:20:06 +09:00
Jean Chalard
4ef27c0358 [ML13] Fix the locale passing in ProximityInfo 
The locale is used to determine additional proximity characters. This
is dependent on the dictionary language, but was passed as a function
of the layout, which is wrong and would have given bad suggestions in
multi-lingual mode.

Ideally, additional proximity characters should be inserted in the
dictionary header, but for now it's a rather simple change to get
it from the dictionary's locale instead of the proximity info locale.

Also, that allows us to remove completely the locale parameter from
proximity info, which is a much needed change.

This change has zero effect on unit tests and on regression tests.

Bug: 11230254
Change-Id: If95157155db7dccd1f00b8ba55ccb3600283f9e4
 2014-10-03 18:16:34 +09:00
Jean Chalard
b28d1cc487 Fix a behavior change in dicttool 
The behavior change was introduced by I8b3458ad. Concretely,
empty bigram lists would end up as empty lists instead of null.

Change-Id: Ibcdf7e6aabc6aba3f5db0477335882394e050ce5
 2014-10-03 18:04:10 +09:00
David Faden
c92c883fdf Add calls to stub for API to consume gesture data. 
Bug: 17400259
Change-Id: Ib3511afffe1d14662e7dd14611f384689516e664
 2014-10-03 15:01:34 +09:00
Tadashi G. Takaoka
049d642cc4 Fix ellipsizing and text scale x calculation 
Bug: 17742721
Bug: 11158757
Change-Id: I98b55a8e661804e84f75e75675c6f2ef33ac1a11
 2014-10-02 19:58:24 +09:00
Yohei Yukawa
45ebb2001d Merge "Preserve spans when splitting sentences" 2014-10-02 09:29:23 +00:00
Jean Chalard
371d76ff07 Merge "[ML12] Add a getPrimaryLocale function and some refactoring" 2014-10-02 09:20:04 +00:00
Jean Chalard
1c0876dc49 [ML12] Add a getPrimaryLocale function and some refactoring 
Bug: 11230254
Change-Id: Ic579b93702c24f47e6cdb0c9a4da6b11f1fa76c8
 2014-10-02 18:15:35 +09:00
Akifumi Yoshimoto
7e5614520a Merge "Include a code point table in the binary dictionary." 2014-10-02 08:55:18 +00:00
Tadashi G. Takaoka
a5cdd6f4c5 Merge "Fix unnecessary touch event handling" 2014-10-02 07:51:02 +00:00
Yohei Yukawa
3852cfa717 Preserve spans when splitting sentences 
This CL fixes a bug that span information was unintentionally
removed when given sentences are split into words. Nothing is
changed in KitKat and prior because TextInfo never returns
spanned text until L.

Note that the spell checker service still doesn't rely on
span information even with this CL.

BUG: 16419551
Change-Id: I6ffb75ee6add4ae20e9d3dcfb90b65f097d70fba
 2014-10-02 14:08:59 +09:00
Jean Chalard
c91166de54 Merge "Avoid downloading the metadata in quick succession." 2014-10-02 04:31:08 +00:00
Tadashi G. Takaoka
8ab46225b3 Fix unnecessary touch event handling 
Bug: 17762449
Change-Id: I698ca91ab977aa65c7bd8a5fb82b3d91264cfbca
 2014-10-02 12:48:26 +09:00
Akifumi Yoshimoto
9168ab60cf Include a code point table in the binary dictionary. 
Bug:17097992
Change-Id: I677a5eb3a704e4386f6573360e44ca335d81d2df
 2014-10-02 12:27:49 +09:00
Jean Chalard
2910990065 Merge "Never include the typed word in recorrections" 2014-10-01 10:34:22 +00:00
Jean Chalard
eff21b653f Merge "Make a better effort to detect a framework lie." 2014-10-01 10:24:32 +00:00
Jean Chalard
38144047ea Make a better effort to detect a framework lie. 
Bug: 17130496
Change-Id: I1a3631670c152d9b7667c9c4e08e14c48569eef5
 2014-10-01 19:17:31 +09:00
Jean Chalard
7f226b4f9d Merge "Fix an NPE on ICS factory rom." 2014-10-01 10:16:40 +00:00
Jean Chalard
57e29436b1 Fix an NPE on ICS factory rom. 
In ICS factory rom and MR0, there was a bug where calling the
constructor for SuggestionSpan that doesn't take a context as
an argument would always return in a crash. Don't call it,
and pass an explicit context instead.

Bug: 13552505
Change-Id: I5c919499b9d086c2cf283795b2af5b91cb425933
 2014-10-01 18:33:47 +09:00
Jean Chalard
4c90df7e5b Never include the typed word in recorrections 
Bug: 17623275
Change-Id: I2461e5e8baf06fb80a05b87f9d3db7a4d1952a01
 2014-10-01 18:32:02 +09:00
Tadashi G. Takaoka
31c16d41bc Add Uzbek keyboard 
Bug: 13222403
Change-Id: I9a4cf447a8ab0c26c4dc7f7794c57390024660cc
 2014-10-01 09:29:34 +00:00
Tadashi G. Takaoka
79d992ccba Merge "Use Devanagari Danda letter as full stop on Hindi keyboard" 2014-10-01 09:29:14 +00:00
Tadashi G. Takaoka
a987f6d0cc Use Devanagari Danda letter as full stop on Hindi keyboard 
Bug: 17418371
Change-Id: I22bb2913015a83604301576e68095974c38b7c9a
 2014-10-01 18:20:31 +09:00
Keisuke Kuroyanagi
bcb439e702 Merge "Add jni method to update entries for a word efficiently." 2014-10-01 08:57:02 +00:00
Keisuke Kuroyanagi
ce5fd94b97 Add jni method to update entries for a word efficiently. 
Bug: 14425059
Change-Id: Ic628939ea68cdee17573409883a8403c73b78905
 2014-10-01 17:40:20 +09:00
Tadashi G. Takaoka
d368975cdb Merge "Add Akkhor Layout for Bengali Bangladesh" 2014-10-01 08:13:46 +00:00
Tadashi G. Takaoka
f41c11a5c0 Merge "Fix when to show more suggestions dot hint" 2014-10-01 07:58:28 +00:00
Tadashi G. Takaoka
0487290f0f Merge "Fix NPE in KeyboardParams" 2014-10-01 07:54:47 +00:00
Keisuke Kuroyanagi
108dad1491 Merge "Introduce NgramProperty in Java side." 2014-10-01 07:53:04 +00:00
Tadashi G. Takaoka
23b35a9689 Fix when to show more suggestions dot hint 
Bug: 17742406
Change-Id: Ifdf5d196778da2bb9bb9e3ca9250d23857d90bab
 2014-10-01 16:50:28 +09:00
Tadashi G. Takaoka
dbf5701ee0 Fix NPE in KeyboardParams 
Bug: 17707885
Change-Id: Ie6a54ac5ab60f5d11363ac8da8eef850d65dba7c
 2014-10-01 16:08:58 +09:00
Jean Chalard
9d92d3e02d Avoid downloading the metadata in quick succession. 
Bug: 17668298
Bug: 8651816
Bug: 17709442
Change-Id: Ib232f9d95d7c01a028be85d10f974a5a570c0ed5
 2014-10-01 12:20:27 +09:00
Yohei Yukawa
7b673c7265 am 5139c4fd: am 702a736e: am 31838876: am 9baaa4b5: am 6ad437ed: Merge "Fix NPE due to the lack of null-check" into lmp-dev 
* commit '5139c4fd28d1a34981d590f2fbec9b407481ea52':
  Fix NPE due to the lack of null-check
 2014-10-01 02:26:35 +00:00
Keisuke Kuroyanagi
c6a6f6a990 Introduce NgramProperty in Java side. 
Bug: 14425059
Change-Id: I8b3458ad22730b3dccbe0caea2c5930f5276dc82
 2014-10-01 11:21:08 +09:00
Jatin Matani
0187db39b5 Merge "Add StatsUtils#onLoadSettings for when settings are changed" 2014-10-01 00:41:32 +00:00
Jatin Matani
cc7e44e34c Add StatsUtils#onLoadSettings for when settings are changed 
Non-blocking call in nature.
Bug:17013677

Change-Id: Iff737422bbacbf22c9b0ff6eaf1c1f75e6bf23c3
 2014-09-30 17:09:00 -07:00
Adrian Velicu
9586d69bdf Avoid double space when autocorrect is triggered 
Bug: 17596034
Change-Id: Iaa6cc066eefd2436195a91791f2628e9a5f1c449
 2014-09-30 15:48:48 +09:00
Yohei Yukawa
de12c1bf49 Fix NPE due to the lack of null-check 
The case that was not coverted well is that
CursorAnchorInfoCompatWrapper could be instantiated
with null object. In such situations, we should
do nothing.

BUG: 17682582
Change-Id: I6625a2f0ed8c5580ed9edfe4728f342da77a8e40
 2014-09-29 17:03:29 +09:00
Tadashi G. Takaoka
4936d259d7 Merge "Fix verbalizing missing emoticons" 2014-09-29 06:39:30 +00:00
Akifumi Yoshimoto
5e828b2c61 Merge "Create a code point table based on occurrence counts." 2014-09-29 06:31:33 +00:00
Tadashi G. Takaoka
d9d5ba4287 Fix verbalizing missing emoticons 
Bug: 15585153
Change-Id: I8ae184047558d1a78e20efde0b08e40beb4458b9
 2014-09-29 15:15:18 +09:00
Keisuke Kuroyanagi
a4a4e9d96b Merge "Rename PrevWordsInfo to NgramContext." 2014-09-29 03:00:55 +00:00
Keisuke Kuroyanagi
33b0ebff27 Merge "Refactoring PrevWordsInfo." 2014-09-29 02:33:00 +00:00
Keisuke Kuroyanagi
bb0eca5705 Rename PrevWordsInfo to NgramContext. 
Bug: 14425059
Change-Id: Id06a71681fa8b5e589e29fba10fe5c1cfed66984
 2014-09-29 10:52:18 +09:00
Tadashi G. Takaoka
76150b8133 Add Akkhor Layout for Bengali Bangladesh 
Bug: 16143057
Change-Id: I0b4a3d0d1125f9af25a98ee7a1852129ae1c1d2c
 2014-09-26 18:20:25 +00:00
Sandeep Siddhartha
569f6f1c9e Merge "Add authentication/http request related code to LatinIme" 2014-09-26 17:22:12 +00:00
Sandeep Siddhartha
05274d5a0d Add authentication/http request related code to LatinIme 
Bug: 17464068
Bug: 17464805
Change-Id: I533ae8821e0628fdf6591538a96ab50f805c0cdf
 2014-09-26 10:14:24 -07:00
Keisuke Kuroyanagi
bbd6a26be0 Refactoring PrevWordsInfo. 
Bug: 14425059
Change-Id: I48a193b965e3055bd10a00046322c2b7b19a6232
 2014-09-26 21:46:57 +09:00
Tadashi G. Takaoka
dade81d78c Fix adding more diacritics letters for Nordic languages 
Bug: 10787354
Change-Id: Ia71417069a0cc10d7908d0c404ce85eb0cd76540
 2014-09-26 20:21:17 +09:00
Tadashi G. Takaoka
8108a3e1cd Add Serbian Latin keyboard 
Bug: 9687668
Change-Id: I0631ab04cf33e3d454c965e98a756c31666537bf
 2014-09-26 16:01:34 +09:00
Akifumi Yoshimoto
8a6e96d286 Create a code point table based on occurrence counts. 
Bug:17097992
Change-Id: Ifd76dbd4d385d800af416368e25c9e56a76d0fbf
 2014-09-26 15:15:16 +09:00
Tadashi G. Takaoka
1c70a8e147 Merge "Add info log of custom input styles" 2014-09-26 03:56:22 +00:00
Tadashi G. Takaoka
10a93dc80c Add info log of custom input styles 
Bug: 17622871
Change-Id: Ia97c7bc2f0923417b458b178fbd8776d5cd0758c
 2014-09-26 12:51:42 +09:00
Tadashi G. Takaoka
90058c3d1f Add an internal state test to ImportantNoticeUtilsTests 
On some 32bit-x86 testing emulators, it seems the internal state after
clear the related settings seems like a contradiction state. This CL
adds an test to check such internal state in order to investigate what
is happening on these emulators.

Bug: 17635340
Change-Id: Iba85f06c46959b1dc22e2a9213c50c9e7e30949b
 2014-09-26 12:16:54 +09:00
Tadashi G. Takaoka
f99cce8615 Merge "Fix checking a11y status just before calling an a11y method" 2014-09-25 14:14:28 +00:00
Tadashi G. Takaoka
aaefd56661 Add !string/<resource_name> reference 
This CL introduces new text reference notation !string/<resource_name>
to refer a string resource on the fly.

This notation is mainly used to represent action key labels may refer
a string in a system locale in run-time.

This notation is needed to implement Hinglish and Serbian-Latin
keyboards that need to refer its own action key labels.

Bug: 17169632
Bug: 9687668
Change-Id: I042f6bd04714e0e448cd92031730eb9fb422e6d3
 2014-09-25 18:27:23 +09:00
Tadashi G. Takaoka
04cd8794e0 Fix checking a11y status just before calling an a11y method 
Bug: 17035860
Change-Id: I9627d525a570ced085281b4db93fe6896081e818
 2014-09-25 18:24:17 +09:00
Keisuke Kuroyanagi
951252bf47 Merge "Get stats from dictionary." 2014-09-25 08:24:55 +00:00
Tadashi G. Takaoka
22e2fa372c Merge "Add allowRedundantMoreKeys attribute" 2014-09-25 08:20:19 +00:00
Jean Chalard
2828d9eda7 Merge "[ML10.1] Adjust call for additional features" 2014-09-25 08:19:47 +00:00
Tadashi G. Takaoka
0be4e6e585 Add allowRedundantMoreKeys attribute 
This CL also adds a couple of custom layout tests of Nordic languages.

Bug: 10787354
Change-Id: I5e875d3f30863395511afa82f0a02deb093d3a6f
 2014-09-25 15:12:06 +09:00
Jean Chalard
8da2052113 [ML10.1] Adjust call for additional features 
Bug: 11230254
Change-Id: I7b60d9174d7d267eb1b3cd848cff36cdbea75b12
 2014-09-25 12:50:11 +09:00
Keisuke Kuroyanagi
a40db55d9b Merge "Fix typo." 2014-09-25 02:52:12 +00:00
Keisuke Kuroyanagi
97465afbf8 Fix typo. 
Change-Id: Ib090a3dfa7e53232e0d1ef5e4d2cbe48130f657f
 2014-09-25 11:50:30 +09:00
Sandeep Siddhartha
145f05d637 Merge "Add account change receiver to handle account removal" 2014-09-24 23:40:58 +00:00
Sandeep Siddhartha
d4aec65f65 Add account change receiver to handle account removal 
Also cleanup the manifest to group similar components together.
Moving LoginAccountUtils to its own package

Bug: 17464068
Change-Id: Iad7928855531d58334b1e4039bb45b97dde75462
 2014-09-24 13:10:54 -07:00
Tadashi G. Takaoka
21f038ee0a Stop showing more suggestions while important notice is showing 
Bug: 15812659
Change-Id: I314e235cfffae3ae655320a9a75867efc28066bf
 2014-09-24 14:12:05 +09:00
Tadashi G. Takaoka
064ba6bc0a Merge "Fix Turkish/Azerbaijani keyboard to add more accented letters" 2014-09-24 03:36:10 +00:00
Tadashi G. Takaoka
9a73a79cbe Merge "Fix not intercepting touch event while in modal mode" 2014-09-24 03:24:18 +00:00
Jean Chalard
3db17c5394 Merge "[ML9.1] Add option for multi-lingual support" 2014-09-24 02:42:46 +00:00
Tadashi G. Takaoka
620bfb9bb9 am 4c4ba10b: am 71b51590: am a76e11a2: am 1f490d6c: am be4e0d0e: Fix when to show important notice 
* commit '4c4ba10bbb257036d7cb6ae8a128263285b7384f':
  Fix when to show important notice
 2014-09-23 16:18:45 +00:00
Keisuke Kuroyanagi
9997853d6f Merge "Prepare supporting n-gram for user history dictionary." 2014-09-23 10:18:41 +00:00
Jatin Matani
e2e48eb9b3 Merge "Add StatsUtilManager.onStartInput & onFinishInput" 2014-09-22 16:15:14 +00:00
Keisuke Kuroyanagi
ddfaeff544 Prepare supporting n-gram for user history dictionary. 
Bug:17097992
Change-Id: Ic8bfde3d4cc0e720bf7681e08e16fb2ad94d5670
 2014-09-22 18:18:50 +09:00
Jean Chalard
4b0dba4cd8 [ML9.1] Add option for multi-lingual support 
Bug: 11230254
Change-Id: I15d42fad155142fa6f556f13e84cad489be00dbd
 2014-09-22 17:41:37 +09:00
Tadashi G. Takaoka
d144b7874e Fix not intercepting touch event while in modal mode 
Bug: 17600156
Change-Id: Ife8f04550411d88311e08dd33e370a410d791ca2
 2014-09-22 15:30:29 +09:00
Adrian Velicu
b12c174c2f Merge "Hiding SuggestedWords.EMPTY and refactoring code that compares SuggestedWords instances directly to it to use isEmpty instead" 2014-09-22 06:20:25 +00:00
Adrian Velicu
30f4a2a4d7 Hiding SuggestedWords.EMPTY and refactoring code that compares SuggestedWords instances directly to it to use isEmpty instead 
Bug: 17560717
Change-Id: I7032bf0ab46f9cf5e3b3312a14e689b5496764c1
 2014-09-22 14:50:21 +09:00
Tadashi G. Takaoka
be4e0d0e39 Fix when to show important notice 
This CL introduces a timeout duration to show an important notice
message. When the timeout has passed, the important notice message
will be suppressed without user intervention.

This CL also adds unit tests and fixes a bug in
getNextImportantNoticeTitle().

Bug: 17181982
Change-Id: If321c0060cc2f7ca14ad0631b84f4990f88bd659
 2014-09-22 14:28:31 +09:00
Jatin Matani
6a6137325b Add StatsUtilManager.onStartInput & onFinishInput 
Bug:15657192
Change-Id: I6e976202812d1c1675bd7822c4a15686d1ec1fe9
 2014-09-21 20:19:12 -07:00
Keisuke Kuroyanagi
825747348b Merge "Create DictionaryStats in executor." 2014-09-22 02:49:04 +00:00
Mohammadinamul Sheik
8f116d7cda Merge "Invoke onWordCommitUserTyped on startInput() with non empty wordcomposer" 2014-09-22 02:13:21 +00:00
Tadashi G. Takaoka
8ea51a2760 Fix Turkish/Azerbaijani keyboard to add more accented letters 
Bug: 16807005
Change-Id: Ifd0ab3aeb8207cdecacf8cfe5b1d58c07690142f
 2014-09-22 10:55:08 +09:00
Keisuke Kuroyanagi
743a9b4499 Get stats from dictionary. 
Bug: 16553957
Change-Id: I70c7a7be3c902dc8a0dfe8f946f9ef75ba6c9655
 2014-09-22 10:26:19 +09:00
Keisuke Kuroyanagi
c724864c61 Create DictionaryStats in executor. 
Bug: 16553957
Change-Id: Ie4e9a6ee67f90ba0086af2075068e078efc7f189
 2014-09-22 10:25:51 +09:00
Yohei Yukawa
c514d64bff am d8c83fb8: am 88cae78f: am 89dd5f03: am c1d35148: am f2d0d9b0: Merge "Avoid the add-to-dictionary indicator from being clipped" into lmp-dev 
* commit 'd8c83fb81bb06e22ab0857e1a7531c666ad8701e':
  Avoid the add-to-dictionary indicator from being clipped
 2014-09-20 04:46:48 +00:00
Yohei Yukawa
f2d0d9b0b9 Merge "Avoid the add-to-dictionary indicator from being clipped" into lmp-dev 2014-09-20 03:58:03 +00:00
Yohei Yukawa
9d2f606aa8 Avoid the add-to-dictionary indicator from being clipped 
With this CL, the display bounds is taken into consideration
when the location of add-to-dictionary indicator is determined.

BUG: 17578360
Change-Id: I31e458fa7bbc33e539578b331fe1c51ff7f8668e
 2014-09-19 19:19:56 +09:00
Keisuke Kuroyanagi
845c061970 Fix unit tests. 
Change-Id: I7706db4c9279488552ea5fabc16dd1dd2bc7fa05
 2014-09-19 19:02:08 +09:00
Jean Chalard
c648bae15d (DO NOT MERGE) Remove some logs which spam encrypted boot 
Bug: 17539539
Change-Id: Idb442c2f0db2361b8e535f39b02d209b1edd1069
(cherry picked from commit 4b6c6fa0e4)
 2014-09-19 07:29:03 +00:00
Mohammadinamul Sheik
6901ea6eac Invoke onWordCommitUserTyped on startInput() with non empty wordcomposer 
In chat clients, the last committed word is not committed via
rich input connection. This will handle those missed out cases.

Change-Id: If3f1f6e1927cdf56a09d3e9124f05c66ca75de53
 2014-09-18 23:00:11 -07:00
Adrian Velicu
bacf2dbac6 Merge "Added @UsedForTesting to 'missing' methods to avoid ProGuard removing them" 2014-09-19 05:39:31 +00:00
Adrian Velicu
8c889784e2 Added @UsedForTesting to 'missing' methods to avoid ProGuard removing them 
Bug: 16864527
Change-Id: I698a1b3e09e7e9a12722169b37f87bd51c8cbd34
 2014-09-19 14:31:33 +09:00
Jean Chalard
17511a41a4 Merge "[ML8] Add a language weight" 2014-09-19 05:15:51 +00:00
Jean Chalard
4b6c6fa0e4 Remove some logs which spam encrypted boot 
Bug: 17539539
Change-Id: Idb442c2f0db2361b8e535f39b02d209b1edd1069
 2014-09-19 14:02:23 +09:00
Jean Chalard
6da9b21191 [ML8] Add a language weight 
...and rename an improperly named normalization value

Bug: 11230254
Change-Id: I0f5633148a9f66dbfd7d28540b8a8985131c4549
 2014-09-19 13:44:42 +09:00
Tadashi G. Takaoka
00e018370f Merge "(DO NOT MERGE) Fix showing important notice even at beginning of sentence" into lmp-dev 2014-09-18 22:48:10 +00:00
Mohammadinamul Sheik
0e9419d014 Add word commit methods to StatsUtils 
Change-Id: Ibb2cf0150cd9a851ff48d097688edc916dc82998
 2014-09-18 13:06:38 -07:00
Sandeep Siddhartha
84185148c5 Add account listing and preference integration for current account 
Bug: 17464068
Change-Id: Idb68a6012b285d6bc4632414bb6d11131148cf67
 2014-09-18 10:39:30 -07:00
Sandeep Siddhartha
27bb70d6a0 Merge "Start showing the split keyboard layout" 2014-09-18 17:05:28 +00:00
Sandeep Siddhartha
a7c5dcdedf Merge "Add Accounts & privacy settings in LatinIME" 2014-09-18 16:49:34 +00:00
Keisuke Kuroyanagi
6624ea96f7 Merge "Pass prevWordCount to native code for getSuggestion." 2014-09-18 13:01:35 +00:00
Keisuke Kuroyanagi
8806248386 Pass prevWordCount to native code for getSuggestion. 
Bug: 14425059
Change-Id: Id2b49a448982c997e5c0a22445b115e675156c3e
 2014-09-18 19:18:55 +09:00
Tadashi G. Takaoka
0055d26164 Merge "Fix showing important notice even at beginning of sentence" 2014-09-18 10:01:49 +00:00
Tadashi G. Takaoka
f4c7eb478f Fix showing important notice even at beginning of sentence 
This is a cherry-pick of Ic72d6fecc3 from lmp-dev.

Bug: 17536096
Change-Id: Id76b8f8dc85d03bc7ed5f24800301c081a82a8d2
 2014-09-18 18:51:23 +09:00
Tadashi G. Takaoka
26b3d1de7e (DO NOT MERGE) Fix showing important notice even at beginning of sentence 
Bug: 17536096
Change-Id: Ic72d6fecc3241c1a9aba87b82a46750cbd69e001
 2014-09-18 09:45:37 +00:00
David Faden
5dda75b538 Add methods to get a Key's horizontal and vertical gaps. 
Record the horizontal and vertical gap for the key, adding
corresponding accessors. This info is helpful in interpreting
corresponding touch points data.

Bug: 17400259
Change-Id: I825c537a48db35baab71580ff5c41cd911094a4b
 2014-09-18 09:40:02 +00:00
Yohei Yukawa
eddfe51b38 resolved conflicts for merge of 233a2f21 to master 
Change-Id: If391cc622367dfb4448c6a5c32b82111d352d86e
 2014-09-18 18:27:45 +09:00
Jean Chalard
cdabc71c6d Merge "Add a Dictionary.isUserSpecific method." 2014-09-18 08:52:07 +00:00
David Faden
0c837daee6 Add a Dictionary.isUserSpecific method. 
As the name suggests, returns true if the Dictionary is of a type
that may use user-specific data, e.g., contacts.

Cherry-pick of I11e71286c7635f50ace156dcc5308dbe51268d4e

Change-Id: I08c3f22f0c34eaa71bbd06594314f3b411658c5c
 2014-09-18 17:42:37 +09:00
Yohei Yukawa
fa63d91095 Merge "Use Add-To-Dictionary indicator only" into lmp-dev 2014-09-18 07:13:42 +00:00
Yohei Yukawa
5896153f93 Use Add-To-Dictionary indicator only 
With this CL, the previously used commit indicator was reverted.
Instead we use the add-to-dictionary indicator only at the moment.

This CL also fixes the indicator position in bidi context.

BUG: 17335734
Change-Id: I5f7cf173ddc30876e2b01320acaff8ba4265edf6
 2014-09-18 16:06:35 +09:00
Tadashi G. Takaoka
e7c2d1c99c am 902cefb6: am 97ad4968: am bfabac44: Suppress voice input key on textWebEmailAddress field 
* commit '902cefb6635053b682a917259eb5a964a17506fd':
  Suppress voice input key on textWebEmailAddress field
 2014-09-18 06:15:41 +00:00
Tadashi G. Takaoka
bfabac449d Suppress voice input key on textWebEmailAddress field 
Bug: 17486589
Change-Id: Ie9bf9266ee423b7e03cebcaa5f522accdd1a7802
 2014-09-18 14:08:21 +09:00
Keisuke Kuroyanagi
ace9c14852 Merge "Use PrevWordsInfo.getPrevWordCount() in Java side." 2014-09-18 04:58:44 +00:00
Sandeep Siddhartha
081c2d386d Start showing the split keyboard layout 
Change [3/3]

Added tests for Qwerty/en-US/split

Parse the switch-case statement from KeyboardBuilder to use the right layout.

Bug: 4968173
Change-Id: If4d6d71d5900525290268d8affa55dccf1ebd4f2
 2014-09-17 20:56:57 -07:00
Sandeep Siddhartha
a4e0b6efdd Add Accounts & privacy settings in LatinIME 
Also start showing the logging preference on this screen too.

This settings screen will be the container for all account
management, sync and privacy related settings

Bug: 17464068
Change-Id: Ie0806f6e8a542e9dea2834445ff7b38805207bda
 2014-09-17 20:50:05 -07:00
Tadashi G. Takaoka
90f06760b9 Fix Romanian keyboard to promote "A with breve" 
Bug: 17324498
Change-Id: Ie27f0023b2bfb18b0ee2051260ecf6bab75727a5
 2014-09-18 11:48:29 +09:00
Jatin Matani
fc12c0a7fd Merge "Add a user preference for split layout within Appearance & Layouts" 2014-09-17 17:00:38 +00:00
Keisuke Kuroyanagi
4466464c24 Use PrevWordsInfo.getPrevWordCount() in Java side. 
Bug: 14425059
Change-Id: Ie6295ff657c483876af403f2d474b7d857e5e3d6
 2014-09-17 22:04:25 +09:00
Tadashi G. Takaoka
7d64bc3455 Merge "Revert "Revert "Fall back to default keyboard theme""" 2014-09-17 11:51:19 +00:00
Tadashi G. Takaoka
311f12d024 Revert "Revert "Fall back to default keyboard theme"" 
This reverts commit 821486ba8b.

Change-Id: If0285c87edcd5f7d3c5449026953a74bf1125f65
 2014-09-17 11:51:09 +00:00
Tadashi G. Takaoka
c6cc000892 Merge "Revert "Fall back to default keyboard theme"" 2014-09-17 11:46:50 +00:00
Tadashi G. Takaoka
821486ba8b Revert "Fall back to default keyboard theme" 
This reverts commit 6ed8b18326.

Change-Id: I48f775e54f4077e556b26bc0146bc918421c6845
 2014-09-17 11:46:40 +00:00
Tadashi G. Takaoka
e2a396eef0 Merge "Fall back to default keyboard theme" 2014-09-17 11:23:56 +00:00
Tadashi G. Takaoka
6ed8b18326 Fall back to default keyboard theme 
Bug: 17537884
Change-Id: I3452d6d4a5837c6b2d417c8d256c121df86131cc
 2014-09-17 19:36:22 +09:00
Adrian Velicu
f116f91033 Making spelling of the word "distracters" consistent 
Bug: 17537869
Change-Id: Ibfc1c84aff72aeb76c9b127503369d00f3dfaceb
 2014-09-17 17:32:43 +09:00
Jatin Matani
a5d4cb7769 Add a user preference for split layout within Appearance & Layouts 
Note The preference is flag protected.

Change-Id: I1be219ba961f002897b7b13ff9f200e2f142b2d8
 2014-09-16 23:27:01 -07:00
Tadashi G. Takaoka
44398bb5e1 am cf5fc1ea: am 4e1f1689: am 5ae05786: Merge "Fix drawing of custom action label key" into lmp-dev 
* commit 'cf5fc1ea065873cd6d7b1d5d467940e4e45354d3':
  Fix drawing of custom action label key
 2014-09-16 23:59:08 +00:00
Mohammadinamul Sheik
16bfac9ff4 Add StatsUtils.onAutoCorrection method. 
Change-Id: I9547b6c0f082ef7c09b251a6458badb65a841229
 2014-09-16 12:34:22 -07:00
Jean Chalard
618907e1f1 Merge "[ML7] Have multiple DictionaryGroup instances in facilitator" 2014-09-16 11:31:27 +00:00
Jean Chalard
8cd5326622 [ML7] Have multiple DictionaryGroup instances in facilitator 
This is the central change of multilingual input.

Bug: 11230254
Change-Id: Id8b68fb101e837e8cf182ab4bc1e55e4da5cc49d
 2014-09-16 19:00:50 +09:00
Tadashi G. Takaoka
dad7a5dffd Fix drawing of custom action label key 
Bug: 17488054
Change-Id: I433561ed19ec2a79402867a0395a3e388730f087
 2014-09-16 18:21:49 +09:00
Sandeep Siddhartha
23f38149c6 Merge "Add a canSplitKeyboard attribute for specifying split keyboard layouts" 2014-09-16 03:05:46 +00:00
Jatin Matani
9b140f4e4f am 4d8efc97: am b41d1fcd: am d0d8f90a: Merge "Reorganize settings in Google Keyboard" into lmp-dev 
* commit '4d8efc97873d12b4596c695fbcf7e72330b5253e':
  Reorganize settings in Google Keyboard
 2014-09-13 02:12:24 +00:00
Ken Wakasa
64176158e7 resolved conflicts for merge of 75513e51 to master 
Change-Id: I058c3e63e5e349b58b2bdd2723cb43fbc24a0425
 2014-09-13 10:41:19 +09:00
Ken Wakasa
8ed81f9fd7 resolved conflicts for merge of 8e9385cc to master 
Change-Id: Ia6d192ee4a8496afa3f788894844ebef78fb7a8c
 2014-09-13 09:25:23 +09:00
Sandeep Siddhartha
3939455c1d Add a canSplitKeyboard attribute for specifying split keyboard layouts 
Change [1/3]

This'll be used in conjunction with a user preference to split the keyboard when possible.

Bug: 4968173
Change-Id: I7a05948d67b94a55024790115ae261d7fef7941a
 2014-09-12 18:46:14 +09:00
Jatin Matani
d0d8f90a32 Merge "Reorganize settings in Google Keyboard" into lmp-dev 2014-09-12 09:12:01 +00:00
Tadashi G. Takaoka
fd5f2b91fd Merge "Fix not always showing input view with physical keyboard connected" into lmp-dev 2014-09-12 09:02:31 +00:00
Tadashi G. Takaoka
3a90cb9ad0 Reorganize settings in Google Keyboard 
Changes :
Input languages ->  Languages
Input preferences -> Preferences
Multi lingual Options -> Multilingual Options
Keyboard Theme -> Theme
Gesture typing preferences -> Gesture typing

**New
 Appearance
        -> Theme
        -> Custom input style

**Removed
 Multilingual options from L dynamically

Bug: 11866784
Change-Id: I07404c27868e1b087b0cafb63d2031a5b493a885
 2014-09-12 02:00:26 -07:00
Jean Chalard
7aa47cb374 Only do double-space-period on real text fields. 
Bug: 15559216
Change-Id: Id6ecadc58c03889496967d67371457e4050d695b
 2014-09-12 17:49:47 +09:00
Tadashi G. Takaoka
88f282de0d Fix not always showing input view with physical keyboard connected 
Bug: 17163374
Change-Id: I57f7eeac0c9ac0a15d3d55927e18a2d97849c508
 2014-09-12 17:45:35 +09:00
Yohei Yukawa
97b465044f am ead70974: am 27ccbeb4: am cd119050: Support CursorAnchorInfo in the full-screen mode 
* commit 'ead70974aecd78d5bad0fa87a759f6bf82dcb503':
  Support CursorAnchorInfo in the full-screen mode
 2014-09-11 17:31:47 +00:00
Jean Chalard
96f0ae5e68 [ML6] Have asyncReloadMainDictionary support multiple locales 
Change-Id: I4c3dfaad38ec1cc91d1a9f81d5ff45ef12f70029
 2014-09-11 19:05:22 +09:00
Jean Chalard
e6df5f015c [ML5] Rewrite resetDictionariesWithDictNamePrefix 
This change rewrites resetDictionariesWithDictNamePrefix so
that it would work if there were several locales, which is going to
happen shortly. This change on its own is quite large and difficult
already, so I didn't want to merge it into the change that actually
makes several locales happen; another such change is following.

Change-Id: Ibb80b05b73c0f0f0bea64b7e308cc4d38ca448f9
 2014-09-11 19:05:19 +09:00
Yohei Yukawa
cd11905022 Support CursorAnchorInfo in the full-screen mode 
This CL allows to emulate the behavior of CursorAnchorInfo
in the full-screen mode to work around the limitation of
the framework.

Basically this CL copies relevant code from the framework
to LatinIME. This is actually a code duplicate which isn't
great, but probably the only way that is available right now.

Change-Id: I30bc8c3387c91c8e47252ba699cbd967d8927dad
 2014-09-11 18:36:53 +09:00
Jatin Matani
fd96928175 Merge "Adds StatsUtil methods for LatinIME.on{Start,Create,Finish}inputView" 2014-09-11 03:14:57 +00:00
Keisuke Kuroyanagi
af1a06d7e1 Enable personalization for multilingual users. 
Bug: 16547557
Change-Id: I03eda34edc902fc4732d16d234216344d8d84d88
 2014-09-10 18:23:09 +09:00
Keisuke Kuroyanagi
89e34169f8 Get locale using detected language for personalization. 
Bug: 16547557
Change-Id: If3d88a548e5a2255ff81c819b056f77bfbe237ae
 2014-09-10 18:23:07 +09:00
Jatin Matani
1c45f9142b Adds StatsUtil methods for LatinIME.on{Start,Create,Finish}inputView 
Change-Id: I4e7dc008b98e398c38aafea5cb31156dde7f42ea
 2014-09-10 15:55:15 +09:00
Mohammadinamul Sheik
97243cea28 Merge "Add backspace event methods to StatsUtils" 2014-09-10 04:56:23 +00:00
Keisuke Kuroyanagi
934e1d8087 Merge "Move case and OOV detection logic into distracter filter." 2014-09-10 03:49:10 +00:00
Keisuke Kuroyanagi
d843081193 Move case and OOV detection logic into distracter filter. 
Bug: 16547557

Change-Id: I8502585976deb5e93fff3b1e0266654b8a927bda
 2014-09-10 11:25:34 +09:00
Mohammadinamul Sheik
acdd2e4572 Add backspace event methods to StatsUtils 
Change-Id: Id45d217073e49ca5f2ba639b608d168d136bba58
 2014-09-10 10:54:49 +09:00
Tadashi G. Takaoka
63ee10d63a am c29276b7: am 12814352: am 486c4894: Keep aspect ratio of Material action key background 
* commit 'c29276b782cfc45be5ab79177e991f2cba8fb04b':
  Keep aspect ratio of Material action key background
 2014-09-09 15:03:15 +00:00
Tadashi G. Takaoka
486c4894ce Keep aspect ratio of Material action key background 
Bug: 15681452
Change-Id: Ie4b823dca541b76b68cade580845a21ff0b21e2f
 2014-09-09 14:28:46 +09:00
Jean Chalard
ef0ef2d0b9 am beb74610: am ab18b5f1: am 9395014e: Don\'t resume suggestions with H/W keyboard 
* commit 'beb746103011149d6dfce10278475946e679263d':
  Don't resume suggestions with H/W keyboard
 2014-09-08 13:52:25 +00:00
Jean Chalard
7140035932 Fix a missing initialization 
Change-Id: I14a35f5a38b6e0f48c95cbb8c0c6e4507cd61fa7
 2014-09-08 22:40:36 +09:00
Jean Chalard
1cf2acd8de am 61e7afa6: am 0eaa25e0: am 914078fd: Fix a bug where recorrection would stop on connectors 
* commit '61e7afa6fa98939f9dcb9f7a2ebb5678a51d4201':
  Fix a bug where recorrection would stop on connectors
 2014-09-08 13:20:27 +00:00
Jean Chalard
9395014e76 Don't resume suggestions with H/W keyboard 
...unless we do support a hardware keyboard, which we still
do not at the moment.

Change-Id: Iec24b1ae8ba5e23e0bbb7e5a468b7404296d4b18
 2014-09-08 22:14:02 +09:00
Jean Chalard
b41ee67194 Fix the sentence separator for Hindi. 
Change-Id: I623e4ccbc324751eb67ec4bb777e2be5ae2a60d1
Bug: 17418371
 2014-09-08 21:54:28 +09:00
Jean Chalard
914078fd91 Fix a bug where recorrection would stop on connectors 
Bug: 16733686
Change-Id: I7a9f79a81e33a1f5bf5f3daf0b78d0f1e4447e7a
 2014-09-08 21:47:01 +09:00
Yohei Yukawa
a48fe12b9c am 42ddc212: am f930ce12: am 1caa0b71: Merge "Follow up API signature changes of CursorAnchorInfo" into lmp-dev 
* commit '42ddc2127deb117a0bb2b7a7797cb8c9ba335f5a':
  Follow up API signature changes of CursorAnchorInfo
 2014-09-08 09:35:00 +00:00
Jean Chalard
653546a618 am c3fac52d: am 1f74ba17: am cb077f75: Merge "Resolve an old TODO." into lmp-dev 
* commit 'c3fac52dd51ba70db83d96b2d421bd440683d9bc':
  Resolve an old TODO.
 2014-09-08 09:34:58 +00:00
Yohei Yukawa
1caa0b714d Merge "Follow up API signature changes of CursorAnchorInfo" into lmp-dev 2014-09-08 09:11:41 +00:00
Jean Chalard
a1d2315499 Merge "Fix a bug with the Greek question mark." 2014-09-08 08:58:27 +00:00
Jean Chalard
cb077f75ac Merge "Resolve an old TODO." into lmp-dev 2014-09-08 08:57:23 +00:00
Yohei Yukawa
a8ecd29646 Follow up API signature changes of CursorAnchorInfo 
This is a follow up CL for Ic8c6fab58c01206872a34e7ee604cdda.

No behavior change is intended in this CL.

BUG: 17365414
BUG: 17335734
Change-Id: I4299536d0cb0c660b7b564653c72c9cb409a7aa5
 2014-09-08 17:07:34 +09:00
Mohammadinamul Sheik
74332597d6 Merge "Add StatsUtils.onPickSuggestionManually and SuggestedWords.indexOf." 2014-09-08 06:52:02 +00:00
Jean Chalard
b526a894db Fix a bug with the Greek question mark. 
Bug: 17398284
Change-Id: If49593e2c959935a183a4cd9d988407cc1160599
 2014-09-08 15:33:51 +09:00
Tadashi G. Takaoka
100a8aec5b am ad4de3fc: am 9ca6658e: am 0f33e614: Implement Floating Action Button more keys keyboard 
* commit 'ad4de3fc819d658775eed470fc74ad76da5caad2':
  Implement Floating Action Button more keys keyboard
 2014-09-08 06:07:52 +00:00
Tadashi G. Takaoka
e1b10aedd7 am 3aabf655: am f21c77d7: am 727e818e: Move more keys divider to MoreKeysKeyboardView 
* commit '3aabf655d0125fb824e5e47687f5084b2df6979c':
  Move more keys divider to MoreKeysKeyboardView
 2014-09-08 05:42:32 +00:00
Tadashi G. Takaoka
0f33e614c0 Implement Floating Action Button more keys keyboard 
Bug: 15681452
Change-Id: I8484e4fe4d989b391f2b5230836dc9dfac218429
 2014-09-08 14:34:33 +09:00
Mohammadinamul Sheik
c74ffe8edc Add StatsUtils.onPickSuggestionManually and SuggestedWords.indexOf. 
Change-Id: I1588448154d086569cb026825fdc36cd1812a582
 2014-09-07 20:43:48 -07:00
Tadashi G. Takaoka
727e818e95 Move more keys divider to MoreKeysKeyboardView 
Bug: 15681452
Change-Id: I1b32719cc927a24db4c41fdeb812b39f7e98a85c
 2014-09-08 11:02:07 +09:00
Tadashi G. Takaoka
8b7ed7f6c6 am 079f9c3f: am 1b430219: am 6888ec00: Merge "Create donottranslate debug settings string resources file" into lmp-dev 
* commit '079f9c3f5ae7b2f7926321522b6020affd422b52':
  Create donottranslate debug settings string resources file
 2014-09-05 17:23:45 +00:00
Jean Chalard
6bb6d30344 Resolve an old TODO. 
This is cleaner.

Bug: 17347779
Change-Id: I5b612783b1ec98a1a11401f00d68db49654f3023
 2014-09-05 20:10:29 +09:00
Jean Chalard
46d111ff4a Merge "Fix a bug where CAPS_WORDS would not be returned." 2014-09-05 09:53:51 +00:00
Jean Chalard
17901db691 Fix a bug where CAPS_WORDS would not be returned. 
Also introduce some unit tests that would have caught the bug.

Bug: 17398284
Change-Id: Idb715b7bd2f70992d6cdf4e25ef368809382caef
 2014-09-05 07:56:25 +00:00
Tadashi G. Takaoka
f0f49f9806 Create donottranslate debug settings string resources file 
This is a follow up of the I26e4d292de.

Bug: 15678343
Bug: 17385083
Change-Id: I2c2b08b8dd991ac981aa8f8c8436de9e4399da5f
 2014-09-05 11:38:29 +09:00
Jean Chalard
78d1dcd356 [ML4] Rename Dictionaries to DictionaryGroup 
We're going to have multiple DictionaryGroup objects and it
would be very confusing to have this class name a plural.

Change-Id: I8f5c621459ede49f245be26097fe71f44289761c
 2014-09-04 18:35:47 +09:00
Tadashi G. Takaoka
964877a8f2 am c297197b: am 1c2cf719: Add new value "spacebar" to Key.backgroundType attribute 
* commit 'c297197b1548307c31017ba3dc89bbb6bbf2223e':
  Add new value "spacebar" to Key.backgroundType attribute
 2014-09-03 17:55:54 +00:00
Tadashi G. Takaoka
e355274642 am ec7d6752: am 5a9c9649: Removes "customAction" value from Key.backgroundType attribute 
* commit 'ec7d67529e0dd4e5bf87e3b96c4b78db44adb96f':
  Removes "customAction" value from Key.backgroundType attribute
 2014-09-03 17:55:53 +00:00
Tadashi G. Takaoka
6a4e9218ca am 2a7a5740: am 0af2472a: Add new "keyboardTheme" <case> predicator 
* commit '2a7a5740e929503a0aca23f376175a9c118b7a83':
  Add new "keyboardTheme" <case> predicator
 2014-09-03 17:55:52 +00:00
Yohei Yukawa
5d7b24f29c am f2c509a8: am 310da35c: Merge "Follow up API signature change" into lmp-dev 
* commit 'f2c509a81ef107e6c71dc6804417469d12c94fca':
  Follow up API signature change
 2014-09-03 17:41:46 +00:00
Yohei Yukawa
f618f351fe am 6e29bf56: am 8c42bf54: Follow API signature change in CursorAnchorInfo 
* commit '6e29bf56c680331a7d1a50be38212c1356cb584d':
  Follow API signature change in CursorAnchorInfo
 2014-09-03 17:41:43 +00:00
Tadashi G. Takaoka
1c2cf71921 Add new value "spacebar" to Key.backgroundType attribute 
Bug: 17318036
Change-Id: Ie84438a6aa3adc14a9db603d0cd4d5e37a55d612
 2014-09-03 23:37:03 +09:00
Tadashi G. Takaoka
5a9c9649db Removes "customAction" value from Key.backgroundType attribute 
Bug: 17318036
Change-Id: I6a36d50ba2e69eafbb0faa049014281bd4d4ddfc
 2014-09-03 23:35:39 +09:00
Tadashi G. Takaoka
0af2472a69 Add new "keyboardTheme" <case> predicator 
Bug: 17318036
Change-Id: Ief386c84969d8646fb5cfe2050a2f59a7db16c88
 2014-09-03 23:26:46 +09:00
Jatin Matani
972003428b Merge "Attempt retry for broken dictionaries" 2014-09-03 08:56:38 +00:00
Yohei Yukawa
5d6ac77732 Follow up API signature change 
This is a follow up CL for API signature change in
I772c48ff18918e48a81e807b48ff907614485c09

BUG: 17320996
Change-Id: Ic8b6162bda12bf74fae79af212c5d81c400eb9e8
 2014-09-03 01:13:15 -07:00
Jatin Matani
256b1b2a1e Attempt retry for broken dictionaries 
1. Add retry count column within metadata in dictionary pack.
2. Attempt a retry for download and installation by running StartDownloadAction.
3. If the number retrial are at the threshold, we don't attempt it again.

Bug: 15150487
Change-Id: I70720353e5803fccf4728c2aa798883ba75c61e5
 2014-09-03 17:11:06 +09:00
Yohei Yukawa
8c42bf54af Follow API signature change in CursorAnchorInfo 
This is just a follow up CL for Ia8cbb9f6b41cd9509fc0147fd68763df.
No behavial change is intended.

BUG: 17200900
Change-Id: Iba23b731ebde64ec2e816c5b4bef1d93632fce1e
 2014-09-02 16:29:35 -07:00
Tadashi G. Takaoka
d27af1a5d4 am 3ad86d91: am afa9d6d8: Merge "Add theme aware key popup preview animation" into lmp-dev 
* commit '3ad86d91f1e3d251635303e0fb9a83dce22efa3a':
  Add theme aware key popup preview animation
 2014-09-02 17:44:10 +00:00
Tadashi G. Takaoka
ac88f3d845 Add theme aware key popup preview animation 
Bug: 15678343
Change-Id: I26e4d292deab37724387cc9ebc03033fcd698c60
 2014-09-02 18:45:23 +09:00
Jean Chalard
a341e7d244 Merge "[ML3] Put the locale in SuggestedWordInfo" 2014-09-02 06:40:59 +00:00
Jean Chalard
c0d3123930 Merge "[ML2] Small refactoring" 2014-09-02 06:40:51 +00:00
Jean Chalard
576c96af95 [ML3] Put the locale in SuggestedWordInfo 
...and remove it from SuggestionResults.

Change-Id: Iae85ec7e82e2caf18cc6d7656aa46dc150707cdd
 2014-09-01 20:09:32 +09:00
Jean Chalard
146cb98e54 [ML2] Small refactoring 
Change-Id: I1283d666b8904ff4e6c012332bdbc9c0c13df415
 2014-09-01 20:09:24 +09:00
Jatin Matani
962c40d326 Merge "StatsUtilsManager should be initiated(#onCreate) before loadSettings." 2014-09-01 08:27:19 +00:00
David Faden
95b7bd3ba5 Add a private IME option to suppress the gesture floating preview text. 
If the option defined by Constants.NO_FLOATING_GESTURE_PREVIEW is set
for a text field via EditorInfo.privateImeOptions, the floating gesture
preview will be suppressed regardless of the settings preference.

Feature request:
bug: 17325039

Change-Id: I1a1df194369e8f2d76abd9d84939a057f55f4a1c
 2014-09-01 03:59:38 +00:00
Keisuke Kuroyanagi
dec2c2d910 Merge "Support multiple locales in distractor filter." 2014-09-01 03:27:35 +00:00
Jatin Matani
aa223400c3 StatsUtilsManager should be initiated(#onCreate) before loadSettings. 
Change-Id: I9002b4afb023e55ab251ea070ec0b7a6ace99261
 2014-08-29 15:51:57 -07:00
Tadashi G. Takaoka
f5960b4f62 am 034a4a5a: am c4710124: Merge "Fix the order of keys on more keys keyboard" into lmp-dev 
* commit '034a4a5a19ba37dba8999b3763ae756fe748deaf':
  Fix the order of keys on more keys keyboard
 2014-08-29 19:07:06 +00:00
Tadashi G. Takaoka
2d713c87c6 am 2fabd50d: am f507d1fe: Support RTL layout in custom input style settings 
* commit '2fabd50df49f894afde15ac5f4ebd2ff5372a9c4':
  Support RTL layout in custom input style settings
 2014-08-29 19:07:04 +00:00
Jean Chalard
78bb2dd945 am 3bd8eee3: am 4e28a6a8: Fix an IOOB exception 
* commit '3bd8eee3e8c3e89539578a4231661819de65c804':
  Fix an IOOB exception
 2014-08-29 19:07:03 +00:00
Tadashi G. Takaoka
f9af39e53e am 727cd740: am f2eadbb4: Clear keyboard cache when system locale is changed 
* commit '727cd74072d97af334fe8c0d18fa6a1e23629ccb':
  Clear keyboard cache when system locale is changed
 2014-08-29 19:07:02 +00:00
Keisuke Kuroyanagi
fdaedb6c1d Support multiple locales in distractor filter. 
Bug: 16547557
Change-Id: I4aba278eb4114e0075f3f8b38c7e132743927fa8
 2014-08-29 22:29:30 +09:00
Keisuke Kuroyanagi
9eec97d5b0 Merge "Use DictionaryFacilitatorLruCache for personalization." 2014-08-29 10:10:40 +00:00
Tadashi G. Takaoka
c471012483 Merge "Fix the order of keys on more keys keyboard" into lmp-dev 2014-08-29 09:58:28 +00:00
Tadashi G. Takaoka
f507d1febb Support RTL layout in custom input style settings 
Bug: 17322353
Change-Id: I3b211ab8729121271563a8a243558a58ee7847c2
 2014-08-29 18:28:53 +09:00
Jean Chalard
4e28a6a844 Fix an IOOB exception 
Bug: 17316001
Change-Id: Iaa2cfd30ebbe0d49e10a5c3a30336e06817d0a8b
 2014-08-29 06:56:34 +00:00
Keisuke Kuroyanagi
e59f3e4fbf Use DictionaryFacilitatorLruCache for personalization. 
Bug: 16547557

Change-Id: I5faba5e26d072b49c0fffcaeaf5062f9e0c2dcc0
 2014-08-29 12:57:50 +09:00
Tadashi G. Takaoka
a9fc8622fe Fix the order of keys on more keys keyboard 
This CL fixes the behavior of !autoColumnOrder!<n> flag in a more keys
specification. Formerly the <n> value specifies the maximum number of
column of more keys. With this CL, the <n> value specifies the exact
number of column of more keys.

Bug: 16603887
Change-Id: I2120620fa512ee30043bb146ad675a942a375129
 2014-08-29 11:06:20 +09:00
Jatin Matani
aabb351279 Refactor StatsUtils into two components:StatsUtils & StatsUtilsManager 
Bug:16522256
Change-Id: I9cb8129c552159cf17ea5c2656e0988bf0f999f5
 2014-08-28 17:28:23 -07:00
Tadashi G. Takaoka
f2eadbb497 Clear keyboard cache when system locale is changed 
Bug: 17310080
Change-Id: I2b388772f269f1e7610a5bd32de80793da2df16e
 2014-08-28 22:50:07 +09:00
Jean Chalard
98e56c6905 am 3ef26ac1: am 6bd267f4: Merge "Add new attributes to our notification" into lmp-dev 
* commit '3ef26ac13b677bc8d7adeed378ce6d6cbad171ee':
  Add new attributes to our notification
 2014-08-28 09:52:03 +00:00
Jean Chalard
a2928484f6 Add new attributes to our notification 
Bug: 17167221
Bug: 17128331
Change-Id: I6a045fd2398f40dbdc10c9d20993f7513e1f2cff
 2014-08-28 07:47:07 +00:00
Jean Chalard
f95770354c Straighten the dead char implementation, take 3. 
Change-Id: I4f70f6eebe076c7d2b780d25e3a2c1d3faa2edfa
 2014-08-28 16:03:45 +09:00
Keisuke Kuroyanagi
b85349e981 Merge "Create DictionaryFacilitatorLruCache." 2014-08-28 03:09:28 +00:00
Yohei Yukawa
af5c2b24e7 am 8d0d2363: am acce1aa5: Make sure to obtain the IC before requesting CursorAnchorInfo 
* commit '8d0d236394548be4e2302a03960ce4ee363a5483':
  Make sure to obtain the IC before requesting CursorAnchorInfo
 2014-08-27 23:41:33 +00:00
Yohei Yukawa
acce1aa59e Make sure to obtain the IC before requesting CursorAnchorInfo 
RichInputConnection#requestUpdateCursorAnchorInfo must make
sure to obtain the input connection before calling methods
of it.

BUG: 17299587
Change-Id: I8e0cd473a4cc32583cd47634c227d702f7c69c6c
 2014-08-27 15:59:52 -07:00
Ken Wakasa
95c4d26994 Merge "Revert "Straighten the dead char implementation."" 2014-08-27 15:07:52 +00:00
Ken Wakasa
0ba6bcb16d Revert "Straighten the dead char implementation." 
This reverts commit 5ef447aeea.

Reverting because this broke a bunch of unit tests -- https://sponge.corp.google.com/target?id=b6439742-099e-46cb-8f00-d0c602a4d9bb&target=com.google.android.inputmethod.latin.tests&searchFor=&show=FAILED&sortBy=STATUS

Change-Id: Ibbd9e11372993f62e630fd9da37158ffcf47c17a
 2014-08-27 15:07:28 +00:00
Keisuke Kuroyanagi
d267764d5a Create DictionaryFacilitatorLruCache. 
This class is separated from AndroidSpellCheckerService

Bug: 16547557

Change-Id: I3e58521207395588cecb2977234b89067d6da8c3
 2014-08-27 22:00:48 +09:00
Jean Chalard
4204d59864 Merge "Straighten the dead char implementation." 2014-08-27 12:54:49 +00:00
Tadashi G. Takaoka
8b5788d72b am 68a2a69a: am 37beaf15: Simplify onComputeInsets of LatinIME 
* commit '68a2a69ae35352650a4c6dfc0b0c69069c4a1e1d':
  Simplify onComputeInsets of LatinIME
 2014-08-27 10:44:51 +00:00
Tadashi G. Takaoka
37beaf1529 Simplify onComputeInsets of LatinIME 
This CL expands SoftInputWindow to the entire screen. Thus a key
review backing view is eliminated and onComputeInsets() gets
simplified too.

Bug: 17212702
Bug: 10841052
Bug: 10541453
Change-Id: I2d859f4e4698c64cabe399000821f13bab729996
 2014-08-27 19:20:38 +09:00
Yohei Yukawa
00042cb453 am c925ca43: am 97681ebd: Set highlight color along with the commit indicator 
* commit 'c925ca43a6e0b3175feb002ce6b5577ef7d66507':
  Set highlight color along with the commit indicator
 2014-08-27 10:01:24 +00:00
Ken Wakasa
6da1c674fd resolved conflicts for merge of 8159336b to master 
Change-Id: I9dd726593c6768b1db35305935ee69b0937358ef
 2014-08-27 18:55:39 +09:00
Ken Wakasa
c1596086d3 resolved conflicts for merge of 0268f736 to master 
Change-Id: Ib89ef55a8752f9b5e357eed3a05c79dd28d0ec0e
 2014-08-27 18:41:31 +09:00
Jean Chalard
5ef447aeea Straighten the dead char implementation. 
This now supports all cases, including cases not supported by
the framework.
Now rebased on top of the right change, and renamed

Change-Id: I7886f0dcbb86cdb4dccec09aa7c52ad339680e04
 2014-08-27 17:59:39 +09:00
Yohei Yukawa
97681ebdf1 Set highlight color along with the commit indicator 
With this CL, the text highlight color is applied
when the commit indicator is displayed.

Note that the underline is not rendered when the
background color is enabled. This is a known issue.

Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
 2014-08-27 01:41:16 -07:00
Yohei Yukawa
29200b0abe Set the text bgcolor only when CursorAnchorInfo is available 
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.

With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not.  This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.

Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
 2014-08-27 01:30:45 -07:00
Yohei Yukawa
a475c85480 Introduce a mechanism to hide the indicator speculatively 
This is an optional optimization to reduce the UI latency.

Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.

If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.

This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.

Change-Id: Id59c6607a1029782410611e768791af9984f14ac
 2014-08-26 23:42:53 -07:00
Yohei Yukawa
bea17c49ec Introduce commit/add-to-dictionary indicators 
This CL introduces commit/add-to-dictionary indicators.

Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.

Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
 2014-08-26 21:20:27 -07:00
Ken Wakasa
4660ecaa44 Merge "Fix a bug where mic/emoji key wouldn't work." 2014-08-26 13:30:15 +00:00
Jean Chalard
e38043849e Fix a bug where mic/emoji key wouldn't work. 
Bug: 17272902
Bug: 17269948
Change-Id: I561609fa84a6265f8148db7d2411bc1fd38dd163
 2014-08-26 22:06:21 +09:00
Jean Chalard
96522da9eb am 2a2d324e: am 8380f921: Fix a bug where the top prediction would disappear. 
* commit '2a2d324eb627807a9d09b491fbb4ac78ffb253fc':
  Fix a bug where the top prediction would disappear.
 2014-08-26 12:37:17 +00:00
Jean Chalard
8380f921f7 Fix a bug where the top prediction would disappear. 
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.

Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
 2014-08-26 20:35:59 +09:00
David Faden
9cf69a45b2 Adds documentation for a few methods. 
Change-Id: I6bdae25a8b81cdac931f2591f33570b01e34fb2c
 2014-08-26 08:08:24 +00:00
Keisuke Kuroyanagi
bf6fc4953b Merge "Get dynamic dict stats via DictionaryFacilitator" 2014-08-25 11:24:54 +00:00
Yohei Yukawa
d8dfac6dcb am abf05cc0: am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev 
* commit 'abf05cc0da1ead7e270a7c99bf9f000dabf91f5b':
  Use more descriptive names for some internal fields
 2014-08-25 10:16:11 +00:00
Jean Chalard
1a31d784cd Merge "Introduce onEvent() to improve testability" 2014-08-25 09:57:42 +00:00
Yohei Yukawa
fdfe73ff1f Merge "Use more descriptive names for some internal fields" into lmp-dev 2014-08-25 09:50:59 +00:00
Tadashi G. Takaoka
d147db8763 am c500700f: am 19dd34a0: Show view even when IME is explicitly shown with physical keyboard 
* commit 'c500700faec11b7a6d54a821009be4d657c43394':
  Show view even when IME is explicitly shown with physical keyboard
 2014-08-25 09:35:08 +00:00
Yohei Yukawa
a61b7245b0 Use more descriptive names for some internal fields 
This CL clarifies that delay parameters are specified with
milliseconds.

Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
 2014-08-25 02:28:01 -07:00
Jean Chalard
ee8ebeecbf Merge "Fix unit tests" 2014-08-25 09:26:17 +00:00
Jean Chalard
dc110b2a6a Fix unit tests 
Change-Id: I48bfa4e4dd80f36d2fe0a1e9d2a2706533cc722e
 2014-08-25 18:19:00 +09:00
Tadashi G. Takaoka
7defe926ca am 4a782da3: am f145fff0: Merge "Fix NPE when pressing ALT key" into lmp-dev 
* commit '4a782da382b83164ea5c23c771b771e73bbe31b3':
  Fix NPE when pressing ALT key
 2014-08-25 08:25:42 +00:00
Yohei Yukawa
4587b135be am 2d508203: am 8681287c: Fix build due to an illegal character 
* commit '2d508203c64f50ed47fb87c24ae5ebbfb0610a36':
  Fix build due to an illegal character
 2014-08-25 08:25:35 +00:00
Yohei Yukawa
8c7daa829a am 02716083: am 5eebaddc: Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev 
* commit '02716083158c3affbcfc719ff6471112d7397578':
  Dismiss "Add to dictionary" hint with non-special char event
 2014-08-25 08:25:34 +00:00
Yohei Yukawa
a5687ee9f7 am b65a1e46: am 2c4cce8d: Merge "Introduce #shouldShowAddToDictionaryHint" into lmp-dev 
* commit 'b65a1e46ce06adc462dfc4cbde302ac27a79b695':
  Introduce #shouldShowAddToDictionaryHint
 2014-08-25 08:25:33 +00:00
Yohei Yukawa
f6f55add17 am e0d00803: am 4a71d2c4: Allow to add/remove background color to/from the committed text 
* commit 'e0d00803087ac2f873332d43a78453c068633545':
  Allow to add/remove background color to/from the committed text
 2014-08-25 08:25:31 +00:00
Yohei Yukawa
c06c6e42ad am 7d146cdb: am cd6ef9a8: Indroduce SuggestedWords#getTypedWordInfoOrNull 
* commit '7d146cdbe86692f153fb5b7f781f701a8c04050d':
  Indroduce SuggestedWords#getTypedWordInfoOrNull
 2014-08-25 08:25:24 +00:00
Jean Chalard
908f0ed154 Introduce onEvent() to improve testability 
...and prepare for the future

Change-Id: Ieed96ab552993fd148e80b9c3355f1b569bd716f
 2014-08-25 16:33:47 +09:00
Tadashi G. Takaoka
19dd34a023 Show view even when IME is explicitly shown with physical keyboard 
Bug: 17242477
Bug: 13988700
Change-Id: I519c0481760a9aa93a5d9bee68e0f6a3a8fc4d9d
 2014-08-25 16:28:44 +09:00
Tadashi G. Takaoka
f145fff085 Merge "Fix NPE when pressing ALT key" into lmp-dev 2014-08-25 06:52:36 +00:00
Keisuke Kuroyanagi
9cbf814cb5 Get dynamic dict stats via DictionaryFacilitator 
Bug: 16553957
Change-Id: Ida08ceaf34708daed52d61b3d5adfbdb48e42c71
 2014-08-25 15:19:48 +09:00
Tadashi G. Takaoka
ad1f880811 Fix NPE when pressing ALT key 
Bug: 17203708
Change-Id: I4f203603496e9401dacba4db21372e3353916418
 2014-08-25 15:08:27 +09:00
Jean Chalard
dc44260484 Merge "Revert "Revert "[ML1] Introduce RichInputMethodSubtype""" 2014-08-25 05:24:28 +00:00
Jean Chalard
85ddfe1317 Revert "Revert "[ML1] Introduce RichInputMethodSubtype"" 
This reverts commit a63d0a8ee6.

This patch seems to be fine after all, but was submitted without its companion [ML1.1] patch causing a build breakage. Reverting the revert and submitting both at the same time seems like the right thing to do.

Change-Id: Ib8fefa40b74dcee0edb025a52dac9b35c82d49df
 2014-08-25 04:42:15 +00:00