nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
8229 commits 1 branch 0 tags 363 MiB
Commit graph

2636 commits

Author SHA1 Message Date
Tadashi G. Takaoka
adc80eef15 Use Keyboard.getKey 
Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
 2012-07-04 16:31:57 +09:00
Tadashi G. Takaoka
040aa28ed4 Merge "Get rid of redundant CharSequence member from SuggestedWordInfo" 2012-07-04 00:27:07 -07:00
Tadashi G. Takaoka
f3897fb54e Get rid of redundant CharSequence member from SuggestedWordInfo 
Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
 2012-07-04 16:04:59 +09:00
Jean Chalard
c5e911c06b Consolidate a method inside another (A45) 
It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.

This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.

Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
 2012-07-04 11:51:51 +09:00
Jean Chalard
f72b8f5662 Move the safety net function to AutoCorrection (A44) 
Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
 2012-07-04 11:51:46 +09:00
Jean Chalard
accd63f35f Merge "Refactoring (A43)" 2012-07-03 19:40:19 -07:00
Jean Chalard
b87b23eb75 Merge "Remove useless code (A42)" 2012-07-02 18:56:41 -07:00
Jean Chalard
6547f43666 Merge "Clarify some code and fix a bug (A41)" 2012-07-02 18:52:56 -07:00
Jean Chalard
d6496c0913 Merge "Fix a bug with the user dictionary locale." 2012-07-02 02:57:50 -07:00
Jean Chalard
d113fd0be4 Fix a bug with the user dictionary locale. 
We internally use the string "zz" to mean no locale, but
the user dictionary service does not understand that and
words added with this locale pitifully end being added to
a "zz" user dictionary, which makes no sense to the user.
This change fixes things so that words added when the
keyboard is in a "no locale" layout, the words are added
to the global, all-locales user dictionary.

Bug: 6645306
Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
 2012-07-02 17:14:47 +09:00
Jean Chalard
4ca05e2474 Refactoring (A43) 
Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
 2012-07-02 15:46:11 +09:00
Jean Chalard
7ad088a4cf Remove useless code (A42) 
If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !

Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>

Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
 2012-07-02 15:46:08 +09:00
Jean Chalard
90d300c770 Clarify some code and fix a bug (A41) 
The test against hasMainDictionary is a test to know if we should
auto-correct or not. Its result should be recorded in
hasAutoCorrection, not in allowsToBeAutoCorrected.

Actually, this value being inserted in allowsToBeAutoCorrected was
causing a bug that nobody noticed: when typing in a language with
no dictionary, the word in the middle of the suggestion strip would
always be bold, as if it was going to auto-correct to itself !
This change fixes this bug.

Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
 2012-07-02 15:46:03 +09:00
Jean Chalard
2631e3b195 Small refactoring (A39) 
Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea
 2012-07-02 15:45:58 +09:00
Jean Chalard
79f5317848 Match calls for future consolidation (A38) 
Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9
 2012-07-02 15:45:54 +09:00
Jean Chalard
cd288620ea Make the autocorrection scheme more straightforward (A37) 
Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd
 2012-07-02 15:45:34 +09:00
Jean Chalard
aba432bf8d Remove a duplicate method (A36) 
Bug: 6705473
Change-Id: Ib6260034b09739b60071e90a018b2dc6be3815d7
 2012-07-02 12:12:16 +09:00
Jean Chalard
84074cf503 Update log and make a variable private (A35). 
Change-Id: Ib4a8f41dc5941bce46402e1a41a6c21dccb0601f
 2012-07-02 12:11:27 +09:00
Jean Chalard
1842fbba93 Remove old debug code that has been long broken (A34) 
Change-Id: I9b5a0e34529724984aad1e2bf99b3e00f8ed0dd7
 2012-06-29 19:47:00 +09:00
Satoshi Kataoka
105069a15f Merge "Add input pointers" 2012-06-29 03:03:01 -07:00
Satoshi Kataoka
71538b08e4 Add input pointers 
Change-Id: I95300bf0a847fb86d026e846ff4ad723bb45284f
 2012-06-29 18:58:51 +09:00
Jean Chalard
1b2e2d893d Add a more synthetic variable (A33) 
The goal here is to disambiguate TypedWordValid and
HasAutoCorrectionCandidate. Ultimately, HasAutoCorrectionCandidate
will disappear.

Bug: 6705473
Change-Id: I1acbd0a5efc7f4bf7b0bdb12839fe3d84e9d1dda
 2012-06-29 17:00:57 +09:00
Jean Chalard
9011b89f4e Remove cruft (A32) 
Change-Id: I35c2ba4caf6be4ba0449e11c0597ae8e468c0e6e
 2012-06-29 17:00:57 +09:00
Jean Chalard
2cda148fd5 Simplification (A31) 
Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
 2012-06-29 17:00:57 +09:00
Jean Chalard
deb2d88245 Small refactoring (A30) 
Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
 2012-06-29 17:00:57 +09:00
Jean Chalard
0a63111821 Remove a useless parameter (A29) 
Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
 2012-06-29 17:00:56 +09:00
Jean Chalard
4f444410f2 Remove a useless variable (A28) 
Change-Id: I1058123d233540fb72a94028987a43740224f635
 2012-06-29 17:00:56 +09:00
Jean Chalard
f4267c0521 Fix a small bug (A27) 
TypedWordValid and AllowsToBeAutoCorrected are almost the
same thing; the difference is whether the word is also a
whitelist entry or not. In this case, TypedWordValid was
the right one to test.

Change-Id: I695fe5b9f6bbe9d3ba314c646da3a25742c9f4ed
 2012-06-29 17:00:56 +09:00
Jean Chalard
9e0af57736 Optimization (A26) 
Change-Id: I1d7790289635729645995fb8c38868259ab1b3be
 2012-06-29 17:00:56 +09:00
Jean Chalard
7a94cbd2a4 Remove useless code (A25) 
isWhitelistedOrNotAWord takes an 'ignoreCase' argument. By looking
at the contents of the wordcomposer here, there is only one case
where its output will be different : when the word is typed with a
capital, but the lower case version exists in the dictionary.
E.g. the user typed "This".

In this case, isWhitelistedOrNotAWord in line 235 will return false
instead of true, so the test will score a true instead of a false,
so hasAutoCorrection may be true instead of false in this specific
case and that's the only case where it's different.

But in this case, allowsToBeAutoCorrected is certain to be false,
which means the result will not have changed if hasAutoCorrection
was true in the first place. So in the end this change is sure not
to change the behavior.

Change-Id: Ic41cf959c20c19165f84d9b8ff006731fa595d84
 2012-06-29 16:57:56 +09:00
Jean Chalard
b3cfde2cbb Add a few comments for future reference (A24) 
Change-Id: Ia356130b8a95ec9cf676bc6be05d801c13f14b64
 2012-06-29 15:45:27 +09:00
Jean Chalard
e398c6c024 Rename a method for readability (A23) 
Change-Id: I6f569322e645d36bc82fddf4ec2fd621972e3b47
 2012-06-29 15:45:24 +09:00
Jean Chalard
ea578f6b1d Revert a test for readability (A22) 
Change-Id: I1df4cef5ae2736a22273843dce67f0012181bfd3
 2012-06-29 15:44:55 +09:00
Jean Chalard
19d02c19d0 Remove a useless variable (A21) 
Change-Id: I901e6b0e2b994128da19d68233b9f68bb308cb95
 2012-06-29 15:44:17 +09:00
Jean Chalard
4d5e7235c5 Remove a useless variable (A20) 
Change-Id: Ifc37462f5243563693c8cd7cbeb401ff054daa52
 2012-06-29 15:12:51 +09:00
Jean Chalard
739683dcfb Rename a method for readability (A19) 
Change-Id: I0b8c06d1fd0bfb3caf363c048acc7048abed1752
 2012-06-29 15:12:51 +09:00
Jean Chalard
31b346aac6 Remove a useless test (A18) 
allowsToBeAutoCorrected always returns false if the word is empty.
This is because the whitelist never contains an empty string,
and isValidWord returns false if the word is empty.

Change-Id: I34ecc2a1563aea6db5b2f12796f251f6598576a2
 2012-06-29 15:12:51 +09:00
Jean Chalard
b01cdb975a Inline a method (A17) 
This will allow us to remove unnecessary processing

Change-Id: I251dfdaffb077906186686ebe65fd82e1e360bd2
 2012-06-29 15:12:51 +09:00
Jean Chalard
42dde06782 Make a function a one-liner (A16) 
...to better inline it

Change-Id: I88496b8f18b81f0c05e4bbf2d1039de1f93e0c25
 2012-06-29 15:12:51 +09:00
Jean Chalard
a96a11949f Inline a simple method (A15) 
Change-Id: Ib74fcbf33c680bf02c39a9896e30e3afbcfd149a
 2012-06-29 15:12:51 +09:00
Jean Chalard
074c90af98 Inline a method (A14) 
The new code is worse than the old one, but this is a necessary
step to make things prettier.

Change-Id: If6e8a139bb85e6920c749743c78792a22a8acb45
 2012-06-29 15:12:51 +09:00
Jean Chalard
1333579b4b Don't special-case 1-letter words (A13) 
There is no reason to prevent 1-letter words to auto-correct
to themselves, or to dictionary words. Don't do it.

Change-Id: Iceada847ae632336026ada29afed0353cd9c51b5
 2012-06-29 15:12:51 +09:00
Jean Chalard
d426941ee8 Fix a theoretical bug (A12) 
If a word is a dictionary word but still has no suggestion,
this method should return true. In the practice, it makes
no difference since a word without suggestion won't be changed
anyway.

Change-Id: Ib1f5ef254b7da7e5cedb2f973529ad431beb93f9
 2012-06-29 15:12:51 +09:00
Jean Chalard
9701b360d9 Rename a terribly-named method for clarity (A11) 
Change-Id: Id180000404dc6929d80f98c0e9cd2026230ad2d1
 2012-06-29 15:12:50 +09:00
Jean Chalard
6b911c27a3 Merge "Small readability improvement (A10)" 2012-06-28 23:11:23 -07:00
Jean Chalard
f89a75134b Small readability improvement (A10) 
Change-Id: Iba326921711e1c4eab38264e66b6b44a64fec398
 2012-06-29 15:05:08 +09:00
Jean Chalard
305326e789 Refactoring and add debug prints (A9) 
Change-Id: I46497bff107f0def0dfa2b043b20d9a0b0cde040
 2012-06-29 14:24:54 +09:00
Jean Chalard
5110e2cb51 Optimization (A8) 
Change-Id: I2b9e8cc6a13fd9af84a5189e4d3fbb2b05c68d46
 2012-06-29 12:54:11 +09:00
Jean Chalard
4847a27f74 Cleanup (A7) 
Change-Id: Iba97e0062b702c005ab3ff9ce59f181d19ab7c98
 2012-06-28 19:13:16 +09:00
Jean Chalard
ed83d4b143 Stop special-casing a single suggestion (A6) 
Treat it like the others

Change-Id: Ic24e40ada0e75773c3ece9470ab61c350697be5d
 2012-06-28 19:12:37 +09:00
Jean Chalard
251bb70f08 Cleanup (A5) 
Change-Id: I06134145b47c46bbc6c340ca539f34a01e2ca163
 2012-06-28 19:12:37 +09:00
Jean Chalard
4c4e3a0949 Transform the whitelist suggestion like the others (A4) 
...instead of having a different code path

Change-Id: Icd177e2151e45d25300000d4b63d4fba1f52b6a8
 2012-06-28 19:10:32 +09:00
Jean Chalard
33b3805e79 Small refactoring (A3) 
This will help make upcoming changes clearer

Change-Id: Ida8d4935f7315e5da6007ad364124694da3112d0
 2012-06-28 19:10:24 +09:00
Jean Chalard
b7cdafd78a Don't pass everything to a function that needs only the head (A2) 
Change-Id: Ic367836202ab8071c1a9a02eaf0651b0da947d51
 2012-06-28 19:10:13 +09:00
Jean Chalard
09b30ac954 Merge "Use a TreeSet to sort suggestions instead of doing it by hand (A1)" 2012-06-28 03:08:26 -07:00
Jean Chalard
2d2e348033 Use a TreeSet to sort suggestions instead of doing it by hand (A1) 
Change-Id: I16ba39321107e87ad48a99c2410a15995a66f23c
 2012-06-28 18:54:14 +09:00
Tadashi G. Takaoka
69527d4d60 am 5e5cf045: am 7f7947c9: Keep subtypes in method.xml the same as pre-JellyBean 
* commit '5e5cf045ca6debafcc29ae1c47afda4a3a152326':
  Keep subtypes in method.xml the same as pre-JellyBean
 2012-06-27 21:58:53 -07:00
Tadashi G. Takaoka
7f7947c97b Keep subtypes in method.xml the same as pre-JellyBean 
This change prevents Android Keyboard subtypes being mistakenly
disabled when upgrading from pre-JellyBean to JellyBean.

Bug: 6750906
Change-Id: I05de6c512e7aa17356e415476e5248986c7d4253
 2012-06-28 13:44:09 +09:00
Jean Chalard
10abf10c1f Convert local members to local variables 
Change-Id: I852787986c79502a4de7effe9c8281a4cf2d519d
 2012-06-27 19:54:29 +09:00
Jean Chalard
3ecb2747b3 Optimization. 
It's useless to do this for all suggestions including those
that will be ousted from the list.

Change-Id: I7bd63d783e21984a269e4b1ae17e9b9d8c0859e3
 2012-06-27 18:55:43 +09:00
Jean Chalard
3705ef407b Read the suggestion type from the suggestion 
...instead of dirtily passing it from the dictionary loop

Change-Id: I92ddbd7451609b69f6d4dc31bf89d614423b2016
 2012-06-27 18:18:35 +09:00
Jean Chalard
24eec0fa68 Remember the source dictionary for each suggestion. 
Change-Id: I3c63372bd5572a479a67eaecfe8c8ea1cabc70d9
 2012-06-27 18:17:28 +09:00
Jean Chalard
d8f0caa406 Move constants to a better place. 
Change-Id: I5c27a3ed99b17f850e26a8503de16f001c7111c1
 2012-06-27 18:08:08 +09:00
Jean Chalard
089c11a086 Cleanup 
Change-Id: I575f22330bf6881af1d9a35f22b51b7bf2198113
 2012-06-27 17:59:58 +09:00
Jean Chalard
b5afd3de0c Remove unused stuff. 
Change-Id: Ifd0d5b6978f76b841574a6e10157c32d0cd656b6
 2012-06-27 17:44:16 +09:00
Jean Chalard
05efe576f9 Cleanup the dictionary type. 
Stop storing an int in each of the different class types, and
just store a string in the top class.

Change-Id: I2af1832743e6fe78e5c1364f6d9cc21252bf5831
 2012-06-27 17:31:09 +09:00
Jean Chalard
c356df8e08 Merge "Update the prototype of onAddSuggestedWord - calling side." 2012-06-27 01:25:59 -07:00
Ken Wakasa
e55c23e4b0 Small cleanups 
Change-Id: Ic1a198ab1b4f0323fde9e4245729fd0e6011b914
 2012-06-27 16:54:37 +09:00
Jean Chalard
32ff2504a0 Update the prototype of onAddSuggestedWord - calling side. 
We want to get rid of all those IDs in Latin IME.

Change-Id: Ibe08100a5e2976c80abb049889233b4047a686f3
 2012-06-27 16:17:14 +09:00
Jean Chalard
2db27bcd06 Merge "Use binarySearch instead of a hand-written linear search" 2012-06-26 23:55:46 -07:00
Jean Chalard
78a8d5b6bc Merge "Implement a comparator for SuggestedWordInfos." 2012-06-26 22:55:51 -07:00
Jean Chalard
56beb9e321 Use binarySearch instead of a hand-written linear search 
Yay.

Change-Id: Icf686eb2d675da959f19edc856b521e6288dcea3
 2012-06-27 14:17:29 +09:00
Jean Chalard
9da0027b38 Implement a comparator for SuggestedWordInfos. 
Change-Id: Ic4b0ae05cd98a1aec5806c5e4b744158e73aea7a
 2012-06-27 14:16:23 +09:00
Kurt Partridge
30447239e8 Merge "only output every kth word to log" 2012-06-26 20:49:03 -07:00
Jean Chalard
4ef01c51f8 Merge "Remove some special casing" 2012-06-26 20:33:43 -07:00
Kurt Partridge
e961188e9f only output every kth word to log 
multi-project CL with Ib5b544b9b2d8b0e4419238976b2e274e5ac564f8

Bug: 6188932
Change-Id: Iea68cf36924d6fda126130a98431a6ce02ba251e
 2012-06-26 16:15:20 -07:00
Jean Chalard
7e49a2b6b8 Remove some special casing 
This special casing is useless. If the word is the same as what
user typed, the scoring algorithm already ensures that it comes
out at the top. Actually, as is written in a comment here, code
executed later is actively relying on this suggestion having
the top score ! There is no need to test it for equalness and
inserting it at the top then.

Change-Id: I263a6de59b77ec72a2dcbb933361b8e16fca0681
 2012-06-26 20:40:42 +09:00
Jean Chalard
a3f5f51ec4 Fix a bug where a log would mysteriously not work 
Change-Id: I5ca77ed65e95a6d357215c0e730238fb463986bb
 2012-06-26 20:36:51 +09:00
Jean Chalard
22657dcba0 Optimization. 
We already had that computed

Change-Id: I2a9742eaee2e9db1f73aeddda7bae7e237b4d15c
 2012-06-26 20:02:07 +09:00
Jean Chalard
ec8b27fe49 Cut out a method for clarity 
Change-Id: I1dc668698a5cd840297e713a26a525f5e32d35d6
 2012-06-26 19:49:01 +09:00
Jean Chalard
5953dc93cf Avoid string conversions when possible. 
Change-Id: Ibf5f3e40da55998364d0d835ecf283f32c80fcf5
 2012-06-26 19:45:52 +09:00
Jean Chalard
bed514bd90 Simplify a method call. 
Change-Id: Ieede787a13cef79353f13af52488ef3732ac9850
 2012-06-26 19:33:16 +09:00
Jean Chalard
9433ce86b7 Refactor and squash long-standing bugs (A2) 
This is awesome.
- Improve performance by stopping useless string/array conversions.
- Simplify method interface.
- Fix localization bugs - we now know our locale
- Fix bugs with surrogate code points

Bug: 4769095
Change-Id: I8a8ee224b713429ee0a4ce5bd52f1b63378cf56f
 2012-06-26 19:12:07 +09:00
Jean Chalard
8e17f6d93a Remember the locale in the Suggest object (A1) 
This will be necessary for uppercasing and titlecasing words
correctly.

Change-Id: I0f446a4c82bc482240ff730a2ad6586a61571d6b
 2012-06-26 18:55:18 +09:00
Jean Chalard
6cad198d9c Remove a useless member (A2) 
Change-Id: Ia727ffc2946352bbf79e0c97684f8fa98f428cef
 2012-06-26 18:42:06 +09:00
Jean Chalard
0da9a7c094 Convert a member to a local variable (A1) 
Change-Id: I9eab910989443704f83711cf4fb0070c5987a13a
 2012-06-26 18:41:49 +09:00
Jean Chalard
f05392f213 Remove an unused method (A22) 
Change-Id: I2195f365df1799c8b3b2a53670d1df535ab1a742
 2012-06-26 17:59:04 +09:00
Jean Chalard
6234be1fe7 Simplification and optimization (A20) 
Change-Id: Ia837e553ccfe67cd4303096290194a5186df059b
 2012-06-26 17:59:04 +09:00
Jean Chalard
77e95e60bb Preparation for a simplification (A19) 
Change-Id: I4605a571faf5fbc68b18ce525d6019600bfa8cf7
 2012-06-26 17:59:04 +09:00
Jean Chalard
0a79446531 Remove a meaningless separation (A18) 
Change-Id: I267177044c7d7b0d9119839a11057b2bbf41f75f
 2012-06-26 17:59:04 +09:00
Jean Chalard
61e7ec6587 Remove the Callback interface for simpler code. (A17) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I009b54fc2e73cadca6734bdca074d033e81f6a2b
 2012-06-26 17:58:52 +09:00
Jean Chalard
2f1b6c9ea4 Remove the callback argument to getBigrams() (A16) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I7457ac04f8cd4019fb86c986725aae3de1b1a65e
 2012-06-26 17:54:49 +09:00
Jean Chalard
60eed92dc3 Remove the callback argument to getWords() (A15) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I919bf70a1213ab5d7c7a9e5715bd72a6e257148b
 2012-06-26 17:36:47 +09:00
Jean Chalard
2225b3bace Do away with Utils#addAllSuggestions (A14) 
It's not used any more.

Change-Id: Id9da40fdbf7078f3ac647d1368237d6601f5a2ba
 2012-06-26 17:36:47 +09:00
Jean Chalard
d9df8094e6 Neutralize AndroidSpellChecker.SuggestionsGatherer#addWords (A13) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Ia54e1e44e1fd4e8ba2c9316928c0595cbe3f933c
 2012-06-26 17:36:47 +09:00
Jean Chalard
7830476022 Neutralize Suggest#addWords (A12) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id923367342a62a650a5f1d38e2fa0e913030dca8
 2012-06-26 17:36:47 +09:00
Jean Chalard
fd998bd37a Refactoring (A11) 
Change-Id: I86bd7587dd80773a51ba6db312ba55dc41e7c8c7
 2012-06-26 17:36:47 +09:00
Jean Chalard
64dad2d5a9 Remove an unused method and inline another (A10) 
Change-Id: Ifd71ce79711b0c15c7764e97351dbb1b8e4c0c2d
 2012-06-26 17:36:47 +09:00
Jean Chalard
28eeb35d14 Merge the interface of two methods that do the same thing (A9) 
Change-Id: Ia5701d713d0fd5bb646b54a03a1a5602dad0a9e6
 2012-06-26 16:55:09 +09:00
Jean Chalard
d82898c5a9 Change the return type of getWords and getBigrams (A8) 
This only returns stuff, but it doesn't change yet how the data
is really passed. It merely adds a way of getting the same data.
Later, the old way will be removed.

Change-Id: If3a064de362175fc5a6781b7a97b65d8730aaf3c
 2012-06-26 16:44:26 +09:00
Jean Chalard
bda7eaa63a Remove dependency on WordCallback from BinaryDictionary (A7) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I8245698fbd170e0f5cbad3c0109774bcaddc0614
 2012-06-26 16:42:48 +09:00
Jean Chalard
17111afcd6 Remove useless code and storage (A6) 
This is only used as temporary storage to be then added to
the other variable, relying on the fact that it is hopefully
sorted. It's better to just add it right away to the final
storage.

Change-Id: I5da702ac9dc579593ab21feb2021a01e5dfdf4dc
 2012-06-26 16:39:32 +09:00
Jean Chalard
5e0545d69d Remove a duplicate processing (A5) 
This filtering is already done in native code. It's useless (and
costly) to do it again here.

Change-Id: Ide6794d7a8682a881f097f33e222f10d30f297bd
 2012-06-26 16:37:05 +09:00
Jean Chalard
fac8a16c6f Merge "Remove another dependency to WordCallback (A4)" 2012-06-25 23:31:39 -07:00
Kurt Partridge
3ec249c6d1 Merge "fix IllegalOutOfBoundsException" 2012-06-25 22:52:36 -07:00
Kurt Partridge
01106f6a10 fix IllegalOutOfBoundsException 
StringUtils.toCodePointArray() had thrown IllegalOutOfBoundsException if
passed an empty string.  change to just return an empty int[].

Bug: 6188932
Change-Id: Ic41c628c0d407f49fc98cd48cb7ea13d8d5bdd77
 2012-06-25 22:40:56 -07:00
Jean Chalard
d7b9e8f503 Remove another dependency to WordCallback (A4) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I5b277124dc9244e78c4a1f4d542a55071eb479bd
 2012-06-26 13:12:01 +09:00
Ken Wakasa
9f78eed456 Remove "Key popup dismiss delay" when "Popup on keypress" is suppressed 
bug: 6714783
Change-Id: Idf674e8e1af80642f2c53f7ae5c03e21c9e04292
 2012-06-26 00:40:53 +09:00
Satoshi Kataoka
7368009799 Change JNI for Gesture 
Change-Id: I774a0052038d16677f60f7efa11fd266cb5f3088
 2012-06-25 18:54:37 +09:00
Jean Chalard
5a73d72265 Merge "Refactoring and groundwork to fix a bug with older apps" 2012-06-25 00:42:21 -07:00
Jean Chalard
c3ebf1a43a Refactoring and groundwork to fix a bug with older apps 
This has a good, although small, impact on performance : it removes
a two-way IPC call in a most frequent case, while possibly adding
one in a rather unfrequent and less critical case.

Also, this fixes a bug with surrogate pairs. This specific branch
of code now correctly handles surrogate pairs.
Aside from this, it should have no impact on behavior.

However, since it does delay access to the previous character in
the text view by a two-way IPC call, it actually goes a long way
toward fixing bug#6668226. It is not really a fix and the race
condition still exists, but this change makes it much, much
harder to hit.

Bug: 6668226
Change-Id: Id11cc6a0b7488d6bd392227cafdcf3a8d4c62f6c
 2012-06-25 16:32:25 +09:00
Jean Chalard
a316a15984 Merge "Tentatively remove a dependency on WordCallback (A3)" 2012-06-24 23:08:13 -07:00
Jean Chalard
dc01bd5ea4 Merge "Improve compatibility for ICS." 2012-06-24 20:41:19 -07:00
Satoshi Kataoka
2cf265b345 Merge "Fix possible NPE from a concurrent problem in LatinIME" 2012-06-21 22:16:48 -07:00
Kurt Partridge
e6a39d5677 Merge "Allow punctuation through privacy filter" 2012-06-21 21:53:48 -07:00
Kurt Partridge
33d9f9b6db Allow punctuation through privacy filter 
Also cleaned up the privacy code a bit.

multi-project commit with Change-Id: Ic0919a6929ebb2623ff4124f7adc96d9e5f8df3c

Bug: 6188932
Change-Id: Id470fe7cc6e4a8fb01f1ea5b178a74cd27d59218
 2012-06-21 00:17:48 -07:00
Jean Chalard
1b71ff00a2 Merge "Update an outdated comment" 2012-06-20 20:18:51 -07:00
Jean Chalard
9997b44846 Improve compatibility for ICS. 
ICS didn't have a SHORTCUT column in the user dictionary.
If running on a build under JellyBean, we should not ask
for it lest we crash.

Bug: 6600617
Change-Id: Iac0cbcc63c10064f01e2d51eec5931fd9cdd0922
 2012-06-20 18:43:56 -07:00
Jean Chalard
83f4a9866a Cleanup, part 10 : remove from the code obsolete options (C10) 
Change-Id: Id0806ad3dc7ccb632713eebaca76f0bab26ece5d
 2012-06-21 10:07:05 +09:00
Jean Chalard
7c406ed655 Tentatively remove a dependency on WordCallback (A3) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id5a59eaec2aeefa0ba4524420a8e035d383f6545
 2012-06-21 10:03:44 +09:00
Jean Chalard
e8bb8351d6 Cleanup, part 9 (C9) 
Change-Id: Ifb15553824915d0634aea83689302c2418b093f3
 2012-06-21 09:22:32 +09:00
Jean Chalard
ca6b7d5265 Cleanup, part 8 (C8) 
Change-Id: Iecc9b3d43c191614c2951408e14085cb77eefd4d
 2012-06-20 03:45:40 +09:00
Jean Chalard
2f3a694e29 Cleanup, part 7 (C7) 
Change-Id: I662be9d3b31fb9e157722f38cab1e6fb8a1152ab
 2012-06-20 03:17:33 +09:00
Jean Chalard
0e8b1db948 Merge "Cleanup, part 6 (C6)" 2012-06-19 09:25:33 -07:00
Jean Chalard
c03bd090ea Merge "Cleanup, part 4 (C4)" 2012-06-19 09:24:25 -07:00
Jean Chalard
bd765d3355 Merge "Cleanup, part 3 (C3)" 2012-06-19 09:24:00 -07:00
Satoshi Kataoka
67b9337b6c Fix possible NPE from a concurrent problem in LatinIME 
Bug: 6620746
Change-Id: Icc18de92d7edc6888c712c2cf5ce479a65f8bfad
 2012-06-19 03:34:45 +09:00
Jean Chalard
b0561ae980 Remove a member (B5) 
The new call in the test ensures getCurrentInputEditorInfo actually
works.

Change-Id: I2ee407bd9927d22db537d12f339e2b977a38054a
 2012-06-19 03:27:37 +09:00
Jean Chalard
64e52051cf Simplification (B4) 
Change-Id: Id5abf722a533980ed2d89381dbddc0a71b6f5b6b
 2012-06-19 02:54:13 +09:00
Jean Chalard
fe53e5c060 Move a settings method to SettingsValues (B3) 
Change-Id: Ibfa27bd919c92be219c4d107b3ace008ca80a19f
 2012-06-19 02:52:36 +09:00
Jean Chalard
8b538807a3 Merge "Make a variable final (A2)" 2012-06-18 10:30:19 -07:00
Jean Chalard
0176faf6c0 Merge "Add a kind to the suggestion for bookkeeping (A1)" 2012-06-18 10:30:10 -07:00
Jean Chalard
1c3c0ff1c3 Merge "Cleanup, part 2 (C2)" 2012-06-18 10:29:06 -07:00
Jean Chalard
65b7bcb045 Merge "Cleanup, part 1 (C1)" 2012-06-18 10:28:58 -07:00
Kurt Partridge
6080f6878b Remove non-dictionary words and digit touch data. 
Output to the ResearchLogger is now queued and only flushed if the word
the user was working on is a dictionary word.

multi-project commit with Ic713ec00777fbdcf4a937b3c77b995257e100fc7

Bug: 6188932
Change-Id: I9de15227ff51be23083d9096f1c1b3d83802fff7
 2012-06-17 15:02:15 -07:00
Kurt Partridge
4b91046759 Merge "Replace digits in ResearchLogger" 2012-06-16 20:48:25 -07:00
Kurt Partridge
a696781c2b Replace digits in ResearchLogger 
Digits may represent personally identifying information.  They are
now replaced with a non-identifying symbol.

multi-project commit with I07d1cfdc45f6086f67af45775f4ed12da1833aca

Bug: 6188932

Change-Id: Ifda8079e6c1f29b5f8af34c6d1fccf5770f164ca
 2012-06-16 12:37:50 -07:00
Jean Chalard
c5f1d998c2 Cleanup, part 6 (C6) 
Change-Id: I184f3a336278559df255c5d600a98fbba468a243
 2012-06-16 10:52:49 +09:00
Jean Chalard
9b233ecef2 Cleanup, part 4 (C4) 
Change-Id: I2821ae71ec49e4b6b512157d17b80198f74321e4
 2012-06-16 10:51:04 +09:00
Jean Chalard
5475e92b3f Cleanup, part 3 (C3) 
Change-Id: Ib0be8dc26b6fa366a3dabeea940d466602073244
 2012-06-16 10:46:18 +09:00
Jean Chalard
71dc280426 Cleanup, part 2 (C2) 
Change-Id: I860f41807e9bc2e38b6ad84e1527fc8707a9aa40
 2012-06-16 10:40:16 +09:00
Jean Chalard
6883153dd0 Cleanup, part 1 (C1) 
Change-Id: I2b1ddd836aaf6bfc0bd2befb78f98239ffcdbb22
 2012-06-16 10:38:57 +09:00
Jean Chalard
4a5cb5c36a Update an outdated comment 
Change-Id: I3d02dc8597ed14d998caeaa056813353e2d7ec1a
 2012-06-16 10:34:57 +09:00
Jean Chalard
dca729fddd Move final attributes to SettingsValues (B2) 
Bug: 6675475
Bug: 6677394
Change-Id: I4a26efb9226d3f909f331c4d2e47cd83a05c011e
 2012-06-16 08:01:09 +09:00
Jean Chalard
3d44f489b3 Inline a method for simplicity (B1) 
This has a confusing name and is a one-liner

Change-Id: I954a648a8413e38a535c2b81e4b171e1bdc9f1c2
 2012-06-16 03:18:00 +09:00
Jean Chalard
0998c48ac3 Make a variable final (A2) 
This is never changed, and probably doesn't need to be.
It's public because it's going to be used elsewhere in a future
change

Change-Id: Iec8d65859c470de5e1fb0b05533356fbc3b8e91b
 2012-06-16 03:10:54 +09:00
Jean Chalard
e7d2ee3ec3 Add a kind to the suggestion for bookkeeping (A1) 
This will help for debug as well as serve as groundwork for
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I74d0a7b943fb22c514ad79dc064d69ddf336d3ef
 2012-06-16 03:10:36 +09:00
Kurt Partridge
23cec44376 Merge "No logging of passwords." 2012-06-14 21:09:20 -07:00
Jean Chalard
a19c5e6380 resolved conflicts for merge of be82f297 to master 
Change-Id: If49ca384ea0ac415a75f8ea1bad77dc6719cb04d
 2012-06-15 09:03:52 +09:00
Kurt Partridge
1cef91e481 No logging of passwords. 
Bug: 6188932
Change-Id: Ibf60ec99c50da3675bf89858624218e6cc3eb1d2
 2012-06-14 15:14:20 -07:00
Jean Chalard
cf6e923b18 am 42ecf39d: am 002e43ea: Merge "Remove irrelevant options." into jb-dev 
* commit '42ecf39d04df9eb02e57cf29e63552bc04092857':
  Remove irrelevant options.
 2012-06-14 14:51:37 -07:00
Tadashi G. Takaoka
775d8dcaeb am de1d88eb: am 32f4ceb2: Dismiss more suggestions panel when suggestions strip is closed 
* commit 'de1d88eb4199160899d227f2c679215e16410c42':
  Dismiss more suggestions panel when suggestions strip is closed
 2012-06-14 14:49:08 -07:00
Jean Chalard
7cbd0478cf Merge "Do not display punctuation suggestions when bigrams are on." into jb-dev 2012-06-14 14:37:13 -07:00
Jean Chalard
002e43ead0 Merge "Remove irrelevant options." into jb-dev 2012-06-14 14:36:26 -07:00
Jean Chalard
d5b765b3bb Do not display punctuation suggestions when bigrams are on. 
Bug: 6310401
Change-Id: I9d31c48e287aceedaf2f4c5129031ddb31402451
 2012-06-15 06:01:09 +09:00
Jean Chalard
78573f2e8a Fix an NPE 
This code is temporary until we get rid of this member.

Bug: 6662963
Bug: 6667091
Change-Id: I1d970d2a97992507e86c5b94978a2543fe42b375
 2012-06-15 05:47:35 +09:00
Jean Chalard
15121cff37 Remove irrelevant options. 
Bug: 6667355
Change-Id: I39b6db17fb52e80f510cf6462f41d9cb1f8e0341
 2012-06-15 05:04:14 +09:00
Tadashi G. Takaoka
32f4ceb243 Dismiss more suggestions panel when suggestions strip is closed 
This change fixes possible NPE as well.

Bug: 6658028
Change-Id: I8706808d1002b7b0b95930fd9b08568f08645da6
 2012-06-14 11:57:43 -07:00
Satoshi Kataoka
d2f210dbe2 am d9c702d2: am 5caaf1b9: Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 
* commit 'd9c702d2ff017452f0264f2be12b6bffd6204e4a':
  Do not add profanity to user history bigram dicitonary
 2012-06-14 10:33:47 -07:00
Satoshi Kataoka
68c650fb2a Do not add profanity to user history bigram dicitonary 
Change-Id: I864c4206e3e6cde4d6ed687a9759e98901e16b9a
 2012-06-14 15:15:08 +09:00
Jean Chalard
9d71748ba4 Fix an occurrence of nested batch edits. 
This is harmless, but against policy.
Also, rework the checking code to be more readable, give more
information, and be called for all relevant methods - and not
for informative methods, which are not required to be in a
batch edit.

Change-Id: I03fa8b2e7d68a6a133f86be8a214671750c29256
 2012-06-13 07:02:07 +09:00
Jean Chalard
c7564a787e Optimization 
This is much faster. It doesn't create messages, it doesn't post
stuff in a queue, it doesn't delay execution of other messages.
Also, it decouples the timer from the functionality of the Handler
so this can be pulled up in another change to consolidate with
mLastKeyTime or so.

Change-Id: I9044fc031373e66b9b40eee8025633613d0945dc
 2012-06-13 07:02:07 +09:00
Jean Chalard
72b358aa90 Small optimization. 
This will avoid some two-way IPC calls.

Change-Id: If9eb3e99b3d08346aadd4bbed2a1761f8c2527b9
 2012-06-13 07:02:07 +09:00
Satoshi Kataoka
84bb18f4c9 resolved conflicts for merge of ee78e780 to master 
Change-Id: I88a4996bdd17c5378a67781d8075eff311670c3b
 2012-06-13 06:45:38 +09:00
Jean Chalard
58d9e46ce0 Merge "Consolidate a test." 2012-06-12 11:50:36 -07:00
Kurt Partridge
5e50eec570 Merge "Check inputs to ResearchLogger" 2012-06-12 11:39:11 -07:00
Jean Chalard
e86054e5c2 Consolidate a test. 
Stop using the numerical value, use the actual method

Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e
 2012-06-13 03:34:58 +09:00
Kurt Partridge
65fc909e13 Check inputs to ResearchLogger 
to avoid NPEs.

Bug: 6188932
Change-Id: I377ceaac867df879dc7984dae44e96b369858cca
 2012-06-12 10:56:03 -07:00
Jean Chalard
140adf204b Consolidate auto-correction settings. 
For some reason, there were several ways, not exactly identical,
to get this setting. The ones that used mAutoCorrectionEnabled
would kick in when the input field was specifying no correction,
so it would be a little strange (although harmless in the practice
because the settings set in this way would not get used later,
because the correct test would be done at that time).

Also perform a very small refactoring

Change-Id: Ica9f32b238d98009ae1852d3c1e940398f5d341c
 2012-06-12 10:29:55 +09:00
Jean Chalard
2010aad741 Move two methods in a more appropriate place 
Change-Id: I512b04e23490413a44b1ca0517102fe2d9138df3
 2012-06-12 10:29:55 +09:00
Jean Chalard
a32eb27213 Move an editing method to the RichInputConnection 
Change-Id: Ie143ad008ca8deb1c5034cb80ec1cb28a6b0682d
 2012-06-12 10:29:55 +09:00
Jean Chalard
243e370fcb Move a member call out of the way 
Change-Id: I5da48442c0b39aaff817c3b6d067a9b13fda0643
 2012-06-12 10:29:55 +09:00
Jean Chalard
747cf0435a Move two editing utility methods to RichInputConnection 
Change-Id: If8d03bea1b6369cb3043da6321048d052995d664
 2012-06-12 10:29:55 +09:00
Jean Chalard
70a046f8ca Merge "Rename mSettingsValues to mCurrentSettings" 2012-06-11 18:24:45 -07:00
Jean Chalard
64913d72bc Merge "Move suggestion strip visibility to SettingsValues" 2012-06-11 18:18:50 -07:00
Jean Chalard
15c0090e88 Merge "Accept a null input attributes for reading settings." 2012-06-11 18:18:43 -07:00
Jean Chalard
f4bc441256 Merge "Move the correction mode to SettingsValue and make it final" 2012-06-11 18:18:03 -07:00
satok
6a71f0610c Fix UserHistoryBigram data contention in UserHistoryDictionary 
Bug: 6637614
Change-Id: I34d26563e59d3b09bf35b8173dac5645ccb6a39f
 2012-06-12 08:00:14 +09:00
Jean Chalard
411a98afb9 Merge "Consolidate updateCorrectionMode() calls" 2012-06-11 14:02:15 -07:00
Jean Chalard
297e6d590b Rename mSettingsValues to mCurrentSettings 
...for readability. After all, it makes sense that "current settings"
is a "SettingsValues", while it's harder to understand why we'd
manipulate an object named "SettingsValues".

Change-Id: Ide9a17b970a6cc00b80b9a217f986268c739c662
 2012-06-08 21:34:07 +09:00
Jean Chalard
d273697259 Move suggestion strip visibility to SettingsValues 
Change-Id: If34112c69acd5122d87554043d87d8f4dbdf5d15
 2012-06-08 21:26:25 +09:00
Jean Chalard
01e3b014bb Accept a null input attributes for reading settings. 
Change-Id: I11a8e1aca3541c35d2b39b27716687fcd8ff3dc6
 2012-06-08 21:15:33 +09:00
Jean Chalard
4b9e6ee6fb Move the correction mode to SettingsValue and make it final 
At last this guy is final, at last

Change-Id: I76911f8d47493f8a1719f75fc7e949be5d7da1a2
 2012-06-08 21:10:35 +09:00
Jean Chalard
3791183076 Consolidate updateCorrectionMode() calls 
Change-Id: I43c0505e9a1652bfc568f23b787fc68a5c5e9220
 2012-06-08 21:02:19 +09:00
Ken Wakasa
e7b34b9f86 Add NativeUtils.powf() 
Change-Id: I0339f39d49bc6390d098017f32d92c776974e03e
 2012-06-08 20:46:19 +09:00
Jean Chalard
bbbdab12be Move some editing methods to RichInputConnection. 
Change-Id: I8527776a4bd8236a85bb77f9791f9b76977ad181
 2012-06-08 20:23:13 +09:00
Jean Chalard
e091982868 Straighten batch edits, pass 1 
Change-Id: I73acfee9098a87b9cde8aca720586ec748b2a82f
 2012-06-08 20:09:41 +09:00
Jean Chalard
02308bec63 Merge RichInputConnection with EditingUtils 
Change-Id: I9982ff325bef56694402caef28a77683c52ccd71
 2012-06-08 20:04:09 +09:00
Jean Chalard
5475b38328 Make a wrapper for the input connection. 
The goal is to simplify the code in LatinIME.java as well as having
a handy place to put debug calls to see interaction with TextView.

Change-Id: I255227e7e7343e0c2f3dcd1f185e5020d6186732
 2012-06-08 19:50:12 +09:00
Jean Chalard
c33a5428be Merge "Small performance tweak" 2012-06-08 01:22:31 -07:00
Jean Chalard
67fd0c240d Remove deprecated classes. 
Should we maybe rename back *BinaryDict* to *Dict* in another
change for simplicity?

Change-Id: I8f7dcb78b9bdf1a13ce403a997fbb8619f2b453b
 2012-06-08 17:12:15 +09:00
Jean Chalard
d10c473347 Small performance tweak 
Change-Id: Icd540742073d49d12e70b2d8bd99aaf7ccb5802d
 2012-06-08 17:09:40 +09:00
Jean Chalard
7214617622 Remove a slew of Eclipse warnings. 
Change-Id: I03236386aea13fbd4fb8eaeee18e0008aa136502
 2012-06-08 16:23:18 +09:00
Ken Wakasa
d418580a71 Fix typo 
Change-Id: I264f829c1584a37995dbc5ee4ba6b6783d5d4834
 2012-06-08 03:42:02 +09:00
Tadashi G. Takaoka
6b8a70105f am e4da18e2: am 6348c54f: Merge "Initializing member variable before it is referenced" into jb-dev 
* commit 'e4da18e27916f770fcd704032d30534d287d67c6':
  Initializing member variable before it is referenced
 2012-06-07 11:32:50 -07:00
satok
1e96cc1f51 am 674c51a0: am ec2981a4: Fix a bug on upgrading user history scheme 
* commit '674c51a01117b73dd25473195f92fb0c0158da26':
  Fix a bug on upgrading user history scheme
 2012-06-07 11:28:41 -07:00
Tadashi G. Takaoka
6348c54ffd Merge "Initializing member variable before it is referenced" into jb-dev 2012-06-07 11:27:32 -07:00
Tadashi G. Takaoka
40582ab438 Initializing member variable before it is referenced 
Bug: 6584882
Change-Id: I1f76388fa8cc16171bc3fc60c935ddcf0a7c4e92
 2012-06-07 11:17:59 -07:00
satok
ec2981a487 Fix a bug on upgrading user history scheme 
Bug: 6626700
Change-Id: I3190d7404e45e704be79ee2031e79b18475feb8c
 2012-06-08 02:55:23 +09:00
Tom Ouyang
11dc22d964 Merge "Contacts binary dictionary updates with change in keyboard locale." 2012-06-07 01:19:44 -07:00
Tom Ouyang
2e8aa06002 Contacts binary dictionary updates with change in keyboard locale. 
Bug: 6616436
Change-Id: I8d66a37f295134c5b9875b2a305a9be7442bd75d
 2012-06-07 00:25:41 -07:00
Jean Chalard
c8a120f970 am eead5492: am 769cecf7: Close spell-checking dictionaries in a background thread 
* commit 'eead5492615f0b05ef85ca1f88d3a41ce3f8d496':
  Close spell-checking dictionaries in a background thread
 2012-06-06 21:52:46 -07:00
Jean Chalard
769cecf7e7 Close spell-checking dictionaries in a background thread 
Bug: 6584677
Change-Id: Ifd9b0f995f4e0cf4d35a7ecde767826ab976f0b8
 2012-06-07 12:56:45 +09:00
Kurt Partridge
9b300f0caa Merge "add research log ui control" 2012-06-06 20:47:53 -07:00
Kurt Partridge
724bc479f7 add research log ui control 
- lets users flag a particular time in the research log
- lets users delete the log for this session

also makes the UsabilityLog setting control whether the ResearchLog logs or not.

multi-project commit with I89067e7d3b8daca7179333f1dbe82224c26920fe

Bug: 6188932
Change-Id: I89864ef3ab53b0efe1ea8d75247be08712f0c399
 2012-06-06 20:42:01 -07:00
Satoshi Kataoka
91c8c4f3a7 am e08cfda1: am 5a8d2fd1: Merge "Cache UserHistoryDictionary for each language" into jb-dev 
* commit 'e08cfda1ebea693c56681816076c419f23c51076':
  Cache UserHistoryDictionary for each language
 2012-06-06 10:48:46 -07:00
Satoshi Kataoka
5a8d2fd1d3 Merge "Cache UserHistoryDictionary for each language" into jb-dev 2012-06-06 10:43:50 -07:00
Satoshi Kataoka
a836808f8b Cache UserHistoryDictionary for each language 
Bug: 6603257
Change-Id: I73b65e921cff8337a00594525f67f6aec2178881
 2012-06-06 20:02:00 +09:00
Satoshi Kataoka
21b782cf22 Merge "Cache bigram results in Android SpellChecker" 2012-06-06 01:01:47 -07:00
Satoshi Kataoka
547bc0cf04 Cache bigram results in Android SpellChecker 
Bug: 6610579
Change-Id: I255c068f64f99ee80abda49153ed8ea009ca8ad3
 2012-06-06 16:58:24 +09:00
Kurt Partridge
6b3b37da97 Merge "Change constants in ResearchLogger" 2012-06-05 20:17:14 -07:00
Tadashi G. Takaoka
876711930d am 2eb5eb4d: am be2fef4d: Merge "Fix backing view height calculation in landscape orientation" into jb-dev 
* commit '2eb5eb4d447cb326b4c10cff2cae64df4e431ffd':
  Fix backing view height calculation in landscape orientation
 2012-06-05 17:58:59 -07:00
Tadashi G. Takaoka
b94f4cc71c Fix backing view height calculation in landscape orientation 
This logic has been dropped by Ib814c07f.

Bug: 6610497
Change-Id: Id89ad3280b73a31d8c9c6826e9ee297791624db1
 2012-06-05 17:41:01 -07:00
Jean Chalard
5235e0cd91 am c750f9eb: am a6166d37: Fix a bug where Latin IME crashes on spell checker request 
* commit 'c750f9eb5398a30b207891e6858863f493875199':
  Fix a bug where Latin IME crashes on spell checker request
 2012-06-05 09:54:58 -07:00
Tom Ouyang
f93551f77b am 18c4137c: am 7f7739fe: Merge "Fix a bug where the spellcheck is using the old non-binary contacts dictionary" into jb-dev 
* commit '18c4137c878c18de24a406b861ddb2a735e02f7d':
  Fix a bug where the spellcheck is using the old non-binary contacts dictionary
 2012-06-05 09:54:55 -07:00
Satoshi Kataoka
037cf8c8a5 am 7394fc43: am 0e134e6b: Merge "Avoid redundant access to DB" into jb-dev 
* commit '7394fc43028ef6e28579921c30915bd8a9c9c990':
  Avoid redundant access to DB
 2012-06-05 09:22:17 -07:00
Jean Chalard
c1cbcf949d am 9252fc1b: am dd487247: Merge "Read the script correctly" into jb-dev 
* commit '9252fc1b88df0c8bd3870546d1c8ca7681e435d3':
  Read the script correctly
 2012-06-05 09:22:15 -07:00
Kurt Partridge
f739119f3f Change constants in ResearchLogger 
Bug: 6188932
Change-Id: I3c6a3fb3e8fb139e16322e544f12bc3294cdaf1c
 2012-06-05 07:13:06 -07:00
Jean Chalard
a6166d3776 Fix a bug where Latin IME crashes on spell checker request 
Bug: 6611183
Change-Id: I8a879feb598e1ac55d73f9cb27e54aa533d3a010
 2012-06-05 16:33:21 +09:00
Tom Ouyang
7f7739fee8 Merge "Fix a bug where the spellcheck is using the old non-binary contacts dictionary" into jb-dev 2012-06-04 23:10:03 -07:00
Satoshi Kataoka
0e134e6be8 Merge "Avoid redundant access to DB" into jb-dev 2012-06-04 20:08:02 -07:00
Jean Chalard
dd4872474a Merge "Read the script correctly" into jb-dev 2012-06-04 19:55:47 -07:00
Tom Ouyang
faf0059f35 Fix a bug where the spellcheck is using the old non-binary contacts dictionary 
Bug: 6607023
Change-Id: I6dc120dea23052a0841e281c20706bfb21fd9876
 2012-06-04 14:07:47 -07:00
Satoshi Kataoka
a8c13e7942 Avoid redundant access to DB 
Bug: 6603257
Change-Id: I2e8017f9e2e222aeab0a80faa239ce83d3b212ad
 2012-06-04 23:41:50 +09:00
Jean Chalard
b1f3c24c63 Read the script correctly 
The script of a language presumably does not depend on the
country variant. This was how it was made but it was later
forgotten and the full locale was registered.

Bug: 6542210
Change-Id: Iebc90c546f9c8caf89f8aa6c6a7c4733e5bcba48
 2012-06-04 18:39:16 +09:00
Tadashi G. Takaoka
9895b815a8 am e2832daf: am 8cf3654a: Merge "Use calculated backing view height instead of the view\'s height" into jb-dev 
* commit 'e2832daf4c289f94d68c546c485fc06bbf6aefd6':
  Use calculated backing view height instead of the view's height
 2012-06-03 21:55:26 -07:00
Tadashi G. Takaoka
bc5b89cdff Use calculated backing view height instead of the view's height 
This change removes the work around that was introduced by If4f24500.

Bug: 6596131
Change-Id: Ib814c07fdac7d0aa0d7fbc2764fda1af42b82ad5
 2012-06-04 12:49:27 +09:00
Ken Wakasa
4a9e5d2c95 am a8b7451b: am 027448e0: Remove an unnecessary thread. 
* commit 'a8b7451b31872d217cd61b7d0e6fbbf7221781c8':
  Remove an unnecessary thread.
 2012-06-02 09:07:51 -07:00
Ken Wakasa
027448e08a Remove an unnecessary thread. 
bug: 6584677

While looking at bug 6584677, we found that LatinIME always spawns an unnecessary thread
for Usability Study Mode.  We don't assume this change will address the root cause of the
bug, but we'd like to remove any suspicious noises in bugreports.

Change-Id: Ie47d104f6cd77ec2ad164f13b4212cb4a70bcf1d
 2012-06-03 00:27:07 +09:00
satok
083fb024d7 am e6560252: am 72cd8466: Merge "Fix NPE in user history bigram dictionary" into jb-dev 
* commit 'e656025282c0da28ed80b2604949092dbc5fb72e':
  Fix NPE in user history bigram dictionary
 2012-05-31 20:29:43 -07:00
satok
4f96bb4520 Fix NPE in user history bigram dictionary 
Bug: 6584882
Change-Id: Id0162bffc4f0f36239cdc68383f8a47d7a957397
 2012-06-01 12:19:22 +09:00
Kurt Partridge
76dbab8eb8 Merge "Include version number in log output." 2012-05-31 16:52:43 -07:00
Kurt Partridge
58caa775a7 Include version number in log output. 
Bug: 6188932
Change-Id: I1039a3ad317d207599f30fe578bdf814c80d6852
 2012-05-31 14:19:38 -07:00
Jean Chalard
b012f45242 am bb104678: am 6f0cd9ba: Fix a possible NPE. 
* commit 'bb10467863ff531c5cbee8ffd72845a91e487e72':
  Fix a possible NPE.
 2012-05-31 03:41:04 -07:00
Jean Chalard
6f0cd9ba6d Fix a possible NPE. 
This NPE's at least in unit tests.

Change-Id: I255ac5fec9502e4e5bd18cba1211cdf46c6cafc8
 2012-05-31 19:33:39 +09:00
Jean Chalard
3d7312af5b am 40bab488: am 4f78f8cb: Merge "Remove a vibration-related option when there\'s no vibrator" into jb-dev 
* commit '40bab488cb70875f46e29f595d577cc6cc4a9264':
  Remove a vibration-related option when there's no vibrator
 2012-05-29 23:37:09 -07:00
Jean Chalard
c7f2878cf5 Remove a vibration-related option when there's no vibrator 
Bug: 6567160
Change-Id: I1b5d425ffb64b2d7390cd0b7be0825f6aca17f41
 2012-05-30 15:24:59 +09:00
Kurt Partridge
30ff0898fd Merge "Fixes to json output" 2012-05-29 17:48:50 -07:00
Kurt Partridge
86fcadde5d Fixes to json output 
- booleans and numbers in SharedPreferences not quoted as strings
- removed redundant logging from KeyboardState
- json output for KeyboardId
- remove unnecessary logging of LatinImeLogger.onStartView() and PointerTracker checking keyboardlayoutchange
- fix to day-of-month part of uuid

Multi-project commit with Idb8f190214f852ab2b58df49f9e514dc7fcbecbb

Bug: 6188932

Change-Id: I67b4a0b34aa26c2804e2b3ee2136614f0ec8181a
 2012-05-29 14:04:05 -07:00
Tom Ouyang
609ce32a4d am 126ed424: am 1ed017ef: Fix performance issue when there are no contacts in the dictionary dictionary. 
* commit '126ed42415a4dc3841e8981a23cbe8a22a9e2213':
  Fix performance issue when there are no contacts in the dictionary dictionary.
 2012-05-29 10:12:33 -07:00
Tom Ouyang
1ed017ef0e Fix performance issue when there are no contacts in the dictionary dictionary. 
Bug: 6551480
Change-Id: I8681a1bd82423c612af2d012f9b872501d8c201d
 2012-05-29 09:45:42 -07:00
Satoshi Kataoka
c5d4362b59 am 408fa1ac: am 961e676b: Merge "Set level 1 as the initial value of the valid words" into jb-dev 
* commit '408fa1ac48a3eb6f378274d5dd0e490da0f453ae':
  Set level 1 as the initial value of the valid words
 2012-05-29 04:49:33 -07:00
Satoshi Kataoka
c88f61215c Set level 1 as the initial value of the valid words 
Bug: 4192129
Change-Id: I867e78ce79c78977d08e8b66881a25b6fe5bf41f
 2012-05-29 20:39:39 +09:00
Satoshi Kataoka
9a989492db am 40ab25ca: am 51705efc: Merge "Add a JNI to get the frequency" into jb-dev 
* commit '40ab25cab0e723f34dc2f1442f414761149b2338':
  Add a JNI to get the frequency
 2012-05-29 01:32:48 -07:00
Satoshi Kataoka
2f854e170c Add a JNI to get the frequency 
Bug: 4192129
Change-Id: I3f220f5a10114d4eb23956148076cf76220bda0f
 2012-05-29 17:21:59 +09:00
Satoshi Kataoka
a62f6e363d am d882aead: am bd40b94f: Merge "Optimize the store of bigram list" into jb-dev 
* commit 'd882aeadb07d16ed887c71895577faabbd635ff3':
  Optimize the store of bigram list
 2012-05-28 23:13:43 -07:00
Satoshi Kataoka
bd40b94f96 Merge "Optimize the store of bigram list" into jb-dev 2012-05-28 23:09:59 -07:00
Satoshi Kataoka
bc56885062 Optimize the store of bigram list 
Bug: 4192129

Change-Id: Idcc62e4f9696b56b1d7013891b2da37b1784423e
 2012-05-29 15:03:10 +09:00
Satoshi Kataoka
1963e46080 am 7317a257: am 24c4d626: Merge "Fix NumberFormatException" into jb-dev 
* commit '7317a257e553c6ecc7adb4211a0370d502bfa0fe':
  Fix NumberFormatException
 2012-05-28 21:24:57 -07:00
Satoshi Kataoka
48255b1747 Fix NumberFormatException 
Bug: 6567496
Change-Id: Ib0d9fab8496c8c856b94cce5812a263efbcb724f
 2012-05-29 13:16:38 +09:00
satok
1c69942683 am fff5cd6f: am aa064139: Merge "Forget user history" into jb-dev 
* commit 'fff5cd6f767e248ecb5b30ea39cb9a22a476b953':
  Forget user history
 2012-05-27 23:03:46 -07:00
satok
aa0641394b Merge "Forget user history" into jb-dev 2012-05-27 22:59:22 -07:00
satok
fd53b8cc2b Forget user history 
Bug: 4192129

Change-Id: Ic98398e5383093a1c24373849eadc48fc4d3626f
 2012-05-28 14:34:02 +09:00
Jean Chalard
1a31b4e484 am fac23787: am bed613cf: Merge "Simulate hardware enter/delete events if the app targets < 16" into jb-dev 
* commit 'fac23787bbd7723acba4e7e344aa6f799d9584f6':
  Simulate hardware enter/delete events if the app targets < 16
 2012-05-27 21:26:06 -07:00
Jean Chalard
bed613cf11 Merge "Simulate hardware enter/delete events if the app targets < 16" into jb-dev 2012-05-27 21:21:22 -07:00
Jean Chalard
4e1a558ee8 Simulate hardware enter/delete events if the app targets < 16 
This will make text input buggy on all apps until they target
JB or superior.

Bug: 6537051
Change-Id: I726347db8c84d1582ad1962d3a910e698389e08c
 2012-05-28 12:00:43 +09:00
Jean Chalard
6d7ac8a4ef am 250f6a44: am 123017cc: Merge "Wipe the application cache selectively" into jb-dev 
* commit '250f6a44a7585d61175ec983f9afd43081cd636f':
  Wipe the application cache selectively
 2012-05-25 04:11:16 -07:00
Jean Chalard
f27ac2733c am d45e334f: am 7707e045: Merge "Cache application info." into jb-dev 
* commit 'd45e334f5a73d2cc36800a81e1bbf881e633f026':
  Cache application info.
 2012-05-25 04:11:15 -07:00
Jean Chalard
123017cc74 Merge "Wipe the application cache selectively" into jb-dev 2012-05-25 04:07:46 -07:00
Jean Chalard
7707e0459f Merge "Cache application info." into jb-dev 2012-05-25 04:07:36 -07:00
Jean Chalard
64766fbcaa am 6691bd67: am 9b93817b: Merge "Get information about the target application." into jb-dev 
* commit '6691bd675a555163aa59c2ac791c6138c1d8a32c':
  Get information about the target application.
 2012-05-25 03:34:46 -07:00
Tadashi G. Takaoka
0dfbde09b2 am 41cf0ced: am b6c314e4: Merge "Clean up some compiler warnings" into jb-dev 
* commit '41cf0ced38912c5f4a6d11a88c0deb4ac4d01860':
  Clean up some compiler warnings
 2012-05-25 03:34:45 -07:00
Jean Chalard
9b93817b7f Merge "Get information about the target application." into jb-dev 2012-05-25 03:28:00 -07:00
Tadashi G. Takaoka
93ebf74bae Clean up some compiler warnings 
Change-Id: I604da15e65fc3cf807ec4033df4e4cd5ef0196fc
 2012-05-25 19:04:54 +09:00
Jean Chalard
eb696d288e Wipe the application cache selectively 
Bug: 6537051
Change-Id: I839d0a98c729f3604582946d70c0140a5cff7dcf
 2012-05-25 18:56:13 +09:00
Jean Chalard
1b1243d61f Cache application info. 
Bug: 6537051
Change-Id: Ieca891235df0d697bdeb0510651b703654fdef38
 2012-05-25 18:54:53 +09:00
Jean Chalard
b224b60c94 Get information about the target application. 
Bug: 6537051
Change-Id: I9fe7a07b5ddf2a423d5764840753ea70544206f1
 2012-05-25 18:41:32 +09:00
Jean Chalard
5ea26193a2 am d8b3e5c6: am 0c207144: Merge "Fix a bug with a concurrent modification of a map." into jb-dev 
* commit 'd8b3e5c69f4de663c748c82155fc3b8854119826':
  Fix a bug with a concurrent modification of a map.
 2012-05-24 03:44:06 -07:00
Jean Chalard
1b06b59e28 Fix a bug with a concurrent modification of a map. 
Bug: 6538848
Change-Id: I1a8422356d9909213e53cfdc8c5bcc12eb48f19d
 2012-05-24 19:38:04 +09:00
Jean Chalard
35dacc8e78 am 9b98c4a8: am 69897af2: Merge "Add new locales for the spell checker." into jb-dev 
* commit '9b98c4a8ce496fa45b8ad6e7da57063c79d1d9e4':
  Add new locales for the spell checker.
 2012-05-24 03:37:22 -07:00
Jean Chalard
69897af20d Merge "Add new locales for the spell checker." into jb-dev 2012-05-24 03:13:56 -07:00
Jean Chalard
d527a15ec4 Add new locales for the spell checker. 
Bug: 6533167
Change-Id: I1581e8446b1af5dc3679e01be16d4fc34af725cc
 2012-05-24 18:45:58 +09:00
Tadashi G. Takaoka
fe36e7fd9b am 9c239184: am 49afe45d: Fix build 
* commit '9c239184530be37fa806cf37a4f19ae0bc824aec':
  Fix build
 2012-05-24 01:21:38 -07:00
Tadashi G. Takaoka
49afe45d8e Fix build 
Follow up of I7822adf407

Change-Id: Iac75c0f2ff2482bce1305c54cb25b708037db6c6
 2012-05-24 17:13:35 +09:00
Tadashi G. Takaoka
516b785ce0 am bc48a8f7: am c60a846e: Fix NPE in Settings.updateCustomInputStylesSummary 
* commit 'bc48a8f7ab0d9003a9c97ceb7d85bcf0502785a6':
  Fix NPE in Settings.updateCustomInputStylesSummary
 2012-05-24 00:50:37 -07:00
Tadashi G. Takaoka
c60a846e21 Fix NPE in Settings.updateCustomInputStylesSummary 
Change-Id: I7822adf407046098f97bf60da9382910c0a40209
 2012-05-24 16:43:13 +09:00
satok
8822d5a346 am 60b2d84d: am 1e1235fe: Merge "Support bigram suggestions in Android spell checker" into jb-dev 
* commit '60b2d84d82ce8fd4a7bf4592d5229ee2436a675c':
  Support bigram suggestions in Android spell checker
 2012-05-23 22:07:06 -07:00
satok
1e1235feeb Merge "Support bigram suggestions in Android spell checker" into jb-dev 2012-05-23 22:02:52 -07:00
satok
315d731d8f Support bigram suggestions in Android spell checker 
Bug: 6136291
Change-Id: Ic278153f95b23e9aa180d1d6b5960785766d96e5
 2012-05-24 12:27:33 +09:00
satok
6d6c070eba am 925212ff: am c54d558e: Cancel adding user history bigram when autocorrection is cancelled 
* commit '925212ff4b3d6ff4182a94a133c0e4a4f23dd6aa':
  Cancel adding user history bigram when autocorrection is cancelled
 2012-05-23 20:19:46 -07:00
satok
c54d558e2e Cancel adding user history bigram when autocorrection is cancelled 
Bug: 6465474
Change-Id: Ifbfe0ddc2ce5fab070939ede3db7bf03a8535a45
 2012-05-24 12:11:02 +09:00
Jean Chalard
bf52a18806 am a6f86554: am 0b6b6ee5: Merge "Notify the dictionary pack about copy failures" into jb-dev 
* commit 'a6f865541bb1f0db7d179d77d6c4fe10a22dc109':
  Notify the dictionary pack about copy failures
 2012-05-23 04:42:35 -07:00
Jean Chalard
0b6b6ee542 Merge "Notify the dictionary pack about copy failures" into jb-dev 2012-05-23 04:12:59 -07:00
Jean Chalard
3abac7e28e Notify the dictionary pack about copy failures 
Bug: 6532896
Change-Id: I57f7b1a400222c89776f9bff652a7da4470232c5
 2012-05-23 18:46:51 +09:00
Tadashi G. Takaoka
ced9f4e385 am 0673e941: am 4cba9f58: Merge "Remove unused private method Suggest.searchBigramSuggestion" into jb-dev 
* commit '0673e941eb26b491f53bbbb2bbdc49bfd07ff973':
  Remove unused private method Suggest.searchBigramSuggestion
 2012-05-23 00:22:20 -07:00
Tadashi G. Takaoka
4cba9f58d4 Merge "Remove unused private method Suggest.searchBigramSuggestion" into jb-dev 2012-05-23 00:17:25 -07:00
Jean Chalard
7555c3bb18 am 41531cfb: am ff4c037c: Merge "Remove an updated dictionary that changed locales" into jb-dev 
* commit '41531cfb7413b22267b17359a76fc47432152d57':
  Remove an updated dictionary that changed locales
 2012-05-23 00:09:51 -07:00
Jean Chalard
ff4c037c9d Merge "Remove an updated dictionary that changed locales" into jb-dev 2012-05-23 00:04:21 -07:00
Jean Chalard
b9e2bce95e Remove an updated dictionary that changed locales 
When a dictionary changes locale, we need to remove the file
that corresponds to the old version. It has a different path
than the new one, so we have to search for it explicitly.

Bug: 6540631
Change-Id: Ie9d63ba636651fe90f8fbb9627b7265ac7b34ccd
 2012-05-23 15:59:49 +09:00
Tadashi G. Takaoka
b5db270962 Remove unused private method Suggest.searchBigramSuggestion 
Change-Id: I077c4c019676fefb8eac6042bd7db1b7ab33ca03
 2012-05-23 15:32:48 +09:00
Tadashi G. Takaoka
307b882c09 am e0e7bba1: am 24ce3645: Merge "Fix RuntiomeException when no custom input style is defined" into jb-dev 
* commit 'e0e7bba154cdc22cf603687eeb8a46e7b57e2eb6':
  Fix RuntiomeException when no custom input style is defined
 2012-05-22 23:17:05 -07:00
Tadashi G. Takaoka
24ce364586 Merge "Fix RuntiomeException when no custom input style is defined" into jb-dev 2012-05-22 23:13:18 -07:00
Tadashi G. Takaoka
d6e238fc33 Fix RuntiomeException when no custom input style is defined 
Bug: 6524480
Change-Id: I6bceea9fe07095b9ff3ed25c5677a82fa5d4086a
 2012-05-23 14:48:16 +09:00
Jean Chalard
008b528cbd am c4f66d32: am 6c034901: Fix an NPE 
* commit 'c4f66d3233159ee224dd0b30dd117fe539af2be6':
  Fix an NPE
 2012-05-22 20:18:01 -07:00
Jean Chalard
6c0349012e Fix an NPE 
Bug: 6538761
Change-Id: Id85486ee93437cfec7db421d5c7f2d7980a7e32e
 2012-05-23 12:05:36 +09:00
Kurt Partridge
8ccc875754 Merge "switch ResearchLogger output to json." 2012-05-22 10:32:23 -07:00
Jean Chalard
906857430b am 37105e86: am 09c4909c: Merge "Remove a high surrogate after a delete if any" into jb-dev 
* commit '37105e8636fc84f9e903581443730a0bf6692996':
  Remove a high surrogate after a delete if any
 2012-05-22 03:38:05 -07:00
Jean Chalard
978c96aa99 Remove a high surrogate after a delete if any 
Bug: 6526328
Change-Id: Iae70cad7b3c114bc13af48ae0eadd52ab88e8471
 2012-05-22 19:04:31 +09:00
Kurt Partridge
07cd1e1731 switch ResearchLogger output to json. 
use multiple logging files, clean up internal nested class structure.

multi-project commit with I1813b6710ef586d96cf8936662f58b870040d6e5

Bug: 6188932
Change-Id: I438790e28f74747c4c1a48a20c1942a0fd818b6c
 2012-05-21 18:45:21 -07:00
Tom Ouyang
c6f4d16826 am b9c597a7: am 2798c85c: Fix cursor leak in ContactsBinaryDictionary 
* commit 'b9c597a72d2e20a23351a832916cea7353f4fc41':
  Fix cursor leak in ContactsBinaryDictionary
 2012-05-21 17:15:28 -07:00
Tom Ouyang
2798c85c0f Fix cursor leak in ContactsBinaryDictionary 
Bug: 6529131
Change-Id: I86493705fbf069ba7a6c43581cfbd1bcc27ff1ba
 2012-05-21 16:50:26 -07:00
Tadashi G. Takaoka
d4577f738b am 82ffc9fe: am 16950d65: Reset automatic upper case when chroding key is pressed 
* commit '82ffc9fe5f7255c902e371bb5353bdef97205fd6':
  Reset automatic upper case when chroding key is pressed
 2012-05-21 14:29:59 -07:00
Tadashi G. Takaoka
1e18869be6 am 2eb4565b: am fc0a0015: Mark UserDictionary and ContactsDictionary as deprecated 
* commit '2eb4565ba33d158520eba693abe3bb263853104e':
  Mark UserDictionary and ContactsDictionary as deprecated
 2012-05-21 14:29:49 -07:00
Tadashi G. Takaoka
865df41ba8 am 647827cc: am 78e3977e: Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK 
* commit '647827cc0171f7dc5d425dea5754fca3df49d036':
  Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK
 2012-05-21 14:29:25 -07:00
Ken Wakasa
1c8d9a33bb am 1dbfbc60: am fd08b439: Tiny comment update to reflect what the class does more accurately. 
* commit '1dbfbc60e7e385455f07ad4c11c34addda5c4902':
  Tiny comment update to reflect what the class does more accurately.
 2012-05-21 14:29:25 -07:00
Tom Ouyang
cfec078d8b am 4bdb2bf3: am e1128687: Merge "Change to a binary version of the expandable user dictionary." into jb-dev 
* commit '4bdb2bf3b9cceb99736a736de42088fcf3bd1a0f':
  Change to a binary version of the expandable user dictionary.
 2012-05-21 14:10:54 -07:00
Tadashi G. Takaoka
6fbb8c8fc3 am 628a5745: am 75c60bf3: Merge "Change auto caps mode argument to int type" into jb-dev 
* commit '628a5745e19d227cdff2370704a4958e2791eb5a':
  Change auto caps mode argument to int type
 2012-05-21 14:10:50 -07:00
satok
ef04186ce8 am 9a06a1e9: am 468ac358: Merge "Add utils for forgetting curve" into jb-dev 
* commit '9a06a1e9eab191838a623aa074c65fd77a2ac7d9':
  Add utils for forgetting curve
 2012-05-21 12:44:31 -07:00
Jean Chalard
45befb946f am 9ad774d1: am 91492993: Merge "Close batch edit" into jb-dev 
* commit '9ad774d1f68bf3d2a4c38e5b4c3a2fa03e371eff':
  Close batch edit
 2012-05-21 12:44:10 -07:00
Tadashi G. Takaoka
9d0c15d9b4 am da3ba3e2: am 8ec3a42d: Merge "Check duplicated entry of "custom input style"" into jb-dev 
* commit 'da3ba3e2549cc69c360fede58b7e170d92e67b0a':
  Check duplicated entry of "custom input style"
 2012-05-21 11:52:36 -07:00
Jean Chalard
c95097f8ef am b7ee6484: am 6139016b: Merge "Fix a bug where the previous word would not be read correctly" into jb-dev 
* commit 'b7ee64844c373a80969d3b98a31e56ecbdfc8bc7':
  Fix a bug where the previous word would not be read correctly
 2012-05-21 11:52:32 -07:00
Jean Chalard
8717ad4cbd am 79daef2e: am 71b047e3: Merge "Don\'t deactivate the LastComposedWord on shift" into jb-dev 
* commit '79daef2e9b29b67048cd052b33c88675a0c62220':
  Don't deactivate the LastComposedWord on shift
 2012-05-21 11:52:11 -07:00
Tadashi G. Takaoka
16950d65c3 Reset automatic upper case when chroding key is pressed 
Bug: 6501446
Change-Id: Idc3b88b5370c0d7968cc388885e9066f922cfcf3
 2012-05-21 19:24:43 +09:00
Tadashi G. Takaoka
fc0a0015f8 Mark UserDictionary and ContactsDictionary as deprecated 
Bug: 6473962
Change-Id: I14477f99f67aedf756d9387ec1d50ef57a1c079e
 2012-05-21 17:04:38 +09:00
Tadashi G. Takaoka
78e3977e90 Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK 
Bug: 6523953
Change-Id: Ibea6c74d00e956116f492a3bedfe40e580b4c316
 2012-05-21 12:24:17 +09:00
Ken Wakasa
fd08b4390e Tiny comment update to reflect what the class does more accurately. 
Change-Id: I9eab3b5d387a5bf5d9b7fce4c1618170a7f34727
 2012-05-20 16:56:29 +09:00
Tom Ouyang
e1128687b1 Merge "Change to a binary version of the expandable user dictionary." into jb-dev 2012-05-18 10:05:11 -07:00
Tadashi G. Takaoka
553e2f19c1 Change auto caps mode argument to int type 
Bug: 6501446
Change-Id: I3f7bc0fc39edd29ebf96107c3d43b9ccc9b8022e
 2012-05-18 17:46:05 +09:00
satok
607a924486 Add utils for forgetting curve 
Bug: 4192129
Change-Id: Iebb7ac355e1c1891da31c33754315bd76a61889b
 2012-05-18 14:50:05 +09:00
Jean Chalard
d4cacb1e41 Close batch edit 
This does the same thing as Ie30e1aff but differently

Bug: 6512086
Change-Id: I47ae990510d3f657abd45ad5f0e325d93dec83c0
 2012-05-18 12:07:58 +09:00
Tom Ouyang
f6adff6227 Change to a binary version of the expandable user dictionary. 
Bug: 6435677
Change-Id: If83409f699608d443796e64a3c65692ae81b98e6
 2012-05-17 15:12:00 -07:00
Tadashi G. Takaoka
8ec3a42d2b Merge "Check duplicated entry of "custom input style"" into jb-dev 2012-05-17 04:36:16 -07:00
Tadashi G. Takaoka
749b2a388e Check duplicated entry of "custom input style" 
Bug: 6495488
Change-Id: Ia6c2421cb0e7c1793d4dfe18acd07fd6f8c5d797
 2012-05-17 20:20:41 +09:00
Jean Chalard
6139016b2b Merge "Fix a bug where the previous word would not be read correctly" into jb-dev 2012-05-17 04:06:54 -07:00
Jean Chalard
6e5ca89050 Fix a bug where the previous word would not be read correctly 
Bug: 6510002
Change-Id: Id30f67e0ca6f7a6fbbbd07922ae19e416c5ef55e
 2012-05-17 20:03:39 +09:00
Jean Chalard
125de3dfdf Don't deactivate the LastComposedWord on shift 
Bug: 6495116
Change-Id: Ib86de02a1216146082bf58a033982ac37fefffe1
 2012-05-17 17:05:30 +09:00
satok
ac067f2db7 am 0028ed36: Use "float" instead of "double" 
* commit '0028ed3627ff4f37a62a80f3b2c857e373cd5090':
  Use "float" instead of "double"
 2012-05-16 05:04:46 -07:00
satok
0028ed3627 Use "float" instead of "double" 
Change-Id: I93ed4d88ede4058f081dd8d634b00dfff4e96d07
 2012-05-16 20:45:05 +09:00
satok
080bc96786 am f837b57b: Merge "Reorder suggestions result according to auto correction threshold" into jb-dev 
* commit 'f837b57bf51b2767ec62a6140b28d84383ad75b1':
  Reorder suggestions result according to auto correction threshold
 2012-05-16 04:42:56 -07:00
satok
f837b57bf5 Merge "Reorder suggestions result according to auto correction threshold" into jb-dev 2012-05-16 04:13:08 -07:00
satok
db1939dbaa Reorder suggestions result according to auto correction threshold 
Bug: 5413904
Change-Id: I3aa3a8109ba45d2129b58d8242866fd3dd3473cb
 2012-05-16 19:58:48 +09:00
Tadashi G. Takaoka
b6d040c57f am b8b9ed81: Merge "Show dialog to guide the user to input subtype enabler" into jb-dev 
* commit 'b8b9ed8187d7d472e7803dd82e68fce7a5816d8e':
  Show dialog to guide the user to input subtype enabler
 2012-05-16 01:57:35 -07:00
Tadashi G. Takaoka
50e373943d am bd85efd5: Merge "Set divider icon\'s alpha value on the fly" into jb-dev 
* commit 'bd85efd5fb70496b05aa7a3dd7646dca894a9464':
  Set divider icon's alpha value on the fly
 2012-05-16 01:57:34 -07:00
Tadashi G. Takaoka
b8b9ed8187 Merge "Show dialog to guide the user to input subtype enabler" into jb-dev 2012-05-16 01:52:25 -07:00
Tadashi G. Takaoka
bd85efd5fb Merge "Set divider icon's alpha value on the fly" into jb-dev 2012-05-16 01:52:19 -07:00
Jean Chalard
93661b3b35 am ed49e4d8: Merge "Stop meaningless bigram computations" into jb-dev 
* commit 'ed49e4d82e3050bcf0e96babb40ce908d03f87f2':
  Stop meaningless bigram computations
 2012-05-16 01:49:08 -07:00
Jean Chalard
ed49e4d82e Merge "Stop meaningless bigram computations" into jb-dev 2012-05-16 01:43:39 -07:00
Tadashi G. Takaoka
1f2d0aa6c9 Set divider icon's alpha value on the fly 
Bug: 6183494
Change-Id: I61a0c7617648d9c52e5001b3479afa0ab4913adc
 2012-05-16 17:41:56 +09:00
Tadashi G. Takaoka
7566448ddf Show dialog to guide the user to input subtype enabler 
Bug: 6370433
Change-Id: Ic5777c1d95fe2ce9f48c72b8cc05c7ac250f4cdf
 2012-05-16 16:19:00 +09:00
Jean Chalard
12fbdfb6f9 am fbecbe84: Merge "Don\'t auto-correct when there is no main dictionary." into jb-dev 
* commit 'fbecbe8474338c237ee6758efe516fad1d58429c':
  Don't auto-correct when there is no main dictionary.
 2012-05-16 00:18:50 -07:00
Jean Chalard
fbecbe8474 Merge "Don't auto-correct when there is no main dictionary." into jb-dev 2012-05-16 00:14:04 -07:00
Jean Chalard
f0e12a9699 Don't auto-correct when there is no main dictionary. 
Bug: 6502485
Change-Id: I5803b0db8552867110587a1140fc03fc2e0eccef
 2012-05-16 16:09:14 +09:00
Tadashi G. Takaoka
fcb81e3171 am b4b3e80f: Merge "Fix empty custom input style entry appears after orientation change" into jb-dev 
* commit 'b4b3e80f1124eaefc4218fbd03a2af2dc4fece17':
  Fix empty custom input style entry appears after orientation change
 2012-05-15 11:37:56 -07:00
Jean Chalard
edcc32802f am 2bbdac53: Merge "Use a formula packing more information into 4 bits field" into jb-dev 
* commit '2bbdac539a7dc5478fd2f28d748b0dcf29eb1dd7':
  Use a formula packing more information into 4 bits field
 2012-05-15 11:37:55 -07:00
Jean Chalard
848081ad8b am 8dced70b: Merge "Read and use user dictionary shortcuts." into jb-dev 
* commit '8dced70b062744a2c27e0cf6dcd0787cf598a97c':
  Read and use user dictionary shortcuts.
 2012-05-15 11:37:54 -07:00
satok
d9c4aa83e1 am 76218b96: Merge "Do not set "SuggestionSpan"s for suggestions from the next word predicition" into jb-dev 
* commit '76218b966a6a712f3baa72d95c6d125d414cdbd4':
  Do not set "SuggestionSpan"s for suggestions from the next word predicition
 2012-05-15 11:37:52 -07:00
Jean Chalard
d09d3598d0 am a9aeb6f3: Merge "Small optimization" into jb-dev 
* commit 'a9aeb6f3ccd2964d79c287860bd660d9f19c8917':
  Small optimization
 2012-05-15 11:37:51 -07:00
Jean Chalard
bc740afba3 am b1120fe7: Merge "Small optimizations" into jb-dev 
* commit 'b1120fe79ac40717b2b91ba60608b2c9f735c368':
  Small optimizations
 2012-05-15 11:37:51 -07:00
Jean Chalard
47fedb8993 am f5ac6c72: Merge "More optimizations" into jb-dev 
* commit 'f5ac6c725a0e12c1ed796de9f255103b957e1724':
  More optimizations
 2012-05-15 11:37:50 -07:00
Jean Chalard
16c34b1bc5 am f184e73d: Merge "Some more obvious optimizations" into jb-dev 
* commit 'f184e73dd77464c53cbfe2815916e826cd32f318':
  Some more obvious optimizations
 2012-05-15 11:37:49 -07:00
Jean Chalard
ee2fc381ba am 78df7181: Merge "Some obvious optimizations to makedict" into jb-dev 
* commit '78df7181ff150596aa62591bfda6255c6517aa59':
  Some obvious optimizations to makedict
 2012-05-15 11:37:49 -07:00
Kurt Partridge
0320c526c2 Merge "include text context in researchLogger" 2012-05-15 10:17:59 -07:00
Tadashi G. Takaoka
b4b3e80f11 Merge "Fix empty custom input style entry appears after orientation change" into jb-dev 2012-05-15 04:23:50 -07:00
Tadashi G. Takaoka
c6846f28ba Fix empty custom input style entry appears after orientation change 
Bug: 6495828
Change-Id: I77c44e24340cff4e0702ac6dee02e4dd84076f3e
 2012-05-15 20:19:31 +09:00
Jean Chalard
2bbdac539a Merge "Use a formula packing more information into 4 bits field" into jb-dev 2012-05-15 03:02:01 -07:00
Jean Chalard
418b343797 Use a formula packing more information into 4 bits field 
Bug: 6313806
Change-Id: Id0779bd69afae0bb4a4a285340c1eb306544663a
 2012-05-15 18:59:21 +09:00
Jean Chalard
a86c0f1ea4 Stop meaningless bigram computations 
Bug: 6313806
Change-Id: Idf765b40812a43de13aa166ed0b44c7b5f7cc218
 2012-05-15 16:34:17 +09:00
Jean Chalard
8dced70b06 Merge "Read and use user dictionary shortcuts." into jb-dev 2012-05-14 20:38:23 -07:00
Jean Chalard
19ad9bf145 Read and use user dictionary shortcuts. 
Bug: 4646172

Change-Id: I51002c73d5bad1a698110c5cda02253348be8eed
 2012-05-15 12:23:43 +09:00
satok
76218b966a Merge "Do not set "SuggestionSpan"s for suggestions from the next word predicition" into jb-dev 2012-05-14 20:14:53 -07:00
satok
0142b997bf Do not set "SuggestionSpan"s for suggestions from the next word predicition 
Bug: 6294817
Change-Id: I5010eafa5ba7e947743706adf7e722f4f0cfb415
 2012-05-15 12:08:31 +09:00
Tom Ouyang
0c5b2a01d4 am 5282f00f: Merge "Contacts dictionary rebuilds only when contact names have changed." into jb-dev 
* commit '5282f00ff871bc0ae8303a2b6dacb283f73e31ea':
  Contacts dictionary rebuilds only when contact names have changed.
 2012-05-14 19:41:34 -07:00
Jean Chalard
a9aeb6f3cc Merge "Small optimization" into jb-dev 2012-05-14 19:11:19 -07:00
Jean Chalard
b1120fe79a Merge "Small optimizations" into jb-dev 2012-05-14 19:11:11 -07:00
Jean Chalard
f5ac6c725a Merge "More optimizations" into jb-dev 2012-05-14 19:11:06 -07:00
Jean Chalard
f184e73dd7 Merge "Some more obvious optimizations" into jb-dev 2012-05-14 19:11:02 -07:00
Jean Chalard
78df7181ff Merge "Some obvious optimizations to makedict" into jb-dev 2012-05-14 19:10:48 -07:00
Kurt Partridge
aec44d50a7 include text context in researchLogger 
when logging LatinIME.onUpdateSelection(), now include the current word and
preceding word.  no escaping of the word is performed; this is temporary
until the output format is cleaned up.

also fix EditingUtils.getWordRangeAtCursor to support supplementary
UTF-16 characters.

Bug: 6188932
Change-Id: If4612a2627537d5d8bb2f9585a3ad1b4e56c2e26
 2012-05-14 09:55:26 -07:00
Jean Chalard
76319c6931 Small optimization 
Performance gain is < 2%

Bug: 6394357
Change-Id: I2b7da946788cf11d1a491efd20fb2bd2333c23d1
 2012-05-14 15:52:01 +09:00
Jean Chalard
4df5b43df8 Small optimizations 
Bug: 6394357
Change-Id: I00ba1b5ab3d527b3768e28090c758ddd1629f281
 2012-05-14 15:51:58 +09:00
Jean Chalard
3b1b72ac4d More optimizations 
We don't merge tails anyway, and we can't do it any more
because that would break the bigram lookup algorithm.
The speedup is about 20%, and possibly double this if
there are no bigrams.

Bug: 6394357

Change-Id: I9eec11dda9000451706d280f120404a2acbea304
 2012-05-14 12:41:18 +09:00
Jean Chalard
12efad3d15 Some more obvious optimizations 
The speedup is about 15%

Bug: 6394357
Change-Id: Ibd57363d9d793206dd916d8927366db4192083b6
 2012-05-14 12:35:31 +09:00
Jean Chalard
47db0be7cb Some obvious optimizations to makedict 
Bug: 6394357
Change-Id: Ibfd98aac2304ef50cf90b1de984736ddcfe7a4bc
 2012-05-14 12:34:05 +09:00
Tom Ouyang
4d289d39ae Contacts dictionary rebuilds only when contact names have changed. 
Bug: 6396600
Change-Id: Iad693ec4bab6351793d624e5c5b0a9f5c12a60e3
 2012-05-11 18:43:53 -07:00
Jean Chalard
19278ea91f am 59e6ad38: Merge "Write the bigram frequency following the new formula" into jb-dev 
* commit '59e6ad38748b0d3c2ed63738d6ab5e6f123466d0':
  Write the bigram frequency following the new formula
 2012-05-11 04:46:21 -07:00
Jean Chalard
59e6ad3874 Merge "Write the bigram frequency following the new formula" into jb-dev 2012-05-11 04:42:36 -07:00
Jean Chalard
f7346de94a Write the bigram frequency following the new formula 
This also tests for bigram frequency against unigram frequency

Bug: 6313806
Bug: 6028348
Change-Id: If7faa3559fee9f2496890f0bc0e081279e100854
 2012-05-11 20:27:22 +09:00
Jean Chalard
e1c75a42c2 am ad0233fa: Merge "Refactor a method" into jb-dev 
* commit 'ad0233fa02985e597054bc50726a412fd8fff371':
  Refactor a method
 2012-05-11 04:13:53 -07:00
Jean Chalard
ad0233fa02 Merge "Refactor a method" into jb-dev 2012-05-11 04:09:17 -07:00
Jean Chalard
4455fe2c89 Refactor a method 
Rename it, rename parameters, and add a parameter that will
be necessary soon.
Also, rescale the bigram frequency as necessary.

Bug: 6313806
Change-Id: I192543cfb6ab6bccda4a1a53c8e67fbf50a257b0
 2012-05-11 19:34:35 +09:00
satok
9978953e29 am 6792a909: Merge "Output caps debug code" into jb-dev 
* commit '6792a909cd0da3db6a957cb2576b4d08f46a53b7':
  Output caps debug code
 2012-05-11 03:33:42 -07:00
satok
59f091875c am 5434f464: Remove unexpectedly split words with single quotes 
* commit '5434f46481c6331c3f107e6940cb49ba9dd5ea4d':
  Remove unexpectedly split words with single quotes
 2012-05-11 03:33:41 -07:00
satok
6792a909cd Merge "Output caps debug code" into jb-dev 2012-05-11 03:06:29 -07:00
satok
5434f46481 Remove unexpectedly split words with single quotes 
Bug: 6451163
Change-Id: I4c5595f727934f2b401e9bb11a6ba613668f4a42
 2012-05-11 18:49:29 +09:00
satok
b6fb5eb391 Output caps debug code 
Change-Id: I4a3399d9066bd28dab893ecebb720924110b871d
 2012-05-11 17:37:14 +09:00
Ken Wakasa
369ab4cd01 am 88794b24: Remove the dependency to SpellCheckerProximityInfo from ProximityInfo. 
* commit '88794b24c0928e3bbea59999fce47c78c028863d':
  Remove the dependency to SpellCheckerProximityInfo from ProximityInfo.
 2012-05-11 01:10:45 -07:00
Ken Wakasa
88794b24c0 Remove the dependency to SpellCheckerProximityInfo from ProximityInfo. 
In conjunction with I596b2deb

Change-Id: I42f059158ae78e1c1c807ed4d3688edbcf18c006
 2012-05-11 17:03:06 +09:00
Tadashi G. Takaoka
7dc925bc9a am 684c519d: Merge "Cleanup indentation" into jb-dev 
* commit '684c519d9d72443b9668fa1474ce2970ceb86a4f':
  Cleanup indentation
 2012-05-10 11:56:23 -07:00
Tadashi G. Takaoka
cee24a1f6c Cleanup indentation 
Change-Id: Iaaade378acb81a2d68e2e721778a82fd8d5e20a5
 2012-05-10 17:48:10 +09:00
Tadashi G. Takaoka
d079a0cde5 am bced8270: Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev 
* commit 'bced82709ad262d59ec523439ea7b22b18c5335b':
  Fix calculation of more keys keyboard position based on key preview
 2012-05-09 10:12:50 -07:00
Tadashi G. Takaoka
bced82709a Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev 2012-05-09 06:04:47 -07:00
Tadashi G. Takaoka
7ecc1081ab Fix calculation of more keys keyboard position based on key preview 
Bug: 6135881
Change-Id: Id1c4e2c13d13b474466cb9b42b425aa9f6f9448b
 2012-05-09 21:23:09 +09:00
Tadashi G. Takaoka
46b26ed892 am c8bde75c: Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev 
* commit 'c8bde75cf455c02efc57c2e35bbe446b83c23739':
  Optimize InputConnection.getCursorCapsMode calling
 2012-05-09 01:55:45 -07:00
Jean Chalard
9648b1674e am d5cd7e64: Small optimization 
* commit 'd5cd7e64aa30096241f63e47a9169699bdd98231':
  Small optimization
 2012-05-09 01:55:44 -07:00
Jean Chalard
4e02b1273b am 442ac5d0: Merge "Don\'t ask for surrounding characters for each keypress" into jb-dev 
* commit '442ac5d0bb96ec257d26b28df2fabefdefe59b96':
  Don't ask for surrounding characters for each keypress
 2012-05-09 01:55:43 -07:00
Tadashi G. Takaoka
3b0f0b57ff am f52aef84: Merge "Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified" into jb-dev 
* commit 'f52aef84a582197d6f8e580044b2d24d2a710cef':
  Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
 2012-05-09 01:55:41 -07:00
Tadashi G. Takaoka
c8bde75cf4 Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev 2012-05-09 00:24:00 -07:00
Tadashi G. Takaoka
03ca17c841 Optimize InputConnection.getCursorCapsMode calling 
Bug: 6464226
Change-Id: I30c1b01be5e1719ded5f7f8a7e24a38e9bbc3637
 2012-05-09 16:19:08 +09:00
Jean Chalard
d5cd7e64aa Small optimization 
Change-Id: I067249976e557b60b606d2153deaeb3c8f1f38ac
 2012-05-09 16:14:25 +09:00
Jean Chalard
736b109e16 Don't ask for surrounding characters for each keypress 
Bug: 6464226
Change-Id: I03745bbcc21e5ec6ca57fa1257bf21c0cd26391a
 2012-05-09 15:19:35 +09:00