Commit graph

7875 commits

Author SHA1 Message Date
Yohei Yukawa
a475c85480 Introduce a mechanism to hide the indicator speculatively
This is an optional optimization to reduce the UI latency.

Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.

If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.

This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.

Change-Id: Id59c6607a1029782410611e768791af9984f14ac
2014-08-26 23:42:53 -07:00
Yohei Yukawa
bea17c49ec Introduce commit/add-to-dictionary indicators
This CL introduces commit/add-to-dictionary indicators.

Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.

Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
2014-08-26 21:20:27 -07:00
Ken Wakasa
4660ecaa44 Merge "Fix a bug where mic/emoji key wouldn't work." 2014-08-26 13:30:15 +00:00
Jean Chalard
e38043849e Fix a bug where mic/emoji key wouldn't work.
Bug: 17272902
Bug: 17269948
Change-Id: I561609fa84a6265f8148db7d2411bc1fd38dd163
2014-08-26 22:06:21 +09:00
Jean Chalard
96522da9eb am 2a2d324e: am 8380f921: Fix a bug where the top prediction would disappear.
* commit '2a2d324eb627807a9d09b491fbb4ac78ffb253fc':
  Fix a bug where the top prediction would disappear.
2014-08-26 12:37:17 +00:00
Jean Chalard
8380f921f7 Fix a bug where the top prediction would disappear.
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.

Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
David Faden
9cf69a45b2 Adds documentation for a few methods.
Change-Id: I6bdae25a8b81cdac931f2591f33570b01e34fb2c
2014-08-26 08:08:24 +00:00
Keisuke Kuroyanagi
bf6fc4953b Merge "Get dynamic dict stats via DictionaryFacilitator" 2014-08-25 11:24:54 +00:00
Yohei Yukawa
d8dfac6dcb am abf05cc0: am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev
* commit 'abf05cc0da1ead7e270a7c99bf9f000dabf91f5b':
  Use more descriptive names for some internal fields
2014-08-25 10:16:11 +00:00
Jean Chalard
1a31d784cd Merge "Introduce onEvent() to improve testability" 2014-08-25 09:57:42 +00:00
Yohei Yukawa
fdfe73ff1f Merge "Use more descriptive names for some internal fields" into lmp-dev 2014-08-25 09:50:59 +00:00
Tadashi G. Takaoka
d147db8763 am c500700f: am 19dd34a0: Show view even when IME is explicitly shown with physical keyboard
* commit 'c500700faec11b7a6d54a821009be4d657c43394':
  Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:35:08 +00:00
Yohei Yukawa
a61b7245b0 Use more descriptive names for some internal fields
This CL clarifies that delay parameters are specified with
milliseconds.

Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
2014-08-25 02:28:01 -07:00
Jean Chalard
ee8ebeecbf Merge "Fix unit tests" 2014-08-25 09:26:17 +00:00
Jean Chalard
dc110b2a6a Fix unit tests
Change-Id: I48bfa4e4dd80f36d2fe0a1e9d2a2706533cc722e
2014-08-25 18:19:00 +09:00
Tadashi G. Takaoka
7defe926ca am 4a782da3: am f145fff0: Merge "Fix NPE when pressing ALT key" into lmp-dev
* commit '4a782da382b83164ea5c23c771b771e73bbe31b3':
  Fix NPE when pressing ALT key
2014-08-25 08:25:42 +00:00
Yohei Yukawa
4587b135be am 2d508203: am 8681287c: Fix build due to an illegal character
* commit '2d508203c64f50ed47fb87c24ae5ebbfb0610a36':
  Fix build due to an illegal character
2014-08-25 08:25:35 +00:00
Yohei Yukawa
8c7daa829a am 02716083: am 5eebaddc: Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev
* commit '02716083158c3affbcfc719ff6471112d7397578':
  Dismiss "Add to dictionary" hint with non-special char event
2014-08-25 08:25:34 +00:00
Yohei Yukawa
a5687ee9f7 am b65a1e46: am 2c4cce8d: Merge "Introduce #shouldShowAddToDictionaryHint" into lmp-dev
* commit 'b65a1e46ce06adc462dfc4cbde302ac27a79b695':
  Introduce #shouldShowAddToDictionaryHint
2014-08-25 08:25:33 +00:00
Yohei Yukawa
f6f55add17 am e0d00803: am 4a71d2c4: Allow to add/remove background color to/from the committed text
* commit 'e0d00803087ac2f873332d43a78453c068633545':
  Allow to add/remove background color to/from the committed text
2014-08-25 08:25:31 +00:00
Yohei Yukawa
c06c6e42ad am 7d146cdb: am cd6ef9a8: Indroduce SuggestedWords#getTypedWordInfoOrNull
* commit '7d146cdbe86692f153fb5b7f781f701a8c04050d':
  Indroduce SuggestedWords#getTypedWordInfoOrNull
2014-08-25 08:25:24 +00:00
Jean Chalard
908f0ed154 Introduce onEvent() to improve testability
...and prepare for the future

Change-Id: Ieed96ab552993fd148e80b9c3355f1b569bd716f
2014-08-25 16:33:47 +09:00
Tadashi G. Takaoka
19dd34a023 Show view even when IME is explicitly shown with physical keyboard
Bug: 17242477
Bug: 13988700
Change-Id: I519c0481760a9aa93a5d9bee68e0f6a3a8fc4d9d
2014-08-25 16:28:44 +09:00
Tadashi G. Takaoka
f145fff085 Merge "Fix NPE when pressing ALT key" into lmp-dev 2014-08-25 06:52:36 +00:00
Keisuke Kuroyanagi
9cbf814cb5 Get dynamic dict stats via DictionaryFacilitator
Bug: 16553957
Change-Id: Ida08ceaf34708daed52d61b3d5adfbdb48e42c71
2014-08-25 15:19:48 +09:00
Tadashi G. Takaoka
ad1f880811 Fix NPE when pressing ALT key
Bug: 17203708
Change-Id: I4f203603496e9401dacba4db21372e3353916418
2014-08-25 15:08:27 +09:00
Jean Chalard
dc44260484 Merge "Revert "Revert "[ML1] Introduce RichInputMethodSubtype""" 2014-08-25 05:24:28 +00:00
Jean Chalard
85ddfe1317 Revert "Revert "[ML1] Introduce RichInputMethodSubtype""
This reverts commit a63d0a8ee6.

This patch seems to be fine after all, but was submitted without its companion [ML1.1] patch causing a build breakage. Reverting the revert and submitting both at the same time seems like the right thing to do.

Change-Id: Ib8fefa40b74dcee0edb025a52dac9b35c82d49df
2014-08-25 04:42:15 +00:00
Yohei Yukawa
8681287cd6 Fix build due to an illegal character
Change-Id: I597ab26db70387b80ddcd7d51de6ae751380030d
2014-08-24 21:14:41 -07:00
Yohei Yukawa
5eebaddccb Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev 2014-08-25 04:08:56 +00:00
Yohei Yukawa
ebc1509039 Introduce #shouldShowAddToDictionaryHint
This is a groundwork for subsequent CLs where we need to
call this method from multiple places. This CL does not
change any existing behaviors.

Change-Id: Id8fa0360305d7383571edffab6752b2240367cf9
2014-08-24 20:59:30 -07:00
Yohei Yukawa
034c326078 Dismiss "Add to dictionary" hint with non-special char event
This CL slightly extends the condition when "Add to dictionary"
hint is dismissed.

With this CL, "Add to dictionary hint" will be dismissed by any
non-special char event. This is more comfortable especially if
we start using more intrusive UIs such as indicator and/or
background color with the text hint in the suggestion strip.

Change-Id: I2ea0fa40d9c6663ebf5d5439be3eca2a2cbd5166
2014-08-24 20:32:22 -07:00
Yohei Yukawa
4a71d2c480 Allow to add/remove background color to/from the committed text
This is a groundwork for subsequent CLs where we need to
add/remove background color to/from the commited text.

In this CL, we use Spanned#SPAN_COMPOSING so that we can easily
remove such a background color by calling
InputConnection#finishComposingText. To make this operation easy
and realiable, we need to track whether we have specified the
background color to the commited text or not at one place. Here
we use RichInputConnection for this purpose.

Change-Id: I5f9bc4425c5d1b80a719a20e5baf336729ec08d2
2014-08-24 20:28:24 -07:00
Yohei Yukawa
cd6ef9a8b1 Indroduce SuggestedWords#getTypedWordInfoOrNull
This is a groundwork for subsequent CLs whith need to
do certain things for and only for the typed word.

Change-Id: I374b79cbc79470f57f523c996010301ea5701a61
2014-08-24 16:32:17 -07:00
Tadashi G. Takaoka
560876508f am cc4d21df: am 2637be27: Support Accept typed word UI
* commit 'cc4d21df7b08c3143dd1c4af786609a279a0bb79':
  Support Accept typed word UI
2014-08-22 14:27:26 +00:00
Tadashi G. Takaoka
2637be27c5 Support Accept typed word UI
Change-Id: I58e95b2791a45afdc7dae8e26dcfc200b3b4b854
2014-08-22 21:25:35 +09:00
Jean Chalard
6c638d1bbd Merge "Revert "[ML1] Introduce RichInputMethodSubtype"" 2014-08-22 09:41:46 +00:00
Jean Chalard
a63d0a8ee6 Revert "[ML1] Introduce RichInputMethodSubtype"
This reverts commit 8ffe4bc932.

Change-Id: I9d4c98b0adfdb78b0f4d376f7691e50d1bd2228f
2014-08-22 09:40:27 +00:00
Yohei Yukawa
eb99b461f0 am 96db9222: am cabb66e9: follow-up to API change in I4a577bfd02b37b
* commit '96db9222c2c8c728498751221cc92664676dd4f0':
  follow-up to API change in I4a577bfd02b37b
2014-08-22 09:26:22 +00:00
Keisuke Kuroyanagi
e2ebd5d621 Merge "Add ExpandableBinaryDictionary#getDictionaryStats()." 2014-08-22 09:05:18 +00:00
Jean Chalard
395d778739 Merge "Revert "[HW17] Straighten the dead char implementation."" 2014-08-22 08:20:28 +00:00
Jean Chalard
5bfd661b38 Revert "[HW17] Straighten the dead char implementation."
This reverts commit c6612ff051.

Change-Id: I750d9bff9cb89a6ab13af7a33567c3a0fe2af381
2014-08-22 08:16:28 +00:00
Jean Chalard
f429d8f138 Merge "[ML1] Introduce RichInputMethodSubtype" 2014-08-22 07:42:29 +00:00
Jean Chalard
8ffe4bc932 [ML1] Introduce RichInputMethodSubtype
Bug: 11230254
Change-Id: Ic7a1bf938a5a186dcff527b556295aba2406e8b9
2014-08-22 16:34:27 +09:00
Jean Chalard
1b34985dcf Merge "[HW17] Straighten the dead char implementation." 2014-08-22 07:33:31 +00:00
Mohammadinamul Sheik
698b19ef35 Pass a new argument to StatsUtils.
Change-Id: I61e32c7a455a273e8daf9a5487d7969923802488
Bug: 17013677
2014-08-22 15:58:45 +09:00
Jean Chalard
c6612ff051 [HW17] Straighten the dead char implementation.
This now supports all cases, including cases not supported by
the framework.

Change-Id: I9dfbe2829c28c5bcb64b0b5a2551e7806990c00f
2014-08-22 15:55:32 +09:00
Yohei Yukawa
cabb66e9bc follow-up to API change in I4a577bfd02b37b
BUG: 17182367
BUG: 17185263
Change-Id: Id54ca29c191b9752fa82ffe5a960113b2e97e5c1
2014-08-21 21:39:15 -07:00
Keisuke Kuroyanagi
6f2ddddb5b Add ExpandableBinaryDictionary#getDictionaryStats().
Bug: 16553957
Change-Id: I05866624d0ba9f32ea7a71cb231ba501dde4376c
2014-08-22 12:02:40 +09:00
Tadashi G. Takaoka
ebec5e1338 Merge "Add Hinglish (hi_ZZ) subtype" 2014-08-21 10:22:17 +00:00
Tadashi G. Takaoka
d6696ae78b Add Hinglish (hi_ZZ) subtype
Bug: 17169632
Change-Id: Ibee088d76c2b19f1d62a3c9c119452726e856ec8
2014-08-21 19:12:25 +09:00
Keisuke Kuroyanagi
68a52c1245 Merge "Update FormatSpec.java" 2014-08-21 09:50:38 +00:00
Keisuke Kuroyanagi
c7b6393535 Update FormatSpec.java
Change-Id: I27d14697f931c9511420a459c49312ea6e10c366
2014-08-21 17:23:11 +09:00
Yohei Yukawa
b8337e7232 am 2834ddf1: am b9768702: Merge "Use #onStartInputInternal to initialize cursor rect retrieval" into lmp-dev
* commit '2834ddf1a0c9bea38569429f90bdf7526ba8fa22':
  Use #onStartInputInternal to initialize cursor rect retrieval
2014-08-20 15:52:48 +00:00
Yohei Yukawa
b9768702fa Merge "Use #onStartInputInternal to initialize cursor rect retrieval" into lmp-dev 2014-08-20 01:43:56 +00:00
Yohei Yukawa
9f4f6681a9 Use #onStartInputInternal to initialize cursor rect retrieval
This CL simply moves the method calls of #requestCursorAnchorInfo
into #onStartInputInternal just to consolidate the logic.

Change-Id: Ia205738b9614e9ae375c1dab767a91d2e1f6d0d3
2014-08-21 00:21:57 +09:00
Yohei Yukawa
fa39ffcf84 Support more methods in the wrapper of CursorAnchorInfo
This CL add more compatibility wrapper methods for
CursorAnchorInfo.

This CL also adds more utility functions and types into
CompatUtils to reduce explict cast operations.

Change-Id: Id50165b552bbf28b832a6da13bf06eedcd2a190e
2014-08-20 09:27:22 +09:00
Ken Wakasa
c37205f5ab Merge "DO NOT MERGE: Abolish source code overlay and introduce overridable src dir" into lmp-dev 2014-08-16 04:25:55 +00:00
Ken Wakasa
0b3e48fb50 DO NOT MERGE: Abolish source code overlay and introduce overridable src dir
This should make IDEs happy with appropriate source code directory
selection.

Change-Id: Ic734bd4d20aa050c688a3158b1a382ae0ac18991
(cherry picked from commit fb74ab15c1)
2014-08-20 02:56:09 +00:00
Yohei Yukawa
3cf13d1267 am 17aeaa75: am fa39ffcf: Support more methods in the wrapper of CursorAnchorInfo
* commit '17aeaa75780591f1bf7fefcc887869fd90c88a9f':
  Support more methods in the wrapper of CursorAnchorInfo
2014-08-20 05:04:07 +00:00
Ken Wakasa
9be350bc21 Merge "Abolish source code overlay and inroduce overridable src dir" 2014-08-16 04:15:21 +00:00
Keisuke Kuroyanagi
ffaa9c2a71 Merge "Add language to PersonalizationDataChunk." 2014-08-16 04:12:14 +00:00
Keisuke Kuroyanagi
e66d59e6d8 Add language to PersonalizationDataChunk.
Bug: 16547557
Change-Id: I11b82667631cbd5263cc08ccb304fc97bf692050
2014-08-19 18:27:34 +09:00
Jean Chalard
8adf5e8a70 Have the "add to dictionary" hint display the right word
Before this, we display the word we have committed instead
of the word we will actually insert into the personal dictionary.
There is a difference when the word was typed with auto-caps.

Bug: 17071785
Change-Id: I2bfec0402b1307934590a78ab5c25104d92b75ca
2014-08-18 20:43:40 +09:00
Yohei Yukawa
c9240d280c am 18ac3c8a: am 16a43d2b: Let the backing view cover the entire content area
* commit '18ac3c8afd06c237a2935abad130aa3b99b5004b':
  Let the backing view cover the entire content area
2014-08-16 14:02:21 +00:00
Yohei Yukawa
16a43d2bd9 Let the backing view cover the entire content area
With this CL, the backing view starts covering the content area
entirely.  This allows the IME to render its UI elements at an
arbitrary position on the screen.

Change-Id: I8b4173410931b776964dddf66de2fe247e51d9de
2014-08-16 12:28:13 +09:00
Ken Wakasa
fb74ab15c1 Abolish source code overlay and inroduce overridable src dir
This should make IDEs happy with appropriate source code directory
selection.

bug: 16829244
Change-Id: Ic734bd4d20aa050c688a3158b1a382ae0ac18991
2014-08-16 03:37:54 +09:00
Jean Chalard
3dbc3ece26 am e04c8b10: am b8d76477: Add the input style to SuggestedWords.
* commit 'e04c8b10d7876effbfdf2340a1fec6bf368c3409':
  Add the input style to SuggestedWords.
2014-08-14 18:10:05 +00:00
Jean Chalard
b8d764772b Add the input style to SuggestedWords.
Change-Id: I81f37d08659d449822b027d3d5912e11eec8b8ff
2014-08-14 17:53:04 +09:00
Tadashi G. Takaoka
af078ce7b4 am 1901c331: am a94c89e0: Use light emoji icon for Material light tablet keyboard
* commit '1901c331283e2f60e6277a7773a103a447bd31ca':
  Use light emoji icon for Material light tablet keyboard
2014-08-13 15:54:51 +00:00
Tadashi G. Takaoka
a94c89e017 Use light emoji icon for Material light tablet keyboard
Bug: 16808603
Change-Id: I39ce0ed8b5580754dfd0cf1494289b0a23863d50
2014-08-14 00:25:34 +09:00
Yohei Yukawa
d9a8e1ccfd Enable CursorAnchorInfo callback when necessary
Change-Id: If3dda7442418053600ac935da50baaddb0e31d37
2014-08-13 20:02:14 +09:00
Yohei Yukawa
6e7806bc00 Add stub implementation of #onUpdateCursorAnchorInfo
This CL never changes existing behavior because
ProductionFlags.ENABLE_CURSOR_ANCHOR_INFO_CALLBACK is
not yet turned on.

Change-Id: I4bcbd2aebd05977b07231e8aa14acdcf6d8e1fa0
2014-08-13 19:36:23 +09:00
Tadashi G. Takaoka
c225d2e29c Add setting boolean for showing UI to accept typed word
Change-Id: Iedd90d07b904362d9debc9994ce86cd78a0303b9
2014-08-13 17:29:49 +09:00
Tadashi G. Takaoka
a696c92477 (DO NOT MERGE) Add debug setting to force hardware special key
Bug: 13988700
Change-Id: If23f8a14097431e76a303a6d6c24e8d9835fb655
(cherry picked from commit 3659c70fc3)
2014-08-13 08:04:54 +00:00
Tadashi G. Takaoka
78cff10f8d Add BuildCompatUtils to get an effective platfrom API version
This CL removes reference of VERSION_CODES.CUR_DEVELOPMENT.

Bug: 13888366
Change-Id: I5c8499a175473a220c8fb04ead219760c585a19a
2014-08-13 16:21:23 +09:00
Tadashi G. Takaoka
8f3e778a21 Revert "Remove reference of VERSION_CODES.CUR_DEVELOPMENT"
This reverts commit 5380acfd04.

Bug: 13888366
Change-Id: Iae0fb6798cef9d59c9de3790123f6acaf8b2746b
2014-08-13 04:00:36 +00:00
Yohei Yukawa
85ce863d19 am 4a2dbd87: am d9a8e1cc: Enable CursorAnchorInfo callback when necessary
* commit '4a2dbd87c4a49afbe40a61028ff338e2864554ed':
  Enable CursorAnchorInfo callback when necessary
2014-08-13 11:38:19 +00:00
Yohei Yukawa
bec6c6e306 am 3a346bf5: am 6e7806bc: Add stub implementation of #onUpdateCursorAnchorInfo
* commit '3a346bf51c441b9b62f0cee364940c2d4661c72c':
  Add stub implementation of #onUpdateCursorAnchorInfo
2014-08-13 10:55:00 +00:00
Tadashi G. Takaoka
f8f83c24ca am 43b8646a: am c225d2e2: Add setting boolean for showing UI to accept typed word
* commit '43b8646a31573ef3ce8efbbaf46c3d72d8c5deca':
  Add setting boolean for showing UI to accept typed word
2014-08-13 09:21:32 +00:00
Tadashi G. Takaoka
26233cddee Merge "Add debug setting to force hardware special key" 2014-08-12 23:14:48 +00:00
Tadashi G. Takaoka
089371b649 am bdb05cc8: am 78cff10f: Add BuildCompatUtils to get an effective platfrom API version
* commit 'bdb05cc89f63f4f3956936fa062d0b4555aa072a':
  Add BuildCompatUtils to get an effective platfrom API version
2014-08-13 07:52:52 +00:00
Tadashi G. Takaoka
3659c70fc3 Add debug setting to force hardware special key
Bug: 13988700
Change-Id: If23f8a14097431e76a303a6d6c24e8d9835fb655
2014-08-13 15:33:07 +09:00
Tadashi G. Takaoka
4ac551d189 am 7edc27f1: am 8f3e778a: Revert "Remove reference of VERSION_CODES.CUR_DEVELOPMENT"
* commit '7edc27f17b450e690f08a972c4573b92b39ef7ee':
  Revert "Remove reference of VERSION_CODES.CUR_DEVELOPMENT"
2014-08-13 05:28:51 +00:00
Keisuke Kuroyanagi
82be1873f1 Merge "Add additional wait for writing file in testAddManyWords()." 2014-08-12 23:14:42 +00:00
Tadashi G. Takaoka
89a2145448 am a70542a5: am 5380acfd: Remove reference of VERSION_CODES.CUR_DEVELOPMENT
* commit 'a70542a5ef2c7f4d5cfe62150ed17be3776904c5':
  Remove reference of VERSION_CODES.CUR_DEVELOPMENT
2014-08-12 15:02:59 +00:00
Tadashi G. Takaoka
5380acfd04 Remove reference of VERSION_CODES.CUR_DEVELOPMENT
Bug: 13888366
Change-Id: I0b829e2cf9a11c694cf01b6f02753233c9c85105
2014-08-12 23:13:18 +09:00
Keisuke Kuroyanagi
9f584e15eb Add additional wait for writing file in testAddManyWords().
Change-Id: Ibb79b9821dac3d48e18c684e8aca605254bec045
2014-08-12 22:29:02 +09:00
Jatin Matani
0807c897f4 Make SettingsValues non-final to testability
Add getter for enableMetricsLogging boolean.

Bug:16522256
Change-Id: Ie9a38efc7861b3d4207562d2bf0344c5c2ae957a
2014-08-11 16:33:01 -07:00
Yohei Yukawa
89e8cba6ae Merge "Add CursorAnchorInfoCompatWrapper for KitKat and older platforms" into lmp-dev 2014-08-11 19:46:21 +00:00
Tadashi G. Takaoka
499153734e (DO NOT MERGE) Add SpecialkeyDetector
Bug: 13988700
Change-Id: I215e879ad33b149370c1d0a5fdcf2203c0fc8b4a
(cherry picked from commit 34541bfeb6)
2014-08-12 10:14:41 +00:00
Tadashi G. Takaoka
8fdff5a111 (DO NOT MERGE) Show InputView even when hardware keyboard is connected
Bug: 13988700
Change-Id: I4aeb01bf3571afc97959c213474a6424d7896120
(cherry picked from commit 06514f00f4)
2014-08-12 10:03:47 +00:00
Yohei Yukawa
deff9495f7 Add CursorAnchorInfoCompatWrapper for KitKat and older platforms
Change-Id: Ia26c783ebefd7b928d623a598792b7ba32d89a80
2014-08-12 17:26:56 +09:00
Tadashi G. Takaoka
016d6c424c Auto scale-X text of key popup preview
Bug: 9978106
Change-Id: I335fa3117ac2af2cb8220c4827dd54c1a1da4c5c
2014-08-12 12:17:40 +09:00
Yohei Yukawa
0ba23b3ab3 am 6a5cba26: am 89e8cba6: Merge "Add CursorAnchorInfoCompatWrapper for KitKat and older platforms" into lmp-dev
* commit '6a5cba2695cc82707535845d6265ddc7d92a79ed':
  Add CursorAnchorInfoCompatWrapper for KitKat and older platforms
2014-08-12 11:08:47 +00:00
Tadashi G. Takaoka
1fc4d5aab3 Merge "Add SpecialkeyDetector" 2014-08-11 19:46:21 +00:00
Tadashi G. Takaoka
34541bfeb6 Add SpecialkeyDetector
Bug: 13988700
Change-Id: I215e879ad33b149370c1d0a5fdcf2203c0fc8b4a
2014-08-12 19:08:58 +09:00
Tadashi G. Takaoka
06514f00f4 Show InputView even when hardware keyboard is connected
Bug: 13988700
Change-Id: I4aeb01bf3571afc97959c213474a6424d7896120
2014-08-12 18:44:05 +09:00
Tadashi G. Takaoka
ef2c537e59 Merge "Show InputView even when hardware keyboard is connected" 2014-08-11 18:59:25 +00:00
Tadashi G. Takaoka
2ae42d7861 am 3d477a73: am 016d6c42: Auto scale-X text of key popup preview
* commit '3d477a73afac2449794d953f00dd3411210b1b81':
  Auto scale-X text of key popup preview
2014-08-12 04:33:01 +00:00
Tadashi G. Takaoka
25906373ff Fix Tamil keyboard
This CL adds Tamil (Sri Lanka) and Tamil (Singapore) subtypes.
This CL also fixes Sinhala Keyboard's currency symbol.

Bug: 9978106
Bug: 6911143
Change-Id: I2060978097882d0f4b1ec10f1103260ed8a447d0
2014-08-11 18:07:27 +09:00
Ken Wakasa
f729f2214f Help & feedback should be the very last item in the menu
bug: 16717930

Change-Id: I7ce73fe067bb7f9a639b414875780c39bb1de12d
2014-08-08 21:26:51 +09:00
Keisuke Kuroyanagi
a848c09485 Merge "Rename distracter filter class." into lmp-dev 2014-08-07 16:37:11 +00:00
Keisuke Kuroyanagi
e05eb21826 Rename distracter filter class.
Bug: 13142176
Bug: 15531638
Change-Id: I89cef5264073eed25ffb5be10fdff731df0a3138
2014-08-08 17:01:19 +09:00
Keisuke Kuroyanagi
33ca0c80c1 Use suggestions in the distracter filter.
Bug: 13142176
Bug: 15531638

Change-Id: I609fa61fccf2a0c738726985806b7d9248eadf49
2014-08-08 17:01:16 +09:00
Keisuke Kuroyanagi
6fef4ff00d Merge "Use suggestions in the distracter filter." into lmp-dev 2014-08-07 16:56:07 +00:00
Ken Wakasa
83a96fe5c7 Initial implementation of Help & feedback
bug: 16717930

Change-Id: Iddc8e831c3f01ec7eb02ed1bc5d5e103d497e177
2014-08-08 12:58:31 +09:00
Tadashi G. Takaoka
db776143d9 Revert "Revert "Align hint label to bottom""
This reverts commit 02c4a80afe.
2014-08-07 23:44:34 +09:00
Tadashi G. Takaoka
f7f6574368 Revert "Revert "Remove unused Key and Keyboard attributes""
This reverts commit 44e20f4fb4.

Change-Id: I6560c8f4ef15bf8318d9eedf68a9eb5031f0581d
2014-08-07 23:36:57 +09:00
Tadashi G. Takaoka
0b5d12c6b4 Revert "Revert "Add Key label off center attribute""
This reverts commit 787e9a37b4.

Change-Id: I177b8f5d08eb487c19180c09101cc073222c4efe
2014-08-07 14:31:47 +00:00
Ken Wakasa
787e9a37b4 Revert "Add Key label off center attribute"
This reverts commit ba49920e80.

Due to unit test breakage.

Bug: 14419121
Change-Id: I6f4fc30b86227e59c883d202551b162dc91b4166
2014-08-07 11:38:36 +00:00
Ken Wakasa
5f57fe4ad0 Merge "Revert "Remove unused Key and Keyboard attributes"" into lmp-dev 2014-08-05 00:03:09 +00:00
Ken Wakasa
44e20f4fb4 Revert "Remove unused Key and Keyboard attributes"
This reverts commit cdcaa37a37.

Due to unit test breakage.

Change-Id: I1c22edf983f6e03a34b86d7c1fae3d3188447a75
2014-08-07 11:37:11 +00:00
Tadashi G. Takaoka
cdcaa37a37 Remove unused Key and Keyboard attributes
This CL removes the following unused Key attributes
- Key.keyLabelFlags' followKeyLargeLabelRatio
- Keyboard.keyLargeLabelRatio

Change-Id: Ib4fb13cc7ca902ac1733ecf27bd284d07e10bc3e
2014-08-07 17:23:37 +09:00
Tadashi G. Takaoka
e19c520b41 Align space key icon to bottom of a key
The Key.keyLabelFlags's flag "alignButtom" (misspelled) has been
removed by Iae3cd66744. This CL re-introduce the same flag with
"alignIconToBottom".

Bug: 16803172
Change-Id: I412590f394c6ca9b36358d6acfe8675071403bdd
2014-08-07 12:42:27 +09:00
Ken Wakasa
3316dcd453 Merge "Revert "Introduce onEvent() to improve testability"" into lmp-dev 2014-08-05 00:07:36 +00:00
Ken Wakasa
f5f5fb4b64 Revert "Introduce onEvent() to improve testability"
This reverts commit ef74e737f5.

Apparently, this CL broke several unit tests.

Change-Id: I86cf5f1ffb0214707afe99ee97f92ba8c5157f3f
2014-08-06 23:57:03 +00:00
Jean Chalard
ef74e737f5 Introduce onEvent() to improve testability
...and prepare for the future

Change-Id: Ieed96ab552993fd148e80b9c3355f1b569bd716f
2014-08-06 07:29:35 +00:00
Jean Chalard
1f3d89c2af Revert "[HS1] Save some data in startInputView"
This reverts commit f1accd4f04.

Bug: 16830599
Change-Id: I4c9367f742b8ee8463920e91263b05c2195f8480
2014-08-06 18:36:55 +09:00
Jean Chalard
772a8019ef Revert "[HS2] Move more stuff to onStartInput"
This reverts commit 93b00a314e.

Bug: 16830599
Change-Id: I955e7da77978c3a495660aa29247e010d489c36b
2014-08-06 18:36:29 +09:00
Tadashi G. Takaoka
5dee1fd67d Merge "Add dedicated background for custom action label key" into lmp-dev 2014-08-05 00:07:36 +00:00
Tadashi G. Takaoka
017e9f7e7f Add dedicated background for custom action label key
Bug: 15526978
Change-Id: Ia73d825c7e00097018822704e61272d0e448f39a
2014-08-06 17:23:14 +09:00
Tadashi G. Takaoka
aa3ff194cd Merge "Use add icon for add custom input style menu" into lmp-dev 2014-08-05 00:07:36 +00:00
Tadashi G. Takaoka
f7d1dc2b5e Use add icon for add custom input style menu
Bug: 16805043
Change-Id: I9730a6aa5d761924457edaabcee25db930e20f02
2014-08-06 11:38:45 +09:00
Jean Chalard
c08c506487 Merge "Fix an NPE when running with Keep." into lmp-dev 2014-08-05 00:07:36 +00:00
Jean Chalard
411fa5909b Fix an NPE when running with Keep.
Change-Id: Ie703e14bff42d34608f11d0c2d7758950b84c88c
2014-08-06 13:00:05 +09:00
Jean Chalard
9273f3832b [HS3] Fix a bug on ICS
There is a bug in ICS where the input connection won't take
any writing commands after rotation until the cursor moves.
This fixes it by wiggling the cursor position once before trying
to do anything.

Bug: 16810766
Change-Id: Ib14c70bd0550420cecfa86dea501d13a1a91e296
2014-08-06 11:38:11 +09:00
Jean Chalard
93b00a314e [HS2] Move more stuff to onStartInput
Bug: 8152758
Change-Id: Ida05df7d151ceb582886e2ad06c5bdf0b59978ee
2014-08-06 11:14:47 +09:00
Tadashi G. Takaoka
a262144dcb Add ViewCompatUtils.setElevation
Bug: 16210054
Change-Id: I632158951a60ab527246410caefd9fbe471dd859
2014-08-05 18:56:24 +09:00
Jean Chalard
6474ef9925 Merge "[HW16] Implement processing event chains." into lmp-dev 2014-08-05 00:07:36 +00:00
Jean Chalard
0a2872cb44 [HW16] Implement processing event chains.
Change-Id: I4e1e4f101050ebda77c629a61c548d3c8efb330f
2014-08-05 15:37:01 +09:00
Jean Chalard
f69bb4c7a3 [HW15] Pass events instead of reading them from the transaction
It's probably cleaner to just pass the events rather than read
them from a transaction, especially when a transaction may be
associated with several events in a chain.

Change-Id: I27830f0f3f3f32fe77ea8b9cad505b7ebee648af
2014-08-05 15:37:01 +09:00
Ken Wakasa
1c7e6f8d6e Merge "Revert "Align hint label to bottom"" into lmp-dev 2014-08-04 23:56:40 +00:00
Ken Wakasa
02c4a80afe Revert "Align hint label to bottom"
This reverts commit f1784266ec.

Due to unit test breakage.

Bug: 14419121
Change-Id: Ibc201649e71135292530b26337d9305a6681f446
2014-08-07 11:35:26 +00:00
Tadashi G. Takaoka
f1784266ec Align hint label to bottom
Bug: 14419121
Change-Id: I9147d3c4a3687ed745ffdddfff221d88652919b2
2014-08-07 18:42:47 +09:00
Tadashi G. Takaoka
8cbb4eb984 Merge "Make popup hint letter theme-aware" into lmp-dev 2014-08-04 23:56:40 +00:00
Tadashi G. Takaoka
3410e16907 Make popup hint letter theme-aware
Bug: 16351091
Change-Id: I6af18ea210c00916157138b9cfbeb073aee6ca1b
2014-08-05 17:32:53 +09:00
Keisuke Kuroyanagi
b6665d958a Merge "Use DistracterFilterCheckingIsInDictionary for User History" into lmp-dev 2014-08-04 23:56:40 +00:00
Keisuke Kuroyanagi
87ab5b0518 Use DistracterFilterCheckingIsInDictionary for User History
Bug: 13142176
Bug: 15531638
Change-Id: I7e4e5afa05c5cee6eedef62c053d81edac5fa6af
2014-08-07 18:39:06 +09:00
Tadashi G. Takaoka
6ba5d63628 Merge "Remove unused Key and Keyboard attributes" into lmp-dev 2014-08-04 23:56:40 +00:00
Tadashi G. Takaoka
ba49920e80 Add Key label off center attribute
This CL adds two Key attributes to control how much a label should be
off centered.
- keyLabelOffCenterRatio
- keyHintLabelOffCenterRatio

Bug: 14419121
Change-Id: I26650eefdd375f0eeca8a1ca6034a8339d2a3182
2014-08-07 14:39:57 +09:00
Jean Chalard
1b9f7c962c Merge "[HW14] Cleanup" into lmp-dev 2014-08-04 23:56:40 +00:00
Jean Chalard
dd31a2dedf [HW14] Cleanup
Do away with the didAutoCorrect local variables which are
unnatural to return out of all these functions.

Change-Id: I22024004d2c489de018beff812c2c589bfd8ca32
2014-08-05 12:59:55 +09:00
Jean Chalard
a88e95e07e [HW13] Split up onCodeInput
Change-Id: I503c5403dcaea5db632eba85ae3fae9ba9a1f946
2014-08-05 12:59:36 +09:00
Jean Chalard
c710b34e34 Merge "[HW13] Split up onCodeInput" into lmp-dev 2014-08-05 00:03:09 +00:00
Jean Chalard
f1accd4f04 [HS1] Save some data in startInputView
Bug: 8152758
Change-Id: Ic57d3918b08e775769d4ba5d73ba5c31231e0d6a
2014-08-04 22:40:21 +09:00
Jean Chalard
85b7b967b7 Merge "[HW12] Use the consumed status of the Event." into lmp-dev 2014-08-01 16:06:20 +00:00
Jean Chalard
e0bad8e988 [HW12] Use the consumed status of the Event.
Change-Id: I1619f6132f8f71bc1291fd6a5604a5e1e3431ae2
2014-08-04 12:41:07 +09:00
Tadashi G. Takaoka
03a1c442ae Clean up compatible utility classes
Change-Id: I95a682052037d292801477db0f05e04926b61412
2014-08-04 01:21:29 +00:00
Jean Chalard
da5ccd9f18 [HW11] Cleanup
Change-Id: Ia866d3f9a5981c687766f8c39979fb6091018e44
2014-07-31 18:33:30 +09:00
Jean Chalard
00ee5f7697 [HW10] Pull the processed event in its eventual place
Change-Id: I5f7932097627766e907764a99a5e9c170f725bc0
2014-07-31 09:10:24 +00:00
Jean Chalard
f290d4073a [HW9] Pull the processed event further.
The 'processedEvent' variables will ultimately disappear entirely.

Change-Id: I612c5ce7dedc341b64921a86ac028fe91b75359b
2014-07-31 09:10:03 +00:00
Jean Chalard
69b68b5916 Fix some unit tests.
The default value for the script needs to be Latin, as we don't specify
it in the files.

Change-Id: I1275f13f1cd92f00dc5708748fefb4982f0a60b3
2014-07-31 12:29:35 +09:00
Jean Chalard
86893a3b3f [HW8] Pull up the processed event.
Change-Id: I18021b7ec1588fc52533c48b7d8774bec7764822
2014-07-30 08:39:46 +00:00
Tadashi G. Takaoka
f4a3fd4893 Merge "Disptach hover events when sliding suggestion mode" into lmp-dev 2014-07-24 16:04:26 +00:00
Jean Chalard
ae4e203625 [SD13] Reorder an enum alphabetically
Change-Id: I907041b09e5bfce537ed4f592947b2cec8cef4ac
2014-07-30 15:58:43 +09:00
Jean Chalard
3a729d4ed8 [SD12] Add the last remaining scripts
Add scripts for Bengali, Devanagari, Kannada, Malayalam,
and Tamil.
Also include a very minor fix for Arabic.

This concludes work on:
Bug: 15840116

Change-Id: Iade313fc70030a67c68d424d8cb0cac245b883d1
2014-07-30 15:58:43 +09:00
Jean Chalard
7c5cd5ec89 [SD11] Add script checks for Myanmar, Sinhala, Thai and Telugu
Bug: 15840116
Change-Id: I1264fdeea0d4739ca0f360f4934d06e5a824d4e5
2014-07-30 15:58:43 +09:00
Tadashi G. Takaoka
da232a70a8 Disptach hover events when sliding suggestion mode
Bug: 15687702
Change-Id: I7ace1fbbba724c6e422230a3d88f8cc9ffa8efc2
2014-07-30 14:55:53 +09:00
Ken Wakasa
7f545a57c9 [HW7.5] Introduce the @Nonnull annotation (take 2)
Change-Id: I05512b5434810046c8b72d6bb41567b6cd8b9d6e
2014-07-30 04:13:58 +00:00
Jean Chalard
0304c77750 Merge "[SD10] Add script checks for Lao and Khmer" into lmp-dev 2014-07-24 16:04:26 +00:00
Jean Chalard
a9c12692ed [SD10] Add script checks for Lao and Khmer
Bug: 15840116
Change-Id: Id72b739e73cb3e72f56e1872ad9d60469555e193
2014-07-30 12:02:37 +09:00
Jean Chalard
8e38b12e9c [HW7] Introduce consumed events
Change-Id: I692c35b8e701d5a84500b949884472545b1f424d
2014-07-30 11:37:19 +09:00
Jean Chalard
7196566d4f [HW6] Split processing and applying the event.
...take 2

Change-Id: I9d13b6d51e13ce2e76ae3febebfb8c310eba509d
2014-07-30 11:06:43 +09:00
Ken Wakasa
c4f6fc1e48 Merge "Revert "[HW6] Split processing and applying the event."" into lmp-dev 2014-07-24 16:04:26 +00:00
Ken Wakasa
4399849dea Revert "[HW6] Split processing and applying the event."
This reverts commit 1db3d860ca.

Reverting due to a few critical bugs and unit test failures.

Change-Id: I5e2d02300320438ef9c29577ec5b0860ea91d822
2014-07-30 00:55:49 +00:00
Jean Chalard
1db3d860ca [HW6] Split processing and applying the event.
If anyone has better names for those...

Change-Id: Ia2dfc75381816bd688948647e2c50c10657b9e89
2014-07-29 17:40:48 +09:00
Tadashi G. Takaoka
76cffec788 Show "navigate up" icon on settings activity
Bug: 15813742
Change-Id: I8b1feb5c35377e62199e5a909640d9c50f970654
2014-07-29 12:05:48 +09:00
Ken Wakasa
9fbeeb609f Merge "Revert "[HW7] Introduce consumed events"" into lmp-dev 2014-07-24 16:04:26 +00:00
Ken Wakasa
bfa6f9533c Revert "[HW7] Introduce consumed events"
This reverts commit 99aff0af98.

Reverting due to a few critical bugs and unit test failures.

Change-Id: Id41d802981d079f17134a03cc30ab36a3cdd4ac1
2014-07-30 00:53:24 +00:00
Jean Chalard
99aff0af98 [HW7] Introduce consumed events
Change-Id: Ic2d95d19b1ac66e3e97e4a16187ce5aecb4ac678
2014-07-29 17:49:14 +09:00
Keisuke Kuroyanagi
c6862ee699 Merge "Allow adding DICTIONARY_MAX_WORD_LENGTH-length words." into lmp-dev 2014-07-25 11:19:20 +00:00
Keisuke Kuroyanagi
d9a8f2a82f Allow adding DICTIONARY_MAX_WORD_LENGTH-length words.
Bug: 12725817
Change-Id: Ib9b30473ba94242a7b97ccd3b850068f596a5d17
2014-07-28 21:48:02 +09:00
Tadashi G. Takaoka
ab661e3ef8 Make "Show correction suggestions" as a binary option
Formerly "Show correction suggestions" had three options, "always
show", "show in portrait mode", and "always hide". The reason behind
"show in portrait mode" was that there may not be enough screen estate
in landscape mode to show suggestions. Because recent phone devices
have relatively large screen, we decide to remove "show in portrait
mode" option.

Bug: 15780939
Change-Id: I896d737452c3893d43ce20bd88127f10c1eb3d83
2014-07-27 14:47:07 +09:00
Ken Wakasa
2ce8799fa8 Merge "Revert "[HW8] Pull up the processed event."" into lmp-dev 2014-07-24 16:04:26 +00:00
Ken Wakasa
76fc4914b3 Revert "[HW8] Pull up the processed event."
This reverts commit ebdd641d58.

Reverting due to a few critical bugs and unit test failures.

Change-Id: Ie7958d749dc813c1752d03aec7f14f5586225ff7
2014-07-30 00:31:57 +00:00
Jean Chalard
ebdd641d58 [HW8] Pull up the processed event.
Change-Id: If4baba0af2e88627f22b5e7312948fc3d9c5a25f
2014-07-29 17:49:24 +09:00
Jean Chalard
60a2cd8ac4 [HW7.5] Introduce the @Nonnull annotation
Change-Id: I1f69ea704056943fa3371ff610e2d8181ead2376
2014-07-29 17:49:19 +09:00
Jean Chalard
036b83f4c4 Merge "Wait for an event before actually realizing it" into lmp-dev 2014-07-25 11:19:20 +00:00
Jean Chalard
3d951c1eff Wait for an event before actually realizing it
This would wrongly emit a 'timeout' log entry when switching
between two instances of the same language.

Change-Id: I56e5de121b87f3e762b58f0b2a77e9abc784036e
2014-07-28 19:33:49 +09:00
Ken Wakasa
dc0c3e1e2a Merge "Revert "[HW9] Pull the processed event further."" into lmp-dev 2014-07-24 16:04:26 +00:00
Ken Wakasa
e2397e54c6 Revert "[HW9] Pull the processed event further."
This reverts commit a8d80ec012.

Reverting due to a few critical bugs and unit test failures.

Change-Id: I3f49b54f34d875e8986d6ddc2523ab0b706dc6f2
2014-07-30 00:31:12 +00:00
Jean Chalard
a8d80ec012 [HW9] Pull the processed event further.
The 'processedEvent' variables will ultimately disappear entirely.

Change-Id: If44c68c1116faa9ca23e4ffeabe320704431ab3c
2014-07-29 18:38:49 +09:00
Ken Wakasa
e8ca3f4091 Merge "Revert "[HW10] Pull the processed event in its eventual place"" into lmp-dev 2014-07-25 11:19:20 +00:00
Ken Wakasa
79fd911c8d Revert "[HW10] Pull the processed event in its eventual place"
This reverts commit bcb61da581.

Reverting due to a few critical bugs and unit test failures.

Change-Id: I5f7ee2c7883496ed36e56b3ef12fac91f85f9866
2014-07-30 00:29:41 +00:00
Jean Chalard
bcb61da581 [HW10] Pull the processed event in its eventual place
Change-Id: I9e13bb3efad557e9199021a344d8dff8215d97fa
2014-07-29 18:48:13 +09:00
Jean Chalard
312c9498be Merge "[HW8] Pull up the processed event." into lmp-dev 2014-07-25 11:19:20 +00:00
Tadashi G. Takaoka
1e491d90f9 Merge "Use fragment for advanced preference screen" into lmp-dev 2014-07-24 16:04:26 +00:00
Tadashi G. Takaoka
9bdcb13160 Use fragment for advanced preference screen
Bug: 16522808
Change-Id: If4a2ad7a7dfecc7019bf78ad37d93fa8f37cf21e
2014-07-28 19:24:41 +09:00
Ken Wakasa
666f1b384f Merge "Revert "[HW7.5] Introduce the @Nonnull annotation"" into lmp-dev 2014-07-24 16:04:26 +00:00
Ken Wakasa
8aa74da98d Revert "[HW7.5] Introduce the @Nonnull annotation"
This reverts commit 60a2cd8ac4.

Reverting due to build breakage under the unbundled branch.

Change-Id: Iab2988c53884166f62c95da920ac7a7079a0e5a0
2014-07-29 15:43:59 +00:00
Jean Chalard
3c7cb5234f Merge "[HW7.5] Introduce the @Nonnull annotation" into lmp-dev 2014-07-24 16:04:26 +00:00
Jean Chalard
3042452170 Merge "[HW7] Introduce consumed events" into lmp-dev 2014-07-25 11:19:20 +00:00
Tadashi G. Takaoka
a715d7f6fd Use fragment for keyboard theme settings
Bug: 11866784
Change-Id: Ic50b6eb1bd8f2b823e2c9dfad04d8615bc910936
2014-07-29 18:19:20 +09:00
Keisuke Kuroyanagi
fb15b768dd Merge "Fix NPE when context.getFilesDir() returns null." into lmp-dev 2014-07-24 16:04:26 +00:00
Keisuke Kuroyanagi
79ff803cb0 Fix NPE when context.getFilesDir() returns null.
Bug: 16416948
Change-Id: I0fac5ab26d6efbadbd688d033a79f6705e0161a5
2014-07-28 19:25:07 +09:00
Tadashi G. Takaoka
9ba854133c Merge "Refactor Debug settings to use SubScreenFragment" into lmp-dev 2014-07-24 16:04:26 +00:00
Tadashi G. Takaoka
99295c8c5f Refactor Debug settings to use SubScreenFragment
Bug: 16522808
Change-Id: I741e2fbc5f0a62c7d4ae00e603eef52cc2a6d086
2014-07-28 19:16:42 +09:00
Tadashi G. Takaoka
00b49cad9c Use fragment for text correction preference screen
Bug: 16522808
Change-Id: Ia8ce83b0e69cc8157f7b8cefcfeb863eb85ee4b4
2014-07-28 17:48:49 +09:00
Tadashi G. Takaoka
3c8a075a58 Use fragment for gesture typing preference screen
Bug: 16522808
Change-Id: Ib8c2997466bb006c6b5d4e980344507b822d0023
2014-07-28 17:45:41 +09:00
Tadashi G. Takaoka
6b71530017 Use fragment for multi lingual preference screen
Bug: 16522808
Change-Id: I0bfac43513e1fb85b5d4c07f56dd4c5b82f75ed1
2014-07-28 17:20:16 +09:00
Tadashi G. Takaoka
bfcd98edc7 Use fragment for input preference screen
This CL introduces a common abstract class, SunScreenFragment, for
PreferenceFragment that implements a PreferenceScreen of the main
settings preference screen.

Bug: 16522808
Change-Id: I11fba71b5e9f96208b261e0c0314de8a41720d0f
2014-07-27 16:06:52 +09:00
Tadashi G. Takaoka
633f1a5e6e Merge "Use fragment for text correction preference screen" into lmp-dev 2014-07-24 16:04:26 +00:00
Tadashi G. Takaoka
a484dc84d9 Merge "Use fragment for gesture typing preference screen" into lmp-dev 2014-07-24 16:04:26 +00:00
Tadashi G. Takaoka
1da4385493 Merge "Use fragment for multi lingual preference screen" into lmp-dev 2014-07-24 16:04:26 +00:00
Jean Chalard
6d7a08107c Merge "Fix a verifier error on ICS." into lmp-dev 2014-07-24 16:04:26 +00:00
Jean Chalard
da70b90aa7 Fix a verifier error on ICS.
Bug: 16530557
Change-Id: I271c5884995a1d5f8a1cb7aee6f52d17fabb9e72
2014-07-28 17:33:52 +09:00
Tadashi G. Takaoka
a270ac4a61 Remove unnecessary DebugSettingsActivity, use fragment directly
This CL must be checked in together with I1db2e848ab.

Bug: 16522808
Change-Id: I08a1b0c300c504def609cbb53462d215d1ead15c
2014-07-23 17:09:46 -07:00
Yohei Yukawa
3f513f107e Enable InputMethodService#onUpdateCursor behind the flag
With this CL, InputMethodService#onUpdateCursor and
InputMethodService#onUpdateCursorAnchorInfo can be enabled
on L when ENABLE_CURSOR_ANCHOR_INFO_CALLBACK and
ENABLE_CURSOR_RECT_CALLBACK are specified, respectively.

BUG: 16382260
Change-Id: I29924128f6bd2f08cbd91cc4e82c9c4a6ecce3ff
2014-07-20 20:56:52 +09:00
Yohei Yukawa
86f36003fd Use CharSequence for spell checker to keep spans preserved
This is a ground work to take per word locale information into
consideration in the spell checker. This CL is supposed to change
no user visible behavior.

With this CL, the spell checker session is able to read span
information if necessary.

BUG: 16029304
Change-Id: Icb1e1ecdf40fe0445e14565b685b1b878b746210
2014-07-20 02:16:11 +00:00
Yohei Yukawa
22ba22f32d Merge "Add two convenient utility methods for L new API" into lmp-dev 2014-07-18 18:24:25 +00:00
Tadashi G. Takaoka
639c93f43b Remove unused Key.keyLabelFlags' values
Change-Id: Iae3cd6674448f258ee0a4bf2966bf3c347876b4f
2014-07-19 12:31:50 -07:00
Yohei Yukawa
5696ac95ac Add two convenient utility methods for L new API
This CL adds two convenient utility methods for
InputConnection#requestCursorAnchorInfo to encapsulate
a bit complicated parameter construction.

BUG: 16382260
Change-Id: Ib11e3bd15a4edcb602c08ff830b2fb7b34ec00da
2014-07-19 23:42:37 +09:00
Ken Wakasa
e645715b25 Clean up under the util package.
- Move util classes that are unused in AOSP
- Remove unused methods

Change-Id: Ic97fd313f1e2bafd50609d42aa3a2d090b63eafc
2014-07-18 17:47:14 +09:00
Yohei Yukawa
413aded600 Add a compatibility library for newly added methods in L
This CL adds an compatibility library for
InputConnection#requestCursorAnchorInfo method that is supposed to
be available in L and later.

BUG: 16382260
Change-Id: I68be0c56b9fd929546e8706ccece938ae4f33339
2014-07-18 08:30:12 +09:00
Yohei Yukawa
eac8670830 Enable StringUtils to split CharSequence like String#split
This is a groundwork for enabling LocaleSpan.

To enable LocaleSpan everywhere, we need to switch to
CharSequence from String so that Span infromation can be
preserved end-to-end.  To achieve this, we need to have
CharSequence version of String#split.

BUG: 16029304
Change-Id: I0dd103185dcf62fb1e25054a374340790e6a4678
2014-07-19 22:47:56 +09:00
Tadashi G. Takaoka
5a5ee95fae Rename ProductionFlag to ProductionFlags
Change-Id: I5da2dbf8828fa0e176e7c2496392a5f561ebfe20
2014-07-16 19:26:32 -07:00
Tadashi G. Takaoka
6f80ed3901 Merge "Rename LatinImeLogger to DebugFlags" into lmp-dev 2014-07-16 23:37:00 +00:00
Tadashi G. Takaoka
2dae79b196 Rename LatinImeLogger to DebugFlags
Bug: 15318007
Change-Id: Ic0268fd12865c9a692a5e7110a9beb76cb8b6d7f
2014-07-16 18:49:00 -07:00
Tadashi G. Takaoka
53c0088d57 Use SwitchPreference for spell checker setting
This is a follow up of I1f7214c689.

Bug: 15781377
Change-Id: I7289b8b724e086da80ab3849cc567560c1a8502d
2014-07-16 12:13:51 -07:00
Keisuke Kuroyanagi
05c70484a2 Track crashing during migration to avoid crash loop. DO NOT MERGE.
Bug: 16213554
Bug: 16235703
Change-Id: Ib29b1a84b4c6ebae06d3dc6448f3c274ec6a7aab
(cherry picked from commit 1d6024d2f8)
2014-07-14 15:48:01 +00:00
Tadashi G. Takaoka
a2087e66e5 Use SwitchPreference on API versions newer than KitKat
Bug: 15781377
Change-Id: I1f7214c689006b1088249783eb614b6f0fbf2ee7
2014-07-13 13:11:09 +09:00
Keisuke Kuroyanagi
b7ecb258dc Merge "Remove SuggestionsGatherer." 2014-07-09 17:48:03 +00:00
Keisuke Kuroyanagi
1467fa0c26 Remove SuggestionsGatherer.
Bug: 13689011
Bug: 13630847
Change-Id: I9930d5ce9cbe16489dc69f68b9590d72afe463b5
2014-07-10 16:23:27 +09:00
Keisuke Kuroyanagi
86dee2295d Quit sorting suggestions in AndroidSpellCheckerService.
Suggestions have been sorted in SuggestionResults.

Bug: 13689011

Change-Id: Iec21e97119ceb7c71673d5b15bb1f06040b59fef
2014-07-10 16:21:31 +09:00
Keisuke Kuroyanagi
9e76304d60 Make spell checker use dictionary facilitator.
Bug: 13630847
Change-Id: I07d17ccf5ce0755f63a0b8d236d77600baaf62b6
2014-07-10 12:51:37 +09:00
Keisuke Kuroyanagi
12e63799d3 Merge "Quit sorting suggestions in AndroidSpellCheckerService." 2014-07-09 17:22:29 +00:00
Keisuke Kuroyanagi
eff9e26bc1 Merge "Make spell checker use dictionary facilitator." 2014-07-09 17:48:03 +00:00
Tadashi G. Takaoka
f9f409530c Add Material Light theme
Bug: 15782668
Change-Id: Id2ae47cfb2065d73f13701b9c6a041129dfd08ae
2014-07-10 07:43:04 +09:00
Yohei Yukawa
fc137f35c8 Simplify the wrapper for TextInfo#getCharSequence
This CL simplifies the wrapper method for
TextInfo#getCharSequence() because in the almost all cases we want
to use the result of TextInfo#getText() as the default value.

BUG: 16029304
Change-Id: I62f987aed8ca42b093255e6c0703d6120fa01299
2014-07-09 23:52:44 +09:00
Tadashi G. Takaoka
36713e5782 Fix alphabet label of Kannada and Telugu
Bug: 10029252
Bug: 10028759
Change-Id: Iea9cc1b7cafa97280503b0236b005cea57ba2c3d
2014-07-09 15:52:03 +09:00
Keisuke Kuroyanagi
3b8f2ece40 Merge "Move phrase gesture from additional features to public." 2014-07-02 20:35:42 +00:00
Keisuke Kuroyanagi
b8a9479b57 Move phrase gesture from additional features to public.
Bug: 15758242
Change-Id: I703dc2703afdf9402c5d2ac27411b74ece993dba
2014-07-08 16:36:06 +09:00
Tadashi G. Takaoka
d5f32b38f5 Add Telugu keyboard
Bug: 10028759
Change-Id: Id1bf030a9928124ead695aa7bf76db48ca58de4b
2014-07-09 02:36:15 +09:00
Tadashi G. Takaoka
03aa084ccd Add Kannada keyboard
Bug: 10029252
Change-Id: Ia03ff886f9e62a2fe228fe59b504b033eead7631
2014-07-09 01:44:04 +09:00
Tadashi G. Takaoka
1c9e9ecdfb Fix Armenian comma on phone device
Bug: 7963631
Change-Id: Ia28b4020652174daa2731b3eed7636db9639c6b6
2014-07-08 15:40:06 +09:00
Tadashi G. Takaoka
cc8f4491e3 Merge "Add Malayalam keyboard" 2014-07-02 20:35:42 +00:00
Tadashi G. Takaoka
59e795ca3f Add Malayalam keyboard
Bug: 10417006
Change-Id: Ieb03fe1f08c85417b5d9ad4d62c8a5bc6d0632bc
2014-07-08 23:42:01 +09:00
Yohei Yukawa
da19daf570 Merge "Ensure each character is coverted by at most one LocaleSpan" 2014-07-02 21:09:42 +00:00
Yohei Yukawa
ece4548eb5 Ensure each character is coverted by at most one LocaleSpan
This is a groundwork to attach LocaleSpan for committed text
in LatinIME.

This CL adds a utility method to ensure that a given range
of the text is coverted by at most one LocaleSpan.  Of course
it could be possible to allow a substring to be coverted by
multiple LocaleSpans at the same time, but ensuring uniqueness
for LocaleSpan is supposed to be a good starting point.

BUG: 16029304
Change-Id: Ic33a7178d0df1f05d3626aeb5773ec902254703f
2014-07-07 20:13:55 +09:00
Yohei Yukawa
733ec699cd Add a compatibility utility class for TextInfo
This is a groundwork for enabling LocaleSpan support in spell
checker service. TextInfo#getCharSequence is supposed to be
available in API Level 21 and later. We need some abstraction
layer as usual.

BUG: 16029304
Change-Id: Iafbf2877db393dbd040295c21d429334e3a13a5f
2014-07-08 14:10:12 +00:00
Tadashi G. Takaoka
074e9812ee Merge "Add Tamil keyboard" 2014-07-02 19:52:36 +00:00
Tadashi G. Takaoka
b5696b4f67 Add Tamil keyboard
Bug: 9978106
Change-Id: I226e640fe453076063121176121ed5923d1ccfa1
2014-07-08 18:05:07 +09:00
Tadashi G. Takaoka
68caceded4 Use bn-rIN resource directory for Bengali (India)
Bug: 10028755
Change-Id: I552ad3b30d359b79c48cde4912d796c532b42b51
2014-07-08 18:47:22 +09:00
Tadashi G. Takaoka
9cb19b1bca Merge "Remove unused keyPreviewIcon attributes" 2014-07-02 21:09:42 +00:00
Tadashi G. Takaoka
6efe9ae1c0 Remove unused keyPreviewIcon attributes
This CL also removes unused tabKeyPreview icon.

Change-Id: Ia69ba9c3d7c67ccb8983275bed262292eb422db2
2014-07-08 17:36:11 +09:00
Tadashi G. Takaoka
649de3f544 Fix Sinhala keyboard for tablet device
This CL introduces fontDefault flag to keyLabelFlags of Key attribute
to reset font specification to keyTypeface attribute.

This is a followup of I065824f3fa.

Bug: 6911143
Change-Id: I33bd4a23aaea73e2b17175ddd39053ec915d5451
2014-07-07 16:57:11 +09:00
Keisuke Kuroyanagi
bb843eb223 Move getPrevWordsInfoFromNthPreviousWord to PrevWordsInfoUtils.
Bug: 14425059
Change-Id: Id37022ac6c1545d6845abfbcdb7ed47f0e250eec
2014-07-07 13:07:57 +09:00
Yohei Yukawa
513784e808 Merge "Restore additional subtypes when the package is updated" 2014-07-02 19:52:36 +00:00
Yohei Yukawa
052ec62abd Restore additional subtypes when the package is updated
With this CL, Intent#ACTION_MY_PACKAGE_REPLACED will
not only update the visibility of the setup activity but
also reconstruct additional subtypes.

This is important because the system always removes all
the additional subtypes whenever the package is updated.

BUG: 15890448
Change-Id: Ic36ea68f50b1ac89b4cbd268ee53f9a5e5d60afd
2014-07-04 20:50:00 +09:00
Yohei Yukawa
3895d7f8dc Additional subtype ID should be independent of OS-version
This CL consolidates the initialization logic for additional
subtypes so that each additional subtypes can have predictable
subtype ID regardless of OS version.

Previously subtype IDs for additional subtypes are calculated
differently depending on the running OS version with hoping it
minimizes the risk of compatibility issues.  However, it is
getting harder and harder to maintain slightly different
logic between OSes. Thus we decided to unify the logic into
that in KitKat even though it may causes some breaking changes.

Note that the actual extra values that are used to instantiate
InputMethodSubtype object are still determined on the fly
depending on the running OS version. However these actual
extra values are no longer used for the subtype ID calculation.

BUG: 16000850
Change-Id: Id3c262386a7bc7ed75966b1395a50171abe550d3
2014-07-04 15:08:58 +09:00
Tadashi G. Takaoka
013ea9d57a Merge "Add Bengali keyboard layout" 2014-07-02 21:09:42 +00:00
Tadashi G. Takaoka
0205fb220d Add Bengali keyboard layout
This is a preliminary keyboard layout.

Bug: 10028755
Change-Id: I365fb8e942a60d4b690a4af95fcd35bf73fffbe4
2014-07-04 20:59:37 +09:00
Yohei Yukawa
c4571a2e29 Merge "Add compatibility utility class for LocaleSpan" 2014-07-02 19:52:36 +00:00
Yohei Yukawa
a92fead202 Add compatibility utility class for LocaleSpan
This is a groundwork for enabling LocaleSpan support.
LocaleSpan is available in API Level 17 and later. We need some
abstraction layer as usual.

BUG: 16029304
Change-Id: Iead1afdc540216edb1b17f91a40d9edb2e790168
2014-07-04 20:31:34 +09:00
Yohei Yukawa
73065b778c Remove dead code to fix test failure due to NoSuchMethodError
This CL removes following methods from StringUtils, which are
no longer used since Id3c262386a7bc7ed75966b1395a50171abe550d3.
- #joinCommaSplittableText
- #appendToCommaSplittableTextIfNotExists

BUG: 16000850
Change-Id: Ibdc9b7e463a19cdfac788b24c0a6322d0c5850c5
2014-07-04 19:12:14 +09:00
Ken Wakasa
0100a49bdd Merge "[HW5] Make the word composer package private." 2014-06-26 23:14:30 +00:00
Jean Chalard
28ebbd481a [HW5] Make the word composer package private.
Change-Id: I66ed277751272eb3ae2fd5e55e9f3e413970082f
2014-07-01 18:21:17 +09:00
Jean Chalard
08c01ea8a8 [HW4] Move a reference to WordComposer out of LatinIME
Change-Id: I5436432c0da86ed1e33b3c9d40204f4ea013ff55
2014-07-01 18:21:17 +09:00
Jean Chalard
350f23f67e [HW3] Some refactoring
Change-Id: I303ce084a56c6ec709d3eab239a4d9d2274d0dea
2014-07-01 18:21:17 +09:00
Jean Chalard
0dab3171d4 [SD9] Add armenian and georgian scripts
Bug: 15840116
Change-Id: I91719e4fc2e3fe29320e4cb8b1a2f8f93c44cc4d
2014-07-01 15:01:41 +09:00
Jean Chalard
292deb632c [SD7] Actually check for script.
...also implement the check for Hebrew and Arabic.

Bug: 15840116
Change-Id: Ia6433d7d98038ade64c171be4fe4b3f094111fac
2014-07-01 15:01:22 +09:00
Jean Chalard
943e91ffbd Merge "[SD6] Inline a constant and remove logic become useless" 2014-06-26 23:19:11 +00:00
Jean Chalard
b6695867a5 [SD6] Inline a constant and remove logic become useless
Bug: 15840116
Change-Id: I545cc9083aa4e2fd7cbbd1fbc02e1e382482db7c
2014-07-01 14:34:53 +09:00
Jean Chalard
20c89b1cf5 [SD5(2)] Remove useless args
Bug: 15840116
Change-Id: I1123426fbd9d420c1be64ccc917a5f870e70e6fa
2014-07-01 13:34:25 +09:00
Jean Chalard
b10ca308af Merge "[HW4] Move a reference to WordComposer out of LatinIME" 2014-06-26 23:14:58 +00:00
Jean Chalard
3afbac8cb7 Merge "[HW2] Have a script for hardware keyboard" 2014-06-26 23:14:58 +00:00
Jean Chalard
5f6c303f0b [HW2] Have a script for hardware keyboard
Change-Id: I3ee85867c529156374ecc17db3243a50912e760b
2014-07-01 13:37:36 +09:00
Ken Wakasa
7eef5d3ff4 Revert "[SD5] Remove useless args"
This reverts commit 1d30023961 that broke the build.

Bug: 15840116
Change-Id: I0a5fa7dea2b418d19df24b2b31ed96bf192d45c0
2014-07-01 03:23:14 +00:00
Jean Chalard
1d30023961 [SD5] Remove useless args
Bug: 15840116
Change-Id: Ib3380cfc9d343c6f8953bba03af3801142bc3bdb
2014-06-30 21:58:55 +09:00
Jean Chalard
6345562e2b [SD4] Restart suggestions on language change
...otherwise we can't recompute the composition when we
change scripts.

This also fixes when we register that we need to take note
that the current subtype was used. Luckily this is a good
occasion for some cleanup that I've wanted to do for some
time: use InputTransaction for onTextInput (with the goal
to ultimately remove it entirely)

Bug: 15840116
Change-Id: Ie4f4f9157b66b79237eeb3db75535803124d3e19
2014-06-30 21:58:52 +09:00
Jean Chalard
4db7da92f2 Merge "[SD3] Forward the script ID to where it will be used" 2014-06-26 23:19:11 +00:00
Jean Chalard
e5a8615de7 [CS6] Cut out methods to clarify what we are doing
Bug: 13238601
Change-Id: I99cc62e91b1e89130358fded572987023d919507
2014-06-30 13:41:04 +09:00
Jean Chalard
35c37dbef8 [SD3] Forward the script ID to where it will be used
Bug: 15840116
Change-Id: If2073e76fed74ae6e1cdd7670013e0e985b0e630
2014-06-27 21:18:42 +09:00
Jean Chalard
aca2ef85e1 [SD2] Add support for a new tag Feature in KeyboardLayoutSet
Bug: 15840116
Change-Id: I3abbe4ce1ae573e9c5f1a8a96dc0056e8889d507
2014-06-27 20:51:48 +09:00
Tadashi G. Takaoka
d966c0727f Merge "Support performAccessibilityAction for CLICK and LONG_CLICK" 2014-06-26 23:19:11 +00:00
Tadashi G. Takaoka
1e31672295 Support performAccessibilityAction for CLICK and LONG_CLICK
Bug: 15727335
Change-Id: I83274c1a9d3cf2e8237d1674fe915b7b2d222a53
2014-06-27 19:01:56 +09:00
Tadashi G. Takaoka
c9c3ea0b68 Merge "Remove redundant override methods and extended classes" 2014-06-26 23:19:11 +00:00
Ken Wakasa
92223c04de Merge "Revert "Move getPrevWordsInfoFromNthPreviousWord to StringUtlis."" 2014-06-26 23:14:58 +00:00
Ken Wakasa
4569a734ad Revert "Move getPrevWordsInfoFromNthPreviousWord to StringUtlis."
This reverts commit ba463c9a66 that broke the dicttool build.

Bug: 14425059
Change-Id: Ie1685587104d26e4416624747c97f6087c13388a
2014-06-27 15:07:07 +00:00
Keisuke Kuroyanagi
ba463c9a66 Move getPrevWordsInfoFromNthPreviousWord to StringUtlis.
Bug: 14425059
Change-Id: I3eb24e840c165e43f68c2a60fccf9974affb57a6
2014-06-27 18:08:17 +09:00
Keisuke Kuroyanagi
1c2f1ada83 Find multiple previous word information to support n-gram.
Bug: 14425059

Change-Id: Ieace636334a9b2a094527341d4fcfc05958296c5
2014-06-27 17:59:21 +09:00
Jean Chalard
e063e1b218 Merge "Fix a unit test" 2014-06-26 23:14:30 +00:00
Jean Chalard
fa4c59f9b6 Fix a unit test
When switching languages, we need to wait until the dictionary is
loaded to compute suggestions.

Change-Id: I7c32a900b297cd6302bfdc020842581315f3007f
2014-07-01 18:19:11 +09:00
Keisuke Kuroyanagi
1a2f3c4433 Merge "Move getPrevWordsInfoFromNthPreviousWord to StringUtlis." 2014-06-26 23:14:30 +00:00
Tadashi G. Takaoka
5a9ccbbef1 Merge "Add Sinhala keyboard layout" 2014-06-26 23:14:30 +00:00
Tadashi G. Takaoka
00da6ee5e8 Add Sinhala keyboard layout
Bug: 6911143
Change-Id: I9ff87ece3e68381c0e9855106e7320c227f09965
2014-06-27 16:16:30 +09:00
Jean Chalard
ee5c032557 [CS5] Use a local var to keep the first suggestion
Bug: 13238601
Change-Id: Ida8973945e8b141d01ea9d1825b89d84f0911575
2014-06-27 12:59:44 +09:00
Jean Chalard
bd5192ae26 Merge "Add a relevant suggestion to period-checkable requests" 2014-06-26 23:14:58 +00:00
Jean Chalard
e530fffc2c Add a relevant suggestion to period-checkable requests
Bug: 15412461
Change-Id: Ibf37df4d31141a7e43b54d6342e7861eedb1c03b
2014-06-27 12:52:23 +09:00
Tadashi G. Takaoka
79beb223fc Merge "Refactor keyboard accessibility delegate classes" 2014-06-26 23:14:58 +00:00
Jean Chalard
ffb086c18d Merge "Don't override application-specified completions" 2014-06-26 23:14:30 +00:00
Jean Chalard
e2744c6384 Don't override application-specified completions
...for any given input.
This is not necessarily the best fix, but it's simple and
it works well enough.

Bug: 15869703
Change-Id: I54b262be8bdbec37031dea655c60a5573b3d8ec3
2014-06-27 17:31:08 +09:00
Keisuke Kuroyanagi
17c5a388d6 Merge "Find multiple previous word information to support n-gram." 2014-06-26 23:14:58 +00:00
Keisuke Kuroyanagi
05b1e0d42f Extend jni method to use multiple previous words.
Bug: 14425059
Change-Id: I8150e8812ee32f8c713315a234b52e5b3a79d7a0
2014-06-26 18:47:25 +09:00
Tadashi G. Takaoka
adba09b54e Remove redundant override methods and extended classes
Bug: 15727335
Change-Id: Icea09f0643e7aeb8e722e473ad322f7439c3497a
2014-06-24 22:31:43 -07:00
Tadashi G. Takaoka
3d8848e5cb Refactor keyboard accessibility delegate classes
Bug: 15727335
Change-Id: I1aa79a6f7f8cf14bacec391c016a5d1c553eea24
2014-06-24 22:14:07 -07:00
Keisuke Kuroyanagi
67f863f4cb Merge "Extend jni method to use multiple previous words." 2014-06-24 01:52:26 +00:00
Jean Chalard
c0748a1990 Fix the build
That was a merge not well resolved by git >.>

Change-Id: I3cd042d6a5206daf1e9942358405d647c67423dd
2014-06-26 18:44:54 +09:00
Keisuke Kuroyanagi
d58a07666e Merge "Rename jni method for n-gram supporting." 2014-06-24 01:52:26 +00:00
Keisuke Kuroyanagi
6c7cebdefb Fix build.
Change-Id: I5c6c0a9098c5a228ed82b208aa6f237a41f2f6cc
2014-06-26 14:42:40 +09:00
Keisuke Kuroyanagi
83b6ee2538 Rename jni method for n-gram supporting.
Bug: 14425059
Change-Id: I242d1de5d9db37344f02d8fba9035829794a56c8
2014-06-25 14:14:40 +09:00
Keisuke Kuroyanagi
e708b1bc2e Make PrevWordsInfo have multiple words' information.
Bug: 14425059
Change-Id: I2bd6a872904a44b80f638a13d91a97559217cc1a
2014-06-25 14:14:37 +09:00
Jean Chalard
310bb2c76f Merge "[HW1] Fix some bugs with event handling" 2014-06-24 01:52:26 +00:00
Jean Chalard
09291050a0 [HW1] Fix some bugs with event handling
With hardware events, we do have some events that
have both a keycode and a code point, so we need
a better way of distinguishing between auto-insert
keystrokes and others.

Change-Id: Ia23042989b4dca9d3a7d4a4c06bcebdabe324a7a
2014-06-26 18:27:53 +09:00
Jean Chalard
90759f2ab7 Merge "[CS4] Remove useless tests and processing" 2014-06-24 01:59:00 +00:00
Jean Chalard
b740886aeb [CS4] Remove useless tests and processing
Since we have a de-duped and transformed collection, we
can just read from it instead of computing it separately.

Bug: 13238601
Change-Id: I0aa4b0d91d3b350f9449e13658bfb587fc538764
2014-06-26 18:26:08 +09:00
Keisuke Kuroyanagi
92827b0712 Merge "Make PrevWordsInfo have multiple words' information." 2014-06-24 01:52:26 +00:00
Keisuke Kuroyanagi
0aef59746c Make Beginning-of-Sentence prediction require two exposures.
Bug: 15868192
Change-Id: I4b577ad11c992d872d6f902fd50527d9ca5cc1ba
2014-06-25 20:20:44 +09:00
Jean Chalard
53f23234e3 Merge "[CS3.5] Small correction" 2014-06-24 01:46:27 +00:00
Jean Chalard
c82257ba6e [CS3.5] Small correction
Bug: 13238601
Change-Id: I7bd82a4678d8bf88f16bf271f20be8d37f9b97d7
2014-06-24 18:26:51 +09:00
Jean Chalard
d700e59700 Merge "Some cleanup to accommodate a fix" 2014-06-24 01:59:00 +00:00
Jean Chalard
132bdd079c Merge "[CS3] Move transformation of words to earlier" 2014-06-24 01:52:26 +00:00
Jean Chalard
8d3d0f3b84 Merge "[SD1] Move script-related methods to a new utils class." 2014-06-24 01:46:27 +00:00
Jean Chalard
289299bf66 [SD1] Move script-related methods to a new utils class.
Bug: 15840116
Change-Id: I3a2a9c41e40590c0116c7885a49c6fa308ed8f44
2014-06-26 18:24:11 +09:00
Jean Chalard
a3f7a5840a Don't commit a space before it's actually needed
Bug: 15740318
Change-Id: Idad06cb2c18335a981d5e9dea7eccf5e7ea8f701
2014-06-25 10:37:06 +09:00
Keisuke Kuroyanagi
dc6ee3a63f Merge "Enable beginning-of-sentence prediction." 2014-06-24 01:46:27 +00:00
Keisuke Kuroyanagi
2725cc17d7 Enable beginning-of-sentence prediction.
Bug: 14119293
Change-Id: I23c407f0afed0ae4af290a1195b0e3bbcd5af8d7
2014-06-24 12:37:09 +09:00
Keisuke Kuroyanagi
88fa47a27d Support migration/dump of Beginning-of-Sentence entries.
Bug: 14119293
Change-Id: Ie975138f819794d5c34a7a547be5a6117050e084
2014-06-24 12:37:07 +09:00
Keisuke Kuroyanagi
702e153fbc Merge "Support migration/dump of Beginning-of-Sentence entries." 2014-06-24 01:59:00 +00:00
Jean Chalard
a1d518ca88 Merge "[CS2] Refactor a bit removeDups" 2014-06-24 01:46:27 +00:00
Tadashi G. Takaoka
d92204b56a Merge "Reorganize Keyboard settings screen" 2014-06-23 21:50:10 +00:00
Tadashi G. Takaoka
058c6c6491 Reorganize Keyboard settings screen
This CL must be checked in together with Ie45df15b18.

Bug: 11866784
Change-Id: I44d6ceb45108be135e3eaa361f4ee2c83f04fb57
2014-06-23 18:46:09 -07:00
Tadashi G. Takaoka
84405d2a68 Fix some comments and rename method and parameter names
This is a follow up change of I12139a925d and I0ac92c56bd

Change-Id: Id6e9f4434fddd5d4274e06da5063606c2ffad932
2014-06-23 13:56:50 -07:00
Jean Chalard
1ec3f158d2 [CS3] Move transformation of words to earlier
Bug: 13238601
Change-Id: I37fe66c6152cdf8c60878d5619bb5dc41f3223df
2014-06-23 22:58:52 +09:00
Jean Chalard
fdebf4005f [CS2] Refactor a bit removeDups
This way is more understandable, and also supporting an
external string is helping for future refactorings

Bug: 13238601
Change-Id: I4ebeed46eb0b35011164946af71ac257c6449ddb
2014-06-23 22:58:46 +09:00
Jean Chalard
debe0dacbd Some cleanup to accommodate a fix
Also, this double tests for CODE_SPACE in the path going through
maybeDoubleSpacePeriod, but that's temporary.

Bug: 15740318
Change-Id: I0a6ace09cc791f0009157d3017675b9b3eb92145
2014-06-23 22:51:45 +09:00
Jean Chalard
e83e79cb05 [CS1] Some initial clean up
Bug: 13238601
Change-Id: I54ee9a85ecfee3c50c8db3eb4cd6f391a775a630
2014-06-23 22:19:09 +09:00
Jean Chalard
7d6bc4d063 Merge "[CS1] Some initial clean up" 2014-06-19 22:58:18 +00:00
Ken Wakasa
ffc843550c Merge "Revert "Reorganize Keyboard settings screen"" 2014-06-19 22:58:18 +00:00
Ken Wakasa
e6a57bc82e Revert "Reorganize Keyboard settings screen"
This reverts commit 339929ba16.

Bug: 11866784
Bug: 13888366
Bug: 15781377

This doesn't build with LOCAL_SDK_VERSION := 19 for UnbundledLatinImeGoogle.

Change-Id: Idf8bd335b076152265f245f578dadf651e291878
2014-06-23 11:20:25 +00:00
Tadashi G. Takaoka
339929ba16 Reorganize Keyboard settings screen
This CL must be checked in together with I6ebfbeb4e8.

Bug: 11866784
Bug: 15781377
Bug: 13888366
Change-Id: I57d47ab174d03121a604fd0dbf553795de0ab9b8
2014-06-22 22:37:26 -07:00
Tadashi G. Takaoka
593fe9b0cf Merge "Add click and long click actions to key node info" 2014-06-20 21:00:34 +00:00
Tadashi G. Takaoka
d4b6af14d8 Add click and long click actions to key node info
This CL adds ACTION_CLICK or ACTION_LONG_CLICK actions to a key node
info. But report a node info without these actions for the same key
while hovering to avoid announcement "double tap to select and double
tap and hold to long press".

Bug: 15727335
Change-Id: I1e9333c94c819d049bda81ad410299f5a509d29c
2014-06-20 18:25:25 -07:00
Tadashi G. Takaoka
d801b6ee66 Populate accessibility root node info of keyboard
Partially reverting Ie033d21ef8 to populate root node info.

This CL also fixes the bounds in screen of virtual node info.

Bug: 15746768
Bug: 15582251
Change-Id: I3a82f904270adf138036ef462fd70b349a3cd33e
2014-06-20 14:32:16 -07:00
Keisuke Kuroyanagi
d2e566f999 Fix unit tests by adding @UsedForTesting.
Change-Id: I62ec07210817295f59a174383ee4b33cc4fc2ca6
2014-06-20 16:27:46 +09:00
Tadashi G. Takaoka
e9d12c9f74 Merge "Refactor drawing preview classes" 2014-06-20 02:09:17 +00:00
Keisuke Kuroyanagi
9bbc3aa02a Merge "Move variables for I/O of a jni method to traverse session." 2014-06-19 22:55:19 +00:00
Tadashi G. Takaoka
294afba81f Merge "Reorganize Keyboard settings screen" 2014-06-21 03:15:09 +00:00
Tadashi G. Takaoka
496fd77850 Merge "Custom view for key preview popup" 2014-06-20 21:00:34 +00:00
Tadashi G. Takaoka
615f431465 Custom view for key preview popup
Bug: 15143928
Change-Id: I12411b9b5b9611ec089e4967def9b5c19a2367c7
2014-06-23 01:07:59 -07:00
Tadashi G. Takaoka
a74719c934 Fix dismissing more keys panel when hiding keyboard
This issue was introduced by Id7002ecb7f.

Bug: 15809493
Change-Id: Iaa51b7f40a54ccbafb45c6444d8bbd21c671f7af
2014-06-22 22:21:39 -07:00
Keisuke Kuroyanagi
f73769c638 Merge "Remove word from personalized dicts when it's canceled." 2014-06-19 22:55:19 +00:00
Keisuke Kuroyanagi
0fbca1ac23 Remove word from personalized dicts when it's canceled.
Bug: 15555552
Bug: 15552347
Change-Id: Ia4d8c79d079e3ce233d46d4bbad4fff1be5c5c39
2014-06-20 14:46:13 +09:00
Tadashi G. Takaoka
0f6f5b1fdc Merge "Disable empty suggestion word on the suggestions strip" 2014-06-20 02:04:45 +00:00
Tadashi G. Takaoka
ae42cd7e43 Disable empty suggestion word on the suggestions strip
It should be disabled when it is empty. But should be enabled even
when it is empty with accessibility exploration on to avoid announcing
"disabled".

Note that this CL may not be able to handle "suspending talk back"
state correctly. It should be handled by registering
TouchExplorationStateChangeListener that is available from API 19.

Bug: 15738513
Bug: 14849593
Change-Id: Id9ad89f770840f74a106f53833060407b20c1e24
2014-06-19 19:22:02 -07:00
Tadashi G. Takaoka
b80fb09ff8 Dismiss more keys panel when hiding window
Bug: 15727301
Change-Id: Id7002ecb7f4eea7be3505f6f0235074264418221
2014-06-19 11:42:32 -07:00
Tadashi G. Takaoka
f49e975740 Clear suggestions strip if a suggestion engine isn't attached
Bug: 15709298
Change-Id: I1b3fff3152960d85060149727d7a3422fea8a0bd
2014-06-18 18:47:34 -07:00
Tadashi G. Takaoka
7fb630b2a8 Refactor drawing preview classes
Change-Id: I0779caa720e3013f055ab48900bed223747b3952
2014-06-18 18:16:21 -07:00
Tadashi G. Takaoka
03288ef47f Refactor MoreKeysKeyboard.Builder a bit
Change-Id: I12139a925d59bb467df629cebc61423d61db1d2d
2014-06-18 18:06:17 -07:00
Tadashi G. Takaoka
d89a34b0a1 Merge "Hide voice input key from URI, Email, Number, and Phone layout" 2014-06-19 00:17:11 +00:00
Tadashi G. Takaoka
0351b81632 Hide voice input key from URI, Email, Number, and Phone layout
Bug: 15709298
Change-Id: I05d9433d4e1c2cc475a2136cc97bc32bde6fc745
2014-06-18 18:44:27 -07:00
Tadashi G. Takaoka
3ff72dd0da Consolidate 3 public methods of key preview into one
Change-Id: I0ac92c56bdb636998f7f5e20fba6830b4ac435fa
2014-06-18 10:05:59 -07:00
Keisuke Kuroyanagi
162f529e93 Move variables for I/O of a jni method to traverse session.
Bug: 15008504
Change-Id: I3e59bc856c1df0e1afe3b42d024620ca1745837b
2014-06-17 17:50:32 +09:00
Keisuke Kuroyanagi
4c45fff240 Merge "Fix: NPE when initializing AOSP keyboard." 2014-06-16 23:18:50 +00:00
Keisuke Kuroyanagi
34ed5b0742 Fix: NPE when initializing AOSP keyboard.
Bug: 15677822
Change-Id: Ibebb215a08795482c0f1eef965db06af57558906
2014-06-17 09:33:37 +09:00
Keisuke Kuroyanagi
37c49f63df Update suggestion strip when the contextual dict is updated.
Bug: 14161647
Change-Id: Ic7d53464bd051bffc8c7f8d097325321fe0aaee7
2014-06-16 18:30:59 +09:00
Keisuke Kuroyanagi
cb368a6dac Fix: Probability used for one word contextual phrase.
Bug: 14161647
Change-Id: Ia5f985ea467145fb381e3ad2c1f67f3b013f19e8
2014-06-16 18:20:33 +09:00
Jean Chalard
ccfc824a88 Merge "[CM2] Update beginning-of-sentence suggestions" 2014-06-10 22:31:57 +00:00
Jean Chalard
c715d95f17 [CM2] Update beginning-of-sentence suggestions
We need to update them after separator-space, and also when
the user presses shift and they are displayed.

Bug: 15554503
Change-Id: I5596163d5cd94d3cc5f6af10a1ab2cc74b6d4279
2014-06-16 18:44:43 +09:00
Jean Chalard
deccc23564 [CM1] Let predictions be aware of capitalize mode.
Bug: 15554503
Change-Id: If5e8c0d94ed26d929400ccbb0d45ac23dd98d180
2014-06-16 18:44:39 +09:00
Tadashi G. Takaoka
ad4f964a70 am 4f28b227: Update SDK version check due to I4716e71d72
* commit '4f28b22766e06b8c62636527393945114ea78002':
  Update SDK version check due to I4716e71d72
2014-06-13 19:20:40 +00:00
Tadashi G. Takaoka
a2e365da0a Stop announcing suggestions strip content while more keys keyboard is showing
This CL also supports announcing dismissing of a more keys keyboard.

Bug: 15582905
Change-Id: Ia9e5d6c7e3e23dac39ee570b20d32f0141ae6184
2014-06-14 01:29:45 +09:00
Tadashi G. Takaoka
4f28b22766 Update SDK version check due to I4716e71d72
Bug: 15603590
Change-Id: Ia2ac28a2dbf3e07678661d59e0aa6b4e6a536a02
2014-06-13 18:53:27 +09:00
Tadashi G. Takaoka
fd0d104fa7 Merge "Fix forwarding event only when sending view is visible" 2014-06-10 22:36:02 +00:00
Tadashi G. Takaoka
28593b5325 Fix forwarding event only when sending view is visible
Bug: 15579941
Change-Id: I25c19068ae4ad26b1ff64ffccf36ef8dd58ed295
2014-06-13 15:12:02 +09:00
Tadashi G. Takaoka
dc0c1e40be Merge "Add EmojiPageKeyboardAccessibilityDelegate" 2014-06-10 22:36:02 +00:00
Tadashi G. Takaoka
e9d9b37b5a Add EmojiPageKeyboardAccessibilityDelegate
Because EmojiPageKeyboardView doesn't use PointerTracker to handle
MotionEvent, a dedicated accessibility delegate is needed. Then the
recent tab can be updated even with accessibility mode on.

Bug: 15582599
Change-Id: I63d75b9aca21ec44f1f77d2eaaf2ba7813992183
2014-06-13 13:35:35 +09:00
Jean Chalard
8a23703763 Merge "[CM1] Let predictions be aware of capitalize mode." 2014-06-10 22:31:57 +00:00
Tadashi G. Takaoka
163f318545 Merge "Return an empty accessibility node info for a keyboard" 2014-06-10 22:31:57 +00:00
Tadashi G. Takaoka
9934740a5f Return an empty accessibility node info for a keyboard
Because a keyboard handling hover events and determining a virtual
node by itself, there is no need to supply whole virtual nodes info
for the keyboard. Just returning an empty accessibility node info
supresses annoucements of all keys.

This CL also fixes the undefined virtual id value.

Bug: 15582251
Change-Id: Ie033d21ef878d272417cf2b20f8eec1e516587f6
2014-06-13 16:44:59 +09:00
Tadashi G. Takaoka
1dbeb251b2 Use MoreKeysDetector for accessibility
A more keys keyboard may have a divider on it. The MoreKeysDetector
should be used even with accessibility mode on to be able to handle a
divider.

Bug: 15583354
Change-Id: Ife2cf8304496c4c330127fde8ca1f34c2f0838e2
2014-06-13 12:49:49 +09:00
Keisuke Kuroyanagi
6aa64e91ed Merge "Add clearContextualDictionary()." 2014-06-10 22:29:12 +00:00
Keisuke Kuroyanagi
60dad15f12 Add clearContextualDictionary().
Change-Id: Ia2f8d5640cde816cca23b26ee261acf44f3cdcdc
2014-06-16 17:01:14 +09:00
Keisuke Kuroyanagi
356539699a Add a method to update contextual dictionary.
Bug: 14161647
Change-Id: I2111f841c94e31d62b670da4236fc738df03a708
2014-06-16 17:00:12 +09:00
Keisuke Kuroyanagi
1a4d815b0b Contextual dictionary updater.
Bug: 14161647
Change-Id: I8106419678d5d26a4debec7bbef43af079c1ab18
2014-06-13 18:39:29 +09:00
Keisuke Kuroyanagi
d7a22c8439 Personalization dictionary updater.
Bug: 14161647
Change-Id: I7ab3d701525e9a19bc100aa577527e332bb2ad95
2014-06-13 16:31:12 +09:00
Keisuke Kuroyanagi
ec59371ff8 Merge "Block offensive words in native code." 2014-06-10 22:36:02 +00:00
Keisuke Kuroyanagi
59ed0c2db2 Block offensive words in native code.
Bug: 15300452

Change-Id: Ic6c91c47453e19fb5db2c62b66659619e72b1ecf
2014-06-12 11:36:00 +09:00
Keisuke Kuroyanagi
17f03583c8 Merge "Add a method to update contextual dictionary." 2014-06-10 22:31:57 +00:00
Keisuke Kuroyanagi
a4f2e8eee0 Merge "Contextual dictionary updater." 2014-06-10 22:31:57 +00:00
Yohei Yukawa
c1cb930dde Merge "Revert "Check OS codename for shouldOfferSwitchingToNextInputMethod"" 2014-06-10 22:29:12 +00:00
Yohei Yukawa
58e248ebda Revert "Check OS codename for shouldOfferSwitchingToNextInputMethod"
This reverts commit 1690992d1b.

Build.VERSION.SDK_INT is bumped with I4716e71d72b2526fe635079d1b.                                                                                     
We no longer need this workaround.

Change-Id: I75a1c2a7055af17a7d40291aadd62ae9bb42e056
2014-06-13 03:12:17 +00:00
Tadashi G. Takaoka
a68e0dd437 Fix NPE by disabling key preview popup of Emoji palette
Bug: 15579928
Change-Id: I6bcf885f2c1aa37b337a85978409ccf41e459c2a
2014-06-13 11:04:56 +09:00
Keisuke Kuroyanagi
da0ea7603b Merge "Add jni method for removeUnigramEntry()." 2014-06-10 22:31:57 +00:00
Keisuke Kuroyanagi
b4d77eca55 Add jni method for removeUnigramEntry().
Bug: 15552347
Change-Id: Iadcdc73d3335d561a27b9314d3fcdab0b0c96e49
2014-06-12 12:21:44 +09:00
Keisuke Kuroyanagi
81bd7e2007 Merge "Personalization dictionary updater." 2014-06-10 22:29:12 +00:00
Tadashi G. Takaoka
08199ec859 Clear PointerTracker state when more keys keyboard is dismissed
With accessibility mode on, hover events for a more keys keyboard are
handled among MoreKeysKeyboardAccessibilityDelegate and
MoreKeysKeyboardView. But the more keys keyboard is shown by
MainKeyboardAccessibilityDelegate that uses PointerTracker to handle
hover events. Thus we need to clear PointerTracker state when the more
keys keyboard is dismissed.

This is a workaround to resolve the issue. We should reconsider the
structure of those views and accessibility delegates in the future.

Bug: 15583751
Change-Id: Ida8c3e55194c59bdaa5bc4ff06068e699b888ced
2014-06-13 15:54:25 +09:00
Keisuke Kuroyanagi
4715baf93b Merge "Fix: Wrong name for ContextualDictionary." 2014-06-10 22:29:12 +00:00
Keisuke Kuroyanagi
3bedb9b3e6 Fix: Wrong name for ContextualDictionary.
Bug: 15557070
Change-Id: I5796df54a74c111d361da8c548e5597aba8e24d0
2014-06-11 19:58:22 +09:00
Tadashi G. Takaoka
6a96c508fd Fix logic to show suggestions
Bug: 15531465
Change-Id: Ic7fe5743ad3767cdaed699e5e2d1ebcaa75e22c2
2014-06-11 11:51:58 +09:00
Keisuke Kuroyanagi
447c19364a Merge "Enable Beginning-of-Sentence prediction for contextual dict." 2014-06-10 22:31:57 +00:00
Keisuke Kuroyanagi
22931cd941 Enable Beginning-of-Sentence prediction for contextual dict.
Bug: 14161647
Bug: 14119293
Change-Id: I0c00f13966db88e4de85e245e7bced43c9d474b2
2014-06-12 12:26:18 +09:00
Jean Chalard
d979d416c1 Merge "Special case periods in the spell checker" 2014-06-10 11:57:21 +00:00
Keisuke Kuroyanagi
cdfd2ce5a3 Merge "Add prefix to the arguments of getDictionary()." 2014-06-10 11:41:34 +00:00
Keisuke Kuroyanagi
f36da2fdba Merge "Make dump dictionary settings easily extensible." 2014-06-10 11:08:38 +00:00
Keisuke Kuroyanagi
a20432479d Make dump dictionary settings easily extensible.
This adds "Dump contextual dictionary".

Bug: 14161647
Change-Id: I41a6d6e131d9d8c300ac0120d903d46d88bb3346
2014-06-10 19:59:19 +09:00
Jean Chalard
4863a06544 Special case periods in the spell checker
Special case <valid word>.<valid word> to send as a suggestion
the same string where the periods is replaced by a space.

Bug: 10780091
Change-Id: I43c94675977f9ab5d7ee5671486cb742b39f3974
2014-06-10 19:52:58 +09:00
Keisuke Kuroyanagi
48b0074349 Merge "Purge dict reading code for 401 and create for 402." 2014-06-10 10:31:05 +00:00
Keisuke Kuroyanagi
07e1412631 Purge dict reading code for 401 and create for 402.
Change-Id: Ib0150b3306bb2db8aff443d1158fecc8464cbbdb
2014-06-10 19:22:40 +09:00
Keisuke Kuroyanagi
18df192535 Add prefix to the arguments of getDictionary().
Bug: 13630847
Change-Id: Ib4513b8cb6981e01dd33fd9703cc01646a2c7ccc
2014-06-10 18:05:10 +09:00
Jean Chalard
2d7feb5ad0 Merge "Split the sentences into words ourselves" 2014-06-10 08:18:36 +00:00
Keisuke Kuroyanagi
1ffb7cd448 Merge "Debug log when failed to add/remove n-gram entry." 2014-06-10 05:14:23 +00:00
Keisuke Kuroyanagi
354a59dfa4 Debug log when failed to add/remove n-gram entry.
Change-Id: Ibf0a4e01e1abc81b09aec104ba39d2ec18f4db8b
2014-06-10 13:04:57 +09:00
Jean Chalard
e689d37f72 Remove a useless method
Change-Id: I21a4219f682f43f4a84b1ab12d00dd930b35caa1
2014-06-10 12:47:55 +09:00
Jean Chalard
264afb10bd Merge "Remove mPrevWordsInfo" 2014-06-10 03:21:47 +00:00
Jean Chalard
367c199de1 Remove mPrevWordsInfo
This member has outlived its usefulness. It's not clear now that it
makes things really faster, but it does bring a lot of complexity
that we can avoid by removing it.

Change-Id: Ifbc8094a45b56b958fe165b1930f4cc358a97721
2014-06-10 12:07:51 +09:00
Tadashi G. Takaoka
874a600dc8 Add audio and haptic feedback for Emoji and Suggestions
Bug: 15378862
Change-Id: Ia14929bd9eb63ad5735cae0ad98ad0e2ad301128
2014-06-10 09:15:59 +09:00
Tadashi G. Takaoka
d022df49bd Merge "Set content descrition of words in suggestions strip" 2014-06-09 13:01:44 +00:00
Tadashi G. Takaoka
f3c852efad Set content descrition of words in suggestions strip
Bug: 14849593
Change-Id: If020e2352c8e950ce87dc4711c39b8a6a41f66fc
2014-06-09 21:40:36 +09:00
Jean Chalard
43ea8f6e77 Merge "Use RichInputConnection to get the previous word." 2014-06-09 10:47:28 +00:00
Jean Chalard
453711abe2 Use RichInputConnection to get the previous word.
We don't need the optimization of storing the old words now
that the RichInputConnection can supply it without IPC.

Bug: 13703802
Change-Id: I37ccb8d5fba879fb04b4f23d33571849736d897c
2014-06-09 19:43:20 +09:00
Jean Chalard
7a6bc607ca Split the sentences into words ourselves
The framework's default split is not suitable for all
languages. Also it does not perform very well when space
is mistyped as period.

Bug: 9063355
Bug: 10780091
Change-Id: I400d790ff1c29f221697fd94d79bbf67c61c7b8a
2014-06-09 19:38:03 +09:00
Tadashi G. Takaoka
48b96a6a52 Fix TalkBack descriptions of keyboard shift mode transition
Bug: 14846348
Change-Id: I32435a31f919974a506e598d1f3cc1b55a0866ae
2014-06-09 17:28:49 +09:00
Tadashi G. Takaoka
402e847477 Merge "Use rectangle region to ignore hover events after long press" 2014-06-09 07:56:41 +00:00
Tadashi G. Takaoka
862d7ec32e Merge "Refactor KeyCodeDescriptionMapper class a bit" 2014-06-09 07:56:28 +00:00
Tadashi G. Takaoka
176f803176 Use rectangle region to ignore hover events after long press
Bug: 15500282
Bug: 15501718
Change-Id: Ia4771198c3120a980b0a2cdd210928a4f47f5b83
2014-06-09 16:32:19 +09:00
Tadashi G. Takaoka
24fab555f9 Refactor KeyCodeDescriptionMapper class a bit
This CL adds getDescriptionForCode() method.

Bug: 15500282
Change-Id: I3bb92c8f356ea623fc992c924506b11e09256e98
2014-06-09 16:28:30 +09:00
Keisuke Kuroyanagi
7f0316c27e Merge "Add distracter cache to optimize the distracter test." 2014-06-09 05:35:46 +00:00
Keisuke Kuroyanagi
9f02a67c77 Merge "Fix: NPE after turning on personalized suggestion." 2014-06-09 05:35:32 +00:00
Keisuke Kuroyanagi
104b582c35 Add distracter cache to optimize the distracter test.
Bug: 13142176
Bug: 15428247
Change-Id: Ia390b148ffb36ace6c2010daf0f14838492413e8
2014-06-09 12:39:06 +09:00
Keisuke Kuroyanagi
65cf23eb38 Fix: NPE after turning on personalized suggestion.
Bug: 13142176
Bug: 15428247
Change-Id: I236202e3c1b70a11d512c946798035087945c0ac
2014-06-09 12:26:59 +09:00
Keisuke Kuroyanagi
a2a4ee2765 Merge "Check isInDictionary() before the distracter test." 2014-06-09 02:53:33 +00:00
Keisuke Kuroyanagi
bdf745da32 Check isInDictionary() before the distracter test.
Bug: 13142176
Bug: 15428247
Change-Id: I7ce2c09ebbef6ca8c056807c2a35f2f987fd436e
2014-06-09 11:43:45 +09:00
Keisuke Kuroyanagi
79e2e9fa8c Merge "Add Dictionary.isInDictionary()." 2014-06-09 02:40:39 +00:00
Keisuke Kuroyanagi
1910392eed Add Dictionary.isInDictionary().
Bug: 13142176
Bug: 15428247
Change-Id: If2d1c1fea7a69e41809a828da8dd032211ad144e
2014-06-09 11:04:28 +09:00
Tadashi G. Takaoka
dec599d172 Fix overwriting accessibility delegate in setKeyboard
A keyboard accessibility delegate object should be a singleton for
each keyboard view.

Bug: 15437933
Bug: 15419386
Change-Id: Ia70853c644d950ea6130c1f209b89929b1cb1ee5
2014-06-08 22:12:52 +09:00
Tadashi G. Takaoka
2385314be0 Merge "Refactor logic to determine showing suggestions strip or not" 2014-06-06 10:48:00 +00:00
Keisuke Kuroyanagi
7640bb1505 Merge "Make Distracter filter use getMaxFrequencyOfExactMatches()." 2014-06-06 10:44:04 +00:00
Tadashi G. Takaoka
987bff9136 Refactor logic to determine showing suggestions strip or not
The logic to determine when the suggestions strip (a.k.a. the
contextual strip) should be shown is already complex. In addition to
that the voice input key get shown on the strip as well. There are a
several factors to be considered and a few things to control.

- The password input field shouldn't have the strip.
- Show voice input key on the strip or not.
  - User preference settings "Show Voice Input Key".
  - A voice IME exists and is enabled.
  - The input field may have a private IME option to prevent the voice
    input key from being displayed.
- Application can specify auto completions.
  - Full screen mode or not.
- User preference settings "Show correction suggestions".
  - Always show, Show in portrait mode, Always hide.
- The input field may have flags to prevent showing suggestions or
  auto corrections.
- Suggestions is empty or not.
- An important notice may be shown.

Bug: 14981852
Bug: 15436479
Change-Id: I3050fd53ee6271fc64a8f17b6b12d9581d37b750
2014-06-06 19:41:21 +09:00
Keisuke Kuroyanagi
166d8c2293 Make Distracter filter use getMaxFrequencyOfExactMatches().
Bug: 13142176
Bug: 15428247

Change-Id: I5c23fbea2851f891f76f19d9da2cb70ae964569b
2014-06-06 19:38:44 +09:00
Keisuke Kuroyanagi
8cae9f50b4 Merge "Implement getMaxProbabilityOfExactMatches()." 2014-06-06 08:39:40 +00:00
Keisuke Kuroyanagi
d9b8602f48 Implement getMaxProbabilityOfExactMatches().
Bug: 13142176
Bug: 15428247
Change-Id: I5be6d683be95505412615ca7c88260de1ea05f54
2014-06-06 17:37:46 +09:00
Jean Chalard
6464d73ad9 Merge "When starting input, include the literal word in suggestions" 2014-06-06 07:27:40 +00:00
Tadashi G. Takaoka
bd3b20ce73 Merge "Always update voice key visibility" 2014-06-06 07:14:28 +00:00
Jean Chalard
fca2c4b439 When starting input, include the literal word in suggestions
This change also includes a fix that has suggestions re-computed
when the typed word is included but no prior suggestions were
found in spans.

Bug: 2349475
Change-Id: Ic06e6ac492507126ffc1e96a5f396c971b567272
2014-06-06 16:00:18 +09:00
Jean Chalard
eb771b9dc4 Merge "Fix a small bug with rotation." 2014-06-06 06:34:00 +00:00
Jean Chalard
c69ba5630d Fix a small bug with rotation.
Bug: 2349475
Change-Id: Id4aa5ce56b1a545e4cb88ca1b01cf24642deade2
2014-06-06 14:06:29 +09:00
Tadashi G. Takaoka
aa4b2c7127 Always update voice key visibility
Bug: 15128166
Change-Id: Ie15724c323efa3b102f6aebddc3bda210aad1727
2014-06-06 13:18:41 +09:00
Tadashi G. Takaoka
3ca65c8fd5 Remove unused supportsSwitchingToShortcutIme attribute
Change-Id: I51c5247ac925a158facb79057f704b763b903552
2014-06-06 13:11:57 +09:00
Tadashi G. Takaoka
b7206b6bca Merge "Add action key test for Lxx theme" 2014-06-06 04:08:40 +00:00
Tadashi G. Takaoka
c5dc740673 Add action key test for Lxx theme
Change-Id: I849cec7deb5607e8ce8fb25c1f903f15328fb611
2014-06-06 12:56:57 +09:00
Jean Chalard
70ff0c2122 Merge "Fix a bug on rotation with selection." 2014-06-06 03:12:12 +00:00
Jean Chalard
9fd9a68d87 Fix a bug on rotation with selection.
The symptom : when text is selected and the device is rotated,
sometimes the keyboard sets the word as being composed around
the start of the selection. Upon the next rotation this ends up
with the keyboard committing some text in place of the selection.

The cause : another bug in the framework with rotation >.>
The keyboard receives a call to startInput with a wrong cursor
position, namely one that does not represent a selection. The
keyboard sets a composition according to this wrong data. When
the keyboard is rotated again, it commits the text, which takes
the place of the selection.

The solution : actually when restarting input the keyboard
realizes that the cursor position is wrong. We cancel composition
at that time.
For robustness, this change also implements two other defensive
changes : upon call to onUpdateSelection, we actually realize
that the previous values were wrong, so we also fix it at that
time, and in addition, when rotating, we finishComposingText()
instead of commitText() which is less dangerous. Implementing
this later change also allows us to let less internal variables
from InputLogic escape to LatinIME, so it's also a good change
for design.

Bug: 14140799

Change-Id: Ib10de18e53e376ac1bbc8487e13d969828483346
2014-06-06 11:18:23 +09:00
Keisuke Kuroyanagi
0ee8644666 Merge "Add getMaxFrequencyOfExactMatches() to Dictionary." 2014-06-05 10:07:59 +00:00
Keisuke Kuroyanagi
d988fcc93d Add getMaxFrequencyOfExactMatches() to Dictionary.
Bug: 13142176
Bug: 15428247
Change-Id: I93b44ef40cafb6b811c68fa79f3a4971fc3916a5
2014-06-05 19:05:58 +09:00
Tadashi G. Takaoka
0dbf15f152 Merge "Rename some boolean variables for readability" 2014-06-05 09:33:05 +00:00
Tadashi G. Takaoka
a12d431c86 Merge "Refactor show voice key preferece migration code" 2014-06-05 09:33:03 +00:00
Tadashi G. Takaoka
2e32e37d5b Rename some boolean variables for readability
Change-Id: I434cf507e68349b9893ac084645986d6b3d7da91
2014-06-05 18:18:46 +09:00
Keisuke Kuroyanagi
d6b89e17a6 Add jni method for getMaxFrequencyOfExactMatches().
Bug: 13142176
Bug: 15428247
Change-Id: I2ae25090b67ad0c6df97dec7712e2f7e0bb08c40
2014-06-05 18:16:11 +09:00