nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30004 commits 1 branch 0 tags 363 MiB
Commit graph

4367 commits

Author SHA1 Message Date
Jean Chalard
2f69348d51 Resume suggestion at start input 
Bug: 9568410
Change-Id: I65468268f8613c863fa7f3a497b64656da0a221c
 2013-06-25 19:38:31 +09:00
Ken Wakasa
fd0945b0da Merge "Make UserLogRingCharBuffer an external class" 2013-06-25 09:40:31 +00:00
Ken Wakasa
9419e02fd9 Make UserLogRingCharBuffer an external class 
Change-Id: I9d506995337d64ec11c72939a8d739423ee46efa
 2013-06-25 18:38:13 +09:00
Jean Chalard
333362adfc Merge "Fix the one-suggestion case." 2013-06-25 09:10:09 +00:00
Jean Chalard
d7d5ff1f99 Fix the one-suggestion case. 
When there is only one suggestion, this code does
not work. The reason for that is, it's not homogeneous
at all and takes indices of one thing into another.

Not completely related to b/8839763, but realized
working on this and needed to have it addressed.

Bug: 8839763
Change-Id: I422730cc7eebb69ff421a171025af0390ebcdf92
 2013-06-25 18:00:30 +09:00
Keisuke Kuroynagi
38b542629a Merge "Add a parameter isUpdatable to the constructor of BinaryDictionary." 2013-06-25 08:44:48 +00:00
Keisuke Kuroynagi
981717da4c Add a parameter isUpdatable to the constructor of BinaryDictionary. 
Bug: 6669677
Change-Id: I6bc25131afd97112e3bbde036a81ab559a9a6460
 2013-06-25 17:39:06 +09:00
Ken Wakasa
12ef7d3702 Merge "Cleanup under the utils package" 2013-06-25 08:20:57 +00:00
Ken Wakasa
03118a2760 Cleanup under the utils package 
Change-Id: If2f7bd1346cc5085bf57645830f0faac44d017e4
 2013-06-25 17:09:12 +09:00
Keisuke Kuroynagi
8bc0b51369 Merge "Allow mmapping dictionary file in writable mode in openNative." 2013-06-25 07:09:37 +00:00
Keisuke Kuroynagi
f3b62900c7 Allow mmapping dictionary file in writable mode in openNative. 
Bug: 6669677
Change-Id: I447668932de118b158fa029ddc977b3f3cc06cb8
 2013-06-25 16:03:33 +09:00
Jean Chalard
10585620bd Merge "Fix a bug in the cached cursor pos, and simplify selection handling" 2013-06-25 05:00:11 +00:00
Jean Chalard
cdf774122d Merge "Fix a small bug" 2013-06-24 10:00:05 +00:00
Ken Wakasa
bfaf349c35 Load the native lib eagerly 
in the hope of avoiding UnsatisfiedLinkError. This is definitely not a
confident fix as we still don't know the root cause of the issue.

bug: 9325110
Change-Id: I1abf8031b98509f63fce6a2d069d497895ea712c
 2013-06-24 18:12:04 +09:00
Ken Wakasa
bc1813186d Merge "Move util classes to the latin/utils directory" 2013-06-24 08:49:06 +00:00
Jean Chalard
ca52e1ca5a Fix a small bug 
SpannableStrings are not the only type of Spanned, they are
only the mutable kind. SpannedString is the immutable one.
Spanned is the correct class to use there.

Bug: 8839763
Bug: 8862327
Change-Id: Ic5e6199a51f22368914f2748ac2d0d1ca6a33f78
 2013-06-24 17:39:17 +09:00
Ken Wakasa
e28eba5074 Move util classes to the latin/utils directory 
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
 2013-06-24 17:04:40 +09:00
Jean Chalard
e8c4b99e56 Refactor text range to be able to get spans larger than the word 
This changes how the Range class stores its data, but not its
functionality. It also improves encapsulation a bit.

Bug: 8839763
Bug: 8862327
Change-Id: I5bd583b3fc96a99b93a2632882d8fd587c03ab76
 2013-06-24 12:31:14 +09:00
Jean Chalard
b7a2fd16a1 Merge "Defer disk-intensive tasks until after the keyboard is shown" 2013-06-21 10:57:33 +00:00
Jean Chalard
673c727b7a Defer disk-intensive tasks until after the keyboard is shown 
Bug: 8689779
Change-Id: Ia78d3540f44ec0028c3246a8e0163e9ecf061ecf
 2013-06-21 19:41:45 +09:00
Jean Chalard
e5dee0af4a Fix a bug in the cached cursor pos, and simplify selection handling 
The documentation for setComposingRegion states explicitly
that it does not move the cursor. This is just a bug.
This does not have any ill effects right now, but it will have
in later changes if not fixed.

As for the selection handling, the specific test that this code
removes used to serve a purpose, but it does not any more because
the code using the value has been much sanitized. Now the variable
can just take the obvious value, and become so self-explanatory
that the comments are unnecessary.

Change-Id: I548d899b38776bd3ab5f5361aab0d89d98f12e73
 2013-06-21 18:15:07 +09:00
Tadashi G. Takaoka
9b570b5e62 Fix punctuations strip 
Bug: 9508186
Change-Id: I8f0fbf4e0578cf9116d4c57e7e5747d38c89387e
 2013-06-21 13:22:37 +09:00
Jean Chalard
93f74bafbb Merge "Add tests to dicttool test." 2013-06-20 08:34:38 +00:00
Jean Chalard
23d4eb55ba Add tests to dicttool test. 
Bug: 8526576
Change-Id: Idd6f9cd076d5915361c68f5c29afbba67dd54eba
 2013-06-20 17:29:37 +09:00
Tadashi G. Takaoka
c90181d6aa Use system default key press volume 
Bug: 9475973
Change-Id: I6ae825b161dde69e19b52d73fb9aa782e2aa7423
 2013-06-18 21:34:30 +09:00
Tadashi G. Takaoka
af69a14c96 Use system default vibration pattern 
Bug: 9468462
Change-Id: Ifa46a56873c10888da8eaa2782fe07ef138a141b
 2013-06-18 21:33:51 +09:00
Tadashi G. Takaoka
3be8263035 Get value text from ValueProxy 
As a preparation to show "system default" in the settings. LatinIME
can't know the actual system default value.

Bug: 9468462
Change-Id: I0b7898d1ca29ded7a619dd636d2ad16eb0db292e
 2013-06-18 18:27:17 +09:00
Jean Chalard
2a81943d16 Fix a bug with recapitalization 
This is a shameful bug :/

Bug: 9410367
Change-Id: I54ddbcd0323fa2c11fbd2aa8a1b3d2e07f6e83c8
 2013-06-17 20:39:06 +09:00
Kurt Partridge
14718ab898 Merge "Log score, kind, and sourceDict for manual suggestion and gesture" 2013-06-14 17:03:03 +00:00
Jean Chalard
6233ee3633 Fix a bug with long user dict entries 
Bug: 9410958
Change-Id: I966e452c6dbdcb444abbb6ffb316849a7c85a73b
 2013-06-14 12:40:35 +09:00
Kurt Partridge
fc98325c61 Log score, kind, and sourceDict for manual suggestion and gesture 
b/9422713

Change-Id: I4880fad6a5b10d09ca11b63311f14862bee724e5
 2013-06-13 11:03:49 -07:00
Jean Chalard
27d9c6f795 Merge "Cache subtype lists reasonably." 2013-06-13 01:49:41 +00:00
Kurt Partridge
e72d1a07b6 Merge "Allow downloadable dictionaries in development builds" 2013-06-12 21:22:34 +00:00
Jean Chalard
ff6445ed0e Cache subtype lists reasonably. 
This will spare a lot of IPC for Latin IME at the cost of very little
retained memory.
This improves the loading by potentially a lot - between 15 and 30%
when the layout is cached (which should now be the case almost every
time), and half that if it's not. More importantly, it makes the
load time less sensitive to high device load, which is one of the
sore points.

Bug: 8689779
Change-Id: I2e07736f1a92c38eed0e203bc690761a181da8b9
 2013-06-12 18:04:52 +09:00
Kurt Partridge
2a1a463e2e Adjust settings for development-only versions 
Change-Id: I4f08632d97f182d312edc82bda3c3897a71099ad
 2013-06-12 02:01:45 -07:00
Satoshi Kataoka
fe95e7b1bf Merge "Fix possible NPE" 2013-06-07 11:09:52 +00:00
Tadashi G. Takaoka
77f63c8ac6 Don't use RichInputMethodManager in setup wizard 
In setup wizard, InputMethodManager may not be able to be aware that
this IME is installed, especially just after the IME is installed via
GooglePlay app and hit the open button on the app to launch the setup
wizard.

Bug: 9299618
Change-Id: I00c8544178b41074253d49ae9481996ec56593d2
 2013-06-07 19:09:44 +09:00
Satoshi Kataoka
6c8136d157 Fix possible NPE 
Bug: 9314901
Change-Id: Id80f59df38ae72766b097fd1c23326fedd302439
 2013-06-07 19:08:58 +09:00
Tadashi G. Takaoka
254b484e75 Defer getting no language subtype 
Bug: 9318351
Change-Id: I55338c001070655a3f90df3dbe1351bd4180d520
 2013-06-07 18:20:31 +09:00
Jean Chalard
6910032972 Merge "Use an iterator to remove stuff from an ArrayList." 2013-06-06 08:19:41 +00:00
Jean Chalard
0dc422e0c7 Use an iterator to remove stuff from an ArrayList. 
Silly me >.>

Bug: 9306154
Change-Id: Ic00e9d6a31cd1d7aacefe68b7be9c2199e297b0d
 2013-06-06 17:03:16 +09:00
Kurt Partridge
efd26bb319 Allow downloadable dictionaries in development builds 
Bug: 9305379

Change-Id: Iab32753070a056d3861a45aa898911b7ab67dfb6
 2013-06-05 22:14:54 -07:00
Satoshi Kataoka
f6a1a76524 Merge "Fix a possible NPE" 2013-06-06 05:02:46 +00:00
Satoshi Kataoka
6f9c6f2c64 Fix a possible NPE 
Bug: 9301208
Change-Id: Id120c99ab9ef698d16cf7b8beea30c98c95d23a1
 2013-06-06 12:01:22 +09:00
Tadashi G. Takaoka
cbd219a761 Move Base64Reader to utils package 
Change-Id: Id46898c5cae268f05850d79938929b7707f27320
 2013-06-05 19:39:36 +09:00
Tadashi G. Takaoka
9d4e251826 Merge "Add CsvUtils that conform to RFC 4180" 2013-06-05 06:28:06 +00:00
Tadashi G. Takaoka
3ceeb6bcc6 Add CsvUtils that conform to RFC 4180 
Bug: 9070153
Change-Id: I66e55dd2f30fddfeb849edb97bc1cbda6b126d92
 2013-06-05 12:26:22 +09:00
Tadashi G. Takaoka
0bfc2bc419 Merge "Add CODE_CAPSLOCK for long press shift key" 2013-06-05 02:19:02 +00:00
Tadashi G. Takaoka
9552badf3c Add CODE_CAPSLOCK for long press shift key 
This change utilizes the no panel auto more key feature to implement
long press shift key for shift lock.

Change-Id: I3995d25dc35aea3c67b5aa29299815462eff9cad
 2013-06-04 18:20:06 +09:00
Tadashi G. Takaoka
cbc7acb6f5 Merge "Expand suggestion strip when center suggestion is long" 2013-06-03 14:45:05 +00:00
Tadashi G. Takaoka
9ff7354d78 Clear previous suggestions when gesture typing starts 
Bug: 8651076
Change-Id: Ic65ed3e3696409edea4e35080c11e4d1869a5a7e
 2013-06-03 17:59:26 +09:00
Tadashi G. Takaoka
043273b00f Expand suggestion strip when center suggestion is long 
Bug: 9059710
Change-Id: I7fa2658cc6442e86f69c991f1e99db6fb1ef909c
 2013-06-03 16:12:59 +09:00
Tadashi G. Takaoka
72ac390ce6 Fix ArrayIndexOutOfBoundException 
Change-Id: I243fc4965365680615eed834efe9ae0240e7f2a8
 2013-06-03 15:35:49 +09:00
Kurt Partridge
743302888b Merge "Uncommit separator LogUnits" 2013-06-03 03:01:23 +00:00
Kurt Partridge
3d20946272 Merge "Uncommit LogUnits when reverting textInput" 2013-06-03 02:58:20 +00:00
Kurt Partridge
4efb5c3b65 Merge "Remove uncommit on reverting batch input" 2013-06-03 02:54:33 +00:00
Kurt Partridge
bdff287a0d Uncommit separator LogUnits 
Now that separators have their own LogUnits, they must be uncommitted
from the LogBuffer when backspacing over them.

Bug: 9088919

Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
 2013-06-02 19:15:57 -07:00
Kurt Partridge
720840851d Uncommit LogUnits when reverting textInput 
Bug: 9088919

Change-Id: I17187aa0afc1c3e9d32269c65f66cfb3a08663cb
 2013-06-01 23:42:35 -07:00
Kurt Partridge
4165ef031f Remove uncommit on reverting batch input 
Currently when the user reverts a batch input, a LogUnit is uncommitted
from the LogBuffer.  It should not be, because the LogUnit containing the
batch input is never committed in the first place (it is only committed
to the LogBuffer when a key is pressed or a new batch input is entered).

Bug: 9088919

Change-Id: I323af453ce082437a663ccae977b21b775a964bc
 2013-06-01 11:15:47 -07:00
Jean Chalard
f61999caba Merge "Make it easy to open several dictionaries from tests" 2013-05-31 11:21:37 +00:00
Tadashi G. Takaoka
a0c3e02d71 Refactor SuggestionStripLayoutHelper a bit 
Bug: 9059710
Change-Id: Ief12029bad75d4dc78090ab97555aece01b873de
 2013-05-31 18:14:47 +09:00
Jean Chalard
1562fc91f0 Make it easy to open several dictionaries from tests 
Bug: 9127175
Change-Id: I3f1840ee73b364df26dfddb5acb10001e0f2cb61
 2013-05-31 15:36:05 +09:00
Tadashi G. Takaoka
723391c945 Merge "Tidy up Utils class a bit" 2013-05-31 06:29:24 +00:00
Kurt Partridge
e6125db98d Merge "Catch a permission exception" 2013-05-31 00:30:14 +00:00
Kurt Partridge
d63f756013 Catch a permission exception 
This change catches a SecurityException if the DictionaryProvider is
unavailable.

Change-Id: I4f2d87327c40765383d8847fd4e934b3cf799488
 2013-05-30 13:40:40 -07:00
Tadashi G. Takaoka
cbb99c60be Tidy up Utils class a bit 
Change-Id: Idc2feb84a902a6cbb7265d1efe06c34e7d63c2c7
 2013-05-31 00:32:57 +09:00
Tadashi G. Takaoka
7097aa2d3d Merge "Cleanup unreadable variable names" 2013-05-30 13:09:27 +00:00
Tadashi G. Takaoka
d67db32b30 Merge "Separate SuggestionStripLayoutHelper for readablity" 2013-05-30 13:09:17 +00:00
Jean Chalard
1a50999ed9 Merge "Tell the text view we reset state on finish input" 2013-05-30 11:53:50 +00:00
Jean Chalard
e90d039e0c Fix two strict mode warnings. 
Bug: 9052555
Change-Id: I86e90488679a78a9f6e901b640025619293765a0
 2013-05-30 20:12:05 +09:00
Tadashi G. Takaoka
500a9752b1 Cleanup unreadable variable names 
Change-Id: Ic97687c58e25e4b0c6833cc25d10854f5f513081
 2013-05-30 19:49:51 +09:00
Tadashi G. Takaoka
653603b725 Separate SuggestionStripLayoutHelper for readablity 
Change-Id: I82c749c6837c3af7ae290f4cd92f5426ca58b5c7
 2013-05-30 19:49:20 +09:00
Jean Chalard
68d9cb62e2 Tell the text view we reset state on finish input 
This should be done in onFinishInput rather than onFinishInputView
but for an unknown reason onFinishInput never comes.

Bug: 9113167
Change-Id: Iafb40846a3ed8fad78bfc160d17cd431f81fe891
 2013-05-29 18:44:40 +09:00
Tadashi G. Takaoka
d99abf8cb1 Delete shared preference entry when user select default value 
Change-Id: I3fbafd9024c26a99d87376f5d5e359e03988a30f
 2013-05-28 20:44:25 +09:00
Tadashi G. Takaoka
39bd6ea0dc Merge "Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs" 2013-05-28 11:40:10 +00:00
Tadashi G. Takaoka
dbed20ad8d Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs 
Change-Id: I16e3f3ebc43772cfd96c824afeddfd225404b857
 2013-05-28 20:23:37 +09:00
Tadashi G. Takaoka
d69e4191b7 Merge "Refactor suggestion strip layout methods a bit" 2013-05-28 11:11:05 +00:00
Tadashi G. Takaoka
389d308fff Refactor suggestion strip layout methods a bit 
Bug: 9059710
Change-Id: I8dc698c1d61ca51b65b232e6c586472588a4accb
 2013-05-28 20:03:37 +09:00
Tadashi G. Takaoka
4c2ac9ee5f Merge "Rename commaConcatinatedText to commaSplittableText" 2013-05-28 10:58:16 +00:00
Tadashi G. Takaoka
c47bc30db8 Rename commaConcatinatedText to commaSplittableText 
This is a follow up of I5a32882a08.

Change-Id: I9f0cda2167811f6bba2af042fbde0a821b4cfecd
 2013-05-28 19:17:15 +09:00
Tadashi G. Takaoka
68cf2cd931 Merge "Check all regexp patterns in ResourceUtils.getDeviceOverrideValue" 2013-05-28 10:13:43 +00:00
Keisuke Kuroyanagi
e168a3c2a5 Merge "Adding additional feature settings." 2013-05-28 10:11:29 +00:00
Tadashi G. Takaoka
4c75ea858a Check all regexp patterns in ResourceUtils.getDeviceOverrideValue 
This change also fixes a regexp error of Galaxy S III.

Change-Id: I42a4780bbfd2b083f4e27e61ec513aa875907344
 2013-05-28 19:05:40 +09:00
Satoshi Kataoka
07e56e76a7 Merge "Implement KIND_OOV_CORRECTION" 2013-05-28 07:27:53 +00:00
Keisuke Kuroyanagi
1b100610b3 Adding additional feature settings. 
Change-Id: I9fec0c03b7da9ce0305b494193f4cfe3fca144f3
 2013-05-28 00:27:48 -07:00
Tadashi G. Takaoka
1b46738796 Rename "csv" in StringUtils to "commaConcatenatedText" 
Change-Id: I5a32882a088e4ff5bfe973a86465d6ff839113d9
 2013-05-28 16:13:36 +09:00
Satoshi Kataoka
3d97b95b90 Implement KIND_OOV_CORRECTION 
Bug: 9127749
Change-Id: I96db15a3138e6b522c4c6ad16cc7faad577d3772
 2013-05-27 18:53:43 -07:00
Keisuke Kuroyanagi
28b6262b54 Merge "Passing options to native suggestion method." 2013-05-24 22:27:19 +00:00
Tadashi G. Takaoka
740d829092 Merge "Use localized toLowerString in AutoCorrection.isValidWord" 2013-05-24 20:00:38 +00:00
Tadashi G. Takaoka
94027c7201 Use Locale.ROOT for locale neutral operations 
Bug: 9112465
Change-Id: I6cd63007287b5a1a57cfbabff35d53f66fc5620e
 2013-05-24 12:07:30 -07:00
Tadashi G. Takaoka
618407ab7e Use localized toLowerString in AutoCorrection.isValidWord 
Bug: 9112465
Change-Id: I63eb4115f393444560e80220d4c90f0f7101b934
 2013-05-24 11:47:36 -07:00
Tadashi G. Takaoka
ebe0544fc8 Remove redundant method AutoCorrection.isInTheDictionary 
Change-Id: I0737fb0b68f411f4db06014f2d94804935808922
 2013-05-24 11:40:03 -07:00
Keisuke Kuroyanagi
50db5f0fff Passing options to native suggestion method. 
Change-Id: I6da180cfa1b9e5aa39600e78e3bc41209a40f583
Signed-off-by: Keisuke Kuroyanagi <ksk@google.com>
 2013-05-24 10:21:04 -07:00
Tadashi G. Takaoka
6f9105383a Remove unnecessary methods of KeyboardSwitcher 
Change-Id: Idd3647bb1a1d40df8bb89eda715d45427a58d0cd
 2013-05-22 10:49:53 -07:00
Tadashi G. Takaoka
db7d4da3e5 Clean up IntentCompatUtils a bit 
Change-Id: I803aa6c2160bfa1ffe992b28e7eb6e8a320c9762
 2013-05-21 15:13:23 -07:00
Jean Chalard
d96f63d2ed am e2bee5b1: am ede3db51: Merge "Fix a crash on a secondary user" into jb-mr2-dev 
* commit 'e2bee5b134aaefc69a680be8ea65e2d7640b3ead':
  Fix a crash on a secondary user
 2013-05-20 21:32:21 -07:00
Jean Chalard
ede3db51f0 Merge "Fix a crash on a secondary user" into jb-mr2-dev 2013-05-21 04:27:34 +00:00
Jean Chalard
05ea7c5d02 am 167ba345: am 89fe1f50: Add a method to work around apps broken by recorrection 
* commit '167ba3459b0ce02b9add12ade9388bd2b1e6eb62':
  Add a method to work around apps broken by recorrection
 2013-05-20 21:10:07 -07:00
Satoshi Kataoka
10e8b93977 Fix a crash on a secondary user 
Bug: 9054063
Change-Id: I092ab6e0077578d0aca57d2e41dfbc00b46e1ba4
 2013-05-21 12:27:16 +09:00
Jean Chalard
0013f97ddd am 5906b05b: am 7058b02a: Extract a new class for app-specific workarounds. 
* commit '5906b05bb50c0a67bd4f03fcfae41db3daefe0bc':
  Extract a new class for app-specific workarounds.
 2013-05-20 19:50:46 -07:00
Jean Chalard
89fe1f5088 Add a method to work around apps broken by recorrection 
Bug: 8944307
Change-Id: I8986622554f30aaf4f595099c4ab5652b75c972c
 2013-05-21 07:53:31 +09:00
Jean Chalard
7058b02a9c Extract a new class for app-specific workarounds. 
Bug: 8944307
Change-Id: Iaff9dd03d3d856a6bdaa2b16c4e71e95cd2b6349
 2013-05-21 07:53:28 +09:00
Kurt Partridge
500dea6ad4 Fix punctuation logging 
Punctuation is currently put into the same LogUnit as the
following word.  This is counter-intuitive and makes
post-processing more complicated.

This change causes punctuation to be put into its own
LogUnit.

A tricky case is the phantom space.  A phantom space is
inserted right before other text, whose MotionEvents have
already been collected and inserted into mCurrentLogBuffer.
Phantom spaces are handled by creating their own LogUnit and
inserting it into the LogBuffer right before
mCurrentLogBuffer is shifted in.

Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
 2013-05-17 09:47:40 -07:00
Kurt Partridge
17b63ba588 Merge "Remove unnecessary commit/uncommit" 2013-05-15 23:52:43 +00:00
Jean Chalard
b1e37e4a47 am f1dcf725: Merge "Don\'t process recorrection or resets when not shown" 
* commit 'f1dcf725061b3e61e40540566a5385cf4934f424':
  Don't process recorrection or resets when not shown
 2013-05-15 07:58:27 -07:00
Tadashi G. Takaoka
25f0c8089e am 96a9f357: Merge "Fix unintentional setup step advance in orientation change" 
* commit '96a9f357c7e2a059687926cd7cd52ac5d06bc65e':
  Fix unintentional setup step advance in orientation change
 2013-05-15 07:58:18 -07:00
Tadashi G. Takaoka
7fe675440e am 769427cf: Adjust aspect ratio of setup image 
* commit '769427cff24944958f5f1f6179090a86444f3eab':
  Adjust aspect ratio of setup image
 2013-05-15 07:57:38 -07:00
Jean Chalard
f1dcf72506 Merge "Don't process recorrection or resets when not shown" 2013-05-15 11:25:25 +00:00
Jean Chalard
c9aaba1253 Don't process recorrection or resets when not shown 
Bug: 8954116
Change-Id: Ica27dbfc570643bb81e6cdf34cc7c796ea080d71
 2013-05-15 20:20:20 +09:00
Tadashi G. Takaoka
9b4a883e09 Fix unintentional setup step advance in orientation change 
Bug: 8159728
Change-Id: I53e7d7c8fb5cc231ea94474b091e550f77ae8dab
 2013-05-15 19:50:35 +09:00
Tadashi G. Takaoka
769427cff2 Adjust aspect ratio of setup image 
Bug: 8159728
Change-Id: I578014912fa63c4c9b4c2c89aeae7ffec836b06c
 2013-05-15 14:48:27 +09:00
Kurt Partridge
993acbaaa2 Remove unnecessary commit/uncommit 
When the user reverts a commit, this causes the committed
word to be changed. The user usually then goes back to edit
that word.  Going back to edit causes an uncommit, so that
the editing actions are added onto the LogUnit containing
the operations used to construct the word.

But currently, reverting also involves its own
commit/uncommit pair, with the caller performing the
uncommit, and the commit happening inside the revert
command.  This may have been necessary in the past, when
revert was called in different situations, but is
unnecessary now.  Furthermore, the guarding conditions are
currently such that the uncommit doesn't always undo the
effects of the commit, corrupting the log output.

Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
 2013-05-14 12:20:27 -07:00
Tadashi G. Takaoka
8b56ad7814 Merge "Revise welcome screen video and still image" 2013-05-14 12:01:47 +00:00
Tadashi G. Takaoka
7348d9fb72 Revise welcome screen video and still image 
Bug: 8159728
Change-Id: Ief8d7197879d24ccef529e975c23d6f11c7aa458
 2013-05-14 20:56:09 +09:00
Ken Wakasa
d6d70e7325 Merge "Revert "Fix isSuggestionsStripVisible when keyboard hidden"" 2013-05-14 11:46:04 +00:00
Ken Wakasa
3efa36f6aa Revert "Fix isSuggestionsStripVisible when keyboard hidden" 
This reverts commit cb0d1c4c58

Change-Id: Ie2c8e01c25bd051b6157e8f32ab84392a0c7252a
bug: 8954116
 2013-05-14 11:44:22 +00:00
Tadashi G. Takaoka
41016acacf Back to previous keyboard layout by canceling sliding input 
Bug: 8915171
Change-Id: Iabdeb7920f67f89246087c3ee06240406ecfbc3d
 2013-05-14 20:28:03 +09:00
Jean Chalard
cb0d1c4c58 Fix isSuggestionsStripVisible when keyboard hidden 
When the keyboard is hidden, the suggestion strip is
never visible.

Bug: 8954116
Change-Id: I9f242d07b49ad60b625a22429bb013251e814905
 2013-05-14 15:19:19 +09:00
Tadashi G. Takaoka
b121538e0c Tune maximum keypress duration to 100 milliseconds 
Bug: 8556975
Change-Id: If7839c5764f7a269243a9570c0b7782b6f7ee73b
 2013-05-13 20:04:59 +09:00
Tadashi G. Takaoka
b5f67e7faf Add device specific keypress vibration duration database 
Bug: 8556975
Change-Id: I11260a64dc13c102bac7a9742dc66f2b05fd32de
 2013-05-13 18:34:48 +09:00
Tadashi G. Takaoka
18184eacb1 Support regular expression for condition pattern 
Bug: 8556975
Change-Id: Iffc53d6a40dd77860434c5f7f4f59af5cd1ba92b
 2013-05-13 16:25:03 +09:00
Tadashi G. Takaoka
d69fa0a09a Support multiple condition for getDeviceOverrideValue 
Bug: 8556975
Change-Id: I29d3a305b6ac3d8e3620c6d8592d85047d62bf48
 2013-05-13 14:38:21 +09:00
Tadashi G. Takaoka
565ced4546 Merge "Refactor StringUtils.findPrefixedString to findValueOfKey" 2013-05-10 09:49:07 +00:00
Tadashi G. Takaoka
6d3d2ae064 Refactor StringUtils.findPrefixedString to findValueOfKey 
Bug: 8556975
Change-Id: I275c99db8a0d10594a5a8c0c27ebc1a87495c307
 2013-05-10 18:44:04 +09:00
Tadashi G. Takaoka
4705c0fa7c Fix screen flash when launching settings activity 
Bug: 8336068
Change-Id: I90a0f259129a3f3319b158b060154cc43960c234
 2013-05-10 15:36:24 +09:00
Tadashi G. Takaoka
2b5c9726f4 Introduce another activity to launch setup wizard 
Bug: 8336068
Change-Id: I35b94dd87c5b01d3e927da8f918a5398dd565d33
 2013-05-10 15:30:53 +09:00
Tadashi G. Takaoka
9ed322b40f Keep SetupActivity alive to check re-launching from launcher 
Bug: 8336068
Change-Id: I183b8e3fd1b3898d5f8dbbb13a0c93c64341fc38
 2013-05-10 15:15:53 +09:00
Satoshi Kataoka
b902109000 Fix usages of getEnabledInputMethodSubtypeList 
Bug: 8450279
Change-Id: Ib8433442ae6ca6c28da2652bff687cdeaf7c196e
 2013-05-09 17:07:19 +09:00
Jean Chalard
71d52474fd Merge "Optimizations and safeguards." 2013-05-08 10:11:49 +00:00
Jean Chalard
9f9cc03277 Optimizations and safeguards. 
- Don't call finishComposingText when useless.
- Add safeguards against calling setComposingRegion when the
  data returned by the editor is inconsistent.
- Cancel pending recorrection messages when new messages arrive.

Bug: 8842941
Bug: 8845001
Change-Id: I939701033cf5c2bbd85871ecf83e329021ddeb91
 2013-05-08 18:47:10 +09:00
Satoshi Kataoka
5648054667 Add account e-mail addresses to the user dictionary 
Bug: 8683365
Change-Id: Id72540c515e61c3dd854892599645dd6d22b496d
 2013-05-08 17:58:21 +09:00
Satoshi Kataoka
faa94a2d0a Merge "Add owner's info to the dictionary" 2013-05-08 08:31:45 +00:00
Satoshi Kataoka
fc6d4a5412 Add owner's info to the dictionary 
Bug: 8683365
Change-Id: I1c30eac128b4172526423ebeeb45bc6cee7fb67b
 2013-05-08 17:29:04 +09:00
Satoshi Kataoka
6435c80087 Merge "Fix an issue on the transition between the setup and the settings" 2013-05-08 08:23:49 +00:00
Tadashi G. Takaoka
331d256f21 Fix an issue on the transition between the setup and the settings 
Bug: 8853220

Change-Id: I99b6c46d900e9391f77986d1ae6e3edeaeff01e5
 2013-05-08 15:18:45 +09:00
Satoshi Kataoka
f59c4f6840 Fix labels in the personal dictionary settings 
Bug: 8855738
Bug: 8853764
Change-Id: I03383bb5d6d72645f511cc6175dec747eb13a840
 2013-05-08 14:58:43 +09:00
Satoshi Kataoka
244a24e368 Consolidate dummy proximity info to the spell checker info 
Bug: 8783170

Change-Id: I067486e5ec1ae7cdef8e2121392464ba71ee8add
 2013-05-08 11:49:12 +09:00
Jean Chalard
2afe88b8d7 Merge "Unify space-adding on gestures." 2013-05-07 11:51:01 +00:00
Jean Chalard
e8b9b35471 Unify space-adding on gestures. 
This is much simpler, and more correct.

Bug: 8808497
Change-Id: I7a56bf9d6d9fb481f898b7a9f5898a86c11b34c0
 2013-05-07 20:38:09 +09:00
Satoshi Kataoka
a9dd74cf3f refactor spell checker 
Change-Id: Ie7bea23f2ac54f03572e77c31ba7cb3d5e8f8d2f
 2013-05-07 20:21:11 +09:00
Tadashi G. Takaoka
a5be033d4a Preserve setup wizard step while orientation change 
Bug: 8159728
Change-Id: I596f59749443b8878b5613285f0fe793d449cdbd
 2013-05-02 18:42:10 +09:00
Jean Chalard
83757d439e Merge "Pass blockOffensiveWords as a parameter" 2013-05-01 11:57:36 +00:00
Jean Chalard
2dbb5957e3 Pass blockOffensiveWords as a parameter 
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
 2013-05-01 20:47:35 +09:00
Ken Wakasa
1490b53416 Cleanup -- follow up to Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1 
Change-Id: Icb89c5119a67edaa019d5f7645b734cfcfc29041
 2013-05-01 20:19:05 +09:00
Satoshi Kataoka
1641a4a457 Merge "Fix Google spell checker tests" 2013-05-01 09:31:52 +00:00
Satoshi Kataoka
d5781eef62 Fix Google spell checker tests 
Bug: 8613307

Change-Id: Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
 2013-05-01 18:21:56 +09:00
Tadashi G. Takaoka
6f7905ae75 Introduce MoreSuggestionsListener class 
Bug: 8694255
Change-Id: I9420a7cb1983c6211f58d13b3b11db4347c3f99b
 2013-05-01 18:03:37 +09:00
Tadashi G. Takaoka
47a66b12ec Override View.drawableStateChanged to detect state_pressed 
Unlike on JB, View.setPressed(boolean) is never called when the view
is pressed on ICS. To detect a pressed state of the view, we need to
override View.drawableStateChanged() and check the drawable state
contains state_pressed.

Bug: 8159728
Change-Id: I481051364d6f3d1370742723c3ce19d898ea5463
 2013-05-01 14:02:18 +09:00
Tadashi G. Takaoka
7b2114a428 Display still image when device can't play welcome video 
Note that the still image in this change is a placeholder and must be
replaced by final asset.

Bug: 8159728
Change-Id: I4f5a28e0af711edacbc87c2ee64508f34f67f0da
 2013-05-01 12:24:36 +09:00
Jean Chalard
019c38060d am ace3f3c5: am 25c90e6d: Merge "Don\'t do recorrection when suggestions are off." into jb-mr2-dev 
* commit 'ace3f3c5d56f5b4a58e8dc400fec1bb8c7b17a63':
  Don't do recorrection when suggestions are off.
 2013-04-30 19:22:13 -07:00
Jean Chalard
aa3a96f3a1 Don't do recorrection when suggestions are off. 
Bug: 8767981
Change-Id: If5c775e488b91ae03ecce2673c99918ac8134928
 2013-05-01 10:17:28 +09:00
Ken Wakasa
a0b62ece83 Merge "Cleanup an unused return value" 2013-04-30 11:16:28 +00:00
Tadashi G. Takaoka
ad46c9e0e0 Catch error while playing welcome video 
Bug: 8159728
Change-Id: Ic8eea7993f12395d6eca6db8d5529803251a9fee
 2013-04-30 18:18:32 +09:00
Ken Wakasa
0d6c87d113 Cleanup an unused return value 
Change-Id: I974964aa3cc24b5480e57bd38c197fe7a49acaa4
 2013-04-30 16:53:18 +09:00
Satoshi Kataoka
5aa14c2636 Fix the title of the fragment of the personal dictionary 
This change is corresponding to I9b8bab21b144385bc2386e7fcb

Bug: 8600958
Change-Id: I0a0cf37d0a11c14a51dc63b2e4371facb34514d0
 2013-04-30 15:01:51 +09:00
Jeff Sharkey
c5ebc792d6 Avoid leaking AssetFileDescriptor. 
Change-Id: Iac388c8aefc684980cb4c7131fb47319f6073eb3
 2013-04-29 12:26:44 -07:00
Tadashi G. Takaoka
be06bce18b Merge "Get rid of janky black box before the movie starts" 2013-04-26 09:38:54 +00:00
Tadashi G. Takaoka
732c93815a Get rid of janky black box before the movie starts 
Bug: 8159728
Change-Id: I1d0a01a05b3b694d21fdfdc246d1329ab829908d
 2013-04-26 18:26:12 +09:00
Jean Chalard
c03aaa1bde Merge "[ZF2] Read settings for profanity filtering." 2013-04-26 08:23:56 +00:00
Satoshi Kataoka
adbafa1a9b Merge "Support ICS on the user dictionary settings" 2013-04-26 06:50:42 +00:00
Satoshi Kataoka
dcef94165b Support ICS on the user dictionary settings 
Bug: 8600958
Change-Id: I50e9228afc7b04147eb7c4734d3145abe8859a30
 2013-04-26 15:48:08 +09:00
Tadashi G. Takaoka
82e476b188 Keep task stack when invoking settings from setup wizard 
Bug: 8336068
Change-Id: If1df32595f72285b2dad16e28b4429b7b6059839
 2013-04-26 13:03:37 +09:00
Jean Chalard
bb61293675 [ZF2] Read settings for profanity filtering. 
Bug: 7226877
Change-Id: Ie0c713e1eba1529c0b288a1e5011023a79bedd6b
 2013-04-25 20:29:14 +09:00
Jean Chalard
99e998286d [ZF1] Check profanity in Java rather than in native 
Bug: 7226877
Change-Id: Ib6c32bfee9977c27dbf7e1e590b2b00d9ceb7301
 2013-04-25 20:29:11 +09:00
Jean Chalard
43590149a5 Work around a bug in older DownloadManager versions. 
This adds a number to the extension.

Note that for DownloadManager to keep this, the server
needs to send it a mime type it does not recognize. Right
now, it does not recognize application/json so it's okay,
but we'd do well to remove the content/type header from
the server to prevent problems.

Bug: 8467516
Change-Id: Ic484f66ac3f67c36f59f2c0bcb8c7fdeb6e8590d
 2013-04-25 18:52:39 +09:00
Jean Chalard
a995bf4031 Put temp files within app files 
Bug: 8715614
Change-Id: I307d83923070994525cf0d27aad403e881a89314
 2013-04-25 18:14:40 +09:00
Satoshi Kataoka
30f0f3a92a Merge "Implement a functionality to add an entry to the user dictionary" 2013-04-25 06:04:08 +00:00
Satoshi Kataoka
a79ba8a3d6 Implement a functionality to add an entry to the user dictionary 
Bug: 8600958

Change-Id: Ic472500406b9d54ec4052c490ee7cef62fc4e52a
 2013-04-25 14:55:07 +09:00
Tadashi G. Takaoka
46913aedb4 Merge "Add next axction to setup wizard" 2013-04-24 10:30:56 +00:00
Tadashi G. Takaoka
b5d33059e0 Add next axction to setup wizard 
Bug: 8159728
Change-Id: Ia37ab32b63e4eda29bf1411719d00846525c278f
 2013-04-24 19:22:41 +09:00
Satoshi Kataoka
b35aa487fd Merge "Make aggressive threshold really aggressive" 2013-04-24 09:14:30 +00:00
Satoshi Kataoka
70f2762e28 Make aggressive threshold really aggressive 
Bug: 8701480
Change-Id: If8242cfe61f3e56712fd6e25e36858cff7f0d177
 2013-04-24 17:49:56 +09:00
Tadashi G. Takaoka
e918bf07a0 Refactor SetupStepGroup 
Bug: 8159728
Change-Id: I1ab846d0910aacbd2f979289d72bafea8a8e0378
 2013-04-24 14:15:59 +09:00
Tadashi G. Takaoka
480284e28a Merge "Add edit personal dictionary settings menu" 2013-04-23 06:01:45 +00:00
Jean Chalard
c3f4783649 Add an additional ID to the client info. 
Bug: 8651863
Change-Id: I748f35726d72ede926d5b06ed87ff029317f1ac3
 2013-04-23 14:37:15 +09:00
Satoshi Kataoka
9b4e3db1af Legal notice 
Bug: 8533258
Change-Id: I00e4916f86f29dd476c51a65e8fa5a6c136fd179
 2013-04-22 21:55:53 +09:00
Tadashi G. Takaoka
4f2535398a Add edit personal dictionary settings menu 
Bug: 8600958
Change-Id: I303adfbe25a56cc9b5ee9f3b5169a5bca0ad6c4a
 2013-04-22 19:59:12 +09:00
Tadashi G. Takaoka
508ab24875 Merge "Implement IMM.switchToNextInputMethod() for ICS" 2013-04-22 10:37:11 +00:00
Tadashi G. Takaoka
85629debaa Implement IMM.switchToNextInputMethod() for ICS 
Bug: 8633367
Change-Id: Ifc0f97b1fdf5e5cc3601c24a503058c4822478dc
 2013-04-22 19:30:56 +09:00
Jean Chalard
f0e579a171 Don't kill suggestions with native score < 1 
Change-Id: I954856b7fec0b91e19a467f2a87978d49caa639d
 2013-04-22 14:21:43 +09:00
Tadashi G. Takaoka
68e4de1e78 Add welcome screen to setup wizard 
This is a preliminary implementation because the welcome screen video
is just a placeholder.

Bug: 8159728
Change-Id: I6a2459a266babec2f078fc393b18c77b0b7992a8
 2013-04-19 20:49:49 +09:00
Tadashi G. Takaoka
fcefabf9ab Groundwork to implement landscape and welcome screen 
Bug: 8159728
Change-Id: I05ff6578980ec2e210ebb482ea51b1600e74a4f4
 2013-04-19 20:10:59 +09:00
Tadashi G. Takaoka
16ec2e1155 Merge "Add finish action to setup wizard" 2013-04-19 10:58:55 +00:00
Tadashi G. Takaoka
192743a6ae Add finish action to setup wizard 
Bug: 8159728
Change-Id: I1578fc31875a1edbfea213fb5e1a1b464d02e941
 2013-04-19 19:44:54 +09:00
Jean Chalard
ff078041e7 am f1dde6a1: am 758c74fe: Merge "Fix an NPE in recorrection" into jb-mr2-dev 
* commit 'f1dde6a1bf659d182db5a2645515cc1efe74459c':
  Fix an NPE in recorrection
 2013-04-19 00:10:22 -07:00
Jean Chalard
e5cbdfe1b8 am 3629605b: am 77226ed0: Merge "Fix an NPE in recapitalize" into jb-mr2-dev 
* commit '3629605b7c14b5eea498ef9588f4fef788ef454c':
  Fix an NPE in recapitalize
 2013-04-19 00:06:58 -07:00
Jean Chalard
758c74fe82 Merge "Fix an NPE in recorrection" into jb-mr2-dev 2013-04-19 07:03:19 +00:00
Jean Chalard
77226ed006 Merge "Fix an NPE in recapitalize" into jb-mr2-dev 2013-04-19 07:01:10 +00:00
Jean Chalard
ae7d1530b4 Fix an NPE in recorrection 
Also, theoretically, we don't want to retrieve older suggestions if
there are no results for a recorrection - that would look random.
This bug addresses this too.

Bug: 8657919
Change-Id: I44f36d34a708a968ab71fa0592da57f4c97d4b7f
 2013-04-19 15:53:33 +09:00
Jean Chalard
3bdf341ea0 Fix an NPE in recapitalize 
Bug: 8657736
Change-Id: I459d1c200826c1c394f8207475ecf60a4f356793
 2013-04-19 15:44:20 +09:00
Tadashi G. Takaoka
1f6e06cf92 Merge "Make setup wizard step number highlighted when activated" 2013-04-19 03:21:04 +00:00
Tadashi G. Takaoka
b84c0468e4 Make setup wizard step number highlighted when activated 
Bug: 8159728
Change-Id: I62ccbebaae0a0c4a93ad7c155fc3020a7f357f3c
 2013-04-19 11:14:21 +09:00
Jean Chalard
3a18ae70cc am a5d2da82: am d91268ad: Initialize dictionaries at onStartInputView 
* commit 'a5d2da82a6a4486a4ef74e51ddd1c875f4c2d935':
  Initialize dictionaries at onStartInputView
 2013-04-18 09:27:35 -07:00
Jean Chalard
d91268ad9f Initialize dictionaries at onStartInputView 
Bug: 8344402
Change-Id: I41b8440f0d72a66fde3f6feb0db8239c9bb10ea3
 2013-04-18 14:48:42 +09:00
Tadashi G. Takaoka
d794f5ae2a Update setup wizard icons 
Bug: 8159728
Change-Id: Ia5a14a35292b43dc1eaa2d4edd65134040355149
 2013-04-18 13:15:53 +09:00
Tadashi G. Takaoka
464202047d Add user feedback to setup action labels and icons 
Bug: 8159728
Change-Id: I46c77c31973ae492c2a12291f2e0b154f64d26c9
 2013-04-17 19:57:46 +09:00
Tadashi G. Takaoka
47a78aeb4d Merge "Finalize setup wizard strings and mark as translatable" 2013-04-17 10:55:41 +00:00
Tadashi G. Takaoka
8712ac7945 Finalize setup wizard strings and mark as translatable 
Bug: 8159728
Change-Id: I9f6f04b09b2cefdb7ece76a4f3c39ab56d0c8fab
 2013-04-17 19:52:50 +09:00
Tadashi G. Takaoka
bb5deb82b5 Fix singleton/utility classes initialization in SettingsFragment 
This is a follow up of Ide3cd3acba.

Bug: 8632344
Change-Id: Iafe51798a1a74eff5d8fcd6f0117d16b419d447d
 2013-04-17 16:16:10 +09:00
Tadashi G. Takaoka
888a194cf1 Fix missing AudioAndHapticFeedbackManager initialization 
Bug: 8632344
Change-Id: Ide3cd3acba3987317cff709fa591eadaa71834e8
 2013-04-17 15:32:01 +09:00
Jean Chalard
73ec85b8ad Don't insert automatic spaces when text looks like a URL 
This is about as ad-hoc as it gets, but then again, what we want
is probably as ad-hoc as it gets.
All URL boxes I know of double as search bars, and not adding
automatic spaces there sucks (e.g. in Chrome URL bar).
And in other boxes actually you don't want to add a space if
it looks like a URL. QSB isn't even a search box, and it behaves
like this.

So I think this is actually the right answer to the problem.

Bug: 7062925
Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
 2013-04-16 18:03:49 +09:00
Jean Chalard
78d658734d Merge "Don't recapitalize on shift while on symbol layout" 2013-04-16 05:31:43 +00:00
Jean Chalard
1f52364630 Don't recapitalize on shift while on symbol layout 
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
 2013-04-16 14:29:02 +09:00
Jean Chalard
8094bf45d7 Match the keyboard state to the recapitalize state. 
Bug: 7657025
Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
 2013-04-16 14:25:03 +09:00
Jean Chalard
e259b9f57d Merge "Clean up RecapitalizeStatus" 2013-04-16 04:57:35 +00:00
Jean Chalard
fd15686ae9 Merge "Fix an NPE" 2013-04-16 04:12:18 +00:00
Jean Chalard
b794e904a3 Clean up RecapitalizeStatus 
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
 2013-04-16 13:11:18 +09:00
Jean Chalard
a024ac6b20 Merge "Fix an NPE" 2013-04-16 03:43:06 +00:00
Jean Chalard
2b42ad0eaa Fix an NPE 
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
 2013-04-16 12:20:10 +09:00
Jean Chalard
7be3ca2ccf Fix an NPE 
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
 2013-04-16 12:17:22 +09:00
Jean Chalard
5fca38c538 Merge "Small performance improvement / minor bugfix" 2013-04-15 14:28:16 +00:00
Jean Chalard
b76ce1251e Merge "Remove a useless function" 2013-04-15 13:06:33 +00:00
Jean Chalard
bc501647fd Remove a useless function 
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
 2013-04-15 22:01:37 +09:00
Jean Chalard
1e5bbe4ce8 Small performance improvement / minor bugfix 
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.

Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
 2013-04-15 21:18:50 +09:00
Jean Chalard
a5a2f3e3c7 Remove gesture suggestions with an INT_MIN score 
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
 2013-04-15 20:55:49 +09:00
Jean Chalard
033958330d Merge "Have Latin IME re-capitalize a selected string" 2013-04-15 11:29:28 +00:00
Jean Chalard
2995abe7aa Have Latin IME re-capitalize a selected string 
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.

Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
 2013-04-15 20:23:01 +09:00
Jean Chalard
0e9ee4d3bf If there are no suggestion span, recompute suggestions. 
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
 2013-04-15 19:33:23 +09:00
Jean Chalard
059e084e98 Merge "Reject a previously user-refused suggestion." 2013-04-15 07:45:34 +00:00
Jean Chalard
d40f3f6bc1 Reject a previously user-refused suggestion. 
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.

Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
 2013-04-15 16:36:44 +09:00
Tadashi G. Takaoka
216fb6a042 Remove unnecessary harmful finish() from SettingsActivity 
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
 2013-04-15 16:26:40 +09:00
Tadashi G. Takaoka
29105a725d Add preference dependency to gesture input related options 
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
 2013-04-15 15:07:49 +09:00
Tadashi G. Takaoka
e2af9b7eb5 Merge "Reset vertical correction when more suggestions are in modal mode" 2013-04-15 04:57:33 +00:00
Tadashi G. Takaoka
51c38a441a Reset vertical correction when more suggestions are in modal mode 
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
 2013-04-15 13:56:03 +09:00
Jean Chalard
c2e9c511cb Fix Binary dict tests 
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
 2013-04-15 12:48:16 +09:00
Jean Chalard
2cd1136b8e Merge "Remove the dialog to insert words to the dictionary." 2013-04-12 12:33:24 +00:00
Jean Chalard
91bcf5eb5d Merge "Restart suggestions when the cursor moves." 2013-04-12 12:27:50 +00:00
Jean Chalard
02ce3dc2d1 Fix a bug with bad application completions 
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
 2013-04-12 20:53:06 +09:00
Jean Chalard
6a114fa700 Restart suggestions when the cursor moves. 
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.

Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
 2013-04-12 20:49:03 +09:00
Jean Chalard
d24f939712 Merge "Make shortcut-only user dict entry non-words." 2013-04-12 11:02:00 +00:00
Jean Chalard
fb5869e9ff Merge "Add a class to encapsulate getting the metadata URI" 2013-04-12 11:01:36 +00:00
Jean Chalard
6a2a4b8e4d Make shortcut-only user dict entry non-words. 
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
 2013-04-12 16:17:09 +09:00
Jean Chalard
1a51833828 Remove the dialog to insert words to the dictionary. 
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
 2013-04-12 15:58:50 +09:00
Jean Chalard
8987cccf89 Add a class to encapsulate getting the metadata URI 
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
 2013-04-11 17:52:16 +09:00
Jean Chalard
b5d5190deb Merge "Add some utility functions." 2013-04-11 07:35:22 +00:00
Jean Chalard
1cbb0b8f2a Add some utility functions. 
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
 2013-04-11 16:16:19 +09:00
Tadashi G. Takaoka
f67a388197 Merge "Add TypefaceUtils" 2013-04-11 05:32:58 +00:00
Tadashi G. Takaoka
08ae0d5ca0 Add TypefaceUtils 
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
 2013-04-11 14:27:42 +09:00
Tadashi G. Takaoka
6d0027a46a Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>" 2013-04-11 05:06:35 +00:00
Jean Chalard
3722f0877e Merge "Fix two bugs in dicttool" 2013-04-11 03:07:30 +00:00
Jean Chalard
ca0fdbbe2e Fix two bugs in dicttool 
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.

Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
 2013-04-10 22:10:31 +09:00
Jean Chalard
fb3e805722 Merge "Fix a bug where a space would not be inserted before a gesture" 2013-04-10 11:19:31 +00:00
Jean Chalard
30b8004b56 Fix a bug where a space would not be inserted before a gesture 
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
 2013-04-10 20:10:28 +09:00
Tadashi G. Takaoka
ce811f50d2 Use private lock object instead of synchronized method 
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
 2013-04-10 18:27:11 +09:00
Jean Chalard
99b93d17d5 Fix a bug where autocorrection status would be wrong. 
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
 2013-04-10 17:49:19 +09:00
Tadashi G. Takaoka
262d5bd9f9 Don't override EXTRA_SHOW_FRAGMENT if exists 
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
 2013-04-10 16:24:17 +09:00
Tadashi G. Takaoka
10af4b6e45 Merge "Separate StringUtils.capitalizeFirstCharacter" 2013-04-10 06:30:33 +00:00
Tadashi G. Takaoka
d20c5a78e2 Separate StringUtils.capitalizeFirstCharacter 
Bug: 8582061
Change-Id: Iac8f65defdd92d7df533bdf0e2937ad897d96363
 2013-04-10 14:55:23 +09:00
Tadashi G. Takaoka
f606fd8554 Hide Setup Wizard icon for stock keyboard 
Bug: 8581647
Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
 2013-04-10 12:24:40 +09:00
Tadashi G. Takaoka
869ea1e555 Use SparseIntArray instead of TreeMap<Integer, Integer> 
Change-Id: I56a64228a5fd85d440d0d08ac67cba8bf2e5690d
 2013-04-10 10:15:26 +09:00
Tadashi G. Takaoka
4fdfce6dcc Merge "Refactor SpellCheckerProximityInfo as extending ProximityInfo" 2013-04-10 01:06:36 +00:00
Jean Chalard
19dcd15493 Merge "Offer to add any OOV typed word to the dictionary." 2013-04-09 10:28:47 +00:00
Jean Chalard
ddafcf82dc Merge "Fix bugs and add tests" 2013-04-09 08:35:28 +00:00
Jean Chalard
9310f42a36 Offer to add any OOV typed word to the dictionary. 
That includes gestures, which used not to work.

Bug: 8532637
Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
 2013-04-09 12:05:54 +09:00
Kurt Partridge
d117c1a116 Merge "Do not record log split time when handling separator" 2013-04-09 02:31:48 +00:00
Ken Wakasa
d17c8bd929 Update comments 
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
 2013-04-08 23:05:45 +09:00
Jean Chalard
c87449497c Fix bugs and add tests 
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
 2013-04-05 12:11:19 +09:00
Jean Chalard
7d3836d63a Move a generic string utility to StringUtils 
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
 2013-04-05 12:09:14 +09:00
Tadashi G. Takaoka
6e3f307266 Refactor SpellCheckerProximityInfo as extending ProximityInfo 
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
 2013-04-02 19:06:32 +09:00
Jean Chalard
ecb59eff90 Revert "[DO NOT MERGE] Activate hardware keyboard handling" 
This reverts commit c741f1f83b
DO NOT MERGE is ignored and this is merged anyway :(

Change-Id: Ie044cdfc6021933379ec97ad7346c5c8591f70bf
 2013-04-02 16:08:48 +09:00
Jean Chalard
c741f1f83b [DO NOT MERGE] Activate hardware keyboard handling 
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
 2013-04-02 15:38:13 +09:00
Kurt Partridge
636b8c4231 Do not record log split time when handling separator 
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken.  However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word.  This change corrects this bug.

Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
 2013-04-01 16:48:15 -07:00
Kurt Partridge
0c0ab2b4d9 Merge "Reorder ResearchLogger call" 2013-04-01 15:19:45 +00:00
Jean Chalard
0745fe83d4 am b8869ec1: am 0fcc4960: Deactivate hardware keyboard handling. 
* commit 'b8869ec1e39c1751825841e790d21fc854dca9ce':
  Deactivate hardware keyboard handling.
 2013-04-01 05:42:42 -07:00
Jean Chalard
0fcc4960bc Deactivate hardware keyboard handling. 
Bug: 8000119

Change-Id: I021481343d6d87efd8ff6110e9aa0906a1a3d11d
 2013-04-01 21:35:45 +09:00
Jean Chalard
43341ba042 Merge "Ask the client to make itself known when it's not" 2013-04-01 09:00:25 +00:00
Jean Chalard
76d5f512f9 Ask the client to make itself known when it's not 
Upon invoking the settings of the dictionary pack with an unknown
client, we now launch an intent to ask the client to make itself known.
This change also includes the code that receives this intent and
acts upon it.

Bug: 8492879
Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
 2013-04-01 17:37:22 +09:00
Jean Chalard
065f126f1d Merge "Fix two nasty bugs with surrogate pairs." 2013-04-01 08:28:08 +00:00
Jean Chalard
a411595b16 Fix two nasty bugs with surrogate pairs. 
The important bug is in findWordInTree. The problem, which is
not obvious, is that we were calling codePointAt() with the
code point index in the string, instead of the char index.
The other bug this change fixes was harmless in the practice,
because it's in the iteration which is only used for debug and
pretty printing purposes. It's very similar in that it would
substract a length in code point to a length in chars and
truncate a StringBuilder at that length, so it would fail in a
quite similar manner. This changes the meaning of the "length"
attribute in Position, but it's clearer this way anyway.

Bug: 8450145
Change-Id: If396f883a9e6449de39351553ba83f5be5bd30f0
 2013-04-01 17:06:19 +09:00
Jean Chalard
740da0d8d0 Fix an NPE 
Also remove an unused method and make 2 private variables
final.

Bug: 8461093
Change-Id: I676d93fda28e82eb5a6978f2e7ad5a0add2cbecf
 2013-03-29 18:41:29 +09:00
Satoshi Kataoka
f463b45d8e Merge "Fix Possible NPE" 2013-03-27 04:51:48 +00:00
Satoshi Kataoka
2cdf5351aa Merge "Fix possible SIOOBE" 2013-03-27 03:28:49 +00:00
Satoshi Kataoka
33306acfa4 Fix possible SIOOBE 
Bug: 8461021

Change-Id: I8b0385610b80b5a672ec380935c485a0e01ae984
 2013-03-27 12:25:02 +09:00
Kurt Partridge
cb25e1fe37 Reorder ResearchLogger call 
Previously, ResearchLogger#onWordFinished() was called with an outdated parameter value for
isBatchMode, causing it to report false even for gestures.  This changes fixes this problem.

Change-Id: Ifcabee236ba5fe20376ad882155d3f3142cd7613
 2013-03-26 14:37:57 -07:00
Kurt Partridge
ef103e1f2e Merge "Close ResearchLogger upon onFinishInputView" 2013-03-26 19:23:00 +00:00
Satoshi Kataoka
435cccb2c5 Fix Possible NPE 
Bug: 8448448
Change-Id: Ibe89c9abd24c4debb33a69c372eadf2afb09ea1c
 2013-03-26 13:02:23 +09:00
Satoshi Kataoka
0b3271010f Merge "Fix possible NPE" 2013-03-26 03:49:06 +00:00
Tadashi G. Takaoka
d17b69ec00 Clean up XmlParserUtils 
Change-Id: I636e8f359d47f39e61a7f77e3e686f2721779b6f
 2013-03-26 12:03:07 +09:00
Kurt Partridge
87bc3a4a62 Close ResearchLogger upon onFinishInputView 
Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden().  This
resulted in multiple logs being written.

Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.

Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
 2013-03-25 17:31:25 -07:00
Satoshi Kataoka
a17dccbfc6 Fix possible NPE 
Bug: 8457109
Change-Id: I321fbef53e20a7c36ef4bd9f544b50abe6a52be9
 2013-03-25 19:00:38 +09:00
Tadashi G. Takaoka
fb658d6c53 Fix possible ArrayIndexOutOfBoundsException 
Bug: 8461864
Change-Id: Icd8f4f51ec064461c08d00c1c58bedf5fbae2553
 2013-03-25 12:37:04 +09:00
Satoshi Kataoka
3c8117c88f Fix appname 
Bug: 6789579
Change-Id: Ic4694e36e0846af95fa8dcdef919be251983b528
 2013-03-22 16:19:44 +09:00
Satoshi Kataoka
242c066dde Use correct appname resource 
Bug: 6789579
Change-Id: Id11435a28d6c5b6c72867814e23f5e62429080f8
 2013-03-22 14:08:38 +09:00
Satoshi Kataoka
a462cd80ae Support feedback 
Bug: 8143554
Change-Id: If0a6bafc94da040f97f27c6d046fb58bed9fd615
 2013-03-19 17:25:55 +09:00
Jean Chalard
8e005f2989 am 1061bfdb: Break dependencies to allow offdevice tests to build 
* commit '1061bfdb34bbcb63bf0046eec42313d264ac33fa':
  Break dependencies to allow offdevice tests to build
 2013-03-19 08:12:50 +00:00
Jean Chalard
6d90a10a34 am 0cc0544a: Merge the dictionary pack in Latin IME. 
* commit '0cc0544a2995c7eb54a830ae54db60af89d4073d':
  Merge the dictionary pack in Latin IME.
 2013-03-19 08:12:49 +00:00
Jean Chalard
1061bfdb34 Break dependencies to allow offdevice tests to build 
Change-Id: Ia9a2e8f0672b3f72943f26fb15de1d3c7c5ce7f1
 2013-03-19 16:45:25 +09:00
Jean Chalard
0cc0544a29 Merge the dictionary pack in Latin IME. 
Bug: 8161354
Change-Id: I17c23f56dd3bc2f27726556bf2c5a9d5520bd172
 2013-03-19 15:40:14 +09:00
Tadashi G. Takaoka
841c295f3c resolved conflicts for merge of 5b048292 to master 
Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
 2013-03-19 10:48:10 +09:00
Ken Wakasa
9c3860ce46 Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS 
bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
 2013-03-18 23:15:47 +09:00
Jean Chalard
f8325ec4bb am 5cb0560b: Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 
* commit '5cb0560b000f37b3fb3937f01b6d3e928afef57a':
  Access the dictionary pack only if have INTERNET permission
 2013-03-18 11:08:52 +00:00
Jean Chalard
5cb0560b00 Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 2013-03-18 11:04:53 +00:00
Jean Chalard
ce487bcf33 Access the dictionary pack only if have INTERNET permission 
Bug: 8161354
Change-Id: I68ee3acb2955a017d25666cc2dad791798f9064a
 2013-03-18 18:40:33 +09:00
Satoshi Kataoka
62ed594c37 am e0e67373: Refactor parameters by naming convention 
* commit 'e0e67373735918c78eaeaf24f127e1d28816aa29':
  Refactor parameters by naming convention
 2013-03-18 06:47:10 +00:00
Satoshi Kataoka
e0e6737373 Refactor parameters by naming convention 
Change-Id: I8bda8075b33f656ecbec08320afcd864b620fe77
 2013-03-18 15:42:15 +09:00
Tadashi G. Takaoka
3268a44e1c am a5067333: Disable the header list of DebugSettingsActivity 
* commit 'a50673330e012f6cca02b83eca1c047b8da319e0':
  Disable the header list of DebugSettingsActivity
 2013-03-15 07:10:00 +00:00
Tadashi G. Takaoka
a50673330e Disable the header list of DebugSettingsActivity 
This change addresses the issue that the debug settings on 10-inch
tablet doesn't show up.

Change-Id: I60540cf21276869a3ca81b7b0154056ce7d93ff1
 2013-03-15 15:33:27 +09:00
Tadashi G. Takaoka
fb606c6277 am f0864b1d: Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 
* commit 'f0864b1d95411ce9886a5ade13f42cb17f578828':
  Clean up StaticInnerHandlerWrapper a bit
 2013-03-14 03:44:00 +00:00
Tadashi G. Takaoka
f0864b1d95 Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 2013-03-14 03:41:01 +00:00
Tadashi G. Takaoka
1ab33383f9 am 0d5f214a: Fix NPE found in monkey test 
* commit '0d5f214aa774ab0ab7c17521984caae11c9f4c2b':
  Fix NPE found in monkey test
 2013-03-14 03:39:38 +00:00
Tadashi G. Takaoka
41e60bf6dd Clean up StaticInnerHandlerWrapper a bit 
Change-Id: Ib07efe6da1eb2f0fd9ef68ca71502c98f7e19f4b
 2013-03-14 12:35:47 +09:00
Tadashi G. Takaoka
0d5f214aa7 Fix NPE found in monkey test 
Bug: 8383127
Change-Id: Ifd70acabe118b477f103937c7f1e99e38e210833
 2013-03-14 12:19:10 +09:00
Tadashi G. Takaoka
f5caf5be99 am 601a8582: Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 
* commit '601a8582d0f761a85b6eb16e7a6b78402f6f2599':
  Move checking non-persistent checkbox to onResume
 2013-03-14 02:33:28 +00:00
Satoshi Kataoka
0b2512017e am 0ab44b21: Merge "Make isInternal mutable" into jb-mr2-dev 
* commit '0ab44b21bd6ef5e9fde329b25dfd84f6ca5c0825':
  Make isInternal mutable
 2013-03-13 17:24:49 +00:00
Jean Chalard
8067b769f1 Merge "[DO NOT MERGE] Deactivate H/W keyboard handling" into jb-mr2-dev 2013-03-13 10:55:04 +00:00
Tadashi G. Takaoka
601a8582d0 Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 2013-03-13 07:52:35 +00:00
Satoshi Kataoka
0ab44b21bd Merge "Make isInternal mutable" into jb-mr2-dev 2013-03-13 07:41:11 +00:00
Satoshi Kataoka
756791e6bf Make isInternal mutable 
Change-Id: Ib81ceba801be0ac7ef65c4eadd1ec8599e80dacc
 2013-03-13 16:28:50 +09:00
Tadashi G. Takaoka
24cea7f1fb Move checking non-persistent checkbox to onResume 
Bug: 8336068
Change-Id: I07e67a6aee24a239a21e6fc69eb2ec741b9a5b2b
 2013-03-13 15:54:33 +09:00
Jean Chalard
92eaa6fc7c [DO NOT MERGE] Deactivate H/W keyboard handling 
For MR2, LatinIME should not be handling hardware keyboard
events. The feature is still work in progress.

Change-Id: I56ff18bff84ba6b5a6bc3f8829b42eaf33b72554
 2013-03-12 14:22:06 +09:00
Svetoslav Ganov
2d9b7f60dd am af37cbb4: Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev 
* commit 'af37cbb44ef40fcd15fa02456c9abda8021847ce':
  Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
 2013-03-08 19:24:25 +00:00
Alan Viverette
c2ee72a214 Announce keyboard mode changes as a WINDOW_STATE_CHANGED event. 
Bug: 8165295
Change-Id: Ie416f6cdb68377f3e06f30e9b6363c38ba2a602d
 2013-03-07 10:39:55 -08:00
Kurt Partridge
dc89d76f6b Merge "Make some methods visible for testing" 2013-03-06 03:43:55 +00:00
Kurt Partridge
25343124dd Make some methods visible for testing 
bug: 8302967

multi-project commit with Icf915abb57ef00840ee93b67a25db42ba51f1c38

Change-Id: I105bda5bdff871508140fb99487dddbf17992790
 2013-03-05 19:28:31 -08:00
Tadashi G. Takaoka
249c887008 am 84fa8043: Merge "Add show setup wizard icon preference settings" into jb-mr2-dev 
* commit '84fa8043e6bef47378b3fc32c277e33034d5c174':
  Add show setup wizard icon preference settings
 2013-03-05 06:30:33 +00:00
Tadashi G. Takaoka
2e1b55f796 Add show setup wizard icon preference settings 
Bug: 8239067
Change-Id: If6106a3632d3abad3e22ce29f1351525a5152ec7
 2013-03-05 14:56:41 +09:00
Kurt Partridge
75e6fb68e9 Clean up PREF_USABILITY_STUDY_MODE 
- Refer to a common default value in DebugSettings
- Make PREF_USABILITY_STUDY_MODE independent of the ResearchLogger
- ResearchLogger uses its own preference through ResearchSettings

multi-project commit with Ie0df836c9d779eba484b522666ec357f4e234823

Change-Id: I88547a2f619db6e7364abbbec12f9f76855dd11a
 2013-03-04 12:05:03 -08:00
Kurt Partridge
b094372bd6 Remove MainLogBuffer#setSuggest() 
multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624

Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
 2013-03-01 13:32:11 -08:00
Tadashi G. Takaoka
578e71e28b am 99b0dc6f: Merge "Add setup wizard launcher icon" into jb-mr2-dev 
* commit '99b0dc6f0d18f5fdd8634e8fa533bf1b3f81a538':
  Add setup wizard launcher icon
 2013-03-01 16:13:45 +00:00
Tadashi G. Takaoka
99b0dc6f0d Merge "Add setup wizard launcher icon" into jb-mr2-dev 2013-03-01 16:08:09 +00:00
Tadashi G. Takaoka
1ffdaafd83 Add setup wizard launcher icon 
The setup wizard icon will be hidden if the Android Keyboard is in
system image.

Bug: 8239067
Change-Id: Ib0c0c9e3a0954512c3e03e42a661cdf86eff0dca
 2013-03-01 22:28:00 +09:00
Jean Chalard
31747ba787 am abaf5827: Separate suggestions from SuggestionView 
* commit 'abaf5827e7a7f5f6c5d8d98e03e6b9528b0c9351':
  Separate suggestions from SuggestionView
 2013-03-01 05:17:52 +00:00
Jean Chalard
abaf5827e7 Separate suggestions from SuggestionView 
This is a cleanup change, but it's also necessary for

Bug: 8152758
Change-Id: Id6ba06243f573fdb856f87d1df03277c9f2e5e71
 2013-02-28 21:03:18 -08:00
Kurt Partridge
424a976e58 Merge "Ensure Preference listener is unregistered" 2013-02-27 03:49:40 +00:00
Kurt Partridge
7e2c1e69bf Ensure Preference listener is unregistered 
Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
 2013-02-26 18:40:34 -08:00
Tadashi G. Takaoka
183fe80031 Small cleanup of RunInLocale 
Change-Id: Ib588e67da2c88345fc4eb51587b07ebfa434e0bb
 2013-02-26 19:11:49 +09:00
Jean Chalard
0f3c05cd6b Merge "Send the dictionaries descriptions to the dict pack" 2013-02-23 10:18:03 +00:00
Jean Chalard
c6799ffeab Send the dictionaries descriptions to the dict pack 
Bug: 8255795
Change-Id: I12a5922f50c2d2e3aa639457abcc1483e6a48721
 2013-02-23 01:46:39 -08:00
Jean Chalard
76ead0ead0 Fix a possible crash 
If the dictionary ID, as indicated in the metadata, is
less than three chars long, it crashes LatinIME.
Of course we don't have such dictionary IDs in the current
metadata, but it's still better to be able to handle
the case gracefully ^^;

Change-Id: I60cdf6f8ecce9f4d44b42ddd5d157aebff9a4163
 2013-02-23 01:41:44 -08:00
Jean Chalard
aefaec3c5f Remove a cluttering log 
Bug: 8175067
Change-Id: I9a104a32ba2b3b52a5dfa250f8c642abd6169cc0
 2013-02-23 00:48:10 -08:00
Jean Chalard
8b4023c4d6 Merge "Tiny cleanup" 2013-02-23 08:07:27 +00:00
Jean Chalard
2521edec09 Fix a bug with the passed dictionary id 
We used to make the dictionary that we passed to the
dictionary pack as an initial value based on the locale.
This is wrong - it should be read from the dictionary.
This change fixes that.

Bug: 7005813
Change-Id: Ib08ed31dd9c216f6f7b9c6c3174ca514bf96e06f
 2013-02-22 20:49:48 -08:00
Jean Chalard
da0d771fe9 Tiny cleanup 
Change-Id: I5d7150a4abb3a498e790f41af569093217cb8b43
 2013-02-22 19:42:45 -08:00
Jean Chalard
4e4f88127b Fix how the Enter action is decided 
This unifies the software and hardware keyboard code
under a single decision process that works.

Bug: 8129303
Bug: 8152758
Change-Id: I7574c563d5f957d57bfe62fe5e3eec59a519d335
 2013-02-22 16:01:37 -08:00
Tadashi G. Takaoka
07296cf7ff Merge "Use WordComposer.addKeyInfo for testing" 2013-02-21 06:20:01 +00:00
Tadashi G. Takaoka
46878544ec Add preliminary setup wizard 
Bug: 8159728
Change-Id: I30d9cd637fb1d2e64588550e0aa4387bc1f7e6e5
 2013-02-21 09:54:02 +09:00
Tadashi G. Takaoka
5701a6647f Use WordComposer.addKeyInfo for testing 
Change-Id: I500654e7a26717aa5547942357e56060afb72969
 2013-02-20 17:09:25 +09:00
Jean Chalard
d4cbc4fd07 Implement getting data files with protocol v2 
This also does it for deleting them
Bug: 8167342
Bug: 6789534
Change-Id: I1823f98508881f109a667146d3608003f87aa4cb
 2013-02-15 11:09:16 -08:00
Jean Chalard
4beaab2a88 Merge "Determine the protocol version of the dictionary pack" 2013-02-14 20:22:09 +00:00
Tadashi G. Takaoka
cb0beaf3f1 Add placeholder of keyboard setup wizard 
Bug: 8159728
Change-Id: I5552e9d0ffa8f94d183e76378d55bba6f718adfe
 2013-02-14 18:00:11 +09:00
Jean Chalard
b1f27a2e26 Determine the protocol version of the dictionary pack 
...for query.

Bug: 8167342
Change-Id: Ieb8e5b31c4b62bf507593c4631e31799aad5f267
 2013-02-13 20:45:36 -08:00
Jean Chalard
a9df972780 Clean up dictionary pack presence test. 
This method is much cleaner and much more readable.

Change-Id: I8055c169ef7c4453ab45c463704bd56a6080da4f
 2013-02-12 17:59:36 -08:00
Tadashi G. Takaoka
fdb1ca560e Merge "Separate caps mode related utils to CapsModeUtils" 2013-02-12 09:26:16 +00:00
Tadashi G. Takaoka
ce6bcdd1a5 Separate caps mode related utils to CapsModeUtils 
Change-Id: I32700c434b296bb3fd39e040c2dda1fe90667daf
 2013-02-12 18:15:42 +09:00
Tadashi G. Takaoka
2c2942dd4b Merge "Move parseCsvString to StringUtils" 2013-02-12 07:57:24 +00:00
Tadashi G. Takaoka
b3fd701181 Move parseCsvString to StringUtils 
Change-Id: I602f33991ca57b6057ec2defe01573552b322857
 2013-02-12 16:18:19 +09:00
Jean Chalard
1c5b2a41ec Cleanups 
Follow-up to Idc6f419a

Change-Id: I4aae8f4e19f27a0a309879dc19af6e40906d58c5
 2013-02-11 21:14:56 -08:00
Jean Chalard
8018051022 Some cleanups 
Improve a slew of logging statements, and put commands that we don't
expect to need protecting against exceptions out of a try {} block.

This is a followup to Id3dc510a

Change-Id: Idc6f419ac095b5b0f2d6862d58926ef888cb34e6
 2013-02-11 19:47:15 -08:00
Jean Chalard
82441e60e2 Remove unnecessary whitespace 
This is a cleanup followup to Id3dc510a

Change-Id: Ie64395eb4b6218fd8c73cacddeed2fba1df65d26
 2013-02-11 13:31:47 -08:00
Jean Chalard
b2eac474ff Don't try to issue delete() commands on missing provider 
Bug: 8173622
Change-Id: Id3dc510ae3535169b5290e87075cb2f433a1f603
 2013-02-11 12:38:24 -08:00
Jean Chalard
3623ad238c [B14] Implement sending the dictionary list. 
Bug: 7005813
Change-Id: Ic3ef69510d2b385d0d403191b2f701b6527d0166
 2013-02-06 19:19:30 -08:00
Jean Chalard
6ecb4c4dcc [B11] Implement reset and passing of the URL to the dict pack 
Bug: 7601410
Bug: 7595195
Change-Id: I78cf04dce7c1e64de6725d32317de288a83bd39d
 2013-02-06 15:21:33 -08:00
Jean Chalard
afe889a83d Merge "[B9] Pass the client id parameter for dict info requests" 2013-02-06 04:38:44 +00:00
Tadashi G. Takaoka
298b4240f8 Separate IntentUtils from CompatUtils 
Change-Id: I373ae7ad26eee44cc8e9720314f6a53b811d0021
 2013-02-04 16:06:38 -08:00
Jean Chalard
8192b4a6ef [B9] Pass the client id parameter for dict info requests 
Bug: 6789534
Change-Id: Ie3ea75b19ae4da2dea531e0077c58742a9502bc6
 2013-02-02 18:23:40 +09:00
Jean Chalard
f1acb0e52d Make some strings private 
Change-Id: I0ffdbcf6bede86a3cdcb3a0e4ec263398502617c
 2013-02-02 15:00:09 +09:00
Jean Chalard
5ea4365f07 Merge "Create methods in LatinIME to make the current dict lists" 2013-01-31 16:59:11 +00:00
Jean Chalard
af4a7e8c4b Create methods in LatinIME to make the current dict lists 
Bug: 7005813
Change-Id: I82232af8e3071333b6fd01e4453b6b3c0a3ddb1f
 2013-01-31 09:26:52 +09:00
Jean Chalard
3c67f6a2d0 Merge "Add a way to know externally if we're installing a new dict" 2013-01-31 00:19:23 +00:00
Jean Chalard
01a4ebcd88 Add a way to know externally if we're installing a new dict 
That helps tests know when to wait and when to declare the
dictionary actually not usable.

Bug: 7925814
Change-Id: Ic963c1206c43e3cde39ac4214a0d601f4fc6c03b
 2013-01-31 09:04:55 +09:00
Kurt Partridge
f3731188e5 [Rlog27] Add replay capability 
- Add support for replaying log files to the ResearchLogger.  This will let
  users preview data that they choose to upload.
- When the user explicitly requests that the system record their action, it
  will record everything up to, and including, the motion involved in shutting
  off the recording.  This change also removes the stop-recording motion
  commands.

Change-Id: Ib1df383bbf1881512cb111fab9f6749c25e436ba
 2013-01-29 09:33:25 -08:00
Jean Chalard
d515f134f7 Refactoring 
This creates a new DictionaryInfoUtils class and moves a bunch
of static methods there for later usage.

Change-Id: Iecb0643e6029a7be36bd6cb36aa918c40e6d8c6a
 2013-01-29 19:16:21 +09:00
Tadashi G. Takaoka
8630cd9d17 Remove keyboard layout description on the spacebar 
Bug: 8056376
Change-Id: I33f07e7a044c2b5fc20de40c7a9777dab493e41c
 2013-01-28 11:49:44 +09:00
Kurt Partridge
f77e9d7e3a Merge "Initialize ResearchLogger later to avoid NPE" 2013-01-25 17:17:34 +00:00
Jean Chalard
5228745ae0 Merge "Remove pending update messages upon starting a gesture" 2013-01-25 12:34:46 +00:00
Jean Chalard
a280e56014 Remove pending update messages upon starting a gesture 
Bug: 8064307
Change-Id: Ia623ab81b6d12eedc6b20bc4c1ce34ce72d5832f
 2013-01-25 17:00:41 +09:00
Tadashi G. Takaoka
ce875664e0 Clean up Settings and SettingsFragment a bit 
Change-Id: I93bf3cb1ea7e8fc09f4ad34b0bdd74f5f5ff1a68
 2013-01-25 16:23:29 +09:00
Kurt Partridge
63bc279596 Initialize ResearchLogger later to avoid NPE 
Change-Id: I1b817dfbdc319ac9bbf2f08e094a007849ce767f
 2013-01-24 11:13:20 -08:00
Tadashi G. Takaoka
52a0d491b4 Merge "Add preliminary graphics of sliding key input preview" 2013-01-24 09:23:28 +00:00
Tadashi G. Takaoka
ff961ddf8c Add preliminary graphics of sliding key input preview 
Bug: 7548583
Change-Id: Idde6a62f9e64458055c99c893b71c02d1adc7b04
 2013-01-24 18:14:20 +09:00
Tadashi G. Takaoka
12f2fc71f7 Merge "Display custom input style name in system locale" 2013-01-24 08:53:46 +00:00
Tadashi G. Takaoka
8203f7afe7 Display custom input style name in system locale 
Bug: 8032166
Change-Id: Ib9a6b63c4d540ce377892fb865e53abdd8adec16
 2013-01-24 17:44:49 +09:00
Tadashi G. Takaoka
f0b5fddcb8 Clean up SettingsFragment a bit 
Change-Id: Ic0727003f2645f0c38200b67bb2f4046249c6273
 2013-01-24 16:16:53 +09:00
Kurt Partridge
edb5c4638b Merge "[Rlog81a] Determine correction type of words" 2013-01-23 17:12:02 +00:00
Tadashi G. Takaoka
9d514af466 Merge "Refactor SubtypeLocale to hold Resources" 2013-01-23 08:37:57 +00:00
Tadashi G. Takaoka
9dc85a673e Merge "Configurable key long press timeout" 2013-01-23 08:37:36 +00:00
Tadashi G. Takaoka
cc5e4a4445 Configurable key long press timeout 
The default long presss timeout is 300msec (previous timeout was
400ms).

Bug: 7600340
Change-Id: Ia8b64784ac03588631cfcbad30e021d74f3fd0d8
 2013-01-23 17:12:28 +09:00
Satoshi Kataoka
f1074c508e Throw exception when invalid time stamps are detected in debug mode 
Change-Id: I360b5bd09869bc85ab3bccb8a43a20fed0035d9b
 2013-01-23 16:29:19 +09:00
Tadashi G. Takaoka
4b3cae9b0c Refactor SubtypeLocale to hold Resources 
Change-Id: Ia667bc2d406d66c87215dd3b9569f36f4642cfe0
 2013-01-23 16:23:11 +09:00
Tadashi G. Takaoka
40651c8cf7 Fix activity flags to launch settings activity 
This change adds the following flags to the intent to lauch settings activity.
 - Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED
 - Intent.FLAG_ACTIVITY_CLEAR_TOP

Bug: 8055342
Change-Id: I85284409bbba3fd284442e5ac4c7a55e58ad15ec
 2013-01-23 15:08:35 +09:00
Kurt Partridge
0c16a5c6ee [Rlog81a] Determine correction type of words 
Heuristic to determine whether a word was a typo correction or a complete
replacement by examining a correction to see if it falls within the list of
suggested words of the original.

Change-Id: Ieec4861a811e96aef0d14622e662b589ef8b4772
 2013-01-22 11:41:52 -08:00
Tadashi G. Takaoka
f008a11cce Merge "Cache MoreKeysKeyboard instead of container view of it" 2013-01-22 08:45:52 +00:00
Tadashi G. Takaoka
a729377395 Cache MoreKeysKeyboard instead of container view of it 
This change also cleans up MoreKeysPanel related stuff.

Bug: 8047165
Change-Id: I4f2211e00c7d08469a7413568db039c1c597fb3c
 2013-01-22 17:34:36 +09:00
Tadashi G. Takaoka
8028c1c523 Merge "SeekBarDialogPreference supports minValue and stepValue" 2013-01-22 07:40:48 +00:00
Tadashi G. Takaoka
c053293484 SeekBarDialogPreference supports minValue and stepValue 
Change-Id: I7aaeeb2db85103708747ae318610bd4896ef96fd
 2013-01-22 16:35:59 +09:00
Ken Wakasa
6c22439bf8 Remove MAX_PROXIMITY_CHARS_SIZE_INTERNAL 
Change-Id: I18a997503de4033b5341b564145bca862a872098
 2013-01-22 13:18:49 +09:00
Kurt Partridge
08d9c996dc Merge "[Rlog81b] Log more data with handleSeparator" 2013-01-21 18:48:16 +00:00
Tadashi G. Takaoka
8aa9963a89 Fix Apache license comment 
Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
 2013-01-21 22:23:37 +09:00
Jean Chalard
b56260b891 [AD4] Actually copy the file in place. 
This finally makes it work.

Bug: 7702011

Change-Id: I3508c88567f79598e4d1dff561b6ba7dc5c3808f
 2013-01-21 17:58:38 +09:00
Jean Chalard
bde94dd96f Merge "[AD3] Implement the interface to choose a local dictionary" 2013-01-21 07:41:48 +00:00
Tadashi G. Takaoka
375982106b Move PointerTracker.DrawingProxy to MainKeyboardView (step 2) 
Change-Id: If15d5ee683b8026d1871a3fe438dba498944faa7
 2013-01-21 16:09:25 +09:00
Jean Chalard
fbc5e9b334 [AD3] Implement the interface to choose a local dictionary 
Bug: 7702011
Change-Id: Id3b9c58dbbf5097e4d6ce986d20924eae19f9690
 2013-01-21 15:40:46 +09:00
Tadashi G. Takaoka
d9449ccf3c Move MoreKeysPanel.Controller implementation to MainKeyboardView 
Change-Id: Iffa298d51ca21a7dcd1e77c633217532d96d2cf5
 2013-01-21 15:28:17 +09:00
Kurt Partridge
80375649d3 [Rlog81b] Log more data with handleSeparator 
Change-Id: I4b2ebaa2398ac2f669e1e009e00842e55979e866
 2013-01-18 11:51:26 -08:00
Jean Chalard
1d15fe7e51 [AD2] Add a helper method to read an arbitrary dict header 
Bug: 7702011
Change-Id: Ib88f6dc222892831ae6932635b65fd2595b16b43
 2013-01-18 20:34:28 +09:00
Jean Chalard
babc71ee30 Merge "[AD1] Add an option to read an arbitrary dictionary." 2013-01-18 11:30:28 +00:00
Jean Chalard
9058bc0df4 [AD1] Add an option to read an arbitrary dictionary. 
Bug: 7702011
Change-Id: I76f52dd3fdb22824fc243ab3845ceec610469c81
 2013-01-18 20:18:06 +09:00
Jean Chalard
2fc4d422e7 Deactivate h/w keyboard when not an internal build. 
The implementation is not really ready yet, so we want to
disable it for normal builds for now.
This goes together with Ic1edc6ed

Bug: 7987492
Change-Id: Id81f417e200c118f24424943823665f0b8bd6849
 2013-01-18 20:15:18 +09:00
Jean Chalard
d5e869ced8 Merge "Track handled events to consistently return handled status (C1)" 2013-01-18 10:49:54 +00:00
Jean Chalard
976a42b873 Track handled events to consistently return handled status (C1) 
Bug: 5037589
Change-Id: I92d5be669420f0b2fdeb8fcf85aefd3961bf84b4
 2013-01-18 19:32:22 +09:00
Tadashi G. Takaoka
f420e506a0 Merge "Add SeekBarDialogPreference" 2013-01-18 10:25:13 +00:00
Tadashi G. Takaoka
2df0cf2c5a Add SeekBarDialogPreference 
This change removes SeekBarDialog class.

Change-Id: I437b1e554a5af264b8031ebe05b8250a831c8d3b
 2013-01-18 19:10:55 +09:00
Jean Chalard
81a4b7f48e Merge "Fix a bug in gesture after a dash or apostrophe" 2013-01-18 08:39:58 +00:00
Jean Chalard
889a5e1430 Merge "Reset forgotten members (D3)" 2013-01-18 07:46:41 +00:00
Jean Chalard
e3ec5fcc88 Fix a bug in gesture after a dash or apostrophe 
It would insert a space when it shouldn't when composing a
word ending in either dash or apostrophe and gesturing right
away.

Bug: 7889078
Change-Id: Ib3e2f6f5e551888cc081b464a641e2deac6f5ef7
 2013-01-18 15:05:34 +09:00
Jean Chalard
5a6b4f953e Merge "Insert into user dict in lower case if auto-caps (D2)" 2013-01-18 05:39:18 +00:00
Kurt Partridge
e6a9655a03 Merge "Consolidate SuggestedWords.getWordInfo and .getInfo" 2013-01-17 22:01:26 +00:00
Kurt Partridge
b5ac8ef586 Consolidate SuggestedWords.getWordInfo and .getInfo 
Change-Id: I959cf049f550b7be3ec002281ca7457e566b0214
 2013-01-17 07:50:15 -08:00
Jean Chalard
8914555776 Reset forgotten members (D3) 
Only resetting mCapitalizedMode is enough to fix bug#8013488,
but we may as well correctly reset both fields.

Bug: 8013488
Change-Id: Icb0d7c5b1e93368e8eb7848aa9137b45d5d3531e
 2013-01-17 20:39:09 +09:00
Jean Chalard
96845ecff6 Insert into user dict in lower case if auto-caps (D2) 
Also recapitalize afterwards if the word has been changed.

Bug: 7972124
Change-Id: I9306580bb4ed0ffa80cc4559ce1abcd2034d1905
 2013-01-17 20:38:52 +09:00
Jean Chalard
c665cbee7f Merge "Forward the capitalized mode to the positional info (D1)" 2013-01-17 11:02:00 +00:00
Jean Chalard
15ea1d4096 Merge "Simplify the space-before and space-after logic." 2013-01-17 09:07:20 +00:00
Jean Chalard
ae3b96b26e Simplify the space-before and space-after logic. 
Bug: 7889078
Bug: 7268000
Change-Id: I6c77b8c9e60ef69f02526b407124d2f5d02818ee
 2013-01-17 17:52:46 +09:00
Tadashi G. Takaoka
40c59727cf Merge "Add default button to vibration/volume settings dialog" 2013-01-17 08:41:01 +00:00
Tadashi G. Takaoka
1b1fa7a18b Merge "SeekBarDialog supports neutral and dismiss listener" 2013-01-17 08:27:27 +00:00
Jean Chalard
b6b7f5e39e Forward the capitalized mode to the positional info (D1) 
Bug: 7972124
Change-Id: I3c74f3b075e698b9e9dd1d2c7b6f173073539063
 2013-01-17 14:35:58 +09:00
Jean Chalard
d818f1e3b6 Stop relying on the soft keyboard to get the editor action. 
Bug: 7969231
Change-Id: I9848c63c4c51550b5dc53c981eafa74e7fa95197
 2013-01-16 18:22:00 +09:00
Kurt Partridge
9579936bcf [Rlog67] Renaming clarification 
ResearchLogger.latinIME_handleSeparator wasn't doing anything really specific to
the separator, so its implementation has been renamed according to its role.

Change-Id: I24e8691c7dc440dd067e96d23e50463683e17cfc
 2013-01-15 08:57:52 -08:00
Jean Chalard
dcfceaff1b Distinguish action-enter/shift-enter/enter 
Bug: 7969231
Change-Id: I75d495ee1ea126da9be4e269ee990ee0a97793c1
 2013-01-15 19:12:41 +09:00
Ken Wakasa
5db594abba Remove MAX_WORD_LENGTH_INTERNAL 
Change-Id: Ie11ff000675601acff5fbb00e9e9f48eb32c5071
 2013-01-15 12:39:08 +09:00
Kurt Partridge
5b611e184b Merge "[Rlog63] Log whether a manual suggestion is a prediction" 2013-01-14 09:30:12 -08:00
Kurt Partridge
939e3f3152 Merge "[Rlog59d] Pass separatorString through revertCommit" 2013-01-14 08:59:04 -08:00
Kurt Partridge
31156c816e [Rlog59d] Pass separatorString through revertCommit 
Change-Id: I5ef20476318979f99f543f9300cf6198d18f6244
 2013-01-14 07:01:49 -08:00
Kurt Partridge
ef3936bc54 [Rlog59c] More detailed logging of backspace 
- Normal delete events are recorded
- Includes number of characters deleted for both batch and normal delete

Change-Id: I422da3ddc94fa0ccd6c7586eaacf14c62dd16679
 2013-01-12 12:54:59 -08:00
Kurt Partridge
343a852cd9 Merge "[Rlog59b] Log CodeInput and KeyCode properly" 2013-01-12 10:18:57 -08:00
Kurt Partridge
3338703a2f [Rlog63] Log whether a manual suggestion is a prediction 
Change-Id: Ia6f793611d4b18aecb1a635655af5edb639e1ecf
 2013-01-11 09:55:09 -08:00
Kurt Partridge
5523a6818d Merge "[Rlog59a] Split logUnits correctly around separators" 2013-01-11 09:18:10 -08:00
Ken Wakasa
f6870cc82d Remove BinaryDictionary.MAX_PREDICTION and MAX_SPACES, and rename MAX_WORDS to MAX_RESULTS 
Change-Id: Iab2a422b367e7521f346481c7fe5e2575f2e9de3
 2013-01-11 20:47:42 +09:00
Kurt Partridge
99931201d0 [Rlog59b] Log CodeInput and KeyCode properly 
- Fix function calls to happen at more resilient times
- In the case of phantom spaces, ensure that the logStatement goes to the
  correct logUnit

Change-Id: Ida8f6eba1e4f33d9f9b4735316e3c6316ed316c0
 2013-01-10 23:39:11 -08:00
Jean Chalard
d8590857bd Fix spell checker subtype list. 
Remove the subtypes that don't get a dictionary any more in AOSP.
Also prepare for all downloadable-dictionary supported subtypes.

Bug: 7673670
Change-Id: I5b754a791233c270237b8f7e5e2208f7282ad294
 2013-01-11 14:59:34 +09:00
Kurt Partridge
90aaa2d0a5 [Rlog59a] Split logUnits correctly around separators 
Change-Id: I65ecdead7e7bdeb8a5f1748e27068ddbd5d3ce00
 2013-01-10 16:36:18 -08:00
Kurt Partridge
75e69753b7 [Rlog57b] fix logging of reverts 
Change-Id: I07c817061a0cc060197e0fea45195ca07a9bf276
 2013-01-10 15:00:28 -08:00
satok
2ef0d3bf8d Merge "fix possible NPE in DebugSettings" 2013-01-10 03:00:24 -08:00
satok
e8b4fd2644 fix possible NPE in DebugSettings 
Change-Id: I44ec5bd3b2a00087603316f14d732164dbcf399f
 2013-01-10 19:57:33 +09:00
Jean Chalard
d9c7a6b9b3 Merge "Move a method to a utility class (C1)" 2013-01-10 00:04:11 -08:00
Jean Chalard
9c75ad1ade Merge "Fix international tests" 2013-01-10 00:03:05 -08:00
Tadashi G. Takaoka
a80b8fc98f Merge "Show final suggested word when batch input is finished" 2013-01-09 23:35:09 -08:00
Tadashi G. Takaoka
50d902ac6f Show final suggested word when batch input is finished 
This change moves dismiss timer of gesture floating preview text from
PreviewPlacerView to KeyboardView.

Bug: 7967461
Change-Id: I0ca5beddc93cb4bc4a405f914d217d37b997402b
 2013-01-10 16:25:05 +09:00
Tadashi G. Takaoka
433f54ce90 Merge "Remove unused variables" 2013-01-09 22:32:23 -08:00
Jean Chalard
912ad4614f Fix international tests 
Tests have been broken again by recent changes to subtype
choice within Latin IME. This fixes the problem and all tests
pass again.

This change also includes a small fix to one test that was
checking for something irrelevant.

Change-Id: I6a03dea24f99b0d2ad84c4161a8413f3060bb811
 2013-01-10 15:12:17 +09:00
Tadashi G. Takaoka
a7a7f4e002 Add default button to vibration/volume settings dialog 
Change-Id: I7beb4517314efdefeb47d91b14a6b02c3075c19f
 2013-01-10 15:11:30 +09:00
Tadashi G. Takaoka
88df3d9239 SeekBarDialog supports neutral and dismiss listener 
Change-Id: I652fd1a383ef4074c04d03a37ebc779d229474e6
 2013-01-10 14:24:54 +09:00
Kurt Partridge
f11c4a9aeb Merge "[Rlog50] capture bigrams properly even with deletions" 2013-01-09 19:52:45 -08:00
Tadashi G. Takaoka
1aa547d94a Remove unused variables 
Change-Id: I508679c2ad21b2624760d37a9503e21733964d4c
 2013-01-10 12:34:35 +09:00
Tadashi G. Takaoka
3727a3fd61 Merge "Clean up public helper methods of SettingsValues" 2013-01-09 19:04:46 -08:00
Kurt Partridge
3b95eaf70b [Rlog50] capture bigrams properly even with deletions 
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0

Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
 2013-01-09 16:02:37 -08:00
Jean Chalard
8da9c337db Move a method to a utility class (C1) 
This is a preparatory change to fix bug 7969231

Change-Id: I44604ae75192a17b4e75a01f3e3d679d4901299e
 2013-01-09 21:59:06 +09:00
Jean Chalard
516b63db28 Fix a race condition with backspaces 
And add a test to make sure it stays not-broken.

Bug: 7946604
Change-Id: I996da3d5507d591ec25a13fb57434f39843f1df5
 2013-01-09 18:37:10 +09:00
Tadashi G. Takaoka
d3b0ecec22 Clean up public helper methods of SettingsValues 
Change-Id: I6c6087580b67f497eaaf16900f8df7a4a895b8e3
 2013-01-09 11:23:34 +09:00
Tadashi G. Takaoka
8315e8168b Merge "Clean up debug related preference keys" 2013-01-08 16:56:13 -08:00
Kurt Partridge
9bad176ebe Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly" 2013-01-08 08:10:31 -08:00
Kurt Partridge
b7fb16e8cc Merge "[Rlog27] Refactor LogBuffer" 2013-01-08 07:40:57 -08:00
Tadashi G. Takaoka
a5ff9f0c77 Clean up debug related preference keys 
Change-Id: Ib7129692c673b3bce253120ee709e0253aeafa52
 2013-01-08 18:26:47 +09:00
Tadashi G. Takaoka
ff0735ada8 Make Settings class singleton to manage SettingsValues 
Change-Id: Id30828a141de86d9bcf8bce586d2adb468cc59e1
 2013-01-08 17:48:47 +09:00
Tadashi G. Takaoka
8873b5ae31 Merge "Rename Settings to SettingsFragment" 2013-01-07 23:00:59 -08:00
Tadashi G. Takaoka
4b852d6044 Merge "Consolidate VibratorUtils with AudioAndHapticFeedbackManager" 2013-01-07 23:00:04 -08:00
Tadashi G. Takaoka
cbee8a33d5 Rename Settings to SettingsFragment 
Change-Id: If5bc53efc67be507663091de0f569f604c03e719
 2013-01-08 15:59:16 +09:00
Tadashi G. Takaoka
b17b887425 Consolidate VibratorUtils with AudioAndHapticFeedbackManager 
Change-Id: Ica4e3193f369330da62a259c718b779ddf9fbde5
 2013-01-08 15:13:19 +09:00
Jean Chalard
c79493a15f Adjust the used frequency of the user dictionary words. 
Bug: 7656666
Change-Id: I4b271af636f6103cb5287336229581365841d778
 2013-01-08 14:57:20 +09:00
Kurt Partridge
99f3189645 [Rlog32] ResearchLogger segment motion data around gestures correctly 
multi-project commit with I684ba5fed8c653777942e6b0366113ca40dfa37c

Change-Id: Id3804e6cfa97b4cdde212b8eebc413f76fa4772c
 2013-01-07 20:06:29 -08:00
Xiaojun Bi
28de7223e6 Merge "[mdfp] Refactoring Gesture Floating Preview Text Code" 2013-01-07 17:12:35 -08:00
Xiaojun Bi
d52730a2d7 [mdfp] Refactoring Gesture Floating Preview Text Code 
This change moves gesture preview text code from PreviewPlacerView.java
to separate classes.

Change-Id: Id8d17eff38e714c3b06aafd0b24985a9bd2d2f52
 2013-01-07 10:39:23 -08:00
Tadashi G. Takaoka
f90fc105ab Simplify singleton class initialization 
Change-Id: I16a27f2ed6ea66184bfdc9903180372cd7ea2fd1
 2013-01-07 19:05:31 +09:00
Ken Wakasa
b6ca354431 Small code cleanups 
Multi-project commit with I249d5fbe

Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
 2013-01-07 12:13:42 +09:00
Jean Chalard
f677681330 Fix double input of chars typed on a h/w keyboard 
Bug: 7939324
Change-Id: I11b7af54893cb645f8a06266a0b0ba95dd0b02f9
 2013-01-07 10:03:20 +09:00
Kurt Partridge
f77dd424b0 [Rlog27] Refactor LogBuffer 
Cleanup and prepare for replaying

Change-Id: Ie09e912c6e9c0d7375168c575ccf1cfd9375dd31
 2013-01-03 16:36:32 -08:00
Tadashi G. Takaoka
fa7f08b373 Set default audio and haptic feedback settings 
- Default keypress volume is set to 0.2f in resource.
- Default keypress vibration duration is set to 10 msec in resource.

Bug: 7055329
Change-Id: I83bd6288d171d9787d52e2b02e4e5305f1435681
 2012-12-28 19:24:32 +09:00
Tadashi G. Takaoka
a2982dd5a7 Refactor to add SeekBarDialog 
Change-Id: Id8e08a1d5ec5efb2baf96a2634111619fcb9fd4e
 2012-12-28 15:49:36 +09:00
Jean Chalard
864db4b0da A small simplification. 
It's useless to setAutoCorrection(getTypedWord()). Every time the
contents of the word composer are altered, the auto-correction is
reset, and at use time if it's null then the typed word is used
anyway.

Change-Id: I0870657a1ab3f456f376995b27e70703f7a5d23a
 2012-12-28 14:41:28 +09:00
Jean Chalard
997cba7dec Start committing hardware events (B4) 
Essentially this does activate auto-correction with a hardware
keyboard, although a lot of things are still left to implement.
No proximity is used yet which means only missing and excessive
letters are considered. Dead keys are not handled. No combiner
is supported. No suggestions are displayed. Resuming suggestions
does not work correctly with a hardware key (because the view
holds a temporary hardware event 'onKeyPreIme' and the event
from the IME won't be handled until this is handled which won't
happen until after the IME said that it did handle the event).

Bug: 5037589
Change-Id: Idcb5c7b26d56717ed772d53c062362807f11cdae
 2012-12-27 16:17:49 +09:00
Jean Chalard
0abc48218e Rename some confusing variables 
Change-Id: Ib0de800599ae7f12c86270a627616d5b52366414
 2012-12-27 15:42:14 +09:00
Jean Chalard
5bde3a6163 Fix an old bug in getting a word from the connected view. 
In this test, it's impossible that start < 0 so the test is useless.
I'm not sure what the cursor test was for, but it's very old code, and
it seems the assumption was either misled or doesn't hold any more:
testing for the absolute cursor position against the length of the
word against the cursor makes no sense.

The net result of this was that when the cursor index got large
enough, resuming suggestion would not work any more.

Bug: 7586467
Change-Id: I3462082374fe9579bec7698f4d424de6ff5f2ded
 2012-12-27 15:41:10 +09:00
Tadashi G. Takaoka
f483225397 Get rid of current subtype and system locale cache from SubtypeSwitcher 
Bug: 7675452
Change-Id: I2121f56964b6d25e8d40f5b8ec67eeae527b2117
 2012-12-27 12:00:38 +09:00
Kurt Partridge
4aff3bf0ea Clean up unnecessary uses of toString() 
Leftover from changing variables from CharSequence to String

Change-Id: I4db43fcb075aa37bf9c5b2a23bad0e4c2d718379
 2012-12-23 18:42:06 -08:00
Kurt Partridge
f763dc5915 [Rlog24] ResearchLogger detect word boundaries in callers above commitText 
multi project commit with I5847d4aba97a7224ae170a7153811c5a11816449

Change-Id: Ie6fbf6f19f0193451fe6f3ddf9d4ef1637a35db1
 2012-12-23 12:33:16 -08:00
Kurt Partridge
13b1be988d Merge "Log LatinIME.commitCurrentAutoCorrection()" 2012-12-23 11:47:47 -08:00
Kurt Partridge
226377e65a Log LatinIME.commitCurrentAutoCorrection() 
Change-Id: Ic46c91374ae0177cafad4579d28d6980af0d8d3a
 2012-12-22 17:32:12 -08:00
Kurt Partridge
ab9f4fd359 Merge "[Rlog7] ResearchLog improve gesture tracking" 2012-12-22 11:50:46 -08:00
Kurt Partridge
f1ce54891f [Rlog7] ResearchLog improve gesture tracking 
- count how many times a gesture is deleted
- count num chars entered by gesture
- change name of fns to reflect capturing gesture information when setting composing text

Change-Id: I1b8ebf9cfcf304e0efd827c8b8e28a4010199728
 2012-12-21 12:33:54 -08:00
Kurt Partridge
4c2b6923c3 Merge "[Rlog11] ResearchLogger printable code for research key" 2012-12-20 11:40:18 -08:00
Kurt Partridge
af34813127 [Rlog11] ResearchLogger printable code for research key 
Change-Id: Ifac7a801ea8534191a9258871d3d7f91e942788b
 2012-12-19 18:15:41 -08:00
Kurt Partridge
94ac7a3851 Merge "Add ProductionFlag.IS_EXPERIMENTAL_DEBUG" 2012-12-19 09:02:05 -08:00
Jean Chalard
cff28c5d5d Add skeleton classes for hardware event flow (B1) 
Bug: 5037589
Change-Id: Id8eea0e2bd00dd339a1efb4b0542e4c091a84195
 2012-12-19 17:47:29 +09:00
Ken Wakasa
45239029ce Remove trailing spaces 
Change-Id: I260b85ef9e91d17f97d6e405d2d92a65b443df44
 2012-12-19 15:36:55 +09:00
Kurt Partridge
0aafbcf879 Add ProductionFlag.IS_EXPERIMENTAL_DEBUG 
The IS_EXPERIMENTAL_DEBUG flag gives a single place to turn off all debugging flags that might be
set and to also enforce privacy controls.  Currently only used in the research package.

multi-project commit with I9275a7c8e40bf56106447a02d3056655329074b3

Change-Id: If769fe3a633f33963ca49e8ddf01ab24a30b6fd2
 2012-12-18 19:46:30 -08:00
Kurt Partridge
ce8b139124 Merge "[Rlog5] ResearchLogging change from onFinishInput to onFinishInputView" 2012-12-18 11:34:34 -08:00
Kurt Partridge
8432c1317a Merge "[Rlog3] improve stat recording" 2012-12-18 09:54:05 -08:00
Kurt Partridge
606058f777 [Rlog5] ResearchLogging change from onFinishInput to onFinishInputView 
Change-Id: I7d3bcfe647249e0b8a14ac3d67460c2684f16d8c
 2012-12-17 21:39:54 -08:00
Kurt Partridge
48160f9d84 [Rlog3] improve stat recording 
Change-Id: Ie3b70e6eadc2a9af5ef45ddfad6a3398cea7bfe8
 2012-12-17 17:08:47 -08:00
Kurt Partridge
c5da4365fb Merge "[Rlog2] ResearchLogging fix multi-space logging" 2012-12-17 16:33:57 -08:00
Kurt Partridge
3370dc8237 [Rlog2] ResearchLogging fix multi-space logging 
multi-space logging should look like single-space logging, missing a few minor log statements
(SuggestionUpdates, SetComposingText)

multi-project commit with I2af842348c2f2b8f7271ac5b63def245e83df24d

Change-Id: Icd3187c0d0377255f82787afffea657c14345803
 2012-12-17 09:53:43 -08:00
Ken Wakasa
fbe83245c9 Clean up SuggestionSpanUtils for API level 14+ 
Change-Id: Iadc235524341b48e7618e9ce05907c786409e004
 2012-12-17 19:41:44 +09:00
Ken Wakasa
96b22200be Privatize a few constants in BinaryDictionary.java 
Change-Id: I7defaf1f577fd67e678cac83ff935e8181dd0a48
 2012-12-17 17:46:57 +09:00
Tadashi G. Takaoka
f21a491ad8 Show last valid suggestions when gesture typing gets no suggestion 
Bug: 7679566
Change-Id: Ie68c7698144c7576b5814ee35664309bcfdcbf0f
 2012-12-17 16:19:10 +09:00
Tadashi G. Takaoka
b808188b2f Show last valid suggestions when tap typing gets no suggestion 
Bug: 7872809
Change-Id: Ib5a255de7968aba214249c1b934327d248a15efd
 2012-12-17 14:32:18 +09:00
Ken Wakasa
8c15e91344 resolved conflicts for merge of d48d6fee to master 
Change-Id: I21141956135debe737453dba87617671b1716d0a
 2012-12-15 09:44:39 +09:00
Jean Chalard
d48d6feedd am db6f21c6: am 18d688c9: Use the amended user dictionary word for insertion 
* commit 'db6f21c6792fe07a733572e1d4978f46b5462c35':
  Use the amended user dictionary word for insertion
 2012-12-14 11:01:56 -08:00
Jean Chalard
18d688c94b Use the amended user dictionary word for insertion 
When the user edits a word before adding it to the user
dictionary, the keyboard should replace whatever was
committed before with the amended version.

Bug: 7725834
Change-Id: I1a417be6c5a86d6a96bc2c76aca314ad8f1202a9
 2012-12-14 20:28:22 +09:00
Tadashi G. Takaoka
edbb65be3e Reset composing state at onFinishInputView 
Bug: 7709817
Change-Id: Icac0b8cb28209d98d291d8f00be55e33af5bf696
 2012-12-14 17:48:13 +09:00
Tom Ouyang
ac69ab400d Refactor more keys menu framework (part 3) 
Make it possible to re-enter gesture input even after triggering the long-press
menu. This is useful for new users who may pause at the start of a word. Works
for both single and bi-manual gestures.

Bug: 7595193
Change-Id: Ieaecfd5385ed6c10ae9347b99c2e35a0de5e895d
 2012-12-13 21:45:51 -08:00
Tom Ouyang
1f4f404e1f Merge "Refactor more keys menu framework (part 2)" 2012-12-13 18:51:37 -08:00
Tom Ouyang
35580bad6f Refactor more keys menu framework (part 2) 
- Integrate pointer tracking between more keys menu, more suggestions menu, and main keyboard.
- Adds multi-touch support for more keys menus. Long press with one finger and select keys with another finger.

Bug: 7508007

Change-Id: I394f28cd79e342d6bcfea573af72aa33b9def00f
 2012-12-13 13:17:28 -08:00
Jean Chalard
f1b464da31 Remove a useless member 
Change-Id: Id13e0aeec6ec3655d6bb0edc7f8f7821e7dc5a36
 2012-12-11 19:15:24 +09:00
Tadashi G. Takaoka
12939572f3 Remove unused suggestion preview stuffs 
Change-Id: Ida5668f4eba1783d96e02001a64ae713f98176b7
 2012-12-07 17:47:09 -08:00
Tom Ouyang
fa2d543785 Refactor more keys menu framework (part 1) 
Eliminate use of slower popup window for rendering the more keys menu and more suggestions menu.
These menus are now drawn directly on the preview placer view.

Change-Id: I40638724a6ffde2be4b5d0341d2a5db7ff7be930
 2012-12-07 16:34:25 -08:00
Tadashi G. Takaoka
8e2b34cdb2 Cancel batch input when orientation has been changed 
Bug: 7665231
Bug: 7662486
Change-Id: I7b6095026dbf1b9b2f6d3b29f2ab83c462ab374e
 2012-12-06 14:24:05 -08:00
Jean Chalard
2da8866518 Remove a couple Eclipse and Android Lint warnings 
Change-Id: I0c29c5d2abcbf80759b996d34b534deb083cd7d3
 2012-12-06 21:30:51 +09:00
Ken Wakasa
2b6a1fed76 Method/variable/resource names clean up for the double-space period 
bug: 7664717
Change-Id: I914aa588b863c442c2d360221e3fa0f4c42640e7
 2012-12-05 12:40:10 +09:00
Jean Chalard
b4a9a6deba Merge "Fix wrong misspelling reports of fully capitalized words" 2012-12-04 01:22:48 -08:00
Jean Chalard
95bfb8ac47 Fix wrong misspelling reports of fully capitalized words 
Two flavors of words would be wrongly reported as misspelled
by the android spell checker when they are written in all
upper case letters:
- Words containing a quote or a dash or any other non-letter
- Words that need the first letter to be capitalized

Bug: 7659216
Change-Id: Ibc5d261945ffcbb8a858d4c73b7c62cef6671abf
 2012-12-04 18:05:27 +09:00
Ken Wakasa
139bd83f0c Add a new option for the double-space period functionality 
bug: 6934756

Change-Id: I94b2d08cac6533e96031d8e97f347e9b5fd72859
 2012-12-04 15:27:22 +09:00
Tadashi G. Takaoka
84f5816cf1 Merge "Groundwork for sliding key input preview" 2012-12-03 01:19:51 -08:00
Tadashi G. Takaoka
547b638194 Groundwork for sliding key input preview 
Bug: 7548583
Change-Id: Id807af31f581c08ff8074ed1f6766337bea9469f
 2012-12-03 18:16:12 +09:00
Satoshi Kataoka
16e9d343c4 Merge "Tweak beeline speed" 2012-11-30 02:08:55 -08:00
Tadashi G. Takaoka
b5fc0e02d0 Cancel update batch input timer when gesture typing has been canceled 
Bug: 7594165
Change-Id: I9dc42919bd196c249c79668570004d3f541cc9ec
 2012-11-30 16:30:56 +09:00
Satoshi Kataoka
6ae8dd4343 Tweak beeline speed 
Change-Id: I77bbd5e1888281e838d87824dc04a574b1a7ecb7
 2012-11-30 02:02:59 +09:00
Tadashi G. Takaoka
359c35e0f6 Add CoordinateUtils class 
Change-Id: I23784117f77da54ee2a0670e65d86e26d762a687
 2012-11-28 19:03:28 +09:00
Tadashi G. Takaoka
85e397cd10 Set additional subtypes before getting current subtype 
Bug: 7594188
Change-Id: I1977acb7189f8eb186b9b20a3e5b64b4aaabf191
 2012-11-28 14:49:38 +09:00
Tadashi G. Takaoka
b3f789799a Cancel gesture typing by sliding out from keyboard 
Bug: 7594165
Change-Id: I7849d763e49b57716e8418fb8b6f90eca3a5d2ec
 2012-11-22 17:49:56 +09:00
Jean Chalard
e36af707c8 resolved conflicts for merge of b7e6bbae to master 
Change-Id: Ic02809190721472d138532d2189328519117e042
 2012-11-21 13:07:31 +09:00
Jean Chalard
b7e6bbaebc am 3acd0c7a: am f732f4dd: Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 
* commit '3acd0c7a9f4a5f17897a4fe51b023d6f14ba7ef0':
  Only add spaces automatically when appropriate.
 2012-11-20 19:38:47 -08:00
Jean Chalard
f732f4ddcc Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 2012-11-20 19:36:50 -08:00
Tadashi G. Takaoka
e44ce053e7 am 8a5b176f: am fd1267e3: Add Spanish United States keyboard (DO NOT MERGE) 
* commit '8a5b176f655a46f1c575886a7d3a3c1120c91b29':
  Add Spanish United States keyboard (DO NOT MERGE)
 2012-11-20 18:58:29 -08:00
Jean Chalard
c82c0d0ef2 Merge "Fix variation dumping." 2012-11-19 23:56:47 -08:00
Jean Chalard
4d0fa31779 Fix variation dumping. 
Variations are not flags - they should not be OR'd in this way.
Only one variation may be active at a time.

Change-Id: I9d3d4c8fc04af56c914c65f9c55f1e7b9517fc68
 2012-11-20 16:55:16 +09:00
Jean Chalard
ec60d60078 Only add spaces automatically when appropriate. 
Correctly check the variations to determine if we should
add automatic spaces (in manual picks and gestures) or not.

Bug: 7164981
Change-Id: I19e25af839b4062c217113cd804b1473912f22a5
 2012-11-19 19:47:40 +09:00
Tadashi G. Takaoka
76d4ffeebf Add Spanish United States keyboard 
The subtype locale name on the spacebar will be suppressed when only
one subtype is enabled and
 - Subtype locale is equal to the system locale.
or
 - Subtype language is equal to the system language but the subtype is
   implicitly enabled.

Thus the "es_ES" system locale chooses "es" subtype keyboard
implicitly but the keyboard doesn't have the subtype name on its
spacebar.

This change also removes Spanish Latin America keyboard.

Bug: 7531804
Change-Id: Ib929e8235d643c0ba039eb010e18ab721a734e15
 2012-11-19 15:39:44 +09:00
Tadashi G. Takaoka
fd1267e396 Add Spanish United States keyboard (DO NOT MERGE) 
Bug: 7531804
Change-Id: Idd66ee30e5228260540308a97c930185b48e775f
 2012-11-19 11:27:07 +09:00
Ken Wakasa
41a2c10e72 resolved conflicts for merge of 4ad92578 to master 
Change-Id: I29ad9f0ba357e39889e30c9ebfcf61f9d08ee4ef
 2012-11-17 11:33:48 +09:00
Ken Wakasa
4ad92578dd am 7acd310d: am f9ff4fb5: Merge "Revert "Only add spaces automatically when appropriate."" into jb-mr1.1-dev 
* commit '7acd310d02f060f3e3e29000db902dffb6b0df9c':
  Revert "Only add spaces automatically when appropriate."
 2012-11-16 18:05:42 -08:00
Ken Wakasa
f9ff4fb5da Merge "Revert "Only add spaces automatically when appropriate."" into jb-mr1.1-dev 2012-11-16 18:00:15 -08:00
Ken Wakasa
5986931fcb Revert "Only add spaces automatically when appropriate." 
This reverts commit 6ce66d1c7d

Change-Id: I90004a5fea0bc7999ecf8742f883ff4dac264d8a
bug: 7565414
 2012-11-16 17:49:22 -08:00
Marco Nelissen
ea23a28557 resolved conflicts for merge of 6f42cf1d to master 
Change-Id: I054bb0cfba9de06473100010a76e2f3d9c2c1180
 2012-11-16 11:23:33 -08:00
Jean Chalard
3a9f84a197 am 8c470f16: am 5dee6e69: am 187e683a: Merge "Fix a bug with some text fields" into jb-mr1.1-dev 
* commit '8c470f16db291e257ac538bd0ac2a9354d34010c':
  Fix a bug with some text fields
 2012-11-16 10:36:15 -08:00
Ken Wakasa
fe9ec6bc7d Remove unused variables 
Change-Id: Ia5079368a1bc86ccdf0052445dc6945041c0abca
 2012-11-16 19:28:56 +09:00
Jean Chalard
6f42cf1dee am 3dd4548e: am 191d49ae: Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 
* commit '3dd4548ec6105ca774e84ab3223bdbcea1e4902e':
  Only add spaces automatically when appropriate.
 2012-11-15 19:14:00 -08:00
Jean Chalard
191d49ae8a Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 2012-11-15 19:09:04 -08:00
Jean Chalard
6ce66d1c7d Only add spaces automatically when appropriate. 
Bug: 7164981
Change-Id: Id672104a0fda99c52923913fb0e40c3a1ead4787
 2012-11-15 17:57:16 +09:00
Jean Chalard
8c470f16db am 5dee6e69: am 187e683a: Merge "Fix a bug with some text fields" into jb-mr1.1-dev 
* commit '5dee6e69f1de114df1f258fdc62559237989dc75':
  Fix a bug with some text fields
 2012-11-14 20:40:33 -08:00
Jean Chalard
187e683aea Merge "Fix a bug with some text fields" into jb-mr1.1-dev 2012-11-14 20:37:19 -08:00
Tadashi G. Takaoka
0dfb89b41e am eea28db3: am d4886ff5: am 929bfdd0: Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 
* commit 'eea28db3333a734bf73e688b8335245929d5f322':
  Update shift state only when input field is restarted
 2012-11-14 16:34:42 -08:00
Tadashi G. Takaoka
eea28db333 am d4886ff5: am 929bfdd0: Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 
* commit 'd4886ff5419003c3bf996939ba87e4b49bcdbfae':
  Update shift state only when input field is restarted
 2012-11-14 16:33:20 -08:00
Tadashi G. Takaoka
dda024cf30 am 428d1b64: am 4826c3ff: Merge "Fix language switch key behavior (DO NOT MERGE)" into jb-mr1.1-dev 
* commit '428d1b6469b5bc9041c35a7e1ee1476d5aacedd7':
  Fix language switch key behavior (DO NOT MERGE)
 2012-11-14 16:33:19 -08:00
Tadashi G. Takaoka
929bfdd059 Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 2012-11-14 16:29:43 -08:00
Tadashi G. Takaoka
d0725a6842 Update shift state only when input field is restarted 
Bug: 7482766
Change-Id: Ifdfa110c44b95acfbcd3e0aa34f675c70b7d7285
 2012-11-14 18:44:43 +09:00
Tadashi G. Takaoka
4a3d4620fc Merge "Fix language switch key behavior" 2012-11-14 01:42:12 -08:00
Tadashi G. Takaoka
d62be28515 Fix language switch key behavior (DO NOT MERGE) 
Bug: 7075923
Change-Id: If139411db4aa65eed64337bf2a79387cfcd04496
 2012-11-14 18:29:01 +09:00
Tadashi G. Takaoka
1931c1cab1 Fix language switch key behavior 
Bug: 7075923
Change-Id: I306e1ff5d9f873541e84e1fafb64b9473947f623
 2012-11-14 18:27:00 +09:00
Satoshi Kataoka
1ee6e14507 Hide statustics logging option 
Change-Id: I1ee258948a8335af7996f9e3afcc0508adbb1ac0
 2012-11-14 14:01:52 +09:00
Jean Chalard
00c0010ccf Fix a bug with some text fields 
Not sure when this happens exactly, but it is possible that
InputConnection#getTextBeforeCursor returns null. This
happens for example upon rotating the screen with the
composing field empty in Gmail.
In this case, StringBuilder#append will convert the null
pointer into the string "null", which is sure better than a
crash, but can have a number of bad side-effects, like
auto-caps not working.

Bug: 7533034
Change-Id: Ia1cfab432c13a12ff1c2f013c59bac05a587f553
 2012-11-14 12:22:40 +09:00
Jean Chalard
372f9da4f9 am 18ff5612: am f592270a: am 7648b37d: Merge "Make sure all FDs are correctly closed." into jb-mr1.1-dev 
* commit '18ff56125345746e288118d177fcabf3c079ead3':
  Make sure all FDs are correctly closed.
 2012-11-13 18:47:02 -08:00
Jean Chalard
18ff561253 am f592270a: am 7648b37d: Merge "Make sure all FDs are correctly closed." into jb-mr1.1-dev 
* commit 'f592270a0f092c5ef52bbb0f24c8873f46e75503':
  Make sure all FDs are correctly closed.
 2012-11-13 18:45:42 -08:00
Jean Chalard
7648b37d1e Merge "Make sure all FDs are correctly closed." into jb-mr1.1-dev 2012-11-13 18:42:35 -08:00
Jean Chalard
5c32b6da44 Make sure all FDs are correctly closed. 
In this kind of series of calls, it's possible that an outer call to a
constructor fails, but the inner succeeded.
Example:
try {
    is = new A(new B());
} finally {
    if (null != is) is.close();
}
In this case, if new B() succeeds but new A() throws an
exception, is stays null and the intermediate object is never
closed. This is what was happening in this instance.

Bug: 7377336
Change-Id: I3fae9fec1135244982fcf5098c76d93f3e0f2add
 2012-11-13 16:53:07 +09:00
Jean Chalard
80d7d32424 am d2116eb2: am 7d34763e: am fac619a3: Merge "Don\'t restrict reset composing state to non-identical setText" into jb-mr1.1-dev 
* commit 'd2116eb2ea7d08e81b7efe5e342772ffcd8a7efc':
  Don't restrict reset composing state to non-identical setText
 2012-11-12 23:48:20 -08:00
Jean Chalard
1b909c2846 Resolve conflicts for merge of 3a9ba17f to master" 
Change-Id: I8a1a84a81745a708f63e4211267c4afc3a6b8e49
 2012-11-13 16:34:23 +09:00
Jean Chalard
d2116eb2ea am 7d34763e: am fac619a3: Merge "Don\'t restrict reset composing state to non-identical setText" into jb-mr1.1-dev 
* commit '7d34763e23cb49c8c96dbf9b4c613e17098dd919':
  Don't restrict reset composing state to non-identical setText
 2012-11-12 23:04:39 -08:00
Jean Chalard
3a9ba17fd2 am a13a8a58: am 0e84041b: Refactor all phantom-space-inserted spaces in one place 
* commit 'a13a8a58e05ecd3f9eccdc47ceca972a814d247e':
  Refactor all phantom-space-inserted spaces in one place
 2012-11-12 23:04:37 -08:00
Jean Chalard
fac619a34c Merge "Don't restrict reset composing state to non-identical setText" into jb-mr1.1-dev 2012-11-12 23:00:12 -08:00
Jean Chalard
0e84041bf7 Refactor all phantom-space-inserted spaces in one place 
Bug: 7164981
Change-Id: If1635c212b2d5d9cf51f5fb074f3b20dd7ec7b2a
 2012-11-13 12:53:55 +09:00
Jean Chalard
61cc2a3391 Don't restrict reset composing state to non-identical setText 
Bug: 7497063
Change-Id: Ifbd5c37408131867458fd921bdef46ef90d81478
 2012-11-12 18:34:18 +09:00
Tadashi G. Takaoka
eaaee28647 Merge "Enhance ImfUtils to InputMethodManagerWrapper class" 2012-11-11 22:43:07 -08:00
Tadashi G. Takaoka
6fbbab3b84 Enhance ImfUtils to InputMethodManagerWrapper class 
Change-Id: I6ff86ee819a446dd3ed5f9c3400d23564027b020
 2012-11-12 15:23:43 +09:00
Tadashi G. Takaoka
21177c1afe Remove gesture typing settings when disabled by configuration 
Bug: 7506408
Change-Id: I4de53ace170d5ddc9779f42ac344c4190c80a019
 2012-11-09 07:58:27 -08:00
Jean Chalard
01d47b8096 Fix a logic flaw. 
This test is seriously wrong : although we do have a method that
does exactly the right thing, this looks at a very specific, unrelated
variable state in hope it happens to be set only in the relevant
cases by the play of logic.
I don't think this changes anything concretely, as the assumption
was probably true in the practice ; still, this code is very hard to
read and prone to unexpected breakage.

Change-Id: I77ab576f90762429fcc752df31ed30e1c81871dc
 2012-11-09 19:16:37 +09:00
Ken Wakasa
710d06cea9 Suppress dictionary pack support when IS_EXPERIMENTAL is true 
Change-Id: If8813cb989c1fa8744a3bf36e8514ced3c8f46a3
 2012-11-09 15:03:31 +09:00
Tadashi G. Takaoka
c43ff6f66c Remove gesture typing settings when disabled by configuration 
Bug: 7506408
Change-Id: I4de53ace170d5ddc9779f42ac344c4190c80a019
 2012-11-09 12:44:40 +09:00
Ken Wakasa
43f579e9f6 am 4eef5101: am aa5d6fe0: am 9cc22c45: am 5d2556b9: Reset the IME if requested by the app. 
* commit '4eef51016adc4e103fa65d944a0ab31527ddced8':
  Reset the IME if requested by the app.
 2012-11-08 06:22:02 -08:00
Ken Wakasa
5d2556b932 Reset the IME if requested by the app. 
Specifically, reset the KeyboardState to the main Alphabet layout in
LatinIME.onStartInputViewInternal() if a keyboard layout set doesn't get
reloaded in the method.

Please note TextView.setText() calls up resetInput(), then the IME should
reset with it.

bug: 7482086

Note that bug: 6851364 needs to be revisited.

Change-Id: I5d448c10963d3dd952dd13cb587085ec7b014e69
 2012-11-07 01:09:26 +09:00
Tadashi G. Takaoka
ffb0c093d1 Merge "Move isInvalidCordinates() method to Constants class" 2012-10-31 21:24:01 -07:00
Tadashi G. Takaoka
24ab8055aa Move isInvalidCordinates() method to Constants class 
Change-Id: Iad1464c299ad6055af1db1ff7978e5cd9a14750f
 2012-11-01 13:12:58 +09:00
Tadashi G. Takaoka
20dd1bc090 Cosmetic source code formating change 
Change-Id: I3a53b49afab70dfb13f12027070635da6001eb79
 2012-11-01 13:10:44 +09:00
Ken Wakasa
1e61493c50 Use 32-bit code points for suggestions output 
This is a multi-project commit with Ic43dd666

bug: 6526418
Change-Id: I39c1acb4e91d04cd8a4ec5a943c8cf575da75ebc
 2012-11-01 00:09:51 +09:00
Jean Chalard
51a0ef8c59 Add a plumbing option to dicttool info. 
Also align the `porcelain' option to the diff command
that was used mistakenly.

Bug: 7388665
Change-Id: Ic0e1b98c62ce37b2e909384a0370af4458563703
 2012-10-31 16:35:22 +09:00
Tadashi G. Takaoka
c7318bbc0b Fix possible NPE 
Bug: 7398904
Change-Id: I6b7aba7a9bf52ca494cb4390b19525c98790bd49
 2012-10-29 18:40:37 +09:00
Tadashi G. Takaoka
cfbfb1c50a Remove reference of android.util.Log in Constants class 
This is a follow up of Iee01d4d2.

Change-Id: I0bcd349d317d9f7d40ef0574e72c640f9f990c5d
 2012-10-29 17:25:13 +09:00
Tadashi G. Takaoka
7947eaf475 Merge "Move code point constants from Keyboard to Constants class" 2012-10-29 00:10:52 -07:00
Tadashi G. Takaoka
240871ecaf Move code point constants from Keyboard to Constants class 
Change-Id: Iee01d4d2b916d0b584531104ac865ae6e6370a3d
 2012-10-29 16:04:20 +09:00
Jean Chalard
f41389a74b Remove warnings 
Thanks Eclipse

Change-Id: I88e3979ed22be5d8be5a5accdde417c6b1a8bf2d
 2012-10-29 14:24:16 +09:00
Jean Chalard
a23e333079 Implement the word-level diff (A9) 
Bug: 7388857
Change-Id: I4c4560d4f4b579936a44cdf409a4c27300b65610
 2012-10-29 12:31:22 +09:00
Satoshi Kataoka
6067b9e1bd am ef5f88f3: am 5e118c4c: am 60dea36d: Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
* commit 'ef5f88f33e432284c958fafe18f891a10f77e1f9':
  Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
 2012-10-25 19:31:27 -07:00
Satoshi Kataoka
60dea36daf Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
Bug: 7393485
Bug: 7272829
Change-Id: I873e8d99486c734e76484526631a90fc55e91c86
 2012-10-25 20:00:46 +09:00
Jean Chalard
47cac57e45 Finish up the "info" command in dicttool. (A6) 
Bug: 7388857
Change-Id: I704f12a6be76ce1644ec5e8dd3b667f112e9c04a
 2012-10-25 19:15:24 +09:00
Jean Chalard
b3c98901c5 Add auto detection and decoding of dictionary files. (A2) 
Bug: 7388852
Change-Id: I25e755fc15f5b383acc046f668e9681efa4f0c2f
 2012-10-25 16:40:15 +09:00
Jean Chalard
ddb0bcc051 Fix a bug where a bigram would be ignored 
Bug: 7403386
Change-Id: I89f495d07f7059a9f1ccd97d487c2f2657a8ebd2
 2012-10-24 13:24:59 +09:00
Jean Chalard
5e5be5a2d2 Merge "Return the correct bigram frequency" 2012-10-23 01:19:28 -07:00
Jean Chalard
c59c741987 Return the correct bigram frequency 
The "correct" bigram frequency is now returned by the reading
code. However, as the binary format represents the frequency
in a lossy manner, the frequency is not guaranteed to be the
exact same as the one in the source text format - only a close
enough value. It is however the exact same value seen by the
native code.

Bug: 7395653
Change-Id: I49199ef18901c671189912b3550623e9643baedd
 2012-10-23 17:17:37 +09:00
Jean Chalard
1e0cc86b6f Fix the build. 
It seems this change snuck out from a previous version.

Change-Id: I9c33d51273732b1d55bfd60f0957184c86fa88ab
 2012-10-23 15:34:42 +09:00
Jean Chalard
c7020f54f9 Merge "Add reader and writer for the combined dict format." 2012-10-22 23:11:20 -07:00
Jean Chalard
9bb4eebf48 Add reader and writer for the combined dict format. 
This introduces a new textual format for the dictionary that combines
words, bigrams and shortcuts to avoid complexity. It is also extensible
to n-grams to fool-prof for the future, and easier to read than XML.

Bug: 7388540
Change-Id: I942bbad51bd0c905a5a54c278667563fd6dd66ec
 2012-10-23 15:06:25 +09:00
Jean Chalard
751f3dc0e1 am 6fe6f38d: am d39e6435: am f960eb18: Don\'t put spaces after characters that don\'t take one 
* commit '6fe6f38d8af09b24e40a6e01eae919820cd04c16':
  Don't put spaces after characters that don't take one
 2012-10-22 21:46:43 -07:00
Jean Chalard
f960eb186d Don't put spaces after characters that don't take one 
Bug: 7393639
Change-Id: I1245a7b5077e554642838d6856ce269ca7f91988
 2012-10-23 12:28:28 +09:00
Tadashi G. Takaoka
7f77aed507 Merge "Replace useless CharSequence to String" 2012-10-22 14:27:35 -07:00
Tadashi G. Takaoka
15f6d4ae34 Add @UsedForTesting and @ExternallyReferenced annotations 
Bug: 7268357
Change-Id: I0b7e0c19f04af9ae30874d0a4c26ad81bc80be8c
 2012-10-22 11:18:43 -07:00
Tadashi G. Takaoka
bc464e2952 Replace useless CharSequence to String 
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
 2012-10-22 11:03:28 -07:00
Tadashi G. Takaoka
5faf419519 Suggestion strip will honor haptic feedback settings of keyboard 
Bug: 7313372
Change-Id: I427da8de68be3d2a78e810556340b96ab4edcc2d
 2012-10-17 21:40:02 -07:00
Tadashi G. Takaoka
8e360c68f1 Move AudioAndHapticFeedbackManager from LatinIME to KeyboardSwitcher 
Bug: 7313372
Change-Id: I9bd3275f57ed3f5c2c4a95768443af505513ee97
 2012-10-17 19:39:16 -07:00
Jean Chalard
c5dc32ac59 am b37e87e7: am 63b3fc0d: am 15142588: Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 
* commit 'b37e87e7d50725f20a6b2f8484fc25cc7db3134f':
  Have "no whitespace before cursor" upon gesture trigger phantom space
 2012-10-16 18:12:50 -07:00
Jean Chalard
1514258824 Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 2012-10-16 18:06:11 -07:00
Jean Chalard
e91d495c53 Have "no whitespace before cursor" upon gesture trigger phantom space 
Bug: 7359291
Bug: 7357758
Bug: 7197651
Change-Id: Ia805a87e922739ae0a06978a3bf00d91c94b6c51
 2012-10-17 09:36:07 +09:00
Tadashi G. Takaoka
788c885aa5 am 344a7fef: am 658e935b: am c0bc3369: Merge "Fix more suggestions text width calculation" into jb-mr1-dev 
* commit '344a7fef5bd101e2d1c4278cc35de2862f28a456':
  Fix more suggestions text width calculation
 2012-10-16 17:32:00 -07:00
Jean Chalard
fa3d984d1b am 60211f0d: am 2631fe4c: am 6686e63f: Honor automatic shift turned off for gestures 
* commit '60211f0d250ca931788d32d5a69c880f75ef7d49':
  Honor automatic shift turned off for gestures
 2012-10-16 17:28:18 -07:00
Tadashi G. Takaoka
c0bc336955 Merge "Fix more suggestions text width calculation" into jb-mr1-dev 2012-10-16 17:24:35 -07:00
Tadashi G. Takaoka
bdc8b9e42b Fix more suggestions text width calculation 
Bug: 7345983
Change-Id: Ic1554db98e7aaf032eb90a98c0c37c7c789461b5
 2012-10-16 14:24:30 -07:00
Jean Chalard
6686e63f21 Honor automatic shift turned off for gestures 
Bug: 7354129
Change-Id: Ia02336e8cea2f04b629edbe74b7815cce0d7fad6
 2012-10-17 05:41:06 +09:00
Jean Chalard
01e0913ad2 Make a better choice for the temporary file 
Change-Id: I745bb285b6b52875c8d2b3a94deb962352f9754e
 2012-10-12 19:58:07 +09:00
Ken Wakasa
b0aa9606ae am 726e98b7: am c1a1937c: am 2220aeed: Merge "Put temporary files under a separate directory." into jb-mr1-dev 
* commit '726e98b7378987b2cfe46ea5395692640b108e83':
  Put temporary files under a separate directory.
 2012-10-11 08:41:42 -07:00
Jean Chalard
66c90cd2ae Put temporary files under a separate directory. 
Bug: 7328003
Change-Id: Ibe5278ea209d149f87fd08785c77b17e3859948e
 2012-10-11 17:53:06 +09:00
Ken Wakasa
06636bf96a am 0081681e: am c44314b4: am dc38a343: Merge "Use a freq of 1 instead of 0 for non-word shortcuts." into jb-mr1-dev 
* commit '0081681e346ce5c958e5eef264caa3f257b094c5':
  Use a freq of 1 instead of 0 for non-word shortcuts.
 2012-10-09 07:48:46 -07:00
Jean Chalard
99b84b42f9 Use a freq of 1 instead of 0 for non-word shortcuts. 
Also fix a spelling mistake in a comment

Bug: 7301525
Change-Id: I4437403dce620fed03871485ee04f13c51ce34fc
 2012-10-09 19:16:07 +09:00
Ken Wakasa
b02ee3d67a Make use of the NELEMS and KEYCODE_SPACE macro. Also, remove an unused parameter. 
Change-Id: I3c7e6c59990c92b0d5e2fb80493e8673cdd37b09
 2012-10-09 11:17:50 +09:00
Ken Wakasa
fc62882591 Fix a small typo 
Change-Id: I813d97b9453f8aa7aae99bd165336b1e5a81dc6a
 2012-10-07 12:05:23 +09:00
Tadashi G. Takaoka
792980d4aa Avoid calling switchToLastInputMethod when other IMEs are in effect (DO NOT MERGE) 
Bug: 7299050
Change-Id: Ife6721a5fcbc4872bd36ffd8a8b81b04d73aebec
 2012-10-06 19:01:36 +09:00
Yuichiro Hanada
d2579c4832 fix writeCharGroup. 
Change-Id: Ib841afaba0a20c3b300eb7d3e9133243f9f3ae58
 2012-10-05 14:54:17 +09:00
Ken Wakasa
feac8a91f9 am 933e7c37: am 37c8f8b5: am 20f07e33: Merge "Unlink an old file before moving the new file over it" into jb-mr1-dev 
* commit '933e7c3770c00a9eea43c447d96daec1ada62041':
  Unlink an old file before moving the new file over it
 2012-10-04 15:40:20 -07:00
Ken Wakasa
20f07e335d Merge "Unlink an old file before moving the new file over it" into jb-mr1-dev 2012-10-04 15:33:41 -07:00
Jean Chalard
daff19bc29 am d173ed18: am bf6c8bd8: am 3f7fe829: Merge "Always consider a new line the start of a sentence" into jb-mr1-dev 
* commit 'd173ed18e44ea5cdc48d5f620bb91efcd3ed5174':
  Always consider a new line the start of a sentence
 2012-10-04 06:00:45 -07:00
Jean Chalard
2699b45dbc Always consider a new line the start of a sentence 
Bug: 7282523
Change-Id: I10a73e99efdfe6acb9a16819694b98c6714fd451
 2012-10-04 20:54:28 +09:00
Yuichiro Hanada
3c6d9fe148 Add insertWord. 
bug: 6669677

Change-Id: Ide55a4931071de9cd42c1cddae63ddd531d2feba
 2012-10-04 17:19:47 +09:00
Jean Chalard
c15726482e Unlink an old file before moving the new file over it 
This is unlikely to be relevant to this bug, but just in case.

Bug: 7274972
Change-Id: I56b31b377af16cc2c15ceb90a19792bed3aab367
 2012-10-04 15:49:08 +09:00
Yuichiro Hanada
c3a98ca306 Add writeNode. 
Change-Id: I088bb6ea43ce0841d725e48b677d429e1155569d
 2012-10-04 14:28:42 +09:00
Yuichiro Hanada
38712ff27d Add updateParentAddresses. 
Change-Id: Iac210131b7c003ef363e1138bf22f777a37c6a89
 2012-10-03 19:37:17 +09:00
Yuichiro Hanada
a853356b82 Add isDeletedGroup. 
Change-Id: I83f09c068868e5e6e1b46f494a6ef957f0b466d8
 2012-10-03 02:19:41 -07:00
Yuichiro Hanada
7223cc2ef1 Add MAX_BIGRAMS_IN_A_GROUP. 
Change-Id: I128d5deb8e523045d7ad77d7a8fd3db944f71238
 2012-10-03 18:10:06 +09:00
Satoshi Kataoka
69c787f3b7 am 96717371: am e8825ce3: am 1fd10ea2: Merge "Throw illegal argument exception in BinaryDictionary::editDistance" into jb-mr1-dev 
* commit '967173711f17ba30d3608881f501985f07fef4fd':
  Throw illegal argument exception in BinaryDictionary::editDistance
 2012-10-03 01:21:43 -07:00
Satoshi Kataoka
1fd10ea22c Merge "Throw illegal argument exception in BinaryDictionary::editDistance" into jb-mr1-dev 2012-10-03 01:15:52 -07:00
Satoshi Kataoka
66d955ad71 Throw illegal argument exception in BinaryDictionary::editDistance 
Bug: 7276803
Change-Id: Icd9bdec0a04179a29d00336819d205627f77b71a
 2012-10-03 17:15:47 +09:00
Tadashi G. Takaoka
c6ff7c42d9 Add SuggestedWords.isEmpty() method 
Change-Id: I0fcb104a6a81aee4b99f5ee848eba7495630dc7d
 2012-10-03 15:09:10 +09:00
Tadashi G. Takaoka
3e5a3c18be Add final modifier to the classes under suggestions sub-package 
Change-Id: I19fc8eaac1aebef9cf4deb004e78484ff9a1e7ca
 2012-10-03 14:57:29 +09:00
Tadashi G. Takaoka
5f5f7825e7 am 4d009dbc: am ace7d128: am d445b56c: Fix possible NPE caused while monkey test 
* commit '4d009dbc514cd77eb22e4162e4ae7ea852e1b77e':
  Fix possible NPE caused while monkey test
 2012-10-02 22:44:57 -07:00
Yuichiro Hanada
4ad4ff618f Add makeCharGroupFlags. 
Change-Id: Id2c580f21b77f66a97c5fbdf4542fdafe6c43614
 2012-10-03 14:33:59 +09:00
Tadashi G. Takaoka
d445b56ce1 Fix possible NPE caused while monkey test 
Bug: 7269036
Change-Id: I9054b33ad3c8996cac3ee5f0e9c01ba8ceea4971
 2012-10-03 14:33:52 +09:00
Tadashi G. Takaoka
c3aea8ea9f Merge "Avoid calling switchToLastInputMethod when other IMEs are in effect" 2012-10-02 01:36:37 -07:00
Tadashi G. Takaoka
aec5cc8476 Avoid calling switchToLastInputMethod when other IMEs are in effect 
Bug: 7268389
Change-Id: I4d960cbf063002b4dc0ea813c966366b56c0346d
 2012-10-02 17:29:15 +09:00
Tadashi G. Takaoka
fe3fb2502d am 58e1be74: am de102ede: am 15281adb: Show gesture floating preview text by default 
* commit '58e1be74a989637b0b71ebf990ed1b3c9a21e7af':
  Show gesture floating preview text by default
 2012-10-01 23:41:38 -07:00
Tadashi G. Takaoka
15281adbc1 Show gesture floating preview text by default 
Bug: 7244214
Change-Id: Ib4ab810ef50798828dd10c39a8077466165772e4
 2012-10-01 21:23:00 -07:00
Jean Chalard
37688ae8c1 am 86db54df: am 137203d4: am 574b80aa: Remove debug prints. 
* commit '86db54df74b821a15f7a3081c3737f8a63f91214':
  Remove debug prints.
 2012-10-01 13:46:16 -07:00
Yuichiro Hanada
7f438aa12f Make writeCharGroup return a size of a new group. 
bug: 6669677

Change-Id: I56f6a07b04b08443f2c052927404318c2018fc9d
 2012-10-01 22:02:04 +09:00
Ken Wakasa
00e1d421c2 Merge "Add writeCharGroup." 2012-10-01 05:53:24 -07:00
Yuichiro Hanada
fb7e08ea8f Add writeCharGroup. 
bug: 6669677

Change-Id: I36792ba9c511a5148c963096cc93ca8c2e0ee04e
 2012-10-01 21:50:38 +09:00
Jean Chalard
574b80aace Remove debug prints. 
Bug: 7226098
Change-Id: Ibacb740022a6af56c9d555d6797dd402a89f6ca4
 2012-10-01 17:03:15 +09:00
Tadashi G. Takaoka
7339a62a13 Fix NPE observed only by monkey test 
Bug: 7258660
Change-Id: I286c704b32efeada8505d953438f2595166f7e8f
 2012-10-01 14:55:18 +09:00
Tadashi G. Takaoka
99501896f5 am 9925e487: am 6052a81e: Merge "Fix gesture detection algorithm" into jb-mr1-dev 
* commit '9925e487b345e4a63d3dc25e3bf156e0fbfbb04d':
  Fix gesture detection algorithm
 2012-09-28 06:54:04 -07:00
Tadashi G. Takaoka
58fe5a421f Fix gesture detection algorithm 
This change also
  * Introduces adaptive gesture detecting threshold for time domain in addition to length domain.
  * Tunes the parameters for detecting gesture after fast typing.
  * Fixes a bug in dismissing gesture floating preview text.
  * Cleanup debug messages

Bug: 7218902
Change-Id: Iafccd872c6efe0c3b5ae65fa40b04c80d9f139c7
 2012-09-28 22:47:55 +09:00
Yuichiro Hanada
f3aed3ea26 Add updateChildrenAddress. 
Change-Id: Ic06a755d85612476e719e580469dc1cd9447286c
 2012-09-28 18:45:56 +09:00
Yuichiro Hanada
7a7d117aa7 Ignore the broken file. 
bug: 7249561

Change-Id: If001bf75ef12b4d342a77e54706c7fed90c89afb
 2012-09-28 14:19:14 +09:00
Tadashi G. Takaoka
a28a05e971 Cleanup: Make some classes as final 
Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
 2012-09-27 19:03:30 +09:00
Yuichiro Hanada
84d858ed5e Use BinaryDictInputOutput to save UserHistoryDictionary. 
bug: 6669677

Change-Id: I08193c26f76dbd48168f8ac02c1b737525bfc7b2
 2012-09-27 12:02:17 +09:00
Yuichiro Hanada
2aea34fb31 Add updateParentAddress. 
bug: 6669677

Change-Id: I353f8ae53720cdf7a809271a28cb703709609f53
 2012-09-26 17:18:01 +09:00
Yuichiro Hanada
2ee70804e9 Add moved char groups. 
bug: 6669677

Change-Id: I372f841044fe8e076a50a80ac10b715e5f8fd4eb
 2012-09-26 17:01:48 +09:00
Yuichiro Hanada
a161bdac88 add capacity to FusionDictionaryBufferInterface. 
bug: 6669677

Change-Id: I4627093811a19c46ce13fe351d1db63cbd78cf4a
 2012-09-25 21:47:11 +09:00
Yuichiro Hanada
93d7c6233f Make getTerminalPosition read linked-list nodes. 
bug: 6669677

Change-Id: I599d276f430efe23d402695c325e23906b7705b3
 2012-09-25 21:11:15 +09:00
Yuichiro Hanada
8ec0064c49 Make children addresses and parent addresses use signed addresses. 
Signed addresses are used only in version 3 with dynamic update.

bug: 6669677

Change-Id: Iadaeab199b5019d2330b4573c24da74d64f0945e
 2012-09-25 12:55:14 +09:00
Jean Chalard
0eef4b1e6f Merge "Add suggestion span upon starting a gesture." into jb-mr1-dev 2012-09-24 04:30:32 -07:00
Jean Chalard
6a58bb7ac9 Add suggestion span upon starting a gesture. 
Bug: 7196761
Change-Id: If60cb809b205159ced1887f94b7caf9775fcf3bb
 2012-09-24 20:25:46 +09:00
Jean Chalard
88985bfa2e Merge "Fix a bug where the cursor pos wouldn't be tracked correctly" into jb-mr1-dev 2012-09-24 03:41:48 -07:00
Jean Chalard
72c5d32888 Fix a bug where the cursor pos wouldn't be tracked correctly 
This would cause
Bug: 7208199

Change-Id: I8474985bfe349e1530b27bc98842937627bbe4e0
 2012-09-24 19:33:42 +09:00
Jean Chalard
6efe788494 Set punctuation suggestions at start if activated 
Bug: 7218468
Change-Id: I9f8c1f13dc26cedb95b65279a34a825021dfa72a
 2012-09-24 17:27:03 +09:00
Jean Chalard
65ef26081b Merge "Fix a race condition with shift" into jb-mr1-dev 2012-09-23 23:48:20 -07:00
Jean Chalard
fff8613df0 Fix a race condition with shift 
Bug: 7062092
Change-Id: Ie1984673e9ffc9291d9650ec38ce99031ad93585
 2012-09-24 15:07:52 +09:00
Yuichiro Hanada
82d9deaaf2 Combine mHasParentAddress with mHasLinkedListNode into mSupportsDynamicUpdate. 
bug: 6669677

Change-Id: I82799af199358420f09ac34fc005091e202c5d3b
 2012-09-24 13:17:44 +09:00
Tadashi G. Takaoka
3088e0c9e9 Merge "Fix gesture start detection algorithm" into jb-mr1-dev 2012-09-21 01:51:57 -07:00
Tadashi G. Takaoka
02a67200fc Fix gesture start detection algorithm 
Bug: 7032858
Change-Id: I9f4d939fa87fdead4c5a5921338a16cd0a59b7ac
 2012-09-21 17:30:00 +09:00
Satoshi Kataoka
8ae8c76149 Cleanup settings 
bug: 7200189

Change-Id: Ibfd9254670cde5f4b2b693cc9334ee2845bede59
 2012-09-21 15:10:27 +09:00
Yuichiro Hanada
66597f5e5f Add deleteWord. 
bug: 6669677

Change-Id: I1a5b90ee05e5cffd74a5c140384a3e37c79e7e70
 2012-09-21 12:40:07 +09:00
Yuichiro Hanada
73779f7631 Make readUnigramsAndBigramsBinary read linked-list nodes. 
Change-Id: I07ae036b0b06e71d7a18f2bf11e4692cd4213568
 2012-09-20 20:37:02 +09:00
Yuichiro Hanada
d36245fad2 Add getTerminalPosition. 
Change-Id: If04d779db23b1aea2cc12e5e9b8cecfcb35a5737
 2012-09-20 18:02:16 +09:00
Jean Chalard
b4e74cfc87 Auto correct on gesture when typed word is 1 char long 
Bug: 7178462
Change-Id: I779d8ee4a957a9d1fdcc80d33257a98965dec7b8
 2012-09-20 16:14:16 +09:00
Tadashi G. Takaoka
bfcd2b3fc0 Merge "Change to "Show language switch key" option" into jb-mr1-dev 2012-09-19 19:56:59 -07:00
Tadashi G. Takaoka
1a4aa7e307 Change to "Show language switch key" option 
This change deprecates "Suppress language switch key".

Bug: 7037410
Change-Id: I1bc90877b4d2ee9364728959fd680dcb5b22ecbf
 2012-09-20 11:33:40 +09:00
Satoshi Kataoka
01a5a7d061 Merge "Clear cache of user dic" into jb-mr1-dev 2012-09-19 04:15:19 -07:00
Satoshi Kataoka
17f7b406aa Clear cache of user dic 
Change-Id: Iec2793de3fff7bf15f68f82a50331de7742b7049
 2012-09-19 20:11:45 +09:00
Tadashi G. Takaoka
567204a140 Merge "Show gesture floating preview text is off by default" into jb-mr1-dev 2012-09-19 03:00:40 -07:00
Tadashi G. Takaoka
4f8e451d0c Show gesture floating preview text is off by default 
Bug: 7043127
Change-Id: Icabf080f43a5934fef3824919bb03229522d5e5a
 2012-09-19 18:59:10 +09:00
Jean Chalard
caf15c3c67 Merge "Fix a bug that would persist caps lock state" into jb-mr1-dev 2012-09-19 02:30:49 -07:00
Satoshi Kataoka
8eb2065289 Merge "Log for geometric input" into jb-mr1-dev 2012-09-19 02:22:03 -07:00
Jean Chalard
ad0642cf25 Fix a bug that would persist caps lock state 
...with regards to suggestions. It's much simpler to look at
whether the word is actually all capitalized or not.

Bug: 7113544
Change-Id: Idc0e77b2f812964e650ade0e32b9d4c09228cb74
 2012-09-19 17:54:35 +09:00
Satoshi Kataoka
87cecf7db6 Log for geometric input 
Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f
 2012-09-19 17:45:27 +09:00
Yuichiro Hanada
65feee12e5 Make BinaryDictIOUtils. 
Change-Id: I45830235ee738233e8eb2bd91d659705b698f58c
 2012-09-19 15:37:37 +09:00
Yuichiro Hanada
c2fdf0dfbf Make readNode read linked list nodes. 
Change-Id: Ia5eaae0653179b2eb74c53b0823beaf80377a389
 2012-09-19 14:49:23 +09:00
Yuichiro Hanada
a149c53c8e add limit to FusionDictionaryBufferInterface. 
Change-Id: Ic9ff717a9751023d47b02ff3b9d1fbf3115c2501
 2012-09-19 12:28:19 +09:00
Jean Chalard
a0ebb28d15 Merge "Fix a bug with capitalizations (A15)" into jb-mr1-dev 2012-09-18 20:02:05 -07:00
Jean Chalard
3bf113f0ea Merge "Mark 2 resolved TODOS as such (A14)" into jb-mr1-dev 2012-09-18 20:01:31 -07:00
Jean Chalard
c9923430ed Merge "Support the gesture + phantom space case (A13)" into jb-mr1-dev 2012-09-18 18:36:13 -07:00
Yuichiro Hanada
b686df15fc Add a new flag for linked list nodes. 
Change-Id: Ib2f194775cfe5ab05481ac95cd709d6e8e8dd3c6
 2012-09-18 22:01:49 +09:00
Yuichiro Hanada
bf45dc4860 Make writePlacedNode write the linked-list node. 
Change-Id: I60feda815ea08cf73300fccca1ae12b97550f116
 2012-09-18 21:20:07 +09:00
Yuichiro Hanada
061d225fb1 Add a new option to FormatOptions. 
Change-Id: I8bf089bea5de46570a5e81fb1ea3ab22c07eeee1
 2012-09-18 21:03:13 +09:00
Satoshi Kataoka
e55785e682 New flag for the internal settings 
Change-Id: I81e69a6cda833a0d2c59a73388321ed11e0bd5b3
 2012-09-18 20:33:43 +09:00
Satoshi Kataoka
2040090b46 Merge "Log touch timing" into jb-mr1-dev 2012-09-18 04:32:52 -07:00
Satoshi Kataoka
f8b35b9b04 Log touch timing 
Change-Id: I45ce16c3194fac6da98486a986d23318347cad3a
 2012-09-18 19:26:25 +09:00
Jean Chalard
75b3f81fe1 Fix a bug with capitalizations (A15) 
When only one character has been typed, we should not take that
as a strong symbol that everything should be upper-cased.

Change-Id: I4e3a3223269e6763e3594baeaa844daa79a624ed
 2012-09-18 18:52:05 +09:00
Jean Chalard
e4783f95b2 Mark 2 resolved TODOS as such (A14) 
Change-Id: Ifbb731f5c825675436d079db4ffbae657d71f8da
 2012-09-18 18:49:17 +09:00
Jean Chalard
d461bfd660 Support the gesture + phantom space case (A13) 
Bug: 6950087
Change-Id: I198699f6e687ac74c35b9edfe469dce880d9ecaf
 2012-09-18 18:48:49 +09:00
Jean Chalard
717d4938b5 Merge "Remove useless code (A12)" into jb-mr1-dev 2012-09-18 02:42:36 -07:00
Jean Chalard
ed47131612 Merge "Fix a bug with surrogate characters" into jb-mr1-dev 2012-09-18 02:06:55 -07:00
Jean Chalard
6c721b5f68 Fix a bug with surrogate characters 
This is a pretty bad bug :/

Bug: 7013840
Change-Id: I12c7cfa4fa9d56b2c1fee6e6222c64fe20b88fa3
 2012-09-18 18:01:15 +09:00
Jean Chalard
b128b1cdfe Merge "Take space state into account for caps (A11)" into jb-mr1-dev 2012-09-18 00:21:48 -07:00
Jean Chalard
5822323514 Remove useless code (A12) 
All this code is done inside the StringUtils or RichInputConnection
classes, where it's more logical. Since the IPC call is entirely
gone now, it's no use having these guards inside Latin IME.

Change-Id: Id324567e7458aed12b6f21d7114be3bd39725f15
 2012-09-18 16:16:33 +09:00
Jean Chalard
90a9127244 Take space state into account for caps (A11) 
Bug: 6950087
Change-Id: I8a1bca24db64b4dd54db8ac74d90cf43cbdddab6
 2012-09-18 16:16:28 +09:00
Yuichiro Hanada
8adc0154e6 Remove populateOptions(final ByteBuffer buffer). 
Change-Id: Ifc4c64c9cffe4f343c5a604c192db010a1792acc
 2012-09-18 14:42:52 +09:00
Yuichiro Hanada
65e4970026 Fix hackCanUseDictionaryFile. 
Bug: 7169473

Change-Id: I575aaa350042af076a8da5756993cdae9e73422c
 2012-09-18 14:19:38 +09:00
Jean Chalard
252da38fcd Take locale into account for caps (A10) 
Bug: 4967874
Change-Id: Ic7ce7b2de088308fa00865c81246c84c605db1e5
 2012-09-14 19:42:05 +09:00
Jean Chalard
da8aca6002 Merge "Fix comment warnings (A9)" into jb-mr1-dev 2012-09-14 03:20:34 -07:00
Jean Chalard
32c8704c21 Merge "Remove an unused function (A8)" into jb-mr1-dev 2012-09-14 03:19:53 -07:00
Jean Chalard
5cb9b70a3a Merge "Fix abbreviations processing for English (A7)" into jb-mr1-dev 2012-09-14 03:14:21 -07:00
Jean Chalard
a3f06baa57 Merge "Do not auto-correct upon starting a gesture." into jb-mr1-dev 2012-09-14 03:11:51 -07:00
Jean Chalard
6e65ff8001 Fix comment warnings (A9) 
Thanks Eclipse

Change-Id: Ie2b83f1ec7ab38a76155f8c264e3944685ae934d
 2012-09-14 19:01:37 +09:00
Jean Chalard
50e61b8628 Remove an unused function (A8) 
Change-Id: I0578068946d32192c4faf14b3e86624b7301c7d9
 2012-09-14 19:01:37 +09:00
Jean Chalard
2c0d916287 Fix abbreviations processing for English (A7) 
It's still incorrect for non-English languages.

Bug: 4967874
Change-Id: I3d4379265f72e1c0435eba90ab878a80bbcf55ce
 2012-09-14 19:01:25 +09:00
Jean Chalard
b29efecd26 Merge "Fix a bug with open parens and some other chars" into jb-mr1-dev 2012-09-14 02:30:36 -07:00
Jean Chalard
7e4ad33a65 Fix a bug with open parens and some other chars 
A space would be inserted after an open parenthesis if
it's typed after a manual pick.

Bug: 7167687
Change-Id: Ic49d09c34747117ccfbdbb8c66f634d88d4a45b0
 2012-09-14 18:23:35 +09:00
Jean Chalard
e8db06fc02 Merge "Replace immediate values with named constants for characters (A6)" into jb-mr1-dev 2012-09-14 02:17:48 -07:00
Jean Chalard
d806065033 Merge "Simplification again (A5)" into jb-mr1-dev 2012-09-14 02:17:01 -07:00
Tadashi G. Takaoka
f035649cb6 Asynchronously look up dictionary for gesture input 
Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280
 2012-09-14 02:12:11 -07:00
Jean Chalard
eda096538b Do not auto-correct upon starting a gesture. 
We decided to revert this UI decision after negative feedback.
Indeed, if you use to gesture but tap just one word, chances
are it's because you know you do NOT want a dictionary word.

Bug: 6965241
Change-Id: I85fdfab3c1cf1d3c0fd3e95908e01bdf56bccbba
 2012-09-14 17:52:54 +09:00
Jean Chalard
35dc8cf223 Replace immediate values with named constants for characters (A6) 
Change-Id: I6248f9f3ff99003ab62be22eac673df0f7f5c015
 2012-09-14 16:59:50 +09:00
Jean Chalard
e94c276690 Simplification again (A5) 
Change-Id: Id3ba200e06244e6d13cf57d346001d61f85ef1a2
 2012-09-14 16:59:18 +09:00
Jean Chalard
6f8dfd92b1 Simplify the code some more (A4) 
Change-Id: I1b1763ceefda6357dc698195928d0f16bc425830
 2012-09-14 16:58:04 +09:00
Jean Chalard
33a226f897 Merge "Small simplification (A3)" into jb-mr1-dev 2012-09-13 19:53:14 -07:00
Yuichiro Hanada
cc958dd96e Refactor BinaryDictInputOutput. 
Change-Id: Idb4b635fcac70cc988e0dd3ce3bf121fba12099c
 2012-09-14 11:08:01 +09:00
Jean Chalard
5fbe3764ae Small simplification (A3) 
Change-Id: I2ea9566ce5cb1fbccd33a42836244a899365de6a
 2012-09-13 20:13:52 +09:00
Jean Chalard
d7fdc730c3 Merge "Simplify a call, and add comments (A2)" into jb-mr1-dev 2012-09-13 03:38:50 -07:00
Jean Chalard
3d54e1c1ec Simplify a call, and add comments (A2) 
Since the function has to be modified heavily but does a lot
of non-trivial work, add a wealth of comments explaining what
it does and why so as to facilitate understanding the changes
to come.

Bug: 4967874
Change-Id: I6c21aea15f161d807035f279dfb7d1b98b3e9144
 2012-09-13 18:59:04 +09:00
Jean Chalard
2427f578c8 Merge "Import TextUtils.getCapsMode to fix it internally (A1)" into jb-mr1-dev 2012-09-13 02:57:35 -07:00
Jean Chalard
378728920b Merge "Make onUpdateSelection much more resilient to race conditions." into jb-mr1-dev 2012-09-13 02:28:52 -07:00
Jean Chalard
9d1c73ffd8 Import TextUtils.getCapsMode to fix it internally (A1) 
This should have on effect at all on behavior,
except an increase in performance.

Bug: 4967874
Bug: 6950087
Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
 2012-09-13 17:46:39 +09:00
Jean Chalard
5ed88457bf Make onUpdateSelection much more resilient to race conditions. 
This is pretty much as strong as it gets. It should be
impossible to get false positives and nearly impossible to
get true negatives with this new code.

Bug: 6981089
Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
 2012-09-13 17:35:26 +09:00
Yuichiro Hanada
1a347723c5 Move FormatOptions and FileHeader to FormatSpec. 
Change-Id: I232e35598635113bf2c81825669c744aadc79efe
 2012-09-13 16:35:41 +09:00
Yuichiro Hanada
81d97eec0e Move constants and comments. 
Change-Id: Ifd66bda7d528827ba61c60531121ea206a2325be
 2012-09-13 14:28:39 +09:00
Jean Chalard
18fc3bf4c4 Merge "Make Latin IME aware of its surrounding text." into jb-mr1-dev 2012-09-12 02:07:48 -07:00
Jean Chalard
28d765ed90 Make Latin IME aware of its surrounding text. 
This is a preparatory change for
Bug: 4967874
Bug: 6617760
Bug: 6950087

Change-Id: I3abf8e45c0d02c42491421f108370220134b9602
 2012-09-12 17:54:16 +09:00
Yuichiro Hanada
8d031a63b4 Add put method to FusionDictionaryBufferInterface. 
Change-Id: Iac0b35d2da05e81237d105e8fe13c56d16038de1
 2012-09-12 15:41:21 +09:00
Jean Chalard
8c06a468e0 Stop auto-correcting non-whitelisted one-char strings 
Bug: 7134017
Change-Id: I75cf474dedafda3e1683dd8f7740c13aafdcf5ab
 2012-09-11 17:24:08 +09:00
Yuichiro Hanada
e55b644aef Add new binary dictionary format. 
Change-Id: Ia99411d4009857d5e420ca87ef8acf1f1826d3ed
 2012-09-10 13:05:46 +09:00
Ken Wakasa
60af4f03a8 Fix dicttool_aosp build 
Change-Id: Iabcf420b4120e3d275fdbcb23939a0ab6052ddf0
 2012-09-10 12:56:10 +09:00
Yuichiro Hanada
eae7b293e4 Check the length of the word when add to FusionDictionary. 
Change-Id: Id98d18e90a8b83b597507728b467f56888c8fd12
 2012-09-10 12:35:53 +09:00
Yuichiro Hanada
be5db53a09 Add tests for readDictionaryBinary with byte array. 
Change-Id: I2c2815e9d4867687fb3f5b0c661e6162b88c0a0c
 2012-09-06 20:35:33 +09:00
Yuichiro Hanada
83dfe0fd8c Add FormatOptions. 
Change-Id: Ibad05a5f9143de1156b2c897593ec89b0a0b07e7
 2012-09-05 18:05:43 +09:00
Jean Chalard
ac25fcac71 Display punctuation suggestions on cursor move 
...if punctuation suggestions are requested.

Fixes the symptom, but not the root cause of
Bug: 6981089

Change-Id: I683a7451c99457829cb4e5a762f43548ff89a535
 2012-09-04 19:54:55 +09:00
Ken Wakasa
2e4713a54e Merge "Check the length of the word when add to userhistory." into jb-mr1-dev 2012-09-04 02:36:35 -07:00
Tadashi G. Takaoka
848331222e Use string-array resource to define predefined-subtypes 
Bug: 6809603
Change-Id: Icafe4652ec17844838b28c04977deb88bcb9aa8f
 2012-09-04 17:18:39 +09:00
Yuichiro Hanada
dd435b305e Check the length of the word when add to userhistory. 
Change-Id: I7f2fe1771eed6b610704892b24f8a0283a779162
 2012-09-04 15:34:41 +09:00
Ken Wakasa
f2789819bd Cosmetic fixes and a bug fix in UnigramDictionary::testCharGroupForContinuedLikeness(). 
This change has actually been extracted from a change work in progress I4fe423834b8131fb122251892c98228a6e08ba25

Change-Id: I52568fa09da2ea22be7f8bfe9676b7cd73c31fa4
 2012-09-04 14:23:37 +09:00
Jean Chalard
8251036616 Match calls in I8a70e43b for Icbe60bdf 
Change-Id: I3a9eaaa018cd338ca8d9aa09c0fa58800b637e19
 2012-09-03 11:58:23 +09:00
Jean Chalard
2035b946a3 Merge "Reinstate the shortcut-only attribute" into jb-mr1-dev 2012-09-02 19:28:01 -07:00
Jean Chalard
72b1c93941 Reinstate the shortcut-only attribute 
Also add the blacklist attribute

Bug: 7005742
Bug: 2704000
Change-Id: Icbe60bdf25bfb098d9e3f20870be30d6aef07c9d
 2012-08-31 22:11:52 +09:00
Yuichiro Hanada
666a433802 add UserHistoryDictIOUtils. 
Change-Id: I8a70e43b23f65b5fd5f0ee0b30a94ad8f5ef8a8a
 2012-08-31 15:08:57 +09:00
Kurt Partridge
9bbc7ec052 Merge changes Ifb983c35,I0b947421 into jb-mr1-dev 
* changes:
  ResearchLogger clean up splash screen
  ResearchLogger no longer offers option to disable logging
 2012-08-30 22:56:53 -07:00
Kurt Partridge
58eb4d9f27 ResearchLogger no longer offers option to disable logging 
Bug: 6188932
Change-Id: I0b9474216080f3820438c09f89b0b6c6c102c69d
 2012-08-30 22:51:56 -07:00
Yuichiro Hanada
b2a43a2ed4 add readUnigramsAndBigramsBinary. 
Change-Id: I7967f11211221d4877bf0a0c30183af885f45390
 2012-08-31 14:39:19 +09:00
Tadashi G. Takaoka
35ff94547c Separate inner classes of keyboard package out under internal package 
Change-Id: Ia3969bd5ddec5aa5d81d05ad4cf676d818587922
 2012-08-30 15:37:55 +09:00
Jean Chalard
ded498d4a4 Merge "add readHeader." into jb-mr1-dev 2012-08-29 22:32:14 -07:00
Yuichiro Hanada
62ed901100 add readHeader. 
Change-Id: I5be5d62a63ca897e36fe93200ffdca6befb363aa
 2012-08-30 14:17:50 +09:00
Tadashi G. Takaoka
61bc66b324 Revert "Revert "Fix key letter size of 5-rows Thai keyboard"" 
This reverts commit 7a5ca9982f.
Depends: Ia4fa5046b3106e2710b9d5df1a6cc5f2cf995ec7

Change-Id: I0b9d0125380efe898943dc26ae884378145c44a3
 2012-08-30 11:30:13 +09:00
Tadashi G. Takaoka
b590d69e1f Merge "Revert "Revert "Move resource related methods to ResourceUtils""" into jb-mr1-dev 2012-08-29 19:29:37 -07:00
Ken Wakasa
d2a81ab9bd Merge "Add FusionDictionaryBufferInterface." into jb-mr1-dev 2012-08-29 18:49:03 -07:00
Tadashi G. Takaoka
92821614fd Revert "Revert "Move resource related methods to ResourceUtils"" 
This reverts commit bfc02a7005.

Change-Id: Ife4c0312ea3260211b1b5ee39b239e8e9d7db67e
Depends: I3d862515568be36d5aa80d12e7e5c0a9bf4d06a6
 2012-08-29 22:30:55 +09:00
Ken Wakasa
bfc02a7005 Revert "Move resource related methods to ResourceUtils" 
This reverts commit 160dc0f98e

Change-Id: Ic5a3d9c70b8f6f2993d8455799945ec2633cad66
 2012-08-29 04:33:39 -07:00
Yuichiro Hanada
f5c4ff4817 Add FusionDictionaryBufferInterface. 
Change-Id: I8640c994231d5f46bc6e074ce8a5bf5344fed0aa
 2012-08-29 19:27:49 +09:00
Tadashi G. Takaoka
160dc0f98e Move resource related methods to ResourceUtils 
Change-Id: I14535b030e58363315dd2daecaaef4edd6990cd9
 2012-08-29 17:51:07 +09:00
Tadashi G. Takaoka
1e11c44d1b Make utility classes final 
Change-Id: Ic4f69b4c8da33c9fca50d6829724179310c2f875
 2012-08-29 17:38:08 +09:00
Jean Chalard
4fa01ee570 Merge "Allow Latin IME to cancel smiley-auto-correct consistenly" into jb-mr1-dev 2012-08-29 01:18:15 -07:00
Jean Chalard
a05a0f2077 Allow Latin IME to cancel smiley-auto-correct consistenly 
This change makes Latin IME behave consistently with regards
to other auto-correction cancellations in cases of auto-correction
cancellation after smiley-triggered auto-correction. That is,
pressing the smiley key when the keyboard signals it's about to
auto-correct will get the auto-correction there plus a smiley,
and pressing backspace will cancel the auto-correction, and
pressing backspace again will delete the smiley.

Bug: 7067593
Change-Id: Ia7eef70a5d06b8b9afa1f1fbb0ed1dbc21a3059f
 2012-08-29 16:49:39 +09:00
Tadashi G. Takaoka
9879f65651 Add ResourceUtils 
Change-Id: Ia198f8d95eae8c007623cd52d73cc1528d22fee9
 2012-08-29 16:36:00 +09:00
Tadashi G. Takaoka
95c486cdf3 Merge "Move some methods from Utils to LocaleUtils class" into jb-mr1-dev 2012-08-29 00:35:27 -07:00
Tadashi G. Takaoka
0023a57eea Move some methods from Utils to LocaleUtils class 
Change-Id: I4a834549c2ea96ac30d7e2cb692d69af219cab1a
 2012-08-29 16:24:53 +09:00
Tadashi G. Takaoka
237f5e4f9b Remove unused methods from Utils class 
Change-Id: I209b75f1cca381610f25cd219f35ea62b9762be2
 2012-08-29 16:10:16 +09:00
Jean Chalard
43d3f0fa3b Merge "Auto-correct after smileys and gestures." into jb-mr1-dev 2012-08-28 01:59:20 -07:00
Tadashi G. Takaoka
ef2bfad590 Use TypedArray.getFraction to read percentile values in resource 
Change-Id: Ifc8b024d190efba4cd536fd639621e841eb9970e
 2012-08-28 15:18:40 +09:00
Jean Chalard
6c70b92003 Auto-correct after smileys and gestures. 
Bug: 6936790
Bug: 6965241
Change-Id: I1f61327eb5591960c280e425df9cd86b9c52f5d6
 2012-08-27 18:54:05 +09:00
Jean Chalard
5cc596160a Merge "Use ByteBuffer when reading FusionDictionary from file." into jb-mr1-dev 2012-08-23 21:56:02 -07:00
Yuichiro Hanada
d4fe7fda30 Use ByteBuffer when reading FusionDictionary from file. 
Change-Id: Ia71561648e17f846d277c22309ac37c21c67a537
 2012-08-24 13:31:08 +09:00
Tadashi G. Takaoka
64a26b4389 Fix bug in InputPointers.append 
Change-Id: I39825757bbae32b66c4b61cb6c4fbcaa2e0c9c47
 2012-08-23 17:59:08 +09:00
Tadashi G. Takaoka
64ee096100 Add toString method to InputPointers and ResizableIntArray 
Change-Id: I835ee131855bef8233cf2672e2fb288b939148a6
 2012-08-23 17:29:36 +09:00
Kurt Partridge
d573bad5bd Merge "ResearchLogging capture full n-gram data" into jb-mr1-dev 2012-08-22 10:41:10 -07:00
Tadashi G. Takaoka
50e7501722 Merge "Fix SubtypeSwitcher initialization path" into jb-mr1-dev 2012-08-22 01:02:04 -07:00
Tadashi G. Takaoka
9fc6af325e Fix SubtypeSwitcher initialization path 
This change also removes the reference of LatinIME from
SubtypeSwitcher.

Bug: 7026856
Change-Id: I78a266f3682b11f09b49bbcdcdb6aee713e6af37
 2012-08-22 16:05:34 +09:00
Kurt Partridge
bf653996ea ResearchLogging capture full n-gram data 
- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ic70ccb6c2e11eb02d887821434b44daa3eb7a3e2

Bug: 6188932
Change-Id: I731d6cff6539e997874f723b68bdb0d9b651b937
 2012-08-21 22:37:33 -07:00
Tadashi G. Takaoka
ecfbf4625c Add static construct method for SparseArray 
Change-Id: I6da97f6ea23578318f403bb5d64c30b1663c69ee
 2012-08-22 14:22:20 +09:00
Tadashi G. Takaoka
1f05cf6dab Remove GCUtils utility class 
Change-Id: Ia666aeb10c155d69763faf7f01ceca113b9b4653
 2012-08-22 12:34:22 +09:00
Tadashi G. Takaoka
f852891437 Merge "Remove KeyboardSwitcher reference from ResearchLogger" into jb-mr1-dev 2012-08-21 20:22:57 -07:00
Jean Chalard
07d485d705 Merge "Fix a silly bug." into jb-mr1-dev 2012-08-21 20:16:28 -07:00
Tadashi G. Takaoka
c3f78c9057 Remove KeyboardSwitcher reference from ResearchLogger 
Change-Id: I671a83c19977fda358c8e8a730e22ee155f65512
 2012-08-22 12:14:52 +09:00
Jean Chalard
32f6503a27 Fix a silly bug. 
This would prevent user history to work at all.

Bug: 7023638
Change-Id: I5d8867a07fb8859325d274e956ae667c094d0ac1
 2012-08-22 12:09:24 +09:00
Tadashi G. Takaoka
5f282ea9e4 Add CollectionUtils class to create generic collection easily 
Change-Id: I6b4de9187e122298e5e9cd8ddc9070d062df6a89
 2012-08-22 10:21:38 +09:00
Kurt Partridge
94e7f4bef9 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with I05496cfd762e9a41c42c50099143f1efc0a3d8a2

Bug: 6188932
Change-Id: I424abb2e437901262a9620255493916b7c3ff74b
 2012-08-21 17:13:36 -07:00
Jean Chalard
8b6b5592cb Merge "Treat all caps for gesture input." into jb-mr1-dev 2012-08-21 04:39:04 -07:00
Jean Chalard
324cc1dbe6 Merge "Tell the shift mode to the word composer." into jb-mr1-dev 2012-08-21 04:38:27 -07:00
Jean Chalard
1eba97d92f Treat all caps for gesture input. 
Bug: 6950087
Change-Id: I9f2271780600572c9befa96c7ad98494c554dd2b
 2012-08-21 20:29:53 +09:00
Jean Chalard
adbd9ae105 Tell the shift mode to the word composer. 
Bug: 6950087
Change-Id: Ifab9d6d075af398c6468d081216488712f8a53fb
 2012-08-21 20:27:42 +09:00
Tadashi G. Takaoka
ac78633be2 Rename and consolidate some constants 
Change-Id: I7863936cca18b28bf0117afcbcf544a5fd7f185d
 2012-08-21 17:54:53 +09:00
Tadashi G. Takaoka
6785b90727 Remove touch coordinate from pickSuggestionManually 
Change-Id: I33b1b4bc6fdfd263c4b2bb7125c07b4bddcf3c9f
 2012-08-21 17:13:45 +09:00
Kurt Partridge
48643b0e0d Merge "Revert "ResearchLogger log RichInputConnection"" into jb-mr1-dev 2012-08-20 10:18:40 -07:00
Kurt Partridge
adb591e75b Merge "Revert "ResearchLogging capture full n-gram data"" into jb-mr1-dev 2012-08-20 10:18:30 -07:00
Kurt Partridge
35c11842a7 Revert "ResearchLogger log RichInputConnection" 
This reverts commit 1964ffb3f4

Change-Id: Ie43e7ac828faa91e1824a255bb3ecf6c8222d4e8
 2012-08-20 10:17:45 -07:00
Kurt Partridge
3d35908749 Revert "ResearchLogging capture full n-gram data" 
This reverts commit 221e756fd7

Change-Id: Iefc4e4e27ddc925d4a4634627b0467bd4ee2a66e
 2012-08-20 10:17:40 -07:00
Kurt Partridge
752c53760c Merge changes I568c90d4,I4667f8f6 into jb-mr1-dev 
* changes:
  ResearchLogging capture full n-gram data
  ResearchLogger to track simple statistics
 2012-08-20 08:47:45 -07:00
Kurt Partridge
461f1942f9 Merge "ResearchLogger log RichInputConnection" into jb-mr1-dev 2012-08-20 08:47:33 -07:00
Tadashi G. Takaoka
cb2362cee1 Merge "Make some usages of SparseArray thread-safe" into jb-mr1-dev 2012-08-19 23:23:08 -07:00
Tadashi G. Takaoka
8ce351a827 Make some usages of SparseArray thread-safe 
This is a follow up of I39d9bf1a7c272eb16d6ed4698f52457579b40f10.

Change-Id: Ic3288e491175f9a85679a21064093f9db5a65466
 2012-08-20 15:00:26 +09:00
Jean Chalard
1aed102d4c Merge "Fix capitalization, part 1" into jb-mr1-dev 2012-08-19 22:29:59 -07:00
Jean Chalard
4c6db0592e Merge "Remove the whitelist dictionary." into jb-mr1-dev 2012-08-19 22:13:15 -07:00
Jean Chalard
04d6649d29 Merge "Remove access to the whitelist class." into jb-mr1-dev 2012-08-19 22:12:36 -07:00
Jean Chalard
13822d2b05 Hack to skip reading an outdated binary file. 
Bug: 7005813
Change-Id: Ie0d8d4b2d5eb147838ca23bdd5ec1cecd4f01151
 2012-08-20 13:56:52 +09:00
Jean Chalard
fb087a95f9 Fix capitalization, part 1 
The case this fixes is typing "Ah.\n" in gmail for example

Bug: 6950087
Change-Id: Ia4bf3a57dde49b9c9d47d315e9f85b7ffc7ee6e3
 2012-08-20 13:51:27 +09:00
Kurt Partridge
221e756fd7 ResearchLogging capture full n-gram data 
DO NOT MERGE

- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ie2bc79fd7fe6b951b24771e94b8d4ca21989af65

Bug: 6188932
Change-Id: I568c90d4af07e7c759c1e7fc64b716bd8c7b4ae5
 2012-08-17 21:44:07 -07:00
Kurt Partridge
1964ffb3f4 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with Ib71f841044ec1072610ab5638a5edfce29b7c05b

DO NOT MERGE

Bug: 6188932
Change-Id: I9ec7500a5b18bfe1a5a5bb1e5bf21c43351fc59e
 2012-08-17 21:44:06 -07:00
Ken Wakasa
e46d12927e Fix NPE in LatinIME.addToUserHistoryDictionary() 
bug: 7007063
Change-Id: Ie3e2f77dcbc597dda0c0df9a970336e5aac0edba
 2012-08-18 00:04:33 +09:00
Ken Wakasa
72c0f4de1d Merge "add reconstructBigramFrequency" into jb-mr1-dev 2012-08-17 03:19:12 -07:00
Yuichiro Hanada
c0a75c8ecb add reconstructBigramFrequency 
Change-Id: Iff20dcb9ca0d6064bb118247887fe24b812c0c61
 2012-08-17 19:05:16 +09:00
Jean Chalard
aa27635a8a Reword a confusing comment 
Bug: 7005645
Change-Id: Ifd942b3ce242aeeec512e132e1cee31329e994b1
 2012-08-17 17:22:28 +09:00
Jean Chalard
46fc768e54 Remove the whitelist dictionary. 
The functionality now lives in the binary dictionary.

This finalizes work on
Bug: 6906525

Change-Id: Id106d871e8afdf9afa886d2a30bea87ff89f2d24
 2012-08-17 15:13:10 +09:00
Jean Chalard
3e43e6998e Remove access to the whitelist class. 
...which becomes useless. It will be entirely removed in an
upcoming change.

Change-Id: I2f1d27f1eceda79454b01f21e057b98f2953131a
 2012-08-17 13:01:25 +09:00
Jean Chalard
228674f6c7 Merge "fix findWordInTree." into jb-mr1-dev 2012-08-16 18:54:24 -07:00
Yuichiro Hanada
0d35c159fe fix findWordInTree. 
Change-Id: I8f42df28f76188677db9d4e55885e1fc6a40b53f
 2012-08-17 10:23:01 +09:00
Jean Chalard
3083b4b77d Merge "Fix a debug method" into jb-mr1-dev 2012-08-16 17:59:11 -07:00
Jean Chalard
cc1062cfd0 Fix a debug method 
Change-Id: Icf78fb0d5f7caea78f053fffd1ecd4289629964a
 2012-08-17 09:24:45 +09:00
Ken Wakasa
bc44ad77e5 Merge "fix findWordInTree." into jb-mr1-dev 2012-08-16 04:26:55 -07:00
Yuichiro Hanada
66f338983b fix findWordInTree. 
Change-Id: I9d81c815494a0670afa81219ad7bad82274d997e
 2012-08-16 20:21:47 +09:00
Jean Chalard
91c64902b0 Merge "Refresh editor info when the text field attributes changes." into jb-mr1-dev 2012-08-15 02:35:21 -07:00
Jean Chalard
e234aed428 Refresh editor info when the text field attributes changes. 
For some reason we get a "restarting" flag from the browser
some times when the input field is different. The attributes
however are not the same, so we can detect that and reload
appropriately.

Bug: 6946793
Change-Id: I6762dae6f41db690497b026a707d9cc89c840b34
 2012-08-15 18:32:59 +09:00
Jean Chalard
cd0e004888 Merge "Ensure #offer always actually offers something." into jb-mr1-dev 2012-08-15 02:16:09 -07:00
Jean Chalard
653dbfb8ed Ensure #offer always actually offers something. 
This will allow remaining requests after a call to terminate
correctly.

Bug: 6963142
Change-Id: Iff67058bb8a39f2f1b468d3894861e8125de6659
 2012-08-15 18:10:10 +09:00
Satoshi Kataoka
3979f060f0 Step 28-A Introduce the session Id to getSuggestion 
Change-Id: I39d9bf1a7c272eb16d6ed4698f52457579b40f10
 2012-08-15 15:44:45 +09:00
alanv
0538493309 Fix the build. 
Change-Id: I744f6232e81981ab694d3d1e92bab5fd6efa46c0
 2012-08-14 15:34:29 -07:00
Charles Chen
dd7f79097a Merge "Change accessibility event type for app-driven speech." into jb-mr1-dev 2012-08-14 14:33:32 -07:00
Jean Chalard
e30c05800f Preemptive anti-deadlock device 
We don't know of any actual bug in the implementation of the
pool that may result in a deadlock, but this still implements
a means out of a deadlock if one ever arises anyway. It's
meant to improve the resilience of the spell checker.

Bug: 5441027
Change-Id: I689491090792dbb89110ee56631965c5bb2dc712
 2012-08-14 17:04:14 +09:00
Jean Chalard
5d6b8e1818 Fix a bug that would prevent spell checking 
java.lang.ArrayIndexOutOfBoundsException:
        [I offset=0 length=528 src.length=512
com.android.inputmethod.keyboard.ProximityInfo
        .setProximityInfoNative(Native Method)
com.android.inputmethod.keyboard.ProximityInfo
        .createSpellCheckerProximityInfo(ProximityInfo.java:85)
com.android.inputmethod.latin.spellcheck.AndroidSpellCheckerService
        .createDictAndProximity(AndroidSpellCheckerService.java:411)

The array was too small with respect with the passed size.

Change-Id: I7777d7aecd17375d3fbf82854a66eb7a5a289ce6
 2012-08-14 14:45:17 +09:00
Ken Wakasa
bcec82de66 Clean up constructors 
And, use C++ style casts and use float math functions rather than double ones to save memory space.

Also, stop using FloatMath and NativeUtils as standard Math methods are faster now.
See http://code.google.com/p/android/issues/detail?id=36199 and https://android-review.googlesource.com/40700

multi-project commit with I4259fb5ab8a15ac5760a7f04fc8f4c860529f04a

Change-Id: I0b81cff8c91769f7559a59b9528c75a5aabb4211
 2012-08-13 10:48:37 +09:00
satok
847c8dfe17 Fix JNI 
Change-Id: If134baf52e78fbe18b78611a23870f5d10c80955
 2012-08-11 13:54:01 +09:00
alanv
5f312c9c15 Change accessibility event type for app-driven speech. 
Bug: 6614400
Change-Id: I0ef309b7f3f35bf37b4664ea599c9e6ffb1a4ab8
 2012-08-10 13:51:17 -07:00
Ken Wakasa
f3850e5543 Use JNI Region calls also in getSuggestions() 
Change-Id: I9cc0208397c202aeb6f7b5bb5ad59e00c5afbd80
 2012-08-10 21:09:23 +09:00
Satoshi Kataoka
f6c2200890 Workaround to stop init dict traverse session 
Change-Id: I3d46c54a96a9fc0359ef75b9d2f8590b44164a8b
 2012-08-10 21:07:53 +09:00
Jean Chalard
7b258e512d Accept whitelisted entries from any source. 
...not only the WhitelistDictionary.

Bug: 6906525
Change-Id: I7f181eb6936ec17bbccdc4e736fd09292af24e9c
 2012-08-10 19:02:19 +09:00
Jean Chalard
caed149b67 Optimization & Simplification 
It's useless to do the whitelist lookup twice. Also, putting
this test out of this method will allow whitelist entries to
come from other sources.

Bug: 6906525
Change-Id: I4afe678cae6556d16642d155ce770fbf4e61ad49
 2012-08-10 19:02:15 +09:00
Jean Chalard
dc2fb6bc6d Merge "Pass the type from native code all the way to Java." into jb-mr1-dev 2012-08-10 01:26:59 -07:00
Jean Chalard
926ef06a1e Pass the type from native code all the way to Java. 
Bug: 6906525
Change-Id: I057390d47a223450e22d8338509e22c28fc0d5f6
 2012-08-10 15:51:55 +09:00
Satoshi Kataoka
e9f3e182e4 Add arguments for dic traverse session 
Change-Id: I8776ad528eeea9a5fc4dcf394ca13bb80c04fb6d
 2012-08-10 12:34:00 +09:00
Ken Wakasa
5bb4206275 Use more JNI Region calls 
Change-Id: I371db517ff4749c0b7e5bdb4362e6310c91a24dc
 2012-08-10 00:46:20 +09:00
Satoshi Kataoka
9d29871605 Add reset method for dic travserse session 
Change-Id: Ia3dd924f92549da2cf8302ef77c629902d4f275b
 2012-08-09 17:49:19 +09:00
Tadashi G. Takaoka
2be2d77664 Update dictionary availability at onStartInputView 
This is a follow up of I7901c0f9489b4deb79314c2c903b138611bfd78e

Change-Id: I38c22e886db247c402a964e3ddd10b09a461151c
 2012-08-09 16:09:54 +09:00
Tadashi G. Takaoka
9abea49dd4 Merge "Fix NPE and don't call UI API from non-UI thread" into jb-mr1-dev 2012-08-08 20:00:19 -07:00
Tadashi G. Takaoka
8335c59ea7 Fix NPE and don't call UI API from non-UI thread 
This change also reverts I29ec3e9f10484f30288fac76f0c45b3707bc2259

Bug: 6956969
Bug: 6891020
Bug: 6947253
Change-Id: I7901c0f9489b4deb79314c2c903b138611bfd78e
 2012-08-09 11:55:41 +09:00
Satoshi Kataoka
60d4961f34 Merge "Pass traverse session" into jb-mr1-dev 2012-08-08 07:50:44 -07:00
Satoshi Kataoka
9127811493 Pass traverse session 
Change-Id: I84bfaaa406e3f51421c08a7ee8f9576ebdba54d4
 2012-08-08 23:30:31 +09:00
Satoshi Kataoka
181567f9c7 Merge "Add traverse session" into jb-mr1-dev 2012-08-08 04:40:36 -07:00
Satoshi Kataoka
c4e4dfe17d Add traverse session 
Bug: 6942265

Change-Id: I384cf701f5ee44c4b1037e5b8ddfa3d570286f55
 2012-08-08 20:39:43 +09:00
Tadashi G. Takaoka
79eefda0d3 Add SuggestInitializationListener to BinaryDictionary.resetMainDict() 
Change-Id: I4c01f172ddb2ca60fa6e604384610c90b76e5457
 2012-08-08 15:55:26 +09:00
Tadashi G. Takaoka
27e48447a4 Lingering gesture floating preview text a bit 
Bug: 6936095
Change-Id: I873343e9aa6afdf6bdb223795f03232509b012a7
 2012-08-07 13:54:42 +09:00
Tadashi G. Takaoka
7a13975700 Cleanup unused import and dead code 
Change-Id: Ife877620561d29a8f25602916420741186104617
 2012-08-06 17:28:33 +09:00
Tadashi G. Takaoka
dba77186f7 Fix duplicate getSuggestions() call for main dictionary 
Change-Id: I092480063452505cdf03dbd83b9c64e535822931
 2012-08-06 17:08:38 +09:00
Tadashi G. Takaoka
b27959741a Fix Utils.getStackTrace() 
Change-Id: Iaf160af32bb77b3ad5929cb5ee8eccd01165bdf6
 2012-08-06 16:50:43 +09:00
Tadashi G. Takaoka
0a524de3df Separate updateSuggestionStrip from commitTyped 
The commitTyped() called updateSuggestionStrip(), and that led to call
Suggest.getSuggestedWordsForTypingInput() even after a batch input was
started because WordComposer.commitWord() reset the batch input state.

Bug: 6932442
Change-Id: If645b1ef0343aa1e21ca71a9275b40c6c3be13df
 2012-08-06 14:31:01 +09:00
Jean Chalard
15b28432ba Merge "Cleanup unused code" into jb-mr1-dev 2012-08-03 09:32:27 -07:00
Jean Chalard
8ee4b35c70 Cleanup unused code 
The Italian dictionary has been amended to contain words that
include apostrophes, and accordingly the apostrophe is now
excluded from word separators in Italian.
This code was only used for Italian, and in the general case
it does the wrong thing; it was only needed by limitations of
the old dictionary.

Bug: 6929108
Change-Id: I7ff4615e01899a1cebed2c4c51679cd0746740fe
 2012-08-04 01:15:04 +09:00
Jean Chalard
54e84a00fc Make a makedict command for dicttool (A3) 
This behaves exactly as the old makedict command. Further
changes will redirect the calls to makedict to this, so as
to consolidate similar code.

Groundwork for
Bug: 6429606

Change-Id: Ibeadbf48bec70f988a15ca36ebf5d1ce3b5b54ea
 2012-08-04 01:11:46 +09:00
Jean Chalard
3f80541844 Merge "Fix an OOB exception" into jb-mr1-dev 2012-08-03 07:17:37 -07:00
Jean Chalard
4c976aceee Fix an OOB exception 
Not sure exactly how this can happen, but at least this should
prevent us from crashing.

Bug: 6920884
Change-Id: I451864756b48c5cb5e98b06edee917d88766d77f
 2012-08-03 23:10:47 +09:00
Tadashi G. Takaoka
622d6a5b1b Using hardware accelerated drawing 
When Canvas has been hardware accelerated, don't use offscreen bitmap.

Bug: 6872994
Change-Id: I1121f76377991692bc29ebeedbfbfa1b2a12dbb7
 2012-08-03 20:46:10 +09:00
Ken Wakasa
fb955693d4 Enable hardware accelerated drawing for SoftInputWindow of LatinIME 
Taking advantage of Ib6a8bda46223ce1153f32834daf02a820d16136e

bug: 6872994
Change-Id: I799b25b6509980dd9f039bead9bc926b42cbb040
 2012-08-02 15:11:31 +09:00
Jean Chalard
f68fe7a9c9 Don't forward phantom space state on stripper input 
Bug: 6890540
Change-Id: I923b24e3bc17e7b923be4940ad739b58dca24a1f
 2012-07-31 01:48:10 +09:00
Tadashi G. Takaoka
ca57f5ba40 Move gesture preview parameters to KeyboardView attributes 
Change-Id: Iff9d6b485e202656fc869f3ff4d94575ad2c186f
 2012-07-30 20:10:48 +09:00
Tadashi G. Takaoka
47e2bf3298 Add advanced options to turn on/off the gesture trail and text preview 
Bug: 6883053
Change-Id: I601718afb37289108b45ef68626c7c315edca35d
 2012-07-30 15:54:27 +09:00
Jean Chalard
79d4c70b93 Merge "Don't auto-correct when there are digits." into jb-mr1-dev 2012-07-27 09:12:01 -07:00
Jean Chalard
e7c471a52f Don't auto-correct when there are digits. 
Bug: 6667462
Change-Id: I796655f57c71c9f50ae6e38dd08b71df3998dbcf
 2012-07-28 00:15:54 +09:00
Jean Chalard
6fc72cae20 Fix a bug with autocaps 
Port of Iece016f4

Bug: 6886405
Change-Id: I148c296d8a3841c40b6748e73ed2b0fff473b627
 2012-07-27 21:09:25 +09:00
Jean Chalard
aa906c36aa Handle correctly the restarting argument 
Bug: 6851364
Change-Id: Ie939a43b8527a76aec213b702d3d850717f22a81
 2012-07-26 21:57:15 +09:00
Tadashi G. Takaoka
941f222c21 Merge "Remove unused setProximityCorrectionEnabled() methods" 2012-07-25 19:54:40 -07:00
Ken Wakasa
e55d78ab0c Stop swallowing an UnsatisfiedLinkError 
Change-Id: I37d61274e1527229befabae2c392fd78e279b807
 2012-07-26 09:15:39 +09:00
Tadashi G. Takaoka
c4376db0f0 Remove unused setProximityCorrectionEnabled() methods 
Change-Id: I03aa6608ee435b36377de41684162b303740f571
 2012-07-25 20:37:36 +09:00
Tom Ouyang
2f81757c3a Add dynamic floating preview for incremental gesture recognition. 
Change-Id: I7ba7ac24aa96a0ff19267997c5b58853079bc6dc
 2012-07-25 19:40:55 +09:00
Tadashi G. Takaoka
0657b9698a Update gesture mode state when dictionary gets available 
Bug: 6860204
Change-Id: I840b7bf1983ab92fa4e0b180129176539e96409f
 2012-07-25 16:11:53 +09:00
Tadashi G. Takaoka
369e54cc33 Add Suggest initialization finish listener 
Bug: 6860204
Change-Id: I1e4c03c99415cd9bdea5a8556ff4093c33f0f508
 2012-07-25 09:55:22 +09:00
Tadashi G. Takaoka
506259396f Merge "Update gesture suggestions even when suggestions strip is off" 2012-07-23 03:45:21 -07:00
Tadashi G. Takaoka
7575ac7054 Update gesture suggestions even when suggestions strip is off 
Bug: 6852483
Change-Id: I873ae0f2e3bc863e989629f8bc0cc90ee33a4920
 2012-07-23 19:37:00 +09:00
Jean Chalard
c0f0ceeccf Merge "Fix a bug with the 'add to dict' hint popping up too much" 2012-07-23 03:20:01 -07:00
Jean Chalard
491d451e38 Fix a bug with the 'add to dict' hint popping up too much 
Not having a main dictionary is not sufficient reason to display
the hint. If the user already added the word to the dictionary then
we shouldn't be displaying it again, even if we don't have a main
dictionary for the current language.

Bug: 6829798
Change-Id: I6b081f51c82ef395fe2e394fd3167363e743ea6f
 2012-07-23 18:32:13 +09:00
Tadashi G. Takaoka
259905ba90 Rename suggestion strip related methods 
Change-Id: I942692bbc2e577482f353d875405c4658a1102fc
 2012-07-23 18:04:02 +09:00
Tadashi G. Takaoka
4702671ea4 Rename SuggestionsView to SuggestionStripView 2012-07-23 15:37:43 +09:00
Tadashi G. Takaoka
c8e45ddb03 Rename LatinKeyboardView to MainKeyboardView 
Change-Id: I8f3123b8d727c7beb72e226f80c17794f89c8b60
 2012-07-23 12:11:43 +09:00
Kurt Partridge
3c233bf1a5 ResearchLogger feedback form 
- also cleaned up RLog menu

multi-project commit with If0fd4fef89d390073e6939d5188ed5696866cb33

Bug: 6188932
Change-Id: I4f66f13bd366b4e8bde742ccd0704f812c6d33f9
 2012-07-22 18:36:24 -07:00
Kurt Partridge
6b966160ac ResearchLog refactor 
- new package: com.android.inputmethod.research

multi-project commit with Ic0a5744f3160d13218addd589890623c0d120ffc

Bug: 6188932

Change-Id: Icf8d4a40a5725401799be6e209a640d99a5f34c4
 2012-07-20 15:06:51 -07:00
Tadashi G. Takaoka
7519091f7c Use ResizableIntArray in GestureStroke 
Change-Id: I034e80df03c7c6c0895fdf2c03763627d410d425
 2012-07-20 19:32:28 +09:00
Tadashi G. Takaoka
62b8dddb6d Add gesture input enable settings 
Bug: 6845325
Change-Id: I3165465b0b280e32a9288da16abb75baa67288dc
 2012-07-20 19:26:36 +09:00
Tom Ouyang
528738341d Merge "Add gesture trail feedback." 2012-07-20 01:26:30 -07:00
Tom Ouyang
4daf32b6c0 Add gesture trail feedback. 
Change-Id: I32709fac0dec3165678a052aa286e2fb3d90721b
 2012-07-20 17:09:23 +09:00
Tadashi G. Takaoka
2f6a90ac31 Merge "Implement ResizableIntArray.fill" 2012-07-20 00:33:07 -07:00
Tadashi G. Takaoka
7abdcf1ed3 Implement ResizableIntArray.fill 
Change-Id: I570641bc2f32d016c247db6c065a138d8235ab8c
 2012-07-20 16:05:37 +09:00
Tadashi G. Takaoka
732edc1ff1 Merge "Fix NPE where the current subtype is null" 2012-07-19 22:57:39 -07:00
Tadashi G. Takaoka
d6a18cdedb Fix NPE where the current subtype is null 
Bug: 6847999
 2012-07-20 14:51:41 +09:00
Kurt Partridge
48ded4e3b1 Merge "ResearchLogger: make logging more reliable (esp on startup)" 2012-07-19 21:31:41 -07:00
Tadashi G. Takaoka
c49c85f835 Implement ResizableIntArray.setLength and .get 
This change revises ResizableIntArrayTests as well.
 2012-07-20 12:02:38 +09:00
Kurt Partridge
0df487678e ResearchLogger: make logging more reliable (esp on startup) 
Bug: 6188932
Change-Id: I692e427ba2e6da7bb15f48208304c4a034392a22
 2012-07-19 09:00:21 -07:00
Tadashi G. Takaoka
9370ab9ada Make ScalableIntArray public as ResizableIntArray 
Change-Id: Ibbbc117214912ffa192c694bde5b7d55154f40c4
 2012-07-19 20:37:53 +09:00
Tadashi G. Takaoka
57f7de0ba6 Add default capacity parameter to InputPointers' constructor 
Change-Id: I02f23096f0682d30effe4dfc1ca57881a1e4aedc
 2012-07-19 12:06:00 +09:00
Tadashi G. Takaoka
9580c467f9 Consolidate GestureTracker into PointerTracker 
Change-Id: Ib28fae10493a9142ba4dff6cf57f52c59766b209
 2012-07-18 20:11:06 +09:00
Tadashi G. Takaoka
10102f02af Change the batch input methods of KeyboardActionListener 
This change also removes the reference of SuggestedWords from
GestureTracker and KeyboardActionListener.

Change-Id: I25ef8756007986abf99a931afd665bbfe6fa387f
 2012-07-18 18:53:36 +09:00
Kurt Partridge
5e53542489 Merge "delete old ResearchLog files" 2012-07-16 09:41:10 -07:00
Kurt Partridge
81dae8d015 delete old ResearchLog files 
cleans out the local directory of files that may have persisted
accidentally because of system crashes, etc.  default lifetime is
curently 1 day.

Bug: 6188932
Change-Id: I4b51169d6dd0eddb6bf8b661165f88e63782ce7d
 2012-07-13 20:25:38 -07:00
Kurt Partridge
73c5dbd9d2 researchLog records versionCode, versionName 
Bug: 6188932
Change-Id: I3d8502a5397035be5287ea720599e3fda4c669d6
 2012-07-13 20:21:18 -07:00
Tom Ouyang
eea34598bf Merging minimal gesture input 
Change-Id: Iee6ae48bb6309c2867b5d2e344fe7d86dfabd654
 2012-07-13 19:32:18 +09:00
Jean Chalard
e9808694fe Fix a bug where the word composer is not correctly reset 
...upon commit

Change-Id: I1fea87cb4c133a0884329eb9b61bf3053c36cd1b
 2012-07-13 13:31:27 +09:00
Tadashi G. Takaoka
7247bff6d6 Fix InputPointers.append 
Change-Id: I6995f9b2ed00b9f948e1299e576a5e24725d58f8
 2012-07-13 11:46:03 +09:00
Jean Chalard
c7387a4fd0 Add values for suggestion types (A120) 
Also, use it in getBigrams.

Change-Id: Ia0be9b57d1b7effcd8a936e01e957d1195b39c68
 2012-07-12 19:21:44 +09:00
Jean Chalard
6931df9c17 Pass an array to output suggestion types (A119a) 
This needs the matching A119b change to not break the build.
The array is passed, but not used yet.

Bug: 6166228
Change-Id: Ia91d658461d989ee8c94e9b31bb06f4a36f4c5b6
 2012-07-12 19:21:42 +09:00
Jean Chalard
2c5cf744e5 Increase encapsulation (A118) 
showSuggestions is only ever called by updateSuggestionsOrPredictions.
It only feels natural that, when called with a 0-sized or null
suggestion list, it clears the suggestions.

Change-Id: I5b52bc9151afca1bb6c6f0a7f81e3255add92177
 2012-07-12 15:58:16 +09:00
Jean Chalard
1343d27de3 Readability improvement (A117) 
Change-Id: I6f8bb05a23edb40a079da60b7136170ec9043282
 2012-07-12 15:58:16 +09:00
Jean Chalard
24a63b5537 Simplification (A116) 
Change-Id: I97cf92a7b0dabc251dd241b24978ea00d1e5f047
 2012-07-12 15:58:16 +09:00
Jean Chalard
f5b55cb70c Compute variables closer to where they are used (A115) 
This improves locality, it's better for readability/performance

Change-Id: Ibb1efaf86e362dd2c9398722d0da2144df96b333
 2012-07-12 15:58:09 +09:00
Jean Chalard
2549b4978e Cleanup (A114) 
Change-Id: I7e24e0aeae7c004cae310ae9f46cf90dac2d4d14
 2012-07-12 15:09:57 +09:00
Jean Chalard
02f1c1534c Cleanup (A113) 
If not composing a word, then consideredWord is always the empty
string.
Hence, it's never whitelisted, but it's also always "NotAWord",
so isWhitelistedOrNotAWord returns always true, so
allowsToBeAutoCorrected is always true. Which means that
isPrediction implies allowsToBeAutoCorrected == true.
Thus, !isPrediction && !allowsToBeAutoCorrected is strictly
equivalent to !allowsToBeAutocorrected.

Change-Id: I4ad7a7c3447851c539646d97cf55ff065e6ee115
 2012-07-12 15:09:48 +09:00
Jean Chalard
ae13061245 Simplification (A112) 
If we are not composing a word, that isFirstCharCapitalized
and isAllUpperCase are guaranteed to return false.

Change-Id: Ic4a0be9574acf4653c729a9594f963f5bcf0c757
 2012-07-12 14:30:33 +09:00
Jean Chalard
d8afa2fbe1 Remove the ultimate code duplication (A111) 
Change-Id: I7c76613df8f148feb02765f187db3ca6dc577977
 2012-07-12 14:30:33 +09:00
Jean Chalard
3b57631b60 Resolve a TODO: bury some implementation detail in native (A110) 
The fact that prediction does not accept a null argument is an
implementation detail, it should not be visible to Java code.

Change-Id: I3a156b323b6db9353de898d33f3f7c81751cecb1
 2012-07-12 14:30:30 +09:00
Jean Chalard
18d76afa91 Remove an unused method (A109) 
Change-Id: Ib785b7e8c554d030395e2c0ca92edb44eb2b245f
 2012-07-12 14:30:03 +09:00
Jean Chalard
251f302985 Stop using a redundant method (A108) 
Change-Id: Iffc0bae0a273419e7c50d69526c0c8e402c6461c
 2012-07-12 14:30:00 +09:00
Jean Chalard
6a5d17cd2f Remove a useless parameter (A106) 
Change-Id: Ic0ecea22212fd1a098a3a168da460374e446f4a3
 2012-07-12 11:28:16 +09:00
Jean Chalard
b7d7c5a369 Make a constant really constant (A104) 
Change-Id: Ied1f9f96a574b1e6a8ee0a71bfb1604d9c962e1c
 2012-07-12 11:16:30 +09:00
Jean Chalard
e4e7e5fc82 Cleanup (A103) 
Change-Id: Ib5ebddfdb87ef71a2f8d859fb45d3ac78040e97a
 2012-07-11 16:14:58 +09:00
Tadashi Takaoka
5e21ea1a35 Revert "Workaround to avoid a bug in the batch input bigram dictionary lookup" 
This reverts commit 1250cdeab2
 2012-07-11 00:07:08 -07:00
Tadashi G. Takaoka
1250cdeab2 Workaround to avoid a bug in the batch input bigram dictionary lookup 
Change-Id: I8a5641c88c45918d6bed81a0b03efdcff0b380c5
 2012-07-11 15:38:13 +09:00
Jean Chalard
9c09fd02eb Inline a method to be able to factorize code (A102) 
Change-Id: I121071f80c8af3c1053968dc76aaeca3352ca9a8
 2012-07-11 14:57:51 +09:00
Jean Chalard
d6c610400e Inline a wrapper method (A101) 
Change-Id: I6ce856ff49a8f8c696851b2487590704010fc758
 2012-07-11 14:57:51 +09:00
Tadashi G. Takaoka
eb1443883f Support batch input 
Change-Id: Ibe63212fe71cdebb5b897bc5018ae75b2a87555a
 2012-07-11 14:53:20 +09:00
Jean Chalard
21e5759e8e Merge "Small readability improvement (A100)" 2012-07-10 22:49:25 -07:00
Jean Chalard
27207eaa04 Merge "Pull up some common code again (A99)" 2012-07-10 22:49:06 -07:00
Jean Chalard
722b00275d Merge "Pull up some identical code (A98)" 2012-07-10 22:48:58 -07:00
Jean Chalard
8b166465b0 Merge "Inline a method to avoid confusion (A97)" 2012-07-10 22:48:52 -07:00
Jean Chalard
fd9b485111 Merge "Remove parameters for easier inlining (A96)" 2012-07-10 22:48:44 -07:00
Jean Chalard
0b329fd0d1 Merge "Pull up some more common code (A95)" 2012-07-10 22:48:38 -07:00
Jean Chalard
a5acd68caa Merge "Pull up common code in the caller (A94)" 2012-07-10 22:48:33 -07:00
Kurt Partridge
0d54692ce4 Merge "intentional logging" 2012-07-10 21:20:47 -07:00
Jean Chalard
82d5ed6fcd Small readability improvement (A100) 
Change-Id: I6340748654a95d203ed43ceb9a7e6468b5b8ab1c
 2012-07-11 11:19:50 +09:00
Jean Chalard
860a9f85ff Pull up some common code again (A99) 
Change-Id: I9e9f5664bb12bb25d74c8a076a6ee1024c708145
 2012-07-11 11:19:50 +09:00
Jean Chalard
8eaeb60e7f Pull up some identical code (A98) 
Change-Id: I6c265956394cf49e74b0256dfa5af06fe6b30467
 2012-07-11 11:19:33 +09:00
Jean Chalard
e77f2996ea Inline a method to avoid confusion (A97) 
Change-Id: I3c3ffcd3d40493f4bfa0f6596f923b3430e605aa
 2012-07-11 11:19:18 +09:00
Jean Chalard
cfae32c610 Remove parameters for easier inlining (A96) 
Change-Id: Ied2e291393609300173681e26e82b7dd36b41bd0
 2012-07-11 11:16:22 +09:00
Jean Chalard
ea98e026f1 Pull up some more common code (A95) 
Change-Id: I3ac7ee823471a6d1da8031e064bce38b0e5a8f5c
 2012-07-11 11:15:18 +09:00
Jean Chalard
b4b93dbf3e Pull up common code in the caller (A94) 
Change-Id: I84b97886280eca75d5f2b7546f20f8b1bced55bc
 2012-07-11 11:13:56 +09:00
Kurt Partridge
223d671ffc intentional logging 
- separate ResearchLog from ResearchLogger
- fix abort menu to explicitly indicate re-enabling of logging
- auto flush entries every 5s
- conform to new suggestedWords class

multi-project change with I9fe1f8fe59d5891daa4ca84af157f36fb1bb17dc

Bug: 6188932

Change-Id: I7e99390f934481c6ed9cea2b259944583edda5bb
 2012-07-10 18:44:18 -07:00
Jean Chalard
6f233f7ba1 Remove useless member variables (A93) 
Change-Id: Iff0a0e8835f4d630b51a15c0d91881437094e785
 2012-07-10 20:18:10 +09:00
Jean Chalard
2ae75ed56b Start converging two identical methods (A92) 
Change-Id: I3c85a80610fde664a328f5606d0724f00d445ebe
 2012-07-10 20:13:54 +09:00
Tadashi G. Takaoka
d82dcdc924 Add batch input dictionary lookup 
Change-Id: I4da3c976838e8eb56c9ec80aafaaf54d759b7981
 2012-07-10 20:01:28 +09:00
Jean Chalard
5e573a1f0a Remove a useless parameter (A91A) 
Change-Id: I1d1758048649ef337875a5141d825569af7ad38c
 2012-07-10 19:31:36 +09:00
Jean Chalard
f5943153ad Cleanup old methods (A90) 
Change-Id: I5435cef8ac6be523934ffa394952cb120c8e89d6
 2012-07-10 19:30:46 +09:00
Jean Chalard
b30d2185f2 Implement the common Dictionary interface (A89) 
This will de-duplicate a lot of existing code.

Change-Id: Idaffb2fde23b9741f057bcb2ecb3dde9d12ea5c5
 2012-07-10 19:30:42 +09:00
Jean Chalard
a69f12a246 Reduce method visibility (A88) 
Change-Id: I29d6afbcba0998558c9b19287a460d9f0e410994
 2012-07-10 19:19:47 +09:00
Jean Chalard
0f57bdc0e5 Factorize code (A87) 
Why was this copy-pasted :(

Change-Id: I6a537c56425ad039d7301a5fe1e0485784f07914
 2012-07-10 19:19:43 +09:00
Jean Chalard
4e42e378fa Move stuff around for readability (A86) 
Change-Id: I5f4a18e43f3012acf96978d625325bf7c69c9c80
 2012-07-10 18:57:57 +09:00
Jean Chalard
82009901ea Add a consolidated method to the Dictionary interface (A85) 
Change-Id: I5d79021e69cc738e3013e31764ab0a59e15decdf
 2012-07-10 18:57:12 +09:00
Jean Chalard
2a37fb9d30 Refresh the cached single quotes count on commit 
Change-Id: I9df5cf95c14da2e11ac709ca5e32dc7db3b02c37
 2012-07-10 18:43:42 +09:00
Jean Chalard
a9632d8173 Merge "Enhance behavior consistency (A84)" 2012-07-10 02:31:40 -07:00
Jean Chalard
184c552917 Merge "Refactoring for whitelist (A83)" 2012-07-10 02:24:58 -07:00
Jean Chalard
b53e96813c Merge "Refactoring (A82)" 2012-07-10 02:24:47 -07:00
Jean Chalard
50d1b7902f Merge "Fix a bug with suggestion behavior (A81)" 2012-07-10 02:24:36 -07:00
Jean Chalard
a4d346c37a Merge "Cleanup visibility in LatinIME (A80)" 2012-07-10 02:21:46 -07:00
Jean Chalard
c677b0071d Enhance behavior consistency (A84) 
Use the word the same way for suggestion and prediction. It makes
little logical sense that the trailing single quotes be removed
for suggestion lookup but not for prediction lookup.

Change-Id: I0de4b5f7c5b4c1b4ba1817ff9653d7c03967146d
 2012-07-10 18:05:20 +09:00
Jean Chalard
1c6693a219 Refactoring for whitelist (A83) 
Avoid special casing the whitelist dictionary by having it implement
the interface it pretends it implements

Change-Id: I8b873cb0f3fe13cefd32c8cb756a25c8ae16a2b4
 2012-07-10 18:05:20 +09:00
Jean Chalard
fb6eeeb35a Refactoring (A82) 
The user history dictionary should be the one knowing it does not suggest words
beyond 2 characters, not Suggest.

Change-Id: Ie85ec6116eb495e0c7f51108e4620c5ae536f4bf
 2012-07-10 18:05:20 +09:00
Jean Chalard
966efe4889 Fix a bug with suggestion behavior (A81) 
Bug: 6788235
Change-Id: I5a4212872e0fd3f9e80168fd3abd5c2b3bc4110f
 2012-07-10 18:05:19 +09:00
Jean Chalard
a5bb353de9 Cleanup visibility in LatinIME (A80) 
Many methods were public but could have been private: change them
to private. Also, add a comment above public methods that don't
come from the IMF to make it clearer why they are necessary.

Change-Id: I574154b015d09c0f8542b81763f497691afdc3c1
 2012-07-10 18:05:15 +09:00
Satoshi Kataoka
7fcad7b9b6 Separate ICS-dependent code from the spell checker service 
Bug: 6789576
Change-Id: Ia768258f6fa121c7a7757093eb8a20e665580865
 2012-07-10 17:45:26 +09:00
Jean Chalard
b98414f8fd Merge "Remove useless code (A79)" 2012-07-10 00:47:56 -07:00
Jean Chalard
29540b25f0 Merge "Simplification (A78)" 2012-07-10 00:47:10 -07:00
Jean Chalard
728c0cb251 Remove useless code (A79) 
We postUpdateSuggestionStrip right away anyway - this only
makes the suggestion strip blink

Change-Id: I2ebd933e9a4c804ef1e8c62ccdaf4953a98a792e
 2012-07-10 16:41:49 +09:00
Jean Chalard
09fdd30e52 Simplification (A78) 
Change-Id: I622503af858ef419e94a17f182253cb03da00462
 2012-07-10 16:41:47 +09:00
Satoshi Kataoka
74620f449e Merge "Create AndroidSpellCheckerSessionFactory" 2012-07-10 00:26:00 -07:00
Satoshi Kataoka
37b19ffe6c Create AndroidSpellCheckerSessionFactory 
Bug: 6789576
Change-Id: I6de1e1aa64cf14f38ecb250579418bc518f0d838
 2012-07-10 16:16:53 +09:00
Satoshi Kataoka
759778a751 Merge "Separate SpellCheckerSession from SpellCheckerService" 2012-07-09 23:42:15 -07:00
Satoshi Kataoka
84ed096641 Separate SpellCheckerSession from SpellCheckerService 
Bug: 6789576
Change-Id: I7c55d36afad7ef6046353b3c9e849a54a6dc83ae
 2012-07-10 15:34:40 +09:00
Jean Chalard
fed702a0ad Merge "Move a test (A77)" 2012-07-09 23:01:33 -07:00
Jean Chalard
75e605f7ca Merge "Pull up common code in the consolidated method (A76)" 2012-07-09 22:41:33 -07:00
Jean Chalard
c466cd3f99 Move a test (A77) 
Change-Id: I417bd5f1318696aaa39fee18f3e750ea5c231f6b
 2012-07-10 14:24:33 +09:00
Jean Chalard
32f5384fc9 Pull up common code in the consolidated method (A76) 
Change-Id: I3ebecec37b49e139c243cf9da8bfe491e7ddada1
 2012-07-10 14:22:12 +09:00
Tadashi G. Takaoka
80973dc76f Merge "A little optimization of InputPointers.copy" 2012-07-09 21:09:13 -07:00
Tadashi G. Takaoka
2ad6d12a30 A little optimization of InputPointers.copy 
Change-Id: Id83b34e076ef91e06d7c1dd2b3ee7bb64d01b8cb
 2012-07-10 13:05:43 +09:00
Jean Chalard
24e8a06f98 am 949d2ae5: am 4bcf70c9: Fix a bad interaction with mmap 
* commit '949d2ae5788977c5e87e35e1bd1770f54ac88f5b':
  Fix a bad interaction with mmap
 2012-07-09 20:24:01 -07:00
Tadashi G. Takaoka
7389c601e3 Merge "Add InputPointers.append() method" 2012-07-09 01:39:38 -07:00
Tadashi G. Takaoka
1087c53f5a Add InputPointers.append() method 
Change-Id: Id2b0e242f7e9ce0ca888067857f8b64c02fde84e
 2012-07-09 17:33:10 +09:00
Jean Chalard
e4498929b0 Simple refactoring (A75) 
Change-Id: Id19efc5d279616da52667fa70326b86aba70d4a0
 2012-07-09 15:06:16 +09:00
Jean Chalard
d579f1aefc Consolidate methods that do the same thing (A74) 
Change-Id: I6e7c3aba2b40ecefa483c9680978bc806368e96e
 2012-07-09 15:06:16 +09:00
Jean Chalard
347a80f793 Tiny refactoring (A73) 
If !mWordComposer.isComposingWord(), then mWordComposer.getTypedWord()
will always return an empty string.

Change-Id: Ife66d0abc44c743cbc30d31724e833cda168fd5c
 2012-07-09 15:06:16 +09:00
Jean Chalard
7a422a0142 Cleanup again (A72) 
Change-Id: Id3765bf9826cc2c7ca70158cda53c75dc58f51c6
 2012-07-09 15:06:16 +09:00
Jean Chalard
37eaa24b5a Simplification (A71) 
Change-Id: I7a91d84291bea581ecc8ec5b29b9a87ccec76e7d
 2012-07-09 15:06:16 +09:00
Jean Chalard
dc1b84d96c Defer testing composition to a later time (A70) 
This is not exactly the same logically speaking, because it's
theoretically possible that the composing state changed in between
the message enqueueing and it's retrieval. However in the practice,
if the composing state changed the message *must* have been
cancelled and resent, else the behavior breaks. So this actually
is more robust, and removes some obscure requirements on the
calling code.

In the practice, it should also make the cancelUpdateSuggestionStrip
message useless, although this change does not yet remove it.

Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
 2012-07-09 15:06:16 +09:00
Jean Chalard
a6757f400a Code simplification (A69) 
Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
 2012-07-09 15:06:16 +09:00
Jean Chalard
8f9c9377fc Consolidate two methods (A68) 
Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
 2012-07-09 15:06:15 +09:00
Jean Chalard
146bd2e456 Pass the value we really want to pass to update functions (A67) 
Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
 2012-07-09 15:06:15 +09:00
Jean Chalard
60dbe0be43 Preparative change to pass a boolean with known value (A66) 
Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
 2012-07-09 15:06:15 +09:00
Jean Chalard
853f4221ab Merge "Remove useless processing (A65)" 2012-07-08 23:05:11 -07:00
Tadashi G. Takaoka
6b4ce58fc6 Remove unused WordComposer.init method 
Change-Id: I46c6a6e1c1536599cb909bf81297001b238f2ec8
 2012-07-06 20:12:14 +09:00
Tadashi G. Takaoka
36311cacd6 Merge "Extend onTextInput to be able to inject suggestions" 2012-07-06 03:40:03 -07:00
Tadashi G. Takaoka
4be03befe3 Extend onTextInput to be able to inject suggestions 
Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
 2012-07-06 19:36:11 +09:00
Jean Chalard
a3dee0d062 Merge "Fix a bug where spaces would be forgotten" 2012-07-06 02:09:28 -07:00
Jean Chalard
4fde56b818 Fix a bug where spaces would be forgotten 
Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
 2012-07-06 17:51:10 +09:00
Jean Chalard
8e36e5102e Remove useless processing (A65) 
We just resetted the composing state - updating suggestions
is sure to yield no results. We may as well not call
updateSuggestions at all.
We should however still cancel any lingering timer from a
previous input field, to avoid this useless processing.

Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
 2012-07-06 16:28:42 +09:00
Jean Chalard
449be371ae Refinement (A64) 
Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
 2012-07-06 16:28:42 +09:00
Jean Chalard
43193ad60f Remove useless code (A63) 
If the separator is not a space, then we will always call
setPunctuationSuggestions and reset the suggestion strip anyway.
If the separator is a space, then the cursor has a space on
the left, which means isCursorTouchingWord depends only on
whether it touches a word on the right. If we were displaying
the "add to dictionary hint", it means a suggestion was just
chosen, so it had to be displayed, and that requires a composing
word and no non-separator at the right of the cursor.

In the end, if we go through this postUpdateSuggestions call,
we are sure we will reset the suggestions later in this method,
either by calling postUpdateBigramPredictions, or
setPunctuationSuggestions.

Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
 2012-07-06 16:28:42 +09:00
Jean Chalard
8ba33c1a49 Simplification (A62) 
Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
 2012-07-06 16:27:55 +09:00
Jean Chalard
66a2e96fb4 Remove useless code (A61) 
Just after this, clear() will be called, removing the suggestion
strip from the screen. It will later be displayed again through
onStartInputView, which will update its content.

Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
 2012-07-06 13:07:48 +09:00
Jean Chalard
b1dc8ad5f2 Simplification (A60) 
Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
 2012-07-06 13:07:48 +09:00
Jean Chalard
663dbfd1cc Simplification & UI improvement (A59) 
The responsivity is better like this. This does not seem to
feel slow as the previous comment seemed to indicate.

Also remove a stale comment.

Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
 2012-07-06 13:07:48 +09:00
Jean Chalard
746e014eb5 Show predictions in the right cases (A58) 
After reverting an auto-correct we always have a separator after
the previously inserted word, and the cursor is never touching
a word. Showing predictions is the right thing to do, while
calling postUpdateSuggestions will invariably yield an invariably
blank suggestion strip, which is not very helpful.

Likewise, after we pick a suggestion, we should be showing the
predictions unless showing the addToDictionary hint. There was
a bug here in the corner case that the word would be a candidate
for user dictionary, but the user dictionary provider is not
available: in this case we should be showing predictions, but
we were showing an unhelpful empty suggestion bar.

Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
 2012-07-06 13:07:48 +09:00
Jean Chalard
0e9e7e337d Cleanup (A57) 
We stopped cancelling manual picks a few weeks ago. This code
is dead.

Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
 2012-07-06 13:07:30 +09:00
Jean Chalard
29eeef75ec Merge "Fix a bug where the caps mode would not be changed" 2012-07-05 19:11:28 -07:00
Jean Chalard
f254e3fec7 Fix a bug where the caps mode would not be changed 
Bug: 6766059
Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
 2012-07-06 11:08:20 +09:00
Jean Chalard
d81e7d24d3 Simplification (A56) 
If suggestion and prediction messages both happen to be in
the queue, the latest one will win (update the suggestion strip
later than the other, overwriting any previous suggestions).
So when we enqueue either one, it is always safe to cancel
all messages of both types.

Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
 2012-07-05 18:19:51 +09:00
Jean Chalard
414f14436e Remove an unused method (A55) 
Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
 2012-07-05 18:10:37 +09:00
Jean Chalard
c84f178cd9 Merge "Remove a useless method, rename another. (A54)" 2012-07-05 02:05:50 -07:00
Tadashi G. Takaoka
92d2f7e03b Merge "Initialize SubtypeLocale from Settings" 2012-07-05 02:04:35 -07:00
Jean Chalard
792e7ddc24 Merge "Remove a redundant test (A53)" 2012-07-05 01:57:04 -07:00
Jean Chalard
9636735c0a Merge "Small simplification (A52)" 2012-07-05 01:56:55 -07:00
Jean Chalard
21524c755c Merge "Put some more code in common (A51)" 2012-07-05 01:50:44 -07:00
Jean Chalard
71d7fc91b7 Merge "Pull up a common variable into the wrapping method (A50)" 2012-07-05 01:47:59 -07:00
Jean Chalard
ac3ad6ef9f Merge "Factorize some common code (A49)" 2012-07-05 01:45:08 -07:00
Tadashi G. Takaoka
d6ac0443f0 Initialize SubtypeLocale from Settings 
Bug: 6781106
Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
 2012-07-05 17:39:30 +09:00
Tadashi G. Takaoka
15d3532170 Merge "Fix tab key's navigation behavior" 2012-07-05 01:24:00 -07:00
Jean Chalard
3d8e7a62fc Remove a useless method, rename another. (A54) 
Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
 2012-07-05 17:22:15 +09:00
Jean Chalard
0783366036 Remove a redundant test (A53) 
Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
 2012-07-05 17:22:04 +09:00
Jean Chalard
4cba560dbb Small simplification (A52) 
Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
 2012-07-05 17:22:00 +09:00
Jean Chalard
ea80794dd4 Put some more code in common (A51) 
Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
 2012-07-05 17:21:55 +09:00
Jean Chalard
cbfd2e1fdb Pull up a common variable into the wrapping method (A50) 
Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
 2012-07-05 17:21:51 +09:00
Jean Chalard
7ed22f1f72 Factorize some common code (A49) 
Also add some comment to clarify what's happening inside those
methods

Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
 2012-07-05 17:21:44 +09:00
Tadashi G. Takaoka
b28934adac Fix tab key's navigation behavior 
Bug: 6435484
Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
 2012-07-05 16:57:14 +09:00
Jean Chalard
e47c728dd5 Add a wrapper to updateSuggestions / Predictions (A48) 
The goal is to have those converge, as they contain almost 100%
duplicated code.

Change-Id: I6921791d47efce9fb396efd9626839d706664a91
 2012-07-05 11:10:04 +09:00
Jean Chalard
7b40c68277 Refactoring which will help with future changes (A47) 
Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
 2012-07-05 11:10:02 +09:00
Jean Chalard
e9a86e2cdb Search bigrams for the lower case version of the word (A46) 
...if there aren't any for the exact case version.

Bug: 6752830
Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
 2012-07-04 20:12:58 +09:00
Jean Chalard
4bcf70c931 Fix a bad interaction with mmap 
Bug: 6761221
Change-Id: I7e6d98dc9d7cb34a6163c3957e401ff97abb975c
 2012-07-04 17:57:06 +09:00
Tadashi G. Takaoka
ac3bd96192 Merge "Remove WordComposer.add(int, int, int, KeyDetector) method" 2012-07-04 01:48:42 -07:00
Tadashi G. Takaoka
5c641a9f59 Remove WordComposer.add(int, int, int, KeyDetector) method 
Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
 2012-07-04 17:29:47 +09:00
Tadashi G. Takaoka
5c98206dc5 Merge "Use Keyboard.getKey" 2012-07-04 01:12:02 -07:00
Tadashi G. Takaoka
adc80eef15 Use Keyboard.getKey 
Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
 2012-07-04 16:31:57 +09:00
Tadashi G. Takaoka
040aa28ed4 Merge "Get rid of redundant CharSequence member from SuggestedWordInfo" 2012-07-04 00:27:07 -07:00
Tadashi G. Takaoka
f3897fb54e Get rid of redundant CharSequence member from SuggestedWordInfo 
Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
 2012-07-04 16:04:59 +09:00
Jean Chalard
c5e911c06b Consolidate a method inside another (A45) 
It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.

This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.

Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
 2012-07-04 11:51:51 +09:00
Jean Chalard
f72b8f5662 Move the safety net function to AutoCorrection (A44) 
Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
 2012-07-04 11:51:46 +09:00
Jean Chalard
accd63f35f Merge "Refactoring (A43)" 2012-07-03 19:40:19 -07:00
Jean Chalard
b87b23eb75 Merge "Remove useless code (A42)" 2012-07-02 18:56:41 -07:00
Jean Chalard
6547f43666 Merge "Clarify some code and fix a bug (A41)" 2012-07-02 18:52:56 -07:00
Jean Chalard
d6496c0913 Merge "Fix a bug with the user dictionary locale." 2012-07-02 02:57:50 -07:00
Jean Chalard
d113fd0be4 Fix a bug with the user dictionary locale. 
We internally use the string "zz" to mean no locale, but
the user dictionary service does not understand that and
words added with this locale pitifully end being added to
a "zz" user dictionary, which makes no sense to the user.
This change fixes things so that words added when the
keyboard is in a "no locale" layout, the words are added
to the global, all-locales user dictionary.

Bug: 6645306
Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
 2012-07-02 17:14:47 +09:00
Jean Chalard
4ca05e2474 Refactoring (A43) 
Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
 2012-07-02 15:46:11 +09:00
Jean Chalard
7ad088a4cf Remove useless code (A42) 
If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !

Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>

Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
 2012-07-02 15:46:08 +09:00
Jean Chalard
90d300c770 Clarify some code and fix a bug (A41) 
The test against hasMainDictionary is a test to know if we should
auto-correct or not. Its result should be recorded in
hasAutoCorrection, not in allowsToBeAutoCorrected.

Actually, this value being inserted in allowsToBeAutoCorrected was
causing a bug that nobody noticed: when typing in a language with
no dictionary, the word in the middle of the suggestion strip would
always be bold, as if it was going to auto-correct to itself !
This change fixes this bug.

Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
 2012-07-02 15:46:03 +09:00
Jean Chalard
2631e3b195 Small refactoring (A39) 
Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea
 2012-07-02 15:45:58 +09:00
Jean Chalard
79f5317848 Match calls for future consolidation (A38) 
Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9
 2012-07-02 15:45:54 +09:00
Jean Chalard
cd288620ea Make the autocorrection scheme more straightforward (A37) 
Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd
 2012-07-02 15:45:34 +09:00
Jean Chalard
aba432bf8d Remove a duplicate method (A36) 
Bug: 6705473
Change-Id: Ib6260034b09739b60071e90a018b2dc6be3815d7
 2012-07-02 12:12:16 +09:00
Jean Chalard
84074cf503 Update log and make a variable private (A35). 
Change-Id: Ib4a8f41dc5941bce46402e1a41a6c21dccb0601f
 2012-07-02 12:11:27 +09:00
Jean Chalard
1842fbba93 Remove old debug code that has been long broken (A34) 
Change-Id: I9b5a0e34529724984aad1e2bf99b3e00f8ed0dd7
 2012-06-29 19:47:00 +09:00
Satoshi Kataoka
105069a15f Merge "Add input pointers" 2012-06-29 03:03:01 -07:00
Satoshi Kataoka
71538b08e4 Add input pointers 
Change-Id: I95300bf0a847fb86d026e846ff4ad723bb45284f
 2012-06-29 18:58:51 +09:00
Jean Chalard
1b2e2d893d Add a more synthetic variable (A33) 
The goal here is to disambiguate TypedWordValid and
HasAutoCorrectionCandidate. Ultimately, HasAutoCorrectionCandidate
will disappear.

Bug: 6705473
Change-Id: I1acbd0a5efc7f4bf7b0bdb12839fe3d84e9d1dda
 2012-06-29 17:00:57 +09:00
Jean Chalard
9011b89f4e Remove cruft (A32) 
Change-Id: I35c2ba4caf6be4ba0449e11c0597ae8e468c0e6e
 2012-06-29 17:00:57 +09:00
Jean Chalard
2cda148fd5 Simplification (A31) 
Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
 2012-06-29 17:00:57 +09:00
Jean Chalard
deb2d88245 Small refactoring (A30) 
Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
 2012-06-29 17:00:57 +09:00
Jean Chalard
0a63111821 Remove a useless parameter (A29) 
Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
 2012-06-29 17:00:56 +09:00
Jean Chalard
4f444410f2 Remove a useless variable (A28) 
Change-Id: I1058123d233540fb72a94028987a43740224f635
 2012-06-29 17:00:56 +09:00
Jean Chalard
f4267c0521 Fix a small bug (A27) 
TypedWordValid and AllowsToBeAutoCorrected are almost the
same thing; the difference is whether the word is also a
whitelist entry or not. In this case, TypedWordValid was
the right one to test.

Change-Id: I695fe5b9f6bbe9d3ba314c646da3a25742c9f4ed
 2012-06-29 17:00:56 +09:00
Jean Chalard
9e0af57736 Optimization (A26) 
Change-Id: I1d7790289635729645995fb8c38868259ab1b3be
 2012-06-29 17:00:56 +09:00
Jean Chalard
7a94cbd2a4 Remove useless code (A25) 
isWhitelistedOrNotAWord takes an 'ignoreCase' argument. By looking
at the contents of the wordcomposer here, there is only one case
where its output will be different : when the word is typed with a
capital, but the lower case version exists in the dictionary.
E.g. the user typed "This".

In this case, isWhitelistedOrNotAWord in line 235 will return false
instead of true, so the test will score a true instead of a false,
so hasAutoCorrection may be true instead of false in this specific
case and that's the only case where it's different.

But in this case, allowsToBeAutoCorrected is certain to be false,
which means the result will not have changed if hasAutoCorrection
was true in the first place. So in the end this change is sure not
to change the behavior.

Change-Id: Ic41cf959c20c19165f84d9b8ff006731fa595d84
 2012-06-29 16:57:56 +09:00
Jean Chalard
b3cfde2cbb Add a few comments for future reference (A24) 
Change-Id: Ia356130b8a95ec9cf676bc6be05d801c13f14b64
 2012-06-29 15:45:27 +09:00
Jean Chalard
e398c6c024 Rename a method for readability (A23) 
Change-Id: I6f569322e645d36bc82fddf4ec2fd621972e3b47
 2012-06-29 15:45:24 +09:00
Jean Chalard
ea578f6b1d Revert a test for readability (A22) 
Change-Id: I1df4cef5ae2736a22273843dce67f0012181bfd3
 2012-06-29 15:44:55 +09:00
Jean Chalard
19d02c19d0 Remove a useless variable (A21) 
Change-Id: I901e6b0e2b994128da19d68233b9f68bb308cb95
 2012-06-29 15:44:17 +09:00
Jean Chalard
4d5e7235c5 Remove a useless variable (A20) 
Change-Id: Ifc37462f5243563693c8cd7cbeb401ff054daa52
 2012-06-29 15:12:51 +09:00
Jean Chalard
739683dcfb Rename a method for readability (A19) 
Change-Id: I0b8c06d1fd0bfb3caf363c048acc7048abed1752
 2012-06-29 15:12:51 +09:00
Jean Chalard
31b346aac6 Remove a useless test (A18) 
allowsToBeAutoCorrected always returns false if the word is empty.
This is because the whitelist never contains an empty string,
and isValidWord returns false if the word is empty.

Change-Id: I34ecc2a1563aea6db5b2f12796f251f6598576a2
 2012-06-29 15:12:51 +09:00
Jean Chalard
b01cdb975a Inline a method (A17) 
This will allow us to remove unnecessary processing

Change-Id: I251dfdaffb077906186686ebe65fd82e1e360bd2
 2012-06-29 15:12:51 +09:00
Jean Chalard
42dde06782 Make a function a one-liner (A16) 
...to better inline it

Change-Id: I88496b8f18b81f0c05e4bbf2d1039de1f93e0c25
 2012-06-29 15:12:51 +09:00
Jean Chalard
a96a11949f Inline a simple method (A15) 
Change-Id: Ib74fcbf33c680bf02c39a9896e30e3afbcfd149a
 2012-06-29 15:12:51 +09:00
Jean Chalard
074c90af98 Inline a method (A14) 
The new code is worse than the old one, but this is a necessary
step to make things prettier.

Change-Id: If6e8a139bb85e6920c749743c78792a22a8acb45
 2012-06-29 15:12:51 +09:00
Jean Chalard
1333579b4b Don't special-case 1-letter words (A13) 
There is no reason to prevent 1-letter words to auto-correct
to themselves, or to dictionary words. Don't do it.

Change-Id: Iceada847ae632336026ada29afed0353cd9c51b5
 2012-06-29 15:12:51 +09:00
Jean Chalard
d426941ee8 Fix a theoretical bug (A12) 
If a word is a dictionary word but still has no suggestion,
this method should return true. In the practice, it makes
no difference since a word without suggestion won't be changed
anyway.

Change-Id: Ib1f5ef254b7da7e5cedb2f973529ad431beb93f9
 2012-06-29 15:12:51 +09:00
Jean Chalard
9701b360d9 Rename a terribly-named method for clarity (A11) 
Change-Id: Id180000404dc6929d80f98c0e9cd2026230ad2d1
 2012-06-29 15:12:50 +09:00
Jean Chalard
6b911c27a3 Merge "Small readability improvement (A10)" 2012-06-28 23:11:23 -07:00
Jean Chalard
f89a75134b Small readability improvement (A10) 
Change-Id: Iba326921711e1c4eab38264e66b6b44a64fec398
 2012-06-29 15:05:08 +09:00
Jean Chalard
305326e789 Refactoring and add debug prints (A9) 
Change-Id: I46497bff107f0def0dfa2b043b20d9a0b0cde040
 2012-06-29 14:24:54 +09:00
Jean Chalard
5110e2cb51 Optimization (A8) 
Change-Id: I2b9e8cc6a13fd9af84a5189e4d3fbb2b05c68d46
 2012-06-29 12:54:11 +09:00
Jean Chalard
4847a27f74 Cleanup (A7) 
Change-Id: Iba97e0062b702c005ab3ff9ce59f181d19ab7c98
 2012-06-28 19:13:16 +09:00
Jean Chalard
ed83d4b143 Stop special-casing a single suggestion (A6) 
Treat it like the others

Change-Id: Ic24e40ada0e75773c3ece9470ab61c350697be5d
 2012-06-28 19:12:37 +09:00
Jean Chalard
251bb70f08 Cleanup (A5) 
Change-Id: I06134145b47c46bbc6c340ca539f34a01e2ca163
 2012-06-28 19:12:37 +09:00
Jean Chalard
4c4e3a0949 Transform the whitelist suggestion like the others (A4) 
...instead of having a different code path

Change-Id: Icd177e2151e45d25300000d4b63d4fba1f52b6a8
 2012-06-28 19:10:32 +09:00
Jean Chalard
33b3805e79 Small refactoring (A3) 
This will help make upcoming changes clearer

Change-Id: Ida8d4935f7315e5da6007ad364124694da3112d0
 2012-06-28 19:10:24 +09:00
Jean Chalard
b7cdafd78a Don't pass everything to a function that needs only the head (A2) 
Change-Id: Ic367836202ab8071c1a9a02eaf0651b0da947d51
 2012-06-28 19:10:13 +09:00
Jean Chalard
09b30ac954 Merge "Use a TreeSet to sort suggestions instead of doing it by hand (A1)" 2012-06-28 03:08:26 -07:00
Jean Chalard
2d2e348033 Use a TreeSet to sort suggestions instead of doing it by hand (A1) 
Change-Id: I16ba39321107e87ad48a99c2410a15995a66f23c
 2012-06-28 18:54:14 +09:00
Tadashi G. Takaoka
69527d4d60 am 5e5cf045: am 7f7947c9: Keep subtypes in method.xml the same as pre-JellyBean 
* commit '5e5cf045ca6debafcc29ae1c47afda4a3a152326':
  Keep subtypes in method.xml the same as pre-JellyBean
 2012-06-27 21:58:53 -07:00
Tadashi G. Takaoka
7f7947c97b Keep subtypes in method.xml the same as pre-JellyBean 
This change prevents Android Keyboard subtypes being mistakenly
disabled when upgrading from pre-JellyBean to JellyBean.

Bug: 6750906
Change-Id: I05de6c512e7aa17356e415476e5248986c7d4253
 2012-06-28 13:44:09 +09:00
Jean Chalard
10abf10c1f Convert local members to local variables 
Change-Id: I852787986c79502a4de7effe9c8281a4cf2d519d
 2012-06-27 19:54:29 +09:00
Jean Chalard
3ecb2747b3 Optimization. 
It's useless to do this for all suggestions including those
that will be ousted from the list.

Change-Id: I7bd63d783e21984a269e4b1ae17e9b9d8c0859e3
 2012-06-27 18:55:43 +09:00
Jean Chalard
3705ef407b Read the suggestion type from the suggestion 
...instead of dirtily passing it from the dictionary loop

Change-Id: I92ddbd7451609b69f6d4dc31bf89d614423b2016
 2012-06-27 18:18:35 +09:00
Jean Chalard
24eec0fa68 Remember the source dictionary for each suggestion. 
Change-Id: I3c63372bd5572a479a67eaecfe8c8ea1cabc70d9
 2012-06-27 18:17:28 +09:00
Jean Chalard
d8f0caa406 Move constants to a better place. 
Change-Id: I5c27a3ed99b17f850e26a8503de16f001c7111c1
 2012-06-27 18:08:08 +09:00
Jean Chalard
089c11a086 Cleanup 
Change-Id: I575f22330bf6881af1d9a35f22b51b7bf2198113
 2012-06-27 17:59:58 +09:00
Jean Chalard
b5afd3de0c Remove unused stuff. 
Change-Id: Ifd0d5b6978f76b841574a6e10157c32d0cd656b6
 2012-06-27 17:44:16 +09:00
Jean Chalard
05efe576f9 Cleanup the dictionary type. 
Stop storing an int in each of the different class types, and
just store a string in the top class.

Change-Id: I2af1832743e6fe78e5c1364f6d9cc21252bf5831
 2012-06-27 17:31:09 +09:00
Jean Chalard
c356df8e08 Merge "Update the prototype of onAddSuggestedWord - calling side." 2012-06-27 01:25:59 -07:00
Ken Wakasa
e55c23e4b0 Small cleanups 
Change-Id: Ic1a198ab1b4f0323fde9e4245729fd0e6011b914
 2012-06-27 16:54:37 +09:00
Jean Chalard
32ff2504a0 Update the prototype of onAddSuggestedWord - calling side. 
We want to get rid of all those IDs in Latin IME.

Change-Id: Ibe08100a5e2976c80abb049889233b4047a686f3
 2012-06-27 16:17:14 +09:00