Commit Graph

11841 Commits (c2e9c511cbc4bd374d3a0680c58da60043ef21c3)

Author SHA1 Message Date
Jean Chalard c2e9c511cb Fix Binary dict tests
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
2013-04-15 12:48:16 +09:00
Jean Chalard 2cd1136b8e Merge "Remove the dialog to insert words to the dictionary." 2013-04-12 12:33:24 +00:00
Jean Chalard 91bcf5eb5d Merge "Restart suggestions when the cursor moves." 2013-04-12 12:27:50 +00:00
Jean Chalard 02ce3dc2d1 Fix a bug with bad application completions
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
2013-04-12 20:53:06 +09:00
Jean Chalard 6a114fa700 Restart suggestions when the cursor moves.
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.

Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
2013-04-12 20:49:03 +09:00
Jean Chalard d24f939712 Merge "Make shortcut-only user dict entry non-words." 2013-04-12 11:02:00 +00:00
Jean Chalard fb5869e9ff Merge "Add a class to encapsulate getting the metadata URI" 2013-04-12 11:01:36 +00:00
Jean Chalard 676c97eb2d Merge "Remove voodoo magic." 2013-04-12 10:59:47 +00:00
Jean Chalard d89ed47616 Remove voodoo magic.
There was a much, much simpler way of achieving the same thing.

Bug: 8583091
Change-Id: I8882f389312caad3b17335672892a31d30cd00bc
2013-04-12 17:05:43 +09:00
Jean Chalard 6a2a4b8e4d Make shortcut-only user dict entry non-words.
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
2013-04-12 16:17:09 +09:00
Jean Chalard 1a51833828 Remove the dialog to insert words to the dictionary.
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
2013-04-12 15:58:50 +09:00
Ken Wakasa 2daea19709 am 47bb8d7d: am 4fffa27d: Fix a native crash in AOSP LatinIME
* commit '47bb8d7d9cd2dcc8e80f90283e4d9b7d4f68e70b':
  Fix a native crash in AOSP LatinIME
2013-04-11 22:21:10 -07:00
Ken Wakasa 47bb8d7d9c am 4fffa27d: Fix a native crash in AOSP LatinIME
* commit '4fffa27d3f620135f61b7dfb447ab3bf2b2367f5':
  Fix a native crash in AOSP LatinIME
2013-04-11 22:18:36 -07:00
Ken Wakasa 4fffa27d3f Fix a native crash in AOSP LatinIME
bug: 8597610

Change-Id: I585c629636a52a1ac45b8cc686bc94427bb601df
2013-04-12 12:53:28 +09:00
Jean Chalard d0623ad7f3 Merge "Move some values to a place where they are easier to override" 2013-04-12 02:53:41 +00:00
Kurt Partridge 2927223edd Merge "Better isolate ResearchLogging data" 2013-04-11 21:56:01 +00:00
Jean Chalard 8987cccf89 Add a class to encapsulate getting the metadata URI
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
2013-04-11 17:52:16 +09:00
Jean Chalard 7ad078e89c Move some values to a place where they are easier to override
Bug: 8418765
Change-Id: Iff0edd4ed8da9d0d1a6fb9545224b232ba374469
2013-04-11 17:35:23 +09:00
Tadashi G. Takaoka cd692be1e1 Merge "Change the default vibration duration to 20msec" 2013-04-11 08:15:29 +00:00
Jean Chalard b5d5190deb Merge "Add some utility functions." 2013-04-11 07:35:22 +00:00
Tadashi G. Takaoka e1416b4399 Change the default vibration duration to 20msec
Bug: 8556975
Change-Id: Ia6a0fe230585c9826199a0696fb0c1367e917134
2013-04-11 16:30:32 +09:00
Jean Chalard 1cbb0b8f2a Add some utility functions.
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
2013-04-11 16:16:19 +09:00
Tadashi G. Takaoka 4f5f81d5f7 Reorder advanced settings menu
Bug: 8247224
Change-Id: I339f285304824b778635f435d8587893fc241c4e
2013-04-11 15:54:38 +09:00
Tadashi G. Takaoka bd8e92d843 Add debug message to detect unusual zero width condition
Bug: 8452013
Change-Id: I0169dc6b0d08d1b4d9e01a5fa2ad01e9db292bda
2013-04-11 15:08:36 +09:00
Tadashi G. Takaoka f67a388197 Merge "Add TypefaceUtils" 2013-04-11 05:32:58 +00:00
Satoshi Kataoka 6c7d008e70 Merge "add a debug flag to evaluate the most probable string" 2013-04-11 05:32:02 +00:00
Tadashi G. Takaoka 08ae0d5ca0 Add TypefaceUtils
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
2013-04-11 14:27:42 +09:00
Tadashi G. Takaoka 6d0027a46a Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>" 2013-04-11 05:06:35 +00:00
Tadashi G. Takaoka cee512b63e Merge "More precise geometry checking for more keys keyboard" 2013-04-11 03:51:42 +00:00
Jean Chalard 3722f0877e Merge "Fix two bugs in dicttool" 2013-04-11 03:07:30 +00:00
Baligh Uddin 269f141bed am cfdc91b9: am 58df3cfa: Import translations. DO NOT MERGE
* commit 'cfdc91b99abbb985a7e9207020b95b1df807d567':
  Import translations. DO NOT MERGE
2013-04-10 19:41:45 -07:00
Tadashi G. Takaoka ac018da68c am 9620943c: am d9a22235: Hide Setup Wizard icon for stock keyboard
* commit '9620943cc80e8f709e1cd53af7bf77a0e717d3db':
  Hide Setup Wizard icon for stock keyboard
2013-04-10 19:41:44 -07:00
Jean Chalard defd295068 am 1aaaa64d: am 75618c33: am 19dcd154: Merge "Offer to add any OOV typed word to the dictionary."
* commit '1aaaa64da8d818dd7a91c024eb4fa2d9e1459f93':
2013-04-10 19:41:43 -07:00
Satoshi Kataoka d355283f56 am fd89cd20: am daef4e8f: am f31553bc: Merge "Fix touch coordinate calibration"
* commit 'fd89cd20c956ce9618353dcd5d7648a2bab3b7ab':
2013-04-10 19:41:41 -07:00
Jean Chalard e040aa197e am 0d72a230: am 04bb419c: am ddafcf82: Merge "Fix bugs and add tests"
* commit '0d72a23054341a8e216a33c0191cace1edc0cff9':
2013-04-10 19:41:40 -07:00
Kurt Partridge e2bdf6861a am bea42fc5: am 5bd24642: am 1f70a4d6: Merge "Allow logging while replaying"
* commit 'bea42fc5bd1e4053e7cf7a3a51021d771d939f97':
2013-04-10 19:41:39 -07:00
Kurt Partridge 1944521bed am 41a049a4: am ae144fe9: am d117c1a1: Merge "Do not record log split time when handling separator"
* commit '41a049a410a921abdb896450abe3c6010a71d9e6':
2013-04-10 19:41:38 -07:00
The Android Open Source Project c89354b9af am fb899d85: am 3019a5e1: am a8d29082: (-s ours) am d5c8247f: Reconcile with jb-mr2-release - do not merge
* commit 'fb899d85ee3497dbb9443fbbee0241aaf94f2e52':
2013-04-10 19:41:37 -07:00
Ken Wakasa d01118aeba am 4c896a2f: am f71b9640: am d17c8bd9: Update comments
* commit '4c896a2fe81748990786288eff28b00233423da9':
2013-04-10 19:41:35 -07:00
Ken Wakasa 3f55a951e9 am b3cf23de: am a271f165: am 31f42ba0: Tiny clean up in Makefile
* commit 'b3cf23de7f30eb4c9c8c757d8b02a12fdad026aa':
2013-04-10 19:41:34 -07:00
Ken Wakasa e4d60a2db0 am ff730a66: am bc2fd24f: am b68e7344: Cleanup the include paths
* commit 'ff730a665cc90aec1c795c8555e8563ff1bfbc37':
2013-04-10 19:41:33 -07:00
Satoshi Kataoka c7d4f50233 am c7e1caac: am cd0984a4: am e320789a: Suppress bigram native log
* commit 'c7e1caac44238d53f635ee1660cb767d122b7416':
2013-04-10 19:41:32 -07:00
Satoshi Kataoka 23b62c9387 am 40d8b652: am dfb680c4: am f5e18e99: Merge "Cleanup suggest interface"
* commit '40d8b652b2fce9246ad34b7f78719b83348136a7':
2013-04-10 19:41:30 -07:00
Ken Wakasa 1c9da7af48 am 34cff46a: am ed8fd94e: am 370461ef: Clean up a few option strings under the Advanced settings
* commit '34cff46a9ca4fc8bdd1d074b94597859bde08a4a':
2013-04-10 19:41:29 -07:00
Jean Chalard 8178241912 am 024d0e4a: am f10e7cbe: am e9f69e16: Merge "Move a generic string utility to StringUtils"
* commit '024d0e4abf9d3bfacfb5495fa27a512c266df114':
2013-04-10 19:41:28 -07:00
Tom Ouyang 3c15067b0e am 8ab65b8b: am 4096fd08: am 08fd3d95: Merge "Add DigraphUtils class"
* commit '8ab65b8b4eb5815398db8abb0a0dfc02f613445e':
2013-04-10 19:41:26 -07:00
Ben Cheng 7629394953 am f82a5a24: am 96cb244d: am 65534ffc: am d0c383e1: am 5a4949c2: Merge "Force inlining Correction::isSingleQuote" into jb-mr2-dev
* commit 'f82a5a24ccc6d9e8a77f49ebb1a58f64d174c59f':
2013-04-10 19:41:25 -07:00
Satoshi Kataoka b3d7d07e58 am e90df243: am 481412bb: am f3633e9b: Merge "Add flag to turn on new suggest implementation for typing"
* commit 'e90df24386ca22689abccaacf70a087912c00343':
2013-04-10 19:41:24 -07:00
Baligh Uddin 1270880eaa am da90ffe0: am 898ec2bf: am 5a5db35d: am 04915a76: am c33a0ab3: keep history after reset to jb-ub-latinimegoogle-azuki
* commit 'da90ffe048850df35a1a8d159d6b50eb2c14bda6':
2013-04-10 19:41:23 -07:00
Baligh Uddin 83c5ec6b3b am 005df808: am 12db86a6: am c48fe5d1: (-s ours) am 51a47422: am a631cede: Import translations. DO NOT MERGE
* commit '005df80888657650ce6c39ecc4c61cb8974f6234':
2013-04-10 19:41:22 -07:00