Jean Chalard
5875362b70
am 9613be01: am d0623ad7: Merge "Move some values to a place where they are easier to override"
...
* commit '9613be01de32ca276104c8c69b44c764d9e66a45':
Move some values to a place where they are easier to override
2013-04-17 19:41:12 -07:00
Kurt Partridge
a5613e634a
am bdce031e: am 2927223e: Merge "Better isolate ResearchLogging data"
...
* commit 'bdce031e00876df72e10b5c4e9c0ae9ff03153d1':
Better isolate ResearchLogging data
2013-04-17 19:41:10 -07:00
Tadashi G. Takaoka
dfc8135941
am 3d6b7431: am cd692be1: Merge "Change the default vibration duration to 20msec"
...
* commit '3d6b7431893aa6aa6d0086e44b85f35057c5b87d':
Change the default vibration duration to 20msec
2013-04-17 19:41:09 -07:00
Jean Chalard
27dede24a6
am 2e4352c5: am b5d5190d: Merge "Add some utility functions."
...
* commit '2e4352c53b48366c40d43b32e8acdc28acac2e6f':
Add some utility functions.
2013-04-17 19:41:08 -07:00
Tadashi G. Takaoka
3be1c7485b
am 05314bf0: am 4f5f81d5: Reorder advanced settings menu
...
* commit '05314bf0054148ec85df8620afcc9189ebca383c':
Reorder advanced settings menu
2013-04-17 19:41:06 -07:00
Tadashi G. Takaoka
46762bf521
am 206ce637: am bd8e92d8: Add debug message to detect unusual zero width condition
...
* commit '206ce6374bb4dfcb93d059ec6795853f36cd4979':
Add debug message to detect unusual zero width condition
2013-04-17 19:41:05 -07:00
Tadashi G. Takaoka
1ba1c411ef
am 93fe83a1: am f67a3881: Merge "Add TypefaceUtils"
...
* commit '93fe83a1c29e8d8671c007a7a4781c791b9864b6':
Add TypefaceUtils
2013-04-17 19:41:04 -07:00
Tadashi G. Takaoka
24b39f16b2
am 18819688: am 6d0027a4: Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>"
...
* commit '188196883c9ac2a877dba27e7beabe4f55208bab':
Use SparseIntArray instead of TreeMap<Integer, Integer>
2013-04-17 19:41:02 -07:00
Tadashi G. Takaoka
dabcd969c5
am 1dc7fd3f: am cee512b6: Merge "More precise geometry checking for more keys keyboard"
...
* commit '1dc7fd3f8085c5a729061a7b35f71a2024a5ce0b':
More precise geometry checking for more keys keyboard
2013-04-17 19:41:00 -07:00
Jean Chalard
e910a9c94a
am b7917ee3: am 3722f087: Merge "Fix two bugs in dicttool"
...
* commit 'b7917ee347898d5dc9b1698ec7818b3a4cc8a035':
Fix two bugs in dicttool
2013-04-17 19:40:59 -07:00
Kurt Partridge
9cf3937281
am 94c441a4: am cdaee868: Merge "Preserve a class for testing"
...
* commit '94c441a424875f815d7e84d02da5c8943ad6f7a6':
Preserve a class for testing
2013-04-17 19:39:00 -07:00
Kurt Partridge
6267ec688e
am 3e1f652c: am 099dd3f2: Merge "Better release build reporting"
...
* commit '3e1f652c2c39351d306b3a930340948a46104de0':
Better release build reporting
2013-04-17 19:38:57 -07:00
Jean Chalard
7503ef330c
am cd51b80a: am fb3e8057: Merge "Fix a bug where a space would not be inserted before a gesture"
...
* commit 'cd51b80a0b31493ef9dce9b5283264399b305ba0':
Fix a bug where a space would not be inserted before a gesture
2013-04-17 19:38:51 -07:00
Tadashi G. Takaoka
c627f64274
am 9a6ff5dc: am c7d41589: Merge "Use private object as a lock instead of synchronized method"
...
* commit '9a6ff5dcef1a593260032b5e10eb801de297c0b2':
Use private object as a lock instead of synchronized method
2013-04-17 19:38:49 -07:00
Tadashi G. Takaoka
4516304436
am 1502d977: am 12e77de2: Merge "Use private lock object instead of synchronized method"
...
* commit '1502d9779555958b0ca147fda1cab1e6302c9035':
Use private lock object instead of synchronized method
2013-04-17 19:38:48 -07:00
Tadashi G. Takaoka
8ea774ebf2
am 14950497: am 1e256f58: Merge "Protect simultaneously modifying gesture preview data"
...
* commit '14950497280f15b6d1de9e6c5d159ce46e27180b':
Protect simultaneously modifying gesture preview data
2013-04-17 19:38:46 -07:00
Jean Chalard
99e91fc8ec
am 2dd2e2d7: am 99b93d17: Fix a bug where autocorrection status would be wrong.
...
* commit '2dd2e2d7dff8c4446d536bd23fc94a5538c24ddf':
Fix a bug where autocorrection status would be wrong.
2013-04-17 19:38:43 -07:00
Tadashi G. Takaoka
9a0f6ef847
am c35bca68: am 262d5bd9: Don\'t override EXTRA_SHOW_FRAGMENT if exists
...
* commit 'c35bca685689ff6430e7a9393af64c74112bf677':
Don't override EXTRA_SHOW_FRAGMENT if exists
2013-04-17 19:38:41 -07:00
Tadashi G. Takaoka
f0a4508ad5
am f5aa2fd5: am 10af4b6e: Merge "Separate StringUtils.capitalizeFirstCharacter"
...
* commit 'f5aa2fd5c868cae6e879858738a5eef4445aaca8':
Separate StringUtils.capitalizeFirstCharacter
2013-04-17 19:38:40 -07:00
Keisuke Kuroynagi
5c7c36e31f
am e81c1678: am 87fdde6e: Typing double letters via a \'circle\' on the key.
...
* commit 'e81c16788712590fd6cf9e14420d50acf029ad48':
Typing double letters via a 'circle' on the key.
2013-04-17 19:38:38 -07:00
Tadashi G. Takaoka
0d9164ecd8
am 0d7499bc: am 4fdfce6d: Merge "Refactor SpellCheckerProximityInfo as extending ProximityInfo"
...
* commit '0d7499bccfb37bad2364202657a4feebab137aeb':
Refactor SpellCheckerProximityInfo as extending ProximityInfo
2013-04-17 19:38:35 -07:00
Kurt Partridge
d34979381d
am ab8f166e: am 09ab6495: Merge "[FileEncap18] Clean up uploading scheduling"
...
* commit 'ab8f166e6793e214dcb92454b10dbe5cc74daf9b':
[FileEncap18] Clean up uploading scheduling
2013-04-17 19:33:02 -07:00
Kurt Partridge
7a1721753b
Merge "Fix user recording dialog"
2013-04-18 02:07:16 +00:00
Kurt Partridge
0833b3cbae
Merge "Fix alarm bug"
2013-04-18 01:01:48 +00:00
Kurt Partridge
a19133011a
Merge "Avoid duplicate MotionEvents"
2013-04-17 22:57:20 +00:00
Kurt Partridge
b903f10393
Merge "Label logUnits after LatinImeOnEndBatchInput"
2013-04-17 21:30:47 +00:00
Baligh Uddin
285ea403e1
Import translations. DO NOT MERGE
...
Change-Id: I923a171d7af715859605f79c35ea37239dcf0a3e
Auto-generated-cl: translation import
2013-04-17 13:39:46 -07:00
Kurt Partridge
a5bfac5bec
Merge "Fix NPE"
2013-04-17 20:33:26 +00:00
Kurt Partridge
7da87f97b0
Merge "Clean up unnecessary log messages"
2013-04-17 20:18:19 +00:00
Kurt Partridge
e9e4fe5227
Merge "Fix logic error"
2013-04-17 18:57:18 +00:00
Kurt Partridge
1f99e04bba
Merge "Fix JsonWriter bug"
2013-04-17 18:20:34 +00:00
Kurt Partridge
dac3ee49ae
Merge "Small dot in corner was not visible"
2013-04-17 17:18:35 +00:00
Kurt Partridge
bf62dc9460
Fix bug in counting words between samples
...
Previously MainLogBuffer#shiftOutWords() assumed it wouldn't be called if
mNumWordsUntilSafeToSample was 0. This relaxes this assumption (which is in fact
false in the current code).
Change-Id: I8723248095e84a0d9d6f4639b4742cc7dda9716b
2013-04-17 08:44:06 -07:00
Kurt Partridge
fdc90d4a58
Fix user recording dialog
...
Clicking the "include recording" checkbox in the user feedback dialog did nothing.
The code was relying on the state of the checkbox, rather than keeping its own state.
Fixing this addresses the bug.
Change-Id: I559d57a4e11f869f6e6f5e5de7878f765531a203
2013-04-17 08:42:20 -07:00
Kurt Partridge
9d3bbc82a0
Fix alarm bug
...
The AlarmManager takes absolute times as an argument, not durations.
Change-Id: I419434ba5908c5f4070608070bbecf753088ecc8
2013-04-17 08:39:49 -07:00
Kurt Partridge
dd8c87a39d
Merge "Include nanoTime in filename"
2013-04-17 15:31:20 +00:00
Tadashi G. Takaoka
530fd15eff
Fix bug to update last interpolated index of GestureStroke
...
Bug: 8556775
Change-Id: Ie12e0dc9bfeae45f6883580801e07d44be1d1d33
2013-04-17 06:36:12 -07:00
Tadashi G. Takaoka
464202047d
Add user feedback to setup action labels and icons
...
Bug: 8159728
Change-Id: I46c77c31973ae492c2a12291f2e0b154f64d26c9
2013-04-17 19:57:46 +09:00
Tadashi G. Takaoka
47a78aeb4d
Merge "Finalize setup wizard strings and mark as translatable"
2013-04-17 10:55:41 +00:00
Tadashi G. Takaoka
8712ac7945
Finalize setup wizard strings and mark as translatable
...
Bug: 8159728
Change-Id: I9f6f04b09b2cefdb7ece76a4f3c39ab56d0c8fab
2013-04-17 19:52:50 +09:00
Kurt Partridge
cd831fa285
Fix JsonWriter bug
...
JsonWriter requires that data be written to it, else close() will throw
an exception.
Change-Id: I596c5363e063cc75bcda55e0a506eefb3f17bd67
2013-04-17 01:26:52 -07:00
Kurt Partridge
fe0529714e
Label logUnits after LatinImeOnEndBatchInput
...
Previously only a commitText would cause a LogUnit to be
labeled with the word that the data generates. In the case
of gestured text, this information is available when
LatinIME#onEndBatchInput is called. Labeling the LogUnit
at this time means that the Log will have labeled words even
if stop() is called before commit.
Change-Id: Idb2f99a9c159a1b1aa00448a2ecddeca6c351c3e
2013-04-17 01:14:36 -07:00
Kurt Partridge
1bf47582a0
Avoid duplicate MotionEvents
...
Change-Id: I9c3b352b738698f262f254e581bde34b060e258f
2013-04-17 00:30:54 -07:00
Tadashi G. Takaoka
bb5deb82b5
Fix singleton/utility classes initialization in SettingsFragment
...
This is a follow up of Ide3cd3acba.
Bug: 8632344
Change-Id: Iafe51798a1a74eff5d8fcd6f0117d16b419d447d
2013-04-17 16:16:10 +09:00
Tadashi G. Takaoka
888a194cf1
Fix missing AudioAndHapticFeedbackManager initialization
...
Bug: 8632344
Change-Id: Ide3cd3acba3987317cff709fa591eadaa71834e8
2013-04-17 15:32:01 +09:00
Kurt Partridge
4ac28ded28
Fix NPE
...
Change-Id: I8a091fb63dab12a0d2ba69e2fe393249bc68d103
2013-04-16 20:39:47 -07:00
Kurt Partridge
2edb4f22cb
Clean up unnecessary log messages
...
Change-Id: I6c3252f3b31c5874ea2f909f636f58b579c06b8d
2013-04-16 20:39:47 -07:00
Kurt Partridge
cd39368c21
Fix logic error
...
Change-Id: Ia36660c66504ba2fbb7f125704926a08726df87a
2013-04-16 20:39:47 -07:00
Kurt Partridge
2d9d4390fd
Small dot in corner was not visible
...
Framework change perhaps? Even if not, this makes it more visible
Change-Id: Ib6d36b5a30136c4516adac666bdff36d1cd9b337
2013-04-16 20:39:47 -07:00
Kurt Partridge
125f22dc58
Include nanoTime in filename
...
System is fast enough that sometimes SystemClock.currentTimeMillis() is duplicated
when used to make a unique filename.
Change-Id: I9454fbb5e10265d36b8e17cba183a1591d52cc7b
2013-04-16 20:29:42 -07:00
Tadashi G. Takaoka
edc49d38e6
Fix bug to update last interpolated index of GestureStroke
...
Bug: 8556775
Change-Id: Ie12e0dc9bfeae45f6883580801e07d44be1d1d33
2013-04-17 11:58:09 +09:00
Jean Chalard
ff766f8c4b
Merge "Don't insert automatic spaces when text looks like a URL"
2013-04-16 10:07:36 +00:00
Jean Chalard
73ec85b8ad
Don't insert automatic spaces when text looks like a URL
...
This is about as ad-hoc as it gets, but then again, what we want
is probably as ad-hoc as it gets.
All URL boxes I know of double as search bars, and not adding
automatic spaces there sucks (e.g. in Chrome URL bar).
And in other boxes actually you don't want to add a space if
it looks like a URL. QSB isn't even a search box, and it behaves
like this.
So I think this is actually the right answer to the problem.
Bug: 7062925
Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
2013-04-16 18:03:49 +09:00
Tadashi G. Takaoka
1711f986d4
Merge "Add shadow to gesture preview trail"
2013-04-16 07:57:29 +00:00
Tadashi G. Takaoka
c71dde9cb5
Add shadow to gesture preview trail
...
Bug: 7167303
Change-Id: I8f76fe0aec6cb32388e7c85d04516d1dd7d28c29
2013-04-16 16:50:59 +09:00
Jean Chalard
962c9f059a
Merge "Small cleanup"
2013-04-16 06:38:17 +00:00
Jean Chalard
30225f3897
Small cleanup
...
Change-Id: Iafdbe305712c8a571f0f5abc2032df086d7ac015
2013-04-16 15:30:48 +09:00
Jean Chalard
78d658734d
Merge "Don't recapitalize on shift while on symbol layout"
2013-04-16 05:31:43 +00:00
Jean Chalard
1f52364630
Don't recapitalize on shift while on symbol layout
...
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
2013-04-16 14:29:02 +09:00
Jean Chalard
8094bf45d7
Match the keyboard state to the recapitalize state.
...
Bug: 7657025
Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
2013-04-16 14:25:03 +09:00
Jean Chalard
e259b9f57d
Merge "Clean up RecapitalizeStatus"
2013-04-16 04:57:35 +00:00
Jean Chalard
fd15686ae9
Merge "Fix an NPE"
2013-04-16 04:12:18 +00:00
Jean Chalard
b794e904a3
Clean up RecapitalizeStatus
...
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
2013-04-16 13:11:18 +09:00
Jean Chalard
a024ac6b20
Merge "Fix an NPE"
2013-04-16 03:43:06 +00:00
Jean Chalard
2b42ad0eaa
Fix an NPE
...
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
2013-04-16 12:20:10 +09:00
Jean Chalard
7be3ca2ccf
Fix an NPE
...
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
2013-04-16 12:17:22 +09:00
Baligh Uddin
5eb28c1928
am a130057b: Import translations. DO NOT MERGE
...
* commit 'a130057bcf1b3daa8c8823743b1190f460bbdc45':
Import translations. DO NOT MERGE
2013-04-15 14:27:38 -07:00
Baligh Uddin
fd2b08c74f
Import translations. DO NOT MERGE
...
Change-Id: I865e5c110e5a31e209fad2e909deb8589347657d
Auto-generated-cl: translation import
2013-04-15 13:44:48 -07:00
Baligh Uddin
a130057bcf
Import translations. DO NOT MERGE
...
Change-Id: I5f6f7233c46f7a5faaac5f959c93329ace4c70f4
Auto-generated-cl: translation import
2013-04-15 13:38:18 -07:00
Jean Chalard
5fca38c538
Merge "Small performance improvement / minor bugfix"
2013-04-15 14:28:16 +00:00
Ken Wakasa
e3aa7f10d0
Adjust CHAR_LIMITs
...
bug: 8589156
bug: 8588538
bug: 8588746
Change-Id: I14050dc3542946c1bae2e1dc8b63b99758d5f9aa
2013-04-15 22:47:08 +09:00
Jean Chalard
b76ce1251e
Merge "Remove a useless function"
2013-04-15 13:06:33 +00:00
Jean Chalard
bc501647fd
Remove a useless function
...
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
2013-04-15 22:01:37 +09:00
Jean Chalard
1e5bbe4ce8
Small performance improvement / minor bugfix
...
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.
Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
2013-04-15 21:18:50 +09:00
Jean Chalard
a5a2f3e3c7
Remove gesture suggestions with an INT_MIN score
...
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
2013-04-15 20:55:49 +09:00
Jean Chalard
033958330d
Merge "Have Latin IME re-capitalize a selected string"
2013-04-15 11:29:28 +00:00
Jean Chalard
e99daea083
Update dictionaries
...
>>> dictionaries/en_GB_wordlist.combined.gz
Header :
date : 1366003032 <=> 1366021966
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Added: www 72
>>> dictionaries/en_US_wordlist.combined.gz
Header :
date : 1366003070 <=> 1366021978
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Added: http 95
Added: www 71
>>> dictionaries/en_wordlist.combined.gz
Header :
date : 1366003861 <=> 1366021987
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Freq changed: http 120 -> 95
Added: www 71
>>> java/res/raw/main_en.dict
Header :
date : 1366003861 <=> 1366021987
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Freq changed: http 120 -> 95
Added: www 71
Bug: 8233807
Change-Id: Id55f6e0dcc9ddff26902c0857edcbb9b10d42328
2013-04-15 20:25:48 +09:00
Jean Chalard
2995abe7aa
Have Latin IME re-capitalize a selected string
...
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.
Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
2013-04-15 20:23:01 +09:00
Jean Chalard
0e9ee4d3bf
If there are no suggestion span, recompute suggestions.
...
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
2013-04-15 19:33:23 +09:00
Jean Chalard
059e084e98
Merge "Reject a previously user-refused suggestion."
2013-04-15 07:45:34 +00:00
Jean Chalard
d40f3f6bc1
Reject a previously user-refused suggestion.
...
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.
Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
2013-04-15 16:36:44 +09:00
Tadashi G. Takaoka
4b6756db3c
Merge "Remove unnecessary harmful finish() from SettingsActivity"
2013-04-15 07:32:05 +00:00
Tadashi G. Takaoka
216fb6a042
Remove unnecessary harmful finish() from SettingsActivity
...
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
2013-04-15 16:26:40 +09:00
Jean Chalard
673ebb4ede
Merge "Update dictionaries"
2013-04-15 07:23:00 +00:00
Tadashi G. Takaoka
1ec4c07a13
Merge "Ignore modifier key while sliding key input"
2013-04-15 06:19:10 +00:00
Tadashi G. Takaoka
f224941c37
Merge "Suppress calling onPressKey and onReleaseKey while detecting gesture"
2013-04-15 06:18:48 +00:00
Tadashi G. Takaoka
29105a725d
Add preference dependency to gesture input related options
...
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
2013-04-15 15:07:49 +09:00
Jean Chalard
da175bdcb1
Update dictionaries
...
>>> dictionaries/en_GB_wordlist.combined.gz
Header :
date : 1355802832 <=> 1366003032
version : 29 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 72
Added: mm 135
>>> dictionaries/en_US_wordlist.combined.gz
Header :
date : 1355112451 <=> 1366003070
version : 28 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 71
Added: mm 135
>>> dictionaries/en_wordlist.combined.gz
Header :
date : 1355802851 <=> 1366003861
version : 29 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 71
Added: mm 135
>>> dictionaries/fr_wordlist.combined.gz
Header :
date : 1357617878 <=> 1366003217
version : 29 <=> 31
Body :
Not a word: re false -> true
Shortcut added: re le 15
>>> dictionaries/nb_wordlist.combined.gz
Header :
date : 1355802836 <=> 1366003450
version : 29 <=> 31
Body :
Freq changed: iPhone 91 -> 30
Added: app 30
>>> dictionaries/ru_wordlist.combined.gz
Header :
date : 1358763720 <=> 1366003693
version : 30 <=> 31
Body :
Freq changed: за 140 -> 181
Freq changed: не 140 -> 191
Freq changed: про 131 -> 151
Freq changed: эры 125 -> 140
>>> dictionaries/sv_wordlist.combined.gz
Header :
date : 1355802856 <=> 1366003804
version : 29 <=> 31
Body :
Added: vi 180
>>> java/res/raw/main_en.dict
Header :
date : 1355802851 <=> 1366003861
version : 29 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 71
Added: mm 135
>>> java/res/raw/main_fr.dict
Header :
date : 1357617878 <=> 1366003217
version : 29 <=> 31
Body :
Not a word: re false -> true
Shortcut added: re le 15
>>> java/res/raw/main_ru.dict
Header :
date : 1358763720 <=> 1366003693
version : 30 <=> 31
Body :
Freq changed: за 140 -> 181
Freq changed: не 140 -> 191
Freq changed: про 131 -> 151
Freq changed: эры 125 -> 140
Bug: 8560415
Bug: 7556679
Change-Id: If1c628edcb1cc5efd67e1715acf94f19c0eb4643
2013-04-15 14:51:02 +09:00
Tadashi G. Takaoka
8dfbb740e1
Ignore modifier key while sliding key input
...
Bug: 8284624
Change-Id: I839d7a769d98f29be647dbe511ba3f73ca44446d
2013-04-15 14:39:02 +09:00
Tadashi G. Takaoka
e2af9b7eb5
Merge "Reset vertical correction when more suggestions are in modal mode"
2013-04-15 04:57:33 +00:00
Tadashi G. Takaoka
51c38a441a
Reset vertical correction when more suggestions are in modal mode
...
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
2013-04-15 13:56:03 +09:00
Jean Chalard
03d1dff38d
Merge "Fix Binary dict tests"
2013-04-15 03:53:54 +00:00
Jean Chalard
c2e9c511cb
Fix Binary dict tests
...
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.
The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.
All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.
Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
2013-04-15 12:48:16 +09:00
Tadashi G. Takaoka
a91da76683
Suppress calling onPressKey and onReleaseKey while detecting gesture
...
Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
2013-04-15 10:59:54 +09:00
Baligh Uddin
0dbc8c3509
am f2ab0adc: Import translations. DO NOT MERGE
...
* commit 'f2ab0adc5e3bd8f436aafcea1b396e288c69f7d4':
Import translations. DO NOT MERGE
2013-04-12 16:59:36 -07:00
Baligh Uddin
bfedad238f
Merge "Import translations. DO NOT MERGE"
2013-04-12 23:56:49 +00:00
Baligh Uddin
8515649312
Import translations. DO NOT MERGE
...
Change-Id: I2cb68d3f0804a0c9990916a89e079510b465253f
Auto-generated-cl: translation import
2013-04-12 13:26:13 -07:00
Baligh Uddin
f2ab0adc5e
Import translations. DO NOT MERGE
...
Change-Id: Ie74fdb8041ac5d7eb5d15a49f9aac834751cc9c2
Auto-generated-cl: translation import
2013-04-12 13:19:32 -07:00
Kurt Partridge
ededdc6a8b
Merge "Avoid NPE"
2013-04-12 18:10:49 +00:00
Jean Chalard
2cd1136b8e
Merge "Remove the dialog to insert words to the dictionary."
2013-04-12 12:33:24 +00:00
Jean Chalard
91bcf5eb5d
Merge "Restart suggestions when the cursor moves."
2013-04-12 12:27:50 +00:00
Jean Chalard
02ce3dc2d1
Fix a bug with bad application completions
...
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
2013-04-12 20:53:06 +09:00
Jean Chalard
6a114fa700
Restart suggestions when the cursor moves.
...
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
2013-04-12 20:49:03 +09:00
Jean Chalard
d24f939712
Merge "Make shortcut-only user dict entry non-words."
2013-04-12 11:02:00 +00:00
Jean Chalard
fb5869e9ff
Merge "Add a class to encapsulate getting the metadata URI"
2013-04-12 11:01:36 +00:00
Jean Chalard
6a2a4b8e4d
Make shortcut-only user dict entry non-words.
...
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
2013-04-12 16:17:09 +09:00
Jean Chalard
1a51833828
Remove the dialog to insert words to the dictionary.
...
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
2013-04-12 15:58:50 +09:00
Jean Chalard
d0623ad7f3
Merge "Move some values to a place where they are easier to override"
2013-04-12 02:53:41 +00:00
Kurt Partridge
2927223edd
Merge "Better isolate ResearchLogging data"
2013-04-11 21:56:01 +00:00
Jean Chalard
8987cccf89
Add a class to encapsulate getting the metadata URI
...
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
2013-04-11 17:52:16 +09:00
Jean Chalard
7ad078e89c
Move some values to a place where they are easier to override
...
Bug: 8418765
Change-Id: Iff0edd4ed8da9d0d1a6fb9545224b232ba374469
2013-04-11 17:35:23 +09:00
Tadashi G. Takaoka
cd692be1e1
Merge "Change the default vibration duration to 20msec"
2013-04-11 08:15:29 +00:00
Jean Chalard
b5d5190deb
Merge "Add some utility functions."
2013-04-11 07:35:22 +00:00
Tadashi G. Takaoka
e1416b4399
Change the default vibration duration to 20msec
...
Bug: 8556975
Change-Id: Ia6a0fe230585c9826199a0696fb0c1367e917134
2013-04-11 16:30:32 +09:00
Jean Chalard
1cbb0b8f2a
Add some utility functions.
...
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
2013-04-11 16:16:19 +09:00
Tadashi G. Takaoka
4f5f81d5f7
Reorder advanced settings menu
...
Bug: 8247224
Change-Id: I339f285304824b778635f435d8587893fc241c4e
2013-04-11 15:54:38 +09:00
Tadashi G. Takaoka
bd8e92d843
Add debug message to detect unusual zero width condition
...
Bug: 8452013
Change-Id: I0169dc6b0d08d1b4d9e01a5fa2ad01e9db292bda
2013-04-11 15:08:36 +09:00
Tadashi G. Takaoka
f67a388197
Merge "Add TypefaceUtils"
2013-04-11 05:32:58 +00:00
Tadashi G. Takaoka
08ae0d5ca0
Add TypefaceUtils
...
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
2013-04-11 14:27:42 +09:00
Tadashi G. Takaoka
6d0027a46a
Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>"
2013-04-11 05:06:35 +00:00
Tadashi G. Takaoka
cee512b63e
Merge "More precise geometry checking for more keys keyboard"
2013-04-11 03:51:42 +00:00
Jean Chalard
3722f0877e
Merge "Fix two bugs in dicttool"
2013-04-11 03:07:30 +00:00
Baligh Uddin
cfdc91b99a
am 58df3cfa: Import translations. DO NOT MERGE
...
* commit '58df3cfaeee020b6703f90feda89a3bc95a3a116':
Import translations. DO NOT MERGE
2013-04-10 19:35:52 -07:00
Tadashi G. Takaoka
9620943cc8
am d9a22235: Hide Setup Wizard icon for stock keyboard
...
* commit 'd9a2223570759d622c690b007369cf32f437f7e5':
Hide Setup Wizard icon for stock keyboard
2013-04-10 19:35:51 -07:00
Jean Chalard
1aaaa64da8
am 75618c33: am 19dcd154: Merge "Offer to add any OOV typed word to the dictionary."
...
* commit '75618c3321b8eae559886ba5f71e967591da7065':
Offer to add any OOV typed word to the dictionary.
2013-04-10 19:35:50 -07:00
Jean Chalard
0d72a23054
am 04bb419c: am ddafcf82: Merge "Fix bugs and add tests"
...
* commit '04bb419c3290d059c5ccd5e1eda8600d44a0a69d':
Fix bugs and add tests
2013-04-10 19:35:48 -07:00
Kurt Partridge
bea42fc5bd
am 5bd24642: am 1f70a4d6: Merge "Allow logging while replaying"
...
* commit '5bd2464297db3035b93410c5359accbda74e9f50':
Allow logging while replaying
2013-04-10 19:35:47 -07:00
Kurt Partridge
41a049a410
am ae144fe9: am d117c1a1: Merge "Do not record log split time when handling separator"
...
* commit 'ae144fe9c3a6c80150c11d96da84f5868f44ab8a':
Do not record log split time when handling separator
2013-04-10 19:35:45 -07:00
Ken Wakasa
4c896a2fe8
am f71b9640: am d17c8bd9: Update comments
...
* commit 'f71b96406391fc00c1d3dc45e6b3e827f3595842':
Update comments
2013-04-10 19:35:44 -07:00
Ken Wakasa
34cff46a9c
am ed8fd94e: am 370461ef: Clean up a few option strings under the Advanced settings
...
* commit 'ed8fd94e3c4fd16c0c767c1a45f46461313bdcb8':
Clean up a few option strings under the Advanced settings
2013-04-10 19:35:37 -07:00
Jean Chalard
024d0e4abf
am f10e7cbe: am e9f69e16: Merge "Move a generic string utility to StringUtils"
...
* commit 'f10e7cbe96596971be5de6592c9cab0aba9ad764':
Move a generic string utility to StringUtils
2013-04-10 19:35:36 -07:00
Tadashi G. Takaoka
a4463d7a9a
More precise geometry checking for more keys keyboard
...
Bug: 8484528
Change-Id: I0dd09530a5262fee9c19bb0f11d5830b00306944
2013-04-11 10:44:54 +09:00
Kurt Partridge
cdaee868a3
Merge "Preserve a class for testing"
2013-04-10 23:45:33 +00:00
Kurt Partridge
3684036eed
Preserve a class for testing
...
Addresses b/8583091
Change-Id: I89605223784312d9572dfc7c8aaa7e5eba44c4f6
2013-04-10 16:40:17 -07:00
Kurt Partridge
099dd3f277
Merge "Better release build reporting"
2013-04-10 22:51:21 +00:00
Baligh Uddin
cc42e139c3
Import translations. DO NOT MERGE
...
Change-Id: Icb4c4f32b1549f3d98b99a48b7c2f1b0de1b5a04
Auto-generated-cl: translation import
2013-04-10 13:25:52 -07:00
Baligh Uddin
58df3cfaee
Import translations. DO NOT MERGE
...
Change-Id: Iafc0a5506abef8e709d76ebf4600bacae7dd1e00
Auto-generated-cl: translation import
2013-04-10 13:21:21 -07:00
Kurt Partridge
6108624a00
Better isolate ResearchLogging data
...
Calls to LatinIME#onStartInputViewInternal log important information
about the context in which an IME is used. This is reported as a
single LogStatement. Previously, this was not placed into a separate
LogUnit, and was mixed in with general word data. This change wraps
this LogStatement in its own LogUnit.
Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
2013-04-10 11:53:38 -07:00
Kurt Partridge
dfa5628cd3
Better release build reporting
...
The ResearchLogger reports whether a build is a release build or not
to avoid polluting data with IME debugging work by developers.
Previously this was done by checking a constant flag, which was also
serving the dual purpose of masking out debug code in release builds.
This change introduces a heuristic to determine whether a build was
created by a developer (using the package versionName), and annotating
the data sent to the server appropriately.
Change-Id: Icbad17c66b703cabf6d23d05e2c7c41bcceaae45
2013-04-10 11:52:37 -07:00
Jean Chalard
ca0fdbbe2e
Fix two bugs in dicttool
...
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.
Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
2013-04-10 22:10:31 +09:00
Jean Chalard
fb3e805722
Merge "Fix a bug where a space would not be inserted before a gesture"
2013-04-10 11:19:31 +00:00
Jean Chalard
30b8004b56
Fix a bug where a space would not be inserted before a gesture
...
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
2013-04-10 20:10:28 +09:00
Tadashi G. Takaoka
c7d4158979
Merge "Use private object as a lock instead of synchronized method"
2013-04-10 09:56:27 +00:00
Tadashi G. Takaoka
12e77de212
Merge "Use private lock object instead of synchronized method"
2013-04-10 09:35:12 +00:00
Tadashi G. Takaoka
1e256f5888
Merge "Protect simultaneously modifying gesture preview data"
2013-04-10 09:34:59 +00:00
Tadashi G. Takaoka
951ea3c06d
Use private object as a lock instead of synchronized method
...
Change-Id: I0b9a935d8c97ddfb18ab7950a9d6bf542863072a
2013-04-10 18:34:01 +09:00
Tadashi G. Takaoka
ce811f50d2
Use private lock object instead of synchronized method
...
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
2013-04-10 18:27:11 +09:00
Tadashi G. Takaoka
ad205b2e3f
Protect simultaneously modifying gesture preview data
...
Bug: 8556775
Change-Id: I83272e3adbfc0c9cc14f9e8b479e926aabf4fa2a
2013-04-10 18:18:54 +09:00
Jean Chalard
99b93d17d5
Fix a bug where autocorrection status would be wrong.
...
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
2013-04-10 17:49:19 +09:00
Tadashi G. Takaoka
262d5bd9f9
Don't override EXTRA_SHOW_FRAGMENT if exists
...
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
2013-04-10 16:24:17 +09:00