nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge "Remove unnecessary harmful finish() from SettingsActivity"

Browse source
This commit is contained in:
Tadashi G. Takaoka 2013-04-15 07:32:04 +00:00 committed by Android (Google) Code Review
commit 4b6756db3c
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
java/src/com/android/inputmethod/latin/SettingsFragment.java
View file

@ -16,7 +16,6 @@
package com.android.inputmethod.latin;
import android.app.Activity;
import android.app.backup.BackupManager;
import android.content.Context;
import android.content.Intent;
@ -115,12 +114,8 @@ public final class SettingsFragment extends InputMethodSettingsFragment
if (FeedbackUtils.isFeedbackFormSupported()) {
feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() {
@Override
public boolean onPreferenceClick(Preference arg0) {
final Activity activity = getActivity();
FeedbackUtils.showFeedbackForm(activity);
if (!activity.isFinishing()) {
activity.finish();
}
public boolean onPreferenceClick(final Preference pref) {
FeedbackUtils.showFeedbackForm(getActivity());
return true;
}
});