nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
5421 commits 1 branch 0 tags 363 MiB
Commit graph

2294 commits

Author SHA1 Message Date
Tadashi G. Takaoka
2764e1dffe Merge "Remove duplicate logic from KeyboardSwitcher and KeyboardState" 2012-01-16 20:22:34 -08:00
Tadashi G. Takaoka
06b7c256b1 Add "force non-distinct multitouch" debug option 
Change-Id: I9fd6fabf03515011cedb8aaa30fdb7a77f2d4d12
 2012-01-17 13:19:01 +09:00
Jean Chalard
a8ba49c253 Small cleanup 
The method deleteWordAtCursor would call finishComposingText,
which is a very unexpected state change and would probably cause
surprising bugs to any parent that would call it.
As it happens, it's not used anywhere any more so let's just
remove it.

Change-Id: Iaa9200866e40b4e914f76baa987279948300679c
 2012-01-17 11:55:23 +09:00
Jean Chalard
72d285f4d7 Add some comments about resuming auto-suggestion 
Bug: 5846646
Change-Id: Ib2c76ec173972eb7acadbfaae7e930849d546721
 2012-01-17 10:29:11 +09:00
Tadashi G. Takaoka
58e782a225 Remove duplicate logic from KeyboardSwitcher and KeyboardState 
Change-Id: I1d331ee7f71501baa4ec2df01df39340499834e4
 2012-01-16 19:16:26 +09:00
Tadashi G. Takaoka
7bc61ca183 Fix double tap shift key to turn off capslock mode 
Bug: 5873562
Change-Id: If1f5ae1684905c1418ae43e55df38509444d29e2
 2012-01-16 18:54:25 +09:00
Tadashi G. Takaoka
9751a626ec Don't cache resource value that depends on orientation 
Bug: 5794655
Change-Id: Ib324366c772e20bb54aba63c2f4540dc0f9de515
 2012-01-16 12:26:34 +09:00
Tadashi G. Takaoka
c88026e1df Update shift state when alphabet keyboard has been set 
Bug: 5857492
Change-Id: I5ef78af21a76e8cf645e223d1ffa6212690bb1eb
 2012-01-16 11:08:29 +09:00
Tadashi G. Takaoka
ca132ce8e2 Merge "Remove reference of SubtypeSwitcher and SettingsValues from KeyboardSet" 2012-01-13 01:39:50 -08:00
Tadashi G. Takaoka
211680e375 Merge "Fix SuggestTests" 2012-01-13 01:39:43 -08:00
Tadashi G. Takaoka
4087ba69fa Remove reference of SubtypeSwitcher and SettingsValues from KeyboardSet 
Change-Id: I6c1150eea5f0a931d01578b0157f06e0aff0cc65
 2012-01-13 18:05:28 +09:00
Tadashi G. Takaoka
9c735b8038 Fix SuggestTests 
We need revised scoring test because dictionary look up algorithm has
been changed significantly since this SuggestTests was made.

Change-Id: I69d527a6bfa24ed0dc189fddad1afab0566c6eb8
 2012-01-13 15:25:28 +09:00
Tadashi G. Takaoka
76dede6b3b Merge "Fix SubtypeLocaleTests" 2012-01-12 22:17:20 -08:00
Tadashi G. Takaoka
4015a64a26 Fix SubtypeLocaleTests 
Change-Id: Id85814aa3bcd9cacbe446b2dfda3ca2ab9146c13
 2012-01-13 14:35:43 +09:00
satok
4da8e8e4d3 Merge "Fix a bug in the logic to show 3 dots of the ime switcher" 2012-01-12 19:41:12 -08:00
satok
83a018419a Fix a bug in the logic to show 3 dots of the ime switcher 
Bug: 5806103
Change-Id: I67b3f0bb25d5fb9cfb902c03f41ae3e582107187
 2012-01-13 11:50:31 +09:00
satok
21814c56f0 Merge "Move auto correction thresthold to the native code" 2012-01-12 02:58:35 -08:00
satok
be0cf72253 Move auto correction thresthold to the native code 
bug: 5858137

Change-Id: Ic4b6270c6e51ef4ed25a6a1d8ddd7fdfa70fd78d
 2012-01-12 19:56:15 +09:00
Jean Chalard
ab34a4a7f5 Merge "Fix a bug where last candidate would not be reset" 2012-01-11 21:47:35 -08:00
Jean Chalard
cda8a42cbe Merge "Add a sanity check" 2012-01-11 21:47:26 -08:00
Jean Chalard
a8c8ab1cb4 Remove an excessive parens 
Change-Id: If8aa4253ab0f664e628ed7f4d7a3adc02a898cc7
 2012-01-12 14:07:56 +09:00
Jean Chalard
852630ba34 Add a sanity check 
Check if any character is both a magic space swapper and
a magic space stripper for the current language, and throw
an exception if found. Since this is expensive, it's done
only in debug mode.

Change-Id: Ibd166db87c91495b76878ea0e4f420a62c7bb276
 2012-01-12 12:44:49 +09:00
Jean Chalard
9de5cfc67a Fix a crash where revertSwap would be wrongly called 
This would crash the program when inputting a punctuation
symbol that should not swap with a weak space through the
suggestion strip, then press backspace.
Those include all two-part punctuation symbols in French for
example, as well as magic space strippers like the dash in
English. For English all suggestion strips symbols happen to
be magic space swappers so this would not happen in English
by default.
Also fix a typo.

Change-Id: Ia40678c264e978509b5786290a75a3c57181648e
 2012-01-12 11:55:40 +09:00
Jean Chalard
cd2286fff1 Fix a bug where last candidate would not be reset 
Bug: 5851148
Change-Id: Ic270318842d8e16bc62d78d5fe0d6be0ca1fb532
 2012-01-12 11:16:51 +09:00
Tadashi G. Takaoka
8cab0b56eb Get rid of Keyboard.CODE_DUMMY 
Change-Id: Id2320f4d9b5f22f0ac844ab20ce42b0c4e7c6880
 2012-01-10 18:19:36 +09:00
Tadashi G. Takaoka
ee4be6e3c6 Call KeyboardState.onUpdateShiftState from onCodeInput if code is a normal letter 
This will be helpful to write unit test code.

Change-Id: Ib61cc46ac547084e0dc9ecd3a50814fecf08ace2
 2012-01-10 15:13:05 +09:00
Tadashi G. Takaoka
0fe45eac18 Merge "Optimize KeybaordView.invalidateAllKeys a bit" 2011-12-26 06:50:31 -08:00
Tadashi G. Takaoka
9f6485a448 Optimize KeybaordView.invalidateAllKeys a bit 
Change-Id: I118c792219f649b7297477c78fa725c678650159
 2011-12-26 23:43:53 +09:00
Tadashi G. Takaoka
07145a3706 Fix automatic temporary upper case mode shift key graphics 
Bug: 5802387
Change-Id: I4f59fb2f971c543748ed32b37af528767a0549e4
 2011-12-26 21:05:33 +09:00
Ken Wakasa
0d0f01da67 Fix a typo. A follow up to I68dd6b8d 
Change-Id: I16fa4099c75faac35344b0e4d3c2b866ddac896a
 2011-12-21 22:34:08 +09:00
Jean Chalard
0fd625bcfd Fix a bug with wrong auto-correct cancellation 
Auto-correct cancellation would sometimes kick in at
wrong times, causing crashes.

Bug: 5784542
Change-Id: I68dd6b8d9237ce9b66af2dc63e77ba6dd5fd69dd
 2011-12-21 19:28:02 +09:00
Jean Chalard
752d8cc4fc Fix a bug with TYPE_TEXT_CLASS 
This was introduced by a badly-rebased commit. The culprit was
I103d6851. There was also another bug lurking there introduced
by a previous commit that this fixes.

Bug: 5775347
Change-Id: I133b54a5159e19714f4bcae8ffbb4824cff9f466
 2011-12-20 15:31:55 +09:00
Jean Chalard
715a203501 Merge "Reorganize the auto-correction memory" 2011-12-19 02:22:49 -08:00
Ken Wakasa
4f7d278af6 Follow-up fix for I68c667b0 
Should have preserved the logic of LatinKeyboard.getNearestKeys().

Change-Id: I97b05aa24006402be03088a215fa07abda9477df
 2011-12-19 17:58:36 +09:00
Jean Chalard
9e8761c440 Reorganize the auto-correction memory 
Change-Id: I31cce9db471dcd4a7b3477bcb037a8ff482b7696
 2011-12-19 17:33:15 +09:00
Tadashi G. Takaoka
42fcb2de64 Get rid of public reference to KeyboardIconsSet.ICON_* constants 
As a consequence,
  * Add Key.iconDisabledKey has been introduced and Key.getIcon honors
    the enabled state of the key.
  * The attribute id of disabled icon for shortcut key,
    Keyboard_iconShortcutKeyDisabled, is renamed to
    Keyboard_iconDisbledShortcutKey
  * KeyboardIconsSet has getIconByIconId and getIconByAttrId methods
    instead of getIcon.

Bug: 5778201
Change-Id: Ica93b073b9a04acd18ead7a33b60e3c6d813e7a1
 2011-12-19 01:11:09 +09:00
Tadashi G. Takaoka
4e1dab8cfa Move KeyboardBuilder and KeyboardParams classes into Keyboard class 
This change also moves XmlParseUtils to com.android.inputmethod.latin package.

Bug: 5778201
Change-Id: I7d9faa344460753ce178ad4048e0fadb65c75614
 2011-12-18 20:19:16 +09:00
Tadashi G. Takaoka
3708787fe9 Remove LatinKeyboard class 
Change-Id: I68c667b00dadf2ed9f1c62fb7da37d2cf499cd81
 2011-12-18 19:10:42 +09:00
Tadashi G. Takaoka
4112dc0500 Move spacebar drawing code from LatinKeyboard to LatinKeyboardView 
Also this change moves LatinKeyboard attributes,
autoCorrectionSpacebarLedEnabled, autoCorrectionSpacebarLedIcon,
spacebarTextRatio, spacebarTextColor, and spacebarTextShadowColor to
LatinKeyboardView.

Change-Id: I7cc27ce1fc550e9f620a9ed0fbe4b8172902d5a1
 2011-12-18 19:07:12 +09:00
Tadashi G. Takaoka
7bd714c086 Add extra key icons to KeyboardIconsSet 
* Get rid of Key.keyIconShifted attribute.
    Add Keyboard.iconShiftKeyShifted to KeyboardIconsSet.
  * Get rid of LatinKeyboardView.disabledShortcutIcon attribute.
    Add Keyboard.iconShortcurKeyDisabled to KeyboardIconsSet.
  * Add Keyboard.iconSpaceKeyForNumber to KeyboardIconsSet.
  * Fix misplaced autoCorrectionSpacebarLedIcon resources.

Change-Id: I381bff3789254977ab3cb18f58f95b3c433b1e1a
 2011-12-18 18:25:29 +09:00
Tadashi G. Takaoka
1ebedd7a15 Remove LatinKeyboard.adjustLabelCase override 
Change-Id: If032605c1cd6bb8e913d465e20dec70798c4b8fb
 2011-12-18 16:46:44 +09:00
Tadashi G. Takaoka
5afc3ae2d9 Add LatinKeyboardView style 
As a result, this change moves shortcut related update code to
LatinKeyboardView from LatinKeyboard.

Change-Id: I1882672577f61e73c90d6c018b7dbb61f3fe21e4
 2011-12-18 16:42:23 +09:00
Tadashi G. Takaoka
22b48de11c Get rid of Key.needsSpecialPopupHint and related 
Change-Id: I28e87ea3af9581f12094770b42f113e9018886c4
 2011-12-18 16:08:28 +09:00
Tadashi G. Takaoka
bc781e963f Can override key drawing methods of KeyboardView 
Change-Id: Ie303df4f5e944ea868f5c28ba3bb72a57cc9a35f
 2011-12-18 16:08:00 +09:00
Tadashi G. Takaoka
605f730959 Merge "Add LatinKeyboard.spacebarTextRatio attribute" 2011-12-17 08:43:34 -08:00
Tadashi G. Takaoka
40a6739645 Fix broken build 
This is a followup change of I8376f4f5

Change-Id: I4de4cbc903beb71d805e62b5172076a949854bc0
 2011-12-18 01:36:11 +09:00
Tadashi G. Takaoka
7cc2595b6f Add LatinKeyboard.spacebarTextRatio attribute 
Bug: 5776979
Change-Id: Ia568d1170ed33a000eb3bb02ecdf611e4b5ff2d5
 2011-12-18 01:00:06 +09:00
Tadashi G. Takaoka
ebec5259b7 Get rid of LatinKeyboardParam class 
Change-Id: I8376f4f570e72929679c5e4955986c48881abd75
 2011-12-18 00:39:40 +09:00
Ken Wakasa
67394a394f Preparatory small clean up for bug: 5776979 
Change-Id: I96b20d3775180366fac50c2bb4e0b47a92ee4cdb
 2011-12-17 20:45:39 +09:00
Ken Wakasa
3425852be4 Remove redundant logs 
bug: 5722703
Change-Id: I6b7285ad6f5c0c8486d24712f22249f83a1c6396
 2011-12-17 00:22:01 +09:00
Tadashi G. Takaoka
4af75010a1 Merge "Use Set to group Keys in Keyboard instead of List" 2011-12-16 04:26:25 -08:00
Tadashi G. Takaoka
7c69397f14 Merge "Fix swapped alphabet and symbols keyboards" 2011-12-16 04:15:35 -08:00
Tadashi G. Takaoka
510ebb9b16 Merge "Get rid of key index from ProxymityInfo" 2011-12-16 04:13:38 -08:00
Tadashi G. Takaoka
854302282d Fix swapped alphabet and symbols keyboards 
Change-Id: I956684332d607cb9ab01d12af7a924c15def7fce
 2011-12-16 21:12:06 +09:00
Tadashi G. Takaoka
4a019a9c96 Use Set to group Keys in Keyboard instead of List 
In deriving various shift stated alphabet keyboards from base/main
keyboard, almost all keys should be shared among variants.  Grouping
keys in Set instead of List is a essential refactor to have.

Bug: 5002108
Bug: 5679585
Change-Id: Idd5644d1c45a3276a24b61c984619c03d4e4c54c
 2011-12-16 21:04:04 +09:00
Tadashi G. Takaoka
0c0ca874fe Get rid of key index from ProxymityInfo 
Change-Id: I9bee0a643d09cdd89e42ae913285c9e78d875c1c
 2011-12-16 21:03:36 +09:00
Jean Chalard
43c0a034bd Merge "Pretty print for InputAttributes" 2011-12-16 04:01:49 -08:00
Jean Chalard
4d0f03bd66 Remove a write-only variable. 
Change-Id: I825307a429f46b31ed9bd940b5a97d2713127dfe
 2011-12-16 20:54:58 +09:00
Jean Chalard
6fa003ee23 Pretty print for InputAttributes 
Change-Id: I5e4b2b6f3cd943c8f6187aaed21d67ec786bf5df
 2011-12-16 20:53:44 +09:00
Jean Chalard
2b2c0b574c Merge "Use the WordComposer to check if we are composing a word" 2011-12-16 03:47:34 -08:00
Jean Chalard
80b66bb166 General cleanup. 
Move variables around, inline useless functions, remove
useless local variables.

Change-Id: Icb89d8b211a2ad4bc3619137c2276a649c2a5e34
 2011-12-16 20:36:32 +09:00
Jean Chalard
644c8b7c96 Initialize input attributes in the InputAttribute class 
Change-Id: I103d6851f54f47cbffdb567fb0f4c505c4697b05
 2011-12-16 20:35:16 +09:00
Jean Chalard
3b7aceca60 Merge "Make applicationSpecifiedCompletionOn final." 2011-12-16 03:20:00 -08:00
Tadashi G. Takaoka
bf7ed75e4f Merge "Move KeyboardSwitcher.getKeyboard to KeyboardSet" 2011-12-16 03:13:38 -08:00
Tadashi G. Takaoka
645128af71 Move KeyboardSwitcher.getKeyboard to KeyboardSet 
This change also gets rid of XML id from KeyboardId.

Bug: 5002108
Bug: 5679585
Change-Id: I7086c7da3c01ba4ade7f77ee5cc731310da46404
 2011-12-16 20:10:57 +09:00
Jean Chalard
ccc35f7fa7 Make applicationSpecifiedCompletionOn final. 
This is the last one (whew)
Also move a somewhat unrelated initialization out of the
input attribute initialization function.

Change-Id: Icc77b32fd16b112ab43786715061b1c9dca31c04
 2011-12-16 19:09:01 +09:00
Jean Chalard
9cc1312eee Make inputTypeAutoCorrect final. 
Change-Id: I550eba1fc3fa2843d007a8208d81fad208c1196b
 2011-12-16 19:08:52 +09:00
Jean Chalard
13db05f930 Make isSettingsSuggestionStripOn final. 
Change-Id: Iabb99a7f8f3f1777f9a87ae2bddff9795a50fa92
 2011-12-16 19:08:13 +09:00
Jean Chalard
1ba17f97d5 Small refactoring 
This helps to make following changes smaller

Change-Id: I95ba2901ac3bf1ed70a748c35a0babdd9af1df63
 2011-12-16 18:21:26 +09:00
Jean Chalard
4fc0f6ab02 Merge "Make insertSpaceOnPickSuggestionManually final." 2011-12-16 01:15:35 -08:00
Jean Chalard
2ad14a2ea7 Merge "Use temporary variables for computing editor attributes" 2011-12-16 01:07:56 -08:00
Jean Chalard
520e69056e Merge "Create a class for input attributes." 2011-12-16 01:06:12 -08:00
Jean Chalard
ae0c109d11 Make insertSpaceOnPickSuggestionManually final. 
Change-Id: I32fce0ea8c5c58b6f920d0758c8bf57769f39a12
 2011-12-16 18:04:39 +09:00
satok
cadc0f7d79 Merge "Send touch event in usability study mode" 2011-12-16 01:04:26 -08:00
Jean Chalard
4e8922f1be Use temporary variables for computing editor attributes 
The ultimate intent is to make these variables final,
which will allow to move the computing function to the
InputAttributes class.

Change-Id: Ifb1fc7321a19b10d60aa63fa0daaa2708deda2cf
 2011-12-16 18:04:17 +09:00
Jean Chalard
dc9d0fcc11 Create a class for input attributes. 
Change-Id: I834390c83865aac59fb758d5c66cf9b74103abd8
 2011-12-16 18:03:16 +09:00
satok
15d4793911 Send touch event in usability study mode 
Change-Id: I0cdcd57bfd31c9b21cfb932d7ff91bd013cde6d7
 2011-12-16 17:56:14 +09:00
Tadashi G. Takaoka
289544d6e4 Use Params instead of Builder as an argument of KeyboardSet constructor 
Change-Id: I4c576a0b0b632cdf413f2ccd5c69dbd37747fbd3
 2011-12-16 16:41:49 +09:00
Jean Chalard
196d82cdd7 Use the WordComposer to check if we are composing a word 
...instead of the hard-to-understand mHasUncommittedTypedChars.
This is possible because now the word composer is actually aware
of commits.

Change-Id: I36b664ce8402a280f801e87b9ebe161f416b0853
 2011-12-16 15:58:29 +09:00
Tadashi G. Takaoka
6ba5f0d341 Merge "Add error log to expensive ArraysCompatUtils.binarySearch" 2011-12-15 22:55:10 -08:00
Jean Chalard
be2f81f055 Merge "Make the word composer aware of commits." 2011-12-15 22:54:23 -08:00
Jean Chalard
c73c26790f Make the word composer aware of commits. 
Change-Id: I04e691fbc9227d4df195429bca89edea93575347
 2011-12-16 15:41:10 +09:00
Tadashi G. Takaoka
f8481883cc Add error log to expensive ArraysCompatUtils.binarySearch 
Change-Id: Id33998e2a99be9249de4011892555f10c5d0968d
 2011-12-16 15:34:11 +09:00
Tadashi G. Takaoka
cfd5b4811f Merge "Cleanup ProximityInfo.calulateSweetSpot" 2011-12-15 22:21:17 -08:00
Tadashi G. Takaoka
f1e05e74e6 Merge "Add com.android.inputmethod.latin.suggestions package" 2011-12-15 22:00:05 -08:00
Tadashi G. Takaoka
6cb72b0f36 Cleanup ProximityInfo.calulateSweetSpot 
Change-Id: I98238359dffd76a620d3b0e73b3b22dd82c56c93
 2011-12-16 14:59:24 +09:00
Tadashi G. Takaoka
8c3d5b6961 Add com.android.inputmethod.latin.suggestions package 
Change-Id: If4b823768ab9c073625da3034ecc8091be1df230
 2011-12-16 14:21:44 +09:00
Tadashi G. Takaoka
8950f259b1 Merge "Make Key.mPreviewIcon public final" 2011-12-15 21:20:46 -08:00
Tadashi G. Takaoka
0b6237da94 Make Key.mPreviewIcon public final 
Change-Id: I280b1fa6a018e095e9b36ea5475dde68e0965350
 2011-12-16 12:47:34 +09:00
Tadashi G. Takaoka
a44685ab32 Add colorValidTypedWord and alphaValidTypedWord 
This change fixes Gingerbread theme.

Change-Id: I142437ac0173df48ab36390f47ed67c6cea24a65
 2011-12-16 12:26:19 +09:00
Tadashi G. Takaoka
e9a0efc242 Merge "Cleanup unused variables and parameters" 2011-12-15 18:02:38 -08:00
Tadashi G. Takaoka
2ac5988f84 Cleanup unused variables and parameters 
Change-Id: Iad756a7a775c93f3344c6962e7b3456ef8339490
 2011-12-15 20:26:12 +09:00
Jean Chalard
05f654d498 Merge "Group all input-related info into an inner class." 2011-12-15 03:21:47 -08:00
Tadashi G. Takaoka
c3ef86d861 Merge "Fix auto correction spacebar LED" 2011-12-15 03:19:32 -08:00
Jean Chalard
27dff63833 Group all input-related info into an inner class. 
Currently, these variables hold the info about the composing
word, or maybe some outdated info, and it's not very clear
which it is. LatinIME is maintaining the freshness info in
a separate boolean, and uses it throughout the code for many,
many things, leading to much confusion.
The idea in grouping this info is, it can be saved in another
instance and restored later. It can be tested against to know
whether there is actually outdated but kept info or not, and
it should allow to straighten out what is actually currently
being typed. Ultimately, it will eliminate the need for
LatinIME to keep track of the status of the info in the
word composer.

Change-Id: I00e2c690f303f8320c9be35590a6df4583e9e456
 2011-12-15 19:58:04 +09:00
Tadashi G. Takaoka
2d74806262 Change visibility to avoid synthetic accessor method 
Change-Id: Ie93c7437fb9a3fe63adaa48c2d4a723f96c0a0e1
 2011-12-15 19:50:53 +09:00
Tadashi G. Takaoka
23d27fefcb Fix auto correction spacebar LED 
Change-Id: I4894d188d5612380cc9f8eec7cb72544e37fb2b0
 2011-12-15 17:34:14 +09:00
Tadashi G. Takaoka
b8c2c6e2ec Merge "Add XmlParseUtils class" 2011-12-14 03:02:17 -08:00
Tadashi G. Takaoka
d549d4334f Merge "Remove long press settings key function" 2011-12-14 03:02:09 -08:00
Tadashi G. Takaoka
17dc10724b Remove long press settings key function 
Bug: 5759092
Change-Id: I328e2043075ce5d0d0285febc4a9b7356702c250
 2011-12-14 19:47:17 +09:00
Tadashi G. Takaoka
4665463ccd Add XmlParseUtils class 
Change-Id: Ie288272bc75832db7d743262c4c4fbe73b6dca04
 2011-12-14 19:46:03 +09:00
Tadashi G. Takaoka
6652e45899 Merge "Move Keyboard.themeName to KeyboardSwitcher and make it private" 2011-12-14 02:43:06 -08:00
Tadashi G. Takaoka
90c12077b2 Merge "Remove EditorInfo from KeyboardId" 2011-12-14 02:42:58 -08:00
Tadashi G. Takaoka
7a91deb685 Move Keyboard.themeName to KeyboardSwitcher and make it private 
Change-Id: I101b6927d43e86b3c636c1a527e181df8af9c73e
 2011-12-14 19:01:20 +09:00
Tadashi G. Takaoka
a042150a69 Merge "Just ignore settings/shortcut key while typing on tablet" 2011-12-14 01:59:46 -08:00
Tadashi G. Takaoka
2d603fff64 Remove EditorInfo from KeyboardId 
Change-Id: I70919ff30622afa1d8c29ca45589fa617f2c1f0e
 2011-12-14 18:58:55 +09:00
Jean Chalard
9750165c9a Merge "Cleanup" 2011-12-14 01:50:25 -08:00
Tadashi G. Takaoka
014b755f8a Merge "Cleanup KeyboardId's hasCode method" 2011-12-14 01:48:46 -08:00
Jean Chalard
f3ca6a59a7 Cleanup 
Change-Id: I724df0be7ac07ffb9f1f4974175aed5a2606221b
 2011-12-14 18:42:47 +09:00
Tadashi G. Takaoka
601e411c13 Cleanup KeyboardId's hasCode method 
Change-Id: I5fd8f6ac0f42152fb0e2aaaedc6092f6d82fe677
 2011-12-14 18:42:20 +09:00
Jean Chalard
64361bd66d Merge "Move some code inside a function to simplify flow" 2011-12-14 01:42:17 -08:00
Jean Chalard
676917dea2 Merge "Fail faster in case of a bug" 2011-12-14 01:42:05 -08:00
Tadashi G. Takaoka
2c4b21d7ca Merge "Cleanup settings key related stuff" 2011-12-14 01:36:34 -08:00
Jean Chalard
1c6cf26c37 Move some code inside a function to simplify flow 
Also rename the function to reflect better the behavior.
An upcoming change will clean up the remnants

Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
 2011-12-14 17:56:57 +09:00
Jean Chalard
46798d8f1f Fail faster in case of a bug 
Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
 2011-12-14 17:54:18 +09:00
Tadashi G. Takaoka
623d0155b6 Just ignore settings/shortcut key while typing on tablet 
Bug: 5759096
Change-Id: Ie1f1800d0f32ac0938715c79974e0f382c9c3d27
 2011-12-14 17:14:44 +09:00
Jean Chalard
b588003426 Refactoring. 
Small simplification of the code.

Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
 2011-12-14 16:59:25 +09:00
Tadashi G. Takaoka
8b1b8aae9c Cleanup settings key related stuff 
Change-Id: Ie0d1204e94fcdf9d578974256bf2ae3e87797f13
 2011-12-14 16:34:35 +09:00
Tadashi G. Takaoka
e35e13fc7d Merge "Record onStartInputView" 2011-12-13 23:31:43 -08:00
Tadashi G. Takaoka
689b901156 Merge "Utilize KeyboardSet XML definitions" 2011-12-13 23:31:00 -08:00
Jean Chalard
dbdb385bb0 Merge "Fix a long-standing race condition." 2011-12-13 23:29:47 -08:00
Tadashi G. Takaoka
f86109ca56 Utilize KeyboardSet XML definitions 
This change introduces KeyboardSet and SubKeyboard XML definitions to
represent a set of keyboard layouts.

Bug: 5002108
Bug: 5679585
Change-Id: Ib6c8d5936187381bb6725c9fe574e93871c01a86
 2011-12-14 16:28:31 +09:00
Jean Chalard
514beb0992 Fix a long-standing race condition. 
Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.

Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
 2011-12-14 16:24:18 +09:00
Tadashi G. Takaoka
7ef235f53f Record onStartInputView 
Bug: 5722703
Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
 2011-12-14 16:22:30 +09:00
Jean Chalard
8e3faff244 Merge "Decouple member logic from control flow" 2011-12-13 06:28:48 -08:00
Jean Chalard
7b5bc1ff4d Decouple member logic from control flow 
This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.

Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
 2011-12-13 23:15:12 +09:00
Jean Chalard
f7d6517d6b Various mini-cleanups 
- Stop the word composer from escaping - take a page from the law
  of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.

Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
 2011-12-13 23:09:22 +09:00
Jean Chalard
edf4995a3b Merge "Remove the input connection sidework from handleCharacter" 2011-12-13 04:28:30 -08:00
Jean Chalard
dafa7a8e15 Remove the input connection sidework from handleCharacter 
Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
 2011-12-13 21:12:07 +09:00
Jean Chalard
117fc93f37 Move mBestWord to the word composer. 
mBestWord has a confusing name - it's actually an auto-correction.
It's cleaner if it lives in the word composer because an
auto-correction should be tied to a specific user input, and
should be reset each time the user input changes to avoid
race conditions.

Change-Id: I718d29395bc747372067e6440e090c6a181994ae
 2011-12-13 21:06:51 +09:00
Jean Chalard
7e6f4daa19 Merge "Tighten conditions for space-related cancelling" 2011-12-13 01:23:15 -08:00
Jean Chalard
c525750835 Merge "Consolidate underlining code under one function." 2011-12-13 01:22:08 -08:00
Tadashi G. Takaoka
cfe264bfee Merge "Introduce KeyboardSet to hold related KeyboardIds" 2011-12-13 01:12:10 -08:00
Tadashi G. Takaoka
c42f285b35 Introduce KeyboardSet to hold related KeyboardIds 
This change moves
  * KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and
    KeyboardSet.getKeyboardId.
  * KeyboardSwitcher.getF2KeyMode to KeyboardSet.
This is the first step to get rid of shift state from Keyboard.

Bug: 5002108
Bug: 5679585
Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
 2011-12-13 18:10:50 +09:00
satok
3dcba4279a Merge "Extract the jni library name" 2011-12-13 00:46:16 -08:00
Jean Chalard
77d59b0691 Consolidate underlining code under one function. 
Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
 2011-12-13 17:42:27 +09:00
Jean Chalard
8ad4013406 Tighten conditions for space-related cancelling 
Instead of ignoring silently a found bug, throw an exception.

Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
 2011-12-13 17:40:06 +09:00
Tadashi G. Takaoka
77ecf52a08 Merge "Remove KeyboardSwitcher.updateShiftLockState method" 2011-12-13 00:27:01 -08:00
satok
ba526e3157 Extract the jni library name 
Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
 2011-12-13 17:25:43 +09:00
Tadashi G. Takaoka
34f1820396 Remove KeyboardSwitcher.updateShiftLockState method 
Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
 2011-12-13 16:57:23 +09:00
Jean Chalard
14cb8448df Remove a useless return 
Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
 2011-12-13 16:48:28 +09:00
Jean Chalard
8e404536cd Merge "Simplification" 2011-12-12 23:39:12 -08:00
Jean Chalard
cf5cecccfe Merge "Refactoring" 2011-12-12 23:39:00 -08:00
Jean Chalard
024ee9ff02 Merge changes I7888797c,I57b2232f 
* changes:
  Refactor + small bugfix
  Refactoring
 2011-12-12 23:38:17 -08:00
Jean Chalard
2939063947 Simplification 
Both tests have the same meaning. They should be merged.
Also, if "deleteLast()" deletes more than one char (which
never happens in the current implementation, but it's not
guaranteed), the new code is more correct.

Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
 2011-12-13 16:06:00 +09:00
Jean Chalard
d2c69c7d12 Refactoring 
If mHasUncommittedTypedChars is true, then
mWordSavedForAutoCorrectCancellation must always be null, and
spaceState must always be SPACE_STATE_NONE.
Hence, this change is supposed to be very no-op.

Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
 2011-12-13 16:04:11 +09:00
Jean Chalard
2245c3b5b3 Refactor + small bugfix 
postUpdateShiftKeyState used to be called also when
mEnteredText is not null => this is a bugfix.
The rest does not change the logic, as posting a message can
be done anywhere within the function with no impact.

Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
 2011-12-13 15:59:36 +09:00
Jean Chalard
a2a85d45e0 Refactoring 
Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
 2011-12-13 15:38:49 +09:00
Tadashi G. Takaoka
dc52e7c646 Remove current keyboard id variable 
Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
 2011-12-13 12:49:40 +09:00
Jean Chalard
34081186f9 Merge "Fix a bug where revert auto-correct would revert too much" 2011-12-12 04:46:27 -08:00
Jean Chalard
5c3ff4c9c8 Fix a bug where revert auto-correct would revert too much 
If there are no uncommitted chars, we shouldn't enter any of
the tests that follow. We didn't use to, but a change today
made it possible - it should not happen.
There is no point in doing the rest of the tests, they are
sure to fail.

Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
 2011-12-12 21:27:16 +09:00
Jean Chalard
4f41cbc588 Remove a useless function call 
Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
 2011-12-12 20:51:43 +09:00
Jean Chalard
dcf8a6b2c6 Merge "Move a settings var to the settings class" 2011-12-12 03:31:42 -08:00
Jean Chalard
2a659b8aa6 Remove a useless variable 
This can be just read when it's needed.

Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
 2011-12-12 20:22:39 +09:00
Jean Chalard
d567b230b0 Move a settings var to the settings class 
Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
 2011-12-12 19:52:17 +09:00
Jean Chalard
7208af0ecd Remove a messy and unused class. 
Today is a happy day

Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
 2011-12-12 19:31:29 +09:00
Jean Chalard
f162ed7ec8 Merge "Remove side-effects from TextEntryState" 2011-12-12 02:20:49 -08:00
Jean Chalard
406d192a9e Remove side-effects from TextEntryState 
Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
 2011-12-12 19:19:39 +09:00
Tadashi G. Takaoka
267cd0151f Add special handling for "Phone number" layout. 
Bug: 5743584
Change-Id: I821b837a2078afb64b460191c98b28f7733cf2c1
 2011-12-12 18:19:29 +09:00
Tadashi G. Takaoka
aa59e24ebe Merge "Add unit test of KeyboardState" 2011-12-12 00:15:42 -08:00
Jean Chalard
c2a76a1529 Remove a useless variable. 
Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
 2011-12-12 16:49:32 +09:00
Jean Chalard
205f9ca310 Merge "Straighten out logic for revert word paths" 2011-12-11 23:48:06 -08:00
Jean Chalard
890d13189d Straighten out logic for revert word paths 
This also includes a new memorized string with simpler
logic that will allow to remove other members

Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
 2011-12-12 16:41:49 +09:00
Tadashi G. Takaoka
dfbe254de6 Add unit test of KeyboardState 
Bug: 5708602
Change-Id: I1a8a9f4320948bb500a96df8773b0bfa1a1d4167
 2011-12-12 16:34:11 +09:00
Tadashi G. Takaoka
243e034716 Merge "Assign Key.mCode from the label only when outputText is not specified" 2011-12-11 23:32:32 -08:00
Tadashi G. Takaoka
06b886f372 Merge "Move KeyDetector.printableCode to Keyboard" 2011-12-11 23:32:25 -08:00
Tadashi G. Takaoka
7dfd5a3e83 Move KeyDetector.printableCode to Keyboard 
Change-Id: I9cde21fbb45c1e5f1a568bb97b1b1a76524f4bf2
 2011-12-12 16:17:45 +09:00
Tadashi G. Takaoka
de66f3af8a Assign Key.mCode from the label only when outputText is not specified 
Bug: 5742827
Change-Id: I72b55ce246b14a2d8f4fd16211b71dc716db30b2
 2011-12-12 16:15:18 +09:00
Jean Chalard
86344836ee Merge "Remove a duplicated variable." 2011-12-11 21:26:31 -08:00
Tadashi G. Takaoka
2ba1bcccdd Remove unused Keyboard.CODE_CANCEL 
Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
 2011-12-12 12:56:30 +09:00
Jean Chalard
3651220327 Remove a duplicated variable. 
This is awesome cleanup.

Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
 2011-12-12 12:06:41 +09:00
Ken Wakasa
9260422423 Build God Mode keyboard with API level 14 
Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8
 2011-12-10 03:45:40 +09:00
satok
4af5e3c5f4 Fix isResearcherPackage 
Change-Id: I286450fe89a37d75cb398f17d300ddc6f5857ffd
 2011-12-10 01:16:16 +09:00
Ken Wakasa
2edd109f84 Some tweaks for Researcher Mode 
Change-Id: I6b16dd2fe6d7356c747ba0ee2da5976738003ded
 2011-12-10 00:35:50 +09:00
satok
2a89e36db0 Merge "Add a functionality to attach a log file to Gmail app Bug: 5722703" 2011-12-09 05:59:36 -08:00
satok
a8b6292cee Add a functionality to attach a log file to Gmail app 
Bug: 5722703

Change-Id: I089f944bdbf2cbb036eb59dd9b5b414370c770f1
 2011-12-09 22:38:15 +09:00
Tadashi G. Takaoka
963abf4bcc Merge "Remove unused public methods from KeyboardState and KeyboardSwitcher" 2011-12-09 04:38:14 -08:00
Jean Chalard
74671cf6c5 Resolve TODOs: add members to hold preferences 
Change-Id: I34f6c76bf9318e1fbe8eb5ffab6772a98ff824e0
 2011-12-09 21:24:13 +09:00
Tadashi G. Takaoka
df9deffba2 Remove unused public methods from KeyboardState and KeyboardSwitcher 
Bug: 5708602
Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
 2011-12-09 21:14:13 +09:00
Jean Chalard
0fe3611bee Resolve TODOs: add some members to store prefs 
Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
 2011-12-09 20:16:57 +09:00
Jean Chalard
85b063f97e Resolve TODOs: add members to store raw settings 
Change-Id: I481eadb6a73faf239e24d05b7e220fcb01194fa4
 2011-12-09 19:03:55 +09:00
Jean Chalard
12f10e1585 Read options in the declaration order 
Change-Id: I1a7c4d0bcaedad6d4045c36c79280c23234db5b3
 2011-12-09 18:58:24 +09:00
Jean Chalard
c40b807ca4 Straighten out prefs reading code 
Change-Id: Ibf9113a8ef07ac720100ee32d2e5ef321e8ddd98
 2011-12-09 18:54:07 +09:00
Jean Chalard
bab1f045f4 Straighten out members extracted from resources. 
Change-Id: I9b9602ec5b379b44b0f0663d4f065dbcf88fd352
 2011-12-09 18:19:30 +09:00
Jean Chalard
92e85c87a3 Merge "Match constant names to option names" 2011-12-09 01:14:14 -08:00
Jean Chalard
f8a056c5c8 Merge "Reorder members in SettingsValues." 2011-12-09 01:14:02 -08:00
Jean Chalard
ba93dda8ce Match constant names to option names 
Change-Id: I7586fa342d7a39412d656890f7b525139c45ea4a
 2011-12-09 17:58:51 +09:00
Jean Chalard
837b109f27 Reorder members in SettingsValues. 
Reorder so that they match the order in the preference xml
file. Also add TODOs for missing raw variables.

Change-Id: I06332c131a624d6c359512d75c808f3f7313fa91
 2011-12-09 17:56:31 +09:00
Tadashi G. Takaoka
1cc046775d Merge "KeyboardState keeps track of isAlphabetMode and isSymbolShifted" 2011-12-09 00:43:18 -08:00
Jean Chalard
c207e0a7da Move settings variables to the settings class 
Change-Id: Ifa7033a84b08ea626eb44cf6d04ba8e28c250bea
 2011-12-09 16:47:31 +09:00
Jean Chalard
284c8a0449 Merge "Stop a flag from escaping." 2011-12-08 23:14:15 -08:00
Jean Chalard
0c3b8ce842 Merge "Move settings method from Utils to SettingsValues" 2011-12-08 23:09:33 -08:00
Tadashi G. Takaoka
10dcc7eb67 KeyboardState keeps track of isAlphabetMode and isSymbolShifted 
Bug: 5708602
Change-Id: I181cdeb90d24984ce6f6c993b278293aae7364eb
 2011-12-09 16:09:16 +09:00
Jean Chalard
4606de117b Stop a flag from escaping. 
The ultimate intent is to close it up in the settings, as it does not
change while typing, only when the keyboard is open again.

Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
 2011-12-09 16:09:04 +09:00
Tadashi G. Takaoka
784181e29f Merge "Cleanup debug logging code" 2011-12-08 23:08:22 -08:00
Jean Chalard
ed43296217 Move settings method from Utils to SettingsValues 
Change-Id: I633378a41f63cd492b8c9345d550e07254df5e5a
 2011-12-09 16:03:10 +09:00
Tadashi G. Takaoka
a7af03baf4 Merge "Get rid of public KeyboardState.setShifted and setShiftLocked" 2011-12-08 23:02:47 -08:00
satok
4bae9d56d9 Merge "Show usability study mode for research purposes" 2011-12-08 22:40:58 -08:00
satok
e0dfc54c5b Show usability study mode for research purposes 
Bug: 5722703

Change-Id: I27acc374c5d4b52707708b83689dea5d78a573d7
 2011-12-09 15:31:06 +09:00
Tadashi G. Takaoka
930a55b846 Cleanup debug logging code 
Change-Id: If806d61c5945d319c89d9cc127e09f98b7b10a4e
 2011-12-09 15:14:05 +09:00
Tadashi G. Takaoka
805402e8fa Get rid of public KeyboardState.setShifted and setShiftLocked 
Bug: 5708602
Change-Id: I98bcca7d3e9dd88f034d0faecada76902b2d0dff
 2011-12-09 15:13:23 +09:00
Tadashi G. Takaoka
a76c62e92d Merge "Remove direct calls of setKeyboardXXX from KeyboardSwitcher" 2011-12-08 21:33:09 -08:00
Tadashi G. Takaoka
96c56cb577 Remove direct calls of setKeyboardXXX from KeyboardSwitcher 
These calls, setAlphabetKeyboard, setSymbolsKeyboard, and
setSymbolsShiftedKeyboard have to be call backed from KeyboardState.

Bug: 5708602
Change-Id: Ibbe1a21bd10bf942e17886869c0ab0fa1735b87e
 2011-12-09 13:26:11 +09:00
Jean Chalard
7a16a061e6 Extract Settings.Values to a new class 
This is pretty much automatic refactoring. Thanks Eclipse!

Change-Id: I8ccd24d11878445c836347e9c487c91461eee9cd
 2011-12-09 12:40:50 +09:00
Tadashi G. Takaoka
d52e760530 Merge "Cleanup KeyboardSwitcher a bit" 2011-12-08 05:55:16 -08:00
Tadashi G. Takaoka
6ad9b012d9 Cleanup KeyboardSwitcher a bit 
* Move caps lock state preserving code to KeyboardState.
* Merge KeyboardState.onLoadKeyboard and onRestoreKeyboardState.
* Merge private methods into toggleShift and toggleKeyboardMode.

Bug: 5708602
Change-Id: I793a934a0ba18d5750be011c52ebe20c1976eac6
 2011-12-08 22:50:46 +09:00
Jean Chalard
92e5756dfb Merge "Cleanup" 2011-12-08 05:14:26 -08:00
Jean Chalard
c1fdd966a7 Remove a useless method 
Change-Id: Ib6a0ee21bfe2000231f9ba7bcad4b18ae57e4249
 2011-12-08 21:47:26 +09:00
Jean Chalard
283b0c2b64 Cleanup 
Here, shouldAutoCorrect implies mSettingsValues.mAutoCorrectEnabled

Change-Id: I9256718dd63b75252d1454e264db6814bbf18aa5
 2011-12-08 21:37:15 +09:00
Jean Chalard
3da7df8db7 Merge "Add proximity for Russian." 2011-12-08 02:22:28 -08:00
Jean Chalard
1830cd1dc8 Add proximity for Russian. 
This also tries to make the code as easy to extend as possible
for future developments.

Bug: 5701241
Change-Id: I1ed48e6a5cc7aab94c5d6e309930cc004247d7e7
 2011-12-08 19:00:52 +09:00
Jean Chalard
9e38f9a980 Merge "Use the system-wide interface to add a word." 2011-12-08 00:52:32 -08:00
Tadashi G. Takaoka
cf58f53a1a Move KeyboardLayoutState into KeyboardState 
Bug: 5708602
Change-Id: Ieb6b872d0f2cf3ad1fcb69409e2cf49f60427672
 2011-12-08 17:00:56 +09:00
Tadashi G. Takaoka
eef6238f94 Move SWITCH_STATE related stuffs to KeyboardState 
Bug: 5708602
Change-Id: I904ec370e3761c47af17a680c0932ec98cfd3c27
 2011-12-08 16:12:49 +09:00
Tadashi G. Takaoka
b300dbbd39 Reset saved caps lock sate when new keyboard is loaded 
Bug: 5722919
Change-Id: Id92632a0feffc3342d3c31e90c0da973c934f3c0
 2011-12-07 22:48:04 +09:00
Tadashi G. Takaoka
6b7100feca Don't execute pending onStartInputView if EditorInfos are equivalent 
Bug: 5722732
Bug: 5722867
Change-Id: I8347c258b286c3329f318d50adf205e78e49c722
 2011-12-07 22:39:13 +09:00
Tadashi G. Takaoka
68d600a5f6 Merge "Remove internal toggleShift calls" 2011-12-07 02:35:52 -08:00
Tadashi G. Takaoka
f47993ee34 Remove internal toggleShift calls 
Bug: 5708602
Change-Id: Id1f76dbd40aaf9ed35d4598d902043675c3d74fc
 2011-12-07 19:32:47 +09:00
Tadashi G. Takaoka
845d829d47 Merge "Get rid of direct reference to KeyboardId from KeyboardLayoutState" 2011-12-07 01:41:05 -08:00
Tadashi G. Takaoka
bc56e04425 Reset keyboard state when loading keyboard 
Bug: 5627467
Change-Id: I709f97e47144d3270450adc7d8053038d0df57bc
 2011-12-07 17:55:22 +09:00
Jean Chalard
361c42b746 Use the system-wide interface to add a word. 
Bug: 5306641
Change-Id: Ic87e5bc3a5f1f03c57d48f2d92c28e0aba06847d
 2011-12-07 16:19:05 +09:00
Tadashi G. Takaoka
2e263b70d5 Get rid of direct reference to KeyboardId from KeyboardLayoutState 
KeyboardLayoutState.restore directly loads keyboard using private
methods such as setAlphabetKeyboard and setShifted etc. instaed of
calling public methods such as toggleCapsLock, onPressShift, and
onReleaseShift.

Bug: 5708602
Change-Id: I799f80f1d505ac7bdf17b92b189fc418994bfa2f
 2011-12-07 13:02:58 +09:00
Alan Viverette
55c0198eee am c960695f: Updated keyboard to use SPEAK_PASSWORD preference. 
* commit 'c960695f38ae0564dff3a6897fd1843c8e74c604':
  Updated keyboard to use SPEAK_PASSWORD preference.
 2011-12-06 16:59:46 -08:00
Alan Viverette
c960695f38 Updated keyboard to use SPEAK_PASSWORD preference. 
Bug: 5678383
Change-Id: Ie9bdc92f4b2c9014159d672b71e4438f8fa34f55
 2011-12-06 14:06:57 -08:00
Tadashi G. Takaoka
e466583ddc Fix caps lock key behavior 
Fix the issue introduced by Idfe69978.

Bug: 5708602
Change-Id: I4265822b7d33417b87b3e7e3f49250ac5d2ecdda
 2011-12-06 19:52:25 +09:00
Tadashi G. Takaoka
8a70e70c84 Remove toggleSymbolsShift and rename toggleKeyboardMode 
Bug: 5708602
Change-Id: Iadef3e862d00505d1d9f588d0d64445754d7b962
 2011-12-06 18:12:34 +09:00
Tadashi G. Takaoka
0da3708540 Merge "Move KeyboardShiftState to KeyboardState" 2011-12-06 00:25:05 -08:00
Tadashi G. Takaoka
c1859b8fd2 Move KeyboardShiftState to KeyboardState 
Bug: 5708602
Change-Id: Idfe69978972bb674e0f360ef5e324739e2652d25
 2011-12-06 17:04:12 +09:00
satok
c9f8cb614e Merge "Refactor reflection member" 2011-12-05 23:38:37 -08:00
satok
b95905669c Refactor reflection member 
Change-Id: I112dbf851e10dae9e4291cf440f01b28d51180f4
 2011-12-06 16:35:02 +09:00
Tadashi G. Takaoka
4f7f61730c Make Keyboard.setShifted return void 
Bug: 5708602
Change-Id: If8150f62fbab864344f59853850ff3213c27940e
 2011-12-06 14:42:30 +09:00
Tadashi G. Takaoka
ec52fb6dbb Merge "Minor refactoring of Keyboard" 2011-12-05 16:49:35 -08:00
satok
a3cf232a2a am e5db3871: Fix a field value for the suggestion max size Bug: 5574747 
* commit 'e5db3871b1269703e5ef360090fb35f50ae57ed4':
  Fix a field value for the suggestion max size Bug: 5574747
 2011-12-05 07:54:59 -08:00
Tadashi G. Takaoka
5b74989bef Minor refactoring of Keyboard 
* Remove isAlphaKeyboard().
* Remove isPhoneKeyboard().
* Remove getKeyboardShiftState().

Bug: 5708602
Change-Id: I8bf5009bf499ecb0501d1379f72e43406080062a
 2011-12-05 20:04:52 +09:00
Jean Chalard
f7fa231b7a Merge "Add support for Russian spell checking." 2011-12-05 02:30:29 -08:00
Jean Chalard
bb2b30fc7f Add support for Russian spell checking. 
Note that this is not enough: we still need to create a
reasonable proximity table for Cyrillic characters, or we
won't be able to show up suggestions.

Bug: 5701241
Change-Id: Idb141f7a230a6e1a46094308c26f43c01ab3b97a
 2011-12-05 18:57:03 +09:00
Tadashi G. Takaoka
6ddb07433f Merge setManualTemporaryUpperCase and setAutomaticTemporaryUpperCase 
Bug: 5708602
Change-Id: I6a0b5f0dcccbb6331a271cd61a48c474a7800289
 2011-12-05 18:54:43 +09:00
Tadashi G. Takaoka
46831d5a4b Renaming KeyboardSwitcher.getPointerCount to isSinglePointer 
Bug: 5708602
Change-Id: If44ed4449a3ea79228e25e2ab2c8c8fe82a93a2b
 2011-12-05 17:53:58 +09:00
Tadashi G. Takaoka
4a292acc6f Make ModifierKeySatate and ShiftKeyState non-public class 
Bug: 5708602
Change-Id: I149c2dab26774686e5c578bbf780081e9fb30e7c
 2011-12-05 15:40:51 +09:00
Tadashi G. Takaoka
b88c9acd88 Add KeyboardState to host shift and symbol key states 
The KeyboardState will conatin all logic of keyboard state when series
of refactoring are achieved.  And the KeyboardState should not be
entangled with other objcets such as Keyboard and KeyboardSwitcher in
order to keep it easily testable.

Bug: 5708602
Change-Id: I288bc169c47e1b4de27fe78854baadbcc85c5d23
 2011-12-05 15:08:59 +09:00
satok
e5db3871b1 Fix a field value for the suggestion max size 
Bug: 5574747

This bug was introduced by I5e40edf6f790c078c4a05d

Change-Id: I5b0f51e1f5e8a12d786657167082bc604089505e
 2011-12-05 12:53:45 +09:00
Tadashi G. Takaoka
c410e243e9 Ignore releasing shift key caused by long press 
Bug: 5694715
Change-Id: If7b84f547f5701e84d740f186d284273565b7eba
 2011-12-05 12:23:38 +09:00
Tadashi G. Takaoka
5c269d1e0d Merge "Use Iterator in PointerTrackerQueue" 2011-12-01 01:36:19 -08:00
Tadashi G. Takaoka
41a51bb2b4 Merge "Fix debug messages neatly" 2011-12-01 01:01:09 -08:00
Tadashi G. Takaoka
78ac86ff9d Use Iterator in PointerTrackerQueue 
Change-Id: Ia5ad7d4511b2f2db056f2acf7cc0e002001e2123
 2011-12-01 17:50:37 +09:00
Tadashi G. Takaoka
e742436a29 Fix debug messages neatly 
Change-Id: I40538d5ffbdf64df4e2848de33393327d704fc1e
 2011-12-01 16:43:22 +09:00
Tadashi G. Takaoka
c9f203805c Fix potential NPE 
Change-Id: I00e7cd521bafd2705ebc2a59d63b7bfc4fe178ba
 2011-12-01 16:29:13 +09:00
Tadashi G. Takaoka
ae7746e580 Merge "Add Key.altCode attribute" 2011-11-30 03:15:44 -08:00
Tadashi G. Takaoka
2013bab89c Add Key.altCode attribute 
* Registering alternate code and while key is typing.
  * Showing press/release graphics of the key that has the above altenate code.
  * Showing press/release graphics of all shift keys.
  * Renaming Key.ignoreWhileTyping to Key.altCodeWhileTyping.

Bug: 5639503
Change-Id: I67fb45bae76284a1f0deb6fd12ae5fb781d06cc3
 2011-11-30 20:06:47 +09:00
Jean Chalard
db5aedb5a5 Add an option to use contacts or not while spell checking 
Bug: 5447495
Change-Id: Iffb09895676c3dd1a79d1699b0eac865282508d4
 2011-11-30 18:58:10 +09:00
Tadashi G. Takaoka
e22baaadd3 Get rid of usage of key index 
Change-Id: I7596ce3ae52fde436d06c2dd95ae873c7aa5ef7f
 2011-11-29 19:07:54 +09:00
Jean Chalard
55042ff977 Merge "Resume suggestion when backspacing to the end of a word" 2011-11-29 01:15:42 -08:00
Tadashi G. Takaoka
b230806f44 Merge "Save keyboard layout only when it is shown" 2011-11-29 00:53:38 -08:00
Jean Chalard
6b1f500da4 Resume suggestion when backspacing to the end of a word 
Bug: 5515381
Change-Id: I26fea896feaf2e9716c7ae3d4f2630360f23ac50
 2011-11-29 17:50:36 +09:00
Jean Chalard
117fc18ed4 Keep count of the trailing single quotes for suggestions 
Bug: 5665809
Change-Id: I4d9100dbe980861ccb55c78464524be670cac1f7
 2011-11-29 15:16:28 +09:00
Tadashi G. Takaoka
f2c9a88887 Save keyboard layout only when it is shown 
Bug: 5130446
Change-Id: I150b4a053036eae050099155169325f0d1f7dfed
 2011-11-29 14:12:49 +09:00
Tadashi G. Takaoka
c1f7d39b4a Introduce ignoreWhileTyping flags to Key.keyActionFlags 
Bug: 5639503
Change-Id: Ic2afad6766edb2538a58f722209e2daa40aa488d
 2011-11-22 18:18:29 -08:00
Tadashi G. Takaoka
adb89c109e Merge "Move ignore special key code out from LatinIME to PointerTracker" 2011-11-22 17:57:59 -08:00
Tadashi G. Takaoka
9324665263 Move ignore special key code out from LatinIME to PointerTracker 
Bug: 5560766
Bug: 5639503
Change-Id: I34c9eea833516adf6ef1db58f1a64a5ef5322fa9
 2011-11-22 17:49:12 -08:00
Svetoslav Ganov
3b82e8163c Merge "Fixed typing uppercase letters when touch exploration is enabled." 2011-11-22 14:57:59 -08:00
Jean Chalard
6d1cbbc2ff Fix a bug with single quotes 
I14dd3815 special-cased single quotes at the start of a word, but
did not do so correctly - it would kill a composing word if entered
just after some punctuations.
The right test was not isCursorTouchingWord() but
mHasUncommittedTypedChars, which actually makes for a simpler
implementation.

Bug: 5648032
Change-Id: Icd21d213e0cad6da68cacfeb921502cd8dcfac95
 2011-11-22 18:29:51 +09:00
Tadashi G. Takaoka
13d5f6605b Add Key.keyActionFlags and obsolete Key.isRepeatable 
This change also renames Key.keyLabelOption to keyLabelFlags.

Change-Id: Iedd0bfaa420ad382c07ce084416355690e390919
 2011-11-21 20:33:03 -08:00
Alan Viverette
e87fd4d282 Fixed typing uppercase letters when touch exploration is enabled. 
Bug: 5652774
Change-Id: Id8cd37b3ff93b45f4f18198bbbb827aadf945b02
 2011-11-21 17:56:03 -08:00
Tadashi G. Takaoka
e7eac906c0 Pending onStartInputView only if the EditorInfo is identical 
Bug: 5604372
Change-Id: I2a88cf15b07eebd29e43e460f6ec758432181b01
 2011-11-21 16:32:46 -08:00
Jean Chalard
19cbdfc92f Merge "Remove an unused (and scary) method" 2011-11-21 00:57:45 -08:00
Jean Chalard
ce86e39e00 Merge "Cleanup." 2011-11-21 00:53:49 -08:00
Jean Chalard
5d5028f2c5 Remove an unused (and scary) method 
Change-Id: I14a545a3e4955a25fde17554156552c755d44e2f
 2011-11-21 17:45:32 +09:00
Jean Chalard
6ecd1e1280 Merge "Special case quotes at start and end of words" 2011-11-21 00:21:09 -08:00
Jean Chalard
c83359f974 Special case quotes at start and end of words 
Single quote at start of word is not considered a part of a
word any more.
Single quote at the end of a word now behave like capitalization:
lookup in the dictionary is done *disregarding* a final quote,
and it is forcefully added back into the suggestions afterwards.

Bug: 5566368
Change-Id: I14dd3815f4b743edba56d64a3abdf4b73d863a6a
 2011-11-21 16:34:39 +09:00
Tadashi G. Takaoka
f3dfa55029 Merge "Introduce noKeyPreview Key attribute" 2011-11-18 16:28:54 -08:00
Tadashi G. Takaoka
e00ede531f am 5619d765: Shift/Symbol/Smiley will not disable settings/microphone keys 
* commit '5619d7658459d13723b6d7ad8969b249adf9e717':
  Shift/Symbol/Smiley will not disable settings/microphone keys
 2011-11-18 15:23:14 -08:00
Tadashi G. Takaoka
5dc318a3f2 am 10dff768: Fix NPE introduced by I38b21d49 
* commit '10dff76856a98b6eec86a53d3d07fdc9708037b7':
  Fix NPE introduced by I38b21d49
 2011-11-18 14:48:05 -08:00
Tadashi G. Takaoka
431ce93925 Introduce noKeyPreview Key attribute 
This change also removes hacks in LatinKeyboardView by utilizing
noKeyPreview attribute.

Bug: 5638595
Change-Id: Icd8a3af3b7849b941f8f5532e2b432e126a909e6
 2011-11-18 14:40:05 -08:00
Tadashi G. Takaoka
18630d5fd6 am 15a01d72: Merge "Do not show key preview of settings and shortcut key" into ics-mr1 
* commit '15a01d72724ce7f0a9a5814443a03b907962f3fd':
  Do not show key preview of settings and shortcut key
 2011-11-18 09:15:52 -08:00
Tadashi G. Takaoka
49cc3beb75 resolved conflicts for merge of 137667ed to master 
Change-Id: I75fc5d278b002ab89dd2475d282d0ee4aede7817
 2011-11-18 08:51:39 -08:00
Tadashi G. Takaoka
5619d76584 Shift/Symbol/Smiley will not disable settings/microphone keys 
Bug: 5560766
Change-Id: Ic2dbb835e87a7debb222093756816e683b464b83
 2011-11-17 23:32:19 -08:00
Jean Chalard
88562bec54 Cleanup. 
Fix a typo, and move a cursor.close() in a finally{} clause

Change-Id: Iac011ebb80b9430774c7dc5cd94728d05cef443f
 2011-11-18 15:24:49 +09:00
Tadashi G. Takaoka
10dff76856 Fix NPE introduced by I38b21d49 
Bug: 5560766
Change-Id: Ic5eaebe0ef893c69ad90a777ebfa07807535a0e3
 2011-11-17 21:46:24 -08:00
Tadashi G. Takaoka
15a01d7272 Merge "Do not show key preview of settings and shortcut key" into ics-mr1 2011-11-17 18:02:05 -08:00
Tadashi G. Takaoka
137667ed3d Merge "Ignore microphone and settings key while typing" into ics-mr1 2011-11-17 18:01:43 -08:00
Tadashi G. Takaoka
175acb8205 Ignore microphone and settings key while typing 
Bug: 5560766
Change-Id: I38b21d49b7e803bf94805ba8e13849b3c734e010
 2011-11-17 16:01:31 -08:00
Tadashi G. Takaoka
ca14c8bf34 Do not show key preview of settings and shortcut key 
Bug: 5560766
Change-Id: I580efaf4e33f7dfbaa591e2afae9c49547bf26fb
 2011-11-17 15:34:57 -08:00
Tadashi G. Takaoka
60acfdf4a8 Skip loading keyboard when SoftInputWindow hasn't shown yet. (DO NOT MERGE) 
This is cherry-pick of I003101b2 from Master for Bug: 5541192
Bug: 5636367

Change-Id: I560126d17be6a770b19c1f1347332ebdfde5d671
 2011-11-17 14:30:54 -08:00
Tadashi G. Takaoka
875c16adc3 Merge "Fix long press caps lock handling (DO NOT MERGE)" into ics-mr1 2011-11-17 11:18:28 -08:00
Tadashi G. Takaoka
ac4bd59864 Merge "Fix long press caps lock handling" 2011-11-17 11:05:51 -08:00
Tadashi G. Takaoka
245a4d9304 am d845c26b: Merge "Fix IndexOutOfBoundsException in monkey test" into ics-mr1 
* commit 'd845c26b0e72e67aa14b5eac4616eb5ee7d81b33':
  Fix IndexOutOfBoundsException in monkey test
 2011-11-17 07:48:20 -08:00
Tadashi G. Takaoka
628ca7a854 Fix long press caps lock handling (DO NOT MERGE) 
This is cherry-pick of I3850f283.

Bug: 5627467
Change-Id: If46dcbe5bac42b975bd001fefb9f11520a0abb70
 2011-11-16 16:50:44 -08:00
Tadashi G. Takaoka
42e8c64a04 Fix long press caps lock handling 
Bug: 5627467
Change-Id: I3850f283d44da81ecb22fc4e6d8aa574f5fcf65f
 2011-11-16 16:50:03 -08:00
Tadashi G. Takaoka
d17786fcd2 Fix IndexOutOfBoundsException in monkey test 
Bug: 5627027

Change-Id: I341cfa5c3d553a1c819d8455936b40a40ad30e87
 2011-11-16 15:53:03 -08:00
Tadashi G. Takaoka
eb520c5683 am 549e295d: Fix updateFullscreenMode of LatinIME 
* commit '549e295dc113bff50077c3c355dcd94af09a1b2f':
  Fix updateFullscreenMode of LatinIME
 2011-11-15 18:25:21 -08:00
Tadashi G. Takaoka
549e295dc1 Fix updateFullscreenMode of LatinIME 
Bug: 5597608
Change-Id: If4b18dc933493bd74bc5506c028af86b0450df1f
 2011-11-15 15:15:11 -08:00
Ken Wakasa
ed631627cb Double space conversion should be enabled only when the 1st space is "weak". 
bug: 5608934
Change-Id: Ide7ca9d526620c4f225a6f5eb27dcd7df5b504bd
 2011-11-15 12:35:22 +09:00
Jean Chalard
85170a9c17 Merge "Be stricter for ruling characters out of spell checking" 2011-11-10 15:51:45 -08:00
Jean Chalard
72479ea363 Be stricter for ruling characters out of spell checking 
Bug: 5548308
Change-Id: Ie8025b02424b72b69a07907cde1093830c2d4d3d
 2011-11-10 12:57:09 +09:00
Jean Chalard
a409f009fa Fill in the HAS_RECOMMENDED_SUGGESTIONS flag. 
Bug: 5530727
Change-Id: Ic53e227f72096053e08d90204bf1f287ec09290b
 2011-11-10 02:52:46 +09:00
Tadashi G. Takaoka
0e39e820ce Merge "Fix referring wrong TypedArray (DO NOT MERGE)" into ics-mr1 2011-11-07 19:14:21 -08:00
Ken Wakasa
cea3c5bc17 am 0a75373f: Merge "Fix a bug where the UserDictionary may not be released" into ics-mr1 
* commit '0a75373f4187d2db036757c2c2bcaba42301fd22':
  Fix a bug where the UserDictionary may not be released
 2011-11-07 23:04:05 +00:00
Jean Chalard
8b9c89aee2 Fix a bug where the UserDictionary may not be released 
Bug: 5547357
Change-Id: I521afeaa349c86fb0087cedb70127de6acebec78
 2011-11-07 14:31:59 +09:00
Tadashi G. Takaoka
549863a7c5 Fix referring wrong TypedArray (DO NOT MERGE) 
This is the cherry-pick of Change I2a8f00ed from Master.

Change-Id: I2a8f00edb579e24e612e839498ece097e9d3d7f6
 2011-11-07 14:09:36 +09:00
Tadashi G. Takaoka
6c1c546a98 Merge "Fix referring wrong TypedArray" 2011-11-04 03:47:01 -07:00
Tadashi G. Takaoka
28f6948745 Fix referring wrong TypedArray 
Change-Id: I2a8f00edb579e24e612e839498ece097e9d3d7f6
 2011-11-04 19:41:23 +09:00
Tadashi G. Takaoka
cb83b300e7 Remember shift locked state when switching between Main keyboard and Symbols 
Bug: 5553660
Change-Id: Icb15a9f8a58243bd113c2d4897fee623ac48b66d
 2011-11-04 17:36:40 +09:00
Tadashi G. Takaoka
1e39565bb4 Skip loading keyboard when SoftInputWindow hasn't shown yet. 
Bug: 5541192
Change-Id: I003101b2a3fdeb5bb554d249634ec5ab50aea09e
 2011-11-04 15:01:58 +09:00
Tadashi G. Takaoka
b8291fb46b Merge "Do not clip the popup key preview even if there is no left/right preview icons" 2011-11-03 20:19:58 -07:00
Tadashi G. Takaoka
80e9bd34d1 Do not clip the popup key preview even if there is no left/right preview icons 
Change-Id: Ie51f56c64ba4c69400fe6472b2397ba19ee74911
 2011-11-04 10:35:06 +09:00
Jean Chalard
2c77216e22 Remove trailing spaces when appropriate 
Bug: 5509651
Change-Id: I99cfb5a6fc2873e2c11ed16967cd82a7f504a263
 2011-11-02 19:44:26 +09:00
Tadashi G. Takaoka
824876ebbb Merge "Fix JNI as 64bit ready" 2011-10-31 05:49:39 -07:00
satok
cbd8ece513 am 352b9310: Merge "Use reflection to get field values of SuggestionSpan" into ics-mr1 
* commit '352b93104afa73fd53a04c4414bf382fcf477f04':
  Use reflection to get field values of SuggestionSpan
 2011-10-31 12:26:22 +00:00
Tadashi G. Takaoka
5fdcd7d5cd Fix JNI as 64bit ready 
Change-Id: I7a3ed2cee3b20744869aa5cf89ff9fd95f5ab8fe
 2011-10-31 20:44:01 +09:00
satok
352b93104a Merge "Use reflection to get field values of SuggestionSpan" into ics-mr1 2011-10-28 18:26:11 -07:00
Svetoslav Ganov
adc5e6f12c am f2c57551: Merge "Removed lift-to-type from LatinIME accessibility." into ics-mr1 
* commit 'f2c57551a70de651dc34bd2d73f5e622ba3887db':
  Removed lift-to-type from LatinIME accessibility.
 2011-10-28 22:27:19 +00:00
Svetoslav Ganov
f2c57551a7 Merge "Removed lift-to-type from LatinIME accessibility." into ics-mr1 2011-10-28 11:13:15 -07:00
satok
68ef7b77ed Use reflection to get field values of SuggestionSpan 
Bug: 5440299
Change-Id: I5e40edf6f790c078c4a05d0d347a89d63f7c042a
 2011-10-28 19:03:49 +09:00
Tadashi G. Takaoka
6f811bd13f Merge "Make some private method static" 2011-10-27 22:57:58 -07:00
Tadashi G. Takaoka
8fbf29e2d5 Make some private method static 
Change-Id: Ia23765268be0ef89d7fe7c3f5372ed32d6615765
 2011-10-28 13:31:31 +09:00
Tadashi G. Takaoka
3122cf8daa am 07a44557: Merge "Cancel pending rotation when another rotation start" into ics-mr1 
* commit '07a445572f7fa21c0e24f5cdb0f0b88ff2adc672':
  Cancel pending rotation when another rotation start
 2011-10-27 22:59:14 +00:00
Ken Wakasa
644d33d60e Display "Touch again to save" in the keyboard locale 
bug: 524239
Change-Id: I227c193ba149f9296f8b1cf40aa3d9cf4e6ae2ab
 2011-10-28 00:33:15 +09:00
Tadashi G. Takaoka
dd25e4fa2c Cancel pending rotation when another rotation start 
Bug: 5516802
Change-Id: Iccb0abeb94e6dc1322a98a0c744188bb74034c7f
 2011-10-27 17:03:03 +09:00
Tadashi G. Takaoka
37c6bbb675 am a7c41996: Merge "Preventing infinite call of dismissMoreKeysPanel" into ics-mr1 
* commit 'a7c419964f46d1c354e81c5688f5da6b43428c9a':
  Preventing infinite call of dismissMoreKeysPanel
 2011-10-27 02:35:12 +00:00
Alan Viverette
166530b195 Removed lift-to-type from LatinIME accessibility. 
Bug: 5522854
Change-Id: I32df86450fa0d5dd9606609ea693d0e331b64b19
 2011-10-26 18:52:08 -07:00
Tadashi G. Takaoka
a7c419964f Merge "Preventing infinite call of dismissMoreKeysPanel" into ics-mr1 2011-10-26 17:27:35 -07:00
Tadashi G. Takaoka
ef543c725e Merge "Use onCustomRequest to request haptick and audio feedback" 2011-10-26 07:54:23 -07:00
Tadashi G. Takaoka
d999ea4480 Use onCustomRequest to request haptick and audio feedback 
Change-Id: I958f274d8cfebb1551cdf08f1bada50c20fb9ca0
 2011-10-26 23:32:38 +09:00
Tadashi G. Takaoka
e648e83939 Merge "Remove eventTime argument from PointerTracker.onShowMoreKeysPanel" 2011-10-26 07:29:25 -07:00
Ken Wakasa
44f4d77b75 am cb8cb95d: Fix NPE 
* commit 'cb8cb95d0afd340de9f1a0e15948f0068d2450bc':
  Fix NPE
 2011-10-26 14:25:28 +00:00
Tadashi G. Takaoka
e51d164482 Remove eventTime argument from PointerTracker.onShowMoreKeysPanel 
Change-Id: Idbcd6e3047c6c0c407e3b347cf9f65951d43a312
 2011-10-26 20:54:35 +09:00
Jean Chalard
120586c226 Group special spaces and double/swapped spaces in undo mode 
This introduces an elementary undo facility that accounts
for magic space, strong space, double space and its cancelling,
and swapped punctuation and its cancelling.
The former three were existing behavior ; this change adds
the swapped punctuation cancelling behavior.

Bug: 5454442
Change-Id: I87af633f30caa2788e9af725e556a7f0746d9a14
 2011-10-26 19:12:55 +09:00
Jean Chalard
dec6c0f929 DO NOT MERGE: Fix a bug where the sequence numbers would be wrong 
The spell checker cannot afford to return static objects,
seeing as the framework will then use the same objects to
pair the cookie and sequence ids to the request.
This is a backport of Ia9c3a933

Bug: 5503243
Change-Id: Ia9c3a933bfb30cf5525418b240ef60632d72c9d0
 2011-10-26 17:57:00 +09:00
Tadashi G. Takaoka
0cf7a45ac5 Preventing infinite call of dismissMoreKeysPanel 
Bug: 5514583

Change-Id: Idf8dd1ebba0afdb768e538c2626b60770421d4be
 2011-10-26 17:03:41 +09:00
Ken Wakasa
cb8cb95d0a Fix NPE 
bug: 5512097
Change-Id: Id6752c95c9c4b39e7975daa187a2ab92b740060a
 2011-10-26 02:35:44 +09:00
Jean Chalard
d0c5f9395a Cleanup. 
Remove a state that can never be reached, and ajust all the
callers that would always have received false.

Change-Id: Iac025568be11743428419e0772da306a4f0a0bf1
 2011-10-25 21:57:30 +09:00
Jean Chalard
ce668e7a0b Small clean up. 
Remove unused methods and constants.

Change-Id: If72e04394a2943b416915217d22cb6e58a0508b3
 2011-10-25 21:35:43 +09:00
Jean Chalard
126698fdd2 Add a strong space behavior. 
Bug: 5454442
Change-Id: Ic095cb65dd7b4427617cd74fc7c53a9666b218c4
 2011-10-25 18:40:14 +09:00
Jean Chalard
c47c2dc65a Merge "Fix a cosmetic bug where text would blink on space swap" 2011-10-25 02:14:28 -07:00
Jean Chalard
b715299125 Fix a cosmetic bug where text would blink on space swap 
On space swap or space removal in some occasions there would be
a small blink on the screen. This change fixes that.

Change-Id: I486cbcc5dfcafd531b3fa92c4f9a3255832f22cc
 2011-10-25 18:02:23 +09:00
Jean Chalard
cd43edbc32 Small clean up 
Remove an unused method and constant

Change-Id: I3e99ea9fc182c83399d46aca81d1b69aab2c36d1
 2011-10-25 17:12:51 +09:00
Jean Chalard
cba1af9c56 Fix a bug where the sequence numbers would be wrong 
The spell checker cannot afford to return static objects,
seeing as the framework will then use the same objects to
pair the cookie and sequence ids to the request.

Bug: 5503243
Change-Id: Ia9c3a933bfb30cf5525418b240ef60632d72c9d0
 2011-10-24 22:40:41 +09:00
Jean Chalard
ee89b40a92 Merge "Use the contacts dictionary in the spell checker." 2011-10-24 03:48:34 -07:00
Jean Chalard
2e3c6da868 Use the contacts dictionary in the spell checker. 
Bug: 5447495
Change-Id: I7292eb291a1630265884cc8e505a2e83a74f0c72
 2011-10-24 19:44:01 +09:00
Tadashi G. Takaoka
b2b1eb5ca5 Call updateFulscreenMode before calling isFullscreenMode 
Bug: 5495739
Change-Id: I25eab59833a8b95a0b75893d37a45e67504fa7d0
 2011-10-24 15:30:49 +09:00
Jean Chalard
26a531c6fe Rename a flag 
...and insert some explaining commands

Change-Id: Iff6511e71d66abfaea9f6c21c47f74fa0a67ad78
 2011-10-21 19:59:46 +09:00
Tadashi G. Takaoka
49426a1ea9 Fix potential NPE 
Bug: 5462524
Change-Id: I76012d1bbcd83d58f034c2f588802e4d1b7edc4d
 2011-10-20 20:31:17 +09:00
Tadashi G. Takaoka
9f058749f2 am 61aebb0a: Merge "Update suggestions strip divider" into ics-mr0 
* commit '61aebb0a1e3d12cd5287c9be3c2e37df565af888':
  Update suggestions strip divider
 2011-10-19 18:11:20 -07:00
Tadashi G. Takaoka
61aebb0a1e Merge "Update suggestions strip divider" into ics-mr0 2011-10-19 18:09:17 -07:00
Tadashi G. Takaoka
78674d0ff7 Add warning log for unexpected inputType (DO NOT MERGE) 
This is a cherry-pick of I3484c751 from Master.

Bug: 5130446
Change-Id: I140980bf093fb3310496c8021166d16f0ddc362f
 2011-10-19 18:52:07 +09:00
Tadashi G. Takaoka
2c47080e7b Update suggestions strip divider 
Bug: 5142447
Change-Id: I275a304e46456e3b80968fb5de330a3b04bd2035
 2011-10-19 16:54:37 +09:00
Tadashi G. Takaoka
82c8c2e6c0 Add warning log for unexpected inputType 
Bug: 5130446
Change-Id: I3484c75144ba68db0734a4d38186d2eafd1b1879
 2011-10-19 16:53:07 +09:00
Tadashi G. Takaoka
cc02aa8af3 Fix missing TypedArray.recycle calls 
Change-Id: I333e55b4e7925dac5495e2e73ac57ffcef4fabb4
 2011-10-19 13:06:33 +09:00
Tadashi G. Takaoka
bf7d8ecb48 Merge "Close XmlResourceParser when finish parsing" 2011-10-17 19:11:12 -07:00
satok
c5d51a40a4 am fe2d9079: Fix a bug that the typed word with the blue underline indicator will be duplicated 
* commit 'fe2d90798ea409ee39d6f63942eb01bb7eed98e3':
  Fix a bug that the typed word with the blue underline indicator will be duplicated
 2011-10-17 11:32:24 -07:00
Tadashi G. Takaoka
ddd759aa9e Close XmlResourceParser when finish parsing 
Change-Id: If21ee187c83f044b235d88fba15af00e6ac8a308
 2011-10-18 02:44:55 +09:00
satok
fe2d90798e Fix a bug that the typed word with the blue underline indicator will be duplicated 
Bug: 5466373

Change-Id: I0300c34cb6076b12ecb89cb29bea95288559108f
 2011-10-17 13:25:22 +09:00
Tadashi G. Takaoka
d2bc850c4c am 908a2f63: Merge "Special handling of one key mini-keyboard to mitigate visual flicker" into ics-mr0 
* commit '908a2f63949687c9e7acb2e3d50fd50815582e8b':
  Special handling of one key mini-keyboard to mitigate visual flicker
 2011-10-14 12:21:17 -07:00
Tadashi G. Takaoka
75c4b5fe1b am 5ad37baf: Merge "Release bitmap buffer when KeyboardView is detached from Window" into ics-mr0 
* commit '5ad37baf1e09416b197da76881a30e79ac2032c7':
  Release bitmap buffer when KeyboardView is detached from Window
 2011-10-14 12:21:17 -07:00
Tadashi G. Takaoka
908a2f6394 Merge "Special handling of one key mini-keyboard to mitigate visual flicker" into ics-mr0 2011-10-14 12:20:02 -07:00
Tadashi G. Takaoka
5ad37baf1e Merge "Release bitmap buffer when KeyboardView is detached from Window" into ics-mr0 2011-10-14 12:19:49 -07:00
satok
c1981eb83b am 59a55fcb: Merge "Set SuggestionSpan with FLAG_AUTO_CORRECTION as a composing span" into ics-mr0 
* commit '59a55fcbec6e9f2b856c3876e51da6191fd2774e':
  Set SuggestionSpan with FLAG_AUTO_CORRECTION as a composing span
 2011-10-14 11:16:59 -07:00
satok
59a55fcbec Merge "Set SuggestionSpan with FLAG_AUTO_CORRECTION as a composing span" into ics-mr0 2011-10-14 11:15:14 -07:00
satok
53af4ae634 Set SuggestionSpan with FLAG_AUTO_CORRECTION as a composing span 
Bug: 5460262
Change-Id: Ibeb875bb885fb663ed23f0299d671e995a66b642
 2011-10-15 02:02:41 +09:00
Tadashi G. Takaoka
28d841534d Release bitmap buffer when KeyboardView is detached from Window 
Bug: 5450387
Change-Id: I3e60edd8c0ea70aff9e484f6e00dadcc8f8981f6
 2011-10-14 20:13:16 +09:00
Tadashi G. Takaoka
a0e4f40994 Special handling of one key mini-keyboard to mitigate visual flicker 
Use pre-computed width and height of mini keyboard if
 * Popup key preview is enabled
 * The mini keyboard has only one key
 * Pre-computed width and height are specified

Bug: 5248783
Change-Id: I53475698e87d5bd67d36e63323c25a9e9f18fbb1
 2011-10-14 17:49:48 +09:00
Tadashi G. Takaoka
6262fa5307 am ed6bc82d: Merge "Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced"" into ics-mr0 
* commit 'ed6bc82d9785372c407e1a4f563ae7d30c479b8a':
  Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced"
 2011-10-13 22:09:08 -07:00
Tadashi G. Takaoka
d874ac581e Revert "Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced" 
This reverts commit b1bc5fd896. (If3a73179)
Bug: 5410786
 2011-10-14 12:15:24 +09:00
satok
22c2a23cda am 605a6fea: Merge "Fix the safety net Bug: 5453150" into ics-mr0 
* commit '605a6fea750c4acc96a5136ecaf7162e0a858b9f':
  Fix the safety net Bug: 5453150
 2011-10-12 23:46:25 -07:00
satok
605a6fea75 Merge "Fix the safety net Bug: 5453150" into ics-mr0 2011-10-12 23:44:54 -07:00
satok
2aa1dd45c4 Fix the safety net 
Bug: 5453150

Change-Id: I5990feb2622738988bf29843c6bcdb9cbf8bbf33
 2011-10-13 15:16:59 +09:00
Tadashi G. Takaoka
283d35cb6c am 62fb8a48: Merge "Take invisible extractArea height into account" into ics-mr0 
* commit '62fb8a480df325ebc6b2a4dc023a944e3cd0bcef':
  Take invisible extractArea height into account
 2011-10-12 12:00:44 -07:00
Tadashi G. Takaoka
62fb8a480d Merge "Take invisible extractArea height into account" into ics-mr0 2011-10-12 11:02:05 -07:00
satok
e596fe2702 am ef0a7b75: Merge "Suppress flickers of the auto correction indicator" into ics-mr0 
* commit 'ef0a7b75462c75b756caa09d9dd356309968abf3':
  Suppress flickers of the auto correction indicator
 2011-10-12 10:10:41 -07:00
satok
604d80c671 Suppress flickers of the auto correction indicator 
Bug: 5440788
Change-Id: I7832b449ee777dbd87388a02cebdfee0ce350fbd
 2011-10-12 19:14:13 +09:00
Tadashi G. Takaoka
d44647e76f Take invisible extractArea height into account 
Bug: 5410786
Change-Id: I97ce2d72f86ce62b37d408103863af66f91e7107
 2011-10-12 19:13:28 +09:00
satok
a86869711e Merge "Add a settings to change the sound effect volume" 2011-10-11 06:29:11 -07:00
satok
79c0acf519 Add a settings to change the sound effect volume 
Bug: 5345401
Bug: 5402541
Change-Id: I1e653573a3362160104b77388d6cbd1700424649
 2011-10-11 22:25:13 +09:00
Tadashi G. Takaoka
8d4be2516a Merge "Fix haptic and audio feedback of caps-lock mode changing" 2011-10-11 00:38:17 -07:00
Tadashi G. Takaoka
f44aeb6618 Fix haptic and audio feedback of caps-lock mode changing 
Bug: 5435669
Change-Id: Ic1c1eb00d7e535a3ac602b9b505fd8bf43da5a8d
 2011-10-11 15:27:56 +09:00
Tadashi G. Takaoka
ed2b6c714b Remove unused import 
Change-Id: I31115c29e47cdd09b2d8cc8f04e9fc9f9d542811
 2011-10-11 12:53:36 +09:00
satok
602bcecf6b Merge "Put SuggestionSpan as the indicater of the auto-correction" 2011-10-10 02:58:22 -07:00
satok
ec780e2868 Put SuggestionSpan as the indicater of the auto-correction 
Bug: 5245468

Change-Id: Ia5609e1b3c69f5553e3632fbce60a55665a5b185
 2011-10-10 18:44:52 +09:00
Svetoslav Ganov
7c2d7ad634 Merge "Let accessibility users know to connect a headset when the IME connects to a password field." 2011-10-07 15:36:04 -07:00
Jean Chalard
fee149abe0 Use the whitelist as a dictionary in the spell checker. 
Bug: 5402436
Change-Id: If89b8bbdebf6751697c4788270d01d4639cff665
 2011-10-07 19:25:36 +09:00
Jean Chalard
266ae6964d Merge "Fix a bug with the whitelist" 2011-10-07 02:50:11 -07:00
Jean Chalard
5f41b705fc Fix a bug with the whitelist 
This bug would kill the case where the whitelist contains
a word to be autocorrected to an uppercased version of
itself, and the user would enter the uppercase version.
In this case, this bug would cause the typed word to be
killed off the list of candidates, and possibly autocorrected
to the *next* candidate.

When the whitelist checks whether this the typed word is
a candidate for whitelisting, this change has it check whether
the whitelisting results in the typed word before returning.
Hence, it can keep the case-insensitive behavior of the
whitelist.

Coincidentally, this change renames the method used to do
this, because it does not comply with the general contract
of Dictionary. This happens to be in the way of another
upcoming change.

Bug: 5420371
Change-Id: Ifb305271acc5f171adf9b18c762ae7975b14be0a
 2011-10-07 18:40:23 +09:00
Tadashi G. Takaoka
beac24226b Merge "Add haptic feedback for caps lock" 2011-10-07 02:21:15 -07:00
Jean Chalard
af0f13d15c Add pretty-printing to SuggestedWords.Builder to help debug 
Change-Id: I2f40ca40f2b452078d0f24cef72e0182e10e2269
 2011-10-07 14:35:18 +09:00
Tadashi G. Takaoka
416ee19d33 Add haptic feedback for caps lock 
When long press triggers caps lock, the keyboard also triggers haptic
feedback.

This change also fixes trivial harmless bug in KeyboardSwitcher.

Bug: 5424681
Change-Id: I62706b49abd7be1dcebc3c5166ea03f426fc8c86
 2011-10-07 13:57:49 +09:00
Tadashi G. Takaoka
ce9e4f926b Merge "Use XmlPullParser interface instead of XmlResourceParser" 2011-10-06 18:10:19 -07:00
Alan Viverette
b0c8db018d Let accessibility users know to connect a headset when the IME connects to a password field. 
Change-Id: If96cd7626950dd12e88a8a97f5e405d303d41e06
 2011-10-06 11:02:29 -07:00
Jean Chalard
3d36cdcd2d Merge "Fix possible NPE in debug mode" 2011-10-06 03:44:24 -07:00
Jean Chalard
51075d145a Fix possible NPE in debug mode 
Change-Id: I55776110a489621c99e9a3bf58daa6fcaf415cb3
 2011-10-06 19:36:40 +09:00
Jean Chalard
c53661f152 Fix a possible OutOfBoundsException 
Change-Id: I6eb13c228738119c78496a96acaedbccefd83cd3
 2011-10-06 19:05:23 +09:00
Tadashi G. Takaoka
406a54f41c Use XmlPullParser interface instead of XmlResourceParser 
Change-Id: I00e8a82aaaf5fec1e27707bce0a82cbfd1bc9fae
 2011-10-06 18:40:32 +09:00
Jean Chalard
3458d61807 Make the whitelist an instanciable class. 
This goes together with I6b8628b9acc32449e4147a2a754b222fbb76c754
or it will break the build

Bug: 5402436
Change-Id: I07c6266b713773a8de80bb22afdd4c566261f78a
 2011-10-06 16:05:21 +09:00
Tadashi G. Takaoka
cf6d374505 Remove unused local variable 
Change-Id: Ia71e03ee59153db1dbc35028569f7c76d5b12bf7
 2011-10-04 16:46:15 +09:00
Tadashi G. Takaoka
ab72a97d7c Cleanup unused import 
This change also gets rid of several compiler warnings.

Change-Id: I23962edaadad18a6e0395d528af17b909dcf5dad
 2011-10-04 12:46:20 +09:00
Yusuke Nojima
a25dd3b5c3 Merge "Pass the touch position correction flag from KeyboardSwitcher." 2011-10-03 04:42:53 -07:00
Yusuke Nojima
294e1b4a5a Pass the touch position correction flag from KeyboardSwitcher. 
Change-Id: Ia242a9fa2fa71f7fdf8f974071a2df7acc4aa51f
 2011-10-03 20:41:03 +09:00
Jean Chalard
45f45a4fdb Cleanup : remove recorrection-related stuff. 
This removes UPDATE_OLD_SUGGESTIONS, and the associated settings.

Bug: 5402537
Change-Id: Ie87d4e05c54e4b7d2dd5a05f2d0b570e9cd3e463
 2011-10-03 18:23:23 +09:00
Jean Chalard
fe5364c825 Cleanup : remove old recorrection code 
This removes the calls, but another change will be needed to remove
the messages LatinIME used to send itself to update the suggestion
strip.

Bug: 5402537
Change-Id: I5d1aa63a892516f339f3ceac21f43771b5ffda34
 2011-10-03 17:45:45 +09:00
Jean Chalard
6b64a0fedc Merge "Fix a bug where moving the cursor would not reset selection" 2011-10-03 01:32:30 -07:00
Jean Chalard
cd95a36558 Fix a bug where moving the cursor would not reset selection 
This change updates suggestions when the cursor is moved.
It is now reasonable to remove the explicit test for
TextEntryState.isAcceptedDefault because it is now shielded
by mExpectingUpdateSelection : actually, this probably fixes
a long-standing bug.

Bug: 5337309
Change-Id: Iee4046420c6a88d1a07d428230f93c3ebef25c39
 2011-10-03 17:18:29 +09:00
Satoshi Kataoka
21ffb08a73 Merge "Fix obtainStyledAttribute not to look for default" 2011-10-03 00:50:21 -07:00
Tadashi G. Takaoka
a27812ae15 Fix obtainStyledAttribute not to look for default 
Bug: 5402266
Change-Id: I8f84754b0080b315f9360e1ffa8353b386e88ad7
 2011-10-03 16:48:03 +09:00
Jean Chalard
397f6f8299 Merge "Small refactoring" 2011-10-02 23:12:41 -07:00
Jean Chalard
4c0fe57198 Small refactoring 
Change-Id: Ifc33e109562abb3dd720ad4fed76add8ab1a64aa
 2011-10-03 14:58:34 +09:00
satok
904baab25a Remove code related to AutoText 
Bug: 5245751

Change-Id: Ic02f951e8e1dbde9d8964d2c16e4928fb374ca41
 2011-10-03 14:38:44 +09:00
Tadashi G. Takaoka
ad2dfa7697 Fix keyboard theme parsing 
This is a followup of I13b9997e.

Change-Id: I4c10fbc8b250c3bad72e38d46089684a839bdd5f
 2011-10-03 12:34:36 +09:00
Tadashi G. Takaoka
aef4f906ff Merge "Move themeId and touch correction data to Keyboard style" 2011-09-30 20:02:19 -07:00
Tadashi G. Takaoka
5c26922ab2 Move themeId and touch correction data to Keyboard style 
Change-Id: I13b9997e013b704734b6fa94131b1f7fec7a152d
 2011-09-30 22:59:53 +09:00
satok
62c7e25e11 Move SharedPreferencesCompat to com.android.inputmethod.compat 
Change-Id: Ied336339b8eb3643f14517c251b07c09398f61fe
 2011-09-30 20:17:32 +09:00
satok
ba76e6ff27 Show the duration of vibration in settings 
bug: 5345401

Change-Id: I666d48d8ddf6c14540eb401129c20ce93972d9cf
 2011-09-30 20:09:04 +09:00
Yusuke Nojima
da9f556a15 Merge "Classify touches into three types." 2011-09-30 01:26:15 -07:00
Yusuke Nojima
258bfe66e0 Classify touches into three types. 
Change-Id: I7c1d42835e0c15d596a1b66d421b0aa514ec0890
 2011-09-30 17:22:22 +09:00
Jean Chalard
646a66159a Merge "Make use of the FULL_EDIT_DISTANCE flag." 2011-09-30 00:41:14 -07:00
Jean Chalard
673cebf9e9 Make use of the FULL_EDIT_DISTANCE flag. 
In effect, this stops the spell checker from suggesting overly
long words.
More precisely, it takes advantage of the new facility that
takes into account the whole length of the dictionary word when
computing scores, so words much longer than the input word will
see their score demoted accordingly.

Bug: 5384578
Change-Id: I326cd7c87c3080e7fa8729f78517f8ba13672a9b
 2011-09-30 16:00:07 +09:00
Tadashi G. Takaoka
59f8ca752d Skip successive InputMethodService callbacks after orientation changed 
IME is called back four methods for each input field as a IME life
cycle. The four methods are onStartInput, onStartInputView,
onFinishInputView and onFinishInput.

After orientation changed, Those quartet methods will be called back
twice. This behavior of the framework might be a bug.

In order to restore the previous keyboard layout, we should skip
onFinishInputView and onFinishInput of the first quartet and
onStartInput and onStartInputView of the second quartet.

Bug: 4311428
Change-Id: I450ddc0cce5d00abc971ffd42a507a8a86682548
 2011-09-30 10:38:32 +09:00
satok
db096d681f Merge "Add a flag to demote completed suggestions" 2011-09-29 03:58:27 -07:00
satok
40a5f6fa4d Add a flag to demote completed suggestions 
Bug: 5390063
Change-Id: I0ef4fbcc705539624269fd2f8c4e782679fc44b3
 2011-09-29 19:48:18 +09:00
Jean Chalard
3ff95b7290 Merge "Add a threshold for suggestion score." 2011-09-29 01:47:50 -07:00
Yusuke Nojima
43149e454c Merge "Pass the touch position correction data to native." 2011-09-29 01:42:54 -07:00
Jean Chalard
4609c02f9e Add a threshold for suggestion score. 
Bug: 5384578

Change-Id: Ic0b0203d873492a41c72defef835adf36f010f47
 2011-09-29 17:38:08 +09:00
Yusuke Nojima
ad35835bac Pass the touch position correction data to native. 
Change-Id: I92958779377a530410d1682100f9d0a2ba267dea
 2011-09-29 17:00:49 +09:00
satok
4866758a98 Merge "Update suggestions when user presses the backspace even when there is not two or more suggestions" 2011-09-29 00:19:17 -07:00
satok
074cda4d26 Update suggestions when user presses the backspace even when there is not two or more suggestions 
Bug: 5384445
Change-Id: I419999da8f5745ac114d0173beeadcb365a8c3ac
 2011-09-29 16:12:11 +09:00
Tadashi G. Takaoka
2087cf508a Merge "Handle back key and outside touch correctly in more suggestions window" 2011-09-28 23:41:55 -07:00
Tadashi G. Takaoka
bfc1d732ac Handle back key and outside touch correctly in more suggestions window 
Bug: 5385284
Change-Id: Ic0517182d294c79e37c88f1ef30cb4d2917b2800
 2011-09-29 15:07:15 +09:00
Yusuke Nojima
b45e095aa2 Merge "Add touch position correction data to resources." 2011-09-28 22:41:11 -07:00
Yusuke Nojima
d6339639c3 Add touch position correction data to resources. 
Change-Id: I156205672f3935f70c250a6c538793f35c5d86b2
 2011-09-29 14:29:23 +09:00
Jean Chalard
85782abaf1 Move some arguments to final members. 
This is preparation for
Bug: 5384578

Change-Id: I7d493c441f375fa5f23c5e3cfa8134e2ce7775fe
 2011-09-29 13:11:09 +09:00
satok
433965784d add vibration duration settings 
Change-Id: I56a1a94df63160f367f866da759d7dd4fc428ed5
 2011-09-29 11:46:20 +09:00
Jean Chalard
90086846dc Merge "Change the logic of the LOOKS_LIKE_TYPO flag" 2011-09-28 03:59:26 -07:00
Jean Chalard
647db70fec Change the logic of the LOOKS_LIKE_TYPO flag 
It now follows the following logic:
- If the word should be filtered out => false
- Else => !IN_THE_DICTIONARY

This defines the behavior for ICS MR0, and prepares for addition
of a new HAS_LIKELY_SUGGESTIONS flag in MR1.

Bug: 5383800

Change-Id: I530b1404ae8cf3337ff68ef5ab0f4d95f2dad0e8
 2011-09-28 19:42:43 +09:00
Tadashi G. Takaoka
2fc4248700 Introduce hit box to Key and get rid of edge flags 
Change-Id: I2b78d2ca756223b5497d01127c3a0190dcc81e57
 2011-09-28 19:31:37 +09:00
Yusuke Nojima
a59f65ad0c Merge "Extend JNI interface to pass the theme id of the keybaord to the native." 2011-09-27 20:27:17 -07:00
Tadashi G. Takaoka
63584323ca Add themeId to Keyboard 
Change-Id: I6abdeaf41459406cf9021efdf5bb96232ba104c7
 2011-09-28 12:08:48 +09:00
Yusuke Nojima
1c923d8581 Extend JNI interface to pass the theme id of the keybaord to the native. 
Change-Id: I705ec2fa1d32a673a8d84bc9afc2a46208a414a1
 2011-09-28 11:56:28 +09:00
Tadashi G. Takaoka
ffd156c77e Postpone onDisplayCompletions until onStartInputView has been executed 
Bug: 5108267
Change-Id: I42d297ce4e4913e5dab5f5d647b1d13dc860b884
 2011-09-28 09:36:40 +09:00
Tadashi G. Takaoka
f451ed2012 Forward touch events above the keyboard to the suggestions strip 
The gutter area between the suggestions strip and the top-row keys
looks like a part of the suggestions strip, and the touch events
landing on the area should be forwarded to the suggestions strip.

Bug: 5246673
Change-Id: I92af763be0feed21aa36ceffb5d575abe554f19e
 2011-09-27 19:02:24 +09:00
Tadashi G. Takaoka
73cd4c1428 Fix onDeatchedFromWindow to protected 
Change-Id: Ief666554ffd405a43363e66ea2bc2d87aa76a882
 2011-09-27 15:18:02 +09:00
Jean Chalard
b95f454018 Merge "Fix a possible deadlock." 2011-09-26 02:30:21 -07:00
Jean Chalard
a9876980c8 Fix a possible deadlock. 
Bug: 5359873
Change-Id: I80ae901c43b6ae59879e3c8b1a9dd8a937d558c1
 2011-09-26 18:16:24 +09:00
Tadashi G. Takaoka
287f4f83e9 Add horizontal edges paddings to phone/number layout 
Bug: 4948171
Change-Id: I8a06a25ffcbd141c9418e77e982233166a347914
 2011-09-26 17:11:01 +09:00
Tadashi G. Takaoka
acf6b6815a Merge "Fix keyboard row height calculation" 2011-09-25 19:25:28 -07:00
Tadashi G. Takaoka
8fbfac4ffb Fix keyboard row height calculation 
The keyboard height will be distrubuted as:
  top_padding + (key_height + vertical_gap) * row_count - vertical_gap + bottom_padding

Change-Id: I841f356b9dbf8cfaf3756178bc9e4e6b2aa61364
 2011-09-26 10:25:49 +09:00
Ken Wakasa
c9f562a9a4 Partially revert I0fa5eefc 
bug: 5344295
Change-Id: Idb10e37862773a62ff60afe874844e8968a58b5d
 2011-09-24 09:38:45 +09:00
Fabrice Di Meglio
c66a7278d2 Merge "Revert "Use "..." instead of "\u2026""" 2011-09-23 15:08:23 -07:00
Fabrice Di Meglio
9bdce3a59e Revert "Use "..." instead of "\u2026"" 
This reverts commit 8673ceb066

The Roboto Font is having the real ellipsis back
 2011-09-23 14:59:33 -07:00
Yusuke Nojima
b225516366 Merge "Extend JNI interface to pass the key coordinate information" 2011-09-22 02:50:51 -07:00
Yusuke Nojima
0e1f656c1b Extend JNI interface to pass the key coordinate information 
Change-Id: Iec0d1415d6abba43b775a014516b961b167597b7
 2011-09-22 18:39:34 +09:00
Gilles Debunne
8d6fd877c5 am b1bc5fd8: Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced 
* commit 'b1bc5fd896329a39ad51a8c79e2970750c814ea0':
  Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced
 2011-09-21 18:57:03 -07:00
Gilles Debunne
b1bc5fd896 Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced 
CL https://android-git.corp.google.com/g/#/c/136474 refactored
the fullscreen test, but ithe IME_FLAG_NO_EXTRACT_UI test was
lost in the process.

Note that there is still a problem (orthogonal to that change
with key_preview_backing, which appears opaque and black sometimes.

I'll re-open 5315001.

Change-Id: If3a73179d21eaca10bdc948db7bac4b4f7a88d34
 2011-09-21 16:14:30 -07:00