nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
31089 commits 1 branch 0 tags 363 MiB
Commit graph

10590 commits

Author SHA1 Message Date
Jean Chalard
4de2fcdde3 Use an executor to serialize opening dictionaries. 
Bug: 13082957
Change-Id: I25570ab4da94337ed60330c0869fe47657096626
 2014-02-24 21:05:24 +09:00
Jean Chalard
b434acee34 Create a utils class for executors. 
Preliminary refactoring to fix
Bug: 13082957

Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
 2014-02-24 20:52:49 +09:00
Tadashi G. Takaoka
c40eb52e43 Merge "Remove hack from EmojiPalettesView.startEmojiPalettes" 2014-02-24 10:49:59 +00:00
Tadashi G. Takaoka
d227b00a72 Remove hack from EmojiPalettesView.startEmojiPalettes 
Bug: 12115967
Change-Id: I91c567a9577012ec28c08430c55e56e9c2e25b5f
 2014-02-24 19:45:50 +09:00
Jean Chalard
65bce4cabc Merge "Never pass negative values to setSelection." 2014-02-24 09:26:43 +00:00
Tadashi G. Takaoka
b08a9e021c Merge "Revert "Prepare for changing text color for functional keys"" 2014-02-24 08:54:55 +00:00
Tadashi G. Takaoka
da500b7ec3 Revert "Prepare for changing text color for functional keys" 
This reverts commit 194e004e81.
Bug: 10786040

Change-Id: I4c5287d46cabe287abce5cba77635cf26d2cd192
 2014-02-24 17:42:28 +09:00
Jean Chalard
f19745728e Never pass negative values to setSelection. 
Bug: 13136079
Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
 2014-02-24 16:52:55 +09:00
Jean Chalard
66c96e8813 Update dictionaries 
en* : add common app and Google product names
en_GB : also add "filters"
ru : add some missing words

Bug: 11043181
Bug: 12276653
Bug: 12953122
Change-Id: I6b62e681a07b7f0149a10ba4e05954e60d6212d4
 2014-02-24 15:30:47 +09:00
Keisuke Kuroyanagi
2b72aa07a9 Disconnect app data search client after fetching all data. 
Bug: 13138201
Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
 2014-02-24 14:47:54 +09:00
Baligh Uddin
dd1d4ba95f Merge "Import translations. DO NOT MERGE" 2014-02-21 16:42:13 +00:00
Baligh Uddin
a761bb3208 Merge "Import translations. DO NOT MERGE" 2014-02-21 16:41:50 +00:00
Jean Chalard
296adf5710 Merge "Change a heuristic and add a log." 2014-02-21 11:58:16 +00:00
Tadashi G. Takaoka
1269ae3144 Merge "Change make-keyboard-text -java option to point LatinIME/java directory" 2014-02-21 11:54:39 +00:00
Keisuke Kuroyanagi
bb6b978a19 Merge "Fix: file descriptor leaking." 2014-02-21 11:37:09 +00:00
Jean Chalard
bf075b21a1 Merge "Don't trim newer inputpointers with old data" 2014-02-21 11:19:04 +00:00
Tadashi G. Takaoka
5eb6ea9f27 Change make-keyboard-text -java option to point LatinIME/java directory 
Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
 2014-02-21 19:24:24 +09:00
Baligh Uddin
522d1575da Import translations. DO NOT MERGE 
Change-Id: If26d287c68a6fed1d5a8ecf6566ccd5cdfb99104
Auto-generated-cl: translation import
 2014-02-21 02:20:21 -08:00
Baligh Uddin
6ddefc567e Import translations. DO NOT MERGE 
Change-Id: Id288919148957318b18962b09e61ebe76a10c2b7
Auto-generated-cl: translation import
 2014-02-21 02:13:34 -08:00
Keisuke Kuroyanagi
ad508d029f Merge "Remove corrupted ver4 dictionaries." 2014-02-21 09:03:19 +00:00
Keisuke Kuroyanagi
d24a99cff6 Fix: file descriptor leaking. 
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.

Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
 2014-02-21 17:25:34 +09:00
Jean Chalard
2a5ec00301 Don't trim newer inputpointers with old data 
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.

Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
 2014-02-21 16:43:11 +09:00
Tadashi G. Takaoka
d73044a249 Add ImportantNoticeDialog 
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
 2014-02-21 16:36:15 +09:00
Keisuke Kuroyanagi
d934fb43ad Remove corrupted ver4 dictionaries. 
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
 2014-02-21 15:09:37 +09:00
Tadashi G. Takaoka
fe39d576dc Support versioned important notice 
This change must be checked in together with If38a754d00.

Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
 2014-02-21 09:54:08 +09:00
Jean Chalard
3b4c1d3056 Change a heuristic and add a log. 
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.

Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.

Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
 2014-02-20 23:49:20 +09:00
Jean Chalard
1b3a142cac Merge "Fix a bug where suggestions would not be updated." 2014-02-20 14:46:35 +00:00
Jean Chalard
6f50c95887 Fix a bug where suggestions would not be updated. 
Also fix a small cosmetic bug where the suggestion strip
would flash.

Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
 2014-02-20 23:32:04 +09:00
Jean Chalard
a118d19f6c Merge "Don't distrust the cursor pos so much as to bug on IPC delay" 2014-02-20 14:22:48 +00:00
Jean Chalard
3c84eb8822 Don't distrust the cursor pos so much as to bug on IPC delay 
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.

When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.

However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.

Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).

So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.

Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
 2014-02-20 23:13:14 +09:00
Keisuke Kuroyanagi
d36328cecf Add test only methods to test personalized dicts. 
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
 2014-02-20 22:20:43 +09:00
Keisuke Kuroyanagi
485c1ec685 Merge "Add final and volatile for members of InputLogic." 2014-02-20 10:12:45 +00:00
Keisuke Kuroyanagi
afdb6f011b Merge "Add user history dictionary decaying test." 2014-02-20 10:05:20 +00:00
Keisuke Kuroyanagi
b063377e77 Add final and volatile for members of InputLogic. 
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
 2014-02-20 18:55:19 +09:00
Keisuke Kuroyanagi
0bc66daae3 Add user history dictionary decaying test. 
Bug: 10667710

Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
 2014-02-20 18:36:46 +09:00
Keisuke Kuroyanagi
a514ea7e1b Merge "Check all enabled IME's subtypes to enable personalization." 2014-02-20 09:33:21 +00:00
Keisuke Kuroyanagi
d10e2d85af Merge "Throw IOException when dict header cannot be read." 2014-02-20 09:33:08 +00:00
Keisuke Kuroyanagi
afd9b62f00 Throw IOException when dict header cannot be read. 
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
 2014-02-20 18:11:17 +09:00
Jean Chalard
475f9f35b6 Merge "Comments improvements" 2014-02-20 08:22:39 +00:00
Tadashi G. Takaoka
1672ccbbb6 Change important notice version preference file 
This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.

Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
 2014-02-20 16:50:34 +09:00
Tadashi G. Takaoka
78db739cdb Fix build due to Ib4c472756f 
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
 2014-02-20 16:16:57 +09:00
Jean Chalard
ad2cf220a9 Merge "Remove a call to a deprecated method" 2014-02-20 06:40:46 +00:00
Tadashi G. Takaoka
251ed3b358 Merge "Revert "Turn off personalization default settings"" 2014-02-20 06:26:48 +00:00
Tadashi G. Takaoka
c2ba73ab41 Revert "Turn off personalization default settings" 
This reverts commit 0a4ac795d6.

Bug: 10587358
Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
 2014-02-20 06:06:29 +00:00
Keisuke Kuroyanagi
6b23749dec Check all enabled IME's subtypes to enable personalization. 
Bug: 13067743

Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
 2014-02-20 15:05:37 +09:00
Jean Chalard
c44b7312ad Remove a call to a deprecated method 
...that would cause a crash

Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
 2014-02-20 14:40:38 +09:00
Tadashi G. Takaoka
f16d63c644 Tweak key popup animation parameters 
Key popup show up start scale 98%
Key popup dismiss end scale 94%
Key popup show up duration 17ms
Key popup dismiss duration 53ms

Bug: 11518021
Change-Id: Icfde99969163f05cfaed1050ea074545d44db13b
 2014-02-20 14:20:44 +09:00
Jean Chalard
be8ad77ebb Comments improvements 
Typo fixes and clarifications

Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
 2014-02-20 13:29:43 +09:00
Baligh Uddin
bb17354041 Merge "Import translations. DO NOT MERGE" 2014-02-19 22:16:21 +00:00
Keisuke Kuroyanagi
34fb962513 Call PersonalizationDictionarySessionRegistrar.init(). 
Wrongly removed in I1f50cb137b6054dc9.

Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
 2014-02-19 23:27:14 +09:00
Keisuke Kuroyanagi
d102eb80da Remove personalization dicts for multilingual users. 
Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
 2014-02-19 21:00:27 +09:00
Tadashi G. Takaoka
920c40fe45 Use AlertDialog.setOnDismissListener 
AlertDialog.Builder.setOnDismissListener is supported from API 17.

Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
 2014-02-19 19:05:06 +09:00
Tadashi G. Takaoka
ed616083dd Merge "Turn personalization on when important notice dialog is displayed" 2014-02-19 09:46:15 +00:00
Tadashi G. Takaoka
6abc852255 Turn personalization on when important notice dialog is displayed 
This change must be checked in together with Ifde70b1d3b.

Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
 2014-02-19 18:36:32 +09:00
Tadashi G. Takaoka
3a7ed5fdfe Merge "Fix IllegalStateException raied by monkey" 2014-02-19 08:27:37 +00:00
Tadashi G. Takaoka
9fd7447d6c Fix IllegalStateException raied by monkey 
Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
 2014-02-19 16:40:52 +09:00
Keisuke Kuroyanagi
03105290d8 Merge "Throw exception when the header cannot be read." 2014-02-19 04:59:47 +00:00
Tadashi G. Takaoka
776bba098b Merge "Turn off personalization default settings" 2014-02-19 04:25:04 +00:00
Keisuke Kuroyanagi
97a40d030f Throw exception when the header cannot be read. 
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
 2014-02-19 12:35:58 +09:00
Keisuke Kuroyanagi
e49e007bb2 Fix: Use old suggest after reloading. 
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
 2014-02-19 12:34:09 +09:00
Tadashi G. Takaoka
0a4ac795d6 Turn off personalization default settings 
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.

Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
 2014-02-19 12:08:50 +09:00
Jean Chalard
80d413caff Merge "Straighten out database cursors behavior." 2014-02-18 11:09:38 +00:00
Jean Chalard
28e0b24965 Merge "Fix a bug where the cache would be out of sync" 2014-02-18 10:58:50 +00:00
Jean Chalard
b8ff8ca9d9 Straighten out database cursors behavior. 
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.

It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.

Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
 2014-02-18 19:58:23 +09:00
Jean Chalard
fe92c174ea Fix a bug where the cache would be out of sync 
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.

Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
 2014-02-18 19:55:54 +09:00
Jean Chalard
783dabb812 Merge "Cleanup." 2014-02-18 09:54:33 +00:00
Jean Chalard
63be066544 Cleanup. 
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.

Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
 2014-02-18 17:07:46 +09:00
Ken Wakasa
266c8c5b1d Merge "Some cosmetic fixes in LatinIME.java" 2014-02-18 06:08:34 +00:00
Ken Wakasa
12ff7da19d Some cosmetic fixes in LatinIME.java 
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
 2014-02-18 14:56:50 +09:00
Jean Chalard
db21fad18f Merge "Avoid crashing when the Content URL is not found." 2014-02-18 05:35:54 +00:00
Jean Chalard
9967f0a1d0 Avoid crashing when the Content URL is not found. 
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.

Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
 2014-02-18 14:27:58 +09:00
Baligh Uddin
0f8134dc40 Merge "Import translations. DO NOT MERGE" 2014-02-18 04:58:14 +00:00
Ken Wakasa
0d32643e69 Merge "Cosmetic fixes" 2014-02-18 03:28:04 +00:00
Ken Wakasa
2312c1954f Cosmetic fixes 
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
 2014-02-18 12:17:24 +09:00
Tadashi G. Takaoka
cc05f468ca Merge "Refactor InputAttributes a bit" 2014-02-18 02:25:46 +00:00
Baligh Uddin
3a73aa4182 Import translations. DO NOT MERGE 
Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709
Auto-generated-cl: translation import
 2014-02-17 18:19:28 -08:00
Baligh Uddin
af78cea362 Import translations. DO NOT MERGE 
Change-Id: I2dc0e76dc4c696c1a7e9748b55e1badd273aea09
Auto-generated-cl: translation import
 2014-02-17 18:17:03 -08:00
Tadashi G. Takaoka
06fbfc4951 Refactor InputAttributes a bit 
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
 2014-02-18 11:11:36 +09:00
Tadashi G. Takaoka
affdd36423 Set neutral suggestions should be called after load settings 
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
 2014-02-18 11:04:00 +09:00
Tadashi G. Takaoka
f0f4e9fc16 Update important notice version even when user select Settings 
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
 2014-02-18 00:14:30 +09:00
Jean Chalard
782c9fee6b Merge "Don't resume suggestion on links." 2014-02-17 11:46:54 +00:00
Jean Chalard
7a7aeffcdc Don't resume suggestion on links. 
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
 2014-02-17 20:36:16 +09:00
Jean Chalard
d91cd9919e Merge "Catch exceptions we can't do anything about." 2014-02-17 11:33:39 +00:00
Tadashi G. Takaoka
da0edf86c4 Merge "Stop overriding InputView.dispatchTouchEvent" 2014-02-17 10:55:11 +00:00
Tadashi G. Takaoka
5cd732f8c5 Stop overriding InputView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
 2014-02-17 19:51:47 +09:00
Jean Chalard
a149731a67 Catch exceptions we can't do anything about. 
This also abstracts away the "package deactivated" case for
simpler and safer code.

Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
 2014-02-17 18:49:31 +09:00
Jean Chalard
1e9897b0c7 Merge "Consider non-breaking spaces separators." 2014-02-17 09:45:41 +00:00
Tadashi G. Takaoka
891e4860f8 Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 2014-02-17 09:20:54 +00:00
Jean Chalard
c051ee7025 Consider non-breaking spaces separators. 
Bug: 13056209
Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
 2014-02-17 18:20:46 +09:00
Tadashi G. Takaoka
e32548f32d Stop overriding SuggestionStripView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
 2014-02-17 18:11:10 +09:00
Tadashi G. Takaoka
1751615f7d Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 2014-02-17 08:26:38 +00:00
Tadashi G. Takaoka
3dd6bdf931 Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 2014-02-17 08:25:57 +00:00
Tadashi G. Takaoka
800ab579a9 Remove unnecessary override of MainKeyboardView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
 2014-02-17 17:09:06 +09:00
Tadashi G. Takaoka
4c628b9d5b Merge "Don't show important notice on password field" 2014-02-17 08:04:11 +00:00
Tadashi G. Takaoka
20ddd4cff5 Add InputMethodSubtypeCompatUtils.isAsciiCapable() 
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
 2014-02-17 16:08:33 +09:00
Tadashi G. Takaoka
ce78a2d8ab Don't show important notice on password field 
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
 2014-02-17 15:38:43 +09:00
Tadashi G. Takaoka
4f4fb5ef34 Merge "Use the same label of switch-to-alphabet key on Emoji palette" 2014-02-17 06:13:39 +00:00
Tadashi G. Takaoka
4c680e7bcf Merge "Add go to "Settings" button to important notice dialog" 2014-02-17 06:13:26 +00:00
Tadashi G. Takaoka
28c02b400f Add go to "Settings" button to important notice dialog 
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.

This change must be checked in together with Id115d89ba9.

Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
 2014-02-17 14:57:04 +09:00
Tadashi G. Takaoka
fe39aec08a Use the same label of switch-to-alphabet key on Emoji palette 
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
 2014-02-17 14:54:39 +09:00
Tadashi G. Takaoka
b092aef4a7 Merge "Remove key show up and dismiss animation" 2014-02-17 03:22:48 +00:00
Tadashi G. Takaoka
c9072dc8da Remove key show up and dismiss animation 
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
 2014-02-17 12:10:09 +09:00
Tadashi G. Takaoka
ffde401b65 Fix PC/QWERTY phone layout 
Bug: 13025426
Change-Id: I980832ccab7fb7700ca8b01d4f05e920b3f45582
 2014-02-17 09:27:47 +09:00
Keisuke Kuroyanagi
95d16561e0 Remove unused code. 
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
 2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi
0fc93fe445 Implement PatriciaTriePolicy::getNextWordAndNextToken(). 
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
 2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi
85fe06e759 Merge "Remove unused argument from readDictionaryBinary." 2014-02-14 10:37:56 +00:00
Tadashi G. Takaoka
36d606fcbc Use 16sp text to show important notice title 
Bug: 10587358
Change-Id: Ib840cb71d9e87282ea0d13839dbf2a2da2081d5f
 2014-02-14 19:10:47 +09:00
Keisuke Kuroyanagi
8e3a1d0f89 Remove unused argument from readDictionaryBinary. 
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
 2014-02-14 19:02:15 +09:00
Tadashi G. Takaoka
b136b7dd6f Merge "Add sanity check to KeybaordTextsTable for debugging" 2014-02-14 09:52:36 +00:00
Tadashi G. Takaoka
53a237323a Add sanity check to KeybaordTextsTable for debugging 
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
 2014-02-14 18:51:03 +09:00
Jean Chalard
fdc4173213 Merge "Fix a view-related crash" 2014-02-14 09:19:34 +00:00
Jean Chalard
a7e3e74ddd Fix a view-related crash 
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
 2014-02-14 18:03:34 +09:00
Tadashi G. Takaoka
3c4f05dd66 Remove unused label_tab_key 
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
 2014-02-14 17:40:53 +09:00
Tadashi G. Takaoka
e422c94634 Fix test resource declarations and parsing a bit 
Change-Id: I882a41b2934c48f4405f1ea5bf4d6ad41e87322c
 2014-02-14 16:27:26 +09:00
Tadashi G. Takaoka
d4469756be Merge "Special punctuations for Arabic and Persian" 2014-02-14 07:20:25 +00:00
Tadashi G. Takaoka
17993ed4ef Merge "Fix null KeyDetector reference" 2014-02-14 07:17:33 +00:00
Tadashi G. Takaoka
d508b676cf Special punctuations for Arabic and Persian 
This change also removes duplications from tablet punctuation suggestions

Bug: 12640318
Change-Id: I221922484027d6b91e2f23a6bf60a18766f3a13c
 2014-02-14 16:11:50 +09:00
Tadashi G. Takaoka
32a7e079e0 Merge "Add PunctuationSuggestions class" 2014-02-14 06:19:52 +00:00
Tadashi G. Takaoka
42e4ea7d6c Add Kazakh (kk) subtype 
The Kazakh (kk) subtype has been temporarily disabled by Ic44ef378a9.

Bug: 9698902
Change-Id: Ib2096cdf79fd45d36f5504be55f76416ba11445d
 2014-02-14 15:16:16 +09:00
Tadashi G. Takaoka
a273319c59 Add PunctuationSuggestions class 
This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
 2014-02-14 14:13:39 +09:00
Jean Chalard
4197c6f3ab Merge "Show the suggestion strip for the important notice" 2014-02-14 04:07:46 +00:00
Tadashi G. Takaoka
ef8a03685f Fix null KeyDetector reference 
This change must be checked in together with I737c266c45.

Bug: 13011041
Change-Id: Ia3d25be6de47fa16ab7156a25641e53a23948ff4
 2014-02-14 11:42:09 +09:00
Yohei Yukawa
362ab36cf0 Fix a null object reference crash on Emoji Palette 
Do nothing if the current EmojiPageKeyboardView is null.

BUG: 13006906
Change-Id: I169b70122ec939075b5be033953b48762fd528fc
 2014-02-14 10:36:31 +09:00
Yohei Yukawa
5f9f4b929b Merge "Fix indent." 2014-02-14 01:26:48 +00:00
Jean Chalard
5e09958056 Merge "Backward compatibility hack : send delete when empty." 2014-02-13 10:09:41 +00:00
Jean Chalard
2c48846903 Backward compatibility hack : send delete when empty. 
Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.

This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.

Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
 2014-02-13 18:41:54 +09:00
Tadashi G. Takaoka
7ae6721ffa Remove RTL aware !code and add corresponding !text 
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
 2014-02-13 17:32:09 +09:00
Tadashi G. Takaoka
3cb77678f5 Fix Armenian switch to alphabet key text 
Bug: 7963631
Change-Id: If5768c761ec96d3404900b0c017abc2317cce8d4
 2014-02-13 17:26:16 +09:00
Tadashi G. Takaoka
0af6d988a7 Merge "Optimize KeyboardTextsTable" 2014-02-13 08:22:58 +00:00
Tadashi G. Takaoka
0fe4d00068 Optimize KeyboardTextsTable 
This change counts all occurrences of each string resource and sort
those in descending order of the occurrence.

Change-Id: I726402157feb0d436a54bd0a7252acd17fd711f9
 2014-02-13 17:11:00 +09:00
Tadashi G. Takaoka
36b8962a9a Merge "Fix UserHistoryDictionaryTests" 2014-02-13 07:49:51 +00:00
Tadashi G. Takaoka
32c8d58cef Merge "Fix showing all suggestions when the top suggestion is long" 2014-02-13 07:17:31 +00:00
Tadashi G. Takaoka
0cda0e8a9c Fix UserHistoryDictionaryTests 
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
 2014-02-13 16:16:44 +09:00
Baligh Uddin
d23cef69c6 Merge "Import translations. DO NOT MERGE" 2014-02-13 06:43:25 +00:00
Tadashi G. Takaoka
4f8a8f125e Fix showing all suggestions when the top suggestion is long 
This change also fixes Bug#12982404; displays the suggestion word
using entire suggestions strip if there is only one suggestion.

Bug: 12564279
Bug: 12982404
Change-Id: I51806b90c3ee34a2072880245d4e33f7be273c8f
 2014-02-13 15:22:36 +09:00
Jean Chalard
e0a425681c Merge "Fix a test." 2014-02-13 05:20:58 +00:00
Jean Chalard
cf03ff02b1 Fix a test. 
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.

Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
 2014-02-13 14:01:37 +09:00
Tadashi G. Takaoka
8dd47029f1 Merge "Refactor dictionary constructor" 2014-02-13 04:55:16 +00:00
Jean Chalard
c3cfabd0eb Merge "Dump settings." 2014-02-13 04:26:52 +00:00
Tadashi G. Takaoka
870d89b1a8 Refactor dictionary constructor 
This change must be checked in together with I3923d5af2a.

Bug: 12994268
Change-Id: I19de6efbdfa3b6c6c69a20a836e53962fd5737de
 2014-02-13 13:23:55 +09:00
Baligh Uddin
a973e0926a Import translations. DO NOT MERGE 
Change-Id: Ibf72865a393c8e5e41ef6420e7131bbcddfb18e5
Auto-generated-cl: translation import
 2014-02-12 16:04:35 -08:00
Yohei Yukawa
cfe26bbcde Fix indent. 
This is a follow up for the previous commit to fix indent.

BUG: 12964092
Change-Id: I0530b1c0dae26ac736ddcc6d426ec6ce57bce4d1
 2014-02-13 01:58:58 +09:00
Jean Chalard
367a35d377 Dump settings. 
Bug: 10315296
Change-Id: Ieb020a23886514b3ba97611d8a6001f32b322f63
 2014-02-12 22:53:15 +09:00
Yohei Yukawa
50fbe4cc09 Merge "Cancel keydown events immediately once the view starts scrolling" 2014-02-12 10:21:08 +00:00
Yohei Yukawa
4c259866c4 Cancel keydown events immediately once the view starts scrolling 
The motivation of this patch is to make sure a user never feel
haptic feedback when scrolling the Emoji palette. In order to
achieve it, EmojiPageKeyboardView#releaseCurrentKey() should
be called whenever (delayed) keydown events should be canceled.

This patch wires up ViewPager.OnPageChangeListener#onPageScrolled
with EmojiPageKeyboardView#releaseCurrentKey() so that delayed
keydown events will be canceled immediately once the ViewParger
starts scrolling.

BUG: 12964092
Change-Id: Iea8c3e090bb16a8622e6b4a850af2bf963aa77d0
 2014-02-12 18:56:08 +09:00
Tadashi G. Takaoka
5a885e85c2 Merge "Keep showing key preview even when keyboard has been changed" 2014-02-12 09:40:55 +00:00
Tadashi G. Takaoka
dd6ba4b184 Merge "Fix bug in KeyPreviewChoreographer.dismissKeyPreview" 2014-02-12 09:13:37 +00:00
Jean Chalard
8adedbf47c Show the suggestion strip for the important notice 
Bug: 10587358
Change-Id: Ia060a9ca9dfc2e7fe0750536a9fea3b9cc5900c4
 2014-02-12 17:30:04 +09:00
Tadashi G. Takaoka
075158ccd0 Keep showing key preview even when keyboard has been changed 
Bug: 12979147
Change-Id: I7e1f60686d6a8a0fca463174abb0a45f1f62ca43
 2014-02-12 15:09:03 +09:00
Tadashi G. Takaoka
7e9b0b42bf Fix bug in KeyPreviewChoreographer.dismissKeyPreview 
Bug: 12979147
Change-Id: Ibc60b4565badaebe760194f27984b02f9f966996
 2014-02-12 14:50:56 +09:00
Tadashi G. Takaoka
351c8e6185 Merge "Make importance notice dialog cancel able" 2014-02-12 04:25:59 +00:00
Keisuke Kuroyanagi
b05b183f60 Merge "Increase CHAR LIMIT for personalized setting." 2014-02-12 04:11:16 +00:00
Keisuke Kuroyanagi
29c92c40e0 Increase CHAR LIMIT for personalized setting. 
Bug: 12189366
Change-Id: I19764b3aaf97319ac841460ac2a6ab1571d3ea2b
 2014-02-12 12:23:22 +09:00
Tadashi G. Takaoka
7ffac033ac Make importance notice dialog cancel able 
Bug: 10587358
Change-Id: I7415a6f33e6b5542718164fea1555095d23233e5
 2014-02-12 11:59:43 +09:00
Baligh Uddin
2089afd257 Merge "Import translations. DO NOT MERGE" 2014-02-11 21:33:06 +00:00
Tadashi G. Takaoka
6e1710f0d4 Merge "Optimize text resources' ordering a bit" 2014-02-11 13:33:42 +00:00
Tadashi G. Takaoka
d495cc36b7 Merge "Get nicer output of make-keyboard-text" 2014-02-11 12:43:32 +00:00
Tadashi G. Takaoka
8bfd6100d9 Optimize text resources' ordering a bit 
Change-Id: I19382f1d9a4b6be173d1e9f62edd727ea987fa20
 2014-02-11 21:41:55 +09:00
Tadashi G. Takaoka
ed509695a4 Get nicer output of make-keyboard-text 
Change-Id: I6d30127aac2198d55b1335002f7a66b4aaebf82d
 2014-02-11 21:41:21 +09:00
Baligh Uddin
d8e4928372 Import translations. DO NOT MERGE 
Change-Id: I55e2d607627ba6f1f27c8cc60ffe8416f250638e
Auto-generated-cl: translation import
 2014-02-10 17:55:21 -08:00
Jean Chalard
3df8bcb7a9 Revert "Display predictions when the cursor is moved after a word." 
This change is lacking some comments and break some unit tests.
It needs more work.

This reverts commit 38d31a5e79.

Change-Id: I675854fd0729f2d01b7751e35c6d0117f4f88993
 2014-02-10 14:24:30 +00:00
Jean Chalard
38d31a5e79 Display predictions when the cursor is moved after a word. 
Bug: 12951777
Change-Id: I744b98df6679edd34ca3c1392e38597325935932
 2014-02-10 23:07:00 +09:00
Jean Chalard
f9e5b1ee4f Merge "Show important notice strip" 2014-02-10 12:18:10 +00:00
Tadashi G. Takaoka
8dda9e480b Show important notice strip 
Bug: 10587358
Change-Id: I1af3faa59afb2fc4cb90176acff1c2b0b1ba369c
 2014-02-10 21:15:35 +09:00
Keisuke Kuroyanagi
ea24abf878 Merge "Remove unused code." 2014-02-10 07:19:53 +00:00
Keisuke Kuroyanagi
2ef87aee3e Merge "Make PtNode have ProbabilityInfo instead of raw value." 2014-02-10 06:10:51 +00:00
Keisuke Kuroyanagi
69ccac6e51 Remove unused code. 
Bug: 12810574
Change-Id: If0ef02a984469a3b6e0c00b1c3c8d98d0d2b5466
 2014-02-10 15:05:11 +09:00
Keisuke Kuroyanagi
8ffc631826 Make PtNode have ProbabilityInfo instead of raw value. 
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
 2014-02-10 15:05:08 +09:00
Tadashi G. Takaoka
cbb0a6de3b Merge "Fix possible NPE while finding device override value from resource" 2014-02-10 05:51:44 +00:00
Tadashi G. Takaoka
bd9887a574 Fix possible NPE while finding device override value from resource 
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
 2014-02-10 14:38:53 +09:00
Tadashi G. Takaoka
f70bcf3d32 Refactor Key constructors 
This is a followup of I76432556ca.

Change-Id: Ie2c8f7c23352a33db28e89ee8e6ebaba9eb760a3
 2014-02-10 11:14:35 +09:00
Tadashi G. Takaoka
e592c1b291 Merge "Add example attribute to <xliff:g> elements in string resources" 2014-02-10 02:09:08 +00:00
Tadashi G. Takaoka
1271da4679 Add example attribute to <xliff:g> elements in string resources 
Bug: 8693729
Change-Id: Ide98ab83439cda43a8b84aaf64d0a9c18e44a8cc
 2014-02-10 10:49:43 +09:00
Tadashi G. Takaoka
541a3d394c Remove unused import 
Change-Id: I3f934de281eefb387026585e678d783a95729720
 2014-02-10 10:22:29 +09:00
Tadashi G. Takaoka
45eb5d924d Allow an empty keySpec for Spacer 
Bug: 12933248
Change-Id: I76432556caf319ce23c1fb7fa3d6b94118e64cf8
 2014-02-09 23:45:23 +09:00
Tadashi G. Takaoka
c44cbf6a3d Merge "Generate KeyboardTextsTable.java instead of KeyboardTextsSet.java" 2014-02-07 10:39:57 +00:00
Tadashi G. Takaoka
c8a0117c9c Fix undefined emojiKeyStyle 
Change-Id: I6798f524c9ac0d2911f2b83a5a5ef650f0815917
 2014-02-07 19:35:00 +09:00
Tadashi G. Takaoka
e5320c1d1f Generate KeyboardTextsTable.java instead of KeyboardTextsSet.java 
Change-Id: Ic48b093dc64b514822cc9daa1ac3d79deb7af089
 2014-02-07 18:56:23 +09:00
Tadashi G. Takaoka
4f72923fa2 Merge "Rename Key.keyLabel attribute to KeySpec" 2014-02-07 09:53:43 +00:00
Tadashi G. Takaoka
4e85476740 Merge "Consolidate keyIcon and code with keyLabel attribute" 2014-02-07 09:53:35 +00:00
Tadashi G. Takaoka
9684b33b69 Rename Key.keyLabel attribute to KeySpec 
Change-Id: Ida48cd9bdbc01fefad651a005084262c0f46c41c
 2014-02-07 18:47:45 +09:00
Tadashi G. Takaoka
a83a1feb62 Consolidate keyIcon and code with keyLabel attribute 
Change-Id: I75fbd348fab5022606ca14552eb03b15af6684c8
 2014-02-07 18:47:22 +09:00
Tadashi G. Takaoka
a9e1db6636 Merge "Decimal number is treated as outputText" 2014-02-07 09:26:04 +00:00
Tadashi G. Takaoka
276b1a2ebc Add debug settings for keypress popup animations 
Bug: 12928125
Change-Id: I49faab754c7d1dcf4a791dfc535d3a78b62ce67a
 2014-02-07 18:09:41 +09:00
Keisuke Kuroyanagi
6422f77e94 Merge "Use native logic to read Ver4 dict." 2014-02-06 13:00:09 +00:00
Keisuke Kuroyanagi
ab6a93773b Use native logic to read Ver4 dict. 
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
 2014-02-06 21:55:37 +09:00
Keisuke Kuroyanagi
fc6d0f8738 Merge "Implement getHeaderInfoNative." 2014-02-06 11:26:49 +00:00
Keisuke Kuroyanagi
fc9ca59cc1 Implement getHeaderInfoNative. 
Bug: 11281877
Bug: 12810574
Change-Id: Ia3d85ae2cfdb486e74b8636a62431eae883c85da
 2014-02-06 18:19:42 +09:00
Tadashi G. Takaoka
3bbd50c36b Use SubtypeLocaleUtils.isRtlLanguage 
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
 2014-02-06 18:15:32 +09:00
Tadashi G. Takaoka
48ea52800a Merge "Consolidate keyOutputText with keyLabel attribute" 2014-02-06 09:14:09 +00:00
Tadashi G. Takaoka
d645db1e37 Merge "Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag" 2014-02-06 09:01:41 +00:00
Tadashi G. Takaoka
a9b67135bd Merge "Parse keyLabel for icon, code, and outputText as well" 2014-02-06 08:38:54 +00:00
Tadashi G. Takaoka
df75444239 Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag 
This change must be checked in together with Iac93eb79fc.

Bug: 12913520
Bug: 12179576
Change-Id: Ic9a40fb0529202893be8ccb6f5abfbbe6d78508c
 2014-02-06 17:28:08 +09:00
Tadashi G. Takaoka
0df462730b Remove unused smiley key definitions 
Change-Id: Icbdfb360abab2964869898949774f47197f6d000
 2014-02-06 16:56:42 +09:00
Tadashi G. Takaoka
d6f147e142 Consolidate keyOutputText with keyLabel attribute 
Change-Id: I90ea2c9d5ce42fabc79599995a2fae1f5f652a6b
 2014-02-06 16:42:57 +09:00
Tadashi G. Takaoka
6193217f5c Parse keyLabel for icon, code, and outputText as well 
Change-Id: I023915b68b4aabd056c2c1eb745876471556e15e
 2014-02-06 16:42:17 +09:00
Jean Chalard
a9e1930a6a Merge "Conditionally store the raw suggestions." 2014-02-06 07:31:22 +00:00
Tadashi G. Takaoka
4a64ad9538 Decimal number is treated as outputText 
Change-Id: I9d4a8ac5dd26a7c41fcfbe1842a40f347a2f2aab
 2014-02-06 16:30:12 +09:00
Keisuke Kuroyanagi
fd018c1588 Merge "Use CombinedFormatUtils to convert dict elements to strings." 2014-02-06 07:29:30 +00:00
Jean Chalard
a49f61f8a7 Conditionally store the raw suggestions. 
Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
 2014-02-06 16:14:41 +09:00
Keisuke Kuroyanagi
b24de426fc Use CombinedFormatUtils to convert dict elements to strings. 
Bug: 11281877
Bug: 12810574
Change-Id: Ib631f75eab73abc9877a7698171c45e8f2fc7600
 2014-02-06 16:09:25 +09:00
Keisuke Kuroyanagi
337dce8074 Merge "Consolidate WordProperty and Word." 2014-02-06 07:02:07 +00:00
Keisuke Kuroyanagi
0c088e2d74 Merge "Unregister DictionaryDumpBroadcastReceiver in onDestroy()." 2014-02-06 06:55:42 +00:00
Keisuke Kuroyanagi
f2d15d6956 Unregister DictionaryDumpBroadcastReceiver in onDestroy(). 
Change-Id: I83a05a8369c2fe2fa7522f18eb00983a0b10dc19
 2014-02-06 15:37:41 +09:00
Keisuke Kuroyanagi
5f5feeba13 Consolidate WordProperty and Word. 
Bug: 11281877
Bug: 12810574
Change-Id: I9dc99188f80f25a8780c1860dab46e4aa80a23e5
 2014-02-06 15:13:33 +09:00
Jean Chalard
7ee6be46b3 Merge "Remove a redundant comment." 2014-02-06 05:42:15 +00:00
Geoff Mendal
2212385061 Import translations. DO NOT MERGE 
Change-Id: Ib99535e93fac58d7e5b22595015096b7be9d0d98
Auto-generated-cl: translation import
 2014-02-05 16:55:40 -08:00
Jean Chalard
058d615121 Remove a redundant comment. 
No need to say this twice.

Change-Id: Ief7ac425037aa2767ee8f21c9552138a9c46afc8
 2014-02-05 22:42:38 +09:00
Jean Chalard
58eed6360d Merge "Stop considering personalization dicts outputs as words" 2014-02-05 13:33:12 +00:00
Jean Chalard
5095fabdd0 Stop considering personalization dicts outputs as words 
Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410
 2014-02-05 21:57:37 +09:00
Keisuke Kuroyanagi
239f7daf4a Merge "Make WeightedString have ProbabilityInfo." 2014-02-05 12:53:14 +00:00
Keisuke Kuroyanagi
df1d3e733e Make WeightedString have ProbabilityInfo. 
Bug: 11281877
Bug: 12810574
Change-Id: I265e3d8654c75766cd0e0d09d67ef62b4566298a
 2014-02-05 21:44:55 +09:00
Keisuke Kuroyanagi
e42380a471 Merge "Separate ProbabilityInfo form WordProperty." 2014-02-05 12:37:49 +00:00
Keisuke Kuroyanagi
75a3df30f6 Separate ProbabilityInfo form WordProperty. 
Bug: 11281877
Bug: 12810574
Change-Id: I0c77d976c915bdf2a2cddabd0cbedc2fb6691c7b
 2014-02-05 21:31:35 +09:00
Jean Chalard
8fb2f6a441 Merge "Fix a flash in the wrong place" 2014-02-05 09:46:44 +00:00
Jean Chalard
9e9e948a70 Fix a flash in the wrong place 
Bug: 7226099
Change-Id: I8f74802b3ae24018fc4176fb2fff2c777ae170b0
 2014-02-05 18:44:24 +09:00
Tadashi G. Takaoka
02a534d13f Merge "Treat a sole "|" as a special case of key label" 2014-02-05 09:32:12 +00:00
Tadashi G. Takaoka
6e5dbdd501 Merge "Add null check to KeySpecParser" 2014-02-05 09:32:04 +00:00
Tadashi G. Takaoka
6a16fa1f10 Merge "Refactor KeySpecParser a bit" 2014-02-05 09:17:01 +00:00
Jean Chalard
b162911fa4 Merge "[HD04] Make the locale mandatory." 2014-02-05 09:16:17 +00:00
Tadashi G. Takaoka
f7d8b8fcbc Treat a sole "|" as a special case of key label 
Change-Id: Ia72c31d15c891fa522935ba9792e88fd5d8ce7f7
 2014-02-05 17:57:44 +09:00
Jean Chalard
bbb6e8f10f Merge "[IL109] Move more code to InputLogic" 2014-02-05 08:50:28 +00:00
Jean Chalard
a6ea33b4d7 Merge "[IL108] Remove some uses of LatinIME in input logic." 2014-02-05 08:49:44 +00:00
Tadashi G. Takaoka
d9c6b33209 Add null check to KeySpecParser 
Change-Id: Ic37db8cbf8f83f753d7381e1edba8eac1ef1ceb1
 2014-02-05 17:49:26 +09:00
Tadashi G. Takaoka
bc9514032a Refactor KeySpecParser a bit 
Change-Id: I1208746f42eb92f937812149033398d8318f9c4e
 2014-02-05 17:43:53 +09:00
Jean Chalard
43cf9076b2 [HD04] Make the locale mandatory. 
Bug: 11281748
Change-Id: I69281b0053bec404c3e3c713ade3f65a140f51b1
 2014-02-05 17:35:25 +09:00
Tadashi G. Takaoka
bb476be4e6 Move key preview related methods to KeyPreviewChoreographer 
Change-Id: Ia8d6b7fa922a4da233bf851b2e94bbd2573a65a3
 2014-02-05 15:41:39 +09:00
Tadashi G. Takaoka
f2749e41e4 Merge "Revert "Move key preview related methods to KeyPreviewChoreographer"" 2014-02-05 06:28:45 +00:00
Tadashi G. Takaoka
32d6c6a400 Revert "Move key preview related methods to KeyPreviewChoreographer" 
This reverts commit 38806940b9.

Change-Id: I185c4d5f5d92dd269f678206ef3ff8316cbce6ed
 2014-02-05 06:27:41 +00:00
Jean Chalard
2bb1c6add9 [IL109] Move more code to InputLogic 
Bug: 8636060
Change-Id: Ib12eacc836e8d39c4165c97a2a287f32f6bf5405
 2014-02-05 14:49:59 +09:00
Jean Chalard
2c01dd00f2 [IL108] Remove some uses of LatinIME in input logic. 
Access the suggestion strip through the interface instead.

Bug: 8636060
Change-Id: Ia8bd705c230f943e309d677ef683b1a2cbe68036
 2014-02-05 14:49:59 +09:00
Jean Chalard
ade1aa55b6 [IL107] Add an interface to access the suggestion view. 
Bug: 8636060
Change-Id: I603af6bcdaa31f64aaaf916784720a133388c737
 2014-02-05 14:49:57 +09:00
Tadashi G. Takaoka
aac53dd7f5 Merge "Move key preview related methods to KeyPreviewChoreographer" 2014-02-05 03:45:08 +00:00
Keisuke Kuroyanagi
c488048634 Merge "Check isEligibleForAutoCommit when batch input is ended." 2014-02-05 03:34:46 +00:00
Tadashi G. Takaoka
38806940b9 Move key preview related methods to KeyPreviewChoreographer 
Change-Id: I18cbbd287313826bc72437c6ebab2915c1d7bc50
 2014-02-05 12:34:06 +09:00
Keisuke Kuroyanagi
8c5c01e981 Check isEligibleForAutoCommit when batch input is ended. 
Bug: 11951198
Change-Id: Ibbe09fa38eaa3ebf8f9b69f744a29db7ac598975
 2014-02-05 11:40:17 +09:00
Tadashi G. Takaoka
66b2fcf2bf Merge "Move some XML attributes to KeyPreviewDrawParams" 2014-02-05 00:51:23 +00:00
Keisuke Kuroyanagi
ad37cddd79 Merge "Add jni interface to get header information from native." 2014-02-04 12:52:50 +00:00
Keisuke Kuroyanagi
f32b2d5c5e Merge "Add a utility method to StringUtils." 2014-02-04 12:47:21 +00:00
Keisuke Kuroyanagi
aaf864db7b Merge "Separate header class from FormatSpec." 2014-02-04 12:42:44 +00:00
Keisuke Kuroyanagi
927aff72bc Add jni interface to get header information from native. 
Bug: 12810574
Change-Id: I2508483bcb3157f04cc1fe13f24f864d301f1f28
 2014-02-04 21:42:09 +09:00
Keisuke Kuroyanagi
53fb86c447 Add a utility method to StringUtils. 
Bug: 12810574
Change-Id: I607803e924b9e99855df7690e67488b2861c120e
 2014-02-04 21:42:06 +09:00
Keisuke Kuroyanagi
b986f78ba8 Separate header class from FormatSpec. 
Bug: 12810574
Change-Id: Iacf1cd05a268bf690ab864b5e32a18a4b0ccc693
 2014-02-04 21:36:04 +09:00
Keisuke Kuroyanagi
866fd42091 Merge "Add dictionary dump buttons in debug settings." 2014-02-04 12:34:32 +00:00
Keisuke Kuroyanagi
36c7a62dff Add dictionary dump buttons in debug settings. 
Bug: 11736680
Bug: 12810574
Change-Id: I1f797b5ac6acf94b40d9698d4535e8f5da2bfb17
 2014-02-04 21:29:09 +09:00
Tadashi G. Takaoka
7d09b56812 Move some XML attributes to KeyPreviewDrawParams 
Change-Id: I0e040b3aed63f8da983fcc51d55b55ac9294a16a
 2014-02-04 19:31:45 +09:00
Tadashi G. Takaoka
f7d682cce1 Merge "Refactor KeyPreviewDrawParams a bit" 2014-02-04 10:14:14 +00:00
Keisuke Kuroyanagi
23c487510a Merge "Check timestamp for each pointer." 2014-02-04 08:26:14 +00:00
Keisuke Kuroyanagi
99b7242f78 Merge "Make dumpAllWordsForDebug() use getNextWordProperty()." 2014-02-04 07:51:00 +00:00
Keisuke Kuroyanagi
ffb12e76b8 Merge "Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken." 2014-02-04 07:46:50 +00:00
Tadashi G. Takaoka
992c521909 Refactor KeyPreviewDrawParams a bit 
Change-Id: Ia1a2c5cd882c2524a2e2f02ae052f0404061b2f7
 2014-02-04 16:10:58 +09:00
Keisuke Kuroyanagi
33fd13bf3c Check timestamp for each pointer. 
Bug: 11325631
Change-Id: I4e296cdeccf21323c5732754e86c3a4075ccf82a
 2014-02-04 14:04:26 +09:00
Keisuke Kuroyanagi
d79fd29f61 Make dumpAllWordsForDebug() use getNextWordProperty(). 
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
 2014-02-04 13:51:49 +09:00
Tadashi G. Takaoka
96aee22e7b Merge "Use "Key popup dismiss delay" to control key preview zoom out animation" 2014-02-04 04:42:36 +00:00
Keisuke Kuroyanagi
941734695b Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken. 
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
 2014-02-04 12:42:14 +09:00
Geoff Mendal
0251c60b44 Merge "Import translations. DO NOT MERGE" 2014-02-04 03:19:22 +00:00
Geoff Mendal
9d9fd48fa2 Import translations. DO NOT MERGE 
Change-Id: Ie6d3ca2063815af9086252dd4e2ce177acbb85bb
Auto-generated-cl: translation import
 2014-02-03 19:18:16 -08:00
Geoff Mendal
6c88544f95 Import translations. DO NOT MERGE 
Change-Id: I7b3358893fca57f1ddc457c74daff9b3b2eb2ee4
Auto-generated-cl: translation import
 2014-02-03 19:17:35 -08:00
Tadashi G. Takaoka
5be8a59a5a Use "Key popup dismiss delay" to control key preview zoom out animation 
Bug: 12809303
Change-Id: I2db0362a2f8c512145f1cf9326f06e5f922987b8
 2014-02-04 11:43:58 +09:00
Tadashi G. Takaoka
b06e455797 Clear important notice strip 
Bug: 10587358
Change-Id: Ic90e5825200a1d424aac4ba263b252187a203241
 2014-02-03 18:28:21 +09:00
Tadashi G. Takaoka
4d539f2c1e Merge "Fix important notice strip text layout" 2014-02-03 09:14:02 +00:00
Tadashi G. Takaoka
9706f9a2f4 Fix important notice strip text layout 
Bug: 10587358
Change-Id: I9cbdd3b450e05d6d0611a16b6b7fad945918dd5f
 2014-02-03 18:07:19 +09:00
Tadashi G. Takaoka
a2d83dfdc7 Merge "Show important notice dialog" 2014-02-03 08:04:03 +00:00
Tadashi G. Takaoka
342e81e7a6 Show important notice dialog 
Bug: 10587358
Change-Id: I3b4282a1bb183aa901110a4a2fc1b6ed72818aae
 2014-02-03 16:21:53 +09:00
Jean Chalard
80fa64e66b Merge "Don't resume suggestions if suggestions are not requested." 2014-02-03 07:07:14 +00:00
Jean Chalard
5d9be8039c Merge "Have empty suggestions go through setNeutralSuggestions." 2014-02-03 06:45:45 +00:00
Jean Chalard
2cbf152986 Have empty suggestions go through setNeutralSuggestions. 
Bug: 12865205
Change-Id: If17a390c445d0820325a9b16cc4f2f27a361187a
 2014-02-03 15:33:00 +09:00
Jean Chalard
9068fd4e77 Don't resume suggestions if suggestions are not requested. 
Bug: 12832614
Change-Id: I6a9b6d128d7e0324ba59a43cf153a3b54e1d35bf
 2014-02-03 15:20:45 +09:00
Keisuke Kuroyanagi
38f341a2a5 Add a jni method to iterate words in a dictionary. 
Bug: 12810574
Change-Id: I87b13559765f0262dfd06c2ba40d43af6437ea7f
 2014-02-03 14:51:58 +09:00
Yohei Yukawa
08d72c52f9 Merge "Introduce a delay for key-press feedback on the Emoji palette" 2014-02-03 02:14:59 +00:00
Keisuke Kuroyanagi
5ecf74b148 Merge "Extend jni interface to get bigrams in WordProperty." 2014-01-31 11:53:10 +00:00
Keisuke Kuroyanagi
94d9a2309f Extend jni interface to get bigrams in WordProperty. 
Bug: 12810574
Change-Id: Ia4b88d02ea8790a5c47d32376cc0b84c3e071ddd
 2014-01-31 20:32:44 +09:00
Tadashi G. Takaoka
2abe1cedc8 Merge "Add important notice strip" 2014-01-31 11:23:52 +00:00
Tadashi G. Takaoka
e855093f55 Move some methods to MoreKeySpec class 
Change-Id: I025ed15e36ac3113db6a5fccefa0c87f016703fa
 2014-01-31 20:19:48 +09:00
Tadashi G. Takaoka
8a296e43c9 Add important notice strip 
This change is a groundwork to show important notice.

Bug: 10587358
Change-Id: I80aa70d30e2a529b37798f0df2183b41df3ac38a
 2014-01-31 20:07:27 +09:00
Jean Chalard
4e6f72cb80 Merge "[HD03] Straighten out attribute key names in Java." 2014-01-31 08:40:25 +00:00
Tadashi G. Takaoka
7914a97b73 Merge "Move some prefix strings to relevant classes" 2014-01-31 08:11:56 +00:00
Tadashi G. Takaoka
3b4eb03fa1 Move some prefix strings to relevant classes 
Change-Id: I7321ac7820d4eded5f16f2440ffb4f525315b3f4
 2014-01-31 17:09:14 +09:00
Tadashi G. Takaoka
1e40af5ebe Merge "Refactor KeyboardTextsSet class" 2014-01-31 08:05:02 +00:00
Tadashi G. Takaoka
be0d05c5ef Merge "Move important notice version to resource" 2014-01-31 07:37:13 +00:00
Tadashi G. Takaoka
0bae2ab460 Refactor KeyboardTextsSet class 
Change-Id: I0b48c85aa2c291e1e7ee25d61c558700fc677e29
 2014-01-31 16:31:07 +09:00
Yohei Yukawa
94797fb3a6 Introduce a delay for key-press feedback on the Emoji palette 
Currently key-press effect such as highlight and vibration
occur even when a user want to scroll the Emoji palette.
To mitigate this situation, this patch introduces a short delay
for key-press feedback on the Emoji palette.

This is not an ideal solution but should be better than now.

BUG: 11103083
Change-Id: I1fa4514d742eb37f36fef60e6beabbc5eaa1653a
 2014-01-31 15:48:10 +09:00
Tadashi G. Takaoka
d245f6c9e2 Move arrayAsList method to CollectionUtils 
Change-Id: If7c1eb7c802490f19c5d3b81d714362408daf376
 2014-01-31 15:26:05 +09:00
Tadashi G. Takaoka
de76e62b69 Merge "Move some methods to StringUtils" 2014-01-31 06:16:14 +00:00
Tadashi G. Takaoka
639bf62e4f Move some methods to StringUtils 
Change-Id: I29d87fdd65ec879d1c0bdf7e7792a677687c1693
 2014-01-31 14:49:36 +09:00
Jean Chalard
79b2e4d86c [HD03] Straighten out attribute key names in Java. 
Bug: 11281748
Change-Id: I1d813bdacd45bcfd9c4cc73ac1d67c5c89854e86
 2014-01-31 14:46:07 +09:00
Jean Chalard
b0df28f4cc Merge "[HD02] Make the date header attribute mandatory." 2014-01-31 03:58:55 +00:00
Tadashi G. Takaoka
5b8ffad26c Move important notice version to resource 
Bug: 10587358
Change-Id: Ie24fc6c53b15880f4ace991a25223056f03f5eda
 2014-01-31 12:49:36 +09:00
Keisuke Kuroyanagi
748f32feba Merge "Rename UnigramProperty to WordProperty." 2014-01-31 03:06:44 +00:00
Keisuke Kuroyanagi
080a35e959 Rename UnigramProperty to WordProperty. 
Bug: 12810574
Change-Id: If5ddd803948aaf6e491ddcbaa5436fb3af3f7257
 2014-01-31 11:06:42 +09:00
Jean Chalard
a137c21c9c [HD02] Make the date header attribute mandatory. 
Bug: 11281748
Change-Id: I48a6f3d95ca89ced0c51335527201ecabfb7998e
 2014-01-30 18:19:21 +09:00
Tadashi G. Takaoka
776d46a771 Merge "Show "Touch again to save" in system locale" 2014-01-30 09:17:11 +00:00
Tadashi G. Takaoka
9b1a66843d Show "Touch again to save" in system locale 
Bug: 12811156
Change-Id: I928daf17297ec5c526720850d6203cb9af0496ac
 2014-01-30 18:03:23 +09:00
Keisuke Kuroyanagi
7ceee45376 Merge "Fix historical info of bigrams reading." 2014-01-30 08:21:34 +00:00
Tadashi G. Takaoka
bf2f0892a0 Merge "Add ImportantNoticeUtils class" 2014-01-30 08:08:37 +00:00
Tadashi G. Takaoka
a14ddfb5ff Add ImportantNoticeUtils class 
Bug: 10587358
Change-Id: I76673b47aab1579cc1310b6a978d04f874d5bcfe
 2014-01-30 17:04:05 +09:00
Keisuke Kuroyanagi
971bbcf562 Fix historical info of bigrams reading. 
Bug: 12809791
Change-Id: I879279a0d0e1007a7c6cb87a627bf046340dda98
 2014-01-30 16:19:22 +09:00
Tadashi G. Takaoka
d432892f0c Fix Farsi keyboard comma and period 
Bug: 12807701
Change-Id: I49503e9945d97e13d7cc98f54ca071cb935d1e52
 2014-01-30 15:45:23 +09:00
Jean Chalard
0c186c31d2 Merge "[IL106] Inline a now useless method." 2014-01-30 03:47:32 +00:00
Jean Chalard
90c072a5ba Merge "[IL105] Remove more useless arguments" 2014-01-30 03:46:08 +00:00
Jean Chalard
362779d608 Merge "[IL104] Remove useless arguments" 2014-01-30 03:45:15 +00:00
Jean Chalard
e5040f6b0d Merge "[IL103] Save the typed word separately in SuggestedWords." 2014-01-30 03:44:54 +00:00
Keisuke Kuroyanagi
26bd46095a Reading dictionary containing timestamps in Java Side. 
Just skipping historical information fields.

Bug: 11281877
Change-Id: I43d2adaa576b7da11ed3ca54990265dbb6f53b08
 2014-01-29 20:19:24 +09:00
Jean Chalard
ac84fe642e [IL106] Inline a now useless method. 
Bug: 8636060
Change-Id: Ic8e0225206358680aa0de421f17ab443c888036d
 2014-01-29 12:23:40 +09:00
Jean Chalard
fa7075768d [IL105] Remove more useless arguments 
Bug: 8636060
Change-Id: I9e817bb9622c84544a5ca8708e5c1fccad1ed447
 2014-01-29 12:23:26 +09:00
Jean Chalard
084c9961f4 [IL104] Remove useless arguments 
Bug: 8636060
Change-Id: I97a371fe0c6227eb0f03d3e391a33726e6280322
 2014-01-29 12:23:25 +09:00
Jean Chalard
1d2e4f9dcc [IL103] Save the typed word separately in SuggestedWords. 
This helps managing the cases where the typed word is not
in the suggestions. This happens during recorrection.

Bug: 8636060
Change-Id: I6784feb793cae96272a7f1d123a0e3bbb8f03143
 2014-01-29 12:22:21 +09:00
Tadashi G. Takaoka
a454a7b85c Add method to clear user history dictionary for testing 
This change should be checked in together with I19cd689157.

Bug: 12179576
Change-Id: I5cc9f52a37ad6623809a14575f3f4b1cd18725c3
 2014-01-29 12:01:37 +09:00
Tadashi G. Takaoka
005d2454c9 Merge "Remove suggestion_word and suggestion_info layout files" 2014-01-29 01:05:37 +00:00
Yohei Yukawa
be18530acf Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key" 2014-01-28 10:50:23 +00:00
Tadashi G. Takaoka
c2ea3f7dd9 Remove suggestion_word and suggestion_info layout files 
Change-Id: I37fea41cfc6e717ce7e5aa36ad331675fc9e8ce5
 2014-01-28 19:38:35 +09:00
Yohei Yukawa
576f8a5b72 Fix inconsistent behavior with the back-to-the-main-keyboard key 
With this patch, the back-to-the-main-keyboard in the Emoji
palette will be registered as a key-release action instead of
a key-press action, like switch-to-the-emoji-palette in the
main layout. This provides mroe consistent UX when the layout is
switched from the main layout to the Emoji palette then
switched back to the main layout.

BUG: 12464067
Change-Id: Ia0d0185db43234dfcfb7cee2677f3d199fe6ed96
 2014-01-28 19:30:27 +09:00
Jean Chalard
c9cc1b1de5 [IL102] Rename a method 
Bug: 8636060
Change-Id: Ia54afdfab9124aa5c35699e357e63eae66a7557f
 2014-01-28 17:18:02 +09:00
Jean Chalard
4500dedfa9 [IL101] Remove a method 
Bug: 8636060
Change-Id: Ic9c12fc6970987b0e1912e8ae85bed55260d66b5
 2014-01-28 17:18:02 +09:00
Jean Chalard
675f1dbaf0 [IL98] Refactoring of setSuggestedWords 
Bug: 8636060
Change-Id: Iab53df96f2c23bddc6c70c3560b380fbaef1053c
 2014-01-28 17:18:01 +09:00
Jean Chalard
491a6a6f23 [IL100] Pull up a check 
Bug: 8636060
Change-Id: I344ed59f5f55b412880fc6dc70205eecb1e79961
 2014-01-28 17:18:01 +09:00
Jean Chalard
4761d2fb00 [IL99] Migrate some code to InputLogic. 
Bug: 8636060
Change-Id: Ibf1f9c7bdc3fdd872d6c15447fa555434485cc52
 2014-01-28 17:18:01 +09:00
Jean Chalard
eb00023b9b [IL97] Readability improvement 
Bug: 8636060
Change-Id: I6b15c7fb91cd4cf23a993541c19842b51e328f8f
 2014-01-28 17:17:58 +09:00
Tadashi G. Takaoka
95e5e267ac Merge "Suggestion strip honors RTL layout" 2014-01-28 07:52:25 +00:00
Keisuke Kuroyanagi
25270ec540 Merge "Check probability before adding to the user history dict." 2014-01-28 07:35:31 +00:00
Jean Chalard
36fda2bae3 Merge "[IL96] Inline a method" 2014-01-28 07:31:48 +00:00
Keisuke Kuroyanagi
90ac041c9f Check probability before adding to the user history dict. 
Bug: 12764888
Change-Id: I5da3ef21d9d82b7034e7dc9b7d0fdca0d48a49f4
 2014-01-28 16:31:37 +09:00
Jean Chalard
7593f93565 Merge "[IL95] Inline a method that's always called in sequence" 2014-01-28 07:31:31 +00:00
Tadashi G. Takaoka
bcd30bf3e7 Suggestion strip honors RTL layout 
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
 2014-01-28 15:47:54 +09:00
Jean Chalard
86210c7dc7 [IL96] Inline a method 
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
 2014-01-28 15:47:04 +09:00
Jean Chalard
90916143b6 [IL95] Inline a method that's always called in sequence 
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
 2014-01-28 15:47:01 +09:00
Tadashi G. Takaoka
02b087090e Merge "Fix test fails caused by I8bede13c87" 2014-01-28 05:19:53 +00:00
Yohei Yukawa
0272553578 Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete." 2014-01-28 05:06:07 +00:00
Yohei Yukawa
0e04c24a05 Fix inconsistent behavior with the spacebar on the Emoji pallete. 
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.

With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.

Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
 2014-01-28 13:44:31 +09:00
Jean Chalard
ca1c1ddd4e Merge "[IL94] Remove a function and some reordering" 2014-01-28 03:46:28 +00:00
Jean Chalard
9909d6aa49 Merge "[IL93] Refactor a method inside another" 2014-01-28 03:32:52 +00:00
Jean Chalard
cbf54dea49 Merge "[IL92] Straighten out showSuggestionStripWithTypedWord" 2014-01-28 03:32:17 +00:00
Jean Chalard
5a1f837356 Merge "[IL91] Call reorder" 2014-01-28 03:26:23 +00:00
Tadashi G. Takaoka
9ac6c9064d Fix test fails caused by I8bede13c87 
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
 2014-01-28 11:17:47 +09:00
Tadashi G. Takaoka
c2e2b3949b Merge "Add SubtypeLocaleUtils.isRtlLanguage method" 2014-01-28 01:28:47 +00:00
Baligh Uddin
16a9bb3da8 Import translations. DO NOT MERGE 
Change-Id: I9632cf713ad9e1bba1df5819c4038739229f7ec2
Auto-generated-cl: translation import
 2014-01-27 14:42:02 -08:00
Jean Chalard
5b5e877efe [IL94] Remove a function and some reordering 
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
 2014-01-27 20:38:45 +09:00
Jean Chalard
37e1cc931f [IL93] Refactor a method inside another 
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.

Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
 2014-01-27 20:38:45 +09:00
Jean Chalard
4c6029e530 [IL92] Straighten out showSuggestionStripWithTypedWord 
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
 2014-01-27 20:38:45 +09:00
Jean Chalard
c6367ee64d [IL91] Call reorder 
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
 2014-01-27 20:38:43 +09:00
Jean Chalard
01893b25dd Merge "[IL90] Small refactoring" 2014-01-27 11:18:52 +00:00
Jean Chalard
3f226af439 Merge "[IL89] Inline a function" 2014-01-27 11:18:19 +00:00
Jean Chalard
5b9e54c135 Merge "[IL88] Simple refactoring" 2014-01-27 11:17:54 +00:00
Jean Chalard
8f3e37a631 Merge "[IL87] Remove a call to clearSuggestionStrip" 2014-01-27 11:17:45 +00:00
Jean Chalard
521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard
7aa7e36611 Merge "[IL85] Maybe show punctuations when app completions are null" 2014-01-27 11:17:18 +00:00
Jean Chalard
264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard
7ac542d490 Merge "[IL83] Inline a call" 2014-01-27 11:16:30 +00:00
Jean Chalard
47ff423121 Merge "[IL82] Fix a wrong comment" 2014-01-27 10:11:42 +00:00
Jean Chalard
75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka
c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method 
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
 2014-01-27 19:05:16 +09:00
Jean Chalard
6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard
b084da2ae6 Merge changes I5092942a,I931c553f 
* changes:
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
 2014-01-27 10:00:37 +00:00
Jean Chalard
a3a85e8c2b Merge "[IL78] Move most of onUpdateSelection to InputLogic." 2014-01-27 09:55:08 +00:00
Jean Chalard
d38b0468b0 [IL90] Small refactoring 
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
 2014-01-27 18:42:33 +09:00
Jean Chalard
33ff321d6c [IL89] Inline a function 
We will then refactor the contents of showSuggestionStripWithTypedWord

Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
 2014-01-27 18:42:33 +09:00
Jean Chalard
ca819178a1 [IL88] Simple refactoring 
With this, the value passed to suggestedWords is never null.

Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
 2014-01-27 18:42:33 +09:00
Jean Chalard
d90bdd2187 [IL87] Remove a call to clearSuggestionStrip 
The goal is to remove the function completely.

Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
 2014-01-27 18:42:33 +09:00
Jean Chalard
3b939ed77f [IL86] Simplification and correctness fix. 
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
 2014-01-27 18:42:33 +09:00
Jean Chalard
07eddf3c43 [IL85] Maybe show punctuations when app completions are null 
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.

Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
 2014-01-27 18:42:32 +09:00
Jean Chalard
b2c0388a69 [IL84] Remove a useless call and rename a method 
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
 2014-01-27 18:42:32 +09:00
Jean Chalard
eb190ab32f [IL83] Inline a call 
The coming string of changes is very complicated, so
I'm going to do things really slowly.

Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
 2014-01-27 18:42:32 +09:00
Jean Chalard
17f1528f9e [IL82] Fix a wrong comment 
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
 2014-01-27 18:42:32 +09:00
Jean Chalard
abbd755689 [IL81] Remove a useless test. 
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
 2014-01-27 18:42:32 +09:00
Jean Chalard
f1e5b9b4d1 [IL80] Reverse a test for clarity. 
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
 2014-01-27 18:42:32 +09:00
Jean Chalard
f59487379e [IL79] Some refactoring 
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
 2014-01-27 18:42:29 +09:00
Jean Chalard
10460441db [IL78] Move most of onUpdateSelection to InputLogic. 
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
 2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka
1e4b1300e6 Merge "Refactor SuggestionsStripLayoutHelper class" 2014-01-27 09:36:52 +00:00
Jean Chalard
68d7291a6b Merge "[IL77] Remove refs to Settings from InputLogic" 2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka
148dedbc5d Refactor SuggestionsStripLayoutHelper class 
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
 2014-01-27 18:25:25 +09:00
Jean Chalard
7bee84095e Merge "[IL75] Move the SubtypeSwitcher out of InputLogic." 2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka
829ad708db Merge "Revert "Use ViewCompat support library"" 2014-01-27 09:20:19 +00:00
Jean Chalard
48df380f78 [IL77] Remove refs to Settings from InputLogic 
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
 2014-01-27 18:18:54 +09:00
Jean Chalard
969c06072d [IL75] Move the SubtypeSwitcher out of InputLogic. 
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
 2014-01-27 18:18:27 +09:00
Jean Chalard
c7ef305bbc Try to figure out whether d.quotes open or close. 
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
 2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka
e4692c0050 Revert "Use ViewCompat support library" 
This reverts commit e7ee4fa862.

Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
 2014-01-27 18:14:40 +09:00
Jean Chalard
5cf70a1d44 Merge "[IL74] Remove unused/unwanted arguments to a method." 2014-01-27 08:57:12 +00:00
Yohei Yukawa
0b58617951 Merge "Fix inconsistent behavior with backspace in the Emoji pallete." 2014-01-27 08:11:51 +00:00
Jean Chalard
0fd556ceca [IL74] Remove unused/unwanted arguments to a method. 
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
 2014-01-27 16:48:17 +09:00
Yohei Yukawa
ea8c1c811c Fix inconsistent behavior with backspace in the Emoji pallete. 
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
  the key.

This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
  different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
  key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
  subsequent delete key events when the finger is moved away
  from the key area.

Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
 2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka
f3ca92dd33 Merge "Use ViewCompat support library" 2014-01-27 07:21:41 +00:00
Tadashi G. Takaoka
e7ee4fa862 Use ViewCompat support library 
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
 2014-01-27 16:11:03 +09:00
Ken Wakasa
03283b636c Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939 
some cleanups as well

Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
 2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi
95043145df Merge "Check length of words for personalization dict." 2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi
b7197b705b Check length of words for personalization dict. 
Bug: 12602903

Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
 2014-01-24 16:32:28 -08:00
Ken Wakasa
0acd121083 Fix wrong indents. 
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
 2014-01-24 23:55:33 +09:00
Jean Chalard
b6e128cc05 Merge "[IL69.1] Move a static method to a utility class." 2014-01-24 03:04:12 +00:00
Jean Chalard
1d6e647ac3 [IL69.1] Move a static method to a utility class. 
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
 2014-01-24 11:59:23 +09:00
Jean Chalard
0c72529088 Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer" 2014-01-24 01:55:57 +00:00
Baligh Uddin
6a39811d90 Merge "Import translations. DO NOT MERGE" 2014-01-23 21:02:33 +00:00
Baligh Uddin
5047b4aa84 Import translations. DO NOT MERGE 
Change-Id: Ib5a8be5d9ac508d57648e4e8811805eea4355fc3
Auto-generated-cl: translation import
 2014-01-23 12:25:35 -08:00
Baligh Uddin
2efb58fc98 Import translations. DO NOT MERGE 
Change-Id: I6c8aa53b9be4c3aa5822a820cc8cfdc3cf31c390
Auto-generated-cl: translation import
 2014-01-23 12:22:23 -08:00
Jean Chalard
3aa2043a66 Merge "[IL76] Remove a SuggestionStripView dependency" 2014-01-23 10:06:42 +00:00
Jean Chalard
f16a2a36d2 [IL71.1] Add some javadoc. 
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
 2014-01-23 17:11:47 +09:00
Jean Chalard
a1ed211c4e [IL76] Remove a SuggestionStripView dependency 
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
 2014-01-23 16:25:48 +09:00
Jean Chalard
4173610bc5 [IL66.1] Add a comment 
Followup to IL66

Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
 2014-01-23 16:00:49 +09:00
Jean Chalard
be846fc352 [IL73] Remove all refs to Key and Keyboard in WordComposer 
Please hold my gun while I have this nice cup of tea.
Yes !!

Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
 2014-01-23 15:52:29 +09:00
Jean Chalard
df8310c6e2 Merge "[IL71] Add indices to toCodePointArray." 2014-01-23 06:50:19 +00:00
Jean Chalard
1284e556f4 [IL70] Remove unused arguments 
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
 2014-01-23 15:33:14 +09:00
Jean Chalard
d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord 
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
 2014-01-23 15:32:59 +09:00
Jean Chalard
9da4b49ef6 [IL68] Start refactoring setComposingWord 
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
 2014-01-23 15:15:49 +09:00
Jean Chalard
18638d30c0 [IL71] Add indices to toCodePointArray. 
This is necessary for tests

Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
 2014-01-23 13:11:40 +09:00
Jean Chalard
eb6d41a525 [IL67] Externalize a call to the keyboard switcher 
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
 2014-01-23 13:10:02 +09:00
Jean Chalard
ab80b41a0d [IL66] Remove two accesses to KeyboardSwitcher. 
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
 2014-01-23 13:09:58 +09:00
Jean Chalard
a91dfff5e5 [IL65] Pull up X,Y processing, step 4 
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.

Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
 2014-01-22 14:44:27 +09:00
Jean Chalard
352286a43b [IL64] Pull up X,Y processing, step 3 
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
 2014-01-22 14:44:25 +09:00
Jean Chalard
b8216a4e7e [IL63] Pull up X,Y processing, step 2 
This also fixes the coordinates passed to logOnDelete and
log onSeparator.

Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
 2014-01-22 14:42:52 +09:00
Jean Chalard
2b38b5e8e6 [IL62] Pull up X,Y processing, step 1 
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.

However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.

Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
 2014-01-22 14:41:45 +09:00
Jean Chalard
591580ee8a Merge "[IL61] Remove an internal use of key coordinates" 2014-01-22 05:19:45 +00:00
Tadashi G. Takaoka
6e15af2626 Merge "Fix newline string resource" 2014-01-20 10:45:11 +00:00
Tadashi G. Takaoka
c93cf1c398 Use sorted int[] to represent word separators 
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
 2014-01-20 19:40:02 +09:00
Tadashi G. Takaoka
08ce454aa5 Fix newline string resource 
The newline string resource "\n" doesn't work off-device simulation.

Bug: 12623502
Change-Id: I3ad63d8afe50be174493d43f00f7191062c87cb7
 2014-01-20 19:36:20 +09:00
Tadashi G. Takaoka
5b6ebdbe9e Merge "Refactor logic to retrieve relevant suggestions a bit" 2014-01-20 09:57:43 +00:00
Tadashi G. Takaoka
837cdd738b Add SpacingAndPunctuationsTests 
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
 2014-01-20 18:33:45 +09:00
Tadashi G. Takaoka
3033cc51b8 Refactor logic to retrieve relevant suggestions a bit 
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
 2014-01-20 12:08:25 +09:00
Keisuke Kuroyanagi
3f3b0af5b7 Merge "Fix unit tests by adding @UsedForTesting" 2014-01-19 22:47:03 +00:00
Keisuke Kuroyanagi
fde4c5f128 Fix unit tests by adding @UsedForTesting 
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
 2014-01-19 13:37:23 -08:00
Keisuke Kuroyanagi
b1814c9633 Merge "Make contacts dict and user dict version 4." 2014-01-17 20:05:17 +00:00
Keisuke Kuroyanagi
ed95d79cc4 Make contacts dict and user dict version 4. 
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
 2014-01-17 10:30:16 -08:00
Tadashi G. Takaoka
6a18af634e Refactor RichInputConnection a bit 
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
 2014-01-17 13:14:29 +09:00
Jean Chalard
2334bf6d8c Merge "Fix a bug specific to German capitalization." 2014-01-17 01:49:14 +00:00
Jean Chalard
e4f584de73 Merge "[IL60] Make InputLogicHandler package private" 2014-01-16 18:15:15 +00:00
Jean Chalard
87f87d9ac5 Merge "[IL59] Rename a method" 2014-01-16 18:13:39 +00:00
Jean Chalard
9c9c43c0b7 Merge "[IL58] Simplification" 2014-01-16 17:45:59 +00:00
Keisuke Kuroyanagi
f4bf620502 Merge "Add a dedicated method to control time in native code." 2014-01-16 17:25:29 +00:00
Jean Chalard
ab4543d593 [IL61] Remove an internal use of key coordinates 
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
 2014-01-17 02:10:56 +09:00
Jean Chalard
81255612bc [IL60] Make InputLogicHandler package private 
Yay

Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
 2014-01-17 02:10:56 +09:00
Jean Chalard
17bd129faf [IL59] Rename a method 
Um... this is not async ? Remove that from the name

Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
 2014-01-17 02:10:56 +09:00
Jean Chalard
ac6dfaf80b [IL58] Simplification 
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.

Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
 2014-01-17 02:10:51 +09:00
Jean Chalard
60afa7000f Fix a bug specific to German capitalization. 
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
 2014-01-17 02:06:24 +09:00
Keisuke Kuroyanagi
9e882e3937 Merge "Update personalization dict via dictionary facilitator." 2014-01-16 02:00:21 +00:00
Keisuke Kuroyanagi
12474634c5 Update personalization dict via dictionary facilitator. 
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
 2014-01-15 17:54:17 -08:00
Geoff Mendal
0851ac5726 Merge "Import translations. DO NOT MERGE" 2014-01-16 00:49:15 +00:00
Geoff Mendal
5802fb05a8 Import translations. DO NOT MERGE 
Change-Id: I9d276ae4391f209e2db3a080b3221e5a8aa59938
Auto-generated-cl: translation import
 2014-01-15 16:42:37 -08:00
Keisuke Kuroyanagi
d78a447d10 Add a dedicated method to control time in native code. 
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
 2014-01-15 14:55:57 -08:00
Jean Chalard
2c1a13c56c Merge "[IL57] Don't require a main dict suggestion." 2014-01-15 22:14:27 +00:00
Jean Chalard
118a4fc2b7 Merge "[IL56] Don't erase suggestions when reverting a commit." 2014-01-15 19:21:06 +00:00
Jean Chalard
e22e67e37a [IL57] Don't require a main dict suggestion. 
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.

Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
 2014-01-16 03:22:51 +09:00
Jean Chalard
4752b68f5a [IL56] Don't erase suggestions when reverting a commit. 
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
 2014-01-16 03:22:46 +09:00
Tadashi G. Takaoka
20a8a4a3d9 Fix native method signature 
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
 2014-01-15 18:56:40 +09:00
Tadashi G. Takaoka
01c1a1a2ba Refactor LanguageModelParam class a bit 
This change must be checked in together with I9ecfd1adc1.

Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
 2014-01-15 17:46:32 +09:00
Tadashi G. Takaoka
17a2bcfcce Make final Locale field public 
This change must be checked in together with Id9382498a8.

Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
 2014-01-15 17:11:54 +09:00
Tadashi G. Takaoka
b8a2772b0e Consolidate LanguageModelParam constructors 
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
 2014-01-15 16:17:53 +09:00
Tadashi G. Takaoka
7b9b095090 Move LanguageModelParams class to utility package 
This change must be checked in together with Ic82d951237.

Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
 2014-01-15 16:14:53 +09:00
Tadashi G. Takaoka
2d1e72b774 Merge "Revert "Disable Nepali layouts temporarily per product call"" 2014-01-15 03:50:58 +00:00
Tadashi G. Takaoka
27274601e7 Merge "Revert "Remove Azerbaijani subtype"" 2014-01-15 03:32:55 +00:00
Tadashi G. Takaoka
4d1620f895 Revert "Disable Nepali layouts temporarily per product call" 
This reverts Id58cdf117d.
This also partially reverts I99be3d54d3.

This change must be checked in together with Ied923ed80b.

Bug: 6910787
Change-Id: Icdeee1b93a6b626b43fefc06d3bb3fe40d2e056b
 2014-01-15 12:31:44 +09:00
Tadashi G. Takaoka
7ae9efbb6a Revert "Remove Azerbaijani subtype" 
This reverts I0d2a98dffe.
This also partially reverts I99be3d54d3.

This change must be checked in together with Ibf49c89832.

Bug: 7963448
Change-Id: Idbb3e1ac9f4e067a0051f618946a345632102fb3
 2014-01-15 12:13:25 +09:00
Keisuke Kuroyanagi
68069c55c4 Fix flaky unit test. 
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
 2014-01-14 18:51:29 -08:00
Narayan Kamath
4f8e678bab Revert "Revert "Disable Nepali layouts temporarily per product call"" 
This reverts commit 93fdfc110b.

Change-Id: Ibe7bfa07aa2437701794209c16f017a88cd166b4
 2014-01-14 12:44:11 +00:00
Tadashi G. Takaoka
93fdfc110b Revert "Disable Nepali layouts temporarily per product call" 
This reverts Id58cdf117d.
This also partially reverts I456268b68f.

This change must be checked in together with I4d5c8ffa45.

Bug: 6910787
Change-Id: I59ba69f1b14164edea8eddf3784554a29a97e9b3
 2014-01-14 17:39:24 +09:00
Tadashi G. Takaoka
6584d42b02 Merge "Move phrase gesture related string resources to AOSP" 2014-01-14 08:20:14 +00:00
Tadashi G. Takaoka
7504913807 Move phrase gesture related string resources to AOSP 
This change must be checked in together with Ica8fc5135.

Change-Id: I288d7083391954f1266a9b77ee4ffc0bc9d4229d
 2014-01-14 17:15:41 +09:00
Tadashi G. Takaoka
bf418f7cba Pass time stamp to addToUserHistory method as an argument 
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
 2014-01-14 15:48:08 +09:00
Jean Chalard
62df0a6d53 Merge "Update dictionaries" 2014-01-14 03:44:20 +00:00
Jean Chalard
155cb77231 Update dictionaries 
This change has no effect on TRT results.

>>> dictionaries/en_US_wordlist.combined.gz
Header :
  date : 1381226409 <=> 1389654051
  version : 42 <=> 43
Body :
Added: dialogue 120
Added: dialogues 94

>>> dictionaries/fr_wordlist.combined.gz
Header :
  date : 1381226409 <=> 1389654052
  version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114

>>> dictionaries/it_wordlist.combined.gz
Header :
  date : 1380519383 <=> 1389654052
  version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180

>>> java/res/raw/main_fr.dict
Header :
  date : 1381226409 <=> 1389654052
  version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114

>>> java/res/raw/main_it.dict
Header :
  date : 1380519383 <=> 1389654052
  version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180

Bug: 12487270
Bug: 12344108
Change-Id: I94768e223d05ad2551a5508e9e01222a028665c4
 2014-01-14 10:37:15 +09:00
Geoff Mendal
9fa6663403 Import translations. DO NOT MERGE 
Change-Id: I3233aa7d5f64fbf8818e0065cd1da47d84070fb6
Auto-generated-cl: translation import
 2014-01-13 16:31:58 -08:00
Keisuke Kuroyanagi
5717c63a2b Fix possible NPE in DictionaryFacilitatorForSuggest. 
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
 2014-01-10 21:42:08 +09:00
Jean Chalard
db0adf86a4 Merge "[IL55] Remove a useless argument." 2014-01-10 11:36:01 +00:00
Keisuke Kuroyanagi
eb66f1906d Merge "Check corpus handles during startup for personalization." 2014-01-10 11:34:39 +00:00
Jean Chalard
6c24b91601 [IL55] Remove a useless argument. 
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
 2014-01-10 20:28:50 +09:00
Keisuke Kuroyanagi
eb28bac542 Check corpus handles during startup for personalization. 
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
 2014-01-10 20:28:30 +09:00
Jean Chalard
4be9137609 Merge "[IL54.5] Use the cursor pos estimate, not the last value" 2014-01-10 10:46:27 +00:00
Jean Chalard
a224aafea3 [IL54.5] Use the cursor pos estimate, not the last value 
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.

Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
 2014-01-10 19:08:47 +09:00
Keisuke Kuroyanagi
f96e0f07af Merge "Periodic wipe of the personalization dict." 2014-01-10 09:31:22 +00:00
Keisuke Kuroyanagi
ba07df7fc1 Periodic wipe of the personalization dict. 
Bug: 12216453

Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
 2014-01-10 16:30:59 +09:00
Jean Chalard
ecf46df226 [IL54] Add a mirror method to fix the cursor pos estimate 
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.

Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
 2014-01-10 16:05:02 +09:00
Jean Chalard
6fbe83be7a [IL53] Fix a wrong test. 
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.

When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.

The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.

Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
 2014-01-10 15:21:20 +09:00
Jean Chalard
958e452025 Merge "Fix an NPE." 2014-01-10 05:13:47 +00:00
Jean Chalard
e1de87ae69 Fix an NPE. 
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
 2014-01-10 13:46:37 +09:00
Jean Chalard
84a3047e80 Fix build. 
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
 2014-01-10 12:18:26 +09:00
Tadashi G. Takaoka
ee35e69eae Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion 
This change must be checked in together with Iec437d6df0.

Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
 2014-01-09 19:05:09 +09:00
Tadashi G. Takaoka
494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords 
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
 2014-01-09 18:33:25 +09:00
Tadashi G. Takaoka
d7660c6f56 Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode" 2014-01-09 09:31:32 +00:00
Tadashi G. Takaoka
c912b2228a Merge "Add American typography boolean to SpacingAndPunctuations" 2014-01-09 09:31:24 +00:00
Tadashi G. Takaoka
0a75cf51af Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode 
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
 2014-01-09 18:19:17 +09:00
Tadashi G. Takaoka
860c3b8e8c Add American typography boolean to SpacingAndPunctuations 
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
 2014-01-09 18:17:29 +09:00
Yohei Yukawa
6c326caa4f A style fix 
Just a style fix to follow up the previous commit.

BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
 2014-01-09 15:54:47 +09:00
Keisuke Kuroyanagi
b30f7e4bce Merge "Check whether the word is OOV or not for amanatto update." 2014-01-09 06:24:17 +00:00
Jean Chalard
eab4d25210 Merge "Remove some warnings" 2014-01-09 05:45:10 +00:00
Yohei Yukawa
c1f2986a72 Merge "Trigger haptic feedback at touch down on the EmojiPalettesView" 2014-01-09 05:19:37 +00:00
Jean Chalard
b11339b3ab Remove some warnings 
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
 2014-01-09 14:04:34 +09:00
Jean Chalard
d3e78fc5ce Merge "Fix a bug where changing auto-shift would cancel autorepeat." 2014-01-09 04:53:34 +00:00
Jean Chalard
5cbda70956 Fix a bug where changing auto-shift would cancel autorepeat. 
Bug: 12453966
Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
 2014-01-09 12:57:10 +09:00
Yohei Yukawa
df10aeb1da Trigger haptic feedback at touch down on the EmojiPalettesView 
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down.
This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts.

This patch set also fixes the missing haptic feedback from facemarks such as ":-)".

Bug: 11439600
Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
 2014-01-09 12:27:31 +09:00
Baligh Uddin
941a4540bc Import translations. DO NOT MERGE 
Change-Id: Ia2d0f4528529df463307e1706cd4d7265b3958c1
Auto-generated-cl: translation import
 2014-01-08 13:45:51 -08:00
Keisuke Kuroyanagi
05113c1847 Check whether the word is OOV or not for amanatto update. 
Bug: 11736529
Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
 2014-01-08 21:02:35 +09:00
Keisuke Kuroyanagi
5742a415f3 Merge "Make reloadMainDict() private." 2014-01-08 11:03:02 +00:00
Keisuke Kuroyanagi
9f1fe87580 Make reloadMainDict() private. 
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
 2014-01-08 18:59:43 +09:00
Jean Chalard
b90fa0fb2c Revert "Revert "Separate spacing and punctuation related settings values"" 
This reverts commit 8bc427799a.

Change-Id: I34f509998afdb1a7c120fbfdb9f0a1b188224a4d
 2014-01-08 18:08:01 +09:00
Jean Chalard
e5cdcaff65 Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
 2014-01-08 18:04:44 +09:00
Jean Chalard
1e7f2809d2 Merge "Revert "Separate spacing and punctuation related settings values"" 2014-01-08 09:03:15 +00:00
Jean Chalard
8bc427799a Revert "Separate spacing and punctuation related settings values" 
This is conflicting with later changes. Temporary revert for cherry-pick.

This reverts commit 0b593ce858.

Change-Id: Id53eadb023a950cfcca496c0cfbfe583c7ec7b8c
 2014-01-08 09:00:45 +00:00
Jean Chalard
d4843c25e2 Merge "Revert "Fix a race condition, take 2."" 2014-01-08 09:00:18 +00:00
Jean Chalard
a247264dc6 Revert "Fix a race condition, take 2." 
Conflicts prevent this to be cherry-picked.

This reverts commit dd3d697a6e.

Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
 2014-01-08 08:59:26 +00:00
Jean Chalard
ff7103d356 Merge "Fix a race condition, take 2." 2014-01-08 08:35:24 +00:00
Jean Chalard
0a0a3cdad8 Merge "Revert "Revert "Fix a race condition.""" 2014-01-08 08:35:19 +00:00
Jean Chalard
dd3d697a6e Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
 2014-01-08 17:19:29 +09:00
Jean Chalard
f628629f69 Revert "Revert "Fix a race condition."" 
This reverts commit 3840127244.

Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
 2014-01-08 16:44:43 +09:00
Tadashi G. Takaoka
ad78058a93 Rename InputPointers.addPointer and ResizableIntArray.add 
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
e13cc9d7e5 Fix ResizableIntArrayTests readability 
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
9b351f7594 Merge "Fix InputPointersTests" 2014-01-08 05:29:32 +00:00
Tadashi G. Takaoka
e7dc5302af Fix InputPointersTests 
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.

Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
 2014-01-08 14:14:42 +09:00
Keisuke Kuroyanagi
b3c51630a6 Fix: NPE in LatinIME.loadSettnigs(). 
Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
 2014-01-08 12:43:58 +09:00
Tadashi G. Takaoka
385031557b Merge "Separate spacing and punctuation related settings values" 2014-01-08 02:41:51 +00:00
Keisuke Kuroyanagi
f86b830986 Merge "Prepare using dictionaryFacilitator for amanatto updates." 2014-01-08 02:09:47 +00:00
Tadashi G. Takaoka
0b593ce858 Separate spacing and punctuation related settings values 
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
 2014-01-08 10:02:37 +09:00
Ken Wakasa
8bd658555d Merge "Revert "Fix a race condition."" 2014-01-07 23:57:07 +00:00
Victoria Lease
3840127244 Revert "Fix a race condition." 
This reverts commit 42e83c7f06.

Bug: 12434783
Change-Id: Id01b6d14906430b13e64f5fc4d7fb01572d0a960
 2014-01-07 23:26:54 +00:00
Baligh Uddin
f2f0640800 Merge "Import translations. DO NOT MERGE" 2014-01-07 18:11:29 +00:00
Baligh Uddin
f75017de55 Import translations. DO NOT MERGE 
Change-Id: Ia0ef830a5bb3ed6fee1a5d113b2baec60bb51a97
Auto-generated-cl: translation import
 2014-01-07 07:27:26 -08:00
Keisuke Kuroyanagi
8a2537e0ae Merge "Update personalized dict only when single subtype is used." 2014-01-07 09:19:29 +00:00
Keisuke Kuroyanagi
c09fd175c3 Prepare using dictionaryFacilitator for amanatto updates. 
Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
 2014-01-07 18:11:23 +09:00
Keisuke Kuroyanagi
55713e3695 Update personalized dict only when single subtype is used. 
Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
 2014-01-07 18:10:27 +09:00
Jean Chalard
42e83c7f06 Fix a race condition. 
Don't use absolute cursor positions, this leads to race
conditions.

Bug: 12390573
Change-Id: I6f04f07a46babbc3d51cb94c7eaee21bed242396
 2014-01-07 15:33:04 +09:00
Keisuke Kuroyanagi
6d5f9fd3d1 Merge "Fix possible NPE." 2014-01-06 09:53:15 +00:00
Keisuke Kuroyanagi
8214a8c2cf Fix possible NPE. 
Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
 2014-01-06 17:56:49 +09:00
Tadashi G. Takaoka
74b5291b84 Merge "Remove language switch key from symbols and symbols shift keyboard" 2014-01-06 06:19:27 +00:00
Tadashi G. Takaoka
d561228f95 Remove language switch key from symbols and symbols shift keyboard 
This change also fixes the background color of the left keys of the space key.

Bug: 12407208
Change-Id: Id869605146e9f72835f892c3c7ae14f118177394
 2014-01-06 15:02:50 +09:00
Tadashi G. Takaoka
3f8c6b8c54 Merge "Add description of disabled voice input key option" 2014-01-06 03:25:15 +00:00
Tadashi G. Takaoka
12ba821bfb Add description of disabled voice input key option 
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
 2014-01-06 12:11:55 +09:00
Tadashi G. Takaoka
e91559a119 Merge "Update shortcut IME info before checking availability of it" 2014-01-06 03:07:23 +00:00
Tadashi G. Takaoka
e9584a1612 Merge "Add DictionaryFacilitatorForSuggest constructor for testing" 2014-01-06 02:58:12 +00:00
Tadashi G. Takaoka
b7c531b751 Update shortcut IME info before checking availability of it 
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
 2014-01-06 11:54:46 +09:00
Tadashi G. Takaoka
49b5fadae1 Add DictionaryFacilitatorForSuggest constructor for testing 
This change must be checked in together with I00b6e79d6b.

Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
 2014-01-06 11:00:51 +09:00
Jean Chalard
1e50c681af [IL52] Remove a useless method. 
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.

Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.

Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
 2013-12-27 22:40:19 +09:00
Jean Chalard
8ce921dd6b [IL51] Make private what can be made private 
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
 2013-12-27 21:09:47 +09:00
Jean Chalard
53c320e275 [IL50] Move the InputUpdater out of LatinIME. 
...at last

Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
 2013-12-27 21:09:41 +09:00
Jean Chalard
81e0ca5fd3 [IL49] Move InputLogic-related init code to InputLogic. 
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
 2013-12-27 20:06:39 +09:00
Jean Chalard
4970eda286 Fix a failing test 
How/when did this happen? How was it not noticed?

Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
 2013-12-27 20:04:41 +09:00
Jean Chalard
d05ea8bd82 Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic." 2013-12-27 08:06:48 +00:00
Jean Chalard
af26a44102 Merge "[IL47] Inline getSuggestedWordsGestureLocked" 2013-12-27 08:04:51 +00:00
Jean Chalard
51e79fb4b2 Merge "[IL46] Remove a useless message passing." 2013-12-27 07:56:56 +00:00
Jean Chalard
2fc1cc099f Merge "[IL45] Remove lingering messages" 2013-12-27 07:56:44 +00:00
Jean Chalard
c654fe57b1 [IL48] Move onEndBatchInputAsyncInternal to InputLogic. 
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
 2013-12-27 16:50:08 +09:00
Jean Chalard
4a144b9b4d [IL47] Inline getSuggestedWordsGestureLocked 
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.

Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
 2013-12-27 16:50:08 +09:00
Jean Chalard
71a3e96382 [IL46] Remove a useless message passing. 
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords

The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.

Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
 2013-12-27 16:50:06 +09:00
Jean Chalard
0d21223521 Merge "[IL44] Some factorization" 2013-12-27 06:58:12 +00:00
Jean Chalard
31ff2a4335 [IL45] Remove lingering messages 
Bug: 8636060
And possibly bug: 12085864

Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
 2013-12-27 15:34:30 +09:00
Jean Chalard
69e7a0d24d [IL44] Some factorization 
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.

Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
 2013-12-27 15:34:26 +09:00
Keisuke Kuroyanagi
c197b9ed90 Merge "Make setAdditionalDictionaries private." 2013-12-27 06:22:18 +00:00
Keisuke Kuroyanagi
86da47e8d7 Fix possible NPE in FileUtils. 
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
 2013-12-27 14:58:38 +09:00
Keisuke Kuroyanagi
abc3d0eb56 Make setAdditionalDictionaries private. 
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
 2013-12-27 14:49:32 +09:00
Jean Chalard
6bca9ac43d Fix a bug where predictions would not pop upon manual pick 
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
 2013-12-26 23:19:29 +09:00
Jean Chalard
33b2aaafc2 Merge "Fix a code path that looks ridiculous" 2013-12-26 13:39:21 +00:00
Jean Chalard
f294ed3308 Fix a code path that looks ridiculous 
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
 2013-12-26 22:28:16 +09:00
Jean Chalard
f441047fad [IL43] Small cleanup 
All calls are already passing this

Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
 2013-12-26 22:12:24 +09:00
Jean Chalard
c28f02880c [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync 
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
 2013-12-26 22:12:22 +09:00
Jean Chalard
70433efc41 [IL41] Remove a useless call and trampoline. 
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.

Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
 2013-12-26 21:58:41 +09:00
Keisuke Kuroyanagi
be147f1fdc Remove DictionaryFacilitatorForSuggest.getMainDictionary(). 
Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
 2013-12-26 20:48:19 +09:00
Keisuke Kuroyanagi
a374482719 Extract dict operations from Suggest to a new class. 
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
 2013-12-26 20:48:19 +09:00
Jean Chalard
5c45ff1214 [IL39] Change a test. 
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.

Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
 2013-12-26 18:44:17 +09:00
Jean Chalard
98140faac3 [IL38] Fix a wrong double call 
This only gives bad results if a gesture results in only one suggestion.

Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
 2013-12-26 18:43:47 +09:00
Keisuke Kuroyanagi
65e3ae6f15 Merge "Remove useless method call for spell checker." 2013-12-26 06:42:51 +00:00
Keisuke Kuroyanagi
7987afbea4 Remove useless method call for spell checker. 
Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
 2013-12-26 14:51:05 +09:00
Tadashi G. Takaoka
3fbcf48591 Merge "Add BatchInputArbiter" 2013-12-26 05:50:07 +00:00
Tadashi G. Takaoka
4a4b6d42a7 Add BatchInputArbiter 
Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.

This change must be checked in together with Ia7db8f4fb7.

Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
 2013-12-26 14:09:57 +09:00
Jean Chalard
30a72da42c [IL37] Small simplification 
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
 2013-12-26 13:51:09 +09:00
Jean Chalard
c08119e5c1 [IL36] Inline setAutoCorrection 
There are far too many one-use methods.

Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
 2013-12-26 13:18:36 +09:00
Jean Chalard
52a2682b99 [IL35] Preparative cleanup 
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
 2013-12-25 22:25:49 +09:00
Jean Chalard
0154609a2e Merge "[IL34] Introduce InputLogicHandler" 2013-12-25 13:21:54 +00:00
Keisuke Kuroyanagi
5c4bd20331 Remove "Boost personalization dictionary" from settings. 
Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
 2013-12-25 19:02:49 +09:00
Keisuke Kuroyanagi
bb39518bd7 Use SettingsValues instead of Settings in Suggest. 
Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
 2013-12-25 18:53:04 +09:00
Tadashi G. Takaoka
d99d225f10 Merge "Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints" 2013-12-25 06:58:08 +00:00
Keisuke Kuroyanagi
eea7122e5b Move dict operations to Suggest. 
Bug: 8187060

Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
 2013-12-25 15:26:50 +09:00
Tadashi G. Takaoka
c3fe1425a5 Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints 
This change must be checked in together with Ibed5330614.

Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace
 2013-12-25 15:19:00 +09:00
Jean Chalard
621dcbc31c [IL34] Introduce InputLogicHandler 
Bug: 8636060
Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f
 2013-12-25 14:20:19 +09:00
Keisuke Kuroyanagi
605caf1b5f Fix NPE in SettingsValues. 
Change-Id: I96fc381d2b45881aeb342d33207cd7fe82f5077c
 2013-12-25 14:00:16 +09:00
Tadashi G. Takaoka
a801c8fd9b Merge "Rename gesture related classes" 2013-12-25 04:04:05 +00:00
Tadashi G. Takaoka
e2a6253cb5 Rename gesture related classes 
Change-Id: I5cb03576bb7221f1864e157857d872880a0a58f8
 2013-12-25 11:52:54 +09:00
Keisuke Kuroyanagi
f1457e7a22 Remove personalized dicts when the option is turned off. 
Bug: 11757851

Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f
 2013-12-25 11:44:16 +09:00
Tadashi G. Takaoka
afca1ddd23 Comprehensive memory deallocation 
Change-Id: I4673543c96eb342c3c977e00d44772a0d719a23e
 2013-12-24 18:26:55 +09:00
Tadashi G. Takaoka
cf915ddc87 Rename classes related to AbstractDrawingPreview 
Change-Id: Ife2e2c08b2b6fbf9ec33cf259f276878816b291c
 2013-12-24 18:17:00 +09:00
Tadashi G. Takaoka
e82200787c Separate GestureStrokePreviewParams to top level class 
Change-Id: I4c6ac12dac9636760128625bb5b7138b7d56f3d1
 2013-12-24 17:27:15 +09:00
Tadashi G. Takaoka
dc2ce72555 Merge "Make GestureStrokeParams as a top level class" 2013-12-24 06:40:29 +00:00
Tadashi G. Takaoka
c845d4c664 Make GestureStrokeParams as a top level class 
Change-Id: I540a2d3a6c6ce6ecdcccecd38df6b3c23fcf8d95
 2013-12-24 15:29:10 +09:00
Jean Chalard
036930e80d Merge "[IL33] Opportunistically remove some KeyboardSwitcher" 2013-12-24 06:28:54 +00:00
Jean Chalard
8476c2e788 [IL33] Opportunistically remove some KeyboardSwitcher 
Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
 2013-12-24 15:11:35 +09:00
Tadashi G. Takaoka
904866c701 Clean up batch input related code a bit 
Change-Id: I3b6a95fdb82bd15e2b636b1374a96d8987d5d8cf
 2013-12-24 14:24:27 +09:00
Tadashi G. Takaoka
aa7a68a3e0 Remove duplicate code 
Change-Id: Ia33ea2dc4bb063ec5bf282c656ccc1f11ac967fe
 2013-12-24 12:39:16 +09:00
Jean Chalard
07f7536b04 [IL32] Remove a useless variable 
Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c
 2013-12-20 21:34:07 +09:00
Jean Chalard
1587be6977 [IL31] Move *BatchInput to InputLogic 
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
 2013-12-20 21:24:27 +09:00
Jean Chalard
059f4c2f39 [IL30] Minor refactoring 
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
 2013-12-20 20:47:44 +09:00
Jean Chalard
0547b33130 [IL29] Move retryResetCaches and tryFixLyingCursorPosition 
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
 2013-12-20 20:47:29 +09:00
Jean Chalard
81e8d16031 [IL28] Remove useless code 
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.

Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
 2013-12-20 19:48:05 +09:00
Jean Chalard
55ce2cc2d5 [IL27] Some refactoring 
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
 2013-12-20 19:24:38 +09:00
Jean Chalard
221df9e59a [IL26] Move restartSuggestionsOnWordTouchedByCursor 
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
 2013-12-20 19:09:36 +09:00
Jean Chalard
ec4b6e7bb3 [IL25] Inline handleClose 
Only ever used here.

Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
 2013-12-20 18:44:13 +09:00
Jean Chalard
aa161eb371 [IL24] Move mDisplayOrientation to SettingsValues. 
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
 2013-12-20 18:44:09 +09:00
Jean Chalard
a22a63f3b1 Merge "Fix an NPE" 2013-12-20 09:14:56 +00:00
Jean Chalard
92392b21f2 Fix an NPE 
Change-Id: I6307c1545d9d48cdea66d08f8efc1b7fbb08ee42
 2013-12-20 18:13:23 +09:00
Tadashi G. Takaoka
f405c58c09 Merge "Use config_screen_metrics resource in BogusMoveEventDetector" 2013-12-20 09:03:25 +00:00
Tadashi G. Takaoka
9c4de1e5f7 Use config_screen_metrics resource in BogusMoveEventDetector 
Change-Id: I6b957b43c6dd7ce4f639e46d248179662c1ee669
 2013-12-20 17:35:19 +09:00
Jean Chalard
1252333efd Merge "[IL23] Resolve a long-standing TODO." 2013-12-20 08:29:29 +00:00
Tadashi G. Takaoka
0c8ea69cad Merge "Separate logic of enabling gesture typing" 2013-12-20 08:03:18 +00:00
Jean Chalard
84e78cb769 Merge "[IL22] Move onTextInput to InputLogic." 2013-12-20 08:02:36 +00:00
Jean Chalard
689cff2e3b Merge "[IL21] Move the workaround utils to a better place." 2013-12-20 08:02:07 +00:00
Jean Chalard
6cf843cba6 [IL23] Resolve a long-standing TODO. 
Bug: 8636060
Change-Id: I3a840c30cc4489debf9118beeec448488503bc1c
 2013-12-20 16:50:14 +09:00
Jean Chalard
11730aa224 [IL22] Move onTextInput to InputLogic. 
Also pull the TLD specific processing

Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
 2013-12-20 16:50:14 +09:00
Jean Chalard
1404c1af85 [IL21] Move the workaround utils to a better place. 
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
 2013-12-20 16:48:54 +09:00
Tadashi G. Takaoka
a00838b6e8 Separate logic of enabling gesture typing 
Change-Id: I91fc566f24a38a55d2352201d5d581d3fa02a428
 2013-12-20 16:37:17 +09:00
Tadashi G. Takaoka
db6d9b0ab4 Merge "Separate BogusMoveEventDetector class" 2013-12-20 07:36:07 +00:00
Tadashi G. Takaoka
c986d16e8a Separate BogusMoveEventDetector class 
Change-Id: I24f0ff385f338ff313ef32514f2930f120183be7
 2013-12-20 16:17:41 +09:00
Tadashi G. Takaoka
9033fb1f64 Merge "Separate TypingTimeRecorder class" 2013-12-20 07:16:34 +00:00
Tadashi G. Takaoka
5045103d61 Separate TypingTimeRecorder class 
Change-Id: Ic56d3e3a1be935854dcace36d8a05a9d2619dab9
 2013-12-20 16:14:26 +09:00
Jean Chalard
529cdf0a0c Merge "[IL20] Remove some useless processing." 2013-12-20 07:14:09 +00:00
Jean Chalard
95d869fed4 Merge "[IL19] Resolve a TODO." 2013-12-20 07:11:24 +00:00
Jean Chalard
8a390023e1 [IL20] Remove some useless processing. 
If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.

Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
 2013-12-20 16:02:07 +09:00
Jean Chalard
4487a30e0d [IL19] Resolve a TODO. 
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
 2013-12-20 16:02:03 +09:00
Jean Chalard
f7d493979a Merge "[IL18] Move and rename updateSuggestionStrip" 2013-12-20 06:54:33 +00:00
Jean Chalard
2a6de7903c [IL18] Move and rename updateSuggestionStrip 
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
 2013-12-20 15:46:34 +09:00
Tadashi G. Takaoka
921a32f0a9 Remove unnecessary default KeyDetector from PointerTracker 
Change-Id: Ib0fbb40a7040202d2a4b4ab49319d9e247a2a6ce
 2013-12-20 15:34:54 +09:00
Tadashi G. Takaoka
dbb88e47c8 Merge "Remove unused default object of GestureStrokePreviewParams" 2013-12-20 06:33:36 +00:00
Tadashi G. Takaoka
081989ca30 Remove unused default object of GestureStrokePreviewParams 
This change also fixes build broken by Id615556766.

Change-Id: I16605cc3b65e3e9ab2d5a498825c31d9b4046b73
 2013-12-20 15:25:24 +09:00
Jean Chalard
1c0374da49 [IL17] Move commitChosenWord to InputLogic. 
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.

Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
 2013-12-20 15:13:48 +09:00
Jean Chalard
a905fcec00 [IL16] Improve getTextWithSuggestionSpan 
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.

Not directly related, but helpful with:
Bug: 8636060

Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
 2013-12-20 15:13:48 +09:00
Tadashi G. Takaoka
6e97efef78 Fix rugged gesture trail 
Bug: 12222472
Change-Id: Id615556766718a8bd4848f7026833fbcea540c39
 2013-12-20 14:40:18 +09:00
Tadashi G. Takaoka
ce9c7d7511 Merge "Remove PointerTracker reference from accessibility package" 2013-12-20 03:33:24 +00:00
Tadashi G. Takaoka
6a23b9e3d5 Remove PointerTracker reference from accessibility package 
Change-Id: I1a88d9fc4db437070778ea1256aae17c32428729
 2013-12-20 12:29:25 +09:00
Jean Chalard
30e3b66fa3 Merge "[IL15] Some small refactoring" 2013-12-20 02:42:09 +00:00
Jean Chalard
00a2f21eeb Merge "[IL14] Move getCurrent*Caps* to InputLogic" 2013-12-20 02:40:53 +00:00
Jean Chalard
5c9e677c2a [IL15] Some small refactoring 
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
 2013-12-20 11:24:45 +09:00
Jean Chalard
48ba1f25ff [IL14] Move getCurrent*Caps* to InputLogic 
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
 2013-12-20 11:24:42 +09:00
Baligh Uddin
c34b4c0744 Merge "Import translations. DO NOT MERGE" 2013-12-19 22:42:51 +00:00
Baligh Uddin
4f878a71b9 Import translations. DO NOT MERGE 
Change-Id: Iec55106743e61ca92f934f1280b0faf0bb2f4b1b
Auto-generated-cl: translation import
 2013-12-19 14:18:14 -08:00
Jean Chalard
cdd8a1a69d [IL13] Inline restartSuggestionsOnWordBeforeCursor 
It's only ever used in one place and makes unhealthy assumptions
about what the caller is doing. It's better inlined.

Bug: 8636060
Change-Id: I265d5d96894e929d09247ee2e3dc2e81efc2a276
 2013-12-19 20:31:52 +09:00
Jean Chalard
bbe40835a9 [IL12] move restartSuggestions* to InputLogic 
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
 2013-12-19 20:30:41 +09:00
Jean Chalard
10755af97b [IL11] Cleanup 
Make some methods private and add comments.

Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
 2013-12-19 20:13:14 +09:00
Jean Chalard
060e292628 [IL10] Move revertCommit to InputLogic 
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
 2013-12-19 19:30:26 +09:00
Jean Chalard
69a57bcdcd [IL9] Move commitCurrentAutoCorrection to InputLogic 
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
 2013-12-19 19:30:20 +09:00
Jean Chalard
035e3885ac [IL8] Move handleNonSeparator to InputLogic 
Also move getActualCapsMode and getNthPreviousWordForSuggestion

Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
 2013-12-19 18:32:51 +09:00
Jean Chalard
d85e49bf8c [IL7] Move performRecapitalization to InputLogic 
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
 2013-12-19 18:20:41 +09:00
Jean Chalard
40b42b7d84 [IL6] Move handleSeparator to InputLogic 
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod

Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
 2013-12-19 17:39:01 +09:00
Jean Chalard
c8dfaab783 [IL5] Some renaming 
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
 2013-12-19 17:38:55 +09:00
Jean Chalard
37d3f1bd02 [IL4] Move handleNonSpecialCharacter to InputLogic. 
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
 2013-12-19 16:46:57 +09:00
Jean Chalard
0e82fa273d [IL3] Move handleBackspace to InputLogic. 
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline

Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
 2013-12-19 16:46:54 +09:00
Jean Chalard
cddf4f9d78 [IL2] Move onCodeInput to InputLogic. 
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
 2013-12-19 16:24:45 +09:00
Jean Chalard
7bd2a75ca1 Start separating the input logic from LatinIME. 
Create an InputEngine class and start moving the relevant
variables to it.

Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
 2013-12-19 14:48:43 +09:00
Jean Chalard
dfbe2bfe08 Add some info to test crashes to help diagnose flakiness 
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
 2013-12-18 18:10:56 +09:00
Baligh Uddin
5e88407c18 Merge "Import translations. DO NOT MERGE" 2013-12-17 17:46:03 +00:00
Ken Wakasa
da173b6ee3 Merge "Move "Personalized suggestions" option." 2013-12-17 13:52:00 +00:00
Keisuke Kuroyanagi
0a8e307a5f Move "Personalized suggestions" option. 
Bug: 11757851
Change-Id: I07411d53b75be767426571edca371f991efc97cb
 2013-12-17 21:01:06 +09:00
Keisuke Kuroyanagi
1f5a3faf76 Merge "Enable Personalized dictionaries based on the setting." 2013-12-17 10:40:29 +00:00
Keisuke Kuroyanagi
8732f9c5f9 Enable Personalized dictionaries based on the setting. 
Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7
 2013-12-17 19:36:19 +09:00
Jean Chalard
4196360912 Run GC when needed, instead of too late. 
Bug: 12164855
Change-Id: Ie4d8be9f2652b01470bcc06911e2191e09fb3149
 2013-12-17 18:08:48 +09:00
Jean Chalard
97a553ae69 Fix wrong dereference reading code. 
Bug: 12164855
Change-Id: I26faf27edfa303510197bccaa3521578f649741d
 2013-12-17 16:42:22 +09:00
Keisuke Kuroyanagi
b54c747d7c Merge "Move DictUpdater to the tests directory." 2013-12-17 05:33:16 +00:00
Keisuke Kuroyanagi
4fdcefe504 Move DictUpdater to the tests directory. 
Bug: 11245133
Change-Id: I0907a091ac3ae960eaf3b27da78dbb48a24b2ea1
 2013-12-17 14:31:25 +09:00
Tadashi G. Takaoka
19dd753c0c Cancel more suggestions panel when touching keyboard 
Bug: 10010128
Change-Id: I2ff0870c69f407d943caf8b9cec90b7ed89de5f1
 2013-12-17 12:59:37 +09:00
Tadashi G. Takaoka
dd4937848a Fix typo in varibale name 
Change-Id: I7ea6c59b7c980e93c88a6cf0fef97592d411c3ba
 2013-12-17 12:15:02 +09:00
Tadashi G. Takaoka
fcacde3dad Revise Armenian punctuations more keys 
Bug: 12096943
Change-Id: Ib8559f030fbc27ec7f7e9a9fb36aad72cca29e9f
 2013-12-17 11:12:33 +09:00
Tadashi G. Takaoka
031317ae61 Merge "Add Armenian "ligature ech yiwn" hint label" 2013-12-17 02:04:57 +00:00
Tadashi G. Takaoka
3aeb6a9d0d Merge "Refactor touch event forwarding in InputView" 2013-12-17 02:04:40 +00:00
Tadashi G. Takaoka
3bb64ff3b2 Add Armenian "ligature ech yiwn" hint label 
Bug: 12100704
Change-Id: I9debef1662c29ab88f27b2fdd61d5f703c3a1c78
 2013-12-17 10:51:02 +09:00
Baligh Uddin
2ea0d56fb5 Import translations. DO NOT MERGE 
Change-Id: Iad038e310497a74f167e7f6cfda1f3bee6cd8f09
Auto-generated-cl: translation import
 2013-12-16 17:37:20 -08:00
Tadashi G. Takaoka
27fab2cc2a Refactor touch event forwarding in InputView 
Bug: 10010128
Change-Id: I82aa4ce847e66cb1241678f39b47b9e27a0f555a
 2013-12-17 08:49:50 +09:00
Jean Chalard
0c7b05fc50 Merge "Fix a bug with languages without spaces and predictions" 2013-12-16 14:17:51 +00:00
Jean Chalard
7cd7cf73f4 Fix a bug with languages without spaces and predictions 
This is simpler and more correct.

Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
 2013-12-16 23:16:02 +09:00
Keisuke Kuroyanagi
e17cc8270f Merge "Increment version number of ver4 format to 401." 2013-12-16 14:13:42 +00:00
Keisuke Kuroyanagi
b5215d456a Increment version number of ver4 format to 401. 
Bug: 11073222
Change-Id: I3878aef02040b1ef73165645fc70ede586289c51
 2013-12-16 23:02:54 +09:00
Keisuke Kuroyanagi
214a3b741f Merge "Fix: incompatible PtNode array size reading." 2013-12-16 13:57:55 +00:00
Keisuke Kuroyanagi
56e7e38d37 Fix: incompatible PtNode array size reading. 
Bug: 11073222
Change-Id: I681be725b5c6dcc10aa536b00327698a7df75277
 2013-12-16 22:42:01 +09:00
Jean Chalard
dc06ee85ef A simplification. 
This does the same thing, but simpler and faster.
Was noticed while investigating bug#12164555

Change-Id: If9926e4da8a53a65489da55197ac87122c44fe7c
 2013-12-16 21:38:31 +09:00
Keisuke Kuroyanagi
769eb083ef Merge "Add option to enable personalization dictionaries." 2013-12-16 10:33:40 +00:00
Keisuke Kuroyanagi
d4bb7df412 Add option to enable personalization dictionaries. 
Bug: 11757851

Change-Id: I4872c10793d4fd55c0bd9e5bc4650925de6d2c1d
 2013-12-16 19:17:31 +09:00
Tadashi G. Takaoka
f3b92fb952 Merge "Fix IllegalStateException of ViewGroup" 2013-12-16 08:36:45 +00:00
Tadashi G. Takaoka
7f8345d59a Fix IllegalStateException of ViewGroup 
Bug: 10629042
Change-Id: I111d092fb2f7dca47328127a155c981aa1c55906
 2013-12-16 17:06:23 +09:00
Keisuke Kuroyanagi
b6a19229ba Merge "Make required binary dictionary version use FormatSpec.*" 2013-12-16 07:56:58 +00:00
Keisuke Kuroyanagi
c837767819 Make required binary dictionary version use FormatSpec.* 
Change-Id: Ifb17d6551bc5071553e32a5640dd166c39374461
 2013-12-16 16:50:28 +09:00
Jean Chalard
5590e9d040 Merge "Make the bad header a checked exception and fix dicttool test" 2013-12-16 07:18:44 +00:00
Jean Chalard
3df617323e Make the bad header a checked exception and fix dicttool test 
Change-Id: If780a2a1cb722aee83d910904c0a6315add9552d
 2013-12-16 15:40:45 +09:00
Tadashi G. Takaoka
1b5b0a3ebc Cancel long press shift key while chording input 
Bug: 12123508
Change-Id: I693caad1f8ee47ebeb14419603d1fc29f6263a75
 2013-12-16 15:30:41 +09:00
Tadashi G. Takaoka
3f6c983adc Merge "Don't use fullscreen mode on large phone" 2013-12-16 05:56:09 +00:00
Jean Chalard
b868375763 Fix failing tests 
- Version 3 is not supported
- Now passing the right string to open v4 dicts. Fix the tests for this.

Change-Id: I7829330c3568a715b96396ba4e4e69c6e17775ab
 2013-12-16 14:32:19 +09:00
Tadashi G. Takaoka
d75d77200f Don't use fullscreen mode on large phone 
Bug: 11920652
Change-Id: Icc26c20c881bc586c800c31c90a45281dc408d2a
 2013-12-16 13:09:13 +09:00
Ken Wakasa
2c25c7c9e1 Fix locale names in the make-keyboard-text tool 
Change-Id: I33c3fafcff124bb94e395cc604ce264daad55d2d
 2013-12-14 18:50:57 +09:00
Jean Chalard
330d2720bb Instead of ignoring PARAGRAPH spans, fix them. 
I don't know what or when this flag is set, but it's only bad
news. Luckily, we can just remove it.

Bug: 12119393
Change-Id: I2952138c8ce517535b91e0fe25d2cf4960e02862
 2013-12-13 23:42:31 +09:00
Jean Chalard
7a904514fb Merge "Don't use the previous word after a non-whitespace separator" 2013-12-13 11:53:30 +00:00
Jean Chalard
0b51fac907 Merge "Only update shift state if left in auto mode." 2013-12-13 11:52:13 +00:00
Jean Chalard
fae1ba767c Don't use the previous word after a non-whitespace separator 
Bug: 12101276
Change-Id: Icf36d55ec171194e5561b946021bcf648782ddd4
 2013-12-13 20:51:28 +09:00
Jean Chalard
28bd6e2297 Only update shift state if left in auto mode. 
Bug: 12100417
Change-Id: I7bc2b19332e142a257b0399f2e5d128caf01fc7c
 2013-12-13 20:47:25 +09:00
Jean Chalard
f3d281b775 Merge "Fix a bug where recapitalize prevents going to more syms" 2013-12-13 10:38:18 +00:00
Jean Chalard
5d98e1d82e Fix a bug where recapitalize prevents going to more syms 
Bug: 11004973
Change-Id: I97ee9df6e8464e2149beb41c688cbfbd83ac3d8c
 2013-12-13 19:21:49 +09:00
Jean Chalard
f08b1ea41a Merge "Remove references to the v3 dictionary." 2013-12-13 10:08:12 +00:00
Tadashi G. Takaoka
bf7503ae6b Merge "Fix key top letter color in shifted layout" 2013-12-13 09:55:19 +00:00
Jean Chalard
1dc7eca114 Remove references to the v3 dictionary. 
Change-Id: I811c8c923ad67a6d9bfdd11bdef8991eb7135c27
 2013-12-13 18:53:41 +09:00
Keisuke Kuroyanagi
3e81d9c39f Merge "Remove code for forgetting curve in Java side." 2013-12-13 09:44:16 +00:00
Keisuke Kuroyanagi
cc8c544ee2 Remove code for forgetting curve in Java side. 
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
 2013-12-13 18:40:58 +09:00
Tadashi G. Takaoka
815a339201 Fix key top letter color in shifted layout 
There is a chance to have an empty hint label even though
keyLabelFlags has hasShiftedLetterHint flag.

Change-Id: I63b9fcc42a40391d5902814cae4c75abb61e4b94
 2013-12-13 18:34:30 +09:00
Jean Chalard
a245d15da5 Have dicttool use the native library to generate v4 dicts. 
Yay !

Change-Id: Iea8ced9e81031b9ab7eff05ad9ef7215be248de9
 2013-12-13 18:18:20 +09:00
Jean Chalard
af0c222a5e Merge "Remove flags from Java side." 2013-12-13 09:17:10 +00:00
Jean Chalard
7b55cd3e2b Remove flags from Java side. 
This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
  The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
  regardless of this flag.

Bug: 11281748
Change-Id: If567e52e245a9342adc7f3104a0f7d8d782df8c1
 2013-12-13 18:15:05 +09:00
Tadashi G. Takaoka
a5b196e939 [FIX] Separate form factor dependent config resources 
This is a cherry-pick of I668b55a514.

Change-Id: I00e9a74812d622c12af0337ba50e1b2f1d675cf1
 2013-12-13 18:01:01 +09:00
Ken Wakasa
2fa3693c26 Reset to 9bd6dac470 
The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
 2013-12-13 17:13:32 +09:00
Keisuke Kuroyanagi
9642286c01 Make ExpandableBinaryDictionary usable for offdevice tests. 
Bug: 11956652
Change-Id: If5a503ef161781818f2efceba542be5a61be6bd1
 2013-12-13 14:48:43 +09:00
Keisuke Kuroyanagi
9bd6dac470 Add a constructor for testing to non-main dictionaries. 
The new constructor is used for creating dictionary instance
that uses a given file.

Bug: 11956652
Change-Id: Ifbf420a1a768eb95a5c3a58eeb1be5936b306d35
 2013-12-12 20:14:06 +09:00
Keisuke Kuroyanagi
d06de553b2 Add waitAllTasksForTests for testing. 
Bug: 10667710
Change-Id: I7a189e32286a6005393fbde8da736541ca9226a8
 2013-12-12 17:08:51 +09:00
Keisuke Kuroyanagi
9ff51527a3 Quit passing header file path to native. 
Bug: 12089197
Change-Id: Ia898f8d2836c0c131a1834dc0a396d9121ecb972
 2013-12-12 16:48:34 +09:00
Jean Chalard
9fa221a7bd Remove dependency from StringUtils to Json 
Change-Id: I2a89497fb9ec12a37ba09f4598742e88f6700576
 2013-12-12 13:55:56 +09:00
Tadashi G. Takaoka
79cc690f55 Fix Filipino keyboard 
Bug: 12102802
Change-Id: Id55ba5ebd8ddaf83ed246315d81b25ad4c9b6294
 2013-12-12 11:12:23 +09:00