eb00023b9b
[IL97] Readability improvement
...
Bug: 8636060
Change-Id: I6b15c7fb91cd4cf23a993541c19842b51e328f8f
2014-01-28 17:17:58 +09:00
95e5e267ac
Merge "Suggestion strip honors RTL layout"
2014-01-28 07:52:25 +00:00
bcd30bf3e7
Suggestion strip honors RTL layout
...
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
2014-01-28 15:47:54 +09:00
86210c7dc7
[IL96] Inline a method
...
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
2014-01-28 15:47:04 +09:00
90916143b6
[IL95] Inline a method that's always called in sequence
...
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
2014-01-28 15:47:01 +09:00
5b5e877efe
[IL94] Remove a function and some reordering
...
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
2014-01-27 20:38:45 +09:00
37e1cc931f
[IL93] Refactor a method inside another
...
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.
Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
2014-01-27 20:38:45 +09:00
4c6029e530
[IL92] Straighten out showSuggestionStripWithTypedWord
...
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
2014-01-27 20:38:45 +09:00
c6367ee64d
[IL91] Call reorder
...
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
2014-01-27 20:38:43 +09:00
d38b0468b0
[IL90] Small refactoring
...
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
33ff321d6c
[IL89] Inline a function
...
We will then refactor the contents of showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
ca819178a1
[IL88] Simple refactoring
...
With this, the value passed to suggestedWords is never null.
Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
d90bdd2187
[IL87] Remove a call to clearSuggestionStrip
...
The goal is to remove the function completely.
Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
07eddf3c43
[IL85] Maybe show punctuations when app completions are null
...
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.
Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
b2c0388a69
[IL84] Remove a useless call and rename a method
...
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
eb190ab32f
[IL83] Inline a call
...
The coming string of changes is very complicated, so
I'm going to do things really slowly.
Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
17f1528f9e
[IL82] Fix a wrong comment
...
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
f59487379e
[IL79] Some refactoring
...
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
10460441db
[IL78] Move most of onUpdateSelection to InputLogic.
...
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
68d7291a6b
Merge "[IL77] Remove refs to Settings from InputLogic"
2014-01-27 09:29:50 +00:00
7bee84095e
Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
2014-01-27 09:24:10 +00:00
48df380f78
[IL77] Remove refs to Settings from InputLogic
...
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
969c06072d
[IL75] Move the SubtypeSwitcher out of InputLogic.
...
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
5cf70a1d44
Merge "[IL74] Remove unused/unwanted arguments to a method."
2014-01-27 08:57:12 +00:00
0fd556ceca
[IL74] Remove unused/unwanted arguments to a method.
...
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
03283b636c
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
some cleanups as well
Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
1d6e647ac3
[IL69.1] Move a static method to a utility class.
...
This is a followup to IL69.
Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
1284e556f4
[IL70] Remove unused arguments
...
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
d1f463eacf
[IL69] Oust Keyboard from WordComposer#setComposingWord
...
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
eb6d41a525
[IL67] Externalize a call to the keyboard switcher
...
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
2014-01-23 13:10:02 +09:00
ab80b41a0d
[IL66] Remove two accesses to KeyboardSwitcher.
...
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
2014-01-23 13:09:58 +09:00
a91dfff5e5
[IL65] Pull up X,Y processing, step 4
...
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.
Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
2014-01-22 14:44:27 +09:00
352286a43b
[IL64] Pull up X,Y processing, step 3
...
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
2014-01-22 14:44:25 +09:00
3033cc51b8
Refactor logic to retrieve relevant suggestions a bit
...
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-20 12:08:25 +09:00
17bd129faf
[IL59] Rename a method
...
Um... this is not async ? Remove that from the name
Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
2014-01-17 02:10:56 +09:00
ac6dfaf80b
[IL58] Simplification
...
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.
Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
2014-01-17 02:10:51 +09:00
4752b68f5a
[IL56] Don't erase suggestions when reverting a commit.
...
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
2014-01-16 03:22:46 +09:00
6c24b91601
[IL55] Remove a useless argument.
...
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
2014-01-10 20:28:50 +09:00
a224aafea3
[IL54.5] Use the cursor pos estimate, not the last value
...
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.
Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
2014-01-10 19:08:47 +09:00
494e2d6c17
Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
...
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
9f1fe87580
Make reloadMainDict() private.
...
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
2014-01-08 18:59:43 +09:00
b3c51630a6
Fix: NPE in LatinIME.loadSettnigs().
...
Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
2014-01-08 12:43:58 +09:00
385031557b
Merge "Separate spacing and punctuation related settings values"
2014-01-08 02:41:51 +00:00
0b593ce858
Separate spacing and punctuation related settings values
...
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
2014-01-08 10:02:37 +09:00
c09fd175c3
Prepare using dictionaryFacilitator for amanatto updates.
...
Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
2014-01-07 18:11:23 +09:00
55713e3695
Update personalized dict only when single subtype is used.
...
Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
2014-01-07 18:10:27 +09:00
1e50c681af
[IL52] Remove a useless method.
...
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.
Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.
Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
2013-12-27 22:40:19 +09:00
53c320e275
[IL50] Move the InputUpdater out of LatinIME.
...
...at last
Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
2013-12-27 21:09:41 +09:00
81e0ca5fd3
[IL49] Move InputLogic-related init code to InputLogic.
...
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
2013-12-27 20:06:39 +09:00
d05ea8bd82
Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic."
2013-12-27 08:06:48 +00:00
af26a44102
Merge "[IL47] Inline getSuggestedWordsGestureLocked"
2013-12-27 08:04:51 +00:00
51e79fb4b2
Merge "[IL46] Remove a useless message passing."
2013-12-27 07:56:56 +00:00
2fc1cc099f
Merge "[IL45] Remove lingering messages"
2013-12-27 07:56:44 +00:00
c654fe57b1
[IL48] Move onEndBatchInputAsyncInternal to InputLogic.
...
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
2013-12-27 16:50:08 +09:00
4a144b9b4d
[IL47] Inline getSuggestedWordsGestureLocked
...
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.
Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
2013-12-27 16:50:08 +09:00
71a3e96382
[IL46] Remove a useless message passing.
...
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords
The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.
Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
2013-12-27 16:50:06 +09:00
0d21223521
Merge "[IL44] Some factorization"
2013-12-27 06:58:12 +00:00
31ff2a4335
[IL45] Remove lingering messages
...
Bug: 8636060
And possibly bug: 12085864
Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
2013-12-27 15:34:30 +09:00
69e7a0d24d
[IL44] Some factorization
...
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.
Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
2013-12-27 15:34:26 +09:00
c197b9ed90
Merge "Make setAdditionalDictionaries private."
2013-12-27 06:22:18 +00:00
abc3d0eb56
Make setAdditionalDictionaries private.
...
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
2013-12-27 14:49:32 +09:00
f441047fad
[IL43] Small cleanup
...
All calls are already passing this
Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
2013-12-26 22:12:24 +09:00
c28f02880c
[IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
...
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
2013-12-26 22:12:22 +09:00
70433efc41
[IL41] Remove a useless call and trampoline.
...
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.
Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
2013-12-26 21:58:41 +09:00
a374482719
Extract dict operations from Suggest to a new class.
...
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
2013-12-26 20:48:19 +09:00
5c45ff1214
[IL39] Change a test.
...
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.
Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
2013-12-26 18:44:17 +09:00
98140faac3
[IL38] Fix a wrong double call
...
This only gives bad results if a gesture results in only one suggestion.
Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
2013-12-26 18:43:47 +09:00
30a72da42c
[IL37] Small simplification
...
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
2013-12-26 13:51:09 +09:00
c08119e5c1
[IL36] Inline setAutoCorrection
...
There are far too many one-use methods.
Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
2013-12-26 13:18:36 +09:00
52a2682b99
[IL35] Preparative cleanup
...
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
2013-12-25 22:25:49 +09:00
bb39518bd7
Use SettingsValues instead of Settings in Suggest.
...
Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
2013-12-25 18:53:04 +09:00
eea7122e5b
Move dict operations to Suggest.
...
Bug: 8187060
Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
2013-12-25 15:26:50 +09:00
f1457e7a22
Remove personalized dicts when the option is turned off.
...
Bug: 11757851
Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f
2013-12-25 11:44:16 +09:00
8476c2e788
[IL33] Opportunistically remove some KeyboardSwitcher
...
Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
2013-12-24 15:11:35 +09:00
1587be6977
[IL31] Move *BatchInput to InputLogic
...
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
2013-12-20 21:24:27 +09:00
059f4c2f39
[IL30] Minor refactoring
...
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
2013-12-20 20:47:44 +09:00
0547b33130
[IL29] Move retryResetCaches and tryFixLyingCursorPosition
...
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
2013-12-20 20:47:29 +09:00
81e8d16031
[IL28] Remove useless code
...
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.
Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
2013-12-20 19:48:05 +09:00
55ce2cc2d5
[IL27] Some refactoring
...
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
2013-12-20 19:24:38 +09:00
221df9e59a
[IL26] Move restartSuggestionsOnWordTouchedByCursor
...
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
2013-12-20 19:09:36 +09:00
ec4b6e7bb3
[IL25] Inline handleClose
...
Only ever used here.
Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
2013-12-20 18:44:13 +09:00
aa161eb371
[IL24] Move mDisplayOrientation to SettingsValues.
...
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
2013-12-20 18:44:09 +09:00
11730aa224
[IL22] Move onTextInput to InputLogic.
...
Also pull the TLD specific processing
Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
2013-12-20 16:50:14 +09:00
1404c1af85
[IL21] Move the workaround utils to a better place.
...
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
2013-12-20 16:48:54 +09:00
8a390023e1
[IL20] Remove some useless processing.
...
If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.
Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
2013-12-20 16:02:07 +09:00
4487a30e0d
[IL19] Resolve a TODO.
...
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
2013-12-20 16:02:03 +09:00
2a6de7903c
[IL18] Move and rename updateSuggestionStrip
...
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
2013-12-20 15:46:34 +09:00
1c0374da49
[IL17] Move commitChosenWord to InputLogic.
...
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.
Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
2013-12-20 15:13:48 +09:00
a905fcec00
[IL16] Improve getTextWithSuggestionSpan
...
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.
Not directly related, but helpful with:
Bug: 8636060
Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
2013-12-20 15:13:48 +09:00
5c9e677c2a
[IL15] Some small refactoring
...
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
2013-12-20 11:24:45 +09:00
48ba1f25ff
[IL14] Move getCurrent*Caps* to InputLogic
...
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
2013-12-20 11:24:42 +09:00
bbe40835a9
[IL12] move restartSuggestions* to InputLogic
...
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
2013-12-19 20:30:41 +09:00
10755af97b
[IL11] Cleanup
...
Make some methods private and add comments.
Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
2013-12-19 20:13:14 +09:00
060e292628
[IL10] Move revertCommit to InputLogic
...
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
2013-12-19 19:30:26 +09:00
69a57bcdcd
[IL9] Move commitCurrentAutoCorrection to InputLogic
...
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
2013-12-19 19:30:20 +09:00
035e3885ac
[IL8] Move handleNonSeparator to InputLogic
...
Also move getActualCapsMode and getNthPreviousWordForSuggestion
Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
2013-12-19 18:32:51 +09:00
d85e49bf8c
[IL7] Move performRecapitalization to InputLogic
...
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
2013-12-19 18:20:41 +09:00
40b42b7d84
[IL6] Move handleSeparator to InputLogic
...
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod
Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
2013-12-19 17:39:01 +09:00
c8dfaab783
[IL5] Some renaming
...
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
2013-12-19 17:38:55 +09:00
37d3f1bd02
[IL4] Move handleNonSpecialCharacter to InputLogic.
...
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
2013-12-19 16:46:57 +09:00
0e82fa273d
[IL3] Move handleBackspace to InputLogic.
...
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline
Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
2013-12-19 16:46:54 +09:00
cddf4f9d78
[IL2] Move onCodeInput to InputLogic.
...
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
2013-12-19 16:24:45 +09:00
7bd2a75ca1
Start separating the input logic from LatinIME.
...
Create an InputEngine class and start moving the relevant
variables to it.
Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
2013-12-19 14:48:43 +09:00
dfbe2bfe08
Add some info to test crashes to help diagnose flakiness
...
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
2013-12-18 18:10:56 +09:00
1f5a3faf76
Merge "Enable Personalized dictionaries based on the setting."
2013-12-17 10:40:29 +00:00
8732f9c5f9
Enable Personalized dictionaries based on the setting.
...
Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7
2013-12-17 19:36:19 +09:00
7cd7cf73f4
Fix a bug with languages without spaces and predictions
...
This is simpler and more correct.
Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
2013-12-16 23:16:02 +09:00
dc06ee85ef
A simplification.
...
This does the same thing, but simpler and faster.
Was noticed while investigating bug#12164555
Change-Id: If9926e4da8a53a65489da55197ac87122c44fe7c
2013-12-16 21:38:31 +09:00
7a904514fb
Merge "Don't use the previous word after a non-whitespace separator"
2013-12-13 11:53:30 +00:00
0b51fac907
Merge "Only update shift state if left in auto mode."
2013-12-13 11:52:13 +00:00
fae1ba767c
Don't use the previous word after a non-whitespace separator
...
Bug: 12101276
Change-Id: Icf36d55ec171194e5561b946021bcf648782ddd4
2013-12-13 20:51:28 +09:00
28bd6e2297
Only update shift state if left in auto mode.
...
Bug: 12100417
Change-Id: I7bc2b19332e142a257b0399f2e5d128caf01fc7c
2013-12-13 20:47:25 +09:00
cc8c544ee2
Remove code for forgetting curve in Java side.
...
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
2013-12-13 18:40:58 +09:00
2fa3693c26
Reset to 9bd6dac470
...
The bulk merge from -bayo to klp-dev should not have been merged to master.
Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
2013-12-13 17:13:32 +09:00
ea8f8da1ac
Fix unusual NPE after onDestroy
...
Bug: 11673978
Change-Id: I4d5268312911685ff1ca9483a62442a1a9686c62
2013-11-22 17:26:42 -08:00
db86a6f271
Add keyboard color switch option
...
Bug: 11622614
Change-Id: I25aa1ff7376fe72fd94ab2cb7190c61d7a98a1af
2013-11-22 17:26:33 -08:00
87cd39124a
handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL
...
This is a fix only for the Bayo branch because this part in master has
been changed.
The corresponding fix in master is I295eeb5f9f0f1f07e919bf54122d003be150a174
bug: 11797053
Change-Id: I779be039ebf992de5d246c7a9d9509623fc3c120
2013-11-21 17:47:05 +09:00
3a9b2430a5
Fix many small nits.
...
...the interaction of which results in a very bad bug.
Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
2013-11-12 22:44:59 -08:00
e4022137ee
Remove an out-of-place check
...
Bug: 11584525
Change-Id: I76cc3e4ee21d62fbd56042adcf085efd5cafb53f
2013-11-12 22:44:58 -08:00
c130be8779
Add a sequence number to SuggestedWords.
...
This allows testing for suggestion freshness in an asynchronous
suggestions world.
In-advance cherrypick of Ic76cd17568598d8534aec81e037f9e37f52eb6b4
because there's a merge conflict.
Bug: 11301597
Change-Id: I4aec765a975298fcac30a48dede73d2622224fe5
2013-10-22 13:19:16 +09:00
b044047227
mExpectingUpdateSelection was out of sync when nothing to delete.
...
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)
This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.
1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace
The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.
bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
2013-10-15 14:05:34 +09:00
cf5dfd2464
am 3a3bbf4a: am eed74b81: am c8383eda: Fix wrong commitText parameter in sendKeyCodePoint()
...
* commit '3a3bbf4a38870ecc42b7f6fbd3a7cae20fe020a7':
Fix wrong commitText parameter in sendKeyCodePoint()
2013-10-14 10:52:40 -07:00
c8383eda8b
Fix wrong commitText parameter in sendKeyCodePoint()
...
Small optimization on generating a String instance from a single code
point too.
bug: 11181913
Change-Id: I0f905e4dc6ec7841092bb4d3d940daf3b2303f5b
2013-10-13 10:56:10 +09:00
fe97ff4083
am 60fb5865: am 06e1bdaa: am 3e35e072: Merge "Make emoji separators" into klp-dev
...
* commit '60fb58654e33448651fea191ba22cfdc87e37466':
Make emoji separators
2013-10-11 05:10:21 -07:00
eb7fa4dc6d
am 40506273: am ac6d0c65: am 6d915037: Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev
...
* commit '405062733cfe066c4b9af719bfc36a9a516c9dd3':
Fix a bug where emojis would remove the suggestion strip.
2013-10-11 05:10:19 -07:00
3e35e0727c
Merge "Make emoji separators" into klp-dev
2013-10-11 11:57:07 +00:00
6fc15b9fc4
Fix a bug where emojis would remove the suggestion strip.
...
Bug: 11163495
Change-Id: I23d12c430125cc2a66a6e00715a4c609bb9e2bb1
2013-10-11 20:51:13 +09:00
401fb908f0
Make emoji separators
...
Bug: 11163495
Change-Id: I3247b8d1bbd3406b29a30a25aebd932c63431943
2013-10-11 20:00:38 +09:00
7e6ac9d727
Allow double-space-to-period after percent
...
Bug: 11158604
Change-Id: If8c94ef91ed58bb5028f51be7c8d9beb677436a4
2013-10-10 21:26:08 +09:00
f178685c11
Always call finishComposingText before recapitalization
...
Workaround for framework bug:
Bug: 10792236
Change-Id: I3706b9eed5223889791840e30660f8d17625cb70
2013-10-09 12:15:21 +09:00
27d78643e8
Remove a useless IPC call.
...
This is not useful because we're going to call setSelection again
with different values on the connection right away.
Also a preliminary change for
Bug: 10792236
Change-Id: I46c6ef1fbb3624086099bf81afddb0ef5ae85661
2013-10-09 12:11:28 +09:00
a701501cb6
Merge "Reduce memory of emoji palette"
2013-10-08 11:22:21 +00:00
0e01df9baf
Reduce memory of emoji palette
...
Bug: 10902556
Change-Id: I3c8da35a601de2bfb248292c7b59235fc1120988
2013-10-08 20:11:35 +09:00
482aa129e4
Show the keyboard earlier when rotating.
...
Bug: 11107229
Change-Id: I0b36341d60b634a860eb13fafd0dc69fe734bdeb
2013-10-08 16:33:27 +09:00
10581e68af
Make the sentence separator a resource.
...
This will help handing correctly the armenian full stop.
Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
2013-10-08 15:28:43 +09:00
3c4e8cb693
Call loadKeyboard later if it can't be called right away
...
Since loadKeyboard relies on the input connection being
available to give it the auto-caps state, but also can't
be called twice in a row because it needs to save and
restore its state and invalidates it after the restore,
we need to wait until we know we have a valid input
connection to call it.
Bug: 11107229
Change-Id: I1c7baf3215682df6f6ceb357bd37254f9e7418c7
2013-10-07 22:57:59 +09:00
4be5f221e6
Clear the cache of subtypes in onStartInputViewInternal
...
Bug: 11077905
Change-Id: I9495f13a20edca0e6153cd1a7a0ac6891f707c59
2013-10-07 20:10:58 +09:00
423921ca13
Merge "Fallback on empty locales."
2013-10-04 13:44:44 +00:00
43a8a0c527
Fallback on empty locales.
...
This is a very rare corner case.
Bug: 11072132
Change-Id: Iad2aa69511f7dc99105284a049c63f2f997b8ef0
2013-10-04 22:04:59 +09:00
8142fd83a6
Accept double-space-period after emoji.
...
This also includes a fix that allows this code to read surrogate
pairs in this processing.
Bug: 11070482
Change-Id: If5ef8d6863938252f09128b7e99ea07ece6e7019
2013-10-04 22:01:36 +09:00
d25cd26f1a
Merge "Try decaying user history at hourly intervals."
2013-10-02 09:44:03 +00:00
f36a97ab3a
Try decaying user history at hourly intervals.
...
Bug: 6669677
Change-Id: Ib465fa7e1a7f289a07843535ba89d0dd5259e803
2013-10-02 18:06:08 +09:00
f735117d36
Fix a pernicious bug with caps.
...
What's happening here is, setAlphabetKeyboard sets the
keyboard to AUTOMATIC_SHIFTED and updates the keyboard, then
restoring the keyboard old state sets it back to UNSHIFTED without
updating it. When we finally know what the correct value is,
we try to set it to UNSHIFTED, but since that's already the currently
recorded state, it skips updating the keyboard forever.
The solution is to avoid setting the shift state without updating the
keyboard.
Bug: 10948582
Change-Id: Ic8670401e378f8284e851281f91a9ad93eac8e90
2013-10-02 16:57:36 +09:00
458fb52b98
Merge "Speak auto-corrections for accessibility"
2013-09-30 18:14:13 +00:00
1cf4789ba6
Merge "Set header attributes for ExpandableBinaryDictionary."
2013-09-29 05:14:22 +00:00
5ed30a7660
Set header attributes for ExpandableBinaryDictionary.
...
Bug: 6669677
Change-Id: I2462777eaa07600f1c774226adfc4f351882f523
2013-09-28 12:50:09 +09:00
67319f92f3
Speak auto-corrections for accessibility
...
BUG: 8669376
Change-Id: Id71b2c2835daa7a8c9d6c92c57a7e302551c289d
2013-09-27 14:15:53 -07:00
de814ec0ec
Send backspace as an event when TYPE_NULL.
...
This is not enough to really fix behavior with TYPE_NULL,
but it does make things a bit better.
Bug: 10949594
Change-Id: Ia359f781cdd76a2e2c5a4c9f166025d81b931174
2013-09-27 16:55:12 +09:00
8f23c6f78b
Merge "Detect cases where rotation messes with initialization"
2013-09-24 05:38:44 +00:00
f1d8aa46f9
Detect cases where rotation messes with initialization
...
...and do a best effort to fix it.
Bug: 10323080
Bug: 10252066
Change-Id: Icb3c9fe85005406bdfce0b7bb143ba0a910a0ddb
2013-09-20 22:21:28 +09:00
be3be424a3
Fix a bug that happens upon a race condition
...
Bug: 10848621
Change-Id: If5ff7f001e69af005a5ff9ab3e9f630b88a0a858
2013-09-20 18:21:10 +09:00
a469743e33
Add showSuggestionStripWithTypedWord.
...
Bug: 10814472
Change-Id: I3a150124baf7a9b7889b033089a859ff9c11e206
2013-09-19 20:52:28 +09:00
08bc97f86f
Merge "Allow double-space-to-period after a plus char"
2013-09-18 12:40:29 +00:00
ba99d8cd0b
Allow double-space-to-period after a plus char
...
Bug: 10704936
Change-Id: I30fdaea648605ef7e7fea6c093581ed5c6de03f3
2013-09-18 21:04:25 +09:00
f71e1db2da
Don't resume suggestion on digits.
...
Bug: 10780016
Change-Id: I94fad06e4c71eddc96bdda1765925f98bed160f3
2013-09-18 11:37:19 +09:00
b1e98c2f4f
[AC8] Restrict the suggestion strip to the correct part
...
...for phrase gesture.
Bug: 9059617
Change-Id: Ic5c0616f28af4ba45ca72a5721d1926029adc1c5
2013-09-17 18:43:12 +09:00
e8754aba1c
[AC7] Actually auto-commit.
...
Bug: 9059617
Change-Id: I7e5d89a9037b9181a0a6456c12043b4bfda8fe4b
2013-09-17 16:44:50 +09:00
41aaff6cdf
Merge "[AC4] Add native methods necessary for auto-commit"
2013-09-13 11:41:55 +00:00
24aad5a4d5
[AC4] Add native methods necessary for auto-commit
...
Bug: 9059617
Change-Id: I7a47b0675446fc4f39628c60d16de9aea90d1b4d
2013-09-13 20:15:15 +09:00
898dbe3c29
Fix emoji keyboard insets
...
Bug: 10541453
Change-Id: I16dd72c8c55cb5d21ad61a3307c0f3c5f16f460c
2013-09-13 14:21:40 +09:00
ce96d0d12f
Avoid recorrection in ex-password fields.
...
Bug: 10115839
Change-Id: I1f1025c9f28adfb6f5a63d5ba86e359f30c0963e
2013-09-12 21:20:07 +09:00
87472f0038
Remove changing a word when added to the dictionary
...
This code is now useless.
I thought it affected 9902905, but it seems it actually does not.
Still, it's dead code.
Bug: 9902905
Change-Id: Id9c90fbf88f015af47b2368b90d173c481647093
2013-09-12 15:10:10 +09:00
e193c5255d
Revert Ida230ca42 and I6adf7d08f.
...
Change-Id: I2ddb250d5a473ea955a5171656974de7288a13f7
2013-09-10 19:08:43 +09:00
acdabb25f4
Add AsyncResultHolder.
...
Change-Id: Icfa685bcda2f5c74f5649f09098d00b4bd321c5a
2013-09-10 15:48:06 +09:00
cc2751ba03
Make commitCurrentAutoCorrection asynchronous.
...
Change-Id: Ida230ca4243347fb3ab9fda7de3a9a18f886cd1c
2013-09-09 14:47:26 +09:00
b1af47c8fe
Add a callback to the arguments of commitCurrentAutoCorrection.
...
Change-Id: I6adf7d08fdc4382233a63304743207368db8058a
2013-09-05 20:00:40 +09:00
648088aa9e
Change GET_SUGGESTED_WORDS_TIMEOUT to 200.
...
Change-Id: Ia5aa0b7af16d7ad45c98d0c5a7dcabba76d19b67
2013-09-03 18:52:53 +09:00
d6c947ef7b
Change GET_SUGGESTED_WORDS_TIMEOUT to 50.
...
Change-Id: I4d495a782ed1dea1c377837c6579ce5ff74086b5
2013-09-03 17:39:47 +09:00
908fc4f1c3
Call getSuggestedWords asynchronously.
...
Change-Id: Ia8a21b53f4d12b759d9ef5a5181ed04875e4d198
2013-09-03 15:12:49 +09:00
8616e4c03d
Remove typedWord from the arguments of showSuggestionStrip.
...
Change-Id: Iddf33227982e65705b49c6a527286d8695878c90
2013-09-02 22:31:43 +09:00
9666a22815
Revert "Revert "Add onGetSuggestedWordsCallback.""
...
This reverts commit 78f707a142
2013-09-02 14:09:53 +09:00
acc886eeb4
Merge "Revert "Add onGetSuggestedWordsCallback.""
2013-08-30 14:07:18 +00:00
78f707a142
Revert "Add onGetSuggestedWordsCallback."
...
This reverts commit 820c290a61
2013-08-30 14:06:19 +00:00
56e1b7e4f1
Fix emoji view insets calculation
...
bug: 10541453
Change-Id: I605e657c94686c4974d162657a5e820798d20e8f
2013-08-30 21:18:36 +09:00
5169937dd4
Revert "Revert "Support Emoji keyboard""
...
Window resizing junkiness is addressed in I605e657c9468
This reverts commit aabc972338
2013-08-30 19:46:10 +09:00
9f79cf6de4
Merge "Add onGetSuggestedWordsCallback."
2013-08-30 07:52:57 +00:00
2f95baaaf0
Merge "Revert "Remove key preview backing view""
2013-08-30 07:51:29 +00:00
c160a3932f
Revert "Remove key preview backing view"
...
This reverts commit 2dfcfc5013
2013-08-30 07:50:37 +00:00
aabc972338
Revert "Support Emoji keyboard"
...
This reverts commit d7791a93b0
2013-08-30 07:23:42 +00:00
820c290a61
Add onGetSuggestedWordsCallback.
...
Change-Id: Ib527d31f9c2dd6dc385cb2f767cd90d9d28a1b1b
2013-08-30 16:08:13 +09:00
d7791a93b0
Support Emoji keyboard
...
Bug: 6370846
Change-Id: I33ce8f952799c89929996a226ac17731a953ec2a
2013-08-29 19:48:34 +09:00
fe87f5f417
Pass additionalFeaturesOptions for getSuggestions().
...
This fixes null pointer exceptions that are caused when
getSuggestion() is called from spell checker.
Change-Id: Ifc9e7abb900e1a4646e33c91022effde439673e4
2013-08-28 19:24:28 +09:00
6e04d65932
Make DynamicPred...Base extend ExpandableBinaryDictionary.
...
Bug: 6669677
Change-Id: I06afad35d3eb73510c34d10cd4116f5bcf934f7c
2013-08-26 18:50:22 +09:00
366c0c5198
Register personalization dictionary
...
Bug: 9429906
Change-Id: Ic754dd8da67446dfb1ebf44aa3d5ab0804298ca0
2013-08-22 18:06:59 +09:00
f739807a3f
Merge "Add onDestroy to PersonalizationDictionarySessionRegister"
2013-08-21 10:54:08 +00:00
3c8f22880f
Add onDestroy to PersonalizationDictionarySessionRegister
...
Bug: 9429906
Change-Id: Ibf8efd7302da2c27ac59e62b0393f1eec03dc136
2013-08-21 17:24:12 +09:00
2448159ad4
Don't start composing on dash.
...
Bug: 10403176
Change-Id: I9f969ab9b772dc5ba2015c494b4f98a8864277c4
2013-08-21 11:59:21 +09:00
2c7a3e0405
Merge "[AC3] Start calling the methods for auto-commit."
2013-08-20 11:05:23 +00:00
c10d76f28c
Merge "[AC2] Reference a dict rather than a string in suggestion infos"
2013-08-20 11:05:12 +00:00
3f15c41d88
Merge "[AC1] Add a memory of where to cut the first word."
2013-08-20 11:05:09 +00:00
66a870cb53
[AC3] Start calling the methods for auto-commit.
...
Bug: 9059617
Change-Id: I190a4baf2fa831b70e00e129b5dfaa8c9c32b3a0
2013-08-20 19:26:11 +09:00
e8ef095670
[AC2] Reference a dict rather than a string in suggestion infos
...
Bug: 9059617
Change-Id: Ic17bc0fd5d812268fd37d7fd35b4e9ebfb95fa5e
2013-08-20 19:18:09 +09:00
ef1e363016
[AC1] Add a memory of where to cut the first word.
...
Bug: 9059617
Change-Id: I931b6d1eb49f9f7dd7d5b18956e35751d1b2b631
2013-08-20 18:43:19 +09:00
d6ddb96ee8
Add a functionality to boost scores of personalization dictionary
...
Bug: 9429906
Change-Id: I1518c5cbc7d41188e7dc6a35d226da277ed5913f
2013-08-20 17:50:48 +09:00
c239a34262
Support languages that don't use spaces.
...
Thai is an example.
Bug: 10138062
Change-Id: Ib9a8264c77ed42b4256432d7c8a60d08575dcdc7
2013-08-16 21:01:08 +09:00
ed5582ec65
Merge "Thin out audio and haptic feedback while key repeat"
2013-08-14 10:11:43 +00:00
5fd8b7ebd5
Merge "Add looksValidForDictionaryInsertion"
2013-08-14 09:41:49 +00:00
af5fbe70ac
Add looksValidForDictionaryInsertion
...
...and test it.
Also at the same time, add a facility to create a SettingsValues for
test, and some minor performance improvement to surrounding
methods.
Change-Id: I13b629ae14755c244af2a9406a7e9b4a4a16090f
2013-08-14 18:39:28 +09:00
ab16237e69
Thin out audio and haptic feedback while key repeat
...
Bug: 6522943
Change-Id: Id60f256ab0f8741578eda276116817fa48917325
2013-08-14 18:37:58 +09:00
fdfc8ad2d0
Merge "Re-evaluate auto-caps earlier."
2013-08-14 09:29:48 +00:00
4bc74d19ef
Merge "Delete surrogate together."
2013-08-14 09:06:07 +00:00
b2d954cad6
Delete surrogate together.
...
Stop deleting them one after the other, it makes no sense. We
can know in advance if we should delete two of them, so let's
use that.
Bug: 6526420
Change-Id: Ifa2263cbde8fedc78bb750b84d4acd3f979774ea
2013-08-14 17:53:33 +09:00
b7e782d868
Re-evaluate auto-caps earlier.
...
We have all we know to re-evaluate auto-caps in this case.
We don't need to wait until we get the callback from TextView.
Bug: 10287972
Change-Id: I87e4e26cd193a001f91fe852ffc5a8f728db2449
2013-08-14 17:40:23 +09:00
1162c0537d
Merge "Remove dead code"
2013-08-14 08:35:46 +00:00
d81b9d0276
Remove dead code
...
isComposingWord() is actually defined as size > 0, so this test
can never be false.
Change-Id: If71afae6f0b16bff46178f0fae3244597354fecb
2013-08-14 16:38:37 +09:00
e18fdf804a
Merge "Fix a bug with surrogate pairs"
2013-08-14 07:27:54 +00:00
a74ae9c451
Fix a bug with surrogate pairs
...
Bug: 10316781
Change-Id: I528c59c8823cda11975cb01b0ae59f12cfadef3b
2013-08-14 16:00:28 +09:00
d1d607287d
Remove audio and haptic feedback while key repeating
...
Bug: 6522943
Change-Id: Iad1b11172e47bfbae2b4129361a56b9d793f8f62
2013-08-13 17:03:26 +09:00
8c4fcb108f
Add PersionalizationDictionaryRegister
...
Bug: 9429906
Change-Id: Ibd4d5cedb371c0b4ee1342a3e6d221c9e34c2402
2013-08-12 14:48:45 +09:00
4a2f6a2216
am 25402fd5: am 724db044: Deallocate gesture trail bitmap when unneeded further
...
* commit '25402fd5309891884a843528d47f6b4646341a3f':
Deallocate gesture trail bitmap when unneeded further
2013-08-09 15:53:29 -07:00
724db04495
Deallocate gesture trail bitmap when unneeded further
...
Follow up to I5bc980c4dc41bc304be3c190934c1f7c55c9d244
bug: 8967766
Change-Id: I7b916daa5269cfde359a77555e8ffadf0e4a8f92
2013-08-09 21:07:40 +09:00
2dfcfc5013
Remove key preview backing view
...
This change re-origanizes view hierarchy of IME's input view.
Change-Id: I9d0a07692d0f41de3345d207366393bcd5424f7e
2013-08-09 20:25:42 +09:00
c05b3b56cc
Merge "Add a session for the personalization dictionary"
2013-08-07 08:45:19 +00:00
80aa7197b4
Add a session for the personalization dictionary
...
Bug: 9429906
Bug: 4192129
Change-Id: I361ab380edeee5a8a8b364df3f9f4ab202b79105
2013-08-07 16:44:30 +09:00
cc38bfb5d3
Merge "Add emoji icon and code as a groundwork"
2013-08-06 05:35:14 +00:00
b127d88285
Add emoji icon and code as a groundwork
...
The emoji switching key icon asset should be updated. The icons in
this change are just borrowed from Hangout.
Bug: 10179862
Bug: 6370846
Change-Id: Icea26d2cf2ac6a6df9beb4c98f646dbe309bdcd9
2013-08-06 14:16:15 +09:00
52d220e71b
Remove unnecessary suggestion strip container
...
Change-Id: I3710e1fe1574c0f69f7f448619e939fb45e9b8d3
2013-08-06 10:57:47 +09:00
c0a732f032
Remove CODE_RESEARCH
...
Instead of CODE_RESEARCH, special outputText ".research." is used to
invoke a research feedback dialog.
Change-Id: Ic95c956ab4f2b5f0c3f2205c9bbcdcfb67db5d6e
2013-08-05 19:05:07 +09:00
28a148681e
Small cleanup
...
Change-Id: I7dce7373b371f1ed5a985815f5d43fb6c6ee1f84
2013-08-05 18:46:35 +09:00
60586b57cf
Connect the personalization dictionary
...
Bug: 9429906
Bug: 4192129
Change-Id: I9c9f3ed7699f74339ad92be6dcddb8a52c377545
2013-08-01 16:33:20 +09:00
c8814e20b7
Deallocate gesture trail bitmap when unneeded
...
This frees up 1.7MB on Nexus 4 (occam), and 900KB on occam_svelte while
LatinIME goes to background.
The keyboard bring-up speed feels acceptable on both devices.
bug: 8967766
Change-Id: I5bc980c4dc41bc304be3c190934c1f7c55c9d244
2013-07-31 20:39:32 +09:00
2d7e927354
Fix inconsistencies with mSuggest.
...
This should fix some NPEs, but they are so unlikely that we never
see them.
Bug: 10065412
Change-Id: I2aefea1f52024405cc3fda9106fea41a02aaf4d8
2013-07-31 18:59:18 +09:00
87d06afc66
Refactor on the user history dictionary
...
Bug: 9429906
Bug: 4192129
Change-Id: I1a2bfe96e18119d30a72290aa48746f77a021018
2013-07-31 16:48:55 +09:00
c5c226c424
Fix inconsistency with mutable settings.
...
Change-Id: I0550044199273cecb6f5713aa2e43ae16319cd47
2013-07-30 14:30:24 +09:00
74bcc911ea
Fix a problem where settings were not renewed correctly.
...
Bug: 10065412
Change-Id: Id05284f45466cd5b2697a695c3d1bdfbf3cc1f24
2013-07-30 13:22:05 +09:00
b60e65a0cc
Rename a variable for SettingsValues
...
Change-Id: Icb4155532ea8724791c9194e8dc75ce32b6e8b16
2013-07-29 18:53:23 +09:00
d9f0c1e020
Merge "Fix an NPE"
2013-07-29 09:46:32 +00:00
5408fec63a
Fix an NPE
...
Also make mSuggest private for more security.
Bug: 10045657
Change-Id: I712505e4d2a2606efff5d09ba9b4c656f9e7c7a9
2013-07-29 18:09:48 +09:00
d45e4b6e5b
Add personalization dictionary helper
...
Bug: 9429906
Bug: 4192129
Change-Id: Ic618b0b09a54ed46b20633bd4c1c570d4ac775af
2013-07-29 12:37:27 +09:00
ffcbbaf127
Refactor on UserHistoryDictionary
...
Bug: 9429906
Change-Id: I576a91643bdaf5017cc826ac2e07a74a9a275d60
2013-07-26 13:00:19 +09:00
5c095e59f6
Cancel all ongoing event when onFinishInputView
...
Bug: 9334755
Change-Id: If0c2ac49a50f4a529aefeca603569f9413367469
2013-07-25 20:05:39 +09:00
a7d2fc6bef
Move settings related classes to "settings"
...
Change-Id: Id170dbfe2dcfc93130b7be4a84615940403ec37f
2013-07-22 16:35:44 +09:00
b03447e1af
Move a couple classes to the utils package
...
Change-Id: Ia14a2011d79bad7cd02697b9254705f6e2099442
2013-07-19 10:46:46 +09:00
6455172a70
Distinguish key press in repeat key
...
Bug: 9859367
Change-Id: Iad643f9785b193e1918a8363de4fefc3b7558bdf
2013-07-16 19:21:16 +09:00
4be6198cb7
Reorganize Utils class
...
Change-Id: I7294d1547def5dcfcae9d1d53b277cb3cc9f2d18
2013-07-05 19:24:40 +09:00
f87e8f7ec1
Handling key repeat by emulating key press and code input
...
This change also eliminates a reference of
AudioAndHapticFeedbackManager from KeyboardSwitcher and MainKeyboard.
Bug: 6522943
Change-Id: Iac42ec8ff00c66deb76a660ffc07477923a58959
2013-07-02 19:50:34 +09:00
e5a3b77664
Merge "Move Range out of RichInputConnection and rename it."
2013-07-01 07:20:51 +00:00
675bcf191c
Move Range out of RichInputConnection and rename it.
...
Range has grown a bit too big to stay an internal class.
Change-Id: Ic3fbc48a5d10776eedd7559c4d696e5926b88288
2013-07-01 15:41:13 +09:00
f0af452ce2
Do not re-resume suggestion if it's not needed.
...
This is much better interface-wise. It eliminates all blinking
of the line in the practice.
Bug: 8874148
Bug: 8864306
Change-Id: I87754e44784327c2e9c8b162d598d145e20668e8
2013-07-01 14:40:12 +09:00
2bbd78ab0a
Merge "Ignore spans that are not the right size."
2013-06-27 03:06:47 +00:00
2f7f6257b6
Ignore spans that are not the right size.
...
Bug: 8839763
Bug: 8862327
Change-Id: I5d49c86edcbc0fc1b2b147856437cfbadd678377
2013-06-26 23:02:50 +09:00
6c0e412137
Merge "Resume suggestion at start input"
2013-06-26 10:18:32 +00:00
fb72890ac6
Readability improvement
...
Change-Id: I2f350145f333ba1fa4eb20027b0f41107c2df02c
2013-06-26 16:03:40 +09:00
7fcf304c97
Fixing follow-up to I548d899b
...
I548d899b introduced a new method to fix a sync miss between
the cursor position and the cached cursor position, but did not
take into account that it should also update the cached text
before and after the cursor in this case and that there was
already a method for doing this.
Change-Id: I31bd741893207c822827304e77791b1159774e1a
2013-06-26 15:28:42 +09:00
2f69348d51
Resume suggestion at start input
...
Bug: 9568410
Change-Id: I65468268f8613c863fa7f3a497b64656da0a221c
2013-06-25 19:38:31 +09:00
9419e02fd9
Make UserLogRingCharBuffer an external class
...
Change-Id: I9d506995337d64ec11c72939a8d739423ee46efa
2013-06-25 18:38:13 +09:00
10585620bd
Merge "Fix a bug in the cached cursor pos, and simplify selection handling"
2013-06-25 05:00:11 +00:00
cdf774122d
Merge "Fix a small bug"
2013-06-24 10:00:05 +00:00
bfaf349c35
Load the native lib eagerly
...
in the hope of avoiding UnsatisfiedLinkError. This is definitely not a
confident fix as we still don't know the root cause of the issue.
bug: 9325110
Change-Id: I1abf8031b98509f63fce6a2d069d497895ea712c
2013-06-24 18:12:04 +09:00
bc1813186d
Merge "Move util classes to the latin/utils directory"
2013-06-24 08:49:06 +00:00
ca52e1ca5a
Fix a small bug
...
SpannableStrings are not the only type of Spanned, they are
only the mutable kind. SpannedString is the immutable one.
Spanned is the correct class to use there.
Bug: 8839763
Bug: 8862327
Change-Id: Ic5e6199a51f22368914f2748ac2d0d1ca6a33f78
2013-06-24 17:39:17 +09:00
e28eba5074
Move util classes to the latin/utils directory
...
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
2013-06-24 17:04:40 +09:00
e8c4b99e56
Refactor text range to be able to get spans larger than the word
...
This changes how the Range class stores its data, but not its
functionality. It also improves encapsulation a bit.
Bug: 8839763
Bug: 8862327
Change-Id: I5bd583b3fc96a99b93a2632882d8fd587c03ab76
2013-06-24 12:31:14 +09:00
673c727b7a
Defer disk-intensive tasks until after the keyboard is shown
...
Bug: 8689779
Change-Id: Ia78d3540f44ec0028c3246a8e0163e9ecf061ecf
2013-06-21 19:41:45 +09:00
e5dee0af4a
Fix a bug in the cached cursor pos, and simplify selection handling
...
The documentation for setComposingRegion states explicitly
that it does not move the cursor. This is just a bug.
This does not have any ill effects right now, but it will have
in later changes if not fixed.
As for the selection handling, the specific test that this code
removes used to serve a purpose, but it does not any more because
the code using the value has been much sanitized. Now the variable
can just take the obvious value, and become so self-explanatory
that the comments are unnecessary.
Change-Id: I548d899b38776bd3ab5f5361aab0d89d98f12e73
2013-06-21 18:15:07 +09:00
fc98325c61
Log score, kind, and sourceDict for manual suggestion and gesture
...
b/9422713
Change-Id: I4880fad6a5b10d09ca11b63311f14862bee724e5
2013-06-13 11:03:49 -07:00
27d9c6f795
Merge "Cache subtype lists reasonably."
2013-06-13 01:49:41 +00:00
ff6445ed0e
Cache subtype lists reasonably.
...
This will spare a lot of IPC for Latin IME at the cost of very little
retained memory.
This improves the loading by potentially a lot - between 15 and 30%
when the layout is cached (which should now be the case almost every
time), and half that if it's not. More importantly, it makes the
load time less sensitive to high device load, which is one of the
sore points.
Bug: 8689779
Change-Id: I2e07736f1a92c38eed0e203bc690761a181da8b9
2013-06-12 18:04:52 +09:00
efd26bb319
Allow downloadable dictionaries in development builds
...
Bug: 9305379
Change-Id: Iab32753070a056d3861a45aa898911b7ab67dfb6
2013-06-05 22:14:54 -07:00
0bfc2bc419
Merge "Add CODE_CAPSLOCK for long press shift key"
2013-06-05 02:19:02 +00:00
9552badf3c
Add CODE_CAPSLOCK for long press shift key
...
This change utilizes the no panel auto more key feature to implement
long press shift key for shift lock.
Change-Id: I3995d25dc35aea3c67b5aa29299815462eff9cad
2013-06-04 18:20:06 +09:00
9ff7354d78
Clear previous suggestions when gesture typing starts
...
Bug: 8651076
Change-Id: Ic65ed3e3696409edea4e35080c11e4d1869a5a7e
2013-06-03 17:59:26 +09:00
743302888b
Merge "Uncommit separator LogUnits"
2013-06-03 03:01:23 +00:00
3d20946272
Merge "Uncommit LogUnits when reverting textInput"
2013-06-03 02:58:20 +00:00
bdff287a0d
Uncommit separator LogUnits
...
Now that separators have their own LogUnits, they must be uncommitted
from the LogBuffer when backspacing over them.
Bug: 9088919
Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
2013-06-02 19:15:57 -07:00
720840851d
Uncommit LogUnits when reverting textInput
...
Bug: 9088919
Change-Id: I17187aa0afc1c3e9d32269c65f66cfb3a08663cb
2013-06-01 23:42:35 -07:00
4165ef031f
Remove uncommit on reverting batch input
...
Currently when the user reverts a batch input, a LogUnit is uncommitted
from the LogBuffer. It should not be, because the LogUnit containing the
batch input is never committed in the first place (it is only committed
to the LogBuffer when a key is pressed or a new batch input is entered).
Bug: 9088919
Change-Id: I323af453ce082437a663ccae977b21b775a964bc
2013-06-01 11:15:47 -07:00
68d9cb62e2
Tell the text view we reset state on finish input
...
This should be done in onFinishInput rather than onFinishInputView
but for an unknown reason onFinishInput never comes.
Bug: 9113167
Change-Id: Iafb40846a3ed8fad78bfc160d17cd431f81fe891
2013-05-29 18:44:40 +09:00
3d97b95b90
Implement KIND_OOV_CORRECTION
...
Bug: 9127749
Change-Id: I96db15a3138e6b522c4c6ad16cc7faad577d3772
2013-05-27 18:53:43 -07:00
618407ab7e
Use localized toLowerString in AutoCorrection.isValidWord
...
Bug: 9112465
Change-Id: I63eb4115f393444560e80220d4c90f0f7101b934
2013-05-24 11:47:36 -07:00
6f9105383a
Remove unnecessary methods of KeyboardSwitcher
...
Change-Id: Idd3647bb1a1d40df8bb89eda715d45427a58d0cd
2013-05-22 10:49:53 -07:00
05ea7c5d02
am 167ba345: am 89fe1f50: Add a method to work around apps broken by recorrection
...
* commit '167ba3459b0ce02b9add12ade9388bd2b1e6eb62':
Add a method to work around apps broken by recorrection
2013-05-20 21:10:07 -07:00
0013f97ddd
am 5906b05b: am 7058b02a: Extract a new class for app-specific workarounds.
...
* commit '5906b05bb50c0a67bd4f03fcfae41db3daefe0bc':
Extract a new class for app-specific workarounds.
2013-05-20 19:50:46 -07:00
89fe1f5088
Add a method to work around apps broken by recorrection
...
Bug: 8944307
Change-Id: I8986622554f30aaf4f595099c4ab5652b75c972c
2013-05-21 07:53:31 +09:00
7058b02a9c
Extract a new class for app-specific workarounds.
...
Bug: 8944307
Change-Id: Iaff9dd03d3d856a6bdaa2b16c4e71e95cd2b6349
2013-05-21 07:53:28 +09:00
500dea6ad4
Fix punctuation logging
...
Punctuation is currently put into the same LogUnit as the
following word. This is counter-intuitive and makes
post-processing more complicated.
This change causes punctuation to be put into its own
LogUnit.
A tricky case is the phantom space. A phantom space is
inserted right before other text, whose MotionEvents have
already been collected and inserted into mCurrentLogBuffer.
Phantom spaces are handled by creating their own LogUnit and
inserting it into the LogBuffer right before
mCurrentLogBuffer is shifted in.
Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
2013-05-17 09:47:40 -07:00
17b63ba588
Merge "Remove unnecessary commit/uncommit"
2013-05-15 23:52:43 +00:00
b1e37e4a47
am f1dcf725: Merge "Don\'t process recorrection or resets when not shown"
...
* commit 'f1dcf725061b3e61e40540566a5385cf4934f424':
Don't process recorrection or resets when not shown
2013-05-15 07:58:27 -07:00
c9aaba1253
Don't process recorrection or resets when not shown
...
Bug: 8954116
Change-Id: Ica27dbfc570643bb81e6cdf34cc7c796ea080d71
2013-05-15 20:20:20 +09:00
993acbaaa2
Remove unnecessary commit/uncommit
...
When the user reverts a commit, this causes the committed
word to be changed. The user usually then goes back to edit
that word. Going back to edit causes an uncommit, so that
the editing actions are added onto the LogUnit containing
the operations used to construct the word.
But currently, reverting also involves its own
commit/uncommit pair, with the caller performing the
uncommit, and the commit happening inside the revert
command. This may have been necessary in the past, when
revert was called in different situations, but is
unnecessary now. Furthermore, the guarding conditions are
currently such that the uncommit doesn't always undo the
effects of the commit, corrupting the log output.
Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
2013-05-14 12:20:27 -07:00
d6d70e7325
Merge "Revert "Fix isSuggestionsStripVisible when keyboard hidden""
2013-05-14 11:46:04 +00:00
3efa36f6aa
Revert "Fix isSuggestionsStripVisible when keyboard hidden"
...
This reverts commit cb0d1c4c58
2013-05-14 11:44:22 +00:00
41016acacf
Back to previous keyboard layout by canceling sliding input
...
Bug: 8915171
Change-Id: Iabdeb7920f67f89246087c3ee06240406ecfbc3d
2013-05-14 20:28:03 +09:00
cb0d1c4c58
Fix isSuggestionsStripVisible when keyboard hidden
...
When the keyboard is hidden, the suggestion strip is
never visible.
Bug: 8954116
Change-Id: I9f242d07b49ad60b625a22429bb013251e814905
2013-05-14 15:19:19 +09:00
9f9cc03277
Optimizations and safeguards.
...
- Don't call finishComposingText when useless.
- Add safeguards against calling setComposingRegion when the
data returned by the editor is inconsistent.
- Cancel pending recorrection messages when new messages arrive.
Bug: 8842941
Bug: 8845001
Change-Id: I939701033cf5c2bbd85871ecf83e329021ddeb91
2013-05-08 18:47:10 +09:00
e8b9b35471
Unify space-adding on gestures.
...
This is much simpler, and more correct.
Bug: 8808497
Change-Id: I7a56bf9d6d9fb481f898b7a9f5898a86c11b34c0
2013-05-07 20:38:09 +09:00
2dbb5957e3
Pass blockOffensiveWords as a parameter
...
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
2013-05-01 20:47:35 +09:00
aa3a96f3a1
Don't do recorrection when suggestions are off.
...
Bug: 8767981
Change-Id: If5c775e488b91ae03ecce2673c99918ac8134928
2013-05-01 10:17:28 +09:00
758c74fe82
Merge "Fix an NPE in recorrection" into jb-mr2-dev
2013-04-19 07:03:19 +00:00
77226ed006
Merge "Fix an NPE in recapitalize" into jb-mr2-dev
2013-04-19 07:01:10 +00:00
ae7d1530b4
Fix an NPE in recorrection
...
Also, theoretically, we don't want to retrieve older suggestions if
there are no results for a recorrection - that would look random.
This bug addresses this too.
Bug: 8657919
Change-Id: I44f36d34a708a968ab71fa0592da57f4c97d4b7f
2013-04-19 15:53:33 +09:00
3bdf341ea0
Fix an NPE in recapitalize
...
Bug: 8657736
Change-Id: I459d1c200826c1c394f8207475ecf60a4f356793
2013-04-19 15:44:20 +09:00
d91268ad9f
Initialize dictionaries at onStartInputView
...
Bug: 8344402
Change-Id: I41b8440f0d72a66fde3f6feb0db8239c9bb10ea3
2013-04-18 14:48:42 +09:00
73ec85b8ad
Don't insert automatic spaces when text looks like a URL
...
This is about as ad-hoc as it gets, but then again, what we want
is probably as ad-hoc as it gets.
All URL boxes I know of double as search bars, and not adding
automatic spaces there sucks (e.g. in Chrome URL bar).
And in other boxes actually you don't want to add a space if
it looks like a URL. QSB isn't even a search box, and it behaves
like this.
So I think this is actually the right answer to the problem.
Bug: 7062925
Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
2013-04-16 18:03:49 +09:00
78d658734d
Merge "Don't recapitalize on shift while on symbol layout"
2013-04-16 05:31:43 +00:00
1f52364630
Don't recapitalize on shift while on symbol layout
...
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
2013-04-16 14:29:02 +09:00
8094bf45d7
Match the keyboard state to the recapitalize state.
...
Bug: 7657025
Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
2013-04-16 14:25:03 +09:00
e259b9f57d
Merge "Clean up RecapitalizeStatus"
2013-04-16 04:57:35 +00:00
fd15686ae9
Merge "Fix an NPE"
2013-04-16 04:12:18 +00:00
b794e904a3
Clean up RecapitalizeStatus
...
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
2013-04-16 13:11:18 +09:00
a024ac6b20
Merge "Fix an NPE"
2013-04-16 03:43:06 +00:00
2b42ad0eaa
Fix an NPE
...
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
2013-04-16 12:20:10 +09:00
7be3ca2ccf
Fix an NPE
...
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
2013-04-16 12:17:22 +09:00
1e5bbe4ce8
Small performance improvement / minor bugfix
...
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.
Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
2013-04-15 21:18:50 +09:00
033958330d
Merge "Have Latin IME re-capitalize a selected string"
2013-04-15 11:29:28 +00:00
2995abe7aa
Have Latin IME re-capitalize a selected string
...
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.
Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
2013-04-15 20:23:01 +09:00
0e9ee4d3bf
If there are no suggestion span, recompute suggestions.
...
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
2013-04-15 19:33:23 +09:00
d40f3f6bc1
Reject a previously user-refused suggestion.
...
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.
Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
2013-04-15 16:36:44 +09:00
2cd1136b8e
Merge "Remove the dialog to insert words to the dictionary."
2013-04-12 12:33:24 +00:00
91bcf5eb5d
Merge "Restart suggestions when the cursor moves."
2013-04-12 12:27:50 +00:00
02ce3dc2d1
Fix a bug with bad application completions
...
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
2013-04-12 20:53:06 +09:00
6a114fa700
Restart suggestions when the cursor moves.
...
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
2013-04-12 20:49:03 +09:00
1a51833828
Remove the dialog to insert words to the dictionary.
...
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
2013-04-12 15:58:50 +09:00
fb3e805722
Merge "Fix a bug where a space would not be inserted before a gesture"
2013-04-10 11:19:31 +00:00
30b8004b56
Fix a bug where a space would not be inserted before a gesture
...
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
2013-04-10 20:10:28 +09:00
ce811f50d2
Use private lock object instead of synchronized method
...
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
2013-04-10 18:27:11 +09:00
19dcd15493
Merge "Offer to add any OOV typed word to the dictionary."
2013-04-09 10:28:47 +00:00
9310f42a36
Offer to add any OOV typed word to the dictionary.
...
That includes gestures, which used not to work.
Bug: 8532637
Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
2013-04-09 12:05:54 +09:00
d117c1a116
Merge "Do not record log split time when handling separator"
2013-04-09 02:31:48 +00:00
636b8c4231
Do not record log split time when handling separator
...
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken. However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word. This change corrects this bug.
Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
2013-04-01 16:48:15 -07:00
0c0ab2b4d9
Merge "Reorder ResearchLogger call"
2013-04-01 15:19:45 +00:00
cb25e1fe37
Reorder ResearchLogger call
...
Previously, ResearchLogger#onWordFinished() was called with an outdated parameter value for
isBatchMode, causing it to report false even for gestures. This changes fixes this problem.
Change-Id: Ifcabee236ba5fe20376ad882155d3f3142cd7613
2013-03-26 14:37:57 -07:00
ef103e1f2e
Merge "Close ResearchLogger upon onFinishInputView"
2013-03-26 19:23:00 +00:00
87bc3a4a62
Close ResearchLogger upon onFinishInputView
...
Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden(). This
resulted in multiple logs being written.
Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.
Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
2013-03-25 17:31:25 -07:00
a17dccbfc6
Fix possible NPE
...
Bug: 8457109
Change-Id: I321fbef53e20a7c36ef4bd9f544b50abe6a52be9
2013-03-25 19:00:38 +09:00
3c8117c88f
Fix appname
...
Bug: 6789579
Change-Id: Ic4694e36e0846af95fa8dcdef919be251983b528
2013-03-22 16:19:44 +09:00
8e005f2989
am 1061bfdb: Break dependencies to allow offdevice tests to build
...
* commit '1061bfdb34bbcb63bf0046eec42313d264ac33fa':
Break dependencies to allow offdevice tests to build
2013-03-19 08:12:50 +00:00
1061bfdb34
Break dependencies to allow offdevice tests to build
...
Change-Id: Ia9a2e8f0672b3f72943f26fb15de1d3c7c5ce7f1
2013-03-19 16:45:25 +09:00
841c295f3c
resolved conflicts for merge of 5b048292 to master
...
Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
2013-03-19 10:48:10 +09:00
9c3860ce46
Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS
...
bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
2013-03-18 23:15:47 +09:00
0b2512017e
am 0ab44b21: Merge "Make isInternal mutable" into jb-mr2-dev
...
* commit '0ab44b21bd6ef5e9fde329b25dfd84f6ca5c0825':
Make isInternal mutable
2013-03-13 17:24:49 +00:00
0ab44b21bd
Merge "Make isInternal mutable" into jb-mr2-dev
2013-03-13 07:41:11 +00:00
756791e6bf
Make isInternal mutable
...
Change-Id: Ib81ceba801be0ac7ef65c4eadd1ec8599e80dacc
2013-03-13 16:28:50 +09:00
2d9b7f60dd
am af37cbb4: Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev
...
* commit 'af37cbb44ef40fcd15fa02456c9abda8021847ce':
Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
2013-03-08 19:24:25 +00:00
c2ee72a214
Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
...
Bug: 8165295
Change-Id: Ie416f6cdb68377f3e06f30e9b6363c38ba2a602d
2013-03-07 10:39:55 -08:00
b094372bd6
Remove MainLogBuffer#setSuggest()
...
multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624
Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
2013-03-01 13:32:11 -08:00
31747ba787
am abaf5827: Separate suggestions from SuggestionView
...
* commit 'abaf5827e7a7f5f6c5d8d98e03e6b9528b0c9351':
Separate suggestions from SuggestionView
2013-03-01 05:17:52 +00:00
abaf5827e7
Separate suggestions from SuggestionView
...
This is a cleanup change, but it's also necessary for
Bug: 8152758
Change-Id: Id6ba06243f573fdb856f87d1df03277c9f2e5e71
2013-02-28 21:03:18 -08:00
7e2c1e69bf
Ensure Preference listener is unregistered
...
Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
2013-02-26 18:40:34 -08:00
4e4f88127b
Fix how the Enter action is decided
...
This unifies the software and hardware keyboard code
under a single decision process that works.
Bug: 8129303
Bug: 8152758
Change-Id: I7574c563d5f957d57bfe62fe5e3eec59a519d335
2013-02-22 16:01:37 -08:00
ce6bcdd1a5
Separate caps mode related utils to CapsModeUtils
...
Change-Id: I32700c434b296bb3fd39e040c2dda1fe90667daf
2013-02-12 18:15:42 +09:00
298b4240f8
Separate IntentUtils from CompatUtils
...
Change-Id: I373ae7ad26eee44cc8e9720314f6a53b811d0021
2013-02-04 16:06:38 -08:00
f3731188e5
[Rlog27] Add replay capability
...
- Add support for replaying log files to the ResearchLogger. This will let
users preview data that they choose to upload.
- When the user explicitly requests that the system record their action, it
will record everything up to, and including, the motion involved in shutting
off the recording. This change also removes the stop-recording motion
commands.
Change-Id: Ib1df383bbf1881512cb111fab9f6749c25e436ba
2013-01-29 09:33:25 -08:00
f77e9d7e3a
Merge "Initialize ResearchLogger later to avoid NPE"
2013-01-25 17:17:34 +00:00
a280e56014
Remove pending update messages upon starting a gesture
...
Bug: 8064307
Change-Id: Ia623ab81b6d12eedc6b20bc4c1ce34ce72d5832f
2013-01-25 17:00:41 +09:00
63bc279596
Initialize ResearchLogger later to avoid NPE
...
Change-Id: I1b817dfbdc319ac9bbf2f08e094a007849ce767f
2013-01-24 11:13:20 -08:00
ff961ddf8c
Add preliminary graphics of sliding key input preview
...
Bug: 7548583
Change-Id: Idde6a62f9e64458055c99c893b71c02d1adc7b04
2013-01-24 18:14:20 +09:00
edb5c4638b
Merge "[Rlog81a] Determine correction type of words"
2013-01-23 17:12:02 +00:00
40651c8cf7
Fix activity flags to launch settings activity
...
This change adds the following flags to the intent to lauch settings activity.
- Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED
- Intent.FLAG_ACTIVITY_CLEAR_TOP
Bug: 8055342
Change-Id: I85284409bbba3fd284442e5ac4c7a55e58ad15ec
2013-01-23 15:08:35 +09:00
0c16a5c6ee
[Rlog81a] Determine correction type of words
...
Heuristic to determine whether a word was a typo correction or a complete
replacement by examining a correction to see if it falls within the list of
suggested words of the original.
Change-Id: Ieec4861a811e96aef0d14622e662b589ef8b4772
2013-01-22 11:41:52 -08:00
08d9c996dc
Merge "[Rlog81b] Log more data with handleSeparator"
2013-01-21 18:48:16 +00:00
8aa9963a89
Fix Apache license comment
...
Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
2013-01-21 22:23:37 +09:00
375982106b
Move PointerTracker.DrawingProxy to MainKeyboardView (step 2)
...
Change-Id: If15d5ee683b8026d1871a3fe438dba498944faa7
2013-01-21 16:09:25 +09:00
80375649d3
[Rlog81b] Log more data with handleSeparator
...
Change-Id: I4b2ebaa2398ac2f669e1e009e00842e55979e866
2013-01-18 11:51:26 -08:00
2fc4d422e7
Deactivate h/w keyboard when not an internal build.
...
The implementation is not really ready yet, so we want to
disable it for normal builds for now.
This goes together with Ic1edc6ed
Bug: 7987492
Change-Id: Id81f417e200c118f24424943823665f0b8bd6849
2013-01-18 20:15:18 +09:00
d5e869ced8
Merge "Track handled events to consistently return handled status (C1)"
2013-01-18 10:49:54 +00:00
976a42b873
Track handled events to consistently return handled status (C1)
...
Bug: 5037589
Change-Id: I92d5be669420f0b2fdeb8fcf85aefd3961bf84b4
2013-01-18 19:32:22 +09:00
81a4b7f48e
Merge "Fix a bug in gesture after a dash or apostrophe"
2013-01-18 08:39:58 +00:00
e3ec5fcc88
Fix a bug in gesture after a dash or apostrophe
...
It would insert a space when it shouldn't when composing a
word ending in either dash or apostrophe and gesturing right
away.
Bug: 7889078
Change-Id: Ib3e2f6f5e551888cc081b464a641e2deac6f5ef7
2013-01-18 15:05:34 +09:00
96845ecff6
Insert into user dict in lower case if auto-caps (D2)
...
Also recapitalize afterwards if the word has been changed.
Bug: 7972124
Change-Id: I9306580bb4ed0ffa80cc4559ce1abcd2034d1905
2013-01-17 20:38:52 +09:00
c665cbee7f
Merge "Forward the capitalized mode to the positional info (D1)"
2013-01-17 11:02:00 +00:00
ae3b96b26e
Simplify the space-before and space-after logic.
...
Bug: 7889078
Bug: 7268000
Change-Id: I6c77b8c9e60ef69f02526b407124d2f5d02818ee
2013-01-17 17:52:46 +09:00
b6b7f5e39e
Forward the capitalized mode to the positional info (D1)
...
Bug: 7972124
Change-Id: I3c74f3b075e698b9e9dd1d2c7b6f173073539063
2013-01-17 14:35:58 +09:00
d818f1e3b6
Stop relying on the soft keyboard to get the editor action.
...
Bug: 7969231
Change-Id: I9848c63c4c51550b5dc53c981eafa74e7fa95197
2013-01-16 18:22:00 +09:00
9579936bcf
[Rlog67] Renaming clarification
...
ResearchLogger.latinIME_handleSeparator wasn't doing anything really specific to
the separator, so its implementation has been renamed according to its role.
Change-Id: I24e8691c7dc440dd067e96d23e50463683e17cfc
2013-01-15 08:57:52 -08:00
dcfceaff1b
Distinguish action-enter/shift-enter/enter
...
Bug: 7969231
Change-Id: I75d495ee1ea126da9be4e269ee990ee0a97793c1
2013-01-15 19:12:41 +09:00
5b611e184b
Merge "[Rlog63] Log whether a manual suggestion is a prediction"
2013-01-14 09:30:12 -08:00
939e3f3152
Merge "[Rlog59d] Pass separatorString through revertCommit"
2013-01-14 08:59:04 -08:00
31156c816e
[Rlog59d] Pass separatorString through revertCommit
...
Change-Id: I5ef20476318979f99f543f9300cf6198d18f6244
2013-01-14 07:01:49 -08:00
ef3936bc54
[Rlog59c] More detailed logging of backspace
...
- Normal delete events are recorded
- Includes number of characters deleted for both batch and normal delete
Change-Id: I422da3ddc94fa0ccd6c7586eaacf14c62dd16679
2013-01-12 12:54:59 -08:00
343a852cd9
Merge "[Rlog59b] Log CodeInput and KeyCode properly"
2013-01-12 10:18:57 -08:00
3338703a2f
[Rlog63] Log whether a manual suggestion is a prediction
...
Change-Id: Ia6f793611d4b18aecb1a635655af5edb639e1ecf
2013-01-11 09:55:09 -08:00
99931201d0
[Rlog59b] Log CodeInput and KeyCode properly
...
- Fix function calls to happen at more resilient times
- In the case of phantom spaces, ensure that the logStatement goes to the
correct logUnit
Change-Id: Ida8f6eba1e4f33d9f9b4735316e3c6316ed316c0
2013-01-10 23:39:11 -08:00
90aaa2d0a5
[Rlog59a] Split logUnits correctly around separators
...
Change-Id: I65ecdead7e7bdeb8a5f1748e27068ddbd5d3ce00
2013-01-10 16:36:18 -08:00
75e69753b7
[Rlog57b] fix logging of reverts
...
Change-Id: I07c817061a0cc060197e0fea45195ca07a9bf276
2013-01-10 15:00:28 -08:00
50d902ac6f
Show final suggested word when batch input is finished
...
This change moves dismiss timer of gesture floating preview text from
PreviewPlacerView to KeyboardView.
Bug: 7967461
Change-Id: I0ca5beddc93cb4bc4a405f914d217d37b997402b
2013-01-10 16:25:05 +09:00
f11c4a9aeb
Merge "[Rlog50] capture bigrams properly even with deletions"
2013-01-09 19:52:45 -08:00
3727a3fd61
Merge "Clean up public helper methods of SettingsValues"
2013-01-09 19:04:46 -08:00
3b95eaf70b
[Rlog50] capture bigrams properly even with deletions
...
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0
Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
2013-01-09 16:02:37 -08:00
516b63db28
Fix a race condition with backspaces
...
And add a test to make sure it stays not-broken.
Bug: 7946604
Change-Id: I996da3d5507d591ec25a13fb57434f39843f1df5
2013-01-09 18:37:10 +09:00
d3b0ecec22
Clean up public helper methods of SettingsValues
...
Change-Id: I6c6087580b67f497eaaf16900f8df7a4a895b8e3
2013-01-09 11:23:34 +09:00
9bad176ebe
Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly"
2013-01-08 08:10:31 -08:00
b7fb16e8cc
Merge "[Rlog27] Refactor LogBuffer"
2013-01-08 07:40:57 -08:00
ff0735ada8
Make Settings class singleton to manage SettingsValues
...
Change-Id: Id30828a141de86d9bcf8bce586d2adb468cc59e1
2013-01-08 17:48:47 +09:00
b17b887425
Consolidate VibratorUtils with AudioAndHapticFeedbackManager
...
Change-Id: Ica4e3193f369330da62a259c718b779ddf9fbde5
2013-01-08 15:13:19 +09:00
99f3189645
[Rlog32] ResearchLogger segment motion data around gestures correctly
...
multi-project commit with I684ba5fed8c653777942e6b0366113ca40dfa37c
Change-Id: Id3804e6cfa97b4cdde212b8eebc413f76fa4772c
2013-01-07 20:06:29 -08:00
28de7223e6
Merge "[mdfp] Refactoring Gesture Floating Preview Text Code"
2013-01-07 17:12:35 -08:00
d52730a2d7
[mdfp] Refactoring Gesture Floating Preview Text Code
...
This change moves gesture preview text code from PreviewPlacerView.java
to separate classes.
Change-Id: Id8d17eff38e714c3b06aafd0b24985a9bd2d2f52
2013-01-07 10:39:23 -08:00
f90fc105ab
Simplify singleton class initialization
...
Change-Id: I16a27f2ed6ea66184bfdc9903180372cd7ea2fd1
2013-01-07 19:05:31 +09:00
b6ca354431
Small code cleanups
...
Multi-project commit with I249d5fbe
Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
2013-01-07 12:13:42 +09:00
f677681330
Fix double input of chars typed on a h/w keyboard
...
Bug: 7939324
Change-Id: I11b7af54893cb645f8a06266a0b0ba95dd0b02f9
2013-01-07 10:03:20 +09:00
f77dd424b0
[Rlog27] Refactor LogBuffer
...
Cleanup and prepare for replaying
Change-Id: Ie09e912c6e9c0d7375168c575ccf1cfd9375dd31
2013-01-03 16:36:32 -08:00
864db4b0da
A small simplification.
...
It's useless to setAutoCorrection(getTypedWord()). Every time the
contents of the word composer are altered, the auto-correction is
reset, and at use time if it's null then the typed word is used
anyway.
Change-Id: I0870657a1ab3f456f376995b27e70703f7a5d23a
2012-12-28 14:41:28 +09:00
997cba7dec
Start committing hardware events (B4)
...
Essentially this does activate auto-correction with a hardware
keyboard, although a lot of things are still left to implement.
No proximity is used yet which means only missing and excessive
letters are considered. Dead keys are not handled. No combiner
is supported. No suggestions are displayed. Resuming suggestions
does not work correctly with a hardware key (because the view
holds a temporary hardware event 'onKeyPreIme' and the event
from the IME won't be handled until this is handled which won't
happen until after the IME said that it did handle the event).
Bug: 5037589
Change-Id: Idcb5c7b26d56717ed772d53c062362807f11cdae
2012-12-27 16:17:49 +09:00
f483225397
Get rid of current subtype and system locale cache from SubtypeSwitcher
...
Bug: 7675452
Change-Id: I2121f56964b6d25e8d40f5b8ec67eeae527b2117
2012-12-27 12:00:38 +09:00
4aff3bf0ea
Clean up unnecessary uses of toString()
...
Leftover from changing variables from CharSequence to String
Change-Id: I4db43fcb075aa37bf9c5b2a23bad0e4c2d718379
2012-12-23 18:42:06 -08:00
f763dc5915
[Rlog24] ResearchLogger detect word boundaries in callers above commitText
...
multi project commit with I5847d4aba97a7224ae170a7153811c5a11816449
Change-Id: Ie6fbf6f19f0193451fe6f3ddf9d4ef1637a35db1
2012-12-23 12:33:16 -08:00
13b1be988d
Merge "Log LatinIME.commitCurrentAutoCorrection()"
2012-12-23 11:47:47 -08:00
226377e65a
Log LatinIME.commitCurrentAutoCorrection()
...
Change-Id: Ic46c91374ae0177cafad4579d28d6980af0d8d3a
2012-12-22 17:32:12 -08:00
ab9f4fd359
Merge "[Rlog7] ResearchLog improve gesture tracking"
2012-12-22 11:50:46 -08:00
Jean Chalard
Tadashi G. Takaoka
Ken Wakasa
Keisuke Kuroyanagi
Satoshi Kataoka
Alan Viverette
Yuichiro Hanada
Kurt Partridge
Svetoslav Ganov
Xiaojun Bi