nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30173 commits 1 branch 0 tags 363 MiB
Commit graph

6467 commits

Author SHA1 Message Date
Jean Chalard
5b9e54c135 Merge "[IL88] Simple refactoring" 2014-01-27 11:17:54 +00:00
Jean Chalard
8f3e37a631 Merge "[IL87] Remove a call to clearSuggestionStrip" 2014-01-27 11:17:45 +00:00
Jean Chalard
521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard
7aa7e36611 Merge "[IL85] Maybe show punctuations when app completions are null" 2014-01-27 11:17:18 +00:00
Jean Chalard
264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard
7ac542d490 Merge "[IL83] Inline a call" 2014-01-27 11:16:30 +00:00
Jean Chalard
47ff423121 Merge "[IL82] Fix a wrong comment" 2014-01-27 10:11:42 +00:00
Jean Chalard
75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka
c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method 
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
 2014-01-27 19:05:16 +09:00
Jean Chalard
6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard
b084da2ae6 Merge changes I5092942a,I931c553f 
* changes:
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
 2014-01-27 10:00:37 +00:00
Jean Chalard
a3a85e8c2b Merge "[IL78] Move most of onUpdateSelection to InputLogic." 2014-01-27 09:55:08 +00:00
Jean Chalard
d38b0468b0 [IL90] Small refactoring 
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
 2014-01-27 18:42:33 +09:00
Jean Chalard
33ff321d6c [IL89] Inline a function 
We will then refactor the contents of showSuggestionStripWithTypedWord

Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
 2014-01-27 18:42:33 +09:00
Jean Chalard
ca819178a1 [IL88] Simple refactoring 
With this, the value passed to suggestedWords is never null.

Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
 2014-01-27 18:42:33 +09:00
Jean Chalard
d90bdd2187 [IL87] Remove a call to clearSuggestionStrip 
The goal is to remove the function completely.

Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
 2014-01-27 18:42:33 +09:00
Jean Chalard
3b939ed77f [IL86] Simplification and correctness fix. 
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
 2014-01-27 18:42:33 +09:00
Jean Chalard
07eddf3c43 [IL85] Maybe show punctuations when app completions are null 
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.

Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
 2014-01-27 18:42:32 +09:00
Jean Chalard
b2c0388a69 [IL84] Remove a useless call and rename a method 
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
 2014-01-27 18:42:32 +09:00
Jean Chalard
eb190ab32f [IL83] Inline a call 
The coming string of changes is very complicated, so
I'm going to do things really slowly.

Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
 2014-01-27 18:42:32 +09:00
Jean Chalard
17f1528f9e [IL82] Fix a wrong comment 
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
 2014-01-27 18:42:32 +09:00
Jean Chalard
abbd755689 [IL81] Remove a useless test. 
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
 2014-01-27 18:42:32 +09:00
Jean Chalard
f1e5b9b4d1 [IL80] Reverse a test for clarity. 
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
 2014-01-27 18:42:32 +09:00
Jean Chalard
f59487379e [IL79] Some refactoring 
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
 2014-01-27 18:42:29 +09:00
Jean Chalard
10460441db [IL78] Move most of onUpdateSelection to InputLogic. 
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
 2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka
1e4b1300e6 Merge "Refactor SuggestionsStripLayoutHelper class" 2014-01-27 09:36:52 +00:00
Jean Chalard
68d7291a6b Merge "[IL77] Remove refs to Settings from InputLogic" 2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka
148dedbc5d Refactor SuggestionsStripLayoutHelper class 
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
 2014-01-27 18:25:25 +09:00
Jean Chalard
7bee84095e Merge "[IL75] Move the SubtypeSwitcher out of InputLogic." 2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka
829ad708db Merge "Revert "Use ViewCompat support library"" 2014-01-27 09:20:19 +00:00
Jean Chalard
48df380f78 [IL77] Remove refs to Settings from InputLogic 
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
 2014-01-27 18:18:54 +09:00
Jean Chalard
969c06072d [IL75] Move the SubtypeSwitcher out of InputLogic. 
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
 2014-01-27 18:18:27 +09:00
Jean Chalard
c7ef305bbc Try to figure out whether d.quotes open or close. 
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
 2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka
e4692c0050 Revert "Use ViewCompat support library" 
This reverts commit e7ee4fa862.

Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
 2014-01-27 18:14:40 +09:00
Jean Chalard
5cf70a1d44 Merge "[IL74] Remove unused/unwanted arguments to a method." 2014-01-27 08:57:12 +00:00
Yohei Yukawa
0b58617951 Merge "Fix inconsistent behavior with backspace in the Emoji pallete." 2014-01-27 08:11:51 +00:00
Jean Chalard
0fd556ceca [IL74] Remove unused/unwanted arguments to a method. 
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
 2014-01-27 16:48:17 +09:00
Yohei Yukawa
ea8c1c811c Fix inconsistent behavior with backspace in the Emoji pallete. 
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
  the key.

This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
  different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
  key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
  subsequent delete key events when the finger is moved away
  from the key area.

Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
 2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka
f3ca92dd33 Merge "Use ViewCompat support library" 2014-01-27 07:21:41 +00:00
Tadashi G. Takaoka
e7ee4fa862 Use ViewCompat support library 
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
 2014-01-27 16:11:03 +09:00
Ken Wakasa
03283b636c Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939 
some cleanups as well

Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
 2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi
95043145df Merge "Check length of words for personalization dict." 2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi
b7197b705b Check length of words for personalization dict. 
Bug: 12602903

Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
 2014-01-24 16:32:28 -08:00
Ken Wakasa
0acd121083 Fix wrong indents. 
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
 2014-01-24 23:55:33 +09:00
Jean Chalard
b6e128cc05 Merge "[IL69.1] Move a static method to a utility class." 2014-01-24 03:04:12 +00:00
Jean Chalard
1d6e647ac3 [IL69.1] Move a static method to a utility class. 
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
 2014-01-24 11:59:23 +09:00
Jean Chalard
0c72529088 Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer" 2014-01-24 01:55:57 +00:00
Jean Chalard
3aa2043a66 Merge "[IL76] Remove a SuggestionStripView dependency" 2014-01-23 10:06:42 +00:00
Jean Chalard
f16a2a36d2 [IL71.1] Add some javadoc. 
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
 2014-01-23 17:11:47 +09:00
Jean Chalard
a1ed211c4e [IL76] Remove a SuggestionStripView dependency 
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
 2014-01-23 16:25:48 +09:00
Jean Chalard
4173610bc5 [IL66.1] Add a comment 
Followup to IL66

Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
 2014-01-23 16:00:49 +09:00
Jean Chalard
be846fc352 [IL73] Remove all refs to Key and Keyboard in WordComposer 
Please hold my gun while I have this nice cup of tea.
Yes !!

Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
 2014-01-23 15:52:29 +09:00
Jean Chalard
df8310c6e2 Merge "[IL71] Add indices to toCodePointArray." 2014-01-23 06:50:19 +00:00
Jean Chalard
1284e556f4 [IL70] Remove unused arguments 
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
 2014-01-23 15:33:14 +09:00
Jean Chalard
d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord 
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
 2014-01-23 15:32:59 +09:00
Jean Chalard
9da4b49ef6 [IL68] Start refactoring setComposingWord 
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
 2014-01-23 15:15:49 +09:00
Jean Chalard
18638d30c0 [IL71] Add indices to toCodePointArray. 
This is necessary for tests

Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
 2014-01-23 13:11:40 +09:00
Jean Chalard
eb6d41a525 [IL67] Externalize a call to the keyboard switcher 
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
 2014-01-23 13:10:02 +09:00
Jean Chalard
ab80b41a0d [IL66] Remove two accesses to KeyboardSwitcher. 
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
 2014-01-23 13:09:58 +09:00
Jean Chalard
a91dfff5e5 [IL65] Pull up X,Y processing, step 4 
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.

Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
 2014-01-22 14:44:27 +09:00
Jean Chalard
352286a43b [IL64] Pull up X,Y processing, step 3 
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
 2014-01-22 14:44:25 +09:00
Jean Chalard
b8216a4e7e [IL63] Pull up X,Y processing, step 2 
This also fixes the coordinates passed to logOnDelete and
log onSeparator.

Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
 2014-01-22 14:42:52 +09:00
Jean Chalard
2b38b5e8e6 [IL62] Pull up X,Y processing, step 1 
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.

However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.

Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
 2014-01-22 14:41:45 +09:00
Jean Chalard
591580ee8a Merge "[IL61] Remove an internal use of key coordinates" 2014-01-22 05:19:45 +00:00
Tadashi G. Takaoka
c93cf1c398 Use sorted int[] to represent word separators 
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
 2014-01-20 19:40:02 +09:00
Tadashi G. Takaoka
5b6ebdbe9e Merge "Refactor logic to retrieve relevant suggestions a bit" 2014-01-20 09:57:43 +00:00
Tadashi G. Takaoka
837cdd738b Add SpacingAndPunctuationsTests 
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
 2014-01-20 18:33:45 +09:00
Tadashi G. Takaoka
3033cc51b8 Refactor logic to retrieve relevant suggestions a bit 
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
 2014-01-20 12:08:25 +09:00
Keisuke Kuroyanagi
3f3b0af5b7 Merge "Fix unit tests by adding @UsedForTesting" 2014-01-19 22:47:03 +00:00
Keisuke Kuroyanagi
fde4c5f128 Fix unit tests by adding @UsedForTesting 
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
 2014-01-19 13:37:23 -08:00
Keisuke Kuroyanagi
b1814c9633 Merge "Make contacts dict and user dict version 4." 2014-01-17 20:05:17 +00:00
Keisuke Kuroyanagi
ed95d79cc4 Make contacts dict and user dict version 4. 
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
 2014-01-17 10:30:16 -08:00
Tadashi G. Takaoka
6a18af634e Refactor RichInputConnection a bit 
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
 2014-01-17 13:14:29 +09:00
Jean Chalard
2334bf6d8c Merge "Fix a bug specific to German capitalization." 2014-01-17 01:49:14 +00:00
Jean Chalard
e4f584de73 Merge "[IL60] Make InputLogicHandler package private" 2014-01-16 18:15:15 +00:00
Jean Chalard
87f87d9ac5 Merge "[IL59] Rename a method" 2014-01-16 18:13:39 +00:00
Jean Chalard
9c9c43c0b7 Merge "[IL58] Simplification" 2014-01-16 17:45:59 +00:00
Keisuke Kuroyanagi
f4bf620502 Merge "Add a dedicated method to control time in native code." 2014-01-16 17:25:29 +00:00
Jean Chalard
ab4543d593 [IL61] Remove an internal use of key coordinates 
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
 2014-01-17 02:10:56 +09:00
Jean Chalard
81255612bc [IL60] Make InputLogicHandler package private 
Yay

Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
 2014-01-17 02:10:56 +09:00
Jean Chalard
17bd129faf [IL59] Rename a method 
Um... this is not async ? Remove that from the name

Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
 2014-01-17 02:10:56 +09:00
Jean Chalard
ac6dfaf80b [IL58] Simplification 
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.

Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
 2014-01-17 02:10:51 +09:00
Jean Chalard
60afa7000f Fix a bug specific to German capitalization. 
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
 2014-01-17 02:06:24 +09:00
Keisuke Kuroyanagi
9e882e3937 Merge "Update personalization dict via dictionary facilitator." 2014-01-16 02:00:21 +00:00
Keisuke Kuroyanagi
12474634c5 Update personalization dict via dictionary facilitator. 
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
 2014-01-15 17:54:17 -08:00
Keisuke Kuroyanagi
d78a447d10 Add a dedicated method to control time in native code. 
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
 2014-01-15 14:55:57 -08:00
Jean Chalard
2c1a13c56c Merge "[IL57] Don't require a main dict suggestion." 2014-01-15 22:14:27 +00:00
Jean Chalard
118a4fc2b7 Merge "[IL56] Don't erase suggestions when reverting a commit." 2014-01-15 19:21:06 +00:00
Jean Chalard
e22e67e37a [IL57] Don't require a main dict suggestion. 
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.

Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
 2014-01-16 03:22:51 +09:00
Jean Chalard
4752b68f5a [IL56] Don't erase suggestions when reverting a commit. 
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
 2014-01-16 03:22:46 +09:00
Tadashi G. Takaoka
20a8a4a3d9 Fix native method signature 
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
 2014-01-15 18:56:40 +09:00
Tadashi G. Takaoka
01c1a1a2ba Refactor LanguageModelParam class a bit 
This change must be checked in together with I9ecfd1adc1.

Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
 2014-01-15 17:46:32 +09:00
Tadashi G. Takaoka
17a2bcfcce Make final Locale field public 
This change must be checked in together with Id9382498a8.

Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
 2014-01-15 17:11:54 +09:00
Tadashi G. Takaoka
b8a2772b0e Consolidate LanguageModelParam constructors 
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
 2014-01-15 16:17:53 +09:00
Tadashi G. Takaoka
7b9b095090 Move LanguageModelParams class to utility package 
This change must be checked in together with Ic82d951237.

Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
 2014-01-15 16:14:53 +09:00
Keisuke Kuroyanagi
68069c55c4 Fix flaky unit test. 
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
 2014-01-14 18:51:29 -08:00
Tadashi G. Takaoka
bf418f7cba Pass time stamp to addToUserHistory method as an argument 
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
 2014-01-14 15:48:08 +09:00
Keisuke Kuroyanagi
5717c63a2b Fix possible NPE in DictionaryFacilitatorForSuggest. 
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
 2014-01-10 21:42:08 +09:00
Jean Chalard
db0adf86a4 Merge "[IL55] Remove a useless argument." 2014-01-10 11:36:01 +00:00
Keisuke Kuroyanagi
eb66f1906d Merge "Check corpus handles during startup for personalization." 2014-01-10 11:34:39 +00:00
Jean Chalard
6c24b91601 [IL55] Remove a useless argument. 
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
 2014-01-10 20:28:50 +09:00
Keisuke Kuroyanagi
eb28bac542 Check corpus handles during startup for personalization. 
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
 2014-01-10 20:28:30 +09:00
Jean Chalard
4be9137609 Merge "[IL54.5] Use the cursor pos estimate, not the last value" 2014-01-10 10:46:27 +00:00
Jean Chalard
a224aafea3 [IL54.5] Use the cursor pos estimate, not the last value 
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.

Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
 2014-01-10 19:08:47 +09:00
Keisuke Kuroyanagi
f96e0f07af Merge "Periodic wipe of the personalization dict." 2014-01-10 09:31:22 +00:00
Keisuke Kuroyanagi
ba07df7fc1 Periodic wipe of the personalization dict. 
Bug: 12216453

Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
 2014-01-10 16:30:59 +09:00
Jean Chalard
ecf46df226 [IL54] Add a mirror method to fix the cursor pos estimate 
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.

Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
 2014-01-10 16:05:02 +09:00
Jean Chalard
6fbe83be7a [IL53] Fix a wrong test. 
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.

When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.

The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.

Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
 2014-01-10 15:21:20 +09:00
Jean Chalard
958e452025 Merge "Fix an NPE." 2014-01-10 05:13:47 +00:00
Jean Chalard
e1de87ae69 Fix an NPE. 
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
 2014-01-10 13:46:37 +09:00
Jean Chalard
84a3047e80 Fix build. 
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
 2014-01-10 12:18:26 +09:00
Tadashi G. Takaoka
ee35e69eae Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion 
This change must be checked in together with Iec437d6df0.

Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
 2014-01-09 19:05:09 +09:00
Tadashi G. Takaoka
494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords 
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
 2014-01-09 18:33:25 +09:00
Tadashi G. Takaoka
d7660c6f56 Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode" 2014-01-09 09:31:32 +00:00
Tadashi G. Takaoka
c912b2228a Merge "Add American typography boolean to SpacingAndPunctuations" 2014-01-09 09:31:24 +00:00
Tadashi G. Takaoka
0a75cf51af Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode 
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
 2014-01-09 18:19:17 +09:00
Tadashi G. Takaoka
860c3b8e8c Add American typography boolean to SpacingAndPunctuations 
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
 2014-01-09 18:17:29 +09:00
Yohei Yukawa
6c326caa4f A style fix 
Just a style fix to follow up the previous commit.

BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
 2014-01-09 15:54:47 +09:00
Keisuke Kuroyanagi
b30f7e4bce Merge "Check whether the word is OOV or not for amanatto update." 2014-01-09 06:24:17 +00:00
Jean Chalard
eab4d25210 Merge "Remove some warnings" 2014-01-09 05:45:10 +00:00
Yohei Yukawa
c1f2986a72 Merge "Trigger haptic feedback at touch down on the EmojiPalettesView" 2014-01-09 05:19:37 +00:00
Jean Chalard
b11339b3ab Remove some warnings 
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
 2014-01-09 14:04:34 +09:00
Jean Chalard
d3e78fc5ce Merge "Fix a bug where changing auto-shift would cancel autorepeat." 2014-01-09 04:53:34 +00:00
Jean Chalard
5cbda70956 Fix a bug where changing auto-shift would cancel autorepeat. 
Bug: 12453966
Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
 2014-01-09 12:57:10 +09:00
Yohei Yukawa
df10aeb1da Trigger haptic feedback at touch down on the EmojiPalettesView 
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down.
This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts.

This patch set also fixes the missing haptic feedback from facemarks such as ":-)".

Bug: 11439600
Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
 2014-01-09 12:27:31 +09:00
Keisuke Kuroyanagi
05113c1847 Check whether the word is OOV or not for amanatto update. 
Bug: 11736529
Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
 2014-01-08 21:02:35 +09:00
Keisuke Kuroyanagi
5742a415f3 Merge "Make reloadMainDict() private." 2014-01-08 11:03:02 +00:00
Keisuke Kuroyanagi
9f1fe87580 Make reloadMainDict() private. 
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
 2014-01-08 18:59:43 +09:00
Jean Chalard
b90fa0fb2c Revert "Revert "Separate spacing and punctuation related settings values"" 
This reverts commit 8bc427799a.

Change-Id: I34f509998afdb1a7c120fbfdb9f0a1b188224a4d
 2014-01-08 18:08:01 +09:00
Jean Chalard
e5cdcaff65 Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
 2014-01-08 18:04:44 +09:00
Jean Chalard
1e7f2809d2 Merge "Revert "Separate spacing and punctuation related settings values"" 2014-01-08 09:03:15 +00:00
Jean Chalard
8bc427799a Revert "Separate spacing and punctuation related settings values" 
This is conflicting with later changes. Temporary revert for cherry-pick.

This reverts commit 0b593ce858.

Change-Id: Id53eadb023a950cfcca496c0cfbfe583c7ec7b8c
 2014-01-08 09:00:45 +00:00
Jean Chalard
d4843c25e2 Merge "Revert "Fix a race condition, take 2."" 2014-01-08 09:00:18 +00:00
Jean Chalard
a247264dc6 Revert "Fix a race condition, take 2." 
Conflicts prevent this to be cherry-picked.

This reverts commit dd3d697a6e.

Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
 2014-01-08 08:59:26 +00:00
Jean Chalard
ff7103d356 Merge "Fix a race condition, take 2." 2014-01-08 08:35:24 +00:00
Jean Chalard
0a0a3cdad8 Merge "Revert "Revert "Fix a race condition.""" 2014-01-08 08:35:19 +00:00
Jean Chalard
dd3d697a6e Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
 2014-01-08 17:19:29 +09:00
Jean Chalard
f628629f69 Revert "Revert "Fix a race condition."" 
This reverts commit 3840127244.

Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
 2014-01-08 16:44:43 +09:00
Tadashi G. Takaoka
ad78058a93 Rename InputPointers.addPointer and ResizableIntArray.add 
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
e13cc9d7e5 Fix ResizableIntArrayTests readability 
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
9b351f7594 Merge "Fix InputPointersTests" 2014-01-08 05:29:32 +00:00
Tadashi G. Takaoka
e7dc5302af Fix InputPointersTests 
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.

Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
 2014-01-08 14:14:42 +09:00
Keisuke Kuroyanagi
b3c51630a6 Fix: NPE in LatinIME.loadSettnigs(). 
Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
 2014-01-08 12:43:58 +09:00
Tadashi G. Takaoka
385031557b Merge "Separate spacing and punctuation related settings values" 2014-01-08 02:41:51 +00:00
Tadashi G. Takaoka
0b593ce858 Separate spacing and punctuation related settings values 
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
 2014-01-08 10:02:37 +09:00
Keisuke Kuroyanagi
c09fd175c3 Prepare using dictionaryFacilitator for amanatto updates. 
Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
 2014-01-07 18:11:23 +09:00
Keisuke Kuroyanagi
55713e3695 Update personalized dict only when single subtype is used. 
Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
 2014-01-07 18:10:27 +09:00
Keisuke Kuroyanagi
8214a8c2cf Fix possible NPE. 
Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
 2014-01-06 17:56:49 +09:00
Tadashi G. Takaoka
3f8c6b8c54 Merge "Add description of disabled voice input key option" 2014-01-06 03:25:15 +00:00
Tadashi G. Takaoka
12ba821bfb Add description of disabled voice input key option 
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
 2014-01-06 12:11:55 +09:00
Tadashi G. Takaoka
e91559a119 Merge "Update shortcut IME info before checking availability of it" 2014-01-06 03:07:23 +00:00
Tadashi G. Takaoka
e9584a1612 Merge "Add DictionaryFacilitatorForSuggest constructor for testing" 2014-01-06 02:58:12 +00:00
Tadashi G. Takaoka
b7c531b751 Update shortcut IME info before checking availability of it 
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
 2014-01-06 11:54:46 +09:00
Tadashi G. Takaoka
49b5fadae1 Add DictionaryFacilitatorForSuggest constructor for testing 
This change must be checked in together with I00b6e79d6b.

Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
 2014-01-06 11:00:51 +09:00
Jean Chalard
1e50c681af [IL52] Remove a useless method. 
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.

Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.

Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
 2013-12-27 22:40:19 +09:00
Jean Chalard
8ce921dd6b [IL51] Make private what can be made private 
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
 2013-12-27 21:09:47 +09:00
Jean Chalard
53c320e275 [IL50] Move the InputUpdater out of LatinIME. 
...at last

Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
 2013-12-27 21:09:41 +09:00
Jean Chalard
81e0ca5fd3 [IL49] Move InputLogic-related init code to InputLogic. 
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
 2013-12-27 20:06:39 +09:00
Jean Chalard
4970eda286 Fix a failing test 
How/when did this happen? How was it not noticed?

Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
 2013-12-27 20:04:41 +09:00
Jean Chalard
d05ea8bd82 Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic." 2013-12-27 08:06:48 +00:00
Jean Chalard
af26a44102 Merge "[IL47] Inline getSuggestedWordsGestureLocked" 2013-12-27 08:04:51 +00:00
Jean Chalard
51e79fb4b2 Merge "[IL46] Remove a useless message passing." 2013-12-27 07:56:56 +00:00
Jean Chalard
2fc1cc099f Merge "[IL45] Remove lingering messages" 2013-12-27 07:56:44 +00:00
Jean Chalard
c654fe57b1 [IL48] Move onEndBatchInputAsyncInternal to InputLogic. 
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
 2013-12-27 16:50:08 +09:00
Jean Chalard
4a144b9b4d [IL47] Inline getSuggestedWordsGestureLocked 
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.

Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
 2013-12-27 16:50:08 +09:00
Jean Chalard
71a3e96382 [IL46] Remove a useless message passing. 
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords

The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.

Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
 2013-12-27 16:50:06 +09:00
Jean Chalard
0d21223521 Merge "[IL44] Some factorization" 2013-12-27 06:58:12 +00:00
Jean Chalard
31ff2a4335 [IL45] Remove lingering messages 
Bug: 8636060
And possibly bug: 12085864

Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
 2013-12-27 15:34:30 +09:00
Jean Chalard
69e7a0d24d [IL44] Some factorization 
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.

Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
 2013-12-27 15:34:26 +09:00
Keisuke Kuroyanagi
c197b9ed90 Merge "Make setAdditionalDictionaries private." 2013-12-27 06:22:18 +00:00
Keisuke Kuroyanagi
86da47e8d7 Fix possible NPE in FileUtils. 
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
 2013-12-27 14:58:38 +09:00
Keisuke Kuroyanagi
abc3d0eb56 Make setAdditionalDictionaries private. 
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
 2013-12-27 14:49:32 +09:00
Jean Chalard
6bca9ac43d Fix a bug where predictions would not pop upon manual pick 
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
 2013-12-26 23:19:29 +09:00
Jean Chalard
33b2aaafc2 Merge "Fix a code path that looks ridiculous" 2013-12-26 13:39:21 +00:00
Jean Chalard
f294ed3308 Fix a code path that looks ridiculous 
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
 2013-12-26 22:28:16 +09:00
Jean Chalard
f441047fad [IL43] Small cleanup 
All calls are already passing this

Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
 2013-12-26 22:12:24 +09:00
Jean Chalard
c28f02880c [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync 
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
 2013-12-26 22:12:22 +09:00
Jean Chalard
70433efc41 [IL41] Remove a useless call and trampoline. 
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.

Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
 2013-12-26 21:58:41 +09:00
Keisuke Kuroyanagi
be147f1fdc Remove DictionaryFacilitatorForSuggest.getMainDictionary(). 
Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
 2013-12-26 20:48:19 +09:00
Keisuke Kuroyanagi
a374482719 Extract dict operations from Suggest to a new class. 
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
 2013-12-26 20:48:19 +09:00
Jean Chalard
5c45ff1214 [IL39] Change a test. 
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.

Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
 2013-12-26 18:44:17 +09:00
Jean Chalard
98140faac3 [IL38] Fix a wrong double call 
This only gives bad results if a gesture results in only one suggestion.

Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
 2013-12-26 18:43:47 +09:00
Keisuke Kuroyanagi
65e3ae6f15 Merge "Remove useless method call for spell checker." 2013-12-26 06:42:51 +00:00
Keisuke Kuroyanagi
7987afbea4 Remove useless method call for spell checker. 
Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
 2013-12-26 14:51:05 +09:00
Tadashi G. Takaoka
3fbcf48591 Merge "Add BatchInputArbiter" 2013-12-26 05:50:07 +00:00
Tadashi G. Takaoka
4a4b6d42a7 Add BatchInputArbiter 
Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.

This change must be checked in together with Ia7db8f4fb7.

Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
 2013-12-26 14:09:57 +09:00
Jean Chalard
30a72da42c [IL37] Small simplification 
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
 2013-12-26 13:51:09 +09:00
Jean Chalard
c08119e5c1 [IL36] Inline setAutoCorrection 
There are far too many one-use methods.

Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
 2013-12-26 13:18:36 +09:00
Jean Chalard
52a2682b99 [IL35] Preparative cleanup 
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
 2013-12-25 22:25:49 +09:00
Jean Chalard
0154609a2e Merge "[IL34] Introduce InputLogicHandler" 2013-12-25 13:21:54 +00:00
Keisuke Kuroyanagi
5c4bd20331 Remove "Boost personalization dictionary" from settings. 
Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
 2013-12-25 19:02:49 +09:00
Keisuke Kuroyanagi
bb39518bd7 Use SettingsValues instead of Settings in Suggest. 
Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
 2013-12-25 18:53:04 +09:00
Tadashi G. Takaoka
d99d225f10 Merge "Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints" 2013-12-25 06:58:08 +00:00
Keisuke Kuroyanagi
eea7122e5b Move dict operations to Suggest. 
Bug: 8187060

Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
 2013-12-25 15:26:50 +09:00
Tadashi G. Takaoka
c3fe1425a5 Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints 
This change must be checked in together with Ibed5330614.

Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace
 2013-12-25 15:19:00 +09:00
Jean Chalard
621dcbc31c [IL34] Introduce InputLogicHandler 
Bug: 8636060
Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f
 2013-12-25 14:20:19 +09:00
Keisuke Kuroyanagi
605caf1b5f Fix NPE in SettingsValues. 
Change-Id: I96fc381d2b45881aeb342d33207cd7fe82f5077c
 2013-12-25 14:00:16 +09:00
Tadashi G. Takaoka
a801c8fd9b Merge "Rename gesture related classes" 2013-12-25 04:04:05 +00:00
Tadashi G. Takaoka
e2a6253cb5 Rename gesture related classes 
Change-Id: I5cb03576bb7221f1864e157857d872880a0a58f8
 2013-12-25 11:52:54 +09:00
Keisuke Kuroyanagi
f1457e7a22 Remove personalized dicts when the option is turned off. 
Bug: 11757851

Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f
 2013-12-25 11:44:16 +09:00
Tadashi G. Takaoka
afca1ddd23 Comprehensive memory deallocation 
Change-Id: I4673543c96eb342c3c977e00d44772a0d719a23e
 2013-12-24 18:26:55 +09:00
Tadashi G. Takaoka
cf915ddc87 Rename classes related to AbstractDrawingPreview 
Change-Id: Ife2e2c08b2b6fbf9ec33cf259f276878816b291c
 2013-12-24 18:17:00 +09:00
Tadashi G. Takaoka
e82200787c Separate GestureStrokePreviewParams to top level class 
Change-Id: I4c6ac12dac9636760128625bb5b7138b7d56f3d1
 2013-12-24 17:27:15 +09:00
Tadashi G. Takaoka
dc2ce72555 Merge "Make GestureStrokeParams as a top level class" 2013-12-24 06:40:29 +00:00
Tadashi G. Takaoka
c845d4c664 Make GestureStrokeParams as a top level class 
Change-Id: I540a2d3a6c6ce6ecdcccecd38df6b3c23fcf8d95
 2013-12-24 15:29:10 +09:00
Jean Chalard
036930e80d Merge "[IL33] Opportunistically remove some KeyboardSwitcher" 2013-12-24 06:28:54 +00:00
Jean Chalard
8476c2e788 [IL33] Opportunistically remove some KeyboardSwitcher 
Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
 2013-12-24 15:11:35 +09:00
Tadashi G. Takaoka
904866c701 Clean up batch input related code a bit 
Change-Id: I3b6a95fdb82bd15e2b636b1374a96d8987d5d8cf
 2013-12-24 14:24:27 +09:00
Tadashi G. Takaoka
aa7a68a3e0 Remove duplicate code 
Change-Id: Ia33ea2dc4bb063ec5bf282c656ccc1f11ac967fe
 2013-12-24 12:39:16 +09:00
Jean Chalard
07f7536b04 [IL32] Remove a useless variable 
Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c
 2013-12-20 21:34:07 +09:00
Jean Chalard
1587be6977 [IL31] Move *BatchInput to InputLogic 
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
 2013-12-20 21:24:27 +09:00
Jean Chalard
059f4c2f39 [IL30] Minor refactoring 
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
 2013-12-20 20:47:44 +09:00
Jean Chalard
0547b33130 [IL29] Move retryResetCaches and tryFixLyingCursorPosition 
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
 2013-12-20 20:47:29 +09:00
Jean Chalard
81e8d16031 [IL28] Remove useless code 
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.

Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
 2013-12-20 19:48:05 +09:00
Jean Chalard
55ce2cc2d5 [IL27] Some refactoring 
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
 2013-12-20 19:24:38 +09:00
Jean Chalard
221df9e59a [IL26] Move restartSuggestionsOnWordTouchedByCursor 
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
 2013-12-20 19:09:36 +09:00
Jean Chalard
ec4b6e7bb3 [IL25] Inline handleClose 
Only ever used here.

Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
 2013-12-20 18:44:13 +09:00
Jean Chalard
aa161eb371 [IL24] Move mDisplayOrientation to SettingsValues. 
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
 2013-12-20 18:44:09 +09:00
Jean Chalard
a22a63f3b1 Merge "Fix an NPE" 2013-12-20 09:14:56 +00:00
Jean Chalard
92392b21f2 Fix an NPE 
Change-Id: I6307c1545d9d48cdea66d08f8efc1b7fbb08ee42
 2013-12-20 18:13:23 +09:00
Tadashi G. Takaoka
f405c58c09 Merge "Use config_screen_metrics resource in BogusMoveEventDetector" 2013-12-20 09:03:25 +00:00
Tadashi G. Takaoka
9c4de1e5f7 Use config_screen_metrics resource in BogusMoveEventDetector 
Change-Id: I6b957b43c6dd7ce4f639e46d248179662c1ee669
 2013-12-20 17:35:19 +09:00
Jean Chalard
1252333efd Merge "[IL23] Resolve a long-standing TODO." 2013-12-20 08:29:29 +00:00
Tadashi G. Takaoka
0c8ea69cad Merge "Separate logic of enabling gesture typing" 2013-12-20 08:03:18 +00:00
Jean Chalard
84e78cb769 Merge "[IL22] Move onTextInput to InputLogic." 2013-12-20 08:02:36 +00:00
Jean Chalard
689cff2e3b Merge "[IL21] Move the workaround utils to a better place." 2013-12-20 08:02:07 +00:00
Jean Chalard
6cf843cba6 [IL23] Resolve a long-standing TODO. 
Bug: 8636060
Change-Id: I3a840c30cc4489debf9118beeec448488503bc1c
 2013-12-20 16:50:14 +09:00
Jean Chalard
11730aa224 [IL22] Move onTextInput to InputLogic. 
Also pull the TLD specific processing

Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
 2013-12-20 16:50:14 +09:00
Jean Chalard
1404c1af85 [IL21] Move the workaround utils to a better place. 
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
 2013-12-20 16:48:54 +09:00
Tadashi G. Takaoka
a00838b6e8 Separate logic of enabling gesture typing 
Change-Id: I91fc566f24a38a55d2352201d5d581d3fa02a428
 2013-12-20 16:37:17 +09:00
Tadashi G. Takaoka
db6d9b0ab4 Merge "Separate BogusMoveEventDetector class" 2013-12-20 07:36:07 +00:00
Tadashi G. Takaoka
c986d16e8a Separate BogusMoveEventDetector class 
Change-Id: I24f0ff385f338ff313ef32514f2930f120183be7
 2013-12-20 16:17:41 +09:00
Tadashi G. Takaoka
9033fb1f64 Merge "Separate TypingTimeRecorder class" 2013-12-20 07:16:34 +00:00
Tadashi G. Takaoka
5045103d61 Separate TypingTimeRecorder class 
Change-Id: Ic56d3e3a1be935854dcace36d8a05a9d2619dab9
 2013-12-20 16:14:26 +09:00
Jean Chalard
529cdf0a0c Merge "[IL20] Remove some useless processing." 2013-12-20 07:14:09 +00:00
Jean Chalard
95d869fed4 Merge "[IL19] Resolve a TODO." 2013-12-20 07:11:24 +00:00
Jean Chalard
8a390023e1 [IL20] Remove some useless processing. 
If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.

Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
 2013-12-20 16:02:07 +09:00
Jean Chalard
4487a30e0d [IL19] Resolve a TODO. 
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
 2013-12-20 16:02:03 +09:00
Jean Chalard
f7d493979a Merge "[IL18] Move and rename updateSuggestionStrip" 2013-12-20 06:54:33 +00:00
Jean Chalard
2a6de7903c [IL18] Move and rename updateSuggestionStrip 
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
 2013-12-20 15:46:34 +09:00
Tadashi G. Takaoka
921a32f0a9 Remove unnecessary default KeyDetector from PointerTracker 
Change-Id: Ib0fbb40a7040202d2a4b4ab49319d9e247a2a6ce
 2013-12-20 15:34:54 +09:00
Tadashi G. Takaoka
dbb88e47c8 Merge "Remove unused default object of GestureStrokePreviewParams" 2013-12-20 06:33:36 +00:00
Tadashi G. Takaoka
081989ca30 Remove unused default object of GestureStrokePreviewParams 
This change also fixes build broken by Id615556766.

Change-Id: I16605cc3b65e3e9ab2d5a498825c31d9b4046b73
 2013-12-20 15:25:24 +09:00
Jean Chalard
1c0374da49 [IL17] Move commitChosenWord to InputLogic. 
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.

Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
 2013-12-20 15:13:48 +09:00
Jean Chalard
a905fcec00 [IL16] Improve getTextWithSuggestionSpan 
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.

Not directly related, but helpful with:
Bug: 8636060

Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
 2013-12-20 15:13:48 +09:00
Tadashi G. Takaoka
6e97efef78 Fix rugged gesture trail 
Bug: 12222472
Change-Id: Id615556766718a8bd4848f7026833fbcea540c39
 2013-12-20 14:40:18 +09:00
Tadashi G. Takaoka
ce9c7d7511 Merge "Remove PointerTracker reference from accessibility package" 2013-12-20 03:33:24 +00:00
Tadashi G. Takaoka
6a23b9e3d5 Remove PointerTracker reference from accessibility package 
Change-Id: I1a88d9fc4db437070778ea1256aae17c32428729
 2013-12-20 12:29:25 +09:00
Jean Chalard
5c9e677c2a [IL15] Some small refactoring 
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
 2013-12-20 11:24:45 +09:00
Jean Chalard
48ba1f25ff [IL14] Move getCurrent*Caps* to InputLogic 
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
 2013-12-20 11:24:42 +09:00
Jean Chalard
cdd8a1a69d [IL13] Inline restartSuggestionsOnWordBeforeCursor 
It's only ever used in one place and makes unhealthy assumptions
about what the caller is doing. It's better inlined.

Bug: 8636060
Change-Id: I265d5d96894e929d09247ee2e3dc2e81efc2a276
 2013-12-19 20:31:52 +09:00
Jean Chalard
bbe40835a9 [IL12] move restartSuggestions* to InputLogic 
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
 2013-12-19 20:30:41 +09:00
Jean Chalard
10755af97b [IL11] Cleanup 
Make some methods private and add comments.

Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
 2013-12-19 20:13:14 +09:00
Jean Chalard
060e292628 [IL10] Move revertCommit to InputLogic 
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
 2013-12-19 19:30:26 +09:00
Jean Chalard
69a57bcdcd [IL9] Move commitCurrentAutoCorrection to InputLogic 
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
 2013-12-19 19:30:20 +09:00
Jean Chalard
035e3885ac [IL8] Move handleNonSeparator to InputLogic 
Also move getActualCapsMode and getNthPreviousWordForSuggestion

Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
 2013-12-19 18:32:51 +09:00
Jean Chalard
d85e49bf8c [IL7] Move performRecapitalization to InputLogic 
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
 2013-12-19 18:20:41 +09:00
Jean Chalard
40b42b7d84 [IL6] Move handleSeparator to InputLogic 
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod

Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
 2013-12-19 17:39:01 +09:00
Jean Chalard
c8dfaab783 [IL5] Some renaming 
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
 2013-12-19 17:38:55 +09:00
Jean Chalard
37d3f1bd02 [IL4] Move handleNonSpecialCharacter to InputLogic. 
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
 2013-12-19 16:46:57 +09:00
Jean Chalard
0e82fa273d [IL3] Move handleBackspace to InputLogic. 
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline

Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
 2013-12-19 16:46:54 +09:00
Jean Chalard
cddf4f9d78 [IL2] Move onCodeInput to InputLogic. 
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
 2013-12-19 16:24:45 +09:00
Jean Chalard
7bd2a75ca1 Start separating the input logic from LatinIME. 
Create an InputEngine class and start moving the relevant
variables to it.

Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
 2013-12-19 14:48:43 +09:00
Jean Chalard
dfbe2bfe08 Add some info to test crashes to help diagnose flakiness 
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
 2013-12-18 18:10:56 +09:00
Keisuke Kuroyanagi
1f5a3faf76 Merge "Enable Personalized dictionaries based on the setting." 2013-12-17 10:40:29 +00:00
Keisuke Kuroyanagi
8732f9c5f9 Enable Personalized dictionaries based on the setting. 
Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7
 2013-12-17 19:36:19 +09:00
Jean Chalard
4196360912 Run GC when needed, instead of too late. 
Bug: 12164855
Change-Id: Ie4d8be9f2652b01470bcc06911e2191e09fb3149
 2013-12-17 18:08:48 +09:00
Jean Chalard
97a553ae69 Fix wrong dereference reading code. 
Bug: 12164855
Change-Id: I26faf27edfa303510197bccaa3521578f649741d
 2013-12-17 16:42:22 +09:00
Keisuke Kuroyanagi
b54c747d7c Merge "Move DictUpdater to the tests directory." 2013-12-17 05:33:16 +00:00
Keisuke Kuroyanagi
4fdcefe504 Move DictUpdater to the tests directory. 
Bug: 11245133
Change-Id: I0907a091ac3ae960eaf3b27da78dbb48a24b2ea1
 2013-12-17 14:31:25 +09:00
Tadashi G. Takaoka
19dd753c0c Cancel more suggestions panel when touching keyboard 
Bug: 10010128
Change-Id: I2ff0870c69f407d943caf8b9cec90b7ed89de5f1
 2013-12-17 12:59:37 +09:00
Tadashi G. Takaoka
dd4937848a Fix typo in varibale name 
Change-Id: I7ea6c59b7c980e93c88a6cf0fef97592d411c3ba
 2013-12-17 12:15:02 +09:00
Tadashi G. Takaoka
fcacde3dad Revise Armenian punctuations more keys 
Bug: 12096943
Change-Id: Ib8559f030fbc27ec7f7e9a9fb36aad72cca29e9f
 2013-12-17 11:12:33 +09:00
Tadashi G. Takaoka
3aeb6a9d0d Merge "Refactor touch event forwarding in InputView" 2013-12-17 02:04:40 +00:00
Tadashi G. Takaoka
27fab2cc2a Refactor touch event forwarding in InputView 
Bug: 10010128
Change-Id: I82aa4ce847e66cb1241678f39b47b9e27a0f555a
 2013-12-17 08:49:50 +09:00
Jean Chalard
0c7b05fc50 Merge "Fix a bug with languages without spaces and predictions" 2013-12-16 14:17:51 +00:00
Jean Chalard
7cd7cf73f4 Fix a bug with languages without spaces and predictions 
This is simpler and more correct.

Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
 2013-12-16 23:16:02 +09:00
Keisuke Kuroyanagi
e17cc8270f Merge "Increment version number of ver4 format to 401." 2013-12-16 14:13:42 +00:00
Keisuke Kuroyanagi
b5215d456a Increment version number of ver4 format to 401. 
Bug: 11073222
Change-Id: I3878aef02040b1ef73165645fc70ede586289c51
 2013-12-16 23:02:54 +09:00
Keisuke Kuroyanagi
214a3b741f Merge "Fix: incompatible PtNode array size reading." 2013-12-16 13:57:55 +00:00
Keisuke Kuroyanagi
56e7e38d37 Fix: incompatible PtNode array size reading. 
Bug: 11073222
Change-Id: I681be725b5c6dcc10aa536b00327698a7df75277
 2013-12-16 22:42:01 +09:00
Jean Chalard
dc06ee85ef A simplification. 
This does the same thing, but simpler and faster.
Was noticed while investigating bug#12164555

Change-Id: If9926e4da8a53a65489da55197ac87122c44fe7c
 2013-12-16 21:38:31 +09:00
Keisuke Kuroyanagi
769eb083ef Merge "Add option to enable personalization dictionaries." 2013-12-16 10:33:40 +00:00
Keisuke Kuroyanagi
d4bb7df412 Add option to enable personalization dictionaries. 
Bug: 11757851

Change-Id: I4872c10793d4fd55c0bd9e5bc4650925de6d2c1d
 2013-12-16 19:17:31 +09:00
Tadashi G. Takaoka
f3b92fb952 Merge "Fix IllegalStateException of ViewGroup" 2013-12-16 08:36:45 +00:00
Tadashi G. Takaoka
7f8345d59a Fix IllegalStateException of ViewGroup 
Bug: 10629042
Change-Id: I111d092fb2f7dca47328127a155c981aa1c55906
 2013-12-16 17:06:23 +09:00
Keisuke Kuroyanagi
b6a19229ba Merge "Make required binary dictionary version use FormatSpec.*" 2013-12-16 07:56:58 +00:00
Keisuke Kuroyanagi
c837767819 Make required binary dictionary version use FormatSpec.* 
Change-Id: Ifb17d6551bc5071553e32a5640dd166c39374461
 2013-12-16 16:50:28 +09:00
Jean Chalard
5590e9d040 Merge "Make the bad header a checked exception and fix dicttool test" 2013-12-16 07:18:44 +00:00
Jean Chalard
3df617323e Make the bad header a checked exception and fix dicttool test 
Change-Id: If780a2a1cb722aee83d910904c0a6315add9552d
 2013-12-16 15:40:45 +09:00
Tadashi G. Takaoka
1b5b0a3ebc Cancel long press shift key while chording input 
Bug: 12123508
Change-Id: I693caad1f8ee47ebeb14419603d1fc29f6263a75
 2013-12-16 15:30:41 +09:00
Jean Chalard
b868375763 Fix failing tests 
- Version 3 is not supported
- Now passing the right string to open v4 dicts. Fix the tests for this.

Change-Id: I7829330c3568a715b96396ba4e4e69c6e17775ab
 2013-12-16 14:32:19 +09:00
Ken Wakasa
2c25c7c9e1 Fix locale names in the make-keyboard-text tool 
Change-Id: I33c3fafcff124bb94e395cc604ce264daad55d2d
 2013-12-14 18:50:57 +09:00
Jean Chalard
330d2720bb Instead of ignoring PARAGRAPH spans, fix them. 
I don't know what or when this flag is set, but it's only bad
news. Luckily, we can just remove it.

Bug: 12119393
Change-Id: I2952138c8ce517535b91e0fe25d2cf4960e02862
 2013-12-13 23:42:31 +09:00
Jean Chalard
7a904514fb Merge "Don't use the previous word after a non-whitespace separator" 2013-12-13 11:53:30 +00:00
Jean Chalard
0b51fac907 Merge "Only update shift state if left in auto mode." 2013-12-13 11:52:13 +00:00
Jean Chalard
fae1ba767c Don't use the previous word after a non-whitespace separator 
Bug: 12101276
Change-Id: Icf36d55ec171194e5561b946021bcf648782ddd4
 2013-12-13 20:51:28 +09:00
Jean Chalard
28bd6e2297 Only update shift state if left in auto mode. 
Bug: 12100417
Change-Id: I7bc2b19332e142a257b0399f2e5d128caf01fc7c
 2013-12-13 20:47:25 +09:00
Jean Chalard
f3d281b775 Merge "Fix a bug where recapitalize prevents going to more syms" 2013-12-13 10:38:18 +00:00
Jean Chalard
5d98e1d82e Fix a bug where recapitalize prevents going to more syms 
Bug: 11004973
Change-Id: I97ee9df6e8464e2149beb41c688cbfbd83ac3d8c
 2013-12-13 19:21:49 +09:00
Jean Chalard
f08b1ea41a Merge "Remove references to the v3 dictionary." 2013-12-13 10:08:12 +00:00
Tadashi G. Takaoka
bf7503ae6b Merge "Fix key top letter color in shifted layout" 2013-12-13 09:55:19 +00:00
Jean Chalard
1dc7eca114 Remove references to the v3 dictionary. 
Change-Id: I811c8c923ad67a6d9bfdd11bdef8991eb7135c27
 2013-12-13 18:53:41 +09:00
Keisuke Kuroyanagi
3e81d9c39f Merge "Remove code for forgetting curve in Java side." 2013-12-13 09:44:16 +00:00
Keisuke Kuroyanagi
cc8c544ee2 Remove code for forgetting curve in Java side. 
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
 2013-12-13 18:40:58 +09:00
Tadashi G. Takaoka
815a339201 Fix key top letter color in shifted layout 
There is a chance to have an empty hint label even though
keyLabelFlags has hasShiftedLetterHint flag.

Change-Id: I63b9fcc42a40391d5902814cae4c75abb61e4b94
 2013-12-13 18:34:30 +09:00
Jean Chalard
a245d15da5 Have dicttool use the native library to generate v4 dicts. 
Yay !

Change-Id: Iea8ced9e81031b9ab7eff05ad9ef7215be248de9
 2013-12-13 18:18:20 +09:00
Jean Chalard
af0c222a5e Merge "Remove flags from Java side." 2013-12-13 09:17:10 +00:00
Jean Chalard
7b55cd3e2b Remove flags from Java side. 
This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
  The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
  regardless of this flag.

Bug: 11281748
Change-Id: If567e52e245a9342adc7f3104a0f7d8d782df8c1
 2013-12-13 18:15:05 +09:00
Ken Wakasa
2fa3693c26 Reset to 9bd6dac470 
The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
 2013-12-13 17:13:32 +09:00
Keisuke Kuroyanagi
9642286c01 Make ExpandableBinaryDictionary usable for offdevice tests. 
Bug: 11956652
Change-Id: If5a503ef161781818f2efceba542be5a61be6bd1
 2013-12-13 14:48:43 +09:00
Keisuke Kuroyanagi
9bd6dac470 Add a constructor for testing to non-main dictionaries. 
The new constructor is used for creating dictionary instance
that uses a given file.

Bug: 11956652
Change-Id: Ifbf420a1a768eb95a5c3a58eeb1be5936b306d35
 2013-12-12 20:14:06 +09:00
Keisuke Kuroyanagi
d06de553b2 Add waitAllTasksForTests for testing. 
Bug: 10667710
Change-Id: I7a189e32286a6005393fbde8da736541ca9226a8
 2013-12-12 17:08:51 +09:00
Keisuke Kuroyanagi
9ff51527a3 Quit passing header file path to native. 
Bug: 12089197
Change-Id: Ia898f8d2836c0c131a1834dc0a396d9121ecb972
 2013-12-12 16:48:34 +09:00
Jean Chalard
9fa221a7bd Remove dependency from StringUtils to Json 
Change-Id: I2a89497fb9ec12a37ba09f4598742e88f6700576
 2013-12-12 13:55:56 +09:00
Tadashi G. Takaoka
79cc690f55 Fix Filipino keyboard 
Bug: 12102802
Change-Id: Id55ba5ebd8ddaf83ed246315d81b25ad4c9b6294
 2013-12-12 11:12:23 +09:00
Keisuke Kuroyanagi
549ae3d84e Merge "Create ver4 dictionary files with the dictionary name." 2013-12-11 10:42:16 +00:00
Keisuke Kuroyanagi
84cc5a2c76 Create ver4 dictionary files with the dictionary name. 
Bug: 12025402

Change-Id: Ia0bb13b2e26aa60a67dff73f3f6a1e276f1bb1dd
 2013-12-11 19:30:18 +09:00
Tadashi G. Takaoka
0719c4ca72 Merge "Ignore other finger while showing more keys keyboard" 2013-12-11 09:20:02 +00:00
Tadashi G. Takaoka
7f82bb55ed Ignore other finger while showing more keys keyboard 
Bug: 12088861
Change-Id: I784cb8fee247a7a4ea4af4c0569fed9334430e18
 2013-12-11 18:12:45 +09:00
Tadashi G. Takaoka
7ca3dbe3e5 Merge "Don't start long press timer while other one is running" 2013-12-11 08:07:47 +00:00
Tadashi G. Takaoka
fa860a091e Don't start long press timer while other one is running 
Bug: 11908158
Bug: 12088861
Change-Id: I2537855f505884da9fe958d946c79840bd19dc5f
 2013-12-11 17:01:26 +09:00
Tadashi G. Takaoka
0a190a389f Merge "Rename deprecated locale directories" 2013-12-11 06:01:34 +00:00
Keisuke Kuroyanagi
ad2d34f80a Rename PersonalizationPredictionDictionary. 
Change-Id: If7497310485a895dd22b8df29dc13508acaa0ab6
 2013-12-11 14:09:00 +09:00
Ken Wakasa
423422c437 Rename deprecated locale directories 
cf. Ibe392f5f9dbc82c3cdff8e06b958bc3bcce3fa82

Also, cf. bug id 11340849

Change-Id: I43e84f8ca04eb1aa74037a705970a36434429a0f
 2013-12-11 13:27:46 +09:00
Jean Chalard
97351ad34c Merge "Fix typos." 2013-12-11 03:41:23 +00:00
Jean Chalard
a8ffdf0288 Merge "Split the header into a separate file." 2013-12-11 03:37:05 +00:00
Jean Chalard
83c879ad67 Fix typos. 
One of these cost me a day and a half searching for a bug :(

Change-Id: I20f0b727f7c02e2754aaaf6a05b74c9cf9e6375e
 2013-12-11 12:06:05 +09:00
Jean Chalard
3839defc90 Split the header into a separate file. 
Bug: 11281748
Change-Id: Ia2490d18bf159990310e10ed45fb6b3a0dee1c5f
 2013-12-11 12:03:40 +09:00
Keisuke Kuroyanagi
499371a5ef Remove PersonalizationDictinoary. 
Now, PersonalizationPredictionDictionary can be used not only
for prediction but also for suggestions.
We should rename PersonalizationPredictionDictionary to
PersonalizationDictionary.

Change-Id: Ifcf4459072f3523e3f3dc783f12e15b89cdbb12d
 2013-12-11 11:09:52 +09:00
Keisuke Kuroyanagi
7c8075c2ac Uncapitalized words for personalization dictionary. 
Bug: 11736529
Change-Id: I62a7469afe03092ec992bfb190f717223a8c556f
 2013-12-10 19:19:18 +09:00
Tadashi G. Takaoka
a2bbb1213d Remove obsolete warning message 
This is a follow up of I5655c5703b.

Change-Id: I4a61689eb275b54648c6112c9f8709e4a9c35a5e
 2013-12-07 18:59:13 +09:00
Tadashi G. Takaoka
4d02aa4e8c Add punctuations letters to period key on tablet 
Bug: 11918360
Change-Id: I5655c5703bfcb541c9ff4b7e0da2f9b8e14947d0
 2013-12-06 18:24:20 +09:00
Tadashi G. Takaoka
637ecce74c Merge "Consolidate multiple locales' period key definition" 2013-12-06 09:21:26 +00:00
Jean Chalard
90c9199753 Merge "[RF4] Actually remove ver4 dicts" 2013-12-06 08:54:33 +00:00
Keisuke Kuroyanagi
fc16c320c6 Merge "Add a jni method to fetch unigram information." 2013-12-06 08:53:21 +00:00
Keisuke Kuroyanagi
9fb28f78f7 Add a jni method to fetch unigram information. 
Bug: 11956652

Change-Id: I59f1823bbc0146f6d2f34cbed8166bb6de197208
 2013-12-06 17:17:38 +09:00
Jean Chalard
c5db41a9d5 [RF4] Actually remove ver4 dicts 
And fix a couple bugs.

Bug: 11281748
Change-Id: If07953a4b1ff9eb1165af03fdb332d7e47cd8f32
 2013-12-06 17:07:59 +09:00
Tadashi G. Takaoka
5bf55a86d0 Return null if "!text/" reference is an empty text 
Change-Id: I01826f3e09527348fb4cba3302a9394ff34f424a
 2013-12-06 16:51:11 +09:00
Tadashi G. Takaoka
aab0140390 Consolidate multiple locales' period key definition 
Bug: 11918360
Change-Id: If59043709a433a57846de07e150bf9c14b614d52
 2013-12-06 15:25:47 +09:00
Jean Chalard
a72e8f1ede [RF3] Cleanups 
Make the version number a single number on native and java side.
Also, remove the hasValidContents method. It's useless since the
native code already checks this when creating the dictionary (I
wish I had known that when I added it).

Bug: 11281748
Change-Id: I572d37429972b2f280e4bdb748b709e5d0d7737e
 2013-12-06 14:53:03 +09:00
Jean Chalard
cb27d955f3 Merge "[RF2] Some refactoring and some cleanup" 2013-12-06 04:30:25 +00:00
Jean Chalard
b8481456f2 [RF2] Some refactoring and some cleanup 
Bug: 11281748
Change-Id: Iff45fdf6b23f77c08271a169c7d7ca45912c85e8
 2013-12-06 13:06:49 +09:00
Tadashi G. Takaoka
6300168cb8 Fix puctuations more keys on Spanish/Phone 
Bug: 11918360
Change-Id: I01e1c1e2a1953855bd2b009fc2d82e18cdde7140
 2013-12-05 18:54:29 +09:00
Tadashi G. Takaoka
4cd86d3bb4 Cleanup exclamation and questuion keys 
Bug: 11918360
Change-Id: I00731a273beea6dbc300dc215996dcadd97f17e2
 2013-12-05 18:53:32 +09:00
Tadashi G. Takaoka
624fcde18b Cleanup comma key of Arabic/Farsi 
Bug: 11918360
Change-Id: I4ab373d8fc012fd77a388a067d7f5d99d8247299
 2013-12-05 18:15:45 +09:00
Tadashi G. Takaoka
f6b479d482 Add exclamation/question marks to Hebrew tablet keyboard 
Bug: 11918360
Change-Id: I226f8fbb2177f472f69b56faca2a141687734494
 2013-12-05 12:47:47 +09:00
Tadashi G. Takaoka
1eb63684f9 Merge "Add workaround to prevent ViewPager from crashing" 2013-12-04 09:05:07 +00:00
Tadashi G. Takaoka
5086275d39 Add workaround to prevent ViewPager from crashing 
Bug: 11721001
Change-Id: I0824f82c30a288a3c1f0ea69e07f10bdeb744bbc
 2013-12-04 17:46:15 +09:00
Jean Chalard
743c7e0e6e Merge "[RF1] Remove files that don't match the expected format, step 1" 2013-12-04 08:19:26 +00:00
Keisuke Kuroyanagi
c63f2762cc Merge "Start to use historical info." 2013-12-04 08:03:53 +00:00
Jean Chalard
5e80e699c4 [RF1] Remove files that don't match the expected format, step 1 
This implements the skeleton implementation, and enables a
fallback implementation in the case the file is coming from the
dictionary provider.
- A better scheme should be used for provider-supplied dicts.
- This does not implement the solution for device-generated
    dicts yet. This will come in a future change.
- This does not implement the checking process on the native
    side yet. This will come in a future change.

Bug: 11281748
Change-Id: Ifa6e237d19dfbffe503e3674915480ea867b0ddf
 2013-12-04 16:19:55 +09:00
Keisuke Kuroyanagi
e33072eb50 Quit using obsolete methods for testing. 
Bug: 11073222
Change-Id: I77c99fbea2f255dbfddb646b6e12bee574647eca
 2013-12-04 16:03:53 +09:00
Keisuke Kuroyanagi
4d68867839 Start to use historical info. 
Bug: 11073222
Change-Id: I232d41bec5df7952856b5ba4765977707c39b94a
 2013-12-04 12:52:58 +09:00
Tadashi G. Takaoka
7081a36e2f Merge "Add spacebar background drawable" 2013-12-04 03:47:41 +00:00
Tadashi G. Takaoka
dc337df48c Add spacebar background drawable 
Bug: 11106827
Change-Id: Ic6e0b6bd9187901b01d64296db816afa73da9ffd
 2013-12-04 12:31:10 +09:00
Keisuke Kuroyanagi
a0befc6490 Start passing timestamp for dynamic dictionaries. 
Bug: 11073222
Change-Id: I89e1277f734d5959e33d61e7e9e7048084b9007a
 2013-12-04 11:57:45 +09:00
Ken Wakasa
64ead8d293 Merge "Add required header attributes for user/contacts dictionary." 2013-12-03 10:23:51 +00:00
Keisuke Kuroyanagi
8bfc8c46ff Add required header attributes for user/contacts dictionary. 
Bug: 11973488

Change-Id: I91ef720a24633aec0f4e81cd4f7c49c749805c49
 2013-12-03 19:22:17 +09:00
Jean Chalard
25848af556 Tiny refactoring 
Add a warning comment and make it so that openNative()
is only called in one place in the code.

Bug: 11281748
Change-Id: Ic7819a01deb62cf145ebf9d620da2d15fae19313
 2013-12-03 17:46:56 +09:00
Tadashi G. Takaoka
6d9e273fb5 Separate common config and dimensions resources 
Change-Id: Ia16880e818927bc3df7292e130b2f7b5efc9776e
 2013-12-03 12:14:27 +09:00
Keisuke Kuroyanagi
d1501ea789 Make contacts/user dictionary ver2. 
Change-Id: I10c29bd45fd37d765f115333087e1700dd90570b
 2013-12-02 21:59:56 +09:00
Jean Chalard
5fa4ad6a85 Merge "Fix some more tests" 2013-12-02 12:41:25 +00:00
Jean Chalard
ca5c7a9e14 Fix some more tests 
Bug: 11960453
Bug: 11954718
Change-Id: I71e98cc6ab30cc89e921e9ef578d7f6366049d01
 2013-12-02 21:05:26 +09:00
Tadashi G. Takaoka
770b00874b Remove KeyEventHandler 
Change-Id: Iddde1f85139cb21bde6e4fc275c32f3d62f4862f
 2013-12-02 20:25:25 +09:00
Tadashi G. Takaoka
5d311f2c13 Merge "Add config_ prefix to the resource names merged from dimens.xml" 2013-12-02 11:14:07 +00:00
Jean Chalard
576c753d25 Fix an obvious bug 
This had to be a typo

Change-Id: Id49e44d7667d64b00e883c55c683535398b6bdea
 2013-12-02 20:04:52 +09:00
Tadashi G. Takaoka
8c6052bce1 Add config_ prefix to the resource names merged from dimens.xml 
Change-Id: I6fb11b8cb52c06b805fb17d61450d7df50e4e20d
 2013-12-02 20:01:15 +09:00
Keisuke Kuroyanagi
545e4191b3 Merge "Quit recording LastUserHistoryWriteTime." 2013-12-02 10:10:32 +00:00
Keisuke Kuroyanagi
cffe4d2d0f Quit recording LastUserHistoryWriteTime. 
Change-Id: I0f2b408b4976d8119c932654e23836803d42c568
 2013-12-02 18:45:32 +09:00
Jean Chalard
9ab71eda83 Fix tests. 
This fixes a few bugs that became apparent with the
reinstating of a test.

Bug: 11954718
Change-Id: I1127bc3180f856566429f40d14c944e6f0007e09
 2013-12-02 18:15:22 +09:00
Tadashi G. Takaoka
9a0216def9 Avoid NPE by checking 
Bug: 11956240
Change-Id: I3de1ebbf96fa2422124e4d8e50190adfa09b8a49
 2013-12-02 16:25:20 +09:00
Jean Chalard
d7337a72bc Merge "Fix auto-detection of format 4." 2013-11-29 10:31:37 +00:00
Jean Chalard
26c9af33a7 Fix auto-detection of format 4. 
Bug: 11073222
Change-Id: I76e47d0399cf43fc3cc18cb1252f166be86b9a69
 2013-11-29 19:10:19 +09:00
Tadashi G. Takaoka
3f8c1d4a19 Clean up PointerTracker a bit 
Change-Id: I227501607ee1476c2f6faceca1c3c0833778a0ee
 2013-11-29 16:55:25 +09:00
Tadashi G. Takaoka
18ffeaba16 Use interfaces instead of MainKeyboardView class 
Change-Id: I760b107d804fc84153f08667f20061fedd308841
 2013-11-29 12:19:49 +09:00
Tadashi G. Takaoka
ccc86630a2 Rename StaticInnerHandlerWrapper to LeakGuardHandlerWrapper 
Change-Id: I024f0ee9c7f7718afc8a4ca0c6c49f2e88b035ad
 2013-11-29 12:15:40 +09:00
Keisuke Kuroyanagi
22e28d5a2d Merge "Add version check to open binary dictionary." 2013-11-28 11:52:59 +00:00
Keisuke Kuroyanagi
8ac3c65b00 Add version check to open binary dictionary. 
Bug: 11073222
Change-Id: Iabae12b8f14a9da3cdc804dcc6af443cedeb3f99
 2013-11-28 20:40:26 +09:00
Tadashi G. Takaoka
2e2af0e1e1 Merge "Move MainKeyboardView.KeyTimerHandler to top level class" 2013-11-28 10:21:41 +00:00
Tadashi G. Takaoka
3fd16cbaa8 Merge "Move MainKeyboardView.DrawingHandler to top level class" 2013-11-28 10:21:34 +00:00
Tadashi G. Takaoka
3c764b2e96 Move MainKeyboardView.KeyTimerHandler to top level class 
Change-Id: Iec310b7fc6127a8a5491dbb9f8f073e455e7ba29
 2013-11-28 19:03:37 +09:00
Jean Chalard
33e777fe08 Merge "Change the timing of reading the previous word." 2013-11-28 09:57:22 +00:00
Tadashi G. Takaoka
c82e99caa0 Move MainKeyboardView.DrawingHandler to top level class 
Change-Id: I7a785725d5eb0b594485ceb25695a89c017cc60f
 2013-11-28 18:56:15 +09:00
Jean Chalard
4866a3e918 Change the timing of reading the previous word. 
Bug: 11328842
Change-Id: I08229e895fc34403932648b9b931583d965f0e01
 2013-11-28 18:51:03 +09:00
Jean Chalard
177a86d394 Merge "Fix getNthPreviousWord." 2013-11-28 09:02:46 +00:00
Tadashi G. Takaoka
b1d87850ec Fix updating list preference summary for unknown value 
Change-Id: I86d3162a90e0068e787a906c0d3d64102487620a
 2013-11-28 14:12:29 +09:00
Jean Chalard
da459787e2 Fix getNthPreviousWord. 
This should take into accounts word connectors.

Change-Id: Ic7fa5c837cd65a43ba43d7ae9d299b8d20019892
 2013-11-28 11:41:23 +09:00
Keisuke Kuroyanagi
3c7b603c46 Merge "Start using Ver4 dictionary format." 2013-11-27 10:02:21 +00:00
Tadashi G. Takaoka
169d76cc5c Merge "Disable mic key on more keys when voice IME is disabled" 2013-11-27 09:56:42 +00:00
Tadashi G. Takaoka
b70a419a9e Disable mic key on more keys when voice IME is disabled 
Bug: 11883501
Change-Id: Ie3f496935f9600e2bde51cbebed2b4f8c90c25b2
 2013-11-27 18:36:08 +09:00
Jean Chalard
4735e1d32a Merge "Fix messages in tests" 2013-11-27 08:44:31 +00:00
Jean Chalard
dfc5aade2d Fix messages in tests 
They are not failing because of this right now, but future
tests would fail without this.
Concretely, since the Handler for any given main thread is
a singleton managed by the framework, the messages won't
be removed automatically. In particular, messages posted
with a delay have a large destructive potential, because
they will go through before the startInputViewInternal
method is called, because it's called with a message too (in
turn, this is because of working around framework bugs).

Bug: 11142685
Change-Id: If81a168efcfd7d93806ddc4ea432d438c45a3e1d
 2013-11-27 17:37:57 +09:00
Tadashi G. Takaoka
05e099d77d Remove voice-on-main related code and resources 
Change-Id: I3a1b06fa028dbf130c7aa2c83e9ec1a180aa1f5c
 2013-11-27 16:48:47 +09:00
Tadashi G. Takaoka
c144299f70 Merge "Remove compiler warnings from emoji related code" 2013-11-27 03:44:34 +00:00
Ken Wakasa
c01dba872c Small optimizations for single code point strings 
Change-Id: I299c7622db291ea411e2b48dfdb622b407912ea6
 2013-11-27 12:40:13 +09:00
Keisuke Kuroyanagi
02fd1a78a3 Start using Ver4 dictionary format. 
Bug: 11073222

Change-Id: Idd836ee15501e2f8c57c8eebc1fef7f103b01d18
 2013-11-27 12:14:03 +09:00
Tadashi G. Takaoka
6bd28dfa99 Remove compiler warnings from emoji related code 
Change-Id: I88ed0d25bee87c4dabcbc425589215b901345908
 2013-11-27 11:51:05 +09:00
Keisuke Kuroyanagi
fd15afae46 Merge "Extend jni interface to support time stamp and shortcut." 2013-11-27 02:17:51 +00:00
Keisuke Kuroyanagi
9cdca3255b Extend jni interface to support time stamp and shortcut. 
Bug: 11073222

Change-Id: I19e0501850917a13ddc756d3e78fc6f6cf3f33c4
 2013-11-26 21:31:26 +09:00