nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
5487 commits 1 branch 0 tags 363 MiB
Commit graph

2352 commits

Author SHA1 Message Date
Jean Chalard
0cf422fbb7 Reduction, step 8 
Change-Id: I54334039597e235e24f169e34c1d44109180ee88
 2012-03-09 19:00:29 +09:00
Jean Chalard
a333ff19ef Reduction, step 7 
Change-Id: I177ef2f29c8b6000c5e3d021c016c5d216fe3fc6
 2012-03-09 18:59:20 +09:00
Jean Chalard
a3ee019331 Reduction, step 6 
Change-Id: I22ad4cea0e0cac23813da7e788f5c94974ce0ebf
 2012-03-09 18:58:01 +09:00
Jean Chalard
dbd140504d Reduction, step 5 
Change-Id: Iac52e62c2bdffad14f916f69eade2b785bb41767
 2012-03-09 18:44:23 +09:00
Jean Chalard
0b96bc4b2b Reduction, step 4 
Change-Id: Ib27dc6e9486c3f0f2ec1e94a88a52d12c1af2d38
 2012-03-09 18:44:20 +09:00
Jean Chalard
5a61d03f31 Reduction, step 3 
Change-Id: I0e08b102c9539d97c473505b9d42176c4a7c8853
 2012-03-09 18:44:16 +09:00
Jean Chalard
8abd15b59f Reduction, step 2 
Change-Id: I06e117df43d25dbaf9fc7a7366efd9355a6215ce
 2012-03-09 18:44:10 +09:00
Jean Chalard
f08f30176b Reduction, step 1 
Change-Id: Ic3ed04300cfd4c0b69b93b27379aca4093b32f67
 2012-03-09 18:38:44 +09:00
Jean Chalard
de165aed2a Separate bigram prediction from suggestion process 
Change-Id: Ibdef206fbd6688a45cebbd7fb8a9f6cd175d03b0
 2012-03-09 18:38:20 +09:00
Jean Chalard
6f722c8301 Remove useless stuff 
Change-Id: I462d24da2d26661990d6aab2a13fde851763fd61
 2012-03-09 18:36:52 +09:00
Jean Chalard
67af2a2415 Export some more logic out of Latin IME 
Change-Id: Ib264533a05e9e09347bf254789e6ab5beec92400
 2012-03-09 18:36:49 +09:00
Jean Chalard
df9fce5df1 Export some logic out of LatinIME 
Hopefully that will end in Suggest/SuggestedWords being autonomous
and won't need the logic spoon-fed to them

Change-Id: I915661bce13c69c8a5b8e5d4a8c41e18fea594cf
 2012-03-09 18:36:45 +09:00
Jean Chalard
91e55ac000 Small optimization 
We only use some of those results in one branch of an if() test.
Let's not compute those that are not needed.

Change-Id: I6ca068646b86d2980fb88e75b110ad077362c4ff
 2012-03-09 16:47:43 +09:00
Jean Chalard
195419b1ec Small reorganization 
...resulting in a slight optimization

Change-Id: I83a9b8c92c3d93ce75988285997ec138b3ffe52e
 2012-03-09 16:41:35 +09:00
Jean Chalard
838629aea0 Remove useless test 
typedWord may not be null here

Change-Id: I9e7afb89fafbf6fcbc91fbc132aecc06aec8979f
 2012-03-09 15:52:23 +09:00
Jean Chalard
d48b76267a Merge "Remove a useless test (B7)" 2012-03-08 22:26:20 -08:00
Jean Chalard
2d82757fc6 Merge "Rename a parameter (B6)" 2012-03-08 22:23:33 -08:00
Jean Chalard
de19ab878d Merge "Remove useless tests (B5)" 2012-03-08 22:22:56 -08:00
Jean Chalard
5a7cb9305a Merge "Remove a provably useless test (B4)" 2012-03-08 22:22:20 -08:00
Jean Chalard
54392438c5 Merge "Optimize and clean up (B2)" 2012-03-08 22:00:02 -08:00
Jean Chalard
90bd4efd10 Remove a useless test (B7) 
consideredWord is provably never null.

Change-Id: Ifaa0d2471c46f14967e70ad004d2b82f841a4566
 2012-03-09 14:55:46 +09:00
Jean Chalard
cf8bc92ba0 Rename a parameter (B6) 
This is not necessarily the typed word. Actually, the parameter
that's passed here has trailing single quotes culled out of it.

Change-Id: Ia2038faa2cbbd3a5b8263e6c0fb5b8e670993fe9
 2012-03-09 14:52:35 +09:00
Jean Chalard
92146f2926 Remove useless tests (B5) 
WordComposer#getTypedWord() may not return null. Don't test for it.

Change-Id: I6aff14892503d0c275a3328c404ed99d2f40a687
 2012-03-09 14:52:04 +09:00
Jean Chalard
31a5da28e3 Merge "Move some code around (B1)" 2012-03-08 21:15:25 -08:00
Jean Chalard
8cd847c2fa Remove a provably useless test (B4) 
If !mInputAttributes.mInputTypeNoAutoCorrect then mCorrectionMode
will not have allowed #hasAutoCorrection() to return true.

Change-Id: I1b498d5aeb26194c765cc9b9dcb24d980de43894
 2012-03-09 12:56:48 +09:00
Jean Chalard
94b20c90d8 Optimize and clean up (B2) 
Stop parameters from escaping and don't do useless work and
simplify the code.
Yay.

Change-Id: I0dfc3e14b1cb50e0730f6d9c1d52b54516baa90e
 2012-03-09 12:51:55 +09:00
Jean Chalard
dc5dfe37e0 Move some code around (B1) 
The goal is to make the creation of the Builder closer to
the #build() call

Change-Id: I48d76d4efdc180479829016582edd9de47e7332c
 2012-03-09 12:33:23 +09:00
Jean Chalard
13fb8fb775 Limit escape of parameters 
Change-Id: I3a7ab069042d5542ab2e033d1eeb13d718cd7698
 2012-03-09 12:30:23 +09:00
Jean Chalard
23a5e9d1a7 Merge "Make AutoCorrection static and non-instantiable (A5)" 2012-03-08 19:05:30 -08:00
Jean Chalard
2621fe2256 Merge "Move a memory in the container class (A4)" 2012-03-08 19:04:56 -08:00
Jean Chalard
427dfe37ec Merge "Remove an unused method" 2012-03-08 18:31:26 -08:00
Jean Chalard
cbbfa15765 Merge "Make AutoCorrection a step closer to being static (A3)" 2012-03-08 18:30:19 -08:00
Jean Chalard
58722d83f0 Merge "Stop uselessly remembering a value (A2)" 2012-03-08 18:30:10 -08:00
Jean Chalard
caae6df0ce Remove an unused method 
Who would have guessed this wasn't being called at all.

Change-Id: Ib74a212356ea44e9bf149619ed5464c14684a1ba
 2012-03-09 11:10:55 +09:00
Jean Chalard
21af2f40c5 Merge broadcast receivers again 
It's probably simpler not to have registers dance around,
and just message the feedback manager when the audio event
happens.

Change-Id: Id0710ed102d10d01f1af93ad8cb660653bb3a9f8
 2012-03-09 11:00:23 +09:00
Jean Chalard
7b77c683d7 Fix a crash 
Bug: 6137076
Change-Id: I05f9f72a2678d10d3400dab5fc71544276739dcf
 2012-03-09 10:29:51 +09:00
Jean Chalard
39286f98bc Merge "Remove useless stuff (A1)" 2012-03-08 04:02:46 -08:00
Tadashi G. Takaoka
f686211183 Merge "Split Utils class to StringUtils, SubtypeUtils, and JniUtils" 2012-03-08 03:59:59 -08:00
Jean Chalard
82adfdaeae Make AutoCorrection static and non-instantiable (A5) 
This needs change Ic6756baa to not break the build

Change-Id: I1c772dd99d63fec5d3ad67a0eb7fbc28ec7a0f0f
 2012-03-08 20:56:59 +09:00
Jean Chalard
7a580a4769 Move a memory in the container class (A4) 
This allows us to make AutoCorrection a purely static class.

Change-Id: I15b81bd7f3d6ea487154a5b09a81bc323be82ce1
 2012-03-08 20:56:11 +09:00
Jean Chalard
9254dbcd7e Make AutoCorrection a step closer to being static (A3) 
Change-Id: Ide3d9785661a672af9bc8dc0cf91cab816dd6caa
 2012-03-08 20:55:49 +09:00
Jean Chalard
719f92fc77 Stop uselessly remembering a value (A2) 
The value is only used in debug mode, and it can be recomputed
at the time.
This change does not impact the logic. There is however a side
effect: in debug mode, the normalized score will be displayed
also when the word comes out of the whitelist or is a valid word.
It's actually a good thing.

The end purpose is to make all methods in AutoCorrection static.

Change-Id: I1642b1fdfa6ae62b8aa2fed94a8a26ff4a7e4d0e
 2012-03-08 20:55:37 +09:00
Jean Chalard
ec0fca8a8b Remove useless stuff (A1) 
Remove an unused method and avoid doing a useless computation

Change-Id: I29593c2e93f15857249b35bdd72ca28045056302
 2012-03-08 20:55:25 +09:00
Tadashi G. Takaoka
cc8c8b99bd Split Utils class to StringUtils, SubtypeUtils, and JniUtils 
Change-Id: I09e91675fe7d573dad8c933ad513b21d7e409144
 2012-03-08 20:30:38 +09:00
Tadashi G. Takaoka
7d6d98ecc5 Merge "Cleanup keyboard theme switching code" 2012-03-08 03:24:38 -08:00
Tadashi G. Takaoka
b43f2aeb69 Merge "Fix centering more suggestions panel on tablet" 2012-03-08 03:24:07 -08:00
Jean Chalard
2b1280c0f0 Merge "Return a value for tests instead of saving it" 2012-03-08 03:10:18 -08:00
Jean Chalard
32c181bfe0 Return a value for tests instead of saving it 
Change-Id: I54fa32b92e89d03a53866bd1c0ee65955dd6b3d3
 2012-03-08 20:07:54 +09:00
Jean Chalard
2bb29c4674 Simplification 
Change-Id: Ibced83da2398f1e9ab6a0d6a22c2ad7c8f25cb7b
 2012-03-08 19:50:47 +09:00
Jean Chalard
0f1efae262 Merge "Cleanup unused imports (A7)" 2012-03-08 02:32:48 -08:00
Jean Chalard
663aabca0c Merge "Get the view for haptic feedback as a parameter (A6)" 2012-03-08 02:32:39 -08:00
Jean Chalard
85e88d30c1 Merge "Remove a useless member (A5)" 2012-03-08 02:32:25 -08:00
Jean Chalard
60705c9ed3 Merge "Simplification of sound settings (A4)" 2012-03-08 02:32:16 -08:00
Jean Chalard
d2b5ea2084 Merge "Make a condition positive (A3)" 2012-03-08 02:32:07 -08:00
Jean Chalard
d749fb86ab Merge "Simplify audio management (A2)" 2012-03-08 02:31:57 -08:00
Jean Chalard
7cfae83434 Merge "Export audio and haptic feedback to a specialized class. (A1)" 2012-03-08 02:31:45 -08:00
Tadashi G. Takaoka
411749a4ba Cleanup keyboard theme switching code 
Change-Id: I023769b765d07237b2129d8f1b2a02ffd4c4f09d
 2012-03-08 19:17:31 +09:00
Tadashi G. Takaoka
bcbaffd9dd Fix centering more suggestions panel on tablet 
Bug: 6129726
Change-Id: I8dac3251eec68ad3fb523c632ff39f3cc661c81f
 2012-03-08 19:02:22 +09:00
Jean Chalard
8667bbeab3 Small rename 
Left/Right is wrong terminology here

Change-Id: I58c55849e45d9984dd3fb7b75a64e07667c9eba4
 2012-03-08 18:49:38 +09:00
Jean Chalard
41a2929282 Cleanup unused imports (A7) 
Change-Id: I48ba12e4311cbf2982ee8f5312b279bc8c1fdfe8
 2012-03-08 18:37:03 +09:00
Jean Chalard
544c3c2952 Get the view for haptic feedback as a parameter (A6) 
It's rather annoying (and possibly dangerous) to keep this as a member.
Get it from outside.

Change-Id: I00c42db96395fb65204fb140aeedc82bf312a86e
 2012-03-08 18:37:00 +09:00
Jean Chalard
29d967fdcb Remove a useless member (A5) 
Change-Id: Ibaaeb8dbcb012f5e973e27ed9928401515656e9e
 2012-03-08 18:36:56 +09:00
Jean Chalard
bdbb22bb33 Simplification of sound settings (A4) 
Change-Id: I0c6e207bae1e08c45a95b3479e1d67228d696792
 2012-03-08 18:36:43 +09:00
Jean Chalard
2651b17fc4 Make a condition positive (A3) 
mSoundOn is much easier to understand than mSilentModeOn

Change-Id: Ie51c5c75fcad62e13e0fb578a266af80f15dc440
 2012-03-08 18:36:19 +09:00
Jean Chalard
793791cdf0 Simplify audio management (A2) 
There is little point in deferring loading for this. Getting the
service at startup time is not very expensive anyway, plus we
can avoid getting it in a later change if sound is off in settings.

Change-Id: I08d65467f245fa2f9f617eb23257c327b3115673
 2012-03-08 18:35:48 +09:00
Jean Chalard
564496bad6 Export audio and haptic feedback to a specialized class. (A1) 
Change-Id: I957d883d1ccf188cb98eb11031aa0a32fce4ed76
 2012-03-08 18:35:20 +09:00
Jean Chalard
f8b39f39cd Merge "Remove a useless class (B4)" 2012-03-08 01:14:33 -08:00
Jean Chalard
4b656a3fef Merge "Remove stuff that's not used any more (B3)" 2012-03-08 01:13:06 -08:00
Jean Chalard
d8447ec353 Merge "Use the simple auto-correction status (B2)" 2012-03-08 01:12:46 -08:00
Jean Chalard
fbe767cec5 Merge "Remember auto-correction status simply (B1)" 2012-03-08 00:54:30 -08:00
Jean Chalard
bedb1d33f3 Merge "Give InputLogicTests the ability to change language" 2012-03-07 23:51:29 -08:00
Jean Chalard
274a0643b1 Give InputLogicTests the ability to change language 
Also fix a typo, and increase the time allowed to load the main
dictionary to 2 secs instead of 1.

Bug: 6114326
Change-Id: I5f70b34fc4277c55977b18466253152aa98a2507
 2012-03-08 16:39:29 +09:00
satok
f0d5a78388 Merge "Add functions to calculate proximity characters in the native code" 2012-03-07 23:31:17 -08:00
Tadashi G. Takaoka
3e2d385810 Restart LatinIME service when keyboard theme is changed 
Bug: 6023947
Change-Id: I779da32708fca7333aff74929cc98173246ee685
 2012-03-08 15:08:16 +09:00
satok
a70ee6e3b3 Add functions to calculate proximity characters in the native code 
Bug: 4343280

Change-Id: I17f8f6295b01900948b98680d0267753f33a46cf
 2012-03-08 12:55:15 +09:00
Tadashi G. Takaoka
c648b88779 Merge "Dynamically determine key preview backing view height" 2012-03-07 04:17:52 -08:00
Tadashi G. Takaoka
c8b0e5797e Dynamically determine key preview backing view height 
Bug: 6023947
Change-Id: I53a5c0eb99100a0dfe3e025808f5dc55747d1287
 2012-03-07 20:33:17 +09:00
Tadashi G. Takaoka
cb8d5fa7e2 Merge "Fix duplicate flag value in Key" 2012-03-07 01:53:10 -08:00
Jean Chalard
dab392c6f4 Merge "Fix a bug with successive manual picks" 2012-03-07 01:51:59 -08:00
Tadashi G. Takaoka
8e14e78377 Fix duplicate flag value in Key 
Change-Id: I98e77e5432a228e4455998bf09a2cc671b113c4e
 2012-03-07 18:41:38 +09:00
Jean Chalard
3dd4bcb283 Merge "Recompute suggestions on language change." 2012-03-07 01:35:12 -08:00
Jean Chalard
b84ee82e66 Recompute suggestions on language change. 
Bug: 6106407
Change-Id: I43d9c89610a9ed7a9f6825bd90334d7b343df52c
 2012-03-07 17:35:32 +09:00
Jean Chalard
845b24d9d3 Fix a bug with successive manual picks 
Bug: 6121571
Change-Id: Ib16fbef1087da3b7da5539901ec57156f242f089
 2012-03-07 17:32:42 +09:00
Jean Chalard
f773ef19e8 Remove a useless class (B4) 
\o/

Bug: 5975068
Change-Id: Ia18b55af6d555e7ee7af1cdd7c6227fc1ee6786b
 2012-03-07 15:34:15 +09:00
Jean Chalard
a0beebf711 Remove stuff that's not used any more (B3) 
Change-Id: Ie86675ff2facd37430051bf129ddd930fb933dc9
 2012-03-07 15:32:55 +09:00
Jean Chalard
0a59ac2ba8 Use the simple auto-correction status (B2) 
Change-Id: I9d2f053b6f7bad20fc6afe5f5086a965e5014a5c
 2012-03-07 15:31:22 +09:00
Jean Chalard
70852c91dc Remember auto-correction status simply (B1) 
This duplicates the functionality in ComposingStateManager at
a fraction of the cost. It's not used yet.

Change-Id: Ica2607fb2f7c41e11189fcb566e253db8f62596f
 2012-03-07 15:20:01 +09:00
Tadashi G. Takaoka
65fe7f7994 Merge "Add language switch key only to the phone layouts" 2012-03-06 18:19:45 -08:00
Tadashi G. Takaoka
81d4e3cd66 Add language switch key only to the phone layouts 
Bug: 5759092
Change-Id: Ic7d7d4812976654c0e85fecabd1128eadfc52c5c
 2012-03-07 10:03:21 +09:00
Jean Chalard
89ffb212b4 Make the keyboardswitcher and the subtypeswitcher final. 
Change-Id: Ifcc79357adcc53f93b190b6e98d5569f42f74655
 2012-03-06 19:07:21 +09:00
Jean Chalard
3cd1a00eca Resolve a todo 
This exports some voiceproxy complexity to voiceproxy rather
than keeping it in latinime

Change-Id: I0b3523e77af4104cc3ed28417956059c734c8bfe
 2012-03-06 18:43:18 +09:00
satok
691f1c174b Fix coordinates sent to native code 
Change-Id: I2c8b093b59ad36ffe860c3c4d360d87251d101c4
 2012-03-06 16:38:00 +09:00
satok
231ef8fa3e Merge "Integrate the logic to calculate the proximities" 2012-03-05 23:25:29 -08:00
satok
ca7ec2097c Integrate the logic to calculate the proximities 
Bug: 4343280

Change-Id: I0f6a7e6912ed4abea07c10d266da4c7ccb0dae76
 2012-03-06 15:34:27 +09:00
Jean Chalard
00ed3be95c Correct special space handling of punctuation 
This fixes two defects:
- One where some separators should promote a phantom space to
a real space. This bug had a unit test but wasn't tracked.
- One where French punctuations would behave incorrectly. Tracked
Bug: 6113693

Change-Id: Ia7f86fc960e00141757632ab2c9bce9168dd6966
 2012-03-06 14:00:34 +09:00
Tadashi G. Takaoka
e79b1a8312 Make SuggestedWords immutable completely 
Change-Id: I1b0f7b857e89307c987187c1969a2846aa97fdcc
 2012-03-05 23:06:37 +09:00
Tadashi G. Takaoka
40b6e666e1 Merge "Make SuggestedWords partially immutable" 2012-03-05 05:29:14 -08:00
Tadashi G. Takaoka
8cc8f26adf Make SuggestedWords partially immutable 
Change-Id: I72a2f71d7f6565a30c06e563b0a64f496542cde9
 2012-03-05 22:11:13 +09:00
satok
717f12472f Merge "Remove unused code" 2012-03-05 04:46:09 -08:00
satok
433be45fce Merge "Refactor to suppress null worning" 2012-03-05 04:08:23 -08:00
satok
add6dfb8fe Remove unused code 
Change-Id: I894c0850e803bdfc7b590a62ddd4076a3a4e4658
 2012-03-05 21:07:03 +09:00
Tadashi Takaoka
d5b6360549 Merge "Revert "Make SuggestedWords immutable"" 2012-03-05 02:57:00 -08:00
Tadashi Takaoka
d62fa834c6 Revert "Make SuggestedWords immutable" 
This reverts commit c208f4dfb7
 2012-03-05 02:54:21 -08:00
Jean Chalard
6a830277df Merge "Refactoring" 2012-03-05 01:49:46 -08:00
Jean Chalard
611a5bdf65 Refactoring 
Change-Id: I2f92c01fa1ff6b318128d387f26942b5d47de3e0
 2012-03-05 18:36:51 +09:00
satok
370674422a Refactor to suppress null worning 
Change-Id: I4b4dc6f86d659491d8b9a74ed120092eab964345
 2012-03-05 18:15:29 +09:00
Tadashi G. Takaoka
8c80fb9bcb Fix Key to use a disabled icon when the key is disabled 
Bug: 6114350
Change-Id: I419bc1736c27046dfea254ac510f5da478b6412c
 2012-03-05 18:01:33 +09:00
Tadashi G. Takaoka
c208f4dfb7 Make SuggestedWords immutable 
Change-Id: I26bd82aee5ead84e40abfc3db5a48ed6d1e42361
 2012-03-05 17:24:30 +09:00
Tadashi G. Takaoka
e5cbc94d10 Merge "Support embedded more key" 2012-03-04 22:10:22 -08:00
Jean Chalard
895b70b8af Move some treatment to a more sensical place. 
It makes more sense to catch words with the safety net in
updateSuggestions() than in showSuggestions(). Also, it's useless
to do it in updateBigramPredictions, because the result will
always be provably false.
This will also help with writing unit tests.

Change-Id: Ifab81e6c5a74b1aa75cf85ef7742fee69a98f5ce
 2012-03-05 14:27:49 +09:00
Tadashi G. Takaoka
e491be6e86 Support embedded more key 
This is a followup change to Ie10b3e0b.

Change-Id: I1f91d96e32357b83bd0546537d561d638b6ff0c6
 2012-03-05 14:22:52 +09:00
Jean Chalard
9b01890254 Move a method to a more sensical place. 
Change-Id: I11f87448f689cf828bff960ad7a3e4739a3457dc
 2012-03-05 14:19:35 +09:00
Jean Chalard
611ec69413 Remove a useless method 
Change-Id: I2002662ee07af2fcc626a52ea4e9ad8977b29ca2
 2012-03-05 12:46:35 +09:00
Jean Chalard
428178aca6 Merge "Replace a useless computation with a constant" 2012-03-04 19:35:11 -08:00
Jean Chalard
4ab5486bf2 Merge "Remove a useless test" 2012-03-04 19:35:02 -08:00
Jean Chalard
4e112d0782 Replace a useless computation with a constant 
This is provably always false

Change-Id: I88d783fa59fec0b7a729558ba974a6a58c158645
 2012-03-05 11:57:36 +09:00
Jean Chalard
a04d2358c0 Remove a useless test 
With the current logic, this test provably always resolves
to false.

Change-Id: Iba84ef5f3a14cd8ac48c6a813519ab283bf605f8
 2012-03-05 11:38:45 +09:00
Tadashi G. Takaoka
50b82dca62 Merge "Fix comment" 2012-03-04 18:28:01 -08:00
Tadashi G. Takaoka
49079df8ec Merge "Omit InputMethodManagerCompatWrapper argument from some utility methods" 2012-03-04 18:12:47 -08:00
Tadashi G. Takaoka
04bc787ce7 Fix comment 
This is follow up of  Ie10b3e0.

Change-Id: Idefbe1575915bb87f1c86cb3ddb5efe578c5b760
 2012-03-05 11:10:28 +09:00
Tadashi G. Takaoka
2d25ba2750 Omit InputMethodManagerCompatWrapper argument from some utility methods 
Change-Id: Ic837018c702c8c575de3e5e81fe8e31fee16fe22
 2012-03-05 10:43:12 +09:00
Jean Chalard
c2136c4e63 Merge "Some renaming" 2012-03-04 17:26:22 -08:00
Svetoslav Ganov
0af449aa64 Merge "Added virtual view hierarchy for keyboard accessibility." 2012-03-02 15:39:12 -08:00
Jean Chalard
a157249014 Merge "Remove a useless method" 2012-03-02 05:57:48 -08:00
Jean Chalard
e53840d216 Merge "Some more simplification" 2012-03-02 05:56:58 -08:00
Tadashi G. Takaoka
508ded5827 Fix long press behavior of akye that has altCode defined 
This issue has been introduced by I2bd4daf2

Change-Id: Ie10b3e0bb360986597a0f5a8e5b8253400f924c4
 2012-03-02 21:29:51 +09:00
Tadashi G. Takaoka
3a1844c33b Merge "Support dividers in MoreKeysKeyboard" 2012-03-02 03:58:13 -08:00
Tadashi G. Takaoka
5ef4fccbb9 Support dividers in MoreKeysKeyboard 
Bug: 6080806
Change-Id: Iacd78c6aab6abf948717d34da7489a79c41316d2
 2012-03-02 20:52:25 +09:00
Jean Chalard
a83a53ba24 Some renaming 
Change-Id: I445277cb3af469a0145a8da0ffb801b7e19048cd
 2012-03-02 20:46:54 +09:00
Jean Chalard
5edda4111e Remove a useless method 
Change-Id: I038e6a82b6463a2a8ec494171a596d76fbc75fe1
 2012-03-02 20:38:41 +09:00
Jean Chalard
dd931c47be Some more simplification 
I wish "are we autocorrecting?" was not computed in a dozen
places all depending on a hundred code paths
More than likely, this fixes very subtle discrepancies
between auto-correction indicator with the underline and with
the LED on the spacebar - which is not displayed any more in
the current version anyway. Especially, the LED probably
would have been off when the word was caught by the safety net.

Change-Id: Idda3021771081d6155b06915e728ecd64d9e042e
 2012-03-02 20:34:10 +09:00
Jean Chalard
e2a50bd804 Optimization 
Avoid doing some useless processing.

Change-Id: I4ce0a188e10db30322bd25751dc5c09492cea301
 2012-03-02 20:26:51 +09:00
Jean Chalard
7204eab3da Precompute two values that never change 
Change-Id: Ic54e7926028ea8374564da5e5004d710f42c53e1
 2012-03-02 20:04:42 +09:00
Jean Chalard
38e535e596 Change a parameter type to make a call clearer 
Change-Id: I2918d0a8b00da743689b919f80128bbf36973f24
 2012-03-02 20:01:34 +09:00
Jean Chalard
5bc2b61274 Move a method up a level 
Change-Id: I6b9a697480127e4745698ab19f8a360b86ff39ca
 2012-03-02 19:59:55 +09:00
Jean Chalard
d02783cb63 Break out a method 
Change-Id: Ia14fc320422b7f198c33ba522bb93dd70fbcb2c1
 2012-03-02 19:52:06 +09:00
Jean Chalard
5a2c19d4fb Merge "Revert "Make a member read-only"" 2012-03-02 02:49:42 -08:00
Jean Chalard
f1967ce322 Revert "Make a member read-only" 
This reverts commit 6a43e39bf0
 2012-03-02 02:49:24 -08:00
Jean Chalard
9727aea418 Merge "Small refactor (A1)" 2012-03-02 02:47:42 -08:00
Jean Chalard
d153228013 Merge "Make a member read-only" 2012-03-02 02:29:41 -08:00
Jean Chalard
6a43e39bf0 Make a member read-only 
Change-Id: I9a718eaf07e1b6c659e649350d3605f365db2839
 2012-03-02 19:17:57 +09:00
Jean Chalard
d992fa847d Small refactor (A1) 
Change-Id: Ia0838bbce47a2b60067f464685ad6d55ee4ec934
 2012-03-02 18:55:04 +09:00
Jean Chalard
7293b65841 Remove a useless method 
Change-Id: Ic00520b18f74838fe1002a679952f62bc7226c15
 2012-03-02 18:49:24 +09:00
Tadashi G. Takaoka
025a16c31c Readable debug output 
Change-Id: I4110791832d2ab1d681b01c9e8a237567442c827
 2012-03-02 14:48:10 +09:00
Tadashi G. Takaoka
ede2133cb1 Support time, date, and datetime keyboard 
Bug: 6030364
Change-Id: I2bd4daf264757d8f3fa7c946d10a39c36ccf5905
 2012-03-02 14:01:07 +09:00
Tadashi G. Takaoka
961703841e Merge "Explicitly specify that labels might be in more keys" 2012-03-01 03:56:32 -08:00
Tadashi G. Takaoka
e4c45c6ef9 Explicitly specify that labels might be in more keys 
Bug: 6080806
Bug: 6081427
Change-Id: I455a0210e65ea2a7774e0e0071cea5f4a99577bd
 2012-03-01 20:03:47 +09:00
Jean Chalard
895da64b62 Merge "Change a dangerous ID" 2012-03-01 02:28:08 -08:00
Jean Chalard
fa12acb8b7 Change a dangerous ID 
The message id 0 is used intrinsically by the framework
for all messages without a specific ID. Using 0 here
we can't reliably use the post(Runnable) method on our
handler, because these would in *some* respects be taken
for update_suggestion messages, but not all.
For example, they'd be removed on removeMessage() but
they would not trigger the actual process. This would
lead to utter confusion.

Change-Id: I5d9b01d38e2ff090cd0d80c27421dc8a41c317b8
 2012-03-01 19:05:51 +09:00
Tadashi G. Takaoka
42fd1d2d72 Refactor more keys spec handling 
Change-Id: Ibd95eff0725724ea35ad58e1d1ec7ec3d02a6e90
 2012-03-01 16:07:02 +09:00