Commit graph

6908 commits

Author SHA1 Message Date
Keisuke Kuroyanagi
5c1416e426 Merge "Remove DictionaryUpdateController." 2014-04-28 08:29:02 +00:00
Keisuke Kuroyanagi
dff7153820 Merge "Use different user dict name for spell checker." 2014-04-28 08:12:17 +00:00
Keisuke Kuroyanagi
a5202c7143 Merge "Use different contacts dict name for spell checker." 2014-04-28 07:58:41 +00:00
Keisuke Kuroyanagi
07c5b307d6 Remove DictionaryUpdateController.
Bug: 8187060
Change-Id: I3e1fa4060d8a5c12d8d609be3357d56051fb5815
2014-04-28 16:58:27 +09:00
Keisuke Kuroyanagi
c5de887fd2 Merge "Move dicts for spellchecker to under spellcheck." 2014-04-28 07:51:29 +00:00
Keisuke Kuroyanagi
6256ec0587 Merge "Fix: Typed word is not included in more suggestions." 2014-04-28 07:46:21 +00:00
Keisuke Kuroyanagi
817cd9a0d5 Use different user dict name for spell checker.
Bug: 13630847
Change-Id: Icabd08c674dcf086250b9e594328a43286d1d203
2014-04-28 16:31:20 +09:00
Keisuke Kuroyanagi
60763a06e8 Use different contacts dict name for spell checker.
Bug: 13630847
Change-Id: I016a464890d5e63794fb1288b4ce7b09adffc453
2014-04-28 16:25:10 +09:00
Keisuke Kuroyanagi
24ec8bd91b Move dicts for spellchecker to under spellcheck.
Bug: 13630847

Change-Id: Iadcf5b31f66fb73efc5c640e96e8c2106a0224dd
2014-04-28 16:24:35 +09:00
Keisuke Kuroyanagi
a8c4731eab Fix: Typed word is not included in more suggestions.
Happened when top suggestion is long and auto-corrected.
Bug: 13738879

Change-Id: I47c2dfb34cfc92b54cfe54c432ee2f646fe454e5
2014-04-28 16:21:27 +09:00
Yohei Yukawa
91db602b83 Merge "Use shouldOfferSwitchingToNextInputMethod when available" 2014-04-28 06:58:02 +00:00
Yohei Yukawa
8ba4f33709 Use shouldOfferSwitchingToNextInputMethod when available
With this CL, LatinIME starts using
InputMethodManager#shouldOfferSwitchingToNextInputMethod when
available and API level is higher than 19 (KitKat).

Note that relevant settings of LatinIME will be ignored if
InputMethodManager#shouldOfferSwitchingToNextInputMethod is
considered to be available at the moment. We will revisit
here to reorganize the user visible settings before the
new global IME switching mechanism becomes publicly
available.

BUG: 12965588
Change-Id: I0188fa56cba8e983c61cef3ae3400a0e3821f718
2014-04-28 15:11:19 +09:00
Tadashi G. Takaoka
0b42851eed Merge "Move some advanced settings to debug settings" 2014-04-28 05:30:28 +00:00
Tadashi G. Takaoka
2cc7c3321d Merge "Remove unnecessary reference to LatinIME" 2014-04-25 22:20:58 +00:00
Tadashi G. Takaoka
7a78127a56 Remove unnecessary reference to LatinIME
Change-Id: Idbb45c504499d39bbf272fae84ea71a83bf4dd69
2014-04-25 15:09:39 -07:00
Keisuke Kuroyanagi
169acbf9f0 Add null check in createDistracterFilter().
Change-Id: Iff2b73081d48f32b1d3a5d5b32c9734979362c23
2014-04-25 13:36:46 -07:00
Tadashi G. Takaoka
a3920c7e6a Move some advanced settings to debug settings
This CL moves "Show slide indicator" and "Key long press delay"
advanced options to the debug settings.

Bug: 11866784
Change-Id: Iec16e09ba6e7c9f82ce0fa73a0d75766b843b44b
2014-04-25 12:03:47 -07:00
Xiaojun Bi
516c884b11 Merge "Prepare to implement distracter filter" 2014-04-25 17:15:53 +00:00
Xiaojun Bi
281dd99346 Prepare to implement distracter filter
It was implemented according to the Plan B in the
design doc:
http://go/ime-misspelling-filter

This CL is to create a DistracterFilter instance
and pass it to PersonalizationDictionarySessionRegistrar.

This patch should be checked in together with
Id633b4fd45693

Bug: 13142176
Change-Id: Ia4957e64218c9619fcf9bb91795a187617c72a2e
2014-04-25 09:13:22 -07:00
Keisuke Kuroyanagi
e581d8f8ab Merge "Fix: contains() is wrongly used in hasDict()." 2014-04-25 07:58:19 +00:00
Keisuke Kuroyanagi
bdf31fb75e Fix: contains() is wrongly used in hasDict().
Change-Id: I4699b1b75fed9dd479f5135f0a7a2dd098e6f798
2014-04-25 00:56:27 -07:00
Keisuke Kuroyanagi
1ed248dc2f Merge "Fix: Wrong null check for user history dict." 2014-04-25 06:48:16 +00:00
Keisuke Kuroyanagi
93f4aec07c Fix: Wrong null check for user history dict.
Change-Id: Idf0bcc44247e35cd95f9482d2a8017329fc977bb
2014-04-24 23:08:48 -07:00
Keisuke Kuroyanagi
a9861ac814 Merge "Handle personalization dictionary as an ExpandableBinaryDictionary." 2014-04-25 04:56:14 +00:00
Keisuke Kuroyanagi
194d64fa58 Merge "Handle contacts dictionary as an ExpandableBinaryDictionary." 2014-04-25 04:54:09 +00:00
Keisuke Kuroyanagi
56e4848ead Handle personalization dictionary as an ExpandableBinaryDictionary.
Bug: 13755213
Change-Id: I26e070e89e09b37e9dcc200d597c74c591467a66
2014-04-24 21:37:49 -07:00
Keisuke Kuroyanagi
98e276a0ec Merge "Quit creating empty dictionary file in ExpandableBinaryDictionary." 2014-04-25 04:36:55 +00:00
Keisuke Kuroyanagi
62c110a4c0 Handle contacts dictionary as an ExpandableBinaryDictionary.
Bug: 13755213
Change-Id: I0eb5055f9cdf5e1df337cdace9bf0919d4d365d3
2014-04-24 21:36:30 -07:00
Keisuke Kuroyanagi
3d2a9af20a Merge "Handle user history dictionary as an ExpandableBinaryDictionary." 2014-04-25 04:30:39 +00:00
Keisuke Kuroyanagi
a933776bf1 Merge "Simplify DictionaryFacilitatorForSuggest to be flexible." 2014-04-25 04:29:50 +00:00
Keisuke Kuroyanagi
67c0ed8f8c Handle user history dictionary as an ExpandableBinaryDictionary.
Bug: 13755213
Change-Id: I1ea8a6df007af7153852f2d32bf5e8ec669c432b
2014-04-24 14:48:01 -07:00
Tadashi G. Takaoka
e2651aa450 Merge "Announce keyboard language when TalkBack is on" 2014-04-24 20:40:31 +00:00
Keisuke Kuroyanagi
3d658a63ca Merge "Remove clearAndFlushDictionary() and use clear()." 2014-04-24 18:29:05 +00:00
Keisuke Kuroyanagi
978958a41f Simplify DictionaryFacilitatorForSuggest to be flexible.
Bug: 13755213
Change-Id: I151269a7038b72a33b436da4c7596e09949e6d00
2014-04-24 11:25:50 -07:00
Keisuke Kuroyanagi
2dcb5c1b4d Remove clearAndFlushDictionary() and use clear().
clearAndFlushDictionary() was needed when dictionaries are constructed
in java side. All expandable dictionaries now use native code; thus,
this method is same to clear() and no longer needed.

Bug: 13755213
Change-Id: Ifd836e64f8ff807930f7cd2319b103b65e8fce70
2014-04-24 11:25:47 -07:00
Tadashi G. Takaoka
b9e0b99765 Merge "Fix handling shift + enter" 2014-04-24 02:38:46 +00:00
Tadashi G. Takaoka
393da03c8e Fix handling shift + enter
Bug: 14278758
Change-Id: Id77c99b83cc69855972b27c9cebd482c8cbd3539
2014-04-23 19:22:00 -07:00
Tadashi G. Takaoka
f7edc6582a Move simulateKeyPress method to AccessibleKeyboardViewProxy
Change-Id: Ic14ff70c7c8475983cf02dc1ba4d5a5f7769aa16
2014-04-23 17:48:27 -07:00
Tadashi G. Takaoka
3cf759074a Announce keyboard language when TalkBack is on
Bug: 13013501
Change-Id: I0595abafbc177f776676cb3560f3990da9328db2
2014-04-23 13:53:06 -07:00
Keisuke Kuroyanagi
7de3d0eed7 Merge "Fix: Reporting wrong main dictionary availability." 2014-04-22 23:32:50 +00:00
Keisuke Kuroyanagi
de4d401038 Fix: Reporting wrong main dictionary availability.
Bug: 13965806
Change-Id: Ida2234ab8cb7785ec5efd433a58949bf21c44351
2014-04-22 16:24:22 -07:00
Tadashi G. Takaoka
5179608e19 Merge "Use ArrayList constructor directly" 2014-04-22 21:54:00 +00:00
Tadashi G. Takaoka
965621574d Use ArrayList constructor directly
This is a follow up of I85a0b18d2d.

Change-Id: Ia7a642bb6e0015242d6e046019b3973226a0add2
2014-04-22 14:36:38 -07:00
Tadashi G. Takaoka
9d84d67b44 Fix typo of local variable name
Change-Id: I09c0aeee979e883af199f5c533d526a089064987
2014-04-22 14:25:53 -07:00
Tadashi G. Takaoka
616b84c93e Merge "Use sorted keys index as virtual view id" 2014-04-22 20:58:24 +00:00
Keisuke Kuroyanagi
d437df0ab0 Quit creating empty dictionary file in ExpandableBinaryDictionary.
Bug: 14166482
Change-Id: I7b7a25141851d7bb14744567639d8e5d8f04a036
2014-04-22 13:18:36 -07:00
Keisuke Kuroyanagi
3b7984752c Support creating BinaryDictionary without creating dict file.
Bug: 14166482
Change-Id: Ic8c78ec2c8f39358a1f085a041b608972a380eef
2014-04-22 13:18:34 -07:00
Keisuke Kuroyanagi
ce76821dce Revert "Support creating BinaryDictionary without creating dict file."
This reverts commit 89939b8708.

Change-Id: I8ca1b55609ad305a93178063bd88bd1cede872af
2014-04-22 19:34:44 +00:00
Tadashi G. Takaoka
9289260822 Use sorted keys index as virtual view id
Change-Id: Id3f81de1edaacc06362b65aa7b68e9317e6596bd
2014-04-22 12:15:52 -07:00
Keisuke Kuroyanagi
89939b8708 Support creating BinaryDictionary without creating dict file.
Bug: 14166482
Change-Id: Ib065279f96e227ab0fee7c8141560c4ada744d3b
2014-04-22 12:01:33 -07:00
Keisuke Kuroyanagi
68b4f2ada9 Merge "Add jni interface to use on memory dictionary." 2014-04-22 17:07:16 +00:00
Tadashi G. Takaoka
543d3d24bd Stop using Configuration.setLocale
The call for method Configuration.setLocale that is introduce by
If60877b29b should be remove to be compatible with API 14 and later.

Bug: 14239862
Change-Id: I3815c2b56bd9c655b8bde6f93143adf3ff08c35d
2014-04-22 09:22:46 -07:00
Keisuke Kuroyanagi
61cb852d33 Add jni interface to use on memory dictionary.
Bug; 14166482

Change-Id: I33ab08dad1e39aa7617d391f7eb2561d6f2504bb
2014-04-21 19:59:09 -07:00
Tadashi G. Takaoka
a685fc1792 Merge "Remove unnecessarily getKeyFromOutputText method from Keyboard" 2014-04-22 01:57:32 +00:00
Tadashi G. Takaoka
543d25d786 Merge "Sort keys from top-left to bottom-right order" 2014-04-22 01:52:00 +00:00
Tadashi G. Takaoka
0ea82be889 Remove unnecessarily getKeyFromOutputText method from Keyboard
Change-Id: I61986ed65ce6696a8b0d885bdeb9668e6087bc47
2014-04-21 18:48:53 -07:00
Tadashi G. Takaoka
c13c1adfa7 Sort keys from top-left to bottom-right order
Change-Id: I228748824de62e9e46fa43db200d23f41eb6d2ce
2014-04-21 18:36:11 -07:00
Keisuke Kuroyanagi
3acbf7d00c Merge "Add BinaryDictionary.flushWithGCIfHasUpdated()." 2014-04-22 00:10:42 +00:00
Keisuke Kuroyanagi
c6704dbe51 Add BinaryDictionary.flushWithGCIfHasUpdated().
Bug: 14166482
Bug: 14161647
Change-Id: I98b0a8b86897b1486491a3aea91729bc9e4cc03c
2014-04-21 15:21:55 -07:00
Tadashi G. Takaoka
5326dcfb7d Use unmodifiable list to return keys from Keyboard
Change-Id: I85a0b18d2d78632e9a9f074eda1de9225001f876
2014-04-21 14:31:27 -07:00
Tadashi G. Takaoka
58d4e610ac Use unmodifiable list to return the nearest keys
Change-Id: Ic9084b08fa9a1f25b7f4b98c627350583c401c12
2014-04-21 14:30:59 -07:00
Tadashi G. Takaoka
064af5c0fc Stop using modifiable Key array
Change-Id: I0f3e96672da4261ae5628d2d5ea39d60e6287ac0
2014-04-21 13:52:00 -07:00
Xiaojun Bi
11b7076168 Fix a bug for counting code points in WordComposer.java
This bug threw an ArrayIndexOutOfBoundsException when the word length
is 49 (maxSize + 1) when calling StringUtils.copyCodePointsAndReturnCodePointCount(...)
in the same function. This bug is discovered by running SKETCH.

The intent is to count the code points from index 0 to index i (included).
The original code only counted the code points from index 0 to index (i-1).

Bug: 13969542
Change-Id: Idbf596aba2379ba552dbe580c83c42044d505aaf
2014-04-18 14:56:35 -07:00
Tadashi G. Takaoka
a980fb39a5 Merge "Refactor RunInLocale a bit" 2014-04-17 08:59:25 +00:00
Tadashi G. Takaoka
8180b02bed Merge "Add contentDescription to Emoji palette" 2014-04-17 08:56:22 +00:00
Tadashi G. Takaoka
bfc998096b Add contentDescription to Emoji palette
This CL adds content descriptions of:
- Emoji Category icon/label.
- Delete key
- Space key

Bug: 11452158
Change-Id: Ic00592c560b6265c880cd25f2e18cfd349b4620b
2014-04-17 17:43:34 +09:00
Tadashi G. Takaoka
5c490e5da5 Refactor RunInLocale a bit
Change-Id: If60877b29bb1263161ec85c99320ad07b7dd4245
2014-04-17 17:39:19 +09:00
Jean Chalard
20b0c3c5a9 Merge "Avoid lower-case version of capitalized words in user hist" 2014-04-17 08:22:42 +00:00
Jean Chalard
649dcba5a8 Avoid lower-case version of capitalized words in user hist
Bug: 14096825
Change-Id: Ib6cc8fc31e90862e0b05f5a06757a73069726b74
2014-04-17 16:41:26 +09:00
Jean Chalard
86ff9d6dda Merge "Fix a wrong parameter passed." 2014-04-17 07:39:52 +00:00
Jean Chalard
26611120c9 Fix a wrong parameter passed.
Bug: 14120001
Change-Id: I8258304bc500fe28870fb8a5c11c15d97795423c
2014-04-17 15:44:55 +09:00
Keisuke Kuroyanagi
b21edc4402 Shuwdown executors after executing all tasks.
Bug: 14113276
Change-Id: Ie42ef30ffe5767ca434db4669efad2027b474e74
2014-04-17 09:28:52 +09:00
Jean Chalard
ba635ad30d Merge "Restart suggestions when restarting input" 2014-04-16 10:43:28 +00:00
Tadashi G. Takaoka
166fd799d4 Merge "Dismiss more suggestions before showing important notice" 2014-04-16 09:43:39 +00:00
Jean Chalard
3aba6263f0 Restart suggestions when restarting input
Bug: 6851364
Change-Id: I3052924053f37f56c9c3953051aa1b22224a2b2e
2014-04-16 17:02:08 +09:00
Tadashi G. Takaoka
c8abd13c77 Dismiss more suggestions before showing important notice
Bug: 14078601
Change-Id: I029cadd8f2f170b5a3e70df170e306c9be109a70
2014-04-16 15:40:39 +09:00
Jean Chalard
66e509b1d4 Fix some failing tests
Bug: 13968927
Change-Id: I7e5e075535e38bf0fa24af98ed6e2cdfd6de6556
2014-04-15 21:44:46 +09:00
Jean Chalard
1ee443d848 Merge "[IL135] Make getCurrentAutoCapsState private" 2014-04-15 02:27:52 +00:00
Jean Chalard
82d3a56b09 Merge "[IL134] Add an alternative path to getCurrentAutoCapsState" 2014-04-15 02:24:41 +00:00
Jean Chalard
751dc070bf Merge "Fix updating the shift state upon backspace" 2014-04-14 12:31:22 +00:00
Jean Chalard
2282e8520a Fix updating the shift state upon backspace
Bug: 13514349
Change-Id: If4c9db12b0ab5be676f7a2f72715f469066ee537
2014-04-14 21:28:24 +09:00
Jean Chalard
f091c491ea [IL135] Make getCurrentAutoCapsState private
Bug: 8636060
Change-Id: I800aefe6fee4c14df6fe5abe21b2387c69abb8f5
2014-04-14 21:09:32 +09:00
Jean Chalard
ddc163988a [IL134] Add an alternative path to getCurrentAutoCapsState
Bug: 8636060

Change-Id: I959e13d34910adad028ed6174f92029ff690eeeb
2014-04-14 21:09:32 +09:00
Tadashi G. Takaoka
c3a19a5249 Remove GingerBread keyboard theme
This CL must be checked in together with I6a9ac172a5.

Bug: 14042743
Change-Id: Ic3f01f5d10097d743325df847bd7cd2959992487
2014-04-14 19:05:21 +09:00
Tadashi G. Takaoka
21eafd7910 Use KeyboardTheme id insteand of index
This CL must be checked in together with I771216f8bd.

Bug: 14042743
Change-Id: I45c3acf9242985fb03721a9a6d377fbccc8e2019
2014-04-14 18:59:54 +09:00
Tadashi G. Takaoka
3568fca95f Merge "Refactor KeyboardTheme as top-level class" 2014-04-14 09:57:36 +00:00
Tadashi G. Takaoka
d6aa94e6b5 Refactor KeyboardTheme as top-level class
This CL should be checked in together with I63e33388f9.

Bug: 14042743
Change-Id: I13f0a45bac6f19e006bf1280a36173e52d6d7160
2014-04-14 17:10:11 +09:00
Tadashi G. Takaoka
30d5ed67d6 Keep ImportantNoticeDialog showing after orientation changed
Bug: 13951402
Change-Id: Ia6340d48843abca68ebadd299827cbe43516cc39
2014-04-14 15:48:19 +09:00
Yohei Yukawa
da498229f4 Merge "Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR" 2014-04-13 12:56:43 +00:00
Jean Chalard
4f4770cbf0 Merge "[CB26] Remove useless variables." 2014-04-11 10:00:57 +00:00
Tadashi G. Takaoka
977d052f8c Revise myanmar keyboard layout
Note that this keyboard layout is still a preliminary.

Bug: 7963632
Change-Id: I4c53b3359ea2c0dd8e2ce7db8ec916ab9340eec5
2014-04-11 15:29:30 +09:00
Yohei Yukawa
fab4ce43f8 Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR
With this CL, LatinIME starts calling
InputMethodService#setCursorAnchorMonitorMode in #onStartInput()
when ProductionFlag.USES_CURSOR_ANCHOR_MONITOR flag is explicitly
set to true.

BUG: 13891796
Change-Id: Ib2fb0c3521b61859d4cc530155ccaaee7ee16cbc
2014-04-11 12:26:33 +09:00
Jean Chalard
cb05dc1d1b Merge "[IL133] Avoid calling a dangerous method from outside." 2014-04-10 09:15:13 +00:00
Jean Chalard
1ef9d5938e [CB26] Remove useless variables.
This is nice for code simplicity, but it has a small adverse impact on
performance.

Bug: 13406701
Change-Id: I9316b3fe8d79b940fbd83cf1187c8c0d10b26c71
2014-04-10 18:13:35 +09:00
Tadashi G. Takaoka
cc729b6df5 Merge "Refactor SubtypeLocaleUtils a bit" 2014-04-10 08:51:03 +00:00
Jean Chalard
2e967f6607 Merge "Fix some flaky tests." 2014-04-10 08:47:20 +00:00
Jean Chalard
4370ff0998 Fix some flaky tests.
In tests, we create many instances of LatinIME, but we never
destroy them. That means we never close the dictionaries nor
the handlers.
This change calls onDestroy, which closes all dictionaries, and
adds some code to finish the handlers.

Change-Id: I942517a2a940c54256b08763f6b38f5b55809f55
2014-04-10 17:32:05 +09:00
Tadashi G. Takaoka
58e830ec19 Refactor SubtypeLocaleUtils a bit
Change-Id: If8b7fd5ef0b4ff3791deeacc12abb256a10176bf
2014-04-10 17:24:58 +09:00
Tadashi G. Takaoka
9eec53a2c2 Merge "Reorder German umlaut letters" 2014-04-10 06:26:21 +00:00
Tadashi G. Takaoka
784a4429ea Reorder German umlaut letters
Bug: 13940739
Change-Id: I2e377b56e4a74d36c7e0cea4ad4e8d9341eb7feb
2014-04-10 15:24:45 +09:00
Tadashi G. Takaoka
ac5e6ddd97 Add Italian (Switzerland) it_CH layout
Bug: 13920900
Change-Id: I57df8ca12b0d8cc4bbca2372c0470dcae5b5cbfb
2014-04-10 11:56:44 +09:00
Yohei Yukawa
a4ac18551f Merge "Add a new production flag for Cursor/Anchor monitor" 2014-04-09 12:36:28 +00:00
Yohei Yukawa
485114905e Add a new production flag for Cursor/Anchor monitor
BUG: 13891796
Change-Id: I3565ca22aaf1d3cfce4f35999e2990b2df5157ef
2014-04-09 21:13:34 +09:00
Jean Chalard
77dd17ad36 Merge "[CB25] Refactor some array copying" 2014-04-09 09:57:00 +00:00
Jean Chalard
5f430e0189 [CB25] Refactor some array copying
Bug: 13406701
Change-Id: I09edd822f5cc2446b324d41c76d835bcff1191e6
2014-04-09 18:38:29 +09:00
Tadashi G. Takaoka
d317796207 Use Locale to process text resources
Change-Id: Ic1c4e1776071332e02c368055157124bb539d14e
2014-04-09 18:28:17 +09:00
Jean Chalard
45e34b4374 [CB24] Remove a useless test
If 1 character, then for sure !isGesture

Bug: 13406701
Change-Id: If8e9b080372eb8ddb15b8f97cce1399dc0c7f099
2014-04-08 21:36:52 +09:00
Yohei Yukawa
36dfb6d1a4 Fix build breakage caused by I0218dd07
BUG: 11746191
Change-Id: I0b693c4b22793f6e8fd77a9f045f205aa8fe4050
2014-04-08 20:00:16 +09:00
Yohei Yukawa
c9539f42f6 Merge "Add StatsUtils for checking state" 2014-04-08 10:23:41 +00:00
Tadashi G. Takaoka
6bb3556ff7 Use locale to look up KeyboardTextsTable
Change-Id: I1e05c7fdbb757efef0e9407dc25482ef1115e49a
2014-04-08 19:12:31 +09:00
Yohei Yukawa
dc0f7ca167 Add StatsUtils for checking state
BUG: 11746191
Change-Id: I0218dd07dde1d09321009ea1497258fc4235a1e8
2014-04-08 19:09:49 +09:00
Tadashi G. Takaoka
ceda8b925f Update KeyboardTextsTable.java
Change-Id: I821eb214f3a8c34e91ca9bbf116cc53389a2fff0
2014-04-08 16:16:05 +09:00
Tadashi G. Takaoka
a857235d0c Merge "Remove workaround code of placing DrawingPreviewPlacerView" 2014-04-07 08:58:20 +00:00
Tadashi G. Takaoka
0c01fc6f1c Remove workaround code of placing DrawingPreviewPlacerView
This CL divides MainKeyboardView.locatePreviewPlacerView method into
two methods. One is installing DrawingPreviewPlacerView to the window
as Frontmost view. Another is telling the location of MainKeyboardView
to DrawingPreviewPlacerView. Thus we can eliminate workaround code to
deal with transient states in orientation change.

Change-Id: Ia5d8f28dfb5213d27aa218c72d838a3c3be5a527
2014-04-07 17:36:53 +09:00
Jean Chalard
da5c206934 Merge "[CB23] Merge add and deleteLast" 2014-04-07 08:16:36 +00:00
Jean Chalard
b724617b41 Merge "[CB22] Merge add and delete" 2014-04-07 06:59:07 +00:00
Jean Chalard
d52bec0069 [CB23] Merge add and deleteLast
Bug: 13406701
Change-Id: Id9a2e4144b1908ad27d78228ee19e6fc4d4d669f
2014-04-07 15:51:44 +09:00
Jean Chalard
633e4f4533 [CB22] Merge add and delete
...but this time, it works.

Bug: 13406701
Change-Id: Iaa00339a6be76413ffaeb74ff1556e15b3bb039d
2014-04-07 15:47:01 +09:00
Tadashi G. Takaoka
b6c70f4ed3 Remove unneeded CustomViewPager class
Originally this hacky class has been introduced by I0824f82c30 to
address bug: 11721001.  Because the bug: 11721001 has been addressed
by I950f13ec40 and etc., this class should be removed.

Bug: 13665882
Change-Id: Iabdd369e4dddb0188534289eea1269fb196895eb
2014-04-07 12:41:51 +09:00
Ken Wakasa
e2e41dc22c Merge "Revert "[CB22] Merge add and delete"" 2014-04-04 18:26:06 +00:00
Ken Wakasa
ef0498a8cc Revert "[CB22] Merge add and delete"
This reverts commit f6bce235ae.

Seeing several new unit test failures after this CL. Reverting..

Change-Id: Ie97127550ee36dd4a07a36701e9c5118684dfbc5
2014-04-04 18:25:34 +00:00
Jean Chalard
f9516b00ec Merge "[IL132] Remove some calls that let a value escape." 2014-04-04 13:33:26 +00:00
Jean Chalard
76c930eede Merge "[CB22] Merge add and delete" 2014-04-04 10:10:55 +00:00
Tadashi G. Takaoka
9b46ddc1d5 Use platform default theme for activities and dialogs
Bug: 13698528
Change-Id: Ib904c911452525e3749c0eb287434b504576db5f
2014-04-04 17:13:54 +09:00
Jean Chalard
f977ca6c92 Merge "[CB21] More refactoring" 2014-04-04 06:56:49 +00:00
Jean Chalard
9298c9b1e1 Merge "Reset the client database on version upgrade." 2014-04-04 05:12:02 +00:00
Jean Chalard
4ac0904f83 Merge "[CB20] Some more refactoring" 2014-04-04 05:03:45 +00:00
Jean Chalard
2e5e74d367 Reset the client database on version upgrade.
Bug: 13632164
Change-Id: Iba333db63558254d760fc80244b3c9753c26b069
2014-04-03 23:20:20 +09:00
Jean Chalard
28a59dd049 Fix a bug with double-space-to-period
Bug: 13778001
Change-Id: I3ebd57950cdfacbbcdc64ed214c0590519a0665c
2014-04-03 22:07:57 +09:00
Jean Chalard
c5bd35e45f Merge "[IL131] Cleanup some cruft" 2014-04-03 09:52:10 +00:00
Keisuke Kuroyanagi
fdd2db576d Always close binary dicts for personalized dicts.
Bug: 10923130
Bug: 13664080
Change-Id: Ib247c775194a03462387994cd832b1650bfd1915
2014-04-03 18:08:23 +09:00
Jean Chalard
8ab4ae4377 [IL133] Avoid calling a dangerous method from outside.
We want to remove all calls to this as it lets internal values
escape, but there is some refactoring to do to finish this.

Bug: 8636060
Change-Id: Iedba6afe4719bc0add868714a1ee5a04b7ead33e
2014-04-03 15:36:15 +09:00
Jean Chalard
9320553ab9 [IL132] Remove some calls that let a value escape.
Bug: 8636060
Change-Id: I696514934586ee71e734fd974026af8b2c866127
2014-04-03 15:36:15 +09:00
Jean Chalard
7ebd7ca9a4 [IL131] Cleanup some cruft
Bug: 8636060
Change-Id: I169618b50532df68e973e14b3f114c6c19714c84
2014-04-03 15:36:12 +09:00
Keisuke Kuroyanagi
35314af0d8 Merge "Extend jni interface to input/output languageWeight." 2014-04-02 16:20:28 +00:00
Keisuke Kuroyanagi
1de95ceada Extend jni interface to input/output languageWeight.
Bug: 8187060
Change-Id: Ic55d328b87f258f4d65fff207233789a53b2b0ff
2014-04-03 01:01:51 +09:00
Keisuke Kuroyanagi
6b64de5063 Merge "Add languageWeight as an argument of getSuggestions." 2014-04-02 15:54:55 +00:00
Keisuke Kuroyanagi
18f21f96e0 Add languageWeight as an argument of getSuggestions.
Bug: 8187060
Change-Id: I8ae20c957a8e127b76c83cc3a65ff052d43bf2b5
2014-04-03 00:47:28 +09:00
Keisuke Kuroyanagi
a327d4a475 Merge "Use fixed order of dictionaries to get suggestions." 2014-04-02 13:24:52 +00:00
Keisuke Kuroyanagi
5b00d74c2e Use fixed order of dictionaries to get suggestions.
Bug: 8187060
Change-Id: Id287776e3a82c0a6b208d677b8f2891266c5fc8d
2014-04-02 22:17:18 +09:00
Jean Chalard
06b50ed5f2 Merge "[IL130] Remove a useless local" 2014-04-02 09:18:45 +00:00
Jean Chalard
a49d326426 Merge "[IL129] Change some confusing method names." 2014-04-02 09:18:15 +00:00
Jean Chalard
4323e1126c Merge "[CB19] Some refactoring" 2014-04-02 09:17:43 +00:00
Jean Chalard
750a3557a0 Merge "[CB18] Move some code around" 2014-04-02 09:17:30 +00:00
Jean Chalard
cc5a71caf1 Merge "[CB17] Remove a member." 2014-04-02 09:17:14 +00:00
Jean Chalard
26650377cf [IL130] Remove a useless local
Bug: 8636060
Change-Id: I36ba3e00630bef644fc4671d0714490b5982f6a1
2014-04-02 18:10:21 +09:00
Jean Chalard
a777c1c460 [IL129] Change some confusing method names.
Bug: 8636060
Change-Id: I2f55fc23d7e05b63582a3f0660b58635eae5ec59
2014-04-02 18:10:18 +09:00
Jean Chalard
f6bce235ae [CB22] Merge add and delete
Bug: 13406701
Change-Id: Ic9e90dd226b58b5ddb9693e04259cde00916007e
2014-04-02 18:01:00 +09:00
Jean Chalard
3e160bbe6b [CB21] More refactoring
Bug: 13406701
Change-Id: I96e0a7fa2d9f4dfd8c355da4effc116bbd0f7f18
2014-04-02 18:01:00 +09:00
Jean Chalard
dfaeb125eb [CB20] Some more refactoring
Bug: 13406701
Change-Id: I4502658f4f1e1997d0ac245d95e2d4a1415b1861
2014-04-02 18:00:57 +09:00
Jean Chalard
0f913ff5ba [CB19] Some refactoring
Bug: 13406701
Change-Id: Ie4d420e8cabbbd93c3eea13a80baa4d766ee61d0
2014-04-02 18:00:19 +09:00
Jean Chalard
8bb2e99aef [CB18] Move some code around
Bring next to each other two methods scheduled for a merge

Bug: 13406701
Change-Id: I335c7202cc07d8865f4ab92e4023c1d93d1f83ac
2014-04-02 17:58:33 +09:00
Jean Chalard
3285b68c97 [CB17] Remove a member.
Bug: 13406701
Change-Id: I2e271f637f6b529a4191a7adc5cdfa5af437761b
2014-04-02 17:57:36 +09:00
Tadashi G. Takaoka
7dd32dfc06 Remove country name from space bar text when appropriate
Remove country name from space bar text when there no other subtype
that is a same language and a same keyboard layout.

Bug: 8084704
Change-Id: I7c785a925ff7a0a61e5d009f138e1df52b3aeb3a
2014-04-02 12:50:52 +09:00
Tadashi G. Takaoka
65a199ca8e Merge "Add SpacebarLanguageUtils class" 2014-04-01 03:25:31 +00:00
Tadashi G. Takaoka
9364d46ac3 Add SpacebarLanguageUtils class
The SpacebarLanguageUtils class is separated from SubtypeLocaleUtils
and handles the language name on the spacebar.

Bug: 8084704
Change-Id: I82f79a061d4f0cc2895263298c3ebf8ee444c61d
2014-04-01 12:17:06 +09:00
Jean Chalard
1dc354bed1 Merge "[IL128] Remove passing some handlers." 2014-03-31 09:32:00 +00:00
Jean Chalard
dbadee96b6 Do not create a handler thread for each session
Bug: 13710224
Bug: 12821388
Bug: 12667742
Change-Id: I6188e0240193d2bca789110e7660a0f31bbafc62
2014-03-31 15:32:48 +09:00
Keisuke Kuroyanagi
f41518dbab Fix: spell checker wrongly sorts suggestions.
Change-Id: I729e1cd5e5e333038b9d9e6197cf50b574990d76
2014-03-28 14:37:48 +00:00
Jean Chalard
452cd2f619 Fix a bug where LatinIME would leak pipes.
Bug: 12667742
Bug: 12821388
Change-Id: Ic0bad56fb96e54ac032759adffc8ea320c06dff2
2014-03-28 19:54:07 +09:00
Jean Chalard
52eb673c46 Merge "Some cleanup" 2014-03-28 09:22:22 +00:00
Tadashi G. Takaoka
03f9c4820a Merge "Make NeedsToDisplayLanguage as a top level class" 2014-03-28 09:15:25 +00:00
Tadashi G. Takaoka
c412a41aff Merge "Remove redundant check to detect forceAscii" 2014-03-28 09:15:18 +00:00
Tadashi G. Takaoka
8e3c585265 Make NeedsToDisplayLanguage as a top level class
Change-Id: Ia05e0494a9dccebfb5c1316479e52f04cf2ae444
2014-03-28 17:59:57 +09:00
Tadashi G. Takaoka
61dbda00de Remove redundant check to detect forceAscii
Change-Id: Ib3272ec19a90b3aa4937573e049ceb86855ea408
2014-03-28 17:56:08 +09:00
Keisuke Kuroyanagi
a4c5c54a19 Merge "Remove unused method." 2014-03-28 08:07:42 +00:00
Keisuke Kuroyanagi
781e3df73b Merge "Dictionary migration in Java side." 2014-03-28 08:07:26 +00:00
Jean Chalard
35645ac39a Merge "[CB14.5] Stop copying WordComposers." 2014-03-28 06:51:17 +00:00
Jean Chalard
70d9152c7f Some cleanup
Change-Id: Ia11d656a70623168b091763ac6524750f9cca8d8
2014-03-28 15:27:00 +09:00
Jean Chalard
8e829c37df [CB14.5] Stop copying WordComposers.
This is an overdue refactoring that I have been wanted to
do forever, and that we can at last do now that suggestions
come only from instances of BinaryDictionary instances.

With this, all unit tests and regression tests are
passing again.

Bug: 13667648
Bug: 13665487
Bug: 8636060
Change-Id: Ie23a19f9b7e692edf2ee0b107ddaff2d7db564b6
2014-03-28 15:26:27 +09:00
Keisuke Kuroyanagi
3c801be5e5 Merge "Fix unit tests by adding @UsedForTesting." 2014-03-28 06:08:37 +00:00
Keisuke Kuroyanagi
aa7abb2d89 Fix unit tests by adding @UsedForTesting.
Change-Id: I8497d6cf446297bc8c15e9d9818078b1026a8c51
2014-03-28 15:02:00 +09:00
Tadashi G. Takaoka
f173b12b03 Merge "Stop displaying locale string on short space bar" 2014-03-28 04:49:17 +00:00
Tadashi G. Takaoka
2202d47386 Stop displaying locale string on short space bar
Bug: 12070355
Change-Id: I2d6fa20431bc56d5139caeac33e396b73906d075
2014-03-28 13:05:13 +09:00
Keisuke Kuroyanagi
30cd0cd2a0 Fix: NPE after onDestroy().
Bug: 13671513
Change-Id: I06aa14870ff5422ad514356ee406600b247858c5
2014-03-28 12:17:44 +09:00
Jean Chalard
080e0253ae Merge "Revert "[CB15] Remove a redundant variable."" 2014-03-27 09:44:31 +00:00
Jean Chalard
f459ccf4f6 Merge "Revert "[CB16] Remove unused stuff"" 2014-03-27 09:44:24 +00:00
Jean Chalard
75715f7d9f Revert "[CB15] Remove a redundant variable."
This reverts commit 0de7a6d1a2.

Change-Id: I327679b76a14cf9c3aec4b00b013b921408c32f9
2014-03-27 09:43:45 +00:00
Jean Chalard
26baa759d8 Revert "[CB16] Remove unused stuff"
This reverts commit 05c46f59fd.

Change-Id: Ica0feea10fff1b2a9ef42bc55cb7c1892b3a3f58
2014-03-27 09:43:21 +00:00
Jean Chalard
5154c47cbe Merge "[CB16] Remove unused stuff" 2014-03-27 08:52:11 +00:00
Jean Chalard
6bd3723e73 [IL128] Remove passing some handlers.
Bug: 8636060
Change-Id: I088be9a7555265ca097667523defd73be4cbe37f
2014-03-27 17:51:32 +09:00
Keisuke Kuroyanagi
c17311cefe Remove unused method.
Change-Id: Iefb75136080e73c357511df045816f18cec767a6
2014-03-27 17:46:38 +09:00
Keisuke Kuroyanagi
a785fa8edd Dictionary migration in Java side.
Bug: 13406708

Change-Id: If83938e4b4810d2e8353c70cdd8ef3ea97a29571
2014-03-27 17:46:35 +09:00
Ken Wakasa
e04a9798f6 Merge "Call setLayerType(LAYER_TYPE_HARDWARE) for EmojiPalettesView too." 2014-03-27 08:27:59 +00:00
Ken Wakasa
e289441f92 Call setLayerType(LAYER_TYPE_HARDWARE) for EmojiPalettesView too.
This CL probably does not addresses the bug, but still this should
be the right thing to do here.

bug: 12667742
Change-Id: I587652942fd66094779fb7942c734e0ff5f9d0b6
2014-03-27 17:26:22 +09:00
Jean Chalard
5feda45a6f Merge "[CB15] Remove a redundant variable." 2014-03-27 08:05:23 +00:00
Jean Chalard
05c46f59fd [CB16] Remove unused stuff
Bug: 13406701
Change-Id: Ib863c5181e1f5d74cfa4458060afc49d1ee8109e
2014-03-27 16:47:30 +09:00
Jean Chalard
0de7a6d1a2 [CB15] Remove a redundant variable.
This is a tiny bit slower, but probably unnoticeable.
Still, it gains some performance in other places,
saves memory, and more importantly makes for simpler
code, so it's certainly better.

Change-Id: Id1ab4f73f71acd73f5920bc729817abd22cf0d07
2014-03-27 16:47:27 +09:00
Keisuke Kuroyanagi
6008898b99 Merge "Move code only used for dicttool and tests under tests." 2014-03-27 06:37:10 +00:00
Keisuke Kuroyanagi
93cda5bb39 Move code only used for dicttool and tests under tests.
Bug: 13035567
Change-Id: I13c6df013ef2b67c9bf67455d9c32d283bf9ea2e
2014-03-27 15:30:32 +09:00
Keisuke Kuroyanagi
3c38e1f269 Merge "Fix: NPE in isValidWord after dictionaries are closed." 2014-03-27 03:12:07 +00:00
Keisuke Kuroyanagi
7b516d496d Fix: NPE in isValidWord after dictionaries are closed.
Bug: 13650542
Change-Id: I1bdc838fca48d6ef12db5e70d40273d1236128d1
2014-03-27 12:03:58 +09:00
Tadashi G. Takaoka
4cb152682d Fix crash while entering emoticons
Bug: 13652919
Change-Id: Idd66240ac882fa890cfb28a477403ee09dc716ce
2014-03-27 11:08:11 +09:00
Tadashi G. Takaoka
c4b558d375 Merge "Rename text resources consistently" 2014-03-26 10:06:34 +00:00
Jean Chalard
071b9c1a05 Merge "[CB14] Implement backspace in the combiner chain" 2014-03-25 10:46:32 +00:00
Jean Chalard
1079665c3c [CB14] Implement backspace in the combiner chain
Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc
2014-03-25 17:57:03 +09:00
Keisuke Kuroyanagi
adfb262797 Remove logic related to dictionary loading from LatinIME.
Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.

Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
2014-03-25 15:35:20 +09:00
Tadashi G. Takaoka
393efd94e5 Rename text resources consistently
- keylabel_<key>, the key label text of the <key>
- keyspec_<key>, the key specification of the <key>
- keyhintlabel_<key>, the hint label text of the <key>
- morekeys_<key>, the more keys specifications of the <key>
- additional_morekeys_<key>, the additional more keys specification of
  the <key>

Change-Id: Ib2127f21fa33a2568e8a6eba65cfdb2cf78b480e
2014-03-25 13:02:09 +09:00
Tadashi G. Takaoka
37b9562fd7 Fix talk back of emoji key
Bug: 13629734
Change-Id: Ifff6f81c2ac99a32855cd333b3d9a01ad7155ffc
2014-03-25 11:58:59 +09:00
Yohei Yukawa
f1f5ed542d Check null before passing to Integer.parseInt
Just after user data is cleared, user preference associated with
PREF_KEYBOARD_LAYOUT is always empty. In such case, we might
want to return the default value immediately, rather than
calling Integer.parseInt(null) and catching NumberFormatException
unnecessarily.

BUG: 13472379
Change-Id: I8dca9a22780d057013c032bd1f56e730dcada3ce
2014-03-24 20:54:03 +09:00