Commit Graph

7653 Commits (dbb2182e3928cb8d204290f83a01718d5ff9b162)

Author SHA1 Message Date
Jean Chalard ef0ef2d0b9 am beb74610: am ab18b5f1: am 9395014e: Don\'t resume suggestions with H/W keyboard
* commit 'beb746103011149d6dfce10278475946e679263d':
  Don't resume suggestions with H/W keyboard
2014-09-08 13:52:25 +00:00
Jean Chalard 7140035932 Fix a missing initialization
Change-Id: I14a35f5a38b6e0f48c95cbb8c0c6e4507cd61fa7
2014-09-08 22:40:36 +09:00
Jean Chalard 1cf2acd8de am 61e7afa6: am 0eaa25e0: am 914078fd: Fix a bug where recorrection would stop on connectors
* commit '61e7afa6fa98939f9dcb9f7a2ebb5678a51d4201':
  Fix a bug where recorrection would stop on connectors
2014-09-08 13:20:27 +00:00
Jean Chalard 9395014e76 Don't resume suggestions with H/W keyboard
...unless we do support a hardware keyboard, which we still
do not at the moment.

Change-Id: Iec24b1ae8ba5e23e0bbb7e5a468b7404296d4b18
2014-09-08 22:14:02 +09:00
Jean Chalard b41ee67194 Fix the sentence separator for Hindi.
Change-Id: I623e4ccbc324751eb67ec4bb777e2be5ae2a60d1
Bug: 17418371
2014-09-08 21:54:28 +09:00
Jean Chalard 914078fd91 Fix a bug where recorrection would stop on connectors
Bug: 16733686
Change-Id: I7a9f79a81e33a1f5bf5f3daf0b78d0f1e4447e7a
2014-09-08 21:47:01 +09:00
Yohei Yukawa a48fe12b9c am 42ddc212: am f930ce12: am 1caa0b71: Merge "Follow up API signature changes of CursorAnchorInfo" into lmp-dev
* commit '42ddc2127deb117a0bb2b7a7797cb8c9ba335f5a':
  Follow up API signature changes of CursorAnchorInfo
2014-09-08 09:35:00 +00:00
Jean Chalard 653546a618 am c3fac52d: am 1f74ba17: am cb077f75: Merge "Resolve an old TODO." into lmp-dev
* commit 'c3fac52dd51ba70db83d96b2d421bd440683d9bc':
  Resolve an old TODO.
2014-09-08 09:34:58 +00:00
Yohei Yukawa 1caa0b714d Merge "Follow up API signature changes of CursorAnchorInfo" into lmp-dev 2014-09-08 09:11:41 +00:00
Jean Chalard a1d2315499 Merge "Fix a bug with the Greek question mark." 2014-09-08 08:58:27 +00:00
Jean Chalard cb077f75ac Merge "Resolve an old TODO." into lmp-dev 2014-09-08 08:57:23 +00:00
Yohei Yukawa a8ecd29646 Follow up API signature changes of CursorAnchorInfo
This is a follow up CL for Ic8c6fab58c01206872a34e7ee604cdda.

No behavior change is intended in this CL.

BUG: 17365414
BUG: 17335734
Change-Id: I4299536d0cb0c660b7b564653c72c9cb409a7aa5
2014-09-08 17:07:34 +09:00
Mohammadinamul Sheik 74332597d6 Merge "Add StatsUtils.onPickSuggestionManually and SuggestedWords.indexOf." 2014-09-08 06:52:02 +00:00
Jean Chalard b526a894db Fix a bug with the Greek question mark.
Bug: 17398284
Change-Id: If49593e2c959935a183a4cd9d988407cc1160599
2014-09-08 15:33:51 +09:00
Tadashi G. Takaoka 100a8aec5b am ad4de3fc: am 9ca6658e: am 0f33e614: Implement Floating Action Button more keys keyboard
* commit 'ad4de3fc819d658775eed470fc74ad76da5caad2':
  Implement Floating Action Button more keys keyboard
2014-09-08 06:07:52 +00:00
Tadashi G. Takaoka e1b10aedd7 am 3aabf655: am f21c77d7: am 727e818e: Move more keys divider to MoreKeysKeyboardView
* commit '3aabf655d0125fb824e5e47687f5084b2df6979c':
  Move more keys divider to MoreKeysKeyboardView
2014-09-08 05:42:32 +00:00
Tadashi G. Takaoka 0f33e614c0 Implement Floating Action Button more keys keyboard
Bug: 15681452
Change-Id: I8484e4fe4d989b391f2b5230836dc9dfac218429
2014-09-08 14:34:33 +09:00
Mohammadinamul Sheik c74ffe8edc Add StatsUtils.onPickSuggestionManually and SuggestedWords.indexOf.
Change-Id: I1588448154d086569cb026825fdc36cd1812a582
2014-09-07 20:43:48 -07:00
Tadashi G. Takaoka 727e818e95 Move more keys divider to MoreKeysKeyboardView
Bug: 15681452
Change-Id: I1b32719cc927a24db4c41fdeb812b39f7e98a85c
2014-09-08 11:02:07 +09:00
Tadashi G. Takaoka 8b7ed7f6c6 am 079f9c3f: am 1b430219: am 6888ec00: Merge "Create donottranslate debug settings string resources file" into lmp-dev
* commit '079f9c3f5ae7b2f7926321522b6020affd422b52':
  Create donottranslate debug settings string resources file
2014-09-05 17:23:45 +00:00
Jean Chalard 6bb6d30344 Resolve an old TODO.
This is cleaner.

Bug: 17347779
Change-Id: I5b612783b1ec98a1a11401f00d68db49654f3023
2014-09-05 20:10:29 +09:00
Jean Chalard 46d111ff4a Merge "Fix a bug where CAPS_WORDS would not be returned." 2014-09-05 09:53:51 +00:00
Jean Chalard 17901db691 Fix a bug where CAPS_WORDS would not be returned.
Also introduce some unit tests that would have caught the bug.

Bug: 17398284
Change-Id: Idb715b7bd2f70992d6cdf4e25ef368809382caef
2014-09-05 07:56:25 +00:00
Tadashi G. Takaoka f0f49f9806 Create donottranslate debug settings string resources file
This is a follow up of the I26e4d292de.

Bug: 15678343
Bug: 17385083
Change-Id: I2c2b08b8dd991ac981aa8f8c8436de9e4399da5f
2014-09-05 11:38:29 +09:00
Jean Chalard 78d1dcd356 [ML4] Rename Dictionaries to DictionaryGroup
We're going to have multiple DictionaryGroup objects and it
would be very confusing to have this class name a plural.

Change-Id: I8f5c621459ede49f245be26097fe71f44289761c
2014-09-04 18:35:47 +09:00
Tadashi G. Takaoka 964877a8f2 am c297197b: am 1c2cf719: Add new value "spacebar" to Key.backgroundType attribute
* commit 'c297197b1548307c31017ba3dc89bbb6bbf2223e':
  Add new value "spacebar" to Key.backgroundType attribute
2014-09-03 17:55:54 +00:00
Tadashi G. Takaoka e355274642 am ec7d6752: am 5a9c9649: Removes "customAction" value from Key.backgroundType attribute
* commit 'ec7d67529e0dd4e5bf87e3b96c4b78db44adb96f':
  Removes "customAction" value from Key.backgroundType attribute
2014-09-03 17:55:53 +00:00
Tadashi G. Takaoka 6a4e9218ca am 2a7a5740: am 0af2472a: Add new "keyboardTheme" <case> predicator
* commit '2a7a5740e929503a0aca23f376175a9c118b7a83':
  Add new "keyboardTheme" <case> predicator
2014-09-03 17:55:52 +00:00
Yohei Yukawa 5d7b24f29c am f2c509a8: am 310da35c: Merge "Follow up API signature change" into lmp-dev
* commit 'f2c509a81ef107e6c71dc6804417469d12c94fca':
  Follow up API signature change
2014-09-03 17:41:46 +00:00
Yohei Yukawa f618f351fe am 6e29bf56: am 8c42bf54: Follow API signature change in CursorAnchorInfo
* commit '6e29bf56c680331a7d1a50be38212c1356cb584d':
  Follow API signature change in CursorAnchorInfo
2014-09-03 17:41:43 +00:00
Tadashi G. Takaoka 1c2cf71921 Add new value "spacebar" to Key.backgroundType attribute
Bug: 17318036
Change-Id: Ie84438a6aa3adc14a9db603d0cd4d5e37a55d612
2014-09-03 23:37:03 +09:00
Tadashi G. Takaoka 5a9c9649db Removes "customAction" value from Key.backgroundType attribute
Bug: 17318036
Change-Id: I6a36d50ba2e69eafbb0faa049014281bd4d4ddfc
2014-09-03 23:35:39 +09:00
Tadashi G. Takaoka 0af2472a69 Add new "keyboardTheme" <case> predicator
Bug: 17318036
Change-Id: Ief386c84969d8646fb5cfe2050a2f59a7db16c88
2014-09-03 23:26:46 +09:00
Jatin Matani 972003428b Merge "Attempt retry for broken dictionaries" 2014-09-03 08:56:38 +00:00
Yohei Yukawa 5d6ac77732 Follow up API signature change
This is a follow up CL for API signature change in
I772c48ff18918e48a81e807b48ff907614485c09

BUG: 17320996
Change-Id: Ic8b6162bda12bf74fae79af212c5d81c400eb9e8
2014-09-03 01:13:15 -07:00
Jatin Matani 256b1b2a1e Attempt retry for broken dictionaries
1. Add retry count column within metadata in dictionary pack.
2. Attempt a retry for download and installation by running StartDownloadAction.
3. If the number retrial are at the threshold, we don't attempt it again.

Bug: 15150487
Change-Id: I70720353e5803fccf4728c2aa798883ba75c61e5
2014-09-03 17:11:06 +09:00
Yohei Yukawa 8c42bf54af Follow API signature change in CursorAnchorInfo
This is just a follow up CL for Ia8cbb9f6b41cd9509fc0147fd68763df.
No behavial change is intended.

BUG: 17200900
Change-Id: Iba23b731ebde64ec2e816c5b4bef1d93632fce1e
2014-09-02 16:29:35 -07:00
Tadashi G. Takaoka d27af1a5d4 am 3ad86d91: am afa9d6d8: Merge "Add theme aware key popup preview animation" into lmp-dev
* commit '3ad86d91f1e3d251635303e0fb9a83dce22efa3a':
  Add theme aware key popup preview animation
2014-09-02 17:44:10 +00:00
Tadashi G. Takaoka ac88f3d845 Add theme aware key popup preview animation
Bug: 15678343
Change-Id: I26e4d292deab37724387cc9ebc03033fcd698c60
2014-09-02 18:45:23 +09:00
Jean Chalard a341e7d244 Merge "[ML3] Put the locale in SuggestedWordInfo" 2014-09-02 06:40:59 +00:00
Jean Chalard c0d3123930 Merge "[ML2] Small refactoring" 2014-09-02 06:40:51 +00:00
Jean Chalard 576c96af95 [ML3] Put the locale in SuggestedWordInfo
...and remove it from SuggestionResults.

Change-Id: Iae85ec7e82e2caf18cc6d7656aa46dc150707cdd
2014-09-01 20:09:32 +09:00
Jean Chalard 146cb98e54 [ML2] Small refactoring
Change-Id: I1283d666b8904ff4e6c012332bdbc9c0c13df415
2014-09-01 20:09:24 +09:00
Jatin Matani 962c40d326 Merge "StatsUtilsManager should be initiated(#onCreate) before loadSettings." 2014-09-01 08:27:19 +00:00
David Faden 95b7bd3ba5 Add a private IME option to suppress the gesture floating preview text.
If the option defined by Constants.NO_FLOATING_GESTURE_PREVIEW is set
for a text field via EditorInfo.privateImeOptions, the floating gesture
preview will be suppressed regardless of the settings preference.

Feature request:
bug: 17325039

Change-Id: I1a1df194369e8f2d76abd9d84939a057f55f4a1c
2014-09-01 03:59:38 +00:00
Keisuke Kuroyanagi dec2c2d910 Merge "Support multiple locales in distractor filter." 2014-09-01 03:27:35 +00:00
Jatin Matani aa223400c3 StatsUtilsManager should be initiated(#onCreate) before loadSettings.
Change-Id: I9002b4afb023e55ab251ea070ec0b7a6ace99261
2014-08-29 15:51:57 -07:00
Tadashi G. Takaoka f5960b4f62 am 034a4a5a: am c4710124: Merge "Fix the order of keys on more keys keyboard" into lmp-dev
* commit '034a4a5a19ba37dba8999b3763ae756fe748deaf':
  Fix the order of keys on more keys keyboard
2014-08-29 19:07:06 +00:00
Tadashi G. Takaoka 2d713c87c6 am 2fabd50d: am f507d1fe: Support RTL layout in custom input style settings
* commit '2fabd50df49f894afde15ac5f4ebd2ff5372a9c4':
  Support RTL layout in custom input style settings
2014-08-29 19:07:04 +00:00
Jean Chalard 78bb2dd945 am 3bd8eee3: am 4e28a6a8: Fix an IOOB exception
* commit '3bd8eee3e8c3e89539578a4231661819de65c804':
  Fix an IOOB exception
2014-08-29 19:07:03 +00:00
Tadashi G. Takaoka f9af39e53e am 727cd740: am f2eadbb4: Clear keyboard cache when system locale is changed
* commit '727cd74072d97af334fe8c0d18fa6a1e23629ccb':
  Clear keyboard cache when system locale is changed
2014-08-29 19:07:02 +00:00
Keisuke Kuroyanagi fdaedb6c1d Support multiple locales in distractor filter.
Bug: 16547557
Change-Id: I4aba278eb4114e0075f3f8b38c7e132743927fa8
2014-08-29 22:29:30 +09:00
Keisuke Kuroyanagi 9eec97d5b0 Merge "Use DictionaryFacilitatorLruCache for personalization." 2014-08-29 10:10:40 +00:00
Tadashi G. Takaoka c471012483 Merge "Fix the order of keys on more keys keyboard" into lmp-dev 2014-08-29 09:58:28 +00:00
Tadashi G. Takaoka f507d1febb Support RTL layout in custom input style settings
Bug: 17322353
Change-Id: I3b211ab8729121271563a8a243558a58ee7847c2
2014-08-29 18:28:53 +09:00
Jean Chalard 4e28a6a844 Fix an IOOB exception
Bug: 17316001
Change-Id: Iaa2cfd30ebbe0d49e10a5c3a30336e06817d0a8b
2014-08-29 06:56:34 +00:00
Keisuke Kuroyanagi e59f3e4fbf Use DictionaryFacilitatorLruCache for personalization.
Bug: 16547557

Change-Id: I5faba5e26d072b49c0fffcaeaf5062f9e0c2dcc0
2014-08-29 12:57:50 +09:00
Tadashi G. Takaoka a9fc8622fe Fix the order of keys on more keys keyboard
This CL fixes the behavior of !autoColumnOrder!<n> flag in a more keys
specification. Formerly the <n> value specifies the maximum number of
column of more keys. With this CL, the <n> value specifies the exact
number of column of more keys.

Bug: 16603887
Change-Id: I2120620fa512ee30043bb146ad675a942a375129
2014-08-29 11:06:20 +09:00
Jatin Matani aabb351279 Refactor StatsUtils into two components:StatsUtils & StatsUtilsManager
Bug:16522256
Change-Id: I9cb8129c552159cf17ea5c2656e0988bf0f999f5
2014-08-28 17:28:23 -07:00
Tadashi G. Takaoka f2eadbb497 Clear keyboard cache when system locale is changed
Bug: 17310080
Change-Id: I2b388772f269f1e7610a5bd32de80793da2df16e
2014-08-28 22:50:07 +09:00
Jean Chalard 98e56c6905 am 3ef26ac1: am 6bd267f4: Merge "Add new attributes to our notification" into lmp-dev
* commit '3ef26ac13b677bc8d7adeed378ce6d6cbad171ee':
  Add new attributes to our notification
2014-08-28 09:52:03 +00:00
Jean Chalard a2928484f6 Add new attributes to our notification
Bug: 17167221
Bug: 17128331
Change-Id: I6a045fd2398f40dbdc10c9d20993f7513e1f2cff
2014-08-28 07:47:07 +00:00
Jean Chalard f95770354c Straighten the dead char implementation, take 3.
Change-Id: I4f70f6eebe076c7d2b780d25e3a2c1d3faa2edfa
2014-08-28 16:03:45 +09:00
Keisuke Kuroyanagi b85349e981 Merge "Create DictionaryFacilitatorLruCache." 2014-08-28 03:09:28 +00:00
Yohei Yukawa af5c2b24e7 am 8d0d2363: am acce1aa5: Make sure to obtain the IC before requesting CursorAnchorInfo
* commit '8d0d236394548be4e2302a03960ce4ee363a5483':
  Make sure to obtain the IC before requesting CursorAnchorInfo
2014-08-27 23:41:33 +00:00
Yohei Yukawa acce1aa59e Make sure to obtain the IC before requesting CursorAnchorInfo
RichInputConnection#requestUpdateCursorAnchorInfo must make
sure to obtain the input connection before calling methods
of it.

BUG: 17299587
Change-Id: I8e0cd473a4cc32583cd47634c227d702f7c69c6c
2014-08-27 15:59:52 -07:00
Ken Wakasa 95c4d26994 Merge "Revert "Straighten the dead char implementation."" 2014-08-27 15:07:52 +00:00
Ken Wakasa 0ba6bcb16d Revert "Straighten the dead char implementation."
This reverts commit 5ef447aeea.

Reverting because this broke a bunch of unit tests -- https://sponge.corp.google.com/target?id=b6439742-099e-46cb-8f00-d0c602a4d9bb&target=com.google.android.inputmethod.latin.tests&searchFor=&show=FAILED&sortBy=STATUS

Change-Id: Ibbd9e11372993f62e630fd9da37158ffcf47c17a
2014-08-27 15:07:28 +00:00
Keisuke Kuroyanagi d267764d5a Create DictionaryFacilitatorLruCache.
This class is separated from AndroidSpellCheckerService

Bug: 16547557

Change-Id: I3e58521207395588cecb2977234b89067d6da8c3
2014-08-27 22:00:48 +09:00
Jean Chalard 4204d59864 Merge "Straighten the dead char implementation." 2014-08-27 12:54:49 +00:00
Tadashi G. Takaoka 8b5788d72b am 68a2a69a: am 37beaf15: Simplify onComputeInsets of LatinIME
* commit '68a2a69ae35352650a4c6dfc0b0c69069c4a1e1d':
  Simplify onComputeInsets of LatinIME
2014-08-27 10:44:51 +00:00
Tadashi G. Takaoka 37beaf1529 Simplify onComputeInsets of LatinIME
This CL expands SoftInputWindow to the entire screen. Thus a key
review backing view is eliminated and onComputeInsets() gets
simplified too.

Bug: 17212702
Bug: 10841052
Bug: 10541453
Change-Id: I2d859f4e4698c64cabe399000821f13bab729996
2014-08-27 19:20:38 +09:00
Yohei Yukawa 00042cb453 am c925ca43: am 97681ebd: Set highlight color along with the commit indicator
* commit 'c925ca43a6e0b3175feb002ce6b5577ef7d66507':
  Set highlight color along with the commit indicator
2014-08-27 10:01:24 +00:00
Ken Wakasa 6da1c674fd resolved conflicts for merge of 8159336b to master
Change-Id: I9dd726593c6768b1db35305935ee69b0937358ef
2014-08-27 18:55:39 +09:00
Ken Wakasa c1596086d3 resolved conflicts for merge of 0268f736 to master
Change-Id: Ib89ef55a8752f9b5e357eed3a05c79dd28d0ec0e
2014-08-27 18:41:31 +09:00
Jean Chalard 5ef447aeea Straighten the dead char implementation.
This now supports all cases, including cases not supported by
the framework.
Now rebased on top of the right change, and renamed

Change-Id: I7886f0dcbb86cdb4dccec09aa7c52ad339680e04
2014-08-27 17:59:39 +09:00
Yohei Yukawa 97681ebdf1 Set highlight color along with the commit indicator
With this CL, the text highlight color is applied
when the commit indicator is displayed.

Note that the underline is not rendered when the
background color is enabled. This is a known issue.

Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
2014-08-27 01:41:16 -07:00
Yohei Yukawa 29200b0abe Set the text bgcolor only when CursorAnchorInfo is available
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.

With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not.  This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.

Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
2014-08-27 01:30:45 -07:00
Yohei Yukawa a475c85480 Introduce a mechanism to hide the indicator speculatively
This is an optional optimization to reduce the UI latency.

Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.

If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.

This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.

Change-Id: Id59c6607a1029782410611e768791af9984f14ac
2014-08-26 23:42:53 -07:00
Yohei Yukawa bea17c49ec Introduce commit/add-to-dictionary indicators
This CL introduces commit/add-to-dictionary indicators.

Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.

Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
2014-08-26 21:20:27 -07:00
Ken Wakasa 4660ecaa44 Merge "Fix a bug where mic/emoji key wouldn't work." 2014-08-26 13:30:15 +00:00
Jean Chalard e38043849e Fix a bug where mic/emoji key wouldn't work.
Bug: 17272902
Bug: 17269948
Change-Id: I561609fa84a6265f8148db7d2411bc1fd38dd163
2014-08-26 22:06:21 +09:00
Jean Chalard 96522da9eb am 2a2d324e: am 8380f921: Fix a bug where the top prediction would disappear.
* commit '2a2d324eb627807a9d09b491fbb4ac78ffb253fc':
  Fix a bug where the top prediction would disappear.
2014-08-26 12:37:17 +00:00
Jean Chalard 8380f921f7 Fix a bug where the top prediction would disappear.
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.

Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
David Faden 9cf69a45b2 Adds documentation for a few methods.
Change-Id: I6bdae25a8b81cdac931f2591f33570b01e34fb2c
2014-08-26 08:08:24 +00:00
Keisuke Kuroyanagi bf6fc4953b Merge "Get dynamic dict stats via DictionaryFacilitator" 2014-08-25 11:24:54 +00:00
Yohei Yukawa d8dfac6dcb am abf05cc0: am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev
* commit 'abf05cc0da1ead7e270a7c99bf9f000dabf91f5b':
  Use more descriptive names for some internal fields
2014-08-25 10:16:11 +00:00
Jean Chalard 1a31d784cd Merge "Introduce onEvent() to improve testability" 2014-08-25 09:57:42 +00:00
Yohei Yukawa fdfe73ff1f Merge "Use more descriptive names for some internal fields" into lmp-dev 2014-08-25 09:50:59 +00:00
Tadashi G. Takaoka d147db8763 am c500700f: am 19dd34a0: Show view even when IME is explicitly shown with physical keyboard
* commit 'c500700faec11b7a6d54a821009be4d657c43394':
  Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:35:08 +00:00
Yohei Yukawa a61b7245b0 Use more descriptive names for some internal fields
This CL clarifies that delay parameters are specified with
milliseconds.

Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
2014-08-25 02:28:01 -07:00
Jean Chalard ee8ebeecbf Merge "Fix unit tests" 2014-08-25 09:26:17 +00:00
Jean Chalard dc110b2a6a Fix unit tests
Change-Id: I48bfa4e4dd80f36d2fe0a1e9d2a2706533cc722e
2014-08-25 18:19:00 +09:00
Tadashi G. Takaoka 7defe926ca am 4a782da3: am f145fff0: Merge "Fix NPE when pressing ALT key" into lmp-dev
* commit '4a782da382b83164ea5c23c771b771e73bbe31b3':
  Fix NPE when pressing ALT key
2014-08-25 08:25:42 +00:00
Yohei Yukawa 4587b135be am 2d508203: am 8681287c: Fix build due to an illegal character
* commit '2d508203c64f50ed47fb87c24ae5ebbfb0610a36':
  Fix build due to an illegal character
2014-08-25 08:25:35 +00:00
Yohei Yukawa 8c7daa829a am 02716083: am 5eebaddc: Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev
* commit '02716083158c3affbcfc719ff6471112d7397578':
  Dismiss "Add to dictionary" hint with non-special char event
2014-08-25 08:25:34 +00:00
Yohei Yukawa a5687ee9f7 am b65a1e46: am 2c4cce8d: Merge "Introduce #shouldShowAddToDictionaryHint" into lmp-dev
* commit 'b65a1e46ce06adc462dfc4cbde302ac27a79b695':
  Introduce #shouldShowAddToDictionaryHint
2014-08-25 08:25:33 +00:00
Yohei Yukawa f6f55add17 am e0d00803: am 4a71d2c4: Allow to add/remove background color to/from the committed text
* commit 'e0d00803087ac2f873332d43a78453c068633545':
  Allow to add/remove background color to/from the committed text
2014-08-25 08:25:31 +00:00
Yohei Yukawa c06c6e42ad am 7d146cdb: am cd6ef9a8: Indroduce SuggestedWords#getTypedWordInfoOrNull
* commit '7d146cdbe86692f153fb5b7f781f701a8c04050d':
  Indroduce SuggestedWords#getTypedWordInfoOrNull
2014-08-25 08:25:24 +00:00
Jean Chalard 908f0ed154 Introduce onEvent() to improve testability
...and prepare for the future

Change-Id: Ieed96ab552993fd148e80b9c3355f1b569bd716f
2014-08-25 16:33:47 +09:00
Tadashi G. Takaoka 19dd34a023 Show view even when IME is explicitly shown with physical keyboard
Bug: 17242477
Bug: 13988700
Change-Id: I519c0481760a9aa93a5d9bee68e0f6a3a8fc4d9d
2014-08-25 16:28:44 +09:00
Tadashi G. Takaoka f145fff085 Merge "Fix NPE when pressing ALT key" into lmp-dev 2014-08-25 06:52:36 +00:00
Keisuke Kuroyanagi 9cbf814cb5 Get dynamic dict stats via DictionaryFacilitator
Bug: 16553957
Change-Id: Ida08ceaf34708daed52d61b3d5adfbdb48e42c71
2014-08-25 15:19:48 +09:00
Tadashi G. Takaoka ad1f880811 Fix NPE when pressing ALT key
Bug: 17203708
Change-Id: I4f203603496e9401dacba4db21372e3353916418
2014-08-25 15:08:27 +09:00
Jean Chalard dc44260484 Merge "Revert "Revert "[ML1] Introduce RichInputMethodSubtype""" 2014-08-25 05:24:28 +00:00
Jean Chalard 85ddfe1317 Revert "Revert "[ML1] Introduce RichInputMethodSubtype""
This reverts commit a63d0a8ee6.

This patch seems to be fine after all, but was submitted without its companion [ML1.1] patch causing a build breakage. Reverting the revert and submitting both at the same time seems like the right thing to do.

Change-Id: Ib8fefa40b74dcee0edb025a52dac9b35c82d49df
2014-08-25 04:42:15 +00:00
Yohei Yukawa 8681287cd6 Fix build due to an illegal character
Change-Id: I597ab26db70387b80ddcd7d51de6ae751380030d
2014-08-24 21:14:41 -07:00
Yohei Yukawa 5eebaddccb Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev 2014-08-25 04:08:56 +00:00
Yohei Yukawa ebc1509039 Introduce #shouldShowAddToDictionaryHint
This is a groundwork for subsequent CLs where we need to
call this method from multiple places. This CL does not
change any existing behaviors.

Change-Id: Id8fa0360305d7383571edffab6752b2240367cf9
2014-08-24 20:59:30 -07:00
Yohei Yukawa 034c326078 Dismiss "Add to dictionary" hint with non-special char event
This CL slightly extends the condition when "Add to dictionary"
hint is dismissed.

With this CL, "Add to dictionary hint" will be dismissed by any
non-special char event. This is more comfortable especially if
we start using more intrusive UIs such as indicator and/or
background color with the text hint in the suggestion strip.

Change-Id: I2ea0fa40d9c6663ebf5d5439be3eca2a2cbd5166
2014-08-24 20:32:22 -07:00
Yohei Yukawa 4a71d2c480 Allow to add/remove background color to/from the committed text
This is a groundwork for subsequent CLs where we need to
add/remove background color to/from the commited text.

In this CL, we use Spanned#SPAN_COMPOSING so that we can easily
remove such a background color by calling
InputConnection#finishComposingText. To make this operation easy
and realiable, we need to track whether we have specified the
background color to the commited text or not at one place. Here
we use RichInputConnection for this purpose.

Change-Id: I5f9bc4425c5d1b80a719a20e5baf336729ec08d2
2014-08-24 20:28:24 -07:00
Yohei Yukawa cd6ef9a8b1 Indroduce SuggestedWords#getTypedWordInfoOrNull
This is a groundwork for subsequent CLs whith need to
do certain things for and only for the typed word.

Change-Id: I374b79cbc79470f57f523c996010301ea5701a61
2014-08-24 16:32:17 -07:00
Tadashi G. Takaoka 560876508f am cc4d21df: am 2637be27: Support Accept typed word UI
* commit 'cc4d21df7b08c3143dd1c4af786609a279a0bb79':
  Support Accept typed word UI
2014-08-22 14:27:26 +00:00
Tadashi G. Takaoka 2637be27c5 Support Accept typed word UI
Change-Id: I58e95b2791a45afdc7dae8e26dcfc200b3b4b854
2014-08-22 21:25:35 +09:00
Jean Chalard 6c638d1bbd Merge "Revert "[ML1] Introduce RichInputMethodSubtype"" 2014-08-22 09:41:46 +00:00
Jean Chalard a63d0a8ee6 Revert "[ML1] Introduce RichInputMethodSubtype"
This reverts commit 8ffe4bc932.

Change-Id: I9d4c98b0adfdb78b0f4d376f7691e50d1bd2228f
2014-08-22 09:40:27 +00:00
Yohei Yukawa eb99b461f0 am 96db9222: am cabb66e9: follow-up to API change in I4a577bfd02b37b
* commit '96db9222c2c8c728498751221cc92664676dd4f0':
  follow-up to API change in I4a577bfd02b37b
2014-08-22 09:26:22 +00:00
Keisuke Kuroyanagi e2ebd5d621 Merge "Add ExpandableBinaryDictionary#getDictionaryStats()." 2014-08-22 09:05:18 +00:00
Jean Chalard 395d778739 Merge "Revert "[HW17] Straighten the dead char implementation."" 2014-08-22 08:20:28 +00:00
Jean Chalard 5bfd661b38 Revert "[HW17] Straighten the dead char implementation."
This reverts commit c6612ff051.

Change-Id: I750d9bff9cb89a6ab13af7a33567c3a0fe2af381
2014-08-22 08:16:28 +00:00
Jean Chalard f429d8f138 Merge "[ML1] Introduce RichInputMethodSubtype" 2014-08-22 07:42:29 +00:00
Jean Chalard 8ffe4bc932 [ML1] Introduce RichInputMethodSubtype
Bug: 11230254
Change-Id: Ic7a1bf938a5a186dcff527b556295aba2406e8b9
2014-08-22 16:34:27 +09:00
Jean Chalard 1b34985dcf Merge "[HW17] Straighten the dead char implementation." 2014-08-22 07:33:31 +00:00
Mohammadinamul Sheik 698b19ef35 Pass a new argument to StatsUtils.
Change-Id: I61e32c7a455a273e8daf9a5487d7969923802488
Bug: 17013677
2014-08-22 15:58:45 +09:00
Jean Chalard c6612ff051 [HW17] Straighten the dead char implementation.
This now supports all cases, including cases not supported by
the framework.

Change-Id: I9dfbe2829c28c5bcb64b0b5a2551e7806990c00f
2014-08-22 15:55:32 +09:00
Yohei Yukawa cabb66e9bc follow-up to API change in I4a577bfd02b37b
BUG: 17182367
BUG: 17185263
Change-Id: Id54ca29c191b9752fa82ffe5a960113b2e97e5c1
2014-08-21 21:39:15 -07:00
Keisuke Kuroyanagi 6f2ddddb5b Add ExpandableBinaryDictionary#getDictionaryStats().
Bug: 16553957
Change-Id: I05866624d0ba9f32ea7a71cb231ba501dde4376c
2014-08-22 12:02:40 +09:00
Tadashi G. Takaoka ebec5e1338 Merge "Add Hinglish (hi_ZZ) subtype" 2014-08-21 10:22:17 +00:00
Tadashi G. Takaoka d6696ae78b Add Hinglish (hi_ZZ) subtype
Bug: 17169632
Change-Id: Ibee088d76c2b19f1d62a3c9c119452726e856ec8
2014-08-21 19:12:25 +09:00
Keisuke Kuroyanagi 68a52c1245 Merge "Update FormatSpec.java" 2014-08-21 09:50:38 +00:00
Keisuke Kuroyanagi c7b6393535 Update FormatSpec.java
Change-Id: I27d14697f931c9511420a459c49312ea6e10c366
2014-08-21 17:23:11 +09:00
Yohei Yukawa b8337e7232 am 2834ddf1: am b9768702: Merge "Use #onStartInputInternal to initialize cursor rect retrieval" into lmp-dev
* commit '2834ddf1a0c9bea38569429f90bdf7526ba8fa22':
  Use #onStartInputInternal to initialize cursor rect retrieval
2014-08-20 15:52:48 +00:00
Yohei Yukawa b9768702fa Merge "Use #onStartInputInternal to initialize cursor rect retrieval" into lmp-dev 2014-08-20 01:43:56 +00:00
Yohei Yukawa 9f4f6681a9 Use #onStartInputInternal to initialize cursor rect retrieval
This CL simply moves the method calls of #requestCursorAnchorInfo
into #onStartInputInternal just to consolidate the logic.

Change-Id: Ia205738b9614e9ae375c1dab767a91d2e1f6d0d3
2014-08-21 00:21:57 +09:00
Yohei Yukawa fa39ffcf84 Support more methods in the wrapper of CursorAnchorInfo
This CL add more compatibility wrapper methods for
CursorAnchorInfo.

This CL also adds more utility functions and types into
CompatUtils to reduce explict cast operations.

Change-Id: Id50165b552bbf28b832a6da13bf06eedcd2a190e
2014-08-20 09:27:22 +09:00
Ken Wakasa c37205f5ab Merge "DO NOT MERGE: Abolish source code overlay and introduce overridable src dir" into lmp-dev 2014-08-16 04:25:55 +00:00
Ken Wakasa 0b3e48fb50 DO NOT MERGE: Abolish source code overlay and introduce overridable src dir
This should make IDEs happy with appropriate source code directory
selection.

Change-Id: Ic734bd4d20aa050c688a3158b1a382ae0ac18991
(cherry picked from commit fb74ab15c1)
2014-08-20 02:56:09 +00:00
Yohei Yukawa 3cf13d1267 am 17aeaa75: am fa39ffcf: Support more methods in the wrapper of CursorAnchorInfo
* commit '17aeaa75780591f1bf7fefcc887869fd90c88a9f':
  Support more methods in the wrapper of CursorAnchorInfo
2014-08-20 05:04:07 +00:00
Ken Wakasa 9be350bc21 Merge "Abolish source code overlay and inroduce overridable src dir" 2014-08-16 04:15:21 +00:00
Keisuke Kuroyanagi ffaa9c2a71 Merge "Add language to PersonalizationDataChunk." 2014-08-16 04:12:14 +00:00
Keisuke Kuroyanagi e66d59e6d8 Add language to PersonalizationDataChunk.
Bug: 16547557
Change-Id: I11b82667631cbd5263cc08ccb304fc97bf692050
2014-08-19 18:27:34 +09:00
Jean Chalard 8adf5e8a70 Have the "add to dictionary" hint display the right word
Before this, we display the word we have committed instead
of the word we will actually insert into the personal dictionary.
There is a difference when the word was typed with auto-caps.

Bug: 17071785
Change-Id: I2bfec0402b1307934590a78ab5c25104d92b75ca
2014-08-18 20:43:40 +09:00
Yohei Yukawa c9240d280c am 18ac3c8a: am 16a43d2b: Let the backing view cover the entire content area
* commit '18ac3c8afd06c237a2935abad130aa3b99b5004b':
  Let the backing view cover the entire content area
2014-08-16 14:02:21 +00:00
Yohei Yukawa 16a43d2bd9 Let the backing view cover the entire content area
With this CL, the backing view starts covering the content area
entirely.  This allows the IME to render its UI elements at an
arbitrary position on the screen.

Change-Id: I8b4173410931b776964dddf66de2fe247e51d9de
2014-08-16 12:28:13 +09:00
Ken Wakasa fb74ab15c1 Abolish source code overlay and inroduce overridable src dir
This should make IDEs happy with appropriate source code directory
selection.

bug: 16829244
Change-Id: Ic734bd4d20aa050c688a3158b1a382ae0ac18991
2014-08-16 03:37:54 +09:00
Jean Chalard 3dbc3ece26 am e04c8b10: am b8d76477: Add the input style to SuggestedWords.
* commit 'e04c8b10d7876effbfdf2340a1fec6bf368c3409':
  Add the input style to SuggestedWords.
2014-08-14 18:10:05 +00:00
Jean Chalard b8d764772b Add the input style to SuggestedWords.
Change-Id: I81f37d08659d449822b027d3d5912e11eec8b8ff
2014-08-14 17:53:04 +09:00
Tadashi G. Takaoka af078ce7b4 am 1901c331: am a94c89e0: Use light emoji icon for Material light tablet keyboard
* commit '1901c331283e2f60e6277a7773a103a447bd31ca':
  Use light emoji icon for Material light tablet keyboard
2014-08-13 15:54:51 +00:00
Tadashi G. Takaoka a94c89e017 Use light emoji icon for Material light tablet keyboard
Bug: 16808603
Change-Id: I39ce0ed8b5580754dfd0cf1494289b0a23863d50
2014-08-14 00:25:34 +09:00
Yohei Yukawa d9a8e1ccfd Enable CursorAnchorInfo callback when necessary
Change-Id: If3dda7442418053600ac935da50baaddb0e31d37
2014-08-13 20:02:14 +09:00