Jean Chalard
fb72890ac6
Readability improvement
...
Change-Id: I2f350145f333ba1fa4eb20027b0f41107c2df02c
2013-06-26 16:03:40 +09:00
Jean Chalard
7fcf304c97
Fixing follow-up to I548d899b
...
I548d899b introduced a new method to fix a sync miss between
the cursor position and the cached cursor position, but did not
take into account that it should also update the cached text
before and after the cursor in this case and that there was
already a method for doing this.
Change-Id: I31bd741893207c822827304e77791b1159774e1a
2013-06-26 15:28:42 +09:00
Keisuke Kuroynagi
5bf1be7162
Add jni methods for dynamically handling a dictionary.
...
Bug: 6669677
Change-Id: I8a26623adbb41a78e3c023c652be635c635e3b47
2013-06-26 12:51:33 +09:00
Jean Chalard
2f69348d51
Resume suggestion at start input
...
Bug: 9568410
Change-Id: I65468268f8613c863fa7f3a497b64656da0a221c
2013-06-25 19:38:31 +09:00
Ken Wakasa
fd0945b0da
Merge "Make UserLogRingCharBuffer an external class"
2013-06-25 09:40:31 +00:00
Ken Wakasa
9419e02fd9
Make UserLogRingCharBuffer an external class
...
Change-Id: I9d506995337d64ec11c72939a8d739423ee46efa
2013-06-25 18:38:13 +09:00
Jean Chalard
333362adfc
Merge "Fix the one-suggestion case."
2013-06-25 09:10:09 +00:00
Jean Chalard
d7d5ff1f99
Fix the one-suggestion case.
...
When there is only one suggestion, this code does
not work. The reason for that is, it's not homogeneous
at all and takes indices of one thing into another.
Not completely related to b/8839763, but realized
working on this and needed to have it addressed.
Bug: 8839763
Change-Id: I422730cc7eebb69ff421a171025af0390ebcdf92
2013-06-25 18:00:30 +09:00
Keisuke Kuroynagi
38b542629a
Merge "Add a parameter isUpdatable to the constructor of BinaryDictionary."
2013-06-25 08:44:48 +00:00
Keisuke Kuroynagi
981717da4c
Add a parameter isUpdatable to the constructor of BinaryDictionary.
...
Bug: 6669677
Change-Id: I6bc25131afd97112e3bbde036a81ab559a9a6460
2013-06-25 17:39:06 +09:00
Ken Wakasa
12ef7d3702
Merge "Cleanup under the utils package"
2013-06-25 08:20:57 +00:00
Ken Wakasa
03118a2760
Cleanup under the utils package
...
Change-Id: If2f7bd1346cc5085bf57645830f0faac44d017e4
2013-06-25 17:09:12 +09:00
Keisuke Kuroynagi
8bc0b51369
Merge "Allow mmapping dictionary file in writable mode in openNative."
2013-06-25 07:09:37 +00:00
Keisuke Kuroynagi
f3b62900c7
Allow mmapping dictionary file in writable mode in openNative.
...
Bug: 6669677
Change-Id: I447668932de118b158fa029ddc977b3f3cc06cb8
2013-06-25 16:03:33 +09:00
Jean Chalard
10585620bd
Merge "Fix a bug in the cached cursor pos, and simplify selection handling"
2013-06-25 05:00:11 +00:00
Jean Chalard
cdf774122d
Merge "Fix a small bug"
2013-06-24 10:00:05 +00:00
Ken Wakasa
bfaf349c35
Load the native lib eagerly
...
in the hope of avoiding UnsatisfiedLinkError. This is definitely not a
confident fix as we still don't know the root cause of the issue.
bug: 9325110
Change-Id: I1abf8031b98509f63fce6a2d069d497895ea712c
2013-06-24 18:12:04 +09:00
Ken Wakasa
bc1813186d
Merge "Move util classes to the latin/utils directory"
2013-06-24 08:49:06 +00:00
Jean Chalard
ca52e1ca5a
Fix a small bug
...
SpannableStrings are not the only type of Spanned, they are
only the mutable kind. SpannedString is the immutable one.
Spanned is the correct class to use there.
Bug: 8839763
Bug: 8862327
Change-Id: Ic5e6199a51f22368914f2748ac2d0d1ca6a33f78
2013-06-24 17:39:17 +09:00
Ken Wakasa
e28eba5074
Move util classes to the latin/utils directory
...
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
2013-06-24 17:04:40 +09:00
Jean Chalard
e8c4b99e56
Refactor text range to be able to get spans larger than the word
...
This changes how the Range class stores its data, but not its
functionality. It also improves encapsulation a bit.
Bug: 8839763
Bug: 8862327
Change-Id: I5bd583b3fc96a99b93a2632882d8fd587c03ab76
2013-06-24 12:31:14 +09:00
Jean Chalard
b7a2fd16a1
Merge "Defer disk-intensive tasks until after the keyboard is shown"
2013-06-21 10:57:33 +00:00
Jean Chalard
673c727b7a
Defer disk-intensive tasks until after the keyboard is shown
...
Bug: 8689779
Change-Id: Ia78d3540f44ec0028c3246a8e0163e9ecf061ecf
2013-06-21 19:41:45 +09:00
Jean Chalard
e5dee0af4a
Fix a bug in the cached cursor pos, and simplify selection handling
...
The documentation for setComposingRegion states explicitly
that it does not move the cursor. This is just a bug.
This does not have any ill effects right now, but it will have
in later changes if not fixed.
As for the selection handling, the specific test that this code
removes used to serve a purpose, but it does not any more because
the code using the value has been much sanitized. Now the variable
can just take the obvious value, and become so self-explanatory
that the comments are unnecessary.
Change-Id: I548d899b38776bd3ab5f5361aab0d89d98f12e73
2013-06-21 18:15:07 +09:00
Tadashi G. Takaoka
9b570b5e62
Fix punctuations strip
...
Bug: 9508186
Change-Id: I8f0fbf4e0578cf9116d4c57e7e5747d38c89387e
2013-06-21 13:22:37 +09:00
Jean Chalard
93f74bafbb
Merge "Add tests to dicttool test."
2013-06-20 08:34:38 +00:00
Jean Chalard
23d4eb55ba
Add tests to dicttool test.
...
Bug: 8526576
Change-Id: Idd6f9cd076d5915361c68f5c29afbba67dd54eba
2013-06-20 17:29:37 +09:00
Tadashi G. Takaoka
c90181d6aa
Use system default key press volume
...
Bug: 9475973
Change-Id: I6ae825b161dde69e19b52d73fb9aa782e2aa7423
2013-06-18 21:34:30 +09:00
Tadashi G. Takaoka
af69a14c96
Use system default vibration pattern
...
Bug: 9468462
Change-Id: Ifa46a56873c10888da8eaa2782fe07ef138a141b
2013-06-18 21:33:51 +09:00
Tadashi G. Takaoka
3be8263035
Get value text from ValueProxy
...
As a preparation to show "system default" in the settings. LatinIME
can't know the actual system default value.
Bug: 9468462
Change-Id: I0b7898d1ca29ded7a619dd636d2ad16eb0db292e
2013-06-18 18:27:17 +09:00
Jean Chalard
2a81943d16
Fix a bug with recapitalization
...
This is a shameful bug :/
Bug: 9410367
Change-Id: I54ddbcd0323fa2c11fbd2aa8a1b3d2e07f6e83c8
2013-06-17 20:39:06 +09:00
Kurt Partridge
14718ab898
Merge "Log score, kind, and sourceDict for manual suggestion and gesture"
2013-06-14 17:03:03 +00:00
Jean Chalard
6233ee3633
Fix a bug with long user dict entries
...
Bug: 9410958
Change-Id: I966e452c6dbdcb444abbb6ffb316849a7c85a73b
2013-06-14 12:40:35 +09:00
Kurt Partridge
fc98325c61
Log score, kind, and sourceDict for manual suggestion and gesture
...
b/9422713
Change-Id: I4880fad6a5b10d09ca11b63311f14862bee724e5
2013-06-13 11:03:49 -07:00
Jean Chalard
27d9c6f795
Merge "Cache subtype lists reasonably."
2013-06-13 01:49:41 +00:00
Kurt Partridge
e72d1a07b6
Merge "Allow downloadable dictionaries in development builds"
2013-06-12 21:22:34 +00:00
Jean Chalard
ff6445ed0e
Cache subtype lists reasonably.
...
This will spare a lot of IPC for Latin IME at the cost of very little
retained memory.
This improves the loading by potentially a lot - between 15 and 30%
when the layout is cached (which should now be the case almost every
time), and half that if it's not. More importantly, it makes the
load time less sensitive to high device load, which is one of the
sore points.
Bug: 8689779
Change-Id: I2e07736f1a92c38eed0e203bc690761a181da8b9
2013-06-12 18:04:52 +09:00
Kurt Partridge
2a1a463e2e
Adjust settings for development-only versions
...
Change-Id: I4f08632d97f182d312edc82bda3c3897a71099ad
2013-06-12 02:01:45 -07:00
Satoshi Kataoka
fe95e7b1bf
Merge "Fix possible NPE"
2013-06-07 11:09:52 +00:00
Tadashi G. Takaoka
77f63c8ac6
Don't use RichInputMethodManager in setup wizard
...
In setup wizard, InputMethodManager may not be able to be aware that
this IME is installed, especially just after the IME is installed via
GooglePlay app and hit the open button on the app to launch the setup
wizard.
Bug: 9299618
Change-Id: I00c8544178b41074253d49ae9481996ec56593d2
2013-06-07 19:09:44 +09:00
Satoshi Kataoka
6c8136d157
Fix possible NPE
...
Bug: 9314901
Change-Id: Id80f59df38ae72766b097fd1c23326fedd302439
2013-06-07 19:08:58 +09:00
Tadashi G. Takaoka
254b484e75
Defer getting no language subtype
...
Bug: 9318351
Change-Id: I55338c001070655a3f90df3dbe1351bd4180d520
2013-06-07 18:20:31 +09:00
Jean Chalard
6910032972
Merge "Use an iterator to remove stuff from an ArrayList."
2013-06-06 08:19:41 +00:00
Jean Chalard
0dc422e0c7
Use an iterator to remove stuff from an ArrayList.
...
Silly me >.>
Bug: 9306154
Change-Id: Ic00e9d6a31cd1d7aacefe68b7be9c2199e297b0d
2013-06-06 17:03:16 +09:00
Kurt Partridge
efd26bb319
Allow downloadable dictionaries in development builds
...
Bug: 9305379
Change-Id: Iab32753070a056d3861a45aa898911b7ab67dfb6
2013-06-05 22:14:54 -07:00
Satoshi Kataoka
f6a1a76524
Merge "Fix a possible NPE"
2013-06-06 05:02:46 +00:00
Satoshi Kataoka
6f9c6f2c64
Fix a possible NPE
...
Bug: 9301208
Change-Id: Id120c99ab9ef698d16cf7b8beea30c98c95d23a1
2013-06-06 12:01:22 +09:00
Tadashi G. Takaoka
cbd219a761
Move Base64Reader to utils package
...
Change-Id: Id46898c5cae268f05850d79938929b7707f27320
2013-06-05 19:39:36 +09:00
Tadashi G. Takaoka
9d4e251826
Merge "Add CsvUtils that conform to RFC 4180"
2013-06-05 06:28:06 +00:00
Tadashi G. Takaoka
3ceeb6bcc6
Add CsvUtils that conform to RFC 4180
...
Bug: 9070153
Change-Id: I66e55dd2f30fddfeb849edb97bc1cbda6b126d92
2013-06-05 12:26:22 +09:00
Tadashi G. Takaoka
0bfc2bc419
Merge "Add CODE_CAPSLOCK for long press shift key"
2013-06-05 02:19:02 +00:00
Tadashi G. Takaoka
9552badf3c
Add CODE_CAPSLOCK for long press shift key
...
This change utilizes the no panel auto more key feature to implement
long press shift key for shift lock.
Change-Id: I3995d25dc35aea3c67b5aa29299815462eff9cad
2013-06-04 18:20:06 +09:00
Tadashi G. Takaoka
cbc7acb6f5
Merge "Expand suggestion strip when center suggestion is long"
2013-06-03 14:45:05 +00:00
Tadashi G. Takaoka
9ff7354d78
Clear previous suggestions when gesture typing starts
...
Bug: 8651076
Change-Id: Ic65ed3e3696409edea4e35080c11e4d1869a5a7e
2013-06-03 17:59:26 +09:00
Tadashi G. Takaoka
043273b00f
Expand suggestion strip when center suggestion is long
...
Bug: 9059710
Change-Id: I7fa2658cc6442e86f69c991f1e99db6fb1ef909c
2013-06-03 16:12:59 +09:00
Tadashi G. Takaoka
72ac390ce6
Fix ArrayIndexOutOfBoundException
...
Change-Id: I243fc4965365680615eed834efe9ae0240e7f2a8
2013-06-03 15:35:49 +09:00
Kurt Partridge
743302888b
Merge "Uncommit separator LogUnits"
2013-06-03 03:01:23 +00:00
Kurt Partridge
3d20946272
Merge "Uncommit LogUnits when reverting textInput"
2013-06-03 02:58:20 +00:00
Kurt Partridge
4efb5c3b65
Merge "Remove uncommit on reverting batch input"
2013-06-03 02:54:33 +00:00
Kurt Partridge
bdff287a0d
Uncommit separator LogUnits
...
Now that separators have their own LogUnits, they must be uncommitted
from the LogBuffer when backspacing over them.
Bug: 9088919
Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
2013-06-02 19:15:57 -07:00
Kurt Partridge
720840851d
Uncommit LogUnits when reverting textInput
...
Bug: 9088919
Change-Id: I17187aa0afc1c3e9d32269c65f66cfb3a08663cb
2013-06-01 23:42:35 -07:00
Kurt Partridge
4165ef031f
Remove uncommit on reverting batch input
...
Currently when the user reverts a batch input, a LogUnit is uncommitted
from the LogBuffer. It should not be, because the LogUnit containing the
batch input is never committed in the first place (it is only committed
to the LogBuffer when a key is pressed or a new batch input is entered).
Bug: 9088919
Change-Id: I323af453ce082437a663ccae977b21b775a964bc
2013-06-01 11:15:47 -07:00
Jean Chalard
f61999caba
Merge "Make it easy to open several dictionaries from tests"
2013-05-31 11:21:37 +00:00
Tadashi G. Takaoka
a0c3e02d71
Refactor SuggestionStripLayoutHelper a bit
...
Bug: 9059710
Change-Id: Ief12029bad75d4dc78090ab97555aece01b873de
2013-05-31 18:14:47 +09:00
Jean Chalard
1562fc91f0
Make it easy to open several dictionaries from tests
...
Bug: 9127175
Change-Id: I3f1840ee73b364df26dfddb5acb10001e0f2cb61
2013-05-31 15:36:05 +09:00
Tadashi G. Takaoka
723391c945
Merge "Tidy up Utils class a bit"
2013-05-31 06:29:24 +00:00
Kurt Partridge
e6125db98d
Merge "Catch a permission exception"
2013-05-31 00:30:14 +00:00
Kurt Partridge
d63f756013
Catch a permission exception
...
This change catches a SecurityException if the DictionaryProvider is
unavailable.
Change-Id: I4f2d87327c40765383d8847fd4e934b3cf799488
2013-05-30 13:40:40 -07:00
Tadashi G. Takaoka
cbb99c60be
Tidy up Utils class a bit
...
Change-Id: Idc2feb84a902a6cbb7265d1efe06c34e7d63c2c7
2013-05-31 00:32:57 +09:00
Tadashi G. Takaoka
7097aa2d3d
Merge "Cleanup unreadable variable names"
2013-05-30 13:09:27 +00:00
Tadashi G. Takaoka
d67db32b30
Merge "Separate SuggestionStripLayoutHelper for readablity"
2013-05-30 13:09:17 +00:00
Jean Chalard
1a50999ed9
Merge "Tell the text view we reset state on finish input"
2013-05-30 11:53:50 +00:00
Jean Chalard
e90d039e0c
Fix two strict mode warnings.
...
Bug: 9052555
Change-Id: I86e90488679a78a9f6e901b640025619293765a0
2013-05-30 20:12:05 +09:00
Tadashi G. Takaoka
500a9752b1
Cleanup unreadable variable names
...
Change-Id: Ic97687c58e25e4b0c6833cc25d10854f5f513081
2013-05-30 19:49:51 +09:00
Tadashi G. Takaoka
653603b725
Separate SuggestionStripLayoutHelper for readablity
...
Change-Id: I82c749c6837c3af7ae290f4cd92f5426ca58b5c7
2013-05-30 19:49:20 +09:00
Jean Chalard
68d9cb62e2
Tell the text view we reset state on finish input
...
This should be done in onFinishInput rather than onFinishInputView
but for an unknown reason onFinishInput never comes.
Bug: 9113167
Change-Id: Iafb40846a3ed8fad78bfc160d17cd431f81fe891
2013-05-29 18:44:40 +09:00
Tadashi G. Takaoka
d99abf8cb1
Delete shared preference entry when user select default value
...
Change-Id: I3fbafd9024c26a99d87376f5d5e359e03988a30f
2013-05-28 20:44:25 +09:00
Tadashi G. Takaoka
39bd6ea0dc
Merge "Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs"
2013-05-28 11:40:10 +00:00
Tadashi G. Takaoka
dbed20ad8d
Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs
...
Change-Id: I16e3f3ebc43772cfd96c824afeddfd225404b857
2013-05-28 20:23:37 +09:00
Tadashi G. Takaoka
d69e4191b7
Merge "Refactor suggestion strip layout methods a bit"
2013-05-28 11:11:05 +00:00
Tadashi G. Takaoka
389d308fff
Refactor suggestion strip layout methods a bit
...
Bug: 9059710
Change-Id: I8dc698c1d61ca51b65b232e6c586472588a4accb
2013-05-28 20:03:37 +09:00
Tadashi G. Takaoka
4c2ac9ee5f
Merge "Rename commaConcatinatedText to commaSplittableText"
2013-05-28 10:58:16 +00:00
Tadashi G. Takaoka
c47bc30db8
Rename commaConcatinatedText to commaSplittableText
...
This is a follow up of I5a32882a08.
Change-Id: I9f0cda2167811f6bba2af042fbde0a821b4cfecd
2013-05-28 19:17:15 +09:00
Tadashi G. Takaoka
68cf2cd931
Merge "Check all regexp patterns in ResourceUtils.getDeviceOverrideValue"
2013-05-28 10:13:43 +00:00
Keisuke Kuroyanagi
e168a3c2a5
Merge "Adding additional feature settings."
2013-05-28 10:11:29 +00:00
Tadashi G. Takaoka
4c75ea858a
Check all regexp patterns in ResourceUtils.getDeviceOverrideValue
...
This change also fixes a regexp error of Galaxy S III.
Change-Id: I42a4780bbfd2b083f4e27e61ec513aa875907344
2013-05-28 19:05:40 +09:00
Satoshi Kataoka
07e56e76a7
Merge "Implement KIND_OOV_CORRECTION"
2013-05-28 07:27:53 +00:00
Keisuke Kuroyanagi
1b100610b3
Adding additional feature settings.
...
Change-Id: I9fec0c03b7da9ce0305b494193f4cfe3fca144f3
2013-05-28 00:27:48 -07:00
Tadashi G. Takaoka
1b46738796
Rename "csv" in StringUtils to "commaConcatenatedText"
...
Change-Id: I5a32882a088e4ff5bfe973a86465d6ff839113d9
2013-05-28 16:13:36 +09:00
Satoshi Kataoka
3d97b95b90
Implement KIND_OOV_CORRECTION
...
Bug: 9127749
Change-Id: I96db15a3138e6b522c4c6ad16cc7faad577d3772
2013-05-27 18:53:43 -07:00
Keisuke Kuroyanagi
28b6262b54
Merge "Passing options to native suggestion method."
2013-05-24 22:27:19 +00:00
Tadashi G. Takaoka
740d829092
Merge "Use localized toLowerString in AutoCorrection.isValidWord"
2013-05-24 20:00:38 +00:00
Tadashi G. Takaoka
94027c7201
Use Locale.ROOT for locale neutral operations
...
Bug: 9112465
Change-Id: I6cd63007287b5a1a57cfbabff35d53f66fc5620e
2013-05-24 12:07:30 -07:00
Tadashi G. Takaoka
618407ab7e
Use localized toLowerString in AutoCorrection.isValidWord
...
Bug: 9112465
Change-Id: I63eb4115f393444560e80220d4c90f0f7101b934
2013-05-24 11:47:36 -07:00
Tadashi G. Takaoka
ebe0544fc8
Remove redundant method AutoCorrection.isInTheDictionary
...
Change-Id: I0737fb0b68f411f4db06014f2d94804935808922
2013-05-24 11:40:03 -07:00
Keisuke Kuroyanagi
50db5f0fff
Passing options to native suggestion method.
...
Change-Id: I6da180cfa1b9e5aa39600e78e3bc41209a40f583
Signed-off-by: Keisuke Kuroyanagi <ksk@google.com>
2013-05-24 10:21:04 -07:00
Tadashi G. Takaoka
6f9105383a
Remove unnecessary methods of KeyboardSwitcher
...
Change-Id: Idd3647bb1a1d40df8bb89eda715d45427a58d0cd
2013-05-22 10:49:53 -07:00
Tadashi G. Takaoka
db7d4da3e5
Clean up IntentCompatUtils a bit
...
Change-Id: I803aa6c2160bfa1ffe992b28e7eb6e8a320c9762
2013-05-21 15:13:23 -07:00
Jean Chalard
d96f63d2ed
am e2bee5b1
: am ede3db51
: Merge "Fix a crash on a secondary user" into jb-mr2-dev
...
* commit 'e2bee5b134aaefc69a680be8ea65e2d7640b3ead':
Fix a crash on a secondary user
2013-05-20 21:32:21 -07:00
Jean Chalard
ede3db51f0
Merge "Fix a crash on a secondary user" into jb-mr2-dev
2013-05-21 04:27:34 +00:00
Jean Chalard
05ea7c5d02
am 167ba345
: am 89fe1f50
: Add a method to work around apps broken by recorrection
...
* commit '167ba3459b0ce02b9add12ade9388bd2b1e6eb62':
Add a method to work around apps broken by recorrection
2013-05-20 21:10:07 -07:00
Satoshi Kataoka
10e8b93977
Fix a crash on a secondary user
...
Bug: 9054063
Change-Id: I092ab6e0077578d0aca57d2e41dfbc00b46e1ba4
2013-05-21 12:27:16 +09:00
Jean Chalard
0013f97ddd
am 5906b05b
: am 7058b02a
: Extract a new class for app-specific workarounds.
...
* commit '5906b05bb50c0a67bd4f03fcfae41db3daefe0bc':
Extract a new class for app-specific workarounds.
2013-05-20 19:50:46 -07:00
Jean Chalard
89fe1f5088
Add a method to work around apps broken by recorrection
...
Bug: 8944307
Change-Id: I8986622554f30aaf4f595099c4ab5652b75c972c
2013-05-21 07:53:31 +09:00
Jean Chalard
7058b02a9c
Extract a new class for app-specific workarounds.
...
Bug: 8944307
Change-Id: Iaff9dd03d3d856a6bdaa2b16c4e71e95cd2b6349
2013-05-21 07:53:28 +09:00
Kurt Partridge
500dea6ad4
Fix punctuation logging
...
Punctuation is currently put into the same LogUnit as the
following word. This is counter-intuitive and makes
post-processing more complicated.
This change causes punctuation to be put into its own
LogUnit.
A tricky case is the phantom space. A phantom space is
inserted right before other text, whose MotionEvents have
already been collected and inserted into mCurrentLogBuffer.
Phantom spaces are handled by creating their own LogUnit and
inserting it into the LogBuffer right before
mCurrentLogBuffer is shifted in.
Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
2013-05-17 09:47:40 -07:00
Kurt Partridge
17b63ba588
Merge "Remove unnecessary commit/uncommit"
2013-05-15 23:52:43 +00:00
Jean Chalard
b1e37e4a47
am f1dcf725
: Merge "Don\'t process recorrection or resets when not shown"
...
* commit 'f1dcf725061b3e61e40540566a5385cf4934f424':
Don't process recorrection or resets when not shown
2013-05-15 07:58:27 -07:00
Tadashi G. Takaoka
25f0c8089e
am 96a9f357
: Merge "Fix unintentional setup step advance in orientation change"
...
* commit '96a9f357c7e2a059687926cd7cd52ac5d06bc65e':
Fix unintentional setup step advance in orientation change
2013-05-15 07:58:18 -07:00
Tadashi G. Takaoka
7fe675440e
am 769427cf
: Adjust aspect ratio of setup image
...
* commit '769427cff24944958f5f1f6179090a86444f3eab':
Adjust aspect ratio of setup image
2013-05-15 07:57:38 -07:00
Jean Chalard
f1dcf72506
Merge "Don't process recorrection or resets when not shown"
2013-05-15 11:25:25 +00:00
Jean Chalard
c9aaba1253
Don't process recorrection or resets when not shown
...
Bug: 8954116
Change-Id: Ica27dbfc570643bb81e6cdf34cc7c796ea080d71
2013-05-15 20:20:20 +09:00
Tadashi G. Takaoka
9b4a883e09
Fix unintentional setup step advance in orientation change
...
Bug: 8159728
Change-Id: I53e7d7c8fb5cc231ea94474b091e550f77ae8dab
2013-05-15 19:50:35 +09:00
Tadashi G. Takaoka
769427cff2
Adjust aspect ratio of setup image
...
Bug: 8159728
Change-Id: I578014912fa63c4c9b4c2c89aeae7ffec836b06c
2013-05-15 14:48:27 +09:00
Kurt Partridge
993acbaaa2
Remove unnecessary commit/uncommit
...
When the user reverts a commit, this causes the committed
word to be changed. The user usually then goes back to edit
that word. Going back to edit causes an uncommit, so that
the editing actions are added onto the LogUnit containing
the operations used to construct the word.
But currently, reverting also involves its own
commit/uncommit pair, with the caller performing the
uncommit, and the commit happening inside the revert
command. This may have been necessary in the past, when
revert was called in different situations, but is
unnecessary now. Furthermore, the guarding conditions are
currently such that the uncommit doesn't always undo the
effects of the commit, corrupting the log output.
Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
2013-05-14 12:20:27 -07:00
Tadashi G. Takaoka
8b56ad7814
Merge "Revise welcome screen video and still image"
2013-05-14 12:01:47 +00:00
Tadashi G. Takaoka
7348d9fb72
Revise welcome screen video and still image
...
Bug: 8159728
Change-Id: Ief8d7197879d24ccef529e975c23d6f11c7aa458
2013-05-14 20:56:09 +09:00
Ken Wakasa
d6d70e7325
Merge "Revert "Fix isSuggestionsStripVisible when keyboard hidden""
2013-05-14 11:46:04 +00:00
Ken Wakasa
3efa36f6aa
Revert "Fix isSuggestionsStripVisible when keyboard hidden"
...
This reverts commit cb0d1c4c58
Change-Id: Ie2c8e01c25bd051b6157e8f32ab84392a0c7252a
bug: 8954116
2013-05-14 11:44:22 +00:00
Tadashi G. Takaoka
41016acacf
Back to previous keyboard layout by canceling sliding input
...
Bug: 8915171
Change-Id: Iabdeb7920f67f89246087c3ee06240406ecfbc3d
2013-05-14 20:28:03 +09:00
Jean Chalard
cb0d1c4c58
Fix isSuggestionsStripVisible when keyboard hidden
...
When the keyboard is hidden, the suggestion strip is
never visible.
Bug: 8954116
Change-Id: I9f242d07b49ad60b625a22429bb013251e814905
2013-05-14 15:19:19 +09:00
Tadashi G. Takaoka
b121538e0c
Tune maximum keypress duration to 100 milliseconds
...
Bug: 8556975
Change-Id: If7839c5764f7a269243a9570c0b7782b6f7ee73b
2013-05-13 20:04:59 +09:00
Tadashi G. Takaoka
b5f67e7faf
Add device specific keypress vibration duration database
...
Bug: 8556975
Change-Id: I11260a64dc13c102bac7a9742dc66f2b05fd32de
2013-05-13 18:34:48 +09:00
Tadashi G. Takaoka
18184eacb1
Support regular expression for condition pattern
...
Bug: 8556975
Change-Id: Iffc53d6a40dd77860434c5f7f4f59af5cd1ba92b
2013-05-13 16:25:03 +09:00
Tadashi G. Takaoka
d69fa0a09a
Support multiple condition for getDeviceOverrideValue
...
Bug: 8556975
Change-Id: I29d3a305b6ac3d8e3620c6d8592d85047d62bf48
2013-05-13 14:38:21 +09:00
Tadashi G. Takaoka
565ced4546
Merge "Refactor StringUtils.findPrefixedString to findValueOfKey"
2013-05-10 09:49:07 +00:00
Tadashi G. Takaoka
6d3d2ae064
Refactor StringUtils.findPrefixedString to findValueOfKey
...
Bug: 8556975
Change-Id: I275c99db8a0d10594a5a8c0c27ebc1a87495c307
2013-05-10 18:44:04 +09:00
Tadashi G. Takaoka
4705c0fa7c
Fix screen flash when launching settings activity
...
Bug: 8336068
Change-Id: I90a0f259129a3f3319b158b060154cc43960c234
2013-05-10 15:36:24 +09:00
Tadashi G. Takaoka
2b5c9726f4
Introduce another activity to launch setup wizard
...
Bug: 8336068
Change-Id: I35b94dd87c5b01d3e927da8f918a5398dd565d33
2013-05-10 15:30:53 +09:00
Tadashi G. Takaoka
9ed322b40f
Keep SetupActivity alive to check re-launching from launcher
...
Bug: 8336068
Change-Id: I183b8e3fd1b3898d5f8dbbb13a0c93c64341fc38
2013-05-10 15:15:53 +09:00
Satoshi Kataoka
b902109000
Fix usages of getEnabledInputMethodSubtypeList
...
Bug: 8450279
Change-Id: Ib8433442ae6ca6c28da2652bff687cdeaf7c196e
2013-05-09 17:07:19 +09:00
Jean Chalard
71d52474fd
Merge "Optimizations and safeguards."
2013-05-08 10:11:49 +00:00
Jean Chalard
9f9cc03277
Optimizations and safeguards.
...
- Don't call finishComposingText when useless.
- Add safeguards against calling setComposingRegion when the
data returned by the editor is inconsistent.
- Cancel pending recorrection messages when new messages arrive.
Bug: 8842941
Bug: 8845001
Change-Id: I939701033cf5c2bbd85871ecf83e329021ddeb91
2013-05-08 18:47:10 +09:00
Satoshi Kataoka
5648054667
Add account e-mail addresses to the user dictionary
...
Bug: 8683365
Change-Id: Id72540c515e61c3dd854892599645dd6d22b496d
2013-05-08 17:58:21 +09:00
Satoshi Kataoka
faa94a2d0a
Merge "Add owner's info to the dictionary"
2013-05-08 08:31:45 +00:00
Satoshi Kataoka
fc6d4a5412
Add owner's info to the dictionary
...
Bug: 8683365
Change-Id: I1c30eac128b4172526423ebeeb45bc6cee7fb67b
2013-05-08 17:29:04 +09:00
Satoshi Kataoka
6435c80087
Merge "Fix an issue on the transition between the setup and the settings"
2013-05-08 08:23:49 +00:00
Tadashi G. Takaoka
331d256f21
Fix an issue on the transition between the setup and the settings
...
Bug: 8853220
Change-Id: I99b6c46d900e9391f77986d1ae6e3edeaeff01e5
2013-05-08 15:18:45 +09:00
Satoshi Kataoka
f59c4f6840
Fix labels in the personal dictionary settings
...
Bug: 8855738
Bug: 8853764
Change-Id: I03383bb5d6d72645f511cc6175dec747eb13a840
2013-05-08 14:58:43 +09:00
Satoshi Kataoka
244a24e368
Consolidate dummy proximity info to the spell checker info
...
Bug: 8783170
Change-Id: I067486e5ec1ae7cdef8e2121392464ba71ee8add
2013-05-08 11:49:12 +09:00
Jean Chalard
2afe88b8d7
Merge "Unify space-adding on gestures."
2013-05-07 11:51:01 +00:00
Jean Chalard
e8b9b35471
Unify space-adding on gestures.
...
This is much simpler, and more correct.
Bug: 8808497
Change-Id: I7a56bf9d6d9fb481f898b7a9f5898a86c11b34c0
2013-05-07 20:38:09 +09:00
Satoshi Kataoka
a9dd74cf3f
refactor spell checker
...
Change-Id: Ie7bea23f2ac54f03572e77c31ba7cb3d5e8f8d2f
2013-05-07 20:21:11 +09:00
Tadashi G. Takaoka
a5be033d4a
Preserve setup wizard step while orientation change
...
Bug: 8159728
Change-Id: I596f59749443b8878b5613285f0fe793d449cdbd
2013-05-02 18:42:10 +09:00
Jean Chalard
83757d439e
Merge "Pass blockOffensiveWords as a parameter"
2013-05-01 11:57:36 +00:00
Jean Chalard
2dbb5957e3
Pass blockOffensiveWords as a parameter
...
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
2013-05-01 20:47:35 +09:00
Ken Wakasa
1490b53416
Cleanup -- follow up to Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
...
Change-Id: Icb89c5119a67edaa019d5f7645b734cfcfc29041
2013-05-01 20:19:05 +09:00
Satoshi Kataoka
1641a4a457
Merge "Fix Google spell checker tests"
2013-05-01 09:31:52 +00:00
Satoshi Kataoka
d5781eef62
Fix Google spell checker tests
...
Bug: 8613307
Change-Id: Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
2013-05-01 18:21:56 +09:00
Tadashi G. Takaoka
6f7905ae75
Introduce MoreSuggestionsListener class
...
Bug: 8694255
Change-Id: I9420a7cb1983c6211f58d13b3b11db4347c3f99b
2013-05-01 18:03:37 +09:00
Tadashi G. Takaoka
47a66b12ec
Override View.drawableStateChanged to detect state_pressed
...
Unlike on JB, View.setPressed(boolean) is never called when the view
is pressed on ICS. To detect a pressed state of the view, we need to
override View.drawableStateChanged() and check the drawable state
contains state_pressed.
Bug: 8159728
Change-Id: I481051364d6f3d1370742723c3ce19d898ea5463
2013-05-01 14:02:18 +09:00
Tadashi G. Takaoka
7b2114a428
Display still image when device can't play welcome video
...
Note that the still image in this change is a placeholder and must be
replaced by final asset.
Bug: 8159728
Change-Id: I4f5a28e0af711edacbc87c2ee64508f34f67f0da
2013-05-01 12:24:36 +09:00
Jean Chalard
019c38060d
am ace3f3c5
: am 25c90e6d
: Merge "Don\'t do recorrection when suggestions are off." into jb-mr2-dev
...
* commit 'ace3f3c5d56f5b4a58e8dc400fec1bb8c7b17a63':
Don't do recorrection when suggestions are off.
2013-04-30 19:22:13 -07:00
Jean Chalard
aa3a96f3a1
Don't do recorrection when suggestions are off.
...
Bug: 8767981
Change-Id: If5c775e488b91ae03ecce2673c99918ac8134928
2013-05-01 10:17:28 +09:00
Ken Wakasa
a0b62ece83
Merge "Cleanup an unused return value"
2013-04-30 11:16:28 +00:00
Tadashi G. Takaoka
ad46c9e0e0
Catch error while playing welcome video
...
Bug: 8159728
Change-Id: Ic8eea7993f12395d6eca6db8d5529803251a9fee
2013-04-30 18:18:32 +09:00
Ken Wakasa
0d6c87d113
Cleanup an unused return value
...
Change-Id: I974964aa3cc24b5480e57bd38c197fe7a49acaa4
2013-04-30 16:53:18 +09:00
Satoshi Kataoka
5aa14c2636
Fix the title of the fragment of the personal dictionary
...
This change is corresponding to I9b8bab21b144385bc2386e7fcb
Bug: 8600958
Change-Id: I0a0cf37d0a11c14a51dc63b2e4371facb34514d0
2013-04-30 15:01:51 +09:00
Jeff Sharkey
c5ebc792d6
Avoid leaking AssetFileDescriptor.
...
Change-Id: Iac388c8aefc684980cb4c7131fb47319f6073eb3
2013-04-29 12:26:44 -07:00
Tadashi G. Takaoka
be06bce18b
Merge "Get rid of janky black box before the movie starts"
2013-04-26 09:38:54 +00:00
Tadashi G. Takaoka
732c93815a
Get rid of janky black box before the movie starts
...
Bug: 8159728
Change-Id: I1d0a01a05b3b694d21fdfdc246d1329ab829908d
2013-04-26 18:26:12 +09:00
Jean Chalard
c03aaa1bde
Merge "[ZF2] Read settings for profanity filtering."
2013-04-26 08:23:56 +00:00
Satoshi Kataoka
adbafa1a9b
Merge "Support ICS on the user dictionary settings"
2013-04-26 06:50:42 +00:00
Satoshi Kataoka
dcef94165b
Support ICS on the user dictionary settings
...
Bug: 8600958
Change-Id: I50e9228afc7b04147eb7c4734d3145abe8859a30
2013-04-26 15:48:08 +09:00
Tadashi G. Takaoka
82e476b188
Keep task stack when invoking settings from setup wizard
...
Bug: 8336068
Change-Id: If1df32595f72285b2dad16e28b4429b7b6059839
2013-04-26 13:03:37 +09:00
Jean Chalard
bb61293675
[ZF2] Read settings for profanity filtering.
...
Bug: 7226877
Change-Id: Ie0c713e1eba1529c0b288a1e5011023a79bedd6b
2013-04-25 20:29:14 +09:00
Jean Chalard
99e998286d
[ZF1] Check profanity in Java rather than in native
...
Bug: 7226877
Change-Id: Ib6c32bfee9977c27dbf7e1e590b2b00d9ceb7301
2013-04-25 20:29:11 +09:00
Jean Chalard
43590149a5
Work around a bug in older DownloadManager versions.
...
This adds a number to the extension.
Note that for DownloadManager to keep this, the server
needs to send it a mime type it does not recognize. Right
now, it does not recognize application/json so it's okay,
but we'd do well to remove the content/type header from
the server to prevent problems.
Bug: 8467516
Change-Id: Ic484f66ac3f67c36f59f2c0bcb8c7fdeb6e8590d
2013-04-25 18:52:39 +09:00
Jean Chalard
a995bf4031
Put temp files within app files
...
Bug: 8715614
Change-Id: I307d83923070994525cf0d27aad403e881a89314
2013-04-25 18:14:40 +09:00
Satoshi Kataoka
30f0f3a92a
Merge "Implement a functionality to add an entry to the user dictionary"
2013-04-25 06:04:08 +00:00
Satoshi Kataoka
a79ba8a3d6
Implement a functionality to add an entry to the user dictionary
...
Bug: 8600958
Change-Id: Ic472500406b9d54ec4052c490ee7cef62fc4e52a
2013-04-25 14:55:07 +09:00
Tadashi G. Takaoka
46913aedb4
Merge "Add next axction to setup wizard"
2013-04-24 10:30:56 +00:00
Tadashi G. Takaoka
b5d33059e0
Add next axction to setup wizard
...
Bug: 8159728
Change-Id: Ia37ab32b63e4eda29bf1411719d00846525c278f
2013-04-24 19:22:41 +09:00
Satoshi Kataoka
b35aa487fd
Merge "Make aggressive threshold really aggressive"
2013-04-24 09:14:30 +00:00
Satoshi Kataoka
70f2762e28
Make aggressive threshold really aggressive
...
Bug: 8701480
Change-Id: If8242cfe61f3e56712fd6e25e36858cff7f0d177
2013-04-24 17:49:56 +09:00
Tadashi G. Takaoka
e918bf07a0
Refactor SetupStepGroup
...
Bug: 8159728
Change-Id: I1ab846d0910aacbd2f979289d72bafea8a8e0378
2013-04-24 14:15:59 +09:00
Tadashi G. Takaoka
480284e28a
Merge "Add edit personal dictionary settings menu"
2013-04-23 06:01:45 +00:00
Jean Chalard
c3f4783649
Add an additional ID to the client info.
...
Bug: 8651863
Change-Id: I748f35726d72ede926d5b06ed87ff029317f1ac3
2013-04-23 14:37:15 +09:00
Satoshi Kataoka
9b4e3db1af
Legal notice
...
Bug: 8533258
Change-Id: I00e4916f86f29dd476c51a65e8fa5a6c136fd179
2013-04-22 21:55:53 +09:00
Tadashi G. Takaoka
4f2535398a
Add edit personal dictionary settings menu
...
Bug: 8600958
Change-Id: I303adfbe25a56cc9b5ee9f3b5169a5bca0ad6c4a
2013-04-22 19:59:12 +09:00
Tadashi G. Takaoka
508ab24875
Merge "Implement IMM.switchToNextInputMethod() for ICS"
2013-04-22 10:37:11 +00:00
Tadashi G. Takaoka
85629debaa
Implement IMM.switchToNextInputMethod() for ICS
...
Bug: 8633367
Change-Id: Ifc0f97b1fdf5e5cc3601c24a503058c4822478dc
2013-04-22 19:30:56 +09:00
Jean Chalard
f0e579a171
Don't kill suggestions with native score < 1
...
Change-Id: I954856b7fec0b91e19a467f2a87978d49caa639d
2013-04-22 14:21:43 +09:00
Tadashi G. Takaoka
68e4de1e78
Add welcome screen to setup wizard
...
This is a preliminary implementation because the welcome screen video
is just a placeholder.
Bug: 8159728
Change-Id: I6a2459a266babec2f078fc393b18c77b0b7992a8
2013-04-19 20:49:49 +09:00
Tadashi G. Takaoka
fcefabf9ab
Groundwork to implement landscape and welcome screen
...
Bug: 8159728
Change-Id: I05ff6578980ec2e210ebb482ea51b1600e74a4f4
2013-04-19 20:10:59 +09:00
Tadashi G. Takaoka
16ec2e1155
Merge "Add finish action to setup wizard"
2013-04-19 10:58:55 +00:00
Tadashi G. Takaoka
192743a6ae
Add finish action to setup wizard
...
Bug: 8159728
Change-Id: I1578fc31875a1edbfea213fb5e1a1b464d02e941
2013-04-19 19:44:54 +09:00
Jean Chalard
ff078041e7
am f1dde6a1
: am 758c74fe
: Merge "Fix an NPE in recorrection" into jb-mr2-dev
...
* commit 'f1dde6a1bf659d182db5a2645515cc1efe74459c':
Fix an NPE in recorrection
2013-04-19 00:10:22 -07:00
Jean Chalard
e5cbdfe1b8
am 3629605b
: am 77226ed0
: Merge "Fix an NPE in recapitalize" into jb-mr2-dev
...
* commit '3629605b7c14b5eea498ef9588f4fef788ef454c':
Fix an NPE in recapitalize
2013-04-19 00:06:58 -07:00
Jean Chalard
758c74fe82
Merge "Fix an NPE in recorrection" into jb-mr2-dev
2013-04-19 07:03:19 +00:00
Jean Chalard
77226ed006
Merge "Fix an NPE in recapitalize" into jb-mr2-dev
2013-04-19 07:01:10 +00:00
Jean Chalard
ae7d1530b4
Fix an NPE in recorrection
...
Also, theoretically, we don't want to retrieve older suggestions if
there are no results for a recorrection - that would look random.
This bug addresses this too.
Bug: 8657919
Change-Id: I44f36d34a708a968ab71fa0592da57f4c97d4b7f
2013-04-19 15:53:33 +09:00
Jean Chalard
3bdf341ea0
Fix an NPE in recapitalize
...
Bug: 8657736
Change-Id: I459d1c200826c1c394f8207475ecf60a4f356793
2013-04-19 15:44:20 +09:00
Tadashi G. Takaoka
1f6e06cf92
Merge "Make setup wizard step number highlighted when activated"
2013-04-19 03:21:04 +00:00
Tadashi G. Takaoka
b84c0468e4
Make setup wizard step number highlighted when activated
...
Bug: 8159728
Change-Id: I62ccbebaae0a0c4a93ad7c155fc3020a7f357f3c
2013-04-19 11:14:21 +09:00
Jean Chalard
3a18ae70cc
am a5d2da82
: am d91268ad
: Initialize dictionaries at onStartInputView
...
* commit 'a5d2da82a6a4486a4ef74e51ddd1c875f4c2d935':
Initialize dictionaries at onStartInputView
2013-04-18 09:27:35 -07:00
Jean Chalard
d91268ad9f
Initialize dictionaries at onStartInputView
...
Bug: 8344402
Change-Id: I41b8440f0d72a66fde3f6feb0db8239c9bb10ea3
2013-04-18 14:48:42 +09:00
Tadashi G. Takaoka
d794f5ae2a
Update setup wizard icons
...
Bug: 8159728
Change-Id: Ia5a14a35292b43dc1eaa2d4edd65134040355149
2013-04-18 13:15:53 +09:00
Tadashi G. Takaoka
464202047d
Add user feedback to setup action labels and icons
...
Bug: 8159728
Change-Id: I46c77c31973ae492c2a12291f2e0b154f64d26c9
2013-04-17 19:57:46 +09:00
Tadashi G. Takaoka
47a78aeb4d
Merge "Finalize setup wizard strings and mark as translatable"
2013-04-17 10:55:41 +00:00
Tadashi G. Takaoka
8712ac7945
Finalize setup wizard strings and mark as translatable
...
Bug: 8159728
Change-Id: I9f6f04b09b2cefdb7ece76a4f3c39ab56d0c8fab
2013-04-17 19:52:50 +09:00
Tadashi G. Takaoka
bb5deb82b5
Fix singleton/utility classes initialization in SettingsFragment
...
This is a follow up of Ide3cd3acba.
Bug: 8632344
Change-Id: Iafe51798a1a74eff5d8fcd6f0117d16b419d447d
2013-04-17 16:16:10 +09:00
Tadashi G. Takaoka
888a194cf1
Fix missing AudioAndHapticFeedbackManager initialization
...
Bug: 8632344
Change-Id: Ide3cd3acba3987317cff709fa591eadaa71834e8
2013-04-17 15:32:01 +09:00
Jean Chalard
73ec85b8ad
Don't insert automatic spaces when text looks like a URL
...
This is about as ad-hoc as it gets, but then again, what we want
is probably as ad-hoc as it gets.
All URL boxes I know of double as search bars, and not adding
automatic spaces there sucks (e.g. in Chrome URL bar).
And in other boxes actually you don't want to add a space if
it looks like a URL. QSB isn't even a search box, and it behaves
like this.
So I think this is actually the right answer to the problem.
Bug: 7062925
Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
2013-04-16 18:03:49 +09:00
Jean Chalard
78d658734d
Merge "Don't recapitalize on shift while on symbol layout"
2013-04-16 05:31:43 +00:00
Jean Chalard
1f52364630
Don't recapitalize on shift while on symbol layout
...
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
2013-04-16 14:29:02 +09:00
Jean Chalard
8094bf45d7
Match the keyboard state to the recapitalize state.
...
Bug: 7657025
Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
2013-04-16 14:25:03 +09:00
Jean Chalard
e259b9f57d
Merge "Clean up RecapitalizeStatus"
2013-04-16 04:57:35 +00:00
Jean Chalard
fd15686ae9
Merge "Fix an NPE"
2013-04-16 04:12:18 +00:00
Jean Chalard
b794e904a3
Clean up RecapitalizeStatus
...
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
2013-04-16 13:11:18 +09:00
Jean Chalard
a024ac6b20
Merge "Fix an NPE"
2013-04-16 03:43:06 +00:00
Jean Chalard
2b42ad0eaa
Fix an NPE
...
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
2013-04-16 12:20:10 +09:00
Jean Chalard
7be3ca2ccf
Fix an NPE
...
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
2013-04-16 12:17:22 +09:00
Jean Chalard
5fca38c538
Merge "Small performance improvement / minor bugfix"
2013-04-15 14:28:16 +00:00
Jean Chalard
b76ce1251e
Merge "Remove a useless function"
2013-04-15 13:06:33 +00:00
Jean Chalard
bc501647fd
Remove a useless function
...
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
2013-04-15 22:01:37 +09:00
Jean Chalard
1e5bbe4ce8
Small performance improvement / minor bugfix
...
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.
Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
2013-04-15 21:18:50 +09:00
Jean Chalard
a5a2f3e3c7
Remove gesture suggestions with an INT_MIN score
...
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
2013-04-15 20:55:49 +09:00
Jean Chalard
033958330d
Merge "Have Latin IME re-capitalize a selected string"
2013-04-15 11:29:28 +00:00
Jean Chalard
2995abe7aa
Have Latin IME re-capitalize a selected string
...
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.
Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
2013-04-15 20:23:01 +09:00
Jean Chalard
0e9ee4d3bf
If there are no suggestion span, recompute suggestions.
...
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
2013-04-15 19:33:23 +09:00
Jean Chalard
059e084e98
Merge "Reject a previously user-refused suggestion."
2013-04-15 07:45:34 +00:00
Jean Chalard
d40f3f6bc1
Reject a previously user-refused suggestion.
...
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.
Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
2013-04-15 16:36:44 +09:00
Tadashi G. Takaoka
216fb6a042
Remove unnecessary harmful finish() from SettingsActivity
...
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
2013-04-15 16:26:40 +09:00
Tadashi G. Takaoka
29105a725d
Add preference dependency to gesture input related options
...
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
2013-04-15 15:07:49 +09:00
Tadashi G. Takaoka
e2af9b7eb5
Merge "Reset vertical correction when more suggestions are in modal mode"
2013-04-15 04:57:33 +00:00
Tadashi G. Takaoka
51c38a441a
Reset vertical correction when more suggestions are in modal mode
...
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
2013-04-15 13:56:03 +09:00
Jean Chalard
c2e9c511cb
Fix Binary dict tests
...
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.
The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.
All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.
Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
2013-04-15 12:48:16 +09:00
Jean Chalard
2cd1136b8e
Merge "Remove the dialog to insert words to the dictionary."
2013-04-12 12:33:24 +00:00
Jean Chalard
91bcf5eb5d
Merge "Restart suggestions when the cursor moves."
2013-04-12 12:27:50 +00:00
Jean Chalard
02ce3dc2d1
Fix a bug with bad application completions
...
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
2013-04-12 20:53:06 +09:00
Jean Chalard
6a114fa700
Restart suggestions when the cursor moves.
...
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
2013-04-12 20:49:03 +09:00
Jean Chalard
d24f939712
Merge "Make shortcut-only user dict entry non-words."
2013-04-12 11:02:00 +00:00
Jean Chalard
fb5869e9ff
Merge "Add a class to encapsulate getting the metadata URI"
2013-04-12 11:01:36 +00:00
Jean Chalard
6a2a4b8e4d
Make shortcut-only user dict entry non-words.
...
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
2013-04-12 16:17:09 +09:00
Jean Chalard
1a51833828
Remove the dialog to insert words to the dictionary.
...
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
2013-04-12 15:58:50 +09:00
Jean Chalard
8987cccf89
Add a class to encapsulate getting the metadata URI
...
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
2013-04-11 17:52:16 +09:00
Jean Chalard
b5d5190deb
Merge "Add some utility functions."
2013-04-11 07:35:22 +00:00
Jean Chalard
1cbb0b8f2a
Add some utility functions.
...
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
2013-04-11 16:16:19 +09:00
Tadashi G. Takaoka
f67a388197
Merge "Add TypefaceUtils"
2013-04-11 05:32:58 +00:00
Tadashi G. Takaoka
08ae0d5ca0
Add TypefaceUtils
...
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
2013-04-11 14:27:42 +09:00
Tadashi G. Takaoka
6d0027a46a
Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>"
2013-04-11 05:06:35 +00:00
Jean Chalard
3722f0877e
Merge "Fix two bugs in dicttool"
2013-04-11 03:07:30 +00:00
Jean Chalard
ca0fdbbe2e
Fix two bugs in dicttool
...
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.
Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
2013-04-10 22:10:31 +09:00
Jean Chalard
fb3e805722
Merge "Fix a bug where a space would not be inserted before a gesture"
2013-04-10 11:19:31 +00:00
Jean Chalard
30b8004b56
Fix a bug where a space would not be inserted before a gesture
...
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
2013-04-10 20:10:28 +09:00
Tadashi G. Takaoka
ce811f50d2
Use private lock object instead of synchronized method
...
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
2013-04-10 18:27:11 +09:00
Jean Chalard
99b93d17d5
Fix a bug where autocorrection status would be wrong.
...
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
2013-04-10 17:49:19 +09:00
Tadashi G. Takaoka
262d5bd9f9
Don't override EXTRA_SHOW_FRAGMENT if exists
...
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
2013-04-10 16:24:17 +09:00
Tadashi G. Takaoka
10af4b6e45
Merge "Separate StringUtils.capitalizeFirstCharacter"
2013-04-10 06:30:33 +00:00