Keisuke Kuroyanagi
7d57fc248b
Clean up for Iba6eeb7981634e7ddb.
...
Bug: 15298959
Change-Id: I6921db77b7d231ad3aad99d4c380ae2ed6bbf540
2014-05-29 13:16:24 +09:00
Keisuke Kuroyanagi
4bffac6db9
Stop directly checking SuggestedWordInfo.mKind
...
Bug: 15298959
Change-Id: Iba6eeb7981634e7ddb896404978b30f6efd6e72f
2014-05-28 20:35:45 +09:00
Tadashi G. Takaoka
14ea11fcde
Add TODO comment about SuggestedWordInfo's kind and flags
...
This CL must be checked in together with I6fd87e1eec.
Change-Id: I4b24157f3e3ce6327579d37122a34d7a30069885
2014-05-28 11:51:05 +09:00
Keisuke Kuroyanagi
dfca51726e
Return whether the dynamic dict operation was success.
...
Bug: 12184250
Change-Id: Iee7e00c1e84c95551a077f4dd023c0a9b9ac9466
2014-05-27 17:30:00 +09:00
Keisuke Kuroyanagi
26628eeb4b
Merge "Add thread name for PrioritizedSerialExecutor."
2014-05-27 07:24:26 +00:00
Keisuke Kuroyanagi
6a546147eb
Merge "Stop filtering out when perfect freq > top non-perfect freq."
2014-05-27 07:14:16 +00:00
Keisuke Kuroyanagi
00da83ed75
Stop filtering out when perfect freq > top non-perfect freq.
...
Bug: 13142176
Change-Id: I0290df918a5bd5018bf55231dc462d5e797155c6
2014-05-27 16:09:59 +09:00
Keisuke Kuroyanagi
733a9c09a9
Add thread name for PrioritizedSerialExecutor.
...
Bug: 15270123
Change-Id: I655ba97f0543476980d0e8461bc1c8a56c9f954b
2014-05-27 16:06:08 +09:00
Tadashi G. Takaoka
01748cde4e
Move MoreSuggestionsListener to MoreSuggestionsView
...
Change-Id: I3b5bc630bf73a357ed0beeec0b555149ef248313
2014-05-27 14:49:25 +09:00
Keisuke Kuroyanagi
71c795d00b
Merge "Apply distracter filter for UserHistoryDictionary."
2014-05-26 16:28:23 +00:00
Keisuke Kuroyanagi
17bd4eb0c9
Apply distracter filter for UserHistoryDictionary.
...
Bug: 13142176
Change-Id: I67d63a5c789d7c587bcd7abacd26b2e76da11978
2014-05-27 01:10:04 +09:00
Keisuke Kuroyanagi
f85b478cd8
Merge "Apply distracter filter for in-vocabulary words."
2014-05-26 14:25:17 +00:00
Keisuke Kuroyanagi
ba33831d76
Apply distracter filter for in-vocabulary words.
...
Bug: 13142176
Change-Id: I4db763783a2f8b9a0df0df951db3223f70748870
2014-05-26 23:11:24 +09:00
Keisuke Kuroyanagi
0088d1f668
Merge "Use whether it's exact match to detect distracters."
2014-05-26 13:53:19 +00:00
Keisuke Kuroyanagi
a6278eb9c1
Use whether it's exact match to detect distracters.
...
Bug: 13142176
Change-Id: Id5b7286d28897931f7bfe571be45d46ffeef4adf
2014-05-26 21:56:20 +09:00
Tadashi G. Takaoka
9df51d10fa
Keep showing important notice when "show correction suggestions" is off
...
When
1. The important notice message is shown on the suggestions strip.
2. And the "Show correction suggestions" settings is off.
we will keep showing the important notice message on the suggestion
strip.
Bug: 13741460
Change-Id: I411007ab1e5e6959b6cdba7a6601a84635259313
2014-05-26 14:11:41 +09:00
Tadashi G. Takaoka
630a24141e
Use ViewCompat support library and delete ViewCompatUtils
...
Change-Id: I57d60cacd86e83894294c3f64402aba8c1829872
2014-05-24 12:26:30 +09:00
Tadashi G. Takaoka
790934158d
Revert "Use ViewCompat support library and delete ViewCompatUtils"
...
This reverts commit db21267b78
.
The reverting change breaks build in unbundled jb-ub-latinimegoole branch.
Change-Id: Ia61424f5321eb97f981d22c4b08e9ea8d348f6c1
2014-05-23 18:31:43 +00:00
Tadashi G. Takaoka
db21267b78
Use ViewCompat support library and delete ViewCompatUtils
...
Change-Id: Ifee496ff7ecaf361898444ff4127f16748d96422
2014-05-24 02:13:52 +09:00
Tadashi G. Takaoka
7a76350b7b
Merge "Enable "show language switch key" settings on K and before"
2014-05-23 16:43:37 +00:00
Tadashi G. Takaoka
a91561aa58
Use Java 7 diamond operator
...
Change-Id: If16ef50ae73147594615d0f49d6a22621eaf1aef
2014-05-24 01:05:42 +09:00
Tadashi G. Takaoka
7ed40a13cc
Enable "show language switch key" settings on K and before
...
"Show language switch key" and "Switch to other IME" settings are
enabled on KitKat and before. On L and later, its preference settings
UI gets hide and the settings values are forcibly set to true.
Bug: 14854377
Change-Id: I10456408452280a1b7688fd1f168933937666c9f
2014-05-24 00:58:24 +09:00
Keisuke Kuroyanagi
9f9988e996
Merge "Introduce EMPTY_PREV_WORDS_INFO and BEGINNING_OF_SENTENCE."
2014-05-23 14:53:13 +00:00
Ken Wakasa
991c9026b9
Merge "Revert "Fix: too many calls to getSuggestedWordsForTypingInput""
2014-05-23 14:34:36 +00:00
Ken Wakasa
d941ea1826
Revert "Fix: too many calls to getSuggestedWordsForTypingInput"
...
This reverts commit 7aa895e2e3
.
Bug: 15148015
Change-Id: If39c4f8b897f247d4eb935923d55d81def4c8fb4
2014-05-23 14:34:06 +00:00
Keisuke Kuroyanagi
a790c5b683
Introduce EMPTY_PREV_WORDS_INFO and BEGINNING_OF_SENTENCE.
...
Bug: 14119293
Change-Id: I5020e5f0aa64bc3e97b3a3c2c07a60c8b765ed64
2014-05-23 23:19:33 +09:00
Keisuke Kuroyanagi
a37f374ad1
Version up dynamic dict format from 401 to 402.
...
Change-Id: Ibea36af905ade773ae3db3a5456f7b5a0ad7d220
2014-05-23 20:20:56 +09:00
Keisuke Kuroyanagi
1adca93381
Extend jni methods and enable Beginning-of-Sentence.
...
Bug: 14119293
Change-Id: I78fc877367dd0d6240eeacb750b6d2d0b93cba83
2014-05-23 19:58:58 +09:00
Keisuke Kuroyanagi
85befc0873
Merge "Make DistracterFilter interface."
2014-05-23 10:11:57 +00:00
Jean Chalard
cfdb1b8d26
Fix some auto-caps problems:
...
- (mainly for Spanish) auto-caps after inverted bang and what
- (German only) don't auto-cap after digits-period-space
Bug: 15177663
Bug: 12206753
Change-Id: Ia214bc067319469d9debbbfbdcb1dcff980847f0
2014-05-23 18:17:09 +09:00
Keisuke Kuroyanagi
f498e53933
Make DistracterFilter interface.
...
Bug: 13142176
Bug: 15094186
Change-Id: If94b0a155b5ea2ff6b839e7da9d12a9cc6553931
2014-05-23 18:12:37 +09:00
Keisuke Kuroyanagi
1fa3e9044f
Move distracter filter to dictionary facilitator.
...
Bug: 13142176
Bug: 15094186
Change-Id: Ib9e42f8e25538009f3ba62cf1e034cae3f6823c7
2014-05-23 16:10:36 +09:00
Keisuke Kuroyanagi
a1035be6d8
Have DictionaryFacilitator in LatinIME.
...
Bug: 13142176
Bug: 15094186
Change-Id: I9da67352ff2abcd289fa5885389895ced878a413
2014-05-23 09:30:55 +09:00
Keisuke Kuroyanagi
a2ce9a49ac
Fix NPE happening in unit tests.
...
Change-Id: I2fc0dba53e18883755ff77351c152a9d3534c92b
2014-05-22 21:57:07 +09:00
Yohei Yukawa
7c6f57d147
Merge "Add a new production flag for metrics logging"
2014-05-22 08:30:20 +00:00
Yohei Yukawa
17eeecdf49
Add a new production flag for metrics logging
...
BUG:14909963
Change-Id: I2d48c5b7d959d9bb95afe2cd3cbd16b27092a054
2014-05-22 16:57:52 +09:00
Jean Chalard
9b3d55fd1a
Merge "Check the md5 checksum of the copied file."
2014-05-22 07:38:08 +00:00
Keisuke Kuroyanagi
9218c51129
Fix: NPE in DistracterFilter
...
Change-Id: I19a92d79cf547aae8f15e7e5fd5309812ae4f2d5
2014-05-22 16:33:45 +09:00
Jean Chalard
9087d19fc0
Check the md5 checksum of the copied file.
...
If it doesn't match, mark it broken. It means the dictionary pack
will try to install it again next time it updates. We may want to
rethink this.
Bug: 13125743
Change-Id: I0eb547aa7066bed8cb00c009debbafe9181c37ad
2014-05-22 14:19:46 +09:00
Keisuke Kuroyanagi
5e2c4c0297
Merge "Use enabled subtypes for Keyboard in DistracterFilter."
2014-05-22 04:50:47 +00:00
Jean Chalard
68f46d9c2f
Merge "Don't upcase suggestions when resuming on an uppercase word"
2014-05-22 03:57:38 +00:00
Jean Chalard
814cf03470
Merge "Arrange to send the rawChecksum to LatinIME."
2014-05-22 03:18:52 +00:00
Jean Chalard
2df6374ffa
Merge "Fix: too many calls to getSuggestedWordsForTypingInput"
2014-05-22 03:14:01 +00:00
Jean Chalard
7aa895e2e3
Fix: too many calls to getSuggestedWordsForTypingInput
...
Bug: 15148015
Change-Id: Idcb729734bd62b537fb81acf8bdb5cae4470404c
2014-05-22 12:08:12 +09:00
Jean Chalard
dfc38358fc
Don't upcase suggestions when resuming on an uppercase word
...
Bug: 13917781
Change-Id: I7458d120898a7c8c0bc2db2f6db3578fd1dd1681
2014-05-22 11:37:08 +09:00
Jean Chalard
267e528253
Arrange to send the rawChecksum to LatinIME.
...
Bug: 13125743
Change-Id: I5d111336e6a0f5ab4e93ff333654a7a1f8f46480
2014-05-22 11:01:04 +09:00
Keisuke Kuroyanagi
17f326b745
Add beginning of sentence information in PrevWordsInfo.
...
Bug: 14119293
Bug: 14425059
Change-Id: I65320920e840082b0b697bb621676716d0933e0c
2014-05-21 15:40:08 +09:00
Keisuke Kuroyanagi
17ae0eb7e7
Use enabled subtypes for Keyboard in DistracterFilter.
...
Bug: 13142176
Bug: 15094186
Change-Id: I142eeaa11f838080a4fc5a342155e5d470eab3d4
2014-05-21 14:08:39 +09:00
Tadashi G. Takaoka
73788ea154
Merge "Refactor MoreKeysKeyboardView to use Key class"
2014-05-21 03:06:43 +00:00
Tadashi G. Takaoka
5fc1510bc1
Refactor MoreKeysKeyboardView to use Key class
...
This can make MoreSuggestionsView to use extended Key class to hold
a index of a suggested word.
Change-Id: I54d03d2447b04e3caf3e19e7cadcd391cbf58dd5
2014-05-21 11:19:01 +09:00
Keisuke Kuroyanagi
e507d92aa3
Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
...
Bug: 14119293
Bug: 14425059
Bug: 15102610
Change-Id: Ib482390f8d15b37d44a1a54e8c243a9eaec3f815
2014-05-21 11:15:38 +09:00
Ken Wakasa
06dd0ef877
Merge "Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.""
2014-05-20 14:01:34 +00:00
Ken Wakasa
4e21d3711f
Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."
...
This reverts commit ff50b39176
.
Bug: 14119293
Bug: 14425059
Bug: 15102610
Change-Id: If278b4ab236e38d20d8cdc0761b0438911bd4ff9
2014-05-20 14:01:06 +00:00
Keisuke Kuroyanagi
1afaf6770b
Merge "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."
2014-05-20 05:36:10 +00:00
Keisuke Kuroyanagi
ff50b39176
Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
...
Bug: 14119293
Bug: 14425059
Change-Id: I12e9ba977c153b514c6591ab52940712fd0874e3
2014-05-20 13:37:04 +09:00
Tadashi G. Takaoka
9fb2797714
Fix number password field handling
...
Bug: 15088419
Change-Id: Ie88375c8c8203c318d9b410692c527443cb0a2d5
2014-05-20 10:26:26 +09:00
Keisuke Kuroyanagi
83c40a2301
Use PrevWordsInfo instead of String in Java side.
...
Bug: 14119293
Bug: 14425059
Change-Id: I3d5da84881a49a04550180dd9aac2c37da2ed762
2014-05-19 13:55:40 +09:00
Keisuke Kuroyanagi
23246ed18d
Use dedicated DictionaryFacilitator for DistracterFilter
...
Bug: 15002249
Change-Id: Ic77eaa7d627d406daad7dcd15cb4884d9f647312
2014-05-17 01:18:08 +09:00
Keisuke Kuroyanagi
96013c9605
Merge "Revert "Use dedicated DictionaryFacilitator for DistracterFilter""
2014-05-16 11:17:45 +00:00
Keisuke Kuroyanagi
f9377c8920
Revert "Use dedicated DictionaryFacilitator for DistracterFilter"
...
This reverts commit 7122fe76e3
.
Change-Id: I341089864a2b58de6e0f35844a12fb632bd1eabb
2014-05-16 11:16:54 +00:00
Keisuke Kuroyanagi
0dac17f5fb
Merge "Use dedicated DictionaryFacilitator for DistracterFilter"
2014-05-16 10:49:02 +00:00
Keisuke Kuroyanagi
7122fe76e3
Use dedicated DictionaryFacilitator for DistracterFilter
...
Bug: 15002249
Change-Id: I2ebf1941fb0453ea4b97c0e539f8b36e5e0262c1
2014-05-16 18:39:31 +09:00
Keisuke Kuroyanagi
d1f9ce00db
Merge "Make session id mandatory for getSuggestions."
2014-05-16 09:33:28 +00:00
Keisuke Kuroyanagi
09c72207c6
Make session id mandatory for getSuggestions.
...
Bug: 15008504
Change-Id: Ic4a17a4b7242118ae74fd89c695da2bb52204fb2
2014-05-16 17:57:03 +09:00
Keisuke Kuroyanagi
f1b3518d71
Merge "Fix: StringIndexOutOfBoundsException."
2014-05-16 07:47:52 +00:00
Keisuke Kuroyanagi
34873a66f0
Fix: StringIndexOutOfBoundsException.
...
Bug: 14985751
Change-Id: I9df2f737555ab02e24e0fbd231a97c1eec26bc57
2014-05-16 15:32:12 +09:00
Keisuke Kuroyanagi
a545e8dd23
Fix: NPE when context.getFilesDir() returns null.
...
Bug: 14517587
Change-Id: Ib99bea14eab3a25ddb5042527b757133734a6ba6
2014-05-15 20:20:13 +09:00
Tadashi G. Takaoka
2ddaf9543d
Remove unused auto correction led for spacebar feature
...
Change-Id: Ie1544bd0d28684d9b7887fddff37b224ed4f8201
2014-05-15 17:53:43 +09:00
Keisuke Kuroyanagi
e810a266fd
Merge "Quit use bigram probability diff for ver4 dict."
2014-05-15 07:07:25 +00:00
Keisuke Kuroyanagi
64341927d2
Quit use bigram probability diff for ver4 dict.
...
Change-Id: I2cfcfbcf351877d1dff466a24974dbb05908f14e
2014-05-15 16:02:58 +09:00
Yohei Yukawa
f0fc320b4e
Merge "Simplify StatsUtils"
2014-05-15 06:35:42 +00:00
Xiaojun Bi
3686bdfcc1
Fix off-device build
...
This CL fixed the breakage caused by DistracterFilter.
It should be checked in together with I8f53e9481c0f
Bug: 14911612
Bug: 13142176
Change-Id: I33c3526165cea58926d10404552f1fadc385c2e5
2014-05-14 17:39:02 -07:00
Yohei Yukawa
9aa7f66a15
Simplify StatsUtils
...
With this CL, the implementation of StatsUtils no longer
needs to know how to read settings from the system.
Insted, the LatinIME class is now responsible for notifying
StatsUtils whenever the settings is changed.
BUG: 14324207
Change-Id: Ic3d26ec31c8d2c082d3e7487b578b323aad2f960
2014-05-15 00:11:13 +09:00
Keisuke Kuroyanagi
aa7329de15
Merge "Add VERSION4_DEV(402) in Java side and use it for tests."
2014-05-14 13:42:24 +00:00
Keisuke Kuroyanagi
04536f14b0
Add VERSION4_DEV(402) in Java side and use it for tests.
...
Bug: 13406708
Change-Id: I7c9c53bf34d12dced7331a359a83f6444490783a
2014-05-14 22:37:07 +09:00
Keisuke Kuroyanagi
ee59975420
Merge "Fix a NPE in DistracterFilter.isDistracterToWordsInDictionaries()"
2014-05-14 12:20:10 +00:00
Jean Chalard
5ce39dfa78
Fix a bug where changing languages kills the composition.
...
Bug: 14926896
Change-Id: Id2a06c68a51f833db4d8bbc858a232c2696afb6e
2014-05-14 20:34:32 +09:00
Jean Chalard
08476dc107
Merge "Don't send empty composing texts."
2014-05-14 09:50:25 +00:00
Keisuke Kuroyanagi
0a04f8be93
Merge "Output dictionary format version for dump."
2014-05-14 09:07:56 +00:00
Jean Chalard
309ab664a8
Don't send empty composing texts.
...
Bug: 13160467
Change-Id: I5e3204ac8aaa18fe9219cc6b564b832ab6cf94fc
2014-05-14 16:55:32 +09:00
Xiaojun Bi
eb4f8506d6
Fix a NPE in DistracterFilter.isDistracterToWordsInDictionaries()
...
Bug: 14904706
Change-Id: I3b52bb01b9c59cbba2eba0bd1d91dffb4419c019
2014-05-13 21:00:28 -07:00
Keisuke Kuroyanagi
935150795b
Output dictionary format version for dump.
...
Change-Id: I13873727dbb25550a5087c883968a77094d2115d
2014-05-14 11:39:28 +09:00
Tadashi G. Takaoka
08103a0e07
Show voice key even when important notice is showing
...
Bug: 14822080
Change-Id: I2a55bb630cf544b6dc31a5e0e6b932c6af268c71
2014-05-14 09:11:35 +09:00
Xiaojun Bi
25ec32f635
Merge "Implement the distracter filter"
2014-05-13 23:08:40 +00:00
Xiaojun Bi
ac20253806
Implement the distracter filter
...
Bug: 13142176
Change-Id: I85a048cdcbbad3d6020a25f900250d8d7a0fe3da
2014-05-13 15:52:14 -07:00
Tadashi G. Takaoka
06d1cdd5dc
Add content description to the voice key
...
Bug: 14849593
Change-Id: I1664b6a4ef54b78a09df65adbffff7861b54c4a9
2014-05-13 16:33:31 +09:00
Keisuke Kuroyanagi
0f645381ee
Merge "Fix typo wordPreperty -> wordProperty."
2014-05-13 02:58:05 +00:00
Keisuke Kuroyanagi
0befbf8289
Fix typo wordPreperty -> wordProperty.
...
Change-Id: I793f9a42f8dbf48fa15292e74df9edf1cf5d8901
2014-05-13 01:32:27 +09:00
Jean Chalard
61ddac28de
Merge "Add initial reordering rules for Myanmar"
2014-05-12 11:29:53 +00:00
Keisuke Kuroyanagi
490e6846a1
Merge "Add freq=0 words to user history depending on the option."
2014-05-12 11:15:52 +00:00
Keisuke Kuroyanagi
84070cbc74
Merge "Improve multi-word suggestion handling for user history."
2014-05-12 11:11:15 +00:00
Keisuke Kuroyanagi
87343166e5
Add freq=0 words to user history depending on the option.
...
Bug: 14686585
Change-Id: Ia1c3adb1bcc625788016e378e1ac7b0792ea9f4e
2014-05-12 19:48:58 +09:00
Jean Chalard
281dbc3973
Add initial reordering rules for Myanmar
...
Bug: 13945569
Change-Id: Ib546ba110e87bf72afa7f42c878cc5f638bff6c7
2014-05-12 19:17:47 +09:00
Keisuke Kuroyanagi
ddacfdeb09
Improve multi-word suggestion handling for user history.
...
Bug: 12902664
Change-Id: I03deed16047f0beaba8932d87c6129ec8061ba9c
2014-05-12 18:04:43 +09:00
Jean Chalard
be99616afa
Create the path for specifying combining rules in the subtype
...
Also add the skeleton of the combining rules for Myanmar
reordering as a pilot.
Bug: 13945569
Change-Id: Iabeb6838f45f1efff482143595ce5b48543e0c43
2014-05-12 15:58:51 +09:00
Tadashi G. Takaoka
c41d261b7e
Add voice key to suggestions strip
...
Bug: 14419121
Change-Id: I3b2bdc3c07bb7e49ea7be53649bd6dd134fea27c
2014-05-12 15:08:14 +09:00
Keisuke Kuroyanagi
4eb220269b
Remove ContextualDictionary.haveContentsChanged().
...
Change-Id: I7023ba4d9515dcad90e0a226f70936550c5241f4
2014-05-12 13:50:08 +09:00
Keisuke Kuroyanagi
47c76f0a45
Merge "Add contextual dictionary to the dictionary facilitator."
2014-05-12 04:42:33 +00:00
Jean Chalard
2b95bc9b64
Cleanup : remove a useless member
...
Change-Id: I7871c3243c82b5a19acf266033187795a2ea1767
2014-05-12 11:52:45 +09:00
Tadashi G. Takaoka
59c3ef1ff8
Refactor KeyboardTheme
...
This CL introduces two preference keys in addition to the existing one.
- pref_keyboard_theme: The new preference key that is used only in the
preference settings.
- pref_keyboard_layout_20110916: The previous preference key that
holds keyboard color scheme settings. This is superseded by the next
key.
- pref_keyboard_theme_20140509: The new preference key that holds
keyboard theme settings. This value is forcibly reset to LMP theme
on a LMP device. On a KitKat and previous device, the settings of
the pref_keyboard_layout_20110916 is carried on into this
preference.
This CL must be checked in together with Id7b3ddd8aa.
Change-Id: I2d55602d026e30b38d8f822d2124f5c5e4a9a812
2014-05-12 10:59:10 +09:00
Ken Wakasa
4f5ea4dfc2
Merge "Revert "Refactor KeyboardTheme""
2014-05-09 11:28:51 +00:00
Ken Wakasa
d47dca429e
Revert "Refactor KeyboardTheme"
...
This reverts commit 19688b584b
.
Build breakage.
Change-Id: I95d4be1578824eaee5a2fb08ec277250727ac668
2014-05-09 11:28:19 +00:00
Tadashi G. Takaoka
c2a49f3006
Merge "Refactor KeyboardTheme"
2014-05-09 08:26:05 +00:00
Tadashi G. Takaoka
19688b584b
Refactor KeyboardTheme
...
This CL introduces two preference keys in addition to the existing one.
- pref_keyboard_theme: The new preference key that is used only in the
preference settings.
- pref_keyboard_layout_20110916: The previous preference key that
holds keyboard color scheme settings. This is superseded by the next
key.
- pref_keyboard_theme_20140509: The new preference key that holds
keyboard theme settings. This value is forcibly reset to LMP theme
on a LMP device. On a KitKat and previous device, the settings of
the pref_keyboard_layout_20110916 is carried on into this
preference.
This CL must be checked in together with Ifcedeabbec.
Change-Id: Ibe75146e2c1c7eebf964ca86550baf244fedb79a
2014-05-09 16:21:02 +09:00
Keisuke Kuroyanagi
eaa347bc1a
Merge "Add VERSION4_TEST for testing."
2014-05-09 07:06:06 +00:00
Keisuke Kuroyanagi
455dc84cf2
Add VERSION4_TEST for testing.
...
Bug: 13406708
Change-Id: I0b434717ea3edbb131650af634c53cfbfe113c3e
2014-05-09 15:17:01 +09:00
Keisuke Kuroyanagi
82fa755bac
Fix unit tests by adding @UsedForTesting
...
Change-Id: I9448b1bfa7bf94039de737725851e63a2921a443
2014-05-09 14:44:44 +09:00
Keisuke Kuroyanagi
28ebe2db23
Merge "Check whether contacts have changed using hashCode()."
2014-05-09 03:48:19 +00:00
Keisuke Kuroyanagi
943e28d202
Merge "Periodic GC for personalization dict."
2014-05-09 03:41:43 +00:00
Keisuke Kuroyanagi
89eaa6701f
Periodic GC for personalization dict.
...
Change-Id: I1ef922684cbf1de10c45c66eb119c2343d194da3
2014-05-08 17:20:43 +09:00
Keisuke Kuroyanagi
08d12a1be3
Merge "Extend jni interface for dictionary migration."
2014-05-08 05:20:33 +00:00
Keisuke Kuroyanagi
1471fbad66
Extend jni interface for dictionary migration.
...
Bug: 13406708
Change-Id: Iadad6df296467d0e5b631fba4a409d53c8a5a6f2
2014-05-08 12:31:04 +09:00
Keisuke Kuroyanagi
9898ee6267
Check whether contacts have changed using hashCode().
...
Bug: 13755213
Change-Id: Ie2f7b7f9dc8bd3fce395618877d9f234287dcb21
2014-05-08 12:25:32 +09:00
Tadashi G. Takaoka
e3e331aebb
Merge "Use margin instead of padding in SuggestionStripView"
2014-05-08 01:14:59 +00:00
Xiaojun Bi
50b5295d5d
Merge "Use DistracterFilter when getting Language Model Param of a word"
2014-05-08 01:10:33 +00:00
Xiaojun Bi
17284659ce
Use DistracterFilter when getting Language Model Param of a word
...
A preparation for implementing Distracter Filter.
This CL should be checked in together with Icfefa0463180
Bug: 13142176
Change-Id: If9e5ca840c4a81cb0339ab70f146b42fbfa7af5d
2014-05-07 10:10:18 -07:00
Tadashi G. Takaoka
2b479cccae
Use margin instead of padding in SuggestionStripView
...
This CL also tunes the width of suggestions strip to be able to
display 15~16 letters without x-scaling at the center slot.
Bug: 14419121
Change-Id: Ia5766cee043899533e24e2ebc621e8dc279370b3
2014-05-07 19:12:28 +09:00
Keisuke Kuroyanagi
7d52f9b81c
Fix: mIsUserDictEnabled is never updated.
...
Bug: 14602321
Change-Id: Ib98d5648ea2a901393b79c7f300bc6d209ee98d1
2014-05-07 16:45:37 +09:00
Keisuke Kuroyanagi
8a7f670ec3
Merge "Remove Dictionaries.mDictMap."
2014-05-01 11:17:28 +00:00
Keisuke Kuroyanagi
c005c1dc56
Merge "Use dictType to class map to create sub dicts."
2014-05-01 10:16:58 +00:00
Keisuke Kuroyanagi
61fe28831d
Merge "Create factory methods for sub dicts."
2014-05-01 10:07:24 +00:00
Keisuke Kuroyanagi
fb87c250cb
Add contextual dictionary to the dictionary facilitator.
...
Bug: 14161647
Change-Id: I0e706b2abd0cb9f351e28681e275cd7f2fdbfd9c
2014-05-01 18:45:01 +09:00
Keisuke Kuroyanagi
d46855da72
Remove Dictionaries.mDictMap.
...
Bug: 13755213
Change-Id: I9ded695c31d3db05f561956c61d56ebd16d34703
2014-05-01 18:45:01 +09:00
Keisuke Kuroyanagi
99f2664871
Use dictType to class map to create sub dicts.
...
Bug: 13755213
Change-Id: I4dcd5684bc65f13361bf9c4f9d50b07b1e33c62d
2014-05-01 18:44:57 +09:00
Keisuke Kuroyanagi
c3b151957c
Move dict version check to proper place.
...
Change-Id: I89a5b4fa93153081b4f7a9183619cbe7c9ea01fa
2014-05-01 17:28:24 +09:00
Keisuke Kuroyanagi
98e358a936
Create factory methods for sub dicts.
...
Bug: 13755213
Change-Id: I046af54b4860d2839328f2089ea785d81d04cf43
2014-05-01 17:22:23 +09:00
Keisuke Kuroyanagi
765cbb81ba
Merge "Simplify DictionaryFacilitatorForSuggest."
2014-05-01 07:55:31 +00:00
Jean Chalard
bedef0b4f0
Merge "Introduce clustering punctuation"
2014-05-01 07:01:04 +00:00
Keisuke Kuroyanagi
1ab6bfdc60
Simplify DictionaryFacilitatorForSuggest.
...
Bug: 13755213
Change-Id: I9663d1d60fccd8deb1a22683fb06fe64dee06b45
2014-05-01 15:51:03 +09:00
Jean Chalard
29c00ff538
Introduce clustering punctuation
...
Bug: 10081730
Change-Id: If198fa3df68ecb267da0a278da41fd509d6165f1
2014-05-01 15:45:24 +09:00
Tadashi G. Takaoka
3903e0d6e8
Merge "Make AccessibleKeyboardViewProxy not singleton"
2014-05-01 03:29:30 +00:00
Tadashi G. Takaoka
bca7e4e9a2
Make AccessibleKeyboardViewProxy not singleton
...
This CL also renames AccessibleKeyboardViewProxy and
AccessibilityEntityProvider to MainKeyboardAccessibilityDelegate and
MainKeyboardAccessibilityNodeProvider.
Change-Id: I2b0ec091a11aa8a495794d633efecb6d8b818f42
2014-05-01 12:24:54 +09:00
Jean Chalard
ec29147375
Merge "Some cleanup and reinforcement"
2014-05-01 03:04:29 +00:00
Jean Chalard
49d7871290
Some cleanup and reinforcement
...
Bug: 9520584
Change-Id: I1c0f9e1b530d4d5bf5f52c2905c20f5ab7c26442
2014-05-01 12:00:20 +09:00
Keisuke Kuroyanagi
a9f0a96377
Merge "Handle user dict as an ExpandableBinaryDictionary."
2014-04-30 12:44:25 +00:00
Keisuke Kuroyanagi
9ed7e47539
Handle user dict as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I2d242a3332e9633d4e41e08c0bbfafcefd814ecd
2014-04-30 20:35:08 +09:00
Tadashi G. Takaoka
412ac4c573
Merge "TalkBack correct shift state"
2014-04-30 09:51:07 +00:00
Tadashi G. Takaoka
24536580bf
TalkBack correct shift state
...
Change-Id: I3097805c6c8b4a4ac19fbe062f763e2639eb5cbf
2014-04-30 18:46:46 +09:00
Yohei Yukawa
1690992d1b
Check OS codename for shouldOfferSwitchingToNextInputMethod
...
Make sure if Build.VERSION.CODENAME is "REL" or not when
Build.VERSION.SDK_INT is 19 (KitKat). This is a tentative
workaround until Build.VERSION.SDK_INT is bumped to 20 or
greater.
BUG: 12965588
Change-Id: I0f6a8ef92af221240d247997ce65bd5e351b2d5e
2014-04-30 17:08:04 +09:00
Keisuke Kuroyanagi
c0d754397e
Fix unit tests by adding @UsedFortesting.
...
Change-Id: I8f66632a32b9e9ddc1b771e8ee74492c7baf9338
2014-04-29 00:00:57 +09:00
Keisuke Kuroyanagi
4426cbc59e
Fix: contacts/user dicts are too frequently regenerated.
...
Change-Id: I6b04a58c543fda6df7a2c016b8b8a5300f137d73
2014-04-28 23:11:25 +09:00
Keisuke Kuroyanagi
f614de62aa
Merge "Cleanup ExpandableBinaryDictionary."
2014-04-28 12:08:01 +00:00
Keisuke Kuroyanagi
b451f270f3
Cleanup ExpandableBinaryDictionary.
...
Bug: 8187060
Change-Id: I9103462412e727b0160b218b1bb301ce43621c46
2014-04-28 21:02:00 +09:00
Keisuke Kuroyanagi
c207955d4f
Merge "Use ReentrantReadWriteLock in ExpandableBinaryDictionary."
2014-04-28 12:01:14 +00:00
Keisuke Kuroyanagi
1737b7ff5c
Use ReentrantReadWriteLock in ExpandableBinaryDictionary.
...
Bug: 8187060
Change-Id: Ic665f0a5e940708aa9addedac068a64900b307e7
2014-04-28 20:56:01 +09:00
Keisuke Kuroyanagi
2367f8f602
Merge "Simplify asyncFlushBinaryDictionary."
2014-04-28 08:44:52 +00:00
Keisuke Kuroyanagi
570602a088
Simplify asyncFlushBinaryDictionary.
...
We no longer write files when the dict has not been updated.
Bug: 8187060
Change-Id: I8aa23a93d5deafb3a7f16f5466a5e0e84fbbf095
2014-04-28 17:30:36 +09:00
Keisuke Kuroyanagi
5c1416e426
Merge "Remove DictionaryUpdateController."
2014-04-28 08:29:02 +00:00
Keisuke Kuroyanagi
dff7153820
Merge "Use different user dict name for spell checker."
2014-04-28 08:12:17 +00:00
Keisuke Kuroyanagi
a5202c7143
Merge "Use different contacts dict name for spell checker."
2014-04-28 07:58:41 +00:00
Keisuke Kuroyanagi
07c5b307d6
Remove DictionaryUpdateController.
...
Bug: 8187060
Change-Id: I3e1fa4060d8a5c12d8d609be3357d56051fb5815
2014-04-28 16:58:27 +09:00
Keisuke Kuroyanagi
c5de887fd2
Merge "Move dicts for spellchecker to under spellcheck."
2014-04-28 07:51:29 +00:00
Keisuke Kuroyanagi
6256ec0587
Merge "Fix: Typed word is not included in more suggestions."
2014-04-28 07:46:21 +00:00
Keisuke Kuroyanagi
817cd9a0d5
Use different user dict name for spell checker.
...
Bug: 13630847
Change-Id: Icabd08c674dcf086250b9e594328a43286d1d203
2014-04-28 16:31:20 +09:00
Keisuke Kuroyanagi
60763a06e8
Use different contacts dict name for spell checker.
...
Bug: 13630847
Change-Id: I016a464890d5e63794fb1288b4ce7b09adffc453
2014-04-28 16:25:10 +09:00
Keisuke Kuroyanagi
24ec8bd91b
Move dicts for spellchecker to under spellcheck.
...
Bug: 13630847
Change-Id: Iadcf5b31f66fb73efc5c640e96e8c2106a0224dd
2014-04-28 16:24:35 +09:00
Keisuke Kuroyanagi
a8c4731eab
Fix: Typed word is not included in more suggestions.
...
Happened when top suggestion is long and auto-corrected.
Bug: 13738879
Change-Id: I47c2dfb34cfc92b54cfe54c432ee2f646fe454e5
2014-04-28 16:21:27 +09:00
Yohei Yukawa
91db602b83
Merge "Use shouldOfferSwitchingToNextInputMethod when available"
2014-04-28 06:58:02 +00:00
Yohei Yukawa
8ba4f33709
Use shouldOfferSwitchingToNextInputMethod when available
...
With this CL, LatinIME starts using
InputMethodManager#shouldOfferSwitchingToNextInputMethod when
available and API level is higher than 19 (KitKat).
Note that relevant settings of LatinIME will be ignored if
InputMethodManager#shouldOfferSwitchingToNextInputMethod is
considered to be available at the moment. We will revisit
here to reorganize the user visible settings before the
new global IME switching mechanism becomes publicly
available.
BUG: 12965588
Change-Id: I0188fa56cba8e983c61cef3ae3400a0e3821f718
2014-04-28 15:11:19 +09:00
Tadashi G. Takaoka
0b42851eed
Merge "Move some advanced settings to debug settings"
2014-04-28 05:30:28 +00:00
Keisuke Kuroyanagi
169acbf9f0
Add null check in createDistracterFilter().
...
Change-Id: Iff2b73081d48f32b1d3a5d5b32c9734979362c23
2014-04-25 13:36:46 -07:00
Tadashi G. Takaoka
a3920c7e6a
Move some advanced settings to debug settings
...
This CL moves "Show slide indicator" and "Key long press delay"
advanced options to the debug settings.
Bug: 11866784
Change-Id: Iec16e09ba6e7c9f82ce0fa73a0d75766b843b44b
2014-04-25 12:03:47 -07:00
Xiaojun Bi
516c884b11
Merge "Prepare to implement distracter filter"
2014-04-25 17:15:53 +00:00
Xiaojun Bi
281dd99346
Prepare to implement distracter filter
...
It was implemented according to the Plan B in the
design doc:
http://go/ime-misspelling-filter
This CL is to create a DistracterFilter instance
and pass it to PersonalizationDictionarySessionRegistrar.
This patch should be checked in together with
Id633b4fd45693
Bug: 13142176
Change-Id: Ia4957e64218c9619fcf9bb91795a187617c72a2e
2014-04-25 09:13:22 -07:00
Keisuke Kuroyanagi
e581d8f8ab
Merge "Fix: contains() is wrongly used in hasDict()."
2014-04-25 07:58:19 +00:00
Keisuke Kuroyanagi
bdf31fb75e
Fix: contains() is wrongly used in hasDict().
...
Change-Id: I4699b1b75fed9dd479f5135f0a7a2dd098e6f798
2014-04-25 00:56:27 -07:00
Keisuke Kuroyanagi
1ed248dc2f
Merge "Fix: Wrong null check for user history dict."
2014-04-25 06:48:16 +00:00
Keisuke Kuroyanagi
93f4aec07c
Fix: Wrong null check for user history dict.
...
Change-Id: Idf0bcc44247e35cd95f9482d2a8017329fc977bb
2014-04-24 23:08:48 -07:00
Keisuke Kuroyanagi
a9861ac814
Merge "Handle personalization dictionary as an ExpandableBinaryDictionary."
2014-04-25 04:56:14 +00:00
Keisuke Kuroyanagi
194d64fa58
Merge "Handle contacts dictionary as an ExpandableBinaryDictionary."
2014-04-25 04:54:09 +00:00
Keisuke Kuroyanagi
56e4848ead
Handle personalization dictionary as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I26e070e89e09b37e9dcc200d597c74c591467a66
2014-04-24 21:37:49 -07:00
Keisuke Kuroyanagi
98e276a0ec
Merge "Quit creating empty dictionary file in ExpandableBinaryDictionary."
2014-04-25 04:36:55 +00:00
Keisuke Kuroyanagi
62c110a4c0
Handle contacts dictionary as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I0eb5055f9cdf5e1df337cdace9bf0919d4d365d3
2014-04-24 21:36:30 -07:00
Keisuke Kuroyanagi
3d2a9af20a
Merge "Handle user history dictionary as an ExpandableBinaryDictionary."
2014-04-25 04:30:39 +00:00
Keisuke Kuroyanagi
a933776bf1
Merge "Simplify DictionaryFacilitatorForSuggest to be flexible."
2014-04-25 04:29:50 +00:00
Keisuke Kuroyanagi
67c0ed8f8c
Handle user history dictionary as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I1ea8a6df007af7153852f2d32bf5e8ec669c432b
2014-04-24 14:48:01 -07:00
Keisuke Kuroyanagi
3d658a63ca
Merge "Remove clearAndFlushDictionary() and use clear()."
2014-04-24 18:29:05 +00:00
Keisuke Kuroyanagi
978958a41f
Simplify DictionaryFacilitatorForSuggest to be flexible.
...
Bug: 13755213
Change-Id: I151269a7038b72a33b436da4c7596e09949e6d00
2014-04-24 11:25:50 -07:00
Keisuke Kuroyanagi
2dcb5c1b4d
Remove clearAndFlushDictionary() and use clear().
...
clearAndFlushDictionary() was needed when dictionaries are constructed
in java side. All expandable dictionaries now use native code; thus,
this method is same to clear() and no longer needed.
Bug: 13755213
Change-Id: Ifd836e64f8ff807930f7cd2319b103b65e8fce70
2014-04-24 11:25:47 -07:00
Tadashi G. Takaoka
393da03c8e
Fix handling shift + enter
...
Bug: 14278758
Change-Id: Id77c99b83cc69855972b27c9cebd482c8cbd3539
2014-04-23 19:22:00 -07:00
Keisuke Kuroyanagi
7de3d0eed7
Merge "Fix: Reporting wrong main dictionary availability."
2014-04-22 23:32:50 +00:00
Keisuke Kuroyanagi
de4d401038
Fix: Reporting wrong main dictionary availability.
...
Bug: 13965806
Change-Id: Ida2234ab8cb7785ec5efd433a58949bf21c44351
2014-04-22 16:24:22 -07:00
Keisuke Kuroyanagi
d437df0ab0
Quit creating empty dictionary file in ExpandableBinaryDictionary.
...
Bug: 14166482
Change-Id: I7b7a25141851d7bb14744567639d8e5d8f04a036
2014-04-22 13:18:36 -07:00
Keisuke Kuroyanagi
3b7984752c
Support creating BinaryDictionary without creating dict file.
...
Bug: 14166482
Change-Id: Ic8c78ec2c8f39358a1f085a041b608972a380eef
2014-04-22 13:18:34 -07:00
Keisuke Kuroyanagi
ce76821dce
Revert "Support creating BinaryDictionary without creating dict file."
...
This reverts commit 89939b8708
.
Change-Id: I8ca1b55609ad305a93178063bd88bd1cede872af
2014-04-22 19:34:44 +00:00
Keisuke Kuroyanagi
89939b8708
Support creating BinaryDictionary without creating dict file.
...
Bug: 14166482
Change-Id: Ib065279f96e227ab0fee7c8141560c4ada744d3b
2014-04-22 12:01:33 -07:00
Keisuke Kuroyanagi
68b4f2ada9
Merge "Add jni interface to use on memory dictionary."
2014-04-22 17:07:16 +00:00
Tadashi G. Takaoka
543d3d24bd
Stop using Configuration.setLocale
...
The call for method Configuration.setLocale that is introduce by
If60877b29b should be remove to be compatible with API 14 and later.
Bug: 14239862
Change-Id: I3815c2b56bd9c655b8bde6f93143adf3ff08c35d
2014-04-22 09:22:46 -07:00
Keisuke Kuroyanagi
61cb852d33
Add jni interface to use on memory dictionary.
...
Bug; 14166482
Change-Id: I33ab08dad1e39aa7617d391f7eb2561d6f2504bb
2014-04-21 19:59:09 -07:00
Keisuke Kuroyanagi
3acbf7d00c
Merge "Add BinaryDictionary.flushWithGCIfHasUpdated()."
2014-04-22 00:10:42 +00:00
Keisuke Kuroyanagi
c6704dbe51
Add BinaryDictionary.flushWithGCIfHasUpdated().
...
Bug: 14166482
Bug: 14161647
Change-Id: I98b0a8b86897b1486491a3aea91729bc9e4cc03c
2014-04-21 15:21:55 -07:00
Xiaojun Bi
11b7076168
Fix a bug for counting code points in WordComposer.java
...
This bug threw an ArrayIndexOutOfBoundsException when the word length
is 49 (maxSize + 1) when calling StringUtils.copyCodePointsAndReturnCodePointCount(...)
in the same function. This bug is discovered by running SKETCH.
The intent is to count the code points from index 0 to index i (included).
The original code only counted the code points from index 0 to index (i-1).
Bug: 13969542
Change-Id: Idbf596aba2379ba552dbe580c83c42044d505aaf
2014-04-18 14:56:35 -07:00
Tadashi G. Takaoka
a980fb39a5
Merge "Refactor RunInLocale a bit"
2014-04-17 08:59:25 +00:00
Tadashi G. Takaoka
5c490e5da5
Refactor RunInLocale a bit
...
Change-Id: If60877b29bb1263161ec85c99320ad07b7dd4245
2014-04-17 17:39:19 +09:00
Jean Chalard
20b0c3c5a9
Merge "Avoid lower-case version of capitalized words in user hist"
2014-04-17 08:22:42 +00:00
Jean Chalard
649dcba5a8
Avoid lower-case version of capitalized words in user hist
...
Bug: 14096825
Change-Id: Ib6cc8fc31e90862e0b05f5a06757a73069726b74
2014-04-17 16:41:26 +09:00
Jean Chalard
86ff9d6dda
Merge "Fix a wrong parameter passed."
2014-04-17 07:39:52 +00:00
Jean Chalard
26611120c9
Fix a wrong parameter passed.
...
Bug: 14120001
Change-Id: I8258304bc500fe28870fb8a5c11c15d97795423c
2014-04-17 15:44:55 +09:00
Keisuke Kuroyanagi
b21edc4402
Shuwdown executors after executing all tasks.
...
Bug: 14113276
Change-Id: Ie42ef30ffe5767ca434db4669efad2027b474e74
2014-04-17 09:28:52 +09:00
Jean Chalard
ba635ad30d
Merge "Restart suggestions when restarting input"
2014-04-16 10:43:28 +00:00
Tadashi G. Takaoka
166fd799d4
Merge "Dismiss more suggestions before showing important notice"
2014-04-16 09:43:39 +00:00
Jean Chalard
3aba6263f0
Restart suggestions when restarting input
...
Bug: 6851364
Change-Id: I3052924053f37f56c9c3953051aa1b22224a2b2e
2014-04-16 17:02:08 +09:00
Tadashi G. Takaoka
c8abd13c77
Dismiss more suggestions before showing important notice
...
Bug: 14078601
Change-Id: I029cadd8f2f170b5a3e70df170e306c9be109a70
2014-04-16 15:40:39 +09:00
Jean Chalard
66e509b1d4
Fix some failing tests
...
Bug: 13968927
Change-Id: I7e5e075535e38bf0fa24af98ed6e2cdfd6de6556
2014-04-15 21:44:46 +09:00
Jean Chalard
1ee443d848
Merge "[IL135] Make getCurrentAutoCapsState private"
2014-04-15 02:27:52 +00:00
Jean Chalard
82d3a56b09
Merge "[IL134] Add an alternative path to getCurrentAutoCapsState"
2014-04-15 02:24:41 +00:00
Jean Chalard
751dc070bf
Merge "Fix updating the shift state upon backspace"
2014-04-14 12:31:22 +00:00
Jean Chalard
2282e8520a
Fix updating the shift state upon backspace
...
Bug: 13514349
Change-Id: If4c9db12b0ab5be676f7a2f72715f469066ee537
2014-04-14 21:28:24 +09:00
Jean Chalard
f091c491ea
[IL135] Make getCurrentAutoCapsState private
...
Bug: 8636060
Change-Id: I800aefe6fee4c14df6fe5abe21b2387c69abb8f5
2014-04-14 21:09:32 +09:00
Jean Chalard
ddc163988a
[IL134] Add an alternative path to getCurrentAutoCapsState
...
Bug: 8636060
Change-Id: I959e13d34910adad028ed6174f92029ff690eeeb
2014-04-14 21:09:32 +09:00
Tadashi G. Takaoka
21eafd7910
Use KeyboardTheme id insteand of index
...
This CL must be checked in together with I771216f8bd.
Bug: 14042743
Change-Id: I45c3acf9242985fb03721a9a6d377fbccc8e2019
2014-04-14 18:59:54 +09:00
Tadashi G. Takaoka
3568fca95f
Merge "Refactor KeyboardTheme as top-level class"
2014-04-14 09:57:36 +00:00
Tadashi G. Takaoka
d6aa94e6b5
Refactor KeyboardTheme as top-level class
...
This CL should be checked in together with I63e33388f9.
Bug: 14042743
Change-Id: I13f0a45bac6f19e006bf1280a36173e52d6d7160
2014-04-14 17:10:11 +09:00
Tadashi G. Takaoka
30d5ed67d6
Keep ImportantNoticeDialog showing after orientation changed
...
Bug: 13951402
Change-Id: Ia6340d48843abca68ebadd299827cbe43516cc39
2014-04-14 15:48:19 +09:00
Yohei Yukawa
da498229f4
Merge "Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR"
2014-04-13 12:56:43 +00:00
Jean Chalard
4f4770cbf0
Merge "[CB26] Remove useless variables."
2014-04-11 10:00:57 +00:00
Yohei Yukawa
fab4ce43f8
Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR
...
With this CL, LatinIME starts calling
InputMethodService#setCursorAnchorMonitorMode in #onStartInput()
when ProductionFlag.USES_CURSOR_ANCHOR_MONITOR flag is explicitly
set to true.
BUG: 13891796
Change-Id: Ib2fb0c3521b61859d4cc530155ccaaee7ee16cbc
2014-04-11 12:26:33 +09:00
Jean Chalard
cb05dc1d1b
Merge "[IL133] Avoid calling a dangerous method from outside."
2014-04-10 09:15:13 +00:00
Jean Chalard
1ef9d5938e
[CB26] Remove useless variables.
...
This is nice for code simplicity, but it has a small adverse impact on
performance.
Bug: 13406701
Change-Id: I9316b3fe8d79b940fbd83cf1187c8c0d10b26c71
2014-04-10 18:13:35 +09:00
Tadashi G. Takaoka
cc729b6df5
Merge "Refactor SubtypeLocaleUtils a bit"
2014-04-10 08:51:03 +00:00
Jean Chalard
4370ff0998
Fix some flaky tests.
...
In tests, we create many instances of LatinIME, but we never
destroy them. That means we never close the dictionaries nor
the handlers.
This change calls onDestroy, which closes all dictionaries, and
adds some code to finish the handlers.
Change-Id: I942517a2a940c54256b08763f6b38f5b55809f55
2014-04-10 17:32:05 +09:00
Tadashi G. Takaoka
58e830ec19
Refactor SubtypeLocaleUtils a bit
...
Change-Id: If8b7fd5ef0b4ff3791deeacc12abb256a10176bf
2014-04-10 17:24:58 +09:00
Yohei Yukawa
a4ac18551f
Merge "Add a new production flag for Cursor/Anchor monitor"
2014-04-09 12:36:28 +00:00
Yohei Yukawa
485114905e
Add a new production flag for Cursor/Anchor monitor
...
BUG: 13891796
Change-Id: I3565ca22aaf1d3cfce4f35999e2990b2df5157ef
2014-04-09 21:13:34 +09:00
Jean Chalard
5f430e0189
[CB25] Refactor some array copying
...
Bug: 13406701
Change-Id: I09edd822f5cc2446b324d41c76d835bcff1191e6
2014-04-09 18:38:29 +09:00
Jean Chalard
45e34b4374
[CB24] Remove a useless test
...
If 1 character, then for sure !isGesture
Bug: 13406701
Change-Id: If8e9b080372eb8ddb15b8f97cce1399dc0c7f099
2014-04-08 21:36:52 +09:00
Yohei Yukawa
36dfb6d1a4
Fix build breakage caused by I0218dd07
...
BUG: 11746191
Change-Id: I0b693c4b22793f6e8fd77a9f045f205aa8fe4050
2014-04-08 20:00:16 +09:00
Yohei Yukawa
c9539f42f6
Merge "Add StatsUtils for checking state"
2014-04-08 10:23:41 +00:00
Yohei Yukawa
dc0f7ca167
Add StatsUtils for checking state
...
BUG: 11746191
Change-Id: I0218dd07dde1d09321009ea1497258fc4235a1e8
2014-04-08 19:09:49 +09:00
Jean Chalard
d52bec0069
[CB23] Merge add and deleteLast
...
Bug: 13406701
Change-Id: Id9a2e4144b1908ad27d78228ee19e6fc4d4d669f
2014-04-07 15:51:44 +09:00
Jean Chalard
633e4f4533
[CB22] Merge add and delete
...
...but this time, it works.
Bug: 13406701
Change-Id: Iaa00339a6be76413ffaeb74ff1556e15b3bb039d
2014-04-07 15:47:01 +09:00
Ken Wakasa
e2e41dc22c
Merge "Revert "[CB22] Merge add and delete""
2014-04-04 18:26:06 +00:00
Ken Wakasa
ef0498a8cc
Revert "[CB22] Merge add and delete"
...
This reverts commit f6bce235ae
.
Seeing several new unit test failures after this CL. Reverting..
Change-Id: Ie97127550ee36dd4a07a36701e9c5118684dfbc5
2014-04-04 18:25:34 +00:00
Jean Chalard
f9516b00ec
Merge "[IL132] Remove some calls that let a value escape."
2014-04-04 13:33:26 +00:00
Jean Chalard
76c930eede
Merge "[CB22] Merge add and delete"
2014-04-04 10:10:55 +00:00
Tadashi G. Takaoka
9b46ddc1d5
Use platform default theme for activities and dialogs
...
Bug: 13698528
Change-Id: Ib904c911452525e3749c0eb287434b504576db5f
2014-04-04 17:13:54 +09:00
Jean Chalard
f977ca6c92
Merge "[CB21] More refactoring"
2014-04-04 06:56:49 +00:00
Jean Chalard
4ac0904f83
Merge "[CB20] Some more refactoring"
2014-04-04 05:03:45 +00:00
Jean Chalard
28a59dd049
Fix a bug with double-space-to-period
...
Bug: 13778001
Change-Id: I3ebd57950cdfacbbcdc64ed214c0590519a0665c
2014-04-03 22:07:57 +09:00
Jean Chalard
c5bd35e45f
Merge "[IL131] Cleanup some cruft"
2014-04-03 09:52:10 +00:00
Keisuke Kuroyanagi
fdd2db576d
Always close binary dicts for personalized dicts.
...
Bug: 10923130
Bug: 13664080
Change-Id: Ib247c775194a03462387994cd832b1650bfd1915
2014-04-03 18:08:23 +09:00
Jean Chalard
8ab4ae4377
[IL133] Avoid calling a dangerous method from outside.
...
We want to remove all calls to this as it lets internal values
escape, but there is some refactoring to do to finish this.
Bug: 8636060
Change-Id: Iedba6afe4719bc0add868714a1ee5a04b7ead33e
2014-04-03 15:36:15 +09:00
Jean Chalard
9320553ab9
[IL132] Remove some calls that let a value escape.
...
Bug: 8636060
Change-Id: I696514934586ee71e734fd974026af8b2c866127
2014-04-03 15:36:15 +09:00
Jean Chalard
7ebd7ca9a4
[IL131] Cleanup some cruft
...
Bug: 8636060
Change-Id: I169618b50532df68e973e14b3f114c6c19714c84
2014-04-03 15:36:12 +09:00
Keisuke Kuroyanagi
35314af0d8
Merge "Extend jni interface to input/output languageWeight."
2014-04-02 16:20:28 +00:00
Keisuke Kuroyanagi
1de95ceada
Extend jni interface to input/output languageWeight.
...
Bug: 8187060
Change-Id: Ic55d328b87f258f4d65fff207233789a53b2b0ff
2014-04-03 01:01:51 +09:00
Keisuke Kuroyanagi
6b64de5063
Merge "Add languageWeight as an argument of getSuggestions."
2014-04-02 15:54:55 +00:00
Keisuke Kuroyanagi
18f21f96e0
Add languageWeight as an argument of getSuggestions.
...
Bug: 8187060
Change-Id: I8ae20c957a8e127b76c83cc3a65ff052d43bf2b5
2014-04-03 00:47:28 +09:00
Keisuke Kuroyanagi
a327d4a475
Merge "Use fixed order of dictionaries to get suggestions."
2014-04-02 13:24:52 +00:00
Keisuke Kuroyanagi
5b00d74c2e
Use fixed order of dictionaries to get suggestions.
...
Bug: 8187060
Change-Id: Id287776e3a82c0a6b208d677b8f2891266c5fc8d
2014-04-02 22:17:18 +09:00
Jean Chalard
06b50ed5f2
Merge "[IL130] Remove a useless local"
2014-04-02 09:18:45 +00:00
Jean Chalard
a49d326426
Merge "[IL129] Change some confusing method names."
2014-04-02 09:18:15 +00:00
Jean Chalard
4323e1126c
Merge "[CB19] Some refactoring"
2014-04-02 09:17:43 +00:00
Jean Chalard
750a3557a0
Merge "[CB18] Move some code around"
2014-04-02 09:17:30 +00:00
Jean Chalard
cc5a71caf1
Merge "[CB17] Remove a member."
2014-04-02 09:17:14 +00:00
Jean Chalard
26650377cf
[IL130] Remove a useless local
...
Bug: 8636060
Change-Id: I36ba3e00630bef644fc4671d0714490b5982f6a1
2014-04-02 18:10:21 +09:00
Jean Chalard
a777c1c460
[IL129] Change some confusing method names.
...
Bug: 8636060
Change-Id: I2f55fc23d7e05b63582a3f0660b58635eae5ec59
2014-04-02 18:10:18 +09:00
Jean Chalard
f6bce235ae
[CB22] Merge add and delete
...
Bug: 13406701
Change-Id: Ic9e90dd226b58b5ddb9693e04259cde00916007e
2014-04-02 18:01:00 +09:00
Jean Chalard
3e160bbe6b
[CB21] More refactoring
...
Bug: 13406701
Change-Id: I96e0a7fa2d9f4dfd8c355da4effc116bbd0f7f18
2014-04-02 18:01:00 +09:00
Jean Chalard
dfaeb125eb
[CB20] Some more refactoring
...
Bug: 13406701
Change-Id: I4502658f4f1e1997d0ac245d95e2d4a1415b1861
2014-04-02 18:00:57 +09:00
Jean Chalard
0f913ff5ba
[CB19] Some refactoring
...
Bug: 13406701
Change-Id: Ie4d420e8cabbbd93c3eea13a80baa4d766ee61d0
2014-04-02 18:00:19 +09:00
Jean Chalard
8bb2e99aef
[CB18] Move some code around
...
Bring next to each other two methods scheduled for a merge
Bug: 13406701
Change-Id: I335c7202cc07d8865f4ab92e4023c1d93d1f83ac
2014-04-02 17:58:33 +09:00
Jean Chalard
3285b68c97
[CB17] Remove a member.
...
Bug: 13406701
Change-Id: I2e271f637f6b529a4191a7adc5cdfa5af437761b
2014-04-02 17:57:36 +09:00
Tadashi G. Takaoka
7dd32dfc06
Remove country name from space bar text when appropriate
...
Remove country name from space bar text when there no other subtype
that is a same language and a same keyboard layout.
Bug: 8084704
Change-Id: I7c785a925ff7a0a61e5d009f138e1df52b3aeb3a
2014-04-02 12:50:52 +09:00
Tadashi G. Takaoka
65a199ca8e
Merge "Add SpacebarLanguageUtils class"
2014-04-01 03:25:31 +00:00
Tadashi G. Takaoka
9364d46ac3
Add SpacebarLanguageUtils class
...
The SpacebarLanguageUtils class is separated from SubtypeLocaleUtils
and handles the language name on the spacebar.
Bug: 8084704
Change-Id: I82f79a061d4f0cc2895263298c3ebf8ee444c61d
2014-04-01 12:17:06 +09:00
Jean Chalard
1dc354bed1
Merge "[IL128] Remove passing some handlers."
2014-03-31 09:32:00 +00:00
Jean Chalard
dbadee96b6
Do not create a handler thread for each session
...
Bug: 13710224
Bug: 12821388
Bug: 12667742
Change-Id: I6188e0240193d2bca789110e7660a0f31bbafc62
2014-03-31 15:32:48 +09:00
Keisuke Kuroyanagi
f41518dbab
Fix: spell checker wrongly sorts suggestions.
...
Change-Id: I729e1cd5e5e333038b9d9e6197cf50b574990d76
2014-03-28 14:37:48 +00:00
Jean Chalard
452cd2f619
Fix a bug where LatinIME would leak pipes.
...
Bug: 12667742
Bug: 12821388
Change-Id: Ic0bad56fb96e54ac032759adffc8ea320c06dff2
2014-03-28 19:54:07 +09:00
Jean Chalard
52eb673c46
Merge "Some cleanup"
2014-03-28 09:22:22 +00:00
Tadashi G. Takaoka
03f9c4820a
Merge "Make NeedsToDisplayLanguage as a top level class"
2014-03-28 09:15:25 +00:00
Tadashi G. Takaoka
c412a41aff
Merge "Remove redundant check to detect forceAscii"
2014-03-28 09:15:18 +00:00
Tadashi G. Takaoka
8e3c585265
Make NeedsToDisplayLanguage as a top level class
...
Change-Id: Ia05e0494a9dccebfb5c1316479e52f04cf2ae444
2014-03-28 17:59:57 +09:00
Tadashi G. Takaoka
61dbda00de
Remove redundant check to detect forceAscii
...
Change-Id: Ib3272ec19a90b3aa4937573e049ceb86855ea408
2014-03-28 17:56:08 +09:00
Keisuke Kuroyanagi
a4c5c54a19
Merge "Remove unused method."
2014-03-28 08:07:42 +00:00
Keisuke Kuroyanagi
781e3df73b
Merge "Dictionary migration in Java side."
2014-03-28 08:07:26 +00:00
Jean Chalard
35645ac39a
Merge "[CB14.5] Stop copying WordComposers."
2014-03-28 06:51:17 +00:00
Jean Chalard
70d9152c7f
Some cleanup
...
Change-Id: Ia11d656a70623168b091763ac6524750f9cca8d8
2014-03-28 15:27:00 +09:00
Jean Chalard
8e829c37df
[CB14.5] Stop copying WordComposers.
...
This is an overdue refactoring that I have been wanted to
do forever, and that we can at last do now that suggestions
come only from instances of BinaryDictionary instances.
With this, all unit tests and regression tests are
passing again.
Bug: 13667648
Bug: 13665487
Bug: 8636060
Change-Id: Ie23a19f9b7e692edf2ee0b107ddaff2d7db564b6
2014-03-28 15:26:27 +09:00
Keisuke Kuroyanagi
3c801be5e5
Merge "Fix unit tests by adding @UsedForTesting."
2014-03-28 06:08:37 +00:00
Keisuke Kuroyanagi
aa7abb2d89
Fix unit tests by adding @UsedForTesting.
...
Change-Id: I8497d6cf446297bc8c15e9d9818078b1026a8c51
2014-03-28 15:02:00 +09:00
Tadashi G. Takaoka
f173b12b03
Merge "Stop displaying locale string on short space bar"
2014-03-28 04:49:17 +00:00
Tadashi G. Takaoka
2202d47386
Stop displaying locale string on short space bar
...
Bug: 12070355
Change-Id: I2d6fa20431bc56d5139caeac33e396b73906d075
2014-03-28 13:05:13 +09:00
Keisuke Kuroyanagi
30cd0cd2a0
Fix: NPE after onDestroy().
...
Bug: 13671513
Change-Id: I06aa14870ff5422ad514356ee406600b247858c5
2014-03-28 12:17:44 +09:00
Jean Chalard
080e0253ae
Merge "Revert "[CB15] Remove a redundant variable.""
2014-03-27 09:44:31 +00:00
Jean Chalard
f459ccf4f6
Merge "Revert "[CB16] Remove unused stuff""
2014-03-27 09:44:24 +00:00
Jean Chalard
75715f7d9f
Revert "[CB15] Remove a redundant variable."
...
This reverts commit 0de7a6d1a2
.
Change-Id: I327679b76a14cf9c3aec4b00b013b921408c32f9
2014-03-27 09:43:45 +00:00
Jean Chalard
26baa759d8
Revert "[CB16] Remove unused stuff"
...
This reverts commit 05c46f59fd
.
Change-Id: Ica0feea10fff1b2a9ef42bc55cb7c1892b3a3f58
2014-03-27 09:43:21 +00:00
Jean Chalard
5154c47cbe
Merge "[CB16] Remove unused stuff"
2014-03-27 08:52:11 +00:00
Jean Chalard
6bd3723e73
[IL128] Remove passing some handlers.
...
Bug: 8636060
Change-Id: I088be9a7555265ca097667523defd73be4cbe37f
2014-03-27 17:51:32 +09:00
Keisuke Kuroyanagi
c17311cefe
Remove unused method.
...
Change-Id: Iefb75136080e73c357511df045816f18cec767a6
2014-03-27 17:46:38 +09:00
Keisuke Kuroyanagi
a785fa8edd
Dictionary migration in Java side.
...
Bug: 13406708
Change-Id: If83938e4b4810d2e8353c70cdd8ef3ea97a29571
2014-03-27 17:46:35 +09:00
Jean Chalard
5feda45a6f
Merge "[CB15] Remove a redundant variable."
2014-03-27 08:05:23 +00:00
Jean Chalard
05c46f59fd
[CB16] Remove unused stuff
...
Bug: 13406701
Change-Id: Ib863c5181e1f5d74cfa4458060afc49d1ee8109e
2014-03-27 16:47:30 +09:00
Jean Chalard
0de7a6d1a2
[CB15] Remove a redundant variable.
...
This is a tiny bit slower, but probably unnoticeable.
Still, it gains some performance in other places,
saves memory, and more importantly makes for simpler
code, so it's certainly better.
Change-Id: Id1ab4f73f71acd73f5920bc729817abd22cf0d07
2014-03-27 16:47:27 +09:00
Keisuke Kuroyanagi
6008898b99
Merge "Move code only used for dicttool and tests under tests."
2014-03-27 06:37:10 +00:00
Keisuke Kuroyanagi
93cda5bb39
Move code only used for dicttool and tests under tests.
...
Bug: 13035567
Change-Id: I13c6df013ef2b67c9bf67455d9c32d283bf9ea2e
2014-03-27 15:30:32 +09:00
Keisuke Kuroyanagi
3c38e1f269
Merge "Fix: NPE in isValidWord after dictionaries are closed."
2014-03-27 03:12:07 +00:00
Keisuke Kuroyanagi
7b516d496d
Fix: NPE in isValidWord after dictionaries are closed.
...
Bug: 13650542
Change-Id: I1bdc838fca48d6ef12db5e70d40273d1236128d1
2014-03-27 12:03:58 +09:00