nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30843 commits 1 branch 0 tags 363 MiB
Commit graph

6808 commits

Author SHA1 Message Date
Keisuke Kuroyanagi
858045b41c Merge "Fix: wrong auto correction for whilelist and personalized words." 2014-02-28 12:26:03 +00:00
Keisuke Kuroyanagi
23ae574a11 Fix: wrong auto correction for whilelist and personalized words. 
This happens when there are tailing single quotes.

Bug: 13237314
Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14
 2014-02-28 21:24:26 +09:00
Keisuke Kuroyanagi
5128935ac4 Add header attributes for evaluation. 
Bug: 13197276
Change-Id: Ib5247da691ff24a73e13485288237ccc51bb54f0
 2014-02-28 21:06:03 +09:00
Keisuke Kuroyanagi
58a536e41a Merge "Use dynamic operations to construct all ver4 dicts." 2014-02-28 09:37:23 +00:00
Keisuke Kuroyanagi
684f5f18b1 Merge "Added a method and run GC for testing." 2014-02-28 09:33:51 +00:00
Keisuke Kuroyanagi
d302b98ce6 Added a method and run GC for testing. 
Bug: 13231889
Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
 2014-02-28 18:17:09 +09:00
Ken Wakasa
98534dc065 Add missing null checks for getOwnerInstance() 
It may just return null.

Change-Id: I778fb48262ef8af28a4af50b70bb94ace75a488c
 2014-02-28 16:13:51 +09:00
Keisuke Kuroyanagi
ea89cb40b7 Use dynamic operations to construct all ver4 dicts. 
Bug: 8187060
Bug: 13127350
Change-Id: I081ee904c41898128efa8ba7a1bf3fa0a46c6231
 2014-02-27 23:21:09 +09:00
Keisuke Kuroyanagi
1aac28a2b9 Remove "Use only personalization dictionary". 
Bug: 13216198
Change-Id: I20ce61c4a10c360e028bf6427f632cc5299763e4
 2014-02-27 22:32:00 +09:00
Keisuke Kuroyanagi
e9926b0d11 Remove redundant creation of dictionary facilitator. 
Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31
 2014-02-27 22:31:57 +09:00
Tadashi G. Takaoka
e989c6ea85 Merge "Remove wrong duplicated resource from Afrikaans layout" 2014-02-27 11:17:34 +00:00
Tadashi G. Takaoka
51cb8e6f4e Remove wrong duplicated resource from Afrikaans layout 
Bug: 6867914
Change-Id: Ibc329c8ea03abaa91ba27e7e62fb6d02cc67debe
 2014-02-27 19:01:49 +09:00
Jean Chalard
d1394b6986 Merge "Fix a bug with auto-caps entries from personalization" 2014-02-27 07:38:24 +00:00
Jean Chalard
71e3ecd0a2 Fix a bug with auto-caps entries from personalization 
Bug: 13215163
Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a
 2014-02-27 14:40:54 +09:00
Tadashi G. Takaoka
f8a45cfd2f Fix NPE in KeyDetector 
This is actually a follow up of I9290974821.

Bug: 13215075
Change-Id: Ib7eef55fd1cfbb05d06aeeb0726bc10c87b07d85
 2014-02-27 14:17:14 +09:00
Tadashi G. Takaoka
997ba1b41e Merge "Add keyboard layout set tests" 2014-02-27 03:08:42 +00:00
Keisuke Kuroyanagi
e1480a246d Merge "Set additional attributes in dictionary facilitator." 2014-02-26 10:37:46 +00:00
Keisuke Kuroyanagi
f8552f61a4 Set additional attributes in dictionary facilitator. 
Bug: 13197276
Change-Id: I206cf4e599ca9cdf40d669358a1067a2954d11e3
 2014-02-26 19:14:16 +09:00
Keisuke Kuroyanagi
e55d44c535 Merge "Add a method to create dict with additional attributes." 2014-02-26 10:07:53 +00:00
Keisuke Kuroyanagi
18f91cf617 Add a method to create dict with additional attributes. 
Bug: 13197276
Change-Id: I80311a51d9e98bfeb8c0dd9cd4adde93af366d54
 2014-02-26 19:03:27 +09:00
Keisuke Kuroyanagi
009bb5642b Merge "Use NOT_A_PROBABILITY for adding OOV words." 2014-02-26 09:48:57 +00:00
Jean Chalard
7e70e9dc49 Merge "[IL110] Remove an unused interface function" 2014-02-26 09:08:30 +00:00
Keisuke Kuroyanagi
2b27e06733 Merge "Read and write forgetting curve header attributes." 2014-02-26 09:06:56 +00:00
Keisuke Kuroyanagi
6112cc26a7 Read and write forgetting curve header attributes. 
Bug: 13197276
Change-Id: I6c38a127e1745903594b7bf0ec80ef179e794feb
 2014-02-26 18:04:12 +09:00
Keisuke Kuroyanagi
8559b403ed Use NOT_A_PROBABILITY for adding OOV words. 
Bug: 13197276
Change-Id: I23f453c2c1deea70eab552f8d433fe264adf68b3
 2014-02-26 17:50:44 +09:00
Jean Chalard
bd1caac16a [IL110] Remove an unused interface function 
...and make a method private.

Bug: 8636060
Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
 2014-02-26 17:46:20 +09:00
Tadashi G. Takaoka
dd01a0bb1d Add keyboard layout set tests 
This CL is a ground work to add keyboard layout labels and more keys
tests.

Bug: 13017434
Change-Id: Ief028e8ab563d79bc0b0f9c06f1fe1d645a6469d
 2014-02-26 16:10:52 +09:00
Jean Chalard
23e22613d7 Remove useless args and processing. 
Bug: 13062385
Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
 2014-02-26 11:40:43 +09:00
Jean Chalard
57c0c577af [QRP6] Fix: recorrection top candidate is displayed in bold 
Bug: 10385162
Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
 2014-02-25 19:48:09 +09:00
Jean Chalard
0c34ee20a8 [QRP5] Fix boldness for predictions, and small refactoring 
This is more correct. When predictions, the typed word should
always be null unless explicitly passed. The text color should be
that of a valid typed word only if it's actually the typed word.

Bug: 13170509
Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
 2014-02-25 19:44:57 +09:00
Jean Chalard
783f193239 [QRP4] Simplification & small correctness fix. 
This fixes the color of the predictions when running
on a theme that has different colors for typed and
suggested words (GB theme).
Also, this is easier to understand and to modify from
now on.

Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4
 2014-02-25 08:59:14 +00:00
Jean Chalard
a0984662a1 [QRP3] Refactoring 
Rename some variables for clarity and use constants
instead of immediates.

Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
 2014-02-25 17:05:47 +09:00
Jean Chalard
74224f2c5c [QRP2] Small refactor 
Bug: 13170509
Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
 2014-02-25 17:05:47 +09:00
Jean Chalard
ef3a45643e [QRP1] Fix a bug where the wrong value would get passed 
In the practice it works because this never tries to access
inside the suggestion strip, and the worst that can happen
is a wrong text color for a suggestion. But since the two
colors that would be swapped are the same, nobody ever
notices -- unless they are using the GingerBread theme.

Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
 2014-02-25 17:05:44 +09:00
Tadashi G. Takaoka
deb5cedf81 Add Key.getIconId for testability 
Bug: 13017434
Change-Id: I94ff45da3f58b74cc9dd4d38179670fbcf619d92
 2014-02-25 09:59:38 +09:00
Jean Chalard
6e224a236a Merge "Correctly read the header of APK-embedded dicts" 2014-02-24 13:57:46 +00:00
Jean Chalard
890b44e537 Correctly read the header of APK-embedded dicts 
Bug: 13164518
Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
 2014-02-24 22:54:01 +09:00
Jean Chalard
64ace089a8 Merge "Use an executor to serialize opening dictionaries." 2014-02-24 13:43:49 +00:00
Tadashi G. Takaoka
2c55706b0e Merge "Create a utils class for executors." 2014-02-24 13:33:44 +00:00
Jean Chalard
4de2fcdde3 Use an executor to serialize opening dictionaries. 
Bug: 13082957
Change-Id: I25570ab4da94337ed60330c0869fe47657096626
 2014-02-24 21:05:24 +09:00
Jean Chalard
b434acee34 Create a utils class for executors. 
Preliminary refactoring to fix
Bug: 13082957

Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
 2014-02-24 20:52:49 +09:00
Tadashi G. Takaoka
c40eb52e43 Merge "Remove hack from EmojiPalettesView.startEmojiPalettes" 2014-02-24 10:49:59 +00:00
Tadashi G. Takaoka
d227b00a72 Remove hack from EmojiPalettesView.startEmojiPalettes 
Bug: 12115967
Change-Id: I91c567a9577012ec28c08430c55e56e9c2e25b5f
 2014-02-24 19:45:50 +09:00
Jean Chalard
65bce4cabc Merge "Never pass negative values to setSelection." 2014-02-24 09:26:43 +00:00
Tadashi G. Takaoka
b08a9e021c Merge "Revert "Prepare for changing text color for functional keys"" 2014-02-24 08:54:55 +00:00
Tadashi G. Takaoka
da500b7ec3 Revert "Prepare for changing text color for functional keys" 
This reverts commit 194e004e81.
Bug: 10786040

Change-Id: I4c5287d46cabe287abce5cba77635cf26d2cd192
 2014-02-24 17:42:28 +09:00
Jean Chalard
f19745728e Never pass negative values to setSelection. 
Bug: 13136079
Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
 2014-02-24 16:52:55 +09:00
Keisuke Kuroyanagi
2b72aa07a9 Disconnect app data search client after fetching all data. 
Bug: 13138201
Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
 2014-02-24 14:47:54 +09:00
Jean Chalard
296adf5710 Merge "Change a heuristic and add a log." 2014-02-21 11:58:16 +00:00
Tadashi G. Takaoka
1269ae3144 Merge "Change make-keyboard-text -java option to point LatinIME/java directory" 2014-02-21 11:54:39 +00:00
Keisuke Kuroyanagi
bb6b978a19 Merge "Fix: file descriptor leaking." 2014-02-21 11:37:09 +00:00
Jean Chalard
bf075b21a1 Merge "Don't trim newer inputpointers with old data" 2014-02-21 11:19:04 +00:00
Tadashi G. Takaoka
5eb6ea9f27 Change make-keyboard-text -java option to point LatinIME/java directory 
Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
 2014-02-21 19:24:24 +09:00
Keisuke Kuroyanagi
ad508d029f Merge "Remove corrupted ver4 dictionaries." 2014-02-21 09:03:19 +00:00
Keisuke Kuroyanagi
d24a99cff6 Fix: file descriptor leaking. 
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.

Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
 2014-02-21 17:25:34 +09:00
Jean Chalard
2a5ec00301 Don't trim newer inputpointers with old data 
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.

Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
 2014-02-21 16:43:11 +09:00
Tadashi G. Takaoka
d73044a249 Add ImportantNoticeDialog 
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
 2014-02-21 16:36:15 +09:00
Keisuke Kuroyanagi
d934fb43ad Remove corrupted ver4 dictionaries. 
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
 2014-02-21 15:09:37 +09:00
Tadashi G. Takaoka
fe39d576dc Support versioned important notice 
This change must be checked in together with If38a754d00.

Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
 2014-02-21 09:54:08 +09:00
Jean Chalard
3b4c1d3056 Change a heuristic and add a log. 
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.

Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.

Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
 2014-02-20 23:49:20 +09:00
Jean Chalard
1b3a142cac Merge "Fix a bug where suggestions would not be updated." 2014-02-20 14:46:35 +00:00
Jean Chalard
6f50c95887 Fix a bug where suggestions would not be updated. 
Also fix a small cosmetic bug where the suggestion strip
would flash.

Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
 2014-02-20 23:32:04 +09:00
Jean Chalard
a118d19f6c Merge "Don't distrust the cursor pos so much as to bug on IPC delay" 2014-02-20 14:22:48 +00:00
Jean Chalard
3c84eb8822 Don't distrust the cursor pos so much as to bug on IPC delay 
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.

When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.

However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.

Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).

So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.

Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
 2014-02-20 23:13:14 +09:00
Keisuke Kuroyanagi
d36328cecf Add test only methods to test personalized dicts. 
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
 2014-02-20 22:20:43 +09:00
Keisuke Kuroyanagi
485c1ec685 Merge "Add final and volatile for members of InputLogic." 2014-02-20 10:12:45 +00:00
Keisuke Kuroyanagi
afdb6f011b Merge "Add user history dictionary decaying test." 2014-02-20 10:05:20 +00:00
Keisuke Kuroyanagi
b063377e77 Add final and volatile for members of InputLogic. 
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
 2014-02-20 18:55:19 +09:00
Keisuke Kuroyanagi
0bc66daae3 Add user history dictionary decaying test. 
Bug: 10667710

Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
 2014-02-20 18:36:46 +09:00
Keisuke Kuroyanagi
a514ea7e1b Merge "Check all enabled IME's subtypes to enable personalization." 2014-02-20 09:33:21 +00:00
Keisuke Kuroyanagi
d10e2d85af Merge "Throw IOException when dict header cannot be read." 2014-02-20 09:33:08 +00:00
Keisuke Kuroyanagi
afd9b62f00 Throw IOException when dict header cannot be read. 
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
 2014-02-20 18:11:17 +09:00
Jean Chalard
475f9f35b6 Merge "Comments improvements" 2014-02-20 08:22:39 +00:00
Tadashi G. Takaoka
1672ccbbb6 Change important notice version preference file 
This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.

Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
 2014-02-20 16:50:34 +09:00
Tadashi G. Takaoka
78db739cdb Fix build due to Ib4c472756f 
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
 2014-02-20 16:16:57 +09:00
Jean Chalard
ad2cf220a9 Merge "Remove a call to a deprecated method" 2014-02-20 06:40:46 +00:00
Tadashi G. Takaoka
251ed3b358 Merge "Revert "Turn off personalization default settings"" 2014-02-20 06:26:48 +00:00
Tadashi G. Takaoka
c2ba73ab41 Revert "Turn off personalization default settings" 
This reverts commit 0a4ac795d6.

Bug: 10587358
Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
 2014-02-20 06:06:29 +00:00
Keisuke Kuroyanagi
6b23749dec Check all enabled IME's subtypes to enable personalization. 
Bug: 13067743

Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
 2014-02-20 15:05:37 +09:00
Jean Chalard
c44b7312ad Remove a call to a deprecated method 
...that would cause a crash

Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
 2014-02-20 14:40:38 +09:00
Jean Chalard
be8ad77ebb Comments improvements 
Typo fixes and clarifications

Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
 2014-02-20 13:29:43 +09:00
Keisuke Kuroyanagi
34fb962513 Call PersonalizationDictionarySessionRegistrar.init(). 
Wrongly removed in I1f50cb137b6054dc9.

Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
 2014-02-19 23:27:14 +09:00
Keisuke Kuroyanagi
d102eb80da Remove personalization dicts for multilingual users. 
Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
 2014-02-19 21:00:27 +09:00
Tadashi G. Takaoka
920c40fe45 Use AlertDialog.setOnDismissListener 
AlertDialog.Builder.setOnDismissListener is supported from API 17.

Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
 2014-02-19 19:05:06 +09:00
Tadashi G. Takaoka
ed616083dd Merge "Turn personalization on when important notice dialog is displayed" 2014-02-19 09:46:15 +00:00
Tadashi G. Takaoka
6abc852255 Turn personalization on when important notice dialog is displayed 
This change must be checked in together with Ifde70b1d3b.

Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
 2014-02-19 18:36:32 +09:00
Tadashi G. Takaoka
3a7ed5fdfe Merge "Fix IllegalStateException raied by monkey" 2014-02-19 08:27:37 +00:00
Tadashi G. Takaoka
9fd7447d6c Fix IllegalStateException raied by monkey 
Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
 2014-02-19 16:40:52 +09:00
Keisuke Kuroyanagi
03105290d8 Merge "Throw exception when the header cannot be read." 2014-02-19 04:59:47 +00:00
Tadashi G. Takaoka
776bba098b Merge "Turn off personalization default settings" 2014-02-19 04:25:04 +00:00
Keisuke Kuroyanagi
97a40d030f Throw exception when the header cannot be read. 
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
 2014-02-19 12:35:58 +09:00
Keisuke Kuroyanagi
e49e007bb2 Fix: Use old suggest after reloading. 
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
 2014-02-19 12:34:09 +09:00
Tadashi G. Takaoka
0a4ac795d6 Turn off personalization default settings 
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.

Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
 2014-02-19 12:08:50 +09:00
Jean Chalard
80d413caff Merge "Straighten out database cursors behavior." 2014-02-18 11:09:38 +00:00
Jean Chalard
28e0b24965 Merge "Fix a bug where the cache would be out of sync" 2014-02-18 10:58:50 +00:00
Jean Chalard
b8ff8ca9d9 Straighten out database cursors behavior. 
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.

It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.

Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
 2014-02-18 19:58:23 +09:00
Jean Chalard
fe92c174ea Fix a bug where the cache would be out of sync 
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.

Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
 2014-02-18 19:55:54 +09:00
Jean Chalard
783dabb812 Merge "Cleanup." 2014-02-18 09:54:33 +00:00
Jean Chalard
63be066544 Cleanup. 
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.

Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
 2014-02-18 17:07:46 +09:00
Ken Wakasa
266c8c5b1d Merge "Some cosmetic fixes in LatinIME.java" 2014-02-18 06:08:34 +00:00
Ken Wakasa
12ff7da19d Some cosmetic fixes in LatinIME.java 
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
 2014-02-18 14:56:50 +09:00
Jean Chalard
9967f0a1d0 Avoid crashing when the Content URL is not found. 
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.

Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
 2014-02-18 14:27:58 +09:00
Ken Wakasa
0d32643e69 Merge "Cosmetic fixes" 2014-02-18 03:28:04 +00:00
Ken Wakasa
2312c1954f Cosmetic fixes 
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
 2014-02-18 12:17:24 +09:00
Tadashi G. Takaoka
cc05f468ca Merge "Refactor InputAttributes a bit" 2014-02-18 02:25:46 +00:00
Tadashi G. Takaoka
06fbfc4951 Refactor InputAttributes a bit 
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
 2014-02-18 11:11:36 +09:00
Tadashi G. Takaoka
affdd36423 Set neutral suggestions should be called after load settings 
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
 2014-02-18 11:04:00 +09:00
Tadashi G. Takaoka
f0f4e9fc16 Update important notice version even when user select Settings 
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
 2014-02-18 00:14:30 +09:00
Jean Chalard
782c9fee6b Merge "Don't resume suggestion on links." 2014-02-17 11:46:54 +00:00
Jean Chalard
7a7aeffcdc Don't resume suggestion on links. 
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
 2014-02-17 20:36:16 +09:00
Jean Chalard
d91cd9919e Merge "Catch exceptions we can't do anything about." 2014-02-17 11:33:39 +00:00
Tadashi G. Takaoka
5cd732f8c5 Stop overriding InputView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
 2014-02-17 19:51:47 +09:00
Jean Chalard
a149731a67 Catch exceptions we can't do anything about. 
This also abstracts away the "package deactivated" case for
simpler and safer code.

Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
 2014-02-17 18:49:31 +09:00
Tadashi G. Takaoka
891e4860f8 Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 2014-02-17 09:20:54 +00:00
Tadashi G. Takaoka
e32548f32d Stop overriding SuggestionStripView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
 2014-02-17 18:11:10 +09:00
Tadashi G. Takaoka
1751615f7d Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 2014-02-17 08:26:38 +00:00
Tadashi G. Takaoka
3dd6bdf931 Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 2014-02-17 08:25:57 +00:00
Tadashi G. Takaoka
800ab579a9 Remove unnecessary override of MainKeyboardView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
 2014-02-17 17:09:06 +09:00
Tadashi G. Takaoka
4c628b9d5b Merge "Don't show important notice on password field" 2014-02-17 08:04:11 +00:00
Tadashi G. Takaoka
20ddd4cff5 Add InputMethodSubtypeCompatUtils.isAsciiCapable() 
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
 2014-02-17 16:08:33 +09:00
Tadashi G. Takaoka
ce78a2d8ab Don't show important notice on password field 
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
 2014-02-17 15:38:43 +09:00
Tadashi G. Takaoka
4f4fb5ef34 Merge "Use the same label of switch-to-alphabet key on Emoji palette" 2014-02-17 06:13:39 +00:00
Tadashi G. Takaoka
4c680e7bcf Merge "Add go to "Settings" button to important notice dialog" 2014-02-17 06:13:26 +00:00
Tadashi G. Takaoka
28c02b400f Add go to "Settings" button to important notice dialog 
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.

This change must be checked in together with Id115d89ba9.

Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
 2014-02-17 14:57:04 +09:00
Tadashi G. Takaoka
fe39aec08a Use the same label of switch-to-alphabet key on Emoji palette 
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
 2014-02-17 14:54:39 +09:00
Tadashi G. Takaoka
c9072dc8da Remove key show up and dismiss animation 
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
 2014-02-17 12:10:09 +09:00
Keisuke Kuroyanagi
95d16561e0 Remove unused code. 
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
 2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi
0fc93fe445 Implement PatriciaTriePolicy::getNextWordAndNextToken(). 
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
 2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi
85fe06e759 Merge "Remove unused argument from readDictionaryBinary." 2014-02-14 10:37:56 +00:00
Keisuke Kuroyanagi
8e3a1d0f89 Remove unused argument from readDictionaryBinary. 
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
 2014-02-14 19:02:15 +09:00
Tadashi G. Takaoka
b136b7dd6f Merge "Add sanity check to KeybaordTextsTable for debugging" 2014-02-14 09:52:36 +00:00
Tadashi G. Takaoka
53a237323a Add sanity check to KeybaordTextsTable for debugging 
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
 2014-02-14 18:51:03 +09:00
Jean Chalard
fdc4173213 Merge "Fix a view-related crash" 2014-02-14 09:19:34 +00:00
Jean Chalard
a7e3e74ddd Fix a view-related crash 
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
 2014-02-14 18:03:34 +09:00
Tadashi G. Takaoka
3c4f05dd66 Remove unused label_tab_key 
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
 2014-02-14 17:40:53 +09:00
Tadashi G. Takaoka
17993ed4ef Merge "Fix null KeyDetector reference" 2014-02-14 07:17:33 +00:00
Tadashi G. Takaoka
a273319c59 Add PunctuationSuggestions class 
This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
 2014-02-14 14:13:39 +09:00
Jean Chalard
4197c6f3ab Merge "Show the suggestion strip for the important notice" 2014-02-14 04:07:46 +00:00
Tadashi G. Takaoka
ef8a03685f Fix null KeyDetector reference 
This change must be checked in together with I737c266c45.

Bug: 13011041
Change-Id: Ia3d25be6de47fa16ab7156a25641e53a23948ff4
 2014-02-14 11:42:09 +09:00
Yohei Yukawa
362ab36cf0 Fix a null object reference crash on Emoji Palette 
Do nothing if the current EmojiPageKeyboardView is null.

BUG: 13006906
Change-Id: I169b70122ec939075b5be033953b48762fd528fc
 2014-02-14 10:36:31 +09:00
Yohei Yukawa
5f9f4b929b Merge "Fix indent." 2014-02-14 01:26:48 +00:00
Jean Chalard
5e09958056 Merge "Backward compatibility hack : send delete when empty." 2014-02-13 10:09:41 +00:00
Jean Chalard
2c48846903 Backward compatibility hack : send delete when empty. 
Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.

This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.

Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
 2014-02-13 18:41:54 +09:00
Tadashi G. Takaoka
7ae6721ffa Remove RTL aware !code and add corresponding !text 
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
 2014-02-13 17:32:09 +09:00
Tadashi G. Takaoka
3cb77678f5 Fix Armenian switch to alphabet key text 
Bug: 7963631
Change-Id: If5768c761ec96d3404900b0c017abc2317cce8d4
 2014-02-13 17:26:16 +09:00
Tadashi G. Takaoka
0af6d988a7 Merge "Optimize KeyboardTextsTable" 2014-02-13 08:22:58 +00:00
Tadashi G. Takaoka
0fe4d00068 Optimize KeyboardTextsTable 
This change counts all occurrences of each string resource and sort
those in descending order of the occurrence.

Change-Id: I726402157feb0d436a54bd0a7252acd17fd711f9
 2014-02-13 17:11:00 +09:00
Tadashi G. Takaoka
36b8962a9a Merge "Fix UserHistoryDictionaryTests" 2014-02-13 07:49:51 +00:00
Tadashi G. Takaoka
32c8d58cef Merge "Fix showing all suggestions when the top suggestion is long" 2014-02-13 07:17:31 +00:00
Tadashi G. Takaoka
0cda0e8a9c Fix UserHistoryDictionaryTests 
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
 2014-02-13 16:16:44 +09:00
Tadashi G. Takaoka
4f8a8f125e Fix showing all suggestions when the top suggestion is long 
This change also fixes Bug#12982404; displays the suggestion word
using entire suggestions strip if there is only one suggestion.

Bug: 12564279
Bug: 12982404
Change-Id: I51806b90c3ee34a2072880245d4e33f7be273c8f
 2014-02-13 15:22:36 +09:00
Jean Chalard
e0a425681c Merge "Fix a test." 2014-02-13 05:20:58 +00:00
Jean Chalard
cf03ff02b1 Fix a test. 
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.

Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
 2014-02-13 14:01:37 +09:00
Tadashi G. Takaoka
8dd47029f1 Merge "Refactor dictionary constructor" 2014-02-13 04:55:16 +00:00
Jean Chalard
c3cfabd0eb Merge "Dump settings." 2014-02-13 04:26:52 +00:00
Tadashi G. Takaoka
870d89b1a8 Refactor dictionary constructor 
This change must be checked in together with I3923d5af2a.

Bug: 12994268
Change-Id: I19de6efbdfa3b6c6c69a20a836e53962fd5737de
 2014-02-13 13:23:55 +09:00
Yohei Yukawa
cfe26bbcde Fix indent. 
This is a follow up for the previous commit to fix indent.

BUG: 12964092
Change-Id: I0530b1c0dae26ac736ddcc6d426ec6ce57bce4d1
 2014-02-13 01:58:58 +09:00
Jean Chalard
367a35d377 Dump settings. 
Bug: 10315296
Change-Id: Ieb020a23886514b3ba97611d8a6001f32b322f63
 2014-02-12 22:53:15 +09:00
Yohei Yukawa
50fbe4cc09 Merge "Cancel keydown events immediately once the view starts scrolling" 2014-02-12 10:21:08 +00:00
Yohei Yukawa
4c259866c4 Cancel keydown events immediately once the view starts scrolling 
The motivation of this patch is to make sure a user never feel
haptic feedback when scrolling the Emoji palette. In order to
achieve it, EmojiPageKeyboardView#releaseCurrentKey() should
be called whenever (delayed) keydown events should be canceled.

This patch wires up ViewPager.OnPageChangeListener#onPageScrolled
with EmojiPageKeyboardView#releaseCurrentKey() so that delayed
keydown events will be canceled immediately once the ViewParger
starts scrolling.

BUG: 12964092
Change-Id: Iea8c3e090bb16a8622e6b4a850af2bf963aa77d0
 2014-02-12 18:56:08 +09:00
Tadashi G. Takaoka
5a885e85c2 Merge "Keep showing key preview even when keyboard has been changed" 2014-02-12 09:40:55 +00:00
Tadashi G. Takaoka
dd6ba4b184 Merge "Fix bug in KeyPreviewChoreographer.dismissKeyPreview" 2014-02-12 09:13:37 +00:00
Jean Chalard
8adedbf47c Show the suggestion strip for the important notice 
Bug: 10587358
Change-Id: Ia060a9ca9dfc2e7fe0750536a9fea3b9cc5900c4
 2014-02-12 17:30:04 +09:00
Tadashi G. Takaoka
075158ccd0 Keep showing key preview even when keyboard has been changed 
Bug: 12979147
Change-Id: I7e1f60686d6a8a0fca463174abb0a45f1f62ca43
 2014-02-12 15:09:03 +09:00
Tadashi G. Takaoka
7e9b0b42bf Fix bug in KeyPreviewChoreographer.dismissKeyPreview 
Bug: 12979147
Change-Id: Ibc60b4565badaebe760194f27984b02f9f966996
 2014-02-12 14:50:56 +09:00
Tadashi G. Takaoka
7ffac033ac Make importance notice dialog cancel able 
Bug: 10587358
Change-Id: I7415a6f33e6b5542718164fea1555095d23233e5
 2014-02-12 11:59:43 +09:00
Tadashi G. Takaoka
6e1710f0d4 Merge "Optimize text resources' ordering a bit" 2014-02-11 13:33:42 +00:00
Tadashi G. Takaoka
d495cc36b7 Merge "Get nicer output of make-keyboard-text" 2014-02-11 12:43:32 +00:00
Tadashi G. Takaoka
8bfd6100d9 Optimize text resources' ordering a bit 
Change-Id: I19382f1d9a4b6be173d1e9f62edd727ea987fa20
 2014-02-11 21:41:55 +09:00
Tadashi G. Takaoka
ed509695a4 Get nicer output of make-keyboard-text 
Change-Id: I6d30127aac2198d55b1335002f7a66b4aaebf82d
 2014-02-11 21:41:21 +09:00
Jean Chalard
3df8bcb7a9 Revert "Display predictions when the cursor is moved after a word." 
This change is lacking some comments and break some unit tests.
It needs more work.

This reverts commit 38d31a5e79.

Change-Id: I675854fd0729f2d01b7751e35c6d0117f4f88993
 2014-02-10 14:24:30 +00:00
Jean Chalard
38d31a5e79 Display predictions when the cursor is moved after a word. 
Bug: 12951777
Change-Id: I744b98df6679edd34ca3c1392e38597325935932
 2014-02-10 23:07:00 +09:00
Jean Chalard
f9e5b1ee4f Merge "Show important notice strip" 2014-02-10 12:18:10 +00:00
Tadashi G. Takaoka
8dda9e480b Show important notice strip 
Bug: 10587358
Change-Id: I1af3faa59afb2fc4cb90176acff1c2b0b1ba369c
 2014-02-10 21:15:35 +09:00
Keisuke Kuroyanagi
ea24abf878 Merge "Remove unused code." 2014-02-10 07:19:53 +00:00
Keisuke Kuroyanagi
2ef87aee3e Merge "Make PtNode have ProbabilityInfo instead of raw value." 2014-02-10 06:10:51 +00:00
Keisuke Kuroyanagi
69ccac6e51 Remove unused code. 
Bug: 12810574
Change-Id: If0ef02a984469a3b6e0c00b1c3c8d98d0d2b5466
 2014-02-10 15:05:11 +09:00
Keisuke Kuroyanagi
8ffc631826 Make PtNode have ProbabilityInfo instead of raw value. 
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
 2014-02-10 15:05:08 +09:00
Tadashi G. Takaoka
cbb0a6de3b Merge "Fix possible NPE while finding device override value from resource" 2014-02-10 05:51:44 +00:00
Tadashi G. Takaoka
bd9887a574 Fix possible NPE while finding device override value from resource 
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
 2014-02-10 14:38:53 +09:00
Tadashi G. Takaoka
f70bcf3d32 Refactor Key constructors 
This is a followup of I76432556ca.

Change-Id: Ie2c8f7c23352a33db28e89ee8e6ebaba9eb760a3
 2014-02-10 11:14:35 +09:00
Tadashi G. Takaoka
541a3d394c Remove unused import 
Change-Id: I3f934de281eefb387026585e678d783a95729720
 2014-02-10 10:22:29 +09:00
Tadashi G. Takaoka
45eb5d924d Allow an empty keySpec for Spacer 
Bug: 12933248
Change-Id: I76432556caf319ce23c1fb7fa3d6b94118e64cf8
 2014-02-09 23:45:23 +09:00
Tadashi G. Takaoka
e5320c1d1f Generate KeyboardTextsTable.java instead of KeyboardTextsSet.java 
Change-Id: Ic48b093dc64b514822cc9daa1ac3d79deb7af089
 2014-02-07 18:56:23 +09:00
Tadashi G. Takaoka
4f72923fa2 Merge "Rename Key.keyLabel attribute to KeySpec" 2014-02-07 09:53:43 +00:00
Tadashi G. Takaoka
4e85476740 Merge "Consolidate keyIcon and code with keyLabel attribute" 2014-02-07 09:53:35 +00:00
Tadashi G. Takaoka
9684b33b69 Rename Key.keyLabel attribute to KeySpec 
Change-Id: Ida48cd9bdbc01fefad651a005084262c0f46c41c
 2014-02-07 18:47:45 +09:00
Tadashi G. Takaoka
a83a1feb62 Consolidate keyIcon and code with keyLabel attribute 
Change-Id: I75fbd348fab5022606ca14552eb03b15af6684c8
 2014-02-07 18:47:22 +09:00
Tadashi G. Takaoka
a9e1db6636 Merge "Decimal number is treated as outputText" 2014-02-07 09:26:04 +00:00
Tadashi G. Takaoka
276b1a2ebc Add debug settings for keypress popup animations 
Bug: 12928125
Change-Id: I49faab754c7d1dcf4a791dfc535d3a78b62ce67a
 2014-02-07 18:09:41 +09:00
Keisuke Kuroyanagi
6422f77e94 Merge "Use native logic to read Ver4 dict." 2014-02-06 13:00:09 +00:00
Keisuke Kuroyanagi
ab6a93773b Use native logic to read Ver4 dict. 
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
 2014-02-06 21:55:37 +09:00
Keisuke Kuroyanagi
fc6d0f8738 Merge "Implement getHeaderInfoNative." 2014-02-06 11:26:49 +00:00
Keisuke Kuroyanagi
fc9ca59cc1 Implement getHeaderInfoNative. 
Bug: 11281877
Bug: 12810574
Change-Id: Ia3d85ae2cfdb486e74b8636a62431eae883c85da
 2014-02-06 18:19:42 +09:00
Tadashi G. Takaoka
3bbd50c36b Use SubtypeLocaleUtils.isRtlLanguage 
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
 2014-02-06 18:15:32 +09:00
Tadashi G. Takaoka
48ea52800a Merge "Consolidate keyOutputText with keyLabel attribute" 2014-02-06 09:14:09 +00:00
Tadashi G. Takaoka
d645db1e37 Merge "Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag" 2014-02-06 09:01:41 +00:00
Tadashi G. Takaoka
a9b67135bd Merge "Parse keyLabel for icon, code, and outputText as well" 2014-02-06 08:38:54 +00:00
Tadashi G. Takaoka
df75444239 Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag 
This change must be checked in together with Iac93eb79fc.

Bug: 12913520
Bug: 12179576
Change-Id: Ic9a40fb0529202893be8ccb6f5abfbbe6d78508c
 2014-02-06 17:28:08 +09:00
Tadashi G. Takaoka
0df462730b Remove unused smiley key definitions 
Change-Id: Icbdfb360abab2964869898949774f47197f6d000
 2014-02-06 16:56:42 +09:00
Tadashi G. Takaoka
d6f147e142 Consolidate keyOutputText with keyLabel attribute 
Change-Id: I90ea2c9d5ce42fabc79599995a2fae1f5f652a6b
 2014-02-06 16:42:57 +09:00
Tadashi G. Takaoka
6193217f5c Parse keyLabel for icon, code, and outputText as well 
Change-Id: I023915b68b4aabd056c2c1eb745876471556e15e
 2014-02-06 16:42:17 +09:00
Jean Chalard
a9e1930a6a Merge "Conditionally store the raw suggestions." 2014-02-06 07:31:22 +00:00
Tadashi G. Takaoka
4a64ad9538 Decimal number is treated as outputText 
Change-Id: I9d4a8ac5dd26a7c41fcfbe1842a40f347a2f2aab
 2014-02-06 16:30:12 +09:00
Keisuke Kuroyanagi
fd018c1588 Merge "Use CombinedFormatUtils to convert dict elements to strings." 2014-02-06 07:29:30 +00:00
Jean Chalard
a49f61f8a7 Conditionally store the raw suggestions. 
Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
 2014-02-06 16:14:41 +09:00
Keisuke Kuroyanagi
b24de426fc Use CombinedFormatUtils to convert dict elements to strings. 
Bug: 11281877
Bug: 12810574
Change-Id: Ib631f75eab73abc9877a7698171c45e8f2fc7600
 2014-02-06 16:09:25 +09:00
Keisuke Kuroyanagi
337dce8074 Merge "Consolidate WordProperty and Word." 2014-02-06 07:02:07 +00:00
Keisuke Kuroyanagi
0c088e2d74 Merge "Unregister DictionaryDumpBroadcastReceiver in onDestroy()." 2014-02-06 06:55:42 +00:00
Keisuke Kuroyanagi
f2d15d6956 Unregister DictionaryDumpBroadcastReceiver in onDestroy(). 
Change-Id: I83a05a8369c2fe2fa7522f18eb00983a0b10dc19
 2014-02-06 15:37:41 +09:00
Keisuke Kuroyanagi
5f5feeba13 Consolidate WordProperty and Word. 
Bug: 11281877
Bug: 12810574
Change-Id: I9dc99188f80f25a8780c1860dab46e4aa80a23e5
 2014-02-06 15:13:33 +09:00
Jean Chalard
058d615121 Remove a redundant comment. 
No need to say this twice.

Change-Id: Ief7ac425037aa2767ee8f21c9552138a9c46afc8
 2014-02-05 22:42:38 +09:00
Jean Chalard
58eed6360d Merge "Stop considering personalization dicts outputs as words" 2014-02-05 13:33:12 +00:00
Jean Chalard
5095fabdd0 Stop considering personalization dicts outputs as words 
Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410
 2014-02-05 21:57:37 +09:00
Keisuke Kuroyanagi
239f7daf4a Merge "Make WeightedString have ProbabilityInfo." 2014-02-05 12:53:14 +00:00
Keisuke Kuroyanagi
df1d3e733e Make WeightedString have ProbabilityInfo. 
Bug: 11281877
Bug: 12810574
Change-Id: I265e3d8654c75766cd0e0d09d67ef62b4566298a
 2014-02-05 21:44:55 +09:00
Keisuke Kuroyanagi
e42380a471 Merge "Separate ProbabilityInfo form WordProperty." 2014-02-05 12:37:49 +00:00
Keisuke Kuroyanagi
75a3df30f6 Separate ProbabilityInfo form WordProperty. 
Bug: 11281877
Bug: 12810574
Change-Id: I0c77d976c915bdf2a2cddabd0cbedc2fb6691c7b
 2014-02-05 21:31:35 +09:00
Jean Chalard
8fb2f6a441 Merge "Fix a flash in the wrong place" 2014-02-05 09:46:44 +00:00
Jean Chalard
9e9e948a70 Fix a flash in the wrong place 
Bug: 7226099
Change-Id: I8f74802b3ae24018fc4176fb2fff2c777ae170b0
 2014-02-05 18:44:24 +09:00
Tadashi G. Takaoka
02a534d13f Merge "Treat a sole "|" as a special case of key label" 2014-02-05 09:32:12 +00:00
Tadashi G. Takaoka
6e5dbdd501 Merge "Add null check to KeySpecParser" 2014-02-05 09:32:04 +00:00
Tadashi G. Takaoka
6a16fa1f10 Merge "Refactor KeySpecParser a bit" 2014-02-05 09:17:01 +00:00
Jean Chalard
b162911fa4 Merge "[HD04] Make the locale mandatory." 2014-02-05 09:16:17 +00:00
Tadashi G. Takaoka
f7d8b8fcbc Treat a sole "|" as a special case of key label 
Change-Id: Ia72c31d15c891fa522935ba9792e88fd5d8ce7f7
 2014-02-05 17:57:44 +09:00
Jean Chalard
bbb6e8f10f Merge "[IL109] Move more code to InputLogic" 2014-02-05 08:50:28 +00:00
Jean Chalard
a6ea33b4d7 Merge "[IL108] Remove some uses of LatinIME in input logic." 2014-02-05 08:49:44 +00:00
Tadashi G. Takaoka
d9c6b33209 Add null check to KeySpecParser 
Change-Id: Ic37db8cbf8f83f753d7381e1edba8eac1ef1ceb1
 2014-02-05 17:49:26 +09:00
Tadashi G. Takaoka
bc9514032a Refactor KeySpecParser a bit 
Change-Id: I1208746f42eb92f937812149033398d8318f9c4e
 2014-02-05 17:43:53 +09:00
Jean Chalard
43cf9076b2 [HD04] Make the locale mandatory. 
Bug: 11281748
Change-Id: I69281b0053bec404c3e3c713ade3f65a140f51b1
 2014-02-05 17:35:25 +09:00
Tadashi G. Takaoka
bb476be4e6 Move key preview related methods to KeyPreviewChoreographer 
Change-Id: Ia8d6b7fa922a4da233bf851b2e94bbd2573a65a3
 2014-02-05 15:41:39 +09:00
Tadashi G. Takaoka
f2749e41e4 Merge "Revert "Move key preview related methods to KeyPreviewChoreographer"" 2014-02-05 06:28:45 +00:00
Tadashi G. Takaoka
32d6c6a400 Revert "Move key preview related methods to KeyPreviewChoreographer" 
This reverts commit 38806940b9.

Change-Id: I185c4d5f5d92dd269f678206ef3ff8316cbce6ed
 2014-02-05 06:27:41 +00:00
Jean Chalard
2bb1c6add9 [IL109] Move more code to InputLogic 
Bug: 8636060
Change-Id: Ib12eacc836e8d39c4165c97a2a287f32f6bf5405
 2014-02-05 14:49:59 +09:00
Jean Chalard
2c01dd00f2 [IL108] Remove some uses of LatinIME in input logic. 
Access the suggestion strip through the interface instead.

Bug: 8636060
Change-Id: Ia8bd705c230f943e309d677ef683b1a2cbe68036
 2014-02-05 14:49:59 +09:00
Jean Chalard
ade1aa55b6 [IL107] Add an interface to access the suggestion view. 
Bug: 8636060
Change-Id: I603af6bcdaa31f64aaaf916784720a133388c737
 2014-02-05 14:49:57 +09:00
Tadashi G. Takaoka
aac53dd7f5 Merge "Move key preview related methods to KeyPreviewChoreographer" 2014-02-05 03:45:08 +00:00
Keisuke Kuroyanagi
c488048634 Merge "Check isEligibleForAutoCommit when batch input is ended." 2014-02-05 03:34:46 +00:00
Tadashi G. Takaoka
38806940b9 Move key preview related methods to KeyPreviewChoreographer 
Change-Id: I18cbbd287313826bc72437c6ebab2915c1d7bc50
 2014-02-05 12:34:06 +09:00
Keisuke Kuroyanagi
8c5c01e981 Check isEligibleForAutoCommit when batch input is ended. 
Bug: 11951198
Change-Id: Ibbe09fa38eaa3ebf8f9b69f744a29db7ac598975
 2014-02-05 11:40:17 +09:00
Tadashi G. Takaoka
66b2fcf2bf Merge "Move some XML attributes to KeyPreviewDrawParams" 2014-02-05 00:51:23 +00:00
Keisuke Kuroyanagi
ad37cddd79 Merge "Add jni interface to get header information from native." 2014-02-04 12:52:50 +00:00
Keisuke Kuroyanagi
f32b2d5c5e Merge "Add a utility method to StringUtils." 2014-02-04 12:47:21 +00:00
Keisuke Kuroyanagi
aaf864db7b Merge "Separate header class from FormatSpec." 2014-02-04 12:42:44 +00:00
Keisuke Kuroyanagi
927aff72bc Add jni interface to get header information from native. 
Bug: 12810574
Change-Id: I2508483bcb3157f04cc1fe13f24f864d301f1f28
 2014-02-04 21:42:09 +09:00
Keisuke Kuroyanagi
53fb86c447 Add a utility method to StringUtils. 
Bug: 12810574
Change-Id: I607803e924b9e99855df7690e67488b2861c120e
 2014-02-04 21:42:06 +09:00
Keisuke Kuroyanagi
b986f78ba8 Separate header class from FormatSpec. 
Bug: 12810574
Change-Id: Iacf1cd05a268bf690ab864b5e32a18a4b0ccc693
 2014-02-04 21:36:04 +09:00
Keisuke Kuroyanagi
866fd42091 Merge "Add dictionary dump buttons in debug settings." 2014-02-04 12:34:32 +00:00
Keisuke Kuroyanagi
36c7a62dff Add dictionary dump buttons in debug settings. 
Bug: 11736680
Bug: 12810574
Change-Id: I1f797b5ac6acf94b40d9698d4535e8f5da2bfb17
 2014-02-04 21:29:09 +09:00
Tadashi G. Takaoka
7d09b56812 Move some XML attributes to KeyPreviewDrawParams 
Change-Id: I0e040b3aed63f8da983fcc51d55b55ac9294a16a
 2014-02-04 19:31:45 +09:00
Tadashi G. Takaoka
f7d682cce1 Merge "Refactor KeyPreviewDrawParams a bit" 2014-02-04 10:14:14 +00:00
Keisuke Kuroyanagi
23c487510a Merge "Check timestamp for each pointer." 2014-02-04 08:26:14 +00:00
Keisuke Kuroyanagi
99b7242f78 Merge "Make dumpAllWordsForDebug() use getNextWordProperty()." 2014-02-04 07:51:00 +00:00
Keisuke Kuroyanagi
ffb12e76b8 Merge "Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken." 2014-02-04 07:46:50 +00:00
Tadashi G. Takaoka
992c521909 Refactor KeyPreviewDrawParams a bit 
Change-Id: Ia1a2c5cd882c2524a2e2f02ae052f0404061b2f7
 2014-02-04 16:10:58 +09:00
Keisuke Kuroyanagi
33fd13bf3c Check timestamp for each pointer. 
Bug: 11325631
Change-Id: I4e296cdeccf21323c5732754e86c3a4075ccf82a
 2014-02-04 14:04:26 +09:00
Keisuke Kuroyanagi
d79fd29f61 Make dumpAllWordsForDebug() use getNextWordProperty(). 
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
 2014-02-04 13:51:49 +09:00
Keisuke Kuroyanagi
941734695b Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken. 
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
 2014-02-04 12:42:14 +09:00
Tadashi G. Takaoka
5be8a59a5a Use "Key popup dismiss delay" to control key preview zoom out animation 
Bug: 12809303
Change-Id: I2db0362a2f8c512145f1cf9326f06e5f922987b8
 2014-02-04 11:43:58 +09:00
Tadashi G. Takaoka
b06e455797 Clear important notice strip 
Bug: 10587358
Change-Id: Ic90e5825200a1d424aac4ba263b252187a203241
 2014-02-03 18:28:21 +09:00
Tadashi G. Takaoka
4d539f2c1e Merge "Fix important notice strip text layout" 2014-02-03 09:14:02 +00:00
Tadashi G. Takaoka
9706f9a2f4 Fix important notice strip text layout 
Bug: 10587358
Change-Id: I9cbdd3b450e05d6d0611a16b6b7fad945918dd5f
 2014-02-03 18:07:19 +09:00
Tadashi G. Takaoka
a2d83dfdc7 Merge "Show important notice dialog" 2014-02-03 08:04:03 +00:00
Tadashi G. Takaoka
342e81e7a6 Show important notice dialog 
Bug: 10587358
Change-Id: I3b4282a1bb183aa901110a4a2fc1b6ed72818aae
 2014-02-03 16:21:53 +09:00
Jean Chalard
80fa64e66b Merge "Don't resume suggestions if suggestions are not requested." 2014-02-03 07:07:14 +00:00
Jean Chalard
5d9be8039c Merge "Have empty suggestions go through setNeutralSuggestions." 2014-02-03 06:45:45 +00:00
Jean Chalard
2cbf152986 Have empty suggestions go through setNeutralSuggestions. 
Bug: 12865205
Change-Id: If17a390c445d0820325a9b16cc4f2f27a361187a
 2014-02-03 15:33:00 +09:00
Jean Chalard
9068fd4e77 Don't resume suggestions if suggestions are not requested. 
Bug: 12832614
Change-Id: I6a9b6d128d7e0324ba59a43cf153a3b54e1d35bf
 2014-02-03 15:20:45 +09:00
Keisuke Kuroyanagi
38f341a2a5 Add a jni method to iterate words in a dictionary. 
Bug: 12810574
Change-Id: I87b13559765f0262dfd06c2ba40d43af6437ea7f
 2014-02-03 14:51:58 +09:00
Yohei Yukawa
08d72c52f9 Merge "Introduce a delay for key-press feedback on the Emoji palette" 2014-02-03 02:14:59 +00:00
Keisuke Kuroyanagi
5ecf74b148 Merge "Extend jni interface to get bigrams in WordProperty." 2014-01-31 11:53:10 +00:00
Keisuke Kuroyanagi
94d9a2309f Extend jni interface to get bigrams in WordProperty. 
Bug: 12810574
Change-Id: Ia4b88d02ea8790a5c47d32376cc0b84c3e071ddd
 2014-01-31 20:32:44 +09:00
Tadashi G. Takaoka
2abe1cedc8 Merge "Add important notice strip" 2014-01-31 11:23:52 +00:00
Tadashi G. Takaoka
e855093f55 Move some methods to MoreKeySpec class 
Change-Id: I025ed15e36ac3113db6a5fccefa0c87f016703fa
 2014-01-31 20:19:48 +09:00
Tadashi G. Takaoka
8a296e43c9 Add important notice strip 
This change is a groundwork to show important notice.

Bug: 10587358
Change-Id: I80aa70d30e2a529b37798f0df2183b41df3ac38a
 2014-01-31 20:07:27 +09:00
Jean Chalard
4e6f72cb80 Merge "[HD03] Straighten out attribute key names in Java." 2014-01-31 08:40:25 +00:00
Tadashi G. Takaoka
7914a97b73 Merge "Move some prefix strings to relevant classes" 2014-01-31 08:11:56 +00:00
Tadashi G. Takaoka
3b4eb03fa1 Move some prefix strings to relevant classes 
Change-Id: I7321ac7820d4eded5f16f2440ffb4f525315b3f4
 2014-01-31 17:09:14 +09:00
Tadashi G. Takaoka
1e40af5ebe Merge "Refactor KeyboardTextsSet class" 2014-01-31 08:05:02 +00:00
Tadashi G. Takaoka
be0d05c5ef Merge "Move important notice version to resource" 2014-01-31 07:37:13 +00:00
Tadashi G. Takaoka
0bae2ab460 Refactor KeyboardTextsSet class 
Change-Id: I0b48c85aa2c291e1e7ee25d61c558700fc677e29
 2014-01-31 16:31:07 +09:00
Yohei Yukawa
94797fb3a6 Introduce a delay for key-press feedback on the Emoji palette 
Currently key-press effect such as highlight and vibration
occur even when a user want to scroll the Emoji palette.
To mitigate this situation, this patch introduces a short delay
for key-press feedback on the Emoji palette.

This is not an ideal solution but should be better than now.

BUG: 11103083
Change-Id: I1fa4514d742eb37f36fef60e6beabbc5eaa1653a
 2014-01-31 15:48:10 +09:00
Tadashi G. Takaoka
d245f6c9e2 Move arrayAsList method to CollectionUtils 
Change-Id: If7c1eb7c802490f19c5d3b81d714362408daf376
 2014-01-31 15:26:05 +09:00
Tadashi G. Takaoka
de76e62b69 Merge "Move some methods to StringUtils" 2014-01-31 06:16:14 +00:00
Tadashi G. Takaoka
639bf62e4f Move some methods to StringUtils 
Change-Id: I29d87fdd65ec879d1c0bdf7e7792a677687c1693
 2014-01-31 14:49:36 +09:00
Jean Chalard
79b2e4d86c [HD03] Straighten out attribute key names in Java. 
Bug: 11281748
Change-Id: I1d813bdacd45bcfd9c4cc73ac1d67c5c89854e86
 2014-01-31 14:46:07 +09:00
Jean Chalard
b0df28f4cc Merge "[HD02] Make the date header attribute mandatory." 2014-01-31 03:58:55 +00:00
Tadashi G. Takaoka
5b8ffad26c Move important notice version to resource 
Bug: 10587358
Change-Id: Ie24fc6c53b15880f4ace991a25223056f03f5eda
 2014-01-31 12:49:36 +09:00
Keisuke Kuroyanagi
748f32feba Merge "Rename UnigramProperty to WordProperty." 2014-01-31 03:06:44 +00:00
Keisuke Kuroyanagi
080a35e959 Rename UnigramProperty to WordProperty. 
Bug: 12810574
Change-Id: If5ddd803948aaf6e491ddcbaa5436fb3af3f7257
 2014-01-31 11:06:42 +09:00
Jean Chalard
a137c21c9c [HD02] Make the date header attribute mandatory. 
Bug: 11281748
Change-Id: I48a6f3d95ca89ced0c51335527201ecabfb7998e
 2014-01-30 18:19:21 +09:00
Tadashi G. Takaoka
776d46a771 Merge "Show "Touch again to save" in system locale" 2014-01-30 09:17:11 +00:00
Tadashi G. Takaoka
9b1a66843d Show "Touch again to save" in system locale 
Bug: 12811156
Change-Id: I928daf17297ec5c526720850d6203cb9af0496ac
 2014-01-30 18:03:23 +09:00
Keisuke Kuroyanagi
7ceee45376 Merge "Fix historical info of bigrams reading." 2014-01-30 08:21:34 +00:00
Tadashi G. Takaoka
bf2f0892a0 Merge "Add ImportantNoticeUtils class" 2014-01-30 08:08:37 +00:00
Tadashi G. Takaoka
a14ddfb5ff Add ImportantNoticeUtils class 
Bug: 10587358
Change-Id: I76673b47aab1579cc1310b6a978d04f874d5bcfe
 2014-01-30 17:04:05 +09:00
Keisuke Kuroyanagi
971bbcf562 Fix historical info of bigrams reading. 
Bug: 12809791
Change-Id: I879279a0d0e1007a7c6cb87a627bf046340dda98
 2014-01-30 16:19:22 +09:00
Tadashi G. Takaoka
d432892f0c Fix Farsi keyboard comma and period 
Bug: 12807701
Change-Id: I49503e9945d97e13d7cc98f54ca071cb935d1e52
 2014-01-30 15:45:23 +09:00
Jean Chalard
0c186c31d2 Merge "[IL106] Inline a now useless method." 2014-01-30 03:47:32 +00:00
Jean Chalard
90c072a5ba Merge "[IL105] Remove more useless arguments" 2014-01-30 03:46:08 +00:00
Jean Chalard
362779d608 Merge "[IL104] Remove useless arguments" 2014-01-30 03:45:15 +00:00
Jean Chalard
e5040f6b0d Merge "[IL103] Save the typed word separately in SuggestedWords." 2014-01-30 03:44:54 +00:00
Keisuke Kuroyanagi
26bd46095a Reading dictionary containing timestamps in Java Side. 
Just skipping historical information fields.

Bug: 11281877
Change-Id: I43d2adaa576b7da11ed3ca54990265dbb6f53b08
 2014-01-29 20:19:24 +09:00
Jean Chalard
ac84fe642e [IL106] Inline a now useless method. 
Bug: 8636060
Change-Id: Ic8e0225206358680aa0de421f17ab443c888036d
 2014-01-29 12:23:40 +09:00
Jean Chalard
fa7075768d [IL105] Remove more useless arguments 
Bug: 8636060
Change-Id: I9e817bb9622c84544a5ca8708e5c1fccad1ed447
 2014-01-29 12:23:26 +09:00
Jean Chalard
084c9961f4 [IL104] Remove useless arguments 
Bug: 8636060
Change-Id: I97a371fe0c6227eb0f03d3e391a33726e6280322
 2014-01-29 12:23:25 +09:00
Jean Chalard
1d2e4f9dcc [IL103] Save the typed word separately in SuggestedWords. 
This helps managing the cases where the typed word is not
in the suggestions. This happens during recorrection.

Bug: 8636060
Change-Id: I6784feb793cae96272a7f1d123a0e3bbb8f03143
 2014-01-29 12:22:21 +09:00
Tadashi G. Takaoka
a454a7b85c Add method to clear user history dictionary for testing 
This change should be checked in together with I19cd689157.

Bug: 12179576
Change-Id: I5cc9f52a37ad6623809a14575f3f4b1cd18725c3
 2014-01-29 12:01:37 +09:00
Tadashi G. Takaoka
005d2454c9 Merge "Remove suggestion_word and suggestion_info layout files" 2014-01-29 01:05:37 +00:00
Yohei Yukawa
be18530acf Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key" 2014-01-28 10:50:23 +00:00
Tadashi G. Takaoka
c2ea3f7dd9 Remove suggestion_word and suggestion_info layout files 
Change-Id: I37fea41cfc6e717ce7e5aa36ad331675fc9e8ce5
 2014-01-28 19:38:35 +09:00
Yohei Yukawa
576f8a5b72 Fix inconsistent behavior with the back-to-the-main-keyboard key 
With this patch, the back-to-the-main-keyboard in the Emoji
palette will be registered as a key-release action instead of
a key-press action, like switch-to-the-emoji-palette in the
main layout. This provides mroe consistent UX when the layout is
switched from the main layout to the Emoji palette then
switched back to the main layout.

BUG: 12464067
Change-Id: Ia0d0185db43234dfcfb7cee2677f3d199fe6ed96
 2014-01-28 19:30:27 +09:00
Jean Chalard
c9cc1b1de5 [IL102] Rename a method 
Bug: 8636060
Change-Id: Ia54afdfab9124aa5c35699e357e63eae66a7557f
 2014-01-28 17:18:02 +09:00
Jean Chalard
4500dedfa9 [IL101] Remove a method 
Bug: 8636060
Change-Id: Ic9c12fc6970987b0e1912e8ae85bed55260d66b5
 2014-01-28 17:18:02 +09:00
Jean Chalard
675f1dbaf0 [IL98] Refactoring of setSuggestedWords 
Bug: 8636060
Change-Id: Iab53df96f2c23bddc6c70c3560b380fbaef1053c
 2014-01-28 17:18:01 +09:00
Jean Chalard
491a6a6f23 [IL100] Pull up a check 
Bug: 8636060
Change-Id: I344ed59f5f55b412880fc6dc70205eecb1e79961
 2014-01-28 17:18:01 +09:00
Jean Chalard
4761d2fb00 [IL99] Migrate some code to InputLogic. 
Bug: 8636060
Change-Id: Ibf1f9c7bdc3fdd872d6c15447fa555434485cc52
 2014-01-28 17:18:01 +09:00
Jean Chalard
eb00023b9b [IL97] Readability improvement 
Bug: 8636060
Change-Id: I6b15c7fb91cd4cf23a993541c19842b51e328f8f
 2014-01-28 17:17:58 +09:00
Tadashi G. Takaoka
95e5e267ac Merge "Suggestion strip honors RTL layout" 2014-01-28 07:52:25 +00:00
Keisuke Kuroyanagi
25270ec540 Merge "Check probability before adding to the user history dict." 2014-01-28 07:35:31 +00:00
Jean Chalard
36fda2bae3 Merge "[IL96] Inline a method" 2014-01-28 07:31:48 +00:00
Keisuke Kuroyanagi
90ac041c9f Check probability before adding to the user history dict. 
Bug: 12764888
Change-Id: I5da3ef21d9d82b7034e7dc9b7d0fdca0d48a49f4
 2014-01-28 16:31:37 +09:00
Jean Chalard
7593f93565 Merge "[IL95] Inline a method that's always called in sequence" 2014-01-28 07:31:31 +00:00
Tadashi G. Takaoka
bcd30bf3e7 Suggestion strip honors RTL layout 
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
 2014-01-28 15:47:54 +09:00
Jean Chalard
86210c7dc7 [IL96] Inline a method 
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
 2014-01-28 15:47:04 +09:00
Jean Chalard
90916143b6 [IL95] Inline a method that's always called in sequence 
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
 2014-01-28 15:47:01 +09:00
Tadashi G. Takaoka
02b087090e Merge "Fix test fails caused by I8bede13c87" 2014-01-28 05:19:53 +00:00
Yohei Yukawa
0272553578 Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete." 2014-01-28 05:06:07 +00:00
Yohei Yukawa
0e04c24a05 Fix inconsistent behavior with the spacebar on the Emoji pallete. 
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.

With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.

Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
 2014-01-28 13:44:31 +09:00
Jean Chalard
ca1c1ddd4e Merge "[IL94] Remove a function and some reordering" 2014-01-28 03:46:28 +00:00
Jean Chalard
9909d6aa49 Merge "[IL93] Refactor a method inside another" 2014-01-28 03:32:52 +00:00
Jean Chalard
cbf54dea49 Merge "[IL92] Straighten out showSuggestionStripWithTypedWord" 2014-01-28 03:32:17 +00:00
Jean Chalard
5a1f837356 Merge "[IL91] Call reorder" 2014-01-28 03:26:23 +00:00
Tadashi G. Takaoka
9ac6c9064d Fix test fails caused by I8bede13c87 
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
 2014-01-28 11:17:47 +09:00
Tadashi G. Takaoka
c2e2b3949b Merge "Add SubtypeLocaleUtils.isRtlLanguage method" 2014-01-28 01:28:47 +00:00
Jean Chalard
5b5e877efe [IL94] Remove a function and some reordering 
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
 2014-01-27 20:38:45 +09:00
Jean Chalard
37e1cc931f [IL93] Refactor a method inside another 
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.

Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
 2014-01-27 20:38:45 +09:00
Jean Chalard
4c6029e530 [IL92] Straighten out showSuggestionStripWithTypedWord 
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
 2014-01-27 20:38:45 +09:00
Jean Chalard
c6367ee64d [IL91] Call reorder 
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
 2014-01-27 20:38:43 +09:00
Jean Chalard
01893b25dd Merge "[IL90] Small refactoring" 2014-01-27 11:18:52 +00:00
Jean Chalard
3f226af439 Merge "[IL89] Inline a function" 2014-01-27 11:18:19 +00:00
Jean Chalard
5b9e54c135 Merge "[IL88] Simple refactoring" 2014-01-27 11:17:54 +00:00
Jean Chalard
8f3e37a631 Merge "[IL87] Remove a call to clearSuggestionStrip" 2014-01-27 11:17:45 +00:00
Jean Chalard
521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard
7aa7e36611 Merge "[IL85] Maybe show punctuations when app completions are null" 2014-01-27 11:17:18 +00:00
Jean Chalard
264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard
7ac542d490 Merge "[IL83] Inline a call" 2014-01-27 11:16:30 +00:00
Jean Chalard
47ff423121 Merge "[IL82] Fix a wrong comment" 2014-01-27 10:11:42 +00:00
Jean Chalard
75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka
c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method 
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
 2014-01-27 19:05:16 +09:00
Jean Chalard
6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard
b084da2ae6 Merge changes I5092942a,I931c553f 
* changes:
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
 2014-01-27 10:00:37 +00:00
Jean Chalard
a3a85e8c2b Merge "[IL78] Move most of onUpdateSelection to InputLogic." 2014-01-27 09:55:08 +00:00
Jean Chalard
d38b0468b0 [IL90] Small refactoring 
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
 2014-01-27 18:42:33 +09:00
Jean Chalard
33ff321d6c [IL89] Inline a function 
We will then refactor the contents of showSuggestionStripWithTypedWord

Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
 2014-01-27 18:42:33 +09:00
Jean Chalard
ca819178a1 [IL88] Simple refactoring 
With this, the value passed to suggestedWords is never null.

Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
 2014-01-27 18:42:33 +09:00
Jean Chalard
d90bdd2187 [IL87] Remove a call to clearSuggestionStrip 
The goal is to remove the function completely.

Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
 2014-01-27 18:42:33 +09:00
Jean Chalard
3b939ed77f [IL86] Simplification and correctness fix. 
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
 2014-01-27 18:42:33 +09:00
Jean Chalard
07eddf3c43 [IL85] Maybe show punctuations when app completions are null 
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.

Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
 2014-01-27 18:42:32 +09:00
Jean Chalard
b2c0388a69 [IL84] Remove a useless call and rename a method 
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
 2014-01-27 18:42:32 +09:00
Jean Chalard
eb190ab32f [IL83] Inline a call 
The coming string of changes is very complicated, so
I'm going to do things really slowly.

Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
 2014-01-27 18:42:32 +09:00
Jean Chalard
17f1528f9e [IL82] Fix a wrong comment 
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
 2014-01-27 18:42:32 +09:00
Jean Chalard
abbd755689 [IL81] Remove a useless test. 
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
 2014-01-27 18:42:32 +09:00
Jean Chalard
f1e5b9b4d1 [IL80] Reverse a test for clarity. 
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
 2014-01-27 18:42:32 +09:00
Jean Chalard
f59487379e [IL79] Some refactoring 
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
 2014-01-27 18:42:29 +09:00
Jean Chalard
10460441db [IL78] Move most of onUpdateSelection to InputLogic. 
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
 2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka
1e4b1300e6 Merge "Refactor SuggestionsStripLayoutHelper class" 2014-01-27 09:36:52 +00:00
Jean Chalard
68d7291a6b Merge "[IL77] Remove refs to Settings from InputLogic" 2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka
148dedbc5d Refactor SuggestionsStripLayoutHelper class 
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
 2014-01-27 18:25:25 +09:00
Jean Chalard
7bee84095e Merge "[IL75] Move the SubtypeSwitcher out of InputLogic." 2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka
829ad708db Merge "Revert "Use ViewCompat support library"" 2014-01-27 09:20:19 +00:00
Jean Chalard
48df380f78 [IL77] Remove refs to Settings from InputLogic 
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
 2014-01-27 18:18:54 +09:00
Jean Chalard
969c06072d [IL75] Move the SubtypeSwitcher out of InputLogic. 
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
 2014-01-27 18:18:27 +09:00
Jean Chalard
c7ef305bbc Try to figure out whether d.quotes open or close. 
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
 2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka
e4692c0050 Revert "Use ViewCompat support library" 
This reverts commit e7ee4fa862.

Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
 2014-01-27 18:14:40 +09:00
Jean Chalard
5cf70a1d44 Merge "[IL74] Remove unused/unwanted arguments to a method." 2014-01-27 08:57:12 +00:00
Yohei Yukawa
0b58617951 Merge "Fix inconsistent behavior with backspace in the Emoji pallete." 2014-01-27 08:11:51 +00:00
Jean Chalard
0fd556ceca [IL74] Remove unused/unwanted arguments to a method. 
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
 2014-01-27 16:48:17 +09:00
Yohei Yukawa
ea8c1c811c Fix inconsistent behavior with backspace in the Emoji pallete. 
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
  the key.

This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
  different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
  key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
  subsequent delete key events when the finger is moved away
  from the key area.

Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
 2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka
f3ca92dd33 Merge "Use ViewCompat support library" 2014-01-27 07:21:41 +00:00
Tadashi G. Takaoka
e7ee4fa862 Use ViewCompat support library 
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
 2014-01-27 16:11:03 +09:00
Ken Wakasa
03283b636c Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939 
some cleanups as well

Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
 2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi
95043145df Merge "Check length of words for personalization dict." 2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi
b7197b705b Check length of words for personalization dict. 
Bug: 12602903

Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
 2014-01-24 16:32:28 -08:00
Ken Wakasa
0acd121083 Fix wrong indents. 
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
 2014-01-24 23:55:33 +09:00
Jean Chalard
b6e128cc05 Merge "[IL69.1] Move a static method to a utility class." 2014-01-24 03:04:12 +00:00
Jean Chalard
1d6e647ac3 [IL69.1] Move a static method to a utility class. 
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
 2014-01-24 11:59:23 +09:00
Jean Chalard
0c72529088 Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer" 2014-01-24 01:55:57 +00:00
Jean Chalard
3aa2043a66 Merge "[IL76] Remove a SuggestionStripView dependency" 2014-01-23 10:06:42 +00:00
Jean Chalard
f16a2a36d2 [IL71.1] Add some javadoc. 
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
 2014-01-23 17:11:47 +09:00
Jean Chalard
a1ed211c4e [IL76] Remove a SuggestionStripView dependency 
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
 2014-01-23 16:25:48 +09:00
Jean Chalard
4173610bc5 [IL66.1] Add a comment 
Followup to IL66

Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
 2014-01-23 16:00:49 +09:00
Jean Chalard
be846fc352 [IL73] Remove all refs to Key and Keyboard in WordComposer 
Please hold my gun while I have this nice cup of tea.
Yes !!

Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
 2014-01-23 15:52:29 +09:00
Jean Chalard
df8310c6e2 Merge "[IL71] Add indices to toCodePointArray." 2014-01-23 06:50:19 +00:00
Jean Chalard
1284e556f4 [IL70] Remove unused arguments 
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
 2014-01-23 15:33:14 +09:00
Jean Chalard
d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord 
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
 2014-01-23 15:32:59 +09:00
Jean Chalard
9da4b49ef6 [IL68] Start refactoring setComposingWord 
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
 2014-01-23 15:15:49 +09:00
Jean Chalard
18638d30c0 [IL71] Add indices to toCodePointArray. 
This is necessary for tests

Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
 2014-01-23 13:11:40 +09:00
Jean Chalard
eb6d41a525 [IL67] Externalize a call to the keyboard switcher 
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
 2014-01-23 13:10:02 +09:00
Jean Chalard
ab80b41a0d [IL66] Remove two accesses to KeyboardSwitcher. 
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
 2014-01-23 13:09:58 +09:00