nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
12632 commits 1 branch 0 tags 363 MiB
Commit graph

12632 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jean Chalard
c2e9c511cb Fix Binary dict tests 
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
 2013-04-15 12:48:16 +09:00
Satoshi Kataoka
6246b7c324 am a94bb198: fix assertion 
* commit 'a94bb198cf13a3729bb992fc9c5bfce779e58469':
  fix assertion
 2013-04-14 20:12:46 -07:00
Satoshi Kataoka
a94bb198cf fix assertion 
Change-Id: I34ff470122aa0f34c66425d2eeae7590187d3074
 2013-04-15 12:03:21 +09:00
Tadashi G. Takaoka
a91da76683 Suppress calling onPressKey and onReleaseKey while detecting gesture 
Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
 2013-04-15 10:59:54 +09:00
Tadashi G. Takaoka
be1232b36f am b12c2af3: Tighten unit test condition of MoreKeysKeyboardBuilder 
* commit 'b12c2af32e09624e1298e0109441b0f4d74b74dd':
  Tighten unit test condition of MoreKeysKeyboardBuilder
 2013-04-14 18:17:25 -07:00
Tadashi G. Takaoka
b12c2af32e Tighten unit test condition of MoreKeysKeyboardBuilder 
Bug: 8601979
Change-Id: Icf584f3b35adce69cc3dfc46f3aacfef05e5dd2a
 2013-04-15 09:58:18 +09:00
Baligh Uddin
a270f90a32 am dc64866c: (-s ours) am 0dbc8c35: am f2ab0adc: Import translations. DO NOT MERGE 
* commit 'dc64866c70f19e1f3613f8ee19f1a602961e0d9d':
  Import translations. DO NOT MERGE
 2013-04-12 17:05:25 -07:00
Baligh Uddin
dc64866c70 am 0dbc8c35: am f2ab0adc: Import translations. DO NOT MERGE 
* commit '0dbc8c3509dc71bfd8ac831b89fe229b9c74f6a7':
  Import translations. DO NOT MERGE
 2013-04-12 17:03:07 -07:00
Baligh Uddin
a5506b53f1 am bfedad23: (-s ours) Merge "Import translations. DO NOT MERGE" 
* commit 'bfedad238f52b873599d68718307c4a8ee98e9eb':
  Import translations. DO NOT MERGE
 2013-04-12 17:00:11 -07:00
Baligh Uddin
0dbc8c3509 am f2ab0adc: Import translations. DO NOT MERGE 
* commit 'f2ab0adc5e3bd8f436aafcea1b396e288c69f7d4':
  Import translations. DO NOT MERGE
 2013-04-12 16:59:36 -07:00
Baligh Uddin
bfedad238f Merge "Import translations. DO NOT MERGE" 2013-04-12 23:56:49 +00:00
Baligh Uddin
a559e767d1 Merge "Import translations. DO NOT MERGE" into jb-ub-latinimegoogle 2013-04-12 23:56:08 +00:00
Baligh Uddin
8515649312 Import translations. DO NOT MERGE 
Change-Id: I2cb68d3f0804a0c9990916a89e079510b465253f
Auto-generated-cl: translation import
 2013-04-12 13:26:13 -07:00
Baligh Uddin
d766bbee7d Import translations. DO NOT MERGE 
Change-Id: I751f337d751b95427c9d142cd29cded80045bd9e
Auto-generated-cl: translation import
 2013-04-12 13:21:41 -07:00
Baligh Uddin
dbff360655 Import translations. DO NOT MERGE 
Change-Id: I7c8b83b352dcc840ee2a8a6f0b8e6d4d28b4e08f
Auto-generated-cl: translation import
 2013-04-12 13:20:47 -07:00
Baligh Uddin
f2ab0adc5e Import translations. DO NOT MERGE 
Change-Id: Ie74fdb8041ac5d7eb5d15a49f9aac834751cc9c2
Auto-generated-cl: translation import
 2013-04-12 13:19:32 -07:00
Kurt Partridge
bfe5c07fda am ededdc6a: Merge "Avoid NPE" 
* commit 'ededdc6a8b6befbb5f21a53d366354ea8c8fd5d9':
  Avoid NPE
 2013-04-12 11:13:44 -07:00
Kurt Partridge
ededdc6a8b Merge "Avoid NPE" 2013-04-12 18:10:49 +00:00
Jean Chalard
8895e5fbea am 128961ad: Fix failing tests 
* commit '128961ade05725564bdc229098c97c6ed66a2e9e':
  Fix failing tests
 2013-04-12 09:09:25 -07:00
Jean Chalard
128961ade0 Fix failing tests 
RichInputConnection#getWordRangeAtCursor may now returning
either a SpannableString or a String. We can't test that with
String#equals(), but TextUtils#equals() does the job for us.

Change-Id: I59ebe54207e92f4d90b49476b64f1e12fd4929cb
 2013-04-12 23:38:36 +09:00
Jean Chalard
41e59b6202 am 2cd1136b: Merge "Remove the dialog to insert words to the dictionary." 
* commit '2cd1136b8ebedc7cf939d7d7546ed753191f8677':
  Remove the dialog to insert words to the dictionary.
 2013-04-12 05:36:50 -07:00
Jean Chalard
2cd1136b8e Merge "Remove the dialog to insert words to the dictionary." 2013-04-12 12:33:24 +00:00
Jean Chalard
cb633e3779 am 91bcf5eb: Merge "Restart suggestions when the cursor moves." 
* commit '91bcf5eb5dcf1f2ff66cfda90832db21bce7e330':
  Restart suggestions when the cursor moves.
 2013-04-12 05:30:26 -07:00
Jean Chalard
991b1ef83e am 02ce3dc2: Fix a bug with bad application completions 
* commit '02ce3dc2d11aba2b521f85223af1f870207b81dc':
  Fix a bug with bad application completions
 2013-04-12 05:30:25 -07:00
Jean Chalard
91bcf5eb5d Merge "Restart suggestions when the cursor moves." 2013-04-12 12:27:50 +00:00
Jean Chalard
02ce3dc2d1 Fix a bug with bad application completions 
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
 2013-04-12 20:53:06 +09:00
Jean Chalard
6a114fa700 Restart suggestions when the cursor moves. 
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.

Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
 2013-04-12 20:49:03 +09:00
Jean Chalard
68b392cc12 am d24f9397: Merge "Make shortcut-only user dict entry non-words." 
* commit 'd24f93971292451c7a16456fecb8eff5deaa2c37':
  Make shortcut-only user dict entry non-words.
 2013-04-12 04:04:52 -07:00
Jean Chalard
907a95c2f1 am fb5869e9: Merge "Add a class to encapsulate getting the metadata URI" 
* commit 'fb5869e9ff378d6834d0eaf970543a2f417c4103':
  Add a class to encapsulate getting the metadata URI
 2013-04-12 04:04:51 -07:00
Jean Chalard
d24f939712 Merge "Make shortcut-only user dict entry non-words." 2013-04-12 11:02:00 +00:00
Jean Chalard
0ea30200b4 am 676c97eb: Merge "Remove voodoo magic." 
* commit '676c97eb2da392abced7d27fffc4fb58abeafbbc':
  Remove voodoo magic.
 2013-04-12 04:01:38 -07:00
Jean Chalard
fb5869e9ff Merge "Add a class to encapsulate getting the metadata URI" 2013-04-12 11:01:36 +00:00
Jean Chalard
676c97eb2d Merge "Remove voodoo magic." 2013-04-12 10:59:47 +00:00
Jean Chalard
d89ed47616 Remove voodoo magic. 
There was a much, much simpler way of achieving the same thing.

Bug: 8583091
Change-Id: I8882f389312caad3b17335672892a31d30cd00bc
 2013-04-12 17:05:43 +09:00
Jean Chalard
6a2a4b8e4d Make shortcut-only user dict entry non-words. 
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
 2013-04-12 16:17:09 +09:00
Jean Chalard
1a51833828 Remove the dialog to insert words to the dictionary. 
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
 2013-04-12 15:58:50 +09:00
Ken Wakasa
78e6104108 am 2daea197: am 47bb8d7d: am 4fffa27d: Fix a native crash in AOSP LatinIME 
* commit '2daea19709cd6c9d844d9ad77076256e2f3967ad':
  Fix a native crash in AOSP LatinIME
 2013-04-11 22:24:28 -07:00
Ken Wakasa
2daea19709 am 47bb8d7d: am 4fffa27d: Fix a native crash in AOSP LatinIME 
* commit '47bb8d7d9cd2dcc8e80f90283e4d9b7d4f68e70b':
  Fix a native crash in AOSP LatinIME
 2013-04-11 22:21:10 -07:00
Ken Wakasa
47bb8d7d9c am 4fffa27d: Fix a native crash in AOSP LatinIME 
* commit '4fffa27d3f620135f61b7dfb447ab3bf2b2367f5':
  Fix a native crash in AOSP LatinIME
 2013-04-11 22:18:36 -07:00
Ken Wakasa
4fffa27d3f Fix a native crash in AOSP LatinIME 
bug: 8597610

Change-Id: I585c629636a52a1ac45b8cc686bc94427bb601df
 2013-04-12 12:53:28 +09:00
Jean Chalard
9613be01de am d0623ad7: Merge "Move some values to a place where they are easier to override" 
* commit 'd0623ad7f3dd22cd9e3a8ee836d8989b6425a438':
  Move some values to a place where they are easier to override
 2013-04-11 19:57:22 -07:00
Jean Chalard
d0623ad7f3 Merge "Move some values to a place where they are easier to override" 2013-04-12 02:53:41 +00:00
Kurt Partridge
bdce031e00 am 2927223e: Merge "Better isolate ResearchLogging data" 
* commit '2927223edde78f495d53b27d26524baa8ade5db6':
  Better isolate ResearchLogging data
 2013-04-11 14:58:44 -07:00
Kurt Partridge
2927223edd Merge "Better isolate ResearchLogging data" 2013-04-11 21:56:01 +00:00
Jean Chalard
8987cccf89 Add a class to encapsulate getting the metadata URI 
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
 2013-04-11 17:52:16 +09:00
Jean Chalard
7ad078e89c Move some values to a place where they are easier to override 
Bug: 8418765
Change-Id: Iff0edd4ed8da9d0d1a6fb9545224b232ba374469
 2013-04-11 17:35:23 +09:00
Tadashi G. Takaoka
3d6b743189 am cd692be1: Merge "Change the default vibration duration to 20msec" 
* commit 'cd692be1e1151c233d0605d5f8eabbf5c3f2b1ab':
  Change the default vibration duration to 20msec
 2013-04-11 01:18:43 -07:00
Tadashi G. Takaoka
cd692be1e1 Merge "Change the default vibration duration to 20msec" 2013-04-11 08:15:29 +00:00
Jean Chalard
2e4352c53b am b5d5190d: Merge "Add some utility functions." 
* commit 'b5d5190debf667b0faf034f73822b4cee923a36c':
  Add some utility functions.
 2013-04-11 00:37:56 -07:00
Jean Chalard
b5d5190deb Merge "Add some utility functions." 2013-04-11 07:35:22 +00:00