nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
14378 commits 1 branch 0 tags 363 MiB
Commit graph

1296 commits

Author SHA1 Message Date
Kurt Partridge
90aaa2d0a5 [Rlog59a] Split logUnits correctly around separators 
Change-Id: I65ecdead7e7bdeb8a5f1748e27068ddbd5d3ce00
 2013-01-10 16:36:18 -08:00
Kurt Partridge
75e69753b7 [Rlog57b] fix logging of reverts 
Change-Id: I07c817061a0cc060197e0fea45195ca07a9bf276
 2013-01-10 15:00:28 -08:00
Tadashi G. Takaoka
50d902ac6f Show final suggested word when batch input is finished 
This change moves dismiss timer of gesture floating preview text from
PreviewPlacerView to KeyboardView.

Bug: 7967461
Change-Id: I0ca5beddc93cb4bc4a405f914d217d37b997402b
 2013-01-10 16:25:05 +09:00
Kurt Partridge
f11c4a9aeb Merge "[Rlog50] capture bigrams properly even with deletions" 2013-01-09 19:52:45 -08:00
Tadashi G. Takaoka
3727a3fd61 Merge "Clean up public helper methods of SettingsValues" 2013-01-09 19:04:46 -08:00
Kurt Partridge
3b95eaf70b [Rlog50] capture bigrams properly even with deletions 
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0

Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
 2013-01-09 16:02:37 -08:00
Jean Chalard
516b63db28 Fix a race condition with backspaces 
And add a test to make sure it stays not-broken.

Bug: 7946604
Change-Id: I996da3d5507d591ec25a13fb57434f39843f1df5
 2013-01-09 18:37:10 +09:00
Tadashi G. Takaoka
d3b0ecec22 Clean up public helper methods of SettingsValues 
Change-Id: I6c6087580b67f497eaaf16900f8df7a4a895b8e3
 2013-01-09 11:23:34 +09:00
Kurt Partridge
9bad176ebe Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly" 2013-01-08 08:10:31 -08:00
Kurt Partridge
b7fb16e8cc Merge "[Rlog27] Refactor LogBuffer" 2013-01-08 07:40:57 -08:00
Tadashi G. Takaoka
ff0735ada8 Make Settings class singleton to manage SettingsValues 
Change-Id: Id30828a141de86d9bcf8bce586d2adb468cc59e1
 2013-01-08 17:48:47 +09:00
Tadashi G. Takaoka
b17b887425 Consolidate VibratorUtils with AudioAndHapticFeedbackManager 
Change-Id: Ica4e3193f369330da62a259c718b779ddf9fbde5
 2013-01-08 15:13:19 +09:00
Kurt Partridge
99f3189645 [Rlog32] ResearchLogger segment motion data around gestures correctly 
multi-project commit with I684ba5fed8c653777942e6b0366113ca40dfa37c

Change-Id: Id3804e6cfa97b4cdde212b8eebc413f76fa4772c
 2013-01-07 20:06:29 -08:00
Xiaojun Bi
28de7223e6 Merge "[mdfp] Refactoring Gesture Floating Preview Text Code" 2013-01-07 17:12:35 -08:00
Xiaojun Bi
d52730a2d7 [mdfp] Refactoring Gesture Floating Preview Text Code 
This change moves gesture preview text code from PreviewPlacerView.java
to separate classes.

Change-Id: Id8d17eff38e714c3b06aafd0b24985a9bd2d2f52
 2013-01-07 10:39:23 -08:00
Tadashi G. Takaoka
f90fc105ab Simplify singleton class initialization 
Change-Id: I16a27f2ed6ea66184bfdc9903180372cd7ea2fd1
 2013-01-07 19:05:31 +09:00
Ken Wakasa
b6ca354431 Small code cleanups 
Multi-project commit with I249d5fbe

Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
 2013-01-07 12:13:42 +09:00
Jean Chalard
f677681330 Fix double input of chars typed on a h/w keyboard 
Bug: 7939324
Change-Id: I11b7af54893cb645f8a06266a0b0ba95dd0b02f9
 2013-01-07 10:03:20 +09:00
Kurt Partridge
f77dd424b0 [Rlog27] Refactor LogBuffer 
Cleanup and prepare for replaying

Change-Id: Ie09e912c6e9c0d7375168c575ccf1cfd9375dd31
 2013-01-03 16:36:32 -08:00
Jean Chalard
864db4b0da A small simplification. 
It's useless to setAutoCorrection(getTypedWord()). Every time the
contents of the word composer are altered, the auto-correction is
reset, and at use time if it's null then the typed word is used
anyway.

Change-Id: I0870657a1ab3f456f376995b27e70703f7a5d23a
 2012-12-28 14:41:28 +09:00
Jean Chalard
997cba7dec Start committing hardware events (B4) 
Essentially this does activate auto-correction with a hardware
keyboard, although a lot of things are still left to implement.
No proximity is used yet which means only missing and excessive
letters are considered. Dead keys are not handled. No combiner
is supported. No suggestions are displayed. Resuming suggestions
does not work correctly with a hardware key (because the view
holds a temporary hardware event 'onKeyPreIme' and the event
from the IME won't be handled until this is handled which won't
happen until after the IME said that it did handle the event).

Bug: 5037589
Change-Id: Idcb5c7b26d56717ed772d53c062362807f11cdae
 2012-12-27 16:17:49 +09:00
Tadashi G. Takaoka
f483225397 Get rid of current subtype and system locale cache from SubtypeSwitcher 
Bug: 7675452
Change-Id: I2121f56964b6d25e8d40f5b8ec67eeae527b2117
 2012-12-27 12:00:38 +09:00
Kurt Partridge
4aff3bf0ea Clean up unnecessary uses of toString() 
Leftover from changing variables from CharSequence to String

Change-Id: I4db43fcb075aa37bf9c5b2a23bad0e4c2d718379
 2012-12-23 18:42:06 -08:00
Kurt Partridge
f763dc5915 [Rlog24] ResearchLogger detect word boundaries in callers above commitText 
multi project commit with I5847d4aba97a7224ae170a7153811c5a11816449

Change-Id: Ie6fbf6f19f0193451fe6f3ddf9d4ef1637a35db1
 2012-12-23 12:33:16 -08:00
Kurt Partridge
13b1be988d Merge "Log LatinIME.commitCurrentAutoCorrection()" 2012-12-23 11:47:47 -08:00
Kurt Partridge
226377e65a Log LatinIME.commitCurrentAutoCorrection() 
Change-Id: Ic46c91374ae0177cafad4579d28d6980af0d8d3a
 2012-12-22 17:32:12 -08:00
Kurt Partridge
ab9f4fd359 Merge "[Rlog7] ResearchLog improve gesture tracking" 2012-12-22 11:50:46 -08:00
Kurt Partridge
f1ce54891f [Rlog7] ResearchLog improve gesture tracking 
- count how many times a gesture is deleted
- count num chars entered by gesture
- change name of fns to reflect capturing gesture information when setting composing text

Change-Id: I1b8ebf9cfcf304e0efd827c8b8e28a4010199728
 2012-12-21 12:33:54 -08:00
Jean Chalard
cff28c5d5d Add skeleton classes for hardware event flow (B1) 
Bug: 5037589
Change-Id: Id8eea0e2bd00dd339a1efb4b0542e4c091a84195
 2012-12-19 17:47:29 +09:00
Kurt Partridge
ce8b139124 Merge "[Rlog5] ResearchLogging change from onFinishInput to onFinishInputView" 2012-12-18 11:34:34 -08:00
Kurt Partridge
8432c1317a Merge "[Rlog3] improve stat recording" 2012-12-18 09:54:05 -08:00
Kurt Partridge
606058f777 [Rlog5] ResearchLogging change from onFinishInput to onFinishInputView 
Change-Id: I7d3bcfe647249e0b8a14ac3d67460c2684f16d8c
 2012-12-17 21:39:54 -08:00
Kurt Partridge
48160f9d84 [Rlog3] improve stat recording 
Change-Id: Ie3b70e6eadc2a9af5ef45ddfad6a3398cea7bfe8
 2012-12-17 17:08:47 -08:00
Tadashi G. Takaoka
f21a491ad8 Show last valid suggestions when gesture typing gets no suggestion 
Bug: 7679566
Change-Id: Ie68c7698144c7576b5814ee35664309bcfdcbf0f
 2012-12-17 16:19:10 +09:00
Tadashi G. Takaoka
b808188b2f Show last valid suggestions when tap typing gets no suggestion 
Bug: 7872809
Change-Id: Ib5a255de7968aba214249c1b934327d248a15efd
 2012-12-17 14:32:18 +09:00
Ken Wakasa
8c15e91344 resolved conflicts for merge of d48d6fee to master 
Change-Id: I21141956135debe737453dba87617671b1716d0a
 2012-12-15 09:44:39 +09:00
Jean Chalard
18d688c94b Use the amended user dictionary word for insertion 
When the user edits a word before adding it to the user
dictionary, the keyboard should replace whatever was
committed before with the amended version.

Bug: 7725834
Change-Id: I1a417be6c5a86d6a96bc2c76aca314ad8f1202a9
 2012-12-14 20:28:22 +09:00
Tadashi G. Takaoka
edbb65be3e Reset composing state at onFinishInputView 
Bug: 7709817
Change-Id: Icac0b8cb28209d98d291d8f00be55e33af5bf696
 2012-12-14 17:48:13 +09:00
Tom Ouyang
fa2d543785 Refactor more keys menu framework (part 1) 
Eliminate use of slower popup window for rendering the more keys menu and more suggestions menu.
These menus are now drawn directly on the preview placer view.

Change-Id: I40638724a6ffde2be4b5d0341d2a5db7ff7be930
 2012-12-07 16:34:25 -08:00
Tadashi G. Takaoka
8e2b34cdb2 Cancel batch input when orientation has been changed 
Bug: 7665231
Bug: 7662486
Change-Id: I7b6095026dbf1b9b2f6d3b29f2ab83c462ab374e
 2012-12-06 14:24:05 -08:00
Jean Chalard
2da8866518 Remove a couple Eclipse and Android Lint warnings 
Change-Id: I0c29c5d2abcbf80759b996d34b534deb083cd7d3
 2012-12-06 21:30:51 +09:00
Ken Wakasa
2b6a1fed76 Method/variable/resource names clean up for the double-space period 
bug: 7664717
Change-Id: I914aa588b863c442c2d360221e3fa0f4c42640e7
 2012-12-05 12:40:10 +09:00
Ken Wakasa
139bd83f0c Add a new option for the double-space period functionality 
bug: 6934756

Change-Id: I94b2d08cac6533e96031d8e97f347e9b5fd72859
 2012-12-04 15:27:22 +09:00
Tadashi G. Takaoka
b5fc0e02d0 Cancel update batch input timer when gesture typing has been canceled 
Bug: 7594165
Change-Id: I9dc42919bd196c249c79668570004d3f541cc9ec
 2012-11-30 16:30:56 +09:00
Tadashi G. Takaoka
85e397cd10 Set additional subtypes before getting current subtype 
Bug: 7594188
Change-Id: I1977acb7189f8eb186b9b20a3e5b64b4aaabf191
 2012-11-28 14:49:38 +09:00
Tadashi G. Takaoka
b3f789799a Cancel gesture typing by sliding out from keyboard 
Bug: 7594165
Change-Id: I7849d763e49b57716e8418fb8b6f90eca3a5d2ec
 2012-11-22 17:49:56 +09:00
Jean Chalard
e36af707c8 resolved conflicts for merge of b7e6bbae to master 
Change-Id: Ic02809190721472d138532d2189328519117e042
 2012-11-21 13:07:31 +09:00
Jean Chalard
ec60d60078 Only add spaces automatically when appropriate. 
Correctly check the variations to determine if we should
add automatic spaces (in manual picks and gestures) or not.

Bug: 7164981
Change-Id: I19e25af839b4062c217113cd804b1473912f22a5
 2012-11-19 19:47:40 +09:00
Ken Wakasa
41a2c10e72 resolved conflicts for merge of 4ad92578 to master 
Change-Id: I29ad9f0ba357e39889e30c9ebfcf61f9d08ee4ef
 2012-11-17 11:33:48 +09:00
Ken Wakasa
f9ff4fb5da Merge "Revert "Only add spaces automatically when appropriate."" into jb-mr1.1-dev 2012-11-16 18:00:15 -08:00
Ken Wakasa
5986931fcb Revert "Only add spaces automatically when appropriate." 
This reverts commit 6ce66d1c7d

Change-Id: I90004a5fea0bc7999ecf8742f883ff4dac264d8a
bug: 7565414
 2012-11-16 17:49:22 -08:00
Marco Nelissen
ea23a28557 resolved conflicts for merge of 6f42cf1d to master 
Change-Id: I054bb0cfba9de06473100010a76e2f3d9c2c1180
 2012-11-16 11:23:33 -08:00
Jean Chalard
191d49ae8a Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev 2012-11-15 19:09:04 -08:00
Jean Chalard
6ce66d1c7d Only add spaces automatically when appropriate. 
Bug: 7164981
Change-Id: Id672104a0fda99c52923913fb0e40c3a1ead4787
 2012-11-15 17:57:16 +09:00
Tadashi G. Takaoka
0dfb89b41e am eea28db3: am d4886ff5: am 929bfdd0: Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 
* commit 'eea28db3333a734bf73e688b8335245929d5f322':
  Update shift state only when input field is restarted
 2012-11-14 16:34:42 -08:00
Tadashi G. Takaoka
929bfdd059 Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev 2012-11-14 16:29:43 -08:00
Tadashi G. Takaoka
d0725a6842 Update shift state only when input field is restarted 
Bug: 7482766
Change-Id: Ifdfa110c44b95acfbcd3e0aa34f675c70b7d7285
 2012-11-14 18:44:43 +09:00
Tadashi G. Takaoka
4a3d4620fc Merge "Fix language switch key behavior" 2012-11-14 01:42:12 -08:00
Tadashi G. Takaoka
d62be28515 Fix language switch key behavior (DO NOT MERGE) 
Bug: 7075923
Change-Id: If139411db4aa65eed64337bf2a79387cfcd04496
 2012-11-14 18:29:01 +09:00
Tadashi G. Takaoka
1931c1cab1 Fix language switch key behavior 
Bug: 7075923
Change-Id: I306e1ff5d9f873541e84e1fafb64b9473947f623
 2012-11-14 18:27:00 +09:00
Jean Chalard
80d7d32424 am d2116eb2: am 7d34763e: am fac619a3: Merge "Don\'t restrict reset composing state to non-identical setText" into jb-mr1.1-dev 
* commit 'd2116eb2ea7d08e81b7efe5e342772ffcd8a7efc':
  Don't restrict reset composing state to non-identical setText
 2012-11-12 23:48:20 -08:00
Jean Chalard
1b909c2846 Resolve conflicts for merge of 3a9ba17f to master" 
Change-Id: I8a1a84a81745a708f63e4211267c4afc3a6b8e49
 2012-11-13 16:34:23 +09:00
Jean Chalard
fac619a34c Merge "Don't restrict reset composing state to non-identical setText" into jb-mr1.1-dev 2012-11-12 23:00:12 -08:00
Jean Chalard
0e84041bf7 Refactor all phantom-space-inserted spaces in one place 
Bug: 7164981
Change-Id: If1635c212b2d5d9cf51f5fb074f3b20dd7ec7b2a
 2012-11-13 12:53:55 +09:00
Jean Chalard
61cc2a3391 Don't restrict reset composing state to non-identical setText 
Bug: 7497063
Change-Id: Ifbd5c37408131867458fd921bdef46ef90d81478
 2012-11-12 18:34:18 +09:00
Tadashi G. Takaoka
eaaee28647 Merge "Enhance ImfUtils to InputMethodManagerWrapper class" 2012-11-11 22:43:07 -08:00
Tadashi G. Takaoka
6fbbab3b84 Enhance ImfUtils to InputMethodManagerWrapper class 
Change-Id: I6ff86ee819a446dd3ed5f9c3400d23564027b020
 2012-11-12 15:23:43 +09:00
Jean Chalard
01d47b8096 Fix a logic flaw. 
This test is seriously wrong : although we do have a method that
does exactly the right thing, this looks at a very specific, unrelated
variable state in hope it happens to be set only in the relevant
cases by the play of logic.
I don't think this changes anything concretely, as the assumption
was probably true in the practice ; still, this code is very hard to
read and prone to unexpected breakage.

Change-Id: I77ab576f90762429fcc752df31ed30e1c81871dc
 2012-11-09 19:16:37 +09:00
Ken Wakasa
710d06cea9 Suppress dictionary pack support when IS_EXPERIMENTAL is true 
Change-Id: If8813cb989c1fa8744a3bf36e8514ced3c8f46a3
 2012-11-09 15:03:31 +09:00
Ken Wakasa
43f579e9f6 am 4eef5101: am aa5d6fe0: am 9cc22c45: am 5d2556b9: Reset the IME if requested by the app. 
* commit '4eef51016adc4e103fa65d944a0ab31527ddced8':
  Reset the IME if requested by the app.
 2012-11-08 06:22:02 -08:00
Ken Wakasa
5d2556b932 Reset the IME if requested by the app. 
Specifically, reset the KeyboardState to the main Alphabet layout in
LatinIME.onStartInputViewInternal() if a keyboard layout set doesn't get
reloaded in the method.

Please note TextView.setText() calls up resetInput(), then the IME should
reset with it.

bug: 7482086

Note that bug: 6851364 needs to be revisited.

Change-Id: I5d448c10963d3dd952dd13cb587085ec7b014e69
 2012-11-07 01:09:26 +09:00
Tadashi G. Takaoka
24ab8055aa Move isInvalidCordinates() method to Constants class 
Change-Id: Iad1464c299ad6055af1db1ff7978e5cd9a14750f
 2012-11-01 13:12:58 +09:00
Tadashi G. Takaoka
c7318bbc0b Fix possible NPE 
Bug: 7398904
Change-Id: I6b7aba7a9bf52ca494cb4390b19525c98790bd49
 2012-10-29 18:40:37 +09:00
Tadashi G. Takaoka
240871ecaf Move code point constants from Keyboard to Constants class 
Change-Id: Iee01d4d2b916d0b584531104ac865ae6e6370a3d
 2012-10-29 16:04:20 +09:00
Satoshi Kataoka
6067b9e1bd am ef5f88f3: am 5e118c4c: am 60dea36d: Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
* commit 'ef5f88f33e432284c958fafe18f891a10f77e1f9':
  Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
 2012-10-25 19:31:27 -07:00
Satoshi Kataoka
60dea36daf Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN 
Bug: 7393485
Bug: 7272829
Change-Id: I873e8d99486c734e76484526631a90fc55e91c86
 2012-10-25 20:00:46 +09:00
Jean Chalard
751f3dc0e1 am 6fe6f38d: am d39e6435: am f960eb18: Don\'t put spaces after characters that don\'t take one 
* commit '6fe6f38d8af09b24e40a6e01eae919820cd04c16':
  Don't put spaces after characters that don't take one
 2012-10-22 21:46:43 -07:00
Jean Chalard
f960eb186d Don't put spaces after characters that don't take one 
Bug: 7393639
Change-Id: I1245a7b5077e554642838d6856ce269ca7f91988
 2012-10-23 12:28:28 +09:00
Tadashi G. Takaoka
7f77aed507 Merge "Replace useless CharSequence to String" 2012-10-22 14:27:35 -07:00
Tadashi G. Takaoka
15f6d4ae34 Add @UsedForTesting and @ExternallyReferenced annotations 
Bug: 7268357
Change-Id: I0b7e0c19f04af9ae30874d0a4c26ad81bc80be8c
 2012-10-22 11:18:43 -07:00
Tadashi G. Takaoka
bc464e2952 Replace useless CharSequence to String 
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
 2012-10-22 11:03:28 -07:00
Tadashi G. Takaoka
8e360c68f1 Move AudioAndHapticFeedbackManager from LatinIME to KeyboardSwitcher 
Bug: 7313372
Change-Id: I9bd3275f57ed3f5c2c4a95768443af505513ee97
 2012-10-17 19:39:16 -07:00
Jean Chalard
c5dc32ac59 am b37e87e7: am 63b3fc0d: am 15142588: Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 
* commit 'b37e87e7d50725f20a6b2f8484fc25cc7db3134f':
  Have "no whitespace before cursor" upon gesture trigger phantom space
 2012-10-16 18:12:50 -07:00
Jean Chalard
1514258824 Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev 2012-10-16 18:06:11 -07:00
Jean Chalard
e91d495c53 Have "no whitespace before cursor" upon gesture trigger phantom space 
Bug: 7359291
Bug: 7357758
Bug: 7197651
Change-Id: Ia805a87e922739ae0a06978a3bf00d91c94b6c51
 2012-10-17 09:36:07 +09:00
Jean Chalard
fa3d984d1b am 60211f0d: am 2631fe4c: am 6686e63f: Honor automatic shift turned off for gestures 
* commit '60211f0d250ca931788d32d5a69c880f75ef7d49':
  Honor automatic shift turned off for gestures
 2012-10-16 17:28:18 -07:00
Jean Chalard
6686e63f21 Honor automatic shift turned off for gestures 
Bug: 7354129
Change-Id: Ia02336e8cea2f04b629edbe74b7815cce0d7fad6
 2012-10-17 05:41:06 +09:00
Ken Wakasa
fc62882591 Fix a small typo 
Change-Id: I813d97b9453f8aa7aae99bd165336b1e5a81dc6a
 2012-10-07 12:05:23 +09:00
Tadashi G. Takaoka
792980d4aa Avoid calling switchToLastInputMethod when other IMEs are in effect (DO NOT MERGE) 
Bug: 7299050
Change-Id: Ife6721a5fcbc4872bd36ffd8a8b81b04d73aebec
 2012-10-06 19:01:36 +09:00
Tadashi G. Takaoka
c6ff7c42d9 Add SuggestedWords.isEmpty() method 
Change-Id: I0fcb104a6a81aee4b99f5ee848eba7495630dc7d
 2012-10-03 15:09:10 +09:00
Tadashi G. Takaoka
5f5f7825e7 am 4d009dbc: am ace7d128: am d445b56c: Fix possible NPE caused while monkey test 
* commit '4d009dbc514cd77eb22e4162e4ae7ea852e1b77e':
  Fix possible NPE caused while monkey test
 2012-10-02 22:44:57 -07:00
Tadashi G. Takaoka
d445b56ce1 Fix possible NPE caused while monkey test 
Bug: 7269036
Change-Id: I9054b33ad3c8996cac3ee5f0e9c01ba8ceea4971
 2012-10-03 14:33:52 +09:00
Tadashi G. Takaoka
aec5cc8476 Avoid calling switchToLastInputMethod when other IMEs are in effect 
Bug: 7268389
Change-Id: I4d960cbf063002b4dc0ea813c966366b56c0346d
 2012-10-02 17:29:15 +09:00
Jean Chalard
574b80aace Remove debug prints. 
Bug: 7226098
Change-Id: Ibacb740022a6af56c9d555d6797dd402a89f6ca4
 2012-10-01 17:03:15 +09:00
Tadashi G. Takaoka
58fe5a421f Fix gesture detection algorithm 
This change also
  * Introduces adaptive gesture detecting threshold for time domain in addition to length domain.
  * Tunes the parameters for detecting gesture after fast typing.
  * Fixes a bug in dismissing gesture floating preview text.
  * Cleanup debug messages

Bug: 7218902
Change-Id: Iafccd872c6efe0c3b5ae65fa40b04c80d9f139c7
 2012-09-28 22:47:55 +09:00
Tadashi G. Takaoka
a28a05e971 Cleanup: Make some classes as final 
Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
 2012-09-27 19:03:30 +09:00
Jean Chalard
0eef4b1e6f Merge "Add suggestion span upon starting a gesture." into jb-mr1-dev 2012-09-24 04:30:32 -07:00
Jean Chalard
6a58bb7ac9 Add suggestion span upon starting a gesture. 
Bug: 7196761
Change-Id: If60cb809b205159ced1887f94b7caf9775fcf3bb
 2012-09-24 20:25:46 +09:00
Jean Chalard
88985bfa2e Merge "Fix a bug where the cursor pos wouldn't be tracked correctly" into jb-mr1-dev 2012-09-24 03:41:48 -07:00
Jean Chalard
72c5d32888 Fix a bug where the cursor pos wouldn't be tracked correctly 
This would cause
Bug: 7208199

Change-Id: I8474985bfe349e1530b27bc98842937627bbe4e0
 2012-09-24 19:33:42 +09:00
Jean Chalard
6efe788494 Set punctuation suggestions at start if activated 
Bug: 7218468
Change-Id: I9f8c1f13dc26cedb95b65279a34a825021dfa72a
 2012-09-24 17:27:03 +09:00
Jean Chalard
fff8613df0 Fix a race condition with shift 
Bug: 7062092
Change-Id: Ie1984673e9ffc9291d9650ec38ce99031ad93585
 2012-09-24 15:07:52 +09:00
Jean Chalard
b4e74cfc87 Auto correct on gesture when typed word is 1 char long 
Bug: 7178462
Change-Id: I779d8ee4a957a9d1fdcc80d33257a98965dec7b8
 2012-09-20 16:14:16 +09:00
Satoshi Kataoka
87cecf7db6 Log for geometric input 
Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f
 2012-09-19 17:45:27 +09:00
Jean Chalard
e4783f95b2 Mark 2 resolved TODOS as such (A14) 
Change-Id: Ifbb731f5c825675436d079db4ffbae657d71f8da
 2012-09-18 18:49:17 +09:00
Jean Chalard
5822323514 Remove useless code (A12) 
All this code is done inside the StringUtils or RichInputConnection
classes, where it's more logical. Since the IPC call is entirely
gone now, it's no use having these guards inside Latin IME.

Change-Id: Id324567e7458aed12b6f21d7114be3bd39725f15
 2012-09-18 16:16:33 +09:00
Jean Chalard
90a9127244 Take space state into account for caps (A11) 
Bug: 6950087
Change-Id: I8a1bca24db64b4dd54db8ac74d90cf43cbdddab6
 2012-09-18 16:16:28 +09:00
Jean Chalard
252da38fcd Take locale into account for caps (A10) 
Bug: 4967874
Change-Id: Ic7ce7b2de088308fa00865c81246c84c605db1e5
 2012-09-14 19:42:05 +09:00
Jean Chalard
a3f06baa57 Merge "Do not auto-correct upon starting a gesture." into jb-mr1-dev 2012-09-14 03:11:51 -07:00
Jean Chalard
b29efecd26 Merge "Fix a bug with open parens and some other chars" into jb-mr1-dev 2012-09-14 02:30:36 -07:00
Jean Chalard
7e4ad33a65 Fix a bug with open parens and some other chars 
A space would be inserted after an open parenthesis if
it's typed after a manual pick.

Bug: 7167687
Change-Id: Ic49d09c34747117ccfbdbb8c66f634d88d4a45b0
 2012-09-14 18:23:35 +09:00
Tadashi G. Takaoka
f035649cb6 Asynchronously look up dictionary for gesture input 
Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280
 2012-09-14 02:12:11 -07:00
Jean Chalard
eda096538b Do not auto-correct upon starting a gesture. 
We decided to revert this UI decision after negative feedback.
Indeed, if you use to gesture but tap just one word, chances
are it's because you know you do NOT want a dictionary word.

Bug: 6965241
Change-Id: I85fdfab3c1cf1d3c0fd3e95908e01bdf56bccbba
 2012-09-14 17:52:54 +09:00
Jean Chalard
2427f578c8 Merge "Import TextUtils.getCapsMode to fix it internally (A1)" into jb-mr1-dev 2012-09-13 02:57:35 -07:00
Jean Chalard
9d1c73ffd8 Import TextUtils.getCapsMode to fix it internally (A1) 
This should have on effect at all on behavior,
except an increase in performance.

Bug: 4967874
Bug: 6950087
Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
 2012-09-13 17:46:39 +09:00
Jean Chalard
5ed88457bf Make onUpdateSelection much more resilient to race conditions. 
This is pretty much as strong as it gets. It should be
impossible to get false positives and nearly impossible to
get true negatives with this new code.

Bug: 6981089
Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
 2012-09-13 17:35:26 +09:00
Jean Chalard
28d765ed90 Make Latin IME aware of its surrounding text. 
This is a preparatory change for
Bug: 4967874
Bug: 6617760
Bug: 6950087

Change-Id: I3abf8e45c0d02c42491421f108370220134b9602
 2012-09-12 17:54:16 +09:00
Jean Chalard
ac25fcac71 Display punctuation suggestions on cursor move 
...if punctuation suggestions are requested.

Fixes the symptom, but not the root cause of
Bug: 6981089

Change-Id: I683a7451c99457829cb4e5a762f43548ff89a535
 2012-09-04 19:54:55 +09:00
Kurt Partridge
58eb4d9f27 ResearchLogger no longer offers option to disable logging 
Bug: 6188932
Change-Id: I0b9474216080f3820438c09f89b0b6c6c102c69d
 2012-08-30 22:51:56 -07:00
Jean Chalard
a05a0f2077 Allow Latin IME to cancel smiley-auto-correct consistenly 
This change makes Latin IME behave consistently with regards
to other auto-correction cancellations in cases of auto-correction
cancellation after smiley-triggered auto-correction. That is,
pressing the smiley key when the keyboard signals it's about to
auto-correct will get the auto-correction there plus a smiley,
and pressing backspace will cancel the auto-correction, and
pressing backspace again will delete the smiley.

Bug: 7067593
Change-Id: Ia7eef70a5d06b8b9afa1f1fbb0ed1dbc21a3059f
 2012-08-29 16:49:39 +09:00
Jean Chalard
6c70b92003 Auto-correct after smileys and gestures. 
Bug: 6936790
Bug: 6965241
Change-Id: I1f61327eb5591960c280e425df9cd86b9c52f5d6
 2012-08-27 18:54:05 +09:00
Kurt Partridge
d573bad5bd Merge "ResearchLogging capture full n-gram data" into jb-mr1-dev 2012-08-22 10:41:10 -07:00
Tadashi G. Takaoka
9fc6af325e Fix SubtypeSwitcher initialization path 
This change also removes the reference of LatinIME from
SubtypeSwitcher.

Bug: 7026856
Change-Id: I78a266f3682b11f09b49bbcdcdb6aee713e6af37
 2012-08-22 16:05:34 +09:00
Kurt Partridge
bf653996ea ResearchLogging capture full n-gram data 
- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ic70ccb6c2e11eb02d887821434b44daa3eb7a3e2

Bug: 6188932
Change-Id: I731d6cff6539e997874f723b68bdb0d9b651b937
 2012-08-21 22:37:33 -07:00
Tadashi G. Takaoka
1f05cf6dab Remove GCUtils utility class 
Change-Id: Ia666aeb10c155d69763faf7f01ceca113b9b4653
 2012-08-22 12:34:22 +09:00
Tadashi G. Takaoka
c3f78c9057 Remove KeyboardSwitcher reference from ResearchLogger 
Change-Id: I671a83c19977fda358c8e8a730e22ee155f65512
 2012-08-22 12:14:52 +09:00
Kurt Partridge
94e7f4bef9 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with I05496cfd762e9a41c42c50099143f1efc0a3d8a2

Bug: 6188932
Change-Id: I424abb2e437901262a9620255493916b7c3ff74b
 2012-08-21 17:13:36 -07:00
Jean Chalard
324cc1dbe6 Merge "Tell the shift mode to the word composer." into jb-mr1-dev 2012-08-21 04:38:27 -07:00
Jean Chalard
adbd9ae105 Tell the shift mode to the word composer. 
Bug: 6950087
Change-Id: Ifab9d6d075af398c6468d081216488712f8a53fb
 2012-08-21 20:27:42 +09:00
Tadashi G. Takaoka
ac78633be2 Rename and consolidate some constants 
Change-Id: I7863936cca18b28bf0117afcbcf544a5fd7f185d
 2012-08-21 17:54:53 +09:00
Tadashi G. Takaoka
6785b90727 Remove touch coordinate from pickSuggestionManually 
Change-Id: I33b1b4bc6fdfd263c4b2bb7125c07b4bddcf3c9f
 2012-08-21 17:13:45 +09:00
Kurt Partridge
48643b0e0d Merge "Revert "ResearchLogger log RichInputConnection"" into jb-mr1-dev 2012-08-20 10:18:40 -07:00
Kurt Partridge
adb591e75b Merge "Revert "ResearchLogging capture full n-gram data"" into jb-mr1-dev 2012-08-20 10:18:30 -07:00
Kurt Partridge
35c11842a7 Revert "ResearchLogger log RichInputConnection" 
This reverts commit 1964ffb3f4

Change-Id: Ie43e7ac828faa91e1824a255bb3ecf6c8222d4e8
 2012-08-20 10:17:45 -07:00
Kurt Partridge
3d35908749 Revert "ResearchLogging capture full n-gram data" 
This reverts commit 221e756fd7

Change-Id: Iefc4e4e27ddc925d4a4634627b0467bd4ee2a66e
 2012-08-20 10:17:40 -07:00
Kurt Partridge
752c53760c Merge changes I568c90d4,I4667f8f6 into jb-mr1-dev 
* changes:
  ResearchLogging capture full n-gram data
  ResearchLogger to track simple statistics
 2012-08-20 08:47:45 -07:00
Kurt Partridge
461f1942f9 Merge "ResearchLogger log RichInputConnection" into jb-mr1-dev 2012-08-20 08:47:33 -07:00
Jean Chalard
fb087a95f9 Fix capitalization, part 1 
The case this fixes is typing "Ah.\n" in gmail for example

Bug: 6950087
Change-Id: Ia4bf3a57dde49b9c9d47d315e9f85b7ffc7ee6e3
 2012-08-20 13:51:27 +09:00
Kurt Partridge
221e756fd7 ResearchLogging capture full n-gram data 
DO NOT MERGE

- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
  in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
  about privacy.
- Moved LogUnit out from ResearchLogger

multi-project change with Ie2bc79fd7fe6b951b24771e94b8d4ca21989af65

Bug: 6188932
Change-Id: I568c90d4af07e7c759c1e7fc64b716bd8c7b4ae5
 2012-08-17 21:44:07 -07:00
Kurt Partridge
1964ffb3f4 ResearchLogger log RichInputConnection 
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.

In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.

multi-project change with Ib71f841044ec1072610ab5638a5edfce29b7c05b

DO NOT MERGE

Bug: 6188932
Change-Id: I9ec7500a5b18bfe1a5a5bb1e5bf21c43351fc59e
 2012-08-17 21:44:06 -07:00
Ken Wakasa
e46d12927e Fix NPE in LatinIME.addToUserHistoryDictionary() 
bug: 7007063
Change-Id: Ie3e2f77dcbc597dda0c0df9a970336e5aac0edba
 2012-08-18 00:04:33 +09:00
Jean Chalard
e234aed428 Refresh editor info when the text field attributes changes. 
For some reason we get a "restarting" flag from the browser
some times when the input field is different. The attributes
however are not the same, so we can detect that and reload
appropriately.

Bug: 6946793
Change-Id: I6762dae6f41db690497b026a707d9cc89c840b34
 2012-08-15 18:32:59 +09:00
alanv
0538493309 Fix the build. 
Change-Id: I744f6232e81981ab694d3d1e92bab5fd6efa46c0
 2012-08-14 15:34:29 -07:00
Charles Chen
dd7f79097a Merge "Change accessibility event type for app-driven speech." into jb-mr1-dev 2012-08-14 14:33:32 -07:00
alanv
5f312c9c15 Change accessibility event type for app-driven speech. 
Bug: 6614400
Change-Id: I0ef309b7f3f35bf37b4664ea599c9e6ffb1a4ab8
 2012-08-10 13:51:17 -07:00
Tadashi G. Takaoka
2be2d77664 Update dictionary availability at onStartInputView 
This is a follow up of I7901c0f9489b4deb79314c2c903b138611bfd78e

Change-Id: I38c22e886db247c402a964e3ddd10b09a461151c
 2012-08-09 16:09:54 +09:00
Tadashi G. Takaoka
8335c59ea7 Fix NPE and don't call UI API from non-UI thread 
This change also reverts I29ec3e9f10484f30288fac76f0c45b3707bc2259

Bug: 6956969
Bug: 6891020
Bug: 6947253
Change-Id: I7901c0f9489b4deb79314c2c903b138611bfd78e
 2012-08-09 11:55:41 +09:00
Tadashi G. Takaoka
79eefda0d3 Add SuggestInitializationListener to BinaryDictionary.resetMainDict() 
Change-Id: I4c01f172ddb2ca60fa6e604384610c90b76e5457
 2012-08-08 15:55:26 +09:00
Tadashi G. Takaoka
27e48447a4 Lingering gesture floating preview text a bit 
Bug: 6936095
Change-Id: I873343e9aa6afdf6bdb223795f03232509b012a7
 2012-08-07 13:54:42 +09:00
Tadashi G. Takaoka
0a524de3df Separate updateSuggestionStrip from commitTyped 
The commitTyped() called updateSuggestionStrip(), and that led to call
Suggest.getSuggestedWordsForTypingInput() even after a batch input was
started because WordComposer.commitWord() reset the batch input state.

Bug: 6932442
Change-Id: If645b1ef0343aa1e21ca71a9275b40c6c3be13df
 2012-08-06 14:31:01 +09:00
Jean Chalard
8ee4b35c70 Cleanup unused code 
The Italian dictionary has been amended to contain words that
include apostrophes, and accordingly the apostrophe is now
excluded from word separators in Italian.
This code was only used for Italian, and in the general case
it does the wrong thing; it was only needed by limitations of
the old dictionary.

Bug: 6929108
Change-Id: I7ff4615e01899a1cebed2c4c51679cd0746740fe
 2012-08-04 01:15:04 +09:00
Tadashi G. Takaoka
622d6a5b1b Using hardware accelerated drawing 
When Canvas has been hardware accelerated, don't use offscreen bitmap.

Bug: 6872994
Change-Id: I1121f76377991692bc29ebeedbfbfa1b2a12dbb7
 2012-08-03 20:46:10 +09:00
Ken Wakasa
fb955693d4 Enable hardware accelerated drawing for SoftInputWindow of LatinIME 
Taking advantage of Ib6a8bda46223ce1153f32834daf02a820d16136e

bug: 6872994
Change-Id: I799b25b6509980dd9f039bead9bc926b42cbb040
 2012-08-02 15:11:31 +09:00
Jean Chalard
f68fe7a9c9 Don't forward phantom space state on stripper input 
Bug: 6890540
Change-Id: I923b24e3bc17e7b923be4940ad739b58dca24a1f
 2012-07-31 01:48:10 +09:00
Tadashi G. Takaoka
ca57f5ba40 Move gesture preview parameters to KeyboardView attributes 
Change-Id: Iff9d6b485e202656fc869f3ff4d94575ad2c186f
 2012-07-30 20:10:48 +09:00
Tadashi G. Takaoka
47e2bf3298 Add advanced options to turn on/off the gesture trail and text preview 
Bug: 6883053
Change-Id: I601718afb37289108b45ef68626c7c315edca35d
 2012-07-30 15:54:27 +09:00
Jean Chalard
6fc72cae20 Fix a bug with autocaps 
Port of Iece016f4

Bug: 6886405
Change-Id: I148c296d8a3841c40b6748e73ed2b0fff473b627
 2012-07-27 21:09:25 +09:00
Jean Chalard
aa906c36aa Handle correctly the restarting argument 
Bug: 6851364
Change-Id: Ie939a43b8527a76aec213b702d3d850717f22a81
 2012-07-26 21:57:15 +09:00
Tadashi G. Takaoka
941f222c21 Merge "Remove unused setProximityCorrectionEnabled() methods" 2012-07-25 19:54:40 -07:00
Tadashi G. Takaoka
c4376db0f0 Remove unused setProximityCorrectionEnabled() methods 
Change-Id: I03aa6608ee435b36377de41684162b303740f571
 2012-07-25 20:37:36 +09:00
Tom Ouyang
2f81757c3a Add dynamic floating preview for incremental gesture recognition. 
Change-Id: I7ba7ac24aa96a0ff19267997c5b58853079bc6dc
 2012-07-25 19:40:55 +09:00
Tadashi G. Takaoka
0657b9698a Update gesture mode state when dictionary gets available 
Bug: 6860204
Change-Id: I840b7bf1983ab92fa4e0b180129176539e96409f
 2012-07-25 16:11:53 +09:00
Tadashi G. Takaoka
369e54cc33 Add Suggest initialization finish listener 
Bug: 6860204
Change-Id: I1e4c03c99415cd9bdea5a8556ff4093c33f0f508
 2012-07-25 09:55:22 +09:00
Tadashi G. Takaoka
506259396f Merge "Update gesture suggestions even when suggestions strip is off" 2012-07-23 03:45:21 -07:00
Tadashi G. Takaoka
7575ac7054 Update gesture suggestions even when suggestions strip is off 
Bug: 6852483
Change-Id: I873ae0f2e3bc863e989629f8bc0cc90ee33a4920
 2012-07-23 19:37:00 +09:00
Jean Chalard
c0f0ceeccf Merge "Fix a bug with the 'add to dict' hint popping up too much" 2012-07-23 03:20:01 -07:00
Jean Chalard
491d451e38 Fix a bug with the 'add to dict' hint popping up too much 
Not having a main dictionary is not sufficient reason to display
the hint. If the user already added the word to the dictionary then
we shouldn't be displaying it again, even if we don't have a main
dictionary for the current language.

Bug: 6829798
Change-Id: I6b081f51c82ef395fe2e394fd3167363e743ea6f
 2012-07-23 18:32:13 +09:00
Tadashi G. Takaoka
259905ba90 Rename suggestion strip related methods 
Change-Id: I942692bbc2e577482f353d875405c4658a1102fc
 2012-07-23 18:04:02 +09:00
Tadashi G. Takaoka
4702671ea4 Rename SuggestionsView to SuggestionStripView 2012-07-23 15:37:43 +09:00
Tadashi G. Takaoka
c8e45ddb03 Rename LatinKeyboardView to MainKeyboardView 
Change-Id: I8f3123b8d727c7beb72e226f80c17794f89c8b60
 2012-07-23 12:11:43 +09:00
Kurt Partridge
3c233bf1a5 ResearchLogger feedback form 
- also cleaned up RLog menu

multi-project commit with If0fd4fef89d390073e6939d5188ed5696866cb33

Bug: 6188932
Change-Id: I4f66f13bd366b4e8bde742ccd0704f812c6d33f9
 2012-07-22 18:36:24 -07:00
Kurt Partridge
6b966160ac ResearchLog refactor 
- new package: com.android.inputmethod.research

multi-project commit with Ic0a5744f3160d13218addd589890623c0d120ffc

Bug: 6188932

Change-Id: Icf8d4a40a5725401799be6e209a640d99a5f34c4
 2012-07-20 15:06:51 -07:00
Kurt Partridge
0df487678e ResearchLogger: make logging more reliable (esp on startup) 
Bug: 6188932
Change-Id: I692e427ba2e6da7bb15f48208304c4a034392a22
 2012-07-19 09:00:21 -07:00
Tadashi G. Takaoka
10102f02af Change the batch input methods of KeyboardActionListener 
This change also removes the reference of SuggestedWords from
GestureTracker and KeyboardActionListener.

Change-Id: I25ef8756007986abf99a931afd665bbfe6fa387f
 2012-07-18 18:53:36 +09:00
Tom Ouyang
eea34598bf Merging minimal gesture input 
Change-Id: Iee6ae48bb6309c2867b5d2e344fe7d86dfabd654
 2012-07-13 19:32:18 +09:00
Jean Chalard
2c5cf744e5 Increase encapsulation (A118) 
showSuggestions is only ever called by updateSuggestionsOrPredictions.
It only feels natural that, when called with a 0-sized or null
suggestion list, it clears the suggestions.

Change-Id: I5b52bc9151afca1bb6c6f0a7f81e3255add92177
 2012-07-12 15:58:16 +09:00
Kurt Partridge
0d54692ce4 Merge "intentional logging" 2012-07-10 21:20:47 -07:00
Kurt Partridge
223d671ffc intentional logging 
- separate ResearchLog from ResearchLogger
- fix abort menu to explicitly indicate re-enabling of logging
- auto flush entries every 5s
- conform to new suggestedWords class

multi-project change with I9fe1f8fe59d5891daa4ca84af157f36fb1bb17dc

Bug: 6188932

Change-Id: I7e99390f934481c6ed9cea2b259944583edda5bb
 2012-07-10 18:44:18 -07:00
Jean Chalard
5e573a1f0a Remove a useless parameter (A91A) 
Change-Id: I1d1758048649ef337875a5141d825569af7ad38c
 2012-07-10 19:31:36 +09:00
Jean Chalard
a5bb353de9 Cleanup visibility in LatinIME (A80) 
Many methods were public but could have been private: change them
to private. Also, add a comment above public methods that don't
come from the IMF to make it clearer why they are necessary.

Change-Id: I574154b015d09c0f8542b81763f497691afdc3c1
 2012-07-10 18:05:15 +09:00
Jean Chalard
728c0cb251 Remove useless code (A79) 
We postUpdateSuggestionStrip right away anyway - this only
makes the suggestion strip blink

Change-Id: I2ebd933e9a4c804ef1e8c62ccdaf4953a98a792e
 2012-07-10 16:41:49 +09:00
Jean Chalard
09fdd30e52 Simplification (A78) 
Change-Id: I622503af858ef419e94a17f182253cb03da00462
 2012-07-10 16:41:47 +09:00
Jean Chalard
c466cd3f99 Move a test (A77) 
Change-Id: I417bd5f1318696aaa39fee18f3e750ea5c231f6b
 2012-07-10 14:24:33 +09:00
Jean Chalard
32f5384fc9 Pull up common code in the consolidated method (A76) 
Change-Id: I3ebecec37b49e139c243cf9da8bfe491e7ddada1
 2012-07-10 14:22:12 +09:00
Jean Chalard
e4498929b0 Simple refactoring (A75) 
Change-Id: Id19efc5d279616da52667fa70326b86aba70d4a0
 2012-07-09 15:06:16 +09:00
Jean Chalard
d579f1aefc Consolidate methods that do the same thing (A74) 
Change-Id: I6e7c3aba2b40ecefa483c9680978bc806368e96e
 2012-07-09 15:06:16 +09:00
Jean Chalard
347a80f793 Tiny refactoring (A73) 
If !mWordComposer.isComposingWord(), then mWordComposer.getTypedWord()
will always return an empty string.

Change-Id: Ife66d0abc44c743cbc30d31724e833cda168fd5c
 2012-07-09 15:06:16 +09:00
Jean Chalard
7a422a0142 Cleanup again (A72) 
Change-Id: Id3765bf9826cc2c7ca70158cda53c75dc58f51c6
 2012-07-09 15:06:16 +09:00
Jean Chalard
37eaa24b5a Simplification (A71) 
Change-Id: I7a91d84291bea581ecc8ec5b29b9a87ccec76e7d
 2012-07-09 15:06:16 +09:00
Jean Chalard
dc1b84d96c Defer testing composition to a later time (A70) 
This is not exactly the same logically speaking, because it's
theoretically possible that the composing state changed in between
the message enqueueing and it's retrieval. However in the practice,
if the composing state changed the message *must* have been
cancelled and resent, else the behavior breaks. So this actually
is more robust, and removes some obscure requirements on the
calling code.

In the practice, it should also make the cancelUpdateSuggestionStrip
message useless, although this change does not yet remove it.

Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
 2012-07-09 15:06:16 +09:00
Jean Chalard
a6757f400a Code simplification (A69) 
Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
 2012-07-09 15:06:16 +09:00
Jean Chalard
8f9c9377fc Consolidate two methods (A68) 
Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
 2012-07-09 15:06:15 +09:00
Jean Chalard
146bd2e456 Pass the value we really want to pass to update functions (A67) 
Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
 2012-07-09 15:06:15 +09:00
Jean Chalard
60dbe0be43 Preparative change to pass a boolean with known value (A66) 
Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
 2012-07-09 15:06:15 +09:00
Jean Chalard
853f4221ab Merge "Remove useless processing (A65)" 2012-07-08 23:05:11 -07:00
Tadashi G. Takaoka
36311cacd6 Merge "Extend onTextInput to be able to inject suggestions" 2012-07-06 03:40:03 -07:00
Tadashi G. Takaoka
4be03befe3 Extend onTextInput to be able to inject suggestions 
Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
 2012-07-06 19:36:11 +09:00
Jean Chalard
a3dee0d062 Merge "Fix a bug where spaces would be forgotten" 2012-07-06 02:09:28 -07:00
Jean Chalard
4fde56b818 Fix a bug where spaces would be forgotten 
Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
 2012-07-06 17:51:10 +09:00
Jean Chalard
8e36e5102e Remove useless processing (A65) 
We just resetted the composing state - updating suggestions
is sure to yield no results. We may as well not call
updateSuggestions at all.
We should however still cancel any lingering timer from a
previous input field, to avoid this useless processing.

Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
 2012-07-06 16:28:42 +09:00