522d1575da
Import translations. DO NOT MERGE
...
Change-Id: If26d287c68a6fed1d5a8ecf6566ccd5cdfb99104
Auto-generated-cl: translation import
2014-02-21 02:20:21 -08:00
6ddefc567e
Import translations. DO NOT MERGE
...
Change-Id: Id288919148957318b18962b09e61ebe76a10c2b7
Auto-generated-cl: translation import
2014-02-21 02:13:34 -08:00
ad508d029f
Merge "Remove corrupted ver4 dictionaries."
2014-02-21 09:03:19 +00:00
d24a99cff6
Fix: file descriptor leaking.
...
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.
Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
2014-02-21 17:25:34 +09:00
2a5ec00301
Don't trim newer inputpointers with old data
...
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
2014-02-21 16:43:11 +09:00
d73044a249
Add ImportantNoticeDialog
...
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
2014-02-21 16:36:15 +09:00
d934fb43ad
Remove corrupted ver4 dictionaries.
...
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
2014-02-21 15:09:37 +09:00
fe39d576dc
Support versioned important notice
...
This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
2014-02-21 09:54:08 +09:00
3b4c1d3056
Change a heuristic and add a log.
...
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.
Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.
Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
2014-02-20 23:49:20 +09:00
1b3a142cac
Merge "Fix a bug where suggestions would not be updated."
2014-02-20 14:46:35 +00:00
6f50c95887
Fix a bug where suggestions would not be updated.
...
Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
2014-02-20 23:32:04 +09:00
a118d19f6c
Merge "Don't distrust the cursor pos so much as to bug on IPC delay"
2014-02-20 14:22:48 +00:00
3c84eb8822
Don't distrust the cursor pos so much as to bug on IPC delay
...
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
2014-02-20 23:13:14 +09:00
d36328cecf
Add test only methods to test personalized dicts.
...
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20 22:20:43 +09:00
485c1ec685
Merge "Add final and volatile for members of InputLogic."
2014-02-20 10:12:45 +00:00
afdb6f011b
Merge "Add user history dictionary decaying test."
2014-02-20 10:05:20 +00:00
b063377e77
Add final and volatile for members of InputLogic.
...
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
2014-02-20 18:55:19 +09:00
0bc66daae3
Add user history dictionary decaying test.
...
Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20 18:36:46 +09:00
a514ea7e1b
Merge "Check all enabled IME's subtypes to enable personalization."
2014-02-20 09:33:21 +00:00
d10e2d85af
Merge "Throw IOException when dict header cannot be read."
2014-02-20 09:33:08 +00:00
afd9b62f00
Throw IOException when dict header cannot be read.
...
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
2014-02-20 18:11:17 +09:00
475f9f35b6
Merge "Comments improvements"
2014-02-20 08:22:39 +00:00
1672ccbbb6
Change important notice version preference file
...
This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.
Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
2014-02-20 16:50:34 +09:00
78db739cdb
Fix build due to Ib4c472756f
...
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
2014-02-20 16:16:57 +09:00
ad2cf220a9
Merge "Remove a call to a deprecated method"
2014-02-20 06:40:46 +00:00
251ed3b358
Merge "Revert "Turn off personalization default settings""
2014-02-20 06:26:48 +00:00
c2ba73ab41
Revert "Turn off personalization default settings"
...
This reverts commit 0a4ac795d6
2014-02-20 06:06:29 +00:00
6b23749dec
Check all enabled IME's subtypes to enable personalization.
...
Bug: 13067743
Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
2014-02-20 15:05:37 +09:00
c44b7312ad
Remove a call to a deprecated method
...
...that would cause a crash
Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
2014-02-20 14:40:38 +09:00
f16d63c644
Tweak key popup animation parameters
...
Key popup show up start scale 98%
Key popup dismiss end scale 94%
Key popup show up duration 17ms
Key popup dismiss duration 53ms
Bug: 11518021
Change-Id: Icfde99969163f05cfaed1050ea074545d44db13b
2014-02-20 14:20:44 +09:00
be8ad77ebb
Comments improvements
...
Typo fixes and clarifications
Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
2014-02-20 13:29:43 +09:00
bb17354041
Merge "Import translations. DO NOT MERGE"
2014-02-19 22:16:21 +00:00
34fb962513
Call PersonalizationDictionarySessionRegistrar.init().
...
Wrongly removed in I1f50cb137b6054dc9.
Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
2014-02-19 23:27:14 +09:00
d102eb80da
Remove personalization dicts for multilingual users.
...
Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
2014-02-19 21:00:27 +09:00
920c40fe45
Use AlertDialog.setOnDismissListener
...
AlertDialog.Builder.setOnDismissListener is supported from API 17.
Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
2014-02-19 19:05:06 +09:00
ed616083dd
Merge "Turn personalization on when important notice dialog is displayed"
2014-02-19 09:46:15 +00:00
6abc852255
Turn personalization on when important notice dialog is displayed
...
This change must be checked in together with Ifde70b1d3b.
Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
2014-02-19 18:36:32 +09:00
3a7ed5fdfe
Merge "Fix IllegalStateException raied by monkey"
2014-02-19 08:27:37 +00:00
9fd7447d6c
Fix IllegalStateException raied by monkey
...
Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
2014-02-19 16:40:52 +09:00
03105290d8
Merge "Throw exception when the header cannot be read."
2014-02-19 04:59:47 +00:00
776bba098b
Merge "Turn off personalization default settings"
2014-02-19 04:25:04 +00:00
97a40d030f
Throw exception when the header cannot be read.
...
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
2014-02-19 12:35:58 +09:00
e49e007bb2
Fix: Use old suggest after reloading.
...
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
2014-02-19 12:34:09 +09:00
0a4ac795d6
Turn off personalization default settings
...
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.
Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
2014-02-19 12:08:50 +09:00
80d413caff
Merge "Straighten out database cursors behavior."
2014-02-18 11:09:38 +00:00
28e0b24965
Merge "Fix a bug where the cache would be out of sync"
2014-02-18 10:58:50 +00:00
b8ff8ca9d9
Straighten out database cursors behavior.
...
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.
It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.
Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
2014-02-18 19:58:23 +09:00
fe92c174ea
Fix a bug where the cache would be out of sync
...
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.
Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18 19:55:54 +09:00
783dabb812
Merge "Cleanup."
2014-02-18 09:54:33 +00:00
63be066544
Cleanup.
...
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
2014-02-18 17:07:46 +09:00
266c8c5b1d
Merge "Some cosmetic fixes in LatinIME.java"
2014-02-18 06:08:34 +00:00
12ff7da19d
Some cosmetic fixes in LatinIME.java
...
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
2014-02-18 14:56:50 +09:00
db21fad18f
Merge "Avoid crashing when the Content URL is not found."
2014-02-18 05:35:54 +00:00
9967f0a1d0
Avoid crashing when the Content URL is not found.
...
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.
Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
2014-02-18 14:27:58 +09:00
0f8134dc40
Merge "Import translations. DO NOT MERGE"
2014-02-18 04:58:14 +00:00
0d32643e69
Merge "Cosmetic fixes"
2014-02-18 03:28:04 +00:00
2312c1954f
Cosmetic fixes
...
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
2014-02-18 12:17:24 +09:00
cc05f468ca
Merge "Refactor InputAttributes a bit"
2014-02-18 02:25:46 +00:00
3a73aa4182
Import translations. DO NOT MERGE
...
Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709
Auto-generated-cl: translation import
2014-02-17 18:19:28 -08:00
af78cea362
Import translations. DO NOT MERGE
...
Change-Id: I2dc0e76dc4c696c1a7e9748b55e1badd273aea09
Auto-generated-cl: translation import
2014-02-17 18:17:03 -08:00
06fbfc4951
Refactor InputAttributes a bit
...
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
2014-02-18 11:11:36 +09:00
affdd36423
Set neutral suggestions should be called after load settings
...
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
2014-02-18 11:04:00 +09:00
f0f4e9fc16
Update important notice version even when user select Settings
...
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
2014-02-18 00:14:30 +09:00
782c9fee6b
Merge "Don't resume suggestion on links."
2014-02-17 11:46:54 +00:00
7a7aeffcdc
Don't resume suggestion on links.
...
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
2014-02-17 20:36:16 +09:00
d91cd9919e
Merge "Catch exceptions we can't do anything about."
2014-02-17 11:33:39 +00:00
da0edf86c4
Merge "Stop overriding InputView.dispatchTouchEvent"
2014-02-17 10:55:11 +00:00
5cd732f8c5
Stop overriding InputView.dispatchTouchEvent
...
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
2014-02-17 19:51:47 +09:00
a149731a67
Catch exceptions we can't do anything about.
...
This also abstracts away the "package deactivated" case for
simpler and safer code.
Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
2014-02-17 18:49:31 +09:00
1e9897b0c7
Merge "Consider non-breaking spaces separators."
2014-02-17 09:45:41 +00:00
891e4860f8
Merge "Stop overriding SuggestionStripView.dispatchTouchEvent"
2014-02-17 09:20:54 +00:00
c051ee7025
Consider non-breaking spaces separators.
...
Bug: 13056209
Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
2014-02-17 18:20:46 +09:00
e32548f32d
Stop overriding SuggestionStripView.dispatchTouchEvent
...
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
2014-02-17 18:11:10 +09:00
1751615f7d
Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent"
2014-02-17 08:26:38 +00:00
3dd6bdf931
Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()"
2014-02-17 08:25:57 +00:00
800ab579a9
Remove unnecessary override of MainKeyboardView.dispatchTouchEvent
...
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
2014-02-17 17:09:06 +09:00
4c628b9d5b
Merge "Don't show important notice on password field"
2014-02-17 08:04:11 +00:00
20ddd4cff5
Add InputMethodSubtypeCompatUtils.isAsciiCapable()
...
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
2014-02-17 16:08:33 +09:00
ce78a2d8ab
Don't show important notice on password field
...
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
2014-02-17 15:38:43 +09:00
4f4fb5ef34
Merge "Use the same label of switch-to-alphabet key on Emoji palette"
2014-02-17 06:13:39 +00:00
4c680e7bcf
Merge "Add go to "Settings" button to important notice dialog"
2014-02-17 06:13:26 +00:00
28c02b400f
Add go to "Settings" button to important notice dialog
...
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.
This change must be checked in together with Id115d89ba9.
Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
2014-02-17 14:57:04 +09:00
fe39aec08a
Use the same label of switch-to-alphabet key on Emoji palette
...
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
2014-02-17 14:54:39 +09:00
b092aef4a7
Merge "Remove key show up and dismiss animation"
2014-02-17 03:22:48 +00:00
c9072dc8da
Remove key show up and dismiss animation
...
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
2014-02-17 12:10:09 +09:00
ffde401b65
Fix PC/QWERTY phone layout
...
Bug: 13025426
Change-Id: I980832ccab7fb7700ca8b01d4f05e920b3f45582
2014-02-17 09:27:47 +09:00
95d16561e0
Remove unused code.
...
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
2014-02-15 17:39:24 +09:00
0fc93fe445
Implement PatriciaTriePolicy::getNextWordAndNextToken().
...
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
2014-02-15 17:39:20 +09:00
85fe06e759
Merge "Remove unused argument from readDictionaryBinary."
2014-02-14 10:37:56 +00:00
36d606fcbc
Use 16sp text to show important notice title
...
Bug: 10587358
Change-Id: Ib840cb71d9e87282ea0d13839dbf2a2da2081d5f
2014-02-14 19:10:47 +09:00
8e3a1d0f89
Remove unused argument from readDictionaryBinary.
...
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
2014-02-14 19:02:15 +09:00
b136b7dd6f
Merge "Add sanity check to KeybaordTextsTable for debugging"
2014-02-14 09:52:36 +00:00
53a237323a
Add sanity check to KeybaordTextsTable for debugging
...
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
2014-02-14 18:51:03 +09:00
fdc4173213
Merge "Fix a view-related crash"
2014-02-14 09:19:34 +00:00
a7e3e74ddd
Fix a view-related crash
...
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
2014-02-14 18:03:34 +09:00
3c4f05dd66
Remove unused label_tab_key
...
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
2014-02-14 17:40:53 +09:00
e422c94634
Fix test resource declarations and parsing a bit
...
Change-Id: I882a41b2934c48f4405f1ea5bf4d6ad41e87322c
2014-02-14 16:27:26 +09:00
d4469756be
Merge "Special punctuations for Arabic and Persian"
2014-02-14 07:20:25 +00:00
17993ed4ef
Merge "Fix null KeyDetector reference"
2014-02-14 07:17:33 +00:00
d508b676cf
Special punctuations for Arabic and Persian
...
This change also removes duplications from tablet punctuation suggestions
Bug: 12640318
Change-Id: I221922484027d6b91e2f23a6bf60a18766f3a13c
2014-02-14 16:11:50 +09:00
32a7e079e0
Merge "Add PunctuationSuggestions class"
2014-02-14 06:19:52 +00:00
42e4ea7d6c
Add Kazakh (kk) subtype
...
The Kazakh (kk) subtype has been temporarily disabled by Ic44ef378a9.
Bug: 9698902
Change-Id: Ib2096cdf79fd45d36f5504be55f76416ba11445d
2014-02-14 15:16:16 +09:00
a273319c59
Add PunctuationSuggestions class
...
This change must be checked in together with I366c477516.
Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
2014-02-14 14:13:39 +09:00
4197c6f3ab
Merge "Show the suggestion strip for the important notice"
2014-02-14 04:07:46 +00:00
ef8a03685f
Fix null KeyDetector reference
...
This change must be checked in together with I737c266c45.
Bug: 13011041
Change-Id: Ia3d25be6de47fa16ab7156a25641e53a23948ff4
2014-02-14 11:42:09 +09:00
362ab36cf0
Fix a null object reference crash on Emoji Palette
...
Do nothing if the current EmojiPageKeyboardView is null.
BUG: 13006906
Change-Id: I169b70122ec939075b5be033953b48762fd528fc
2014-02-14 10:36:31 +09:00
5f9f4b929b
Merge "Fix indent."
2014-02-14 01:26:48 +00:00
5e09958056
Merge "Backward compatibility hack : send delete when empty."
2014-02-13 10:09:41 +00:00
2c48846903
Backward compatibility hack : send delete when empty.
...
Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.
This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.
Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
2014-02-13 18:41:54 +09:00
7ae6721ffa
Remove RTL aware !code and add corresponding !text
...
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
2014-02-13 17:32:09 +09:00
3cb77678f5
Fix Armenian switch to alphabet key text
...
Bug: 7963631
Change-Id: If5768c761ec96d3404900b0c017abc2317cce8d4
2014-02-13 17:26:16 +09:00
0af6d988a7
Merge "Optimize KeyboardTextsTable"
2014-02-13 08:22:58 +00:00
0fe4d00068
Optimize KeyboardTextsTable
...
This change counts all occurrences of each string resource and sort
those in descending order of the occurrence.
Change-Id: I726402157feb0d436a54bd0a7252acd17fd711f9
2014-02-13 17:11:00 +09:00
36b8962a9a
Merge "Fix UserHistoryDictionaryTests"
2014-02-13 07:49:51 +00:00
32c8d58cef
Merge "Fix showing all suggestions when the top suggestion is long"
2014-02-13 07:17:31 +00:00
0cda0e8a9c
Fix UserHistoryDictionaryTests
...
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
2014-02-13 16:16:44 +09:00
d23cef69c6
Merge "Import translations. DO NOT MERGE"
2014-02-13 06:43:25 +00:00
4f8a8f125e
Fix showing all suggestions when the top suggestion is long
...
This change also fixes Bug#12982404; displays the suggestion word
using entire suggestions strip if there is only one suggestion.
Bug: 12564279
Bug: 12982404
Change-Id: I51806b90c3ee34a2072880245d4e33f7be273c8f
2014-02-13 15:22:36 +09:00
e0a425681c
Merge "Fix a test."
2014-02-13 05:20:58 +00:00
cf03ff02b1
Fix a test.
...
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.
Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
2014-02-13 14:01:37 +09:00
8dd47029f1
Merge "Refactor dictionary constructor"
2014-02-13 04:55:16 +00:00
c3cfabd0eb
Merge "Dump settings."
2014-02-13 04:26:52 +00:00
870d89b1a8
Refactor dictionary constructor
...
This change must be checked in together with I3923d5af2a.
Bug: 12994268
Change-Id: I19de6efbdfa3b6c6c69a20a836e53962fd5737de
2014-02-13 13:23:55 +09:00
a973e0926a
Import translations. DO NOT MERGE
...
Change-Id: Ibf72865a393c8e5e41ef6420e7131bbcddfb18e5
Auto-generated-cl: translation import
2014-02-12 16:04:35 -08:00
cfe26bbcde
Fix indent.
...
This is a follow up for the previous commit to fix indent.
BUG: 12964092
Change-Id: I0530b1c0dae26ac736ddcc6d426ec6ce57bce4d1
2014-02-13 01:58:58 +09:00
367a35d377
Dump settings.
...
Bug: 10315296
Change-Id: Ieb020a23886514b3ba97611d8a6001f32b322f63
2014-02-12 22:53:15 +09:00
50fbe4cc09
Merge "Cancel keydown events immediately once the view starts scrolling"
2014-02-12 10:21:08 +00:00
4c259866c4
Cancel keydown events immediately once the view starts scrolling
...
The motivation of this patch is to make sure a user never feel
haptic feedback when scrolling the Emoji palette. In order to
achieve it, EmojiPageKeyboardView#releaseCurrentKey() should
be called whenever (delayed) keydown events should be canceled.
This patch wires up ViewPager.OnPageChangeListener#onPageScrolled
with EmojiPageKeyboardView#releaseCurrentKey() so that delayed
keydown events will be canceled immediately once the ViewParger
starts scrolling.
BUG: 12964092
Change-Id: Iea8c3e090bb16a8622e6b4a850af2bf963aa77d0
2014-02-12 18:56:08 +09:00
5a885e85c2
Merge "Keep showing key preview even when keyboard has been changed"
2014-02-12 09:40:55 +00:00
dd6ba4b184
Merge "Fix bug in KeyPreviewChoreographer.dismissKeyPreview"
2014-02-12 09:13:37 +00:00
8adedbf47c
Show the suggestion strip for the important notice
...
Bug: 10587358
Change-Id: Ia060a9ca9dfc2e7fe0750536a9fea3b9cc5900c4
2014-02-12 17:30:04 +09:00
075158ccd0
Keep showing key preview even when keyboard has been changed
...
Bug: 12979147
Change-Id: I7e1f60686d6a8a0fca463174abb0a45f1f62ca43
2014-02-12 15:09:03 +09:00
7e9b0b42bf
Fix bug in KeyPreviewChoreographer.dismissKeyPreview
...
Bug: 12979147
Change-Id: Ibc60b4565badaebe760194f27984b02f9f966996
2014-02-12 14:50:56 +09:00
351c8e6185
Merge "Make importance notice dialog cancel able"
2014-02-12 04:25:59 +00:00
b05b183f60
Merge "Increase CHAR LIMIT for personalized setting."
2014-02-12 04:11:16 +00:00
29c92c40e0
Increase CHAR LIMIT for personalized setting.
...
Bug: 12189366
Change-Id: I19764b3aaf97319ac841460ac2a6ab1571d3ea2b
2014-02-12 12:23:22 +09:00
7ffac033ac
Make importance notice dialog cancel able
...
Bug: 10587358
Change-Id: I7415a6f33e6b5542718164fea1555095d23233e5
2014-02-12 11:59:43 +09:00
2089afd257
Merge "Import translations. DO NOT MERGE"
2014-02-11 21:33:06 +00:00
6e1710f0d4
Merge "Optimize text resources' ordering a bit"
2014-02-11 13:33:42 +00:00
d495cc36b7
Merge "Get nicer output of make-keyboard-text"
2014-02-11 12:43:32 +00:00
8bfd6100d9
Optimize text resources' ordering a bit
...
Change-Id: I19382f1d9a4b6be173d1e9f62edd727ea987fa20
2014-02-11 21:41:55 +09:00
ed509695a4
Get nicer output of make-keyboard-text
...
Change-Id: I6d30127aac2198d55b1335002f7a66b4aaebf82d
2014-02-11 21:41:21 +09:00
d8e4928372
Import translations. DO NOT MERGE
...
Change-Id: I55e2d607627ba6f1f27c8cc60ffe8416f250638e
Auto-generated-cl: translation import
2014-02-10 17:55:21 -08:00
3df8bcb7a9
Revert "Display predictions when the cursor is moved after a word."
...
This change is lacking some comments and break some unit tests.
It needs more work.
This reverts commit 38d31a5e79
2014-02-10 14:24:30 +00:00
38d31a5e79
Display predictions when the cursor is moved after a word.
...
Bug: 12951777
Change-Id: I744b98df6679edd34ca3c1392e38597325935932
2014-02-10 23:07:00 +09:00
f9e5b1ee4f
Merge "Show important notice strip"
2014-02-10 12:18:10 +00:00
8dda9e480b
Show important notice strip
...
Bug: 10587358
Change-Id: I1af3faa59afb2fc4cb90176acff1c2b0b1ba369c
2014-02-10 21:15:35 +09:00
ea24abf878
Merge "Remove unused code."
2014-02-10 07:19:53 +00:00
2ef87aee3e
Merge "Make PtNode have ProbabilityInfo instead of raw value."
2014-02-10 06:10:51 +00:00
69ccac6e51
Remove unused code.
...
Bug: 12810574
Change-Id: If0ef02a984469a3b6e0c00b1c3c8d98d0d2b5466
2014-02-10 15:05:11 +09:00
8ffc631826
Make PtNode have ProbabilityInfo instead of raw value.
...
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
2014-02-10 15:05:08 +09:00
cbb0a6de3b
Merge "Fix possible NPE while finding device override value from resource"
2014-02-10 05:51:44 +00:00
bd9887a574
Fix possible NPE while finding device override value from resource
...
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
2014-02-10 14:38:53 +09:00
f70bcf3d32
Refactor Key constructors
...
This is a followup of I76432556ca.
Change-Id: Ie2c8f7c23352a33db28e89ee8e6ebaba9eb760a3
2014-02-10 11:14:35 +09:00
e592c1b291
Merge "Add example attribute to <xliff:g> elements in string resources"
2014-02-10 02:09:08 +00:00
1271da4679
Add example attribute to <xliff:g> elements in string resources
...
Bug: 8693729
Change-Id: Ide98ab83439cda43a8b84aaf64d0a9c18e44a8cc
2014-02-10 10:49:43 +09:00
541a3d394c
Remove unused import
...
Change-Id: I3f934de281eefb387026585e678d783a95729720
2014-02-10 10:22:29 +09:00
45eb5d924d
Allow an empty keySpec for Spacer
...
Bug: 12933248
Change-Id: I76432556caf319ce23c1fb7fa3d6b94118e64cf8
2014-02-09 23:45:23 +09:00
c44cbf6a3d
Merge "Generate KeyboardTextsTable.java instead of KeyboardTextsSet.java"
2014-02-07 10:39:57 +00:00
c8a0117c9c
Fix undefined emojiKeyStyle
...
Change-Id: I6798f524c9ac0d2911f2b83a5a5ef650f0815917
2014-02-07 19:35:00 +09:00
e5320c1d1f
Generate KeyboardTextsTable.java instead of KeyboardTextsSet.java
...
Change-Id: Ic48b093dc64b514822cc9daa1ac3d79deb7af089
2014-02-07 18:56:23 +09:00
4f72923fa2
Merge "Rename Key.keyLabel attribute to KeySpec"
2014-02-07 09:53:43 +00:00
4e85476740
Merge "Consolidate keyIcon and code with keyLabel attribute"
2014-02-07 09:53:35 +00:00
9684b33b69
Rename Key.keyLabel attribute to KeySpec
...
Change-Id: Ida48cd9bdbc01fefad651a005084262c0f46c41c
2014-02-07 18:47:45 +09:00
a83a1feb62
Consolidate keyIcon and code with keyLabel attribute
...
Change-Id: I75fbd348fab5022606ca14552eb03b15af6684c8
2014-02-07 18:47:22 +09:00
a9e1db6636
Merge "Decimal number is treated as outputText"
2014-02-07 09:26:04 +00:00
276b1a2ebc
Add debug settings for keypress popup animations
...
Bug: 12928125
Change-Id: I49faab754c7d1dcf4a791dfc535d3a78b62ce67a
2014-02-07 18:09:41 +09:00
6422f77e94
Merge "Use native logic to read Ver4 dict."
2014-02-06 13:00:09 +00:00
ab6a93773b
Use native logic to read Ver4 dict.
...
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
2014-02-06 21:55:37 +09:00
fc6d0f8738
Merge "Implement getHeaderInfoNative."
2014-02-06 11:26:49 +00:00
fc9ca59cc1
Implement getHeaderInfoNative.
...
Bug: 11281877
Bug: 12810574
Change-Id: Ia3d85ae2cfdb486e74b8636a62431eae883c85da
2014-02-06 18:19:42 +09:00
3bbd50c36b
Use SubtypeLocaleUtils.isRtlLanguage
...
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
2014-02-06 18:15:32 +09:00
48ea52800a
Merge "Consolidate keyOutputText with keyLabel attribute"
2014-02-06 09:14:09 +00:00
d645db1e37
Merge "Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag"
2014-02-06 09:01:41 +00:00
a9b67135bd
Merge "Parse keyLabel for icon, code, and outputText as well"
2014-02-06 08:38:54 +00:00
df75444239
Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag
...
This change must be checked in together with Iac93eb79fc.
Bug: 12913520
Bug: 12179576
Change-Id: Ic9a40fb0529202893be8ccb6f5abfbbe6d78508c
2014-02-06 17:28:08 +09:00
0df462730b
Remove unused smiley key definitions
...
Change-Id: Icbdfb360abab2964869898949774f47197f6d000
2014-02-06 16:56:42 +09:00
d6f147e142
Consolidate keyOutputText with keyLabel attribute
...
Change-Id: I90ea2c9d5ce42fabc79599995a2fae1f5f652a6b
2014-02-06 16:42:57 +09:00
6193217f5c
Parse keyLabel for icon, code, and outputText as well
...
Change-Id: I023915b68b4aabd056c2c1eb745876471556e15e
2014-02-06 16:42:17 +09:00
a9e1930a6a
Merge "Conditionally store the raw suggestions."
2014-02-06 07:31:22 +00:00
4a64ad9538
Decimal number is treated as outputText
...
Change-Id: I9d4a8ac5dd26a7c41fcfbe1842a40f347a2f2aab
2014-02-06 16:30:12 +09:00
fd018c1588
Merge "Use CombinedFormatUtils to convert dict elements to strings."
2014-02-06 07:29:30 +00:00
a49f61f8a7
Conditionally store the raw suggestions.
...
Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
2014-02-06 16:14:41 +09:00
b24de426fc
Use CombinedFormatUtils to convert dict elements to strings.
...
Bug: 11281877
Bug: 12810574
Change-Id: Ib631f75eab73abc9877a7698171c45e8f2fc7600
2014-02-06 16:09:25 +09:00
337dce8074
Merge "Consolidate WordProperty and Word."
2014-02-06 07:02:07 +00:00
0c088e2d74
Merge "Unregister DictionaryDumpBroadcastReceiver in onDestroy()."
2014-02-06 06:55:42 +00:00
f2d15d6956
Unregister DictionaryDumpBroadcastReceiver in onDestroy().
...
Change-Id: I83a05a8369c2fe2fa7522f18eb00983a0b10dc19
2014-02-06 15:37:41 +09:00
5f5feeba13
Consolidate WordProperty and Word.
...
Bug: 11281877
Bug: 12810574
Change-Id: I9dc99188f80f25a8780c1860dab46e4aa80a23e5
2014-02-06 15:13:33 +09:00
7ee6be46b3
Merge "Remove a redundant comment."
2014-02-06 05:42:15 +00:00
2212385061
Import translations. DO NOT MERGE
...
Change-Id: Ib99535e93fac58d7e5b22595015096b7be9d0d98
Auto-generated-cl: translation import
2014-02-05 16:55:40 -08:00
058d615121
Remove a redundant comment.
...
No need to say this twice.
Change-Id: Ief7ac425037aa2767ee8f21c9552138a9c46afc8
2014-02-05 22:42:38 +09:00
58eed6360d
Merge "Stop considering personalization dicts outputs as words"
2014-02-05 13:33:12 +00:00
5095fabdd0
Stop considering personalization dicts outputs as words
...
Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410
2014-02-05 21:57:37 +09:00
239f7daf4a
Merge "Make WeightedString have ProbabilityInfo."
2014-02-05 12:53:14 +00:00
df1d3e733e
Make WeightedString have ProbabilityInfo.
...
Bug: 11281877
Bug: 12810574
Change-Id: I265e3d8654c75766cd0e0d09d67ef62b4566298a
2014-02-05 21:44:55 +09:00
e42380a471
Merge "Separate ProbabilityInfo form WordProperty."
2014-02-05 12:37:49 +00:00
75a3df30f6
Separate ProbabilityInfo form WordProperty.
...
Bug: 11281877
Bug: 12810574
Change-Id: I0c77d976c915bdf2a2cddabd0cbedc2fb6691c7b
2014-02-05 21:31:35 +09:00
8fb2f6a441
Merge "Fix a flash in the wrong place"
2014-02-05 09:46:44 +00:00
9e9e948a70
Fix a flash in the wrong place
...
Bug: 7226099
Change-Id: I8f74802b3ae24018fc4176fb2fff2c777ae170b0
2014-02-05 18:44:24 +09:00
02a534d13f
Merge "Treat a sole "|" as a special case of key label"
2014-02-05 09:32:12 +00:00
6e5dbdd501
Merge "Add null check to KeySpecParser"
2014-02-05 09:32:04 +00:00
6a16fa1f10
Merge "Refactor KeySpecParser a bit"
2014-02-05 09:17:01 +00:00
b162911fa4
Merge "[HD04] Make the locale mandatory."
2014-02-05 09:16:17 +00:00
f7d8b8fcbc
Treat a sole "|" as a special case of key label
...
Change-Id: Ia72c31d15c891fa522935ba9792e88fd5d8ce7f7
2014-02-05 17:57:44 +09:00
bbb6e8f10f
Merge "[IL109] Move more code to InputLogic"
2014-02-05 08:50:28 +00:00
a6ea33b4d7
Merge "[IL108] Remove some uses of LatinIME in input logic."
2014-02-05 08:49:44 +00:00
d9c6b33209
Add null check to KeySpecParser
...
Change-Id: Ic37db8cbf8f83f753d7381e1edba8eac1ef1ceb1
2014-02-05 17:49:26 +09:00
bc9514032a
Refactor KeySpecParser a bit
...
Change-Id: I1208746f42eb92f937812149033398d8318f9c4e
2014-02-05 17:43:53 +09:00
43cf9076b2
[HD04] Make the locale mandatory.
...
Bug: 11281748
Change-Id: I69281b0053bec404c3e3c713ade3f65a140f51b1
2014-02-05 17:35:25 +09:00
bb476be4e6
Move key preview related methods to KeyPreviewChoreographer
...
Change-Id: Ia8d6b7fa922a4da233bf851b2e94bbd2573a65a3
2014-02-05 15:41:39 +09:00
f2749e41e4
Merge "Revert "Move key preview related methods to KeyPreviewChoreographer""
2014-02-05 06:28:45 +00:00
32d6c6a400
Revert "Move key preview related methods to KeyPreviewChoreographer"
...
This reverts commit 38806940b9
2014-02-05 06:27:41 +00:00
2bb1c6add9
[IL109] Move more code to InputLogic
...
Bug: 8636060
Change-Id: Ib12eacc836e8d39c4165c97a2a287f32f6bf5405
2014-02-05 14:49:59 +09:00
2c01dd00f2
[IL108] Remove some uses of LatinIME in input logic.
...
Access the suggestion strip through the interface instead.
Bug: 8636060
Change-Id: Ia8bd705c230f943e309d677ef683b1a2cbe68036
2014-02-05 14:49:59 +09:00
ade1aa55b6
[IL107] Add an interface to access the suggestion view.
...
Bug: 8636060
Change-Id: I603af6bcdaa31f64aaaf916784720a133388c737
2014-02-05 14:49:57 +09:00
aac53dd7f5
Merge "Move key preview related methods to KeyPreviewChoreographer"
2014-02-05 03:45:08 +00:00
c488048634
Merge "Check isEligibleForAutoCommit when batch input is ended."
2014-02-05 03:34:46 +00:00
38806940b9
Move key preview related methods to KeyPreviewChoreographer
...
Change-Id: I18cbbd287313826bc72437c6ebab2915c1d7bc50
2014-02-05 12:34:06 +09:00
8c5c01e981
Check isEligibleForAutoCommit when batch input is ended.
...
Bug: 11951198
Change-Id: Ibbe09fa38eaa3ebf8f9b69f744a29db7ac598975
2014-02-05 11:40:17 +09:00
66b2fcf2bf
Merge "Move some XML attributes to KeyPreviewDrawParams"
2014-02-05 00:51:23 +00:00
ad37cddd79
Merge "Add jni interface to get header information from native."
2014-02-04 12:52:50 +00:00
f32b2d5c5e
Merge "Add a utility method to StringUtils."
2014-02-04 12:47:21 +00:00
aaf864db7b
Merge "Separate header class from FormatSpec."
2014-02-04 12:42:44 +00:00
927aff72bc
Add jni interface to get header information from native.
...
Bug: 12810574
Change-Id: I2508483bcb3157f04cc1fe13f24f864d301f1f28
2014-02-04 21:42:09 +09:00
53fb86c447
Add a utility method to StringUtils.
...
Bug: 12810574
Change-Id: I607803e924b9e99855df7690e67488b2861c120e
2014-02-04 21:42:06 +09:00
b986f78ba8
Separate header class from FormatSpec.
...
Bug: 12810574
Change-Id: Iacf1cd05a268bf690ab864b5e32a18a4b0ccc693
2014-02-04 21:36:04 +09:00
866fd42091
Merge "Add dictionary dump buttons in debug settings."
2014-02-04 12:34:32 +00:00
36c7a62dff
Add dictionary dump buttons in debug settings.
...
Bug: 11736680
Bug: 12810574
Change-Id: I1f797b5ac6acf94b40d9698d4535e8f5da2bfb17
2014-02-04 21:29:09 +09:00
7d09b56812
Move some XML attributes to KeyPreviewDrawParams
...
Change-Id: I0e040b3aed63f8da983fcc51d55b55ac9294a16a
2014-02-04 19:31:45 +09:00
f7d682cce1
Merge "Refactor KeyPreviewDrawParams a bit"
2014-02-04 10:14:14 +00:00
23c487510a
Merge "Check timestamp for each pointer."
2014-02-04 08:26:14 +00:00
99b7242f78
Merge "Make dumpAllWordsForDebug() use getNextWordProperty()."
2014-02-04 07:51:00 +00:00
ffb12e76b8
Merge "Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken."
2014-02-04 07:46:50 +00:00
992c521909
Refactor KeyPreviewDrawParams a bit
...
Change-Id: Ia1a2c5cd882c2524a2e2f02ae052f0404061b2f7
2014-02-04 16:10:58 +09:00
33fd13bf3c
Check timestamp for each pointer.
...
Bug: 11325631
Change-Id: I4e296cdeccf21323c5732754e86c3a4075ccf82a
2014-02-04 14:04:26 +09:00
d79fd29f61
Make dumpAllWordsForDebug() use getNextWordProperty().
...
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
2014-02-04 13:51:49 +09:00
96aee22e7b
Merge "Use "Key popup dismiss delay" to control key preview zoom out animation"
2014-02-04 04:42:36 +00:00
941734695b
Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken.
...
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
2014-02-04 12:42:14 +09:00
0251c60b44
Merge "Import translations. DO NOT MERGE"
2014-02-04 03:19:22 +00:00
9d9fd48fa2
Import translations. DO NOT MERGE
...
Change-Id: Ie6d3ca2063815af9086252dd4e2ce177acbb85bb
Auto-generated-cl: translation import
2014-02-03 19:18:16 -08:00
6c88544f95
Import translations. DO NOT MERGE
...
Change-Id: I7b3358893fca57f1ddc457c74daff9b3b2eb2ee4
Auto-generated-cl: translation import
2014-02-03 19:17:35 -08:00
5be8a59a5a
Use "Key popup dismiss delay" to control key preview zoom out animation
...
Bug: 12809303
Change-Id: I2db0362a2f8c512145f1cf9326f06e5f922987b8
2014-02-04 11:43:58 +09:00
b06e455797
Clear important notice strip
...
Bug: 10587358
Change-Id: Ic90e5825200a1d424aac4ba263b252187a203241
2014-02-03 18:28:21 +09:00
4d539f2c1e
Merge "Fix important notice strip text layout"
2014-02-03 09:14:02 +00:00
9706f9a2f4
Fix important notice strip text layout
...
Bug: 10587358
Change-Id: I9cbdd3b450e05d6d0611a16b6b7fad945918dd5f
2014-02-03 18:07:19 +09:00
a2d83dfdc7
Merge "Show important notice dialog"
2014-02-03 08:04:03 +00:00
342e81e7a6
Show important notice dialog
...
Bug: 10587358
Change-Id: I3b4282a1bb183aa901110a4a2fc1b6ed72818aae
2014-02-03 16:21:53 +09:00
80fa64e66b
Merge "Don't resume suggestions if suggestions are not requested."
2014-02-03 07:07:14 +00:00
5d9be8039c
Merge "Have empty suggestions go through setNeutralSuggestions."
2014-02-03 06:45:45 +00:00
2cbf152986
Have empty suggestions go through setNeutralSuggestions.
...
Bug: 12865205
Change-Id: If17a390c445d0820325a9b16cc4f2f27a361187a
2014-02-03 15:33:00 +09:00
Baligh Uddin
Keisuke Kuroyanagi
Jean Chalard
Tadashi G. Takaoka
Ken Wakasa
Yohei Yukawa
Geoff Mendal