Jean Chalard
b084da2ae6
Merge changes I5092942a,I931c553f
...
* changes:
[IL80] Reverse a test for clarity.
[IL79] Some refactoring
2014-01-27 10:00:37 +00:00
Jean Chalard
f58a96c977
am a3a85e8c: Merge "[IL78] Move most of onUpdateSelection to InputLogic."
...
* commit 'a3a85e8c2bcab6ff9b00fda52e3ba0c666055951':
[IL78] Move most of onUpdateSelection to InputLogic.
2014-01-27 01:57:15 -08:00
Jean Chalard
a3a85e8c2b
Merge "[IL78] Move most of onUpdateSelection to InputLogic."
2014-01-27 09:55:08 +00:00
Jean Chalard
d38b0468b0
[IL90] Small refactoring
...
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
Jean Chalard
33ff321d6c
[IL89] Inline a function
...
We will then refactor the contents of showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
Jean Chalard
ca819178a1
[IL88] Simple refactoring
...
With this, the value passed to suggestedWords is never null.
Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
Jean Chalard
d90bdd2187
[IL87] Remove a call to clearSuggestionStrip
...
The goal is to remove the function completely.
Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
Jean Chalard
3b939ed77f
[IL86] Simplification and correctness fix.
...
This should be what was intended.
Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
Jean Chalard
07eddf3c43
[IL85] Maybe show punctuations when app completions are null
...
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.
Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
Jean Chalard
b2c0388a69
[IL84] Remove a useless call and rename a method
...
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
Jean Chalard
eb190ab32f
[IL83] Inline a call
...
The coming string of changes is very complicated, so
I'm going to do things really slowly.
Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
Jean Chalard
17f1528f9e
[IL82] Fix a wrong comment
...
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
Jean Chalard
abbd755689
[IL81] Remove a useless test.
...
It seems the comments were right all along. This seems to really
be useless.
Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
Jean Chalard
f1e5b9b4d1
[IL80] Reverse a test for clarity.
...
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
Jean Chalard
f59487379e
[IL79] Some refactoring
...
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
Jean Chalard
10460441db
[IL78] Move most of onUpdateSelection to InputLogic.
...
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka
c8bddebf1a
am 1e4b1300: Merge "Refactor SuggestionsStripLayoutHelper class"
...
* commit '1e4b1300e65095ca4b064afb5590d4bc02ff7725':
Refactor SuggestionsStripLayoutHelper class
2014-01-27 01:39:02 -08:00
Tadashi G. Takaoka
1e4b1300e6
Merge "Refactor SuggestionsStripLayoutHelper class"
2014-01-27 09:36:52 +00:00
Jean Chalard
d7c3ceac59
am 68d7291a: Merge "[IL77] Remove refs to Settings from InputLogic"
...
* commit '68d7291a6bdc1d5633d744759a5c76599499d9e9':
[IL77] Remove refs to Settings from InputLogic
2014-01-27 01:35:46 -08:00
Tadashi G. Takaoka
3312f281ff
am 46c37e63: Merge "Fix SubtypeLocaleUtilsTests"
...
* commit '46c37e63cc81a3a7e1bc72f82ad00925f334c8f9':
Fix SubtypeLocaleUtilsTests
2014-01-27 01:35:44 -08:00
Jean Chalard
37985b2540
am 7bee8409: Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
...
* commit '7bee84095e24a9e21e8a2146f7bb9d1ad2cd89ba':
[IL75] Move the SubtypeSwitcher out of InputLogic.
2014-01-27 01:35:41 -08:00
Tadashi G. Takaoka
c6473b5964
am 829ad708: Merge "Revert "Use ViewCompat support library""
...
* commit '829ad708db7bc3c9a0eabad8d3e410da400f36e6':
Revert "Use ViewCompat support library"
2014-01-27 01:35:39 -08:00
Jean Chalard
68d7291a6b
Merge "[IL77] Remove refs to Settings from InputLogic"
2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka
46c37e63cc
Merge "Fix SubtypeLocaleUtilsTests"
2014-01-27 09:26:50 +00:00
Tadashi G. Takaoka
148dedbc5d
Refactor SuggestionsStripLayoutHelper class
...
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
2014-01-27 18:25:25 +09:00
Jean Chalard
7bee84095e
Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka
73472efac1
Fix SubtypeLocaleUtilsTests
...
Change-Id: Ifbdfd320b1416d210592ec14099e4dd9d9d0047d
2014-01-27 18:23:54 +09:00
Tadashi G. Takaoka
829ad708db
Merge "Revert "Use ViewCompat support library""
2014-01-27 09:20:19 +00:00
Jean Chalard
48df380f78
[IL77] Remove refs to Settings from InputLogic
...
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
Jean Chalard
969c06072d
[IL75] Move the SubtypeSwitcher out of InputLogic.
...
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
Jean Chalard
c7ef305bbc
Try to figure out whether d.quotes open or close.
...
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka
e4692c0050
Revert "Use ViewCompat support library"
...
This reverts commit e7ee4fa862
.
Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
2014-01-27 18:14:40 +09:00
Jean Chalard
5be5fd13e0
am 5cf70a1d: Merge "[IL74] Remove unused/unwanted arguments to a method."
...
* commit '5cf70a1d44395a4a857eeb33504f8458fbba2464':
[IL74] Remove unused/unwanted arguments to a method.
2014-01-27 00:58:49 -08:00
Jean Chalard
5cf70a1d44
Merge "[IL74] Remove unused/unwanted arguments to a method."
2014-01-27 08:57:12 +00:00
Yohei Yukawa
c93a0e71fe
am 0b586179: Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
...
* commit '0b5861795158e4a9f1c8b8c9025ab3f4e49adebc':
Fix inconsistent behavior with backspace in the Emoji pallete.
2014-01-27 00:14:23 -08:00
Yohei Yukawa
0b58617951
Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
2014-01-27 08:11:51 +00:00
Jean Chalard
0fd556ceca
[IL74] Remove unused/unwanted arguments to a method.
...
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
Yohei Yukawa
ea8c1c811c
Fix inconsistent behavior with backspace in the Emoji pallete.
...
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
the key.
This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
subsequent delete key events when the finger is moved away
from the key area.
Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka
4bc31d5111
am f3ca92dd: Merge "Use ViewCompat support library"
...
* commit 'f3ca92dd33254e0c7cc87e9ffac0cfc41c4ea3f5':
Use ViewCompat support library
2014-01-26 23:23:12 -08:00
Tadashi G. Takaoka
f3ca92dd33
Merge "Use ViewCompat support library"
2014-01-27 07:21:41 +00:00
Ken Wakasa
3873ee735d
am 03283b63: Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
* commit '03283b636c0c35bfd4ff8fe6b30db27fad5cf824':
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-26 23:19:57 -08:00
Tadashi G. Takaoka
e7ee4fa862
Use ViewCompat support library
...
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
Ken Wakasa
03283b636c
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
some cleanups as well
Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi
3dfdd307ce
am 963d97af: Merge "Add length check for dict update operations."
...
* commit '963d97af6d83f62c48a4395caca8ac64972f8a57':
Add length check for dict update operations.
2014-01-24 16:51:17 -08:00
Keisuke Kuroyanagi
c9243ca1f7
am 95043145: Merge "Check length of words for personalization dict."
...
* commit '95043145df6d943849f871a80802fc40c5c8ff5b':
Check length of words for personalization dict.
2014-01-24 16:47:53 -08:00
Keisuke Kuroyanagi
963d97af6d
Merge "Add length check for dict update operations."
2014-01-25 00:47:27 +00:00
Keisuke Kuroyanagi
95043145df
Merge "Check length of words for personalization dict."
2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi
51c5ec10f9
Add length check for dict update operations.
...
Bug: 12602903
Change-Id: I6835dee8bf8b356f0f1cf6c0531bee5b3415a13f
2014-01-24 16:32:42 -08:00
Keisuke Kuroyanagi
b7197b705b
Check length of words for personalization dict.
...
Bug: 12602903
Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
Ken Wakasa
86795823f7
am 0acd1210: Fix wrong indents.
...
* commit '0acd121083baf137dc81cd2c5ce4214a9848a82d':
Fix wrong indents.
2014-01-24 06:59:07 -08:00