Commit Graph

8789 Commits (b9ce84214212f5b5072cd9fda458526887c3c739)

Author SHA1 Message Date
Ken Wakasa b9ce842142 mExpectingUpdateSelection was out of sync when nothing to delete.
This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I9c6a948331726a821bd3ccec9c1d02dec2c4703a
2013-10-14 17:57:48 +09:00
Ken Wakasa c8383eda8b Fix wrong commitText parameter in sendKeyCodePoint()
Small optimization on generating a String instance from a single code
point too.

bug: 11181913

Change-Id: I0f905e4dc6ec7841092bb4d3d940daf3b2303f5b
2013-10-13 10:56:10 +09:00
Baligh Uddin cdc4c1dca7 Import translations. DO NOT MERGE
Change-Id: Icbe028a32311c167219f366e695cb7932f5a9a71
Auto-generated-cl: translation import
2013-10-12 09:43:32 -07:00
Baligh Uddin 40823338e2 Merge "Import translations. DO NOT MERGE" into klp-dev 2013-10-11 15:35:27 +00:00
Baligh Uddin 02ecae3aa3 Import translations. DO NOT MERGE
Change-Id: I45a783763fce6254469a39374d03edb6a1867cc9
Auto-generated-cl: translation import
2013-10-11 06:31:03 -07:00
Ken Wakasa 3e35e0727c Merge "Make emoji separators" into klp-dev 2013-10-11 11:57:07 +00:00
Satoshi Kataoka 6d91503727 Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev 2013-10-11 11:53:07 +00:00
Jean Chalard 6fc15b9fc4 Fix a bug where emojis would remove the suggestion strip.
Bug: 11163495
Change-Id: I23d12c430125cc2a66a6e00715a4c609bb9e2bb1
2013-10-11 20:51:13 +09:00
Jean Chalard 401fb908f0 Make emoji separators
Bug: 11163495
Change-Id: I3247b8d1bbd3406b29a30a25aebd932c63431943
2013-10-11 20:00:38 +09:00
Jean Chalard 5fe9ab1cc6 Merge "Fix the suggestion size." into klp-dev 2013-10-11 08:38:31 +00:00
Jean Chalard c0bd0a244d Fix the suggestion size.
The available space was not computed correctly. This makes the
decision to ellipsize/expand the middle suggestion correct.

Also, the scale was not applied correctly in some cases.

Finally, for some reason ellipsize does not work as we expect.
I'm not sure how to get it to work like we want it to, but
this works around the problem in a simple manner.

Bug: 11158757
Change-Id: I083e7ac56e157f100923733e67b92a6368a526c9
2013-10-11 16:42:46 +09:00
Satoshi Kataoka 7611af753a Merge "Do not merge. Save / restore the last used emoji category" into klp-dev 2013-10-11 07:21:35 +00:00
Satoshi Kataoka 7d3f53a1cb Do not merge. Save / restore the last used emoji category
Bug: 11029983
Change-Id: I5547910c7b5dd7974292fc075af33568940f4e81
2013-10-11 16:05:38 +09:00
Ken Wakasa 6dac27eeb4 Merge "Tweak vertical gap of Emoji palette. DO NOT MERGE" into klp-dev 2013-10-10 03:39:30 +00:00
Ken Wakasa f9d7d17f8f Merge "Retry to tweak punctuations. DO NOT MERGE" into klp-dev 2013-10-10 03:39:17 +00:00
Satoshi Kataoka c8e4ad0748 Support sw540 (ultra Z). DO NOT MERGE
cherrypick of Ib930ba810b25e28bcc36ea1647d46731816d9def

Bug: 11125351
Change-Id: Ifc4ab2a0495e886259c34f78bbe8cbf8fb75203b
2013-10-10 11:33:10 +09:00
Satoshi Kataoka 3a9ae65525 Tweak vertical gap of Emoji palette. DO NOT MERGE
cherrypick of I8163568a9d7f9d321148001e161c672f78796c96

Bug: 11140087
Change-Id: Ifd28f3017a8cf568a8c4a1045811564a129d85b7
2013-10-10 11:29:08 +09:00
Satoshi Kataoka 557a0935d4 Retry to tweak punctuations. DO NOT MERGE
cherrypick of I9ffc457ca44bccfa3eb3bdb0c26535d795215b26

Bug: 11130808
Change-Id: I1a65fd8acc4efe9b4e4786a3dc959498ae63c2f8
2013-10-10 11:14:37 +09:00
Satoshi Kataoka a6a6abc816 Fix the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
2013-10-09 02:59:32 -07:00
Satoshi Kataoka 6862b8192d Fix crash in AdditionalSubtypeUtils
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
2013-10-09 02:59:26 -07:00
Satoshi Kataoka 31e152e380 am de65b7c0: Merge "Fix the position of emoji palette"
* commit 'de65b7c0b36963de0f5c4f5cede543b247a8ccd7':
  Fix the position of emoji palette
2013-10-08 05:06:39 -07:00
Satoshi Kataoka de65b7c0b3 Merge "Fix the position of emoji palette" 2013-10-08 12:04:03 +00:00
Satoshi Kataoka f981fe7ed2 Fix the position of emoji palette
Change-Id: I07a3912cb9fef8e28f3605de4e73a201a900e95c
2013-10-08 21:00:43 +09:00
Ken Wakasa 1d24f19b00 am c040d59d: Merge "Add more_keys_for_* declarations for the Swedish keyboard."
* commit 'c040d59defe38ce4b55e54dc8859db2e48307f1f':
  Add more_keys_for_* declarations for the Swedish keyboard.
2013-10-08 04:46:02 -07:00
Ken Wakasa c040d59def Merge "Add more_keys_for_* declarations for the Swedish keyboard." 2013-10-08 11:44:54 +00:00
Jean Chalard e9631bcda4 am 0152ff53: Merge "Update dictionaries"
* commit '0152ff53a261e1b8dd2a876120480cc103b7a799':
  Update dictionaries
2013-10-08 04:39:19 -07:00
Jean Chalard 0152ff53a2 Merge "Update dictionaries" 2013-10-08 11:36:35 +00:00
Fredrik Roubert a30884e0e0 Add more_keys_for_* declarations for the Swedish keyboard.
This adds all those popup keys that were included in commit
b1cb13292f when the Swedish keyboard was
first added. Many of these definitions were later removed by commit
79b965e04f but most likely by mistake, as
that commit log message doesn't mention anything about removing these.

To help making this file more maintainable, this commit also moves a few
definitions around so that all definitions now appear in alphabetical
order.

Change-Id: Iadef9e3dd1dc7b39fe87b2fc75210d0697b24361
2013-10-08 13:28:08 +02:00
Satoshi Kataoka db7513bb25 am a701501c: Merge "Reduce memory of emoji palette"
* commit 'a701501cb67127f6a144f9cdbd62b8a97f37856f':
  Reduce memory of emoji palette
2013-10-08 04:27:13 -07:00
Satoshi Kataoka a701501cb6 Merge "Reduce memory of emoji palette" 2013-10-08 11:22:21 +00:00
Satoshi Kataoka 0e01df9baf Reduce memory of emoji palette
Bug: 10902556
Change-Id: I3c8da35a601de2bfb248292c7b59235fc1120988
2013-10-08 20:11:35 +09:00
Jean Chalard b1eedc6ba0 Update dictionaries
>>> dictionaries/en_GB_wordlist.combined.gz
Header :
  date : 1381130519 <=> 1381226409
  version : 41 <=> 42
Body :
Added: haha 45

>>> dictionaries/en_US_wordlist.combined.gz
Header :
  date : 1380293342 <=> 1381226409
  version : 40 <=> 42
Body :
Added: haha 45

>>> dictionaries/en_wordlist.combined.gz
Header :
  date : 1380293363 <=> 1381226429
  version : 40 <=> 42
Body :
Added: haha 45

>>> dictionaries/fr_wordlist.combined.gz
Header :
  date : 1380519383 <=> 1381226409
  version : 40 <=> 42
Body :
Freq changed: haha 0 -> 30

>>> java/res/raw/main_en.dict
Header :
  date : 1380293363 <=> 1381226429
  version : 40 <=> 42
Body :
Added: haha 45

>>> java/res/raw/main_fr.dict
Header :
  date : 1380519383 <=> 1381226409
  version : 40 <=> 42
Body :
Freq changed: haha 0 -> 30

Bug: 11114205
Change-Id: I39d429d24d93ee07a70d8613ce0752432b26acc4
2013-10-08 10:34:56 +00:00
Jean Chalard 17bec5cb1c am 92190d9a: Merge "Show the keyboard earlier when rotating."
* commit '92190d9a756b7bad95648075828b23e61340358d':
  Show the keyboard earlier when rotating.
2013-10-08 03:15:55 -07:00
Jean Chalard 92190d9a75 Merge "Show the keyboard earlier when rotating." 2013-10-08 10:14:41 +00:00
Satoshi Kataoka 67aa1a93f8 am 2d3e1210: Fix memory leak in EmojiPaletteView
* commit '2d3e121014a97b7de90f287f1ef82fa98f37007c':
  Fix memory leak in EmojiPaletteView
2013-10-08 03:12:41 -07:00
Satoshi Kataoka 2d3e121014 Fix memory leak in EmojiPaletteView
Bug: 10902556
Change-Id: I3a8c1e08d6f953b462d914acd1f411c36f9d80f2
2013-10-08 19:05:00 +09:00
Ken Wakasa 87f0603380 am d900b90d: Merge "Prep for RAM footprint optimization for Emoji palettes"
* commit 'd900b90db7d411c8cfc8ff9e41518bf98f50daff':
  Prep for RAM footprint optimization for Emoji palettes
2013-10-08 01:36:46 -07:00
Ken Wakasa d900b90db7 Merge "Prep for RAM footprint optimization for Emoji palettes" 2013-10-08 08:11:53 +00:00
Ken Wakasa 8cf2a5e59f Prep for RAM footprint optimization for Emoji palettes
bug: 10902556
Change-Id: I313948c73b60cd33c437cf02e8d3fb61c288a240
2013-10-08 17:09:24 +09:00
Jean Chalard 482aa129e4 Show the keyboard earlier when rotating.
Bug: 11107229
Change-Id: I0b36341d60b634a860eb13fafd0dc69fe734bdeb
2013-10-08 16:33:27 +09:00
Jean Chalard 620017028c am 36c56cae: Merge "Make the sentence separator a resource."
* commit '36c56caee3049737a55e2421bf9e3727c4936f24':
  Make the sentence separator a resource.
2013-10-07 23:45:52 -07:00
Jean Chalard 10581e68af Make the sentence separator a resource.
This will help handing correctly the armenian full stop.

Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
2013-10-08 15:28:43 +09:00
Satoshi Kataoka da9408c8d8 am 984aa60e: Merge "Extend hitbox of emoji keys"
* commit '984aa60e11a160ae712527dcaa1bc837db2e7466':
  Extend hitbox of emoji keys
2013-10-07 16:29:33 -07:00
Satoshi Kataoka 984aa60e11 Merge "Extend hitbox of emoji keys" 2013-10-07 23:27:07 +00:00
Jean Chalard 6e979246be am 7712baa5: Merge "Fix a possible IOOB"
* commit '7712baa59baadccf2da64f8dc5d21621fba860af':
  Fix a possible IOOB
2013-10-07 07:23:12 -07:00
Jean Chalard 9493affce3 am 3c4e8cb6: Call loadKeyboard later if it can\'t be called right away
* commit '3c4e8cb693ce584ea1f87e354430c069cdd3da39':
  Call loadKeyboard later if it can't be called right away
2013-10-07 07:23:09 -07:00
Satoshi Kataoka 5d27cb9397 Extend hitbox of emoji keys
Bug: 11105065
Change-Id: I5e90ba55cf708bf7be27d7d101cbc0719ac583c8
2013-10-07 23:22:12 +09:00
Jean Chalard 7712baa59b Merge "Fix a possible IOOB" 2013-10-07 14:21:00 +00:00
Jean Chalard ca9c3c0613 Fix a possible IOOB
We want to use StringUtils here, but it's full of references to
stuff not accessible host-side like JsonReader and TextUtils
and SettingsValues :/

Bug: 11061476
Change-Id: I3c0194979833ede283b4f9190335dba5376fe6fc
2013-10-07 23:16:57 +09:00
Jean Chalard 3c4e8cb693 Call loadKeyboard later if it can't be called right away
Since loadKeyboard relies on the input connection being
available to give it the auto-caps state, but also can't
be called twice in a row because it needs to save and
restore its state and invalidates it after the restore,
we need to wait until we know we have a valid input
connection to call it.

Bug: 11107229
Change-Id: I1c7baf3215682df6f6ceb357bd37254f9e7418c7
2013-10-07 22:57:59 +09:00