Commit graph

9871 commits

Author SHA1 Message Date
Jean Chalard
b8ff8ca9d9 Straighten out database cursors behavior.
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.

It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.

Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
2014-02-18 19:58:23 +09:00
Jean Chalard
db21fad18f Merge "Avoid crashing when the Content URL is not found." 2014-02-18 05:35:54 +00:00
Jean Chalard
9967f0a1d0 Avoid crashing when the Content URL is not found.
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.

Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
2014-02-18 14:27:58 +09:00
Baligh Uddin
0f8134dc40 Merge "Import translations. DO NOT MERGE" 2014-02-18 04:58:14 +00:00
Ken Wakasa
0d32643e69 Merge "Cosmetic fixes" 2014-02-18 03:28:04 +00:00
Ken Wakasa
2312c1954f Cosmetic fixes
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
2014-02-18 12:17:24 +09:00
Tadashi G. Takaoka
cc05f468ca Merge "Refactor InputAttributes a bit" 2014-02-18 02:25:46 +00:00
Baligh Uddin
3a73aa4182 Import translations. DO NOT MERGE
Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709
Auto-generated-cl: translation import
2014-02-17 18:19:28 -08:00
Tadashi G. Takaoka
06fbfc4951 Refactor InputAttributes a bit
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
2014-02-18 11:11:36 +09:00
Tadashi G. Takaoka
affdd36423 Set neutral suggestions should be called after load settings
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
2014-02-18 11:04:00 +09:00
Tadashi G. Takaoka
f0f4e9fc16 Update important notice version even when user select Settings
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
2014-02-18 00:14:30 +09:00
Jean Chalard
782c9fee6b Merge "Don't resume suggestion on links." 2014-02-17 11:46:54 +00:00
Jean Chalard
7a7aeffcdc Don't resume suggestion on links.
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
2014-02-17 20:36:16 +09:00
Jean Chalard
d91cd9919e Merge "Catch exceptions we can't do anything about." 2014-02-17 11:33:39 +00:00
Tadashi G. Takaoka
da0edf86c4 Merge "Stop overriding InputView.dispatchTouchEvent" 2014-02-17 10:55:11 +00:00
Tadashi G. Takaoka
5cd732f8c5 Stop overriding InputView.dispatchTouchEvent
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
2014-02-17 19:51:47 +09:00
Jean Chalard
a149731a67 Catch exceptions we can't do anything about.
This also abstracts away the "package deactivated" case for
simpler and safer code.

Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
2014-02-17 18:49:31 +09:00
Jean Chalard
1e9897b0c7 Merge "Consider non-breaking spaces separators." 2014-02-17 09:45:41 +00:00
Tadashi G. Takaoka
891e4860f8 Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 2014-02-17 09:20:54 +00:00
Jean Chalard
c051ee7025 Consider non-breaking spaces separators.
Bug: 13056209
Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
2014-02-17 18:20:46 +09:00
Tadashi G. Takaoka
e32548f32d Stop overriding SuggestionStripView.dispatchTouchEvent
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
2014-02-17 18:11:10 +09:00
Tadashi G. Takaoka
1751615f7d Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 2014-02-17 08:26:38 +00:00
Tadashi G. Takaoka
3dd6bdf931 Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 2014-02-17 08:25:57 +00:00
Tadashi G. Takaoka
800ab579a9 Remove unnecessary override of MainKeyboardView.dispatchTouchEvent
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
2014-02-17 17:09:06 +09:00
Tadashi G. Takaoka
4c628b9d5b Merge "Don't show important notice on password field" 2014-02-17 08:04:11 +00:00
Tadashi G. Takaoka
20ddd4cff5 Add InputMethodSubtypeCompatUtils.isAsciiCapable()
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
2014-02-17 16:08:33 +09:00
Tadashi G. Takaoka
ce78a2d8ab Don't show important notice on password field
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
2014-02-17 15:38:43 +09:00
Tadashi G. Takaoka
4f4fb5ef34 Merge "Use the same label of switch-to-alphabet key on Emoji palette" 2014-02-17 06:13:39 +00:00
Tadashi G. Takaoka
4c680e7bcf Merge "Add go to "Settings" button to important notice dialog" 2014-02-17 06:13:26 +00:00
Tadashi G. Takaoka
28c02b400f Add go to "Settings" button to important notice dialog
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.

This change must be checked in together with Id115d89ba9.

Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
2014-02-17 14:57:04 +09:00
Tadashi G. Takaoka
fe39aec08a Use the same label of switch-to-alphabet key on Emoji palette
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
2014-02-17 14:54:39 +09:00
Tadashi G. Takaoka
b092aef4a7 Merge "Remove key show up and dismiss animation" 2014-02-17 03:22:48 +00:00
Tadashi G. Takaoka
c9072dc8da Remove key show up and dismiss animation
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
2014-02-17 12:10:09 +09:00
Tadashi G. Takaoka
ffde401b65 Fix PC/QWERTY phone layout
Bug: 13025426
Change-Id: I980832ccab7fb7700ca8b01d4f05e920b3f45582
2014-02-17 09:27:47 +09:00
Keisuke Kuroyanagi
95d16561e0 Remove unused code.
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi
0fc93fe445 Implement PatriciaTriePolicy::getNextWordAndNextToken().
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi
85fe06e759 Merge "Remove unused argument from readDictionaryBinary." 2014-02-14 10:37:56 +00:00
Tadashi G. Takaoka
36d606fcbc Use 16sp text to show important notice title
Bug: 10587358
Change-Id: Ib840cb71d9e87282ea0d13839dbf2a2da2081d5f
2014-02-14 19:10:47 +09:00
Keisuke Kuroyanagi
8e3a1d0f89 Remove unused argument from readDictionaryBinary.
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
2014-02-14 19:02:15 +09:00
Tadashi G. Takaoka
b136b7dd6f Merge "Add sanity check to KeybaordTextsTable for debugging" 2014-02-14 09:52:36 +00:00
Tadashi G. Takaoka
53a237323a Add sanity check to KeybaordTextsTable for debugging
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
2014-02-14 18:51:03 +09:00
Jean Chalard
fdc4173213 Merge "Fix a view-related crash" 2014-02-14 09:19:34 +00:00
Jean Chalard
a7e3e74ddd Fix a view-related crash
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
2014-02-14 18:03:34 +09:00
Tadashi G. Takaoka
3c4f05dd66 Remove unused label_tab_key
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
2014-02-14 17:40:53 +09:00
Tadashi G. Takaoka
e422c94634 Fix test resource declarations and parsing a bit
Change-Id: I882a41b2934c48f4405f1ea5bf4d6ad41e87322c
2014-02-14 16:27:26 +09:00
Tadashi G. Takaoka
d4469756be Merge "Special punctuations for Arabic and Persian" 2014-02-14 07:20:25 +00:00
Tadashi G. Takaoka
17993ed4ef Merge "Fix null KeyDetector reference" 2014-02-14 07:17:33 +00:00
Tadashi G. Takaoka
d508b676cf Special punctuations for Arabic and Persian
This change also removes duplications from tablet punctuation suggestions

Bug: 12640318
Change-Id: I221922484027d6b91e2f23a6bf60a18766f3a13c
2014-02-14 16:11:50 +09:00
Tadashi G. Takaoka
32a7e079e0 Merge "Add PunctuationSuggestions class" 2014-02-14 06:19:52 +00:00
Tadashi G. Takaoka
42e4ea7d6c Add Kazakh (kk) subtype
The Kazakh (kk) subtype has been temporarily disabled by Ic44ef378a9.

Bug: 9698902
Change-Id: Ib2096cdf79fd45d36f5504be55f76416ba11445d
2014-02-14 15:16:16 +09:00