Commit Graph

9625 Commits (b3b2676c4a408ee69f660dcff9b1577c7c7c8ffe)

Author SHA1 Message Date
Jean Chalard c7ef305bbc Try to figure out whether d.quotes open or close.
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka e4692c0050 Revert "Use ViewCompat support library"
This reverts commit e7ee4fa862.

Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
2014-01-27 18:14:40 +09:00
Jean Chalard 5be5fd13e0 am 5cf70a1d: Merge "[IL74] Remove unused/unwanted arguments to a method."
* commit '5cf70a1d44395a4a857eeb33504f8458fbba2464':
  [IL74] Remove unused/unwanted arguments to a method.
2014-01-27 00:58:49 -08:00
Jean Chalard 5cf70a1d44 Merge "[IL74] Remove unused/unwanted arguments to a method." 2014-01-27 08:57:12 +00:00
Yohei Yukawa c93a0e71fe am 0b586179: Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
* commit '0b5861795158e4a9f1c8b8c9025ab3f4e49adebc':
  Fix inconsistent behavior with backspace in the Emoji pallete.
2014-01-27 00:14:23 -08:00
Yohei Yukawa 0b58617951 Merge "Fix inconsistent behavior with backspace in the Emoji pallete." 2014-01-27 08:11:51 +00:00
Jean Chalard 0fd556ceca [IL74] Remove unused/unwanted arguments to a method.
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
Yohei Yukawa ea8c1c811c Fix inconsistent behavior with backspace in the Emoji pallete.
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
  the key.

This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
  different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
  key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
  subsequent delete key events when the finger is moved away
  from the key area.

Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka 4bc31d5111 am f3ca92dd: Merge "Use ViewCompat support library"
* commit 'f3ca92dd33254e0c7cc87e9ffac0cfc41c4ea3f5':
  Use ViewCompat support library
2014-01-26 23:23:12 -08:00
Tadashi G. Takaoka f3ca92dd33 Merge "Use ViewCompat support library" 2014-01-27 07:21:41 +00:00
Ken Wakasa 3873ee735d am 03283b63: Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
* commit '03283b636c0c35bfd4ff8fe6b30db27fad5cf824':
  Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-26 23:19:57 -08:00
Tadashi G. Takaoka e7ee4fa862 Use ViewCompat support library
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
Ken Wakasa 03283b636c Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
some cleanups as well

Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi c9243ca1f7 am 95043145: Merge "Check length of words for personalization dict."
* commit '95043145df6d943849f871a80802fc40c5c8ff5b':
  Check length of words for personalization dict.
2014-01-24 16:47:53 -08:00
Keisuke Kuroyanagi 95043145df Merge "Check length of words for personalization dict." 2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi b7197b705b Check length of words for personalization dict.
Bug: 12602903

Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
Ken Wakasa 86795823f7 am 0acd1210: Fix wrong indents.
* commit '0acd121083baf137dc81cd2c5ce4214a9848a82d':
  Fix wrong indents.
2014-01-24 06:59:07 -08:00
Ken Wakasa 0acd121083 Fix wrong indents.
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
Jean Chalard 341044034c am b6e128cc: Merge "[IL69.1] Move a static method to a utility class."
* commit 'b6e128cc05fa0b4b1f79b6c7eb4d67f44833c7f4':
  [IL69.1] Move a static method to a utility class.
2014-01-23 19:07:26 -08:00
Jean Chalard b6e128cc05 Merge "[IL69.1] Move a static method to a utility class." 2014-01-24 03:04:12 +00:00
Jean Chalard 1d6e647ac3 [IL69.1] Move a static method to a utility class.
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
Jean Chalard 9bbb214edd am 0c725290: Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer"
* commit '0c72529088e02d7dbe496397fbb64089b8acd594':
  [IL73] Remove all refs to Key and Keyboard in WordComposer
2014-01-23 17:58:29 -08:00
Jean Chalard 0c72529088 Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer" 2014-01-24 01:55:57 +00:00
Baligh Uddin 6a39811d90 Merge "Import translations. DO NOT MERGE" 2014-01-23 21:02:33 +00:00
Baligh Uddin 5047b4aa84 Import translations. DO NOT MERGE
Change-Id: Ib5a8be5d9ac508d57648e4e8811805eea4355fc3
Auto-generated-cl: translation import
2014-01-23 12:25:35 -08:00
Baligh Uddin 9d7c6aafde Import translations. DO NOT MERGE
Change-Id: I4ddadf6504a80fc0955c03496eeefc6c665d0965
Auto-generated-cl: translation import
2014-01-23 12:24:12 -08:00
Baligh Uddin 2efb58fc98 Import translations. DO NOT MERGE
Change-Id: I6c8aa53b9be4c3aa5822a820cc8cfdc3cf31c390
Auto-generated-cl: translation import
2014-01-23 12:22:23 -08:00
Jean Chalard 3aa2043a66 Merge "[IL76] Remove a SuggestionStripView dependency" 2014-01-23 10:06:42 +00:00
Jean Chalard f16a2a36d2 [IL71.1] Add some javadoc.
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
2014-01-23 17:11:47 +09:00
Jean Chalard a1ed211c4e [IL76] Remove a SuggestionStripView dependency
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
2014-01-23 16:25:48 +09:00
Jean Chalard 4173610bc5 [IL66.1] Add a comment
Followup to IL66

Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
2014-01-23 16:00:49 +09:00
Jean Chalard be846fc352 [IL73] Remove all refs to Key and Keyboard in WordComposer
Please hold my gun while I have this nice cup of tea.
Yes !!

Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
2014-01-23 15:52:29 +09:00
Jean Chalard df8310c6e2 Merge "[IL71] Add indices to toCodePointArray." 2014-01-23 06:50:19 +00:00
Jean Chalard 1284e556f4 [IL70] Remove unused arguments
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
Jean Chalard d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
Jean Chalard 9da4b49ef6 [IL68] Start refactoring setComposingWord
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
2014-01-23 15:15:49 +09:00
Jean Chalard 18638d30c0 [IL71] Add indices to toCodePointArray.
This is necessary for tests

Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
2014-01-23 13:11:40 +09:00
Jean Chalard eb6d41a525 [IL67] Externalize a call to the keyboard switcher
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
2014-01-23 13:10:02 +09:00
Jean Chalard ab80b41a0d [IL66] Remove two accesses to KeyboardSwitcher.
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
2014-01-23 13:09:58 +09:00
Jean Chalard a91dfff5e5 [IL65] Pull up X,Y processing, step 4
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.

Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
2014-01-22 14:44:27 +09:00
Jean Chalard 352286a43b [IL64] Pull up X,Y processing, step 3
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
2014-01-22 14:44:25 +09:00
Jean Chalard b8216a4e7e [IL63] Pull up X,Y processing, step 2
This also fixes the coordinates passed to logOnDelete and
log onSeparator.

Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
2014-01-22 14:42:52 +09:00
Jean Chalard 2b38b5e8e6 [IL62] Pull up X,Y processing, step 1
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.

However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.

Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
2014-01-22 14:41:45 +09:00
Jean Chalard 591580ee8a Merge "[IL61] Remove an internal use of key coordinates" 2014-01-22 05:19:45 +00:00
Tadashi G. Takaoka 6e15af2626 Merge "Fix newline string resource" 2014-01-20 10:45:11 +00:00
Tadashi G. Takaoka c93cf1c398 Use sorted int[] to represent word separators
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
2014-01-20 19:40:02 +09:00
Tadashi G. Takaoka 08ce454aa5 Fix newline string resource
The newline string resource "\n" doesn't work off-device simulation.

Bug: 12623502
Change-Id: I3ad63d8afe50be174493d43f00f7191062c87cb7
2014-01-20 19:36:20 +09:00
Tadashi G. Takaoka 5b6ebdbe9e Merge "Refactor logic to retrieve relevant suggestions a bit" 2014-01-20 09:57:43 +00:00
Tadashi G. Takaoka 837cdd738b Add SpacingAndPunctuationsTests
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
2014-01-20 18:33:45 +09:00
Tadashi G. Takaoka 3033cc51b8 Refactor logic to retrieve relevant suggestions a bit
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-20 12:08:25 +09:00
Keisuke Kuroyanagi 3f3b0af5b7 Merge "Fix unit tests by adding @UsedForTesting" 2014-01-19 22:47:03 +00:00
Keisuke Kuroyanagi fde4c5f128 Fix unit tests by adding @UsedForTesting
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
2014-01-19 13:37:23 -08:00
Keisuke Kuroyanagi b1814c9633 Merge "Make contacts dict and user dict version 4." 2014-01-17 20:05:17 +00:00
Keisuke Kuroyanagi ed95d79cc4 Make contacts dict and user dict version 4.
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
2014-01-17 10:30:16 -08:00
Tadashi G. Takaoka 6a18af634e Refactor RichInputConnection a bit
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
2014-01-17 13:14:29 +09:00
Jean Chalard 2334bf6d8c Merge "Fix a bug specific to German capitalization." 2014-01-17 01:49:14 +00:00
Jean Chalard e4f584de73 Merge "[IL60] Make InputLogicHandler package private" 2014-01-16 18:15:15 +00:00
Jean Chalard 87f87d9ac5 Merge "[IL59] Rename a method" 2014-01-16 18:13:39 +00:00
Jean Chalard 9c9c43c0b7 Merge "[IL58] Simplification" 2014-01-16 17:45:59 +00:00
Keisuke Kuroyanagi f4bf620502 Merge "Add a dedicated method to control time in native code." 2014-01-16 17:25:29 +00:00
Jean Chalard ab4543d593 [IL61] Remove an internal use of key coordinates
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
2014-01-17 02:10:56 +09:00
Jean Chalard 81255612bc [IL60] Make InputLogicHandler package private
Yay

Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
2014-01-17 02:10:56 +09:00
Jean Chalard 17bd129faf [IL59] Rename a method
Um... this is not async ? Remove that from the name

Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
2014-01-17 02:10:56 +09:00
Jean Chalard ac6dfaf80b [IL58] Simplification
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.

Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
2014-01-17 02:10:51 +09:00
Jean Chalard 60afa7000f Fix a bug specific to German capitalization.
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
2014-01-17 02:06:24 +09:00
Keisuke Kuroyanagi 9e882e3937 Merge "Update personalization dict via dictionary facilitator." 2014-01-16 02:00:21 +00:00
Keisuke Kuroyanagi 12474634c5 Update personalization dict via dictionary facilitator.
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
2014-01-15 17:54:17 -08:00
Geoff Mendal 0851ac5726 Merge "Import translations. DO NOT MERGE" 2014-01-16 00:49:15 +00:00
Geoff Mendal 5802fb05a8 Import translations. DO NOT MERGE
Change-Id: I9d276ae4391f209e2db3a080b3221e5a8aa59938
Auto-generated-cl: translation import
2014-01-15 16:42:37 -08:00
Keisuke Kuroyanagi d78a447d10 Add a dedicated method to control time in native code.
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
2014-01-15 14:55:57 -08:00
Jean Chalard 2c1a13c56c Merge "[IL57] Don't require a main dict suggestion." 2014-01-15 22:14:27 +00:00
Jean Chalard 118a4fc2b7 Merge "[IL56] Don't erase suggestions when reverting a commit." 2014-01-15 19:21:06 +00:00
Jean Chalard e22e67e37a [IL57] Don't require a main dict suggestion.
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.

Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
2014-01-16 03:22:51 +09:00
Jean Chalard 4752b68f5a [IL56] Don't erase suggestions when reverting a commit.
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
2014-01-16 03:22:46 +09:00
Tadashi G. Takaoka 20a8a4a3d9 Fix native method signature
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
2014-01-15 18:56:40 +09:00
Tadashi G. Takaoka 01c1a1a2ba Refactor LanguageModelParam class a bit
This change must be checked in together with I9ecfd1adc1.

Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
2014-01-15 17:46:32 +09:00
Tadashi G. Takaoka 17a2bcfcce Make final Locale field public
This change must be checked in together with Id9382498a8.

Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
2014-01-15 17:11:54 +09:00
Tadashi G. Takaoka b8a2772b0e Consolidate LanguageModelParam constructors
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
2014-01-15 16:17:53 +09:00
Tadashi G. Takaoka 7b9b095090 Move LanguageModelParams class to utility package
This change must be checked in together with Ic82d951237.

Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
2014-01-15 16:14:53 +09:00
Tadashi G. Takaoka 2d1e72b774 Merge "Revert "Disable Nepali layouts temporarily per product call"" 2014-01-15 03:50:58 +00:00
Tadashi G. Takaoka 27274601e7 Merge "Revert "Remove Azerbaijani subtype"" 2014-01-15 03:32:55 +00:00
Tadashi G. Takaoka 4d1620f895 Revert "Disable Nepali layouts temporarily per product call"
This reverts Id58cdf117d.
This also partially reverts I99be3d54d3.

This change must be checked in together with Ied923ed80b.

Bug: 6910787
Change-Id: Icdeee1b93a6b626b43fefc06d3bb3fe40d2e056b
2014-01-15 12:31:44 +09:00
Tadashi G. Takaoka 7ae9efbb6a Revert "Remove Azerbaijani subtype"
This reverts I0d2a98dffe.
This also partially reverts I99be3d54d3.

This change must be checked in together with Ibf49c89832.

Bug: 7963448
Change-Id: Idbb3e1ac9f4e067a0051f618946a345632102fb3
2014-01-15 12:13:25 +09:00
Keisuke Kuroyanagi 68069c55c4 Fix flaky unit test.
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
2014-01-14 18:51:29 -08:00
Narayan Kamath 4f8e678bab Revert "Revert "Disable Nepali layouts temporarily per product call""
This reverts commit 93fdfc110b.

Change-Id: Ibe7bfa07aa2437701794209c16f017a88cd166b4
2014-01-14 12:44:11 +00:00
Tadashi G. Takaoka 93fdfc110b Revert "Disable Nepali layouts temporarily per product call"
This reverts Id58cdf117d.
This also partially reverts I456268b68f.

This change must be checked in together with I4d5c8ffa45.

Bug: 6910787
Change-Id: I59ba69f1b14164edea8eddf3784554a29a97e9b3
2014-01-14 17:39:24 +09:00
Tadashi G. Takaoka 6584d42b02 Merge "Move phrase gesture related string resources to AOSP" 2014-01-14 08:20:14 +00:00
Tadashi G. Takaoka 7504913807 Move phrase gesture related string resources to AOSP
This change must be checked in together with Ica8fc5135.

Change-Id: I288d7083391954f1266a9b77ee4ffc0bc9d4229d
2014-01-14 17:15:41 +09:00
Tadashi G. Takaoka bf418f7cba Pass time stamp to addToUserHistory method as an argument
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
2014-01-14 15:48:08 +09:00
Jean Chalard 62df0a6d53 Merge "Update dictionaries" 2014-01-14 03:44:20 +00:00
Jean Chalard 155cb77231 Update dictionaries
This change has no effect on TRT results.

>>> dictionaries/en_US_wordlist.combined.gz
Header :
  date : 1381226409 <=> 1389654051
  version : 42 <=> 43
Body :
Added: dialogue 120
Added: dialogues 94

>>> dictionaries/fr_wordlist.combined.gz
Header :
  date : 1381226409 <=> 1389654052
  version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114

>>> dictionaries/it_wordlist.combined.gz
Header :
  date : 1380519383 <=> 1389654052
  version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180

>>> java/res/raw/main_fr.dict
Header :
  date : 1381226409 <=> 1389654052
  version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114

>>> java/res/raw/main_it.dict
Header :
  date : 1380519383 <=> 1389654052
  version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180

Bug: 12487270
Bug: 12344108
Change-Id: I94768e223d05ad2551a5508e9e01222a028665c4
2014-01-14 10:37:15 +09:00
Geoff Mendal 9fa6663403 Import translations. DO NOT MERGE
Change-Id: I3233aa7d5f64fbf8818e0065cd1da47d84070fb6
Auto-generated-cl: translation import
2014-01-13 16:31:58 -08:00
Keisuke Kuroyanagi 5717c63a2b Fix possible NPE in DictionaryFacilitatorForSuggest.
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
2014-01-10 21:42:08 +09:00
Jean Chalard db0adf86a4 Merge "[IL55] Remove a useless argument." 2014-01-10 11:36:01 +00:00
Keisuke Kuroyanagi eb66f1906d Merge "Check corpus handles during startup for personalization." 2014-01-10 11:34:39 +00:00
Jean Chalard 6c24b91601 [IL55] Remove a useless argument.
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
2014-01-10 20:28:50 +09:00
Keisuke Kuroyanagi eb28bac542 Check corpus handles during startup for personalization.
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
2014-01-10 20:28:30 +09:00
Jean Chalard 4be9137609 Merge "[IL54.5] Use the cursor pos estimate, not the last value" 2014-01-10 10:46:27 +00:00
Jean Chalard a224aafea3 [IL54.5] Use the cursor pos estimate, not the last value
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.

Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
2014-01-10 19:08:47 +09:00
Keisuke Kuroyanagi f96e0f07af Merge "Periodic wipe of the personalization dict." 2014-01-10 09:31:22 +00:00