Jean Chalard
1d80cb2301
Merge "Fix a NPE"
2014-11-20 05:28:47 +00:00
Jean Chalard
a2cb2f36a6
Make the typed word a SuggestedWordInfo
...
That allows to carry the language information in an
accurate manner.
Bug: 18063142
Change-Id: I0bca8981372ae10648274095b18b26a3686b762b
2014-11-20 13:57:01 +09:00
Jean Chalard
0e00f5fe3a
Fix a NPE
...
Bug: 18451316
Change-Id: Ia20bf388471f84c963354df050182e722d966a02
2014-11-20 13:50:27 +09:00
Jean Chalard
8736f2d719
Merge "Fix oscillations on ICS"
2014-11-19 10:23:28 +00:00
Jean Chalard
9444d70514
Fix oscillations on ICS
...
Bug: 18181427
Change-Id: Ib4dd62037b1f7b2d10496ee3e45b4a138e29f90a
2014-11-19 19:22:04 +09:00
Jean Chalard
fde0cce103
Merge "Remove the other deprecated constructor to SuggestedWords"
2014-11-19 08:30:03 +00:00
Tadashi G. Takaoka
b9116af29f
Fix SubtypeLocaleUtils.getSubtypeNameForLogging accepting null
...
Change-Id: Ic5cb55e24a2d843027ccc4e8e5d6954f9391c125
2014-11-19 11:57:49 +09:00
Jean Chalard
6d1201915d
Rename a confusing method name
...
...and fix a bug that happened because of it.
Bug: 18417740
Change-Id: I7a33780adcb8f4e2625abcd3eec906dfee1f5dcf
2014-11-18 11:52:35 +09:00
Jean Chalard
83f9524b87
Remove the other deprecated constructor to SuggestedWords
...
Change-Id: Ied821df01e032ebc913d2f15dffdf41a51372ea4
2014-11-17 16:23:52 +09:00
Adrian Velicu
91a81a2790
More verbosity when reporting broken dictionaries
...
Also added toString for AssetFileAddress for easier debugging.
Change-Id: Ie5d15d12bae46c31b28d8c67002e627f4c6690e3
2014-11-14 13:42:24 -08:00
Adrian Velicu
39d50e7e7a
Merge "UpdateHandler to support v202 dicts."
2014-11-14 03:45:32 +00:00
Jatin Matani
d60f9c046e
Merge "Implement UserHistoryDictionary for each user account."
2014-11-14 00:46:37 +00:00
Jatin Matani
5365191a9d
Implement UserHistoryDictionary for each user account.
...
UserHistoryDictionary currently uses locale to determine the
UserHistoryDictionary on the filesystem. With this change we
use the account name as well. Thus each UserHistoryDictionary
would following the following spec:
UserHistoryDictionary.<locale>.<account>.dict.
In case no account is selected, we default to the existing
spec:
UserHistoryDictionary.<locale>.dict
Example
UserHistoryDictionary.en_US.testaccount@example.com.dict
Bug: 18104749
Change-Id: Iab031e166b55cf2ded68275a7e9be22475737b37
2014-11-13 14:21:38 -08:00
Tadashi G. Takaoka
d6e367ff5b
Move isRtlLanguage method to LocaleUtils
...
Change-Id: I485a076b81927fed0da593216fea2c740449ef4c
2014-11-12 16:47:38 -08:00
Tadashi G. Takaoka
63e076764b
Merge "Add RichInputMethodSubtype.getKeyboardLayoutSetName"
2014-11-13 00:41:10 +00:00
Tadashi G. Takaoka
6de31466b0
Add RichInputMethodSubtype.getKeyboardLayoutSetName
...
Change-Id: I90cc74ee882e8aa2b243885d3b994223ca3b6f44
2014-11-12 15:41:38 -08:00
Tadashi G. Takaoka
1dfdd9b509
Clean SubtypeLocaleUtils a bit
...
Change-Id: If8b981715983e3a12867c9b7c53bfa5effaddd39
2014-11-12 15:14:52 -08:00
Adrian Velicu
de29278592
UpdateHandler to support v202 dicts.
...
Change-Id: Ib61a5005a82927f5e12a19c9c14f20d46572cf31
2014-11-12 12:04:38 -08:00
Tadashi G. Takaoka
0d6ce46528
Move logic to determine spacebar text to LanguageOnSpacebarHelper
...
Change-Id: Ib9dbbb4bd4e35c15fd752c364d3012e8a7da2410
2014-11-08 18:50:59 -08:00
Tadashi G. Takaoka
ec0d6bb9b7
Merge "Move current subtype management code to RichInputMethodManager"
2014-11-07 18:02:22 +00:00
Jean Chalard
5c4f642df6
Merge "Move util classes under common"
2014-11-07 09:15:35 +00:00
Jean Chalard
5b91b551e5
Move util classes under common
...
Also why did we have two copies of LocaleUtils >.>
Bug: 18108776
Change-Id: I03b4403dfd51934e66b567f2f8b87da419cfb3ab
2014-11-07 18:00:03 +09:00
Jean Chalard
e0c2e5b2f7
Merge "Remove a deprecated constructor to SuggestedWords"
2014-11-07 08:49:26 +00:00
Jean Chalard
c3e211bd6b
Remove a deprecated constructor to SuggestedWords
...
Change-Id: If4d358b3a11fb25fc214c728269519d8c25f9adc
2014-11-07 16:40:24 +09:00
Tadashi G. Takaoka
7286667754
Merge "Move shorcut IME related code from SubtypeSwitcher to RichInputMethodManager"
2014-11-07 06:20:07 +00:00
Jean Chalard
536bf61658
Merge "Remove dicttool dependency to NativeSuggestOptions"
2014-11-07 06:00:40 +00:00
Tadashi G. Takaoka
7fb0ed58ed
Move current subtype management code to RichInputMethodManager
...
Change-Id: I82d5a17a5ec96f26047d29e79f3f28850fc5b3bb
2014-11-06 11:51:07 -08:00
Tadashi G. Takaoka
8a2c4afad4
Move shorcut IME related code from SubtypeSwitcher to RichInputMethodManager
...
Change-Id: I0f95f603d80570c937e8c38ded88df341c11795e
2014-11-06 11:51:07 -08:00
Tadashi G. Takaoka
2a7da0ab87
Move some methods out from SubtypeSwitcher
...
Change-Id: I89aaf87d7d0cc204b0ca0f61c2f64d15e2df848e
2014-11-06 11:51:01 -08:00
Jean Chalard
03eb9de961
Remove dicttool dependency to NativeSuggestOptions
...
Bug: 18108776
Change-Id: I0f57594617f8d5080aea9002b2356d18bfe97043
2014-11-06 21:38:11 +09:00
Jean Chalard
ab68143ad0
Fix a bug where LatinIME would recorrect with no input view
...
Bug: 18071127
Change-Id: I634d1f63f7d5c5b7453ed7559f9b65fa0433dcd8
2014-11-05 17:41:15 +09:00
Tadashi G. Takaoka
98dfa6e334
Fix MainKeyboardView visibility must be aligned with main keyboard frame
...
Bug: 18105755
Change-Id: Ifdcaded538d0eac3b100486ddf27ae4314293792
2014-11-04 13:17:07 +09:00
Ken Wakasa
f296e7cdfa
Small comment fixes
...
Change-Id: Iecb432c414eadf13ee6a57fb21fc02d1c27e777f
2014-11-02 23:54:20 +09:00
Keisuke Kuroyanagi
b3bae2e89b
Merge "Update v4 format version from 402 to 403."
2014-10-31 14:19:44 +00:00
Tadashi G. Takaoka
ef8068f9a8
Merge "Add helper methods to convert flags to readable text"
2014-10-31 10:12:37 +00:00
Keisuke Kuroyanagi
ea468cc9de
Update v4 format version from 402 to 403.
...
Without personalization:
Total words: 1134774, Success Num: 899230, Success Percentage: 79.243%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1871, Bad Failure Percentage: 0.165%
Failures, with auto-correction (F-C): 29084, F-C Percentage: 2.563%
Max Keystrokes: 6072959, Min Keystrokes: 4436090, Keystroke Saving Percentage:26.953%
Before:
Total words: 1134646, Success Num: 925194, Success Percentage: 81.540%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1316, Bad Failure Percentage: 0.116%
Failures, with auto-correction (F-C): 28288, F-C Percentage: 2.493%
Max Keystrokes: 6072831, Min Keystrokes: 3946188, Keystroke Saving Percentage:35.019%
After
Total words: 1134659, Success Num: 944746, Success Percentage: 83.263%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28016, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3387333, Keystroke Saving Percentage:44.222%
Change-Id: I3af42ec37a11847c0429c28616e726f6a339247f
2014-10-31 17:23:39 +09:00
Jean Chalard
5840a7c6e7
Merge "Remove Dict dependency on WordComposer and ProximityInfo"
2014-10-31 07:59:12 +00:00
Tadashi G. Takaoka
9dc3ae84ee
Add helper methods to convert flags to readable text
...
Change-Id: I23608927cef8a897ff4ad8c938560cc78093ddac
2014-10-31 16:20:20 +09:00
Ken Wakasa
ed575b62da
Merge "Add documentation for CollectionUtils#arrayAsList"
2014-10-31 07:07:07 +00:00
David Faden
d443146c34
Add documentation for CollectionUtils#arrayAsList
...
(This is a cherrypick of http://ag/576739 )
Also, modify the IllegalArgumentException to capture the
values passed for start, end, and array.length to make
debugging easier in the unlikely event that it is thrown.
Add corresponding tests for the exceptions.
Tested:
tapas LatinImeGoogle LatinImeGoogleTests userdebug
make -j30 && \
adb install -r \
out/target/product/generic/data/app/LatinImeGoogleTests/LatinImeGoogleTests.apk && \
adb install -r \
out/target/product/generic/system/app/LatinImeGoogle/LatinImeGoogle.apk && \
adb shell am instrument -w -e class \
com.android.inputmethod.latin.utils.CollectionUtilsTests \
com.google.android.inputmethod.latin.tests/android.support.test.runner.AndroidJUnitRunner
Change-Id: I0c579ca4f4f2a9b2575aa6f8fa75e3ee4a21cf8a
2014-10-31 06:18:35 +00:00
Adrian Velicu
88480f39f6
Update unit tests for new static dict version.
...
Bug: 11031090
Change-Id: Ifd7b241f1a0a30678ca7de97cc6e96927a9b5c8f
2014-10-31 14:50:18 +09:00
Adrian Velicu
7c87859d4c
Using "blacklist" flag as "possibly offensive"
...
Bug: 11031090
Change-Id: I5cc0d006ab003656498eb82b0875eb9c051d331e
2014-10-31 14:33:05 +09:00
Andy Wang
0ca400c827
Merge "Add a preference to resize the keyboard height."
2014-10-30 03:37:26 +00:00
Andy Wang
bb9400aebc
Add a preference to resize the keyboard height.
...
The keyboard height is controlled by a slider in the debug preferences.
Without access to debug preferences, this change is a no-op.
Bug: 6867494
Change-Id: I984064ed1cab752876615f5ed582818474d6041b
2014-10-30 11:45:41 +09:00
Tadashi G. Takaoka
051f8b1442
Consolidate similar methods
...
This CL consolidates similar methods in MainKeyboardView.
- startWhileTypingFadeinAnimation and startWhileTypingFadeoutAnimation
- showSlidingKeyInputPreview and dismissSlidingKeyInputPreview
Change-Id: I607ab74683820de2456af3e75663cf8cf358ab38
2014-10-30 11:15:59 +09:00
Tadashi G. Takaoka
4e0149c22a
Merge "Remove DrawingHandler"
2014-10-29 13:42:44 +00:00
Jean Chalard
93e5cdea71
Merge "[CS8] Add explanations"
2014-10-29 12:26:23 +00:00
Tadashi G. Takaoka
2ad6d9cda3
Remove DrawingHandler
...
Change-Id: I658a5b16cca1e56f0b944009b8aef09e0a97a0db
2014-10-29 18:51:41 +09:00
Tadashi G. Takaoka
ca6e5dfedb
Remove DrawingHandler.Callbacks.dismissAllKeyPreviews()
...
Change-Id: I2b11ca0dec0f3522648557a9a909f305cc4170fb
2014-10-29 15:25:09 +09:00
Jean Chalard
ecab6aff59
Remove Dict dependency on WordComposer and ProximityInfo
...
Bug: 18108776
Change-Id: I9b399a44241e05a7add9bb8094263aa76de37880
2014-10-29 12:27:24 +09:00
Jean Chalard
36799b2aa2
Move InputPointers and ResizableIntArray to common
...
Bug: 18108776
Change-Id: Ie5c0430aa41a8d6c58bf510a10173223d7dfe9fe
2014-10-29 12:09:11 +09:00
Jean Chalard
4beeb9253a
Move StringUtils under common.
...
Bug: 18108776
Change-Id: Ia46a4102a0e86e71118ca5e641f9f531998e166b
2014-10-28 22:44:30 +09:00
Jean Chalard
ca724ef71f
Reduce StringUtils dependency on the Android libs
...
Bug: 18108776
Change-Id: I43feb25d79f89276d44462ba71788a14c4583277
2014-10-28 22:03:18 +09:00
Tadashi G. Takaoka
fec5219974
Fix Serbian Latin subtype handling
...
This CL also adds unit tests for Hinglish and Serbian Latin.
Bug: 9687668
Bug: 17169632
Change-Id: Ib9aa1bcdf5b390a9d8c61f07165beacf850e2692
2014-10-28 18:36:16 +09:00
Tadashi G. Takaoka
395009c03e
Fix NPE in AppearanceSettingsFragment
...
Bug: 18147440
Change-Id: I7a7a47b3484e54146d34d11b5bd9c1305421d829
2014-10-28 15:02:31 +09:00
Jean Chalard
67527f847e
[CS8] Add explanations
...
Bug: 13238601
Change-Id: I72a78be5848485f7fd77f5586573692529c7547b
2014-10-28 13:41:00 +09:00
Tadashi G. Takaoka
d5455fea4a
Merge "Add null analysis annotation to CollectionUtils"
2014-10-27 09:43:22 +00:00
Tadashi G. Takaoka
7a3de4dca9
Add null analysis annotation to CollectionUtils
...
Change-Id: I3a610b037d6d1431cced3ea193171108bd5a040d
2014-10-27 18:30:29 +09:00
Tadashi G. Takaoka
f6a6371096
Refactor CoordinateUtils
...
Change-Id: I607b803273a4d7983e9e25a81b6941a3b59194c6
2014-10-27 18:02:33 +09:00
Tadashi G. Takaoka
f7e01e866f
Remove device checking of Emoji physical key
...
This CL also adds a settings option to enable/disable an Emoji-ALT
physical key.
Bug: 18122464
Change-Id: Iee1d97efec979a902b0492071d5e511ca1792ff0
2014-10-27 16:26:22 +09:00
Keisuke Kuroyanagi
aad188d40a
Merge "Height of the keyboard for spellchecker is too large."
2014-10-24 06:29:10 +00:00
Keisuke Kuroyanagi
6cc318bd6a
Height of the keyboard for spellchecker is too large.
...
Bug: 18109041
Change-Id: I0eb98a66290058c28e20c86f36395af4f763952e
2014-10-24 14:59:52 +09:00
Ken Wakasa
7e88eae623
Add missing header
...
Change-Id: I1befc2f1288674b4d871b27bdc5251b2b95e8bb7
2014-10-24 12:00:26 +09:00
Ken Wakasa
9342484e8d
Move Constants.java to the latin.common package
...
Our intention is to have classes of latinime-common under the common
package as much as we can.
Change-Id: I76efbbbe7bebf1a4aa943715cdff64f91675e20d
2014-10-23 20:27:37 +09:00
Jean Chalard
b224594aca
Merge "Fix a concurrency bug that ends up in a crash."
2014-10-23 08:02:37 +00:00
Keisuke Kuroyanagi
ade5ad1dae
Merge "Use trigrams for personalization dict."
2014-10-23 05:42:38 +00:00
Keisuke Kuroyanagi
16cc3992d7
Use trigrams for personalization dict.
...
5Bug: 14425059
Change-Id: I73cf6904e569d60996a3b079f16ea6df0cb90f02
2014-10-23 14:32:45 +09:00
Ken Wakasa
b11fc7d423
Move annotations classes to latiime-common
...
Move Constants.java too.
Change-Id: I55e8cf06f61c0a37746a7328834a52a5306cf0f2
2014-10-23 13:00:46 +09:00
Jean Chalard
4097a20b36
Fix a concurrency bug that ends up in a crash.
...
Bug: 18085768
Change-Id: I016bec997787839526ddfc521ebb99d0c7b05189
2014-10-23 12:36:42 +09:00
Tadashi G. Takaoka
d3a4c51324
Fix Javadoc and null analysis related warnings
...
This CL also adds @SuppressWarning("unused" to java-overridable package.
Bug: 18003991
Change-Id: If70527e30654384705d7a814f5efd181d9f539e1
2014-10-23 09:58:42 +09:00
Keisuke Kuroyanagi
b5ef884fbb
Support dumping ngram entries.
...
Bug: 14425059
Change-Id: Ib03a0c3d166ed6f1e60c67127b28006d55143b6b
2014-10-22 18:15:53 +09:00
Yohei Yukawa
baecaa5411
Merge "Remove BuildCompatUtils.VERSION_CODES_LXX"
2014-10-22 02:01:32 +00:00
Yohei Yukawa
66d30a4b22
Remove BuildCompatUtils.VERSION_CODES_LXX
...
Finally it is turned out to be a XXL-size Lollipop.
Change-Id: Icbd22506be9de514eba287cdd8d97fbfd070ac09
2014-10-22 01:29:58 +09:00
Yohei Yukawa
63cbdf49b9
Add @Override for a method that is overriding a new L API
...
Now all the downstream builds have switched to API Level 21.
Hence putting @Override to new APIs no longer makes javac unhappy.
Change-Id: Ib3324a5d06b17d298beacab8c8802bb14e5be968
2014-10-22 01:28:10 +09:00
Tadashi G. Takaoka
46a007261f
Merge "Fix some compiler warnings"
2014-10-21 15:06:55 +00:00
Tadashi G. Takaoka
5f00fe09e9
Fix some compiler warnings
...
This CL fixes the following compiler warnings.
- Indirect access to static member
- Access to a non-accessible member of an enclosing type
- Parameter assignment
- Method can be static
- Local variable declaration hides another field or variable
- Value of local variable is not used
- Unused import
- Unused private member
- Unnecessary 'else' statement
- Unnecessary declaration of throw exception
- Redundant type arguments
- Missing '@Override' annotation
- Unused '@SuppressWarning' annotations
Bug: 18003991
Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
2014-10-21 19:28:37 +09:00
Tadashi G. Takaoka
2105aa3ea6
Merge "FIx potential NPE"
2014-10-21 08:14:46 +00:00
Tadashi G. Takaoka
097bcdcde8
FIx potential NPE
...
Bug: 18052047
Change-Id: I9097d0a504b8a1d875cf66e44bb65eb6ecc8908e
2014-10-21 14:13:27 +09:00
Adrian Velicu
05172bf1a5
Renaming "blacklist" flag to "possibly offensive"
...
No behaviour changes.
Unified the overloaded FusionDictionary::add method to always take an
isPossiblyOffensive argument.
Bug: 11031090
Change-Id: I5741a023ca1ce842d2cf10d4f6c926b0efabaa78
2014-10-21 11:51:47 +09:00
Tadashi G. Takaoka
b0ccf3a0a2
Refactor CustomInputStyleSettingsFragment
...
Bug: 18003991
Change-Id: Ib005dd394faf546e4faed89ff2018ce49858a06e
2014-10-20 17:12:33 +09:00
Keisuke Kuroyanagi
1085fef8d0
Change entry count limit.
...
Unigram 10K, Bigram 30K, Trigram 30K.
Change-Id: Ibd19c6a2b618499df1c70000bad7b47498187f0a
2014-10-20 15:01:49 +09:00
Nick Kralevich
237f6ca799
fix build
...
Change-Id: I58a94fc0be01f272b6ad12524946f073c9f49894
2014-10-18 06:50:03 -07:00
Jean Chalard
ea32e8fb04
Merge "Enforce a length limit to auto-correction for some languages"
2014-10-17 13:11:39 +00:00
Jean Chalard
8fc872762f
Enforce a length limit to auto-correction for some languages
...
Bug: 15379262
Change-Id: I27fad12f468b5bc6ad1a0876aac72e5f5ca5760a
2014-10-17 22:05:05 +09:00
Tadashi G. Takaoka
ad2f695083
Bring back long press timeout settings
...
Bug: 18025209
Change-Id: Id8dbb051e04270f6892cae12a443103bd0d32dcb
2014-10-17 18:20:43 +09:00
Jean Chalard
bd4693cd3f
Merge "[ML27.1] Allow adding additional features to other settings"
2014-10-16 11:08:37 +00:00
Jean Chalard
bdf70af177
[ML27.1] Allow adding additional features to other settings
...
We may want to add additional features from some of the
other screens.
Bug: 11230254
Bug: 17966252
Change-Id: I1bb877e5cbdd74f2ffa8010b5bc6af35fe77279a
2014-10-16 19:32:00 +09:00
Jean Chalard
eaa7efd136
[ML29] Reinitialize the subtype at input start
...
Bug: 11230254
Bug: 17994347
Change-Id: I3476909c4b371d6e94a0d4c35d91e109d639b8d5
2014-10-16 18:43:14 +09:00
Jean Chalard
f13487dfbf
[ML25] Add an hasDict method.
...
We used to have separate methods for existence of dicts
according to whether it's a file or a resource. This unifies both.
Bug: 11230254
Bug: 17979623
Change-Id: I728773461f3465f756d06297c3f3bee34390c3e6
2014-10-16 17:09:27 +09:00
Jean Chalard
17100ad8ea
am 8435acd7
: am f7f786d8
: am d9c04a6b
: am 6456af0e
: am ecea8551
: Fix a bug with no suggestions flag
...
* commit '8435acd789bd4f9c1322a73b9e0567c2dee7b336':
Fix a bug with no suggestions flag
2014-10-15 07:52:58 +00:00
Jean Chalard
ecea8551c3
Fix a bug with no suggestions flag
...
We should reset the composition state when moving the cursor inside
the word after a gesture when the text field specifies no suggestions.
Bug: 17959921
Change-Id: I977fea775f7b7e145e343636f0fb94266a40953a
2014-10-15 06:15:02 +00:00
Sandeep Siddhartha
b17a3bc4e8
Move sync policy related code out of account settings
...
Bug: 17981687
Bug: 17464069
Change-Id: I0ae3400564fd346cc84af74dfef65f01cc1ce6a8
2014-10-14 13:39:28 -07:00
Tadashi G. Takaoka
296b11503e
Merge "Add JSR305 annotation to LeakGuardHandlerWrapper"
2014-10-14 12:30:12 +00:00
Jean Chalard
10ac940312
Merge "[ML24] Add facilities to read the script of a subtype"
2014-10-14 11:26:07 +00:00
Jean Chalard
b256bb5791
[ML24] Add facilities to read the script of a subtype
...
...or more exactly, the script of the keyboard layout set associated
with a given subtype.
Bug: 11230254
Change-Id: I82f5fc81ecffc561781816008c853be6ff9438dd
2014-10-14 20:19:15 +09:00
Keisuke Kuroyanagi
d1471ee053
Merge "Remove shouldBlockAutoCorrectionBySafetyNet"
2014-10-14 10:52:32 +00:00
Tadashi G. Takaoka
c4ffa235e5
Add JSR305 annotation to LeakGuardHandlerWrapper
...
Change-Id: I7456200af739db4510c5549b7bc894fb48749455
2014-10-14 18:19:22 +09:00
Ken Wakasa
95f100ba40
Merge "Performance fix for multiple language subtypes"
2014-10-14 06:42:14 +00:00
Jean Chalard
d15f6e8c98
Performance fix for multiple language subtypes
...
The code would iterate all enabled subtypes each time
getCurrentSubtype() is called, which is really quite frequent.
Bug: 11230254
Change-Id: I91feb36de6eca84967e848fc585aae04b350be89
2014-10-14 15:13:35 +09:00
Jean Chalard
9959140f15
Merge "Fix an NPE."
2014-10-14 02:51:16 +00:00