nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
5384 commits 1 branch 0 tags 363 MiB
Commit graph

2265 commits

Author SHA1 Message Date
Jean Chalard
9dedec7c29 Make a method accessible for tests 
Tests are using a wrapper method that's going to disappear soon.
The method that becomes package-visible now is destined to be
removed too a little later.

Change-Id: If99b1c77ed52e050b47216cc7afab5f35c4bbb38
 2012-03-12 16:11:16 +09:00
Ken Wakasa
c1ca8815f5 Fix an obvious bug in handleLanguageSwitchKey() 
bug: 5759092

Change-Id: I8c7b2ef024cbab399d96f6b3ec553da4e9d2fb18
 2012-03-11 00:44:47 +09:00
Jean Chalard
1a85b74adb Entirely remove safety net memory. 
mHasAutoCorrectionCandidate now includes the fact that this
did not get caught by the safety net. This is more intuitive.

Change-Id: I6502bbf1ca64a0a6d64f55d723305cf78352a656
 2012-03-09 22:10:25 +09:00
Jean Chalard
68823ae08e Make the safety net memory private 
Change-Id: I10959d47c980d2e8f2ea995955acf02193e3ff7b
 2012-03-09 22:01:15 +09:00
Jean Chalard
ebbb7e9665 Recompute safety net in debug cases instead of memorizing 
Change-Id: I67f3a31db081afa4871ec441dd461c56e098c668
 2012-03-09 22:00:23 +09:00
Jean Chalard
682c2d53cc Make access to the safety net calculation easier 
Change-Id: If33897b38af94ae81b05e5ef140a542724b9f34a
 2012-03-09 21:44:40 +09:00
Jean Chalard
151d5cb532 Extract a condition from a method 
Change-Id: I6b0262fe7cb3f7a31cc19d724c301467be932640
 2012-03-09 21:37:44 +09:00
Jean Chalard
36c1b37914 Remove a useless argument 
Change-Id: I713433a3225193489fad5bdafcf302b529903116
 2012-03-09 21:24:47 +09:00
Jean Chalard
28e59b98c6 Remove a useless escape 
Change-Id: I1ef0685cc9888c9cef9f60015d32b66dde75ef9b
 2012-03-09 21:10:55 +09:00
Jean Chalard
d5f618e90a Remove a useless test 
If we are not composing a word here, we have already returned

Change-Id: I63281abace777e3658286d4df6781d2cd5a29c33
 2012-03-09 20:53:45 +09:00
Jean Chalard
c5d2bb786e Don't use an intermediate object with a different meaning 
Change-Id: Ie89916b49c852a51385ffd61cb596a58f23a46a0
 2012-03-09 20:51:33 +09:00
Jean Chalard
ed9986824e Move some auto-correction logic to where it belongs 
Change-Id: I897c5ec3a630a4a6bfc593906df4d3fc7b244482
 2012-03-09 20:45:37 +09:00
Jean Chalard
dfd4abe818 Fix a shameful bug 
I must have been sleeping when I wrote that

Change-Id: I887180ab610785a2000636adeeed99230b3c5390
 2012-03-09 19:31:35 +09:00
Jean Chalard
0cf422fbb7 Reduction, step 8 
Change-Id: I54334039597e235e24f169e34c1d44109180ee88
 2012-03-09 19:00:29 +09:00
Jean Chalard
a333ff19ef Reduction, step 7 
Change-Id: I177ef2f29c8b6000c5e3d021c016c5d216fe3fc6
 2012-03-09 18:59:20 +09:00
Jean Chalard
a3ee019331 Reduction, step 6 
Change-Id: I22ad4cea0e0cac23813da7e788f5c94974ce0ebf
 2012-03-09 18:58:01 +09:00
Jean Chalard
dbd140504d Reduction, step 5 
Change-Id: Iac52e62c2bdffad14f916f69eade2b785bb41767
 2012-03-09 18:44:23 +09:00
Jean Chalard
0b96bc4b2b Reduction, step 4 
Change-Id: Ib27dc6e9486c3f0f2ec1e94a88a52d12c1af2d38
 2012-03-09 18:44:20 +09:00
Jean Chalard
5a61d03f31 Reduction, step 3 
Change-Id: I0e08b102c9539d97c473505b9d42176c4a7c8853
 2012-03-09 18:44:16 +09:00
Jean Chalard
8abd15b59f Reduction, step 2 
Change-Id: I06e117df43d25dbaf9fc7a7366efd9355a6215ce
 2012-03-09 18:44:10 +09:00
Jean Chalard
f08f30176b Reduction, step 1 
Change-Id: Ic3ed04300cfd4c0b69b93b27379aca4093b32f67
 2012-03-09 18:38:44 +09:00
Jean Chalard
de165aed2a Separate bigram prediction from suggestion process 
Change-Id: Ibdef206fbd6688a45cebbd7fb8a9f6cd175d03b0
 2012-03-09 18:38:20 +09:00
Jean Chalard
6f722c8301 Remove useless stuff 
Change-Id: I462d24da2d26661990d6aab2a13fde851763fd61
 2012-03-09 18:36:52 +09:00
Jean Chalard
67af2a2415 Export some more logic out of Latin IME 
Change-Id: Ib264533a05e9e09347bf254789e6ab5beec92400
 2012-03-09 18:36:49 +09:00
Jean Chalard
df9fce5df1 Export some logic out of LatinIME 
Hopefully that will end in Suggest/SuggestedWords being autonomous
and won't need the logic spoon-fed to them

Change-Id: I915661bce13c69c8a5b8e5d4a8c41e18fea594cf
 2012-03-09 18:36:45 +09:00
Jean Chalard
91e55ac000 Small optimization 
We only use some of those results in one branch of an if() test.
Let's not compute those that are not needed.

Change-Id: I6ca068646b86d2980fb88e75b110ad077362c4ff
 2012-03-09 16:47:43 +09:00
Jean Chalard
195419b1ec Small reorganization 
...resulting in a slight optimization

Change-Id: I83a9b8c92c3d93ce75988285997ec138b3ffe52e
 2012-03-09 16:41:35 +09:00
Jean Chalard
838629aea0 Remove useless test 
typedWord may not be null here

Change-Id: I9e7afb89fafbf6fcbc91fbc132aecc06aec8979f
 2012-03-09 15:52:23 +09:00
Jean Chalard
d48b76267a Merge "Remove a useless test (B7)" 2012-03-08 22:26:20 -08:00
Jean Chalard
2d82757fc6 Merge "Rename a parameter (B6)" 2012-03-08 22:23:33 -08:00
Jean Chalard
de19ab878d Merge "Remove useless tests (B5)" 2012-03-08 22:22:56 -08:00
Jean Chalard
5a7cb9305a Merge "Remove a provably useless test (B4)" 2012-03-08 22:22:20 -08:00
Jean Chalard
54392438c5 Merge "Optimize and clean up (B2)" 2012-03-08 22:00:02 -08:00
Jean Chalard
90bd4efd10 Remove a useless test (B7) 
consideredWord is provably never null.

Change-Id: Ifaa0d2471c46f14967e70ad004d2b82f841a4566
 2012-03-09 14:55:46 +09:00
Jean Chalard
cf8bc92ba0 Rename a parameter (B6) 
This is not necessarily the typed word. Actually, the parameter
that's passed here has trailing single quotes culled out of it.

Change-Id: Ia2038faa2cbbd3a5b8263e6c0fb5b8e670993fe9
 2012-03-09 14:52:35 +09:00
Jean Chalard
92146f2926 Remove useless tests (B5) 
WordComposer#getTypedWord() may not return null. Don't test for it.

Change-Id: I6aff14892503d0c275a3328c404ed99d2f40a687
 2012-03-09 14:52:04 +09:00
Jean Chalard
31a5da28e3 Merge "Move some code around (B1)" 2012-03-08 21:15:25 -08:00
Jean Chalard
8cd847c2fa Remove a provably useless test (B4) 
If !mInputAttributes.mInputTypeNoAutoCorrect then mCorrectionMode
will not have allowed #hasAutoCorrection() to return true.

Change-Id: I1b498d5aeb26194c765cc9b9dcb24d980de43894
 2012-03-09 12:56:48 +09:00
Jean Chalard
94b20c90d8 Optimize and clean up (B2) 
Stop parameters from escaping and don't do useless work and
simplify the code.
Yay.

Change-Id: I0dfc3e14b1cb50e0730f6d9c1d52b54516baa90e
 2012-03-09 12:51:55 +09:00
Jean Chalard
dc5dfe37e0 Move some code around (B1) 
The goal is to make the creation of the Builder closer to
the #build() call

Change-Id: I48d76d4efdc180479829016582edd9de47e7332c
 2012-03-09 12:33:23 +09:00
Jean Chalard
13fb8fb775 Limit escape of parameters 
Change-Id: I3a7ab069042d5542ab2e033d1eeb13d718cd7698
 2012-03-09 12:30:23 +09:00
Jean Chalard
23a5e9d1a7 Merge "Make AutoCorrection static and non-instantiable (A5)" 2012-03-08 19:05:30 -08:00
Jean Chalard
2621fe2256 Merge "Move a memory in the container class (A4)" 2012-03-08 19:04:56 -08:00
Jean Chalard
427dfe37ec Merge "Remove an unused method" 2012-03-08 18:31:26 -08:00
Jean Chalard
cbbfa15765 Merge "Make AutoCorrection a step closer to being static (A3)" 2012-03-08 18:30:19 -08:00
Jean Chalard
58722d83f0 Merge "Stop uselessly remembering a value (A2)" 2012-03-08 18:30:10 -08:00
Jean Chalard
caae6df0ce Remove an unused method 
Who would have guessed this wasn't being called at all.

Change-Id: Ib74a212356ea44e9bf149619ed5464c14684a1ba
 2012-03-09 11:10:55 +09:00
Jean Chalard
21af2f40c5 Merge broadcast receivers again 
It's probably simpler not to have registers dance around,
and just message the feedback manager when the audio event
happens.

Change-Id: Id0710ed102d10d01f1af93ad8cb660653bb3a9f8
 2012-03-09 11:00:23 +09:00
Jean Chalard
7b77c683d7 Fix a crash 
Bug: 6137076
Change-Id: I05f9f72a2678d10d3400dab5fc71544276739dcf
 2012-03-09 10:29:51 +09:00
Jean Chalard
39286f98bc Merge "Remove useless stuff (A1)" 2012-03-08 04:02:46 -08:00