Commit graph

34612 commits

Author SHA1 Message Date
Adrian Velicu
009e02ce4a Further fixes to treat 0-frequency words
Previously, when both legitimate 0-frequency words (such as
distracters) and offensive words were encoded in the same
way, distracters would never show up when the user blocked
offensive words (the default setting, as well as the setting
for regression tests).

When b/11031090 was fixed and a separate encoding was used
for offensive words, 0-frequency words would no longer be
blocked when they were an "exact match" (where case
mismatches and accent mismatches would be considered an
"exact match"). The exact match boosting functionality meant
that, for example, when the user typed "mt" they would be
suggested the word "Mt", although they most probably meant
to type "my".

For this reason, we introduced this change, which does the
following:
* Defines the "perfect match" as a really exact match, with
no room for case or accent mismatches
* When the target word has probability zero (as "Mt" does,
because it is a distracter), ONLY boost its score if it is a
perfect match.

By doing this, when the user types "mt", the word "Mt" will
NOT be boosted, and they will get "my". However, if the user
makes an explicit effort to type "Mt", we do boost the word
"Mt" so that the user's input is not autocorrected to "My".

Bug: 11031090
Change-Id: I92ee1b4e742645d52e2f7f8c4390920481e8fff0
2014-10-31 15:58:50 +09:00
Adrian Velicu
10416241f7 Block offensive words in multi-word suggestions
If the user has chosen to block offensive words and types
"aaaxbb", where "aaa" is an offensive word and "bb" is not,
we should not suggest "aaa bb".

Bug: 11031090
Change-Id: Ie23b8dd5d347bc26b1c046c3f5e8dfbc259bf528
2014-10-31 15:58:50 +09:00
Adrian Velicu
61d43e5c94 Merge "Update unit tests for new static dict version." 2014-10-31 06:49:51 +00:00
Adrian Velicu
f59c3b6238 Merge "Update dictionaries (possibly_offensive flag)" 2014-10-31 06:49:42 +00:00
Adrian Velicu
aa20342d7e Merge "Using "blacklist" flag as "possibly offensive"" 2014-10-31 06:49:29 +00:00
David Faden
d443146c34 Add documentation for CollectionUtils#arrayAsList
(This is a cherrypick of http://ag/576739)

Also, modify the IllegalArgumentException to capture the
values passed for start, end, and array.length to make
debugging easier in the unlikely event that it is thrown.
Add corresponding tests for the exceptions.

Tested:
tapas LatinImeGoogle LatinImeGoogleTests userdebug
make -j30 && \
adb install -r \
out/target/product/generic/data/app/LatinImeGoogleTests/LatinImeGoogleTests.apk && \
adb install -r \
out/target/product/generic/system/app/LatinImeGoogle/LatinImeGoogle.apk && \
adb shell am instrument -w -e class \
com.android.inputmethod.latin.utils.CollectionUtilsTests \
com.google.android.inputmethod.latin.tests/android.support.test.runner.AndroidJUnitRunner

Change-Id: I0c579ca4f4f2a9b2575aa6f8fa75e3ee4a21cf8a
2014-10-31 06:18:35 +00:00
Adrian Velicu
88480f39f6 Update unit tests for new static dict version.
Bug: 11031090
Change-Id: Ifd7b241f1a0a30678ca7de97cc6e96927a9b5c8f
2014-10-31 14:50:18 +09:00
Adrian Velicu
8dd31a28ae Update dictionaries (possibly_offensive flag)
Correctly encoding possibly offensive words with their correct
frequency and the possibly_offensive flag set.

Continuing to encode with zero frequency only distracters or
words that should never come up.

https://paste.googleplex.com/5167060875214848

Bug: 11031090
Change-Id: Ia394b1827f292ff8d4791cc2f3e6e50b5aff4cbe
2014-10-31 14:49:24 +09:00
Adrian Velicu
7c87859d4c Using "blacklist" flag as "possibly offensive"
Bug: 11031090
Change-Id: I5cc0d006ab003656498eb82b0875eb9c051d331e
2014-10-31 14:33:05 +09:00
Tadashi G. Takaoka
8523720b22 Remove deprecated Canvas.clipRegion(Region) call
Change-Id: I88e0a8d327c17bf4bafbe44cdfa265f5d0acb879
2014-10-31 14:06:30 +09:00
Keisuke Kuroyanagi
0cd1f222fd Fix: native unit test build.
Change-Id: Id2bd4b60d6a4023815a630ebb3059a435b72c193
2014-10-31 12:50:45 +09:00
Keisuke Kuroyanagi
c096100b01 Merge "Enable count based dynamic ngram language model for v403." 2014-10-31 03:15:20 +00:00
Baligh Uddin
b2039bcd7b Import translations. DO NOT MERGE
Change-Id: I7e725d123380b47feb9f3442cf5ac4299997d1a9
Auto-generated-cl: translation import
2014-10-30 11:06:09 -07:00
Baligh Uddin
f6a4367279 Import translations. DO NOT MERGE
Change-Id: I7db7b88569ffbe44449f97950cb337ea2f3b1761
Auto-generated-cl: translation import
2014-10-30 11:04:58 -07:00
Baligh Uddin
d107ca5b4e Import translations. DO NOT MERGE
Change-Id: I58e9e2b6fbeea9369903208642f548dcd60db631
Auto-generated-cl: translation import
2014-10-30 11:01:30 -07:00
Baligh Uddin
de4da90db2 Import translations. DO NOT MERGE
Change-Id: I2c081d71d715a47d2baabd8069d6cdf28ca03cdc
Auto-generated-cl: translation import
2014-10-30 11:00:41 -07:00
Baligh Uddin
34bca016c7 Import translations. DO NOT MERGE
Change-Id: I6427702f2022b2423ef102b00edff0a7ffe5122a
Auto-generated-cl: translation import
2014-10-30 11:00:06 -07:00
Baligh Uddin
980c86dcff Import translations. DO NOT MERGE
Change-Id: I5a18946cc2b568f649028a1bc50a4f78e6aad0af
Auto-generated-cl: translation import
2014-10-30 10:59:28 -07:00
Baligh Uddin
bfe51d5938 Import translations. DO NOT MERGE
Change-Id: I19b5c3a4956bbf3e22566cce7f74791a98869727
Auto-generated-cl: translation import
2014-10-30 10:58:15 -07:00
Keisuke Kuroyanagi
bcb52d73e2 Enable count based dynamic ngram language model for v403.
Bug: 14425059

Change-Id: Icc15e14cfd77d37cd75f75318fd0fa36f9ca7a5b
2014-10-30 23:38:19 +09:00
Keisuke Kuroyanagi
04a492cb49 Merge "Add DynamicLanguageModelProbabilityUtils." 2014-10-30 14:08:17 +00:00
Keisuke Kuroyanagi
660b00477c Add DynamicLanguageModelProbabilityUtils.
Bug: 14425059
Change-Id: Ia58ab3f0ead02798046d182a9464dcbd95f086bc
2014-10-30 21:33:57 +09:00
Tadashi G. Takaoka
77947c9c96 Merge "Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy" 2014-10-30 09:55:51 +00:00
Tadashi G. Takaoka
34a9e2ae87 Make DrawingProxy and TimerProxy as a top-level interface
Change-Id: Ia425f341255595f8f80c13b2aa409249f9ce4202
2014-10-30 18:29:49 +09:00
Tadashi G. Takaoka
be708c4e59 Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy
Change-Id: I654f7483d1c013ac2685a45af4eb2af15fa219ad
2014-10-30 18:28:40 +09:00
Keisuke Kuroyanagi
5286073529 Merge "Add method to encode probability." 2014-10-30 03:46:19 +00:00
Keisuke Kuroyanagi
0a9c3f30b6 Add method to encode probability.
Bug: 14425059
Change-Id: I3e5d359ba5fa38f1669f0e98dfae792ff53efbf8
2014-10-30 12:42:35 +09:00
Andy Wang
0ca400c827 Merge "Add a preference to resize the keyboard height." 2014-10-30 03:37:26 +00:00
Tadashi G. Takaoka
d9b1327c21 Merge "Consolidate similar methods" 2014-10-30 02:54:38 +00:00
Andy Wang
bb9400aebc Add a preference to resize the keyboard height.
The keyboard height is controlled by a slider in the debug preferences.
Without access to debug preferences, this change is a no-op.

Bug: 6867494
Change-Id: I984064ed1cab752876615f5ed582818474d6041b
2014-10-30 11:45:41 +09:00
Tadashi G. Takaoka
d2c00f550d Fix dismiss key preview bug introduced by I658a5b16cc
Change-Id: I5248374dfe0504f6e64cc5d994e275d80364ec9d
2014-10-30 11:43:53 +09:00
Tadashi G. Takaoka
051f8b1442 Consolidate similar methods
This CL consolidates similar methods in MainKeyboardView.
- startWhileTypingFadeinAnimation and startWhileTypingFadeoutAnimation
- showSlidingKeyInputPreview and dismissSlidingKeyInputPreview

Change-Id: I607ab74683820de2456af3e75663cf8cf358ab38
2014-10-30 11:15:59 +09:00
Geoff Mendal
c96bb3e9a7 Merge "Import translations. DO NOT MERGE" 2014-10-29 19:14:14 +00:00
Geoff Mendal
4caa03c839 Import translations. DO NOT MERGE
Change-Id: I3643a631ae94f295bdcd4cf4427fd4bcfef00a17
Auto-generated-cl: translation import
2014-10-29 12:02:07 -07:00
Keisuke Kuroyanagi
c2ba0ce411 Fix: TRT and ime-simulator bulid.
Change-Id: I1697a907562d1ed6aff2b001763d1594263ba0d3
2014-10-30 01:01:40 +09:00
Tadashi G. Takaoka
4e0149c22a Merge "Remove DrawingHandler" 2014-10-29 13:42:44 +00:00
Jean Chalard
93e5cdea71 Merge "[CS8] Add explanations" 2014-10-29 12:26:23 +00:00
Keisuke Kuroyanagi
afe67611c3 Merge "Add a class to have global counters for LanguageModelDictContent." 2014-10-29 12:18:12 +00:00
Keisuke Kuroyanagi
6b0561f9d2 Add a class to have global counters for LanguageModelDictContent.
Bug: 14425059
Change-Id: I08ec19903432356b6028853fd73b4eefce20218e
2014-10-29 21:05:41 +09:00
Tadashi G. Takaoka
2ad6d9cda3 Remove DrawingHandler
Change-Id: I658a5b16cca1e56f0b944009b8aef09e0a97a0db
2014-10-29 18:51:41 +09:00
Tadashi G. Takaoka
ca6e5dfedb Remove DrawingHandler.Callbacks.dismissAllKeyPreviews()
Change-Id: I2b11ca0dec0f3522648557a9a909f305cc4170fb
2014-10-29 15:25:09 +09:00
Jean Chalard
ecab6aff59 Remove Dict dependency on WordComposer and ProximityInfo
Bug: 18108776
Change-Id: I9b399a44241e05a7add9bb8094263aa76de37880
2014-10-29 12:27:24 +09:00
Jean Chalard
36799b2aa2 Move InputPointers and ResizableIntArray to common
Bug: 18108776
Change-Id: Ie5c0430aa41a8d6c58bf510a10173223d7dfe9fe
2014-10-29 12:09:11 +09:00
Tadashi G. Takaoka
80980574ac Fix test breakage
This CL also adds null analysis annotations to StringUtils.

Change-Id: I751932c1ed2579bc10f4584651b997356f180899
2014-10-29 11:52:08 +09:00
Tadashi G. Takaoka
48ee473c1e Merge "Clean up UserDictionaryCompatUtils" 2014-10-29 00:37:43 +00:00
Jean Chalard
4beeb9253a Move StringUtils under common.
Bug: 18108776
Change-Id: Ia46a4102a0e86e71118ca5e641f9f531998e166b
2014-10-28 22:44:30 +09:00
Jean Chalard
8cad60ae88 Fix tests build
Change-Id: I873ab97e2c4b30caa9227d26d7880d5ed6d134b0
2014-10-28 22:37:16 +09:00
Jean Chalard
ca724ef71f Reduce StringUtils dependency on the Android libs
Bug: 18108776
Change-Id: I43feb25d79f89276d44462ba71788a14c4583277
2014-10-28 22:03:18 +09:00
Ken Wakasa
b3b1ba8d4a Fix unit test failures
Change-Id: I1d66a0124961d524f83f7895a2c09e0ee2c1aab4
2014-10-28 19:33:01 +09:00
Tadashi G. Takaoka
1290399123 Merge "Fix Serbian Latin subtype handling" 2014-10-28 09:40:00 +00:00