nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
7546 commits 1 branch 0 tags 363 MiB
Commit graph

3293 commits

Author SHA1 Message Date
Jean Chalard
32ff2504a0 Update the prototype of onAddSuggestedWord - calling side. 
We want to get rid of all those IDs in Latin IME.

Change-Id: Ibe08100a5e2976c80abb049889233b4047a686f3
 2012-06-27 16:17:14 +09:00
Jean Chalard
2db27bcd06 Merge "Use binarySearch instead of a hand-written linear search" 2012-06-26 23:55:46 -07:00
Jean Chalard
78a8d5b6bc Merge "Implement a comparator for SuggestedWordInfos." 2012-06-26 22:55:51 -07:00
Jean Chalard
56beb9e321 Use binarySearch instead of a hand-written linear search 
Yay.

Change-Id: Icf686eb2d675da959f19edc856b521e6288dcea3
 2012-06-27 14:17:29 +09:00
Jean Chalard
9da0027b38 Implement a comparator for SuggestedWordInfos. 
Change-Id: Ic4b0ae05cd98a1aec5806c5e4b744158e73aea7a
 2012-06-27 14:16:23 +09:00
Kurt Partridge
30447239e8 Merge "only output every kth word to log" 2012-06-26 20:49:03 -07:00
Jean Chalard
4ef01c51f8 Merge "Remove some special casing" 2012-06-26 20:33:43 -07:00
Kurt Partridge
e961188e9f only output every kth word to log 
multi-project CL with Ib5b544b9b2d8b0e4419238976b2e274e5ac564f8

Bug: 6188932
Change-Id: Iea68cf36924d6fda126130a98431a6ce02ba251e
 2012-06-26 16:15:20 -07:00
Jean Chalard
7e49a2b6b8 Remove some special casing 
This special casing is useless. If the word is the same as what
user typed, the scoring algorithm already ensures that it comes
out at the top. Actually, as is written in a comment here, code
executed later is actively relying on this suggestion having
the top score ! There is no need to test it for equalness and
inserting it at the top then.

Change-Id: I263a6de59b77ec72a2dcbb933361b8e16fca0681
 2012-06-26 20:40:42 +09:00
Jean Chalard
a3f5f51ec4 Fix a bug where a log would mysteriously not work 
Change-Id: I5ca77ed65e95a6d357215c0e730238fb463986bb
 2012-06-26 20:36:51 +09:00
Jean Chalard
22657dcba0 Optimization. 
We already had that computed

Change-Id: I2a9742eaee2e9db1f73aeddda7bae7e237b4d15c
 2012-06-26 20:02:07 +09:00
Jean Chalard
ec8b27fe49 Cut out a method for clarity 
Change-Id: I1dc668698a5cd840297e713a26a525f5e32d35d6
 2012-06-26 19:49:01 +09:00
Jean Chalard
0131170da9 Merge "Avoid string conversions when possible." 2012-06-26 03:48:01 -07:00
Jean Chalard
5953dc93cf Avoid string conversions when possible. 
Change-Id: Ibf5f3e40da55998364d0d835ecf283f32c80fcf5
 2012-06-26 19:45:52 +09:00
Jean Chalard
5d218bc029 Merge "Simplify a method call." 2012-06-26 03:45:02 -07:00
Jean Chalard
bed514bd90 Simplify a method call. 
Change-Id: Ieede787a13cef79353f13af52488ef3732ac9850
 2012-06-26 19:33:16 +09:00
Jean Chalard
61c1002b6b Merge "Refactor and squash long-standing bugs (A2)" 2012-06-26 03:19:20 -07:00
Tadashi G. Takaoka
abf81192ff Merge "Remove unnecessary variables" 2012-06-26 03:16:17 -07:00
Tadashi G. Takaoka
342ea3d324 Merge "Pass MotionEvent to PointerTracker" 2012-06-26 03:16:12 -07:00
Jean Chalard
9433ce86b7 Refactor and squash long-standing bugs (A2) 
This is awesome.
- Improve performance by stopping useless string/array conversions.
- Simplify method interface.
- Fix localization bugs - we now know our locale
- Fix bugs with surrogate code points

Bug: 4769095
Change-Id: I8a8ee224b713429ee0a4ce5bd52f1b63378cf56f
 2012-06-26 19:12:07 +09:00
Tadashi G. Takaoka
3314d38daf Pass MotionEvent to PointerTracker 
This is a one of groundwork to integrate gesture input.

Change-Id: I5b75c6978b51df91fdc384a9f6d1d5a5ddc563e2
 2012-06-26 19:05:47 +09:00
Jean Chalard
a8c9946b44 Merge "Remember the locale in the Suggest object (A1)" 2012-06-26 03:05:05 -07:00
Tadashi G. Takaoka
7bb8e95b52 Merge "Cleanup PointerTracker debug method" 2012-06-26 03:03:49 -07:00
Tadashi G. Takaoka
0d9d37cec2 Remove unnecessary variables 
Bug: 6722052
Change-Id: I92e85b3e49b8f4b228f0cf0994216c5050e0865c
 2012-06-26 19:01:59 +09:00
Jean Chalard
8e17f6d93a Remember the locale in the Suggest object (A1) 
This will be necessary for uppercasing and titlecasing words
correctly.

Change-Id: I0f446a4c82bc482240ff730a2ad6586a61571d6b
 2012-06-26 18:55:18 +09:00
Jean Chalard
6cad198d9c Remove a useless member (A2) 
Change-Id: Ia727ffc2946352bbf79e0c97684f8fa98f428cef
 2012-06-26 18:42:06 +09:00
Jean Chalard
0da9a7c094 Convert a member to a local variable (A1) 
Change-Id: I9eab910989443704f83711cf4fb0070c5987a13a
 2012-06-26 18:41:49 +09:00
Tadashi G. Takaoka
d7edd1cbb5 Cleanup PointerTracker debug method 
Change-Id: Ib3bfa0a46f5814a6df838005d7243e2f536a98a0
 2012-06-26 18:36:30 +09:00
Jean Chalard
f05392f213 Remove an unused method (A22) 
Change-Id: I2195f365df1799c8b3b2a53670d1df535ab1a742
 2012-06-26 17:59:04 +09:00
Jean Chalard
6234be1fe7 Simplification and optimization (A20) 
Change-Id: Ia837e553ccfe67cd4303096290194a5186df059b
 2012-06-26 17:59:04 +09:00
Jean Chalard
77e95e60bb Preparation for a simplification (A19) 
Change-Id: I4605a571faf5fbc68b18ce525d6019600bfa8cf7
 2012-06-26 17:59:04 +09:00
Jean Chalard
0a79446531 Remove a meaningless separation (A18) 
Change-Id: I267177044c7d7b0d9119839a11057b2bbf41f75f
 2012-06-26 17:59:04 +09:00
Jean Chalard
61e7ec6587 Remove the Callback interface for simpler code. (A17) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I009b54fc2e73cadca6734bdca074d033e81f6a2b
 2012-06-26 17:58:52 +09:00
Jean Chalard
2f1b6c9ea4 Remove the callback argument to getBigrams() (A16) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I7457ac04f8cd4019fb86c986725aae3de1b1a65e
 2012-06-26 17:54:49 +09:00
Jean Chalard
60eed92dc3 Remove the callback argument to getWords() (A15) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I919bf70a1213ab5d7c7a9e5715bd72a6e257148b
 2012-06-26 17:36:47 +09:00
Jean Chalard
2225b3bace Do away with Utils#addAllSuggestions (A14) 
It's not used any more.

Change-Id: Id9da40fdbf7078f3ac647d1368237d6601f5a2ba
 2012-06-26 17:36:47 +09:00
Jean Chalard
d9df8094e6 Neutralize AndroidSpellChecker.SuggestionsGatherer#addWords (A13) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Ia54e1e44e1fd4e8ba2c9316928c0595cbe3f933c
 2012-06-26 17:36:47 +09:00
Jean Chalard
7830476022 Neutralize Suggest#addWords (A12) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id923367342a62a650a5f1d38e2fa0e913030dca8
 2012-06-26 17:36:47 +09:00
Jean Chalard
fd998bd37a Refactoring (A11) 
Change-Id: I86bd7587dd80773a51ba6db312ba55dc41e7c8c7
 2012-06-26 17:36:47 +09:00
Jean Chalard
64dad2d5a9 Remove an unused method and inline another (A10) 
Change-Id: Ifd71ce79711b0c15c7764e97351dbb1b8e4c0c2d
 2012-06-26 17:36:47 +09:00
Jean Chalard
d522ddefc2 Merge "Merge the interface of two methods that do the same thing (A9)" 2012-06-26 01:35:15 -07:00
Jean Chalard
90981e423a Merge "Change the return type of getWords and getBigrams (A8)" 2012-06-26 01:33:04 -07:00
Jean Chalard
9053862470 Merge "Remove dependency on WordCallback from BinaryDictionary (A7)" 2012-06-26 01:16:43 -07:00
Jean Chalard
b9f99c8679 Merge "Remove useless code and storage (A6)" 2012-06-26 01:16:32 -07:00
Jean Chalard
8fb0ff00b1 Merge "Remove a duplicate processing (A5)" 2012-06-26 01:16:19 -07:00
Tadashi G. Takaoka
1c6a9cc44d Merge "Update current key reference in PointerTracker when keyboard is changed" 2012-06-26 00:58:16 -07:00
Jean Chalard
28eeb35d14 Merge the interface of two methods that do the same thing (A9) 
Change-Id: Ia5701d713d0fd5bb646b54a03a1a5602dad0a9e6
 2012-06-26 16:55:09 +09:00
Jean Chalard
d82898c5a9 Change the return type of getWords and getBigrams (A8) 
This only returns stuff, but it doesn't change yet how the data
is really passed. It merely adds a way of getting the same data.
Later, the old way will be removed.

Change-Id: If3a064de362175fc5a6781b7a97b65d8730aaf3c
 2012-06-26 16:44:26 +09:00
Jean Chalard
bda7eaa63a Remove dependency on WordCallback from BinaryDictionary (A7) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I8245698fbd170e0f5cbad3c0109774bcaddc0614
 2012-06-26 16:42:48 +09:00
Jean Chalard
17111afcd6 Remove useless code and storage (A6) 
This is only used as temporary storage to be then added to
the other variable, relying on the fact that it is hopefully
sorted. It's better to just add it right away to the final
storage.

Change-Id: I5da702ac9dc579593ab21feb2021a01e5dfdf4dc
 2012-06-26 16:39:32 +09:00
Jean Chalard
5e0545d69d Remove a duplicate processing (A5) 
This filtering is already done in native code. It's useless (and
costly) to do it again here.

Change-Id: Ide6794d7a8682a881f097f33e222f10d30f297bd
 2012-06-26 16:37:05 +09:00
Jean Chalard
fac8a16c6f Merge "Remove another dependency to WordCallback (A4)" 2012-06-25 23:31:39 -07:00
Tadashi G. Takaoka
8a092b4ede Update current key reference in PointerTracker when keyboard is changed 
This change also checks that the current key is the same key that
started the key repeat, when key repeat timer is fired.

Bug: 6722052
Change-Id: Id69880ded3338a5a3cbe7f8bf951f94f2651119c
 2012-06-26 15:00:12 +09:00
Kurt Partridge
3ec249c6d1 Merge "fix IllegalOutOfBoundsException" 2012-06-25 22:52:36 -07:00
Kurt Partridge
01106f6a10 fix IllegalOutOfBoundsException 
StringUtils.toCodePointArray() had thrown IllegalOutOfBoundsException if
passed an empty string.  change to just return an empty int[].

Bug: 6188932
Change-Id: Ic41c628c0d407f49fc98cd48cb7ea13d8d5bdd77
 2012-06-25 22:40:56 -07:00
Jean Chalard
d7b9e8f503 Remove another dependency to WordCallback (A4) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I5b277124dc9244e78c4a1f4d542a55071eb479bd
 2012-06-26 13:12:01 +09:00
Ken Wakasa
9f78eed456 Remove "Key popup dismiss delay" when "Popup on keypress" is suppressed 
bug: 6714783
Change-Id: Idf674e8e1af80642f2c53f7ae5c03e21c9e04292
 2012-06-26 00:40:53 +09:00
Satoshi Kataoka
7368009799 Change JNI for Gesture 
Change-Id: I774a0052038d16677f60f7efa11fd266cb5f3088
 2012-06-25 18:54:37 +09:00
Jean Chalard
5a73d72265 Merge "Refactoring and groundwork to fix a bug with older apps" 2012-06-25 00:42:21 -07:00
Jean Chalard
c3ebf1a43a Refactoring and groundwork to fix a bug with older apps 
This has a good, although small, impact on performance : it removes
a two-way IPC call in a most frequent case, while possibly adding
one in a rather unfrequent and less critical case.

Also, this fixes a bug with surrogate pairs. This specific branch
of code now correctly handles surrogate pairs.
Aside from this, it should have no impact on behavior.

However, since it does delay access to the previous character in
the text view by a two-way IPC call, it actually goes a long way
toward fixing bug#6668226. It is not really a fix and the race
condition still exists, but this change makes it much, much
harder to hit.

Bug: 6668226
Change-Id: Id11cc6a0b7488d6bd392227cafdcf3a8d4c62f6c
 2012-06-25 16:32:25 +09:00
Jean Chalard
a316a15984 Merge "Tentatively remove a dependency on WordCallback (A3)" 2012-06-24 23:08:13 -07:00
Jean Chalard
dc01bd5ea4 Merge "Improve compatibility for ICS." 2012-06-24 20:41:19 -07:00
Satoshi Kataoka
2cf265b345 Merge "Fix possible NPE from a concurrent problem in LatinIME" 2012-06-21 22:16:48 -07:00
Kurt Partridge
e6a39d5677 Merge "Allow punctuation through privacy filter" 2012-06-21 21:53:48 -07:00
Kurt Partridge
33d9f9b6db Allow punctuation through privacy filter 
Also cleaned up the privacy code a bit.

multi-project commit with Change-Id: Ic0919a6929ebb2623ff4124f7adc96d9e5f8df3c

Bug: 6188932
Change-Id: Id470fe7cc6e4a8fb01f1ea5b178a74cd27d59218
 2012-06-21 00:17:48 -07:00
Jean Chalard
1b71ff00a2 Merge "Update an outdated comment" 2012-06-20 20:18:51 -07:00
Jean Chalard
9997b44846 Improve compatibility for ICS. 
ICS didn't have a SHORTCUT column in the user dictionary.
If running on a build under JellyBean, we should not ask
for it lest we crash.

Bug: 6600617
Change-Id: Iac0cbcc63c10064f01e2d51eec5931fd9cdd0922
 2012-06-20 18:43:56 -07:00
Jean Chalard
83f4a9866a Cleanup, part 10 : remove from the code obsolete options (C10) 
Change-Id: Id0806ad3dc7ccb632713eebaca76f0bab26ece5d
 2012-06-21 10:07:05 +09:00
Jean Chalard
7c406ed655 Tentatively remove a dependency on WordCallback (A3) 
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id5a59eaec2aeefa0ba4524420a8e035d383f6545
 2012-06-21 10:03:44 +09:00
Jean Chalard
e8bb8351d6 Cleanup, part 9 (C9) 
Change-Id: Ifb15553824915d0634aea83689302c2418b093f3
 2012-06-21 09:22:32 +09:00
Jean Chalard
ca6b7d5265 Cleanup, part 8 (C8) 
Change-Id: Iecc9b3d43c191614c2951408e14085cb77eefd4d
 2012-06-20 03:45:40 +09:00
Jean Chalard
2f3a694e29 Cleanup, part 7 (C7) 
Change-Id: I662be9d3b31fb9e157722f38cab1e6fb8a1152ab
 2012-06-20 03:17:33 +09:00
Jean Chalard
0e8b1db948 Merge "Cleanup, part 6 (C6)" 2012-06-19 09:25:33 -07:00
Jean Chalard
c03bd090ea Merge "Cleanup, part 4 (C4)" 2012-06-19 09:24:25 -07:00
Jean Chalard
bd765d3355 Merge "Cleanup, part 3 (C3)" 2012-06-19 09:24:00 -07:00
Jean Chalard
b821b72aa1 Merge "Remove a member (B5)" 2012-06-19 09:15:57 -07:00
Satoshi Kataoka
67b9337b6c Fix possible NPE from a concurrent problem in LatinIME 
Bug: 6620746
Change-Id: Icc18de92d7edc6888c712c2cf5ce479a65f8bfad
 2012-06-19 03:34:45 +09:00
Svetoslav Ganov
808ba7b8f8 am e6730ac0: am 5e4df66f: Merge "Removing implementation of unnecessary APIs taken out of the support lib." into jb-dev 
* commit 'e6730ac0e89de1cd81b92412751ec3950d8befb4':
  Removing implementation of unnecessary APIs taken out of the support lib.
 2012-06-18 11:31:43 -07:00
Svetoslav Ganov
5e4df66fce Merge "Removing implementation of unnecessary APIs taken out of the support lib." into jb-dev 2012-06-18 11:28:04 -07:00
Jean Chalard
b0561ae980 Remove a member (B5) 
The new call in the test ensures getCurrentInputEditorInfo actually
works.

Change-Id: I2ee407bd9927d22db537d12f339e2b977a38054a
 2012-06-19 03:27:37 +09:00
Jean Chalard
56523ce0bf Merge "Simplification (B4)" 2012-06-18 10:55:59 -07:00
Jean Chalard
64e52051cf Simplification (B4) 
Change-Id: Id5abf722a533980ed2d89381dbddc0a71b6f5b6b
 2012-06-19 02:54:13 +09:00
Jean Chalard
5a1259523f Merge "Move a settings method to SettingsValues (B3)" 2012-06-18 10:53:47 -07:00
Tadashi G. Takaoka
a5bbb8df75 am e4bbff78: am 38dc9ca3: Fix duplicate period on Persian tablet keyboard 
* commit 'e4bbff783bddb70f52402454987ede281fb86039':
  Fix duplicate period on Persian tablet keyboard
 2012-06-18 10:52:54 -07:00
Tadashi G. Takaoka
794a9c913a am 58f9b35e: am 6de1b7a7: Fix Persian keyboard having correct code points 
* commit '58f9b35e1cf5a975ec1312858aad9b5cc307fda8':
  Fix Persian keyboard having correct code points
 2012-06-18 10:52:46 -07:00
Svetoslav Ganov
27bda8fee8 am 866cfd3a: am fa447071: Merge "Update LatinIME due to hidden APIs taken out of the support lib." into jb-dev 
* commit '866cfd3a68c370bedc4deb3d40ff4ff7c44902bd':
  Update LatinIME due to hidden APIs taken out of the support lib.
 2012-06-18 10:52:42 -07:00
Jean Chalard
fe53e5c060 Move a settings method to SettingsValues (B3) 
Change-Id: Ibfa27bd919c92be219c4d107b3ace008ca80a19f
 2012-06-19 02:52:36 +09:00
Tadashi G. Takaoka
38dc9ca314 Fix duplicate period on Persian tablet keyboard 
Bug: 6679579
Change-Id: I8bccbfbdf7ea1fa1b78a5af05eb1df100f22ab0c
 2012-06-18 10:33:03 -07:00
Jean Chalard
8b538807a3 Merge "Make a variable final (A2)" 2012-06-18 10:30:19 -07:00
Jean Chalard
0176faf6c0 Merge "Add a kind to the suggestion for bookkeeping (A1)" 2012-06-18 10:30:10 -07:00
Jean Chalard
1c3c0ff1c3 Merge "Cleanup, part 2 (C2)" 2012-06-18 10:29:06 -07:00
Jean Chalard
65b7bcb045 Merge "Cleanup, part 1 (C1)" 2012-06-18 10:28:58 -07:00
Svetoslav Ganov
d3cc73ada8 Removing implementation of unnecessary APIs taken out of the support lib. 
1. We have hidden a framework API and it was take out of the
   support lib. This API is not necessary and this patch removes
   the implementation in LatinIME.

bug:6675330

Change-Id: I18aff7a6c7bc2b76c7332abe0bf294fbbb99ccfc
 2012-06-17 15:22:02 -07:00
Kurt Partridge
6080f6878b Remove non-dictionary words and digit touch data. 
Output to the ResearchLogger is now queued and only flushed if the word
the user was working on is a dictionary word.

multi-project commit with Ic713ec00777fbdcf4a937b3c77b995257e100fc7

Bug: 6188932
Change-Id: I9de15227ff51be23083d9096f1c1b3d83802fff7
 2012-06-17 15:02:15 -07:00
Kurt Partridge
4b91046759 Merge "Replace digits in ResearchLogger" 2012-06-16 20:48:25 -07:00
Tadashi G. Takaoka
6de1b7a709 Fix Persian keyboard having correct code points 
Bug: 6679850
Change-Id: Iaa33f48ffb5634de31e039574fb58185c6c078e8
 2012-06-16 20:30:45 -07:00
Kurt Partridge
a696781c2b Replace digits in ResearchLogger 
Digits may represent personally identifying information.  They are
now replaced with a non-identifying symbol.

multi-project commit with I07d1cfdc45f6086f67af45775f4ed12da1833aca

Bug: 6188932

Change-Id: Ifda8079e6c1f29b5f8af34c6d1fccf5770f164ca
 2012-06-16 12:37:50 -07:00
Jean Chalard
c5f1d998c2 Cleanup, part 6 (C6) 
Change-Id: I184f3a336278559df255c5d600a98fbba468a243
 2012-06-16 10:52:49 +09:00
Jean Chalard
9b233ecef2 Cleanup, part 4 (C4) 
Change-Id: I2821ae71ec49e4b6b512157d17b80198f74321e4
 2012-06-16 10:51:04 +09:00
Jean Chalard
5475e92b3f Cleanup, part 3 (C3) 
Change-Id: Ib0be8dc26b6fa366a3dabeea940d466602073244
 2012-06-16 10:46:18 +09:00
Jean Chalard
71dc280426 Cleanup, part 2 (C2) 
Change-Id: I860f41807e9bc2e38b6ad84e1527fc8707a9aa40
 2012-06-16 10:40:16 +09:00
Jean Chalard
6883153dd0 Cleanup, part 1 (C1) 
Change-Id: I2b1ddd836aaf6bfc0bd2befb78f98239ffcdbb22
 2012-06-16 10:38:57 +09:00
Jean Chalard
4a5cb5c36a Update an outdated comment 
Change-Id: I3d02dc8597ed14d998caeaa056813353e2d7ec1a
 2012-06-16 10:34:57 +09:00
Jean Chalard
dca729fddd Move final attributes to SettingsValues (B2) 
Bug: 6675475
Bug: 6677394
Change-Id: I4a26efb9226d3f909f331c4d2e47cd83a05c011e
 2012-06-16 08:01:09 +09:00
Svetoslav Ganov
fa447071df Merge "Update LatinIME due to hidden APIs taken out of the support lib." into jb-dev 2012-06-15 15:00:55 -07:00
Jean Chalard
3d44f489b3 Inline a method for simplicity (B1) 
This has a confusing name and is a one-liner

Change-Id: I954a648a8413e38a535c2b81e4b171e1bdc9f1c2
 2012-06-16 03:18:00 +09:00
Jean Chalard
0998c48ac3 Make a variable final (A2) 
This is never changed, and probably doesn't need to be.
It's public because it's going to be used elsewhere in a future
change

Change-Id: Iec8d65859c470de5e1fb0b05533356fbc3b8e91b
 2012-06-16 03:10:54 +09:00
Jean Chalard
e7d2ee3ec3 Add a kind to the suggestion for bookkeeping (A1) 
This will help for debug as well as serve as groundwork for
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I74d0a7b943fb22c514ad79dc064d69ddf336d3ef
 2012-06-16 03:10:36 +09:00
Svetoslav Ganov
b910b18c2c Update LatinIME due to hidden APIs taken out of the support lib. 
1. We have hidden the APIs for accessiiblity focus search since
   it wull be perfomred by the client, updated the support lib,
   and now we are updating the LatinIME.

bug:6675330

Change-Id: I9dd3450b40148be7ce750f6bffc0a047a541982f
 2012-06-15 11:01:15 -07:00
Kurt Partridge
23cec44376 Merge "No logging of passwords." 2012-06-14 21:09:20 -07:00
Tadashi G. Takaoka
9328e0f2d9 am aee2ed1f: am 14bc2e89: Fix Arabic diacritics order 
* commit 'aee2ed1f4b0be7a538cc5722fed274632f2a40ba':
  Fix Arabic diacritics order
 2012-06-14 21:08:18 -07:00
Tadashi G. Takaoka
14bc2e89ef Fix Arabic diacritics order 
Bug: 6662536
Change-Id: I96e45ce0e8b9b5440a54f3b321a925bc87ec3ca9
 2012-06-14 20:33:52 -07:00
Tadashi G. Takaoka
dfcf7cac5e am 1ab436c1: am 0e473e9c: Reorder Persian diacritics 
* commit '1ab436c1e60c0e49333549fb93e135fa99458bda':
  Reorder Persian diacritics
 2012-06-14 18:30:52 -07:00
Jean Chalard
a19c5e6380 resolved conflicts for merge of be82f297 to master 
Change-Id: If49ca384ea0ac415a75f8ea1bad77dc6719cb04d
 2012-06-15 09:03:52 +09:00
Tadashi G. Takaoka
0e473e9c92 Reorder Persian diacritics 
Bug: 6661783
Change-Id: I42bab7655121ec5671854d54c47bd0c7a29e7a98
 2012-06-14 16:56:36 -07:00
Kurt Partridge
1cef91e481 No logging of passwords. 
Bug: 6188932
Change-Id: Ibf60ec99c50da3675bf89858624218e6cc3eb1d2
 2012-06-14 15:14:20 -07:00
Jean Chalard
cf6e923b18 am 42ecf39d: am 002e43ea: Merge "Remove irrelevant options." into jb-dev 
* commit '42ecf39d04df9eb02e57cf29e63552bc04092857':
  Remove irrelevant options.
 2012-06-14 14:51:37 -07:00
Tadashi G. Takaoka
775d8dcaeb am de1d88eb: am 32f4ceb2: Dismiss more suggestions panel when suggestions strip is closed 
* commit 'de1d88eb4199160899d227f2c679215e16410c42':
  Dismiss more suggestions panel when suggestions strip is closed
 2012-06-14 14:49:08 -07:00
Jean Chalard
7cbd0478cf Merge "Do not display punctuation suggestions when bigrams are on." into jb-dev 2012-06-14 14:37:13 -07:00
Jean Chalard
002e43ead0 Merge "Remove irrelevant options." into jb-dev 2012-06-14 14:36:26 -07:00
Jean Chalard
d5b765b3bb Do not display punctuation suggestions when bigrams are on. 
Bug: 6310401
Change-Id: I9d31c48e287aceedaf2f4c5129031ddb31402451
 2012-06-15 06:01:09 +09:00
Jean Chalard
78573f2e8a Fix an NPE 
This code is temporary until we get rid of this member.

Bug: 6662963
Bug: 6667091
Change-Id: I1d970d2a97992507e86c5b94978a2543fe42b375
 2012-06-15 05:47:35 +09:00
Jean Chalard
15121cff37 Remove irrelevant options. 
Bug: 6667355
Change-Id: I39b6db17fb52e80f510cf6462f41d9cb1f8e0341
 2012-06-15 05:04:14 +09:00
Tadashi G. Takaoka
32f4ceb243 Dismiss more suggestions panel when suggestions strip is closed 
This change fixes possible NPE as well.

Bug: 6658028
Change-Id: I8706808d1002b7b0b95930fd9b08568f08645da6
 2012-06-14 11:57:43 -07:00
Satoshi Kataoka
d2f210dbe2 am d9c702d2: am 5caaf1b9: Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 
* commit 'd9c702d2ff017452f0264f2be12b6bffd6204e4a':
  Do not add profanity to user history bigram dicitonary
 2012-06-14 10:33:47 -07:00
Tadashi G. Takaoka
c380959f48 am bbf18807: am 1db4f951: Fix the order of Persian diacritics 
* commit 'bbf188075d5e14626c0609f4c3ee6031f6c6d5a6':
  Fix the order of Persian diacritics
 2012-06-14 10:33:46 -07:00
Satoshi Kataoka
5caaf1b9e9 Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 2012-06-14 00:31:55 -07:00
Tadashi G. Takaoka
1db4f95105 Fix the order of Persian diacritics 
The java source file KeyboardTextsSet.java has rather big change, but
this file is auto generated by "maketext" tool. The crucial part of
this change is in 5 XML resource files.

Bug: 6661783
Change-Id: I1d827ab0ebe6caa5ab73531682d6c32540b0d7aa
 2012-06-14 15:18:25 +09:00
Satoshi Kataoka
68c650fb2a Do not add profanity to user history bigram dicitonary 
Change-Id: I864c4206e3e6cde4d6ed687a9759e98901e16b9a
 2012-06-14 15:15:08 +09:00
Jean Chalard
bbd7434229 Merge "Fix an occurrence of nested batch edits." 2012-06-13 10:37:12 -07:00
Tadashi G. Takaoka
8fa20d6a36 Merge "Remove useless copy constructor of ProximityInfo" 2012-06-12 16:24:39 -07:00
Tadashi G. Takaoka
9f42140ae2 Remove useless copy constructor of ProximityInfo 
Change-Id: I56b4a99f670ad38708ad83d76b93a631295e3333
 2012-06-12 15:13:07 -07:00
Jean Chalard
9d71748ba4 Fix an occurrence of nested batch edits. 
This is harmless, but against policy.
Also, rework the checking code to be more readable, give more
information, and be called for all relevant methods - and not
for informative methods, which are not required to be in a
batch edit.

Change-Id: I03fa8b2e7d68a6a133f86be8a214671750c29256
 2012-06-13 07:02:07 +09:00
Jean Chalard
c7564a787e Optimization 
This is much faster. It doesn't create messages, it doesn't post
stuff in a queue, it doesn't delay execution of other messages.
Also, it decouples the timer from the functionality of the Handler
so this can be pulled up in another change to consolidate with
mLastKeyTime or so.

Change-Id: I9044fc031373e66b9b40eee8025633613d0945dc
 2012-06-13 07:02:07 +09:00
Jean Chalard
72b358aa90 Small optimization. 
This will avoid some two-way IPC calls.

Change-Id: If9eb3e99b3d08346aadd4bbed2a1761f8c2527b9
 2012-06-13 07:02:07 +09:00
Satoshi Kataoka
84bb18f4c9 resolved conflicts for merge of ee78e780 to master 
Change-Id: I88a4996bdd17c5378a67781d8075eff311670c3b
 2012-06-13 06:45:38 +09:00
Jean Chalard
58d9e46ce0 Merge "Consolidate a test." 2012-06-12 11:50:36 -07:00
Kurt Partridge
5e50eec570 Merge "Check inputs to ResearchLogger" 2012-06-12 11:39:11 -07:00
Jean Chalard
e86054e5c2 Consolidate a test. 
Stop using the numerical value, use the actual method

Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e
 2012-06-13 03:34:58 +09:00
Kurt Partridge
65fc909e13 Check inputs to ResearchLogger 
to avoid NPEs.

Bug: 6188932
Change-Id: I377ceaac867df879dc7984dae44e96b369858cca
 2012-06-12 10:56:03 -07:00
Jean Chalard
140adf204b Consolidate auto-correction settings. 
For some reason, there were several ways, not exactly identical,
to get this setting. The ones that used mAutoCorrectionEnabled
would kick in when the input field was specifying no correction,
so it would be a little strange (although harmless in the practice
because the settings set in this way would not get used later,
because the correct test would be done at that time).

Also perform a very small refactoring

Change-Id: Ica9f32b238d98009ae1852d3c1e940398f5d341c
 2012-06-12 10:29:55 +09:00
Jean Chalard
2010aad741 Move two methods in a more appropriate place 
Change-Id: I512b04e23490413a44b1ca0517102fe2d9138df3
 2012-06-12 10:29:55 +09:00
Jean Chalard
a32eb27213 Move an editing method to the RichInputConnection 
Change-Id: Ie143ad008ca8deb1c5034cb80ec1cb28a6b0682d
 2012-06-12 10:29:55 +09:00
Jean Chalard
243e370fcb Move a member call out of the way 
Change-Id: I5da48442c0b39aaff817c3b6d067a9b13fda0643
 2012-06-12 10:29:55 +09:00
Jean Chalard
747cf0435a Move two editing utility methods to RichInputConnection 
Change-Id: If8d03bea1b6369cb3043da6321048d052995d664
 2012-06-12 10:29:55 +09:00
Jean Chalard
70a046f8ca Merge "Rename mSettingsValues to mCurrentSettings" 2012-06-11 18:24:45 -07:00
Jean Chalard
64913d72bc Merge "Move suggestion strip visibility to SettingsValues" 2012-06-11 18:18:50 -07:00
Jean Chalard
15c0090e88 Merge "Accept a null input attributes for reading settings." 2012-06-11 18:18:43 -07:00
Jean Chalard
f4bc441256 Merge "Move the correction mode to SettingsValue and make it final" 2012-06-11 18:18:03 -07:00
satok
6a71f0610c Fix UserHistoryBigram data contention in UserHistoryDictionary 
Bug: 6637614
Change-Id: I34d26563e59d3b09bf35b8173dac5645ccb6a39f
 2012-06-12 08:00:14 +09:00
Jean Chalard
411a98afb9 Merge "Consolidate updateCorrectionMode() calls" 2012-06-11 14:02:15 -07:00
Jean Chalard
297e6d590b Rename mSettingsValues to mCurrentSettings 
...for readability. After all, it makes sense that "current settings"
is a "SettingsValues", while it's harder to understand why we'd
manipulate an object named "SettingsValues".

Change-Id: Ide9a17b970a6cc00b80b9a217f986268c739c662
 2012-06-08 21:34:07 +09:00
Jean Chalard
d273697259 Move suggestion strip visibility to SettingsValues 
Change-Id: If34112c69acd5122d87554043d87d8f4dbdf5d15
 2012-06-08 21:26:25 +09:00
Jean Chalard
01e3b014bb Accept a null input attributes for reading settings. 
Change-Id: I11a8e1aca3541c35d2b39b27716687fcd8ff3dc6
 2012-06-08 21:15:33 +09:00
Jean Chalard
4b9e6ee6fb Move the correction mode to SettingsValue and make it final 
At last this guy is final, at last

Change-Id: I76911f8d47493f8a1719f75fc7e949be5d7da1a2
 2012-06-08 21:10:35 +09:00
Jean Chalard
3791183076 Consolidate updateCorrectionMode() calls 
Change-Id: I43c0505e9a1652bfc568f23b787fc68a5c5e9220
 2012-06-08 21:02:19 +09:00
Ken Wakasa
e7b34b9f86 Add NativeUtils.powf() 
Change-Id: I0339f39d49bc6390d098017f32d92c776974e03e
 2012-06-08 20:46:19 +09:00
Jean Chalard
bbbdab12be Move some editing methods to RichInputConnection. 
Change-Id: I8527776a4bd8236a85bb77f9791f9b76977ad181
 2012-06-08 20:23:13 +09:00
Jean Chalard
e091982868 Straighten batch edits, pass 1 
Change-Id: I73acfee9098a87b9cde8aca720586ec748b2a82f
 2012-06-08 20:09:41 +09:00
Jean Chalard
02308bec63 Merge RichInputConnection with EditingUtils 
Change-Id: I9982ff325bef56694402caef28a77683c52ccd71
 2012-06-08 20:04:09 +09:00
Jean Chalard
5475b38328 Make a wrapper for the input connection. 
The goal is to simplify the code in LatinIME.java as well as having
a handy place to put debug calls to see interaction with TextView.

Change-Id: I255227e7e7343e0c2f3dcd1f185e5020d6186732
 2012-06-08 19:50:12 +09:00
Jean Chalard
c33a5428be Merge "Small performance tweak" 2012-06-08 01:22:31 -07:00
Jean Chalard
67fd0c240d Remove deprecated classes. 
Should we maybe rename back *BinaryDict* to *Dict* in another
change for simplicity?

Change-Id: I8f7dcb78b9bdf1a13ce403a997fbb8619f2b453b
 2012-06-08 17:12:15 +09:00
Jean Chalard
d10c473347 Small performance tweak 
Change-Id: Icd540742073d49d12e70b2d8bd99aaf7ccb5802d
 2012-06-08 17:09:40 +09:00
Jean Chalard
e91f32d8c1 Merge "Remove a slew of Eclipse warnings." 2012-06-08 00:35:05 -07:00
Jean Chalard
7214617622 Remove a slew of Eclipse warnings. 
Change-Id: I03236386aea13fbd4fb8eaeee18e0008aa136502
 2012-06-08 16:23:18 +09:00
Satoshi Kataoka
eed2cf287d Merge "Separate state from proximity_info step1" 2012-06-07 22:18:11 -07:00
Ken Wakasa
d418580a71 Fix typo 
Change-Id: I264f829c1584a37995dbc5ee4ba6b6783d5d4834
 2012-06-08 03:42:02 +09:00
Tadashi G. Takaoka
6b8a70105f am e4da18e2: am 6348c54f: Merge "Initializing member variable before it is referenced" into jb-dev 
* commit 'e4da18e27916f770fcd704032d30534d287d67c6':
  Initializing member variable before it is referenced
 2012-06-07 11:32:50 -07:00
satok
1e96cc1f51 am 674c51a0: am ec2981a4: Fix a bug on upgrading user history scheme 
* commit '674c51a01117b73dd25473195f92fb0c0158da26':
  Fix a bug on upgrading user history scheme
 2012-06-07 11:28:41 -07:00
Tadashi G. Takaoka
6348c54ffd Merge "Initializing member variable before it is referenced" into jb-dev 2012-06-07 11:27:32 -07:00
Tadashi G. Takaoka
40582ab438 Initializing member variable before it is referenced 
Bug: 6584882
Change-Id: I1f76388fa8cc16171bc3fc60c935ddcf0a7c4e92
 2012-06-07 11:17:59 -07:00
satok
ec2981a487 Fix a bug on upgrading user history scheme 
Bug: 6626700
Change-Id: I3190d7404e45e704be79ee2031e79b18475feb8c
 2012-06-08 02:55:23 +09:00
Tom Ouyang
11dc22d964 Merge "Contacts binary dictionary updates with change in keyboard locale." 2012-06-07 01:19:44 -07:00
Tom Ouyang
2e8aa06002 Contacts binary dictionary updates with change in keyboard locale. 
Bug: 6616436
Change-Id: I8d66a37f295134c5b9875b2a305a9be7442bd75d
 2012-06-07 00:25:41 -07:00
Jean Chalard
c8a120f970 am eead5492: am 769cecf7: Close spell-checking dictionaries in a background thread 
* commit 'eead5492615f0b05ef85ca1f88d3a41ce3f8d496':
  Close spell-checking dictionaries in a background thread
 2012-06-06 21:52:46 -07:00
Satoshi Kataoka
3e8c58f68d Separate state from proximity_info step1 
Bug: 6548943

Change-Id: I7b4fbe20615a28151a74875be43b9f4a20e0dce9
 2012-06-07 13:35:34 +09:00
Jean Chalard
769cecf7e7 Close spell-checking dictionaries in a background thread 
Bug: 6584677
Change-Id: Ifd9b0f995f4e0cf4d35a7ecde767826ab976f0b8
 2012-06-07 12:56:45 +09:00
Kurt Partridge
9b300f0caa Merge "add research log ui control" 2012-06-06 20:47:53 -07:00
Kurt Partridge
724bc479f7 add research log ui control 
- lets users flag a particular time in the research log
- lets users delete the log for this session

also makes the UsabilityLog setting control whether the ResearchLog logs or not.

multi-project commit with I89067e7d3b8daca7179333f1dbe82224c26920fe

Bug: 6188932
Change-Id: I89864ef3ab53b0efe1ea8d75247be08712f0c399
 2012-06-06 20:42:01 -07:00
Satoshi Kataoka
91c8c4f3a7 am e08cfda1: am 5a8d2fd1: Merge "Cache UserHistoryDictionary for each language" into jb-dev 
* commit 'e08cfda1ebea693c56681816076c419f23c51076':
  Cache UserHistoryDictionary for each language
 2012-06-06 10:48:46 -07:00
Satoshi Kataoka
5a8d2fd1d3 Merge "Cache UserHistoryDictionary for each language" into jb-dev 2012-06-06 10:43:50 -07:00
Tadashi G. Takaoka
562239bf51 am 59dae7e1: am 907ba593: Can specify Key.backgroundType in <Row> and <include> attribute 
* commit '59dae7e141b6d6a8bea287f6699e34137390c5f9':
  Can specify Key.backgroundType in <Row> and <include> attribute
 2012-06-06 10:42:38 -07:00
Tadashi G. Takaoka
2bf014d2a8 Fix xml tag in comment 
Bug: 6620122
Change-Id: I2852f77d78b242c1a96c53cdd1e4c0e299f8ea4f
 2012-06-06 10:36:30 -07:00
Tadashi G. Takaoka
907ba59397 Can specify Key.backgroundType in <Row> and <include> attribute 
Bug: 6568834
Change-Id: I138464b5445e13eaf062ce84a1ba332dfd1afafa
 2012-06-06 10:15:51 -07:00
Satoshi Kataoka
a836808f8b Cache UserHistoryDictionary for each language 
Bug: 6603257
Change-Id: I73b65e921cff8337a00594525f67f6aec2178881
 2012-06-06 20:02:00 +09:00
Satoshi Kataoka
21b782cf22 Merge "Cache bigram results in Android SpellChecker" 2012-06-06 01:01:47 -07:00
Satoshi Kataoka
547bc0cf04 Cache bigram results in Android SpellChecker 
Bug: 6610579
Change-Id: I255c068f64f99ee80abda49153ed8ea009ca8ad3
 2012-06-06 16:58:24 +09:00
Kurt Partridge
6b3b37da97 Merge "Change constants in ResearchLogger" 2012-06-05 20:17:14 -07:00
Tadashi G. Takaoka
876711930d am 2eb5eb4d: am be2fef4d: Merge "Fix backing view height calculation in landscape orientation" into jb-dev 
* commit '2eb5eb4d447cb326b4c10cff2cae64df4e431ffd':
  Fix backing view height calculation in landscape orientation
 2012-06-05 17:58:59 -07:00
Tadashi G. Takaoka
be2fef4d5e Merge "Fix backing view height calculation in landscape orientation" into jb-dev 2012-06-05 17:54:42 -07:00
Tadashi G. Takaoka
b94f4cc71c Fix backing view height calculation in landscape orientation 
This logic has been dropped by Ib814c07f.

Bug: 6610497
Change-Id: Id89ad3280b73a31d8c9c6826e9ee297791624db1
 2012-06-05 17:41:01 -07:00
Charles Chen
7b250c25f7 am 6b0d0fa3: am f8233ec3: Merge "Refresh Accessibility key mapping when KeyboardView changes Keyboards." into jb-dev 
* commit '6b0d0fa3501247ccf3190c938dec580102fe0473':
  Refresh Accessibility key mapping when KeyboardView changes Keyboards.
 2012-06-05 15:02:27 -07:00
Charles Chen
f8233ec32d Merge "Refresh Accessibility key mapping when KeyboardView changes Keyboards." into jb-dev 2012-06-05 14:55:59 -07:00
alanv
f147794fd4 Refresh Accessibility key mapping when KeyboardView changes Keyboards. 
Bug: 6609626
Change-Id: I93d764b46e96fe70b61c91a7dcb46945ac8853dd
 2012-06-05 11:02:54 -07:00
Jean Chalard
5235e0cd91 am c750f9eb: am a6166d37: Fix a bug where Latin IME crashes on spell checker request 
* commit 'c750f9eb5398a30b207891e6858863f493875199':
  Fix a bug where Latin IME crashes on spell checker request
 2012-06-05 09:54:58 -07:00
Tom Ouyang
f93551f77b am 18c4137c: am 7f7739fe: Merge "Fix a bug where the spellcheck is using the old non-binary contacts dictionary" into jb-dev 
* commit '18c4137c878c18de24a406b861ddb2a735e02f7d':
  Fix a bug where the spellcheck is using the old non-binary contacts dictionary
 2012-06-05 09:54:55 -07:00
Satoshi Kataoka
037cf8c8a5 am 7394fc43: am 0e134e6b: Merge "Avoid redundant access to DB" into jb-dev 
* commit '7394fc43028ef6e28579921c30915bd8a9c9c990':
  Avoid redundant access to DB
 2012-06-05 09:22:17 -07:00
Jean Chalard
c1cbcf949d am 9252fc1b: am dd487247: Merge "Read the script correctly" into jb-dev 
* commit '9252fc1b88df0c8bd3870546d1c8ca7681e435d3':
  Read the script correctly
 2012-06-05 09:22:15 -07:00
Kurt Partridge
f739119f3f Change constants in ResearchLogger 
Bug: 6188932
Change-Id: I3c6a3fb3e8fb139e16322e544f12bc3294cdaf1c
 2012-06-05 07:13:06 -07:00