Ken Wakasa
95c4d26994
Merge "Revert "Straighten the dead char implementation.""
2014-08-27 15:07:52 +00:00
Ken Wakasa
0ba6bcb16d
Revert "Straighten the dead char implementation."
...
This reverts commit 5ef447aeea
.
Reverting because this broke a bunch of unit tests -- https://sponge.corp.google.com/target?id=b6439742-099e-46cb-8f00-d0c602a4d9bb&target=com.google.android.inputmethod.latin.tests&searchFor=&show=FAILED&sortBy=STATUS
Change-Id: Ibbd9e11372993f62e630fd9da37158ffcf47c17a
2014-08-27 15:07:28 +00:00
Jean Chalard
4204d59864
Merge "Straighten the dead char implementation."
2014-08-27 12:54:49 +00:00
Keisuke Kuroyanagi
733a023b64
Remove redundant code.
...
Change-Id: I173eac15dc128e84893881ec4ee0ad1ad2fce44b
2014-08-27 20:28:48 +09:00
Keisuke Kuroyanagi
6ae4d79d81
Use IntArrayView for dictionary structure policy.
...
Change-Id: I0dc94908259d70d5085ff22abf422d90affb1452
2014-08-27 20:28:43 +09:00
Keisuke Kuroyanagi
b85bf4ebb8
Merge "Use word id to construct DicNode instead of isTerminal flag."
2014-08-27 11:21:41 +00:00
Keisuke Kuroyanagi
fe395232d6
Remove bigram dict content.
...
Bug: 14425059
Change-Id: I75918c6761a50832da511088eb83becd56b23662
2014-08-27 20:05:59 +09:00
Keisuke Kuroyanagi
758d093644
Get entry count after truncation using LanguageModelDictContent.
...
Bug: 14425059
Change-Id: I41b237c1c22c21740946d52e3be9d6f963c9cd54
2014-08-27 20:04:39 +09:00
Keisuke Kuroyanagi
c7f1de826c
Merge "Use LanguageModelDictContent in getWordProperty()."
2014-08-27 10:58:28 +00:00
Tadashi G. Takaoka
8b5788d72b
am 68a2a69a: am 37beaf15: Simplify onComputeInsets of LatinIME
...
* commit '68a2a69ae35352650a4c6dfc0b0c69069c4a1e1d':
Simplify onComputeInsets of LatinIME
2014-08-27 10:44:51 +00:00
Keisuke Kuroyanagi
7c08ede12b
Merge "Use LanguageModelDictContent in iterateNgramEntries()."
2014-08-27 10:44:21 +00:00
Tadashi G. Takaoka
68a2a69ae3
am 37beaf15: Simplify onComputeInsets of LatinIME
...
* commit '37beaf1529a61228d6240736937789e5622b29ed':
Simplify onComputeInsets of LatinIME
2014-08-27 10:36:05 +00:00
Keisuke Kuroyanagi
82f7d3a9de
Merge "Add a method to iterate entries in LanguageModelDictContent."
2014-08-27 10:35:38 +00:00
Tadashi G. Takaoka
37beaf1529
Simplify onComputeInsets of LatinIME
...
This CL expands SoftInputWindow to the entire screen. Thus a key
review backing view is eliminated and onComputeInsets() gets
simplified too.
Bug: 17212702
Bug: 10841052
Bug: 10541453
Change-Id: I2d859f4e4698c64cabe399000821f13bab729996
2014-08-27 19:20:38 +09:00
Yohei Yukawa
00042cb453
am c925ca43: am 97681ebd: Set highlight color along with the commit indicator
...
* commit 'c925ca43a6e0b3175feb002ce6b5577ef7d66507':
Set highlight color along with the commit indicator
2014-08-27 10:01:24 +00:00
Ken Wakasa
d8380fdba0
Merge "resolved conflicts for merge of 8159336b
to master"
2014-08-27 09:59:12 +00:00
Ken Wakasa
6da1c674fd
resolved conflicts for merge of 8159336b
to master
...
Change-Id: I9dd726593c6768b1db35305935ee69b0937358ef
2014-08-27 18:55:39 +09:00
Yohei Yukawa
8a413a2a62
am 00d140ca: am a475c854: Introduce a mechanism to hide the indicator speculatively
...
* commit '00d140caeb02e2e68f5b2cf7b71d349e1ad4cb5c':
Introduce a mechanism to hide the indicator speculatively
2014-08-27 09:48:34 +00:00
Ken Wakasa
c1596086d3
resolved conflicts for merge of 0268f736
to master
...
Change-Id: Ib89ef55a8752f9b5e357eed3a05c79dd28d0ec0e
2014-08-27 18:41:31 +09:00
Yohei Yukawa
c925ca43a6
am 97681ebd: Set highlight color along with the commit indicator
...
* commit '97681ebdf16dd94b7ed0607342cc2750fb96a641':
Set highlight color along with the commit indicator
2014-08-27 09:18:50 +00:00
Yohei Yukawa
8159336ba1
am 29200b0a: Set the text bgcolor only when CursorAnchorInfo is available
...
* commit '29200b0abe1d65aa2f9ddefd247ab91563d666f8':
Set the text bgcolor only when CursorAnchorInfo is available
2014-08-27 09:18:49 +00:00
Jean Chalard
5ef447aeea
Straighten the dead char implementation.
...
This now supports all cases, including cases not supported by
the framework.
Now rebased on top of the right change, and renamed
Change-Id: I7886f0dcbb86cdb4dccec09aa7c52ad339680e04
2014-08-27 17:59:39 +09:00
Yohei Yukawa
97681ebdf1
Set highlight color along with the commit indicator
...
With this CL, the text highlight color is applied
when the commit indicator is displayed.
Note that the underline is not rendered when the
background color is enabled. This is a known issue.
Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
2014-08-27 01:41:16 -07:00
Yohei Yukawa
29200b0abe
Set the text bgcolor only when CursorAnchorInfo is available
...
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.
With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not. This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.
Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
2014-08-27 01:30:45 -07:00
Yohei Yukawa
00d140caeb
am a475c854: Introduce a mechanism to hide the indicator speculatively
...
* commit 'a475c85480b2bc2a8d036b4b1ea29f6a8e749ac5':
Introduce a mechanism to hide the indicator speculatively
2014-08-27 07:31:42 +00:00
Yohei Yukawa
a475c85480
Introduce a mechanism to hide the indicator speculatively
...
This is an optional optimization to reduce the UI latency.
Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.
If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.
This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.
Change-Id: Id59c6607a1029782410611e768791af9984f14ac
2014-08-26 23:42:53 -07:00
Keisuke Kuroyanagi
b7bedccb29
Merge "Add TimeKeeperTest."
2014-08-27 06:13:47 +00:00
Keisuke Kuroyanagi
78aea9f133
Add TimeKeeperTest.
...
Change-Id: Id35823414f8552fd6820a5a559d6c9d54c7d6cb6
2014-08-27 14:39:27 +09:00
Yohei Yukawa
0268f7368f
am bea17c49: Introduce commit/add-to-dictionary indicators
...
* commit 'bea17c49ec23bf0f646cb548445c7756aa50d233':
Introduce commit/add-to-dictionary indicators
2014-08-27 05:01:40 +00:00
Yohei Yukawa
bea17c49ec
Introduce commit/add-to-dictionary indicators
...
This CL introduces commit/add-to-dictionary indicators.
Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.
Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
2014-08-26 21:20:27 -07:00
Ken Wakasa
4660ecaa44
Merge "Fix a bug where mic/emoji key wouldn't work."
2014-08-26 13:30:15 +00:00
Jean Chalard
e38043849e
Fix a bug where mic/emoji key wouldn't work.
...
Bug: 17272902
Bug: 17269948
Change-Id: I561609fa84a6265f8148db7d2411bc1fd38dd163
2014-08-26 22:06:21 +09:00
Jean Chalard
96522da9eb
am 2a2d324e: am 8380f921: Fix a bug where the top prediction would disappear.
...
* commit '2a2d324eb627807a9d09b491fbb4ac78ffb253fc':
Fix a bug where the top prediction would disappear.
2014-08-26 12:37:17 +00:00
Jean Chalard
2a2d324eb6
am 8380f921: Fix a bug where the top prediction would disappear.
...
* commit '8380f921f7edaeea2033a1e967a14941400fe246':
Fix a bug where the top prediction would disappear.
2014-08-26 12:25:59 +00:00
Jean Chalard
8380f921f7
Fix a bug where the top prediction would disappear.
...
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.
Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
David Faden
9cf69a45b2
Adds documentation for a few methods.
...
Change-Id: I6bdae25a8b81cdac931f2591f33570b01e34fb2c
2014-08-26 08:08:24 +00:00
Keisuke Kuroyanagi
7d47500357
Use word id to construct DicNode instead of isTerminal flag.
...
Bug: 14425059
Change-Id: I8484d34756bd76668ece34211e7366a4758d7bf5
2014-08-26 14:33:19 +09:00
Keisuke Kuroyanagi
8b4409f4b9
Use LanguageModelDictContent in getWordProperty().
...
Bug: 14425059
Change-Id: Ic230f764ff5570f24ce6ce930023798718f326df
2014-08-26 12:05:02 +09:00
Keisuke Kuroyanagi
1c14effab5
Use LanguageModelDictContent in iterateNgramEntries().
...
Bug: 14425059
Change-Id: I8a5028657ea5a4eeee8ef40db52a80f09b878972
2014-08-26 12:03:14 +09:00
Keisuke Kuroyanagi
07b3b41c25
Add a method to iterate entries in LanguageModelDictContent.
...
Bug: 14425059
Change-Id: I4e9c3a97891c020f762fa709f806d333c067f496
2014-08-26 12:01:08 +09:00
Keisuke Kuroyanagi
4793e91317
Merge "Add SparseTableTest."
2014-08-26 02:23:51 +00:00
Keisuke Kuroyanagi
30e6b21af0
Add SparseTableTest.
...
Change-Id: I5684a24f9584cd326e014274c2298773aa3a91ca
2014-08-25 22:27:01 +09:00
Keisuke Kuroyanagi
bf6fc4953b
Merge "Get dynamic dict stats via DictionaryFacilitator"
2014-08-25 11:24:54 +00:00
Yohei Yukawa
d8dfac6dcb
am abf05cc0: am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev
...
* commit 'abf05cc0da1ead7e270a7c99bf9f000dabf91f5b':
Use more descriptive names for some internal fields
2014-08-25 10:16:11 +00:00
Yohei Yukawa
abf05cc0da
am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev
...
* commit 'fdfe73ff1f4b8c9d7d8728baa322d70c3a74df99':
Use more descriptive names for some internal fields
2014-08-25 10:07:25 +00:00
Jean Chalard
1a31d784cd
Merge "Introduce onEvent() to improve testability"
2014-08-25 09:57:42 +00:00
Yohei Yukawa
fdfe73ff1f
Merge "Use more descriptive names for some internal fields" into lmp-dev
2014-08-25 09:50:59 +00:00
Tadashi G. Takaoka
d147db8763
am c500700f: am 19dd34a0: Show view even when IME is explicitly shown with physical keyboard
...
* commit 'c500700faec11b7a6d54a821009be4d657c43394':
Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:35:08 +00:00
Yohei Yukawa
a61b7245b0
Use more descriptive names for some internal fields
...
This CL clarifies that delay parameters are specified with
milliseconds.
Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
2014-08-25 02:28:01 -07:00
Jean Chalard
ee8ebeecbf
Merge "Fix unit tests"
2014-08-25 09:26:17 +00:00