bf075b21a1
Merge "Don't trim newer inputpointers with old data"
2014-02-21 11:19:04 +00:00
5eb6ea9f27
Change make-keyboard-text -java option to point LatinIME/java directory
...
Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
2014-02-21 19:24:24 +09:00
522d1575da
Import translations. DO NOT MERGE
...
Change-Id: If26d287c68a6fed1d5a8ecf6566ccd5cdfb99104
Auto-generated-cl: translation import
2014-02-21 02:20:21 -08:00
6ddefc567e
Import translations. DO NOT MERGE
...
Change-Id: Id288919148957318b18962b09e61ebe76a10c2b7
Auto-generated-cl: translation import
2014-02-21 02:13:34 -08:00
ad508d029f
Merge "Remove corrupted ver4 dictionaries."
2014-02-21 09:03:19 +00:00
d24a99cff6
Fix: file descriptor leaking.
...
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.
Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
2014-02-21 17:25:34 +09:00
2a5ec00301
Don't trim newer inputpointers with old data
...
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
2014-02-21 16:43:11 +09:00
d73044a249
Add ImportantNoticeDialog
...
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
2014-02-21 16:36:15 +09:00
d934fb43ad
Remove corrupted ver4 dictionaries.
...
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
2014-02-21 15:09:37 +09:00
fe39d576dc
Support versioned important notice
...
This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
2014-02-21 09:54:08 +09:00
3b4c1d3056
Change a heuristic and add a log.
...
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.
Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.
Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
2014-02-20 23:49:20 +09:00
1b3a142cac
Merge "Fix a bug where suggestions would not be updated."
2014-02-20 14:46:35 +00:00
6f50c95887
Fix a bug where suggestions would not be updated.
...
Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
2014-02-20 23:32:04 +09:00
a118d19f6c
Merge "Don't distrust the cursor pos so much as to bug on IPC delay"
2014-02-20 14:22:48 +00:00
3c84eb8822
Don't distrust the cursor pos so much as to bug on IPC delay
...
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
2014-02-20 23:13:14 +09:00
d36328cecf
Add test only methods to test personalized dicts.
...
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20 22:20:43 +09:00
485c1ec685
Merge "Add final and volatile for members of InputLogic."
2014-02-20 10:12:45 +00:00
afdb6f011b
Merge "Add user history dictionary decaying test."
2014-02-20 10:05:20 +00:00
b063377e77
Add final and volatile for members of InputLogic.
...
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
2014-02-20 18:55:19 +09:00
0bc66daae3
Add user history dictionary decaying test.
...
Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20 18:36:46 +09:00
a514ea7e1b
Merge "Check all enabled IME's subtypes to enable personalization."
2014-02-20 09:33:21 +00:00
d10e2d85af
Merge "Throw IOException when dict header cannot be read."
2014-02-20 09:33:08 +00:00
afd9b62f00
Throw IOException when dict header cannot be read.
...
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
2014-02-20 18:11:17 +09:00
475f9f35b6
Merge "Comments improvements"
2014-02-20 08:22:39 +00:00
1672ccbbb6
Change important notice version preference file
...
This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.
Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
2014-02-20 16:50:34 +09:00
78db739cdb
Fix build due to Ib4c472756f
...
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
2014-02-20 16:16:57 +09:00
ad2cf220a9
Merge "Remove a call to a deprecated method"
2014-02-20 06:40:46 +00:00
251ed3b358
Merge "Revert "Turn off personalization default settings""
2014-02-20 06:26:48 +00:00
c2ba73ab41
Revert "Turn off personalization default settings"
...
This reverts commit 0a4ac795d6
2014-02-20 06:06:29 +00:00
6b23749dec
Check all enabled IME's subtypes to enable personalization.
...
Bug: 13067743
Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
2014-02-20 15:05:37 +09:00
c44b7312ad
Remove a call to a deprecated method
...
...that would cause a crash
Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
2014-02-20 14:40:38 +09:00
f16d63c644
Tweak key popup animation parameters
...
Key popup show up start scale 98%
Key popup dismiss end scale 94%
Key popup show up duration 17ms
Key popup dismiss duration 53ms
Bug: 11518021
Change-Id: Icfde99969163f05cfaed1050ea074545d44db13b
2014-02-20 14:20:44 +09:00
be8ad77ebb
Comments improvements
...
Typo fixes and clarifications
Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
2014-02-20 13:29:43 +09:00
bb17354041
Merge "Import translations. DO NOT MERGE"
2014-02-19 22:16:21 +00:00
34fb962513
Call PersonalizationDictionarySessionRegistrar.init().
...
Wrongly removed in I1f50cb137b6054dc9.
Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
2014-02-19 23:27:14 +09:00
d102eb80da
Remove personalization dicts for multilingual users.
...
Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
2014-02-19 21:00:27 +09:00
920c40fe45
Use AlertDialog.setOnDismissListener
...
AlertDialog.Builder.setOnDismissListener is supported from API 17.
Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
2014-02-19 19:05:06 +09:00
ed616083dd
Merge "Turn personalization on when important notice dialog is displayed"
2014-02-19 09:46:15 +00:00
6abc852255
Turn personalization on when important notice dialog is displayed
...
This change must be checked in together with Ifde70b1d3b.
Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
2014-02-19 18:36:32 +09:00
3a7ed5fdfe
Merge "Fix IllegalStateException raied by monkey"
2014-02-19 08:27:37 +00:00
9fd7447d6c
Fix IllegalStateException raied by monkey
...
Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
2014-02-19 16:40:52 +09:00
03105290d8
Merge "Throw exception when the header cannot be read."
2014-02-19 04:59:47 +00:00
776bba098b
Merge "Turn off personalization default settings"
2014-02-19 04:25:04 +00:00
97a40d030f
Throw exception when the header cannot be read.
...
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
2014-02-19 12:35:58 +09:00
e49e007bb2
Fix: Use old suggest after reloading.
...
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
2014-02-19 12:34:09 +09:00
0a4ac795d6
Turn off personalization default settings
...
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.
Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
2014-02-19 12:08:50 +09:00
80d413caff
Merge "Straighten out database cursors behavior."
2014-02-18 11:09:38 +00:00
28e0b24965
Merge "Fix a bug where the cache would be out of sync"
2014-02-18 10:58:50 +00:00
b8ff8ca9d9
Straighten out database cursors behavior.
...
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.
It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.
Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
2014-02-18 19:58:23 +09:00
fe92c174ea
Fix a bug where the cache would be out of sync
...
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.
Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18 19:55:54 +09:00
783dabb812
Merge "Cleanup."
2014-02-18 09:54:33 +00:00
63be066544
Cleanup.
...
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
2014-02-18 17:07:46 +09:00
266c8c5b1d
Merge "Some cosmetic fixes in LatinIME.java"
2014-02-18 06:08:34 +00:00
12ff7da19d
Some cosmetic fixes in LatinIME.java
...
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
2014-02-18 14:56:50 +09:00
db21fad18f
Merge "Avoid crashing when the Content URL is not found."
2014-02-18 05:35:54 +00:00
9967f0a1d0
Avoid crashing when the Content URL is not found.
...
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.
Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
2014-02-18 14:27:58 +09:00
0f8134dc40
Merge "Import translations. DO NOT MERGE"
2014-02-18 04:58:14 +00:00
0d32643e69
Merge "Cosmetic fixes"
2014-02-18 03:28:04 +00:00
2312c1954f
Cosmetic fixes
...
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
2014-02-18 12:17:24 +09:00
cc05f468ca
Merge "Refactor InputAttributes a bit"
2014-02-18 02:25:46 +00:00
3a73aa4182
Import translations. DO NOT MERGE
...
Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709
Auto-generated-cl: translation import
2014-02-17 18:19:28 -08:00
af78cea362
Import translations. DO NOT MERGE
...
Change-Id: I2dc0e76dc4c696c1a7e9748b55e1badd273aea09
Auto-generated-cl: translation import
2014-02-17 18:17:03 -08:00
06fbfc4951
Refactor InputAttributes a bit
...
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
2014-02-18 11:11:36 +09:00
affdd36423
Set neutral suggestions should be called after load settings
...
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
2014-02-18 11:04:00 +09:00
f0f4e9fc16
Update important notice version even when user select Settings
...
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
2014-02-18 00:14:30 +09:00
782c9fee6b
Merge "Don't resume suggestion on links."
2014-02-17 11:46:54 +00:00
7a7aeffcdc
Don't resume suggestion on links.
...
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
2014-02-17 20:36:16 +09:00
d91cd9919e
Merge "Catch exceptions we can't do anything about."
2014-02-17 11:33:39 +00:00
da0edf86c4
Merge "Stop overriding InputView.dispatchTouchEvent"
2014-02-17 10:55:11 +00:00
5cd732f8c5
Stop overriding InputView.dispatchTouchEvent
...
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
2014-02-17 19:51:47 +09:00
a149731a67
Catch exceptions we can't do anything about.
...
This also abstracts away the "package deactivated" case for
simpler and safer code.
Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
2014-02-17 18:49:31 +09:00
1e9897b0c7
Merge "Consider non-breaking spaces separators."
2014-02-17 09:45:41 +00:00
891e4860f8
Merge "Stop overriding SuggestionStripView.dispatchTouchEvent"
2014-02-17 09:20:54 +00:00
c051ee7025
Consider non-breaking spaces separators.
...
Bug: 13056209
Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
2014-02-17 18:20:46 +09:00
e32548f32d
Stop overriding SuggestionStripView.dispatchTouchEvent
...
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
2014-02-17 18:11:10 +09:00
1751615f7d
Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent"
2014-02-17 08:26:38 +00:00
3dd6bdf931
Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()"
2014-02-17 08:25:57 +00:00
800ab579a9
Remove unnecessary override of MainKeyboardView.dispatchTouchEvent
...
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
2014-02-17 17:09:06 +09:00
4c628b9d5b
Merge "Don't show important notice on password field"
2014-02-17 08:04:11 +00:00
20ddd4cff5
Add InputMethodSubtypeCompatUtils.isAsciiCapable()
...
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
2014-02-17 16:08:33 +09:00
ce78a2d8ab
Don't show important notice on password field
...
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
2014-02-17 15:38:43 +09:00
4f4fb5ef34
Merge "Use the same label of switch-to-alphabet key on Emoji palette"
2014-02-17 06:13:39 +00:00
4c680e7bcf
Merge "Add go to "Settings" button to important notice dialog"
2014-02-17 06:13:26 +00:00
28c02b400f
Add go to "Settings" button to important notice dialog
...
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.
This change must be checked in together with Id115d89ba9.
Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
2014-02-17 14:57:04 +09:00
fe39aec08a
Use the same label of switch-to-alphabet key on Emoji palette
...
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
2014-02-17 14:54:39 +09:00
b092aef4a7
Merge "Remove key show up and dismiss animation"
2014-02-17 03:22:48 +00:00
c9072dc8da
Remove key show up and dismiss animation
...
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
2014-02-17 12:10:09 +09:00
ffde401b65
Fix PC/QWERTY phone layout
...
Bug: 13025426
Change-Id: I980832ccab7fb7700ca8b01d4f05e920b3f45582
2014-02-17 09:27:47 +09:00
95d16561e0
Remove unused code.
...
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
2014-02-15 17:39:24 +09:00
0fc93fe445
Implement PatriciaTriePolicy::getNextWordAndNextToken().
...
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
2014-02-15 17:39:20 +09:00
85fe06e759
Merge "Remove unused argument from readDictionaryBinary."
2014-02-14 10:37:56 +00:00
36d606fcbc
Use 16sp text to show important notice title
...
Bug: 10587358
Change-Id: Ib840cb71d9e87282ea0d13839dbf2a2da2081d5f
2014-02-14 19:10:47 +09:00
8e3a1d0f89
Remove unused argument from readDictionaryBinary.
...
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
2014-02-14 19:02:15 +09:00
b136b7dd6f
Merge "Add sanity check to KeybaordTextsTable for debugging"
2014-02-14 09:52:36 +00:00
53a237323a
Add sanity check to KeybaordTextsTable for debugging
...
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
2014-02-14 18:51:03 +09:00
fdc4173213
Merge "Fix a view-related crash"
2014-02-14 09:19:34 +00:00
a7e3e74ddd
Fix a view-related crash
...
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
2014-02-14 18:03:34 +09:00
3c4f05dd66
Remove unused label_tab_key
...
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
2014-02-14 17:40:53 +09:00
e422c94634
Fix test resource declarations and parsing a bit
...
Change-Id: I882a41b2934c48f4405f1ea5bf4d6ad41e87322c
2014-02-14 16:27:26 +09:00
d4469756be
Merge "Special punctuations for Arabic and Persian"
2014-02-14 07:20:25 +00:00
Jean Chalard
Tadashi G. Takaoka
Baligh Uddin
Keisuke Kuroyanagi
Ken Wakasa