Commit Graph

12158 Commits (8a711f2a547a61b9f4f3ef3bdb79a66b618db58f)

Author SHA1 Message Date
Jean Chalard 51d0b3351b Merge "Remove a useless method." 2014-11-07 06:00:54 +00:00
Jean Chalard 536bf61658 Merge "Remove dicttool dependency to NativeSuggestOptions" 2014-11-07 06:00:40 +00:00
Tadashi G. Takaoka 6e61cd3b3b Merge "Move some methods out from SubtypeSwitcher" 2014-11-06 23:40:06 +00:00
Sandeep Siddhartha 35bb12e010 Merge "Fix restore from keyboard" 2014-11-06 21:41:03 +00:00
Tadashi G. Takaoka 7fb0ed58ed Move current subtype management code to RichInputMethodManager
Change-Id: I82d5a17a5ec96f26047d29e79f3f28850fc5b3bb
2014-11-06 11:51:07 -08:00
Tadashi G. Takaoka 8a2c4afad4 Move shorcut IME related code from SubtypeSwitcher to RichInputMethodManager
Change-Id: I0f95f603d80570c937e8c38ded88df341c11795e
2014-11-06 11:51:07 -08:00
Tadashi G. Takaoka 2a7da0ab87 Move some methods out from SubtypeSwitcher
Change-Id: I89aaf87d7d0cc204b0ca0f61c2f64d15e2df848e
2014-11-06 11:51:01 -08:00
Baligh Uddin 8188faae1b Import translations. DO NOT MERGE
Change-Id: I4b38b31403db1ee5b5bab7a6328db1919d822d20
Auto-generated-cl: translation import
2014-11-06 08:28:08 -08:00
Baligh Uddin 84cb890e15 Import translations. DO NOT MERGE
Change-Id: Ib227ef25b8d0eef2f1b83bddfadde5c1a6d93cd8
Auto-generated-cl: translation import
2014-11-06 08:22:11 -08:00
Jean Chalard b395ce4396 Remove a useless method.
Yay for cleanup

Bug: 18108776
Change-Id: I13f4066cd54f294377fdcf375a69350c44d4a32a
2014-11-06 21:38:17 +09:00
Jean Chalard 03eb9de961 Remove dicttool dependency to NativeSuggestOptions
Bug: 18108776
Change-Id: I0f57594617f8d5080aea9002b2356d18bfe97043
2014-11-06 21:38:11 +09:00
Sandeep Siddhartha e9d814674b Fix restore from keyboard
The keyboard starts up before the restore process and the default shared
preferences are cached and used even after the restore.

Bug: 17837918
Change-Id: I2669e377b6e95813657fd6a80fbff4472330e3aa
2014-11-05 19:41:16 -08:00
Tadashi G. Takaoka b68f90ac1a Clean up KeyboardLayoutSet a bit
This CL moves getScriptId() from KeyboardLayoutSet.Builder to
KeyboardLayoutSet.

Change-Id: I13588467e3d03abb92120acb367f021ee3490a50
2014-11-06 12:30:16 +09:00
Jean Chalard ab68143ad0 Fix a bug where LatinIME would recorrect with no input view
Bug: 18071127
Change-Id: I634d1f63f7d5c5b7453ed7559f9b65fa0433dcd8
2014-11-05 17:41:15 +09:00
Tadashi G. Takaoka b1439c2872 Fix EmojiPageKeyboardView onPress bug
Change-Id: I110f36e0547be4957656217c42a8dafd9359b700
2014-11-04 20:27:39 +09:00
Tadashi G. Takaoka 3481cfc81d Fix Emoji key feedback
Bug: 18166905
Change-Id: I629eab41b78810325710ce024068b86a157186b4
2014-11-04 20:26:43 +09:00
Tadashi G. Takaoka ede88a3bd6 Merge "Revert "Fix Emoji key feedback"" 2014-11-04 11:25:58 +00:00
Tadashi G. Takaoka a5d24336bf Revert "Fix Emoji key feedback"
This reverts commit 953858d615.
The original CL should be split into two.

Change-Id: Ic1d032e2964a1b9bb44d98bdb8573c6cb47a865c
2014-11-04 11:24:26 +00:00
Tadashi G. Takaoka 11cdcf604c Fix missing ZWNJ key of BengaliAkhhor keyboard
This CL also fixes the wrong script of Bengali Akkhor.

Change-Id: Id4af2ea160b4ef3cfd40ffc5984354bc60f0b7b7
2014-11-04 18:53:28 +09:00
Tadashi G. Takaoka c514d3ead2 Merge "Fix Emoji key feedback" 2014-11-04 09:17:51 +00:00
Tadashi G. Takaoka ed264f80dc Merge "Fix symbol letter size of phone/number layout" 2014-11-04 08:49:46 +00:00
Tadashi G. Takaoka 953858d615 Fix Emoji key feedback
Bug: 18166905
Change-Id: I3c3296cabeed31e1250ff0753ea94576b494b96a
2014-11-04 17:49:18 +09:00
Tadashi G. Takaoka 981d465d78 Fix symbol letter size of phone/number layout
This CL
- decreases the size of symbols letter on number and phone layout.
- increases the size of "Pause" and "Wait" label.
- fixes "Pause" and "Wait" label for no language keyboard

Bug: 18179572
Change-Id: I6e8b4a8e07d805c3da0558b4832291ce41ad3db0
2014-11-04 16:48:04 +09:00
Tadashi G. Takaoka b9ba5fc778 Merge "Fix MainKeyboardView visibility must be aligned with main keyboard frame" 2014-11-04 07:28:23 +00:00
Tadashi G. Takaoka d071545df9 Fix number and phone keyboard visual glitches
Bug: 18179572
Change-Id: I387b965ed4f7adc5a34b63e622520e3c88ffd5ca
2014-11-04 13:35:24 +09:00
Tadashi G. Takaoka 98dfa6e334 Fix MainKeyboardView visibility must be aligned with main keyboard frame
Bug: 18105755
Change-Id: Ifdcaded538d0eac3b100486ddf27ae4314293792
2014-11-04 13:17:07 +09:00
Tadashi G. Takaoka d60f49425b Merge "Make DrawingProxy and TimerProxy as a top-level interface" 2014-11-04 02:52:15 +00:00
Ken Wakasa 933920feae Fix a wrong indent
Change-Id: Iaee83be85bb52c350dd08e4497732927b92eabcd
2014-11-04 11:18:52 +09:00
Geoff Mendal 85d08274b2 Merge "Import translations. DO NOT MERGE" 2014-11-03 14:15:56 +00:00
Geoff Mendal 615710cfdc Import translations. DO NOT MERGE
Change-Id: I3e67ed5ff3bbdbc372dfd1b3b408ac2c095fe6d6
Auto-generated-cl: translation import
2014-11-03 06:13:00 -08:00
Geoff Mendal 7cb5cd8ff4 Import translations. DO NOT MERGE
Change-Id: I4a4f46a2e3aa848ba9ac47300815f6ccf8af808b
Auto-generated-cl: translation import
2014-11-03 06:09:34 -08:00
Ken Wakasa f296e7cdfa Small comment fixes
Change-Id: Iecb432c414eadf13ee6a57fb21fc02d1c27e777f
2014-11-02 23:54:20 +09:00
Tadashi G. Takaoka c235a3be9d Add debug logging
Change-Id: I38bf53a0b5ea5064462b8eb5d99b7247ff8bddc4
2014-11-02 22:34:43 +09:00
Keisuke Kuroyanagi b3bae2e89b Merge "Update v4 format version from 402 to 403." 2014-10-31 14:19:44 +00:00
Tadashi G. Takaoka ef8068f9a8 Merge "Add helper methods to convert flags to readable text" 2014-10-31 10:12:37 +00:00
Keisuke Kuroyanagi ea468cc9de Update v4 format version from 402 to 403.
Without personalization:
Total words: 1134774, Success Num: 899230, Success Percentage: 79.243%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1871, Bad Failure Percentage: 0.165%
Failures, with auto-correction (F-C): 29084, F-C Percentage: 2.563%
Max Keystrokes: 6072959, Min Keystrokes: 4436090, Keystroke Saving Percentage:26.953%

Before:
Total words: 1134646, Success Num: 925194, Success Percentage: 81.540%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1316, Bad Failure Percentage: 0.116%
Failures, with auto-correction (F-C): 28288, F-C Percentage: 2.493%
Max Keystrokes: 6072831, Min Keystrokes: 3946188, Keystroke Saving Percentage:35.019%

After
Total words: 1134659, Success Num: 944746, Success Percentage: 83.263%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28016, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3387333, Keystroke Saving Percentage:44.222%

Change-Id: I3af42ec37a11847c0429c28616e726f6a339247f
2014-10-31 17:23:39 +09:00
Jean Chalard 5840a7c6e7 Merge "Remove Dict dependency on WordComposer and ProximityInfo" 2014-10-31 07:59:12 +00:00
Tadashi G. Takaoka 9dc3ae84ee Add helper methods to convert flags to readable text
Change-Id: I23608927cef8a897ff4ad8c938560cc78093ddac
2014-10-31 16:20:20 +09:00
Ken Wakasa ed575b62da Merge "Add documentation for CollectionUtils#arrayAsList" 2014-10-31 07:07:07 +00:00
David Faden d443146c34 Add documentation for CollectionUtils#arrayAsList
(This is a cherrypick of http://ag/576739)

Also, modify the IllegalArgumentException to capture the
values passed for start, end, and array.length to make
debugging easier in the unlikely event that it is thrown.
Add corresponding tests for the exceptions.

Tested:
tapas LatinImeGoogle LatinImeGoogleTests userdebug
make -j30 && \
adb install -r \
out/target/product/generic/data/app/LatinImeGoogleTests/LatinImeGoogleTests.apk && \
adb install -r \
out/target/product/generic/system/app/LatinImeGoogle/LatinImeGoogle.apk && \
adb shell am instrument -w -e class \
com.android.inputmethod.latin.utils.CollectionUtilsTests \
com.google.android.inputmethod.latin.tests/android.support.test.runner.AndroidJUnitRunner

Change-Id: I0c579ca4f4f2a9b2575aa6f8fa75e3ee4a21cf8a
2014-10-31 06:18:35 +00:00
Adrian Velicu 88480f39f6 Update unit tests for new static dict version.
Bug: 11031090
Change-Id: Ifd7b241f1a0a30678ca7de97cc6e96927a9b5c8f
2014-10-31 14:50:18 +09:00
Adrian Velicu 8dd31a28ae Update dictionaries (possibly_offensive flag)
Correctly encoding possibly offensive words with their correct
frequency and the possibly_offensive flag set.

Continuing to encode with zero frequency only distracters or
words that should never come up.

https://paste.googleplex.com/5167060875214848

Bug: 11031090
Change-Id: Ia394b1827f292ff8d4791cc2f3e6e50b5aff4cbe
2014-10-31 14:49:24 +09:00
Adrian Velicu 7c87859d4c Using "blacklist" flag as "possibly offensive"
Bug: 11031090
Change-Id: I5cc0d006ab003656498eb82b0875eb9c051d331e
2014-10-31 14:33:05 +09:00
Tadashi G. Takaoka 8523720b22 Remove deprecated Canvas.clipRegion(Region) call
Change-Id: I88e0a8d327c17bf4bafbe44cdfa265f5d0acb879
2014-10-31 14:06:30 +09:00
Tadashi G. Takaoka 77947c9c96 Merge "Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy" 2014-10-30 09:55:51 +00:00
Tadashi G. Takaoka 34a9e2ae87 Make DrawingProxy and TimerProxy as a top-level interface
Change-Id: Ia425f341255595f8f80c13b2aa409249f9ce4202
2014-10-30 18:29:49 +09:00
Tadashi G. Takaoka be708c4e59 Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy
Change-Id: I654f7483d1c013ac2685a45af4eb2af15fa219ad
2014-10-30 18:28:40 +09:00
Andy Wang 0ca400c827 Merge "Add a preference to resize the keyboard height." 2014-10-30 03:37:26 +00:00
Tadashi G. Takaoka d9b1327c21 Merge "Consolidate similar methods" 2014-10-30 02:54:38 +00:00
Andy Wang bb9400aebc Add a preference to resize the keyboard height.
The keyboard height is controlled by a slider in the debug preferences.
Without access to debug preferences, this change is a no-op.

Bug: 6867494
Change-Id: I984064ed1cab752876615f5ed582818474d6041b
2014-10-30 11:45:41 +09:00
Tadashi G. Takaoka d2c00f550d Fix dismiss key preview bug introduced by I658a5b16cc
Change-Id: I5248374dfe0504f6e64cc5d994e275d80364ec9d
2014-10-30 11:43:53 +09:00
Tadashi G. Takaoka 051f8b1442 Consolidate similar methods
This CL consolidates similar methods in MainKeyboardView.
- startWhileTypingFadeinAnimation and startWhileTypingFadeoutAnimation
- showSlidingKeyInputPreview and dismissSlidingKeyInputPreview

Change-Id: I607ab74683820de2456af3e75663cf8cf358ab38
2014-10-30 11:15:59 +09:00
Geoff Mendal c96bb3e9a7 Merge "Import translations. DO NOT MERGE" 2014-10-29 19:14:14 +00:00
Geoff Mendal 4caa03c839 Import translations. DO NOT MERGE
Change-Id: I3643a631ae94f295bdcd4cf4427fd4bcfef00a17
Auto-generated-cl: translation import
2014-10-29 12:02:07 -07:00
Tadashi G. Takaoka 4e0149c22a Merge "Remove DrawingHandler" 2014-10-29 13:42:44 +00:00
Jean Chalard 93e5cdea71 Merge "[CS8] Add explanations" 2014-10-29 12:26:23 +00:00
Tadashi G. Takaoka 2ad6d9cda3 Remove DrawingHandler
Change-Id: I658a5b16cca1e56f0b944009b8aef09e0a97a0db
2014-10-29 18:51:41 +09:00
Tadashi G. Takaoka ca6e5dfedb Remove DrawingHandler.Callbacks.dismissAllKeyPreviews()
Change-Id: I2b11ca0dec0f3522648557a9a909f305cc4170fb
2014-10-29 15:25:09 +09:00
Jean Chalard ecab6aff59 Remove Dict dependency on WordComposer and ProximityInfo
Bug: 18108776
Change-Id: I9b399a44241e05a7add9bb8094263aa76de37880
2014-10-29 12:27:24 +09:00
Jean Chalard 36799b2aa2 Move InputPointers and ResizableIntArray to common
Bug: 18108776
Change-Id: Ie5c0430aa41a8d6c58bf510a10173223d7dfe9fe
2014-10-29 12:09:11 +09:00
Tadashi G. Takaoka 48ee473c1e Merge "Clean up UserDictionaryCompatUtils" 2014-10-29 00:37:43 +00:00
Jean Chalard 4beeb9253a Move StringUtils under common.
Bug: 18108776
Change-Id: Ia46a4102a0e86e71118ca5e641f9f531998e166b
2014-10-28 22:44:30 +09:00
Jean Chalard ca724ef71f Reduce StringUtils dependency on the Android libs
Bug: 18108776
Change-Id: I43feb25d79f89276d44462ba71788a14c4583277
2014-10-28 22:03:18 +09:00
Tadashi G. Takaoka fec5219974 Fix Serbian Latin subtype handling
This CL also adds unit tests for Hinglish and Serbian Latin.

Bug: 9687668
Bug: 17169632
Change-Id: Ib9aa1bcdf5b390a9d8c61f07165beacf850e2692
2014-10-28 18:36:16 +09:00
Tadashi G. Takaoka dccf4f2a41 Clean up UserDictionaryCompatUtils
Change-Id: I1b22c82930af4f30db4237335850fb34b66f9299
2014-10-28 17:42:17 +09:00
Tadashi G. Takaoka 395009c03e Fix NPE in AppearanceSettingsFragment
Bug: 18147440
Change-Id: I7a7a47b3484e54146d34d11b5bd9c1305421d829
2014-10-28 15:02:31 +09:00
Jean Chalard 67527f847e [CS8] Add explanations
Bug: 13238601
Change-Id: I72a78be5848485f7fd77f5586573692529c7547b
2014-10-28 13:41:00 +09:00
Tadashi G. Takaoka d5455fea4a Merge "Add null analysis annotation to CollectionUtils" 2014-10-27 09:43:22 +00:00
Tadashi G. Takaoka 7a3de4dca9 Add null analysis annotation to CollectionUtils
Change-Id: I3a610b037d6d1431cced3ea193171108bd5a040d
2014-10-27 18:30:29 +09:00
Tadashi G. Takaoka f6a6371096 Refactor CoordinateUtils
Change-Id: I607b803273a4d7983e9e25a81b6941a3b59194c6
2014-10-27 18:02:33 +09:00
Tadashi G. Takaoka f7e01e866f Remove device checking of Emoji physical key
This CL also adds a settings option to enable/disable an Emoji-ALT
physical key.

Bug: 18122464
Change-Id: Iee1d97efec979a902b0492071d5e511ca1792ff0
2014-10-27 16:26:22 +09:00
Ken Wakasa 53b010384e Remove an unused import
Follow up to I2b81450f99d7b4493ba0fc5e502f4333b8db48cd

Change-Id: I3d106db076e8181b65ce6843b801d12c6ca0adb1
2014-10-24 21:36:24 +09:00
Ken Wakasa 23a357d71d Small cleanup
Change-Id: I2b81450f99d7b4493ba0fc5e502f4333b8db48cd
2014-10-24 19:47:26 +09:00
Tadashi G. Takaoka 067d8cdf56 Fix unit test breakage
Change-Id: I538288054a58eb2c81ce3cbe5c9bef900fb653a5
2014-10-24 16:48:46 +09:00
Keisuke Kuroyanagi aad188d40a Merge "Height of the keyboard for spellchecker is too large." 2014-10-24 06:29:10 +00:00
Keisuke Kuroyanagi 6cc318bd6a Height of the keyboard for spellchecker is too large.
Bug: 18109041
Change-Id: I0eb98a66290058c28e20c86f36395af4f763952e
2014-10-24 14:59:52 +09:00
Ken Wakasa 7e88eae623 Add missing header
Change-Id: I1befc2f1288674b4d871b27bdc5251b2b95e8bb7
2014-10-24 12:00:26 +09:00
Ken Wakasa 2c6aaa7c3c Merge "Move Constants.java to the latin.common package" 2014-10-24 02:50:07 +00:00
Keisuke Kuroyanagi 989699a690 Fix unit tests (InputLogicTestsDeadKeys).
Change-Id: I9a3191548aa0a4e674d736bc10845b952fc9a1e8
2014-10-23 22:09:08 +09:00
Ken Wakasa 9342484e8d Move Constants.java to the latin.common package
Our intention is to have classes of latinime-common under the common
package as much as we can.

Change-Id: I76efbbbe7bebf1a4aa943715cdff64f91675e20d
2014-10-23 20:27:37 +09:00
Jean Chalard b224594aca Merge "Fix a concurrency bug that ends up in a crash." 2014-10-23 08:02:37 +00:00
Keisuke Kuroyanagi ade5ad1dae Merge "Use trigrams for personalization dict." 2014-10-23 05:42:38 +00:00
Keisuke Kuroyanagi 16cc3992d7 Use trigrams for personalization dict.
5Bug: 14425059
Change-Id: I73cf6904e569d60996a3b079f16ea6df0cb90f02
2014-10-23 14:32:45 +09:00
Ken Wakasa b11fc7d423 Move annotations classes to latiime-common
Move Constants.java too.

Change-Id: I55e8cf06f61c0a37746a7328834a52a5306cf0f2
2014-10-23 13:00:46 +09:00
Jean Chalard 4097a20b36 Fix a concurrency bug that ends up in a crash.
Bug: 18085768
Change-Id: I016bec997787839526ddfc521ebb99d0c7b05189
2014-10-23 12:36:42 +09:00
Tadashi G. Takaoka d3a4c51324 Fix Javadoc and null analysis related warnings
This CL also adds @SuppressWarning("unused" to java-overridable package.

Bug: 18003991
Change-Id: If70527e30654384705d7a814f5efd181d9f539e1
2014-10-23 09:58:42 +09:00
Tadashi G. Takaoka 924b8fd0fa Merge "Enable preliminary subtypes for F-release" 2014-10-23 00:19:03 +00:00
Geoff Mendal 2e30c86c84 Import translations. DO NOT MERGE
Change-Id: Ia95e94fb8246f5b44753b8091fca45c3e650f732
Auto-generated-cl: translation import
2014-10-22 13:26:03 -07:00
Ken Wakasa d42df5125d Merge "Add latinime-common local lib" 2014-10-22 10:28:19 +00:00
Ken Wakasa 54a1b8ec54 Add latinime-common local lib
This is just a placeholder in this CL. It will be shared by LatinIME,
dicttool, and tests.

Change-Id: I6fb3516a5061555f6f24b29141c2871d2319b023
2014-10-22 19:26:21 +09:00
Tadashi G. Takaoka 45c917e238 Enable preliminary subtypes for F-release
Bug: 17743363
Change-Id: I098ae6e21a7f2a1ceed1d206740a2d12e1ef7d99
2014-10-22 18:52:53 +09:00
Keisuke Kuroyanagi b5ef884fbb Support dumping ngram entries.
Bug: 14425059
Change-Id: Ib03a0c3d166ed6f1e60c67127b28006d55143b6b
2014-10-22 18:15:53 +09:00
Yohei Yukawa baecaa5411 Merge "Remove BuildCompatUtils.VERSION_CODES_LXX" 2014-10-22 02:01:32 +00:00
Yohei Yukawa 66d30a4b22 Remove BuildCompatUtils.VERSION_CODES_LXX
Finally it is turned out to be a XXL-size Lollipop.

Change-Id: Icbd22506be9de514eba287cdd8d97fbfd070ac09
2014-10-22 01:29:58 +09:00
Yohei Yukawa 63cbdf49b9 Add @Override for a method that is overriding a new L API
Now all the downstream builds have switched to API Level 21.
Hence putting @Override to new APIs no longer makes javac unhappy.

Change-Id: Ib3324a5d06b17d298beacab8c8802bb14e5be968
2014-10-22 01:28:10 +09:00
Tadashi G. Takaoka 46a007261f Merge "Fix some compiler warnings" 2014-10-21 15:06:55 +00:00
Tadashi G. Takaoka 5f00fe09e9 Fix some compiler warnings
This CL fixes the following compiler warnings.

- Indirect access to static member
- Access to a non-accessible member of an enclosing type
- Parameter assignment
- Method can be static
- Local variable declaration hides another field or variable
- Value of local variable is not used
- Unused import
- Unused private member
- Unnecessary 'else' statement
- Unnecessary declaration of throw exception
- Redundant type arguments
- Missing '@Override' annotation
- Unused '@SuppressWarning' annotations

Bug: 18003991
Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
2014-10-21 19:28:37 +09:00
Tadashi G. Takaoka 2105aa3ea6 Merge "FIx potential NPE" 2014-10-21 08:14:46 +00:00
Tadashi G. Takaoka 097bcdcde8 FIx potential NPE
Bug: 18052047
Change-Id: I9097d0a504b8a1d875cf66e44bb65eb6ecc8908e
2014-10-21 14:13:27 +09:00
Adrian Velicu 05172bf1a5 Renaming "blacklist" flag to "possibly offensive"
No behaviour changes.
Unified the overloaded FusionDictionary::add method to always take an
isPossiblyOffensive argument.

Bug: 11031090
Change-Id: I5741a023ca1ce842d2cf10d4f6c926b0efabaa78
2014-10-21 11:51:47 +09:00