nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30842 commits 1 branch 0 tags 363 MiB
Commit graph

6807 commits

Author SHA1 Message Date
Jean Chalard
cbed462d19 [CB12] Reset the combining state when resetting the composer 
Bug: 13406701
Change-Id: I490574b7ca4b953f67dd2c0ef97401297fade0a4
 2014-03-24 17:44:31 +09:00
Jean Chalard
7f0e5fa66c Merge "[CB11] Get the result of the combination" 2014-03-24 05:33:34 +00:00
Jean Chalard
1dda9107ca Merge "Rework the logic that tells if the cursor touches words" 2014-03-20 14:35:19 +00:00
Jean Chalard
835965a75e [CB11] Get the result of the combination 
Change-Id: I165ec4a24f5b1334d55c14948e4d942ec40eb33b
 2014-03-20 23:33:12 +09:00
Jean Chalard
72b67f6541 Rework the logic that tells if the cursor touches words 
Bug: 13312942
Change-Id: I6be6a558bbc6c88508150f9c25cadbd0240ff88e
 2014-03-20 23:16:53 +09:00
Jean Chalard
4df6bc0853 Merge "[CB10] Add an event for string input" 2014-03-20 11:34:16 +00:00
Jean Chalard
058a38988b [CB10] Add an event for string input 
Change-Id: Ie5da6c73d4df4553067c58cd0dce9abb34534250
 2014-03-20 19:47:01 +09:00
Tadashi G. Takaoka
b20dad6fab Merge "Consolidate KeyboardTextsSet.setLocale and loadStringResoucres" 2014-03-20 09:59:11 +00:00
Tadashi G. Takaoka
df39eb6961 Consolidate KeyboardTextsSet.setLocale and loadStringResoucres 
Change-Id: Idaf8f0d80fdeef4f1430f11d4083366e8ab7f6e0
 2014-03-20 18:55:03 +09:00
Keisuke Kuroyanagi
7c20f140e0 Merge "Remove unused partial commit." 2014-03-20 09:54:15 +00:00
Tadashi G. Takaoka
0c268b08b6 Merge "Refactor KeyboardTextsSet class" 2014-03-20 09:52:02 +00:00
Keisuke Kuroyanagi
5a0381f7d0 Remove unused partial commit. 
Change-Id: Ia9341a5cb24947d93056810890d94c1f66481d8c
 2014-03-20 18:47:45 +09:00
Tadashi G. Takaoka
6007a1b7a9 Refactor KeyboardTextsSet class 
Change-Id: Ibb59a9d4902db9ec0e00244304be9ab35b215a50
 2014-03-20 18:38:59 +09:00
Jean Chalard
437dbbcfee Merge "[IL127] Move the double space countdown to InputLogic" 2014-03-20 09:07:49 +00:00
Tadashi G. Takaoka
aacfa31c8e Merge "Remove reference of KeyboardTextsSet from SpacingAndPunctuations" 2014-03-20 08:46:11 +00:00
Jean Chalard
83372e75e4 Merge "[CB09] Pass events through the combiner chain" 2014-03-20 08:32:36 +00:00
Tadashi G. Takaoka
44f144ab3a Remove reference of KeyboardTextsSet from SpacingAndPunctuations 
Change-Id: I76a8fcbd2466bcaf9cd85501af270db5aa913999
 2014-03-20 17:14:43 +09:00
Tadashi G. Takaoka
e7420f6bd1 Merge "Utilize autoColumnOrder for punctuation more keys" 2014-03-20 08:01:18 +00:00
Jean Chalard
f2bb15b0ab [CB09] Pass events through the combiner chain 
Bug: 13406701
Change-Id: I4696f145478afdd132314b7d3c148c3a9ca11c9c
 2014-03-20 16:59:29 +09:00
Tadashi G. Takaoka
844205ca2e Utilize autoColumnOrder for punctuation more keys 
Change-Id: I1f8f5013f0bdf93cf590b8bd00d680b31e03d8b0
 2014-03-20 16:38:38 +09:00
Jean Chalard
c083733972 Merge "[CB08] Create a combiner chain in the word composer." 2014-03-20 07:02:48 +00:00
Tadashi G. Takaoka
e884fde8d2 Merge "Fix Armenian punctuation order" 2014-03-20 06:43:50 +00:00
Jean Chalard
7ede642df4 [CB08] Create a combiner chain in the word composer. 
Bug: 13406701
Change-Id: I3b9f75de9283f76366d1bef7e14a8f22f2186669
 2014-03-20 14:27:55 +09:00
Tadashi G. Takaoka
d51aebd328 Fix Armenian punctuation order 
Bug: 12623502
Change-Id: I6cc026132922e103d212b663664e7e0aa2404b35
 2014-03-20 13:17:38 +09:00
Tadashi G. Takaoka
89f1b72793 Merge "Remove Latin comma from Arabic/Persian keyboard" 2014-03-20 03:56:02 +00:00
Tadashi G. Takaoka
f96bffa69e Suppress important notice when its title message is empty 
Bug: 13422608
Change-Id: Ied16e87381e82d8539269ddd90d737f80c2a94c0
 2014-03-20 11:48:28 +09:00
Tadashi G. Takaoka
270bd39af4 Remove Latin comma from Arabic/Persian keyboard 
Bug: 12807701
Change-Id: Icca63586d561a57b2c15cbfbae0de98dfcc137a3
 2014-03-20 11:45:53 +09:00
Tadashi G. Takaoka
14e908c348 Remove unused argument in SuggestionStripLayoutHelper 
Bug: 13461039
Change-Id: I3f6227bd56fb81021aaacf0e901eab8a9e91d4a1
 2014-03-20 11:06:55 +09:00
Tadashi G. Takaoka
110e9f9e88 Add Galician keyboard 
Bug: 13169021
Bug: 13017434
Change-Id: I5d44dc4c2387644028a5cf594954795e014f357a
 2014-03-19 19:41:18 +09:00
Tadashi G. Takaoka
0c797e8867 Add Basque keyboard 
Bug: 13169021
Bug: 13017434
Change-Id: I46c738e833a9f287586a03bda9ab0230f8b9eac1
 2014-03-19 19:40:34 +09:00
Tadashi G. Takaoka
682853c3af Merge "Fix French accented letters order" 2014-03-19 10:38:01 +00:00
Jean Chalard
350d73932d [IL127] Move the double space countdown to InputLogic 
Bug: 8636060
Change-Id: Ie193b747bd9d0b5ba6a986b9a3c746c2182742ed
 2014-03-19 17:47:03 +09:00
Jean Chalard
554346e94c [IL126] Move a setting value to SettingsValues 
Bug: 8636060
Change-Id: I7cb082df13a10cf5a3aa5786e6a9599376652dee
 2014-03-19 17:47:03 +09:00
Jean Chalard
46e17983c6 [IL125] Remove arg to onPickSuggestionManually 
Bug: 8636060

Change-Id: I55332c22897e97148621cbd367acf5175b5b3d04
 2014-03-19 17:47:03 +09:00
Tadashi G. Takaoka
4640e7c989 Fix French accented letters order 
Bug: 13497958
Change-Id: I062a0e2e75b2f6c2606b1309808cbaa83cc91018
 2014-03-19 17:43:53 +09:00
Tadashi G. Takaoka
1325ddbae3 Merge "Guard possible NumberFormatException" 2014-03-18 07:26:18 +00:00
Tadashi G. Takaoka
d2c6151d4d Guard possible NumberFormatException 
Bug: 13472379
Change-Id: Ib7640b3d8816d8d7fb4747d2288eedd94bc49b06
 2014-03-18 15:40:43 +09:00
Tadashi G. Takaoka
6bdb2e60dc Merge "Add preliminary Myanmar keyboard" 2014-03-18 05:53:51 +00:00
Tadashi G. Takaoka
fc3263a75c Add preliminary Myanmar keyboard 
This CL adds preliminary Myanmar keyboard as a groundwork. The
keyboard layout comes mainly from virtual keyboard of
<http://www.google.com.mm/>

Bug: 7963632
Change-Id: I36504ceb6c2079a6e133edaeb458da1c5cf3ded2
 2014-03-18 10:28:57 +09:00
Jean Chalard
1110adad11 [CB07] Small refactoring 
Bug: 8689779
Change-Id: I2cf10c690c7e4a9c6bf27211d1fccc1f9d4a9249
 2014-03-17 21:26:36 +09:00
Jean Chalard
5eac728b4a [CB06] Fix a design error. 
The event interpreter should intervene later, after decoding.
Decoding should happen first, and then the Event should
be passed to the InputLogic.

For the time being, we will leave the (unused) EventInterpreter
class and its friends, because we'll use them again later.

Bug: 13406701
Change-Id: I7582d486724311e39e6692e606cca50c78800643
 2014-03-17 20:49:29 +09:00
Tadashi G. Takaoka
ef27c83e74 Fix Persian symbols shifted output text 
Bug: 13017434
Change-Id: I57af849ae4342bfee3fa08d7e90c6a6dbc229380
 2014-03-17 12:31:09 +09:00
Tadashi G. Takaoka
538abc27dc Fix Arabic keyboard text and test comments 
Bug: 13017434

Change-Id: Iec2ddab719e0c68a70bcf56a90eb4522c5fd7978
 2014-03-17 11:56:13 +09:00
Jean Chalard
5a1e351751 Merge "[CB04] Add an event array to WordComposer." 2014-03-14 04:29:59 +00:00
Jean Chalard
f8accd8839 [CB04] Add an event array to WordComposer. 
Bug: 13406701
Change-Id: I9ecd2709c8f1c678a85b0cfaf7c5ed4f78459821
 2014-03-14 12:44:49 +09:00
Tadashi G. Takaoka
a9c1a3da63 Fix clipped important notice message on tablet 
Bug: 13461039
Change-Id: I710bf10c9cbc202c7f6ee39ab4c8b9d699741a81
 2014-03-14 12:32:38 +09:00
Jean Chalard
309773c322 Merge "[CB03] Pass whole events to the various input logic handlers." 2014-03-13 12:12:31 +00:00
Tadashi G. Takaoka
a8e3ae6e96 Merge "Refactor keyboard layout test more customizable" 2014-03-13 12:09:47 +00:00
Tadashi G. Takaoka
15a6b66dda Refactor keyboard layout test more customizable 
Bug: 13017434
Change-Id: I804b4cb9f56684d425e83a20cb3f71d947a87f98
 2014-03-13 20:55:22 +09:00
Jean Chalard
750cd48981 [CB03] Pass whole events to the various input logic handlers. 
Bug: 13406701
Change-Id: I0a0e4e0b3357f116e1b915c548dee4575e300c92
 2014-03-13 19:35:54 +09:00
Jean Chalard
a79a3265db [CB02] Pass an Event to onCodeInput. 
Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
 2014-03-13 18:41:02 +09:00
Jean Chalard
66dce6003f Merge "[CB01] Reset some old assumptions about dead keys" 2014-03-13 08:53:29 +00:00
Jean Chalard
92db209c60 [CB01] Reset some old assumptions about dead keys 
The combining framework will be more generic than previously
thought. We don't need to handle dead keys as a special type
of event, as all events can be combined arbitrarily.

Bug: 13406701
Change-Id: I8137fdb186c4d70eaa71808c5a1430b1559db1ae
 2014-03-13 17:47:13 +09:00
Jean Chalard
13b446b8fb Merge "Don't reset the value needed before it's used" 2014-03-12 08:04:42 +00:00
Tadashi G. Takaoka
567fbe90f7 Fix unused text resources of keyboard layouts 
Icelandic keyboard has no nordic layout.
Latvian, Lithuanian, and Slovak keyboards have duplicated N WITH ACUTE.
No Language keyboard has duplicated letter a variants.

Change-Id: Iaeacebc1f7efdb70294e6342e42232b73aed9398
 2014-03-10 17:31:25 +09:00
Jean Chalard
e93a7232d1 Don't reset the value needed before it's used 
Nice recipe for failure

Bug: 13387534
Change-Id: Ida1978449c1997587b2ec0955c5c94fcef336121
 2014-03-10 15:55:15 +09:00
Tadashi G. Takaoka
e07a777ed6 Fix unneeded u with diaeresis more key on Swedish keyboard 
Change-Id: Ib4a17fa464899907616e76426e5df0d370a40f80
 2014-03-10 11:15:18 +09:00
Tadashi G. Takaoka
315010636a Fix excessive more keys on Estonian keyboard 
Change-Id: I6c2d5d123d519278a6ff0f12fece69ccbad1aad5
 2014-03-10 10:56:26 +09:00
Keisuke Kuroyanagi
32326a9d7a Merge "Move DictionaryOptions from FusionDictionary to FormatSpec." 2014-03-07 10:42:18 +00:00
Keisuke Kuroyanagi
e137ec0a91 Introduce SuggestionResults and use it for predictions. 
Bug: 8187060
Bug: 13333066
Change-Id: I1ead897024508b7e40fbd93af7d14bfe74b93826
 2014-03-07 19:36:19 +09:00
Keisuke Kuroyanagi
a103e29d00 Merge "Separate WeightedString from FusionDictionary." 2014-03-07 09:07:26 +00:00
Tadashi G. Takaoka
ff8405cdfb Add ActualKeyboardBuilder for testing keyboard layouts 
Bug: 13017434
Change-Id: I38b1f5c261ea1f3ff312c780d7d9b5fe3fba8aaf
 2014-03-07 17:29:58 +09:00
Keisuke Kuroyanagi
3ad4af2354 Move DictionaryOptions from FusionDictionary to FormatSpec. 
Bug: 8187060
Bug:13035567

Change-Id: Id4f45e589521ae98c926a4c0607be10ce1a983f2
 2014-03-06 18:53:09 +09:00
Keisuke Kuroyanagi
516f86815d Separate WeightedString from FusionDictionary. 
Bug: 8187060

Change-Id: I40c1dafca3eb52244c64fdb4c1db30a56385d678
 2014-03-06 18:53:06 +09:00
Jean Chalard
3892991b80 Merge "[IL124] Remove the KeyboardSwitcher arg to onCodeInput" 2014-03-06 09:15:26 +00:00
Jean Chalard
4da06b9a19 Merge "Correctly update the suggestion strip on non-resumable word" 2014-03-06 08:54:44 +00:00
Keisuke Kuroyanagi
d93eb680c4 Merge "Use BinaryDictionaryUtils to read dictionary header." 2014-03-06 07:32:07 +00:00
Jean Chalard
a1bf550294 [IL124] Remove the KeyboardSwitcher arg to onCodeInput 
Bug: 8636060
Change-Id: I29ce4c82ea880a937b1c9e5daf494fcdbbdd1336
 2014-03-06 14:20:41 +09:00
Jean Chalard
db38d5cf63 [IL123] Put the settings values inside the transaction 
A transaction should always operate with a consistent set
of settings. It's better to have it reference them than to
always pass them along.

Bug: 8636060
Change-Id: I3c642dfea6be30712fc6cbb279c64f3185895791
 2014-03-06 14:20:37 +09:00
Jean Chalard
5054530934 Merge "[IL122] Put the code, x and y in the transaction" 2014-03-06 03:55:00 +00:00
Jean Chalard
29881854bc [IL122] Put the code, x and y in the transaction 
Bug: 8636060
Change-Id: Icdf87995dedec410b54c306e8d312ba7ec25cea6
 2014-03-06 12:50:07 +09:00
Tadashi G. Takaoka
dbe531efa8 Merge "Remove unused text resource keylabel_for_east_slavic_row1_12" 2014-03-06 02:47:06 +00:00
Keisuke Kuroyanagi
de36b47d29 Use BinaryDictionaryUtils to read dictionary header. 
Bug: 8187060
Bug:13035567
Change-Id: I90a5e0665c367f5a1bd786f4babf0d03e79e68fa
 2014-03-05 19:42:53 +09:00
Keisuke Kuroyanagi
274eae95ba Merge "Separate utility methods from BinaryDictionary." 2014-03-05 10:07:33 +00:00
Jean Chalard
c6e200ef3a Correctly update the suggestion strip on non-resumable word 
Bug: 13303965
Change-Id: Iedc5d38f70af76fbebb99e59a0d17c1e226c810d
 2014-03-05 18:47:41 +09:00
Keisuke Kuroyanagi
e784148ae6 Separate utility methods from BinaryDictionary. 
Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50
 2014-03-05 18:19:34 +09:00
Jean Chalard
7b905c40e9 [IL121] Introduce InputTransaction 
We probably can't put this off any longer

Bug: 8636060
Change-Id: I1e5d3cf62d719f4d064ced3282bebf2e822f6baa
 2014-03-05 17:04:10 +09:00
Tadashi G. Takaoka
8204078a84 Merge "Remove unused MoreKeysPanel argument from Controller interface" 2014-03-04 10:53:23 +00:00
Jean Chalard
151761a276 [IL120] Cleanup 
Remove useless arguments, local vars, make stuff private

Change-Id: I7cc6c19e9c1703304d593e02be31eb9569cc7b4e
 2014-03-04 17:52:14 +09:00
Jean Chalard
fb28935f82 [IL119] Make fields private. 
Change-Id: Ia84d3e5a102e1056e3d7467be07df89390f17617
 2014-03-04 17:52:14 +09:00
Jean Chalard
0e489d1ba3 [IL118] Factorize a method 
If we can't get the right locale from the subtype switcher, we
should fallback in all cases.

Change-Id: I46a53a67927a793d9d3592a996a5a4392a36c6ff
 2014-03-04 17:52:14 +09:00
Jean Chalard
129ca9e7eb [IL117] Simplification 
Change-Id: Id4d4f30ecdc80dd59543f90fe2525f4bcc5afb9d
 2014-03-04 17:52:11 +09:00
Tadashi G. Takaoka
4309b83ea9 Remove unused text resource keylabel_for_east_slavic_row1_12 
The text resource used in 10 inch tablet layout.

This change also corrects {keylabel|more_keys}_for_east_slavic_row2_1
to _row2_2.

Change-Id: I60d69af22f97c008449b8dccc7c84ae6a05fe0d8
 2014-03-04 17:12:31 +09:00
Tadashi G. Takaoka
1f215a58c9 Remove unused MoreKeysPanel argument from Controller interface 
Bug: 13204690
Change-Id: Ife438e78d9bbbf796df20f95c2da7a4d50e5a035
 2014-03-04 16:05:15 +09:00
Jean Chalard
2ca916c215 [IL116] Inline a method 
Change-Id: I6af8f2bd6b4917f9b119ff78a0f299b2f6fb921e
 2014-03-04 14:46:04 +09:00
Jean Chalard
e110018e2a [IL114] Move a method to InputLogic 
Bug: 8636060
Change-Id: I0d8f93985ddc6e93ce9af0d92a8056620351a498
 2014-03-04 14:46:04 +09:00
Jean Chalard
030da519de [IL115] Cleanup continues 
Bug: 8636060
Change-Id: I944b10ec9798eec57d986e1075ba348aa0892cae
 2014-03-04 14:46:04 +09:00
Jean Chalard
5d8f6660bf [IL113] More cleanup 
We should not test punctuation with this equality test any more.
Also, whether the suggestion strip is displayed or not, or whether
the hint is displayed or not, has nothing to do with this method
and should be handled elsewhere rather than here -- and as a
matter of fact, it is, which makes this useless.

Bug: 8636060
Change-Id: I6a54ee87e4e9f81bc33158acf4a264c3abd5829d
 2014-03-04 14:46:04 +09:00
Jean Chalard
c92dabb27e Merge "[IL112] Cleanup" 2014-03-04 05:45:15 +00:00
Jean Chalard
27c23c691c Merge "[IL111] Remove a member." 2014-03-04 05:36:00 +00:00
Jean Chalard
145e8568f4 [IL112] Cleanup 
Bug: 8636060
Change-Id: Ic7c2dec2521613d52707457463691bec383177ff
 2014-03-04 14:32:02 +09:00
Jean Chalard
32c6d4caea [IL111] Remove a member. 
...and improve encapsulation and readability.

Bug: 8636060
Change-Id: I36407630b307df0721ea7fdb7e7a22cdf2b018b3
 2014-03-04 14:31:47 +09:00
Tadashi G. Takaoka
ddc21f5bd1 Dismiss all key preview before showing more suggestions 
This CL also release key graphics and dismiss sliding key input
preview.

Bug: 13204690
Change-Id: Ie8eb7b7beca51689a907da9c0713b4d34d48dda1
 2014-03-04 14:26:00 +09:00
Ken Wakasa
61c726f591 Merge "Dismiss more keys keyboard before statring more suggestionsview to show" 2014-03-04 01:10:09 +00:00
Tadashi G. Takaoka
56e0373b5c Dismiss more keys keyboard before statring more suggestionsview to show 
Bug: 13204690
Change-Id: I9188edd0e99ca8acdcb0f0e045be7d267d56b12d
 2014-03-04 10:02:05 +09:00
Tadashi G. Takaoka
8df489444d Merge "Fix InputMethodInfo cache in RichInputMethodManager" 2014-03-03 15:16:55 +00:00
Tadashi G. Takaoka
ad5795a891 Fix InputMethodInfo cache in RichInputMethodManager 
Bug: 13271570
Change-Id: Ie06cd83baaaf674d8b34f0232c164c4541aceb43
 2014-03-03 23:36:35 +09:00
Tadashi G. Takaoka
3f91acdc96 Add additional subtypes test 
Change-Id: I2994fd72bc284c84757f5a2bfa8045aa574a8fbc
 2014-03-03 17:16:02 +09:00
Keisuke Kuroyanagi
e76c273502 Merge changes I20ce61c4,I2edab4e3 
* changes:
  Remove "Use only personalization dictionary".
  Remove redundant creation of dictionary facilitator.
 2014-03-03 04:00:24 +00:00
Keisuke Kuroyanagi
858045b41c Merge "Fix: wrong auto correction for whilelist and personalized words." 2014-02-28 12:26:03 +00:00
Keisuke Kuroyanagi
23ae574a11 Fix: wrong auto correction for whilelist and personalized words. 
This happens when there are tailing single quotes.

Bug: 13237314
Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14
 2014-02-28 21:24:26 +09:00
Keisuke Kuroyanagi
5128935ac4 Add header attributes for evaluation. 
Bug: 13197276
Change-Id: Ib5247da691ff24a73e13485288237ccc51bb54f0
 2014-02-28 21:06:03 +09:00
Keisuke Kuroyanagi
58a536e41a Merge "Use dynamic operations to construct all ver4 dicts." 2014-02-28 09:37:23 +00:00
Keisuke Kuroyanagi
684f5f18b1 Merge "Added a method and run GC for testing." 2014-02-28 09:33:51 +00:00
Keisuke Kuroyanagi
d302b98ce6 Added a method and run GC for testing. 
Bug: 13231889
Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
 2014-02-28 18:17:09 +09:00
Ken Wakasa
98534dc065 Add missing null checks for getOwnerInstance() 
It may just return null.

Change-Id: I778fb48262ef8af28a4af50b70bb94ace75a488c
 2014-02-28 16:13:51 +09:00
Keisuke Kuroyanagi
ea89cb40b7 Use dynamic operations to construct all ver4 dicts. 
Bug: 8187060
Bug: 13127350
Change-Id: I081ee904c41898128efa8ba7a1bf3fa0a46c6231
 2014-02-27 23:21:09 +09:00
Keisuke Kuroyanagi
1aac28a2b9 Remove "Use only personalization dictionary". 
Bug: 13216198
Change-Id: I20ce61c4a10c360e028bf6427f632cc5299763e4
 2014-02-27 22:32:00 +09:00
Keisuke Kuroyanagi
e9926b0d11 Remove redundant creation of dictionary facilitator. 
Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31
 2014-02-27 22:31:57 +09:00
Tadashi G. Takaoka
e989c6ea85 Merge "Remove wrong duplicated resource from Afrikaans layout" 2014-02-27 11:17:34 +00:00
Tadashi G. Takaoka
51cb8e6f4e Remove wrong duplicated resource from Afrikaans layout 
Bug: 6867914
Change-Id: Ibc329c8ea03abaa91ba27e7e62fb6d02cc67debe
 2014-02-27 19:01:49 +09:00
Jean Chalard
d1394b6986 Merge "Fix a bug with auto-caps entries from personalization" 2014-02-27 07:38:24 +00:00
Jean Chalard
71e3ecd0a2 Fix a bug with auto-caps entries from personalization 
Bug: 13215163
Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a
 2014-02-27 14:40:54 +09:00
Tadashi G. Takaoka
f8a45cfd2f Fix NPE in KeyDetector 
This is actually a follow up of I9290974821.

Bug: 13215075
Change-Id: Ib7eef55fd1cfbb05d06aeeb0726bc10c87b07d85
 2014-02-27 14:17:14 +09:00
Tadashi G. Takaoka
997ba1b41e Merge "Add keyboard layout set tests" 2014-02-27 03:08:42 +00:00
Keisuke Kuroyanagi
e1480a246d Merge "Set additional attributes in dictionary facilitator." 2014-02-26 10:37:46 +00:00
Keisuke Kuroyanagi
f8552f61a4 Set additional attributes in dictionary facilitator. 
Bug: 13197276
Change-Id: I206cf4e599ca9cdf40d669358a1067a2954d11e3
 2014-02-26 19:14:16 +09:00
Keisuke Kuroyanagi
e55d44c535 Merge "Add a method to create dict with additional attributes." 2014-02-26 10:07:53 +00:00
Keisuke Kuroyanagi
18f91cf617 Add a method to create dict with additional attributes. 
Bug: 13197276
Change-Id: I80311a51d9e98bfeb8c0dd9cd4adde93af366d54
 2014-02-26 19:03:27 +09:00
Keisuke Kuroyanagi
009bb5642b Merge "Use NOT_A_PROBABILITY for adding OOV words." 2014-02-26 09:48:57 +00:00
Jean Chalard
7e70e9dc49 Merge "[IL110] Remove an unused interface function" 2014-02-26 09:08:30 +00:00
Keisuke Kuroyanagi
2b27e06733 Merge "Read and write forgetting curve header attributes." 2014-02-26 09:06:56 +00:00
Keisuke Kuroyanagi
6112cc26a7 Read and write forgetting curve header attributes. 
Bug: 13197276
Change-Id: I6c38a127e1745903594b7bf0ec80ef179e794feb
 2014-02-26 18:04:12 +09:00
Keisuke Kuroyanagi
8559b403ed Use NOT_A_PROBABILITY for adding OOV words. 
Bug: 13197276
Change-Id: I23f453c2c1deea70eab552f8d433fe264adf68b3
 2014-02-26 17:50:44 +09:00
Jean Chalard
bd1caac16a [IL110] Remove an unused interface function 
...and make a method private.

Bug: 8636060
Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
 2014-02-26 17:46:20 +09:00
Tadashi G. Takaoka
dd01a0bb1d Add keyboard layout set tests 
This CL is a ground work to add keyboard layout labels and more keys
tests.

Bug: 13017434
Change-Id: Ief028e8ab563d79bc0b0f9c06f1fe1d645a6469d
 2014-02-26 16:10:52 +09:00
Jean Chalard
23e22613d7 Remove useless args and processing. 
Bug: 13062385
Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
 2014-02-26 11:40:43 +09:00
Jean Chalard
57c0c577af [QRP6] Fix: recorrection top candidate is displayed in bold 
Bug: 10385162
Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
 2014-02-25 19:48:09 +09:00
Jean Chalard
0c34ee20a8 [QRP5] Fix boldness for predictions, and small refactoring 
This is more correct. When predictions, the typed word should
always be null unless explicitly passed. The text color should be
that of a valid typed word only if it's actually the typed word.

Bug: 13170509
Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
 2014-02-25 19:44:57 +09:00
Jean Chalard
783f193239 [QRP4] Simplification & small correctness fix. 
This fixes the color of the predictions when running
on a theme that has different colors for typed and
suggested words (GB theme).
Also, this is easier to understand and to modify from
now on.

Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4
 2014-02-25 08:59:14 +00:00
Jean Chalard
a0984662a1 [QRP3] Refactoring 
Rename some variables for clarity and use constants
instead of immediates.

Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
 2014-02-25 17:05:47 +09:00
Jean Chalard
74224f2c5c [QRP2] Small refactor 
Bug: 13170509
Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
 2014-02-25 17:05:47 +09:00
Jean Chalard
ef3a45643e [QRP1] Fix a bug where the wrong value would get passed 
In the practice it works because this never tries to access
inside the suggestion strip, and the worst that can happen
is a wrong text color for a suggestion. But since the two
colors that would be swapped are the same, nobody ever
notices -- unless they are using the GingerBread theme.

Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
 2014-02-25 17:05:44 +09:00
Tadashi G. Takaoka
deb5cedf81 Add Key.getIconId for testability 
Bug: 13017434
Change-Id: I94ff45da3f58b74cc9dd4d38179670fbcf619d92
 2014-02-25 09:59:38 +09:00
Jean Chalard
6e224a236a Merge "Correctly read the header of APK-embedded dicts" 2014-02-24 13:57:46 +00:00
Jean Chalard
890b44e537 Correctly read the header of APK-embedded dicts 
Bug: 13164518
Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
 2014-02-24 22:54:01 +09:00
Jean Chalard
64ace089a8 Merge "Use an executor to serialize opening dictionaries." 2014-02-24 13:43:49 +00:00
Tadashi G. Takaoka
2c55706b0e Merge "Create a utils class for executors." 2014-02-24 13:33:44 +00:00
Jean Chalard
4de2fcdde3 Use an executor to serialize opening dictionaries. 
Bug: 13082957
Change-Id: I25570ab4da94337ed60330c0869fe47657096626
 2014-02-24 21:05:24 +09:00
Jean Chalard
b434acee34 Create a utils class for executors. 
Preliminary refactoring to fix
Bug: 13082957

Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
 2014-02-24 20:52:49 +09:00
Tadashi G. Takaoka
c40eb52e43 Merge "Remove hack from EmojiPalettesView.startEmojiPalettes" 2014-02-24 10:49:59 +00:00
Tadashi G. Takaoka
d227b00a72 Remove hack from EmojiPalettesView.startEmojiPalettes 
Bug: 12115967
Change-Id: I91c567a9577012ec28c08430c55e56e9c2e25b5f
 2014-02-24 19:45:50 +09:00
Jean Chalard
65bce4cabc Merge "Never pass negative values to setSelection." 2014-02-24 09:26:43 +00:00
Tadashi G. Takaoka
b08a9e021c Merge "Revert "Prepare for changing text color for functional keys"" 2014-02-24 08:54:55 +00:00
Tadashi G. Takaoka
da500b7ec3 Revert "Prepare for changing text color for functional keys" 
This reverts commit 194e004e81.
Bug: 10786040

Change-Id: I4c5287d46cabe287abce5cba77635cf26d2cd192
 2014-02-24 17:42:28 +09:00
Jean Chalard
f19745728e Never pass negative values to setSelection. 
Bug: 13136079
Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
 2014-02-24 16:52:55 +09:00
Keisuke Kuroyanagi
2b72aa07a9 Disconnect app data search client after fetching all data. 
Bug: 13138201
Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
 2014-02-24 14:47:54 +09:00
Jean Chalard
296adf5710 Merge "Change a heuristic and add a log." 2014-02-21 11:58:16 +00:00
Tadashi G. Takaoka
1269ae3144 Merge "Change make-keyboard-text -java option to point LatinIME/java directory" 2014-02-21 11:54:39 +00:00
Keisuke Kuroyanagi
bb6b978a19 Merge "Fix: file descriptor leaking." 2014-02-21 11:37:09 +00:00
Jean Chalard
bf075b21a1 Merge "Don't trim newer inputpointers with old data" 2014-02-21 11:19:04 +00:00
Tadashi G. Takaoka
5eb6ea9f27 Change make-keyboard-text -java option to point LatinIME/java directory 
Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
 2014-02-21 19:24:24 +09:00
Keisuke Kuroyanagi
ad508d029f Merge "Remove corrupted ver4 dictionaries." 2014-02-21 09:03:19 +00:00
Keisuke Kuroyanagi
d24a99cff6 Fix: file descriptor leaking. 
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.

Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
 2014-02-21 17:25:34 +09:00
Jean Chalard
2a5ec00301 Don't trim newer inputpointers with old data 
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.

Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
 2014-02-21 16:43:11 +09:00
Tadashi G. Takaoka
d73044a249 Add ImportantNoticeDialog 
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
 2014-02-21 16:36:15 +09:00
Keisuke Kuroyanagi
d934fb43ad Remove corrupted ver4 dictionaries. 
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
 2014-02-21 15:09:37 +09:00
Tadashi G. Takaoka
fe39d576dc Support versioned important notice 
This change must be checked in together with If38a754d00.

Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
 2014-02-21 09:54:08 +09:00
Jean Chalard
3b4c1d3056 Change a heuristic and add a log. 
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.

Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.

Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
 2014-02-20 23:49:20 +09:00
Jean Chalard
1b3a142cac Merge "Fix a bug where suggestions would not be updated." 2014-02-20 14:46:35 +00:00
Jean Chalard
6f50c95887 Fix a bug where suggestions would not be updated. 
Also fix a small cosmetic bug where the suggestion strip
would flash.

Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
 2014-02-20 23:32:04 +09:00
Jean Chalard
a118d19f6c Merge "Don't distrust the cursor pos so much as to bug on IPC delay" 2014-02-20 14:22:48 +00:00
Jean Chalard
3c84eb8822 Don't distrust the cursor pos so much as to bug on IPC delay 
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.

When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.

However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.

Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).

So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.

Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
 2014-02-20 23:13:14 +09:00
Keisuke Kuroyanagi
d36328cecf Add test only methods to test personalized dicts. 
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
 2014-02-20 22:20:43 +09:00
Keisuke Kuroyanagi
485c1ec685 Merge "Add final and volatile for members of InputLogic." 2014-02-20 10:12:45 +00:00
Keisuke Kuroyanagi
afdb6f011b Merge "Add user history dictionary decaying test." 2014-02-20 10:05:20 +00:00
Keisuke Kuroyanagi
b063377e77 Add final and volatile for members of InputLogic. 
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
 2014-02-20 18:55:19 +09:00
Keisuke Kuroyanagi
0bc66daae3 Add user history dictionary decaying test. 
Bug: 10667710

Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
 2014-02-20 18:36:46 +09:00
Keisuke Kuroyanagi
a514ea7e1b Merge "Check all enabled IME's subtypes to enable personalization." 2014-02-20 09:33:21 +00:00
Keisuke Kuroyanagi
d10e2d85af Merge "Throw IOException when dict header cannot be read." 2014-02-20 09:33:08 +00:00
Keisuke Kuroyanagi
afd9b62f00 Throw IOException when dict header cannot be read. 
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
 2014-02-20 18:11:17 +09:00
Jean Chalard
475f9f35b6 Merge "Comments improvements" 2014-02-20 08:22:39 +00:00
Tadashi G. Takaoka
1672ccbbb6 Change important notice version preference file 
This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.

Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
 2014-02-20 16:50:34 +09:00
Tadashi G. Takaoka
78db739cdb Fix build due to Ib4c472756f 
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
 2014-02-20 16:16:57 +09:00
Jean Chalard
ad2cf220a9 Merge "Remove a call to a deprecated method" 2014-02-20 06:40:46 +00:00
Tadashi G. Takaoka
251ed3b358 Merge "Revert "Turn off personalization default settings"" 2014-02-20 06:26:48 +00:00
Tadashi G. Takaoka
c2ba73ab41 Revert "Turn off personalization default settings" 
This reverts commit 0a4ac795d6.

Bug: 10587358
Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
 2014-02-20 06:06:29 +00:00
Keisuke Kuroyanagi
6b23749dec Check all enabled IME's subtypes to enable personalization. 
Bug: 13067743

Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
 2014-02-20 15:05:37 +09:00
Jean Chalard
c44b7312ad Remove a call to a deprecated method 
...that would cause a crash

Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
 2014-02-20 14:40:38 +09:00
Jean Chalard
be8ad77ebb Comments improvements 
Typo fixes and clarifications

Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
 2014-02-20 13:29:43 +09:00
Keisuke Kuroyanagi
34fb962513 Call PersonalizationDictionarySessionRegistrar.init(). 
Wrongly removed in I1f50cb137b6054dc9.

Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
 2014-02-19 23:27:14 +09:00
Keisuke Kuroyanagi
d102eb80da Remove personalization dicts for multilingual users. 
Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
 2014-02-19 21:00:27 +09:00
Tadashi G. Takaoka
920c40fe45 Use AlertDialog.setOnDismissListener 
AlertDialog.Builder.setOnDismissListener is supported from API 17.

Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
 2014-02-19 19:05:06 +09:00
Tadashi G. Takaoka
ed616083dd Merge "Turn personalization on when important notice dialog is displayed" 2014-02-19 09:46:15 +00:00
Tadashi G. Takaoka
6abc852255 Turn personalization on when important notice dialog is displayed 
This change must be checked in together with Ifde70b1d3b.

Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
 2014-02-19 18:36:32 +09:00
Tadashi G. Takaoka
3a7ed5fdfe Merge "Fix IllegalStateException raied by monkey" 2014-02-19 08:27:37 +00:00
Tadashi G. Takaoka
9fd7447d6c Fix IllegalStateException raied by monkey 
Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
 2014-02-19 16:40:52 +09:00
Keisuke Kuroyanagi
03105290d8 Merge "Throw exception when the header cannot be read." 2014-02-19 04:59:47 +00:00
Tadashi G. Takaoka
776bba098b Merge "Turn off personalization default settings" 2014-02-19 04:25:04 +00:00
Keisuke Kuroyanagi
97a40d030f Throw exception when the header cannot be read. 
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
 2014-02-19 12:35:58 +09:00
Keisuke Kuroyanagi
e49e007bb2 Fix: Use old suggest after reloading. 
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
 2014-02-19 12:34:09 +09:00
Tadashi G. Takaoka
0a4ac795d6 Turn off personalization default settings 
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.

Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
 2014-02-19 12:08:50 +09:00
Jean Chalard
80d413caff Merge "Straighten out database cursors behavior." 2014-02-18 11:09:38 +00:00
Jean Chalard
28e0b24965 Merge "Fix a bug where the cache would be out of sync" 2014-02-18 10:58:50 +00:00
Jean Chalard
b8ff8ca9d9 Straighten out database cursors behavior. 
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.

It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.

Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
 2014-02-18 19:58:23 +09:00
Jean Chalard
fe92c174ea Fix a bug where the cache would be out of sync 
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.

Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
 2014-02-18 19:55:54 +09:00
Jean Chalard
783dabb812 Merge "Cleanup." 2014-02-18 09:54:33 +00:00
Jean Chalard
63be066544 Cleanup. 
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.

Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
 2014-02-18 17:07:46 +09:00
Ken Wakasa
266c8c5b1d Merge "Some cosmetic fixes in LatinIME.java" 2014-02-18 06:08:34 +00:00
Ken Wakasa
12ff7da19d Some cosmetic fixes in LatinIME.java 
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
 2014-02-18 14:56:50 +09:00
Jean Chalard
9967f0a1d0 Avoid crashing when the Content URL is not found. 
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.

Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
 2014-02-18 14:27:58 +09:00
Ken Wakasa
0d32643e69 Merge "Cosmetic fixes" 2014-02-18 03:28:04 +00:00
Ken Wakasa
2312c1954f Cosmetic fixes 
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
 2014-02-18 12:17:24 +09:00
Tadashi G. Takaoka
cc05f468ca Merge "Refactor InputAttributes a bit" 2014-02-18 02:25:46 +00:00
Tadashi G. Takaoka
06fbfc4951 Refactor InputAttributes a bit 
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
 2014-02-18 11:11:36 +09:00
Tadashi G. Takaoka
affdd36423 Set neutral suggestions should be called after load settings 
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
 2014-02-18 11:04:00 +09:00
Tadashi G. Takaoka
f0f4e9fc16 Update important notice version even when user select Settings 
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
 2014-02-18 00:14:30 +09:00
Jean Chalard
782c9fee6b Merge "Don't resume suggestion on links." 2014-02-17 11:46:54 +00:00
Jean Chalard
7a7aeffcdc Don't resume suggestion on links. 
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
 2014-02-17 20:36:16 +09:00
Jean Chalard
d91cd9919e Merge "Catch exceptions we can't do anything about." 2014-02-17 11:33:39 +00:00
Tadashi G. Takaoka
5cd732f8c5 Stop overriding InputView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
 2014-02-17 19:51:47 +09:00
Jean Chalard
a149731a67 Catch exceptions we can't do anything about. 
This also abstracts away the "package deactivated" case for
simpler and safer code.

Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
 2014-02-17 18:49:31 +09:00
Tadashi G. Takaoka
891e4860f8 Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 2014-02-17 09:20:54 +00:00
Tadashi G. Takaoka
e32548f32d Stop overriding SuggestionStripView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
 2014-02-17 18:11:10 +09:00
Tadashi G. Takaoka
1751615f7d Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 2014-02-17 08:26:38 +00:00
Tadashi G. Takaoka
3dd6bdf931 Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 2014-02-17 08:25:57 +00:00
Tadashi G. Takaoka
800ab579a9 Remove unnecessary override of MainKeyboardView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
 2014-02-17 17:09:06 +09:00
Tadashi G. Takaoka
4c628b9d5b Merge "Don't show important notice on password field" 2014-02-17 08:04:11 +00:00
Tadashi G. Takaoka
20ddd4cff5 Add InputMethodSubtypeCompatUtils.isAsciiCapable() 
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
 2014-02-17 16:08:33 +09:00
Tadashi G. Takaoka
ce78a2d8ab Don't show important notice on password field 
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
 2014-02-17 15:38:43 +09:00
Tadashi G. Takaoka
4f4fb5ef34 Merge "Use the same label of switch-to-alphabet key on Emoji palette" 2014-02-17 06:13:39 +00:00
Tadashi G. Takaoka
4c680e7bcf Merge "Add go to "Settings" button to important notice dialog" 2014-02-17 06:13:26 +00:00
Tadashi G. Takaoka
28c02b400f Add go to "Settings" button to important notice dialog 
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.

This change must be checked in together with Id115d89ba9.

Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
 2014-02-17 14:57:04 +09:00
Tadashi G. Takaoka
fe39aec08a Use the same label of switch-to-alphabet key on Emoji palette 
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
 2014-02-17 14:54:39 +09:00
Tadashi G. Takaoka
c9072dc8da Remove key show up and dismiss animation 
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
 2014-02-17 12:10:09 +09:00
Keisuke Kuroyanagi
95d16561e0 Remove unused code. 
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
 2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi
0fc93fe445 Implement PatriciaTriePolicy::getNextWordAndNextToken(). 
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
 2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi
85fe06e759 Merge "Remove unused argument from readDictionaryBinary." 2014-02-14 10:37:56 +00:00
Keisuke Kuroyanagi
8e3a1d0f89 Remove unused argument from readDictionaryBinary. 
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
 2014-02-14 19:02:15 +09:00
Tadashi G. Takaoka
b136b7dd6f Merge "Add sanity check to KeybaordTextsTable for debugging" 2014-02-14 09:52:36 +00:00
Tadashi G. Takaoka
53a237323a Add sanity check to KeybaordTextsTable for debugging 
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
 2014-02-14 18:51:03 +09:00
Jean Chalard
fdc4173213 Merge "Fix a view-related crash" 2014-02-14 09:19:34 +00:00
Jean Chalard
a7e3e74ddd Fix a view-related crash 
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
 2014-02-14 18:03:34 +09:00
Tadashi G. Takaoka
3c4f05dd66 Remove unused label_tab_key 
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
 2014-02-14 17:40:53 +09:00
Tadashi G. Takaoka
17993ed4ef Merge "Fix null KeyDetector reference" 2014-02-14 07:17:33 +00:00
Tadashi G. Takaoka
a273319c59 Add PunctuationSuggestions class 
This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
 2014-02-14 14:13:39 +09:00
Jean Chalard
4197c6f3ab Merge "Show the suggestion strip for the important notice" 2014-02-14 04:07:46 +00:00
Tadashi G. Takaoka
ef8a03685f Fix null KeyDetector reference 
This change must be checked in together with I737c266c45.

Bug: 13011041
Change-Id: Ia3d25be6de47fa16ab7156a25641e53a23948ff4
 2014-02-14 11:42:09 +09:00
Yohei Yukawa
362ab36cf0 Fix a null object reference crash on Emoji Palette 
Do nothing if the current EmojiPageKeyboardView is null.

BUG: 13006906
Change-Id: I169b70122ec939075b5be033953b48762fd528fc
 2014-02-14 10:36:31 +09:00
Yohei Yukawa
5f9f4b929b Merge "Fix indent." 2014-02-14 01:26:48 +00:00
Jean Chalard
5e09958056 Merge "Backward compatibility hack : send delete when empty." 2014-02-13 10:09:41 +00:00
Jean Chalard
2c48846903 Backward compatibility hack : send delete when empty. 
Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.

This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.

Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
 2014-02-13 18:41:54 +09:00
Tadashi G. Takaoka
7ae6721ffa Remove RTL aware !code and add corresponding !text 
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
 2014-02-13 17:32:09 +09:00
Tadashi G. Takaoka
3cb77678f5 Fix Armenian switch to alphabet key text 
Bug: 7963631
Change-Id: If5768c761ec96d3404900b0c017abc2317cce8d4
 2014-02-13 17:26:16 +09:00
Tadashi G. Takaoka
0af6d988a7 Merge "Optimize KeyboardTextsTable" 2014-02-13 08:22:58 +00:00
Tadashi G. Takaoka
0fe4d00068 Optimize KeyboardTextsTable 
This change counts all occurrences of each string resource and sort
those in descending order of the occurrence.

Change-Id: I726402157feb0d436a54bd0a7252acd17fd711f9
 2014-02-13 17:11:00 +09:00
Tadashi G. Takaoka
36b8962a9a Merge "Fix UserHistoryDictionaryTests" 2014-02-13 07:49:51 +00:00
Tadashi G. Takaoka
32c8d58cef Merge "Fix showing all suggestions when the top suggestion is long" 2014-02-13 07:17:31 +00:00
Tadashi G. Takaoka
0cda0e8a9c Fix UserHistoryDictionaryTests 
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
 2014-02-13 16:16:44 +09:00
Tadashi G. Takaoka
4f8a8f125e Fix showing all suggestions when the top suggestion is long 
This change also fixes Bug#12982404; displays the suggestion word
using entire suggestions strip if there is only one suggestion.

Bug: 12564279
Bug: 12982404
Change-Id: I51806b90c3ee34a2072880245d4e33f7be273c8f
 2014-02-13 15:22:36 +09:00
Jean Chalard
e0a425681c Merge "Fix a test." 2014-02-13 05:20:58 +00:00
Jean Chalard
cf03ff02b1 Fix a test. 
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.

Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
 2014-02-13 14:01:37 +09:00
Tadashi G. Takaoka
8dd47029f1 Merge "Refactor dictionary constructor" 2014-02-13 04:55:16 +00:00
Jean Chalard
c3cfabd0eb Merge "Dump settings." 2014-02-13 04:26:52 +00:00
Tadashi G. Takaoka
870d89b1a8 Refactor dictionary constructor 
This change must be checked in together with I3923d5af2a.

Bug: 12994268
Change-Id: I19de6efbdfa3b6c6c69a20a836e53962fd5737de
 2014-02-13 13:23:55 +09:00
Yohei Yukawa
cfe26bbcde Fix indent. 
This is a follow up for the previous commit to fix indent.

BUG: 12964092
Change-Id: I0530b1c0dae26ac736ddcc6d426ec6ce57bce4d1
 2014-02-13 01:58:58 +09:00
Jean Chalard
367a35d377 Dump settings. 
Bug: 10315296
Change-Id: Ieb020a23886514b3ba97611d8a6001f32b322f63
 2014-02-12 22:53:15 +09:00
Yohei Yukawa
50fbe4cc09 Merge "Cancel keydown events immediately once the view starts scrolling" 2014-02-12 10:21:08 +00:00
Yohei Yukawa
4c259866c4 Cancel keydown events immediately once the view starts scrolling 
The motivation of this patch is to make sure a user never feel
haptic feedback when scrolling the Emoji palette. In order to
achieve it, EmojiPageKeyboardView#releaseCurrentKey() should
be called whenever (delayed) keydown events should be canceled.

This patch wires up ViewPager.OnPageChangeListener#onPageScrolled
with EmojiPageKeyboardView#releaseCurrentKey() so that delayed
keydown events will be canceled immediately once the ViewParger
starts scrolling.

BUG: 12964092
Change-Id: Iea8c3e090bb16a8622e6b4a850af2bf963aa77d0
 2014-02-12 18:56:08 +09:00
Tadashi G. Takaoka
5a885e85c2 Merge "Keep showing key preview even when keyboard has been changed" 2014-02-12 09:40:55 +00:00
Tadashi G. Takaoka
dd6ba4b184 Merge "Fix bug in KeyPreviewChoreographer.dismissKeyPreview" 2014-02-12 09:13:37 +00:00
Jean Chalard
8adedbf47c Show the suggestion strip for the important notice 
Bug: 10587358
Change-Id: Ia060a9ca9dfc2e7fe0750536a9fea3b9cc5900c4
 2014-02-12 17:30:04 +09:00
Tadashi G. Takaoka
075158ccd0 Keep showing key preview even when keyboard has been changed 
Bug: 12979147
Change-Id: I7e1f60686d6a8a0fca463174abb0a45f1f62ca43
 2014-02-12 15:09:03 +09:00
Tadashi G. Takaoka
7e9b0b42bf Fix bug in KeyPreviewChoreographer.dismissKeyPreview 
Bug: 12979147
Change-Id: Ibc60b4565badaebe760194f27984b02f9f966996
 2014-02-12 14:50:56 +09:00
Tadashi G. Takaoka
7ffac033ac Make importance notice dialog cancel able 
Bug: 10587358
Change-Id: I7415a6f33e6b5542718164fea1555095d23233e5
 2014-02-12 11:59:43 +09:00
Tadashi G. Takaoka
6e1710f0d4 Merge "Optimize text resources' ordering a bit" 2014-02-11 13:33:42 +00:00
Tadashi G. Takaoka
d495cc36b7 Merge "Get nicer output of make-keyboard-text" 2014-02-11 12:43:32 +00:00
Tadashi G. Takaoka
8bfd6100d9 Optimize text resources' ordering a bit 
Change-Id: I19382f1d9a4b6be173d1e9f62edd727ea987fa20
 2014-02-11 21:41:55 +09:00
Tadashi G. Takaoka
ed509695a4 Get nicer output of make-keyboard-text 
Change-Id: I6d30127aac2198d55b1335002f7a66b4aaebf82d
 2014-02-11 21:41:21 +09:00
Jean Chalard
3df8bcb7a9 Revert "Display predictions when the cursor is moved after a word." 
This change is lacking some comments and break some unit tests.
It needs more work.

This reverts commit 38d31a5e79.

Change-Id: I675854fd0729f2d01b7751e35c6d0117f4f88993
 2014-02-10 14:24:30 +00:00
Jean Chalard
38d31a5e79 Display predictions when the cursor is moved after a word. 
Bug: 12951777
Change-Id: I744b98df6679edd34ca3c1392e38597325935932
 2014-02-10 23:07:00 +09:00
Jean Chalard
f9e5b1ee4f Merge "Show important notice strip" 2014-02-10 12:18:10 +00:00
Tadashi G. Takaoka
8dda9e480b Show important notice strip 
Bug: 10587358
Change-Id: I1af3faa59afb2fc4cb90176acff1c2b0b1ba369c
 2014-02-10 21:15:35 +09:00
Keisuke Kuroyanagi
ea24abf878 Merge "Remove unused code." 2014-02-10 07:19:53 +00:00
Keisuke Kuroyanagi
2ef87aee3e Merge "Make PtNode have ProbabilityInfo instead of raw value." 2014-02-10 06:10:51 +00:00
Keisuke Kuroyanagi
69ccac6e51 Remove unused code. 
Bug: 12810574
Change-Id: If0ef02a984469a3b6e0c00b1c3c8d98d0d2b5466
 2014-02-10 15:05:11 +09:00
Keisuke Kuroyanagi
8ffc631826 Make PtNode have ProbabilityInfo instead of raw value. 
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
 2014-02-10 15:05:08 +09:00
Tadashi G. Takaoka
cbb0a6de3b Merge "Fix possible NPE while finding device override value from resource" 2014-02-10 05:51:44 +00:00
Tadashi G. Takaoka
bd9887a574 Fix possible NPE while finding device override value from resource 
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
 2014-02-10 14:38:53 +09:00
Tadashi G. Takaoka
f70bcf3d32 Refactor Key constructors 
This is a followup of I76432556ca.

Change-Id: Ie2c8f7c23352a33db28e89ee8e6ebaba9eb760a3
 2014-02-10 11:14:35 +09:00
Tadashi G. Takaoka
541a3d394c Remove unused import 
Change-Id: I3f934de281eefb387026585e678d783a95729720
 2014-02-10 10:22:29 +09:00
Tadashi G. Takaoka
45eb5d924d Allow an empty keySpec for Spacer 
Bug: 12933248
Change-Id: I76432556caf319ce23c1fb7fa3d6b94118e64cf8
 2014-02-09 23:45:23 +09:00
Tadashi G. Takaoka
e5320c1d1f Generate KeyboardTextsTable.java instead of KeyboardTextsSet.java 
Change-Id: Ic48b093dc64b514822cc9daa1ac3d79deb7af089
 2014-02-07 18:56:23 +09:00
Tadashi G. Takaoka
4f72923fa2 Merge "Rename Key.keyLabel attribute to KeySpec" 2014-02-07 09:53:43 +00:00
Tadashi G. Takaoka
4e85476740 Merge "Consolidate keyIcon and code with keyLabel attribute" 2014-02-07 09:53:35 +00:00
Tadashi G. Takaoka
9684b33b69 Rename Key.keyLabel attribute to KeySpec 
Change-Id: Ida48cd9bdbc01fefad651a005084262c0f46c41c
 2014-02-07 18:47:45 +09:00
Tadashi G. Takaoka
a83a1feb62 Consolidate keyIcon and code with keyLabel attribute 
Change-Id: I75fbd348fab5022606ca14552eb03b15af6684c8
 2014-02-07 18:47:22 +09:00
Tadashi G. Takaoka
a9e1db6636 Merge "Decimal number is treated as outputText" 2014-02-07 09:26:04 +00:00
Tadashi G. Takaoka
276b1a2ebc Add debug settings for keypress popup animations 
Bug: 12928125
Change-Id: I49faab754c7d1dcf4a791dfc535d3a78b62ce67a
 2014-02-07 18:09:41 +09:00
Keisuke Kuroyanagi
6422f77e94 Merge "Use native logic to read Ver4 dict." 2014-02-06 13:00:09 +00:00
Keisuke Kuroyanagi
ab6a93773b Use native logic to read Ver4 dict. 
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
 2014-02-06 21:55:37 +09:00
Keisuke Kuroyanagi
fc6d0f8738 Merge "Implement getHeaderInfoNative." 2014-02-06 11:26:49 +00:00
Keisuke Kuroyanagi
fc9ca59cc1 Implement getHeaderInfoNative. 
Bug: 11281877
Bug: 12810574
Change-Id: Ia3d85ae2cfdb486e74b8636a62431eae883c85da
 2014-02-06 18:19:42 +09:00
Tadashi G. Takaoka
3bbd50c36b Use SubtypeLocaleUtils.isRtlLanguage 
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
 2014-02-06 18:15:32 +09:00
Tadashi G. Takaoka
48ea52800a Merge "Consolidate keyOutputText with keyLabel attribute" 2014-02-06 09:14:09 +00:00
Tadashi G. Takaoka
d645db1e37 Merge "Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag" 2014-02-06 09:01:41 +00:00
Tadashi G. Takaoka
a9b67135bd Merge "Parse keyLabel for icon, code, and outputText as well" 2014-02-06 08:38:54 +00:00
Tadashi G. Takaoka
df75444239 Move INCLUDE_RAW_SUGGESTIONS flag to ProductionFlag 
This change must be checked in together with Iac93eb79fc.

Bug: 12913520
Bug: 12179576
Change-Id: Ic9a40fb0529202893be8ccb6f5abfbbe6d78508c
 2014-02-06 17:28:08 +09:00
Tadashi G. Takaoka
0df462730b Remove unused smiley key definitions 
Change-Id: Icbdfb360abab2964869898949774f47197f6d000
 2014-02-06 16:56:42 +09:00
Tadashi G. Takaoka
d6f147e142 Consolidate keyOutputText with keyLabel attribute 
Change-Id: I90ea2c9d5ce42fabc79599995a2fae1f5f652a6b
 2014-02-06 16:42:57 +09:00