nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
8261 commits 1 branch 0 tags 363 MiB
Commit graph

3736 commits

Author SHA1 Message Date
Ken Wakasa
bcec82de66 Clean up constructors 
And, use C++ style casts and use float math functions rather than double ones to save memory space.

Also, stop using FloatMath and NativeUtils as standard Math methods are faster now.
See http://code.google.com/p/android/issues/detail?id=36199 and https://android-review.googlesource.com/40700

multi-project commit with I4259fb5ab8a15ac5760a7f04fc8f4c860529f04a

Change-Id: I0b81cff8c91769f7559a59b9528c75a5aabb4211
 2012-08-13 10:48:37 +09:00
satok
847c8dfe17 Fix JNI 
Change-Id: If134baf52e78fbe18b78611a23870f5d10c80955
 2012-08-11 13:54:01 +09:00
alanv
5f312c9c15 Change accessibility event type for app-driven speech. 
Bug: 6614400
Change-Id: I0ef309b7f3f35bf37b4664ea599c9e6ffb1a4ab8
 2012-08-10 13:51:17 -07:00
Ken Wakasa
f3850e5543 Use JNI Region calls also in getSuggestions() 
Change-Id: I9cc0208397c202aeb6f7b5bb5ad59e00c5afbd80
 2012-08-10 21:09:23 +09:00
Satoshi Kataoka
f6c2200890 Workaround to stop init dict traverse session 
Change-Id: I3d46c54a96a9fc0359ef75b9d2f8590b44164a8b
 2012-08-10 21:07:53 +09:00
Jean Chalard
7b258e512d Accept whitelisted entries from any source. 
...not only the WhitelistDictionary.

Bug: 6906525
Change-Id: I7f181eb6936ec17bbccdc4e736fd09292af24e9c
 2012-08-10 19:02:19 +09:00
Jean Chalard
caed149b67 Optimization & Simplification 
It's useless to do the whitelist lookup twice. Also, putting
this test out of this method will allow whitelist entries to
come from other sources.

Bug: 6906525
Change-Id: I4afe678cae6556d16642d155ce770fbf4e61ad49
 2012-08-10 19:02:15 +09:00
Jean Chalard
dc2fb6bc6d Merge "Pass the type from native code all the way to Java." into jb-mr1-dev 2012-08-10 01:26:59 -07:00
Jean Chalard
926ef06a1e Pass the type from native code all the way to Java. 
Bug: 6906525
Change-Id: I057390d47a223450e22d8338509e22c28fc0d5f6
 2012-08-10 15:51:55 +09:00
Tadashi G. Takaoka
ce38c62aef Merge "Remove conservative MainKeyboardView.draw" into jb-mr1-dev 2012-08-09 23:31:53 -07:00
Satoshi Kataoka
e9f3e182e4 Add arguments for dic traverse session 
Change-Id: I8776ad528eeea9a5fc4dcf394ca13bb80c04fb6d
 2012-08-10 12:34:00 +09:00
Tadashi G. Takaoka
1b6829b0e0 Remove conservative MainKeyboardView.draw 
Change-Id: I52f58d1e013dfe1f1b0f8320cba903d3dbb4eabd
 2012-08-10 11:02:41 +09:00
Ken Wakasa
5bb4206275 Use more JNI Region calls 
Change-Id: I371db517ff4749c0b7e5bdb4362e6310c91a24dc
 2012-08-10 00:46:20 +09:00
Satoshi Kataoka
9d29871605 Add reset method for dic travserse session 
Change-Id: Ia3dd924f92549da2cf8302ef77c629902d4f275b
 2012-08-09 17:49:19 +09:00
Tadashi G. Takaoka
877157e1f5 Optimize keyboard drawing code a bit 
* Remove useless boolean flag.
 * Use invalidate(int,int,int,int).
 * Don't draw background when hardware acceleration is enabled.

Change-Id: Id560ac84f33b5151437a42a4ff22736284d71e2d
 2012-08-09 16:44:11 +09:00
Tadashi G. Takaoka
2be2d77664 Update dictionary availability at onStartInputView 
This is a follow up of I7901c0f9489b4deb79314c2c903b138611bfd78e

Change-Id: I38c22e886db247c402a964e3ddd10b09a461151c
 2012-08-09 16:09:54 +09:00
Tadashi G. Takaoka
9abea49dd4 Merge "Fix NPE and don't call UI API from non-UI thread" into jb-mr1-dev 2012-08-08 20:00:19 -07:00
Tadashi G. Takaoka
8335c59ea7 Fix NPE and don't call UI API from non-UI thread 
This change also reverts I29ec3e9f10484f30288fac76f0c45b3707bc2259

Bug: 6956969
Bug: 6891020
Bug: 6947253
Change-Id: I7901c0f9489b4deb79314c2c903b138611bfd78e
 2012-08-09 11:55:41 +09:00
Satoshi Kataoka
60d4961f34 Merge "Pass traverse session" into jb-mr1-dev 2012-08-08 07:50:44 -07:00
Satoshi Kataoka
9127811493 Pass traverse session 
Change-Id: I84bfaaa406e3f51421c08a7ee8f9576ebdba54d4
 2012-08-08 23:30:31 +09:00
Satoshi Kataoka
181567f9c7 Merge "Add traverse session" into jb-mr1-dev 2012-08-08 04:40:36 -07:00
Satoshi Kataoka
c4e4dfe17d Add traverse session 
Bug: 6942265

Change-Id: I384cf701f5ee44c4b1037e5b8ddfa3d570286f55
 2012-08-08 20:39:43 +09:00
Tadashi G. Takaoka
732f27984e Merge "Add toString() method to Keyboard" into jb-mr1-dev 2012-08-08 00:08:13 -07:00
Tadashi G. Takaoka
2bcd913e56 Merge "Add SuggestInitializationListener to BinaryDictionary.resetMainDict()" into jb-mr1-dev 2012-08-08 00:07:57 -07:00
Tadashi G. Takaoka
35336cf83a Add toString() method to Keyboard 
Change-Id: I74c8f006323ed78ec67414fd17849ab40966968e
 2012-08-08 15:59:56 +09:00
Tadashi G. Takaoka
79eefda0d3 Add SuggestInitializationListener to BinaryDictionary.resetMainDict() 
Change-Id: I4c01f172ddb2ca60fa6e604384610c90b76e5457
 2012-08-08 15:55:26 +09:00
Tadashi G. Takaoka
7ae1fd02d4 Use ArrayList to implement PointerTrackerQueue 
Change-Id: Ie386e6c7869df4df940e09fccffc5cd661134557
 2012-08-08 14:18:30 +09:00
Tadashi G. Takaoka
0cc425bd9c Add PointerTrackerQueue unit tests 
This is a groundwork to elminate LinkedList from PointerTrackerQueue.

Change-Id: Ib77780537ceb0b4273fb8e483977ab76124c5ce7
 2012-08-07 16:56:41 +09:00
Tadashi G. Takaoka
27e48447a4 Lingering gesture floating preview text a bit 
Bug: 6936095
Change-Id: I873343e9aa6afdf6bdb223795f03232509b012a7
 2012-08-07 13:54:42 +09:00
Tadashi G. Takaoka
7a13975700 Cleanup unused import and dead code 
Change-Id: Ife877620561d29a8f25602916420741186104617
 2012-08-06 17:28:33 +09:00
Tadashi G. Takaoka
dba77186f7 Fix duplicate getSuggestions() call for main dictionary 
Change-Id: I092480063452505cdf03dbd83b9c64e535822931
 2012-08-06 17:08:38 +09:00
Tadashi G. Takaoka
b27959741a Fix Utils.getStackTrace() 
Change-Id: Iaf160af32bb77b3ad5929cb5ee8eccd01165bdf6
 2012-08-06 16:50:43 +09:00
Tadashi G. Takaoka
0a524de3df Separate updateSuggestionStrip from commitTyped 
The commitTyped() called updateSuggestionStrip(), and that led to call
Suggest.getSuggestedWordsForTypingInput() even after a batch input was
started because WordComposer.commitWord() reset the batch input state.

Bug: 6932442
Change-Id: If645b1ef0343aa1e21ca71a9275b40c6c3be13df
 2012-08-06 14:31:01 +09:00
Tadashi G. Takaoka
4e9e6cd154 Fix IllegalStateException of KeyDetector 
A KeyDetector without Keyboard may exist in some rare cases. This
change eliminates throwing IllegalStateException and checks explicitly
against null.

Bug: 6891020
Change-Id: I29ec3e9f10484f30288fac76f0c45b3707bc2259
 2012-08-06 11:09:50 +09:00
Jean Chalard
15b28432ba Merge "Cleanup unused code" into jb-mr1-dev 2012-08-03 09:32:27 -07:00
Jean Chalard
8ee4b35c70 Cleanup unused code 
The Italian dictionary has been amended to contain words that
include apostrophes, and accordingly the apostrophe is now
excluded from word separators in Italian.
This code was only used for Italian, and in the general case
it does the wrong thing; it was only needed by limitations of
the old dictionary.

Bug: 6929108
Change-Id: I7ff4615e01899a1cebed2c4c51679cd0746740fe
 2012-08-04 01:15:04 +09:00
Jean Chalard
54e84a00fc Make a makedict command for dicttool (A3) 
This behaves exactly as the old makedict command. Further
changes will redirect the calls to makedict to this, so as
to consolidate similar code.

Groundwork for
Bug: 6429606

Change-Id: Ibeadbf48bec70f988a15ca36ebf5d1ce3b5b54ea
 2012-08-04 01:11:46 +09:00
Jean Chalard
3f80541844 Merge "Fix an OOB exception" into jb-mr1-dev 2012-08-03 07:17:37 -07:00
Jean Chalard
4c976aceee Fix an OOB exception 
Not sure exactly how this can happen, but at least this should
prevent us from crashing.

Bug: 6920884
Change-Id: I451864756b48c5cb5e98b06edee917d88766d77f
 2012-08-03 23:10:47 +09:00
Tadashi G. Takaoka
622d6a5b1b Using hardware accelerated drawing 
When Canvas has been hardware accelerated, don't use offscreen bitmap.

Bug: 6872994
Change-Id: I1121f76377991692bc29ebeedbfbfa1b2a12dbb7
 2012-08-03 20:46:10 +09:00
Tadashi G. Takaoka
ffe36cdc6d Merge "Small cleanup for keyboard drawing code" into jb-mr1-dev 2012-08-02 01:04:05 -07:00
Tadashi G. Takaoka
8344259fc9 Small cleanup for keyboard drawing code 
Change-Id: I8b562e03b30f82dddae311b49d316402e867cd31
 2012-08-02 16:50:31 +09:00
Tadashi G. Takaoka
76c242a1f6 Merge "Fix multi-touch input in auto-caps field" into jb-mr1-dev 2012-08-01 23:45:24 -07:00
Ken Wakasa
fb955693d4 Enable hardware accelerated drawing for SoftInputWindow of LatinIME 
Taking advantage of Ib6a8bda46223ce1153f32834daf02a820d16136e

bug: 6872994
Change-Id: I799b25b6509980dd9f039bead9bc926b42cbb040
 2012-08-02 15:11:31 +09:00
Tadashi G. Takaoka
44972bcdb6 Fix multi-touch input in auto-caps field 
Bug: 6905194
Change-Id: I7f9f61f36b7f3aa2b40c126a68232a947976aad2
 2012-08-01 18:56:11 +09:00
Tadashi G. Takaoka
d2173b5737 Cancel the while-typing timer when user hits the spacebar 
Bug: 6689079
Change-Id: I6b366acdcefb8b2c0d973a4f2a12329fc12eb5c5
 2012-07-31 19:39:52 +09:00
Tadashi G. Takaoka
b98b957424 Fix east slavic keyboard layouts 
This change affects Ukrainian, Belarusian, Kyrgyz, and Russian
keyboard. The followings are the layout changes for each language
respectively.

[Ukrainian]
 * Replace useless CYRILLIC LETTER E with CYRILLIC LETTER UKRAINIAN IE.
 * Replace useless CYRILLIC LETTER HARD SIGN with CYRILLIC LETTER YI
   on 10-inch tablet.
 * Add CYRILLIC LETTER GHE WITH UPTURN as more keys of CYRILLIC LETTER
   GHE.

[Belarusian]
 * Add CYRILLIC LETTER IO as more keys of CYRILLIC LETTER IE.
 * Replace useless CYRILLIC LETTER HARD SIGN with CYRILLIC LETTER IE
   on 10-inch tablet.

[Kyrgyz]
 * Add CYRILLIC LETTER IO as more keys of CYRILLIC LETTER IE.
 * Remove CYRILLIC LETTER HARD SIGN from more keys of CYRILLIC LETTER
   HA because CYRILLIC LETTER SOFT SIGN has it.

[Russian]
 * Remove CYRILLIC LETTER HARD SIGN from more keys of CYRILLIC LETTER
   HA because CYRILLIC LETTER SOFT SIGN has it.

This change also replace misspelled "more_keys_for_cyrillic_ye" text
name with "more_keys_for_cyrillic_ie".

Bug: 6881007
Change-Id: I9e88c4e27f66225e1676f2b286a7e55b9f2cbf5b
 2012-07-31 13:19:11 +09:00
Jean Chalard
f68fe7a9c9 Don't forward phantom space state on stripper input 
Bug: 6890540
Change-Id: I923b24e3bc17e7b923be4940ad739b58dca24a1f
 2012-07-31 01:48:10 +09:00
Tadashi G. Takaoka
ca57f5ba40 Move gesture preview parameters to KeyboardView attributes 
Change-Id: Iff9d6b485e202656fc869f3ff4d94575ad2c186f
 2012-07-30 20:10:48 +09:00
Tadashi G. Takaoka
6b9677d84b Merge "Small fix to KeyboardView" into jb-mr1-dev 2012-07-30 01:48:59 -07:00
Tadashi G. Takaoka
b9770cb7f7 Merge "Add device form factor to KeyboardId" into jb-mr1-dev 2012-07-30 00:50:25 -07:00
Tadashi G. Takaoka
edf7990e84 Small fix to KeyboardView 
Change-Id: Ifb7500ec2e55b50bb7951aa847fd4fbf49e32f4e
 2012-07-30 16:50:03 +09:00
Tadashi G. Takaoka
293f062c26 Merge "Add advanced options to turn on/off the gesture trail and text preview" into jb-mr1-dev 2012-07-30 00:22:41 -07:00
Tadashi G. Takaoka
47e2bf3298 Add advanced options to turn on/off the gesture trail and text preview 
Bug: 6883053
Change-Id: I601718afb37289108b45ef68626c7c315edca35d
 2012-07-30 15:54:27 +09:00
Tadashi G. Takaoka
75fb3ce1be More readable Key.toString() and MoreKeySpec.toString() 
Change-Id: Iee3c33dedd0c00ba259aa55e8b0c1c57b84eccdd
 2012-07-30 15:51:41 +09:00
Tadashi G. Takaoka
4731b67629 Add device form factor to KeyboardId 
This is a groundword for optimizing keyboard parsing.

Bug: 6860259
Change-Id: Ie65aa502b18c920e25cf2998b79120b3cc835952
 2012-07-30 15:33:17 +09:00
Tadashi G. Takaoka
efd8b838ee Add MoreKeySpec.toString() method for debugging 
Change-Id: Icf9c6e15521849ffc51911c1e256c9815c1960f4
 2012-07-30 15:06:26 +09:00
Jean Chalard
79d4c70b93 Merge "Don't auto-correct when there are digits." into jb-mr1-dev 2012-07-27 09:12:01 -07:00
Jean Chalard
e7c471a52f Don't auto-correct when there are digits. 
Bug: 6667462
Change-Id: I796655f57c71c9f50ae6e38dd08b71df3998dbcf
 2012-07-28 00:15:54 +09:00
Jean Chalard
78ee77ad08 Merge "Fix a bug with autocaps" into jb-mr1-dev 2012-07-27 05:19:48 -07:00
Jean Chalard
6fc72cae20 Fix a bug with autocaps 
Port of Iece016f4

Bug: 6886405
Change-Id: I148c296d8a3841c40b6748e73ed2b0fff473b627
 2012-07-27 21:09:25 +09:00
Tadashi G. Takaoka
1057670881 Make PreviewPlacerView final 
This is a groundwork for the bug.

Bug: 6883053
Change-Id: I51e9235d3bc7021790a88a44596c4314125a1ab3
 2012-07-27 19:40:39 +09:00
Tadashi G. Takaoka
99906b3fc2 Move SuddenJumpingTouchEventHandler to internal package 
Change-Id: Ifc9fb6322a2edbaac0b10e7134ee7e735f14937b
 2012-07-27 14:25:53 +09:00
Jean Chalard
7677a0ee7f Merge "Handle correctly the restarting argument" 2012-07-26 06:47:59 -07:00
Jean Chalard
aa906c36aa Handle correctly the restarting argument 
Bug: 6851364
Change-Id: Ie939a43b8527a76aec213b702d3d850717f22a81
 2012-07-26 21:57:15 +09:00
Tadashi G. Takaoka
97c8d288a8 Add Zulu keyboard 
Bug: 6867914
Change-Id: I13316ac2a554a8601f920e875d540e5375e12860
 2012-07-26 19:03:35 +09:00
Tadashi G. Takaoka
e863fb712f Merge "Fix gesture detection when sliding key input is disabled" 2012-07-26 02:13:20 -07:00
Tadashi G. Takaoka
c902dfeb8f Fix gesture detection when sliding key input is disabled 
Bug: 6867837
Change-Id: Icbfa69928c436343db545860a7d63171f52266b6
 2012-07-26 17:41:54 +09:00
Tadashi G. Takaoka
b90363e40c Fix Afrikaans more keys layout 
Bug: 6867914
Change-Id: I43178a729f4770743f9fea87bad539c54da045c5
 2012-07-26 16:31:06 +09:00
Tadashi G. Takaoka
55c01170c4 Add Afrikaans keyboard layout 
Bug: 6867914
Change-Id: Ice35b20a0a51dda21c8271256064523bb5844952
 2012-07-26 15:57:35 +09:00
Tadashi G. Takaoka
941f222c21 Merge "Remove unused setProximityCorrectionEnabled() methods" 2012-07-25 19:54:40 -07:00
Ken Wakasa
e55d78ab0c Stop swallowing an UnsatisfiedLinkError 
Change-Id: I37d61274e1527229befabae2c392fd78e279b807
 2012-07-26 09:15:39 +09:00
Charles Chen
e1643ed694 Merge "Add accessibility descriptions for additional non-character keys." 2012-07-25 11:29:56 -07:00
alanv
ba037c62ac Add accessibility descriptions for additional non-character keys. 
Bug: 6621009
Change-Id: I82fb2dc6af0fda795397e8be8c09a4f53b1656ab
 2012-07-25 11:03:41 -07:00
Shawn Pearce
0a370ac80f Merge "Add Swahili keyboard layout" 2012-07-25 10:58:44 -07:00
Tadashi G. Takaoka
c4376db0f0 Remove unused setProximityCorrectionEnabled() methods 
Change-Id: I03aa6608ee435b36377de41684162b303740f571
 2012-07-25 20:37:36 +09:00
Tom Ouyang
2f81757c3a Add dynamic floating preview for incremental gesture recognition. 
Change-Id: I7ba7ac24aa96a0ff19267997c5b58853079bc6dc
 2012-07-25 19:40:55 +09:00
Tadashi G. Takaoka
a28f6c9a18 Add Swahili keyboard layout 
Bug: 6867914
Change-Id: I2b9b0a06ff49a2afe16ec7a0ace0503d1658d413
 2012-07-25 17:48:37 +09:00
Tom Ouyang
e68385871a Fix gesture trail rendering on tablet. 
Bug: 6867837
Change-Id: I54dceee1c83679f78462104d6cee1f2300a0cfc2
 2012-07-25 16:12:37 +09:00
Tadashi G. Takaoka
0657b9698a Update gesture mode state when dictionary gets available 
Bug: 6860204
Change-Id: I840b7bf1983ab92fa4e0b180129176539e96409f
 2012-07-25 16:11:53 +09:00
Tadashi G. Takaoka
369e54cc33 Add Suggest initialization finish listener 
Bug: 6860204
Change-Id: I1e4c03c99415cd9bdea5a8556ff4093c33f0f508
 2012-07-25 09:55:22 +09:00
Tadashi G. Takaoka
9ecf634686 Add Seriban Latin keyboard layout as comments 
Bug: 6867914
Bug: 6867842
Change-Id: I3434434628e72fdb127d158de6c17fdfa77ee9c8
 2012-07-24 20:07:59 +09:00
Tadashi G. Takaoka
a01d9aea64 Add Tagalog keyboard layout 
Bug: 6867914
Change-Id: I78ca6216cc74f8d34291950c05c810c800a3ddba
 2012-07-24 18:54:43 +09:00
Tadashi G. Takaoka
506259396f Merge "Update gesture suggestions even when suggestions strip is off" 2012-07-23 03:45:21 -07:00
Tadashi G. Takaoka
7575ac7054 Update gesture suggestions even when suggestions strip is off 
Bug: 6852483
Change-Id: I873ae0f2e3bc863e989629f8bc0cc90ee33a4920
 2012-07-23 19:37:00 +09:00
Jean Chalard
c0f0ceeccf Merge "Fix a bug with the 'add to dict' hint popping up too much" 2012-07-23 03:20:01 -07:00
Jean Chalard
491d451e38 Fix a bug with the 'add to dict' hint popping up too much 
Not having a main dictionary is not sufficient reason to display
the hint. If the user already added the word to the dictionary then
we shouldn't be displaying it again, even if we don't have a main
dictionary for the current language.

Bug: 6829798
Change-Id: I6b081f51c82ef395fe2e394fd3167363e743ea6f
 2012-07-23 18:32:13 +09:00
Tadashi G. Takaoka
259905ba90 Rename suggestion strip related methods 
Change-Id: I942692bbc2e577482f353d875405c4658a1102fc
 2012-07-23 18:04:02 +09:00
Tadashi G. Takaoka
4702671ea4 Rename SuggestionsView to SuggestionStripView 2012-07-23 15:37:43 +09:00
Tadashi G. Takaoka
c8e45ddb03 Rename LatinKeyboardView to MainKeyboardView 
Change-Id: I8f3123b8d727c7beb72e226f80c17794f89c8b60
 2012-07-23 12:11:43 +09:00
Kurt Partridge
a4f762ff98 Merge "ResearchLogging indicator" 2012-07-22 19:31:40 -07:00
Kurt Partridge
4fa6e57260 ResearchLogging indicator 
- shows a indicator that logging is on.  two options are available: an obvious
red outline around the keyboard, and a subtle red dot in the lower right-hand
corner.  currently configured for the subtle red dot.

Bug: 6188932
Change-Id: I0fd1ac5a0f20329adc603aa65ab85f2d38b9fc43
 2012-07-22 19:04:34 -07:00
Kurt Partridge
74c95d6d18 Merge "ResearchLog splash screen" 2012-07-22 18:53:38 -07:00
Kurt Partridge
f0c6606807 Merge "ResearchLogger feedback form" 2012-07-22 18:53:30 -07:00
Kurt Partridge
4331012a9e ResearchLog splash screen 
Bug: 6188932
Change-Id: I1b247ecc26a2dd4f3f1c1b1cd3d928af717ebdd5
 2012-07-22 18:36:43 -07:00
Kurt Partridge
3c233bf1a5 ResearchLogger feedback form 
- also cleaned up RLog menu

multi-project commit with If0fd4fef89d390073e6939d5188ed5696866cb33

Bug: 6188932
Change-Id: I4f66f13bd366b4e8bde742ccd0704f812c6d33f9
 2012-07-22 18:36:24 -07:00
Tom Ouyang
ccaa799ee9 Update gesture bounding box handling. 
Change-Id: I085611ce6fd82608f284d74973e5bb14258cdc24
 2012-07-22 10:54:27 +09:00
Kurt Partridge
9c539d5a5c ResearchLog uploading 
- uploads files in the background to server

multi-project commit with Ie0d937773e04b2fbefc8d76c231aaa52ebc392c9

Bug: 6188932

Change-Id: I90bb0e237eeb567e4cbb51085f2229f17f1fe71c
 2012-07-20 15:24:48 -07:00
Kurt Partridge
6b966160ac ResearchLog refactor 
- new package: com.android.inputmethod.research

multi-project commit with Ic0a5744f3160d13218addd589890623c0d120ffc

Bug: 6188932

Change-Id: Icf8d4a40a5725401799be6e209a640d99a5f34c4
 2012-07-20 15:06:51 -07:00
Tadashi G. Takaoka
7519091f7c Use ResizableIntArray in GestureStroke 
Change-Id: I034e80df03c7c6c0895fdf2c03763627d410d425
 2012-07-20 19:32:28 +09:00
Tadashi G. Takaoka
2474b37abd Merge "Disable gesture input detection when more keys keyboard is showing" 2012-07-20 03:28:52 -07:00
Tadashi G. Takaoka
62b8dddb6d Add gesture input enable settings 
Bug: 6845325
Change-Id: I3165465b0b280e32a9288da16abb75baa67288dc
 2012-07-20 19:26:36 +09:00
Tadashi G. Takaoka
cc3500b0c8 Disable gesture input detection when more keys keyboard is showing 
Bug: 6852441
 2012-07-20 18:40:31 +09:00
Tom Ouyang
b8bd45a22a Merge "Fix bug where key previews do not show up." 2012-07-20 02:06:29 -07:00
Tom Ouyang
c022a9f8d4 Fix bug where key previews do not show up. 
Bug: 6852705

Change-Id: Ib90107a5dde774b4d6c1e570629ce7f7eaff44bc
 2012-07-20 18:02:12 +09:00
Ken Wakasa
afed0567e9 Performance improvements - Avoid using iterators 
Change-Id: Iab604aa1ef67acf5d54208a6bc44635632845ae0
 2012-07-20 17:51:52 +09:00
Tom Ouyang
528738341d Merge "Add gesture trail feedback." 2012-07-20 01:26:30 -07:00
Tom Ouyang
4daf32b6c0 Add gesture trail feedback. 
Change-Id: I32709fac0dec3165678a052aa286e2fb3d90721b
 2012-07-20 17:09:23 +09:00
Tadashi G. Takaoka
2f6a90ac31 Merge "Implement ResizableIntArray.fill" 2012-07-20 00:33:07 -07:00
Tadashi G. Takaoka
7abdcf1ed3 Implement ResizableIntArray.fill 
Change-Id: I570641bc2f32d016c247db6c065a138d8235ab8c
 2012-07-20 16:05:37 +09:00
Tadashi G. Takaoka
732edc1ff1 Merge "Fix NPE where the current subtype is null" 2012-07-19 22:57:39 -07:00
Tadashi G. Takaoka
d6a18cdedb Fix NPE where the current subtype is null 
Bug: 6847999
 2012-07-20 14:51:41 +09:00
Kurt Partridge
48ded4e3b1 Merge "ResearchLogger: make logging more reliable (esp on startup)" 2012-07-19 21:31:41 -07:00
Tadashi G. Takaoka
19ac19e5fd Merge "Implement ResizableIntArray.setLength and .get" 2012-07-19 20:44:54 -07:00
Ken Wakasa
2fc127698a Make ALPHA_OPAQUE public 
Change-Id: I904685be07e23292dd95296617a4b64c366f06f2
 2012-07-20 12:17:31 +09:00
Tadashi G. Takaoka
c49c85f835 Implement ResizableIntArray.setLength and .get 
This change revises ResizableIntArrayTests as well.
 2012-07-20 12:02:38 +09:00
Tom Ouyang
0c5f72e2bf Improve incremental gesture tracking. 
Eliminates need to recreate batch InputPointers on each gesture move event.
Fixes issue where batch points from previous tapping input get mixed into next gesture.

Change-Id: I9ecac66db88f5a87c6dde2138408906dd3d11139
 2012-07-20 10:44:37 +09:00
Kurt Partridge
0df487678e ResearchLogger: make logging more reliable (esp on startup) 
Bug: 6188932
Change-Id: I692e427ba2e6da7bb15f48208304c4a034392a22
 2012-07-19 09:00:21 -07:00
Tadashi G. Takaoka
9370ab9ada Make ScalableIntArray public as ResizableIntArray 
Change-Id: Ibbbc117214912ffa192c694bde5b7d55154f40c4
 2012-07-19 20:37:53 +09:00
Tadashi G. Takaoka
1e6f39a9f9 Tune the gesture detection logic a bit 
Change-Id: Ia8e8c15fdbbd49768d57cafd50325e7e45af6251
 2012-07-19 18:53:39 +09:00
Tadashi G. Takaoka
918e420d1b Gesture input should be turned off depending on the configuration 
The gesture input will be disabled when
 * It is AOSP build.
 * Accessibility mode is on.
 * The input field is password mode.

Bug: 6844755
Bug: 6844763
Bug: 6845011
Change-Id: I74972cc765d15c08059e0c9014f863ffb2a57c6c
 2012-07-19 16:33:09 +09:00
Tadashi G. Takaoka
57f7de0ba6 Add default capacity parameter to InputPointers' constructor 
Change-Id: I02f23096f0682d30effe4dfc1ca57881a1e4aedc
 2012-07-19 12:06:00 +09:00
Tadashi G. Takaoka
9580c467f9 Consolidate GestureTracker into PointerTracker 
Change-Id: Ib28fae10493a9142ba4dff6cf57f52c59766b209
 2012-07-18 20:11:06 +09:00
Tadashi G. Takaoka
10102f02af Change the batch input methods of KeyboardActionListener 
This change also removes the reference of SuggestedWords from
GestureTracker and KeyboardActionListener.

Change-Id: I25ef8756007986abf99a931afd665bbfe6fa387f
 2012-07-18 18:53:36 +09:00
Tadashi G. Takaoka
f39fccbd0f Make GestureStroke as top level class 
And make PointerTracker object has GestureStroke object.

Change-Id: Ibf5cfd593c4f13468368e01acb847589b0ab12e7
 2012-07-18 17:32:17 +09:00
Tadashi G. Takaoka
3ec31f4971 A gesture should not start from the delete key 
Change-Id: I5c8c7665454b7f10f944f307431dfffe20cf3134
 2012-07-18 14:38:51 +09:00
Tadashi G. Takaoka
af2c115253 Opening punctuations have a priority in Spanish keyboard 
Bug: 6737535
Change-Id: I87442eb978ac68be3d3df99eed8a92877a6f4ab0
 2012-07-17 16:14:36 +09:00
Kurt Partridge
5e53542489 Merge "delete old ResearchLog files" 2012-07-16 09:41:10 -07:00
Kurt Partridge
81dae8d015 delete old ResearchLog files 
cleans out the local directory of files that may have persisted
accidentally because of system crashes, etc.  default lifetime is
curently 1 day.

Bug: 6188932
Change-Id: I4b51169d6dd0eddb6bf8b661165f88e63782ce7d
 2012-07-13 20:25:38 -07:00
Kurt Partridge
73c5dbd9d2 researchLog records versionCode, versionName 
Bug: 6188932
Change-Id: I3d8502a5397035be5287ea720599e3fda4c669d6
 2012-07-13 20:21:18 -07:00
Tom Ouyang
eea34598bf Merging minimal gesture input 
Change-Id: Iee6ae48bb6309c2867b5d2e344fe7d86dfabd654
 2012-07-13 19:32:18 +09:00
Jean Chalard
e9808694fe Fix a bug where the word composer is not correctly reset 
...upon commit

Change-Id: I1fea87cb4c133a0884329eb9b61bf3053c36cd1b
 2012-07-13 13:31:27 +09:00
Tadashi G. Takaoka
7247bff6d6 Fix InputPointers.append 
Change-Id: I6995f9b2ed00b9f948e1299e576a5e24725d58f8
 2012-07-13 11:46:03 +09:00
Jean Chalard
c7387a4fd0 Add values for suggestion types (A120) 
Also, use it in getBigrams.

Change-Id: Ia0be9b57d1b7effcd8a936e01e957d1195b39c68
 2012-07-12 19:21:44 +09:00
Jean Chalard
6931df9c17 Pass an array to output suggestion types (A119a) 
This needs the matching A119b change to not break the build.
The array is passed, but not used yet.

Bug: 6166228
Change-Id: Ia91d658461d989ee8c94e9b31bb06f4a36f4c5b6
 2012-07-12 19:21:42 +09:00
Jean Chalard
2c5cf744e5 Increase encapsulation (A118) 
showSuggestions is only ever called by updateSuggestionsOrPredictions.
It only feels natural that, when called with a 0-sized or null
suggestion list, it clears the suggestions.

Change-Id: I5b52bc9151afca1bb6c6f0a7f81e3255add92177
 2012-07-12 15:58:16 +09:00
Jean Chalard
1343d27de3 Readability improvement (A117) 
Change-Id: I6f8bb05a23edb40a079da60b7136170ec9043282
 2012-07-12 15:58:16 +09:00
Jean Chalard
24a63b5537 Simplification (A116) 
Change-Id: I97cf92a7b0dabc251dd241b24978ea00d1e5f047
 2012-07-12 15:58:16 +09:00
Jean Chalard
f5b55cb70c Compute variables closer to where they are used (A115) 
This improves locality, it's better for readability/performance

Change-Id: Ibb1efaf86e362dd2c9398722d0da2144df96b333
 2012-07-12 15:58:09 +09:00
Jean Chalard
2549b4978e Cleanup (A114) 
Change-Id: I7e24e0aeae7c004cae310ae9f46cf90dac2d4d14
 2012-07-12 15:09:57 +09:00
Jean Chalard
02f1c1534c Cleanup (A113) 
If not composing a word, then consideredWord is always the empty
string.
Hence, it's never whitelisted, but it's also always "NotAWord",
so isWhitelistedOrNotAWord returns always true, so
allowsToBeAutoCorrected is always true. Which means that
isPrediction implies allowsToBeAutoCorrected == true.
Thus, !isPrediction && !allowsToBeAutoCorrected is strictly
equivalent to !allowsToBeAutocorrected.

Change-Id: I4ad7a7c3447851c539646d97cf55ff065e6ee115
 2012-07-12 15:09:48 +09:00
Jean Chalard
ae13061245 Simplification (A112) 
If we are not composing a word, that isFirstCharCapitalized
and isAllUpperCase are guaranteed to return false.

Change-Id: Ic4a0be9574acf4653c729a9594f963f5bcf0c757
 2012-07-12 14:30:33 +09:00
Jean Chalard
d8afa2fbe1 Remove the ultimate code duplication (A111) 
Change-Id: I7c76613df8f148feb02765f187db3ca6dc577977
 2012-07-12 14:30:33 +09:00
Jean Chalard
3b57631b60 Resolve a TODO: bury some implementation detail in native (A110) 
The fact that prediction does not accept a null argument is an
implementation detail, it should not be visible to Java code.

Change-Id: I3a156b323b6db9353de898d33f3f7c81751cecb1
 2012-07-12 14:30:30 +09:00
Jean Chalard
18d76afa91 Remove an unused method (A109) 
Change-Id: Ib785b7e8c554d030395e2c0ca92edb44eb2b245f
 2012-07-12 14:30:03 +09:00
Jean Chalard
251f302985 Stop using a redundant method (A108) 
Change-Id: Iffc0bae0a273419e7c50d69526c0c8e402c6461c
 2012-07-12 14:30:00 +09:00
Jean Chalard
6a5d17cd2f Remove a useless parameter (A106) 
Change-Id: Ic0ecea22212fd1a098a3a168da460374e446f4a3
 2012-07-12 11:28:16 +09:00
Jean Chalard
b7d7c5a369 Make a constant really constant (A104) 
Change-Id: Ied1f9f96a574b1e6a8ee0a71bfb1604d9c962e1c
 2012-07-12 11:16:30 +09:00
Jean Chalard
e4e7e5fc82 Cleanup (A103) 
Change-Id: Ib5ebddfdb87ef71a2f8d859fb45d3ac78040e97a
 2012-07-11 16:14:58 +09:00
Tadashi Takaoka
5e21ea1a35 Revert "Workaround to avoid a bug in the batch input bigram dictionary lookup" 
This reverts commit 1250cdeab2
 2012-07-11 00:07:08 -07:00
Tadashi G. Takaoka
1250cdeab2 Workaround to avoid a bug in the batch input bigram dictionary lookup 
Change-Id: I8a5641c88c45918d6bed81a0b03efdcff0b380c5
 2012-07-11 15:38:13 +09:00
Jean Chalard
9c09fd02eb Inline a method to be able to factorize code (A102) 
Change-Id: I121071f80c8af3c1053968dc76aaeca3352ca9a8
 2012-07-11 14:57:51 +09:00
Jean Chalard
d6c610400e Inline a wrapper method (A101) 
Change-Id: I6ce856ff49a8f8c696851b2487590704010fc758
 2012-07-11 14:57:51 +09:00
Tadashi G. Takaoka
eb1443883f Support batch input 
Change-Id: Ibe63212fe71cdebb5b897bc5018ae75b2a87555a
 2012-07-11 14:53:20 +09:00
Jean Chalard
21e5759e8e Merge "Small readability improvement (A100)" 2012-07-10 22:49:25 -07:00
Jean Chalard
27207eaa04 Merge "Pull up some common code again (A99)" 2012-07-10 22:49:06 -07:00
Jean Chalard
722b00275d Merge "Pull up some identical code (A98)" 2012-07-10 22:48:58 -07:00
Jean Chalard
8b166465b0 Merge "Inline a method to avoid confusion (A97)" 2012-07-10 22:48:52 -07:00
Jean Chalard
fd9b485111 Merge "Remove parameters for easier inlining (A96)" 2012-07-10 22:48:44 -07:00
Jean Chalard
0b329fd0d1 Merge "Pull up some more common code (A95)" 2012-07-10 22:48:38 -07:00
Jean Chalard
a5acd68caa Merge "Pull up common code in the caller (A94)" 2012-07-10 22:48:33 -07:00
Kurt Partridge
0d54692ce4 Merge "intentional logging" 2012-07-10 21:20:47 -07:00
Jean Chalard
82d5ed6fcd Small readability improvement (A100) 
Change-Id: I6340748654a95d203ed43ceb9a7e6468b5b8ab1c
 2012-07-11 11:19:50 +09:00
Jean Chalard
860a9f85ff Pull up some common code again (A99) 
Change-Id: I9e9f5664bb12bb25d74c8a076a6ee1024c708145
 2012-07-11 11:19:50 +09:00
Jean Chalard
8eaeb60e7f Pull up some identical code (A98) 
Change-Id: I6c265956394cf49e74b0256dfa5af06fe6b30467
 2012-07-11 11:19:33 +09:00
Jean Chalard
e77f2996ea Inline a method to avoid confusion (A97) 
Change-Id: I3c3ffcd3d40493f4bfa0f6596f923b3430e605aa
 2012-07-11 11:19:18 +09:00
Jean Chalard
cfae32c610 Remove parameters for easier inlining (A96) 
Change-Id: Ied2e291393609300173681e26e82b7dd36b41bd0
 2012-07-11 11:16:22 +09:00
Jean Chalard
ea98e026f1 Pull up some more common code (A95) 
Change-Id: I3ac7ee823471a6d1da8031e064bce38b0e5a8f5c
 2012-07-11 11:15:18 +09:00
Jean Chalard
b4b93dbf3e Pull up common code in the caller (A94) 
Change-Id: I84b97886280eca75d5f2b7546f20f8b1bced55bc
 2012-07-11 11:13:56 +09:00
Kurt Partridge
223d671ffc intentional logging 
- separate ResearchLog from ResearchLogger
- fix abort menu to explicitly indicate re-enabling of logging
- auto flush entries every 5s
- conform to new suggestedWords class

multi-project change with I9fe1f8fe59d5891daa4ca84af157f36fb1bb17dc

Bug: 6188932

Change-Id: I7e99390f934481c6ed9cea2b259944583edda5bb
 2012-07-10 18:44:18 -07:00
Jean Chalard
ff730dbd14 Merge "Remove useless member variables (A93)" 2012-07-10 04:33:32 -07:00
Tadashi G. Takaoka
20823b4623 Merge "Register the key when the finger slides off it in multitouch" 2012-07-10 04:19:40 -07:00
Jean Chalard
6f233f7ba1 Remove useless member variables (A93) 
Change-Id: Iff0a0e8835f4d630b51a15c0d91881437094e785
 2012-07-10 20:18:10 +09:00
Tadashi G. Takaoka
5e06b8534f Register the key when the finger slides off it in multitouch 
Moved from jb-dev branch (I807fd6f4).

Bug: 6722867
Change-Id: I9764ac72f726396caaac819675d440372c882981
 2012-07-10 20:14:29 +09:00
Jean Chalard
2ae75ed56b Start converging two identical methods (A92) 
Change-Id: I3c85a80610fde664a328f5606d0724f00d445ebe
 2012-07-10 20:13:54 +09:00
Tadashi G. Takaoka
d82dcdc924 Add batch input dictionary lookup 
Change-Id: I4da3c976838e8eb56c9ec80aafaaf54d759b7981
 2012-07-10 20:01:28 +09:00
Jean Chalard
5e573a1f0a Remove a useless parameter (A91A) 
Change-Id: I1d1758048649ef337875a5141d825569af7ad38c
 2012-07-10 19:31:36 +09:00
Jean Chalard
f5943153ad Cleanup old methods (A90) 
Change-Id: I5435cef8ac6be523934ffa394952cb120c8e89d6
 2012-07-10 19:30:46 +09:00
Jean Chalard
b30d2185f2 Implement the common Dictionary interface (A89) 
This will de-duplicate a lot of existing code.

Change-Id: Idaffb2fde23b9741f057bcb2ecb3dde9d12ea5c5
 2012-07-10 19:30:42 +09:00
Jean Chalard
a69f12a246 Reduce method visibility (A88) 
Change-Id: I29d6afbcba0998558c9b19287a460d9f0e410994
 2012-07-10 19:19:47 +09:00
Jean Chalard
0f57bdc0e5 Factorize code (A87) 
Why was this copy-pasted :(

Change-Id: I6a537c56425ad039d7301a5fe1e0485784f07914
 2012-07-10 19:19:43 +09:00
Jean Chalard
4e42e378fa Move stuff around for readability (A86) 
Change-Id: I5f4a18e43f3012acf96978d625325bf7c69c9c80
 2012-07-10 18:57:57 +09:00
Jean Chalard
82009901ea Add a consolidated method to the Dictionary interface (A85) 
Change-Id: I5d79021e69cc738e3013e31764ab0a59e15decdf
 2012-07-10 18:57:12 +09:00
Jean Chalard
2a37fb9d30 Refresh the cached single quotes count on commit 
Change-Id: I9df5cf95c14da2e11ac709ca5e32dc7db3b02c37
 2012-07-10 18:43:42 +09:00
Jean Chalard
a9632d8173 Merge "Enhance behavior consistency (A84)" 2012-07-10 02:31:40 -07:00
Jean Chalard
184c552917 Merge "Refactoring for whitelist (A83)" 2012-07-10 02:24:58 -07:00
Jean Chalard
b53e96813c Merge "Refactoring (A82)" 2012-07-10 02:24:47 -07:00
Jean Chalard
50d1b7902f Merge "Fix a bug with suggestion behavior (A81)" 2012-07-10 02:24:36 -07:00
Jean Chalard
a4d346c37a Merge "Cleanup visibility in LatinIME (A80)" 2012-07-10 02:21:46 -07:00
Jean Chalard
c677b0071d Enhance behavior consistency (A84) 
Use the word the same way for suggestion and prediction. It makes
little logical sense that the trailing single quotes be removed
for suggestion lookup but not for prediction lookup.

Change-Id: I0de4b5f7c5b4c1b4ba1817ff9653d7c03967146d
 2012-07-10 18:05:20 +09:00
Jean Chalard
1c6693a219 Refactoring for whitelist (A83) 
Avoid special casing the whitelist dictionary by having it implement
the interface it pretends it implements

Change-Id: I8b873cb0f3fe13cefd32c8cb756a25c8ae16a2b4
 2012-07-10 18:05:20 +09:00
Jean Chalard
fb6eeeb35a Refactoring (A82) 
The user history dictionary should be the one knowing it does not suggest words
beyond 2 characters, not Suggest.

Change-Id: Ie85ec6116eb495e0c7f51108e4620c5ae536f4bf
 2012-07-10 18:05:20 +09:00
Jean Chalard
966efe4889 Fix a bug with suggestion behavior (A81) 
Bug: 6788235
Change-Id: I5a4212872e0fd3f9e80168fd3abd5c2b3bc4110f
 2012-07-10 18:05:19 +09:00
Jean Chalard
a5bb353de9 Cleanup visibility in LatinIME (A80) 
Many methods were public but could have been private: change them
to private. Also, add a comment above public methods that don't
come from the IMF to make it clearer why they are necessary.

Change-Id: I574154b015d09c0f8542b81763f497691afdc3c1
 2012-07-10 18:05:15 +09:00
Satoshi Kataoka
7fcad7b9b6 Separate ICS-dependent code from the spell checker service 
Bug: 6789576
Change-Id: Ia768258f6fa121c7a7757093eb8a20e665580865
 2012-07-10 17:45:26 +09:00
Jean Chalard
b98414f8fd Merge "Remove useless code (A79)" 2012-07-10 00:47:56 -07:00
Jean Chalard
29540b25f0 Merge "Simplification (A78)" 2012-07-10 00:47:10 -07:00
Jean Chalard
728c0cb251 Remove useless code (A79) 
We postUpdateSuggestionStrip right away anyway - this only
makes the suggestion strip blink

Change-Id: I2ebd933e9a4c804ef1e8c62ccdaf4953a98a792e
 2012-07-10 16:41:49 +09:00
Jean Chalard
09fdd30e52 Simplification (A78) 
Change-Id: I622503af858ef419e94a17f182253cb03da00462
 2012-07-10 16:41:47 +09:00
Satoshi Kataoka
74620f449e Merge "Create AndroidSpellCheckerSessionFactory" 2012-07-10 00:26:00 -07:00
Satoshi Kataoka
37b19ffe6c Create AndroidSpellCheckerSessionFactory 
Bug: 6789576
Change-Id: I6de1e1aa64cf14f38ecb250579418bc518f0d838
 2012-07-10 16:16:53 +09:00
Satoshi Kataoka
759778a751 Merge "Separate SpellCheckerSession from SpellCheckerService" 2012-07-09 23:42:15 -07:00
Satoshi Kataoka
84ed096641 Separate SpellCheckerSession from SpellCheckerService 
Bug: 6789576
Change-Id: I7c55d36afad7ef6046353b3c9e849a54a6dc83ae
 2012-07-10 15:34:40 +09:00
Jean Chalard
fed702a0ad Merge "Move a test (A77)" 2012-07-09 23:01:33 -07:00
Jean Chalard
75e605f7ca Merge "Pull up common code in the consolidated method (A76)" 2012-07-09 22:41:33 -07:00
Jean Chalard
c466cd3f99 Move a test (A77) 
Change-Id: I417bd5f1318696aaa39fee18f3e750ea5c231f6b
 2012-07-10 14:24:33 +09:00
Jean Chalard
32f5384fc9 Pull up common code in the consolidated method (A76) 
Change-Id: I3ebecec37b49e139c243cf9da8bfe491e7ddada1
 2012-07-10 14:22:12 +09:00
Tadashi G. Takaoka
80973dc76f Merge "A little optimization of InputPointers.copy" 2012-07-09 21:09:13 -07:00
Tadashi G. Takaoka
2ad6d12a30 A little optimization of InputPointers.copy 
Change-Id: Id83b34e076ef91e06d7c1dd2b3ee7bb64d01b8cb
 2012-07-10 13:05:43 +09:00
Jean Chalard
24e8a06f98 am 949d2ae5: am 4bcf70c9: Fix a bad interaction with mmap 
* commit '949d2ae5788977c5e87e35e1bd1770f54ac88f5b':
  Fix a bad interaction with mmap
 2012-07-09 20:24:01 -07:00
Tadashi G. Takaoka
7389c601e3 Merge "Add InputPointers.append() method" 2012-07-09 01:39:38 -07:00
Tadashi G. Takaoka
1087c53f5a Add InputPointers.append() method 
Change-Id: Id2b0e242f7e9ce0ca888067857f8b64c02fde84e
 2012-07-09 17:33:10 +09:00
Jean Chalard
e4498929b0 Simple refactoring (A75) 
Change-Id: Id19efc5d279616da52667fa70326b86aba70d4a0
 2012-07-09 15:06:16 +09:00
Jean Chalard
d579f1aefc Consolidate methods that do the same thing (A74) 
Change-Id: I6e7c3aba2b40ecefa483c9680978bc806368e96e
 2012-07-09 15:06:16 +09:00
Jean Chalard
347a80f793 Tiny refactoring (A73) 
If !mWordComposer.isComposingWord(), then mWordComposer.getTypedWord()
will always return an empty string.

Change-Id: Ife66d0abc44c743cbc30d31724e833cda168fd5c
 2012-07-09 15:06:16 +09:00
Jean Chalard
7a422a0142 Cleanup again (A72) 
Change-Id: Id3765bf9826cc2c7ca70158cda53c75dc58f51c6
 2012-07-09 15:06:16 +09:00
Jean Chalard
37eaa24b5a Simplification (A71) 
Change-Id: I7a91d84291bea581ecc8ec5b29b9a87ccec76e7d
 2012-07-09 15:06:16 +09:00
Jean Chalard
dc1b84d96c Defer testing composition to a later time (A70) 
This is not exactly the same logically speaking, because it's
theoretically possible that the composing state changed in between
the message enqueueing and it's retrieval. However in the practice,
if the composing state changed the message *must* have been
cancelled and resent, else the behavior breaks. So this actually
is more robust, and removes some obscure requirements on the
calling code.

In the practice, it should also make the cancelUpdateSuggestionStrip
message useless, although this change does not yet remove it.

Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
 2012-07-09 15:06:16 +09:00
Jean Chalard
a6757f400a Code simplification (A69) 
Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
 2012-07-09 15:06:16 +09:00
Jean Chalard
8f9c9377fc Consolidate two methods (A68) 
Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
 2012-07-09 15:06:15 +09:00
Jean Chalard
146bd2e456 Pass the value we really want to pass to update functions (A67) 
Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
 2012-07-09 15:06:15 +09:00
Jean Chalard
60dbe0be43 Preparative change to pass a boolean with known value (A66) 
Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
 2012-07-09 15:06:15 +09:00
Jean Chalard
853f4221ab Merge "Remove useless processing (A65)" 2012-07-08 23:05:11 -07:00
Tadashi G. Takaoka
6b4ce58fc6 Remove unused WordComposer.init method 
Change-Id: I46c6a6e1c1536599cb909bf81297001b238f2ec8
 2012-07-06 20:12:14 +09:00
Tadashi G. Takaoka
36311cacd6 Merge "Extend onTextInput to be able to inject suggestions" 2012-07-06 03:40:03 -07:00
Tadashi G. Takaoka
4be03befe3 Extend onTextInput to be able to inject suggestions 
Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
 2012-07-06 19:36:11 +09:00
Jean Chalard
a3dee0d062 Merge "Fix a bug where spaces would be forgotten" 2012-07-06 02:09:28 -07:00
Jean Chalard
4fde56b818 Fix a bug where spaces would be forgotten 
Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
 2012-07-06 17:51:10 +09:00
Jean Chalard
8e36e5102e Remove useless processing (A65) 
We just resetted the composing state - updating suggestions
is sure to yield no results. We may as well not call
updateSuggestions at all.
We should however still cancel any lingering timer from a
previous input field, to avoid this useless processing.

Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
 2012-07-06 16:28:42 +09:00
Jean Chalard
449be371ae Refinement (A64) 
Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
 2012-07-06 16:28:42 +09:00
Jean Chalard
43193ad60f Remove useless code (A63) 
If the separator is not a space, then we will always call
setPunctuationSuggestions and reset the suggestion strip anyway.
If the separator is a space, then the cursor has a space on
the left, which means isCursorTouchingWord depends only on
whether it touches a word on the right. If we were displaying
the "add to dictionary hint", it means a suggestion was just
chosen, so it had to be displayed, and that requires a composing
word and no non-separator at the right of the cursor.

In the end, if we go through this postUpdateSuggestions call,
we are sure we will reset the suggestions later in this method,
either by calling postUpdateBigramPredictions, or
setPunctuationSuggestions.

Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
 2012-07-06 16:28:42 +09:00
Jean Chalard
8ba33c1a49 Simplification (A62) 
Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
 2012-07-06 16:27:55 +09:00
Jean Chalard
66a2e96fb4 Remove useless code (A61) 
Just after this, clear() will be called, removing the suggestion
strip from the screen. It will later be displayed again through
onStartInputView, which will update its content.

Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
 2012-07-06 13:07:48 +09:00
Jean Chalard
b1dc8ad5f2 Simplification (A60) 
Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
 2012-07-06 13:07:48 +09:00
Jean Chalard
663dbfd1cc Simplification & UI improvement (A59) 
The responsivity is better like this. This does not seem to
feel slow as the previous comment seemed to indicate.

Also remove a stale comment.

Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
 2012-07-06 13:07:48 +09:00
Jean Chalard
746e014eb5 Show predictions in the right cases (A58) 
After reverting an auto-correct we always have a separator after
the previously inserted word, and the cursor is never touching
a word. Showing predictions is the right thing to do, while
calling postUpdateSuggestions will invariably yield an invariably
blank suggestion strip, which is not very helpful.

Likewise, after we pick a suggestion, we should be showing the
predictions unless showing the addToDictionary hint. There was
a bug here in the corner case that the word would be a candidate
for user dictionary, but the user dictionary provider is not
available: in this case we should be showing predictions, but
we were showing an unhelpful empty suggestion bar.

Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
 2012-07-06 13:07:48 +09:00
Jean Chalard
0e9e7e337d Cleanup (A57) 
We stopped cancelling manual picks a few weeks ago. This code
is dead.

Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
 2012-07-06 13:07:30 +09:00
Jean Chalard
29eeef75ec Merge "Fix a bug where the caps mode would not be changed" 2012-07-05 19:11:28 -07:00
Jean Chalard
f254e3fec7 Fix a bug where the caps mode would not be changed 
Bug: 6766059
Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
 2012-07-06 11:08:20 +09:00
Jean Chalard
d81e7d24d3 Simplification (A56) 
If suggestion and prediction messages both happen to be in
the queue, the latest one will win (update the suggestion strip
later than the other, overwriting any previous suggestions).
So when we enqueue either one, it is always safe to cancel
all messages of both types.

Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
 2012-07-05 18:19:51 +09:00
Jean Chalard
414f14436e Remove an unused method (A55) 
Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
 2012-07-05 18:10:37 +09:00
Jean Chalard
c84f178cd9 Merge "Remove a useless method, rename another. (A54)" 2012-07-05 02:05:50 -07:00
Tadashi G. Takaoka
92d2f7e03b Merge "Initialize SubtypeLocale from Settings" 2012-07-05 02:04:35 -07:00
Jean Chalard
792e7ddc24 Merge "Remove a redundant test (A53)" 2012-07-05 01:57:04 -07:00
Jean Chalard
9636735c0a Merge "Small simplification (A52)" 2012-07-05 01:56:55 -07:00
Jean Chalard
21524c755c Merge "Put some more code in common (A51)" 2012-07-05 01:50:44 -07:00
Jean Chalard
71d7fc91b7 Merge "Pull up a common variable into the wrapping method (A50)" 2012-07-05 01:47:59 -07:00
Jean Chalard
ac3ad6ef9f Merge "Factorize some common code (A49)" 2012-07-05 01:45:08 -07:00
Tadashi G. Takaoka
d6ac0443f0 Initialize SubtypeLocale from Settings 
Bug: 6781106
Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
 2012-07-05 17:39:30 +09:00
Tadashi G. Takaoka
15d3532170 Merge "Fix tab key's navigation behavior" 2012-07-05 01:24:00 -07:00
Jean Chalard
3d8e7a62fc Remove a useless method, rename another. (A54) 
Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
 2012-07-05 17:22:15 +09:00
Jean Chalard
0783366036 Remove a redundant test (A53) 
Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
 2012-07-05 17:22:04 +09:00
Jean Chalard
4cba560dbb Small simplification (A52) 
Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
 2012-07-05 17:22:00 +09:00
Jean Chalard
ea80794dd4 Put some more code in common (A51) 
Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
 2012-07-05 17:21:55 +09:00
Jean Chalard
cbfd2e1fdb Pull up a common variable into the wrapping method (A50) 
Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
 2012-07-05 17:21:51 +09:00
Jean Chalard
7ed22f1f72 Factorize some common code (A49) 
Also add some comment to clarify what's happening inside those
methods

Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
 2012-07-05 17:21:44 +09:00
Tadashi G. Takaoka
b28934adac Fix tab key's navigation behavior 
Bug: 6435484
Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
 2012-07-05 16:57:14 +09:00
Tadashi G. Takaoka
133bb8544a Merge "Fix upper case Eszett more key" 2012-07-05 00:52:08 -07:00
Tadashi G. Takaoka
5946838b8e Fix upper case Eszett more key 
Bug: 6773873
Change-Id: I1a533c729c312a53663fb142cb6fcb4915b53206
 2012-07-05 16:13:52 +09:00
Jean Chalard
0726f466f7 Merge "Add a wrapper to updateSuggestions / Predictions (A48)" 2012-07-04 21:08:21 -07:00
Tadashi G. Takaoka
7aeb7ef1ab Merge "Fix Keyboard.getKey as thread safe" 2012-07-04 19:58:17 -07:00
Tadashi G. Takaoka
8f6c603b3b Fix Keyboard.getKey as thread safe 
This is a follow up of Id962e670.

Change-Id: I9e8542bff9e8faf57f934051fe612463c99ad61f
 2012-07-05 11:43:43 +09:00
Jean Chalard
e47c728dd5 Add a wrapper to updateSuggestions / Predictions (A48) 
The goal is to have those converge, as they contain almost 100%
duplicated code.

Change-Id: I6921791d47efce9fb396efd9626839d706664a91
 2012-07-05 11:10:04 +09:00
Jean Chalard
7b40c68277 Refactoring which will help with future changes (A47) 
Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
 2012-07-05 11:10:02 +09:00
Jean Chalard
e9a86e2cdb Search bigrams for the lower case version of the word (A46) 
...if there aren't any for the exact case version.

Bug: 6752830
Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
 2012-07-04 20:12:58 +09:00
Jean Chalard
4bcf70c931 Fix a bad interaction with mmap 
Bug: 6761221
Change-Id: I7e6d98dc9d7cb34a6163c3957e401ff97abb975c
 2012-07-04 17:57:06 +09:00
Tadashi G. Takaoka
ac3bd96192 Merge "Remove WordComposer.add(int, int, int, KeyDetector) method" 2012-07-04 01:48:42 -07:00
Tadashi G. Takaoka
5c641a9f59 Remove WordComposer.add(int, int, int, KeyDetector) method 
Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
 2012-07-04 17:29:47 +09:00
Tadashi G. Takaoka
5c98206dc5 Merge "Use Keyboard.getKey" 2012-07-04 01:12:02 -07:00
Tadashi G. Takaoka
adc80eef15 Use Keyboard.getKey 
Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
 2012-07-04 16:31:57 +09:00
Tadashi G. Takaoka
040aa28ed4 Merge "Get rid of redundant CharSequence member from SuggestedWordInfo" 2012-07-04 00:27:07 -07:00
Tadashi G. Takaoka
f3897fb54e Get rid of redundant CharSequence member from SuggestedWordInfo 
Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
 2012-07-04 16:04:59 +09:00
Jean Chalard
c5e911c06b Consolidate a method inside another (A45) 
It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.

This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.

Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
 2012-07-04 11:51:51 +09:00
Jean Chalard
f72b8f5662 Move the safety net function to AutoCorrection (A44) 
Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
 2012-07-04 11:51:46 +09:00
Jean Chalard
accd63f35f Merge "Refactoring (A43)" 2012-07-03 19:40:19 -07:00
Jean Chalard
b87b23eb75 Merge "Remove useless code (A42)" 2012-07-02 18:56:41 -07:00
Jean Chalard
6547f43666 Merge "Clarify some code and fix a bug (A41)" 2012-07-02 18:52:56 -07:00
Jean Chalard
d6496c0913 Merge "Fix a bug with the user dictionary locale." 2012-07-02 02:57:50 -07:00
Jean Chalard
d113fd0be4 Fix a bug with the user dictionary locale. 
We internally use the string "zz" to mean no locale, but
the user dictionary service does not understand that and
words added with this locale pitifully end being added to
a "zz" user dictionary, which makes no sense to the user.
This change fixes things so that words added when the
keyboard is in a "no locale" layout, the words are added
to the global, all-locales user dictionary.

Bug: 6645306
Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
 2012-07-02 17:14:47 +09:00
Jean Chalard
4ca05e2474 Refactoring (A43) 
Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
 2012-07-02 15:46:11 +09:00
Jean Chalard
7ad088a4cf Remove useless code (A42) 
If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !

Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>

Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
 2012-07-02 15:46:08 +09:00
Jean Chalard
90d300c770 Clarify some code and fix a bug (A41) 
The test against hasMainDictionary is a test to know if we should
auto-correct or not. Its result should be recorded in
hasAutoCorrection, not in allowsToBeAutoCorrected.

Actually, this value being inserted in allowsToBeAutoCorrected was
causing a bug that nobody noticed: when typing in a language with
no dictionary, the word in the middle of the suggestion strip would
always be bold, as if it was going to auto-correct to itself !
This change fixes this bug.

Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
 2012-07-02 15:46:03 +09:00
Jean Chalard
2631e3b195 Small refactoring (A39) 
Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea
 2012-07-02 15:45:58 +09:00
Jean Chalard
79f5317848 Match calls for future consolidation (A38) 
Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9
 2012-07-02 15:45:54 +09:00
Jean Chalard
cd288620ea Make the autocorrection scheme more straightforward (A37) 
Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd
 2012-07-02 15:45:34 +09:00
Jean Chalard
aba432bf8d Remove a duplicate method (A36) 
Bug: 6705473
Change-Id: Ib6260034b09739b60071e90a018b2dc6be3815d7
 2012-07-02 12:12:16 +09:00
Jean Chalard
84074cf503 Update log and make a variable private (A35). 
Change-Id: Ib4a8f41dc5941bce46402e1a41a6c21dccb0601f
 2012-07-02 12:11:27 +09:00
Jean Chalard
1842fbba93 Remove old debug code that has been long broken (A34) 
Change-Id: I9b5a0e34529724984aad1e2bf99b3e00f8ed0dd7
 2012-06-29 19:47:00 +09:00
Satoshi Kataoka
105069a15f Merge "Add input pointers" 2012-06-29 03:03:01 -07:00
Satoshi Kataoka
71538b08e4 Add input pointers 
Change-Id: I95300bf0a847fb86d026e846ff4ad723bb45284f
 2012-06-29 18:58:51 +09:00
Jean Chalard
f2af726f79 Merge "Add a more synthetic variable (A33)" 2012-06-29 02:22:05 -07:00
Jean Chalard
aa246f23ce Merge "Remove cruft (A32)" 2012-06-29 02:12:47 -07:00
Jean Chalard
defc2e2efa Merge "Simplification (A31)" 2012-06-29 02:09:16 -07:00
Jean Chalard
7a6ac44f5f Merge "Small refactoring (A30)" 2012-06-29 02:09:06 -07:00
Tadashi G. Takaoka
e0b7359126 Merge "Use SparseArray<E> instead of HashMap<Integer,E>" 2012-06-29 02:05:39 -07:00
Tadashi G. Takaoka
56853c1e48 Use SparseArray<E> instead of HashMap<Integer,E> 
Change-Id: Id962e670ee1a5164e6c69deb84625139bf5e7974
 2012-06-29 17:56:31 +09:00
Jean Chalard
1b2e2d893d Add a more synthetic variable (A33) 
The goal here is to disambiguate TypedWordValid and
HasAutoCorrectionCandidate. Ultimately, HasAutoCorrectionCandidate
will disappear.

Bug: 6705473
Change-Id: I1acbd0a5efc7f4bf7b0bdb12839fe3d84e9d1dda
 2012-06-29 17:00:57 +09:00
Jean Chalard
9011b89f4e Remove cruft (A32) 
Change-Id: I35c2ba4caf6be4ba0449e11c0597ae8e468c0e6e
 2012-06-29 17:00:57 +09:00
Jean Chalard
2cda148fd5 Simplification (A31) 
Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
 2012-06-29 17:00:57 +09:00
Jean Chalard
deb2d88245 Small refactoring (A30) 
Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
 2012-06-29 17:00:57 +09:00