Commit Graph

9699 Commits (6ab076e24424f75b8ee61492b774b04ef6e978fa)

Author SHA1 Message Date
Jean Chalard 90916143b6 [IL95] Inline a method that's always called in sequence
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
2014-01-28 15:47:01 +09:00
Tadashi G. Takaoka 61ba174e16 am 02b08709: Merge "Fix test fails caused by I8bede13c87"
* commit '02b087090e9a4fe1a388bd18939711f988931744':
  Fix test fails caused by I8bede13c87
2014-01-27 21:22:47 -08:00
Tadashi G. Takaoka 02b087090e Merge "Fix test fails caused by I8bede13c87" 2014-01-28 05:19:53 +00:00
Yohei Yukawa a04ead80d7 am 02725535: Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete."
* commit '02725535784e03c3d6789251569204d2e397000f':
  Fix inconsistent behavior with the spacebar on the Emoji pallete.
2014-01-27 21:08:47 -08:00
Yohei Yukawa 0272553578 Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete." 2014-01-28 05:06:07 +00:00
Yohei Yukawa 0e04c24a05 Fix inconsistent behavior with the spacebar on the Emoji pallete.
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.

With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.

Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
2014-01-28 13:44:31 +09:00
Jean Chalard 4b5e56d648 am ca1c1ddd: Merge "[IL94] Remove a function and some reordering"
* commit 'ca1c1ddd4ecdca1a863dbf8274dca2fc3e91a8ac':
  [IL94] Remove a function and some reordering
2014-01-27 19:48:05 -08:00
Jean Chalard ca1c1ddd4e Merge "[IL94] Remove a function and some reordering" 2014-01-28 03:46:28 +00:00
Jean Chalard 43502ea3ba am 9909d6aa: Merge "[IL93] Refactor a method inside another"
* commit '9909d6aa49ea17b6dd391a48e2ad29be11006249':
  [IL93] Refactor a method inside another
2014-01-27 19:34:07 -08:00
Jean Chalard d5259d578b am cbf54dea: Merge "[IL92] Straighten out showSuggestionStripWithTypedWord"
* commit 'cbf54dea49151e3d8a8dff5074d289ce38dd0698':
  [IL92] Straighten out showSuggestionStripWithTypedWord
2014-01-27 19:34:05 -08:00
Jean Chalard 9909d6aa49 Merge "[IL93] Refactor a method inside another" 2014-01-28 03:32:52 +00:00
Jean Chalard cbf54dea49 Merge "[IL92] Straighten out showSuggestionStripWithTypedWord" 2014-01-28 03:32:17 +00:00
Jean Chalard ba122b291b am 5a1f8373: Merge "[IL91] Call reorder"
* commit '5a1f837356673f04fd68dea8f0b084dc9de7db33':
  [IL91] Call reorder
2014-01-27 19:28:41 -08:00
Jean Chalard 5a1f837356 Merge "[IL91] Call reorder" 2014-01-28 03:26:23 +00:00
Tadashi G. Takaoka 9ac6c9064d Fix test fails caused by I8bede13c87
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
2014-01-28 11:17:47 +09:00
Tadashi G. Takaoka a4d04eb863 am c2e2b394: Merge "Add SubtypeLocaleUtils.isRtlLanguage method"
* commit 'c2e2b3949b159d6412e0e5815c1503d94b2b5ce7':
  Add SubtypeLocaleUtils.isRtlLanguage method
2014-01-27 17:30:14 -08:00
Tadashi G. Takaoka c2e2b3949b Merge "Add SubtypeLocaleUtils.isRtlLanguage method" 2014-01-28 01:28:47 +00:00
Baligh Uddin 16a9bb3da8 Import translations. DO NOT MERGE
Change-Id: I9632cf713ad9e1bba1df5819c4038739229f7ec2
Auto-generated-cl: translation import
2014-01-27 14:42:02 -08:00
Baligh Uddin 92b67fc32b Import translations. DO NOT MERGE
Change-Id: I4aa5b70b2bb231583501347c69dba7172aa975cb
Auto-generated-cl: translation import
2014-01-27 14:40:58 -08:00
Jean Chalard 5b5e877efe [IL94] Remove a function and some reordering
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
2014-01-27 20:38:45 +09:00
Jean Chalard 37e1cc931f [IL93] Refactor a method inside another
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.

Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
2014-01-27 20:38:45 +09:00
Jean Chalard 4c6029e530 [IL92] Straighten out showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
2014-01-27 20:38:45 +09:00
Jean Chalard c6367ee64d [IL91] Call reorder
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
2014-01-27 20:38:43 +09:00
Jean Chalard b3b2676c4a am 01893b25: Merge "[IL90] Small refactoring"
* commit '01893b25dd25266d14c38d892176fbda052e1812':
  [IL90] Small refactoring
2014-01-27 03:22:08 -08:00
Jean Chalard efef6d87e9 am 3f226af4: Merge "[IL89] Inline a function"
* commit '3f226af439700e9e01eabf7280a5c366e10a3d74':
  [IL89] Inline a function
2014-01-27 03:22:06 -08:00
Jean Chalard 2a36d9bf3b am 5b9e54c1: Merge "[IL88] Simple refactoring"
* commit '5b9e54c135cb1fa2ca1a5b5967a7934b789a8ed4':
  [IL88] Simple refactoring
2014-01-27 03:22:03 -08:00
Jean Chalard 925f8fcf88 am 8f3e37a6: Merge "[IL87] Remove a call to clearSuggestionStrip"
* commit '8f3e37a63187f4fb2731f629472037a373796097':
  [IL87] Remove a call to clearSuggestionStrip
2014-01-27 03:22:01 -08:00
Jean Chalard 01893b25dd Merge "[IL90] Small refactoring" 2014-01-27 11:18:52 +00:00
Jean Chalard 38f4272ade am 521a83a3: Merge "[IL86] Simplification and correctness fix."
* commit '521a83a3f122d02d24317540fd7bafb1918acb08':
  [IL86] Simplification and correctness fix.
2014-01-27 03:18:40 -08:00
Jean Chalard ddfce8b7c4 am 7aa7e366: Merge "[IL85] Maybe show punctuations when app completions are null"
* commit '7aa7e3661117ab60d85b4d4ce83167073c370bec':
  [IL85] Maybe show punctuations when app completions are null
2014-01-27 03:18:37 -08:00
Jean Chalard 9cc7238f71 am 264f4e38: Merge "[IL84] Remove a useless call and rename a method"
* commit '264f4e380dd496b156914a47089bd26b9eba1cb6':
  [IL84] Remove a useless call and rename a method
2014-01-27 03:18:34 -08:00
Jean Chalard 1ced9e6ddc am 7ac542d4: Merge "[IL83] Inline a call"
* commit '7ac542d490b4761837733d1732a8e6ca8c097739':
  [IL83] Inline a call
2014-01-27 03:18:32 -08:00
Jean Chalard 3f226af439 Merge "[IL89] Inline a function" 2014-01-27 11:18:19 +00:00
Jean Chalard 5b9e54c135 Merge "[IL88] Simple refactoring" 2014-01-27 11:17:54 +00:00
Jean Chalard 8f3e37a631 Merge "[IL87] Remove a call to clearSuggestionStrip" 2014-01-27 11:17:45 +00:00
Jean Chalard 521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard 7aa7e36611 Merge "[IL85] Maybe show punctuations when app completions are null" 2014-01-27 11:17:18 +00:00
Jean Chalard 264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard 7ac542d490 Merge "[IL83] Inline a call" 2014-01-27 11:16:30 +00:00
Jean Chalard 2e7f0680ad am 47ff4231: Merge "[IL82] Fix a wrong comment"
* commit '47ff423121ce9d584cb4c71295ff42b275552214':
  [IL82] Fix a wrong comment
2014-01-27 02:13:37 -08:00
Jean Chalard 0256b15d3a am 75ec579e: Merge "[IL81] Remove a useless test."
* commit '75ec579e07ccb598970bc800db2d9f2dac11ec7a':
  [IL81] Remove a useless test.
2014-01-27 02:13:35 -08:00
Jean Chalard 47ff423121 Merge "[IL82] Fix a wrong comment" 2014-01-27 10:11:42 +00:00
Jean Chalard 75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
Jean Chalard 7f1a5c4d9b am 6d1c8b2c: Merge "Try to figure out whether d.quotes open or close."
* commit '6d1c8b2c3f78969866db7f718e7e8d2be240f674':
  Try to figure out whether d.quotes open or close.
2014-01-27 02:02:44 -08:00
Jean Chalard a8b37414f8 am b084da2a: Merge changes I5092942a,I931c553f
* commit 'b084da2ae6622488779ddb3a66081610bfe96a66':
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
2014-01-27 02:02:42 -08:00
Jean Chalard 6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard b084da2ae6 Merge changes I5092942a,I931c553f
* changes:
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
2014-01-27 10:00:37 +00:00
Jean Chalard f58a96c977 am a3a85e8c: Merge "[IL78] Move most of onUpdateSelection to InputLogic."
* commit 'a3a85e8c2bcab6ff9b00fda52e3ba0c666055951':
  [IL78] Move most of onUpdateSelection to InputLogic.
2014-01-27 01:57:15 -08:00
Jean Chalard a3a85e8c2b Merge "[IL78] Move most of onUpdateSelection to InputLogic." 2014-01-27 09:55:08 +00:00
Jean Chalard d38b0468b0 [IL90] Small refactoring
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
Jean Chalard 33ff321d6c [IL89] Inline a function
We will then refactor the contents of showSuggestionStripWithTypedWord

Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
Jean Chalard ca819178a1 [IL88] Simple refactoring
With this, the value passed to suggestedWords is never null.

Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
Jean Chalard d90bdd2187 [IL87] Remove a call to clearSuggestionStrip
The goal is to remove the function completely.

Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
Jean Chalard 3b939ed77f [IL86] Simplification and correctness fix.
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
Jean Chalard 07eddf3c43 [IL85] Maybe show punctuations when app completions are null
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.

Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
Jean Chalard b2c0388a69 [IL84] Remove a useless call and rename a method
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
Jean Chalard eb190ab32f [IL83] Inline a call
The coming string of changes is very complicated, so
I'm going to do things really slowly.

Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
Jean Chalard 17f1528f9e [IL82] Fix a wrong comment
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
Jean Chalard abbd755689 [IL81] Remove a useless test.
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
Jean Chalard f1e5b9b4d1 [IL80] Reverse a test for clarity.
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
Jean Chalard f59487379e [IL79] Some refactoring
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
Jean Chalard 10460441db [IL78] Move most of onUpdateSelection to InputLogic.
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka c8bddebf1a am 1e4b1300: Merge "Refactor SuggestionsStripLayoutHelper class"
* commit '1e4b1300e65095ca4b064afb5590d4bc02ff7725':
  Refactor SuggestionsStripLayoutHelper class
2014-01-27 01:39:02 -08:00
Tadashi G. Takaoka 1e4b1300e6 Merge "Refactor SuggestionsStripLayoutHelper class" 2014-01-27 09:36:52 +00:00
Jean Chalard d7c3ceac59 am 68d7291a: Merge "[IL77] Remove refs to Settings from InputLogic"
* commit '68d7291a6bdc1d5633d744759a5c76599499d9e9':
  [IL77] Remove refs to Settings from InputLogic
2014-01-27 01:35:46 -08:00
Jean Chalard 37985b2540 am 7bee8409: Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
* commit '7bee84095e24a9e21e8a2146f7bb9d1ad2cd89ba':
  [IL75] Move the SubtypeSwitcher out of InputLogic.
2014-01-27 01:35:41 -08:00
Tadashi G. Takaoka c6473b5964 am 829ad708: Merge "Revert "Use ViewCompat support library""
* commit '829ad708db7bc3c9a0eabad8d3e410da400f36e6':
  Revert "Use ViewCompat support library"
2014-01-27 01:35:39 -08:00
Jean Chalard 68d7291a6b Merge "[IL77] Remove refs to Settings from InputLogic" 2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka 148dedbc5d Refactor SuggestionsStripLayoutHelper class
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
2014-01-27 18:25:25 +09:00
Jean Chalard 7bee84095e Merge "[IL75] Move the SubtypeSwitcher out of InputLogic." 2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka 829ad708db Merge "Revert "Use ViewCompat support library"" 2014-01-27 09:20:19 +00:00
Jean Chalard 48df380f78 [IL77] Remove refs to Settings from InputLogic
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
Jean Chalard 969c06072d [IL75] Move the SubtypeSwitcher out of InputLogic.
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
Jean Chalard c7ef305bbc Try to figure out whether d.quotes open or close.
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka e4692c0050 Revert "Use ViewCompat support library"
This reverts commit e7ee4fa862.

Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
2014-01-27 18:14:40 +09:00
Jean Chalard 5be5fd13e0 am 5cf70a1d: Merge "[IL74] Remove unused/unwanted arguments to a method."
* commit '5cf70a1d44395a4a857eeb33504f8458fbba2464':
  [IL74] Remove unused/unwanted arguments to a method.
2014-01-27 00:58:49 -08:00
Jean Chalard 5cf70a1d44 Merge "[IL74] Remove unused/unwanted arguments to a method." 2014-01-27 08:57:12 +00:00
Yohei Yukawa c93a0e71fe am 0b586179: Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
* commit '0b5861795158e4a9f1c8b8c9025ab3f4e49adebc':
  Fix inconsistent behavior with backspace in the Emoji pallete.
2014-01-27 00:14:23 -08:00
Yohei Yukawa 0b58617951 Merge "Fix inconsistent behavior with backspace in the Emoji pallete." 2014-01-27 08:11:51 +00:00
Jean Chalard 0fd556ceca [IL74] Remove unused/unwanted arguments to a method.
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
Yohei Yukawa ea8c1c811c Fix inconsistent behavior with backspace in the Emoji pallete.
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
  the key.

This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
  different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
  key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
  subsequent delete key events when the finger is moved away
  from the key area.

Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka 4bc31d5111 am f3ca92dd: Merge "Use ViewCompat support library"
* commit 'f3ca92dd33254e0c7cc87e9ffac0cfc41c4ea3f5':
  Use ViewCompat support library
2014-01-26 23:23:12 -08:00
Tadashi G. Takaoka f3ca92dd33 Merge "Use ViewCompat support library" 2014-01-27 07:21:41 +00:00
Ken Wakasa 3873ee735d am 03283b63: Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
* commit '03283b636c0c35bfd4ff8fe6b30db27fad5cf824':
  Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-26 23:19:57 -08:00
Tadashi G. Takaoka e7ee4fa862 Use ViewCompat support library
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
Ken Wakasa 03283b636c Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
some cleanups as well

Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi c9243ca1f7 am 95043145: Merge "Check length of words for personalization dict."
* commit '95043145df6d943849f871a80802fc40c5c8ff5b':
  Check length of words for personalization dict.
2014-01-24 16:47:53 -08:00
Keisuke Kuroyanagi 95043145df Merge "Check length of words for personalization dict." 2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi b7197b705b Check length of words for personalization dict.
Bug: 12602903

Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
Ken Wakasa 86795823f7 am 0acd1210: Fix wrong indents.
* commit '0acd121083baf137dc81cd2c5ce4214a9848a82d':
  Fix wrong indents.
2014-01-24 06:59:07 -08:00
Ken Wakasa 0acd121083 Fix wrong indents.
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
Jean Chalard 341044034c am b6e128cc: Merge "[IL69.1] Move a static method to a utility class."
* commit 'b6e128cc05fa0b4b1f79b6c7eb4d67f44833c7f4':
  [IL69.1] Move a static method to a utility class.
2014-01-23 19:07:26 -08:00
Jean Chalard b6e128cc05 Merge "[IL69.1] Move a static method to a utility class." 2014-01-24 03:04:12 +00:00
Jean Chalard 1d6e647ac3 [IL69.1] Move a static method to a utility class.
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
Jean Chalard 9bbb214edd am 0c725290: Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer"
* commit '0c72529088e02d7dbe496397fbb64089b8acd594':
  [IL73] Remove all refs to Key and Keyboard in WordComposer
2014-01-23 17:58:29 -08:00
Jean Chalard 0c72529088 Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer" 2014-01-24 01:55:57 +00:00
Baligh Uddin 6a39811d90 Merge "Import translations. DO NOT MERGE" 2014-01-23 21:02:33 +00:00
Baligh Uddin 5047b4aa84 Import translations. DO NOT MERGE
Change-Id: Ib5a8be5d9ac508d57648e4e8811805eea4355fc3
Auto-generated-cl: translation import
2014-01-23 12:25:35 -08:00
Baligh Uddin 9d7c6aafde Import translations. DO NOT MERGE
Change-Id: I4ddadf6504a80fc0955c03496eeefc6c665d0965
Auto-generated-cl: translation import
2014-01-23 12:24:12 -08:00