Commit graph

12426 commits

Author SHA1 Message Date
Ken Wakasa
e3aa7f10d0 Adjust CHAR_LIMITs
bug: 8589156
bug: 8588538
bug: 8588746

Change-Id: I14050dc3542946c1bae2e1dc8b63b99758d5f9aa
2013-04-15 22:47:08 +09:00
Jean Chalard
8e643e32e6 am b76ce125: Merge "Remove a useless function"
* commit 'b76ce1251ee78067ebdc349ea94ea145d87488c4':
  Remove a useless function
2013-04-15 06:09:18 -07:00
Jean Chalard
b76ce1251e Merge "Remove a useless function" 2013-04-15 13:06:33 +00:00
Jean Chalard
647f629a5a am a5a2f3e3: Remove gesture suggestions with an INT_MIN score
* commit 'a5a2f3e3c77ebf2e1bb74b08c8587c15b9711ac8':
  Remove gesture suggestions with an INT_MIN score
2013-04-15 06:04:00 -07:00
Jean Chalard
bc501647fd Remove a useless function
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
2013-04-15 22:01:37 +09:00
Jean Chalard
1e5bbe4ce8 Small performance improvement / minor bugfix
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.

Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
2013-04-15 21:18:50 +09:00
Jean Chalard
a5a2f3e3c7 Remove gesture suggestions with an INT_MIN score
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
2013-04-15 20:55:49 +09:00
Jean Chalard
dea5e6a301 am 03395833: Merge "Have Latin IME re-capitalize a selected string"
* commit '033958330dbfed19ea15379ff5d9a0a52aa375ff':
  Have Latin IME re-capitalize a selected string
2013-04-15 04:31:29 -07:00
Jean Chalard
12bf5a0546 am e99daea0: Update dictionaries
* commit 'e99daea0835d170f40fe79c8b9848732c4e56a34':
  Update dictionaries
2013-04-15 04:31:28 -07:00
Jean Chalard
033958330d Merge "Have Latin IME re-capitalize a selected string" 2013-04-15 11:29:28 +00:00
Jean Chalard
e99daea083 Update dictionaries
>>> dictionaries/en_GB_wordlist.combined.gz
Header :
  date : 1366003032 <=> 1366021966
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Added: www 72

>>> dictionaries/en_US_wordlist.combined.gz
Header :
  date : 1366003070 <=> 1366021978
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Added: http 95
Added: www 71

>>> dictionaries/en_wordlist.combined.gz
Header :
  date : 1366003861 <=> 1366021987
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Freq changed: http 120 -> 95
Added: www 71

>>> java/res/raw/main_en.dict
Header :
  date : 1366003861 <=> 1366021987
Body :
Deleted: FTP 88
Deleted: HTTPS 66
Freq changed: http 120 -> 95
Added: www 71

Bug: 8233807
Change-Id: Id55f6e0dcc9ddff26902c0857edcbb9b10d42328
2013-04-15 20:25:48 +09:00
Jean Chalard
34676d92cc am a022c538: Merge "If there are no suggestion span, recompute suggestions."
* commit 'a022c53882642d1669e229f4f1b8d649c09447f7':
  If there are no suggestion span, recompute suggestions.
2013-04-15 04:24:01 -07:00
Jean Chalard
2995abe7aa Have Latin IME re-capitalize a selected string
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.

Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
2013-04-15 20:23:01 +09:00
Jean Chalard
a022c53882 Merge "If there are no suggestion span, recompute suggestions." 2013-04-15 11:18:27 +00:00
Jean Chalard
0e9ee4d3bf If there are no suggestion span, recompute suggestions.
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
2013-04-15 19:33:23 +09:00
Satoshi Kataoka
d55ccbf7f9 am 837f46dc: Enable touch coordinate correction for new algorithm
* commit '837f46dcb35a8f42a6bd5bc5fc6395d7386acb81':
  Enable touch coordinate correction for new algorithm
2013-04-15 03:24:16 -07:00
Satoshi Kataoka
837f46dcb3 Enable touch coordinate correction for new algorithm
Bug: 8505668

Change-Id: I07eb785c74c446777524104a3d2b61f0f591a498
2013-04-15 19:10:27 +09:00
Jean Chalard
be0e013be8 am 059e084e: Merge "Reject a previously user-refused suggestion."
* commit '059e084e983ce4a1440dc065f5167d278d8939e7':
  Reject a previously user-refused suggestion.
2013-04-15 00:47:58 -07:00
Jean Chalard
059e084e98 Merge "Reject a previously user-refused suggestion." 2013-04-15 07:45:34 +00:00
Jean Chalard
d40f3f6bc1 Reject a previously user-refused suggestion.
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.

Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
2013-04-15 16:36:44 +09:00
Tadashi G. Takaoka
1a42236a8b am 4b6756db: Merge "Remove unnecessary harmful finish() from SettingsActivity"
* commit '4b6756db3c3ab982daaf378bc9677c8a1e26ece0':
  Remove unnecessary harmful finish() from SettingsActivity
2013-04-15 00:35:26 -07:00
Tadashi G. Takaoka
4b6756db3c Merge "Remove unnecessary harmful finish() from SettingsActivity" 2013-04-15 07:32:05 +00:00
Tadashi G. Takaoka
216fb6a042 Remove unnecessary harmful finish() from SettingsActivity
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
2013-04-15 16:26:40 +09:00
Jean Chalard
5f6492c584 am 673ebb4e: Merge "Update dictionaries"
* commit '673ebb4ede351b43b03c5fe249e152feab954f32':
  Update dictionaries
2013-04-15 00:26:02 -07:00
Jean Chalard
673ebb4ede Merge "Update dictionaries" 2013-04-15 07:23:00 +00:00
Tadashi G. Takaoka
2fd4a00bea am 1ec4c07a: Merge "Ignore modifier key while sliding key input"
* commit '1ec4c07a13447a98deca1fc9e79f5d507030695d':
  Ignore modifier key while sliding key input
2013-04-14 23:20:53 -07:00
Tadashi G. Takaoka
eabb710b60 am f224941c: Merge "Suppress calling onPressKey and onReleaseKey while detecting gesture"
* commit 'f224941c37a04d3c290ef2db5003a5af2a701fce':
  Suppress calling onPressKey and onReleaseKey while detecting gesture
2013-04-14 23:20:52 -07:00
Tadashi G. Takaoka
1ec4c07a13 Merge "Ignore modifier key while sliding key input" 2013-04-15 06:19:10 +00:00
Tadashi G. Takaoka
f224941c37 Merge "Suppress calling onPressKey and onReleaseKey while detecting gesture" 2013-04-15 06:18:48 +00:00
Tadashi G. Takaoka
089f1ce954 am bfb07ed7: Merge "Add preference dependency to gesture input related options"
* commit 'bfb07ed7d66c014ea35c3ac9f339b526e7d64815':
  Add preference dependency to gesture input related options
2013-04-14 23:17:36 -07:00
Tadashi G. Takaoka
bfb07ed7d6 Merge "Add preference dependency to gesture input related options" 2013-04-15 06:15:36 +00:00
Tadashi G. Takaoka
29105a725d Add preference dependency to gesture input related options
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
2013-04-15 15:07:49 +09:00
Jean Chalard
da175bdcb1 Update dictionaries
>>> dictionaries/en_GB_wordlist.combined.gz
Header :
  date : 1355802832 <=> 1366003032
  version : 29 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 72
Added: mm 135

>>> dictionaries/en_US_wordlist.combined.gz
Header :
  date : 1355112451 <=> 1366003070
  version : 28 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 71
Added: mm 135

>>> dictionaries/en_wordlist.combined.gz
Header :
  date : 1355802851 <=> 1366003861
  version : 29 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 71
Added: mm 135

>>> dictionaries/fr_wordlist.combined.gz
Header :
  date : 1357617878 <=> 1366003217
  version : 29 <=> 31
Body :
Not a word: re false -> true
Shortcut added: re le 15

>>> dictionaries/nb_wordlist.combined.gz
Header :
  date : 1355802836 <=> 1366003450
  version : 29 <=> 31
Body :
Freq changed: iPhone 91 -> 30
Added: app 30

>>> dictionaries/ru_wordlist.combined.gz
Header :
  date : 1358763720 <=> 1366003693
  version : 30 <=> 31
Body :
Freq changed: за 140 -> 181
Freq changed: не 140 -> 191
Freq changed: про 131 -> 151
Freq changed: эры 125 -> 140

>>> dictionaries/sv_wordlist.combined.gz
Header :
  date : 1355802856 <=> 1366003804
  version : 29 <=> 31
Body :
Added: vi 180

>>> java/res/raw/main_en.dict
Header :
  date : 1355802851 <=> 1366003861
  version : 29 <=> 31
Body :
Deleted: HTTP 95
Deleted: WWW 71
Added: mm 135

>>> java/res/raw/main_fr.dict
Header :
  date : 1357617878 <=> 1366003217
  version : 29 <=> 31
Body :
Not a word: re false -> true
Shortcut added: re le 15

>>> java/res/raw/main_ru.dict
Header :
  date : 1358763720 <=> 1366003693
  version : 30 <=> 31
Body :
Freq changed: за 140 -> 181
Freq changed: не 140 -> 191
Freq changed: про 131 -> 151
Freq changed: эры 125 -> 140

Bug: 8560415
Bug: 7556679
Change-Id: If1c628edcb1cc5efd67e1715acf94f19c0eb4643
2013-04-15 14:51:02 +09:00
Jean Chalard
fd959fd159 am 1903b41f: Merge "Clean up tests and increase speed"
* commit '1903b41ffd42cd90c8fe71ee32bbe1fe556b8167':
  Clean up tests and increase speed
2013-04-14 22:45:52 -07:00
Jean Chalard
1903b41ffd Merge "Clean up tests and increase speed" 2013-04-15 05:42:09 +00:00
Tadashi G. Takaoka
8dfbb740e1 Ignore modifier key while sliding key input
Bug: 8284624
Change-Id: I839d7a769d98f29be647dbe511ba3f73ca44446d
2013-04-15 14:39:02 +09:00
Jean Chalard
001884a1ee Clean up tests and increase speed
Conservatively reduce the number of unigrams to test from 1000
to 100.

Bug: 8583091
Change-Id: I48621ec44ff5f0590640d7c6b174ab5a6d267aaf
2013-04-15 14:25:32 +09:00
Tadashi G. Takaoka
18414333d4 am e2af9b7e: Merge "Reset vertical correction when more suggestions are in modal mode"
* commit 'e2af9b7eb519126e67fb054e8bd5064049958feb':
  Reset vertical correction when more suggestions are in modal mode
2013-04-14 22:00:05 -07:00
Tadashi G. Takaoka
e2af9b7eb5 Merge "Reset vertical correction when more suggestions are in modal mode" 2013-04-15 04:57:33 +00:00
Tadashi G. Takaoka
51c38a441a Reset vertical correction when more suggestions are in modal mode
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
2013-04-15 13:56:03 +09:00
Jean Chalard
6223d82312 am c2653d0b: Fix a typo
* commit 'c2653d0b5c42290d8e7331617f0207c5a7537f67':
  Fix a typo
2013-04-14 21:01:25 -07:00
Jean Chalard
c2653d0b5c Fix a typo
Change-Id: I27b925be030e9e6ee8ae49dc13f39accec996d7e
2013-04-15 12:57:27 +09:00
Jean Chalard
69ffa8b0ff am 03d1dff3: Merge "Fix Binary dict tests"
* commit '03d1dff38d4de0f043420aae8a292d74b531324a':
  Fix Binary dict tests
2013-04-14 20:56:11 -07:00
Jean Chalard
03d1dff38d Merge "Fix Binary dict tests" 2013-04-15 03:53:54 +00:00
Jean Chalard
c2e9c511cb Fix Binary dict tests
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
2013-04-15 12:48:16 +09:00
Satoshi Kataoka
6246b7c324 am a94bb198: fix assertion
* commit 'a94bb198cf13a3729bb992fc9c5bfce779e58469':
  fix assertion
2013-04-14 20:12:46 -07:00
Satoshi Kataoka
a94bb198cf fix assertion
Change-Id: I34ff470122aa0f34c66425d2eeae7590187d3074
2013-04-15 12:03:21 +09:00
Tadashi G. Takaoka
a91da76683 Suppress calling onPressKey and onReleaseKey while detecting gesture
Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
2013-04-15 10:59:54 +09:00
Tadashi G. Takaoka
be1232b36f am b12c2af3: Tighten unit test condition of MoreKeysKeyboardBuilder
* commit 'b12c2af32e09624e1298e0109441b0f4d74b74dd':
  Tighten unit test condition of MoreKeysKeyboardBuilder
2013-04-14 18:17:25 -07:00
Tadashi G. Takaoka
b12c2af32e Tighten unit test condition of MoreKeysKeyboardBuilder
Bug: 8601979
Change-Id: Icf584f3b35adce69cc3dfc46f3aacfef05e5dd2a
2013-04-15 09:58:18 +09:00