nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
34083 commits 1 branch 0 tags 363 MiB
Commit graph

7975 commits

Author SHA1 Message Date
Tadashi G. Takaoka
9d5d01a543 Add null analysis annotations to keyboard package 
Change-Id: I6f020ece3c45d584d413e4265d6d3fbdf1ea8bd8
 2014-11-27 12:37:38 +09:00
Tadashi G. Takaoka
bb4075bc93 Merge "Fix possible NPE in MainKeyboardView" 2014-11-27 03:03:54 +00:00
Tadashi G. Takaoka
2ffcad113a Merge "Remove unused code from DictionaryFactory" 2014-11-27 03:01:46 +00:00
Tadashi G. Takaoka
b5a7ece02b Merge "Remove obsolete comment" 2014-11-27 02:52:04 +00:00
Jatin Matani
12d63820d4 Hook for fetching sync content from UserHistoryDict 
Add API to ExpandableBinaryDictionary to dump content
from a given dictionary. We use this for dumping data
for sync process.

Refactored UserHistoryDictionaryTests to scrap out the util
methods for testing. These utility methods would be used
for testing sync + user dictionary code in LatinIMEGoogleTests

Bug:18106539
Change-Id: I357f9192ea1bd69a526d0b620c25616a2e8e9d5b
 2014-11-26 11:17:24 -08:00
Jean Chalard
56577461d6 Allow whitelist changes when no close word 
When there isn't a close word in another language of the
current multi-language set, we allow whitelist entries
to take force even if we are not confident in the current
language.

Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: I044674ba7b70aa86ab2a48d2e4d53a1c8007b62c
 2014-11-26 18:43:22 +09:00
Jean Chalard
e752aab70d Use confidence to fix whitelist 
With this the most obvious problem is fixed. However there
are two remaining items : we should still enforce whitelist
when there are no close candidates at all, and we should
start in confident mode when pressing the globe key.

Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: Ibc0571ae35fc28f8d13760aa86b25db1163d3e31
 2014-11-26 17:29:59 +09:00
Tadashi G. Takaoka
cbefc0c8f9 Remove obsolete comment 
Change-Id: I9e606fd573a60d12482b12e0e9adaecd552f66a7
 2014-11-26 12:02:07 +09:00
Jean Chalard
b479a56f28 Merge "Add confidence." 2014-11-25 06:22:30 +00:00
Jean Chalard
d06dd0ca12 Add confidence. 
Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: Ica09d11cb95308dd014c4e4e0d99a30dd66bfea9
 2014-11-25 14:41:27 +09:00
Tadashi G. Takaoka
8e32700914 Merge "Refactor PointerTracker and MainKeyboardView" 2014-11-25 02:09:25 +00:00
Tadashi G. Takaoka
a414b81a6c Remove unused code from DictionaryFactory 
Change-Id: I666308ada968ee7993235ad98b92f2ad522af122
 2014-11-21 17:58:50 +09:00
Tadashi G. Takaoka
8a711f2a54 Remove unneeded Context argument 
Change-Id: Ib34931836a617d0dc049fb3c9ae6686374ec8c12
 2014-11-21 12:49:04 +09:00
Tadashi G. Takaoka
53b6d627e7 Refactor PointerTracker and MainKeyboardView 
This CL reorganize the key press/release state visual drawing code.

Change-Id: I4aa10f57309ae2f81333a1e2bd863c23a7a41d82
 2014-11-21 12:40:00 +09:00
Tadashi G. Takaoka
ebe5b42f71 Make LocaleUtils.constructLocaleFromString as @Nonnull 
Change-Id: I82d574c67b25239510f3ecc8882efe46e40677eb
 2014-11-21 12:02:06 +09:00
Jean Chalard
a7efe06208 Annotate the typed word with its source dictionary 
...when applicable of course. This will allow for informing the
language switching authorities that the typed word was a
specific language, instead of leaving them in the dark.

Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: Ice3e7026a68c3018f54d730ec84f6762bf55899b
 2014-11-20 18:31:01 +09:00
Tadashi G. Takaoka
a66069abd8 Fix possible NPE in MainKeyboardView 
Change-Id: I1fc21a981d9f1740315763b5ca0c1024ece1fa4d
 2014-11-20 15:07:28 +09:00
Jean Chalard
a94733cbca Fix an NPE. 
Change-Id: Ie5ab5cc716ef1211eb9ad76baa0467455e1f1a71
 2014-11-20 14:48:33 +09:00
Jean Chalard
1d80cb2301 Merge "Fix a NPE" 2014-11-20 05:28:47 +00:00
Jean Chalard
a2cb2f36a6 Make the typed word a SuggestedWordInfo 
That allows to carry the language information in an
accurate manner.

Bug: 18063142
Change-Id: I0bca8981372ae10648274095b18b26a3686b762b
 2014-11-20 13:57:01 +09:00
Jean Chalard
0e00f5fe3a Fix a NPE 
Bug: 18451316
Change-Id: Ia20bf388471f84c963354df050182e722d966a02
 2014-11-20 13:50:27 +09:00
Jean Chalard
8736f2d719 Merge "Fix oscillations on ICS" 2014-11-19 10:23:28 +00:00
Jean Chalard
9444d70514 Fix oscillations on ICS 
Bug: 18181427
Change-Id: Ib4dd62037b1f7b2d10496ee3e45b4a138e29f90a
 2014-11-19 19:22:04 +09:00
Tadashi G. Takaoka
6c47403e27 Rename StringUtils methods that handle title case manipulation 
Change-Id: Iee0dd077a0423f110f4f8dad0f04933045baef2a
 2014-11-19 19:08:05 +09:00
Jean Chalard
fde0cce103 Merge "Remove the other deprecated constructor to SuggestedWords" 2014-11-19 08:30:03 +00:00
Tadashi G. Takaoka
b9116af29f Fix SubtypeLocaleUtils.getSubtypeNameForLogging accepting null 
Change-Id: Ic5cb55e24a2d843027ccc4e8e5d6954f9391c125
 2014-11-19 11:57:49 +09:00
Jean Chalard
6d1201915d Rename a confusing method name 
...and fix a bug that happened because of it.

Bug: 18417740
Change-Id: I7a33780adcb8f4e2625abcd3eec906dfee1f5dcf
 2014-11-18 11:52:35 +09:00
Tadashi G. Takaoka
76f47ee433 Merge "Refactor KeyboardState.SavedKeyboardState class a bit" 2014-11-17 10:00:02 +00:00
Tadashi G. Takaoka
81dde500a8 Merge "Remove deprecated Canvas.clipRegion(Region) call" 2014-11-17 09:05:12 +00:00
Jean Chalard
83f9524b87 Remove the other deprecated constructor to SuggestedWords 
Change-Id: Ied821df01e032ebc913d2f15dffdf41a51372ea4
 2014-11-17 16:23:52 +09:00
Adrian Velicu
37f5b0d4ff Bumping metadata database version to 11. 
Change-Id: I19e2f701f3e2334355bfd7105f9b62dcb53cc209
 2014-11-14 15:14:21 -08:00
Adrian Velicu
91a81a2790 More verbosity when reporting broken dictionaries 
Also added toString for AssetFileAddress for easier debugging.

Change-Id: Ie5d15d12bae46c31b28d8c67002e627f4c6690e3
 2014-11-14 13:42:24 -08:00
Adrian Velicu
39d50e7e7a Merge "UpdateHandler to support v202 dicts." 2014-11-14 03:45:32 +00:00
Jatin Matani
d60f9c046e Merge "Implement UserHistoryDictionary for each user account." 2014-11-14 00:46:37 +00:00
Jatin Matani
5365191a9d Implement UserHistoryDictionary for each user account. 
UserHistoryDictionary currently uses locale to determine the
UserHistoryDictionary on the filesystem. With this change we
use the account name as well. Thus each UserHistoryDictionary
would following the following spec:

UserHistoryDictionary.<locale>.<account>.dict.
In case no account is selected, we default to the existing
spec:
UserHistoryDictionary.<locale>.dict

Example
UserHistoryDictionary.en_US.testaccount@example.com.dict

Bug: 18104749
Change-Id: Iab031e166b55cf2ded68275a7e9be22475737b37
 2014-11-13 14:21:38 -08:00
Tadashi G. Takaoka
d6e367ff5b Move isRtlLanguage method to LocaleUtils 
Change-Id: I485a076b81927fed0da593216fea2c740449ef4c
 2014-11-12 16:47:38 -08:00
Tadashi G. Takaoka
63e076764b Merge "Add RichInputMethodSubtype.getKeyboardLayoutSetName" 2014-11-13 00:41:10 +00:00
Tadashi G. Takaoka
6de31466b0 Add RichInputMethodSubtype.getKeyboardLayoutSetName 
Change-Id: I90cc74ee882e8aa2b243885d3b994223ca3b6f44
 2014-11-12 15:41:38 -08:00
Tadashi G. Takaoka
1dfdd9b509 Clean SubtypeLocaleUtils a bit 
Change-Id: If8b981715983e3a12867c9b7c53bfa5effaddd39
 2014-11-12 15:14:52 -08:00
Adrian Velicu
de29278592 UpdateHandler to support v202 dicts. 
Change-Id: Ib61a5005a82927f5e12a19c9c14f20d46572cf31
 2014-11-12 12:04:38 -08:00
Tadashi G. Takaoka
dd0b8a06a8 Refactor KeyboardState.SavedKeyboardState class a bit 
Change-Id: I5be7339c4797b0308c1a192d2984056619fdfbdd
 2014-11-10 16:40:59 -08:00
Tadashi G. Takaoka
0d6ce46528 Move logic to determine spacebar text to LanguageOnSpacebarHelper 
Change-Id: Ib9dbbb4bd4e35c15fd752c364d3012e8a7da2410
 2014-11-08 18:50:59 -08:00
Tadashi G. Takaoka
52a87a4cc3 Merge "Clean up KeyboardLayoutSet a bit" 2014-11-07 18:02:48 +00:00
Tadashi G. Takaoka
ec0d6bb9b7 Merge "Move current subtype management code to RichInputMethodManager" 2014-11-07 18:02:22 +00:00
Jean Chalard
5c4f642df6 Merge "Move util classes under common" 2014-11-07 09:15:35 +00:00
Jean Chalard
5b91b551e5 Move util classes under common 
Also why did we have two copies of LocaleUtils >.>

Bug: 18108776
Change-Id: I03b4403dfd51934e66b567f2f8b87da419cfb3ab
 2014-11-07 18:00:03 +09:00
Jean Chalard
e0c2e5b2f7 Merge "Remove a deprecated constructor to SuggestedWords" 2014-11-07 08:49:26 +00:00
Jean Chalard
c3e211bd6b Remove a deprecated constructor to SuggestedWords 
Change-Id: If4d358b3a11fb25fc214c728269519d8c25f9adc
 2014-11-07 16:40:24 +09:00
Tadashi G. Takaoka
7286667754 Merge "Move shorcut IME related code from SubtypeSwitcher to RichInputMethodManager" 2014-11-07 06:20:07 +00:00
Jean Chalard
51d0b3351b Merge "Remove a useless method." 2014-11-07 06:00:54 +00:00
Jean Chalard
536bf61658 Merge "Remove dicttool dependency to NativeSuggestOptions" 2014-11-07 06:00:40 +00:00
Tadashi G. Takaoka
7fb0ed58ed Move current subtype management code to RichInputMethodManager 
Change-Id: I82d5a17a5ec96f26047d29e79f3f28850fc5b3bb
 2014-11-06 11:51:07 -08:00
Tadashi G. Takaoka
8a2c4afad4 Move shorcut IME related code from SubtypeSwitcher to RichInputMethodManager 
Change-Id: I0f95f603d80570c937e8c38ded88df341c11795e
 2014-11-06 11:51:07 -08:00
Tadashi G. Takaoka
2a7da0ab87 Move some methods out from SubtypeSwitcher 
Change-Id: I89aaf87d7d0cc204b0ca0f61c2f64d15e2df848e
 2014-11-06 11:51:01 -08:00
Jean Chalard
b395ce4396 Remove a useless method. 
Yay for cleanup

Bug: 18108776
Change-Id: I13f4066cd54f294377fdcf375a69350c44d4a32a
 2014-11-06 21:38:17 +09:00
Jean Chalard
03eb9de961 Remove dicttool dependency to NativeSuggestOptions 
Bug: 18108776
Change-Id: I0f57594617f8d5080aea9002b2356d18bfe97043
 2014-11-06 21:38:11 +09:00
Tadashi G. Takaoka
b68f90ac1a Clean up KeyboardLayoutSet a bit 
This CL moves getScriptId() from KeyboardLayoutSet.Builder to
KeyboardLayoutSet.

Change-Id: I13588467e3d03abb92120acb367f021ee3490a50
 2014-11-06 12:30:16 +09:00
Jean Chalard
ab68143ad0 Fix a bug where LatinIME would recorrect with no input view 
Bug: 18071127
Change-Id: I634d1f63f7d5c5b7453ed7559f9b65fa0433dcd8
 2014-11-05 17:41:15 +09:00
Tadashi G. Takaoka
b1439c2872 Fix EmojiPageKeyboardView onPress bug 
Change-Id: I110f36e0547be4957656217c42a8dafd9359b700
 2014-11-04 20:27:39 +09:00
Tadashi G. Takaoka
ede88a3bd6 Merge "Revert "Fix Emoji key feedback"" 2014-11-04 11:25:58 +00:00
Tadashi G. Takaoka
a5d24336bf Revert "Fix Emoji key feedback" 
This reverts commit 953858d615.
The original CL should be split into two.

Change-Id: Ic1d032e2964a1b9bb44d98bdb8573c6cb47a865c
 2014-11-04 11:24:26 +00:00
Tadashi G. Takaoka
c514d3ead2 Merge "Fix Emoji key feedback" 2014-11-04 09:17:51 +00:00
Tadashi G. Takaoka
953858d615 Fix Emoji key feedback 
Bug: 18166905
Change-Id: I3c3296cabeed31e1250ff0753ea94576b494b96a
 2014-11-04 17:49:18 +09:00
Tadashi G. Takaoka
98dfa6e334 Fix MainKeyboardView visibility must be aligned with main keyboard frame 
Bug: 18105755
Change-Id: Ifdcaded538d0eac3b100486ddf27ae4314293792
 2014-11-04 13:17:07 +09:00
Tadashi G. Takaoka
d60f49425b Merge "Make DrawingProxy and TimerProxy as a top-level interface" 2014-11-04 02:52:15 +00:00
Ken Wakasa
933920feae Fix a wrong indent 
Change-Id: Iaee83be85bb52c350dd08e4497732927b92eabcd
 2014-11-04 11:18:52 +09:00
Ken Wakasa
f296e7cdfa Small comment fixes 
Change-Id: Iecb432c414eadf13ee6a57fb21fc02d1c27e777f
 2014-11-02 23:54:20 +09:00
Tadashi G. Takaoka
c235a3be9d Add debug logging 
Change-Id: I38bf53a0b5ea5064462b8eb5d99b7247ff8bddc4
 2014-11-02 22:34:43 +09:00
Keisuke Kuroyanagi
b3bae2e89b Merge "Update v4 format version from 402 to 403." 2014-10-31 14:19:44 +00:00
Tadashi G. Takaoka
ef8068f9a8 Merge "Add helper methods to convert flags to readable text" 2014-10-31 10:12:37 +00:00
Keisuke Kuroyanagi
ea468cc9de Update v4 format version from 402 to 403. 
Without personalization:
Total words: 1134774, Success Num: 899230, Success Percentage: 79.243%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1871, Bad Failure Percentage: 0.165%
Failures, with auto-correction (F-C): 29084, F-C Percentage: 2.563%
Max Keystrokes: 6072959, Min Keystrokes: 4436090, Keystroke Saving Percentage:26.953%

Before:
Total words: 1134646, Success Num: 925194, Success Percentage: 81.540%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1316, Bad Failure Percentage: 0.116%
Failures, with auto-correction (F-C): 28288, F-C Percentage: 2.493%
Max Keystrokes: 6072831, Min Keystrokes: 3946188, Keystroke Saving Percentage:35.019%

After
Total words: 1134659, Success Num: 944746, Success Percentage: 83.263%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28016, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3387333, Keystroke Saving Percentage:44.222%

Change-Id: I3af42ec37a11847c0429c28616e726f6a339247f
 2014-10-31 17:23:39 +09:00
Jean Chalard
5840a7c6e7 Merge "Remove Dict dependency on WordComposer and ProximityInfo" 2014-10-31 07:59:12 +00:00
Tadashi G. Takaoka
9dc3ae84ee Add helper methods to convert flags to readable text 
Change-Id: I23608927cef8a897ff4ad8c938560cc78093ddac
 2014-10-31 16:20:20 +09:00
Ken Wakasa
ed575b62da Merge "Add documentation for CollectionUtils#arrayAsList" 2014-10-31 07:07:07 +00:00
David Faden
d443146c34 Add documentation for CollectionUtils#arrayAsList 
(This is a cherrypick of http://ag/576739)

Also, modify the IllegalArgumentException to capture the
values passed for start, end, and array.length to make
debugging easier in the unlikely event that it is thrown.
Add corresponding tests for the exceptions.

Tested:
tapas LatinImeGoogle LatinImeGoogleTests userdebug
make -j30 && \
adb install -r \
out/target/product/generic/data/app/LatinImeGoogleTests/LatinImeGoogleTests.apk && \
adb install -r \
out/target/product/generic/system/app/LatinImeGoogle/LatinImeGoogle.apk && \
adb shell am instrument -w -e class \
com.android.inputmethod.latin.utils.CollectionUtilsTests \
com.google.android.inputmethod.latin.tests/android.support.test.runner.AndroidJUnitRunner

Change-Id: I0c579ca4f4f2a9b2575aa6f8fa75e3ee4a21cf8a
 2014-10-31 06:18:35 +00:00
Adrian Velicu
88480f39f6 Update unit tests for new static dict version. 
Bug: 11031090
Change-Id: Ifd7b241f1a0a30678ca7de97cc6e96927a9b5c8f
 2014-10-31 14:50:18 +09:00
Adrian Velicu
7c87859d4c Using "blacklist" flag as "possibly offensive" 
Bug: 11031090
Change-Id: I5cc0d006ab003656498eb82b0875eb9c051d331e
 2014-10-31 14:33:05 +09:00
Tadashi G. Takaoka
8523720b22 Remove deprecated Canvas.clipRegion(Region) call 
Change-Id: I88e0a8d327c17bf4bafbe44cdfa265f5d0acb879
 2014-10-31 14:06:30 +09:00
Tadashi G. Takaoka
77947c9c96 Merge "Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy" 2014-10-30 09:55:51 +00:00
Tadashi G. Takaoka
34a9e2ae87 Make DrawingProxy and TimerProxy as a top-level interface 
Change-Id: Ia425f341255595f8f80c13b2aa409249f9ce4202
 2014-10-30 18:29:49 +09:00
Tadashi G. Takaoka
be708c4e59 Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy 
Change-Id: I654f7483d1c013ac2685a45af4eb2af15fa219ad
 2014-10-30 18:28:40 +09:00
Andy Wang
0ca400c827 Merge "Add a preference to resize the keyboard height." 2014-10-30 03:37:26 +00:00
Tadashi G. Takaoka
d9b1327c21 Merge "Consolidate similar methods" 2014-10-30 02:54:38 +00:00
Andy Wang
bb9400aebc Add a preference to resize the keyboard height. 
The keyboard height is controlled by a slider in the debug preferences.
Without access to debug preferences, this change is a no-op.

Bug: 6867494
Change-Id: I984064ed1cab752876615f5ed582818474d6041b
 2014-10-30 11:45:41 +09:00
Tadashi G. Takaoka
d2c00f550d Fix dismiss key preview bug introduced by I658a5b16cc 
Change-Id: I5248374dfe0504f6e64cc5d994e275d80364ec9d
 2014-10-30 11:43:53 +09:00
Tadashi G. Takaoka
051f8b1442 Consolidate similar methods 
This CL consolidates similar methods in MainKeyboardView.
- startWhileTypingFadeinAnimation and startWhileTypingFadeoutAnimation
- showSlidingKeyInputPreview and dismissSlidingKeyInputPreview

Change-Id: I607ab74683820de2456af3e75663cf8cf358ab38
 2014-10-30 11:15:59 +09:00
Tadashi G. Takaoka
4e0149c22a Merge "Remove DrawingHandler" 2014-10-29 13:42:44 +00:00
Jean Chalard
93e5cdea71 Merge "[CS8] Add explanations" 2014-10-29 12:26:23 +00:00
Tadashi G. Takaoka
2ad6d9cda3 Remove DrawingHandler 
Change-Id: I658a5b16cca1e56f0b944009b8aef09e0a97a0db
 2014-10-29 18:51:41 +09:00
Tadashi G. Takaoka
ca6e5dfedb Remove DrawingHandler.Callbacks.dismissAllKeyPreviews() 
Change-Id: I2b11ca0dec0f3522648557a9a909f305cc4170fb
 2014-10-29 15:25:09 +09:00
Jean Chalard
ecab6aff59 Remove Dict dependency on WordComposer and ProximityInfo 
Bug: 18108776
Change-Id: I9b399a44241e05a7add9bb8094263aa76de37880
 2014-10-29 12:27:24 +09:00
Jean Chalard
36799b2aa2 Move InputPointers and ResizableIntArray to common 
Bug: 18108776
Change-Id: Ie5c0430aa41a8d6c58bf510a10173223d7dfe9fe
 2014-10-29 12:09:11 +09:00
Tadashi G. Takaoka
48ee473c1e Merge "Clean up UserDictionaryCompatUtils" 2014-10-29 00:37:43 +00:00
Jean Chalard
4beeb9253a Move StringUtils under common. 
Bug: 18108776
Change-Id: Ia46a4102a0e86e71118ca5e641f9f531998e166b
 2014-10-28 22:44:30 +09:00
Jean Chalard
ca724ef71f Reduce StringUtils dependency on the Android libs 
Bug: 18108776
Change-Id: I43feb25d79f89276d44462ba71788a14c4583277
 2014-10-28 22:03:18 +09:00
Tadashi G. Takaoka
fec5219974 Fix Serbian Latin subtype handling 
This CL also adds unit tests for Hinglish and Serbian Latin.

Bug: 9687668
Bug: 17169632
Change-Id: Ib9aa1bcdf5b390a9d8c61f07165beacf850e2692
 2014-10-28 18:36:16 +09:00
Tadashi G. Takaoka
dccf4f2a41 Clean up UserDictionaryCompatUtils 
Change-Id: I1b22c82930af4f30db4237335850fb34b66f9299
 2014-10-28 17:42:17 +09:00
Tadashi G. Takaoka
395009c03e Fix NPE in AppearanceSettingsFragment 
Bug: 18147440
Change-Id: I7a7a47b3484e54146d34d11b5bd9c1305421d829
 2014-10-28 15:02:31 +09:00
Jean Chalard
67527f847e [CS8] Add explanations 
Bug: 13238601
Change-Id: I72a78be5848485f7fd77f5586573692529c7547b
 2014-10-28 13:41:00 +09:00
Tadashi G. Takaoka
d5455fea4a Merge "Add null analysis annotation to CollectionUtils" 2014-10-27 09:43:22 +00:00