a04ead80d7
am 02725535: Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete."
...
* commit '02725535784e03c3d6789251569204d2e397000f':
Fix inconsistent behavior with the spacebar on the Emoji pallete.
2014-01-27 21:08:47 -08:00
0272553578
Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete."
2014-01-28 05:06:07 +00:00
0e04c24a05
Fix inconsistent behavior with the spacebar on the Emoji pallete.
...
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.
With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.
Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
2014-01-28 13:44:31 +09:00
4b5e56d648
am ca1c1ddd: Merge "[IL94] Remove a function and some reordering"
...
* commit 'ca1c1ddd4ecdca1a863dbf8274dca2fc3e91a8ac':
[IL94] Remove a function and some reordering
2014-01-27 19:48:05 -08:00
ca1c1ddd4e
Merge "[IL94] Remove a function and some reordering"
2014-01-28 03:46:28 +00:00
43502ea3ba
am 9909d6aa: Merge "[IL93] Refactor a method inside another"
...
* commit '9909d6aa49ea17b6dd391a48e2ad29be11006249':
[IL93] Refactor a method inside another
2014-01-27 19:34:07 -08:00
d5259d578b
am cbf54dea: Merge "[IL92] Straighten out showSuggestionStripWithTypedWord"
...
* commit 'cbf54dea49151e3d8a8dff5074d289ce38dd0698':
[IL92] Straighten out showSuggestionStripWithTypedWord
2014-01-27 19:34:05 -08:00
9909d6aa49
Merge "[IL93] Refactor a method inside another"
2014-01-28 03:32:52 +00:00
cbf54dea49
Merge "[IL92] Straighten out showSuggestionStripWithTypedWord"
2014-01-28 03:32:17 +00:00
ba122b291b
am 5a1f8373: Merge "[IL91] Call reorder"
...
* commit '5a1f837356673f04fd68dea8f0b084dc9de7db33':
[IL91] Call reorder
2014-01-27 19:28:41 -08:00
5a1f837356
Merge "[IL91] Call reorder"
2014-01-28 03:26:23 +00:00
9ac6c9064d
Fix test fails caused by I8bede13c87
...
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
2014-01-28 11:17:47 +09:00
a4d04eb863
am c2e2b394: Merge "Add SubtypeLocaleUtils.isRtlLanguage method"
...
* commit 'c2e2b3949b159d6412e0e5815c1503d94b2b5ce7':
Add SubtypeLocaleUtils.isRtlLanguage method
2014-01-27 17:30:14 -08:00
c2e2b3949b
Merge "Add SubtypeLocaleUtils.isRtlLanguage method"
2014-01-28 01:28:47 +00:00
16a9bb3da8
Import translations. DO NOT MERGE
...
Change-Id: I9632cf713ad9e1bba1df5819c4038739229f7ec2
Auto-generated-cl: translation import
2014-01-27 14:42:02 -08:00
92b67fc32b
Import translations. DO NOT MERGE
...
Change-Id: I4aa5b70b2bb231583501347c69dba7172aa975cb
Auto-generated-cl: translation import
2014-01-27 14:40:58 -08:00
5b5e877efe
[IL94] Remove a function and some reordering
...
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
2014-01-27 20:38:45 +09:00
37e1cc931f
[IL93] Refactor a method inside another
...
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.
Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
2014-01-27 20:38:45 +09:00
4c6029e530
[IL92] Straighten out showSuggestionStripWithTypedWord
...
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
2014-01-27 20:38:45 +09:00
c6367ee64d
[IL91] Call reorder
...
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
2014-01-27 20:38:43 +09:00
b3b2676c4a
am 01893b25: Merge "[IL90] Small refactoring"
...
* commit '01893b25dd25266d14c38d892176fbda052e1812':
[IL90] Small refactoring
2014-01-27 03:22:08 -08:00
efef6d87e9
am 3f226af4: Merge "[IL89] Inline a function"
...
* commit '3f226af439700e9e01eabf7280a5c366e10a3d74':
[IL89] Inline a function
2014-01-27 03:22:06 -08:00
2a36d9bf3b
am 5b9e54c1: Merge "[IL88] Simple refactoring"
...
* commit '5b9e54c135cb1fa2ca1a5b5967a7934b789a8ed4':
[IL88] Simple refactoring
2014-01-27 03:22:03 -08:00
925f8fcf88
am 8f3e37a6: Merge "[IL87] Remove a call to clearSuggestionStrip"
...
* commit '8f3e37a63187f4fb2731f629472037a373796097':
[IL87] Remove a call to clearSuggestionStrip
2014-01-27 03:22:01 -08:00
01893b25dd
Merge "[IL90] Small refactoring"
2014-01-27 11:18:52 +00:00
38f4272ade
am 521a83a3: Merge "[IL86] Simplification and correctness fix."
...
* commit '521a83a3f122d02d24317540fd7bafb1918acb08':
[IL86] Simplification and correctness fix.
2014-01-27 03:18:40 -08:00
ddfce8b7c4
am 7aa7e366: Merge "[IL85] Maybe show punctuations when app completions are null"
...
* commit '7aa7e3661117ab60d85b4d4ce83167073c370bec':
[IL85] Maybe show punctuations when app completions are null
2014-01-27 03:18:37 -08:00
9cc7238f71
am 264f4e38: Merge "[IL84] Remove a useless call and rename a method"
...
* commit '264f4e380dd496b156914a47089bd26b9eba1cb6':
[IL84] Remove a useless call and rename a method
2014-01-27 03:18:34 -08:00
1ced9e6ddc
am 7ac542d4: Merge "[IL83] Inline a call"
...
* commit '7ac542d490b4761837733d1732a8e6ca8c097739':
[IL83] Inline a call
2014-01-27 03:18:32 -08:00
3f226af439
Merge "[IL89] Inline a function"
2014-01-27 11:18:19 +00:00
5b9e54c135
Merge "[IL88] Simple refactoring"
2014-01-27 11:17:54 +00:00
8f3e37a631
Merge "[IL87] Remove a call to clearSuggestionStrip"
2014-01-27 11:17:45 +00:00
521a83a3f1
Merge "[IL86] Simplification and correctness fix."
2014-01-27 11:17:31 +00:00
7aa7e36611
Merge "[IL85] Maybe show punctuations when app completions are null"
2014-01-27 11:17:18 +00:00
264f4e380d
Merge "[IL84] Remove a useless call and rename a method"
2014-01-27 11:17:05 +00:00
7ac542d490
Merge "[IL83] Inline a call"
2014-01-27 11:16:30 +00:00
2e7f0680ad
am 47ff4231: Merge "[IL82] Fix a wrong comment"
...
* commit '47ff423121ce9d584cb4c71295ff42b275552214':
[IL82] Fix a wrong comment
2014-01-27 02:13:37 -08:00
0256b15d3a
am 75ec579e: Merge "[IL81] Remove a useless test."
...
* commit '75ec579e07ccb598970bc800db2d9f2dac11ec7a':
[IL81] Remove a useless test.
2014-01-27 02:13:35 -08:00
47ff423121
Merge "[IL82] Fix a wrong comment"
2014-01-27 10:11:42 +00:00
75ec579e07
Merge "[IL81] Remove a useless test."
2014-01-27 10:11:14 +00:00
c0c74d22a0
Add SubtypeLocaleUtils.isRtlLanguage method
...
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
7f1a5c4d9b
am 6d1c8b2c: Merge "Try to figure out whether d.quotes open or close."
...
* commit '6d1c8b2c3f78969866db7f718e7e8d2be240f674':
Try to figure out whether d.quotes open or close.
2014-01-27 02:02:44 -08:00
a8b37414f8
am b084da2a: Merge changes I5092942a,I931c553f
...
* commit 'b084da2ae6622488779ddb3a66081610bfe96a66':
[IL80] Reverse a test for clarity.
[IL79] Some refactoring
2014-01-27 02:02:42 -08:00
6d1c8b2c3f
Merge "Try to figure out whether d.quotes open or close."
2014-01-27 10:01:17 +00:00
b084da2ae6
Merge changes I5092942a,I931c553f
...
* changes:
[IL80] Reverse a test for clarity.
[IL79] Some refactoring
2014-01-27 10:00:37 +00:00
f58a96c977
am a3a85e8c: Merge "[IL78] Move most of onUpdateSelection to InputLogic."
...
* commit 'a3a85e8c2bcab6ff9b00fda52e3ba0c666055951':
[IL78] Move most of onUpdateSelection to InputLogic.
2014-01-27 01:57:15 -08:00
a3a85e8c2b
Merge "[IL78] Move most of onUpdateSelection to InputLogic."
2014-01-27 09:55:08 +00:00
d38b0468b0
[IL90] Small refactoring
...
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
33ff321d6c
[IL89] Inline a function
...
We will then refactor the contents of showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
ca819178a1
[IL88] Simple refactoring
...
With this, the value passed to suggestedWords is never null.
Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
d90bdd2187
[IL87] Remove a call to clearSuggestionStrip
...
The goal is to remove the function completely.
Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
3b939ed77f
[IL86] Simplification and correctness fix.
...
This should be what was intended.
Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
07eddf3c43
[IL85] Maybe show punctuations when app completions are null
...
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.
Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
b2c0388a69
[IL84] Remove a useless call and rename a method
...
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
eb190ab32f
[IL83] Inline a call
...
The coming string of changes is very complicated, so
I'm going to do things really slowly.
Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
17f1528f9e
[IL82] Fix a wrong comment
...
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
abbd755689
[IL81] Remove a useless test.
...
It seems the comments were right all along. This seems to really
be useless.
Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
f1e5b9b4d1
[IL80] Reverse a test for clarity.
...
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
f59487379e
[IL79] Some refactoring
...
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
10460441db
[IL78] Move most of onUpdateSelection to InputLogic.
...
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
c8bddebf1a
am 1e4b1300: Merge "Refactor SuggestionsStripLayoutHelper class"
...
* commit '1e4b1300e65095ca4b064afb5590d4bc02ff7725':
Refactor SuggestionsStripLayoutHelper class
2014-01-27 01:39:02 -08:00
1e4b1300e6
Merge "Refactor SuggestionsStripLayoutHelper class"
2014-01-27 09:36:52 +00:00
d7c3ceac59
am 68d7291a: Merge "[IL77] Remove refs to Settings from InputLogic"
...
* commit '68d7291a6bdc1d5633d744759a5c76599499d9e9':
[IL77] Remove refs to Settings from InputLogic
2014-01-27 01:35:46 -08:00
37985b2540
am 7bee8409: Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
...
* commit '7bee84095e24a9e21e8a2146f7bb9d1ad2cd89ba':
[IL75] Move the SubtypeSwitcher out of InputLogic.
2014-01-27 01:35:41 -08:00
c6473b5964
am 829ad708: Merge "Revert "Use ViewCompat support library""
...
* commit '829ad708db7bc3c9a0eabad8d3e410da400f36e6':
Revert "Use ViewCompat support library"
2014-01-27 01:35:39 -08:00
68d7291a6b
Merge "[IL77] Remove refs to Settings from InputLogic"
2014-01-27 09:29:50 +00:00
148dedbc5d
Refactor SuggestionsStripLayoutHelper class
...
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
2014-01-27 18:25:25 +09:00
7bee84095e
Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
2014-01-27 09:24:10 +00:00
829ad708db
Merge "Revert "Use ViewCompat support library""
2014-01-27 09:20:19 +00:00
48df380f78
[IL77] Remove refs to Settings from InputLogic
...
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
969c06072d
[IL75] Move the SubtypeSwitcher out of InputLogic.
...
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
c7ef305bbc
Try to figure out whether d.quotes open or close.
...
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
e4692c0050
Revert "Use ViewCompat support library"
...
This reverts commit e7ee4fa862
2014-01-27 18:14:40 +09:00
5be5fd13e0
am 5cf70a1d: Merge "[IL74] Remove unused/unwanted arguments to a method."
...
* commit '5cf70a1d44395a4a857eeb33504f8458fbba2464':
[IL74] Remove unused/unwanted arguments to a method.
2014-01-27 00:58:49 -08:00
5cf70a1d44
Merge "[IL74] Remove unused/unwanted arguments to a method."
2014-01-27 08:57:12 +00:00
c93a0e71fe
am 0b586179: Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
...
* commit '0b5861795158e4a9f1c8b8c9025ab3f4e49adebc':
Fix inconsistent behavior with backspace in the Emoji pallete.
2014-01-27 00:14:23 -08:00
0b58617951
Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
2014-01-27 08:11:51 +00:00
0fd556ceca
[IL74] Remove unused/unwanted arguments to a method.
...
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
ea8c1c811c
Fix inconsistent behavior with backspace in the Emoji pallete.
...
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
the key.
This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
subsequent delete key events when the finger is moved away
from the key area.
Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
4bc31d5111
am f3ca92dd: Merge "Use ViewCompat support library"
...
* commit 'f3ca92dd33254e0c7cc87e9ffac0cfc41c4ea3f5':
Use ViewCompat support library
2014-01-26 23:23:12 -08:00
f3ca92dd33
Merge "Use ViewCompat support library"
2014-01-27 07:21:41 +00:00
3873ee735d
am 03283b63: Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
* commit '03283b636c0c35bfd4ff8fe6b30db27fad5cf824':
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-26 23:19:57 -08:00
e7ee4fa862
Use ViewCompat support library
...
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
03283b636c
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
some cleanups as well
Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
c9243ca1f7
am 95043145: Merge "Check length of words for personalization dict."
...
* commit '95043145df6d943849f871a80802fc40c5c8ff5b':
Check length of words for personalization dict.
2014-01-24 16:47:53 -08:00
95043145df
Merge "Check length of words for personalization dict."
2014-01-25 00:44:58 +00:00
b7197b705b
Check length of words for personalization dict.
...
Bug: 12602903
Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
86795823f7
am 0acd1210: Fix wrong indents.
...
* commit '0acd121083baf137dc81cd2c5ce4214a9848a82d':
Fix wrong indents.
2014-01-24 06:59:07 -08:00
0acd121083
Fix wrong indents.
...
Removed an unused method too.
Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
341044034c
am b6e128cc: Merge "[IL69.1] Move a static method to a utility class."
...
* commit 'b6e128cc05fa0b4b1f79b6c7eb4d67f44833c7f4':
[IL69.1] Move a static method to a utility class.
2014-01-23 19:07:26 -08:00
b6e128cc05
Merge "[IL69.1] Move a static method to a utility class."
2014-01-24 03:04:12 +00:00
1d6e647ac3
[IL69.1] Move a static method to a utility class.
...
This is a followup to IL69.
Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
9bbb214edd
am 0c725290: Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer"
...
* commit '0c72529088e02d7dbe496397fbb64089b8acd594':
[IL73] Remove all refs to Key and Keyboard in WordComposer
2014-01-23 17:58:29 -08:00
0c72529088
Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer"
2014-01-24 01:55:57 +00:00
6a39811d90
Merge "Import translations. DO NOT MERGE"
2014-01-23 21:02:33 +00:00
5047b4aa84
Import translations. DO NOT MERGE
...
Change-Id: Ib5a8be5d9ac508d57648e4e8811805eea4355fc3
Auto-generated-cl: translation import
2014-01-23 12:25:35 -08:00
9d7c6aafde
Import translations. DO NOT MERGE
...
Change-Id: I4ddadf6504a80fc0955c03496eeefc6c665d0965
Auto-generated-cl: translation import
2014-01-23 12:24:12 -08:00
2efb58fc98
Import translations. DO NOT MERGE
...
Change-Id: I6c8aa53b9be4c3aa5822a820cc8cfdc3cf31c390
Auto-generated-cl: translation import
2014-01-23 12:22:23 -08:00
3aa2043a66
Merge "[IL76] Remove a SuggestionStripView dependency"
2014-01-23 10:06:42 +00:00
f16a2a36d2
[IL71.1] Add some javadoc.
...
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
2014-01-23 17:11:47 +09:00
a1ed211c4e
[IL76] Remove a SuggestionStripView dependency
...
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.
Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
2014-01-23 16:25:48 +09:00
4173610bc5
[IL66.1] Add a comment
...
Followup to IL66
Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
2014-01-23 16:00:49 +09:00
be846fc352
[IL73] Remove all refs to Key and Keyboard in WordComposer
...
Please hold my gun while I have this nice cup of tea.
Yes !!
Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
2014-01-23 15:52:29 +09:00
df8310c6e2
Merge "[IL71] Add indices to toCodePointArray."
2014-01-23 06:50:19 +00:00
1284e556f4
[IL70] Remove unused arguments
...
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
d1f463eacf
[IL69] Oust Keyboard from WordComposer#setComposingWord
...
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
9da4b49ef6
[IL68] Start refactoring setComposingWord
...
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
2014-01-23 15:15:49 +09:00
18638d30c0
[IL71] Add indices to toCodePointArray.
...
This is necessary for tests
Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
2014-01-23 13:11:40 +09:00
eb6d41a525
[IL67] Externalize a call to the keyboard switcher
...
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
2014-01-23 13:10:02 +09:00
ab80b41a0d
[IL66] Remove two accesses to KeyboardSwitcher.
...
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
2014-01-23 13:09:58 +09:00
a91dfff5e5
[IL65] Pull up X,Y processing, step 4
...
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.
Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
2014-01-22 14:44:27 +09:00
352286a43b
[IL64] Pull up X,Y processing, step 3
...
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
2014-01-22 14:44:25 +09:00
b8216a4e7e
[IL63] Pull up X,Y processing, step 2
...
This also fixes the coordinates passed to logOnDelete and
log onSeparator.
Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
2014-01-22 14:42:52 +09:00
2b38b5e8e6
[IL62] Pull up X,Y processing, step 1
...
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.
However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.
Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
2014-01-22 14:41:45 +09:00
591580ee8a
Merge "[IL61] Remove an internal use of key coordinates"
2014-01-22 05:19:45 +00:00
6e15af2626
Merge "Fix newline string resource"
2014-01-20 10:45:11 +00:00
c93cf1c398
Use sorted int[] to represent word separators
...
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
2014-01-20 19:40:02 +09:00
08ce454aa5
Fix newline string resource
...
The newline string resource "\n" doesn't work off-device simulation.
Bug: 12623502
Change-Id: I3ad63d8afe50be174493d43f00f7191062c87cb7
2014-01-20 19:36:20 +09:00
5b6ebdbe9e
Merge "Refactor logic to retrieve relevant suggestions a bit"
2014-01-20 09:57:43 +00:00
837cdd738b
Add SpacingAndPunctuationsTests
...
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
2014-01-20 18:33:45 +09:00
3033cc51b8
Refactor logic to retrieve relevant suggestions a bit
...
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-20 12:08:25 +09:00
3f3b0af5b7
Merge "Fix unit tests by adding @UsedForTesting"
2014-01-19 22:47:03 +00:00
fde4c5f128
Fix unit tests by adding @UsedForTesting
...
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
2014-01-19 13:37:23 -08:00
b1814c9633
Merge "Make contacts dict and user dict version 4."
2014-01-17 20:05:17 +00:00
ed95d79cc4
Make contacts dict and user dict version 4.
...
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
2014-01-17 10:30:16 -08:00
6a18af634e
Refactor RichInputConnection a bit
...
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
2014-01-17 13:14:29 +09:00
2334bf6d8c
Merge "Fix a bug specific to German capitalization."
2014-01-17 01:49:14 +00:00
e4f584de73
Merge "[IL60] Make InputLogicHandler package private"
2014-01-16 18:15:15 +00:00
87f87d9ac5
Merge "[IL59] Rename a method"
2014-01-16 18:13:39 +00:00
9c9c43c0b7
Merge "[IL58] Simplification"
2014-01-16 17:45:59 +00:00
f4bf620502
Merge "Add a dedicated method to control time in native code."
2014-01-16 17:25:29 +00:00
ab4543d593
[IL61] Remove an internal use of key coordinates
...
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
2014-01-17 02:10:56 +09:00
81255612bc
[IL60] Make InputLogicHandler package private
...
Yay
Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
2014-01-17 02:10:56 +09:00
17bd129faf
[IL59] Rename a method
...
Um... this is not async ? Remove that from the name
Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
2014-01-17 02:10:56 +09:00
ac6dfaf80b
[IL58] Simplification
...
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.
Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
2014-01-17 02:10:51 +09:00
60afa7000f
Fix a bug specific to German capitalization.
...
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
2014-01-17 02:06:24 +09:00
9e882e3937
Merge "Update personalization dict via dictionary facilitator."
2014-01-16 02:00:21 +00:00
12474634c5
Update personalization dict via dictionary facilitator.
...
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
2014-01-15 17:54:17 -08:00
0851ac5726
Merge "Import translations. DO NOT MERGE"
2014-01-16 00:49:15 +00:00
5802fb05a8
Import translations. DO NOT MERGE
...
Change-Id: I9d276ae4391f209e2db3a080b3221e5a8aa59938
Auto-generated-cl: translation import
2014-01-15 16:42:37 -08:00
d78a447d10
Add a dedicated method to control time in native code.
...
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
2014-01-15 14:55:57 -08:00
2c1a13c56c
Merge "[IL57] Don't require a main dict suggestion."
2014-01-15 22:14:27 +00:00
118a4fc2b7
Merge "[IL56] Don't erase suggestions when reverting a commit."
2014-01-15 19:21:06 +00:00
e22e67e37a
[IL57] Don't require a main dict suggestion.
...
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.
Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
2014-01-16 03:22:51 +09:00
4752b68f5a
[IL56] Don't erase suggestions when reverting a commit.
...
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
2014-01-16 03:22:46 +09:00
20a8a4a3d9
Fix native method signature
...
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
2014-01-15 18:56:40 +09:00
01c1a1a2ba
Refactor LanguageModelParam class a bit
...
This change must be checked in together with I9ecfd1adc1.
Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
2014-01-15 17:46:32 +09:00
17a2bcfcce
Make final Locale field public
...
This change must be checked in together with Id9382498a8.
Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
2014-01-15 17:11:54 +09:00
b8a2772b0e
Consolidate LanguageModelParam constructors
...
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
2014-01-15 16:17:53 +09:00
7b9b095090
Move LanguageModelParams class to utility package
...
This change must be checked in together with Ic82d951237.
Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
2014-01-15 16:14:53 +09:00
2d1e72b774
Merge "Revert "Disable Nepali layouts temporarily per product call""
2014-01-15 03:50:58 +00:00
27274601e7
Merge "Revert "Remove Azerbaijani subtype""
2014-01-15 03:32:55 +00:00
4d1620f895
Revert "Disable Nepali layouts temporarily per product call"
...
This reverts Id58cdf117d.
This also partially reverts I99be3d54d3.
This change must be checked in together with Ied923ed80b.
Bug: 6910787
Change-Id: Icdeee1b93a6b626b43fefc06d3bb3fe40d2e056b
2014-01-15 12:31:44 +09:00
7ae9efbb6a
Revert "Remove Azerbaijani subtype"
...
This reverts I0d2a98dffe.
This also partially reverts I99be3d54d3.
This change must be checked in together with Ibf49c89832.
Bug: 7963448
Change-Id: Idbb3e1ac9f4e067a0051f618946a345632102fb3
2014-01-15 12:13:25 +09:00
68069c55c4
Fix flaky unit test.
...
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
2014-01-14 18:51:29 -08:00
4f8e678bab
Revert "Revert "Disable Nepali layouts temporarily per product call""
...
This reverts commit 93fdfc110b
2014-01-14 12:44:11 +00:00
93fdfc110b
Revert "Disable Nepali layouts temporarily per product call"
...
This reverts Id58cdf117d.
This also partially reverts I456268b68f.
This change must be checked in together with I4d5c8ffa45.
Bug: 6910787
Change-Id: I59ba69f1b14164edea8eddf3784554a29a97e9b3
2014-01-14 17:39:24 +09:00
6584d42b02
Merge "Move phrase gesture related string resources to AOSP"
2014-01-14 08:20:14 +00:00
7504913807
Move phrase gesture related string resources to AOSP
...
This change must be checked in together with Ica8fc5135.
Change-Id: I288d7083391954f1266a9b77ee4ffc0bc9d4229d
2014-01-14 17:15:41 +09:00
bf418f7cba
Pass time stamp to addToUserHistory method as an argument
...
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
2014-01-14 15:48:08 +09:00
62df0a6d53
Merge "Update dictionaries"
2014-01-14 03:44:20 +00:00
155cb77231
Update dictionaries
...
This change has no effect on TRT results.
>>> dictionaries/en_US_wordlist.combined.gz
Header :
date : 1381226409 <=> 1389654051
version : 42 <=> 43
Body :
Added: dialogue 120
Added: dialogues 94
>>> dictionaries/fr_wordlist.combined.gz
Header :
date : 1381226409 <=> 1389654052
version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114
>>> dictionaries/it_wordlist.combined.gz
Header :
date : 1380519383 <=> 1389654052
version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180
>>> java/res/raw/main_fr.dict
Header :
date : 1381226409 <=> 1389654052
version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114
>>> java/res/raw/main_it.dict
Header :
date : 1380519383 <=> 1389654052
version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180
Bug: 12487270
Bug: 12344108
Change-Id: I94768e223d05ad2551a5508e9e01222a028665c4
2014-01-14 10:37:15 +09:00
9fa6663403
Import translations. DO NOT MERGE
...
Change-Id: I3233aa7d5f64fbf8818e0065cd1da47d84070fb6
Auto-generated-cl: translation import
2014-01-13 16:31:58 -08:00
5717c63a2b
Fix possible NPE in DictionaryFacilitatorForSuggest.
...
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
2014-01-10 21:42:08 +09:00
db0adf86a4
Merge "[IL55] Remove a useless argument."
2014-01-10 11:36:01 +00:00
eb66f1906d
Merge "Check corpus handles during startup for personalization."
2014-01-10 11:34:39 +00:00
6c24b91601
[IL55] Remove a useless argument.
...
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
2014-01-10 20:28:50 +09:00
eb28bac542
Check corpus handles during startup for personalization.
...
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
2014-01-10 20:28:30 +09:00
4be9137609
Merge "[IL54.5] Use the cursor pos estimate, not the last value"
2014-01-10 10:46:27 +00:00
a224aafea3
[IL54.5] Use the cursor pos estimate, not the last value
...
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.
Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
2014-01-10 19:08:47 +09:00
f96e0f07af
Merge "Periodic wipe of the personalization dict."
2014-01-10 09:31:22 +00:00
ba07df7fc1
Periodic wipe of the personalization dict.
...
Bug: 12216453
Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
2014-01-10 16:30:59 +09:00
ecf46df226
[IL54] Add a mirror method to fix the cursor pos estimate
...
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.
Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
2014-01-10 16:05:02 +09:00
6fbe83be7a
[IL53] Fix a wrong test.
...
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.
When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.
The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.
Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
2014-01-10 15:21:20 +09:00
958e452025
Merge "Fix an NPE."
2014-01-10 05:13:47 +00:00
e1de87ae69
Fix an NPE.
...
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
2014-01-10 13:46:37 +09:00
84a3047e80
Fix build.
...
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
2014-01-10 12:18:26 +09:00
ee35e69eae
Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
...
This change must be checked in together with Iec437d6df0.
Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
2014-01-09 19:05:09 +09:00
494e2d6c17
Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
...
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
d7660c6f56
Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode"
2014-01-09 09:31:32 +00:00
c912b2228a
Merge "Add American typography boolean to SpacingAndPunctuations"
2014-01-09 09:31:24 +00:00
0a75cf51af
Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
...
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
2014-01-09 18:19:17 +09:00
860c3b8e8c
Add American typography boolean to SpacingAndPunctuations
...
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
2014-01-09 18:17:29 +09:00
6c326caa4f
A style fix
...
Just a style fix to follow up the previous commit.
BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
2014-01-09 15:54:47 +09:00
b30f7e4bce
Merge "Check whether the word is OOV or not for amanatto update."
2014-01-09 06:24:17 +00:00
eab4d25210
Merge "Remove some warnings"
2014-01-09 05:45:10 +00:00
c1f2986a72
Merge "Trigger haptic feedback at touch down on the EmojiPalettesView"
2014-01-09 05:19:37 +00:00
b11339b3ab
Remove some warnings
...
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
2014-01-09 14:04:34 +09:00
d3e78fc5ce
Merge "Fix a bug where changing auto-shift would cancel autorepeat."
2014-01-09 04:53:34 +00:00
5cbda70956
Fix a bug where changing auto-shift would cancel autorepeat.
...
Bug: 12453966
Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
2014-01-09 12:57:10 +09:00
df10aeb1da
Trigger haptic feedback at touch down on the EmojiPalettesView
...
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down.
This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts.
This patch set also fixes the missing haptic feedback from facemarks such as ":-)".
Bug: 11439600
Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
2014-01-09 12:27:31 +09:00
941a4540bc
Import translations. DO NOT MERGE
...
Change-Id: Ia2d0f4528529df463307e1706cd4d7265b3958c1
Auto-generated-cl: translation import
2014-01-08 13:45:51 -08:00
05113c1847
Check whether the word is OOV or not for amanatto update.
...
Bug: 11736529
Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
2014-01-08 21:02:35 +09:00
5742a415f3
Merge "Make reloadMainDict() private."
2014-01-08 11:03:02 +00:00
9f1fe87580
Make reloadMainDict() private.
...
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
2014-01-08 18:59:43 +09:00
b90fa0fb2c
Revert "Revert "Separate spacing and punctuation related settings values""
...
This reverts commit 8bc427799a
2014-01-08 18:08:01 +09:00
e5cdcaff65
Fix a race condition, take 2.
...
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.
Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
2014-01-08 18:04:44 +09:00
1e7f2809d2
Merge "Revert "Separate spacing and punctuation related settings values""
2014-01-08 09:03:15 +00:00
8bc427799a
Revert "Separate spacing and punctuation related settings values"
...
This is conflicting with later changes. Temporary revert for cherry-pick.
This reverts commit 0b593ce858
2014-01-08 09:00:45 +00:00
d4843c25e2
Merge "Revert "Fix a race condition, take 2.""
2014-01-08 09:00:18 +00:00
a247264dc6
Revert "Fix a race condition, take 2."
...
Conflicts prevent this to be cherry-picked.
This reverts commit dd3d697a6e
2014-01-08 08:59:26 +00:00
ff7103d356
Merge "Fix a race condition, take 2."
2014-01-08 08:35:24 +00:00
0a0a3cdad8
Merge "Revert "Revert "Fix a race condition."""
2014-01-08 08:35:19 +00:00
dd3d697a6e
Fix a race condition, take 2.
...
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.
Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
2014-01-08 17:19:29 +09:00
f628629f69
Revert "Revert "Fix a race condition.""
...
This reverts commit 3840127244
2014-01-08 16:44:43 +09:00
ad78058a93
Rename InputPointers.addPointer and ResizableIntArray.add
...
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
2014-01-08 14:30:21 +09:00
e13cc9d7e5
Fix ResizableIntArrayTests readability
...
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
2014-01-08 14:30:21 +09:00
9b351f7594
Merge "Fix InputPointersTests"
2014-01-08 05:29:32 +00:00
e7dc5302af
Fix InputPointersTests
...
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.
Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
2014-01-08 14:14:42 +09:00
b3c51630a6
Fix: NPE in LatinIME.loadSettnigs().
...
Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
2014-01-08 12:43:58 +09:00
385031557b
Merge "Separate spacing and punctuation related settings values"
2014-01-08 02:41:51 +00:00
f86b830986
Merge "Prepare using dictionaryFacilitator for amanatto updates."
2014-01-08 02:09:47 +00:00
0b593ce858
Separate spacing and punctuation related settings values
...
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
2014-01-08 10:02:37 +09:00
8bd658555d
Merge "Revert "Fix a race condition.""
2014-01-07 23:57:07 +00:00
3840127244
Revert "Fix a race condition."
...
This reverts commit 42e83c7f06
2014-01-07 23:26:54 +00:00
f2f0640800
Merge "Import translations. DO NOT MERGE"
2014-01-07 18:11:29 +00:00
f75017de55
Import translations. DO NOT MERGE
...
Change-Id: Ia0ef830a5bb3ed6fee1a5d113b2baec60bb51a97
Auto-generated-cl: translation import
2014-01-07 07:27:26 -08:00
8a2537e0ae
Merge "Update personalized dict only when single subtype is used."
2014-01-07 09:19:29 +00:00
c09fd175c3
Prepare using dictionaryFacilitator for amanatto updates.
...
Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
2014-01-07 18:11:23 +09:00
55713e3695
Update personalized dict only when single subtype is used.
...
Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
2014-01-07 18:10:27 +09:00
42e83c7f06
Fix a race condition.
...
Don't use absolute cursor positions, this leads to race
conditions.
Bug: 12390573
Change-Id: I6f04f07a46babbc3d51cb94c7eaee21bed242396
2014-01-07 15:33:04 +09:00
6d5f9fd3d1
Merge "Fix possible NPE."
2014-01-06 09:53:15 +00:00
8214a8c2cf
Fix possible NPE.
...
Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
2014-01-06 17:56:49 +09:00
74b5291b84
Merge "Remove language switch key from symbols and symbols shift keyboard"
2014-01-06 06:19:27 +00:00
d561228f95
Remove language switch key from symbols and symbols shift keyboard
...
This change also fixes the background color of the left keys of the space key.
Bug: 12407208
Change-Id: Id869605146e9f72835f892c3c7ae14f118177394
2014-01-06 15:02:50 +09:00
3f8c6b8c54
Merge "Add description of disabled voice input key option"
2014-01-06 03:25:15 +00:00
12ba821bfb
Add description of disabled voice input key option
...
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
2014-01-06 12:11:55 +09:00
e91559a119
Merge "Update shortcut IME info before checking availability of it"
2014-01-06 03:07:23 +00:00
e9584a1612
Merge "Add DictionaryFacilitatorForSuggest constructor for testing"
2014-01-06 02:58:12 +00:00
b7c531b751
Update shortcut IME info before checking availability of it
...
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
2014-01-06 11:54:46 +09:00
49b5fadae1
Add DictionaryFacilitatorForSuggest constructor for testing
...
This change must be checked in together with I00b6e79d6b.
Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
2014-01-06 11:00:51 +09:00
1e50c681af
[IL52] Remove a useless method.
...
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.
Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.
Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
2013-12-27 22:40:19 +09:00
8ce921dd6b
[IL51] Make private what can be made private
...
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
2013-12-27 21:09:47 +09:00
53c320e275
[IL50] Move the InputUpdater out of LatinIME.
...
...at last
Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
2013-12-27 21:09:41 +09:00
81e0ca5fd3
[IL49] Move InputLogic-related init code to InputLogic.
...
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
2013-12-27 20:06:39 +09:00
4970eda286
Fix a failing test
...
How/when did this happen? How was it not noticed?
Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
2013-12-27 20:04:41 +09:00
d05ea8bd82
Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic."
2013-12-27 08:06:48 +00:00
af26a44102
Merge "[IL47] Inline getSuggestedWordsGestureLocked"
2013-12-27 08:04:51 +00:00
51e79fb4b2
Merge "[IL46] Remove a useless message passing."
2013-12-27 07:56:56 +00:00
2fc1cc099f
Merge "[IL45] Remove lingering messages"
2013-12-27 07:56:44 +00:00
c654fe57b1
[IL48] Move onEndBatchInputAsyncInternal to InputLogic.
...
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
2013-12-27 16:50:08 +09:00
4a144b9b4d
[IL47] Inline getSuggestedWordsGestureLocked
...
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.
Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
2013-12-27 16:50:08 +09:00
71a3e96382
[IL46] Remove a useless message passing.
...
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords
The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.
Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
2013-12-27 16:50:06 +09:00
0d21223521
Merge "[IL44] Some factorization"
2013-12-27 06:58:12 +00:00
31ff2a4335
[IL45] Remove lingering messages
...
Bug: 8636060
And possibly bug: 12085864
Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
2013-12-27 15:34:30 +09:00
69e7a0d24d
[IL44] Some factorization
...
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.
Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
2013-12-27 15:34:26 +09:00
c197b9ed90
Merge "Make setAdditionalDictionaries private."
2013-12-27 06:22:18 +00:00
86da47e8d7
Fix possible NPE in FileUtils.
...
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
2013-12-27 14:58:38 +09:00
abc3d0eb56
Make setAdditionalDictionaries private.
...
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
2013-12-27 14:49:32 +09:00
6bca9ac43d
Fix a bug where predictions would not pop upon manual pick
...
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
2013-12-26 23:19:29 +09:00
33b2aaafc2
Merge "Fix a code path that looks ridiculous"
2013-12-26 13:39:21 +00:00
f294ed3308
Fix a code path that looks ridiculous
...
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
2013-12-26 22:28:16 +09:00
f441047fad
[IL43] Small cleanup
...
All calls are already passing this
Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
2013-12-26 22:12:24 +09:00
c28f02880c
[IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
...
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
2013-12-26 22:12:22 +09:00
70433efc41
[IL41] Remove a useless call and trampoline.
...
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.
Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
2013-12-26 21:58:41 +09:00
be147f1fdc
Remove DictionaryFacilitatorForSuggest.getMainDictionary().
...
Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
2013-12-26 20:48:19 +09:00
a374482719
Extract dict operations from Suggest to a new class.
...
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
2013-12-26 20:48:19 +09:00
5c45ff1214
[IL39] Change a test.
...
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.
Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
2013-12-26 18:44:17 +09:00
98140faac3
[IL38] Fix a wrong double call
...
This only gives bad results if a gesture results in only one suggestion.
Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
2013-12-26 18:43:47 +09:00
65e3ae6f15
Merge "Remove useless method call for spell checker."
2013-12-26 06:42:51 +00:00
7987afbea4
Remove useless method call for spell checker.
...
Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
2013-12-26 14:51:05 +09:00
3fbcf48591
Merge "Add BatchInputArbiter"
2013-12-26 05:50:07 +00:00
4a4b6d42a7
Add BatchInputArbiter
...
Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.
This change must be checked in together with Ia7db8f4fb7.
Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
2013-12-26 14:09:57 +09:00
30a72da42c
[IL37] Small simplification
...
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
2013-12-26 13:51:09 +09:00
c08119e5c1
[IL36] Inline setAutoCorrection
...
There are far too many one-use methods.
Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
2013-12-26 13:18:36 +09:00
52a2682b99
[IL35] Preparative cleanup
...
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
2013-12-25 22:25:49 +09:00
0154609a2e
Merge "[IL34] Introduce InputLogicHandler"
2013-12-25 13:21:54 +00:00
5c4bd20331
Remove "Boost personalization dictionary" from settings.
...
Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
2013-12-25 19:02:49 +09:00
bb39518bd7
Use SettingsValues instead of Settings in Suggest.
...
Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
2013-12-25 18:53:04 +09:00
d99d225f10
Merge "Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints"
2013-12-25 06:58:08 +00:00
eea7122e5b
Move dict operations to Suggest.
...
Bug: 8187060
Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
2013-12-25 15:26:50 +09:00
c3fe1425a5
Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints
...
This change must be checked in together with Ibed5330614.
Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace
2013-12-25 15:19:00 +09:00
621dcbc31c
[IL34] Introduce InputLogicHandler
...
Bug: 8636060
Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f
2013-12-25 14:20:19 +09:00
605caf1b5f
Fix NPE in SettingsValues.
...
Change-Id: I96fc381d2b45881aeb342d33207cd7fe82f5077c
2013-12-25 14:00:16 +09:00
a801c8fd9b
Merge "Rename gesture related classes"
2013-12-25 04:04:05 +00:00
e2a6253cb5
Rename gesture related classes
...
Change-Id: I5cb03576bb7221f1864e157857d872880a0a58f8
2013-12-25 11:52:54 +09:00
f1457e7a22
Remove personalized dicts when the option is turned off.
...
Bug: 11757851
Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f
2013-12-25 11:44:16 +09:00
afca1ddd23
Comprehensive memory deallocation
...
Change-Id: I4673543c96eb342c3c977e00d44772a0d719a23e
2013-12-24 18:26:55 +09:00
cf915ddc87
Rename classes related to AbstractDrawingPreview
...
Change-Id: Ife2e2c08b2b6fbf9ec33cf259f276878816b291c
2013-12-24 18:17:00 +09:00
e82200787c
Separate GestureStrokePreviewParams to top level class
...
Change-Id: I4c6ac12dac9636760128625bb5b7138b7d56f3d1
2013-12-24 17:27:15 +09:00
dc2ce72555
Merge "Make GestureStrokeParams as a top level class"
2013-12-24 06:40:29 +00:00
c845d4c664
Make GestureStrokeParams as a top level class
...
Change-Id: I540a2d3a6c6ce6ecdcccecd38df6b3c23fcf8d95
2013-12-24 15:29:10 +09:00
036930e80d
Merge "[IL33] Opportunistically remove some KeyboardSwitcher"
2013-12-24 06:28:54 +00:00
8476c2e788
[IL33] Opportunistically remove some KeyboardSwitcher
...
Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
2013-12-24 15:11:35 +09:00
904866c701
Clean up batch input related code a bit
...
Change-Id: I3b6a95fdb82bd15e2b636b1374a96d8987d5d8cf
2013-12-24 14:24:27 +09:00
aa7a68a3e0
Remove duplicate code
...
Change-Id: Ia33ea2dc4bb063ec5bf282c656ccc1f11ac967fe
2013-12-24 12:39:16 +09:00
07f7536b04
[IL32] Remove a useless variable
...
Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c
2013-12-20 21:34:07 +09:00
1587be6977
[IL31] Move *BatchInput to InputLogic
...
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
2013-12-20 21:24:27 +09:00
059f4c2f39
[IL30] Minor refactoring
...
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
2013-12-20 20:47:44 +09:00
0547b33130
[IL29] Move retryResetCaches and tryFixLyingCursorPosition
...
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
2013-12-20 20:47:29 +09:00
81e8d16031
[IL28] Remove useless code
...
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.
Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
2013-12-20 19:48:05 +09:00
55ce2cc2d5
[IL27] Some refactoring
...
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
2013-12-20 19:24:38 +09:00
221df9e59a
[IL26] Move restartSuggestionsOnWordTouchedByCursor
...
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
2013-12-20 19:09:36 +09:00
ec4b6e7bb3
[IL25] Inline handleClose
...
Only ever used here.
Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
2013-12-20 18:44:13 +09:00
aa161eb371
[IL24] Move mDisplayOrientation to SettingsValues.
...
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
2013-12-20 18:44:09 +09:00
a22a63f3b1
Merge "Fix an NPE"
2013-12-20 09:14:56 +00:00
92392b21f2
Fix an NPE
...
Change-Id: I6307c1545d9d48cdea66d08f8efc1b7fbb08ee42
2013-12-20 18:13:23 +09:00
f405c58c09
Merge "Use config_screen_metrics resource in BogusMoveEventDetector"
2013-12-20 09:03:25 +00:00
9c4de1e5f7
Use config_screen_metrics resource in BogusMoveEventDetector
...
Change-Id: I6b957b43c6dd7ce4f639e46d248179662c1ee669
2013-12-20 17:35:19 +09:00
1252333efd
Merge "[IL23] Resolve a long-standing TODO."
2013-12-20 08:29:29 +00:00
Yohei Yukawa
Jean Chalard
Tadashi G. Takaoka
Baligh Uddin
Ken Wakasa
Keisuke Kuroyanagi
Geoff Mendal
Narayan Kamath
Victoria Lease