Tadashi G. Takaoka
aa7a68a3e0
Remove duplicate code
...
Change-Id: Ia33ea2dc4bb063ec5bf282c656ccc1f11ac967fe
2013-12-24 12:39:16 +09:00
Jean Chalard
07f7536b04
[IL32] Remove a useless variable
...
Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c
2013-12-20 21:34:07 +09:00
Jean Chalard
1587be6977
[IL31] Move *BatchInput to InputLogic
...
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
2013-12-20 21:24:27 +09:00
Jean Chalard
059f4c2f39
[IL30] Minor refactoring
...
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
2013-12-20 20:47:44 +09:00
Jean Chalard
0547b33130
[IL29] Move retryResetCaches and tryFixLyingCursorPosition
...
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
2013-12-20 20:47:29 +09:00
Jean Chalard
81e8d16031
[IL28] Remove useless code
...
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.
Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
2013-12-20 19:48:05 +09:00
Jean Chalard
55ce2cc2d5
[IL27] Some refactoring
...
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
2013-12-20 19:24:38 +09:00
Jean Chalard
221df9e59a
[IL26] Move restartSuggestionsOnWordTouchedByCursor
...
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
2013-12-20 19:09:36 +09:00
Jean Chalard
ec4b6e7bb3
[IL25] Inline handleClose
...
Only ever used here.
Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
2013-12-20 18:44:13 +09:00
Jean Chalard
aa161eb371
[IL24] Move mDisplayOrientation to SettingsValues.
...
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
2013-12-20 18:44:09 +09:00
Jean Chalard
a22a63f3b1
Merge "Fix an NPE"
2013-12-20 09:14:56 +00:00
Jean Chalard
92392b21f2
Fix an NPE
...
Change-Id: I6307c1545d9d48cdea66d08f8efc1b7fbb08ee42
2013-12-20 18:13:23 +09:00
Tadashi G. Takaoka
f405c58c09
Merge "Use config_screen_metrics resource in BogusMoveEventDetector"
2013-12-20 09:03:25 +00:00
Tadashi G. Takaoka
9c4de1e5f7
Use config_screen_metrics resource in BogusMoveEventDetector
...
Change-Id: I6b957b43c6dd7ce4f639e46d248179662c1ee669
2013-12-20 17:35:19 +09:00
Jean Chalard
1252333efd
Merge "[IL23] Resolve a long-standing TODO."
2013-12-20 08:29:29 +00:00
Tadashi G. Takaoka
0c8ea69cad
Merge "Separate logic of enabling gesture typing"
2013-12-20 08:03:18 +00:00
Jean Chalard
84e78cb769
Merge "[IL22] Move onTextInput to InputLogic."
2013-12-20 08:02:36 +00:00
Jean Chalard
689cff2e3b
Merge "[IL21] Move the workaround utils to a better place."
2013-12-20 08:02:07 +00:00
Jean Chalard
6cf843cba6
[IL23] Resolve a long-standing TODO.
...
Bug: 8636060
Change-Id: I3a840c30cc4489debf9118beeec448488503bc1c
2013-12-20 16:50:14 +09:00
Jean Chalard
11730aa224
[IL22] Move onTextInput to InputLogic.
...
Also pull the TLD specific processing
Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
2013-12-20 16:50:14 +09:00
Jean Chalard
1404c1af85
[IL21] Move the workaround utils to a better place.
...
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
2013-12-20 16:48:54 +09:00
Tadashi G. Takaoka
a00838b6e8
Separate logic of enabling gesture typing
...
Change-Id: I91fc566f24a38a55d2352201d5d581d3fa02a428
2013-12-20 16:37:17 +09:00
Tadashi G. Takaoka
db6d9b0ab4
Merge "Separate BogusMoveEventDetector class"
2013-12-20 07:36:07 +00:00
Tadashi G. Takaoka
c986d16e8a
Separate BogusMoveEventDetector class
...
Change-Id: I24f0ff385f338ff313ef32514f2930f120183be7
2013-12-20 16:17:41 +09:00
Tadashi G. Takaoka
9033fb1f64
Merge "Separate TypingTimeRecorder class"
2013-12-20 07:16:34 +00:00
Tadashi G. Takaoka
5045103d61
Separate TypingTimeRecorder class
...
Change-Id: Ic56d3e3a1be935854dcace36d8a05a9d2619dab9
2013-12-20 16:14:26 +09:00
Jean Chalard
529cdf0a0c
Merge "[IL20] Remove some useless processing."
2013-12-20 07:14:09 +00:00
Jean Chalard
95d869fed4
Merge "[IL19] Resolve a TODO."
2013-12-20 07:11:24 +00:00
Jean Chalard
8a390023e1
[IL20] Remove some useless processing.
...
If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.
Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
2013-12-20 16:02:07 +09:00
Jean Chalard
4487a30e0d
[IL19] Resolve a TODO.
...
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
2013-12-20 16:02:03 +09:00
Jean Chalard
f7d493979a
Merge "[IL18] Move and rename updateSuggestionStrip"
2013-12-20 06:54:33 +00:00
Jean Chalard
2a6de7903c
[IL18] Move and rename updateSuggestionStrip
...
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
2013-12-20 15:46:34 +09:00
Tadashi G. Takaoka
921a32f0a9
Remove unnecessary default KeyDetector from PointerTracker
...
Change-Id: Ib0fbb40a7040202d2a4b4ab49319d9e247a2a6ce
2013-12-20 15:34:54 +09:00
Tadashi G. Takaoka
dbb88e47c8
Merge "Remove unused default object of GestureStrokePreviewParams"
2013-12-20 06:33:36 +00:00
Tadashi G. Takaoka
081989ca30
Remove unused default object of GestureStrokePreviewParams
...
This change also fixes build broken by Id615556766.
Change-Id: I16605cc3b65e3e9ab2d5a498825c31d9b4046b73
2013-12-20 15:25:24 +09:00
Jean Chalard
1c0374da49
[IL17] Move commitChosenWord to InputLogic.
...
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.
Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
2013-12-20 15:13:48 +09:00
Jean Chalard
a905fcec00
[IL16] Improve getTextWithSuggestionSpan
...
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.
Not directly related, but helpful with:
Bug: 8636060
Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
2013-12-20 15:13:48 +09:00
Tadashi G. Takaoka
6e97efef78
Fix rugged gesture trail
...
Bug: 12222472
Change-Id: Id615556766718a8bd4848f7026833fbcea540c39
2013-12-20 14:40:18 +09:00
Tadashi G. Takaoka
ce9c7d7511
Merge "Remove PointerTracker reference from accessibility package"
2013-12-20 03:33:24 +00:00
Tadashi G. Takaoka
6a23b9e3d5
Remove PointerTracker reference from accessibility package
...
Change-Id: I1a88d9fc4db437070778ea1256aae17c32428729
2013-12-20 12:29:25 +09:00
Jean Chalard
5c9e677c2a
[IL15] Some small refactoring
...
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
2013-12-20 11:24:45 +09:00
Jean Chalard
48ba1f25ff
[IL14] Move getCurrent*Caps* to InputLogic
...
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
2013-12-20 11:24:42 +09:00
Jean Chalard
cdd8a1a69d
[IL13] Inline restartSuggestionsOnWordBeforeCursor
...
It's only ever used in one place and makes unhealthy assumptions
about what the caller is doing. It's better inlined.
Bug: 8636060
Change-Id: I265d5d96894e929d09247ee2e3dc2e81efc2a276
2013-12-19 20:31:52 +09:00
Jean Chalard
bbe40835a9
[IL12] move restartSuggestions* to InputLogic
...
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
2013-12-19 20:30:41 +09:00
Jean Chalard
10755af97b
[IL11] Cleanup
...
Make some methods private and add comments.
Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
2013-12-19 20:13:14 +09:00
Jean Chalard
060e292628
[IL10] Move revertCommit to InputLogic
...
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
2013-12-19 19:30:26 +09:00
Jean Chalard
69a57bcdcd
[IL9] Move commitCurrentAutoCorrection to InputLogic
...
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
2013-12-19 19:30:20 +09:00
Jean Chalard
035e3885ac
[IL8] Move handleNonSeparator to InputLogic
...
Also move getActualCapsMode and getNthPreviousWordForSuggestion
Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
2013-12-19 18:32:51 +09:00
Jean Chalard
d85e49bf8c
[IL7] Move performRecapitalization to InputLogic
...
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
2013-12-19 18:20:41 +09:00
Jean Chalard
40b42b7d84
[IL6] Move handleSeparator to InputLogic
...
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod
Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
2013-12-19 17:39:01 +09:00
Jean Chalard
c8dfaab783
[IL5] Some renaming
...
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
2013-12-19 17:38:55 +09:00
Jean Chalard
37d3f1bd02
[IL4] Move handleNonSpecialCharacter to InputLogic.
...
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
2013-12-19 16:46:57 +09:00
Jean Chalard
0e82fa273d
[IL3] Move handleBackspace to InputLogic.
...
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline
Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
2013-12-19 16:46:54 +09:00
Jean Chalard
cddf4f9d78
[IL2] Move onCodeInput to InputLogic.
...
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
2013-12-19 16:24:45 +09:00
Jean Chalard
7bd2a75ca1
Start separating the input logic from LatinIME.
...
Create an InputEngine class and start moving the relevant
variables to it.
Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
2013-12-19 14:48:43 +09:00
Jean Chalard
dfbe2bfe08
Add some info to test crashes to help diagnose flakiness
...
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
2013-12-18 18:10:56 +09:00
Keisuke Kuroyanagi
1f5a3faf76
Merge "Enable Personalized dictionaries based on the setting."
2013-12-17 10:40:29 +00:00
Keisuke Kuroyanagi
8732f9c5f9
Enable Personalized dictionaries based on the setting.
...
Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7
2013-12-17 19:36:19 +09:00
Jean Chalard
4196360912
Run GC when needed, instead of too late.
...
Bug: 12164855
Change-Id: Ie4d8be9f2652b01470bcc06911e2191e09fb3149
2013-12-17 18:08:48 +09:00
Jean Chalard
97a553ae69
Fix wrong dereference reading code.
...
Bug: 12164855
Change-Id: I26faf27edfa303510197bccaa3521578f649741d
2013-12-17 16:42:22 +09:00
Keisuke Kuroyanagi
b54c747d7c
Merge "Move DictUpdater to the tests directory."
2013-12-17 05:33:16 +00:00
Keisuke Kuroyanagi
4fdcefe504
Move DictUpdater to the tests directory.
...
Bug: 11245133
Change-Id: I0907a091ac3ae960eaf3b27da78dbb48a24b2ea1
2013-12-17 14:31:25 +09:00
Tadashi G. Takaoka
19dd753c0c
Cancel more suggestions panel when touching keyboard
...
Bug: 10010128
Change-Id: I2ff0870c69f407d943caf8b9cec90b7ed89de5f1
2013-12-17 12:59:37 +09:00
Tadashi G. Takaoka
dd4937848a
Fix typo in varibale name
...
Change-Id: I7ea6c59b7c980e93c88a6cf0fef97592d411c3ba
2013-12-17 12:15:02 +09:00
Tadashi G. Takaoka
fcacde3dad
Revise Armenian punctuations more keys
...
Bug: 12096943
Change-Id: Ib8559f030fbc27ec7f7e9a9fb36aad72cca29e9f
2013-12-17 11:12:33 +09:00
Tadashi G. Takaoka
3aeb6a9d0d
Merge "Refactor touch event forwarding in InputView"
2013-12-17 02:04:40 +00:00
Tadashi G. Takaoka
27fab2cc2a
Refactor touch event forwarding in InputView
...
Bug: 10010128
Change-Id: I82aa4ce847e66cb1241678f39b47b9e27a0f555a
2013-12-17 08:49:50 +09:00
Jean Chalard
0c7b05fc50
Merge "Fix a bug with languages without spaces and predictions"
2013-12-16 14:17:51 +00:00
Jean Chalard
7cd7cf73f4
Fix a bug with languages without spaces and predictions
...
This is simpler and more correct.
Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
2013-12-16 23:16:02 +09:00
Keisuke Kuroyanagi
e17cc8270f
Merge "Increment version number of ver4 format to 401."
2013-12-16 14:13:42 +00:00
Keisuke Kuroyanagi
b5215d456a
Increment version number of ver4 format to 401.
...
Bug: 11073222
Change-Id: I3878aef02040b1ef73165645fc70ede586289c51
2013-12-16 23:02:54 +09:00
Keisuke Kuroyanagi
214a3b741f
Merge "Fix: incompatible PtNode array size reading."
2013-12-16 13:57:55 +00:00
Keisuke Kuroyanagi
56e7e38d37
Fix: incompatible PtNode array size reading.
...
Bug: 11073222
Change-Id: I681be725b5c6dcc10aa536b00327698a7df75277
2013-12-16 22:42:01 +09:00
Jean Chalard
dc06ee85ef
A simplification.
...
This does the same thing, but simpler and faster.
Was noticed while investigating bug#12164555
Change-Id: If9926e4da8a53a65489da55197ac87122c44fe7c
2013-12-16 21:38:31 +09:00
Keisuke Kuroyanagi
769eb083ef
Merge "Add option to enable personalization dictionaries."
2013-12-16 10:33:40 +00:00
Keisuke Kuroyanagi
d4bb7df412
Add option to enable personalization dictionaries.
...
Bug: 11757851
Change-Id: I4872c10793d4fd55c0bd9e5bc4650925de6d2c1d
2013-12-16 19:17:31 +09:00
Tadashi G. Takaoka
f3b92fb952
Merge "Fix IllegalStateException of ViewGroup"
2013-12-16 08:36:45 +00:00
Tadashi G. Takaoka
7f8345d59a
Fix IllegalStateException of ViewGroup
...
Bug: 10629042
Change-Id: I111d092fb2f7dca47328127a155c981aa1c55906
2013-12-16 17:06:23 +09:00
Keisuke Kuroyanagi
b6a19229ba
Merge "Make required binary dictionary version use FormatSpec.*"
2013-12-16 07:56:58 +00:00
Keisuke Kuroyanagi
c837767819
Make required binary dictionary version use FormatSpec.*
...
Change-Id: Ifb17d6551bc5071553e32a5640dd166c39374461
2013-12-16 16:50:28 +09:00
Jean Chalard
5590e9d040
Merge "Make the bad header a checked exception and fix dicttool test"
2013-12-16 07:18:44 +00:00
Jean Chalard
3df617323e
Make the bad header a checked exception and fix dicttool test
...
Change-Id: If780a2a1cb722aee83d910904c0a6315add9552d
2013-12-16 15:40:45 +09:00
Tadashi G. Takaoka
1b5b0a3ebc
Cancel long press shift key while chording input
...
Bug: 12123508
Change-Id: I693caad1f8ee47ebeb14419603d1fc29f6263a75
2013-12-16 15:30:41 +09:00
Jean Chalard
b868375763
Fix failing tests
...
- Version 3 is not supported
- Now passing the right string to open v4 dicts. Fix the tests for this.
Change-Id: I7829330c3568a715b96396ba4e4e69c6e17775ab
2013-12-16 14:32:19 +09:00
Ken Wakasa
2c25c7c9e1
Fix locale names in the make-keyboard-text tool
...
Change-Id: I33c3fafcff124bb94e395cc604ce264daad55d2d
2013-12-14 18:50:57 +09:00
Jean Chalard
330d2720bb
Instead of ignoring PARAGRAPH spans, fix them.
...
I don't know what or when this flag is set, but it's only bad
news. Luckily, we can just remove it.
Bug: 12119393
Change-Id: I2952138c8ce517535b91e0fe25d2cf4960e02862
2013-12-13 23:42:31 +09:00
Jean Chalard
7a904514fb
Merge "Don't use the previous word after a non-whitespace separator"
2013-12-13 11:53:30 +00:00
Jean Chalard
0b51fac907
Merge "Only update shift state if left in auto mode."
2013-12-13 11:52:13 +00:00
Jean Chalard
fae1ba767c
Don't use the previous word after a non-whitespace separator
...
Bug: 12101276
Change-Id: Icf36d55ec171194e5561b946021bcf648782ddd4
2013-12-13 20:51:28 +09:00
Jean Chalard
28bd6e2297
Only update shift state if left in auto mode.
...
Bug: 12100417
Change-Id: I7bc2b19332e142a257b0399f2e5d128caf01fc7c
2013-12-13 20:47:25 +09:00
Jean Chalard
f3d281b775
Merge "Fix a bug where recapitalize prevents going to more syms"
2013-12-13 10:38:18 +00:00
Jean Chalard
5d98e1d82e
Fix a bug where recapitalize prevents going to more syms
...
Bug: 11004973
Change-Id: I97ee9df6e8464e2149beb41c688cbfbd83ac3d8c
2013-12-13 19:21:49 +09:00
Jean Chalard
f08b1ea41a
Merge "Remove references to the v3 dictionary."
2013-12-13 10:08:12 +00:00
Tadashi G. Takaoka
bf7503ae6b
Merge "Fix key top letter color in shifted layout"
2013-12-13 09:55:19 +00:00
Jean Chalard
1dc7eca114
Remove references to the v3 dictionary.
...
Change-Id: I811c8c923ad67a6d9bfdd11bdef8991eb7135c27
2013-12-13 18:53:41 +09:00
Keisuke Kuroyanagi
3e81d9c39f
Merge "Remove code for forgetting curve in Java side."
2013-12-13 09:44:16 +00:00
Keisuke Kuroyanagi
cc8c544ee2
Remove code for forgetting curve in Java side.
...
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
2013-12-13 18:40:58 +09:00
Tadashi G. Takaoka
815a339201
Fix key top letter color in shifted layout
...
There is a chance to have an empty hint label even though
keyLabelFlags has hasShiftedLetterHint flag.
Change-Id: I63b9fcc42a40391d5902814cae4c75abb61e4b94
2013-12-13 18:34:30 +09:00
Jean Chalard
a245d15da5
Have dicttool use the native library to generate v4 dicts.
...
Yay !
Change-Id: Iea8ced9e81031b9ab7eff05ad9ef7215be248de9
2013-12-13 18:18:20 +09:00
Jean Chalard
af0c222a5e
Merge "Remove flags from Java side."
2013-12-13 09:17:10 +00:00