Commit Graph

32018 Commits (464ff7c131b097e1320a6d7b9207ccbf3eb70d22)

Author SHA1 Message Date
Tadashi G. Takaoka 464ff7c131 Add unit tests for enter key's more keys
Bug: 15681452
Change-Id: I3070c46bb2c0cb8ccaae66eaea132b41c567e135
2014-09-04 00:18:14 +09:00
Tadashi G. Takaoka e8e0821306 Merge "Add shared abstract test class for action label test" into lmp-dev 2014-09-03 15:06:47 +00:00
Tadashi G. Takaoka cd6f5ae566 Add shared abstract test class for action label test
Bug: 15681452
Change-Id: I0ad21e6979aed1b5c8c210399c4edfd5993adbdc
2014-09-03 23:55:36 +09:00
Tadashi G. Takaoka cc5050d7ca Update spacebar background for Material
Bug: 17318036
Change-Id: Iaa091b525433d56db9aca9e0301f3727ce392605
2014-09-03 14:39:13 +00:00
Tadashi G. Takaoka 1c2cf71921 Add new value "spacebar" to Key.backgroundType attribute
Bug: 17318036
Change-Id: Ie84438a6aa3adc14a9db603d0cd4d5e37a55d612
2014-09-03 23:37:03 +09:00
Tadashi G. Takaoka 5a9c9649db Removes "customAction" value from Key.backgroundType attribute
Bug: 17318036
Change-Id: I6a36d50ba2e69eafbb0faa049014281bd4d4ddfc
2014-09-03 23:35:39 +09:00
Tadashi G. Takaoka 0af2472a69 Add new "keyboardTheme" <case> predicator
Bug: 17318036
Change-Id: Ief386c84969d8646fb5cfe2050a2f59a7db16c88
2014-09-03 23:26:46 +09:00
Yohei Yukawa 310da35c77 Merge "Follow up API signature change" into lmp-dev 2014-09-03 09:42:11 +00:00
Yohei Yukawa 5d6ac77732 Follow up API signature change
This is a follow up CL for API signature change in
I772c48ff18918e48a81e807b48ff907614485c09

BUG: 17320996
Change-Id: Ic8b6162bda12bf74fae79af212c5d81c400eb9e8
2014-09-03 01:13:15 -07:00
Tadashi G. Takaoka ca70bd5f3a Fix depedency of debug settings
This is a follow of the I26e4d292de.

Bug: 15678343
Change-Id: I364d6df386cf32102e4ebb0151d18e49dcc5bd2c
2014-09-03 05:05:07 +00:00
Yohei Yukawa 8c42bf54af Follow API signature change in CursorAnchorInfo
This is just a follow up CL for Ia8cbb9f6b41cd9509fc0147fd68763df.
No behavial change is intended.

BUG: 17200900
Change-Id: Iba23b731ebde64ec2e816c5b4bef1d93632fce1e
2014-09-02 16:29:35 -07:00
Yohei Yukawa 6ef88a65a2 Merge "Use right arrow for the commit indicator" into lmp-dev 2014-09-02 18:30:15 +00:00
Tadashi G. Takaoka afa9d6d8de Merge "Add theme aware key popup preview animation" into lmp-dev 2014-09-02 12:17:57 +00:00
Tadashi G. Takaoka ac88f3d845 Add theme aware key popup preview animation
Bug: 15678343
Change-Id: I26e4d292deab37724387cc9ebc03033fcd698c60
2014-09-02 18:45:23 +09:00
Tadashi G. Takaoka f4383ed3a2 Fix missing Material light more keys' background
Bug: 15782668
Change-Id: I8b59d8a4dabe03418e520c18d5d64e2d10f4cae2
2014-09-02 10:59:23 +09:00
Yohei Yukawa 2412d9ae3c Use right arrow for the commit indicator
Change-Id: I5074acd2eec451f77b47378bf9a5f7a14c792ce6
2014-08-29 22:29:25 -07:00
Yohei Yukawa ee0d8077d6 Show the commit indicator only for word to be auto-corrected
Change-Id: I61e25b960ae083857efc2704498a0761e0965ad3
2014-08-29 17:31:36 -07:00
Tadashi G. Takaoka c471012483 Merge "Fix the order of keys on more keys keyboard" into lmp-dev 2014-08-29 09:58:28 +00:00
Tadashi G. Takaoka f507d1febb Support RTL layout in custom input style settings
Bug: 17322353
Change-Id: I3b211ab8729121271563a8a243558a58ee7847c2
2014-08-29 18:28:53 +09:00
Jean Chalard 4e28a6a844 Fix an IOOB exception
Bug: 17316001
Change-Id: Iaa2cfd30ebbe0d49e10a5c3a30336e06817d0a8b
2014-08-29 06:56:34 +00:00
Tadashi G. Takaoka a9fc8622fe Fix the order of keys on more keys keyboard
This CL fixes the behavior of !autoColumnOrder!<n> flag in a more keys
specification. Formerly the <n> value specifies the maximum number of
column of more keys. With this CL, the <n> value specifies the exact
number of column of more keys.

Bug: 16603887
Change-Id: I2120620fa512ee30043bb146ad675a942a375129
2014-08-29 11:06:20 +09:00
Tadashi G. Takaoka f2eadbb497 Clear keyboard cache when system locale is changed
Bug: 17310080
Change-Id: I2b388772f269f1e7610a5bd32de80793da2df16e
2014-08-28 22:50:07 +09:00
Jean Chalard 6bd267f4f7 Merge "Add new attributes to our notification" into lmp-dev 2014-08-28 09:22:19 +00:00
Tadashi G. Takaoka 5f19606d54 Add action label tests in other locale than subtype's
This unit test can catch the bug: 17310080.

Bug: 17310080
Change-Id: I931561217647fd558929b954ee1ef58c1d49df07
2014-08-28 17:36:26 +09:00
Jean Chalard a2928484f6 Add new attributes to our notification
Bug: 17167221
Bug: 17128331
Change-Id: I6a045fd2398f40dbdc10c9d20993f7513e1f2cff
2014-08-28 07:47:07 +00:00
Yohei Yukawa acce1aa59e Make sure to obtain the IC before requesting CursorAnchorInfo
RichInputConnection#requestUpdateCursorAnchorInfo must make
sure to obtain the input connection before calling methods
of it.

BUG: 17299587
Change-Id: I8e0cd473a4cc32583cd47634c227d702f7c69c6c
2014-08-27 15:59:52 -07:00
Tadashi G. Takaoka 37beaf1529 Simplify onComputeInsets of LatinIME
This CL expands SoftInputWindow to the entire screen. Thus a key
review backing view is eliminated and onComputeInsets() gets
simplified too.

Bug: 17212702
Bug: 10841052
Bug: 10541453
Change-Id: I2d859f4e4698c64cabe399000821f13bab729996
2014-08-27 19:20:38 +09:00
Yohei Yukawa 97681ebdf1 Set highlight color along with the commit indicator
With this CL, the text highlight color is applied
when the commit indicator is displayed.

Note that the underline is not rendered when the
background color is enabled. This is a known issue.

Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
2014-08-27 01:41:16 -07:00
Yohei Yukawa 29200b0abe Set the text bgcolor only when CursorAnchorInfo is available
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.

With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not.  This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.

Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
2014-08-27 01:30:45 -07:00
Yohei Yukawa a475c85480 Introduce a mechanism to hide the indicator speculatively
This is an optional optimization to reduce the UI latency.

Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.

If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.

This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.

Change-Id: Id59c6607a1029782410611e768791af9984f14ac
2014-08-26 23:42:53 -07:00
Yohei Yukawa bea17c49ec Introduce commit/add-to-dictionary indicators
This CL introduces commit/add-to-dictionary indicators.

Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.

Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
2014-08-26 21:20:27 -07:00
Jean Chalard 8380f921f7 Fix a bug where the top prediction would disappear.
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.

Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
Yohei Yukawa fdfe73ff1f Merge "Use more descriptive names for some internal fields" into lmp-dev 2014-08-25 09:50:59 +00:00
Yohei Yukawa a61b7245b0 Use more descriptive names for some internal fields
This CL clarifies that delay parameters are specified with
milliseconds.

Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
2014-08-25 02:28:01 -07:00
Tadashi G. Takaoka 19dd34a023 Show view even when IME is explicitly shown with physical keyboard
Bug: 17242477
Bug: 13988700
Change-Id: I519c0481760a9aa93a5d9bee68e0f6a3a8fc4d9d
2014-08-25 16:28:44 +09:00
Tadashi G. Takaoka f145fff085 Merge "Fix NPE when pressing ALT key" into lmp-dev 2014-08-25 06:52:36 +00:00
Tadashi G. Takaoka ad1f880811 Fix NPE when pressing ALT key
Bug: 17203708
Change-Id: I4f203603496e9401dacba4db21372e3353916418
2014-08-25 15:08:27 +09:00
Yohei Yukawa 8681287cd6 Fix build due to an illegal character
Change-Id: I597ab26db70387b80ddcd7d51de6ae751380030d
2014-08-24 21:14:41 -07:00
Yohei Yukawa 5eebaddccb Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev 2014-08-25 04:08:56 +00:00
Yohei Yukawa 2c4cce8d6c Merge "Introduce #shouldShowAddToDictionaryHint" into lmp-dev 2014-08-25 04:05:56 +00:00
Yohei Yukawa ebc1509039 Introduce #shouldShowAddToDictionaryHint
This is a groundwork for subsequent CLs where we need to
call this method from multiple places. This CL does not
change any existing behaviors.

Change-Id: Id8fa0360305d7383571edffab6752b2240367cf9
2014-08-24 20:59:30 -07:00
Tadashi G. Takaoka 5e7a6fe098 Merge "Fix the bottom row of tablet keyboard layout" into lmp-dev 2014-08-25 03:45:35 +00:00
Tadashi G. Takaoka c9aa1beb6d Fix the bottom row of tablet keyboard layout
This CL eliminates "_" and "/" keys from the bottom row of tablet
keyboard.  This CL also reorganizes the bottom row of tablet Dvorak
keyboard.

Bug: 16603887
Change-Id: Ic1570836dea1a475bed5d43aeb6a351507bf5428
2014-08-25 12:34:58 +09:00
Yohei Yukawa 034c326078 Dismiss "Add to dictionary" hint with non-special char event
This CL slightly extends the condition when "Add to dictionary"
hint is dismissed.

With this CL, "Add to dictionary hint" will be dismissed by any
non-special char event. This is more comfortable especially if
we start using more intrusive UIs such as indicator and/or
background color with the text hint in the suggestion strip.

Change-Id: I2ea0fa40d9c6663ebf5d5439be3eca2a2cbd5166
2014-08-24 20:32:22 -07:00
Yohei Yukawa 4a71d2c480 Allow to add/remove background color to/from the committed text
This is a groundwork for subsequent CLs where we need to
add/remove background color to/from the commited text.

In this CL, we use Spanned#SPAN_COMPOSING so that we can easily
remove such a background color by calling
InputConnection#finishComposingText. To make this operation easy
and realiable, we need to track whether we have specified the
background color to the commited text or not at one place. Here
we use RichInputConnection for this purpose.

Change-Id: I5f9bc4425c5d1b80a719a20e5baf336729ec08d2
2014-08-24 20:28:24 -07:00
Yohei Yukawa cd6ef9a8b1 Indroduce SuggestedWords#getTypedWordInfoOrNull
This is a groundwork for subsequent CLs whith need to
do certain things for and only for the typed word.

Change-Id: I374b79cbc79470f57f523c996010301ea5701a61
2014-08-24 16:32:17 -07:00
Tadashi G. Takaoka 2637be27c5 Support Accept typed word UI
Change-Id: I58e95b2791a45afdc7dae8e26dcfc200b3b4b854
2014-08-22 21:25:35 +09:00
Yohei Yukawa cabb66e9bc follow-up to API change in I4a577bfd02b37b
BUG: 17182367
BUG: 17185263
Change-Id: Id54ca29c191b9752fa82ffe5a960113b2e97e5c1
2014-08-21 21:39:15 -07:00
Yohei Yukawa 8e2fcaa334 Merge "Use FrameLayout for the backing view" into lmp-dev 2014-08-21 18:06:07 +00:00
Yohei Yukawa b9768702fa Merge "Use #onStartInputInternal to initialize cursor rect retrieval" into lmp-dev 2014-08-20 01:43:56 +00:00