58e830ec19
Refactor SubtypeLocaleUtils a bit
...
Change-Id: If8b7fd5ef0b4ff3791deeacc12abb256a10176bf
2014-04-10 17:24:58 +09:00
9eec53a2c2
Merge "Reorder German umlaut letters"
2014-04-10 06:26:21 +00:00
784a4429ea
Reorder German umlaut letters
...
Bug: 13940739
Change-Id: I2e377b56e4a74d36c7e0cea4ad4e8d9341eb7feb
2014-04-10 15:24:45 +09:00
ac5e6ddd97
Add Italian (Switzerland) it_CH layout
...
Bug: 13920900
Change-Id: I57df8ca12b0d8cc4bbca2372c0470dcae5b5cbfb
2014-04-10 11:56:44 +09:00
a4ac18551f
Merge "Add a new production flag for Cursor/Anchor monitor"
2014-04-09 12:36:28 +00:00
485114905e
Add a new production flag for Cursor/Anchor monitor
...
BUG: 13891796
Change-Id: I3565ca22aaf1d3cfce4f35999e2990b2df5157ef
2014-04-09 21:13:34 +09:00
77dd17ad36
Merge "[CB25] Refactor some array copying"
2014-04-09 09:57:00 +00:00
5f430e0189
[CB25] Refactor some array copying
...
Bug: 13406701
Change-Id: I09edd822f5cc2446b324d41c76d835bcff1191e6
2014-04-09 18:38:29 +09:00
d317796207
Use Locale to process text resources
...
Change-Id: Ic1c4e1776071332e02c368055157124bb539d14e
2014-04-09 18:28:17 +09:00
45e34b4374
[CB24] Remove a useless test
...
If 1 character, then for sure !isGesture
Bug: 13406701
Change-Id: If8e9b080372eb8ddb15b8f97cce1399dc0c7f099
2014-04-08 21:36:52 +09:00
36dfb6d1a4
Fix build breakage caused by I0218dd07
...
BUG: 11746191
Change-Id: I0b693c4b22793f6e8fd77a9f045f205aa8fe4050
2014-04-08 20:00:16 +09:00
c9539f42f6
Merge "Add StatsUtils for checking state"
2014-04-08 10:23:41 +00:00
6bb3556ff7
Use locale to look up KeyboardTextsTable
...
Change-Id: I1e05c7fdbb757efef0e9407dc25482ef1115e49a
2014-04-08 19:12:31 +09:00
dc0f7ca167
Add StatsUtils for checking state
...
BUG: 11746191
Change-Id: I0218dd07dde1d09321009ea1497258fc4235a1e8
2014-04-08 19:09:49 +09:00
ceda8b925f
Update KeyboardTextsTable.java
...
Change-Id: I821eb214f3a8c34e91ca9bbf116cc53389a2fff0
2014-04-08 16:16:05 +09:00
a857235d0c
Merge "Remove workaround code of placing DrawingPreviewPlacerView"
2014-04-07 08:58:20 +00:00
0c01fc6f1c
Remove workaround code of placing DrawingPreviewPlacerView
...
This CL divides MainKeyboardView.locatePreviewPlacerView method into
two methods. One is installing DrawingPreviewPlacerView to the window
as Frontmost view. Another is telling the location of MainKeyboardView
to DrawingPreviewPlacerView. Thus we can eliminate workaround code to
deal with transient states in orientation change.
Change-Id: Ia5d8f28dfb5213d27aa218c72d838a3c3be5a527
2014-04-07 17:36:53 +09:00
da5c206934
Merge "[CB23] Merge add and deleteLast"
2014-04-07 08:16:36 +00:00
b724617b41
Merge "[CB22] Merge add and delete"
2014-04-07 06:59:07 +00:00
d52bec0069
[CB23] Merge add and deleteLast
...
Bug: 13406701
Change-Id: Id9a2e4144b1908ad27d78228ee19e6fc4d4d669f
2014-04-07 15:51:44 +09:00
633e4f4533
[CB22] Merge add and delete
...
...but this time, it works.
Bug: 13406701
Change-Id: Iaa00339a6be76413ffaeb74ff1556e15b3bb039d
2014-04-07 15:47:01 +09:00
b6c70f4ed3
Remove unneeded CustomViewPager class
...
Originally this hacky class has been introduced by I0824f82c30 to
address bug: 11721001. Because the bug: 11721001 has been addressed
by I950f13ec40 and etc., this class should be removed.
Bug: 13665882
Change-Id: Iabdd369e4dddb0188534289eea1269fb196895eb
2014-04-07 12:41:51 +09:00
e2e41dc22c
Merge "Revert "[CB22] Merge add and delete""
2014-04-04 18:26:06 +00:00
ef0498a8cc
Revert "[CB22] Merge add and delete"
...
This reverts commit f6bce235ae
2014-04-04 18:25:34 +00:00
f9516b00ec
Merge "[IL132] Remove some calls that let a value escape."
2014-04-04 13:33:26 +00:00
76c930eede
Merge "[CB22] Merge add and delete"
2014-04-04 10:10:55 +00:00
9b46ddc1d5
Use platform default theme for activities and dialogs
...
Bug: 13698528
Change-Id: Ib904c911452525e3749c0eb287434b504576db5f
2014-04-04 17:13:54 +09:00
f977ca6c92
Merge "[CB21] More refactoring"
2014-04-04 06:56:49 +00:00
9298c9b1e1
Merge "Reset the client database on version upgrade."
2014-04-04 05:12:02 +00:00
4ac0904f83
Merge "[CB20] Some more refactoring"
2014-04-04 05:03:45 +00:00
2e5e74d367
Reset the client database on version upgrade.
...
Bug: 13632164
Change-Id: Iba333db63558254d760fc80244b3c9753c26b069
2014-04-03 23:20:20 +09:00
28a59dd049
Fix a bug with double-space-to-period
...
Bug: 13778001
Change-Id: I3ebd57950cdfacbbcdc64ed214c0590519a0665c
2014-04-03 22:07:57 +09:00
c5bd35e45f
Merge "[IL131] Cleanup some cruft"
2014-04-03 09:52:10 +00:00
fdd2db576d
Always close binary dicts for personalized dicts.
...
Bug: 10923130
Bug: 13664080
Change-Id: Ib247c775194a03462387994cd832b1650bfd1915
2014-04-03 18:08:23 +09:00
8ab4ae4377
[IL133] Avoid calling a dangerous method from outside.
...
We want to remove all calls to this as it lets internal values
escape, but there is some refactoring to do to finish this.
Bug: 8636060
Change-Id: Iedba6afe4719bc0add868714a1ee5a04b7ead33e
2014-04-03 15:36:15 +09:00
9320553ab9
[IL132] Remove some calls that let a value escape.
...
Bug: 8636060
Change-Id: I696514934586ee71e734fd974026af8b2c866127
2014-04-03 15:36:15 +09:00
7ebd7ca9a4
[IL131] Cleanup some cruft
...
Bug: 8636060
Change-Id: I169618b50532df68e973e14b3f114c6c19714c84
2014-04-03 15:36:12 +09:00
35314af0d8
Merge "Extend jni interface to input/output languageWeight."
2014-04-02 16:20:28 +00:00
1de95ceada
Extend jni interface to input/output languageWeight.
...
Bug: 8187060
Change-Id: Ic55d328b87f258f4d65fff207233789a53b2b0ff
2014-04-03 01:01:51 +09:00
6b64de5063
Merge "Add languageWeight as an argument of getSuggestions."
2014-04-02 15:54:55 +00:00
18f21f96e0
Add languageWeight as an argument of getSuggestions.
...
Bug: 8187060
Change-Id: I8ae20c957a8e127b76c83cc3a65ff052d43bf2b5
2014-04-03 00:47:28 +09:00
a327d4a475
Merge "Use fixed order of dictionaries to get suggestions."
2014-04-02 13:24:52 +00:00
5b00d74c2e
Use fixed order of dictionaries to get suggestions.
...
Bug: 8187060
Change-Id: Id287776e3a82c0a6b208d677b8f2891266c5fc8d
2014-04-02 22:17:18 +09:00
06b50ed5f2
Merge "[IL130] Remove a useless local"
2014-04-02 09:18:45 +00:00
a49d326426
Merge "[IL129] Change some confusing method names."
2014-04-02 09:18:15 +00:00
4323e1126c
Merge "[CB19] Some refactoring"
2014-04-02 09:17:43 +00:00
750a3557a0
Merge "[CB18] Move some code around"
2014-04-02 09:17:30 +00:00
cc5a71caf1
Merge "[CB17] Remove a member."
2014-04-02 09:17:14 +00:00
26650377cf
[IL130] Remove a useless local
...
Bug: 8636060
Change-Id: I36ba3e00630bef644fc4671d0714490b5982f6a1
2014-04-02 18:10:21 +09:00
a777c1c460
[IL129] Change some confusing method names.
...
Bug: 8636060
Change-Id: I2f55fc23d7e05b63582a3f0660b58635eae5ec59
2014-04-02 18:10:18 +09:00
f6bce235ae
[CB22] Merge add and delete
...
Bug: 13406701
Change-Id: Ic9e90dd226b58b5ddb9693e04259cde00916007e
2014-04-02 18:01:00 +09:00
3e160bbe6b
[CB21] More refactoring
...
Bug: 13406701
Change-Id: I96e0a7fa2d9f4dfd8c355da4effc116bbd0f7f18
2014-04-02 18:01:00 +09:00
dfaeb125eb
[CB20] Some more refactoring
...
Bug: 13406701
Change-Id: I4502658f4f1e1997d0ac245d95e2d4a1415b1861
2014-04-02 18:00:57 +09:00
0f913ff5ba
[CB19] Some refactoring
...
Bug: 13406701
Change-Id: Ie4d420e8cabbbd93c3eea13a80baa4d766ee61d0
2014-04-02 18:00:19 +09:00
8bb2e99aef
[CB18] Move some code around
...
Bring next to each other two methods scheduled for a merge
Bug: 13406701
Change-Id: I335c7202cc07d8865f4ab92e4023c1d93d1f83ac
2014-04-02 17:58:33 +09:00
3285b68c97
[CB17] Remove a member.
...
Bug: 13406701
Change-Id: I2e271f637f6b529a4191a7adc5cdfa5af437761b
2014-04-02 17:57:36 +09:00
7dd32dfc06
Remove country name from space bar text when appropriate
...
Remove country name from space bar text when there no other subtype
that is a same language and a same keyboard layout.
Bug: 8084704
Change-Id: I7c785a925ff7a0a61e5d009f138e1df52b3aeb3a
2014-04-02 12:50:52 +09:00
65a199ca8e
Merge "Add SpacebarLanguageUtils class"
2014-04-01 03:25:31 +00:00
9364d46ac3
Add SpacebarLanguageUtils class
...
The SpacebarLanguageUtils class is separated from SubtypeLocaleUtils
and handles the language name on the spacebar.
Bug: 8084704
Change-Id: I82f79a061d4f0cc2895263298c3ebf8ee444c61d
2014-04-01 12:17:06 +09:00
1dc354bed1
Merge "[IL128] Remove passing some handlers."
2014-03-31 09:32:00 +00:00
dbadee96b6
Do not create a handler thread for each session
...
Bug: 13710224
Bug: 12821388
Bug: 12667742
Change-Id: I6188e0240193d2bca789110e7660a0f31bbafc62
2014-03-31 15:32:48 +09:00
f41518dbab
Fix: spell checker wrongly sorts suggestions.
...
Change-Id: I729e1cd5e5e333038b9d9e6197cf50b574990d76
2014-03-28 14:37:48 +00:00
452cd2f619
Fix a bug where LatinIME would leak pipes.
...
Bug: 12667742
Bug: 12821388
Change-Id: Ic0bad56fb96e54ac032759adffc8ea320c06dff2
2014-03-28 19:54:07 +09:00
52eb673c46
Merge "Some cleanup"
2014-03-28 09:22:22 +00:00
03f9c4820a
Merge "Make NeedsToDisplayLanguage as a top level class"
2014-03-28 09:15:25 +00:00
c412a41aff
Merge "Remove redundant check to detect forceAscii"
2014-03-28 09:15:18 +00:00
8e3c585265
Make NeedsToDisplayLanguage as a top level class
...
Change-Id: Ia05e0494a9dccebfb5c1316479e52f04cf2ae444
2014-03-28 17:59:57 +09:00
61dbda00de
Remove redundant check to detect forceAscii
...
Change-Id: Ib3272ec19a90b3aa4937573e049ceb86855ea408
2014-03-28 17:56:08 +09:00
a4c5c54a19
Merge "Remove unused method."
2014-03-28 08:07:42 +00:00
781e3df73b
Merge "Dictionary migration in Java side."
2014-03-28 08:07:26 +00:00
35645ac39a
Merge "[CB14.5] Stop copying WordComposers."
2014-03-28 06:51:17 +00:00
70d9152c7f
Some cleanup
...
Change-Id: Ia11d656a70623168b091763ac6524750f9cca8d8
2014-03-28 15:27:00 +09:00
8e829c37df
[CB14.5] Stop copying WordComposers.
...
This is an overdue refactoring that I have been wanted to
do forever, and that we can at last do now that suggestions
come only from instances of BinaryDictionary instances.
With this, all unit tests and regression tests are
passing again.
Bug: 13667648
Bug: 13665487
Bug: 8636060
Change-Id: Ie23a19f9b7e692edf2ee0b107ddaff2d7db564b6
2014-03-28 15:26:27 +09:00
3c801be5e5
Merge "Fix unit tests by adding @UsedForTesting."
2014-03-28 06:08:37 +00:00
aa7abb2d89
Fix unit tests by adding @UsedForTesting.
...
Change-Id: I8497d6cf446297bc8c15e9d9818078b1026a8c51
2014-03-28 15:02:00 +09:00
f173b12b03
Merge "Stop displaying locale string on short space bar"
2014-03-28 04:49:17 +00:00
2202d47386
Stop displaying locale string on short space bar
...
Bug: 12070355
Change-Id: I2d6fa20431bc56d5139caeac33e396b73906d075
2014-03-28 13:05:13 +09:00
30cd0cd2a0
Fix: NPE after onDestroy().
...
Bug: 13671513
Change-Id: I06aa14870ff5422ad514356ee406600b247858c5
2014-03-28 12:17:44 +09:00
080e0253ae
Merge "Revert "[CB15] Remove a redundant variable.""
2014-03-27 09:44:31 +00:00
f459ccf4f6
Merge "Revert "[CB16] Remove unused stuff""
2014-03-27 09:44:24 +00:00
75715f7d9f
Revert "[CB15] Remove a redundant variable."
...
This reverts commit 0de7a6d1a2
2014-03-27 09:43:45 +00:00
26baa759d8
Revert "[CB16] Remove unused stuff"
...
This reverts commit 05c46f59fd
2014-03-27 09:43:21 +00:00
5154c47cbe
Merge "[CB16] Remove unused stuff"
2014-03-27 08:52:11 +00:00
6bd3723e73
[IL128] Remove passing some handlers.
...
Bug: 8636060
Change-Id: I088be9a7555265ca097667523defd73be4cbe37f
2014-03-27 17:51:32 +09:00
c17311cefe
Remove unused method.
...
Change-Id: Iefb75136080e73c357511df045816f18cec767a6
2014-03-27 17:46:38 +09:00
a785fa8edd
Dictionary migration in Java side.
...
Bug: 13406708
Change-Id: If83938e4b4810d2e8353c70cdd8ef3ea97a29571
2014-03-27 17:46:35 +09:00
e04a9798f6
Merge "Call setLayerType(LAYER_TYPE_HARDWARE) for EmojiPalettesView too."
2014-03-27 08:27:59 +00:00
e289441f92
Call setLayerType(LAYER_TYPE_HARDWARE) for EmojiPalettesView too.
...
This CL probably does not addresses the bug, but still this should
be the right thing to do here.
bug: 12667742
Change-Id: I587652942fd66094779fb7942c734e0ff5f9d0b6
2014-03-27 17:26:22 +09:00
5feda45a6f
Merge "[CB15] Remove a redundant variable."
2014-03-27 08:05:23 +00:00
05c46f59fd
[CB16] Remove unused stuff
...
Bug: 13406701
Change-Id: Ib863c5181e1f5d74cfa4458060afc49d1ee8109e
2014-03-27 16:47:30 +09:00
0de7a6d1a2
[CB15] Remove a redundant variable.
...
This is a tiny bit slower, but probably unnoticeable.
Still, it gains some performance in other places,
saves memory, and more importantly makes for simpler
code, so it's certainly better.
Change-Id: Id1ab4f73f71acd73f5920bc729817abd22cf0d07
2014-03-27 16:47:27 +09:00
6008898b99
Merge "Move code only used for dicttool and tests under tests."
2014-03-27 06:37:10 +00:00
93cda5bb39
Move code only used for dicttool and tests under tests.
...
Bug: 13035567
Change-Id: I13c6df013ef2b67c9bf67455d9c32d283bf9ea2e
2014-03-27 15:30:32 +09:00
3c38e1f269
Merge "Fix: NPE in isValidWord after dictionaries are closed."
2014-03-27 03:12:07 +00:00
7b516d496d
Fix: NPE in isValidWord after dictionaries are closed.
...
Bug: 13650542
Change-Id: I1bdc838fca48d6ef12db5e70d40273d1236128d1
2014-03-27 12:03:58 +09:00
4cb152682d
Fix crash while entering emoticons
...
Bug: 13652919
Change-Id: Idd66240ac882fa890cfb28a477403ee09dc716ce
2014-03-27 11:08:11 +09:00
c4b558d375
Merge "Rename text resources consistently"
2014-03-26 10:06:34 +00:00
071b9c1a05
Merge "[CB14] Implement backspace in the combiner chain"
2014-03-25 10:46:32 +00:00
1079665c3c
[CB14] Implement backspace in the combiner chain
...
Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc
2014-03-25 17:57:03 +09:00
adfb262797
Remove logic related to dictionary loading from LatinIME.
...
Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.
Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
2014-03-25 15:35:20 +09:00
393efd94e5
Rename text resources consistently
...
- keylabel_<key>, the key label text of the <key>
- keyspec_<key>, the key specification of the <key>
- keyhintlabel_<key>, the hint label text of the <key>
- morekeys_<key>, the more keys specifications of the <key>
- additional_morekeys_<key>, the additional more keys specification of
the <key>
Change-Id: Ib2127f21fa33a2568e8a6eba65cfdb2cf78b480e
2014-03-25 13:02:09 +09:00
37b9562fd7
Fix talk back of emoji key
...
Bug: 13629734
Change-Id: Ifff6f81c2ac99a32855cd333b3d9a01ad7155ffc
2014-03-25 11:58:59 +09:00
f1f5ed542d
Check null before passing to Integer.parseInt
...
Just after user data is cleared, user preference associated with
PREF_KEYBOARD_LAYOUT is always empty. In such case, we might
want to return the default value immediately, rather than
calling Integer.parseInt(null) and catching NumberFormatException
unnecessarily.
BUG: 13472379
Change-Id: I8dca9a22780d057013c032bd1f56e730dcada3ce
2014-03-24 20:54:03 +09:00
d36cbc44e4
[CB13] Remove an unused method.
...
Change-Id: If4d2fa9c6499ce9b2427cea424abd497ec4a966b
2014-03-24 17:44:36 +09:00
cbed462d19
[CB12] Reset the combining state when resetting the composer
...
Bug: 13406701
Change-Id: I490574b7ca4b953f67dd2c0ef97401297fade0a4
2014-03-24 17:44:31 +09:00
7f0e5fa66c
Merge "[CB11] Get the result of the combination"
2014-03-24 05:33:34 +00:00
1dda9107ca
Merge "Rework the logic that tells if the cursor touches words"
2014-03-20 14:35:19 +00:00
835965a75e
[CB11] Get the result of the combination
...
Change-Id: I165ec4a24f5b1334d55c14948e4d942ec40eb33b
2014-03-20 23:33:12 +09:00
72b67f6541
Rework the logic that tells if the cursor touches words
...
Bug: 13312942
Change-Id: I6be6a558bbc6c88508150f9c25cadbd0240ff88e
2014-03-20 23:16:53 +09:00
4df6bc0853
Merge "[CB10] Add an event for string input"
2014-03-20 11:34:16 +00:00
058a38988b
[CB10] Add an event for string input
...
Change-Id: Ie5da6c73d4df4553067c58cd0dce9abb34534250
2014-03-20 19:47:01 +09:00
b20dad6fab
Merge "Consolidate KeyboardTextsSet.setLocale and loadStringResoucres"
2014-03-20 09:59:11 +00:00
df39eb6961
Consolidate KeyboardTextsSet.setLocale and loadStringResoucres
...
Change-Id: Idaf8f0d80fdeef4f1430f11d4083366e8ab7f6e0
2014-03-20 18:55:03 +09:00
7c20f140e0
Merge "Remove unused partial commit."
2014-03-20 09:54:15 +00:00
0c268b08b6
Merge "Refactor KeyboardTextsSet class"
2014-03-20 09:52:02 +00:00
5a0381f7d0
Remove unused partial commit.
...
Change-Id: Ia9341a5cb24947d93056810890d94c1f66481d8c
2014-03-20 18:47:45 +09:00
6007a1b7a9
Refactor KeyboardTextsSet class
...
Change-Id: Ibb59a9d4902db9ec0e00244304be9ab35b215a50
2014-03-20 18:38:59 +09:00
437dbbcfee
Merge "[IL127] Move the double space countdown to InputLogic"
2014-03-20 09:07:49 +00:00
aacfa31c8e
Merge "Remove reference of KeyboardTextsSet from SpacingAndPunctuations"
2014-03-20 08:46:11 +00:00
83372e75e4
Merge "[CB09] Pass events through the combiner chain"
2014-03-20 08:32:36 +00:00
44f144ab3a
Remove reference of KeyboardTextsSet from SpacingAndPunctuations
...
Change-Id: I76a8fcbd2466bcaf9cd85501af270db5aa913999
2014-03-20 17:14:43 +09:00
e7420f6bd1
Merge "Utilize autoColumnOrder for punctuation more keys"
2014-03-20 08:01:18 +00:00
f2bb15b0ab
[CB09] Pass events through the combiner chain
...
Bug: 13406701
Change-Id: I4696f145478afdd132314b7d3c148c3a9ca11c9c
2014-03-20 16:59:29 +09:00
844205ca2e
Utilize autoColumnOrder for punctuation more keys
...
Change-Id: I1f8f5013f0bdf93cf590b8bd00d680b31e03d8b0
2014-03-20 16:38:38 +09:00
c083733972
Merge "[CB08] Create a combiner chain in the word composer."
2014-03-20 07:02:48 +00:00
e884fde8d2
Merge "Fix Armenian punctuation order"
2014-03-20 06:43:50 +00:00
7ede642df4
[CB08] Create a combiner chain in the word composer.
...
Bug: 13406701
Change-Id: I3b9f75de9283f76366d1bef7e14a8f22f2186669
2014-03-20 14:27:55 +09:00
d51aebd328
Fix Armenian punctuation order
...
Bug: 12623502
Change-Id: I6cc026132922e103d212b663664e7e0aa2404b35
2014-03-20 13:17:38 +09:00
89f1b72793
Merge "Remove Latin comma from Arabic/Persian keyboard"
2014-03-20 03:56:02 +00:00
f96bffa69e
Suppress important notice when its title message is empty
...
Bug: 13422608
Change-Id: Ied16e87381e82d8539269ddd90d737f80c2a94c0
2014-03-20 11:48:28 +09:00
270bd39af4
Remove Latin comma from Arabic/Persian keyboard
...
Bug: 12807701
Change-Id: Icca63586d561a57b2c15cbfbae0de98dfcc137a3
2014-03-20 11:45:53 +09:00
14e908c348
Remove unused argument in SuggestionStripLayoutHelper
...
Bug: 13461039
Change-Id: I3f6227bd56fb81021aaacf0e901eab8a9e91d4a1
2014-03-20 11:06:55 +09:00
110e9f9e88
Add Galician keyboard
...
Bug: 13169021
Bug: 13017434
Change-Id: I5d44dc4c2387644028a5cf594954795e014f357a
2014-03-19 19:41:18 +09:00
0c797e8867
Add Basque keyboard
...
Bug: 13169021
Bug: 13017434
Change-Id: I46c738e833a9f287586a03bda9ab0230f8b9eac1
2014-03-19 19:40:34 +09:00
682853c3af
Merge "Fix French accented letters order"
2014-03-19 10:38:01 +00:00
350d73932d
[IL127] Move the double space countdown to InputLogic
...
Bug: 8636060
Change-Id: Ie193b747bd9d0b5ba6a986b9a3c746c2182742ed
2014-03-19 17:47:03 +09:00
554346e94c
[IL126] Move a setting value to SettingsValues
...
Bug: 8636060
Change-Id: I7cb082df13a10cf5a3aa5786e6a9599376652dee
2014-03-19 17:47:03 +09:00
46e17983c6
[IL125] Remove arg to onPickSuggestionManually
...
Bug: 8636060
Change-Id: I55332c22897e97148621cbd367acf5175b5b3d04
2014-03-19 17:47:03 +09:00
4640e7c989
Fix French accented letters order
...
Bug: 13497958
Change-Id: I062a0e2e75b2f6c2606b1309808cbaa83cc91018
2014-03-19 17:43:53 +09:00
1325ddbae3
Merge "Guard possible NumberFormatException"
2014-03-18 07:26:18 +00:00
d2c6151d4d
Guard possible NumberFormatException
...
Bug: 13472379
Change-Id: Ib7640b3d8816d8d7fb4747d2288eedd94bc49b06
2014-03-18 15:40:43 +09:00
6bdb2e60dc
Merge "Add preliminary Myanmar keyboard"
2014-03-18 05:53:51 +00:00
fc3263a75c
Add preliminary Myanmar keyboard
...
This CL adds preliminary Myanmar keyboard as a groundwork. The
keyboard layout comes mainly from virtual keyboard of
<http://www.google.com.mm/ >
Bug: 7963632
Change-Id: I36504ceb6c2079a6e133edaeb458da1c5cf3ded2
2014-03-18 10:28:57 +09:00
1110adad11
[CB07] Small refactoring
...
Bug: 8689779
Change-Id: I2cf10c690c7e4a9c6bf27211d1fccc1f9d4a9249
2014-03-17 21:26:36 +09:00
5eac728b4a
[CB06] Fix a design error.
...
The event interpreter should intervene later, after decoding.
Decoding should happen first, and then the Event should
be passed to the InputLogic.
For the time being, we will leave the (unused) EventInterpreter
class and its friends, because we'll use them again later.
Bug: 13406701
Change-Id: I7582d486724311e39e6692e606cca50c78800643
2014-03-17 20:49:29 +09:00
ef27c83e74
Fix Persian symbols shifted output text
...
Bug: 13017434
Change-Id: I57af849ae4342bfee3fa08d7e90c6a6dbc229380
2014-03-17 12:31:09 +09:00
538abc27dc
Fix Arabic keyboard text and test comments
...
Bug: 13017434
Change-Id: Iec2ddab719e0c68a70bcf56a90eb4522c5fd7978
2014-03-17 11:56:13 +09:00
5a1e351751
Merge "[CB04] Add an event array to WordComposer."
2014-03-14 04:29:59 +00:00
f8accd8839
[CB04] Add an event array to WordComposer.
...
Bug: 13406701
Change-Id: I9ecd2709c8f1c678a85b0cfaf7c5ed4f78459821
2014-03-14 12:44:49 +09:00
a9c1a3da63
Fix clipped important notice message on tablet
...
Bug: 13461039
Change-Id: I710bf10c9cbc202c7f6ee39ab4c8b9d699741a81
2014-03-14 12:32:38 +09:00
309773c322
Merge "[CB03] Pass whole events to the various input logic handlers."
2014-03-13 12:12:31 +00:00
a8e3ae6e96
Merge "Refactor keyboard layout test more customizable"
2014-03-13 12:09:47 +00:00
15a6b66dda
Refactor keyboard layout test more customizable
...
Bug: 13017434
Change-Id: I804b4cb9f56684d425e83a20cb3f71d947a87f98
2014-03-13 20:55:22 +09:00
750cd48981
[CB03] Pass whole events to the various input logic handlers.
...
Bug: 13406701
Change-Id: I0a0e4e0b3357f116e1b915c548dee4575e300c92
2014-03-13 19:35:54 +09:00
a79a3265db
[CB02] Pass an Event to onCodeInput.
...
Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
2014-03-13 18:41:02 +09:00
66dce6003f
Merge "[CB01] Reset some old assumptions about dead keys"
2014-03-13 08:53:29 +00:00
92db209c60
[CB01] Reset some old assumptions about dead keys
...
The combining framework will be more generic than previously
thought. We don't need to handle dead keys as a special type
of event, as all events can be combined arbitrarily.
Bug: 13406701
Change-Id: I8137fdb186c4d70eaa71808c5a1430b1559db1ae
2014-03-13 17:47:13 +09:00
13b446b8fb
Merge "Don't reset the value needed before it's used"
2014-03-12 08:04:42 +00:00
567fbe90f7
Fix unused text resources of keyboard layouts
...
Icelandic keyboard has no nordic layout.
Latvian, Lithuanian, and Slovak keyboards have duplicated N WITH ACUTE.
No Language keyboard has duplicated letter a variants.
Change-Id: Iaeacebc1f7efdb70294e6342e42232b73aed9398
2014-03-10 17:31:25 +09:00
e93a7232d1
Don't reset the value needed before it's used
...
Nice recipe for failure
Bug: 13387534
Change-Id: Ida1978449c1997587b2ec0955c5c94fcef336121
2014-03-10 15:55:15 +09:00
e07a777ed6
Fix unneeded u with diaeresis more key on Swedish keyboard
...
Change-Id: Ib4a17fa464899907616e76426e5df0d370a40f80
2014-03-10 11:15:18 +09:00
315010636a
Fix excessive more keys on Estonian keyboard
...
Change-Id: I6c2d5d123d519278a6ff0f12fece69ccbad1aad5
2014-03-10 10:56:26 +09:00
32326a9d7a
Merge "Move DictionaryOptions from FusionDictionary to FormatSpec."
2014-03-07 10:42:18 +00:00
e137ec0a91
Introduce SuggestionResults and use it for predictions.
...
Bug: 8187060
Bug: 13333066
Change-Id: I1ead897024508b7e40fbd93af7d14bfe74b93826
2014-03-07 19:36:19 +09:00
a103e29d00
Merge "Separate WeightedString from FusionDictionary."
2014-03-07 09:07:26 +00:00
ff8405cdfb
Add ActualKeyboardBuilder for testing keyboard layouts
...
Bug: 13017434
Change-Id: I38b1f5c261ea1f3ff312c780d7d9b5fe3fba8aaf
2014-03-07 17:29:58 +09:00
3ad4af2354
Move DictionaryOptions from FusionDictionary to FormatSpec.
...
Bug: 8187060
Bug:13035567
Change-Id: Id4f45e589521ae98c926a4c0607be10ce1a983f2
2014-03-06 18:53:09 +09:00
516f86815d
Separate WeightedString from FusionDictionary.
...
Bug: 8187060
Change-Id: I40c1dafca3eb52244c64fdb4c1db30a56385d678
2014-03-06 18:53:06 +09:00
3892991b80
Merge "[IL124] Remove the KeyboardSwitcher arg to onCodeInput"
2014-03-06 09:15:26 +00:00
4da06b9a19
Merge "Correctly update the suggestion strip on non-resumable word"
2014-03-06 08:54:44 +00:00
d93eb680c4
Merge "Use BinaryDictionaryUtils to read dictionary header."
2014-03-06 07:32:07 +00:00
a1bf550294
[IL124] Remove the KeyboardSwitcher arg to onCodeInput
...
Bug: 8636060
Change-Id: I29ce4c82ea880a937b1c9e5daf494fcdbbdd1336
2014-03-06 14:20:41 +09:00
db38d5cf63
[IL123] Put the settings values inside the transaction
...
A transaction should always operate with a consistent set
of settings. It's better to have it reference them than to
always pass them along.
Bug: 8636060
Change-Id: I3c642dfea6be30712fc6cbb279c64f3185895791
2014-03-06 14:20:37 +09:00
5054530934
Merge "[IL122] Put the code, x and y in the transaction"
2014-03-06 03:55:00 +00:00
29881854bc
[IL122] Put the code, x and y in the transaction
...
Bug: 8636060
Change-Id: Icdf87995dedec410b54c306e8d312ba7ec25cea6
2014-03-06 12:50:07 +09:00
dbe531efa8
Merge "Remove unused text resource keylabel_for_east_slavic_row1_12"
2014-03-06 02:47:06 +00:00
de36b47d29
Use BinaryDictionaryUtils to read dictionary header.
...
Bug: 8187060
Bug:13035567
Change-Id: I90a5e0665c367f5a1bd786f4babf0d03e79e68fa
2014-03-05 19:42:53 +09:00
274eae95ba
Merge "Separate utility methods from BinaryDictionary."
2014-03-05 10:07:33 +00:00
c6e200ef3a
Correctly update the suggestion strip on non-resumable word
...
Bug: 13303965
Change-Id: Iedc5d38f70af76fbebb99e59a0d17c1e226c810d
2014-03-05 18:47:41 +09:00
e784148ae6
Separate utility methods from BinaryDictionary.
...
Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50
2014-03-05 18:19:34 +09:00
7b905c40e9
[IL121] Introduce InputTransaction
...
We probably can't put this off any longer
Bug: 8636060
Change-Id: I1e5d3cf62d719f4d064ced3282bebf2e822f6baa
2014-03-05 17:04:10 +09:00
8204078a84
Merge "Remove unused MoreKeysPanel argument from Controller interface"
2014-03-04 10:53:23 +00:00
151761a276
[IL120] Cleanup
...
Remove useless arguments, local vars, make stuff private
Change-Id: I7cc6c19e9c1703304d593e02be31eb9569cc7b4e
2014-03-04 17:52:14 +09:00
fb28935f82
[IL119] Make fields private.
...
Change-Id: Ia84d3e5a102e1056e3d7467be07df89390f17617
2014-03-04 17:52:14 +09:00
0e489d1ba3
[IL118] Factorize a method
...
If we can't get the right locale from the subtype switcher, we
should fallback in all cases.
Change-Id: I46a53a67927a793d9d3592a996a5a4392a36c6ff
2014-03-04 17:52:14 +09:00
129ca9e7eb
[IL117] Simplification
...
Change-Id: Id4d4f30ecdc80dd59543f90fe2525f4bcc5afb9d
2014-03-04 17:52:11 +09:00
4309b83ea9
Remove unused text resource keylabel_for_east_slavic_row1_12
...
The text resource used in 10 inch tablet layout.
This change also corrects {keylabel|more_keys}_for_east_slavic_row2_1
to _row2_2.
Change-Id: I60d69af22f97c008449b8dccc7c84ae6a05fe0d8
2014-03-04 17:12:31 +09:00
1f215a58c9
Remove unused MoreKeysPanel argument from Controller interface
...
Bug: 13204690
Change-Id: Ife438e78d9bbbf796df20f95c2da7a4d50e5a035
2014-03-04 16:05:15 +09:00
2ca916c215
[IL116] Inline a method
...
Change-Id: I6af8f2bd6b4917f9b119ff78a0f299b2f6fb921e
2014-03-04 14:46:04 +09:00
e110018e2a
[IL114] Move a method to InputLogic
...
Bug: 8636060
Change-Id: I0d8f93985ddc6e93ce9af0d92a8056620351a498
2014-03-04 14:46:04 +09:00
030da519de
[IL115] Cleanup continues
...
Bug: 8636060
Change-Id: I944b10ec9798eec57d986e1075ba348aa0892cae
2014-03-04 14:46:04 +09:00
5d8f6660bf
[IL113] More cleanup
...
We should not test punctuation with this equality test any more.
Also, whether the suggestion strip is displayed or not, or whether
the hint is displayed or not, has nothing to do with this method
and should be handled elsewhere rather than here -- and as a
matter of fact, it is, which makes this useless.
Bug: 8636060
Change-Id: I6a54ee87e4e9f81bc33158acf4a264c3abd5829d
2014-03-04 14:46:04 +09:00
c92dabb27e
Merge "[IL112] Cleanup"
2014-03-04 05:45:15 +00:00
27c23c691c
Merge "[IL111] Remove a member."
2014-03-04 05:36:00 +00:00
145e8568f4
[IL112] Cleanup
...
Bug: 8636060
Change-Id: Ic7c2dec2521613d52707457463691bec383177ff
2014-03-04 14:32:02 +09:00
32c6d4caea
[IL111] Remove a member.
...
...and improve encapsulation and readability.
Bug: 8636060
Change-Id: I36407630b307df0721ea7fdb7e7a22cdf2b018b3
2014-03-04 14:31:47 +09:00
ddc21f5bd1
Dismiss all key preview before showing more suggestions
...
This CL also release key graphics and dismiss sliding key input
preview.
Bug: 13204690
Change-Id: Ie8eb7b7beca51689a907da9c0713b4d34d48dda1
2014-03-04 14:26:00 +09:00
61c726f591
Merge "Dismiss more keys keyboard before statring more suggestionsview to show"
2014-03-04 01:10:09 +00:00
56e0373b5c
Dismiss more keys keyboard before statring more suggestionsview to show
...
Bug: 13204690
Change-Id: I9188edd0e99ca8acdcb0f0e045be7d267d56b12d
2014-03-04 10:02:05 +09:00
8df489444d
Merge "Fix InputMethodInfo cache in RichInputMethodManager"
2014-03-03 15:16:55 +00:00
ad5795a891
Fix InputMethodInfo cache in RichInputMethodManager
...
Bug: 13271570
Change-Id: Ie06cd83baaaf674d8b34f0232c164c4541aceb43
2014-03-03 23:36:35 +09:00
3f91acdc96
Add additional subtypes test
...
Change-Id: I2994fd72bc284c84757f5a2bfa8045aa574a8fbc
2014-03-03 17:16:02 +09:00
e76c273502
Merge changes I20ce61c4,I2edab4e3
...
* changes:
Remove "Use only personalization dictionary".
Remove redundant creation of dictionary facilitator.
2014-03-03 04:00:24 +00:00
858045b41c
Merge "Fix: wrong auto correction for whilelist and personalized words."
2014-02-28 12:26:03 +00:00
23ae574a11
Fix: wrong auto correction for whilelist and personalized words.
...
This happens when there are tailing single quotes.
Bug: 13237314
Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14
2014-02-28 21:24:26 +09:00
5128935ac4
Add header attributes for evaluation.
...
Bug: 13197276
Change-Id: Ib5247da691ff24a73e13485288237ccc51bb54f0
2014-02-28 21:06:03 +09:00
58a536e41a
Merge "Use dynamic operations to construct all ver4 dicts."
2014-02-28 09:37:23 +00:00
684f5f18b1
Merge "Added a method and run GC for testing."
2014-02-28 09:33:51 +00:00
d302b98ce6
Added a method and run GC for testing.
...
Bug: 13231889
Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
2014-02-28 18:17:09 +09:00
98534dc065
Add missing null checks for getOwnerInstance()
...
It may just return null.
Change-Id: I778fb48262ef8af28a4af50b70bb94ace75a488c
2014-02-28 16:13:51 +09:00
ea89cb40b7
Use dynamic operations to construct all ver4 dicts.
...
Bug: 8187060
Bug: 13127350
Change-Id: I081ee904c41898128efa8ba7a1bf3fa0a46c6231
2014-02-27 23:21:09 +09:00
1aac28a2b9
Remove "Use only personalization dictionary".
...
Bug: 13216198
Change-Id: I20ce61c4a10c360e028bf6427f632cc5299763e4
2014-02-27 22:32:00 +09:00
e9926b0d11
Remove redundant creation of dictionary facilitator.
...
Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31
2014-02-27 22:31:57 +09:00
e989c6ea85
Merge "Remove wrong duplicated resource from Afrikaans layout"
2014-02-27 11:17:34 +00:00
51cb8e6f4e
Remove wrong duplicated resource from Afrikaans layout
...
Bug: 6867914
Change-Id: Ibc329c8ea03abaa91ba27e7e62fb6d02cc67debe
2014-02-27 19:01:49 +09:00
d1394b6986
Merge "Fix a bug with auto-caps entries from personalization"
2014-02-27 07:38:24 +00:00
71e3ecd0a2
Fix a bug with auto-caps entries from personalization
...
Bug: 13215163
Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a
2014-02-27 14:40:54 +09:00
f8a45cfd2f
Fix NPE in KeyDetector
...
This is actually a follow up of I9290974821.
Bug: 13215075
Change-Id: Ib7eef55fd1cfbb05d06aeeb0726bc10c87b07d85
2014-02-27 14:17:14 +09:00
997ba1b41e
Merge "Add keyboard layout set tests"
2014-02-27 03:08:42 +00:00
e1480a246d
Merge "Set additional attributes in dictionary facilitator."
2014-02-26 10:37:46 +00:00
f8552f61a4
Set additional attributes in dictionary facilitator.
...
Bug: 13197276
Change-Id: I206cf4e599ca9cdf40d669358a1067a2954d11e3
2014-02-26 19:14:16 +09:00
e55d44c535
Merge "Add a method to create dict with additional attributes."
2014-02-26 10:07:53 +00:00
18f91cf617
Add a method to create dict with additional attributes.
...
Bug: 13197276
Change-Id: I80311a51d9e98bfeb8c0dd9cd4adde93af366d54
2014-02-26 19:03:27 +09:00
009bb5642b
Merge "Use NOT_A_PROBABILITY for adding OOV words."
2014-02-26 09:48:57 +00:00
7e70e9dc49
Merge "[IL110] Remove an unused interface function"
2014-02-26 09:08:30 +00:00
2b27e06733
Merge "Read and write forgetting curve header attributes."
2014-02-26 09:06:56 +00:00
6112cc26a7
Read and write forgetting curve header attributes.
...
Bug: 13197276
Change-Id: I6c38a127e1745903594b7bf0ec80ef179e794feb
2014-02-26 18:04:12 +09:00
8559b403ed
Use NOT_A_PROBABILITY for adding OOV words.
...
Bug: 13197276
Change-Id: I23f453c2c1deea70eab552f8d433fe264adf68b3
2014-02-26 17:50:44 +09:00
bd1caac16a
[IL110] Remove an unused interface function
...
...and make a method private.
Bug: 8636060
Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
2014-02-26 17:46:20 +09:00
dd01a0bb1d
Add keyboard layout set tests
...
This CL is a ground work to add keyboard layout labels and more keys
tests.
Bug: 13017434
Change-Id: Ief028e8ab563d79bc0b0f9c06f1fe1d645a6469d
2014-02-26 16:10:52 +09:00
23e22613d7
Remove useless args and processing.
...
Bug: 13062385
Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
2014-02-26 11:40:43 +09:00
57c0c577af
[QRP6] Fix: recorrection top candidate is displayed in bold
...
Bug: 10385162
Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
2014-02-25 19:48:09 +09:00
0c34ee20a8
[QRP5] Fix boldness for predictions, and small refactoring
...
This is more correct. When predictions, the typed word should
always be null unless explicitly passed. The text color should be
that of a valid typed word only if it's actually the typed word.
Bug: 13170509
Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
2014-02-25 19:44:57 +09:00
783f193239
[QRP4] Simplification & small correctness fix.
...
This fixes the color of the predictions when running
on a theme that has different colors for typed and
suggested words (GB theme).
Also, this is easier to understand and to modify from
now on.
Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4
2014-02-25 08:59:14 +00:00
a0984662a1
[QRP3] Refactoring
...
Rename some variables for clarity and use constants
instead of immediates.
Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
2014-02-25 17:05:47 +09:00
74224f2c5c
[QRP2] Small refactor
...
Bug: 13170509
Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
2014-02-25 17:05:47 +09:00
ef3a45643e
[QRP1] Fix a bug where the wrong value would get passed
...
In the practice it works because this never tries to access
inside the suggestion strip, and the worst that can happen
is a wrong text color for a suggestion. But since the two
colors that would be swapped are the same, nobody ever
notices -- unless they are using the GingerBread theme.
Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
2014-02-25 17:05:44 +09:00
deb5cedf81
Add Key.getIconId for testability
...
Bug: 13017434
Change-Id: I94ff45da3f58b74cc9dd4d38179670fbcf619d92
2014-02-25 09:59:38 +09:00
6e224a236a
Merge "Correctly read the header of APK-embedded dicts"
2014-02-24 13:57:46 +00:00
890b44e537
Correctly read the header of APK-embedded dicts
...
Bug: 13164518
Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
2014-02-24 22:54:01 +09:00
64ace089a8
Merge "Use an executor to serialize opening dictionaries."
2014-02-24 13:43:49 +00:00
2c55706b0e
Merge "Create a utils class for executors."
2014-02-24 13:33:44 +00:00
4de2fcdde3
Use an executor to serialize opening dictionaries.
...
Bug: 13082957
Change-Id: I25570ab4da94337ed60330c0869fe47657096626
2014-02-24 21:05:24 +09:00
b434acee34
Create a utils class for executors.
...
Preliminary refactoring to fix
Bug: 13082957
Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
2014-02-24 20:52:49 +09:00
c40eb52e43
Merge "Remove hack from EmojiPalettesView.startEmojiPalettes"
2014-02-24 10:49:59 +00:00
d227b00a72
Remove hack from EmojiPalettesView.startEmojiPalettes
...
Bug: 12115967
Change-Id: I91c567a9577012ec28c08430c55e56e9c2e25b5f
2014-02-24 19:45:50 +09:00
65bce4cabc
Merge "Never pass negative values to setSelection."
2014-02-24 09:26:43 +00:00
b08a9e021c
Merge "Revert "Prepare for changing text color for functional keys""
2014-02-24 08:54:55 +00:00
da500b7ec3
Revert "Prepare for changing text color for functional keys"
...
This reverts commit 194e004e81
2014-02-24 17:42:28 +09:00
f19745728e
Never pass negative values to setSelection.
...
Bug: 13136079
Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
2014-02-24 16:52:55 +09:00
2b72aa07a9
Disconnect app data search client after fetching all data.
...
Bug: 13138201
Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
2014-02-24 14:47:54 +09:00
296adf5710
Merge "Change a heuristic and add a log."
2014-02-21 11:58:16 +00:00
1269ae3144
Merge "Change make-keyboard-text -java option to point LatinIME/java directory"
2014-02-21 11:54:39 +00:00
bb6b978a19
Merge "Fix: file descriptor leaking."
2014-02-21 11:37:09 +00:00
bf075b21a1
Merge "Don't trim newer inputpointers with old data"
2014-02-21 11:19:04 +00:00
5eb6ea9f27
Change make-keyboard-text -java option to point LatinIME/java directory
...
Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
2014-02-21 19:24:24 +09:00
ad508d029f
Merge "Remove corrupted ver4 dictionaries."
2014-02-21 09:03:19 +00:00
d24a99cff6
Fix: file descriptor leaking.
...
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.
Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
2014-02-21 17:25:34 +09:00
2a5ec00301
Don't trim newer inputpointers with old data
...
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
2014-02-21 16:43:11 +09:00
d73044a249
Add ImportantNoticeDialog
...
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
2014-02-21 16:36:15 +09:00
d934fb43ad
Remove corrupted ver4 dictionaries.
...
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
2014-02-21 15:09:37 +09:00
fe39d576dc
Support versioned important notice
...
This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
2014-02-21 09:54:08 +09:00
3b4c1d3056
Change a heuristic and add a log.
...
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.
Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.
Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
2014-02-20 23:49:20 +09:00
1b3a142cac
Merge "Fix a bug where suggestions would not be updated."
2014-02-20 14:46:35 +00:00
6f50c95887
Fix a bug where suggestions would not be updated.
...
Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
2014-02-20 23:32:04 +09:00
a118d19f6c
Merge "Don't distrust the cursor pos so much as to bug on IPC delay"
2014-02-20 14:22:48 +00:00
3c84eb8822
Don't distrust the cursor pos so much as to bug on IPC delay
...
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
2014-02-20 23:13:14 +09:00
d36328cecf
Add test only methods to test personalized dicts.
...
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20 22:20:43 +09:00
485c1ec685
Merge "Add final and volatile for members of InputLogic."
2014-02-20 10:12:45 +00:00
afdb6f011b
Merge "Add user history dictionary decaying test."
2014-02-20 10:05:20 +00:00
b063377e77
Add final and volatile for members of InputLogic.
...
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
2014-02-20 18:55:19 +09:00
0bc66daae3
Add user history dictionary decaying test.
...
Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20 18:36:46 +09:00
a514ea7e1b
Merge "Check all enabled IME's subtypes to enable personalization."
2014-02-20 09:33:21 +00:00
d10e2d85af
Merge "Throw IOException when dict header cannot be read."
2014-02-20 09:33:08 +00:00
afd9b62f00
Throw IOException when dict header cannot be read.
...
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
2014-02-20 18:11:17 +09:00
475f9f35b6
Merge "Comments improvements"
2014-02-20 08:22:39 +00:00
1672ccbbb6
Change important notice version preference file
...
This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.
Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
2014-02-20 16:50:34 +09:00
78db739cdb
Fix build due to Ib4c472756f
...
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
2014-02-20 16:16:57 +09:00
ad2cf220a9
Merge "Remove a call to a deprecated method"
2014-02-20 06:40:46 +00:00
251ed3b358
Merge "Revert "Turn off personalization default settings""
2014-02-20 06:26:48 +00:00
c2ba73ab41
Revert "Turn off personalization default settings"
...
This reverts commit 0a4ac795d6
2014-02-20 06:06:29 +00:00
6b23749dec
Check all enabled IME's subtypes to enable personalization.
...
Bug: 13067743
Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
2014-02-20 15:05:37 +09:00
c44b7312ad
Remove a call to a deprecated method
...
...that would cause a crash
Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
2014-02-20 14:40:38 +09:00
be8ad77ebb
Comments improvements
...
Typo fixes and clarifications
Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
2014-02-20 13:29:43 +09:00
34fb962513
Call PersonalizationDictionarySessionRegistrar.init().
...
Wrongly removed in I1f50cb137b6054dc9.
Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
2014-02-19 23:27:14 +09:00
d102eb80da
Remove personalization dicts for multilingual users.
...
Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
2014-02-19 21:00:27 +09:00
920c40fe45
Use AlertDialog.setOnDismissListener
...
AlertDialog.Builder.setOnDismissListener is supported from API 17.
Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
2014-02-19 19:05:06 +09:00
ed616083dd
Merge "Turn personalization on when important notice dialog is displayed"
2014-02-19 09:46:15 +00:00
6abc852255
Turn personalization on when important notice dialog is displayed
...
This change must be checked in together with Ifde70b1d3b.
Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
2014-02-19 18:36:32 +09:00
3a7ed5fdfe
Merge "Fix IllegalStateException raied by monkey"
2014-02-19 08:27:37 +00:00
9fd7447d6c
Fix IllegalStateException raied by monkey
...
Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
2014-02-19 16:40:52 +09:00
03105290d8
Merge "Throw exception when the header cannot be read."
2014-02-19 04:59:47 +00:00
776bba098b
Merge "Turn off personalization default settings"
2014-02-19 04:25:04 +00:00
97a40d030f
Throw exception when the header cannot be read.
...
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
2014-02-19 12:35:58 +09:00
e49e007bb2
Fix: Use old suggest after reloading.
...
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
2014-02-19 12:34:09 +09:00
0a4ac795d6
Turn off personalization default settings
...
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.
Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
2014-02-19 12:08:50 +09:00
80d413caff
Merge "Straighten out database cursors behavior."
2014-02-18 11:09:38 +00:00
28e0b24965
Merge "Fix a bug where the cache would be out of sync"
2014-02-18 10:58:50 +00:00
b8ff8ca9d9
Straighten out database cursors behavior.
...
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.
It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.
Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
2014-02-18 19:58:23 +09:00
fe92c174ea
Fix a bug where the cache would be out of sync
...
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.
Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18 19:55:54 +09:00
Tadashi G. Takaoka
Yohei Yukawa
Jean Chalard
Ken Wakasa
Keisuke Kuroyanagi