3a7356c402
am 8e2951f2: Merge "Fix punctuation test for tablet"
...
* commit '8e2951f29984eb163b6107ebd9ab54504c54f4ae':
Fix punctuation test for tablet
2014-02-21 03:56:57 -08:00
8e2951f299
Merge "Fix punctuation test for tablet"
2014-02-21 11:54:28 +00:00
24065c60e0
am bb6b978a: Merge "Fix: file descriptor leaking."
...
* commit 'bb6b978a190e552eefa31426595db93705d50c1f':
Fix: file descriptor leaking.
2014-02-21 03:39:46 -08:00
bb6b978a19
Merge "Fix: file descriptor leaking."
2014-02-21 11:37:09 +00:00
e48e95566d
am bf075b21: Merge "Don\'t trim newer inputpointers with old data"
...
* commit 'bf075b21a1b85c9aa382276e95d3986d3d6d5b1d':
Don't trim newer inputpointers with old data
2014-02-21 03:21:29 -08:00
bf075b21a1
Merge "Don't trim newer inputpointers with old data"
2014-02-21 11:19:04 +00:00
62f192f60f
am ad508d02: Merge "Remove corrupted ver4 dictionaries."
...
* commit 'ad508d029f7fbd225f41f3b2a0b7134bd90c37ba':
Remove corrupted ver4 dictionaries.
2014-02-21 01:38:38 -08:00
acf61fbdf5
am 9cfa8417: Merge "Add boundary check for ver2 dict reading."
...
* commit '9cfa8417dacb1d3efc687c8b9c5a7f141f5f7746':
Add boundary check for ver2 dict reading.
2014-02-21 01:38:36 -08:00
ad508d029f
Merge "Remove corrupted ver4 dictionaries."
2014-02-21 09:03:19 +00:00
9cfa8417da
Merge "Add boundary check for ver2 dict reading."
2014-02-21 09:03:12 +00:00
d28a58c25d
Fix punctuation test for tablet
...
It seems that some test devices are tablet and some are phone. The
unit test should aware of which device the test is running.
Change-Id: I8651a540993de29aa1cd9f40919dffe7a8df9512
2014-02-21 17:50:07 +09:00
d24a99cff6
Fix: file descriptor leaking.
...
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.
Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
2014-02-21 17:25:34 +09:00
5041d9267e
am 239256b1: Merge "Add an auto-correction by user history test."
...
* commit '239256b1564cce1aba3d79d7bf931b290243432a':
Add an auto-correction by user history test.
2014-02-21 00:01:07 -08:00
239256b156
Merge "Add an auto-correction by user history test."
2014-02-21 07:59:05 +00:00
7a1c3b917f
am d73044a2: Add ImportantNoticeDialog
...
* commit 'd73044a2494873a4abe0d4da208533164314d2f0':
Add ImportantNoticeDialog
2014-02-20 23:46:13 -08:00
2a5ec00301
Don't trim newer inputpointers with old data
...
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
2014-02-21 16:43:11 +09:00
d73044a249
Add ImportantNoticeDialog
...
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
2014-02-21 16:36:15 +09:00
6ec9019f87
am fe39d576: Support versioned important notice
...
* commit 'fe39d576dcd515d7fcd678a2ed6a621185cc69e3':
Support versioned important notice
2014-02-20 23:02:17 -08:00
d934fb43ad
Remove corrupted ver4 dictionaries.
...
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
2014-02-21 15:09:37 +09:00
be81b75dec
Add boundary check for ver2 dict reading.
...
Bug: 12916055
Change-Id: I78ad1f98a5401f920dcfc3379aa431eb2311ae02
2014-02-21 13:26:01 +09:00
4cc582f3ba
Add an auto-correction by user history test.
...
Bug: 11122480
Change-Id: I830bb3399f9839a80c6d86fbf582299bce424871
2014-02-21 13:12:26 +09:00
fe39d576dc
Support versioned important notice
...
This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
2014-02-21 09:54:08 +09:00
743da437fd
am 1b3a142c: Merge "Fix a bug where suggestions would not be updated."
...
* commit '1b3a142cace93ab22064ae5cf5f2d2ff7635ae9e':
Fix a bug where suggestions would not be updated.
2014-02-20 06:52:08 -08:00
1b3a142cac
Merge "Fix a bug where suggestions would not be updated."
2014-02-20 14:46:35 +00:00
6f50c95887
Fix a bug where suggestions would not be updated.
...
Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
2014-02-20 23:32:04 +09:00
c2c8368c2e
am a118d19f: Merge "Don\'t distrust the cursor pos so much as to bug on IPC delay"
...
* commit 'a118d19f6c2ad1e6f6bfe34b0ce022e961da4f02':
Don't distrust the cursor pos so much as to bug on IPC delay
2014-02-20 06:27:56 -08:00
a118d19f6c
Merge "Don't distrust the cursor pos so much as to bug on IPC delay"
2014-02-20 14:22:48 +00:00
3c84eb8822
Don't distrust the cursor pos so much as to bug on IPC delay
...
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
2014-02-20 23:13:14 +09:00
52b067e5d4
am e03e4257: Merge "Add test only methods to test personalized dicts."
...
* commit 'e03e4257f1dc727db383bd56097eb60eeae7ceb8':
Add test only methods to test personalized dicts.
2014-02-20 05:29:26 -08:00
e03e4257f1
Merge "Add test only methods to test personalized dicts."
2014-02-20 13:25:59 +00:00
d36328cecf
Add test only methods to test personalized dicts.
...
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20 22:20:43 +09:00
4ebf561932
am 21f94829: Fix: UserHistoryDictionaryTests.testDecaying().
...
* commit '21f94829994d5a5c2773605fec6b7eeef920c646':
Fix: UserHistoryDictionaryTests.testDecaying().
2014-02-20 04:36:23 -08:00
21f9482999
Fix: UserHistoryDictionaryTests.testDecaying().
...
Bug: 13106697
Change-Id: If81f77c3cefdefae94cb9145aa9f700494f8237a
2014-02-20 21:23:57 +09:00
0917b6fd8f
am a7ee108f: Merge "Record reading error during traversing dictionaries."
...
* commit 'a7ee108fc549a3b0cd939e875ff3fc3e9dff3973':
Record reading error during traversing dictionaries.
2014-02-20 02:22:18 -08:00
a7ee108fc5
Merge "Record reading error during traversing dictionaries."
2014-02-20 10:20:22 +00:00
cfd8189856
am 485c1ec6: Merge "Add final and volatile for members of InputLogic."
...
* commit '485c1ec685e6822bf244ef68ba80c1cbda895dc4':
Add final and volatile for members of InputLogic.
2014-02-20 02:14:43 -08:00
485c1ec685
Merge "Add final and volatile for members of InputLogic."
2014-02-20 10:12:45 +00:00
b96012acef
Record reading error during traversing dictionaries.
...
Bug: 12916055
Change-Id: I439f21aa87cfa1f71e0354370a1514af03d68f6c
2014-02-20 19:12:32 +09:00
5bc284a01d
am afdb6f01: Merge "Add user history dictionary decaying test."
...
* commit 'afdb6f011ba89cb967fbf3b9e4f4d0411b648361':
Add user history dictionary decaying test.
2014-02-20 02:07:12 -08:00
afdb6f011b
Merge "Add user history dictionary decaying test."
2014-02-20 10:05:20 +00:00
b063377e77
Add final and volatile for members of InputLogic.
...
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
2014-02-20 18:55:19 +09:00
7cf00033b8
am a514ea7e: Merge "Check all enabled IME\'s subtypes to enable personalization."
...
* commit 'a514ea7e1b39defc0a28b1acca00a2886478b0ed':
Check all enabled IME's subtypes to enable personalization.
2014-02-20 01:38:15 -08:00
2af1763dda
am d10e2d85: Merge "Throw IOException when dict header cannot be read."
...
* commit 'd10e2d85afefb420ff88528cdb3f3b2fe676c857':
Throw IOException when dict header cannot be read.
2014-02-20 01:38:13 -08:00
0bc66daae3
Add user history dictionary decaying test.
...
Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20 18:36:46 +09:00
a514ea7e1b
Merge "Check all enabled IME's subtypes to enable personalization."
2014-02-20 09:33:21 +00:00
d10e2d85af
Merge "Throw IOException when dict header cannot be read."
2014-02-20 09:33:08 +00:00
afd9b62f00
Throw IOException when dict header cannot be read.
...
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
2014-02-20 18:11:17 +09:00
f0ed3799c5
am 475f9f35: Merge "Comments improvements"
...
* commit '475f9f35b61f9dfe8a15cf274a60e8fd073d9df9':
Comments improvements
2014-02-20 00:25:26 -08:00
475f9f35b6
Merge "Comments improvements"
2014-02-20 08:22:39 +00:00
4aa83faea0
am 1672ccbb: Change important notice version preference file
...
* commit '1672ccbbb6167f434842093feaadc2bcd5634eab':
Change important notice version preference file
2014-02-20 00:11:20 -08:00
Tadashi G. Takaoka
Keisuke Kuroyanagi
Jean Chalard