Commit graph

4681 commits

Author SHA1 Message Date
Keisuke Kuroyanagi
7de3d0eed7 Merge "Fix: Reporting wrong main dictionary availability." 2014-04-22 23:32:50 +00:00
Keisuke Kuroyanagi
de4d401038 Fix: Reporting wrong main dictionary availability.
Bug: 13965806
Change-Id: Ida2234ab8cb7785ec5efd433a58949bf21c44351
2014-04-22 16:24:22 -07:00
Keisuke Kuroyanagi
d437df0ab0 Quit creating empty dictionary file in ExpandableBinaryDictionary.
Bug: 14166482
Change-Id: I7b7a25141851d7bb14744567639d8e5d8f04a036
2014-04-22 13:18:36 -07:00
Keisuke Kuroyanagi
3b7984752c Support creating BinaryDictionary without creating dict file.
Bug: 14166482
Change-Id: Ic8c78ec2c8f39358a1f085a041b608972a380eef
2014-04-22 13:18:34 -07:00
Keisuke Kuroyanagi
ce76821dce Revert "Support creating BinaryDictionary without creating dict file."
This reverts commit 89939b8708.

Change-Id: I8ca1b55609ad305a93178063bd88bd1cede872af
2014-04-22 19:34:44 +00:00
Keisuke Kuroyanagi
89939b8708 Support creating BinaryDictionary without creating dict file.
Bug: 14166482
Change-Id: Ib065279f96e227ab0fee7c8141560c4ada744d3b
2014-04-22 12:01:33 -07:00
Keisuke Kuroyanagi
68b4f2ada9 Merge "Add jni interface to use on memory dictionary." 2014-04-22 17:07:16 +00:00
Tadashi G. Takaoka
543d3d24bd Stop using Configuration.setLocale
The call for method Configuration.setLocale that is introduce by
If60877b29b should be remove to be compatible with API 14 and later.

Bug: 14239862
Change-Id: I3815c2b56bd9c655b8bde6f93143adf3ff08c35d
2014-04-22 09:22:46 -07:00
Keisuke Kuroyanagi
61cb852d33 Add jni interface to use on memory dictionary.
Bug; 14166482

Change-Id: I33ab08dad1e39aa7617d391f7eb2561d6f2504bb
2014-04-21 19:59:09 -07:00
Keisuke Kuroyanagi
3acbf7d00c Merge "Add BinaryDictionary.flushWithGCIfHasUpdated()." 2014-04-22 00:10:42 +00:00
Keisuke Kuroyanagi
c6704dbe51 Add BinaryDictionary.flushWithGCIfHasUpdated().
Bug: 14166482
Bug: 14161647
Change-Id: I98b0a8b86897b1486491a3aea91729bc9e4cc03c
2014-04-21 15:21:55 -07:00
Xiaojun Bi
11b7076168 Fix a bug for counting code points in WordComposer.java
This bug threw an ArrayIndexOutOfBoundsException when the word length
is 49 (maxSize + 1) when calling StringUtils.copyCodePointsAndReturnCodePointCount(...)
in the same function. This bug is discovered by running SKETCH.

The intent is to count the code points from index 0 to index i (included).
The original code only counted the code points from index 0 to index (i-1).

Bug: 13969542
Change-Id: Idbf596aba2379ba552dbe580c83c42044d505aaf
2014-04-18 14:56:35 -07:00
Tadashi G. Takaoka
a980fb39a5 Merge "Refactor RunInLocale a bit" 2014-04-17 08:59:25 +00:00
Tadashi G. Takaoka
5c490e5da5 Refactor RunInLocale a bit
Change-Id: If60877b29bb1263161ec85c99320ad07b7dd4245
2014-04-17 17:39:19 +09:00
Jean Chalard
20b0c3c5a9 Merge "Avoid lower-case version of capitalized words in user hist" 2014-04-17 08:22:42 +00:00
Jean Chalard
649dcba5a8 Avoid lower-case version of capitalized words in user hist
Bug: 14096825
Change-Id: Ib6cc8fc31e90862e0b05f5a06757a73069726b74
2014-04-17 16:41:26 +09:00
Jean Chalard
86ff9d6dda Merge "Fix a wrong parameter passed." 2014-04-17 07:39:52 +00:00
Jean Chalard
26611120c9 Fix a wrong parameter passed.
Bug: 14120001
Change-Id: I8258304bc500fe28870fb8a5c11c15d97795423c
2014-04-17 15:44:55 +09:00
Keisuke Kuroyanagi
b21edc4402 Shuwdown executors after executing all tasks.
Bug: 14113276
Change-Id: Ie42ef30ffe5767ca434db4669efad2027b474e74
2014-04-17 09:28:52 +09:00
Jean Chalard
ba635ad30d Merge "Restart suggestions when restarting input" 2014-04-16 10:43:28 +00:00
Tadashi G. Takaoka
166fd799d4 Merge "Dismiss more suggestions before showing important notice" 2014-04-16 09:43:39 +00:00
Jean Chalard
3aba6263f0 Restart suggestions when restarting input
Bug: 6851364
Change-Id: I3052924053f37f56c9c3953051aa1b22224a2b2e
2014-04-16 17:02:08 +09:00
Tadashi G. Takaoka
c8abd13c77 Dismiss more suggestions before showing important notice
Bug: 14078601
Change-Id: I029cadd8f2f170b5a3e70df170e306c9be109a70
2014-04-16 15:40:39 +09:00
Jean Chalard
66e509b1d4 Fix some failing tests
Bug: 13968927
Change-Id: I7e5e075535e38bf0fa24af98ed6e2cdfd6de6556
2014-04-15 21:44:46 +09:00
Jean Chalard
1ee443d848 Merge "[IL135] Make getCurrentAutoCapsState private" 2014-04-15 02:27:52 +00:00
Jean Chalard
82d3a56b09 Merge "[IL134] Add an alternative path to getCurrentAutoCapsState" 2014-04-15 02:24:41 +00:00
Jean Chalard
751dc070bf Merge "Fix updating the shift state upon backspace" 2014-04-14 12:31:22 +00:00
Jean Chalard
2282e8520a Fix updating the shift state upon backspace
Bug: 13514349
Change-Id: If4c9db12b0ab5be676f7a2f72715f469066ee537
2014-04-14 21:28:24 +09:00
Jean Chalard
f091c491ea [IL135] Make getCurrentAutoCapsState private
Bug: 8636060
Change-Id: I800aefe6fee4c14df6fe5abe21b2387c69abb8f5
2014-04-14 21:09:32 +09:00
Jean Chalard
ddc163988a [IL134] Add an alternative path to getCurrentAutoCapsState
Bug: 8636060

Change-Id: I959e13d34910adad028ed6174f92029ff690eeeb
2014-04-14 21:09:32 +09:00
Tadashi G. Takaoka
21eafd7910 Use KeyboardTheme id insteand of index
This CL must be checked in together with I771216f8bd.

Bug: 14042743
Change-Id: I45c3acf9242985fb03721a9a6d377fbccc8e2019
2014-04-14 18:59:54 +09:00
Tadashi G. Takaoka
3568fca95f Merge "Refactor KeyboardTheme as top-level class" 2014-04-14 09:57:36 +00:00
Tadashi G. Takaoka
d6aa94e6b5 Refactor KeyboardTheme as top-level class
This CL should be checked in together with I63e33388f9.

Bug: 14042743
Change-Id: I13f0a45bac6f19e006bf1280a36173e52d6d7160
2014-04-14 17:10:11 +09:00
Tadashi G. Takaoka
30d5ed67d6 Keep ImportantNoticeDialog showing after orientation changed
Bug: 13951402
Change-Id: Ia6340d48843abca68ebadd299827cbe43516cc39
2014-04-14 15:48:19 +09:00
Yohei Yukawa
da498229f4 Merge "Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR" 2014-04-13 12:56:43 +00:00
Jean Chalard
4f4770cbf0 Merge "[CB26] Remove useless variables." 2014-04-11 10:00:57 +00:00
Yohei Yukawa
fab4ce43f8 Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR
With this CL, LatinIME starts calling
InputMethodService#setCursorAnchorMonitorMode in #onStartInput()
when ProductionFlag.USES_CURSOR_ANCHOR_MONITOR flag is explicitly
set to true.

BUG: 13891796
Change-Id: Ib2fb0c3521b61859d4cc530155ccaaee7ee16cbc
2014-04-11 12:26:33 +09:00
Jean Chalard
cb05dc1d1b Merge "[IL133] Avoid calling a dangerous method from outside." 2014-04-10 09:15:13 +00:00
Jean Chalard
1ef9d5938e [CB26] Remove useless variables.
This is nice for code simplicity, but it has a small adverse impact on
performance.

Bug: 13406701
Change-Id: I9316b3fe8d79b940fbd83cf1187c8c0d10b26c71
2014-04-10 18:13:35 +09:00
Tadashi G. Takaoka
cc729b6df5 Merge "Refactor SubtypeLocaleUtils a bit" 2014-04-10 08:51:03 +00:00
Jean Chalard
4370ff0998 Fix some flaky tests.
In tests, we create many instances of LatinIME, but we never
destroy them. That means we never close the dictionaries nor
the handlers.
This change calls onDestroy, which closes all dictionaries, and
adds some code to finish the handlers.

Change-Id: I942517a2a940c54256b08763f6b38f5b55809f55
2014-04-10 17:32:05 +09:00
Tadashi G. Takaoka
58e830ec19 Refactor SubtypeLocaleUtils a bit
Change-Id: If8b7fd5ef0b4ff3791deeacc12abb256a10176bf
2014-04-10 17:24:58 +09:00
Yohei Yukawa
a4ac18551f Merge "Add a new production flag for Cursor/Anchor monitor" 2014-04-09 12:36:28 +00:00
Yohei Yukawa
485114905e Add a new production flag for Cursor/Anchor monitor
BUG: 13891796
Change-Id: I3565ca22aaf1d3cfce4f35999e2990b2df5157ef
2014-04-09 21:13:34 +09:00
Jean Chalard
5f430e0189 [CB25] Refactor some array copying
Bug: 13406701
Change-Id: I09edd822f5cc2446b324d41c76d835bcff1191e6
2014-04-09 18:38:29 +09:00
Jean Chalard
45e34b4374 [CB24] Remove a useless test
If 1 character, then for sure !isGesture

Bug: 13406701
Change-Id: If8e9b080372eb8ddb15b8f97cce1399dc0c7f099
2014-04-08 21:36:52 +09:00
Yohei Yukawa
36dfb6d1a4 Fix build breakage caused by I0218dd07
BUG: 11746191
Change-Id: I0b693c4b22793f6e8fd77a9f045f205aa8fe4050
2014-04-08 20:00:16 +09:00
Yohei Yukawa
c9539f42f6 Merge "Add StatsUtils for checking state" 2014-04-08 10:23:41 +00:00
Yohei Yukawa
dc0f7ca167 Add StatsUtils for checking state
BUG: 11746191
Change-Id: I0218dd07dde1d09321009ea1497258fc4235a1e8
2014-04-08 19:09:49 +09:00
Jean Chalard
d52bec0069 [CB23] Merge add and deleteLast
Bug: 13406701
Change-Id: Id9a2e4144b1908ad27d78228ee19e6fc4d4d669f
2014-04-07 15:51:44 +09:00
Jean Chalard
633e4f4533 [CB22] Merge add and delete
...but this time, it works.

Bug: 13406701
Change-Id: Iaa00339a6be76413ffaeb74ff1556e15b3bb039d
2014-04-07 15:47:01 +09:00
Ken Wakasa
e2e41dc22c Merge "Revert "[CB22] Merge add and delete"" 2014-04-04 18:26:06 +00:00
Ken Wakasa
ef0498a8cc Revert "[CB22] Merge add and delete"
This reverts commit f6bce235ae.

Seeing several new unit test failures after this CL. Reverting..

Change-Id: Ie97127550ee36dd4a07a36701e9c5118684dfbc5
2014-04-04 18:25:34 +00:00
Jean Chalard
f9516b00ec Merge "[IL132] Remove some calls that let a value escape." 2014-04-04 13:33:26 +00:00
Jean Chalard
76c930eede Merge "[CB22] Merge add and delete" 2014-04-04 10:10:55 +00:00
Tadashi G. Takaoka
9b46ddc1d5 Use platform default theme for activities and dialogs
Bug: 13698528
Change-Id: Ib904c911452525e3749c0eb287434b504576db5f
2014-04-04 17:13:54 +09:00
Jean Chalard
f977ca6c92 Merge "[CB21] More refactoring" 2014-04-04 06:56:49 +00:00
Jean Chalard
4ac0904f83 Merge "[CB20] Some more refactoring" 2014-04-04 05:03:45 +00:00
Jean Chalard
28a59dd049 Fix a bug with double-space-to-period
Bug: 13778001
Change-Id: I3ebd57950cdfacbbcdc64ed214c0590519a0665c
2014-04-03 22:07:57 +09:00
Jean Chalard
c5bd35e45f Merge "[IL131] Cleanup some cruft" 2014-04-03 09:52:10 +00:00
Keisuke Kuroyanagi
fdd2db576d Always close binary dicts for personalized dicts.
Bug: 10923130
Bug: 13664080
Change-Id: Ib247c775194a03462387994cd832b1650bfd1915
2014-04-03 18:08:23 +09:00
Jean Chalard
8ab4ae4377 [IL133] Avoid calling a dangerous method from outside.
We want to remove all calls to this as it lets internal values
escape, but there is some refactoring to do to finish this.

Bug: 8636060
Change-Id: Iedba6afe4719bc0add868714a1ee5a04b7ead33e
2014-04-03 15:36:15 +09:00
Jean Chalard
9320553ab9 [IL132] Remove some calls that let a value escape.
Bug: 8636060
Change-Id: I696514934586ee71e734fd974026af8b2c866127
2014-04-03 15:36:15 +09:00
Jean Chalard
7ebd7ca9a4 [IL131] Cleanup some cruft
Bug: 8636060
Change-Id: I169618b50532df68e973e14b3f114c6c19714c84
2014-04-03 15:36:12 +09:00
Keisuke Kuroyanagi
35314af0d8 Merge "Extend jni interface to input/output languageWeight." 2014-04-02 16:20:28 +00:00
Keisuke Kuroyanagi
1de95ceada Extend jni interface to input/output languageWeight.
Bug: 8187060
Change-Id: Ic55d328b87f258f4d65fff207233789a53b2b0ff
2014-04-03 01:01:51 +09:00
Keisuke Kuroyanagi
6b64de5063 Merge "Add languageWeight as an argument of getSuggestions." 2014-04-02 15:54:55 +00:00
Keisuke Kuroyanagi
18f21f96e0 Add languageWeight as an argument of getSuggestions.
Bug: 8187060
Change-Id: I8ae20c957a8e127b76c83cc3a65ff052d43bf2b5
2014-04-03 00:47:28 +09:00
Keisuke Kuroyanagi
a327d4a475 Merge "Use fixed order of dictionaries to get suggestions." 2014-04-02 13:24:52 +00:00
Keisuke Kuroyanagi
5b00d74c2e Use fixed order of dictionaries to get suggestions.
Bug: 8187060
Change-Id: Id287776e3a82c0a6b208d677b8f2891266c5fc8d
2014-04-02 22:17:18 +09:00
Jean Chalard
06b50ed5f2 Merge "[IL130] Remove a useless local" 2014-04-02 09:18:45 +00:00
Jean Chalard
a49d326426 Merge "[IL129] Change some confusing method names." 2014-04-02 09:18:15 +00:00
Jean Chalard
4323e1126c Merge "[CB19] Some refactoring" 2014-04-02 09:17:43 +00:00
Jean Chalard
750a3557a0 Merge "[CB18] Move some code around" 2014-04-02 09:17:30 +00:00
Jean Chalard
cc5a71caf1 Merge "[CB17] Remove a member." 2014-04-02 09:17:14 +00:00
Jean Chalard
26650377cf [IL130] Remove a useless local
Bug: 8636060
Change-Id: I36ba3e00630bef644fc4671d0714490b5982f6a1
2014-04-02 18:10:21 +09:00
Jean Chalard
a777c1c460 [IL129] Change some confusing method names.
Bug: 8636060
Change-Id: I2f55fc23d7e05b63582a3f0660b58635eae5ec59
2014-04-02 18:10:18 +09:00
Jean Chalard
f6bce235ae [CB22] Merge add and delete
Bug: 13406701
Change-Id: Ic9e90dd226b58b5ddb9693e04259cde00916007e
2014-04-02 18:01:00 +09:00
Jean Chalard
3e160bbe6b [CB21] More refactoring
Bug: 13406701
Change-Id: I96e0a7fa2d9f4dfd8c355da4effc116bbd0f7f18
2014-04-02 18:01:00 +09:00
Jean Chalard
dfaeb125eb [CB20] Some more refactoring
Bug: 13406701
Change-Id: I4502658f4f1e1997d0ac245d95e2d4a1415b1861
2014-04-02 18:00:57 +09:00
Jean Chalard
0f913ff5ba [CB19] Some refactoring
Bug: 13406701
Change-Id: Ie4d420e8cabbbd93c3eea13a80baa4d766ee61d0
2014-04-02 18:00:19 +09:00
Jean Chalard
8bb2e99aef [CB18] Move some code around
Bring next to each other two methods scheduled for a merge

Bug: 13406701
Change-Id: I335c7202cc07d8865f4ab92e4023c1d93d1f83ac
2014-04-02 17:58:33 +09:00
Jean Chalard
3285b68c97 [CB17] Remove a member.
Bug: 13406701
Change-Id: I2e271f637f6b529a4191a7adc5cdfa5af437761b
2014-04-02 17:57:36 +09:00
Tadashi G. Takaoka
7dd32dfc06 Remove country name from space bar text when appropriate
Remove country name from space bar text when there no other subtype
that is a same language and a same keyboard layout.

Bug: 8084704
Change-Id: I7c785a925ff7a0a61e5d009f138e1df52b3aeb3a
2014-04-02 12:50:52 +09:00
Tadashi G. Takaoka
65a199ca8e Merge "Add SpacebarLanguageUtils class" 2014-04-01 03:25:31 +00:00
Tadashi G. Takaoka
9364d46ac3 Add SpacebarLanguageUtils class
The SpacebarLanguageUtils class is separated from SubtypeLocaleUtils
and handles the language name on the spacebar.

Bug: 8084704
Change-Id: I82f79a061d4f0cc2895263298c3ebf8ee444c61d
2014-04-01 12:17:06 +09:00
Jean Chalard
1dc354bed1 Merge "[IL128] Remove passing some handlers." 2014-03-31 09:32:00 +00:00
Jean Chalard
dbadee96b6 Do not create a handler thread for each session
Bug: 13710224
Bug: 12821388
Bug: 12667742
Change-Id: I6188e0240193d2bca789110e7660a0f31bbafc62
2014-03-31 15:32:48 +09:00
Keisuke Kuroyanagi
f41518dbab Fix: spell checker wrongly sorts suggestions.
Change-Id: I729e1cd5e5e333038b9d9e6197cf50b574990d76
2014-03-28 14:37:48 +00:00
Jean Chalard
452cd2f619 Fix a bug where LatinIME would leak pipes.
Bug: 12667742
Bug: 12821388
Change-Id: Ic0bad56fb96e54ac032759adffc8ea320c06dff2
2014-03-28 19:54:07 +09:00
Jean Chalard
52eb673c46 Merge "Some cleanup" 2014-03-28 09:22:22 +00:00
Tadashi G. Takaoka
03f9c4820a Merge "Make NeedsToDisplayLanguage as a top level class" 2014-03-28 09:15:25 +00:00
Tadashi G. Takaoka
c412a41aff Merge "Remove redundant check to detect forceAscii" 2014-03-28 09:15:18 +00:00
Tadashi G. Takaoka
8e3c585265 Make NeedsToDisplayLanguage as a top level class
Change-Id: Ia05e0494a9dccebfb5c1316479e52f04cf2ae444
2014-03-28 17:59:57 +09:00
Tadashi G. Takaoka
61dbda00de Remove redundant check to detect forceAscii
Change-Id: Ib3272ec19a90b3aa4937573e049ceb86855ea408
2014-03-28 17:56:08 +09:00
Keisuke Kuroyanagi
a4c5c54a19 Merge "Remove unused method." 2014-03-28 08:07:42 +00:00
Keisuke Kuroyanagi
781e3df73b Merge "Dictionary migration in Java side." 2014-03-28 08:07:26 +00:00
Jean Chalard
35645ac39a Merge "[CB14.5] Stop copying WordComposers." 2014-03-28 06:51:17 +00:00
Jean Chalard
70d9152c7f Some cleanup
Change-Id: Ia11d656a70623168b091763ac6524750f9cca8d8
2014-03-28 15:27:00 +09:00
Jean Chalard
8e829c37df [CB14.5] Stop copying WordComposers.
This is an overdue refactoring that I have been wanted to
do forever, and that we can at last do now that suggestions
come only from instances of BinaryDictionary instances.

With this, all unit tests and regression tests are
passing again.

Bug: 13667648
Bug: 13665487
Bug: 8636060
Change-Id: Ie23a19f9b7e692edf2ee0b107ddaff2d7db564b6
2014-03-28 15:26:27 +09:00